Feed Advanced Search

Apr 12 2019

alexde added a comment to D20452: Clear terminal display when closing and opening it.

This patch looks more like a workaround to me. I'd suggest to identify the root cause of "^C" and "cd <path>" whenever the terminal is hidden and reopened again by hitting F4 and to find a another solution as I guess and especially hope that this behaviour is actually not necessary to happen.

Apr 12 2019, 11:33 AM · Dolphin

Feb 10 2019

alexde added a comment to D18809: Image Wallpaper Slideshow - display the list of images that will be shown.

Do you mean the Controls on the top? (...) Please correct me if I'm wrong.

Feb 10 2019, 11:00 AM · Plasma

Feb 9 2019

alexde added a comment to D18809: Image Wallpaper Slideshow - display the list of images that will be shown.

Great work!

Feb 9 2019, 11:28 AM · Plasma

Feb 5 2019

alexde updated subscribers of D18744: Add action in Edit menu to select the text on current page.

Seems sane enough to me. However I wonder if maybe triple-click might be better though? Triple-click is used for "select everything" in word processors, so perhaps we could take advantage of some familiarity there?

Feb 5 2019, 4:07 PM · Documentation, Okular

Dec 6 2018

alexde added a comment to D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout.

Changing the style just here would introduce inconsistency at a time when we're trying to make everything more consistent. The current FormLayout style is what we've decided on for the moment and I think it makes sense to fully implement it before we think about replacing it with something else. :)

Dec 6 2018, 7:02 PM · Plasma
alexde added a comment to D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout.

Thank you Nate! I am just curious if you considered to structure titles and options vertically, where the options are indented by a tab:

Dec 6 2018, 6:34 PM · Plasma
alexde added a comment to T9658: Rethink blur-by-default for Breeze SDDM login screen theme for Plasma 5.15.

Yeah it bothers me as well. The problem with black text is that it often doesn't offer satisfactory legibility:

Dec 6 2018, 1:44 PM · Plasma, VDG

Dec 5 2018

alexde added a comment to T9658: Rethink blur-by-default for Breeze SDDM login screen theme for Plasma 5.15.

If a lot of things were possible, this is how I'd do the SDDM theme design.

Dec 5 2018, 9:40 PM · Plasma, VDG
alexde added a comment to D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required.
Dec 5 2018, 12:56 PM · Plasma

Oct 27 2018

alexde added a watcher for KDE Promo: alexde.
Oct 27 2018, 12:15 PM
alexde added a watcher for VDG: alexde.
Oct 27 2018, 12:15 PM
alexde added a watcher for Dolphin: alexde.
Oct 27 2018, 12:14 PM
alexde added a watcher for Bugsquad: alexde.
Oct 27 2018, 12:13 PM

Oct 9 2018

alexde abandoned D16049: Added missing Icons to Places Panel code from KIO.
Oct 9 2018, 10:00 PM · Frameworks
alexde added a comment to D16049: Added missing Icons to Places Panel code from KIO.

Also, you might want to set up arc, which makes it much simpler and faster to submit patches, and easier for me too.

Oct 9 2018, 9:58 PM · Frameworks
alexde requested review of D16091: Added missing Icons to Places Panel code from KIO.
Oct 9 2018, 9:52 PM · Frameworks

Oct 8 2018

alexde added a comment to D16050: Added missing QStringLiteral to Dolphin code.

You did great! I'll land this for you later today.

Oct 8 2018, 7:35 PM · Dolphin
alexde added a comment to D16050: Added missing QStringLiteral to Dolphin code.

I hope creating a new revision for each patch was the right way to go! Also, I based this patch on the master branch and not on the branches, where I submitted my other patches. Looking forward to hearing your feedback!

Oct 8 2018, 6:19 PM · Dolphin
alexde requested review of D16050: Added missing QStringLiteral to Dolphin code.
Oct 8 2018, 6:18 PM · Dolphin
alexde requested review of D16049: Added missing Icons to Places Panel code from KIO.
Oct 8 2018, 6:00 PM · Frameworks
alexde added a comment to D16019: Added missing icons to panel places items.

Dolphin currently does not use the KIO code for parts of its places panel, so this change needs to be replicated for the KIO code so that Places panels in the open/save dialogs and Gwenview (etc.) get the change too. Can you submit a patch for KIO too? The code is in <kio repo>/src/panels/places/placespanel.cpp Thanks! Once you submit that patch and both are accepted, we can land them both.

Oct 8 2018, 1:07 PM · Dolphin

Oct 7 2018

alexde updated the summary of D16019: Added missing icons to panel places items.
Oct 7 2018, 7:05 PM · Dolphin
alexde updated the summary of D16019: Added missing icons to panel places items.
Oct 7 2018, 7:02 PM · Dolphin
alexde added a comment to D16019: Added missing icons to panel places items.

Could you add some screenshots?

Oct 7 2018, 4:39 PM · Dolphin
alexde retitled D16019: Added missing icons to panel places items from Added missing 'visibility' icons to panel places items to Added missing icons to panel places items.
Oct 7 2018, 4:30 PM · Dolphin
alexde updated the diff for D16019: Added missing icons to panel places items.

Changed the icon from "visibility" to "hint" as it describes the action better. Also added another missing icon to "Show all entries".

Oct 7 2018, 4:29 PM · Dolphin
alexde requested review of D16019: Added missing icons to panel places items.
Oct 7 2018, 3:51 PM · Dolphin