gvgeo (George Vogiatzis)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Dec 4 2019, 12:29 PM (26 w, 2 d)
Availability
Available

Recent Activity

Mar 21 2020

gvgeo added a comment to D27711: [Applet]Use gridLayout for details.

Instead of kuserfeedback which uploads data collected prior users consent, I believe this patch is good enough. @ngraham It appears that I should let you know that, I'm no longer going to work on it under these circumstances, so that you can use it if you want.

Mar 21 2020, 7:30 AM · Plasma

Mar 18 2020

gvgeo added a comment to D26983: Enable adding place as first child.

That's not how this works; reviewers being slow is not a good reason to abandon a patch. If you've lost interest in it, you can ask someone else can take it over, but just throwing away the work is pretty sad.

Mar 18 2020, 3:26 PM · Frameworks
gvgeo added a comment to D27199: [Applet]Update layout based on T10470.

Differently sized icons are about to be restored in D28034.

Nice! Thanks

You should thank @ngraham. He is the one making these small changes, including the password field size, in that patch.

Mar 18 2020, 2:28 PM · Plasma
gvgeo abandoned D28002: [WIP]Allow disabling of data collection.

Don't see any interest (or response), made a bug report instead.
https://bugs.kde.org/show_bug.cgi?id=418981

Mar 18 2020, 8:50 AM
gvgeo abandoned D27032: Enable adding a place as first item..

Base patch was abandoned.

Mar 18 2020, 8:16 AM · Dolphin
gvgeo abandoned D26983: Enable adding place as first child.

Thanks for your help @meven, but I 'll close this patch now.
It doesn't seem to be high in priorities.
And to be honest among other reasons, after I found how problematic the code is, I'm not so keen on building on top of it.

Mar 18 2020, 8:16 AM · Frameworks

Mar 16 2020

gvgeo added a comment to D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it.

Are there objections for Math.round(gridUnit * 2.33) (42 with default settings) suggested by @filipf? So that it can have big icons.

Mar 16 2020, 2:41 PM · Plasma

Mar 14 2020

gvgeo added a comment to D28002: [WIP]Allow disabling of data collection.

Currently data is collected by default, with no way of disabling it.

That's far from true. Things are off by default. Most providers are not run at all.
The commit message is either confused or misleading.

Mar 14 2020, 7:40 PM
gvgeo added a comment to D27199: [Applet]Update layout based on T10470.

Differently sized icons are about to be restored in D28034.

Mar 14 2020, 4:10 PM · Plasma

Mar 13 2020

gvgeo added a comment to D28034: [Applet] Port to ExpandableListItem.

Labels need eliding. Full width has problems?
Button need to expand also. Click always collapse?
Listitem.qml can be removed now. Not exactly.

Mar 13 2020, 9:31 PM · Plasma
gvgeo added a comment to D28002: [WIP]Allow disabling of data collection.

Currently data is collected by default, with no way of disabling it.

That's far from true. Things are off by default. Most providers are not run at all.
The commit message is either confused or misleading.

I made an assumption, based on the data collected for gammaray. But on second check, it seems that it uses it's own implementation of kuserfeedback.
Changed the description. Confused or not, if it is wrong, it is misleading.

Mar 13 2020, 11:49 AM
gvgeo updated the summary of D28002: [WIP]Allow disabling of data collection.
Mar 13 2020, 11:39 AM

Mar 12 2020

gvgeo updated subscribers of D28002: [WIP]Allow disabling of data collection.

Added Frameworks for visibility. kuserfeedback is not included in the group.

Mar 12 2020, 4:53 PM
gvgeo abandoned D28003: [WIP][Kcm/kuserFeedback]Expose global switch to the user.
Mar 12 2020, 10:31 AM · Plasma
gvgeo retitled D28003: [WIP][Kcm/kuserFeedback]Expose global switch to the user from [WIP]Expose global switch to the user to [WIP][Kcm/kuserFeedback]Expose global switch to the user.
Mar 12 2020, 10:30 AM · Plasma
gvgeo updated the test plan for D28002: [WIP]Allow disabling of data collection.
Mar 12 2020, 10:26 AM
gvgeo requested review of D28003: [WIP][Kcm/kuserFeedback]Expose global switch to the user.
Mar 12 2020, 10:21 AM · Plasma
gvgeo requested review of D28002: [WIP]Allow disabling of data collection.
Mar 12 2020, 10:17 AM

Mar 10 2020

gvgeo added a comment to D27823: Use consistent highlight.

Couple of notes, as I'm not sure what the aim was here. I have not test it, take them with a grain of salt.

  • Highlight area was changed, without changing the click area.
  • Connect button pop up area change, was not documented.
  • Highlight svg is not consistent with list's highlight. And maybe not always look good. (Although it's designation is pressed, everywhere used as highlight, which is an different story itself.)
  • There is code left in various places, listitem.qml possibly could be removed completely now.
Mar 10 2020, 9:44 AM · Plasma
gvgeo updated the summary of D26983: Enable adding place as first child.
Mar 10 2020, 4:59 AM · Frameworks

Mar 9 2020

gvgeo added a comment to D27711: [Applet]Use gridLayout for details.

Generally FormLayout is unfit for this, If I understand it correctly they cannot get theme.smallestFont height. Which will introduce big height, and big margins between lines.

Mar 9 2020, 7:52 PM · Plasma
gvgeo added inline comments to D26983: Enable adding place as first child.
Mar 9 2020, 7:43 PM · Frameworks
gvgeo added a comment to D27711: [Applet]Use gridLayout for details.

Do we need to reduce the opacity for the labels?

The opacity was reduced in the layout update. IMO this is vital part of the new layout.

Mar 9 2020, 7:40 PM · Plasma
gvgeo added a comment to D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid.

I believe that D26992, moves the icons down. And this patch, by adding an extra smallSpacing/2 makes it more noticeable.

Mar 9 2020, 11:37 AM · Plasma
gvgeo added a comment to D26983: Enable adding place as first child.

ping Frameworks

Mar 9 2020, 8:40 AM · Frameworks
gvgeo updated the test plan for D26983: Enable adding place as first child.
Mar 9 2020, 8:36 AM · Frameworks
gvgeo added a comment to D27711: [Applet]Use gridLayout for details.

@ngraham If FormLayout does not support opacity/enabled for labels, then maybe, this patch is good enough.

Mar 9 2020, 6:46 AM · Plasma

Mar 6 2020

gvgeo added a comment to T12441: Consider using a vertical Icons-Only Task Manager populated with apps, and a thickened panel.

Currently the default font size for time is 17. In picture above is 10 or 9 with the extra "1" (at 10 o'clock). I feel that needs to be bigger, otherwise better stay as is.
That's why I made "am" smaller, to make the time in description's example size 12.

Mar 6 2020, 3:10 PM · Goal: Consistency, VDG, Plasma
gvgeo added a comment to T12441: Consider using a vertical Icons-Only Task Manager populated with apps, and a thickened panel.

Vertical panel has limited space for time and date. If time could get bigger numbers, would be +1 from me.

Mar 6 2020, 9:13 AM · Goal: Consistency, VDG, Plasma

Mar 5 2020

gvgeo committed R119:d6731530bb43: Fixes for applet configuration layout. (authored by gvgeo).
Fixes for applet configuration layout.
Mar 5 2020, 7:55 PM
gvgeo closed D27608: Fixes for applet configuration layout..
Mar 5 2020, 7:55 PM · Plasma
gvgeo added a comment to D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it.

IMO better use Math.round(gridUnit*2.1) than fixed value that will not always look good with a scaled display.

Mar 5 2020, 4:53 PM · Plasma
gvgeo added a comment to D27870: [applets/systemtray] Right align popup heading when in RTL mode.

It seems that QQC2 as long a horizontal value is set, will flip it around. Otherwise will use the default direction left.
Agree, looks like a bug. Kirigami and frameworks are the places where this should be set. Already have corrected the other patch.

Mar 5 2020, 4:46 PM · Plasma
gvgeo updated the diff for D27608: Fixes for applet configuration layout..

Remove title alingment for kirigami change.

Mar 5 2020, 3:38 PM · Plasma
gvgeo added a comment to D27874: Disable the audio stream indicator for IOTM by default.

Disable the mute function then. And maybe add as an option.

Mar 5 2020, 3:21 PM · Plasma
gvgeo closed D27792: [Applet]Fix traffic monitor labels width.
Mar 5 2020, 1:16 PM · Plasma
gvgeo committed R116:986341a3fae8: [Applet]Fix traffic monitor labels width (authored by gvgeo).
[Applet]Fix traffic monitor labels width
Mar 5 2020, 1:16 PM
gvgeo updated the summary of D27608: Fixes for applet configuration layout..
Mar 5 2020, 1:09 PM · Plasma
gvgeo updated the summary of D27608: Fixes for applet configuration layout..
Mar 5 2020, 1:07 PM · Plasma
gvgeo updated the diff for D27608: Fixes for applet configuration layout..

Prevent vertical scrollbar from popping on/off internally.
Fix title alignment for RTL.
Set RTL content to use available width .

Mar 5 2020, 1:05 PM · Plasma

Mar 4 2020

gvgeo added a comment to D27792: [Applet]Fix traffic monitor labels width.

I don't plan to make more patches, for now. But if the problem would not exist with Layouts, I would prefer to do it than make quick bugfixes.

Mar 4 2020, 7:32 PM · Plasma
gvgeo added a comment to D27608: Fixes for applet configuration layout..

There is a problem, I still try to fix...

Mar 4 2020, 6:57 PM · Plasma
gvgeo abandoned D26806: [Applets/Power Manager] Update layout based on T10470.

Unfortunately I won't be able to continue with this patch about battery applet.
Feel free to use/modify if you want.

Mar 4 2020, 9:32 AM · Plasma
gvgeo added a comment to D27608: Fixes for applet configuration layout..

Strange, I don't get the resizing problem as it is now, or in master. Only managed to get this space by changing the theme, and was immediately fixed with resize.

Mar 4 2020, 9:24 AM · Plasma
gvgeo updated the diff for D27608: Fixes for applet configuration layout..

Cancel button was touching the edge in RTL.

Mar 4 2020, 9:16 AM · Plasma
gvgeo committed R115:ca15ec82c121: [KCM]Align volume controls row (authored by gvgeo).
[KCM]Align volume controls row
Mar 4 2020, 9:00 AM
gvgeo closed D27645: [KCM]Align volume controls row.
Mar 4 2020, 9:00 AM · Plasma
gvgeo updated the diff for D27608: Fixes for applet configuration layout..

Fixed margins.
Unfortunatly the RTL layout has some issues, had to disable the use of available width for RTL layout, to stop the jumping from the scrollview.

Mar 4 2020, 8:58 AM · Plasma
gvgeo added a comment to D27792: [Applet]Fix traffic monitor labels width.

VDG Does a better way exist, to measure the width of transfer speed text?

Mar 4 2020, 6:50 AM · Plasma
gvgeo added inline comments to D26946: Changed leftMargins to smallSpacing to be consistent.
Mar 4 2020, 6:21 AM · Plasma

Mar 3 2020

gvgeo updated the diff for D27645: [KCM]Align volume controls row.

Fix rebase.

Mar 3 2020, 9:30 PM · Plasma
gvgeo updated the diff for D27645: [KCM]Align volume controls row.

Math round.

Mar 3 2020, 6:42 PM · Plasma
gvgeo updated the diff for D27645: [KCM]Align volume controls row.

rebase

Mar 3 2020, 6:40 PM · Plasma
gvgeo added a comment to D27608: Fixes for applet configuration layout..

I'll give a bit more time, so @filipf gets a chance to check again and accept if possible.

Mar 3 2020, 6:38 PM · Plasma
gvgeo committed R115:606c6499750a: [KCM]Update Device item layout based on applet (authored by gvgeo).
[KCM]Update Device item layout based on applet
Mar 3 2020, 5:49 PM
gvgeo closed D27422: [KCM]Update Device item layout based on applet.
Mar 3 2020, 5:49 PM · Plasma
gvgeo updated the diff for D27608: Fixes for applet configuration layout..

Restore code for vertical line.
Cannot find a reason this happens or replicate. But realized that the change was unnecessary. Did this fixed it?

Mar 3 2020, 5:45 PM · Plasma
gvgeo added a comment to D27422: [KCM]Update Device item layout based on applet.

I'm seeing some weird jagginess on radio buttons, slider handles, and combobox shadows:

This is just 1x scaling with no weird font DPI fiddling.

Mar 3 2020, 11:24 AM · Plasma
gvgeo updated the diff for D27422: [KCM]Update Device item layout based on applet.

rebase

Mar 3 2020, 11:21 AM · Plasma
gvgeo committed R115:20c0e9b8eb7d: Merge branch 'Plasma/5.18' (authored by gvgeo).
Merge branch 'Plasma/5.18'
Mar 3 2020, 10:43 AM
gvgeo committed R115:552b0384ffd2: [KCM]Fix content below scrollbars (authored by gvgeo).
[KCM]Fix content below scrollbars
Mar 3 2020, 10:41 AM
gvgeo closed D27577: [KCM]Fix content below scrollbars.
Mar 3 2020, 10:41 AM · Plasma
gvgeo committed R119:bfcc6df32396: [Applet/TaskManager]Don't create extra PulseAudio component (authored by gvgeo).
[Applet/TaskManager]Don't create extra PulseAudio component
Mar 3 2020, 10:30 AM
gvgeo closed D27734: [Applet/TaskManager]Don't create extra PulseAudio component.
Mar 3 2020, 10:30 AM · Plasma
gvgeo added a comment to D27608: Fixes for applet configuration layout..

I'm starting to agree that this is the wrong place to add the titlebar separator.

Can this go as is, for now? I don't believe there is an alternative in the near future.

Mar 3 2020, 8:06 AM · Plasma

Mar 2 2020

gvgeo added a comment to D27792: [Applet]Fix traffic monitor labels width.

Is it?

Mar 2 2020, 8:15 PM · Plasma
gvgeo added a comment to D27792: [Applet]Fix traffic monitor labels width.

@ngraham Is there a better way to fix this?

Looks this changed introduced an issue. The traffic monitor doesn't fit into the applet.

See picture below:

Mar 2 2020, 8:08 PM · Plasma
gvgeo updated the test plan for D27792: [Applet]Fix traffic monitor labels width.
Mar 2 2020, 8:05 PM · Plasma
gvgeo requested review of D27792: [Applet]Fix traffic monitor labels width.
Mar 2 2020, 8:03 PM · Plasma
gvgeo added a comment to D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid.

IMO this is the wrong way to do these changes.

  1. I don't see "itemSize" to be used anywhere else(didn't check) than "tasksRow" where we already add a smallSpacing. It would be best to increase the size in one place.
  2. For tablets already allow to use bigger size icons. There is no need to artificially increase the size this way, if they need bigger size can increase the panel height.
  3. Can expose plasmoid.configuration.iconSize to the user. Otherwise can be removed.
Mar 2 2020, 5:06 AM · Plasma

Feb 29 2020

gvgeo added a comment to D27737: Fixed margin of digital clock.

I was too late, it does change constantly now. But it depends on the font. The default font has the same width for all numbers, others don't.

Feb 29 2020, 6:46 PM · Plasma
gvgeo added a comment to D27737: Fixed margin of digital clock.

By using paintedWidth size is going to change constantly and will move the rest of the widgets.

Feb 29 2020, 5:49 PM · Plasma
gvgeo added a comment to D27645: [KCM]Align volume controls row.

In my opinion this is better even without the workaround.
Only when scale is 100% for devices, look worse (first photo in before-after).

Feb 29 2020, 8:12 AM · Plasma
gvgeo added a comment to D27577: [KCM]Fix content below scrollbars.

I don't see any objections, will push to stable.

Feb 29 2020, 7:58 AM · Plasma
gvgeo requested review of D27734: [Applet/TaskManager]Don't create extra PulseAudio component.
Feb 29 2020, 7:48 AM · Plasma

Feb 28 2020

gvgeo abandoned D27711: [Applet]Use gridLayout for details.

In favor of kirigami form.

Feb 28 2020, 8:13 AM · Plasma
gvgeo added a comment to D27711: [Applet]Use gridLayout for details.

Kirigami in applet?

Feb 28 2020, 3:15 AM · Plasma

Feb 27 2020

gvgeo added a comment to D27711: [Applet]Use gridLayout for details.

Separate patch so can be easily reverted, if a grid+repeater problem exist R120:d12521b149fa.

Feb 27 2020, 6:48 PM · Plasma
gvgeo requested review of D27711: [Applet]Use gridLayout for details.
Feb 27 2020, 6:38 PM · Plasma
gvgeo committed R116:24b737bc6d5c: [Applet]Update layout based on T10470 (authored by gvgeo).
[Applet]Update layout based on T10470
Feb 27 2020, 6:34 PM
gvgeo closed D27199: [Applet]Update layout based on T10470.
Feb 27 2020, 6:34 PM · Plasma
gvgeo updated the test plan for D27645: [KCM]Align volume controls row.
Feb 27 2020, 12:31 PM · Plasma
gvgeo updated the test plan for D27645: [KCM]Align volume controls row.
Feb 27 2020, 10:38 AM · Plasma
gvgeo added a comment to D27669: [kstyle] Tools area.

Filelight works fine here. Kmag has some buttons with wrong color, but the toolbar row takes correct color.

Feb 27 2020, 9:56 AM · Plasma
gvgeo updated the diff for D27199: [Applet]Update layout based on T10470.

rebase

Feb 27 2020, 9:39 AM · Plasma
gvgeo updated the diff for D27645: [KCM]Align volume controls row.

Removed workaround.

Feb 27 2020, 7:57 AM · Plasma
gvgeo added inline comments to D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled.
Feb 27 2020, 6:48 AM · Plasma
gvgeo added a comment to D27645: [KCM]Align volume controls row.

Should I remove the slider workaround? And leave it with 2 pixel offset?

Feb 27 2020, 6:25 AM · Plasma
gvgeo added a comment to D27199: [Applet]Update layout based on T10470.

ping

Feb 27 2020, 6:04 AM · Plasma
gvgeo added a comment to D26983: Enable adding place as first child.

ping

Feb 27 2020, 5:58 AM · Frameworks
gvgeo added a comment to D26806: [Applets/Power Manager] Update layout based on T10470.

@davidedmundson ping

Feb 27 2020, 5:57 AM · Plasma
gvgeo updated the summary of D26806: [Applets/Power Manager] Update layout based on T10470.
Feb 27 2020, 5:56 AM · Plasma
gvgeo updated the summary of D26806: [Applets/Power Manager] Update layout based on T10470.
Feb 27 2020, 5:49 AM · Plasma

Feb 26 2020

gvgeo added inline comments to D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled.
Feb 26 2020, 8:37 PM · Plasma
gvgeo committed R115:8169507305aa: Merge branch 'Plasma/5.18' (authored by gvgeo).
Merge branch 'Plasma/5.18'
Feb 26 2020, 5:34 PM
gvgeo committed R115:8dea974eacf0: [KCM]Set implicitWidth for main page (authored by gvgeo).
[KCM]Set implicitWidth for main page
Feb 26 2020, 5:30 PM
gvgeo closed D27648: [KCM]Set implicitWidth for main page.
Feb 26 2020, 5:30 PM · Plasma
gvgeo committed R115:ada3385d04c3: [Applet]Improvements for unavailable port. (authored by gvgeo).
[Applet]Improvements for unavailable port.
Feb 26 2020, 5:19 PM
gvgeo closed D27420: [Applet]Improvements for unavailable port..
Feb 26 2020, 5:19 PM · Plasma
gvgeo updated the diff for D27422: [KCM]Update Device item layout based on applet.

Hide portbox if window is too small.

Feb 26 2020, 5:09 PM · Plasma