- User Since
- Dec 4 2019, 12:29 PM (26 w, 2 d)
Mar 21 2020
Instead of kuserfeedback which uploads data collected prior users consent, I believe this patch is good enough. @ngraham It appears that I should let you know that, I'm no longer going to work on it under these circumstances, so that you can use it if you want.
Mar 18 2020
You should thank @ngraham. He is the one making these small changes, including the password field size, in that patch.
Don't see any interest (or response), made a bug report instead.
Base patch was abandoned.
Thanks for your help @meven, but I 'll close this patch now.
It doesn't seem to be high in priorities.
And to be honest among other reasons, after I found how problematic the code is, I'm not so keen on building on top of it.
Mar 16 2020
Are there objections for Math.round(gridUnit * 2.33) (42 with default settings) suggested by @filipf? So that it can have big icons.
Mar 14 2020
Differently sized icons are about to be restored in D28034.
Mar 13 2020
Labels need eliding. Full width has problems?
Button need to expand also. Click always collapse?
Listitem.qml can be removed now. Not exactly.
Currently data is collected by default, with no way of disabling it.
That's far from true. Things are off by default. Most providers are not run at all.
The commit message is either confused or misleading.
I made an assumption, based on the data collected for gammaray. But on second check, it seems that it uses it's own implementation of kuserfeedback.
Changed the description. Confused or not, if it is wrong, it is misleading.
Mar 12 2020
Added Frameworks for visibility. kuserfeedback is not included in the group.
Mar 10 2020
Couple of notes, as I'm not sure what the aim was here. I have not test it, take them with a grain of salt.
- Highlight area was changed, without changing the click area.
- Connect button pop up area change, was not documented.
- Highlight svg is not consistent with list's highlight. And maybe not always look good. (Although it's designation is pressed, everywhere used as highlight, which is an different story itself.)
- There is code left in various places, listitem.qml possibly could be removed completely now.
Mar 9 2020
Generally FormLayout is unfit for this, If I understand it correctly they cannot get theme.smallestFont height. Which will introduce big height, and big margins between lines.
Do we need to reduce the opacity for the labels?
The opacity was reduced in the layout update. IMO this is vital part of the new layout.
I believe that D26992, moves the icons down. And this patch, by adding an extra smallSpacing/2 makes it more noticeable.
@ngraham If FormLayout does not support opacity/enabled for labels, then maybe, this patch is good enough.
Mar 6 2020
Currently the default font size for time is 17. In picture above is 10 or 9 with the extra "1" (at 10 o'clock). I feel that needs to be bigger, otherwise better stay as is.
That's why I made "am" smaller, to make the time in description's example size 12.
Vertical panel has limited space for time and date. If time could get bigger numbers, would be +1 from me.
Mar 5 2020
IMO better use Math.round(gridUnit*2.1) than fixed value that will not always look good with a scaled display.
It seems that QQC2 as long a horizontal value is set, will flip it around. Otherwise will use the default direction left.
Agree, looks like a bug. Kirigami and frameworks are the places where this should be set. Already have corrected the other patch.
Remove title alingment for kirigami change.
Disable the mute function then. And maybe add as an option.
Prevent vertical scrollbar from popping on/off internally.
Fix title alignment for RTL.
Set RTL content to use available width .
Mar 4 2020
I don't plan to make more patches, for now. But if the problem would not exist with Layouts, I would prefer to do it than make quick bugfixes.
There is a problem, I still try to fix...
Unfortunately I won't be able to continue with this patch about battery applet.
Feel free to use/modify if you want.
Strange, I don't get the resizing problem as it is now, or in master. Only managed to get this space by changing the theme, and was immediately fixed with resize.
Cancel button was touching the edge in RTL.
Unfortunatly the RTL layout has some issues, had to disable the use of available width for RTL layout, to stop the jumping from the scrollview.
VDG Does a better way exist, to measure the width of transfer speed text?
Mar 3 2020
I'll give a bit more time, so @filipf gets a chance to check again and accept if possible.
Restore code for vertical line.
Cannot find a reason this happens or replicate. But realized that the change was unnecessary. Did this fixed it?
I'm starting to agree that this is the wrong place to add the titlebar separator.
Can this go as is, for now? I don't believe there is an alternative in the near future.
Mar 2 2020
@ngraham Is there a better way to fix this?
IMO this is the wrong way to do these changes.
- I don't see "itemSize" to be used anywhere else(didn't check) than "tasksRow" where we already add a smallSpacing. It would be best to increase the size in one place.
- For tablets already allow to use bigger size icons. There is no need to artificially increase the size this way, if they need bigger size can increase the panel height.
- Can expose plasmoid.configuration.iconSize to the user. Otherwise can be removed.
Feb 29 2020
I was too late, it does change constantly now. But it depends on the font. The default font has the same width for all numbers, others don't.
By using paintedWidth size is going to change
constantly and will move the rest of the widgets.
In my opinion this is better even without the workaround.
Only when scale is 100% for devices, look worse (first photo in before-after).
I don't see any objections, will push to stable.
Feb 28 2020
In favor of kirigami form.
Kirigami in applet?
Feb 27 2020
Separate patch so can be easily reverted, if a grid+repeater problem exist R120:d12521b149fa.
Filelight works fine here. Kmag has some buttons with wrong color, but the toolbar row takes correct color.
Should I remove the slider workaround? And leave it with 2 pixel offset?
Feb 26 2020
Hide portbox if window is too small.