gvgeo (George Vogiatzis)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Dec 4 2019, 12:29 PM (6 w, 3 d)
Availability
Available

Recent Activity

Today

gvgeo added a comment to T10470: Improve the visuals of tray popups.

The new layout.

Sat, Jan 18, 8:29 AM · VDG
gvgeo added a comment to D26735: [Components 3]Make slider tickmarks optional.

My case would be solved with stepCount > 1. But AFAIK there are keyboards with 3-4 steps.

Is there a way to achieve this with the existing qqc2 API?

Not that I know. And need moved signal from it.

Sat, Jan 18, 5:02 AM · Frameworks

Yesterday

gvgeo retitled D26735: [Components 3]Make slider tickmarks optional from [Components 3]Make Slider tickmarks optional to [Components 3]Make slider tickmarks optional.
Fri, Jan 17, 7:39 PM · Frameworks
gvgeo added a comment to D26735: [Components 3]Make slider tickmarks optional.

Added to disable tickmarks, in battery's keyboard brightness control.

Fri, Jan 17, 7:33 PM · Frameworks
gvgeo requested review of D26735: [Components 3]Make slider tickmarks optional.
Fri, Jan 17, 7:31 PM · Frameworks
gvgeo added a comment to T10470: Improve the visuals of tray popups.

I 'm working on battery panel.
Almost there, but need an idea what to do with the suppression messages.


The brightness icons are unreadable now (keyboard icon has a sun, on the top right corner). Better use generic brightness icons?
Anything else you can see from this picture? And yes, I know, checkbox needs more space on top.

Fri, Jan 17, 3:40 PM · VDG

Wed, Jan 15

gvgeo added a comment to D26660: [Applets/Task Manager] Fix and improve behavior tab layouts.

Originally didn't include the bug report into the summary, because my request was: Add a 4th option, to affect option 2. IMHO these settings are confusing.
If you would welcome such a change (or similar), maybe need a new, clear bug report.

Wed, Jan 15, 10:27 AM · Plasma

Tue, Jan 14

gvgeo updated the test plan for D26660: [Applets/Task Manager] Fix and improve behavior tab layouts.
Tue, Jan 14, 9:06 PM · Plasma
gvgeo updated the test plan for D26660: [Applets/Task Manager] Fix and improve behavior tab layouts.
Tue, Jan 14, 9:05 PM · Plasma
gvgeo updated the diff for D26660: [Applets/Task Manager] Fix and improve behavior tab layouts.

On more careful examination, "Group only when the Task Manager is full" option, does not affect grouping, when "combing into single button" is disabled.
Flipped back the order of the 2 options, and brought back the condition and text.

Tue, Jan 14, 9:03 PM · Plasma
gvgeo updated the test plan for D26660: [Applets/Task Manager] Fix and improve behavior tab layouts.
Tue, Jan 14, 1:03 PM · Plasma
gvgeo added a comment to D26660: [Applets/Task Manager] Fix and improve behavior tab layouts.

From https://bugs.kde.org/show_bug.cgi?id=415649
Option 3 affects option 1 instead of 2.

Tue, Jan 14, 12:51 PM · Plasma
gvgeo requested review of D26660: [Applets/Task Manager] Fix and improve behavior tab layouts.
Tue, Jan 14, 12:41 PM · Plasma
gvgeo added a comment to D26634: Correctly compute bottom margin for grid delegates with subtitles.

That's what you see with this patch?....

Tue, Jan 14, 1:09 AM · Frameworks

Mon, Jan 13

gvgeo added a comment to D26634: Correctly compute bottom margin for grid delegates with subtitles.

Then, is it an option to create GridDelegateSubtitles.qml instead?
As is now, without subtitles, I see everywhere squash shapes and bigger than necessary empty space.

Mon, Jan 13, 8:27 PM · Frameworks
gvgeo added inline comments to D26634: Correctly compute bottom margin for grid delegates with subtitles.
Mon, Jan 13, 5:47 PM · Frameworks
gvgeo updated the test plan for D26627: Mark applications that play audio for small panels..
Mon, Jan 13, 4:30 PM · Plasma
gvgeo added a comment to D25925: Mark applications that play audio, for all task icon sizes.

D26627

Mon, Jan 13, 2:41 PM · Plasma
gvgeo updated the summary of D26627: Mark applications that play audio for small panels..
Mon, Jan 13, 2:40 PM · Plasma
gvgeo added a comment to D26627: Mark applications that play audio for small panels..

I was not so fond of limiting when small, but was trying to avoid this.


Didn't notice that for classic panel is more visible at the same size.

Mon, Jan 13, 2:39 PM · Plasma
gvgeo requested review of D26627: Mark applications that play audio for small panels..
Mon, Jan 13, 2:35 PM · Plasma
gvgeo added a comment to D26271: [Applet]Update layout based on T10470.

Found this request to display the name of the stream https://bugs.kde.org/show_bug.cgi?id=409453 .
Which was done, but remove here. Maybe should leave it too?
With a quick check, not many applications have this information.

Mon, Jan 13, 11:59 AM · Plasma
gvgeo added a comment to D15418: Dim application icon when it is not playing anything.

Maybe something like this?

Mon, Jan 13, 11:27 AM · Plasma

Sat, Jan 11

gvgeo added a comment to D26271: [Applet]Update layout based on T10470.

Can't include an untested patch because we are in a hurry.

Sat, Jan 11, 6:18 AM · Plasma

Fri, Jan 10

gvgeo updated the test plan for D26574: [Applet]Hide hamburger menu when empty.
Fri, Jan 10, 10:39 PM · Plasma
gvgeo added a comment to D26574: [Applet]Hide hamburger menu when empty.

KCM is in a state of confusion. Doesn't see the port change from lock prevention, and shows the port that was selected(unavailable). While the volume and mute affect the active port.
If these patches ever get accepted, can see at a later time this part.

Fri, Jan 10, 10:38 PM · Plasma
gvgeo updated the test plan for D26574: [Applet]Hide hamburger menu when empty.
Fri, Jan 10, 10:28 PM · Plasma
gvgeo requested review of D26574: [Applet]Hide hamburger menu when empty.
Fri, Jan 10, 10:25 PM · Plasma
gvgeo added a dependent revision for D26418: [Applet]Add global mute function: D26574: [Applet]Hide hamburger menu when empty.
Fri, Jan 10, 10:25 PM · Plasma
gvgeo updated the diff for D26418: [Applet]Add global mute function.

Removal of trailing space

Fri, Jan 10, 10:24 PM · Plasma
gvgeo updated the diff for D26256: [Applet] Make 'raise maximum volume' global.

rebase

Fri, Jan 10, 10:21 PM · Plasma
gvgeo updated the diff for D26271: [Applet]Update layout based on T10470.

Separate bug fixes.
Change defaultButton visibility
Change defaultButton's RowLayout height

Fri, Jan 10, 10:21 PM · Plasma

Thu, Jan 9

gvgeo requested review of D26548: [Applet] Fix empty space and give correct size.
Thu, Jan 9, 4:43 PM · Plasma
gvgeo added a comment to D26271: [Applet]Update layout based on T10470.

It makes possible to change volume/mute before plug something. But have no idea, if there is any real reason.

Thu, Jan 9, 4:03 PM · Plasma
gvgeo planned changes to D26271: [Applet]Update layout based on T10470.

Found a bug. There is no update when a port that is not in use gets unavailable.

Thu, Jan 9, 8:15 AM · Plasma

Mon, Jan 6

gvgeo updated the summary of D25925: Mark applications that play audio, for all task icon sizes.
Mon, Jan 6, 8:27 PM · Plasma
gvgeo added a comment to D25925: Mark applications that play audio, for all task icon sizes.

No problem ngraham, was tiny change anyway.

Mon, Jan 6, 8:26 PM · Plasma
gvgeo updated the diff for D25925: Mark applications that play audio, for all task icon sizes.

Removed glow
Small increase of icon size.

Mon, Jan 6, 8:23 PM · Plasma
gvgeo updated the diff for D26418: [Applet]Add global mute function.

rebase

Mon, Jan 6, 6:59 PM · Plasma
gvgeo updated the diff for D26256: [Applet] Make 'raise maximum volume' global.

rebase

Mon, Jan 6, 6:58 PM · Plasma
gvgeo updated the diff for D26271: [Applet]Update layout based on T10470.

Add description check

Mon, Jan 6, 6:57 PM · Plasma
gvgeo added a comment to D26271: [Applet]Update layout based on T10470.

Lovely. Any chance we could make the bottom divider touch the edges of the window?

Not really, not from here. This space is part of system tray. If you use the plasma-pa widget only, will see that it touches exactly the edge.
Bigger negative value does not show in the system tray, but would make the line appear outside the widget if used on desktop.

Mon, Jan 6, 3:47 PM · Plasma
gvgeo added inline comments to D26271: [Applet]Update layout based on T10470.
Mon, Jan 6, 2:29 PM · Plasma
gvgeo added a comment to D26271: [Applet]Update layout based on T10470.

It is a theme problem. Breeze light also has problem.
Widgets take color from Plasma Style. While in applications are fine.
I checked with this widget to compare.

Mon, Jan 6, 10:39 AM · Plasma
gvgeo updated the summary of D26271: [Applet]Update layout based on T10470.
Mon, Jan 6, 10:03 AM · Plasma
gvgeo added a comment to D26271: [Applet]Update layout based on T10470.
Mon, Jan 6, 9:49 AM · Plasma
gvgeo updated the diff for D26418: [Applet]Add global mute function.

Cleanup
Planed changes

Mon, Jan 6, 9:44 AM · Plasma
gvgeo updated the diff for D26256: [Applet] Make 'raise maximum volume' global.

rebase

Mon, Jan 6, 9:42 AM · Plasma
gvgeo updated the diff for D26271: [Applet]Update layout based on T10470.

leanup
Remove separation lines
Fix 2 bugs
Full Name display when a port name sub-strings are same.
Requested changes

Mon, Jan 6, 9:37 AM · Plasma

Sun, Jan 5

This is a test notification, sent at Sun, Jan 5, 11:57 PM.
Sun, Jan 5, 9:57 PM
This is a test notification, sent at Sun, Jan 5, 11:57 PM.
Sun, Jan 5, 9:57 PM
gvgeo planned changes to D26418: [Applet]Add global mute function.

Will remove timer,onRowsInserted in paSinkModel does the same during init.

Sun, Jan 5, 5:24 AM · Plasma

Sat, Jan 4

gvgeo updated the diff for D26418: [Applet]Add global mute function.

Add global mute for shortcuts/tray icon.
Will prioritize current sink mute state, and accordingly will also trigger global mute.

Sat, Jan 4, 6:18 PM · Plasma
gvgeo updated the diff for D26418: [Applet]Add global mute function.

squash

Sat, Jan 4, 3:54 PM · Plasma
gvgeo updated the diff for D26256: [Applet] Make 'raise maximum volume' global.

squash

Sat, Jan 4, 3:46 PM · Plasma
gvgeo updated the diff for D26271: [Applet]Update layout based on T10470.

Add visibility to the line that splits playback and record.
On the application side, will show if there is 1 record and 1 playback
application. Because there is no port name to easily differentiate them.

Sat, Jan 4, 3:34 PM · Plasma
gvgeo added a comment to D26418: [Applet]Add global mute function.

Icon is not monochrome. Is there an alternative? Or have to do it with desaturate graphical effect?

Sat, Jan 4, 1:01 PM · Plasma
gvgeo added a comment to D26271: [Applet]Update layout based on T10470.

About the devices labels, I feel it is fine as it is. It is not a problem, to have two devices with the same port name.
Only if could put a tooltip. But no, Radiobutton does not deserve a tooltip.
What else to do, without displaying the full device names?

Sat, Jan 4, 12:48 PM · Plasma
gvgeo retitled D26418: [Applet]Add global mute function from [APPLET]Add global mute function to [Applet]Add global mute function.
Sat, Jan 4, 12:34 PM · Plasma
gvgeo added a dependent revision for D26256: [Applet] Make 'raise maximum volume' global: D26418: [Applet]Add global mute function.
Sat, Jan 4, 12:33 PM · Plasma
gvgeo requested review of D26418: [Applet]Add global mute function.
Sat, Jan 4, 12:33 PM · Plasma
gvgeo added a dependent revision for D26271: [Applet]Update layout based on T10470: D26256: [Applet] Make 'raise maximum volume' global.
Sat, Jan 4, 12:27 PM · Plasma
gvgeo added a dependency for D26256: [Applet] Make 'raise maximum volume' global: D26271: [Applet]Update layout based on T10470.
Sat, Jan 4, 12:27 PM · Plasma
gvgeo updated the diff for D26256: [Applet] Make 'raise maximum volume' global.

Moved limit max volume, code part,from listbase.qml into the main.qml checkbox.

Sat, Jan 4, 12:25 PM · Plasma
gvgeo updated the diff for D26271: [Applet]Update layout based on T10470.

Remove port combobox and put port selection back the hamburger menu.

Now port selection appears only if there is at least 2 available ports.

Made devices/applications labels clickable.
Removed RTL margin problems.
Made playback/recording separation line smaller.(according to mockup)

Sat, Jan 4, 12:20 PM · Plasma

Mon, Dec 30

gvgeo updated the summary of D26271: [Applet]Update layout based on T10470.
Mon, Dec 30, 12:17 PM · Plasma
gvgeo updated the diff for D26271: [Applet]Update layout based on T10470.

Brought back spacing, and corrected sizes.
Centered icons, and align text.
Reduced checkbox to 18 pixel.

Mon, Dec 30, 12:06 PM · Plasma

Sun, Dec 29

gvgeo added a comment to D26271: [Applet]Update layout based on T10470.

I was not able to change the checkbox size, nothing I tried worked.
Checked other places with smaller checkbox(like notifications). But could not found how the size is controlled.

Sun, Dec 29, 8:13 PM · Plasma
gvgeo updated the diff for D26271: [Applet]Update layout based on T10470.

Fix spacing
Change plasmoid tooltip to mirror the port name
Cleanup main.qml

Sun, Dec 29, 8:04 PM · Plasma
gvgeo added a comment to D26271: [Applet]Update layout based on T10470.

Looks weird right now.
From what I can tell, themes add lines between list items.
There must be some easy way to disable it.

Sun, Dec 29, 9:49 AM · Plasma
gvgeo requested review of D26271: [Applet]Update layout based on T10470.
Sun, Dec 29, 9:44 AM · Plasma
gvgeo added a comment to T10470: Improve the visuals of tray popups.

Will the applications tab take any change?
Currently they have a nice big icon.

Sun, Dec 29, 7:11 AM · VDG

Sat, Dec 28

gvgeo added a comment to D26256: [Applet] Make 'raise maximum volume' global.

Actually I never touch volume control, so don't have strong opinion. Either way I'm good, no worries.
But in general believe, that should simplify UI and usability, while trying to keep features.

Sat, Dec 28, 6:54 PM · Plasma
gvgeo updated the diff for D26256: [Applet] Make 'raise maximum volume' global.

Fixed shortcut keys.

Sat, Dec 28, 2:12 PM · Plasma
gvgeo updated the summary of D26256: [Applet] Make 'raise maximum volume' global.
Sat, Dec 28, 1:18 PM · Plasma
gvgeo added a comment to D26256: [Applet] Make 'raise maximum volume' global.

Have a problem that marked with a TODO comment in code, but the desired functionality is working.
@ngraham I should mention that I still oppose to the functionality of this patch, and I believe the better way is D26234 that maybe missed cause of the status change.

Sat, Dec 28, 1:12 PM · Plasma
gvgeo requested review of D26256: [Applet] Make 'raise maximum volume' global.
Sat, Dec 28, 1:07 PM · Plasma

Fri, Dec 27

gvgeo planned changes to D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'.

Either I missing something, or I need to make it more clear.

Fri, Dec 27, 3:34 PM · Plasma
gvgeo planned changes to D26212: [Applet] Remember devices to raise maximum volume.

Patch is not needed, without separate raise maximum volume mode. D26234#583337

Fri, Dec 27, 10:51 AM · Plasma
gvgeo added a comment to D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'.

I get what you mean global, but I'll try to clarify for others, too.
Currently, the option in configuration, only works from shortcuts or mouse wheel on task icon.
And affects only the default output device, that is selected, at the moment of volume change.

Fri, Dec 27, 10:41 AM · Plasma

Thu, Dec 26

gvgeo requested review of D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'.
Thu, Dec 26, 1:35 PM · Plasma
gvgeo added a dependent revision for D26212: [Applet] Remember devices to raise maximum volume: D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'.
Thu, Dec 26, 1:35 PM · Plasma
gvgeo updated the diff for D26212: [Applet] Remember devices to raise maximum volume.

Changed names and function.

Thu, Dec 26, 5:45 AM · Plasma

Tue, Dec 24

gvgeo added a reviewer for D26212: [Applet] Remember devices to raise maximum volume: Plasma.
Tue, Dec 24, 5:54 PM · Plasma
gvgeo requested review of D26212: [Applet] Remember devices to raise maximum volume.
Tue, Dec 24, 5:51 PM · Plasma
gvgeo updated the diff for D25925: Mark applications that play audio, for all task icon sizes.

Replace magic number with iconSize.

Tue, Dec 24, 10:00 AM · Plasma

Mon, Dec 23

gvgeo updated the diff for D25925: Mark applications that play audio, for all task icon sizes.

Add 'cached' Glow property.

Mon, Dec 23, 12:10 PM · Plasma
gvgeo added a comment to D25925: Mark applications that play audio, for all task icon sizes.

There is a cached option too for Glow, that did not include.
Don't know if it will make any difference. Somewhere read that plasma already cache all icons.

Mon, Dec 23, 12:00 PM · Plasma
gvgeo updated the diff for D25925: Mark applications that play audio, for all task icon sizes.

Change visibility. (iconBox from >14 to >=16)
Change visibility comment.
Change the Glow's radius. (audioStreamIcon 0.2 -> 0.17)
Decrease Glow's samples.

Mon, Dec 23, 11:43 AM · Plasma

Sat, Dec 21

gvgeo updated the diff for D26124: Add byte display option in Network Monitor plasmoid.

Correct label of displayUnits in xml.
Add values to displayUints options.
Correct copyright message.

Sat, Dec 21, 8:03 AM · Plasma

Fri, Dec 20

gvgeo updated the diff for D26124: Add byte display option in Network Monitor plasmoid.

Add xml display entry, to save the option.
Added in the common main.xml. Now the rest 4 system monitor applets
will have an extra entry that will not use.

Fri, Dec 20, 9:09 PM · Plasma
gvgeo added a comment to D26124: Add byte display option in Network Monitor plasmoid.

I can't find a way to add the new option in the same Interfaces group.
If I add Kirigami.FormLayout stops reading the values, even if the layout works.
Tried something like this:

Kirigami.FormLayout {  //<----Adding only this line alone, is a problem.
    ConfigGeneral {
    // existing part, netConfg.qml 
    }  
   Kirigami.FormLayout {
   //new part, displayConfig.qml
   }
}
Fri, Dec 20, 5:10 PM · Plasma
gvgeo added a reviewer for D26124: Add byte display option in Network Monitor plasmoid: VDG.
Fri, Dec 20, 5:05 PM · Plasma
gvgeo requested review of D26124: Add byte display option in Network Monitor plasmoid.
Fri, Dec 20, 5:04 PM · Plasma

Dec 19 2019

gvgeo added a comment to D25741: Add natural sorting and case-insensitive sorting for all role-types.

Name should be more clear, marking as done for now.

Dec 19 2019, 5:35 PM · Dolphin
gvgeo updated the diff for D25741: Add natural sorting and case-insensitive sorting for all role-types.

String role was not the best option. Function's comment was also wrong.

Dec 19 2019, 5:27 PM · Dolphin

Dec 18 2019

gvgeo added a comment to D25741: Add natural sorting and case-insensitive sorting for all role-types.

As for the multicase, the are still these cases that don't benefit (if I'm not wrong) from the natural sorting and case insensitive:

Dec 18 2019, 6:32 PM · Dolphin
gvgeo updated the diff for D25741: Add natural sorting and case-insensitive sorting for all role-types.

Fixed style.
Move 'roleLessThan' part in lambda code.

Dec 18 2019, 6:25 PM · Dolphin
gvgeo added a comment to D25741: Add natural sorting and case-insensitive sorting for all role-types.

Natural sort problem was indeed locale problem. The bug was irrelevant, removed from summary.

Dec 18 2019, 10:56 AM · Dolphin
gvgeo updated the diff for D25741: Add natural sorting and case-insensitive sorting for all role-types.

Add funciton roleLessThan. Kept 'nameLessThan' instead of changing it to 'stringLessThan'
Add funciton stringRolesTrue. To compare multiple values to m_sortRole
Added stringRolesTrue in KFileItemModel::sort for parallelMergeSort. To speed up now that have natural sorting.

Dec 18 2019, 10:46 AM · Dolphin