alexde (Alex Debus)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2018, 3:42 PM (57 w, 4 d)
Availability
Available

Recent Activity

Mon, Nov 11

alexde added a comment to D25018: Move ACPI battery information from /proc/acpi to /sys.

Are states > 100 or < 0 really well defined? Is it save to assume that a state > 100 can be associated with 100?

Yes : this is a percentage. States out of this value are bad hardware : I have a travel battery which shows crazy values along time, from 0,001Wh capacity till 901Wh (Real capacity is near 45Wh).

Mon, Nov 11, 7:56 PM · Plasma
alexde added inline comments to D25018: Move ACPI battery information from /proc/acpi to /sys.
Mon, Nov 11, 6:39 PM · Plasma

Sun, Oct 20

alexde added a comment to T11660: requirements for Krita on plasma wayland.

So, one needed thing ultimately is to extend libinput to reach feature parity with xf86-input-wacom. I know this is not directly part of plasma dev, but this had to be said, and I hope we can get good communication with libinput devs to move forward on that topic.

Sun, Oct 20, 9:35 AM · Plasma on Wayland

Oct 4 2019

alexde added a comment to D24362: Don't count hidden files in folder item count.

X files (Y hidden) can be misleading if X >> Y, for example 240 files (3 hidden) could be interpreted as there are 240 files from which 3 are hidden.
Maybe a X files + Y hidden is more obvious.

Oct 4 2019, 10:57 AM · Baloo

Oct 3 2019

alexde added a comment to D24379: [energy kcm] Fix Technology values.

As this it not in the scope of this patch, those values look suspicious to me too:

switch(model.battery.type) {
case 3: return i18n("Internal battery")
case 2: return i18n("UPS battery")
case 9: return i18n("Monitor battery")
case 4: return i18n("Mouse battery")
case 5: return i18n("Keyboard battery")
case 1: return i18n("PDA battery")
case 7: return i18n("Phone battery")
default: return i18n("Unknown battery")

Is there a special reason for the weired order? Is it correct that case 0 and 6 are missing and default to unknown? Maybe (I haven't looked deeper into it) this needs another patch.

Oct 3 2019, 11:06 AM · Plasma

Sep 28 2019

alexde retitled D24280: Split Util in public and private functions from Spit Util in public and private functions to Split Util in public and private functions.
Sep 28 2019, 10:44 AM · KDE PIM

Sep 17 2019

alexde updated the diff for D24036: Fix the last fix of the max y-range computation.

The next loop starts with index+1. This rare case with index out of bounds should not happen, but just in case ...

Sep 17 2019, 10:04 PM · Plasma
alexde added a comment to D24036: Fix the last fix of the max y-range computation.

This range check should definitely be included. The other error, I don't know right away. If no one else spots it, I will check it on the weekend.

Sep 17 2019, 9:57 PM · Plasma
alexde updated the diff for D24036: Fix the last fix of the max y-range computation.

Add range check for index variable

Sep 17 2019, 9:56 PM · Plasma
alexde added a comment to D24036: Fix the last fix of the max y-range computation.

I still get:

file:///home/nate/kde/usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/Graph.qml:114: TypeError: Cannot read property 'x' of undefined
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/Graph.qml:114: TypeError: Cannot read property 'x' of undefined
Sep 17 2019, 9:20 PM · Plasma
alexde updated the summary of D24036: Fix the last fix of the max y-range computation.
Sep 17 2019, 8:52 PM · Plasma
alexde updated the summary of D24036: Fix the last fix of the max y-range computation.
Sep 17 2019, 8:52 PM · Plasma
alexde requested review of D24036: Fix the last fix of the max y-range computation.
Sep 17 2019, 8:50 PM · Plasma
alexde added a comment to R102:e45efe059ca9: Fix maximum y-value-range computation.

I have spotted a mistake, it should have been something like this with floor:

Sep 17 2019, 5:18 PM
alexde updated the test plan for D24029: Fix maximum y-value-range computation.
Sep 17 2019, 4:49 PM · Plasma
alexde abandoned D24028: Summary: Fix computing maximum range for y-values.

https://phabricator.kde.org/D24029

Sep 17 2019, 4:49 PM
alexde requested review of D24029: Fix maximum y-value-range computation.
Sep 17 2019, 4:48 PM · Plasma
alexde added a comment to D24028: Summary: Fix computing maximum range for y-values.

Oh, need to rebase, I guess. :-)

Sep 17 2019, 4:41 PM
alexde updated the test plan for D24028: Summary: Fix computing maximum range for y-values.
Sep 17 2019, 4:40 PM
alexde retitled D24028: Summary: Fix computing maximum range for y-values from Summary: Fix scaling of Y-Values to Summary: Fix computing maximum range for y-values.
Sep 17 2019, 4:39 PM
alexde requested review of D24028: Summary: Fix computing maximum range for y-values.
Sep 17 2019, 4:38 PM

Sep 14 2019

alexde updated the diff for D23520: Add time line to X axis.

Remove redundant and now wrong comment

Sep 14 2019, 4:11 PM · Plasma
alexde updated the diff for D23520: Add time line to X axis.

Fix offset calculation for the one hour graph

Sep 14 2019, 3:45 PM · Plasma
alexde added a comment to D23520: Add time line to X axis.

Thanks, that's fixed now. However the "Last hour" graph still looks a little odd...

Sep 14 2019, 3:04 PM · Plasma
alexde updated the diff for D23520: Add time line to X axis.

Fix typo in variable and by that make all X axis labels appear again.

Sep 14 2019, 2:44 PM · Plasma
alexde updated the diff for D23520: Add time line to X axis.

The former scaling of the x-Positions of the data points did not fit to the time axis.
Now the x-values of the points, i. e. their timestamps, are correctly aligned.

Sep 14 2019, 1:02 PM · Plasma
alexde updated the diff for D23520: Add time line to X axis.

Remove redundant semicolons and move comment about unit (ms) to the declaration of the var

Sep 14 2019, 10:18 AM · Plasma
alexde updated the diff for D23520: Add time line to X axis.

Use a switch statement for xTicksAt

Sep 14 2019, 10:14 AM · Plasma

Sep 10 2019

alexde updated the test plan for D23848: Add Breeze icons for Jupyter Notebook files.
Sep 10 2019, 7:38 PM · Frameworks
alexde requested review of D23848: Add Breeze icons for Jupyter Notebook files.
Sep 10 2019, 7:28 PM · Frameworks

Sep 9 2019

alexde added a comment to D23520: Add time line to X axis.

*Friendly ping to the reviewers.*

Sep 9 2019, 12:49 PM · Plasma

Sep 8 2019

alexde added a comment to D23788: Change the blog's texts align to justify..

I think I should exclude the headlines in a following patch.

Sep 8 2019, 1:59 PM
alexde updated the test plan for D23788: Change the blog's texts align to justify..
Sep 8 2019, 1:58 PM
alexde updated the test plan for D23788: Change the blog's texts align to justify..
Sep 8 2019, 1:56 PM
alexde updated the test plan for D23788: Change the blog's texts align to justify..
Sep 8 2019, 1:53 PM
alexde requested review of D23788: Change the blog's texts align to justify..
Sep 8 2019, 1:49 PM

Sep 5 2019

alexde requested review of D23746: Set a minimum window size to reasonable 800x600 px.
Sep 5 2019, 7:28 PM · Plasma
alexde updated the diff for D23520: Add time line to X axis.

Set correct right border for the grid lines and ticks.

Sep 5 2019, 4:32 PM · Plasma
alexde updated the test plan for D23520: Add time line to X axis.
Sep 5 2019, 1:15 PM · Plasma
alexde updated the diff for D23520: Add time line to X axis.

Move stroke() out of the loop.
Reduce line with by pixel.

Sep 5 2019, 1:12 PM · Plasma
alexde updated the diff for D23520: Add time line to X axis.

Shrink plotWidth a little bit so the earliest date on the right side may fit.
Change the way the division widths are defined to hopefully make the code easier to understand
and to maintain.

Sep 5 2019, 12:50 PM · Plasma
alexde added a comment to D23520: Add time line to X axis.

For some reason the xGridOffset seems sometimes to be wrong, and I have no explanation why. It especially happens for 1 hour graphs.

Sep 5 2019, 11:24 AM · Plasma
alexde requested review of D23520: Add time line to X axis.

I have changed some stuff, can you please review it again.

Sep 5 2019, 11:13 AM · Plasma
alexde updated the test plan for D23520: Add time line to X axis.
Sep 5 2019, 11:12 AM · Plasma
alexde updated the diff for D23520: Add time line to X axis.

Rename variables to make their function clearer.
Decrease the lower loop border by 1 to make sure that all
possible grid lines are drawn.

Sep 5 2019, 11:09 AM · Plasma
alexde updated the diff for D23520: Add time line to X axis.

Fix issue that a date may be displayed unintentionally.
Shrink right margin for grid lines and try to add an additional grid line
on the right side if reasonable.
Add more divisions for 2h and 24h graphs.

Sep 5 2019, 10:24 AM · Plasma
alexde updated the diff for D23520: Add time line to X axis.

Use dashed grid lines instead of solid lines. Grid lines with tick labels are less faint.
Rename variable to make its function clearer.
Show grid lines at all five minutes for the 1 hour graph.

Sep 5 2019, 9:28 AM · Plasma
alexde updated the diff for D23520: Add time line to X axis.

Align grid to 10 minutes for the 1h graph.

Sep 5 2019, 8:04 AM · Plasma

Sep 3 2019

alexde updated the diff for D23520: Add time line to X axis.

Set valid defaults.

Sep 3 2019, 1:55 PM · Plasma
alexde updated the diff for D23520: Add time line to X axis.
  • Set valid defaults.
Sep 3 2019, 1:54 PM · Plasma
alexde added a comment to D23464: Add breeze icons for ROOT cern files.

Looks like you've got everything

Sep 3 2019, 12:24 PM · Frameworks
alexde updated the test plan for D23464: Add breeze icons for ROOT cern files.
Sep 3 2019, 12:23 PM · Frameworks
alexde updated the diff for D23464: Add breeze icons for ROOT cern files.

16px: add 2px margins to top and bottom
22px: add 3px margins to top and bottom
32px: use existing and approved 32px icon as template instead of shrinking the 64px version

Sep 3 2019, 12:07 PM · Frameworks

Sep 2 2019

alexde updated the test plan for D23464: Add breeze icons for ROOT cern files.
Sep 2 2019, 6:19 PM · Frameworks
alexde updated the diff for D23464: Add breeze icons for ROOT cern files.

Remove all circles and only use root symbol.
This makes the root symbol less faint and the icons fit better to Breeze overall.

Sep 2 2019, 6:15 PM · Frameworks

Aug 30 2019

alexde added a reviewer for D23464: Add breeze icons for ROOT cern files: ngraham.
Aug 30 2019, 3:44 PM · Frameworks
alexde added a comment to D23464: Add breeze icons for ROOT cern files.

As @noahdvs mentioned above, the white background should be removed and the entire symbol should be made up of one filled path with no outline (!). This is important to keep the icon looking as intended with the Qt SVG renderer

Aug 30 2019, 1:52 PM · Frameworks

Aug 29 2019

alexde added a comment to D23464: Add breeze icons for ROOT cern files.

The 16 and 22 px versions aren't supposed to have backgrounds and the root symbols are pretty faint.

Aug 29 2019, 3:45 PM · Frameworks
alexde updated the test plan for D23464: Add breeze icons for ROOT cern files.
Aug 29 2019, 2:08 PM · Frameworks
alexde updated the diff for D23464: Add breeze icons for ROOT cern files.

Add new 32px icons.

Aug 29 2019, 2:01 PM · Frameworks
alexde updated the test plan for D23464: Add breeze icons for ROOT cern files.
Aug 29 2019, 1:35 PM · Frameworks
alexde updated the test plan for D23464: Add breeze icons for ROOT cern files.
Aug 29 2019, 1:34 PM · Frameworks
alexde updated the diff for D23464: Add breeze icons for ROOT cern files.

Also add the new 64px breeze icon.
Add new 22 px icons. Transparent background, less faint, original color.

Aug 29 2019, 1:30 PM · Frameworks
alexde added a comment to D23464: Add breeze icons for ROOT cern files.

I think we should use #1ed4e5 for the color instead since that's what the official logo uses. Normally, I'd say to use a similar Breeze-like color, but mimetype icons are a mess anyway and I don't think it's worth worrying too much about unless Breeze's official color palette is expanded.

Aug 29 2019, 12:50 PM · Frameworks
alexde updated the test plan for D23464: Add breeze icons for ROOT cern files.
Aug 29 2019, 12:43 PM · Frameworks
alexde updated the diff for D23464: Add breeze icons for ROOT cern files.

Improve the root logo layout and change the root's color to the offical color 1ED4E5

Aug 29 2019, 12:41 PM · Frameworks
alexde added a comment to D23520: Add time line to X axis.

Right now I only display the date under the tick mark if the date has changed and the tickmark number is odd, which I think is already good enough for this graph.
However, indicating a date change at midnight (12 pm / 0 am) would make sense as well. If you prefer that and find a suitable position for the indicator label, I may implemement it.

Aug 29 2019, 7:49 AM · Plasma
alexde updated the diff for D23520: Add time line to X axis.

Fix displaying wrong variable.
Add postfix "Str" to indicate that those vars are explicitely strings.
Make sure that the date is only displayed when date has changed for <= 24h graphs.

Aug 29 2019, 7:39 AM · Plasma

Aug 28 2019

alexde updated the diff for D23520: Add time line to X axis.

Improve the formatting's consistancy

Aug 28 2019, 9:37 PM · Plasma
alexde updated the diff for D23520: Add time line to X axis.

Update comment

Aug 28 2019, 9:07 PM · Plasma
alexde updated the diff for D23520: Add time line to X axis.

Omit the date if date equals today and the graph does not range over 24 hours.

Aug 28 2019, 8:52 PM · Plasma
alexde updated the diff for D23520: Add time line to X axis.

Resolve formatting issues

Aug 28 2019, 8:40 PM · Plasma
alexde added a comment to D23520: Add time line to X axis.
Aug 28 2019, 8:26 PM · Plasma
alexde added a comment to D23415: Improve comprehensibility and consistency of window placement mode names.

I am not sure if I am allowed to intervene in this discussion, but "smart" is a really "dumb" description as it says nothing about what it actually does.
As a user I am left to do four things to find out, what it means:

Aug 28 2019, 4:54 PM · Documentation, KWin
alexde updated the diff for D23520: Add time line to X axis.

Set more sane left/right margins

Aug 28 2019, 12:56 PM · Plasma
alexde updated the summary of D23520: Add time line to X axis.
Aug 28 2019, 12:05 PM · Plasma
alexde updated the summary of D23520: Add time line to X axis.
Aug 28 2019, 8:59 AM · Plasma
alexde added a reviewer for D23520: Add time line to X axis: ngraham.
Aug 28 2019, 8:58 AM · Plasma
alexde updated the diff for D23520: Add time line to X axis.

Set correct default value for a tick position

Aug 28 2019, 8:58 AM · Plasma
alexde updated the test plan for D23520: Add time line to X axis.
Aug 28 2019, 8:53 AM · Plasma
alexde updated the test plan for D23520: Add time line to X axis.
Aug 28 2019, 8:53 AM · Plasma
alexde requested review of D23520: Add time line to X axis.
Aug 28 2019, 8:51 AM · Plasma

Aug 26 2019

alexde added a comment to D23465: Add new non standard mime type for ROOT cern files.

Yes. The maintainers of shared-mime-info will tell you if the type is right (I think, that it would be better to use <mime-type type="application/root">, similar to PDF, but I might be wrong).

Aug 26 2019, 3:51 PM · Frameworks
alexde updated subscribers of D23465: Add new non standard mime type for ROOT cern files.

The idea is good, but it should be proposed to shared-mime-info repository instead. As far as I remember from the previous discussions, this file is meant to contain a limited number of entities and possibiy disappear over time.

Aug 26 2019, 3:03 PM · Frameworks
alexde added a comment to D23450: Icons for ROOT cern files..

Sorry, for some reason it was easier for me to abandon this revision and to reopen another one here: https://phabricator.kde.org/D23464

Aug 26 2019, 2:43 PM · Frameworks
alexde updated the summary of D23464: Add breeze icons for ROOT cern files.
Aug 26 2019, 2:36 PM · Frameworks
alexde updated the test plan for D23464: Add breeze icons for ROOT cern files.
Aug 26 2019, 2:34 PM · Frameworks
alexde added a comment to D23465: Add new non standard mime type for ROOT cern files.

Here's a testfile for the defined mime type:

Aug 26 2019, 2:28 PM · Frameworks
alexde requested review of D23465: Add new non standard mime type for ROOT cern files.
Aug 26 2019, 2:21 PM · Frameworks
alexde requested review of D23464: Add breeze icons for ROOT cern files.
Aug 26 2019, 2:17 PM · Frameworks
alexde abandoned D23450: Icons for ROOT cern files..
Aug 26 2019, 2:12 PM · Frameworks

Aug 25 2019

alexde added reviewers for D23450: Icons for ROOT cern files.: ngraham, ndavis.
Aug 25 2019, 7:18 PM · Frameworks
alexde added a comment to D23450: Icons for ROOT cern files..

For some reason if I try to set the icons for ".root" files, they are shown in the dialog box, the icon can be set, but they are not shown in Dolphin. Has anyone an idea what I am doing wrong?

Aug 25 2019, 7:17 PM · Frameworks
alexde updated the test plan for D23450: Icons for ROOT cern files..
Aug 25 2019, 6:56 PM · Frameworks
alexde requested review of D23450: Icons for ROOT cern files..
Aug 25 2019, 6:53 PM · Frameworks
alexde added a comment to D22183: Add click to play/pause feature on previews for audio/video.

I am not against a better version, but the culprit is that I am no designer.
For anything more complicated we would need an icon/svg.

Aug 25 2019, 11:27 AM · Dolphin
alexde added a comment to D22183: Add click to play/pause feature on previews for audio/video.

Is the triangle set? How about such a triangle:

https://www.netclipart.com/pp/m/120-1201455_play-button-png-video-youtube-youtube-video-play.png

I can imagine that it can be discerned better due to the dark background casted on the image preview within the outer white ring.
For Breeze Dark, the colors could become inverted.

Aug 25 2019, 8:50 AM · Dolphin

Aug 24 2019

alexde added a comment to D23389: Use visible buttons to switch the default device.

for various technical reasons that are not yet fixable

Aug 24 2019, 6:49 PM · Plasma
alexde added a comment to D23389: Use visible buttons to switch the default device.

DnD is not very intuitive for things that don't look inherently draggable

Aug 24 2019, 6:31 PM · Plasma
alexde added a comment to D23389: Use visible buttons to switch the default device.

Just brainstorming: What about two sections, 1) "default" with a single entry and 2) "others".
The user could drag and drop the speaker to default place and the current default one would move downwards with an animation.

Aug 24 2019, 6:26 PM · Plasma