What do you think about placing the button on the top next to the search?

Not sure, if this is part of the scope of this work, but do you also plan to add some meaningful labels and ticks to the axis?

Here's another inspiration for the app drawer: Instead of text, optionally symbols could be displayed for the app categories:

In T11520#203511, @chempfling wrote:

• Alt + XXX combinations are used for the menu bar of the current application

An impressive job!

In T12068#223749, @alex-l wrote:

In my mockups there is already less dimming than in current implementation, I think that is already a good middle ground

For inspiration: I think Piper handles the key mapping pretty:

In T12068#223671, @niccolove wrote:

In T12068#223657, @alex-l wrote:

If you need some inspiration:

Those look awesome!

In D27544#622272, @ngraham wrote:

(...) there has to be a way to (...) label everything properly etc.

Does this patch also fix indirectly #274629?

In D27198#607110, @ngraham wrote:

I tried 1.4 but it looked a bit too small to me, and not sufficiently differentiated from the level 2 and 3 headings in content areas:

Looks way better, thanks Nate!

In T10470#219347, @gvgeo wrote:

Something like this?

In T12631#219569, @ndavis wrote:

+1 to this. It's a bit hard for me to get a proper perspective from the screenshots though since you appear to be using fractional scaling.

I unfortunately no longer have time for this.

In D15418#604200, @broulik wrote:

Can't we dim label instead?

I quite like that. Also not very obvious what it means, I guess..

In T10470#219124, @gvgeo wrote:

Network manager doesn't really fit visually with the other applets. How about slim it down too?

In D26914#601922, @ngraham wrote:

Wow, this radically improves the appearance of resizing Dolphin! Very nice.

! In T12420#215327, @KonqiDragon wrote:
I think it would be a good idea to add a background in message area like in Telegram.

Have you had a look at the KDE based NX desktop? I just stumbled over the screenshots they posted in their announcemet of about teaming up with Manjaro:

UI-wise, this would probably be better off as a button than a checkbox.

Personally, I'm more inclined to a checkbox. Why is "turn wifi on/off" not an action? Right now, I don't see the big difference.

In D21273#586877, @luc4 wrote:

Probably the consequence of not reviewing changes? This one can probably be abandoned.

This patch looks pretty similar to the already merged one https://phabricator.kde.org/D25018. How are they related?

Re-adding the "Contacts" text Seems like a simple thing but pretty much every kirigami app has a title so removing it makes it less consistent

In T12434#215375, @jbbgameich wrote:

Do you think this changes already make kaidan look more similar to your mockups?

Independetly of the modifier keys Meta + or Alt + Ctrl + , why don't we assign both ASWD and the arrow keys ←↑↓→ to move between the VDs?
There's probably a global alternative for a reason and I don't see any other action to be assigned to one of those in the near future. That way both parties would be happy.
If a user requires one of those hotkeys for a different action, it can still be changed individually.

Since the most common problem that people have is "the OSD gets in the way when I change the volume while playing a video", how about only changing those OSD styles for the "volume" and "brightness" and leave the rest as it is with their characteristic appearance and visual distinctiveness?

Personally I am in favour of the current Windows 10 style, a compact version in the top left corner. I tried to to create a mockup to demonstrate how it could look like:

Can you please post a screenshot/mockup with several tabs + splitscreen + tree view for both the bright and the dark version?
I'd like to know how it looks like with your new design as the tabs are now above the bread crumbs.

I'd like to also suggest the Qt VoIP project Mumble (https://github.com/mumble-voip/mumble, https://www.mumble.info/). It would be interesting to have it in the portfolio. It uses a BSD license, though.

GoldenCheetah, https://github.com/GoldenCheetah/GoldenCheetah ("Performance Software for Cyclists, Runners and Triathletes").
Stellarium, https://github.com/Stellarium/stellarium However, competes with KStars probably.

In T9142#188117, @ognarb wrote:

For the Plasma 5.16 release:

• https://userbase.kde.org/Plasma

Do I understand it correctly, that Activities are in principle sets of desktop Widgets and backgrounds?

In D25018#561268, @jjorge wrote:

Are states > 100 or < 0 really well defined? Is it save to assume that a state > 100 can be associated with 100?

Yes : this is a percentage. States out of this value are bad hardware : I have a travel battery which shows crazy values along time, from 0,001Wh capacity till 901Wh (Real capacity is near 45Wh).

So, one needed thing ultimately is to extend libinput to reach feature parity with xf86-input-wacom. I know this is not directly part of plasma dev, but this had to be said, and I hope we can get good communication with libinput devs to move forward on that topic.

X files (Y hidden) can be misleading if X >> Y, for example 240 files (3 hidden) could be interpreted as there are 240 files from which 3 are hidden.
Maybe a X files + Y hidden is more obvious.

As this it not in the scope of this patch, those values look suspicious to me too:

switch(model.battery.type) {
case 3: return i18n("Internal battery")
case 2: return i18n("UPS battery")
case 9: return i18n("Monitor battery")
case 4: return i18n("Mouse battery")
case 5: return i18n("Keyboard battery")
case 1: return i18n("PDA battery")
case 7: return i18n("Phone battery")
default: return i18n("Unknown battery")

Is there a special reason for the weired order? Is it correct that case 0 and 6 are missing and default to unknown? Maybe (I haven't looked deeper into it) this needs another patch.

The next loop starts with index+1. This rare case with index out of bounds should not happen, but just in case ...

This range check should definitely be included. The other error, I don't know right away. If no one else spots it, I will check it on the weekend.

Add range check for index variable

In D24036#533557, @ngraham wrote:

I still get:

file:///home/nate/kde/usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/Graph.qml:114: TypeError: Cannot read property 'x' of undefined
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/Graph.qml:114: TypeError: Cannot read property 'x' of undefined

I have spotted a mistake, it should have been something like this with floor:

https://phabricator.kde.org/D24029

Oh, need to rebase, I guess. :-)

Remove redundant and now wrong comment

Fix offset calculation for the one hour graph

In D23520#531168, @ngraham wrote:

Thanks, that's fixed now. However the "Last hour" graph still looks a little odd...

Fix typo in variable and by that make all X axis labels appear again.