- User Since
- Oct 7 2018, 3:42 PM (50 w, 1 h)
Tue, Sep 17
The next loop starts with index+1. This rare case with index out of bounds should not happen, but just in case ...
This range check should definitely be included. The other error, I don't know right away. If no one else spots it, I will check it on the weekend.
Add range check for index variable
I have spotted a mistake, it should have been something like this with floor:
Oh, need to rebase, I guess. :-)
Sat, Sep 14
Remove redundant and now wrong comment
Fix offset calculation for the one hour graph
Fix typo in variable and by that make all X axis labels appear again.
The former scaling of the x-Positions of the data points did not fit to the time axis.
Now the x-values of the points, i. e. their timestamps, are correctly aligned.
Remove redundant semicolons and move comment about unit (ms) to the declaration of the var
Use a switch statement for xTicksAt
Tue, Sep 10
Mon, Sep 9
*Friendly ping to the reviewers.*
Sun, Sep 8
I think I should exclude the headlines in a following patch.
Thu, Sep 5
Set correct right border for the grid lines and ticks.
Move stroke() out of the loop.
Reduce line with by pixel.
Shrink plotWidth a little bit so the earliest date on the right side may fit.
Change the way the division widths are defined to hopefully make the code easier to understand
and to maintain.
For some reason the xGridOffset seems sometimes to be wrong, and I have no explanation why. It especially happens for 1 hour graphs.
I have changed some stuff, can you please review it again.
Rename variables to make their function clearer.
Decrease the lower loop border by 1 to make sure that all
possible grid lines are drawn.
Fix issue that a date may be displayed unintentionally.
Shrink right margin for grid lines and try to add an additional grid line
on the right side if reasonable.
Add more divisions for 2h and 24h graphs.
Use dashed grid lines instead of solid lines. Grid lines with tick labels are less faint.
Rename variable to make its function clearer.
Show grid lines at all five minutes for the 1 hour graph.
Align grid to 10 minutes for the 1h graph.
Tue, Sep 3
Set valid defaults.
- Set valid defaults.
16px: add 2px margins to top and bottom
22px: add 3px margins to top and bottom
32px: use existing and approved 32px icon as template instead of shrinking the 64px version
Mon, Sep 2
Remove all circles and only use root symbol.
This makes the root symbol less faint and the icons fit better to Breeze overall.
Fri, Aug 30
Thu, Aug 29
The 16 and 22 px versions aren't supposed to have backgrounds and the root symbols are pretty faint.
Add new 32px icons.
Also add the new 64px breeze icon.
Add new 22 px icons. Transparent background, less faint, original color.
Improve the root logo layout and change the root's color to the offical color 1ED4E5
Right now I only display the date under the tick mark if the date has changed and the tickmark number is odd, which I think is already good enough for this graph.
However, indicating a date change at midnight (12 pm / 0 am) would make sense as well. If you prefer that and find a suitable position for the indicator label, I may implemement it.
Fix displaying wrong variable.
Add postfix "Str" to indicate that those vars are explicitely strings.
Make sure that the date is only displayed when date has changed for <= 24h graphs.
Wed, Aug 28
Improve the formatting's consistancy
Omit the date if date equals today and the graph does not range over 24 hours.
Resolve formatting issues
I am not sure if I am allowed to intervene in this discussion, but "smart" is a really "dumb" description as it says nothing about what it actually does.
As a user I am left to do four things to find out, what it means:
Set more sane left/right margins
Set correct default value for a tick position
Mon, Aug 26
Sorry, for some reason it was easier for me to abandon this revision and to reopen another one here: https://phabricator.kde.org/D23464
Here's a testfile for the defined mime type:
Sun, Aug 25
For some reason if I try to set the icons for ".root" files, they are shown in the dialog box, the icon can be set, but they are not shown in Dolphin. Has anyone an idea what I am doing wrong?
I am not against a better version, but the culprit is that I am no designer.
For anything more complicated we would need an icon/svg.
Is the triangle set? How about such a triangle:
I can imagine that it can be discerned better due to the dark background casted on the image preview within the outer white ring.
For Breeze Dark, the colors could become inverted.
Sat, Aug 24
for various technical reasons that are not yet fixable
DnD is not very intuitive for things that don't look inherently draggable
Just brainstorming: What about two sections, 1) "default" with a single entry and 2) "others".
The user could drag and drop the speaker to default place and the current default one would move downwards with an animation.
Aug 19 2019
In which GUI do I find "Vendor" and "Model" now? There's the "Energy Information" in KInfocenter, which
has a section "manufacturer" (in screenshot "Hersteller"), but only lists the serial number. Maby it could go there?
Aug 16 2019
Jul 28 2019
Friendly ping. :-)