luc4 (Luca Carlon)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jul 4 2017, 10:16 AM (123 w, 2 d)
Availability
Available

Recent Activity

Sep 8 2019

luc4 added a comment to D21273: Add support for newer linux kernel power_supply API.

Ping.

Sep 8 2019, 10:29 PM · Plasma

Sep 7 2019

luc4 added a comment to D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu..

Sorry but someone will have to also commit for me, I don't have commit access.
Thanks!

Sep 7 2019, 3:22 PM · Plasma
luc4 added a comment to D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu..

Ping.

Sep 7 2019, 1:27 PM · Plasma

Aug 26 2019

luc4 updated the diff for D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu..

Updated according to requests.

Aug 26 2019, 6:11 PM · Plasma
luc4 added a comment to D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu..

Could you update the title and summary so they reflect what's in the patch now?

This isn't done (or at least phabricator is being unhelpful and not showing it if you have)

Aug 26 2019, 10:42 AM · Plasma

Aug 24 2019

luc4 added a comment to D21470: Properly read stderr when data is ready from the daemon..

Ping.

Aug 24 2019, 1:02 PM · Plasma
luc4 added a comment to D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu..

Anyone?

Aug 24 2019, 8:46 AM · Plasma

Aug 16 2019

luc4 added a comment to D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu..

Ping.

Aug 16 2019, 9:45 AM · Plasma

Aug 7 2019

luc4 retitled D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu. from Add a button to the notes applet to clear formatting to In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu..
Aug 7 2019, 1:05 AM · Plasma
luc4 updated the diff for D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu..

I updated the TextArea element to QtQuickControls 2 (this may not be necessary) and I added a menu with a look more consistent with the rest of Plasma. The menu includes the same actions we had before: undo, redo, copy, cut, paste, delete, clear and select all. In addition, I added a new paste action (now the default paste action), which pastes without formatting. Also, I set the shortcut to remove formatting before pasting.

Aug 7 2019, 12:29 AM · Plasma

Aug 4 2019

luc4 added a comment to D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu..

Hello, I'm not a Plasma expert, but I tried to investigate the situation a bit in Qt and plasma-framework. My understanding is that the notes applet is using TextArea from QtQuick.Controls 1. TextArea 1 creates an edit menu inside Qt, probably the one defined in EditMenu_base.qml. I see it is probably possible to replace this. Not sure if this can be modified, it is not public.

Aug 4 2019, 2:03 PM · Plasma

Aug 1 2019

luc4 added a comment to D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu..

Also notice that the current aspect doesn't look good nor consistent with the rest of Plasma.
In my researches I found this: https://git.reviewboard.kde.org/r/121698/diff/1/#, which is a bit what I'm doing. I'll stop with this until an agreement is found.

Aug 1 2019, 10:13 PM · Plasma
luc4 added a comment to D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu..

I started to reimplement the menu. This is how it looked for me:

Aug 1 2019, 9:01 PM · Plasma

Jul 28 2019

luc4 added a comment to D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu..

I had a look at the code. It is my understanding the menu is provided by Qt and it is probably styled somewhere. Is this correct? I can't find a way to modify it, so I guess I'll have to create an entirely new menu. Before I go on, can someone maybe confirm if I'm on the right track? Thanks!

Jul 28 2019, 10:12 AM · Plasma

Jul 27 2019

luc4 added a comment to D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu..

I'll try to implement that behavior then.

Jul 27 2019, 10:32 PM · Plasma
luc4 added a comment to D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu..

Yes, I couldn't find a better icon so I temporarily used this.

Jul 27 2019, 4:39 PM · Plasma
luc4 requested review of D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu..
Jul 27 2019, 10:56 AM · Plasma

Jul 24 2019

luc4 added a comment to D22306: Do not skip code launching application in application dashboard.

I do not have commit access, can someone do it for me? Thank you guys for your help!

Jul 24 2019, 5:23 PM · Plasma
luc4 updated the diff for D22306: Do not skip code launching application in application dashboard.

Updated to respect code conventions.

Jul 24 2019, 4:31 PM · Plasma

Jul 22 2019

luc4 updated the diff for D22306: Do not skip code launching application in application dashboard.

Removed volatile modifier, not probably useful in that context.

Jul 22 2019, 6:19 PM · Plasma

Jul 21 2019

luc4 updated the diff for D22306: Do not skip code launching application in application dashboard.

This is another implementation that follows the same principle of the previous ones, but moves the responsibility of maintaining the state to the dragHelper object. This requires to postpone the reset of the state after the onRelease event.

Jul 21 2019, 9:12 AM · Plasma

Jul 18 2019

luc4 added a comment to D22306: Do not skip code launching application in application dashboard.

Hello! Thank you for your help! I can see the logs now.
Unfortunately I cannot update my patch according to your notes. According to the logs I added, I do not see values that I wouldn't expect. Can you describe somehow how to reproduce the behavior you reported?
Thanks.

Jul 18 2019, 11:01 PM · Plasma
luc4 updated the diff for D22306: Do not skip code launching application in application dashboard.
Jul 18 2019, 6:02 PM · Plasma

Jul 17 2019

luc4 added a comment to D22306: Do not skip code launching application in application dashboard.

Unfortunately I'm not able to get logs from plasma-desktop. Can someone explain how (assuming this is possible) to write logs in this portion of code and read? Or can you point me to docs? I tried to add console.log calls and read using journalctl but I don't see the logs. Can someone help so I can check the values of those variables? Thanks.

Jul 17 2019, 11:19 AM · Plasma

Jul 7 2019

luc4 added a reviewer for D22306: Do not skip code launching application in application dashboard: trmdi.
Jul 7 2019, 1:11 PM · Plasma
luc4 requested review of D22306: Do not skip code launching application in application dashboard.
Jul 7 2019, 12:57 PM · Plasma

May 28 2019

luc4 requested review of D21470: Properly read stderr when data is ready from the daemon..
May 28 2019, 9:20 PM · Plasma

May 19 2019

luc4 retitled D21273: Add support for newer linux kernel power_supply API from Add support for newer linux kernel power_supply API. Keep backwardcompatibility with older procfs API. to Add support for newer linux kernel power_supply API.
May 19 2019, 11:46 AM · Plasma

May 18 2019

luc4 updated the summary of D21273: Add support for newer linux kernel power_supply API.
May 18 2019, 2:18 PM · Plasma
luc4 added a reviewer for D21273: Add support for newer linux kernel power_supply API: davidedmundson.
May 18 2019, 2:17 PM · Plasma
luc4 requested review of D21273: Add support for newer linux kernel power_supply API.
May 18 2019, 2:09 PM · Plasma

Apr 8 2019

luc4 added a comment to D20123: Do not assume framebuffer and scalines are always 32-bit aligned.

Not sure if you already did, but I guess someone will also have to push this to git, sorry.

Apr 8 2019, 7:31 PM

Mar 31 2019

luc4 added a comment to D20123: Do not assume framebuffer and scalines are always 32-bit aligned.

Yes, all three seem correct. I tested with a couple of resolutions. Server for the test was installed on a Raspberry Pi. It would be interesting to test also with other servers.

Mar 31 2019, 12:26 PM

Mar 30 2019

luc4 requested review of D20123: Do not assume framebuffer and scalines are always 32-bit aligned.
Mar 30 2019, 1:57 PM
luc4 added a comment to D20118: Pass va_list as such, instead of passing to variadic function.

Should I add someone else as reviewer (sorry, I'm not an experience KDE dev)?

Mar 30 2019, 10:54 AM
luc4 added a reviewer for D20118: Pass va_list as such, instead of passing to variadic function: uwolfer.
Mar 30 2019, 8:09 AM
luc4 requested review of D20118: Pass va_list as such, instead of passing to variadic function.
Mar 30 2019, 1:05 AM

Mar 24 2019

luc4 added a comment to D19931: Explicitly set charset to UTF-8.

Thank you: "Luca Carlon <carlon.luca@gmail.com>".

Mar 24 2019, 3:10 PM · Plasma

Mar 23 2019

luc4 added a comment to D19931: Explicitly set charset to UTF-8.

Should I do something else or will someone else take care of committing?

Mar 23 2019, 2:20 PM · Plasma

Mar 22 2019

luc4 added a comment to D19931: Explicitly set charset to UTF-8.

Hello. No, sorry, I don't think I have it.

Mar 22 2019, 11:41 AM · Plasma

Mar 21 2019

luc4 requested review of D19958: Include QIcon header to fully declare type..
Mar 21 2019, 11:23 PM · Simon
luc4 added a comment to D19931: Explicitly set charset to UTF-8.

I added the explicit charset to all scss files.

Mar 21 2019, 10:23 PM · Plasma
luc4 updated the diff for D19931: Explicitly set charset to UTF-8.
Mar 21 2019, 10:23 PM · Plasma
luc4 added a comment to D19931: Explicitly set charset to UTF-8.

Happened on KDE Neon in docker.

Mar 21 2019, 6:30 AM · Plasma

Mar 20 2019

luc4 added a reviewer for D19931: Explicitly set charset to UTF-8: gepardo.
Mar 20 2019, 11:27 PM · Plasma
luc4 requested review of D19931: Explicitly set charset to UTF-8.
Mar 20 2019, 11:22 PM · Plasma

Aug 20 2018

luc4 abandoned D14921: Fix compilation error when removing file in test.
Aug 20 2018, 9:05 PM · Gwenview

Aug 18 2018

luc4 requested review of D14921: Fix compilation error when removing file in test.
Aug 18 2018, 5:38 PM · Gwenview

Aug 9 2018

luc4 updated the summary of D14457: Forward-declare X509 structure.
Aug 9 2018, 2:19 PM · Frameworks
luc4 added a comment to D14457: Forward-declare X509 structure.

When QT_NO_OPENSSL is defined, I see that X509 was declared as a class, so I used the same instruction.
In ksslconfig.h I have #define KSSL_HAVE_SSL 0. I don't know if I can recovery much more output, the build succeeded days ago.
Unfortunately I'm not an expert of this section, but I see that libssl-dev is not installed. Maybe that made find() fail?
In any case, if that dep is optional, I guess the build is not supposed to fail, is it?

Aug 9 2018, 11:40 AM · Frameworks
luc4 added a comment to D14457: Forward-declare X509 structure.

Unfortunately it would take some time to determine what changed that made this mandatory for me. Maybe some header changed in the hierarchy and the declaration is no more included anymore? Anyway, I cannot build it without declaring it. I'm building in docker using kdeneon/plasma:dev-unstable.

Aug 9 2018, 10:16 AM · Frameworks
luc4 updated the summary of D14457: Forward-declare X509 structure.
Aug 9 2018, 10:09 AM · Frameworks

Jul 29 2018

luc4 updated the summary of D14457: Forward-declare X509 structure.
Jul 29 2018, 9:23 PM · Frameworks
luc4 requested review of D14457: Forward-declare X509 structure.
Jul 29 2018, 1:41 PM · Frameworks