Details
- Reviewers
- None
- Group Reviewers
VDG
Diff Detail
- Repository
- R244 KCoreAddons
- Branch
- ROOT (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 15659 Build 15677: arc lint + arc unit
The idea is good, but it should be proposed to shared-mime-info repository instead. As far as I remember from the previous discussions, this file is meant to contain a limited number of entities and possibiy disappear over time.
Thank you for your answers. Due to lack of experience and limited amount of time on my side, can you please guide, how I accomplish this surely trivial task?
Do I only need to open a modified PR against https://gitlab.freedesktop.org/xdg/shared-mime-info/blob/master/freedesktop.org.xml.in?
If I got it right, it should look like this:
<mime-type type="application/x-root"> <_comment>ROOT</_comment> <sub-class-of type="application/octet-stream"/> <magic priority="80"> <match value="root" type="string" offset="0"/> <match value ="TFile" type="string" offset="177"/> </magic> <glob pattern="*.root"/> </mime-type>
After that I can abandon this merge request again here? Do I need to change the naming of the icons again, which I commited today or do I need to submit them to freedesktop as well? :-)
Yes. The maintainers of shared-mime-info will tell you if the type is right (I think, that it would be better to use <mime-type type="application/root">, similar to PDF, but I might be wrong).
After that I can abandon this merge request again here?
If the MR on freedesktop will be merged, yes.
Do I need to change the naming of the icons again, [[ https://phabricator.kde.org/D23464 | which I commited today ]] or do I need to submit them to freedesktop as well? :-)
It depends on what type will be recommended by shared-mime-info maintainers. No, there is no sense to submit icons to shared-mime-info. The icons should be reviewed here by our VDG team but their names should be chosen according to the type in shared-mime-info package.