Newer kernel versions seem not to provide battery data in procfs. I added the implementation to read from the newer power supply class, while keeping the older implementation working.
Details
Details
Diff Detail
Diff Detail
- Repository
- R106 KSysguard
- Branch
- batt
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 11927 Build 11945: arc lint + arc unit
Comment Actions
Hm, looks ideologically similar to how it was done in SDL2...
https://hg.libsdl.org/SDL/file/792c26401463/src/power/linux/SDL_syspower.c
Comment Actions
Thank you @luc4 for pinging again
I have tested it, it works nicely, apparently the code you are replacing has not been working for a while.
The code looks good to me.
I would be great to have a second opinion though from more .
Comment Actions
This patch looks pretty similar to the already merged one https://phabricator.kde.org/D25018. How are they related?
Comment Actions
Probably the consequence of not reviewing changes? This one can probably be abandoned.
Comment Actions
What a shame! As you are familiar with the code, you could probably review the other patch too and see if it there's space for improvements, which probably your patch already coveres. :)
Comment Actions
I don't see why, it was proposed after mine and it is already merged... Does not seem to need a review.
Thanks for answering though.