- User Since
- Sep 14 2018, 11:24 AM (35 w, 4 d)
Thu, May 2
Given the time, four members is perfect to me.
Some VDG members expressed the expressed the will to partecipate. Since whoever proposes a wallpaper should not also be a judge, it was proposed to create a jury from the VDG that will not partecipate in the contest. If they are avaiable some jury member who were proposed are Andy and @ngraham. Also, @flipwise and @GB_2 also said they would be avaiable to be member of it.
Mar 30 2019
Mar 18 2019
Thank you so much for the detailed answer. I was able to do [1,2,4,5].
Unfortunately, I do not understand how to add margin in elements in . I tried to use anchor-based margin, but I see that in some files anchor is not used at all, and where it is used, the margin won't affect the appareance at all. I'm sorry to disturb you again, but may I ask you what the correct approach would be here?
Mar 9 2019
The dock has a real margin, meaning that interactions (/mouse clicks and hovers) made between the panel and the screen border are not be managed by latte, and an auto-hide panel will disappear if mouse is there. Approaching the edge with the mouse will show the autohidden dock anyway. Example:
Feb 28 2019
I personally feel like the most intuitive way is to create a KCM just for Layout, and then make the Look and Feel able to override those setting. In this way if you only want to change the layout you will change it in the Layout KCM, but Look and Feel would still be able to change the layout. If I recall correctly, that should be the same relationship between Look and Feel and Plasma Theme.
Feb 15 2019
Feb 13 2019
It seems like it landed. Please tell me if I screwed up anything.
Feb 12 2019
I do not have a developer account. I requested one some days ago with no answer yet.
Feb 4 2019
- fixed whitespace, sorry
- Made windows show even without export-pdf flag
Jan 31 2019
- Made window show on pdf print and removed trailing spaces
Jan 30 2019
- Removed connection between job and exiting; added todo
I have some doubts:
- Moved QString pdfFileName to KoApplicationPrivate
This solution is Qt <5.12 friendly
- Adding pdf filename as propriety of KoApplication
What have I Done:
- Added slots in KoApplication to handle pdf and print.
Jan 29 2019
- Removed unnecessary newlines
- Made slotFilePrint depend on signal loadCompleted to avoid it running before remote file being complete
Jan 26 2019
I'm not sure on how to do that, do you have any tip?
openDocumentInternal is called by openDocument, which is called in KoApplication just before checking the arguments. When it sees the print argument, it calls slotFilePrint. openDocumentInternal downloads the document in async. Should it be made not async, or is there another way to make it wait until the other process ends? Also, "slotLoadCanceled" is already implemented, or were you talking about something else?
Jan 23 2019
I tried differents files (locale and remote, opening and printing), and everything works okay. Other applications work normally, but calligrasheets still crashes when trying to print a remote (odt) file - but I can see the file is downloaded correctly, so it looks like a different problem (calligrasheets manages printing?).
About removing features from slotLoadCompleted, it is important to notice that it is only called by openDocumentInternal itself, so that should not be a problem.
I've seen that openDoumentInternal is called every time a remote document is used as input. I'm not sure if it's also used in different scenarios.
- Moving the if from slotLoadCompleted to openDocumentInternal.
At this point my only worry is that the setRootDocument in openDocumentInternal makes the check for opening a new window in slotLoadCompleted useless. Moving the whole if statement from slotLoadCompleted to openDocumentInternal also works, and could avoid to replace the root document instead of opening a new window. It makes more sense, now that I think of it.
Calligra was crashing because the method "slotFilePrint" called "rootView()" that tried to return the first elements of "d->rootViews". The problem is that such list was empitya, as SetRootDocument was never called: that method is called in openDocument but not in openDocumentInternal. I therefore added that function and it now works. But, when slotLoadCompleted is called (that is, after slotFilePrint), there's a check to open a new window if there's already a non-blank document. Since the root document was already set, it opened a new window with the same document. I therefore added the conditions of the two documents being different.
I hope I've been clear, this is one of my first commits here :-/
- Fixed typos
Jan 22 2019
Jan 21 2019
What about turning on by default the "Dim Inactive" Desktop Effect, maybe lighter?
Dec 19 2018
Dec 9 2018
Dec 4 2018
Related bug: https://bugs.kde.org/show_bug.cgi?id=399569
Deleted one of the two accidentally double-pasted xml content.