- User Since
- Sep 14 2018, 11:24 AM (22 w, 6 d)
Fri, Feb 15
Wed, Feb 13
It seems like it landed. Please tell me if I screwed up anything.
Tue, Feb 12
I do not have a developer account. I requested one some days ago with no answer yet.
Mon, Feb 4
- fixed whitespace, sorry
- Made windows show even without export-pdf flag
Thu, Jan 31
- Made window show on pdf print and removed trailing spaces
Wed, Jan 30
- Removed connection between job and exiting; added todo
I have some doubts:
- Moved QString pdfFileName to KoApplicationPrivate
This solution is Qt <5.12 friendly
- Adding pdf filename as propriety of KoApplication
What have I Done:
- Added slots in KoApplication to handle pdf and print.
Tue, Jan 29
- Removed unnecessary newlines
- Made slotFilePrint depend on signal loadCompleted to avoid it running before remote file being complete
Sat, Jan 26
I'm not sure on how to do that, do you have any tip?
openDocumentInternal is called by openDocument, which is called in KoApplication just before checking the arguments. When it sees the print argument, it calls slotFilePrint. openDocumentInternal downloads the document in async. Should it be made not async, or is there another way to make it wait until the other process ends? Also, "slotLoadCanceled" is already implemented, or were you talking about something else?
Wed, Jan 23
I tried differents files (locale and remote, opening and printing), and everything works okay. Other applications work normally, but calligrasheets still crashes when trying to print a remote (odt) file - but I can see the file is downloaded correctly, so it looks like a different problem (calligrasheets manages printing?).
About removing features from slotLoadCompleted, it is important to notice that it is only called by openDocumentInternal itself, so that should not be a problem.
I've seen that openDoumentInternal is called every time a remote document is used as input. I'm not sure if it's also used in different scenarios.
- Moving the if from slotLoadCompleted to openDocumentInternal.
At this point my only worry is that the setRootDocument in openDocumentInternal makes the check for opening a new window in slotLoadCompleted useless. Moving the whole if statement from slotLoadCompleted to openDocumentInternal also works, and could avoid to replace the root document instead of opening a new window. It makes more sense, now that I think of it.
Calligra was crashing because the method "slotFilePrint" called "rootView()" that tried to return the first elements of "d->rootViews". The problem is that such list was empitya, as SetRootDocument was never called: that method is called in openDocument but not in openDocumentInternal. I therefore added that function and it now works. But, when slotLoadCompleted is called (that is, after slotFilePrint), there's a check to open a new window if there's already a non-blank document. Since the root document was already set, it opened a new window with the same document. I therefore added the conditions of the two documents being different.
I hope I've been clear, this is one of my first commits here :-/
- Fixed typos
Jan 22 2019
Jan 21 2019
What about turning on by default the "Dim Inactive" Desktop Effect, maybe lighter?
Dec 19 2018
Dec 9 2018
Dec 4 2018
Related bug: https://bugs.kde.org/show_bug.cgi?id=399569
Deleted one of the two accidentally double-pasted xml content.