niccolove (Niccolò Venerandi)
Veggero

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Sep 14 2018, 11:24 AM (22 w, 6 d)
Availability
Available

Recent Activity

Fri, Feb 15

niccolove committed R8:5ae87d37a693: Replaced "distraction free" with "fullscreen" - BUG:378527 (authored by niccolove).
Replaced "distraction free" with "fullscreen" - BUG:378527
Fri, Feb 15, 2:31 PM
niccolove closed D18448: Replaced "distraction free" with "fullscreen" - BUG:378527.
Fri, Feb 15, 2:31 PM · Calligra: 3.0

Wed, Feb 13

niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

It seems like it landed. Please tell me if I screwed up anything.

Wed, Feb 13, 7:00 PM · Calligra: 3.0
niccolove committed R8:18bfd13a8020: Fixed calligra crashing when opening remote document (authored by niccolove).
Fixed calligra crashing when opening remote document
Wed, Feb 13, 6:57 PM
niccolove closed D18466: Fixed calligra crashing when opening remote document.
Wed, Feb 13, 6:57 PM · Calligra: 3.0
niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.

BUG:358581

Wed, Feb 13, 6:34 PM · Calligra: 3.0

Tue, Feb 12

niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

I do not have a developer account. I requested one some days ago with no answer yet.

Tue, Feb 12, 8:55 PM · Calligra: 3.0

Mon, Feb 4

niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • fixed whitespace, sorry
Mon, Feb 4, 12:04 PM · Calligra: 3.0
niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Made windows show even without export-pdf flag
Mon, Feb 4, 12:02 PM · Calligra: 3.0

Thu, Jan 31

niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Made window show on pdf print and removed trailing spaces
Thu, Jan 31, 11:35 AM · Calligra: 3.0

Wed, Jan 30

niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Removed connection between job and exiting; added todo
Wed, Jan 30, 2:39 PM · Calligra: 3.0
niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

I have some doubts:

Wed, Jan 30, 1:28 PM · Calligra: 3.0
niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Moved QString pdfFileName to KoApplicationPrivate
Wed, Jan 30, 12:59 PM · Calligra: 3.0
niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.
Wed, Jan 30, 12:49 PM · Calligra: 3.0
niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

This solution is Qt <5.12 friendly

Wed, Jan 30, 12:16 PM · Calligra: 3.0
niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Adding pdf filename as propriety of KoApplication
Wed, Jan 30, 12:15 PM · Calligra: 3.0
niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

What have I Done:

Wed, Jan 30, 9:56 AM · Calligra: 3.0
niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Added slots in KoApplication to handle pdf and print.
Wed, Jan 30, 9:38 AM · Calligra: 3.0

Tue, Jan 29

niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Removed unnecessary newlines
Tue, Jan 29, 9:59 PM · Calligra: 3.0
niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Made slotFilePrint depend on signal loadCompleted to avoid it running before remote file being complete
Tue, Jan 29, 9:58 PM · Calligra: 3.0

Sat, Jan 26

niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

I'm not sure on how to do that, do you have any tip?
openDocumentInternal is called by openDocument, which is called in KoApplication just before checking the arguments. When it sees the print argument, it calls slotFilePrint. openDocumentInternal downloads the document in async. Should it be made not async, or is there another way to make it wait until the other process ends? Also, "slotLoadCanceled" is already implemented, or were you talking about something else?

Sat, Jan 26, 5:13 PM · Calligra: 3.0

Wed, Jan 23

niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

I tried differents files (locale and remote, opening and printing), and everything works okay. Other applications work normally, but calligrasheets still crashes when trying to print a remote (odt) file - but I can see the file is downloaded correctly, so it looks like a different problem (calligrasheets manages printing?).
About removing features from slotLoadCompleted, it is important to notice that it is only called by openDocumentInternal itself, so that should not be a problem.

Wed, Jan 23, 1:31 PM · Calligra: 3.0
niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

I've seen that openDoumentInternal is called every time a remote document is used as input. I'm not sure if it's also used in different scenarios.

Wed, Jan 23, 1:19 PM · Calligra: 3.0
niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Moving the if from slotLoadCompleted to openDocumentInternal.
Wed, Jan 23, 1:16 PM · Calligra: 3.0
niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

At this point my only worry is that the setRootDocument in openDocumentInternal makes the check for opening a new window in slotLoadCompleted useless. Moving the whole if statement from slotLoadCompleted to openDocumentInternal also works, and could avoid to replace the root document instead of opening a new window. It makes more sense, now that I think of it.

Wed, Jan 23, 1:13 PM · Calligra: 3.0
niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

Sure.
Calligra was crashing because the method "slotFilePrint" called "rootView()" that tried to return the first elements of "d->rootViews". The problem is that such list was empitya, as SetRootDocument was never called: that method is called in openDocument but not in openDocumentInternal. I therefore added that function and it now works. But, when slotLoadCompleted is called (that is, after slotFilePrint), there's a check to open a new window if there's already a non-blank document. Since the root document was already set, it opened a new window with the same document. I therefore added the conditions of the two documents being different.
I hope I've been clear, this is one of my first commits here :-/

Wed, Jan 23, 1:07 PM · Calligra: 3.0
niccolove updated the test plan for D18466: Fixed calligra crashing when opening remote document.
Wed, Jan 23, 12:53 PM · Calligra: 3.0
niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Fixed typos
Wed, Jan 23, 12:52 PM · Calligra: 3.0
niccolove requested review of D18466: Fixed calligra crashing when opening remote document.
Wed, Jan 23, 12:49 PM · Calligra: 3.0

Jan 22 2019

niccolove retitled D18448: Replaced "distraction free" with "fullscreen" - BUG:378527 from Replaced "distraction free" with "fullscreen"BUG:378527 to Replaced "distraction free" with "fullscreen" - BUG:378527.
Jan 22 2019, 8:37 AM · Calligra: 3.0
niccolove retitled D18448: Replaced "distraction free" with "fullscreen" - BUG:378527 from Replaced "disturb free" with "fullscreen"BUG:378527 to Replaced "distraction free" with "fullscreen"BUG:378527.
Jan 22 2019, 8:36 AM · Calligra: 3.0
niccolove updated the summary of D18448: Replaced "distraction free" with "fullscreen" - BUG:378527.
Jan 22 2019, 8:36 AM · Calligra: 3.0
niccolove requested review of D18448: Replaced "distraction free" with "fullscreen" - BUG:378527.
Jan 22 2019, 8:36 AM · Calligra: 3.0

Jan 21 2019

niccolove added a comment to T10201: Window titlebar colors.

What about turning on by default the "Dim Inactive" Desktop Effect, maybe lighter?

Jan 21 2019, 5:38 PM · KDE Applications, VDG

Dec 19 2018

niccolove awarded M128: Plasma Sets a Love token.
Dec 19 2018, 11:52 AM

Dec 9 2018

niccolove updated the summary of D17352: Made descriptions for DEC2BIN/OCT2BIN/HEX2DEC/HEX2BIN mention input number system.
Dec 9 2018, 9:14 AM · Calligra: 3.0

Dec 4 2018

niccolove added a comment to D17352: Made descriptions for DEC2BIN/OCT2BIN/HEX2DEC/HEX2BIN mention input number system.

Related bug: https://bugs.kde.org/show_bug.cgi?id=399569

Dec 4 2018, 6:15 PM · Calligra: 3.0
niccolove updated the diff for D17352: Made descriptions for DEC2BIN/OCT2BIN/HEX2DEC/HEX2BIN mention input number system.

Deleted one of the two accidentally double-pasted xml content.

Dec 4 2018, 5:52 PM · Calligra: 3.0
niccolove requested review of D17352: Made descriptions for DEC2BIN/OCT2BIN/HEX2DEC/HEX2BIN mention input number system.
Dec 4 2018, 5:49 PM · Calligra: 3.0

Oct 10 2018

niccolove added a member for Bugsquad: niccolove.
Oct 10 2018, 2:34 PM