niccolove (Niccolò Venerandi)
Veggero

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Sep 14 2018, 11:24 AM (88 w, 5 d)
Availability
Available

Recent Activity

Mon, May 25

niccolove committed R108:e46d602c0b39: Update blur.cpp (authored by niccolove).
Update blur.cpp
Mon, May 25, 5:53 PM

Sat, May 23

niccolove committed R242:76575146bc98: Revert last commit (authored by niccolove).
Revert last commit
Sat, May 23, 6:24 PM
niccolove committed R242:e836a43e312f: Change position of flag set (authored by niccolove).
Change position of flag set
Sat, May 23, 4:07 PM
niccolove committed R108:a1c2ce7a6030: Remove left touch border by default (authored by niccolove).
Remove left touch border by default
Sat, May 23, 3:56 PM
niccolove added a comment to D27439: Replaced isDock check with !hasDecoration.

Moved and finished (now works) here: https://invent.kde.org/plasma/kwin/-/merge_requests/17

Sat, May 23, 2:32 PM · KWin

Fri, May 22

niccolove committed R108:3435ca3dfeb1: Expose transientFor and only blur underneath when transientParent is dock (authored by niccolove).
Expose transientFor and only blur underneath when transientParent is dock
Fri, May 22, 6:24 PM
niccolove committed R242:baa65aa1a2ce: Set type to Dialog in flags if type is Dialog::Normal (authored by niccolove).
Set type to Dialog in flags if type is Dialog::Normal
Fri, May 22, 4:29 PM

Thu, May 21

niccolove committed R120:b9f1d838de86: Remove useless double line (authored by niccolove).
Remove useless double line
Thu, May 21, 7:01 PM
niccolove committed R120:8452e5242910: Make system tray impossible to resize again (authored by niccolove).
Make system tray impossible to resize again
Thu, May 21, 6:59 PM
niccolove committed R120:3437a1e065ac: Update ExpandedRepresentation.qml (authored by niccolove).
Update ExpandedRepresentation.qml
Thu, May 21, 6:56 PM
niccolove committed R120:b3dc997250f0: Remove useless double line (authored by niccolove).
Remove useless double line
Thu, May 21, 6:56 PM
niccolove committed R120:6e73cf357d6c: Avoid system tray resizing (authored by niccolove).
Avoid system tray resizing
Thu, May 21, 6:56 PM
niccolove committed R120:d8ccda18652d: Update ExpandedRepresentation.qml (authored by niccolove).
Update ExpandedRepresentation.qml
Thu, May 21, 6:43 PM
niccolove committed R120:a4d76840ab24: Remove useless double line (authored by niccolove).
Remove useless double line
Thu, May 21, 1:19 PM
niccolove committed R120:a4d8f258b9c9: Avoid system tray resizing (authored by niccolove).
Avoid system tray resizing
Thu, May 21, 1:19 PM
niccolove committed R120:4b286d7ce6e0: Make system tray impossible to resize again (authored by niccolove).
Make system tray impossible to resize again
Thu, May 21, 1:08 PM
niccolove abandoned D29824: Avoid system tray resizing.
Thu, May 21, 12:50 PM · Plasma
niccolove added a comment to D29824: Avoid system tray resizing.

whops, this created a diff, not a MR

Thu, May 21, 12:49 PM · Plasma
niccolove requested review of D29824: Avoid system tray resizing.
Thu, May 21, 12:48 PM · Plasma
niccolove added a comment to D28627: Adaptive panel opacity.

Ping @davidedmundson ?

Thu, May 21, 7:33 AM · Plasma

Wed, May 20

niccolove added a comment to T13180: Make it easier to apply the wallpaper to the desktop(s), lock screen, and login screen all at once.

Strong +1

Wed, May 20, 2:04 PM · Plasma, VDG
niccolove added a comment to D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs.

I agree with a single KCM called wallpapers used to set all wallpaper in System Settings. Not a fan of having so many apply buttons, but I'm sure we can come up with something good.

Wed, May 20, 8:37 AM · Plasma
niccolove added a comment to D29263: Position OSD a bit farther down.

I'm a bit confused. Aren't we changing the size for third party global themes as well? Do all global themes set their size?

Wed, May 20, 6:10 AM · KWin

Tue, May 19

niccolove added a comment to D29263: Position OSD a bit farther down.

How do you think about putting it horizontally centered at the top of the screen? Maybe even avoiding panels, if possible?
I'd be fine both with "floating a bit under the panel" and "merged with screen/panel top" like krunner.

Tue, May 19, 8:55 PM · KWin
niccolove added a comment to D29263: Position OSD a bit farther down.

With the smaller appearance, I'm feeling a bit like it just floats there... for no reason... it gives me the impression than there's no visual connection with anything. It's a bit like it's in a random position, maybe because it's not vertically centered. Could be fine anyway, but I was wondering if there's another place where it would better fit. Maybe top left? Can it avoid panels?

Tue, May 19, 6:00 PM · KWin
niccolove accepted D20569: Use more compact OSD.
Tue, May 19, 5:53 PM · Plasma

Mon, May 18

niccolove added a comment to D29419: Improved Touch support.

Can confirm. Also, I'd make the tap and hold indicator a bit smaller, maybe half of the size it currently has :-)

I want to see the indicator under my finger, at the current size I can almost see it (maybe my fingers are too thick)

Mon, May 18, 9:40 AM · Dolphin

Sat, May 16

niccolove added a comment to D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs.

I'm a bit torn about this. It is indeed very nice, but at the same time I don't feel like it's the right solution. Ignoring minor complaints I'd have ("it's a very large button!") it doesn't feel right that the user, in order to change login wallpaper, would think that they have to right click on the desktop, click on edit desktop, click on "login and logout settings", and then change it. I think two other solutions that _might_ be better are:

  • Decide that login and lockscreen wallpapers are part of the desktop as much as the desktop wallpaper (which doesn't make sense tech-wise, but it might make sense user-wise), rename "Wallpaper" to "Desktop Wallpaper" in the Desktop Settings KCM and embed directly there "Lockscreen Wallpaper" and "Login screen theme". This would mean
    • Splitting the "Appearance" tab from the Screen Locking KCM to a new KCM called "Lockscreen Wallpaper" which would be in the customize desktop window, thus making the content of the Screen Locking KCM just the "activation tab", but adding a button "customize wallpaper..." which would open the "Lockscreen Wallpaper" KCM
    • Doing the same with the "Login Screen" KCM, which would be split in "Login Screen Theme" KCM (shown in customize desktop) and "Login Screen" KCM (shown in SySe) only containing what now is in the "Advanced" tab, but with a "Customize theme..." at the top. OR - probably better - have only one "Login Screen" KCM which only shows the theme selector and is both on the "customize desktop" and current location in system settings, and add "Advanced" as a button that open up a new kirigami page rather than using tabs.
    • All of which kinda feel ugly from a "let's categorize things based on how they work under the hood" point of view, but instead it could make sense from a "let's categorize things based on what the user expects" point of view.
  • OR, show the desktop configuration KCM is system settings, and somehow create a category there for wallpapers?
  • OR we just go with what you are proposing. I'm not against it, but I feel it's more of a "limiting damage" than a "let's fix the problem at the root"
Sat, May 16, 3:40 PM · Plasma
niccolove added a comment to D29419: Improved Touch support.

Can confirm. Also, I'd make the tap and hold indicator a bit smaller, maybe half of the size it currently has :-)

Sat, May 16, 1:34 PM · Dolphin

Thu, May 14

niccolove added a comment to D29419: Improved Touch support.

two fingers swipe gesture to left, right and up as shortcut to navigate back, forward and up

Thu, May 14, 6:04 PM · Dolphin
niccolove accepted D29732: Remove system tray and KPassivePopup.
Thu, May 14, 8:00 AM

Wed, May 13

niccolove added a comment to D29419: Improved Touch support.

Everything works for me, except two finger gestures

Wed, May 13, 8:50 PM · Dolphin
niccolove accepted D29730: Remove disabled Kontact integration.
Wed, May 13, 8:00 PM
niccolove added a comment to D28627: Adaptive panel opacity.

Actually -- this seems to no longer apply panel internal margins?

Works for me.

Wed, May 13, 7:15 PM · Plasma
niccolove accepted D29718: Refactor CMakeFiles.
Wed, May 13, 7:07 PM
niccolove accepted D29559: Remove obsolte and broken importer.
Wed, May 13, 7:06 PM
niccolove added a comment to T12839: Fix sizing of first-party plasmoids in the panel.

Should the icons increase by fixed value steps, or smoothly scale as the panel is resized?

Wed, May 13, 7:04 PM · Plasma, VDG, Goal: Consistency
niccolove committed R954:778e75dd164d: Fix http to https for veggero (authored by niccolove).
Fix http to https for veggero
Wed, May 13, 10:53 AM
niccolove committed R954:320d58d6daff: Merge branch 'master' into 'master' (authored by niccolove).
Merge branch 'master' into 'master'
Wed, May 13, 10:53 AM
niccolove committed R954:3ad0813a7b84: Add personal blog (authored by niccolove).
Add personal blog
Wed, May 13, 10:53 AM

Tue, May 12

niccolove added a comment to T13008: Figure out a good UI for the "show which settings have been changed" feature.

I'm not a great fan of button that will be - imo - hardly used by the average user in such a visible location. Also, it takes up some vertical space from the sidebar which isn't great.

Tue, May 12, 6:21 PM · Plasma, VDG
niccolove added a comment to D29264: New tabs for Breeze.

+1 for the direction!

Tue, May 12, 4:15 PM · VDG, Breeze, Plasma
niccolove committed R120:de52cb8944e8: Fix some alignments (authored by niccolove).
Fix some alignments
Tue, May 12, 7:15 AM
niccolove closed D29570: Fix some alignments.
Tue, May 12, 7:15 AM · Plasma

Mon, May 11

niccolove added a comment to T11791: Goal sprint: Consistency.

Ok, so.
What about a virtual sprint? Who's interested in joining in? It could be in late June / early July.

Mon, May 11, 3:43 PM · Goal: Consistency, KDE e.V., Goal Setting
niccolove added a comment to D29603: Adds custom spacing between task manager icons.

Are we really sure this is worth exposing to the user?

Mon, May 11, 12:57 PM · Plasma
niccolove added inline comments to D29570: Fix some alignments.
Mon, May 11, 12:54 PM · Plasma

Sat, May 9

niccolove added a comment to D29570: Fix some alignments.

For some reason, the heading is still one or two pixels off... still, much better than before

Sat, May 9, 6:13 PM · Plasma
niccolove added reviewers for D29570: Fix some alignments: VDG, Plasma.
Sat, May 9, 6:13 PM · Plasma
niccolove requested review of D29570: Fix some alignments.
Sat, May 9, 6:12 PM · Plasma
niccolove added a comment to D29501: Use left-aligned thickened panel with IOTM populated with some apps by default.

Generic +1 to the idea, but:

  • I would not go higher than 50 as panel width
  • The clock is too small, it probably needs a version where there's a new line between hour and minutes
  • We should check that all widgets work correctly in a vertical panel
Sat, May 9, 10:47 AM · Plasma

Thu, May 7

niccolove updated the test plan for D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly.
Thu, May 7, 7:58 PM · Frameworks
niccolove updated the test plan for D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly.
Thu, May 7, 7:57 PM · Frameworks
niccolove updated the test plan for D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly.
Thu, May 7, 7:57 PM · Frameworks
niccolove updated the test plan for D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly.
Thu, May 7, 7:55 PM · Frameworks
niccolove updated the test plan for D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly.
Thu, May 7, 5:47 PM · Frameworks

Wed, May 6

l10n daemon script <scripty@kde.org> committed R242:3018ebe579ed: Fix rounded borders (authored by niccolove).
Fix rounded borders
Wed, May 6, 10:31 PM
niccolove accepted D29081: [QStyle] Make menu titles look less like menu items.

VDG wise, this looks good and consistent.

Wed, May 6, 7:57 PM · Plasma
niccolove committed R242:1bc004e5c65f: Fix rounded borders (authored by niccolove).
Fix rounded borders
Wed, May 6, 7:47 PM
niccolove closed D29479: Fix rounded borders.
Wed, May 6, 7:47 PM · Frameworks
niccolove committed R120:571f0aba2fc5: This removes the negative top margin, as it's already removed by the… (authored by niccolove).
This removes the negative top margin, as it's already removed by the…
Wed, May 6, 7:36 PM
niccolove closed D29490: This removes the negative top margin, as it's already removed by the NotificationPopup.
Wed, May 6, 7:36 PM · Plasma
niccolove added inline comments to D29479: Fix rounded borders.
Wed, May 6, 7:36 PM · Frameworks
niccolove updated the diff for D29479: Fix rounded borders.

Round things up again

Wed, May 6, 6:26 PM · Frameworks
niccolove added a comment to D29479: Fix rounded borders.

Notifications don't use PlasmoidHeading

Wed, May 6, 6:14 PM · Frameworks
niccolove updated the diff for D29479: Fix rounded borders.

Address some feedback

Wed, May 6, 6:14 PM · Frameworks
niccolove updated the test plan for D29490: This removes the negative top margin, as it's already removed by the NotificationPopup.
Wed, May 6, 6:04 PM · Plasma
niccolove added a reviewer for D29490: This removes the negative top margin, as it's already removed by the NotificationPopup: Plasma.
Wed, May 6, 6:03 PM · Plasma
niccolove updated the test plan for D29490: This removes the negative top margin, as it's already removed by the NotificationPopup.
Wed, May 6, 6:03 PM · Plasma
niccolove requested review of D29490: This removes the negative top margin, as it's already removed by the NotificationPopup.
Wed, May 6, 6:02 PM · Plasma
niccolove committed R120:7e4b0979bbbb: Add inHistory bool and hide heading on inHistory (authored by niccolove).
Add inHistory bool and hide heading on inHistory
Wed, May 6, 6:01 PM
niccolove closed D29474: Add inHistory bool and hide heading on inHistory.
Wed, May 6, 6:01 PM · Plasma
niccolove updated the test plan for D29479: Fix rounded borders.
Wed, May 6, 11:17 AM · Frameworks
niccolove added a reviewer for D29479: Fix rounded borders: Plasma.
Wed, May 6, 11:13 AM · Frameworks
niccolove requested review of D29479: Fix rounded borders.
Wed, May 6, 11:12 AM · Frameworks
niccolove added a reviewer for D29474: Add inHistory bool and hide heading on inHistory: broulik.
Wed, May 6, 8:48 AM · Plasma
niccolove updated the test plan for D29474: Add inHistory bool and hide heading on inHistory.
Wed, May 6, 8:48 AM · Plasma
niccolove requested review of D29474: Add inHistory bool and hide heading on inHistory.
Wed, May 6, 8:48 AM · Plasma
niccolove committed R120:bf6b8353a73f: Fix various bugs introduced with heading (authored by niccolove).
Fix various bugs introduced with heading
Wed, May 6, 8:43 AM
niccolove closed D29234: Fix various bugs introduced with heading.
Wed, May 6, 8:43 AM · Plasma
niccolove updated the diff for D29234: Fix various bugs introduced with heading.

Remove inHistory change

Wed, May 6, 8:25 AM · Plasma
niccolove updated the summary of D29234: Fix various bugs introduced with heading.
Wed, May 6, 8:24 AM · Plasma
niccolove added a comment to D29234: Fix various bugs introduced with heading.

Sorry, I'll make a different patch for that

Wed, May 6, 8:24 AM · Plasma
niccolove updated the summary of D29234: Fix various bugs introduced with heading.
Wed, May 6, 8:23 AM · Plasma
niccolove requested review of D29234: Fix various bugs introduced with heading.

I added one last thing: I feel like it was not a good idea to show the heading in history for notifications that are not in group. I added a inHistory bool, false by default, that's set true in FullRepresentation for notifications that are in history. Heading is not shown for any notification in the history.

Wed, May 6, 8:22 AM · Plasma
niccolove updated the diff for D29234: Fix various bugs introduced with heading.

Address feedback and add inHistory bool

Wed, May 6, 8:20 AM · Plasma

Sun, May 3

niccolove updated the summary of D29234: Fix various bugs introduced with heading.
Sun, May 3, 11:44 AM · Plasma
niccolove updated the diff for D29234: Fix various bugs introduced with heading.

Fix very long application names

Sun, May 3, 11:43 AM · Plasma

Sat, May 2

niccolove awarded D12162: Add support for touch scrolling in Dolphin a Love token.
Sat, May 2, 9:21 PM · Dolphin
The-Feren-OS-Dev awarded T11093: Improve Consistency across the Board a Love token.
Sat, May 2, 8:16 PM · Goal: Consistency, Goal Setting 2019
niccolove updated the diff for D29234: Fix various bugs introduced with heading.

Fix very long notification titles

Sat, May 2, 5:46 PM · Plasma
niccolove planned changes to D29234: Fix various bugs introduced with heading.
Sat, May 2, 5:43 PM · Plasma
niccolove updated the summary of D29234: Fix various bugs introduced with heading.
Sat, May 2, 5:38 PM · Plasma
niccolove updated the diff for D29234: Fix various bugs introduced with heading.

Address feedback

Sat, May 2, 5:37 PM · Plasma
niccolove created T13074: Basket / KJots.
Sat, May 2, 5:28 PM
niccolove updated the diff for D29234: Fix various bugs introduced with heading.

Move lineSvg to root element

Sat, May 2, 10:03 AM · Plasma
niccolove updated the diff for D29234: Fix various bugs introduced with heading.

Fix visibility

Sat, May 2, 10:03 AM · Plasma
niccolove accepted D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme.

LGTM

Sat, May 2, 9:48 AM · Frameworks
niccolove planned changes to D29234: Fix various bugs introduced with heading.

Ah, there's a mistake on visibility, just a sec

Sat, May 2, 9:43 AM · Plasma
niccolove added a comment to D29234: Fix various bugs introduced with heading.

Keyboard navigation is now working again; however, pressing tab to focus buttons seem to no longer be possible after this patch; looking at the code, I'm given the impression that it was true before porting notifications to page as well. Is that correct, or should I investigate tabbing?

Sat, May 2, 9:36 AM · Plasma