Summary: Fix computing maximum range for y-values
AbandonedPublic

Authored by alexde on Sep 17 2019, 4:38 PM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Plasma
Summary

Rounding to the next 10 did not work if the maximum value was something like y_max = 30.947
In this case modulo 10 gives 0 and therefore the maximum values becomes 30 in the end, though it should be 40
otherwise the peak points outside of the chart.

Floor(max) + 10 always works.

Test Plan

Before:


After:

Diff Detail

Branch
y-scaling (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16690
Build 16708: arc lint + arc unit
alexde requested review of this revision.Sep 17 2019, 4:38 PM
alexde created this revision.
alexde retitled this revision from Summary: Fix scaling of Y-Values to Summary: Fix computing maximum range for y-values.Sep 17 2019, 4:39 PM
alexde edited the test plan for this revision. (Show Details)

Oh, need to rebase, I guess. :-)