Feed All Stories

Today

lueck committed R883:1525174: translation update.
translation update
Sun, Sep 23, 7:35 PM
lueck committed R883:1525173: translation update.
translation update
Sun, Sep 23, 7:35 PM
rjvbb added a comment to D15694: Make implicit fallthroughs a compiler error, remove unneeded breaks.
Can you explain in more detail how an unreachable `break` after a `return` statement makes the code more readable?
Sun, Sep 23, 7:33 PM · KDevelop
svuorela added inline comments to D15714: add a string suffix to test data and use for unicode testing of taglibwriter.
Sun, Sep 23, 7:25 PM · Baloo, Frameworks
svuorela added a comment to D15715: remove own implementation of QString to TString conversion for taglibwriter.

since I'm still unsure about those things: the q2t function was not declared static, but was never exported. It is still safe to remove, right?

Sun, Sep 23, 7:23 PM · Baloo, Frameworks
mqualmann committed R482:60644e76035a: uncheck checkbox to update filter before delete tag BUGS: 398986 FIXED-IN: 6.0.0 (authored by mqualmann).
uncheck checkbox to update filter before delete tag BUGS: 398986 FIXED-IN: 6.0.0
Sun, Sep 23, 7:22 PM
yurchor committed R340:b3ea9fba9719: Fix minor EBN issues (authored by yurchor).
Fix minor EBN issues
Sun, Sep 23, 7:20 PM
marten requested review of D15716: Suspicious use of signed arithmetic leads to negative index crash.
Sun, Sep 23, 7:13 PM
astippich abandoned D12639: remove sorting from sql queries.
Sun, Sep 23, 7:13 PM · Elisa
astippich added a comment to D12443: fix bitrate unit.

Gentle ping. It is only a change of a unit label after all :)

Sun, Sep 23, 7:13 PM · Baloo
mpyne committed R365:94c9beb3bf7e: sample-rc: Fix configure-based option name. (authored by mpyne).
sample-rc: Fix configure-based option name.
Sun, Sep 23, 7:07 PM
astippich added a dependency for D15715: remove own implementation of QString to TString conversion for taglibwriter: D15220: implement more basic tags for taglibwriter.
Sun, Sep 23, 7:07 PM · Baloo, Frameworks
astippich added a dependent revision for D15220: implement more basic tags for taglibwriter: D15715: remove own implementation of QString to TString conversion for taglibwriter.
Sun, Sep 23, 7:07 PM · Baloo, Frameworks
astippich added a comment to D15715: remove own implementation of QString to TString conversion for taglibwriter.

since I'm still unsure about those things: the q2t function was not declared static, but was never exported. It is still safe to remove, right?

Sun, Sep 23, 7:07 PM · Baloo, Frameworks
zzag added a comment to D15634: [WobblyWindows] Prevent hash table to grow significantly.

if you have suggest to watch some variable or container change?

Sun, Sep 23, 7:06 PM · KWin
astippich requested review of D15715: remove own implementation of QString to TString conversion for taglibwriter.
Sun, Sep 23, 7:05 PM · Baloo, Frameworks
astippich added inline comments to D15714: add a string suffix to test data and use for unicode testing of taglibwriter.
Sun, Sep 23, 7:03 PM · Baloo, Frameworks
astippich committed R286:4c760d4588f3: remove usage of own TString to QString conversion function (authored by astippich).
remove usage of own TString to QString conversion function
Sun, Sep 23, 7:00 PM
astippich closed D15614: remove usage of own TString to QString conversion function.
Sun, Sep 23, 7:00 PM · Baloo, Frameworks
astippich committed R286:26dcd784b45a: bump required taglib version to 1.11.1 (authored by astippich).
bump required taglib version to 1.11.1
Sun, Sep 23, 6:59 PM
astippich closed D15615: bump required taglib version to 1.11.1.
Sun, Sep 23, 6:59 PM · Baloo, Frameworks
lueck committed R883:1525172: translation update.
translation update
Sun, Sep 23, 6:59 PM
lueck committed R883:1525171: translation update.
translation update
Sun, Sep 23, 6:59 PM
rizzitello updated the diff for D15701: More Cleanup.
  • Tomaz's std::min suggetion
Sun, Sep 23, 6:59 PM · Atelier: AtCore
astippich retitled D15615: bump required taglib version to 1.11.1 from bump required taglib version to bump required taglib version to 1.11.1.
Sun, Sep 23, 6:59 PM · Baloo, Frameworks
svuorela added inline comments to D15714: add a string suffix to test data and use for unicode testing of taglibwriter.
Sun, Sep 23, 6:56 PM · Baloo, Frameworks
pino committed R883:1525170: new translation.
new translation
Sun, Sep 23, 6:53 PM
bruns added inline comments to D15714: add a string suffix to test data and use for unicode testing of taglibwriter.
Sun, Sep 23, 6:51 PM · Baloo, Frameworks
lueck committed R883:1525169: translation update.
translation update
Sun, Sep 23, 6:45 PM
IlyaBizyaev closed T9653: KDE Russia website as Resolved.
Sun, Sep 23, 6:45 PM · Websites
IlyaBizyaev updated the task description for T9653: KDE Russia website.
Sun, Sep 23, 6:45 PM · Websites
lueck committed R883:1525168: translation update.
translation update
Sun, Sep 23, 6:44 PM
lueck committed R883:1525167: translation update.
translation update
Sun, Sep 23, 6:44 PM
mludwig added a comment to D15711: Allow KXmlGui UI files to be found more easily.

I don't like qrc, are you saying that the only way kxmlgui works on MacOs is by not installing files?

This is weird since it seems to work just fine on Windows

Sun, Sep 23, 6:44 PM · Okular
zzag retitled D15514: [libbreezecommon] Use box blur instead of FFT blur from [libbreezecommon] Use box blur instead of FFT approach to [libbreezecommon] Use box blur instead of FFT blur.
Sun, Sep 23, 6:43 PM · Plasma
zzag added a comment to D15514: [libbreezecommon] Use box blur instead of FFT blur.

I would even say 'after' looks better, because the bottom shadow isn't as strong as 'before'.

Sun, Sep 23, 6:41 PM · Plasma
dantti committed R658:20d54acea93d: Fix kded metadata (authored by dantti).
Fix kded metadata
Sun, Sep 23, 6:40 PM
dantti committed R549:d55b1677cbf9: Fix apperd metadata (authored by dantti).
Fix apperd metadata
Sun, Sep 23, 6:37 PM
tbaumgart committed R933:7014f9ffd7c6: Added AppImage build status (authored by tbaumgart).
Added AppImage build status
Sun, Sep 23, 6:35 PM
anthonyfieroni added a comment to D15634: [WobblyWindows] Prevent hash table to grow significantly.

I run it with debug messages for a while, there is no leak in windows neither in stackingOrder. @zzag if you have suggest to watch some variable or container change? I can transform this review to some profiling changes, removing double lookups, const ref against copying of Pair and so on.

Sun, Sep 23, 6:31 PM · KWin
asemke committed R262:5cf27d9134c1: Create histograms in PlotDataDialog. (authored by asemke).
Create histograms in PlotDataDialog.
Sun, Sep 23, 6:29 PM
yurchor committed R340:40b817c8ec27: Fix i18n (authored by yurchor).
Fix i18n
Sun, Sep 23, 6:16 PM
zzag updated the summary of D15514: [libbreezecommon] Use box blur instead of FFT blur.
Sun, Sep 23, 6:11 PM · Plasma
aaronpuchert added a comment to D15694: Make implicit fallthroughs a compiler error, remove unneeded breaks.

As mentioned on another ticket, I don't like the idea of not putting breaks, no matter how clever the compiler and hard-coded choice of compiler options.

Sun, Sep 23, 6:04 PM · KDevelop
yurchor committed R341:f6ae93b60198: Fix minor EBN issues and minor porting for KStandardDirs, KInputDialog and… (authored by yurchor).
Fix minor EBN issues and minor porting for KStandardDirs, KInputDialog and…
Sun, Sep 23, 6:01 PM
svuorela added inline comments to D15714: add a string suffix to test data and use for unicode testing of taglibwriter.
Sun, Sep 23, 5:52 PM · Baloo, Frameworks
svuorela added a comment to D15704: increase test coverage of taglibwriter.

Looks good to me. A nice and simple way to drastically increase test coverage.

Sun, Sep 23, 5:49 PM · Baloo, Frameworks
vkrause committed R81:f57f6bf4e13a: Let ExtractorEngine pick the extractors (authored by vkrause).
Let ExtractorEngine pick the extractors
Sun, Sep 23, 5:44 PM
vkrause committed R1003:e556f9bff089: Extract UIC carrier codes (authored by vkrause).
Extract UIC carrier codes
Sun, Sep 23, 5:42 PM
vkrause committed R1003:f20f8063fb25: Parse the carrier code from UIC 918.3 ticket tokens (authored by vkrause).
Parse the carrier code from UIC 918.3 ticket tokens
Sun, Sep 23, 5:42 PM
astippich added a dependent revision for D15704: increase test coverage of taglibwriter: D15714: add a string suffix to test data and use for unicode testing of taglibwriter.
Sun, Sep 23, 5:40 PM · Baloo, Frameworks
astippich added a dependency for D15714: add a string suffix to test data and use for unicode testing of taglibwriter: D15704: increase test coverage of taglibwriter.
Sun, Sep 23, 5:40 PM · Baloo, Frameworks
astippich requested review of D15714: add a string suffix to test data and use for unicode testing of taglibwriter.
Sun, Sep 23, 5:39 PM · Baloo, Frameworks
aacid added a comment to D15711: Allow KXmlGui UI files to be found more easily.

I don't like qrc, are you saying that the only way kxmlgui works on MacOs is by not installing files?

Sun, Sep 23, 5:38 PM · Okular
rjvbb added a comment to D15694: Make implicit fallthroughs a compiler error, remove unneeded breaks.

As mentioned on another ticket, I don't like the idea of not putting breaks, no matter how clever the compiler and hard-coded choice of compiler options; I don't think you gain anything from it, and it doesn't improve code readability either for me (esp. when switch cases aren't indented w.r.t the switch context, as in the last hunk in plugins/qmljs/codecompletion/context.cpp.
Making it obligatory to add a token confirming that fallthrough is intended is a good idea, though using a largish term in all-caps like Q_FALLTHROUGH also doesn't improve readibilty. And what about the most common type of fallthrough, are we really going to have to write something like the following?

Sun, Sep 23, 5:31 PM · KDevelop
zzag added a comment to D14688: [libkwineffects] Expose getting/setting activeFullScript to scripted effects.

FYI, I ported the Minimize Animation effect to JavaScript (zzag/port-minimizeanimation-to-js branch). There are several obstacles:

  • checking whether there is a full screen effect;
  • reversing animation (easy to fix, but I think it will go only after ScriptedEffect is ported to QJSEngine).
Sun, Sep 23, 5:26 PM · KWin
zzag committed R108:2a6fcc9eba58: [effects] Re-implement the Minimize Animation effect in JavaScript (authored by zzag).
[effects] Re-implement the Minimize Animation effect in JavaScript
Sun, Sep 23, 5:21 PM
andrewgr added a comment to D15524: Cirkuit version 0.5.0.

Dear Luigi,
    I should inform you that I've been in touch with Andreas Sturnlechner (you were copied in) - who has pointed out that there is a KF5 version already. It's a pity I did not discover this earlier - but I am new to a number of the software tools, including GitHub.

Sun, Sep 23, 5:20 PM · Documentation
astippich updated the diff for D15704: increase test coverage of taglibwriter.
  • don't change test strings for now
Sun, Sep 23, 5:13 PM · Baloo, Frameworks
yurchor committed R370:8d09f513145b: Fix minor EBN issues (authored by yurchor).
Fix minor EBN issues
Sun, Sep 23, 5:13 PM
tcanabrava added inline comments to D15701: More Cleanup.
Sun, Sep 23, 5:12 PM · Atelier: AtCore
tcanabrava committed R319:99f233b9a155: Refactor Profile and ColorScheme (authored by tcanabrava).
Refactor Profile and ColorScheme
Sun, Sep 23, 5:07 PM
tcanabrava closed D13854: Refactor Profile and ColorScheme.
Sun, Sep 23, 5:07 PM · Konsole
tcanabrava added a comment to D13854: Refactor Profile and ColorScheme.

Sure.

Sun, Sep 23, 5:05 PM · Konsole
aaronpuchert updated the diff for D15694: Make implicit fallthroughs a compiler error, remove unneeded breaks.

Remove comment in plugins/ghprovider/ghproviderwidget.cpp, as the fallthrough is probably intended, and add break in plugins/qmljs/codecompletion/context.cpp, as it is probably not intended. Now the code completion doesn't suggest variables of the same type as the last parameter in functions calls, which seems about right.

Sun, Sep 23, 4:58 PM · KDevelop
vkrause committed R1007:240b38e2e10b: Let ExtractorEngine select custom extractors itself (authored by vkrause).
Let ExtractorEngine select custom extractors itself
Sun, Sep 23, 4:53 PM
vkrause committed R1018:39d7a6daa443: Let ExtractorEngine select custom extractors itself (authored by vkrause).
Let ExtractorEngine select custom extractors itself
Sun, Sep 23, 4:52 PM
yurchor committed R344:56358be70aa5: Fix minor EBN issues (authored by yurchor).
Fix minor EBN issues
Sun, Sep 23, 4:50 PM
scottpetrovic committed R37:f68be991f72a: Moved the scratchpad and presets list to the sides of the editor instead of… (authored by scottpetrovic).
Moved the scratchpad and presets list to the sides of the editor instead of…
Sun, Sep 23, 4:50 PM
scottpetrovic committed R37:16830d9e1310: make the brush preview larger (authored by scottpetrovic).
make the brush preview larger
Sun, Sep 23, 4:50 PM
vkrause committed R1003:03049271643b: Port custom extractor tests to the universal extractor test (authored by vkrause).
Port custom extractor tests to the universal extractor test
Sun, Sep 23, 4:47 PM
vkrause committed R1003:adb83e76f21f: Move custom extractor lookup into ExtractorEngine (authored by vkrause).
Move custom extractor lookup into ExtractorEngine
Sun, Sep 23, 4:47 PM
vkrause committed R1003:7a09916e7005: Adapt tests to new ExtractorEngine interface (authored by vkrause).
Adapt tests to new ExtractorEngine interface
Sun, Sep 23, 4:47 PM
vkrause committed R1003:6dba6871451b: Remove the Air France extractor (authored by vkrause).
Remove the Air France extractor
Sun, Sep 23, 4:47 PM
vkrause committed R1003:1d2d79c3541a: Allow to look up extractors by JSON-LD provider identifier (authored by vkrause).
Allow to look up extractors by JSON-LD provider identifier
Sun, Sep 23, 4:47 PM
vkrause committed R1003:3a7f4b9743d0: Initialize m_pass (authored by vkrause).
Initialize m_pass
Sun, Sep 23, 4:47 PM
vkrause committed R1003:7edaf0985ad6: Make ExtractorRepository cheap to create (authored by vkrause).
Make ExtractorRepository cheap to create
Sun, Sep 23, 4:47 PM
woltherav requested review of D15713: Extend the categories model with some extra items..
Sun, Sep 23, 4:43 PM · Peruse
aaronpuchert updated subscribers of D15694: Make implicit fallthroughs a compiler error, remove unneeded breaks.
Sun, Sep 23, 4:42 PM · KDevelop
pino requested changes to D15690: Removed old style casts.
Sun, Sep 23, 4:41 PM · KDE Edu
pino added a comment to D15690: Removed old style casts.
  • again, please do not mix unrelated changes, just submit separate and documented review for them
  • please follow a bit more the existing coding style
Sun, Sep 23, 4:41 PM · KDE Edu
smartins committed R74:c5f3df1e0997: Bump master to 1.5 (authored by smartins).
Bump master to 1.5
Sun, Sep 23, 4:25 PM
alvinhochun added a comment to D15585: Add openssl download and build step to krita.

This post [1] describes a way of building OpenSSL with mingw(-w64).

That's rather different from what's in the openssl readme itself :-(

Sun, Sep 23, 4:25 PM · Krita
smartins committed R74:57745c294974: Merge branch '1.4' (authored by smartins).
Merge branch '1.4'
Sun, Sep 23, 4:23 PM
smartins committed R74:6e0cf5c30e5a: Changelog: Add date of 1.4 release (authored by smartins).
Changelog: Add date of 1.4 release
Sun, Sep 23, 4:22 PM
smartins committed R74:bd44903073f5: README: Minimum LLVM for clazy 1.4 is now 4.0 (authored by smartins).
README: Minimum LLVM for clazy 1.4 is now 4.0
Sun, Sep 23, 4:22 PM
dvratil committed R241:7615e3405c30: Fix deletion of files from DAV (authored by dvratil).
Fix deletion of files from DAV
Sun, Sep 23, 4:17 PM
dvratil closed D15697: Fix deletion of files from DAV.
Sun, Sep 23, 4:17 PM · Frameworks
zzag requested review of D15712: [effects/blur] Add missing override keywords.
Sun, Sep 23, 4:15 PM · KWin
cgilles committed R482:af704e52f0c6: fix typo (authored by cgilles).
fix typo
Sun, Sep 23, 4:14 PM
carlos_hdc updated the diff for D15690: Removed old style casts.
  • Removed unnecessary casts
  • Altered dynamic to static cast
  • Changed variables from uint to int type
  • Removed casts
Sun, Sep 23, 4:14 PM · KDE Edu
smartins committed R74:e72a6f69af4a: tests: Fixes usages of minimum_qt_version (authored by smartins).
tests: Fixes usages of minimum_qt_version
Sun, Sep 23, 4:12 PM
yurchor added a comment to D15355: Port KolourPaint away from deprecated KFileDialog.

- Current version of the "Save file" dialog
- Ported (non-native) dialog

Sun, Sep 23, 4:08 PM
rjvbb added a comment to D15530: kdev-clang : somewhat more complete ObjC(++) support.

Doesn't KDevelop already add (install) a few mimetypes of its own? I think I mentioned before that I do have a .xml file for SMI, adding the x-objc++src definition and I presume that's why I am not seeing mimetype warnings about ObC (I'm seeing others though.)

Sun, Sep 23, 3:59 PM · KDevelop
smartins committed R74:086486269701: docker: Add ubuntu-18.04 (authored by smartins).
docker: Add ubuntu-18.04
Sun, Sep 23, 3:52 PM
smartins committed R74:5c5111eb59ee: README: Remove reference to ubuntu's version (authored by smartins).
README: Remove reference to ubuntu's version
Sun, Sep 23, 3:52 PM
mpyne created T9727: Validate cxxflags options works for all build types.
Sun, Sep 23, 3:49 PM · kdesrc-build
scottpetrovic committed R37:829038c8bea0: clean up a few setting area UI elements in brush editor (authored by scottpetrovic).
clean up a few setting area UI elements in brush editor
Sun, Sep 23, 3:41 PM
scottpetrovic committed R37:7944993a4662: re-arrange the editor widget a bit to be less wide (authored by scottpetrovic).
re-arrange the editor widget a bit to be less wide
Sun, Sep 23, 3:41 PM
scottpetrovic committed R37:4747e773d5c9: make setting areas in scrollable area (authored by scottpetrovic).
make setting areas in scrollable area
Sun, Sep 23, 3:41 PM