Feed All Stories

Today

mardelle committed R158:131673816996: Merge branch '1912' (authored by mardelle).
Merge branch '1912'
Wed, Nov 13, 4:44 PM
mardelle committed R158:5d6f44a2fbb1: Minor optimizations (authored by mardelle).
Minor optimizations
Wed, Nov 13, 4:44 PM
bam removed a watcher for Discover Software Store: bam.
Wed, Nov 13, 4:42 PM
dkazakov committed R37:f683f82b4f30: Remove unused file (authored by dkazakov).
Remove unused file
Wed, Nov 13, 4:41 PM
alexanderschmidt committed R767:7c48cc642f9e: new js var for image host created (authored by alexanderschmidt).
new js var for image host created
Wed, Nov 13, 4:40 PM
leinir committed R134:11bfabfcbee9: Ensure comments fetch for KNS starts on the right page (authored by leinir).
Ensure comments fetch for KNS starts on the right page
Wed, Nov 13, 4:36 PM
leinir closed D25282: Ensure comments fetch for KNS starts on the right page.
Wed, Nov 13, 4:36 PM · Plasma
ngraham added a comment to D25226: [KPropertiesDialog] provide a way of showing the target of a symlink.

Last question: give the button text, or stick with the icon only? I ask because go-jump is kind of an odd icon IMO:

Wed, Nov 13, 4:33 PM · Frameworks
ngraham updated the diff for D25226: [KPropertiesDialog] provide a way of showing the target of a symlink.

Use more semantically correct icon

Wed, Nov 13, 4:29 PM · Frameworks
dkazakov committed R37:433244e53e3c: Fix transform tool to work correctly with selection mask's overlay (authored by dkazakov).
Fix transform tool to work correctly with selection mask's overlay
Wed, Nov 13, 4:28 PM
dkazakov committed R37:b7a9efed95c3: Fix compilation (authored by dkazakov).
Fix compilation
Wed, Nov 13, 4:28 PM
ngraham added a comment to D25226: [KPropertiesDialog] provide a way of showing the target of a symlink.

Actually I played with that and in retrospect I don't think it would work. If we give it a "link-like" appearance, that would suggest that clicking on it would actually open the destination file/folder (i.e. the typical link behavior), which is not what we want here. We want to show it in the file manager, not open it. I'll stay with the current approach and change the icon as @ndavis requested.

Wed, Nov 13, 4:22 PM · Frameworks
ngraham added a comment to D24122: [GTK3] Generate Breeze Light assets.

I see.

Wed, Nov 13, 4:20 PM · Plasma
ngraham added a comment to D25290: KCM launchfeedback : port to KConfig XT.

So much red!

Wed, Nov 13, 4:17 PM · Plasma
habacker committed R139:42d8a2c6a794: Merge remote-tracking branch 'origin/release/19.12' (authored by habacker).
Merge remote-tracking branch 'origin/release/19.12'
Wed, Nov 13, 4:16 PM
habacker committed R139:abcdd7fec420: In codegenerator use term 'value' instead of 'new_var' for setter/getter… (authored by habacker).
In codegenerator use term 'value' instead of 'new_var' for setter/getter…
Wed, Nov 13, 4:15 PM
habacker committed R139:5dd834d045f0: Left alignment for lines of documentation displayed in a ClassifierWidget is set (authored by habacker).
Left alignment for lines of documentation displayed in a ClassifierWidget is set
Wed, Nov 13, 4:15 PM
crossi requested review of D25290: KCM launchfeedback : port to KConfig XT.
Wed, Nov 13, 4:14 PM · Plasma
habacker committed R139:c083902ef178: Add super/sub class related tests to classifier unit tests (authored by habacker).
Add super/sub class related tests to classifier unit tests
Wed, Nov 13, 4:09 PM
habacker committed R139:07220325cb98: Fix issue detected by UMLCanvasObject unit test (authored by habacker).
Fix issue detected by UMLCanvasObject unit test
Wed, Nov 13, 3:52 PM
habacker committed R139:7b422fc22f1f: Add unit test for class UMLCanvasObject (authored by habacker).
Add unit test for class UMLCanvasObject
Wed, Nov 13, 3:52 PM
ngraham added a comment to D22684: [Klipper] Fix clipboard history management.

@pdabrowski can you rebase this?

Wed, Nov 13, 3:51 PM · Plasma
woltherav committed R37:1f41f29ee087: Fix saving Image Hose Brushes (authored by woltherav).
Fix saving Image Hose Brushes
Wed, Nov 13, 3:49 PM
woltherav committed R37:30dbe866bb4f: Fix cloning the brushtip image inside kisbrushes. (authored by woltherav).
Fix cloning the brushtip image inside kisbrushes.
Wed, Nov 13, 3:49 PM
yurchor committed R369:048bda83a2e5: Use URLs with transport encryption (authored by yurchor).
Use URLs with transport encryption
Wed, Nov 13, 3:47 PM
ngraham added a comment to D22684: [Klipper] Fix clipboard history management.

@davidedmundson are you still good with this?

Wed, Nov 13, 3:44 PM · Plasma
woltherav committed R37:df2394f6e653: Make sure the brushtip image reflects whether it is painted as a mask. Also… (authored by woltherav).
Make sure the brushtip image reflects whether it is painted as a mask. Also…
Wed, Nov 13, 3:34 PM
woltherav committed R37:3b0a368911c9: Fix brush tip preview scaling inside the brush tip creation dialogues. (authored by woltherav).
Fix brush tip preview scaling inside the brush tip creation dialogues.
Wed, Nov 13, 3:34 PM
woltherav committed R37:dc03a8868dc5: Fix crash in the brush from clipboard. (authored by woltherav).
Fix crash in the brush from clipboard.
Wed, Nov 13, 3:34 PM
siyuandong committed R767:da628a82cc99: react cleanup (authored by siyuandong).
react cleanup
Wed, Nov 13, 3:29 PM
zepires committed R883:1556121: Finished HEAD for now.
Finished HEAD for now
Wed, Nov 13, 3:27 PM
rjvbb added a comment to D22801: [KIO] silence a QFileInfo warning.

Are you not seeing these for instance when browsing an MSWin share in Dolphin (with the same or newer versions of kio-extras, Samba and MSWin)?

Wed, Nov 13, 3:21 PM · Frameworks
dcaliste added reviewers for D25289: Read floating date time as LocalTime.: vkrause, pvuorela, KDE PIM, dvratil.

I think that tests are still passing properly, but this change may have unexpected consequences. I would like to tqke the opportunity of this pqtch to discuss if it's a valid approach for floating date time input. Thank you.

Wed, Nov 13, 3:15 PM · KDE PIM
dkazakov committed R37:b9f7132e8835: Fix warnings at the tail of *ASSERT*RECOVER lines (authored by dkazakov).
Fix warnings at the tail of *ASSERT*RECOVER lines
Wed, Nov 13, 3:15 PM
siyuandong committed R767:bdeacc470141: react cleanup (authored by siyuandong).
react cleanup
Wed, Nov 13, 3:15 PM
dkazakov committed R37:7ec0e67e771e: Add debugging capabilities to KisUpdateJobItem (authored by dkazakov).
Add debugging capabilities to KisUpdateJobItem
Wed, Nov 13, 3:15 PM
ngraham accepted D25282: Ensure comments fetch for KNS starts on the right page.
Wed, Nov 13, 3:15 PM · Plasma
dcaliste requested review of D25289: Read floating date time as LocalTime..
Wed, Nov 13, 3:12 PM · KDE PIM
ngraham added a project to T12027: Relicence breeze to LGPL: Breeze.
Wed, Nov 13, 3:05 PM · Breeze, Goal: All About the Apps
broulik added a comment to D24070: Don't use toolTipMainText to show info, rather use the second line.

There's also a lot of code duplication making the diff hard to read. Please group if statements together where it makes sense, e.g. avpod things like

if (foo) {
    return plasmoid.title;
} else if (foo) {
    return plasmoid.title;

or

if (foo) {
    if (bar) {
        baz();
    }
} else {
    if (bar) {
        baz();
    }
}
Wed, Nov 13, 3:01 PM · Plasma
ronaldv committed R979:63e6d44bff76: cache (authored by ronaldv).
cache
Wed, Nov 13, 3:01 PM
pvuorela added reviewers for D25288: Fix build on newish gcc with qreal as float: leinir, denexter.
Wed, Nov 13, 2:51 PM · Calligra: 3.0
pvuorela requested review of D25288: Fix build on newish gcc with qreal as float.
Wed, Nov 13, 2:50 PM · Calligra: 3.0
jriddell moved T11933: Debrand KDE Applications as Release Service from Discussing to Doing on the Goal: All About the Apps board.
Wed, Nov 13, 2:48 PM · KDE Promo, KDE Applications, Goal: All About the Apps
ervin requested review of D25287: Integrate the lnf and wallpaper settings with the KCM logic.
Wed, Nov 13, 2:48 PM · Plasma
jriddell created T12027: Relicence breeze to LGPL.
Wed, Nov 13, 2:48 PM · Breeze, Goal: All About the Apps
ronaldv committed R979:458fed256f5c: cache (authored by ronaldv).
cache
Wed, Nov 13, 2:47 PM
bellaperez committed R883:1556120: doc: Catalan Works.
doc: Catalan Works
Wed, Nov 13, 2:46 PM
ngraham added a comment to D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before.

There is already a method to enable/disable BT, why don't you reuse it?

Wed, Nov 13, 2:45 PM · Plasma
ervin closed D25286: Allow to disable autosave behavior in ConfigPropertyMap.
Wed, Nov 13, 2:42 PM · Frameworks
ervin committed R296:40b94af6f0f4: Allow to disable autosave behavior in ConfigPropertyMap (authored by ervin).
Allow to disable autosave behavior in ConfigPropertyMap
Wed, Nov 13, 2:42 PM
mart accepted D25286: Allow to disable autosave behavior in ConfigPropertyMap.
Wed, Nov 13, 2:41 PM · Frameworks
ngraham added a comment to D25281: [GTK3] Improve legibility of Firefox CSD colours.
However Once we implement the Breeze color scheme changes

How is that related? If i keep using a dark title bar I will still have that issue. Merely changing the colorscheme doesn't fix the underlying bug?

Wed, Nov 13, 2:41 PM · Plasma
ngraham added a comment to D25273: Enable selecting all installed color schemes in Cuttlefish.

Since this directly uses KColorSchemeManager, do you also see duplicated entries in Kate's color scheme menu?

Wed, Nov 13, 2:39 PM · Plasma
ervin requested review of D25286: Allow to disable autosave behavior in ConfigPropertyMap.
Wed, Nov 13, 2:39 PM · Frameworks
bellaperez committed R883:1556119: gui: Catalan Works.
gui: Catalan Works
Wed, Nov 13, 2:38 PM
ervin committed R133:68bdeb8cd7d9: Move the shortcut management in the settings object (authored by ervin).
Move the shortcut management in the settings object
Wed, Nov 13, 2:37 PM
ervin closed D25212: Move the shortcut management in the settings object.
Wed, Nov 13, 2:37 PM · Plasma
ervin closed D25211: Add KPropertySkeletonItem.
Wed, Nov 13, 2:35 PM · Frameworks
ervin committed R237:d63955cfe547: Add KPropertySkeletonItem (authored by ervin).
Add KPropertySkeletonItem
Wed, Nov 13, 2:35 PM
ervin committed R237:44cfa0631d25: Prepare KConfigSkeletonItem to allow inheriting its private class (authored by ervin).
Prepare KConfigSkeletonItem to allow inheriting its private class
Wed, Nov 13, 2:35 PM
ervin closed D25210: Prepare KConfigSkeletonItem to allow inheriting its private class.
Wed, Nov 13, 2:35 PM · Frameworks
davidedmundson added inline comments to D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before.
Wed, Nov 13, 2:35 PM · Plasma
pvuorela added reviewers for D25285: Mark \shp and \shpinst as supported control words on rtf reader: denexter, davidllewellynjones.
Wed, Nov 13, 2:33 PM · Calligra: 3.0
broulik added inline comments to D25284: Make QmlComponentsPool one instance per engine.
Wed, Nov 13, 2:32 PM · Kirigami
pvuorela requested review of D25285: Mark \shp and \shpinst as supported control words on rtf reader.
Wed, Nov 13, 2:31 PM · Calligra: 3.0
laane committed R883:1556118: pudemeid juurde ja kdemultimedia pisut kenamaks.
pudemeid juurde ja kdemultimedia pisut kenamaks
Wed, Nov 13, 2:28 PM
mutlaqja committed R321:d3645e7da2c3: Use backend instead of type to avoid confusion (authored by mutlaqja).
Use backend instead of type to avoid confusion
Wed, Nov 13, 2:27 PM
cgilles committed R482:aafb8a4276eb: typo (authored by cgilles).
typo
Wed, Nov 13, 2:27 PM
mvourlakos committed R878:61016444fbb2: dont crash when changing layouts (authored by mvourlakos).
dont crash when changing layouts
Wed, Nov 13, 2:24 PM
mvourlakos committed R878:062fde2e80ca: dont crash when changing layouts (authored by mvourlakos).
dont crash when changing layouts
Wed, Nov 13, 2:23 PM
davidedmundson requested review of D25284: Make QmlComponentsPool one instance per engine.
Wed, Nov 13, 2:23 PM · Kirigami
camiloh committed R899:e348d9944574: return of cloud view and add download quick action (authored by camiloh).
return of cloud view and add download quick action
Wed, Nov 13, 1:50 PM
rempt committed R37:4628887fa285: Clone the document resource storage when the document is cloned (authored by rempt).
Clone the document resource storage when the document is cloned
Wed, Nov 13, 1:40 PM
rempt committed R37:d47a0b347de3: Define the order of the resource types in one place only (authored by rempt).
Define the order of the resource types in one place only
Wed, Nov 13, 1:40 PM
cullmann committed R40:d2bb4717b9ff: LSP: support ocaml merlin (authored by cullmann).
LSP: support ocaml merlin
Wed, Nov 13, 1:21 PM
cullmann committed R40:8b9f75ef1320: LSP: support ocaml merlin (authored by cullmann).
LSP: support ocaml merlin
Wed, Nov 13, 1:20 PM
bruns added inline comments to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Wed, Nov 13, 1:19 PM · Dolphin
davidedmundson added a comment to D24457: [wayland] Ensure that repaints_region is in frame-local coordinates.

When we call this line:

connect(m_surface, &SurfaceInterface::damaged, this, &Toplevel::addDamage);
Wed, Nov 13, 1:12 PM · KWin
poboiko updated the summary of D23787: [baloo_file_extractor] Improve handling of large plain-text files.
Wed, Nov 13, 1:11 PM · Baloo, Frameworks
poboiko added a comment to D23787: [baloo_file_extractor] Improve handling of large plain-text files.

@bruns: I've missed D16593: [ExtractorCollection] Use only best matching extractor plugin, and had in mind previous situation where we've matched all extractors based on inheritance. In that case, "Secondly" part indeed does not seem to apply anymore.
(as for my previous answer: I misunderstood you, thought you were asking about the case where PlainTextExtractor did not match & matched afterwards)

Wed, Nov 13, 1:08 PM · Baloo, Frameworks
siyuandong committed R767:0cd7ee829604: media (authored by siyuandong).
media
Wed, Nov 13, 1:03 PM
sitter added a comment to T11933: Debrand KDE Applications as Release Service.

^ Plays into https://github.com/ximion/appstream/issues/240

Wed, Nov 13, 1:01 PM · KDE Promo, KDE Applications, Goal: All About the Apps
rempt committed R37:a78baa8e82a3: Add a unique ID to KisDocument (authored by rempt).
Add a unique ID to KisDocument
Wed, Nov 13, 12:58 PM
mlaurent committed R119:18c3aa641a52: Port some deprecated methods (authored by mlaurent).
Port some deprecated methods
Wed, Nov 13, 12:57 PM
David Nelband <dnelband@gmail.com> committed R767:91a7c8aeff61: pb mp (authored by David Nelband <dnelband@gmail.com>).
pb mp
Wed, Nov 13, 12:52 PM
David Nelband <dnelband@gmail.com> committed R767:63e85ddd9ec6: pb mp (authored by David Nelband <dnelband@gmail.com>).
pb mp
Wed, Nov 13, 12:48 PM
davidedmundson accepted D24456: [wayland] Provide correct input transformation matrix for client-side decorated clients.
Wed, Nov 13, 12:48 PM · KWin
David Nelband <dnelband@gmail.com> committed R767:d1a34b918861: pms mp (authored by David Nelband <dnelband@gmail.com>).
pms mp
Wed, Nov 13, 12:45 PM
meven added a comment to D23507: Replace custom single threaded merge sort with std::stable_sort.

Seems sane to me and nice since it removes some code.

Wed, Nov 13, 12:43 PM · Dolphin
David Nelband <dnelband@gmail.com> committed R767:beadbba9a29b: pms mp (authored by David Nelband <dnelband@gmail.com>).
pms mp
Wed, Nov 13, 12:43 PM
davidedmundson accepted D24455: [wayland] Implement window geometry more properly.

Technically there's one potentially interesting behavioural change.
If a client is server side decorated and then draws a subsurface outside the main surface, previously I believe we would have drawn our frame over the main surface, whereas now I think we'll draw our frame over the union. Probably not a real world issue though.

Wed, Nov 13, 12:43 PM · KWin
mlaurent committed R94:49163a8adaee: Merge remote-tracking branch 'origin/release/19.12' (authored by mlaurent).
Merge remote-tracking branch 'origin/release/19.12'
Wed, Nov 13, 12:36 PM
mlaurent committed R94:a63f63be45b3: Check from SSID (authored by mlaurent).
Check from SSID
Wed, Nov 13, 12:35 PM
mlaurent committed R94:4ac0b665b89e: Improve parsing (authored by mlaurent).
Improve parsing
Wed, Nov 13, 12:35 PM
meven added a comment to D22801: [KIO] silence a QFileInfo warning.

The issue could be as well located in previewjob.cpp.
Could you debug why KMountPoint::List::findByPath is called with an empty string or non-existing file.
We might want to prevent this to happen instead.

Wed, Nov 13, 12:35 PM · Frameworks
siyuandong committed R767:a400e0f9a850: media slider (authored by siyuandong).
media slider
Wed, Nov 13, 12:33 PM
bruns added a comment to D23787: [baloo_file_extractor] Improve handling of large plain-text files.

Can you please provide an example which:

  • is currently indexed though it should be skipped due to size
  • is skipped after this change

Sure. Any mimetype inherited from "text/plain", but starting with "text/" counts. I've made an actual list:


(using simple python script, which iterates over QMimeDatabase().allMimeTypes(), checks if type.inherits("text/plain") and is not already excluded by default Baloo config from file/fileexcludefilters.cpp)

Wed, Nov 13, 12:32 PM · Baloo, Frameworks
bruns added a comment to D23787: [baloo_file_extractor] Improve handling of large plain-text files.

and another example which:

  • is currently skipped though it should be indexed
  • is indexed after this change

There shouldn't be any. I mean, "PlaintextExtractor" should be inside exList for anything that starts with text/...

Wed, Nov 13, 12:27 PM · Baloo, Frameworks
mvourlakos committed R878:6b5f4a952a8c: dont drag/maximize windows from different desktops (authored by mvourlakos).
dont drag/maximize windows from different desktops
Wed, Nov 13, 12:26 PM