jjorge (José JORGE)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Feb 6 2017, 3:54 PM (145 w, 3 d)
Availability
Available

Recent Activity

Fri, Nov 15

jjorge added a comment to D25018: Move ACPI battery information from /proc/acpi to /sys.

Do you have a developer account to push the changes? Otherwise I can do that for you.

Fri, Nov 15, 4:25 PM · Plasma

Thu, Nov 14

jjorge added a comment to D25018: Move ACPI battery information from /proc/acpi to /sys.

How will this be merged? Will it be in time for Kde 19.12 ?

Thu, Nov 14, 8:52 PM · Plasma

Tue, Nov 12

jjorge added a comment to D25018: Move ACPI battery information from /proc/acpi to /sys.

How can you interpret these weird charge_now values correctly? If the range is [1/1000, 901] Wh, while the real range is [0, 45] Wh, how does the charge curve look like while charging or discharging? Are there (continues) values in [46, 901] Wh? Do you assume all of those as 100%?

Tue, Nov 12, 8:37 AM · Plasma

Mon, Nov 11

jjorge added a comment to D25018: Move ACPI battery information from /proc/acpi to /sys.

Are states > 100 or < 0 really well defined? Is it save to assume that a state > 100 can be associated with 100?

Yes : this is a percentage. States out of this value are bad hardware : I have a travel battery which shows crazy values along time, from 0,001Wh capacity till 901Wh (Real capacity is near 45Wh).

Mon, Nov 11, 7:24 PM · Plasma
jjorge added a comment to D25018: Move ACPI battery information from /proc/acpi to /sys.

Thanks. Just some thoughts : designcharge is usefull if you want to see the percentage of charge you reach against what it should be with a new battery. For some adicional sensors, of course, even if I dont see what ones you are thinking about.

Mon, Nov 11, 5:18 PM · Plasma

Wed, Nov 6

jjorge updated the diff for D25018: Move ACPI battery information from /proc/acpi to /sys.
  • hopefully correct all problems found in nice ahiemstra's revision
  • - indentation corrected to 4 chars
  • - function braces in newline
  • - We can calculate charge even if current is <= zero.
Wed, Nov 6, 5:43 PM · Plasma

Mon, Nov 4

jjorge requested review of D25018: Move ACPI battery information from /proc/acpi to /sys.

So asking again for feedback, if I understand well how phabricator works ...

Mon, Nov 4, 5:06 PM · Plasma
jjorge added a comment to D25018: Move ACPI battery information from /proc/acpi to /sys.

Hmm, I would like to see some smarter sys file handling for this. Right now, multiple calls to getSysFileValue result in the same file being read from disk over and over. While the original implementation may not have been ideal either, the update function at least made sure the ACPI stuff got only read once per update. If you need some inspiration, Memory.c has a fairly decent implementation.

Mon, Nov 4, 5:04 PM · Plasma

Mon, Oct 28

jjorge requested review of D25018: Move ACPI battery information from /proc/acpi to /sys.
Mon, Oct 28, 9:25 PM · Plasma
jjorge added a comment to D24998: Fix ksysguard acpi cooling devices.

How to test : just add an ACPI cooling device to ksysguard, it would always show 0% before this patch. To find one cooling device that actually changes, you can use the 'acpi -V' command

Mon, Oct 28, 9:04 AM · Plasma
jjorge requested review of D24998: Fix ksysguard acpi cooling devices.
Mon, Oct 28, 9:02 AM · Plasma

Jun 3 2019

jjorge updated the test plan for D21477: Use the theme file defined sounds if they are declared..
Jun 3 2019, 5:05 PM

May 30 2019

jjorge updated the diff for D21477: Use the theme file defined sounds if they are declared..
  • Added a loadtheme function to allow sound theme switching on config change.
May 30 2019, 11:39 AM

May 29 2019

jjorge updated the diff for D21477: Use the theme file defined sounds if they are declared..
  • Add .arcconfig file to the project to make contribution easier.
May 29 2019, 8:27 AM
jjorge requested review of D21477: Use the theme file defined sounds if they are declared..
May 29 2019, 8:25 AM
jjorge requested review of D21472: Add a prefix public function to access the internatl prefix..
May 29 2019, 7:22 AM

May 2 2019

jjorge added a comment to D20936: Add support for Mageia distro.

I think I cannot commit as I never did ;-)

May 2 2019, 12:07 PM · kdesrc-build

May 1 2019

jjorge requested review of D20936: Add support for Mageia distro.
May 1 2019, 1:10 PM · kdesrc-build