Add Breeze icons for Jupyter Notebook files
Needs RevisionPublic

Authored by alexde on Tue, Sep 10, 7:28 PM.

Details

Reviewers
ndavis
Group Reviewers
VDG
Summary

This patch adds icons for Jupyter Notebook files. It uses the offical SVG logo.
As far I see it, this patch applies with both

  • Trademark Usage Policy [1]
  • Brand Guide [2]

as it uses the logo in a non-commercial way and clearly only in relation to Jupyter projects. [1]
Further it does use a proposed version of the logo. [2]

[1] https://github.com/jupyter/governance/blob/master/trademarks.md
[2] https://github.com/jupyter/design/blob/master/brandguide/brand_guide.pdf

Test Plan

Diff Detail

Repository
R266 Breeze Icons
Branch
jupyter (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16346
Build 16364: arc lint + arc unit
alexde created this revision.Tue, Sep 10, 7:28 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptTue, Sep 10, 7:28 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
alexde requested review of this revision.Tue, Sep 10, 7:28 PM
alexde edited the test plan for this revision. (Show Details)Tue, Sep 10, 7:38 PM
ndavis requested changes to this revision.EditedWed, Sep 11, 12:11 AM
ndavis added a subscriber: ndavis.

The spheres around the planet need better pixel alignment, particularly on the 16, 22 and 32px versions. This will require remaking parts of the logo so that it fills pixels. Round to the nearest size in whole pixels. Half pixels can be tolerated sometimes when the area is greater than 2x2, but pick what looks good to you at 100% zoom in general. The planet itself could have better pixel alignment too, but it's not as critical.

BTW, when you put images of the icons in the test plan section, it's best to show them at 1x size so that I can see how they would look on a user's screen without needing to download the patch. See this: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Icon_compilation_images

This revision now requires changes to proceed.Wed, Sep 11, 12:11 AM