This patch adds icons for Jupyter Notebook files. It uses the offical SVG logo.
As far I see it, this patch applies with both
as it uses the logo in a non-commercial way and clearly only in relation to Jupyter projects. [1]
Further it does use a proposed version of the logo. [2]
[1] https://github.com/jupyter/governance/blob/master/trademarks.md
[2] https://github.com/jupyter/design/blob/master/brandguide/brand_guide.pdf
| No Linters Available |
| No Unit Test Coverage |
| Buildable 16346 | |
| Build 16364: arc lint + arc unit |
The spheres around the planet need better pixel alignment, particularly on the 16, 22 and 32px versions. This will require remaking parts of the logo so that it fills pixels. Round to the nearest size in whole pixels. Half pixels can be tolerated sometimes when the area is greater than 2x2, but pick what looks good to you at 100% zoom in general. The planet itself could have better pixel alignment too, but it's not as critical.
BTW, when you put images of the icons in the test plan section, it's best to show them at 1x size so that I can see how they would look on a user's screen without needing to download the patch. See this: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Icon_compilation_images