ognarb (Carl Schwan)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Dec 18 2017, 2:32 PM (65 w, 2 d)
Availability
Available

Computer Science Student at the University of Saarland (Germany). Native French speaker.

I love contributing to the userbase documentation and some patch here and here.

Recent Activity

Today

ognarb added a comment to T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG.

I'm interested in implementing this search field component with a focus sequence. But I have some questions before I start.

Wed, Mar 20, 12:54 AM · VDG, Plasma

Yesterday

ognarb added a comment to D19895: Use https for links in the UI and documentation.

I made sure that all the links are still working. So +1

Tue, Mar 19, 7:04 PM · Documentation, Frameworks
ognarb committed R169:8dc09a000125: Fix errors in kirigami example files (authored by ognarb).
Fix errors in kirigami example files
Tue, Mar 19, 6:44 PM
ognarb closed D19454: Fix errors in kirigami example files.
Tue, Mar 19, 6:44 PM · Kirigami
ognarb committed R169:546f82f9e645: Add a SearchField and PasswordField component (authored by ognarb).
Add a SearchField and PasswordField component
Tue, Mar 19, 6:42 PM
ognarb closed D19502: Add a SearchField and PasswordField component.
Tue, Mar 19, 6:42 PM · Kirigami

Mon, Mar 18

ognarb placed T9420: [KOrganizer] Improve event display up for grabs.

I don't have much time now, so if someone want to clain this task instead you are welcome.

Mon, Mar 18, 10:37 PM · KDE PIM: Junior Jobs, KDE PIM

Sun, Mar 17

ognarb committed R473:c77b09fe37ac: Follow KDE HIG by using ellipis (authored by ognarb).
Follow KDE HIG by using ellipis
Sun, Mar 17, 11:40 PM
ognarb closed D19772: Follow KDE HIG by using ellipis.
Sun, Mar 17, 11:40 PM
ognarb updated the diff for D19770: Use placeholder for search action.

Now compile. Sorry :/

Sun, Mar 17, 9:58 PM · Documentation, Dolphin
ognarb added a comment to D19774: Use ellipsis in search field.

I wish you used proper commit logs, this is not "Use ellipsis in the search field" this is "Remove search label and replace it by a placeholder"

You may not think of it, but this commit logs are going to be read by people in 10 years and them being accurate is quite important.

Sun, Mar 17, 8:30 PM · KDE Edu
ognarb added a comment to D19773: Update search bar following kde HIG.

No it was not, placeholder text is to give extra information that may be useful, not to describe what the field is about, because once you type on it the information goes away and when you have 4 line edits without labels and placeholders because you wrote stuff on them suddenly it's impossible to remember what each field did.

Sun, Mar 17, 8:27 PM · KDE Edu
ognarb committed R326:76a9bcd87426: Use ellipsis in search field (authored by ognarb).
Use ellipsis in search field
Sun, Mar 17, 7:20 PM
ognarb closed D19774: Use ellipsis in search field.
Sun, Mar 17, 7:20 PM · KDE Edu
ognarb updated the diff for D19774: Use ellipsis in search field.

Use 3 dots instead of the unicode ellipsis

Sun, Mar 17, 7:12 PM · KDE Edu
ognarb added a reviewer for D19772: Follow KDE HIG by using ellipis: stikonas.
Sun, Mar 17, 7:03 PM
ognarb updated the diff for D19772: Follow KDE HIG by using ellipis.

Use 3 dots instead of the unicode ellipsis

Sun, Mar 17, 7:00 PM
ognarb updated the summary of D19770: Use placeholder for search action.
Sun, Mar 17, 6:41 PM · Documentation, Dolphin
ognarb updated the summary of D19770: Use placeholder for search action.
Sun, Mar 17, 6:39 PM · Documentation, Dolphin
ognarb updated the diff for D19770: Use placeholder for search action.

Use better variable name

Sun, Mar 17, 6:37 PM · Documentation, Dolphin
ognarb updated the diff for D19770: Use placeholder for search action.
  • Use 3 dots instead of unicode
  • Apply same change to filter bar
  • This time change Find to Search correctly
Sun, Mar 17, 6:35 PM · Documentation, Dolphin
ognarb updated the diff for D19454: Fix errors in kirigami example files.

Remove goBack funtion, and I repported the bug https://bugs.kde.org/show_bug.cgi?id=405571 :)

Sun, Mar 17, 6:08 PM · Kirigami
ognarb updated the diff for D19502: Add a SearchField and PasswordField component.

Rebase

Sun, Mar 17, 5:57 PM · Kirigami
ognarb updated the diff for D19502: Add a SearchField and PasswordField component.
  • Use qsTr instead of i18n
  • Kirigami version 2.7 -> 2.8
Sun, Mar 17, 5:55 PM · Kirigami
ognarb updated the diff for D19770: Use placeholder for search action.
  • Translate Search
  • Update doc
Sun, Mar 17, 1:49 PM · Documentation, Dolphin

Sat, Mar 16

ognarb added a comment to D19771: Use placeholder instead of label.

I'm not aware of why we tend to use three dots instead of the real ellipsis character. Possibly because that character can be challenging to type. Best to follow the existing convention, I think.

Sat, Mar 16, 8:05 PM · Frameworks, Kate
ognarb committed R55:74db72222b17: Update search bar following kde HIG (authored by ognarb).
Update search bar following kde HIG
Sat, Mar 16, 7:56 PM
ognarb closed D19773: Update search bar following kde HIG.
Sat, Mar 16, 7:56 PM · KDE Edu
ognarb added inline comments to D19804: Updated README.md with detailed build instructions.
Sat, Mar 16, 12:57 PM · Falkon

Thu, Mar 14

ognarb added a comment to D19770: Use placeholder for search action.

The menu item and the toolbar button say "Find". "Search" is really the correct term here, so we should change the text of the menu item and toolbar button to match it.

Thu, Mar 14, 11:53 PM · Documentation, Dolphin
ognarb updated subscribers of D19774: Use ellipsis in search field.
Thu, Mar 14, 11:43 PM · KDE Edu
ognarb added a task to D19774: Use ellipsis in search field: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG.
Thu, Mar 14, 11:33 PM · KDE Edu
ognarb added a revision to T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG: D19774: Use ellipsis in search field.
Thu, Mar 14, 11:33 PM · VDG, Plasma
ognarb added reviewers for D19774: Use ellipsis in search field: Kalzium, VDG.
Thu, Mar 14, 11:33 PM · KDE Edu
ognarb requested review of D19774: Use ellipsis in search field.
Thu, Mar 14, 11:32 PM · KDE Edu
ognarb added a task to D19773: Update search bar following kde HIG: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG.
Thu, Mar 14, 11:12 PM · KDE Edu
ognarb added a revision to T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG: D19773: Update search bar following kde HIG.
Thu, Mar 14, 11:12 PM · VDG, Plasma
ognarb added reviewers for D19773: Update search bar following kde HIG: Cantor, VDG.
Thu, Mar 14, 11:11 PM · KDE Edu
ognarb updated the summary of D19773: Update search bar following kde HIG.
Thu, Mar 14, 11:04 PM · KDE Edu
ognarb requested review of D19773: Update search bar following kde HIG.
Thu, Mar 14, 11:03 PM · KDE Edu
ognarb added a task to D19625: Use a searchbar similar to the one in okular: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG.
Thu, Mar 14, 10:30 PM · Falkon
ognarb added a revision to T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG: D19625: Use a searchbar similar to the one in okular.
Thu, Mar 14, 10:30 PM · VDG, Plasma
ognarb added a task to D19771: Use placeholder instead of label: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG.
Thu, Mar 14, 10:30 PM · Frameworks, Kate
ognarb added a revision to T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG: D19771: Use placeholder instead of label.
Thu, Mar 14, 10:30 PM · VDG, Plasma
ognarb added a revision to T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG: D19622: Use a searchbar similar to the one in okular using the webenginepart.
Thu, Mar 14, 10:29 PM · VDG, Plasma
ognarb added a task to D19622: Use a searchbar similar to the one in okular using the webenginepart: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG.
Thu, Mar 14, 10:29 PM
ognarb added a task to D19770: Use placeholder for search action: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG.
Thu, Mar 14, 10:28 PM · Documentation, Dolphin
ognarb added a revision to T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG: D19770: Use placeholder for search action.
Thu, Mar 14, 10:28 PM · VDG, Plasma
ognarb added a task to D19626: Remove find label and use a placeholder text instead: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG.
Thu, Mar 14, 10:28 PM · Okular
ognarb added a revision to T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG: D19626: Remove find label and use a placeholder text instead.
Thu, Mar 14, 10:28 PM · VDG, Plasma
ognarb added a revision to T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG: D19772: Follow KDE HIG by using ellipis.
Thu, Mar 14, 10:27 PM · VDG, Plasma
ognarb added a task to D19772: Follow KDE HIG by using ellipis: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG.
Thu, Mar 14, 10:27 PM
ognarb added a reviewer for D19772: Follow KDE HIG by using ellipis: VDG.
Thu, Mar 14, 10:27 PM
ognarb requested review of D19772: Follow KDE HIG by using ellipis.
Thu, Mar 14, 10:26 PM
ognarb updated the diff for D19622: Use a searchbar similar to the one in okular using the webenginepart.

Use unicode ellipsis

Thu, Mar 14, 10:16 PM
ognarb updated the diff for D19620: Use a searchbar similar to the one in okular.

Use Unicode ellipsis

Thu, Mar 14, 10:15 PM · Frameworks
ognarb planned changes to D19771: Use placeholder instead of label.

Look likes I misread a part of the HIG: Since the placeholder won’t be visible anymore as soon as the user types, you should only use it on standalone input elements, not in groups of input elements such as forms.

Thu, Mar 14, 9:56 PM · Frameworks, Kate
ognarb updated the diff for D19771: Use placeholder instead of label.

Use proper Unicode ellipsis

Thu, Mar 14, 8:52 PM · Frameworks, Kate
ognarb added a reviewer for D19771: Use placeholder instead of label: VDG.
Thu, Mar 14, 8:51 PM · Frameworks, Kate
ognarb added a reviewer for D19771: Use placeholder instead of label: KTextEditor.
Thu, Mar 14, 8:51 PM · Frameworks, Kate
ognarb added inline comments to D19770: Use placeholder for search action.
Thu, Mar 14, 8:44 PM · Documentation, Dolphin
ognarb updated the diff for D19770: Use placeholder for search action.

Use proper ellipsis not 3 points

Thu, Mar 14, 8:29 PM · Documentation, Dolphin
ognarb requested review of D19771: Use placeholder instead of label.
Thu, Mar 14, 8:12 PM · Frameworks, Kate
ognarb added reviewers for D19770: Use placeholder for search action: Dolphin, VDG.
Thu, Mar 14, 7:56 PM · Documentation, Dolphin
ognarb requested review of D19770: Use placeholder for search action.
Thu, Mar 14, 7:55 PM · Documentation, Dolphin
ognarb updated the test plan for D19622: Use a searchbar similar to the one in okular using the webenginepart.
Thu, Mar 14, 7:22 PM
ognarb updated the summary of D19620: Use a searchbar similar to the one in okular.
Thu, Mar 14, 7:22 PM · Frameworks
ognarb updated the diff for D19622: Use a searchbar similar to the one in okular using the webenginepart.

After discution in VDG group, add configure button again ;)

Thu, Mar 14, 7:18 PM
ognarb updated the diff for D19622: Use a searchbar similar to the one in okular using the webenginepart.

Remove icon for options button

Thu, Mar 14, 6:43 PM
ognarb updated the summary of D19620: Use a searchbar similar to the one in okular.
Thu, Mar 14, 6:40 PM · Frameworks
ognarb updated the summary of D19620: Use a searchbar similar to the one in okular.
Thu, Mar 14, 6:39 PM · Frameworks
ognarb updated the diff for D19620: Use a searchbar similar to the one in okular.

Remove icon to option button

Thu, Mar 14, 6:39 PM · Frameworks
ognarb added a comment to T10618: review our use of khelpcenter (and its deps).

Just want to point out that System Settings has a lot of help buttons that link to khelpcenter. Maybe someone from Plasma team can implement a fallback to open the web version in case khelpcenter is not running.

Thu, Mar 14, 6:21 PM · Neon
ognarb updated the summary of D19620: Use a searchbar similar to the one in okular.
Thu, Mar 14, 1:31 PM · Frameworks
ognarb updated the diff for D19622: Use a searchbar similar to the one in okular using the webenginepart.

Add setting icon to config button

Thu, Mar 14, 1:22 PM
ognarb updated the summary of D19622: Use a searchbar similar to the one in okular using the webenginepart.
Thu, Mar 14, 1:08 PM
ognarb committed R875:9601e8ad3452: Use a searchbar similar to the one in okular (authored by ognarb).
Use a searchbar similar to the one in okular
Thu, Mar 14, 12:58 PM
ognarb closed D19625: Use a searchbar similar to the one in okular.
Thu, Mar 14, 12:58 PM · Falkon
ognarb added a comment to D19625: Use a searchbar similar to the one in okular.

I like it, thanks!

Thu, Mar 14, 12:56 PM · Falkon
ognarb added a comment to D19625: Use a searchbar similar to the one in okular.

Just my 2Cents

The advantage of current approach is that all control buttons are close together (I wuld call it "compact design")

I also dislike when the edit field and some related buttons are to wide separated

  • I dislike ToolTips, they are most of the time annoying, WhatsThis is not so easy to find but on the far end better
Thu, Mar 14, 12:56 PM · Falkon

Tue, Mar 12

ognarb updated the diff for D18658: Modify search bar in the contextDrawer.

Use string.length > 0 instead of string == "". It's faster

Tue, Mar 12, 4:11 PM · Okular

Mon, Mar 11

ognarb committed R169:f7100e2c9ca6: Fix Qmake based build (authored by ognarb).
Fix Qmake based build
Mon, Mar 11, 3:15 PM
ognarb closed D19662: Fix Qmake based build.
Mon, Mar 11, 3:15 PM · Kirigami
ognarb added a comment to D18658: Modify search bar in the contextDrawer.

@aacid It is ready to land now?

Mon, Mar 11, 1:59 PM · Okular

Sun, Mar 10

ognarb requested review of D19662: Fix Qmake based build.
Sun, Mar 10, 10:12 PM · Kirigami
ognarb committed R238:a67daca8199c: Update design to look more similar to kde.org (authored by ognarb).
Update design to look more similar to kde.org
Sun, Mar 10, 9:07 PM
ognarb closed D19557: Update design to look more similar to kde.org.
Sun, Mar 10, 9:07 PM · Documentation, Frameworks
ognarb added a comment to D19557: Update design to look more similar to kde.org.

Thank you! And sorry for the ping-pong.

Sun, Mar 10, 9:06 PM · Documentation, Frameworks
ognarb updated the summary of D19557: Update design to look more similar to kde.org.
Sun, Mar 10, 8:53 PM · Documentation, Frameworks
ognarb updated the diff for D19557: Update design to look more similar to kde.org.

Don't change image link and remove kde.png

Sun, Mar 10, 8:52 PM · Documentation, Frameworks
ognarb updated the test plan for D19557: Update design to look more similar to kde.org.
Sun, Mar 10, 8:48 PM · Documentation, Frameworks
ognarb added a comment to D19557: Update design to look more similar to kde.org.

They use the old link for the image, also the jpg version instead of the png. I tested with new page and old page and the result is visually the same.

But do the existing pages use the old link for the image with the new CSS?

Sun, Mar 10, 8:40 PM · Documentation, Frameworks
ognarb added a comment to D19557: Update design to look more similar to kde.org.

No, wait a minute. What happens with pages which are not regenerated?

Sun, Mar 10, 8:36 PM · Documentation, Frameworks
ognarb added a comment to T10034: Attract existing FLOSS software projects to KDE and incorporate their members into our community.

That about asteroidOS. It's open source system for smartwatch build with qt quick. Maybe some collaboration with plasma mobile and/or kde connect could be interesting.

Sun, Mar 10, 4:57 PM · KDE Promo
ognarb updated the diff for D19557: Update design to look more similar to kde.org.

Don't change image size

Sun, Mar 10, 4:39 PM · Documentation, Frameworks
ognarb updated the diff for D19557: Update design to look more similar to kde.org.
  • Add deleted image
  • Rename top-kde.png to kde.png
  • Fix strange margin issues for some elements
Sun, Mar 10, 1:35 PM · Documentation, Frameworks

Sat, Mar 9

ognarb updated the diff for D19557: Update design to look more similar to kde.org.

Apply optipng. Thanks @bruns I learned something new :D.

Sat, Mar 9, 9:46 PM · Documentation, Frameworks
ognarb updated the diff for D19557: Update design to look more similar to kde.org.

Use inkscape to generate png

Sat, Mar 9, 9:42 PM · Documentation, Frameworks
ognarb added a comment to D19557: Update design to look more similar to kde.org.

Lol 128x128 png image 6kb, 129x129 png image 2kb

Sat, Mar 9, 9:29 PM · Documentation, Frameworks
ognarb updated the diff for D19557: Update design to look more similar to kde.org.

Use a 128x128 png image

Sat, Mar 9, 9:28 PM · Documentation, Frameworks