| manueljlin | |
| mart |
| VDG | |
| Kirigami |
Level 1 headings are humongous. The degree of humongousness is maybe a bit excessive,
especially on page titles with toolbars, where it looks like it's positively trying
to burst from its bounds! Also, the left padding could stand to be increased, which
would make the titles align with the content for most views. This was brought up in
T12631.
If this patch is approved, I will submit companion patches to make the same changes in
the PlasmaExtras Heading and KTitleWidget.
Discover, before:
Discover, after:
Kirigami Gallery, after:
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| src/controls/private/globaltoolbar/TitlesPageHeader.qml | ||
|---|---|---|
| 37 | Shouldn't this be Units.gridUnit if you actually want to match the default Page margins? | |
Looks way better, thanks Nate!
Since case 1 to 3 are steps of 0.1 and from case 3 to 4 is a step of 0.2, how would it looke like with 1.40 instead of 1.50?
Would it be too small? Would you like attach another screenshot please? :-)
I tried 1.4 but it looked a bit too small to me, and not sufficiently differentiated from the level 2 and 3 headings in content areas:
When looking at the screenshots, 1.4 looks fine to me, but go with whatever you guys think is better. :)
Interesting that a difference < 7% is visually is spotted so easily.
Edit: actually, checking with a computer screen both look good, but I still prefer the screenshots from the Details section
Thanks! Companion changes:
plasma-framework: a9ea008b8d6fab00fdeee029e685a9fc3b4061c8
kwidgetsaddons: 2157e258721be0c81477b2e305e6d697cafb597d