| bruns | |
| meven |
| Frameworks |
Refactor fstab handling
Splits the fstab/mtab handling code into smaller pieces and allow unit
testing of each one. The reafacting allows us to use the various classes
individually, e.g. use the FilesystemTableParser for parsing any
fstab/mtab style file.
This refactoring is a prerequisite for adding proper support for
fuseiso, since fuseiso maintains it's own mtab file, which we would like
to parse and use.
Unit tests
Tested manually with Plasma Vaults
| No Linters Available |
| No Unit Test Coverage |
| Buildable 20996 | |
| Build 21014: arc lint + arc unit |
@meven - I am a little unsure if I have broken the fix you have done in commit c97f0b2a3076731b35435f200bd09a22859f3e03 - could you please check?
I have not tested with NFS or SMB mounts.
Finally, I think this code could be moved to a more general library in KDE Frameworks, because it appears that we have this functionality in multiple places. We have at least a partial copy of this in solid/src/solid/devices/backends/hal and probably also other places.
| src/solid/devices/backends/fstab/call_system_command.cpp | ||
|---|---|---|
| 1 | I think the Copyright notice needs to include the original authors of this function | |
| src/solid/devices/backends/fstab/filesystem_table_parser.cpp | ||
| 2 | I think the Copyright notice needs to include the original authors of this function | |
Yes, sorry about that - I need to fix that. This is just my editor, when I create new files this is the default template. I will make sure to put all the original authors in.
and this is definitely too much code being moved around. Please split this up into multiple reviews.
You should likely start with the introduction of the FilesystemEntry class, use that from the existing code.