- User Since
- Dec 14 2015, 3:47 PM (139 w, 4 d)
It is just a question. I think since you call setData when the job finishes anyway, it should be fine but I don't really know the architecture of that stuff either, so it might be fine to just trigger a free space job in updateSourceEvent
I found Breeze's ShadowHelper::loadConfig() stick out in hotspot on Dolphin startup, so I investigated what it did and found it would needlessly load the shadows.
The icons do have a tooltip
Yes, please use KIO::FileSystemFreeSpaceJob which is a lot simpler than all of this manually added threading code.
Alright, just important to get this fixed for 5.14, if all else fails we can still revert this, as it only asserts on debug builds
Wed, Aug 15
I used to do that to compare layouts and metrics of different applications or images but that doesn't really justify being enabled for everyone by default
Thanks for your patch and explanation on the mailing list!
- Use "application enforce presentation mode" to communicate better that the checkbox might be overruled
I used to disable that effect back in the days but now couldn't be bothered anymore. I don't particularly mind either way. :)
Tue, Aug 14
While you're at it can't you move them to plasma-framework? Having them in Breeze makes it not work with other themes and also they are only shown in the context of Plasma anyway
Not pretty but if it works.. Thanks!
Mon, Aug 13
- Fix top, should have worn my glasses when reading that
Should be "Prefer higher BPP"
Please hang on, we need to more thorougly test this.
Did you check the updated version with stable_partition? It makes the folders generate in the correct order as well.
Is this about generating the thumbnails for the first time or displaying them?
- Use stable_partition so the order of elements is preserved
Sun, Aug 12
I found a way to get the actual depth of the icon extracted
- Prefer higher DPI as well
This actually seems to break re-arranging files, at least on Qt 5.11.1:
Reverting this patch makes it work again
Sat, Aug 11
You can't and I don't see why you can't just use Home/End. Sorry.
I don't understand. Also, you can change the default shortcut from Home/End to whatever you like.
Can you explain the rationale behind this? Since you've seemingly randomly changed the shortcut, it doesn't seem like a "common" shortcut sheme?
- Use algorithm suggested by Stefan, thanks.
Shouldn't it rather be called "Reload" with the appropriate icon?
Checkout KStandardAction or KGuiItem
Ctrl+A is reserved for "Select All"
Thu, Aug 9
Wouldn't that break third party effects that have "Candy" in their manifest? Perhaps only change the user-visible string?
- Move check
isDirectoryMounted creates a QFileInfo on the url anyway, so both are prone to block, doesn't really matter which way round, does it?
- use QDir().absoluteFilePath()
Wed, Aug 8
Even isSlow() causes blockage as that does KFileSystemType::fileSystemType which then blocks in statfs64 :( (this patch still makes sense imho)