broulik (Kai Uwe Broulik)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Dec 14 2015, 3:47 PM (204 w, 2 d)
Availability
Available

Recent Activity

Today

broulik added a comment to D24070: Don't use toolTipMainText to show info, rather use the second line.

There's also a lot of code duplication making the diff hard to read. Please group if statements together where it makes sense, e.g. avpod things like

if (foo) {
    return plasmoid.title;
} else if (foo) {
    return plasmoid.title;

or

if (foo) {
    if (bar) {
        baz();
    }
} else {
    if (bar) {
        baz();
    }
}
Wed, Nov 13, 3:01 PM · Plasma
broulik added inline comments to D25284: Make QmlComponentsPool one instance per engine.
Wed, Nov 13, 2:32 PM · Kirigami
broulik added a comment to D25281: [GTK3] Improve legibility of Firefox CSD colours.
However Once we implement the Breeze color scheme changes
Wed, Nov 13, 10:04 AM · Plasma
broulik committed R856:260d158ce100: Improve error reporting for port on Firefox (authored by broulik).
Improve error reporting for port on Firefox
Wed, Nov 13, 8:10 AM
broulik committed R856:bbbde760eea4: Fix clearing kde connect devices on disconnect (authored by broulik).
Fix clearing kde connect devices on disconnect
Wed, Nov 13, 7:54 AM

Yesterday

broulik updated the test plan for D25277: [Tabs Runner] Filter on the host side already.
Tue, Nov 12, 6:06 PM · Plasma
broulik requested review of D25277: [Tabs Runner] Filter on the host side already.
Tue, Nov 12, 6:03 PM · Plasma
broulik updated the diff for D24870: Fixup new Audio() constructor and apply autoplay prevention evasion to document.createElement.
  • Also apply the same thing to Firefox
Tue, Nov 12, 3:01 PM · Plasma
broulik added a comment to D24893: [Lock Screen] Add option to hide clock when idle.

Does it make sense to have the option off by default, i.e. hiding the clock on idle by default?

Tue, Nov 12, 1:12 PM · Plasma
broulik added inline comments to D25223: Avoid side effects during menu initialization.
Tue, Nov 12, 8:10 AM · Plasma
broulik added a comment to T10201: Window titlebars.

what is the general consensus of having applications be able to set their own colors for titlebars?

No consensus but I don't think we should allow applications to "brand" themselves. They should use whatever color scheme the user has decided for them or the system. If the user set a color scheme for them, then sure, we already have some infrastructure for that in e.g. Kate, Krita. It is possible to set a different color scheme for the decoration but it must be an existing theme on disk, an application cannot set arbitrary colors.

Tue, Nov 12, 8:05 AM · KDE Applications, VDG
broulik committed R119:90f568e17742: Merge branch 'Plasma/5.17' (authored by broulik).
Merge branch 'Plasma/5.17'
Tue, Nov 12, 8:00 AM
broulik committed R119:582bd8e04af0: [Cursor Theme KCM] Elide size ComboBox text (authored by broulik).
[Cursor Theme KCM] Elide size ComboBox text
Tue, Nov 12, 8:00 AM
broulik closed D25264: [Cursor Theme KCM] Elide size ComboBox text.
Tue, Nov 12, 8:00 AM · Plasma
broulik committed R858:d11ba447fa78: [ComboBox] Don't dim Popup (authored by broulik).
[ComboBox] Don't dim Popup
Tue, Nov 12, 7:59 AM
broulik closed D25263: [ComboBox] Don't dim Popup.
Tue, Nov 12, 7:59 AM · Plasma
broulik updated the test plan for D24870: Fixup new Audio() constructor and apply autoplay prevention evasion to document.createElement.
Tue, Nov 12, 7:56 AM · Plasma
broulik updated the diff for D24870: Fixup new Audio() constructor and apply autoplay prevention evasion to document.createElement.
  • Add missing play() call
Tue, Nov 12, 7:53 AM · Plasma

Mon, Nov 11

broulik updated the test plan for D25264: [Cursor Theme KCM] Elide size ComboBox text.
Mon, Nov 11, 7:16 PM · Plasma
broulik requested review of D25264: [Cursor Theme KCM] Elide size ComboBox text.
Mon, Nov 11, 7:14 PM · Plasma
broulik requested review of D25263: [ComboBox] Don't dim Popup.
Mon, Nov 11, 7:09 PM · Plasma
broulik accepted D25252: Fix binding loop in lockscreen media controls.

Clever!

Mon, Nov 11, 2:58 PM · Plasma
broulik abandoned D24688: [KCM] Disallow dropping screen outside of reachable area.
Mon, Nov 11, 10:53 AM · Plasma

Sun, Nov 10

broulik requested review of D24870: Fixup new Audio() constructor and apply autoplay prevention evasion to document.createElement.
Sun, Nov 10, 7:02 PM · Plasma
broulik updated the diff for D24870: Fixup new Audio() constructor and apply autoplay prevention evasion to document.createElement.
  • Only apply hack on playback
  • Use better syntax
  • More testing
Sun, Nov 10, 7:01 PM · Plasma
broulik added inline comments to D25205: Remove pointless QDBusServiceWatcher.
Sun, Nov 10, 5:37 PM · Plasma

Fri, Nov 8

broulik added a comment to D25222: [Lock Screen] Fix album art binding loop.

Painted size depends on the aspect ratio of the loaded image. I think it should just be hard-coded to some icon size or grid unit rather than depend on the highly dynamic font rendering (which governs its size effectively as it's the layout's size)

Fri, Nov 8, 10:34 PM · Plasma
broulik added a comment to D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu.

This causes menus (mostly submenus) to randomly show up when the SNI is updated, e.g. every time VLC changes a track I get its "speed (slower, normal, faster)" menu open:


(note the thick shadow, this is multiple menus stacked ontop of each other)

Fri, Nov 8, 2:25 PM · Plasma
broulik added a comment to D25198: KCM Colors : port color scheme state management to KConfigXT.

Note that the KCM also writes all of the colors into kdeglobals (for whatever reason) - does this also need to be ported? We don't read those colors in the KCM anymore, just write them out when applying, so maybe not.

Fri, Nov 8, 8:57 AM · Plasma

Thu, Nov 7

broulik committed R120:56a43f8ee0ad: [Lock Screen] Add option to hide clock when idle (authored by broulik).
[Lock Screen] Add option to hide clock when idle
Thu, Nov 7, 12:50 PM
broulik closed D24893: [Lock Screen] Add option to hide clock when idle.
Thu, Nov 7, 12:50 PM · Plasma
broulik added inline comments to D25176: Add a displayHint property to Action.
Thu, Nov 7, 10:57 AM · Kirigami
broulik added inline comments to D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible.
Thu, Nov 7, 10:56 AM · Kirigami
broulik added inline comments to D25186: Update internal printer enabled/paused state if it changes externally.
Thu, Nov 7, 10:42 AM

Mon, Nov 4

broulik closed D24883: [ComboBox] Don't indicate focus when popup is open.
Mon, Nov 4, 10:47 AM · Plasma
broulik committed R858:5dc1c74cad6f: [ComboBox] Don't indicate focus when popup is open (authored by broulik).
[ComboBox] Don't indicate focus when popup is open
Mon, Nov 4, 10:47 AM
broulik committed R858:b1452c37b49c: [ComboBox] Follow focusPolicy (authored by broulik).
[ComboBox] Follow focusPolicy
Mon, Nov 4, 10:47 AM
broulik closed D24879: [ComboBox] Follow focusPolicy.
Mon, Nov 4, 10:47 AM · Plasma

Sun, Nov 3

broulik updated subscribers of D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set.

Hmm, where does that happen?

Sun, Nov 3, 2:51 PM · Frameworks
broulik added a comment to D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set.

If you e.g. want to switch to "breeze-dark" this fails as the icons will not be found.

Sun, Nov 3, 2:26 PM · Frameworks

Sat, Nov 2

broulik added a comment to D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set.

Can you expand on that dark theme issue? We just colorize the same SVGs as needed.

Sat, Nov 2, 6:00 PM · Frameworks

Fri, Nov 1

broulik added a comment to D24879: [ComboBox] Follow focusPolicy.

Ping

Fri, Nov 1, 9:48 PM · Plasma
broulik committed R108:66f2e2b158b6: Merge branch 'Plasma/5.17' (authored by broulik).
Merge branch 'Plasma/5.17'
Fri, Nov 1, 9:44 PM
broulik committed R108:87f36f53b3e6: [effects/startupfeedback] Fallback to small icon size when no cursor size is… (authored by broulik).
[effects/startupfeedback] Fallback to small icon size when no cursor size is…
Fri, Nov 1, 9:43 PM
broulik closed D25065: [effects/startupfeedback] Fallback to small icon size when no cursor size is configured.
Fri, Nov 1, 9:43 PM · KWin
broulik added a comment to D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else.

I think it might make sense to move that to libnotification Server so the applet can get the same information without duplicating code there.

Fri, Nov 1, 5:12 PM · Plasma

Thu, Oct 31

broulik planned changes to D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else.

Alright, will disable those

Thu, Oct 31, 9:39 PM · Plasma
broulik added a comment to D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else.

Would it makes sense to also disable all the controls in the KCM when either of these messages are open?

Thu, Oct 31, 9:35 PM · Plasma
broulik updated the test plan for D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else.
Thu, Oct 31, 4:51 PM · Plasma
broulik updated the test plan for D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else.
Thu, Oct 31, 4:50 PM · Plasma
broulik committed R120:e477d80bbbc7: [Digital Clock] Disable custom format input when date option is unchecked (authored by broulik).
[Digital Clock] Disable custom format input when date option is unchecked
Thu, Oct 31, 4:49 PM
broulik closed D25096: [Digital Clock] Disable custom format input when date option is unchecked.
Thu, Oct 31, 4:49 PM · Plasma
broulik requested review of D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else.
Thu, Oct 31, 4:48 PM · Plasma
broulik requested review of D25096: [Digital Clock] Disable custom format input when date option is unchecked.
Thu, Oct 31, 4:43 PM · Plasma
broulik committed R120:6671c13d4cb6: [Digital Clock] Add preview for date format (authored by broulik).
[Digital Clock] Add preview for date format
Thu, Oct 31, 3:28 PM
broulik closed D25091: [Digital Clock] Add preview for date format.
Thu, Oct 31, 3:28 PM · Plasma
broulik added inline comments to D24945: [ksmserver] Signal session management state to kwin directly.
Thu, Oct 31, 2:46 PM · Plasma
broulik requested review of D25091: [Digital Clock] Add preview for date format.
Thu, Oct 31, 12:52 PM · Plasma
broulik added a comment to D25003: [KDesktopFile] Add a property and propertyKde functions to access custom properties.

KDesktopFile::desktopGroup() just gives you a KConfigGroup of the ´[Desktop Entry]` section at which point you can read whatever you want

Thu, Oct 31, 11:23 AM · Frameworks
broulik accepted D25047: [Night Color KCM] Reset seconds and milliseconds in provided timings.
Thu, Oct 31, 9:05 AM · Plasma

Wed, Oct 30

broulik added a comment to T11948: Kiosk self-documentation improvement.

There's basically two types of actions that could be authorized

  • Individual KXmlGui actions (authorizeAction, basically just "action/" + name), like "open", "quit", "paste", "undo", "configure", "show_toolbar", whatever. Perhaps we can just list all the KStandardActions or something. Really hard to get a sensible list out of them, unless we just list *all* of the actions in *all* of kxmlgui rc files... Could be useful for some other purpose, maybe still.
  • A bunch of keys (authorize), like "run_command" (which I think even is/was an action...), "switch_user", "ghns", "start_session", "shell_access", "lineedit_autocomplete", etc. I would be in favor of having an enum for those.
Wed, Oct 30, 9:01 PM · KF6
broulik added a comment to T11627: Improve KIO asynchronicity.

I'm pretty sure there's a tonne of blocking DBus calls being done all over the place during file copy (checking for slaves on hold, updating kuiserver job tracking info, etc) which can cause apps to hang or slow down if whatever they're trying to call into is busy. Best example: SIGSTOP plasmashell, try copying a file in Dolphin, won't work until plasmashell SIGCONTs.

Wed, Oct 30, 8:10 PM · Dolphin, Frameworks
broulik accepted D24701: Notify about change after cursor config is saved.
Wed, Oct 30, 4:25 PM · Plasma
broulik added a reviewer for D25055: [containments/desktop] Delete the "Tweaks" page and its options: hein.
Wed, Oct 30, 2:53 PM · Plasma
broulik added a comment to D25055: [containments/desktop] Delete the "Tweaks" page and its options.

+1

Wed, Oct 30, 2:53 PM · Plasma
broulik planned changes to D24870: Fixup new Audio() constructor and apply autoplay prevention evasion to document.createElement.
Wed, Oct 30, 11:55 AM · Plasma
broulik accepted D25076: Force reevaluating state on pending deletion changes.
Wed, Oct 30, 11:49 AM · Plasma
broulik added a comment to D24744: Remove unneeded options in GTK KCM.

remove it from the view and always set it to "one page per click"?

Absolutely not.

Wed, Oct 30, 10:48 AM · VDG, Plasma
broulik committed R856:9d23911e002f: Add Itinerary Extractor support (authored by broulik).
Add Itinerary Extractor support
Wed, Oct 30, 10:12 AM
broulik added a comment to T11535: Organize 2019 KF6 sprint.

Interested! :)
Reimbursements event: https://reimbursements.kde.org/events/114

Wed, Oct 30, 9:35 AM · KF6
broulik updated the test plan for D25065: [effects/startupfeedback] Fallback to small icon size when no cursor size is configured.
Wed, Oct 30, 7:37 AM · KWin
broulik requested review of D25065: [effects/startupfeedback] Fallback to small icon size when no cursor size is configured.
Wed, Oct 30, 7:37 AM · KWin

Tue, Oct 29

broulik accepted D25048: Expose libkworkspace SessionManagement class to QML.
Tue, Oct 29, 4:50 PM · Plasma
broulik added a comment to D24958: Delete nepomuk icon.

https://cgit.kde.org/dolphin.git/tree/src/panels/information/informationpanelcontent.cpp#n231

Tue, Oct 29, 1:42 PM · Frameworks
broulik committed R112:eed4eb1ed5a1: [ResultDelegate] Use theme.disabledColor (authored by broulik).
[ResultDelegate] Use theme.disabledColor
Tue, Oct 29, 1:32 PM
broulik closed D25043: [ResultDelegate] Use theme.disabledColor.
Tue, Oct 29, 1:32 PM · Plasma
broulik added a comment to D25043: [ResultDelegate] Use theme.disabledColor.
in fact this is what I get now when testing this patch with Breeze and the Breeze Dark color scheme:

Make sure your plasma-framework is up to date

Tue, Oct 29, 1:24 PM · Plasma
broulik committed R1034:829ea6461c2b: Lower CMake minimum requirement (authored by broulik).
Lower CMake minimum requirement
Tue, Oct 29, 1:23 PM
broulik closed D25040: Lower CMake minimum requirement.

https://invent.kde.org/kde/kirogi/commit/829ea6461c2b3abd699c2c0b6afa17bde7262a09

Tue, Oct 29, 1:22 PM
broulik added a comment to D24958: Delete nepomuk icon.

Note that Dolphin still uses that icon for its information panel when in search mode.

Tue, Oct 29, 1:04 PM · Frameworks
broulik requested review of D25043: [ResultDelegate] Use theme.disabledColor.
Tue, Oct 29, 12:24 PM · Plasma
broulik updated the test plan for D25040: Lower CMake minimum requirement.
Tue, Oct 29, 9:32 AM
broulik requested review of D25040: Lower CMake minimum requirement.
Tue, Oct 29, 9:31 AM
broulik added inline comments to D24865: [SystemTray] Support for AttentionIcon.
Tue, Oct 29, 8:57 AM · Plasma

Mon, Oct 28

broulik added inline comments to D24997: [Lock & Login Screens] Don't use a black shadow with black text.
Mon, Oct 28, 7:52 AM · Plasma
broulik added a comment to D24995: Fix terminal not always gaining focus when shown.

Doesn't terminal widget need to set the konsole part as focus proxy? This looks like a workaround

Mon, Oct 28, 7:37 AM · Dolphin

Fri, Oct 25

broulik added a comment to D24916: KCM style : fix combobox that weren't updated after user made change.

It's likely we'll encounter that ComboBox breakage at other places.

we do :) https://cgit.kde.org/kscreen.git/tree/kcm/package/contents/ui/Panel.qml?id=7811411c6425dd52bcd732a5910d177fee4a89d2#n42

Fri, Oct 25, 2:44 PM · Plasma
broulik added a comment to D24916: KCM style : fix combobox that weren't updated after user made change.

Ah somehow I thought we had a third more "clever" case of currentIndex moving.

Heh, yea, there's also some more elaborate "change index while moving the mouse" going on :(
So best hack would be to have a c++ thing that sets the property without going through QML's binding system :D

Fri, Oct 25, 2:37 PM · Plasma
broulik added a comment to D24916: KCM style : fix combobox that weren't updated after user made change.

AFAICT it won't be pretty though. :-)

I think it's pretty straightforward
1.) the delegate must not explicitly set a currentIndex because Qt does it for us, see D18299
2.) the wheel handler must be changed to call decrementCurrentIndex() and incrementCurrentIndex() (hopefully they wrap...) instead of changing the index manually, so it doesn't break the binding.

Fri, Oct 25, 2:09 PM · Plasma
broulik added a comment to D24916: KCM style : fix combobox that weren't updated after user made change.

Hm I think qqc2-desktop-style breaks the binding on currentIndex, otherwise this would not be neccessary...

Fri, Oct 25, 1:36 PM · Plasma
broulik added a comment to D24476: [KPropertiesDialog] Only show volume-related info for volumes.

Don't you already have the free space information in the status bar though?

Fri, Oct 25, 12:47 PM · Frameworks
broulik updated the task description for T11849: Stuff and swag.
Fri, Oct 25, 12:13 PM · KDE Promo
broulik added a comment to D24798: Migrate QQC1 to QQC2.

That new time zone view lacks any form of keyboard navigation. I cannot use arrow keys to navigate it and neither can I hit space to toggle a checkbox. It also lacks a frame around its content area like the text field has.

Fri, Oct 25, 8:28 AM · Plasma

Thu, Oct 24

broulik added inline comments to D24934: [notifications] Center no notification text on mobile.
Thu, Oct 24, 9:51 PM · Plasma
broulik accepted D24934: [notifications] Center no notification text on mobile.

Fix it, then ship it

Thu, Oct 24, 9:33 PM · Plasma
broulik requested changes to D24934: [notifications] Center no notification text on mobile.

Keep the width and enable wrapping and horizontal centering. We both know how wide some locale can get :)

Thu, Oct 24, 9:21 PM · Plasma
broulik added a comment to T11537: Investigate a QAction/QML Action unification upstream.

There's work being done on a QGuiAction and QGuiShortcut: https://codereview.qt-project.org/c/qt/qtbase/+/265909

Thu, Oct 24, 7:04 PM · KF6
broulik closed D24926: [ResultsView] Expose limit.

https://cgit.kde.org/milou.git/commit/?id=eda3d274da1d502e61e24fa41f6b23b9f236baed

Thu, Oct 24, 3:26 PM · Plasma
broulik committed R112:eda3d274da1d: [ResultsView] Expose limit (authored by broulik).
[ResultsView] Expose limit
Thu, Oct 24, 3:26 PM
broulik requested review of D24926: [ResultsView] Expose limit.
Thu, Oct 24, 3:25 PM · Plasma