- User Since
- Dec 14 2015, 3:47 PM (114 w, 6 d)
Also I think all of this will become obsolete with Qt 5.11 where it supports multiple platform plugins as a fallback chain: https://codereview.qt-project.org/#/c/220294/
I'm not too fond of that extra button on its own line. Can we perhaps add a "Empty Trash" (also capitalize the T) button to the tool bar dynamically like it's done with the "Control" button (only shown when menu is hidden, could take some code inspiration from it)
Makes sense. Thanks!
Can you check whether this affects Task manager also?
Framework for […] tracking users
Fri, Feb 23
- Remove debug
Thu, Feb 22
Wed, Feb 21
This was to keep an auto-hidden panel visible but I think the panel (at least Plasma, dunno about latte) is smart enough to stay open when a transient child is open, see 2d8b4e1dec26c5976dd75c238c3ae8a4700b8dd9
Could that be a candidate for KWidgetsAddons? Though, perhaps if it turns out to be useful elsewhere it can still be moved there.
Tue, Feb 20
If we were to do this, we need to first make Device Notifier not freak out when you have a wonky USB cable.
and then copy the correct or suggested into the clipboard for further usage?
Thanks! I assume you tested it with a light color scheme also. 5.12 branch pls
See D10684 to make it easy for users to bring it back
shipit once you addressed the other comments
I added a similar check in Storage Volume but did not here.. :/
Can this property become something more official, with real documentation
Thanks for this patch! It does not take into account device pixel ratio, ie. screen scaling. Here the screenshots turn into half (a quarter) the size they should have since I'm on a 2x scaled screen.
Mon, Feb 19
Those magic values are copied straight from Plasma TextFieldStyle
Shouldn't we fix it?
Okay, nevermind. Go for it then!
I just received a +2 for my Qt patch and will merge it. This is obsolete then. Thanks, Hugo!
If no Frameworks dev objects within next few days this will be pushed
Sun, Feb 18
A quick search through plasma codebase reveals that setResult followed by emitResult is done quite often. Care to fix these, too? :)
Fri, Feb 16
There surely needs to be some CMake change somewhere with the version?
Thu, Feb 15
If and when this goes in, any chance you could land it for 5.12.x?
Strictly speaking, this is a behavior change, feature, not a bugfix per se.
This would let Kubuntu get rid of a downstream override, and help other distros planning to package 5.12.
They could have told us earlier that they're patching it… distros could also just apply this patch if they want to.
and others excluding Kickoff :P
Looks good to me but I don't feel confident enough to give it a shipit but if it fixes the unittest and works..
I would actually prefer the class to be KRunner::AbstractRunner but that's obviously not something we could change.
PlasmaComponents.MenuItem is a QQuickItem, for whatever reason, I suspect for recursive enabled/visible handling, and with my patch it then complains about not having been placed in a scene.