broulik (Kai Uwe Broulik)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Dec 14 2015, 3:47 PM (192 w, 1 d)
Availability
Available

Recent Activity

Today

broulik accepted D23319: Add dark theme icons.
Wed, Aug 21, 2:40 PM · Plasma
broulik committed R856:7bf9b738bcd2: Apply browser_style to action popup (authored by broulik).
Apply browser_style to action popup
Wed, Aug 21, 2:39 PM
broulik accepted D23318: Add dark theme in the extension popup.

Cool!

Wed, Aug 21, 2:16 PM · Plasma
broulik committed R856:57456679dfcf: Replace sad-face PNGs by SVG (authored by broulik).
Replace sad-face PNGs by SVG
Wed, Aug 21, 2:03 PM
broulik committed R856:4356d9306990: Add browser action for status reporting (authored by broulik).
Add browser action for status reporting
Wed, Aug 21, 2:00 PM
broulik closed D23126: Add browser action for status reporting.
Wed, Aug 21, 2:00 PM · Plasma
broulik added inline comments to D22513: Expose if we're still searching for more results.
Wed, Aug 21, 1:43 PM · Plasma
broulik added a comment to D23317: Change icon colors, add disabled icons.

shipit!

Wed, Aug 21, 1:37 PM · Plasma
broulik accepted D23317: Change icon colors, add disabled icons.

Thanks

Wed, Aug 21, 1:35 PM · Plasma
broulik committed R856:d4ab4e922404: Enable enhanced media controls by default (authored by broulik).
Enable enhanced media controls by default
Wed, Aug 21, 1:17 PM
broulik closed D23122: Enable enhanced media controls by default.
Wed, Aug 21, 1:17 PM · Plasma
broulik committed R120:b32043331643: Merge branch 'Plasma/5.16' (authored by broulik).
Merge branch 'Plasma/5.16'
Wed, Aug 21, 12:29 PM
broulik committed R120:5806f4969604: [Notifications] Bring back dismissed progress in case of crash (authored by broulik).
[Notifications] Bring back dismissed progress in case of crash
Wed, Aug 21, 12:28 PM
broulik closed D23294: [Notifications] Bring back dismissed progress in case of crash.
Wed, Aug 21, 12:28 PM · Plasma
broulik committed R120:1315ea0d3707: Don't auto-restart KRunner when crashed (authored by broulik).
Don't auto-restart KRunner when crashed
Wed, Aug 21, 12:28 PM
broulik closed D23056: RFC: Don't auto-restart KRunner when crashed.
Wed, Aug 21, 12:28 PM · Plasma
broulik accepted D23314: Fix runnertest exiting early.
Wed, Aug 21, 11:44 AM · Frameworks
broulik added a comment to D23313: improve code in Snore backend.

I don't really see the point in this cleanup as it only messes up git history and doesn't actually follow coding style better

Wed, Aug 21, 6:48 AM · Frameworks

Yesterday

broulik added a comment to D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob.

This map will keep growing and growing...

Tue, Aug 20, 3:39 PM · Frameworks
broulik retitled D23295: [Tab Bar] Resolve tab icon only if visible from [Tab Bar] Resolve tab icon lazily to [Tab Bar] Resolve tab icon only if visible.
Tue, Aug 20, 3:30 PM · Dolphin
broulik updated the test plan for D23295: [Tab Bar] Resolve tab icon only if visible.
Tue, Aug 20, 3:28 PM · Dolphin
broulik requested review of D23295: [Tab Bar] Resolve tab icon only if visible.
Tue, Aug 20, 3:27 PM · Dolphin
broulik requested review of D23294: [Notifications] Bring back dismissed progress in case of crash.
Tue, Aug 20, 3:08 PM · Plasma
broulik requested review of D23293: [Notifications] Implement JobViewV2.
Tue, Aug 20, 2:55 PM · Plasma
broulik added inline comments to D23287: Create a plugin framework for processes.
Tue, Aug 20, 2:25 PM · Plasma
broulik accepted D22885: Add global animation speed slider to workspace options KCM.
Tue, Aug 20, 1:51 PM · Plasma
broulik accepted D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces.
Tue, Aug 20, 1:37 PM · Frameworks
broulik accepted D23196: have 1024x1024 app icon as fallback icon in Snore.
Tue, Aug 20, 1:13 PM · Frameworks
broulik added a comment to D23286: Prevent dragging SimpleKCM contents outside view.

Can we keep it on mobile?

Tue, Aug 20, 8:49 AM · Frameworks
broulik added a comment to D13757: Move parsing .desktop file for folder Comment to file KIO.

Theres's also the directory icon reading which potentially blocks, so doing both in the KIO slave improves the situation without having to introduce new API and rewrite everything and the kitchen sink.

Tue, Aug 20, 7:20 AM · Frameworks
broulik accepted D23271: [Battery Monitor] Call battery capacity "Capacity degradation" for better clarity.
Tue, Aug 20, 6:43 AM · Plasma
broulik added a comment to D23283: When asked to switch sessions, skip to session creation if there's nothing to switch to.

Screenshots please

Tue, Aug 20, 6:40 AM · Plasma
broulik added a comment to D23261: Add option to discourage reporting bugs.

Whatever happened to m_iconName?

Tue, Aug 20, 6:39 AM · Plasma

Mon, Aug 19

broulik accepted D22896: Port System Settings sidebar to QQC2.

Fix it, then shipit!

Mon, Aug 19, 4:32 PM · Plasma
broulik updated the summary of D23261: Add option to discourage reporting bugs.
Mon, Aug 19, 1:26 PM · Plasma
broulik requested review of D23261: Add option to discourage reporting bugs.
Mon, Aug 19, 1:25 PM · Plasma
broulik accepted D23260: [Battery plasmoid] do not show vendor and product, always show battery details.

Thanks

Mon, Aug 19, 11:47 AM · Plasma
broulik added a comment to D23237: Do not display vendor, Product and capacity in network plasmoid.

It literally says in the commit message that this will be moved exactly there.

Mon, Aug 19, 8:59 AM · Plasma
broulik requested changes to D23237: Do not display vendor, Product and capacity in network plasmoid.
Mon, Aug 19, 8:58 AM · Plasma
broulik reopened D23237: Do not display vendor, Product and capacity in network plasmoid.

You cannot remove those from the dataengine, which is "Public API", there might be other users of that.
Instead, remove them from the battery monitor UI. And while at it maybe show the details always even if there are multiple batteries.
Capacity is also used in battery monitor to show a hint like "Your battery is broken"

Mon, Aug 19, 8:48 AM · Plasma
broulik added a comment to D23255: Change warning dialog box to a question dialog box.

I think a warning is appropriate as opening a gazillion applications could lead to an unresponsive system.

Mon, Aug 19, 8:39 AM · Dolphin
broulik accepted D22852: Allow applets/containments/wallpaper to defer UIReadyConstraint.
Mon, Aug 19, 8:38 AM · Frameworks
broulik added a comment to D23253: [Notifications] Don't allow popup to obscure things in corners.

Not a fan.

Mon, Aug 19, 6:56 AM · Plasma

Fri, Aug 16

broulik added a comment to D22896: Port System Settings sidebar to QQC2.

Working very nice now! Just some minor nitpicks then this can go in

Fri, Aug 16, 12:37 PM · Plasma
broulik added a comment to D23198: Skip mime type check only for files on network mounts.

fileSystemType calls statvfs which might also block, so I don't think this helps.

Fri, Aug 16, 11:58 AM · Plasma
broulik added inline comments to D23196: have 1024x1024 app icon as fallback icon in Snore.
Fri, Aug 16, 6:47 AM · Frameworks

Thu, Aug 15

broulik updated the diff for D23151: Implement Web Share API through Purpose.
  • Reset to -1
  • Use urls again
Thu, Aug 15, 2:49 PM · Plasma
broulik updated the diff for D23151: Implement Web Share API through Purpose.
  • Address comments
Thu, Aug 15, 2:44 PM · Plasma
broulik added inline comments to D23151: Implement Web Share API through Purpose.
Thu, Aug 15, 2:07 PM · Plasma
broulik added inline comments to D23151: Implement Web Share API through Purpose.
Thu, Aug 15, 2:06 PM · Plasma
broulik added inline comments to D23151: Implement Web Share API through Purpose.
Thu, Aug 15, 7:02 AM · Plasma
broulik accepted D23157: Expose technology property in battery interface.
Thu, Aug 15, 6:59 AM · Frameworks

Wed, Aug 14

broulik accepted D22376: new env var DRKONQI_HTTP_DELAY_MS to force a connection delay.
Wed, Aug 14, 2:33 PM · Plasma
broulik added a comment to D22885: Add global animation speed slider to workspace options KCM.

We agreed that code-wise a multiplier is easier but then the name of the group should be adjusted to reflect that.

Wed, Aug 14, 1:16 PM · Plasma
broulik updated the diff for D23151: Implement Web Share API through Purpose.
  • Remove leftover testing code
Wed, Aug 14, 12:00 PM · Plasma
broulik requested review of D23151: Implement Web Share API through Purpose.
Wed, Aug 14, 11:13 AM · Plasma
broulik updated the diff for D23126: Add browser action for status reporting.
  • Rebase
Wed, Aug 14, 9:06 AM · Plasma
broulik committed R856:55d78db657be: Allow hiding option items depending on available extension and version in the… (authored by broulik).
Allow hiding option items depending on available extension and version in the…
Wed, Aug 14, 9:03 AM
broulik closed D21113: Allow hiding option items depending on available extension and version in the host.
Wed, Aug 14, 9:03 AM · Plasma
broulik updated the diff for D21113: Allow hiding option items depending on available extension and version in the host.
  • Check the right thing...
Wed, Aug 14, 8:55 AM · Plasma
broulik updated the diff for D21113: Allow hiding option items depending on available extension and version in the host.
  • required→requires
  • redundant check
  • ret var
Wed, Aug 14, 8:52 AM · Plasma
broulik added a comment to D21113: Allow hiding option items depending on available extension and version in the host.

Depends on the

Wed, Aug 14, 8:49 AM · Plasma
broulik added a comment to D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces.

Then please investigate what's going on there.

Wed, Aug 14, 8:31 AM · Frameworks
broulik updated the diff for D21113: Allow hiding option items depending on available extension and version in the host.
  • use new promise-based reply message API
Wed, Aug 14, 8:19 AM · Plasma
broulik requested review of D23145: [Exe Thumbnailer] Match 16 bit executables and don't request icon types wrestool cannot handle.
Wed, Aug 14, 7:51 AM · Frameworks, Dolphin
broulik added inline comments to D21760: Add KListOpenFiles::listProcessesWithOpenFiles.
Wed, Aug 14, 6:55 AM · Frameworks
broulik added inline comments to D23112: Add a event Spy for GtkFileChooser recent files.
Wed, Aug 14, 6:52 AM · Plasma
broulik added a comment to D23130: [energy kcm] Remove bogus Has power supply property from UI.

That property is whether the selected battery powers the computer or is just a peripheral. Perhaps just the label must be changed?

Wed, Aug 14, 6:51 AM · Plasma
broulik added a comment to D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces.

I think this is a bug in KDE Connect? I've seen numerous people complain about that in the new notification system that didn't filter them out originally.

Wed, Aug 14, 6:50 AM · Frameworks

Tue, Aug 13

broulik requested review of D23126: Add browser action for status reporting.
Tue, Aug 13, 1:59 PM · Plasma
broulik committed R856:32a4fce2aa74: Allow sending a port message and receive a reply (authored by broulik).
Allow sending a port message and receive a reply
Tue, Aug 13, 1:45 PM
broulik closed D23099: Allow sending a port message and receive a reply.
Tue, Aug 13, 1:45 PM · Plasma
broulik updated the diff for D23099: Allow sending a port message and receive a reply.
  • We're signed int :)
Tue, Aug 13, 9:17 AM · Plasma
broulik updated the diff for D23099: Allow sending a port message and receive a reply.
  • Properly support zero as serial
  • Wrap int max properly
Tue, Aug 13, 9:15 AM · Plasma
broulik added a comment to D23099: Allow sending a port message and receive a reply.

Didn't add it to settings as I have some follow-up patches that will actually use the other overload, too

Tue, Aug 13, 8:56 AM · Plasma
broulik updated the diff for D23099: Allow sending a port message and receive a reply.
  • Silence method hidden warning
Tue, Aug 13, 8:55 AM · Plasma
broulik committed R119:3417dd1620c7: [Notifications KCM] Add checkbox for enabling do not disturb mode when screens… (authored by broulik).
[Notifications KCM] Add checkbox for enabling do not disturb mode when screens…
Tue, Aug 13, 8:18 AM
broulik closed D22857: [Notifications KCM] Add checkbox for enabling do not disturb mode when screens are mirrored.
Tue, Aug 13, 8:18 AM · Plasma
broulik committed R120:523ef16369cc: [Notifications] Enable do not disturb mode when screens are mirrored (authored by broulik).
[Notifications] Enable do not disturb mode when screens are mirrored
Tue, Aug 13, 8:17 AM
broulik closed D22856: [Notifications] Enable do not disturb mode when screens are mirrored.
Tue, Aug 13, 8:17 AM · Plasma
broulik added inline comments to D23099: Allow sending a port message and receive a reply.
Tue, Aug 13, 7:54 AM · Plasma
broulik requested review of D23122: Enable enhanced media controls by default.
Tue, Aug 13, 7:34 AM · Plasma
broulik committed R856:c8572d6cbed5: Let settings work with arbitrary input controls (authored by broulik).
Let settings work with arbitrary input controls
Tue, Aug 13, 7:29 AM
broulik closed D23100: Let settings work with arbitrary input controls.
Tue, Aug 13, 7:29 AM · Plasma
broulik updated the diff for D23100: Let settings work with arbitrary input controls.
  • Don't write config keys for which we don't have a default
Tue, Aug 13, 7:09 AM · Plasma

Mon, Aug 12

broulik updated the diff for D23100: Let settings work with arbitrary input controls.
Mon, Aug 12, 9:00 PM · Plasma
broulik committed R856:a181a9e5b3e8: Handle media session callbacks before passing it on to the browser (authored by broulik).
Handle media session callbacks before passing it on to the browser
Mon, Aug 12, 8:55 PM
broulik closed D23090: Handle media session callbacks before passing it on to the browser.
Mon, Aug 12, 8:55 PM · Plasma
broulik added inline comments to D23099: Allow sending a port message and receive a reply.
Mon, Aug 12, 8:54 PM · Plasma
broulik updated the diff for D23099: Allow sending a port message and receive a reply.
  • address review comments
Mon, Aug 12, 8:27 PM · Plasma
broulik added inline comments to D23100: Let settings work with arbitrary input controls.
Mon, Aug 12, 8:06 PM · Plasma
broulik updated the diff for D23090: Handle media session callbacks before passing it on to the browser.
  • Register ourselves before passing on to the browser which may throw
Mon, Aug 12, 8:04 PM · Plasma
broulik committed R856:2a6557e41e2a: Call media session callback with details (authored by broulik).
Call media session callback with details
Mon, Aug 12, 7:58 PM
broulik closed D23091: Call media session callback with details.
Mon, Aug 12, 7:58 PM · Plasma
broulik committed R856:77128e353466: Slightly prettier debug (authored by broulik).
Slightly prettier debug
Mon, Aug 12, 7:58 PM
broulik closed D23107: Slightly prettier debug.
Mon, Aug 12, 7:58 PM · Plasma
broulik added inline comments to D22896: Port System Settings sidebar to QQC2.
Mon, Aug 12, 4:10 PM · Plasma
broulik added inline comments to D23112: Add a event Spy for GtkFileChooser recent files.
Mon, Aug 12, 12:27 PM · Plasma
broulik added a comment to D23112: Add a event Spy for GtkFileChooser recent files.

Can you check out the KBookmarks framework which has classes for processing xbel files

Mon, Aug 12, 12:21 PM · Plasma
broulik updated the test plan for D23107: Slightly prettier debug.
Mon, Aug 12, 9:10 AM · Plasma