broulik (Kai Uwe Broulik)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Dec 14 2015, 3:47 PM (201 w, 21 h)
Availability
Available

Recent Activity

Today

broulik added a comment to D24865: [SystemTray] Support for AttentionIcon.

You might want to split that into a proper if statement otherwise it becomes somewhat hard to read. Something like

source: {
    if (taskIcon.status === PlasmaCore.Types.NeedsAttentionStatus && (AttentionIcon || AttentionIconName)) {
        return AttentionIcon || AttentionIconName;
    }
    return Icon || IconName;
}
Tue, Oct 22, 1:05 PM · Plasma
broulik accepted D24865: [SystemTray] Support for AttentionIcon.

Thanks for following up!

Tue, Oct 22, 1:02 PM · Plasma
broulik added a comment to D24865: [SystemTray] Support for AttentionIcon.

PlasmaCore.IconItem has a status property, so you probably need to explicitly check taskIcon.status then it should work with the proper enum

Tue, Oct 22, 12:53 PM · Plasma
broulik added a comment to D24767: [SystemTray] Support for AttentionIcon.

Doesn't this break the binding for source? My tray icons don't update anymore

Tue, Oct 22, 11:44 AM · Plasma
broulik accepted D24765: Notification applet on the phone.
Tue, Oct 22, 10:01 AM · Plasma
broulik committed R119:6355a5a1e4ff: Merge branch 'Plasma/5.17' (authored by broulik).
Merge branch 'Plasma/5.17'
Tue, Oct 22, 9:39 AM
broulik committed R119:c79902431d9a: [Desktop Toolbox] Add missing i18n domain (authored by broulik).
[Desktop Toolbox] Add missing i18n domain
Tue, Oct 22, 9:38 AM
broulik closed D24854: [Desktop Toolbox] Add missing i18n domain.
Tue, Oct 22, 9:38 AM · Plasma
broulik requested review of D24854: [Desktop Toolbox] Add missing i18n domain.
Tue, Oct 22, 9:36 AM · Plasma
broulik committed R120:5db30d8885c9: Merge branch 'Plasma/5.17' (authored by broulik).
Merge branch 'Plasma/5.17'
Tue, Oct 22, 8:59 AM
broulik committed R120:549374ba5f1e: [Windows Runner] Gather window again when running result (authored by broulik).
[Windows Runner] Gather window again when running result
Tue, Oct 22, 8:58 AM
broulik closed D24849: [Windows Runner] Gather window again when running result.
Tue, Oct 22, 8:58 AM · Plasma
broulik requested review of D24849: [Windows Runner] Gather window again when running result.
Tue, Oct 22, 7:56 AM · Plasma
broulik added inline comments to D24839: Only show "Unlock Widgets" in the UI, not "Lock Widgets".
Tue, Oct 22, 7:13 AM · Plasma
broulik added a comment to D24844: [Applet] Remove hamburger button and menu.

Big -1 to removing it on similar grounds as I also quite frequently use the raise maximum volume feature.

Tue, Oct 22, 7:11 AM · Plasma
broulik added inline comments to D24846: Port kcm icons to kconfigxt.
Tue, Oct 22, 7:06 AM · Plasma
broulik added a comment to D24847: KCM Icons fix theme selected when we hit delete theme.

Hmm, let's see what VDG thinks about that.

Tue, Oct 22, 7:01 AM · Plasma
broulik accepted D24848: fix kcm fonts "typo" on connect.

Interesting, I thought Qt would/could static_assert that

Tue, Oct 22, 6:59 AM · Plasma
broulik added inline comments to D24845: KCM don't support icons effect anymore, clean-up config file.
Tue, Oct 22, 6:58 AM · Plasma
broulik accepted D24845: KCM don't support icons effect anymore, clean-up config file.
Tue, Oct 22, 6:58 AM · Plasma
broulik added a comment to D24688: [KCM] Disallow dropping screen outside of reachable area.

So, what about this now? Or is there an auto scale patch anywhere?

Tue, Oct 22, 6:42 AM · Plasma

Yesterday

broulik updated the task description for T11848: Devices.
Mon, Oct 21, 12:44 PM · KDE Promo
broulik updated the task description for T11848: Devices.
Mon, Oct 21, 12:44 PM · KDE Promo
broulik committed R124:69138ea80deb: Merge branch 'Plasma/5.17' (authored by broulik).
Merge branch 'Plasma/5.17'
Mon, Oct 21, 11:09 AM
broulik committed R124:ec90e4066c16: Filter invalid services in most used model (authored by broulik).
Filter invalid services in most used model
Mon, Oct 21, 11:08 AM
broulik closed D24818: Filter invalid services in most used model.
Mon, Oct 21, 11:08 AM · Plasma
broulik committed R120:7673a6a096cd: Merge branch 'Plasma/5.17' (authored by broulik).
Merge branch 'Plasma/5.17'
Mon, Oct 21, 10:00 AM
broulik closed D24823: [startplasma] Pass actual variable to kapplymousetheme.
Mon, Oct 21, 10:00 AM · Plasma
broulik committed R120:b59af69b6521: [startplasma] Pass actual variable to kapplymousetheme (authored by broulik).
[startplasma] Pass actual variable to kapplymousetheme
Mon, Oct 21, 10:00 AM
broulik added a reviewer for D24823: [startplasma] Pass actual variable to kapplymousetheme: romangg.
Mon, Oct 21, 9:38 AM · Plasma
broulik requested review of D24823: [startplasma] Pass actual variable to kapplymousetheme.
Mon, Oct 21, 9:38 AM · Plasma
broulik added a comment to T11849: Stuff and swag.

Konqi Qt sticker


KDE Logo

Beer coaster

Mon, Oct 21, 9:12 AM · KDE Promo
broulik accepted D24723: Fix slideshow crashing in invalidate().
Mon, Oct 21, 8:46 AM · Plasma
broulik requested review of D24818: Filter invalid services in most used model.
Mon, Oct 21, 6:50 AM · Plasma
broulik added a comment to D24816: [Applet] Make spinboxes editable.

Does it also need a valueFromText function then?

Mon, Oct 21, 6:31 AM · Plasma

Sat, Oct 19

broulik added a comment to T11637: Investigate if KIconThemes is needed as a framework.

Panel icon size is used as *maximum* size a widget may grow in the panel so they don't get insanely huge when you have a thick panel.

Sat, Oct 19, 1:13 PM · KF6

Fri, Oct 18

broulik added a comment to T11637: Investigate if KIconThemes is needed as a framework.

For icon sizes, would that be something worth adding to QStyleHints in Qt? There's also already some icon size stuff in QStyle. Our QPT could then read those values from kdeglobals like normal.

Fri, Oct 18, 6:39 PM · KF6
broulik added a comment to T11642: Split plasma-framework.

Anything related to applets/

Fri, Oct 18, 6:36 PM · Plasma, KF6
broulik added a comment to D24763: [kcms/nightcolor] Add hints to temperature slider direction.

Nevermind I am an idiot and don't know how (colo(u)r) temperature works.

Fri, Oct 18, 5:47 PM · Plasma
broulik added a comment to D24763: [kcms/nightcolor] Add hints to temperature slider direction.

In right to left layout the labels must be swapped.

Fri, Oct 18, 5:46 PM · Plasma
broulik accepted D24758: [KEditFileType] Add a desktop file.
Fri, Oct 18, 2:16 PM · Plasma
broulik added a comment to D24758: [KEditFileType] Add a desktop file.

Should this be NoDisplay since you can't just launch it without an argument

Fri, Oct 18, 1:42 PM · Plasma
broulik committed R119:e06e897f9d45: Port away from KIconThemes (authored by broulik).
Port away from KIconThemes
Fri, Oct 18, 1:19 PM
broulik closed D24757: Port away from KIconThemes.
Fri, Oct 18, 1:19 PM · Plasma
broulik committed R120:88c1f2093cac: Port away from KIconThemes (authored by broulik).
Port away from KIconThemes
Fri, Oct 18, 1:18 PM
broulik closed D24756: Port away from KIconThemes.
Fri, Oct 18, 1:18 PM · Plasma
broulik requested review of D24757: Port away from KIconThemes.
Fri, Oct 18, 12:27 PM · Plasma
broulik requested review of D24756: Port away from KIconThemes.
Fri, Oct 18, 12:23 PM · Plasma
broulik committed R120:16e9f977551c: Drop unused KIconThemes dependency (authored by broulik).
Drop unused KIconThemes dependency
Fri, Oct 18, 12:05 PM
broulik added a comment to D15451: Let KUrlCombo operate on QIcon instead of QPixmap.

However, setDummyHistoryEntry has some logic for icon being null and "reuse previous pixmap if null" which would be moot if I change it to always fall back to application-octet-stream?

Fri, Oct 18, 11:15 AM · Frameworks
broulik planned changes to D15451: Let KUrlCombo operate on QIcon instead of QPixmap.

Yes.

Fri, Oct 18, 11:11 AM · Frameworks
broulik committed R119:739014d98f89: Merge branch 'Plasma/5.17' (authored by broulik).
Merge branch 'Plasma/5.17'
Fri, Oct 18, 9:06 AM
broulik committed R119:58fe6dabbb0f: [Style KCM] Don't explicitly reload KWin's configuration (authored by broulik).
[Style KCM] Don't explicitly reload KWin's configuration
Fri, Oct 18, 9:06 AM
broulik closed D24260: [Style KCM] Don't explicitly reload KWin's configuration.
Fri, Oct 18, 9:06 AM · Plasma
broulik added a comment to D24744: Remove unneeded options in GTK KCM.

Ideally, we'd also sync SH_ScrollBar_LeftClickAbsolutePosition to GTK and drop the cursor to position radios

Fri, Oct 18, 7:52 AM · VDG, Plasma
broulik committed R120:9c7a902eec08: Merge branch 'Plasma/5.17' (authored by broulik).
Merge branch 'Plasma/5.17'
Fri, Oct 18, 7:03 AM
broulik committed R120:1be4bb880fde: [Media Controller] Multiple artists support (authored by lesf0).
[Media Controller] Multiple artists support
Fri, Oct 18, 7:03 AM
broulik closed D24740: [Media Controller] Multiple artists support.
Fri, Oct 18, 7:03 AM · Plasma
broulik added a comment to D24743: Update GTK settings according to Plasma settings.

Pretty cool!
Some minor nitpicks.
Once all the KCMs have been ported to KConfigXT (XML config description, currently ongoing) we'll have a compile-time checked way to read KDE settings and easier way to get the default values.

Fri, Oct 18, 6:53 AM · VDG, Plasma

Thu, Oct 17

broulik added inline comments to D24740: [Media Controller] Multiple artists support.
Thu, Oct 17, 5:28 PM · Plasma
broulik committed R108:6429019a0f31: Merge branch 'Plasma/5.17' (authored by broulik).
Merge branch 'Plasma/5.17'
Thu, Oct 17, 5:04 PM
broulik committed R108:2497f901d712: [effects/startupfeedback] Scale application icon size with cursor size (authored by broulik).
[effects/startupfeedback] Scale application icon size with cursor size
Thu, Oct 17, 5:04 PM
broulik closed D24714: [effects/startupfeedback] Scale application icon size with cursor size.
Thu, Oct 17, 5:04 PM · KWin
broulik added a comment to D24734: [KCM] remove the page indicator dots.

I don't think the complaints are about the dots, it's a complaint that they're the only means of accessing disabled outputs (discount swiping), which is rectified by the combo box.

Thu, Oct 17, 5:00 PM · Plasma
broulik added inline comments to D24723: Fix slideshow crashing in invalidate().
Thu, Oct 17, 4:43 PM · Plasma
broulik accepted D24740: [Media Controller] Multiple artists support.

Thanks for your patch!
I am not sure if the property should be perhaps changed to a property var and always contain an Array. But that would mean changing the tooltip, full representation, among other things.
I think this is fine.
Do you have commit access? If not, I need an E-Mail address so I can land this for you

Thu, Oct 17, 4:35 PM · Plasma
broulik added a reviewer for D24737: Correctly highlight the icon in the system tray: apol.
Thu, Oct 17, 3:05 PM · Plasma
broulik accepted D24738: Highlight the icon in the system tray on mouse over.

Thanks

Thu, Oct 17, 2:30 PM · Plasma
broulik committed R104:7ad6fb79a953: Merge branch 'Plasma/5.17' (authored by broulik).
Merge branch 'Plasma/5.17'
Thu, Oct 17, 2:28 PM
broulik committed R104:987f8210337d: Add missing check for outputModel (authored by broulik).
Add missing check for outputModel
Thu, Oct 17, 2:27 PM
broulik closed D24735: Gracefully replace outputModel.
Thu, Oct 17, 2:27 PM · Plasma
broulik committed R104:2ab4c2f136c5: Gracefully replace outputModel (authored by broulik).
Gracefully replace outputModel
Thu, Oct 17, 2:27 PM
broulik added a comment to D24735: Gracefully replace outputModel.

I call release() instead of get() so I reset the pointer to null so that when I signal outputModelChanged it returns null and QtQuick resets everything and only then I delete it.

Thu, Oct 17, 2:18 PM · Plasma
broulik updated the diff for D24735: Gracefully replace outputModel.
  • Delete the old model
Thu, Oct 17, 2:17 PM · Plasma
broulik added a comment to D24735: Gracefully replace outputModel.

Oh I'm an idiot, I forgot to delete the model.

Thu, Oct 17, 2:16 PM · Plasma
broulik added a comment to D24735: Gracefully replace outputModel.

But just destroying and recreating is much simpler. ;)

And causes crashes by leaving things on the QML side in an inconsistent state.

Thu, Oct 17, 2:15 PM · Plasma
broulik added a comment to D24734: [KCM] remove the page indicator dots.

Alright, convinced. See D24735

Thu, Oct 17, 2:13 PM · Plasma
broulik added a comment to D24736: Grab the keyboard when KeySequenceItem is recording.

Alternatively you could make the KeySequenceHelper itself a QQuickItem so it gets assigned a window.

Thu, Oct 17, 2:01 PM · Frameworks
broulik updated the summary of D24735: Gracefully replace outputModel.
Thu, Oct 17, 1:57 PM · Plasma
broulik requested review of D24735: Gracefully replace outputModel.
Thu, Oct 17, 1:57 PM · Plasma
broulik added a comment to D24734: [KCM] remove the page indicator dots.

I would prefer they stay in. It's a swiping sliding view, they do no harm.
Also I'm having trouble with the ComboBox right now, please hold this for now.

Thu, Oct 17, 1:51 PM · Plasma
broulik committed R104:7811411c6425: [KCM] Add output selector ComboBox (authored by broulik).
[KCM] Add output selector ComboBox
Thu, Oct 17, 1:36 PM
broulik committed R104:27fc97e9f45c: Merge branch 'Plasma/5.17' (authored by broulik).
Merge branch 'Plasma/5.17'
Thu, Oct 17, 1:36 PM
broulik closed D24687: [KCM] Add output selector ComboBox.
Thu, Oct 17, 1:36 PM · Plasma
broulik added a comment to D24688: [KCM] Disallow dropping screen outside of reachable area.

That could also work, however the view wastes a lot of space right now, the screens could be a lot bigger, if we were to auto-zoom.

Thu, Oct 17, 1:33 PM · Plasma
broulik updated the diff for D24688: [KCM] Disallow dropping screen outside of reachable area.
  • No magic numbers
Thu, Oct 17, 12:40 PM · Plasma
broulik accepted D24716: Fix memory leak of KQuickAddons::ConfigModule objects.
Thu, Oct 17, 11:59 AM · Frameworks
broulik added inline comments to D24714: [effects/startupfeedback] Scale application icon size with cursor size.
Thu, Oct 17, 7:42 AM · KWin
broulik added inline comments to D24687: [KCM] Add output selector ComboBox.
Thu, Oct 17, 6:56 AM · Plasma

Wed, Oct 16

broulik requested review of D24717: [Advanced Settings] Clean up UI file.
Wed, Oct 16, 9:42 PM · Plasma
broulik edited reviewers for D24714: [effects/startupfeedback] Scale application icon size with cursor size, added: KWin; removed: kwinslet.
Wed, Oct 16, 9:12 PM · KWin
broulik requested review of D24714: [effects/startupfeedback] Scale application icon size with cursor size.
Wed, Oct 16, 9:12 PM · KWin
broulik added inline comments to D24488: [kcm] Don't transform button to show rotated icon.
Wed, Oct 16, 8:18 PM · Plasma
broulik added a comment to D24488: [kcm] Don't transform button to show rotated icon.

I would still suggest overriding the contentItem of the Button and put a rotated Kirigami.Icon in there without actually transforming the entire button.

Wed, Oct 16, 6:04 PM · Plasma
broulik added a comment to D24208: [Notifications] Dodge Plasma dialogs.

Hidding the notification behind a popup is at best a workaround.

It is.

What if you receive an email while changing your audio setup ?

Then you close the popup and get the notification, I don't see an issue with that. It's not like you fiddle with System Tray for long periods of time, are you? The only reason I previously had to keep System Tray open was to monitor a copy progress but that is possible without doing that nowadays.

how long before we get bug reports ?

Dunno. I got bug reports about notifications covering System Tray before that. You can never make people happy.

So I thought you would consider adding it somewhere on your infinite TODO list ^^

I don't have any concrete plans. Maybe one day when I can be arsed to but moving the popups out of the way in a sensible fashion as a group is a lot harder than just hiding them individually.
When your panel is on the left, where to move the notifications? What if there isn't enough room to move them out of the way? etc

In the end I am happy opening a notification bug, to let us deal with it it in due times.

Sure.

Wed, Oct 16, 4:44 PM · Plasma
broulik added a comment to T11849: Stuff and swag.

I was thinking of instead having beer coasters with KDE logo/Konqi + some product info on the back since we won't be getting proper flyers. However, seems nobody from VDG is interested or has time.

Wed, Oct 16, 3:32 PM · KDE Promo
broulik added a comment to D24667: [KStatusNotifierItem] Allow left click when menu is null.

bool takeOwnership = true);

Wed, Oct 16, 3:30 PM · Frameworks
broulik accepted D24699: Disable the module if the setting is locked down.

Cool!

Wed, Oct 16, 2:33 PM · Plasma
broulik accepted D24698: Leverage latest KConfig changes.
Wed, Oct 16, 2:33 PM · Plasma
broulik accepted D24697: Expose isImmutable to introspection (e.g. QML).
Wed, Oct 16, 2:20 PM · Frameworks