broulik (Kai Uwe Broulik)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Dec 14 2015, 3:47 PM (182 w, 6 d)
Availability
Available

Recent Activity

Fri, Jun 14

broulik committed R856:dafc41cd112e: Store protocolVersion in AbstractBrowserPlugin (authored by broulik).
Store protocolVersion in AbstractBrowserPlugin
Fri, Jun 14, 6:45 AM
broulik committed R856:37f48b7e4fde: Don't track subsystem status (authored by broulik).
Don't track subsystem status
Fri, Jun 14, 6:43 AM
broulik closed D21785: Don't track subsystem status.
Fri, Jun 14, 6:43 AM · Plasma
broulik added a comment to D21785: Don't track subsystem status.

I think in the options page we don't really have a choice since it's a separate page opened by the user when the extension is already running.
If we ever do breaking changes in the extension script and need to check it, we can still reintroduce something.

Fri, Jun 14, 6:00 AM · Plasma

Thu, Jun 13

broulik updated the test plan for D21785: Don't track subsystem status.
Thu, Jun 13, 5:51 PM · Plasma
broulik added a reviewer for D21785: Don't track subsystem status: fvogt.
Thu, Jun 13, 5:50 PM · Plasma
broulik requested review of D21785: Don't track subsystem status.
Thu, Jun 13, 5:50 PM · Plasma
broulik planned changes to D21112: Support message response and reply callbacks.

Ok, I have an idea.
browser.runtime.sendMessage (Firefox) returns a promise that is fulfilled when a reply is sent. Chrome instead uses a callback function in chrome.runtime.sendMessage
I'm gonna rework the sendMessage() to always return a Promise (makes for nicer code) by either forwarding the promise from Firefox or creating one forwarding the callback in Chrome

Thu, Jun 13, 5:28 PM · Plasma
broulik added a comment to T11084: [Notifications] indicator for the disappearance on the bottom.

it would disappear faster making it more prominent:

Thu, Jun 13, 1:44 PM · VDG
broulik committed R856:01a8fa605459: Prefer document.title over sender.tab.title (authored by broulik).
Prefer document.title over sender.tab.title
Thu, Jun 13, 1:10 PM
broulik closed D21743: Prefer document.title over sender.tab.title.
Thu, Jun 13, 1:10 PM · Plasma
broulik requested review of D21780: Add X-Flatpak-RenamedFrom as recognized key.
Thu, Jun 13, 12:50 PM · Frameworks
broulik committed R120:98a9f24b763f: Merge branch 'Plasma/5.16' (authored by broulik).
Merge branch 'Plasma/5.16'
Thu, Jun 13, 12:45 PM
broulik committed R120:9258ef586324: [Notifications] Resolve X-Flatpak-RenamedFrom (authored by broulik).
[Notifications] Resolve X-Flatpak-RenamedFrom
Thu, Jun 13, 12:45 PM
broulik closed D21779: Resolve X-Flatpak-RenamedFrom.
Thu, Jun 13, 12:45 PM · Plasma
broulik updated the diff for D21779: Resolve X-Flatpak-RenamedFrom.
Thu, Jun 13, 12:03 PM · Plasma
broulik requested review of D21779: Resolve X-Flatpak-RenamedFrom.
Thu, Jun 13, 10:46 AM · Plasma
broulik added inline comments to D21618: Allow QtQuick applets and wallpapers to defer UiReadyConstraint.
Thu, Jun 13, 8:02 AM · Frameworks

Wed, Jun 12

broulik added a comment to D19745: Fix system tray UI/UX & refactor.

Will you address the broken event delivery to the compact applet item?

Wed, Jun 12, 5:49 PM · Plasma
broulik added inline comments to D21638: Display delay in the taskmanager.
Wed, Jun 12, 12:39 PM · Spectacle
broulik added inline comments to D21638: Display delay in the taskmanager.
Wed, Jun 12, 12:06 PM · Spectacle
broulik added a comment to D21761: move SolidUiServer::showActionsDialog to hotplug dataengine.

I suppose it should never happen that an action cannot be resolved, so maybe an assertion to that extent is sufficient?

Wed, Jun 12, 10:32 AM · Plasma
broulik accepted D21758: [ksmserver] Drop internal loading of alternative window managers.
Wed, Jun 12, 10:29 AM · Plasma
broulik added inline comments to D21113: Allow hiding option items depending on available extension and version in the host.
Wed, Jun 12, 9:03 AM · Plasma

Tue, Jun 11

broulik accepted D21747: drop the solid runner.
Tue, Jun 11, 3:03 PM · Plasma
broulik added a comment to D21112: Support message response and reply callbacks.

It works just fine in Firefox 67 here. Maybe the documentation is outdated?

browser.runtime.sendMessage({foo: "bar"}, callback)

works just fine

Tue, Jun 11, 1:29 PM · Plasma
broulik committed R122:86f4b4d37e36: Merge branch 'Plasma/5.16' (authored by broulik).
Merge branch 'Plasma/5.16'
Tue, Jun 11, 8:47 AM
broulik committed R122:82db1f446966: Ignore power management inhibition in battery critical timeout (authored by broulik).
Ignore power management inhibition in battery critical timeout
Tue, Jun 11, 8:46 AM
broulik closed D21648: Ignore power management inhibition in battery critical timeout.
Tue, Jun 11, 8:46 AM · Plasma
broulik requested review of D21743: Prefer document.title over sender.tab.title.
Tue, Jun 11, 8:02 AM · Plasma
broulik added inline comments to D21725: Use a native application for starting plasma.
Tue, Jun 11, 6:53 AM · Plasma

Sat, Jun 8

broulik added a reviewer for D11234: [DrKonqi] Show debug button when KDevelop session is running: sitter.
Sat, Jun 8, 2:50 PM · Plasma

Fri, Jun 7

broulik accepted D21646: re-read color palettes when application color changes.

You need to run arc amend to reflect the change to the commit message in your local checkout

Fri, Jun 7, 1:17 PM · Plasma
broulik requested review of D21648: Ignore power management inhibition in battery critical timeout.
Fri, Jun 7, 12:23 PM · Plasma
broulik added inline comments to D21646: re-read color palettes when application color changes.
Fri, Jun 7, 12:16 PM · Plasma
broulik accepted D21645: copy backtrace file with overwrite flag.
Fri, Jun 7, 12:05 PM · Plasma
broulik accepted D21644: use errorString instead of errorText.
Fri, Jun 7, 12:04 PM · Plasma
broulik added a comment to D21647: send signal to breeze to trigger reparsing the color scheme.

-1 on having the KCM do something style-specific. Ideally Breeze listened to some signals which your other patch does.

Fri, Jun 7, 12:03 PM · Plasma
broulik added inline comments to D21646: re-read color palettes when application color changes.
Fri, Jun 7, 11:56 AM · Plasma
broulik abandoned D21438: [plasmashell] Don't talk to ksmserver.

Yeah, let's use the Qt flag since it's in 5.13 now.

Fri, Jun 7, 8:47 AM · Plasma
broulik committed R318:10d8a5731507: [DolphinContextMenu] Restore check for whether place already exists (authored by broulik).
[DolphinContextMenu] Restore check for whether place already exists
Fri, Jun 7, 8:37 AM
broulik closed D21600: [DolphinContextMenu] Restore check for whether place already exists.
Fri, Jun 7, 8:37 AM · Dolphin
broulik committed R858:e98728c7667a: [ToolButton] Pass custom icon size to StyleItem (authored by broulik).
[ToolButton] Pass custom icon size to StyleItem
Fri, Jun 7, 8:34 AM
broulik closed D21623: [ToolButton] Pass custom icon size to StyleItem.
Fri, Jun 7, 8:34 AM · Plasma
broulik accepted D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon.

Looks good. Perhaps now that we can have proper tooltips for the buttons we should add some?

Fri, Jun 7, 8:30 AM · Plasma
broulik added a comment to D21638: Display delay in the taskmanager.

While I don't think my bits left in the code reach a neccessary threshold of originality, I agree to a relicensing from GPLv2 to LGPLv2+ (not sure why Spectacle as an application is *L*GPL, though)

Fri, Jun 7, 8:29 AM · Spectacle

Thu, Jun 6

broulik requested review of D21623: [ToolButton] Pass custom icon size to StyleItem.
Thu, Jun 6, 3:15 PM · Plasma
broulik added a comment to T11041: Make notifications accessible.

It's on purpose they don't get focus as they should never interrupt you. We need to find a way to address this in some way without jeopardizing the default usecase.

Thu, Jun 6, 1:01 PM · Plasma Accessibility
broulik abandoned D21425: [UDev Backend] Filter for ID_MEDIA_PLAYER already when querying.

Pushed as part of D21379

Thu, Jun 6, 12:20 PM · Frameworks
broulik added a comment to D21593: [showdesktop][minimzeall] Reduce the maximum panel icon size.

I couldn't figure out how to make the widget get the icon from the desktop theme

Thu, Jun 6, 10:53 AM · Plasma
broulik committed R245:fe1c9c02e09f: [UDev Backend] Narrow device queried for (authored by broulik).
[UDev Backend] Narrow device queried for
Thu, Jun 6, 10:48 AM
broulik closed D21379: [UDev Backend] Narrow device queried for.
Thu, Jun 6, 10:48 AM · Frameworks
broulik committed R120:cac7af89b7eb: use desktop file actions instead of global shortcuts (authored by broulik).
use desktop file actions instead of global shortcuts
Thu, Jun 6, 7:37 AM
broulik closed D9037: use desktop file actions instead of global shortcuts.
Thu, Jun 6, 7:37 AM · Plasma
broulik updated the diff for D21600: [DolphinContextMenu] Restore check for whether place already exists.

The StripTrailingSlash didn't seem to be neccessary

Thu, Jun 6, 7:00 AM · Dolphin
broulik added a comment to D21379: [UDev Backend] Narrow device queried for.

The question now is, should we also differnentiate here, i.e. map QVariant() to nullptr, and use "*" for wildcards?

Thu, Jun 6, 6:49 AM · Frameworks

Wed, Jun 5

broulik added a comment to D21605: Don't give up if no results arrive after 500ms.

Does that by chance also fix the dictionary runner which does network queries that take a while?

Wed, Jun 5, 3:02 PM · Plasma
broulik requested review of D21600: [DolphinContextMenu] Restore check for whether place already exists.
Wed, Jun 5, 1:22 PM · Dolphin
broulik committed R97:f1d201ab6f2a: Merge branch 'Plasma/5.16' (authored by broulik).
Merge branch 'Plasma/5.16'
Wed, Jun 5, 10:07 AM
broulik committed R97:445e7203ac99: [CompactRepresentation] Glow on hover (authored by broulik).
[CompactRepresentation] Glow on hover
Wed, Jun 5, 10:07 AM
broulik closed D21596: [CompactRepresentation] Glow on hover.
Wed, Jun 5, 10:07 AM · Plasma
broulik committed R116:4df0808caf64: Merge branch 'Plasma/5.16' (authored by broulik).
Merge branch 'Plasma/5.16'
Wed, Jun 5, 10:06 AM
broulik closed D21595: [CompactRepresentation] Glow on hover.
Wed, Jun 5, 10:06 AM · Plasma
broulik committed R116:dc37c655aaf7: [CompactRepresentation] Glow on hover (authored by broulik).
[CompactRepresentation] Glow on hover
Wed, Jun 5, 10:06 AM
broulik requested review of D21596: [CompactRepresentation] Glow on hover.
Wed, Jun 5, 9:22 AM · Plasma
broulik committed R856:e7c353c7f437: Allow media controls and tabs runner in incognito mode for Firefox 67 (authored by broulik).
Allow media controls and tabs runner in incognito mode for Firefox 67
Wed, Jun 5, 9:20 AM
broulik closed D21594: Allow media controls and tabs runner in incognito mode for Firefox 67.
Wed, Jun 5, 9:20 AM · Plasma
broulik requested review of D21595: [CompactRepresentation] Glow on hover.
Wed, Jun 5, 9:20 AM · Plasma
broulik added a comment to D21593: [showdesktop][minimzeall] Reduce the maximum panel icon size.

While I'm all for making the show desktop icon stick out less I don't think randomly limiting the size of one particular applet is a good approach. The iconSizeHints is there for a reason, defining the maximum size of icons in the panel.

Wed, Jun 5, 9:08 AM · Plasma
broulik requested review of D21594: Allow media controls and tabs runner in incognito mode for Firefox 67.
Wed, Jun 5, 9:05 AM · Plasma
broulik committed R120:fe08bc2c9f22: Merge branch 'Plasma/5.16' (authored by broulik).
Merge branch 'Plasma/5.16'
Wed, Jun 5, 7:38 AM
broulik committed R120:fa74ee535d13: [Notifications] Don't alter top margin of ThumbnailStrip (authored by broulik).
[Notifications] Don't alter top margin of ThumbnailStrip
Wed, Jun 5, 7:37 AM
broulik closed D21569: [Notifications] Don't alter top margin of ThumbnailStrip.
Wed, Jun 5, 7:37 AM · Plasma
broulik added a comment to D21591: Panel: Use bitwise operators on flags.

git pull https://cgit.kde.org/plasma-workspace.git/commit/?id=f6258fa4ec69243fd638251eafeeb10af5e8c66e :)

Wed, Jun 5, 6:25 AM · Plasma

Tue, Jun 4

broulik committed R120:f6258fa4ec69: [PanelView] Fix wrong usage of operators with flags (authored by broulik).
[PanelView] Fix wrong usage of operators with flags
Tue, Jun 4, 11:38 AM
broulik committed R134:89681ad47084: [Notifier] Delay creating QNetworkConfigurationManager (authored by broulik).
[Notifier] Delay creating QNetworkConfigurationManager
Tue, Jun 4, 9:15 AM
broulik closed D21561: [Notifier] Delay creating QNetworkConfigurationManager.
Tue, Jun 4, 9:15 AM · Plasma
broulik accepted D21572: [UnindexedFileIndexer] Loop optimizations (avoid detach, invariants).
Tue, Jun 4, 8:55 AM · Baloo, Frameworks
broulik requested review of D21569: [Notifications] Don't alter top margin of ThumbnailStrip.
Tue, Jun 4, 7:41 AM · Plasma
broulik committed R318:0bc919bd4758: Merge branch 'Applications/19.04' (authored by broulik).
Merge branch 'Applications/19.04'
Tue, Jun 4, 6:59 AM
broulik committed R318:c43165a1c42f: [Places Panel] Pass iconName to KFilePlaceEditDialog (authored by broulik).
[Places Panel] Pass iconName to KFilePlaceEditDialog
Tue, Jun 4, 6:59 AM
broulik closed D21558: [Places Panel] Pass iconName to KFilePlaceEditDialog.
Tue, Jun 4, 6:59 AM · Dolphin
broulik added a comment to D21561: [Notifier] Delay creating QNetworkConfigurationManager.

As I feared, no matter if I disconnect, it's always NetworkAccessible, even with a stock QML app (i.e. without KIO AccessManager that KDeclarative injects).
QNetworkAccessManager only checks the actual network session when the QNetworkConfigurationManager::NetworkSessionRequired flag in the bearer plugin which isn't the case for us (only connman as far as I can tell). Otherwise it's merely a "did the caller disable network access explicitly or is it allowed".

Tue, Jun 4, 6:56 AM · Plasma
broulik added a comment to D21561: [Notifier] Delay creating QNetworkConfigurationManager.

Sorry, misread you there. networkAccessible could work. It claims to reflect the actual device state and since the QQmlEngine already has its own QNetworkAccessManager we don't need to create one. I'll give it a go.

Tue, Jun 4, 6:43 AM · Plasma
broulik added a comment to D21561: [Notifier] Delay creating QNetworkConfigurationManager.

Is QNetworkAccessManager::networkAccessible any better?

It has an unknown state which implies it might be async.

Tue, Jun 4, 6:36 AM · Plasma

Mon, Jun 3

broulik accepted D21503: [Calculator] Make buttons' text labels scale in size along with the widget.

That 12 is a bit random, isn't it? But glad my approach just works™

Mon, Jun 3, 4:05 PM · Plasma
broulik accepted D21502: [PlasmaComponents3] Vertically center button text as well.
Mon, Jun 3, 4:04 PM · Frameworks
broulik added a comment to D21555: [KFilePlacesModel] Explicitly query for PTP cameras.

The Solid predicate actually uses Camera.supportedDrivers == 'gphoto' and while this patch worked perfectly fine this morning somehow not nothing works :(

Mon, Jun 3, 2:34 PM · Frameworks
broulik added a revision to T10958: Faster Startup: D21561: [Notifier] Delay creating QNetworkConfigurationManager.
Mon, Jun 3, 1:04 PM · Plasma
broulik added a task to D21561: [Notifier] Delay creating QNetworkConfigurationManager: T10958: Faster Startup.
Mon, Jun 3, 1:04 PM · Plasma
broulik requested review of D21561: [Notifier] Delay creating QNetworkConfigurationManager.
Mon, Jun 3, 1:03 PM · Plasma
broulik added a reviewer for D21558: [Places Panel] Pass iconName to KFilePlaceEditDialog: Dolphin.
Mon, Jun 3, 10:37 AM · Dolphin
broulik requested review of D21558: [Places Panel] Pass iconName to KFilePlaceEditDialog.
Mon, Jun 3, 10:36 AM · Dolphin
broulik committed R120:9dc4787ececb: Merge branch 'Plasma/5.16' (authored by broulik).
Merge branch 'Plasma/5.16'
Mon, Jun 3, 8:44 AM
broulik committed R120:0cd335211ad4: [Media Controller] Anchor album art left and right as well (authored by broulik).
[Media Controller] Anchor album art left and right as well
Mon, Jun 3, 8:44 AM
broulik closed D21557: [Media Controller] Anchor album art left and right as well.
Mon, Jun 3, 8:44 AM · Plasma
broulik added a comment to D21556: Change defaultSaveLocation to use QUrl.

Shouldn't that return a QUrl with QUrl::fromLocalFile then?

Mon, Jun 3, 8:40 AM · Spectacle
broulik requested review of D21557: [Media Controller] Anchor album art left and right as well.
Mon, Jun 3, 8:28 AM · Plasma
broulik updated the diff for D21379: [UDev Backend] Narrow device queried for.
  • Use * wildcard
Mon, Jun 3, 7:50 AM · Frameworks
broulik requested review of D21555: [KFilePlacesModel] Explicitly query for PTP cameras.
Mon, Jun 3, 7:48 AM · Frameworks