broulik (Kai Uwe Broulik)
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Dec 14 2015, 3:47 PM (131 w, 6 d)
Availability
Available

Recent Activity

Sat, Jun 23

broulik added a comment to D13686: Updated RunCommand.qml to scroll with Ctrl + home row (j, k).

Idea is fine I guess

Sat, Jun 23, 9:56 AM · Plasma

Wed, Jun 20

broulik added inline comments to D13618: Only add Media Sessions Shim if we find a valid video object.
Wed, Jun 20, 8:53 AM · Plasma

Tue, Jun 19

broulik added a comment to D13619: Inject script on relevant video nodes not top of DOM.

Media sessions doesn't necessarily need a player item, it's basically meant for when you don't have one. The website might remove the player item when it pauses when it's using media sessions API to do custom handling. Can't think of a better solution, though.

Tue, Jun 19, 8:01 PM · Plasma
broulik added a comment to D13618: Only add Media Sessions Shim if we find a valid video object.

An idea how to avoid adding a DOM node altogether

Tue, Jun 19, 7:52 PM · Plasma

Sat, Jun 16

broulik accepted D13541: Port solid from Qt5::Widgets to Qt5::Gui.
Sat, Jun 16, 11:46 AM · Frameworks

Thu, Jun 7

broulik committed R31:b25a8fea49a4: Merge branch 'Plasma/5.13' (authored by broulik).
Merge branch 'Plasma/5.13'
Thu, Jun 7, 2:26 PM
broulik added a comment to D12827: Added process details in the process list context menu.

That crash should be fixed by [1] which I just saw forgot to merge to master

Thu, Jun 7, 2:25 PM · Plasma
broulik accepted D12256: [kstyle] Drop QStyleOptionProgressBarV2 in Qt 5 style plugin.
Thu, Jun 7, 1:20 PM · Plasma
broulik committed R856:3754854c1cd1: Merge branch 'Plasma/5.13' (authored by broulik).
Merge branch 'Plasma/5.13'
Thu, Jun 7, 11:54 AM
broulik committed R856:eb4cde504d27: Bump version number of extension in preparation for Plasma 5.13 (authored by broulik).
Bump version number of extension in preparation for Plasma 5.13
Thu, Jun 7, 11:50 AM
broulik added inline comments to D13178: Compress calls to configuration slots upon new connections.
Thu, Jun 7, 10:38 AM · Plasma
broulik added a comment to D12827: Added process details in the process list context menu.

The existing "Show detailed memory information" and "Process details". I think they can be merged.

Thu, Jun 7, 10:04 AM · Plasma
broulik committed R228:c500842b288a: Merge branch 'Applications/18.04' (authored by broulik).
Merge branch 'Applications/18.04'
Thu, Jun 7, 9:37 AM
broulik committed R228:c290e496fda4: Changed the minimum required Qt version from 5.6.0 to 5.9.0 (authored by shubham).
Changed the minimum required Qt version from 5.6.0 to 5.9.0
Thu, Jun 7, 9:36 AM
broulik committed R241:a44fa03029c8: [KFileItem] Check most local URL for whether it's shared (authored by broulik).
[KFileItem] Check most local URL for whether it's shared
Thu, Jun 7, 7:27 AM
broulik closed D13398: [KFileItem] Check most local URL for whether it's shared.
Thu, Jun 7, 7:27 AM · Frameworks
broulik updated subscribers of D13390: Fonts KCM: Fix text readability regression.

Is this working for you? For me this resolves to the disabled palette (as it should).

Thu, Jun 7, 6:43 AM · Plasma
broulik added a comment to D13390: Fonts KCM: Fix text readability regression.

It will lead users to click into the field, expecting to be able to edit the name directly

Thu, Jun 7, 6:31 AM · Plasma
broulik added a comment to D13390: Fonts KCM: Fix text readability regression.

Unfortunately that's not what I think is needed here.

Thu, Jun 7, 6:27 AM · Plasma
broulik requested review of D13398: [KFileItem] Check most local URL for whether it's shared.
Thu, Jun 7, 5:58 AM · Frameworks
broulik requested review of D13397: Support desktop:/ protocol.
Thu, Jun 7, 5:51 AM

Wed, Jun 6

broulik committed R119:658f9f7cdbe2: Merge branch 'Plasma/5.13' (authored by broulik).
Merge branch 'Plasma/5.13'
Wed, Jun 6, 7:21 PM
broulik committed R119:c4f05a9372ab: [Icons KCM] Floor icon size to avoid premature wrapping in certain cases (authored by broulik).
[Icons KCM] Floor icon size to avoid premature wrapping in certain cases
Wed, Jun 6, 7:21 PM
broulik added inline comments to D13367: Improve the clarity and presentation of the update details text field.
Wed, Jun 6, 2:04 PM · Plasma
broulik accepted D13034: Add mechanism to notify other clients of config changes over DBus.
Wed, Jun 6, 12:06 PM · Frameworks
This is a test notification, sent at Wed, Jun 6, 13:42.
Wed, Jun 6, 11:42 AM
This is a test notification, sent at Wed, Jun 6, 13:42.
Wed, Jun 6, 11:42 AM
This is a test notification, sent at Wed, Jun 6, 13:42.
Wed, Jun 6, 11:42 AM
broulik committed R856:f0c75ae7e219: Merge branch 'Plasma/5.13' (authored by broulik).
Merge branch 'Plasma/5.13'
Wed, Jun 6, 11:33 AM
broulik committed R856:a5c049a1a6c6: Handle when the added node itself is audio/video (authored by broulik).
Handle when the added node itself is audio/video
Wed, Jun 6, 11:33 AM
broulik closed D13378: Handle when the added node itself is audio/video.
Wed, Jun 6, 11:33 AM · Plasma
broulik updated the diff for D13378: Handle when the added node itself is audio/video.
  • Use same selector order as the existing code below
Wed, Jun 6, 10:07 AM · Plasma
broulik updated the diff for D13378: Handle when the added node itself is audio/video.
  • Simplify
Wed, Jun 6, 10:07 AM · Plasma
broulik added a comment to D13358: Add new class that is a model of numbers between two values.

Just saw I forgot to submit those comments yesterday

Wed, Jun 6, 10:02 AM · Frameworks
broulik requested review of D13378: Handle when the added node itself is audio/video.
Wed, Jun 6, 9:52 AM · Plasma
broulik committed R302:20f7137145f6: Support Icon Scale from Icon naming specification 0.13 (authored by broulik).
Support Icon Scale from Icon naming specification 0.13
Wed, Jun 6, 7:42 AM
broulik closed D6313: Support Icon Scale from Icon naming specification 0.13.
Wed, Jun 6, 7:42 AM · Frameworks, Plasma
broulik committed R320:9b27cf15433f: Don't generate thumbnail for desktop files (authored by broulik).
Don't generate thumbnail for desktop files
Wed, Jun 6, 7:24 AM
broulik closed D13332: Don't generate thumbnail for desktop files with custom icon.
Wed, Jun 6, 7:24 AM
broulik committed R318:d8cf33d563e1: Merge branch 'Applications/18.04' (authored by broulik).
Merge branch 'Applications/18.04'
Wed, Jun 6, 7:18 AM
broulik committed R318:2f6635f4e8c2: [KBalooRolesProvider] Support properties of type QStringList (authored by broulik).
[KBalooRolesProvider] Support properties of type QStringList
Wed, Jun 6, 7:18 AM
broulik closed D13349: [KBalooRolesProvider] Support properties of type QStringList.
Wed, Jun 6, 7:18 AM · Dolphin

Tue, Jun 5

broulik accepted D13288: Fix the icons KCM.
Tue, Jun 5, 2:55 PM · Plasma
broulik committed R856:27096b7afc81: Hide settings when run on non-supported platform (authored by broulik).
Hide settings when run on non-supported platform
Tue, Jun 5, 12:48 PM
broulik closed D13326: Hide settings when run on non-supported platform.
Tue, Jun 5, 12:48 PM · Plasma
broulik updated the diff for D13326: Hide settings when run on non-supported platform.
  • Don't load settings when unsupported
  • Also don't register the save handlers
Tue, Jun 5, 11:45 AM · Plasma
broulik updated the diff for D13332: Don't generate thumbnail for desktop files with custom icon.
  • Bail out for all .desktop files no matter if they have an icon or not
Tue, Jun 5, 11:27 AM
broulik committed R31:6d886e9f75d0: Check for option->styleObject before accessing it (authored by broulik).
Check for option->styleObject before accessing it
Tue, Jun 5, 10:31 AM
broulik closed D13336: Check for option->styleObject before accessing it.
Tue, Jun 5, 10:31 AM · Plasma
broulik committed R120:fb96a53daaaa: [FreeSpaceNotifier] Use KIO FileSystemFreeSpaceJob (authored by broulik).
[FreeSpaceNotifier] Use KIO FileSystemFreeSpaceJob
Tue, Jun 5, 10:09 AM
broulik closed D13350: [FreeSpaceNotifier] Use KIO FileSystemFreeSpaceJob.
Tue, Jun 5, 10:08 AM · Plasma
broulik accepted D13355: [effects/minimizeanimation] Include QVector2D by its class name.
Tue, Jun 5, 9:57 AM · KWin
broulik requested review of D13350: [FreeSpaceNotifier] Use KIO FileSystemFreeSpaceJob.
Tue, Jun 5, 8:45 AM · Plasma
broulik requested review of D13349: [KBalooRolesProvider] Support properties of type QStringList.
Tue, Jun 5, 8:16 AM · Dolphin
broulik committed R856:569620ba0932: Add README.md file with link to community wiki page (authored by broulik).
Add README.md file with link to community wiki page
Tue, Jun 5, 7:56 AM
broulik added inline comments to D13344: Add possibility to sort by rating.
Tue, Jun 5, 7:47 AM
broulik added a reviewer for D13346: Use more contextual strings for some button labels: drosca.
Tue, Jun 5, 7:44 AM · Plasma
broulik added a comment to D13346: Use more contextual strings for some button labels.

+1

Tue, Jun 5, 7:44 AM · Plasma

Mon, Jun 4

broulik requested review of D13336: Check for option->styleObject before accessing it.
Mon, Jun 4, 3:07 PM · Plasma
broulik added a comment to D13332: Don't generate thumbnail for desktop files with custom icon.

I could also just render no thumbnail at all for desktop files. I thought maybe the user wants to see the text instead, I wouldn't mind doing it either way.

Mon, Jun 4, 2:59 PM
broulik requested review of D13332: Don't generate thumbnail for desktop files with custom icon.
Mon, Jun 4, 1:33 PM
broulik added a comment to T8707: Window borders.

I don't know if our browser extension thing can make use of it,

Mon, Jun 4, 10:31 AM · VDG
broulik added inline comments to D12520: [PasteJob] Emit KDirNotify on paste.
Mon, Jun 4, 7:54 AM · Frameworks
broulik added inline comments to D13315: Detect mime type of local files based on their contents.
Mon, Jun 4, 7:34 AM · Frameworks
broulik committed R856:88bf1fd191f9: Merge branch 'Plasma/5.13' (authored by broulik).
Merge branch 'Plasma/5.13'
Mon, Jun 4, 6:56 AM
broulik committed R856:272f60c55557: Don't bother loading on non-supported platforms (authored by broulik).
Don't bother loading on non-supported platforms
Mon, Jun 4, 6:56 AM
broulik closed D13325: Don't bother loading on non-supported platforms.
Mon, Jun 4, 6:56 AM · Plasma
broulik requested review of D13326: Hide settings when run on non-supported platform.
Mon, Jun 4, 6:49 AM · Plasma
broulik added a dependent revision for D13325: Don't bother loading on non-supported platforms: D13326: Hide settings when run on non-supported platform.
Mon, Jun 4, 6:49 AM · Plasma
broulik requested review of D13325: Don't bother loading on non-supported platforms.
Mon, Jun 4, 6:47 AM · Plasma

Fri, Jun 1

broulik added inline comments to D13263: [effects/glide] Do not animate logout screen.
Fri, Jun 1, 3:37 PM · KWin
broulik added inline comments to D13263: [effects/glide] Do not animate logout screen.
Fri, Jun 1, 1:20 PM · KWin
broulik added a comment to D13215: FrameSvg: Recache maskFrame if enabledBorders has been changed.

Doesn't make a difference in Oxygen's rounded corners on panels but doesn't make it worse either. Please also profile whether it causes any needless recalculations on Plasma startup

Fri, Jun 1, 11:01 AM · Frameworks
broulik added inline comments to D13263: [effects/glide] Do not animate logout screen.
Fri, Jun 1, 10:56 AM · KWin
broulik added a comment to D12520: [PasteJob] Emit KDirNotify on paste.

Ping

Fri, Jun 1, 10:50 AM · Frameworks
broulik updated the diff for D6313: Support Icon Scale from Icon naming specification 0.13.

Fri, Jun 1, 10:49 AM · Frameworks, Plasma
broulik updated the diff for D6313: Support Icon Scale from Icon naming specification 0.13.
  • Fix rebase
Fri, Jun 1, 10:48 AM · Frameworks, Plasma
broulik committed R856:d9ae5d7d1475: Merge branch 'Plasma/5.13' (authored by broulik).
Merge branch 'Plasma/5.13'
Fri, Jun 1, 10:45 AM
broulik committed R856:4f5eeec505e8: [Installation Reminder] Watch for service registration and hide (authored by broulik).
[Installation Reminder] Watch for service registration and hide
Fri, Jun 1, 10:45 AM
broulik closed D13210: [Installation Reminder] Watch for service registration and hide.
Fri, Jun 1, 10:45 AM · Plasma
broulik abandoned D12895: WIP: Add KFileItemActionsPlugin.

Superseded by D13124

Fri, Jun 1, 10:43 AM · Frameworks
broulik committed R119:8739b7c16519: Merge branch 'Plasma/5.13' (authored by broulik).
Merge branch 'Plasma/5.13'
Fri, Jun 1, 10:41 AM
broulik committed R119:9dfb3b5c3bd9: Move "click" and "double click" keywords from Mouse to Workspace KCM (authored by broulik).
Move "click" and "double click" keywords from Mouse to Workspace KCM
Fri, Jun 1, 10:41 AM
broulik closed D13187: Move "click" and "double click" keywords from Mouse to Workspace KCM.
Fri, Jun 1, 10:41 AM · Plasma
broulik added inline comments to D13247: Deduplicate code for showing inline messages.
Fri, Jun 1, 10:03 AM
broulik added inline comments to D13232: introduce Custom color set.
Fri, Jun 1, 10:00 AM · Kirigami
broulik committed R120:3d8937b9122a: Merge branch 'Plasma/5.13' (authored by broulik).
Merge branch 'Plasma/5.13'
Fri, Jun 1, 9:42 AM
broulik committed R120:d73fa7aac8d7: Merge branch 'Plasma/5.12' into Plasma/5.13 (authored by broulik).
Merge branch 'Plasma/5.12' into Plasma/5.13
Fri, Jun 1, 9:42 AM
broulik committed R120:b39522e9e925: [Slideshow Wallpaper] Ignore hidden files and folders (authored by broulik).
[Slideshow Wallpaper] Ignore hidden files and folders
Fri, Jun 1, 9:41 AM
broulik closed D13260: [Slideshow Wallpaper] Ignore hidden files and folders.
Fri, Jun 1, 9:41 AM · Plasma
broulik requested review of D13260: [Slideshow Wallpaper] Ignore hidden files and folders.
Fri, Jun 1, 9:37 AM · Plasma

Wed, May 30

broulik added a comment to D13215: FrameSvg: Recache maskFrame if enabledBorders has been changed.

Wow. I wasted hours in FrameSvg trying to find this. Does this also fix the panel mask in non-composited mode, e.g. round corners with Oxygen? (Quickly browsing the bug numbers suggests it does \o/)

Wed, May 30, 3:06 PM · Frameworks
broulik added a comment to D13192: Implement a triangle filter for mouse events on the Kickoff tabbar.

Minor code nitpicks.

Wed, May 30, 1:14 PM · Plasma
broulik requested review of D13210: [Installation Reminder] Watch for service registration and hide.
Wed, May 30, 9:00 AM · Plasma

Tue, May 29

broulik added inline comments to D13207: [lookandfeel/lockscreen] Hide cursor on login controls fade out.
Tue, May 29, 8:20 PM · Plasma
broulik accepted D13043: Properly sanitize input.
Tue, May 29, 1:23 PM · Frameworks
broulik retitled D13187: Move "click" and "double click" keywords from Mouse to Workspace KCM from Move "click" and "double click" s keywords to Move "click" and "double click" keywords from Mouse to Workspace KCM.
Tue, May 29, 6:59 AM · Plasma
broulik updated the diff for D13187: Move "click" and "double click" keywords from Mouse to Workspace KCM.
  • Remove from mouse kcm
Tue, May 29, 6:59 AM · Plasma
broulik added a comment to D13186: Use HiddenStatus when keyboard indicator is inactive.

+1

Tue, May 29, 6:36 AM · Plasma
broulik requested review of D13187: Move "click" and "double click" keywords from Mouse to Workspace KCM.
Tue, May 29, 6:33 AM · Plasma