- User Since
- Dec 14 2015, 3:47 PM (122 w, 5 d)
Fri, Apr 20
What's the performance penalty of that? Does the file dialog request the correct size from the preview job? It shouldn't have to end up in this codepath that often, I think.
- Also reject QMouseEvent
Ideally, there was a mime data flag an application could set to indicate it wouldn't want it to end up in clipboard history but this is probably impossible to get applications to use..
Thu, Apr 19
I don't like how the button floats in "mid air" between the two sides of the toolbar
+1 for consistency
My checkout wasnt up to date, this was already fixed
Wed, Apr 18
Thanks a lot!
I think there's something severly wrong with the dialog's size hints if we need to add arbitrary numbers all over the place. Can you make sure this doesn't break with
- different font
- larger font
- screen scaling
- different widget style
Can we fix configurationNeeded in the desktop/panel containment, please? :P
Hmm I think it would make for a nicer API to expose wallpaperPluginName and wallpaperConfiguration directly? I find doing wallpaper.something and wallpaperIntegration.pluginName a bit awkward, but fine with me.
I think it could be somehow done to start a separate plasma windowed instance and tell it to temporarily load the layout JS, not sure it'll be worth the effort. @mart what do you think?
How would one switch to the "Fine tuning" view? I mean, how to achieve that in Kirigami? Use a horizontally paginated thing, an overlay, a StackView, …?
It's missing the destructive hint about the "use desktop layout from theme"
Tue, Apr 17
This is master-only code, right? The upcoming Plasma 5.13 will depend on KF 5.46 so this should be fine.
This bug is 15 years old and no proof to this claim was provided.
Also, the wording as "subclasses can add" suggests a virtual method
Mon, Apr 16
Fine in principle but it doesn't enforce any minimum spacing
Is it also accessible from the menu in the top right?
Fri, Apr 13
+1 always annoyed me that the converter runner didn't use localed decimal points
Thu, Apr 12
Now I don't see any wallpapers in the list
GridDelegate.qml:63: ReferenceError: view is not defined
I did update kdeclarative and kirigami before
Oh, I see. So Okular's Print action must go then. There is currently no way to print a PDF file from within Ark.
Wouldn't make a big difference, would it?
But do we remove the offending properties when the interface is removed? Not sure, is probably unrelated bug
Wed, Apr 11
Worth changing, but not cve and urgent release worthy.
The only downside this has is that you can longer resize the column wider manually but then you might as well resize the window and actually see more :)
where do we put third party data in an OSDItem
Tue, Apr 10
the session is defunct after resume
Ping, if no one objects I'll push this once next FW is released
- Use default sink instead of preferred sink as the latter also changes depending on where music is being played
Can we arrange them so that they're more consistent with Dolphin? i.e. put the Preview button at right-most
Mon, Apr 9
This doesn't work.
- `Containment::restore(KConfigGroup&)` overwrites it with the form factor stored in config
- `SystemTrayContainer``` also overwrites it depending on the container's form factor
I just noticed that setUsedByContainment actually renames the "reload" action to "Refresh desktop", so "refresh" is essentially useless.
Will refactor this to get rid of the dedicated "Refresh" action and just use "Reload" everywhere (with appropriate name as is currently done in the code already)
Sun, Apr 8
Let's go for it now! Thanks for patience and apologies it took so long :/
Do you have commit access? else I need your email address and can push it on your behalf.
I did the KF5 port but I don't recall doing that or why it would be there, so +1 from me if it fixes that. I don't use automounter so I don't know
Fri, Apr 6
Thanks for updating! I think this patch makes sense (and seems to work well) but I'm not too familiar with QTreeView, let's wait a bit for further feedback and merge it once Frameworks 5.45 has been tagged.
- Also use positionViewAtBeginning as contentY alone doesn't really work with the way ListView works