broulik (Kai Uwe Broulik)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Dec 14 2015, 3:47 PM (174 w, 5 d)
Availability
Available

Recent Activity

Thu, Apr 18

broulik accepted D20656: Plotter: Scope GL Program to lifespan of scenegraph node.
Thu, Apr 18, 3:50 PM · Frameworks
broulik added a comment to D20664: Fix adding "Create New..." menu to toolbar.

+1

Thu, Apr 18, 2:01 PM · Dolphin
broulik committed R120:9b24060c632e: [MPRIS Data Engine] Avoid blocking calls when changing volume (authored by broulik).
[MPRIS Data Engine] Avoid blocking calls when changing volume
Thu, Apr 18, 1:32 PM
broulik closed D20661: [MPRIS Data Engine] Avoid blocking calls when changing volume.
Thu, Apr 18, 1:32 PM · Plasma
broulik requested review of D20661: [MPRIS Data Engine] Avoid blocking calls when changing volume.
Thu, Apr 18, 12:46 PM · Plasma
broulik accepted D20579: [FrameSvgItem] Update filtering on smooth changes.
Thu, Apr 18, 11:00 AM · Frameworks
broulik committed R289:85bdacf738eb: [Notify by Portal] Support default action and priority hints (authored by broulik).
[Notify by Portal] Support default action and priority hints
Thu, Apr 18, 10:52 AM
broulik closed D20649: [Notify by Portal] Support default action and priority hints.
Thu, Apr 18, 10:52 AM · Frameworks
broulik updated the diff for D20649: [Notify by Portal] Support default action and priority hints.
  • Support high
  • Handle all switch cases
Thu, Apr 18, 9:25 AM · Frameworks
broulik committed R289:134e131762e9: [KNotification] Add HighUrgency (authored by broulik).
[KNotification] Add HighUrgency
Thu, Apr 18, 9:24 AM
broulik closed D20648: [KNotification] Add HighUrgency.
Thu, Apr 18, 9:24 AM · Frameworks
broulik requested review of D20655: Use generated DBus interface.
Thu, Apr 18, 9:04 AM · Frameworks
broulik added inline comments to D20648: [KNotification] Add HighUrgency.
Thu, Apr 18, 8:38 AM · Frameworks
broulik committed R845:b553905222dc: Show Vaults action only for local folders (authored by broulik).
Show Vaults action only for local folders
Thu, Apr 18, 8:22 AM
broulik closed D20635: Show Vaults action only for local folders.
Thu, Apr 18, 8:22 AM · Plasma
broulik added a dependent revision for D20648: [KNotification] Add HighUrgency: D20651: Support default action, priority hints, set desktop-entry.
Thu, Apr 18, 8:22 AM · Frameworks
broulik added a dependency for D20651: Support default action, priority hints, set desktop-entry: D20648: [KNotification] Add HighUrgency.
Thu, Apr 18, 8:22 AM · Plasma
broulik requested review of D20651: Support default action, priority hints, set desktop-entry.
Thu, Apr 18, 8:20 AM · Plasma
broulik added a dependent revision for D20158: Allow to set urgency for notifications: D20651: Support default action, priority hints, set desktop-entry.
Thu, Apr 18, 8:20 AM · Frameworks
broulik requested review of D20649: [Notify by Portal] Support default action and priority hints.
Thu, Apr 18, 8:16 AM · Frameworks
broulik requested review of D20648: [KNotification] Add HighUrgency.
Thu, Apr 18, 8:14 AM · Frameworks
broulik added a comment to D15418: Dim application icon when it is not playing anything.

Not a huge fan of this giant gap tbh

Thu, Apr 18, 8:03 AM · Plasma
broulik added a comment to D20158: Allow to set urgency for notifications.

Good point, I shall space them apart a bit.

Thu, Apr 18, 7:25 AM · Frameworks

Wed, Apr 17

broulik added a comment to D20158: Allow to set urgency for notifications.

@vkrause I just noticed xdg portal notification spec (the ones used for sandboxed flatpak apps) has four urgency levels: low, normal, *high*, critical.
Do you think it would be useful to add HighUrgency, too? For Android, maybe? For freedesktop Notifications we could just map High to Normal then (like Gnome does it).
It's not released yet, we can still meddle the enums for another few weeks :)

Wed, Apr 17, 8:17 PM · Frameworks
broulik accepted D20638: [Widget Explorer] Continue using a trash can icon for deleting delegates.
Wed, Apr 17, 6:00 PM · Plasma
broulik accepted D20637: [Widget Explorer] Continue using a trash can icon for "Uninstallable" category.
Wed, Apr 17, 5:52 PM · Plasma
broulik accepted D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons.

Volume icon are consistent now, Vault icon in tray is prettier (imho), media controls look unchanged/fine, folder view nav buttons look fine/better, lgtm

Wed, Apr 17, 4:28 PM · Frameworks
broulik added inline comments to D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI.
Wed, Apr 17, 3:37 PM · Plasma
broulik requested changes to D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI.
Wed, Apr 17, 3:34 PM · Plasma
broulik added inline comments to D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI.
Wed, Apr 17, 3:34 PM · Plasma
broulik requested review of D20635: Show Vaults action only for local folders.
Wed, Apr 17, 2:59 PM · Plasma
broulik accepted D17410: Add alternatives button to applet configuration in panel edit mode.
Wed, Apr 17, 1:57 PM · VDG, Plasma
broulik requested changes to D17410: Add alternatives button to applet configuration in panel edit mode.
Wed, Apr 17, 1:41 PM · VDG, Plasma
broulik added a comment to D20576: Add new notifications KCM.

List-remove looks awful in this context

Wed, Apr 17, 8:56 AM · Plasma
broulik added a dependent revision for D20631: Support CriticalNotification window type: D20629: Support CriticalNotification type and place it in a CriticalNotificationLayer.
Wed, Apr 17, 8:52 AM · Plasma
broulik added dependencies for D20629: Support CriticalNotification type and place it in a CriticalNotificationLayer: D20631: Support CriticalNotification window type, D20628: Add CriticalNotification window type to PlasmaShellSurface protocol.
Wed, Apr 17, 8:52 AM · KWin
broulik added a dependent revision for D20628: Add CriticalNotification window type to PlasmaShellSurface protocol: D20629: Support CriticalNotification type and place it in a CriticalNotificationLayer.
Wed, Apr 17, 8:52 AM · Frameworks
broulik updated the test plan for D20629: Support CriticalNotification type and place it in a CriticalNotificationLayer.
Wed, Apr 17, 8:51 AM · KWin
broulik requested review of D20631: Support CriticalNotification window type.
Wed, Apr 17, 8:51 AM · Plasma
broulik closed D20624: Add missing window types to WindowInfo.
Wed, Apr 17, 8:49 AM · Plasma
broulik committed R130:9436a2c1afe4: Add missing window types to WindowInfo (authored by broulik).
Add missing window types to WindowInfo
Wed, Apr 17, 8:49 AM
broulik requested review of D20630: [Dialog] Add CriticalNotification type.
Wed, Apr 17, 8:39 AM · Frameworks
broulik added a dependent revision for D20627: Introduce CriticalNotificationType: D20630: [Dialog] Add CriticalNotification type.
Wed, Apr 17, 8:39 AM · Frameworks
broulik added a dependent revision for D20627: Introduce CriticalNotificationType: D20629: Support CriticalNotification type and place it in a CriticalNotificationLayer.
Wed, Apr 17, 8:38 AM · Frameworks
broulik requested review of D20629: Support CriticalNotification type and place it in a CriticalNotificationLayer.
Wed, Apr 17, 8:38 AM · KWin
broulik requested review of D20628: Add CriticalNotification window type to PlasmaShellSurface protocol.
Wed, Apr 17, 8:27 AM · Frameworks
broulik requested review of D20627: Introduce CriticalNotificationType.
Wed, Apr 17, 8:24 AM · Frameworks
broulik abandoned D20154: Raise notifications with KeepAbove flag to OnScreenDisplay layer.
Wed, Apr 17, 8:23 AM · KWin
broulik requested review of D20624: Add missing window types to WindowInfo.
Wed, Apr 17, 7:47 AM · Plasma
broulik added a comment to D20612: [Kickoff] Modernize settings window layout.

+1

Wed, Apr 17, 7:00 AM · Plasma

Tue, Apr 16

broulik added inline comments to D20533: Display a shortcut to the kcm Energy Information from the battery applet context menu.
Tue, Apr 16, 2:22 PM · Plasma
broulik added a comment to D20602: Air/Oxygen desktoptheme: fix progressbar height using "hint-bar-size".

+1

Tue, Apr 16, 1:16 PM · Frameworks
broulik requested changes to D20283: [RFC] [SimpleKCM] Fix height calculation.

Instead of swapping out one random number for another, please correctly calculate the implicit size of the page, like GridViewKCM does:
Something like

implicitHeight: Math.min(flickable.contentHeight, Kirigami.Units.gridUnit * 20)
                    + topPadding + bottomPadding
                    + (header && header.visible ? header.height + header.topPadding + header.bottomPadding : 0)
                    + (footer && footer.visible ? footer.height + footer.topPadding + footer.bottomPadding : 0) + Kirigami.Units.gridUnit

plus the page's own padding or so. :)

Tue, Apr 16, 1:10 PM · Frameworks
broulik abandoned D9878: [Notifications] Keep notification popup open when covered by fullscreen window.

Obsoleted by new notification system which has a better history overall

Tue, Apr 16, 11:13 AM · Plasma
broulik requested review of D20154: Raise notifications with KeepAbove flag to OnScreenDisplay layer.
Tue, Apr 16, 11:07 AM · KWin
broulik added a comment to D20154: Raise notifications with KeepAbove flag to OnScreenDisplay layer.

I can make you a new layer if you want. There's also D18365 to make keep above work.

Tue, Apr 16, 11:07 AM · KWin
broulik added a comment to D20576: Add new notifications KCM.

The trash icons in the app list make me think that it's going to uninstall those apps lol

Tue, Apr 16, 10:25 AM · Plasma
broulik committed R856:999e790c1eeb: Only consider player gone if really no longer part of the visible DOM (authored by broulik).
Only consider player gone if really no longer part of the visible DOM
Tue, Apr 16, 9:48 AM
broulik closed D20582: Only consider player gone if really no longer part of the visible DOM.
Tue, Apr 16, 9:48 AM · Plasma
broulik closed D20594: Fix MobileTextSelection namespacing.

https://cgit.kde.org/plasma-framework.git/commit/?id=8431223542110fd112cda5a4b352ab4a8a21bb51

Tue, Apr 16, 9:33 AM · Frameworks
broulik updated the diff for D20582: Only consider player gone if really no longer part of the visible DOM.
  • Rebase
Tue, Apr 16, 9:29 AM · Plasma
broulik committed R856:7cd776720613: Minimize code duplication between node and its children (authored by broulik).
Minimize code duplication between node and its children
Tue, Apr 16, 9:26 AM
broulik closed D20593: Minimize code duplication between node and its children.
Tue, Apr 16, 9:26 AM · Plasma
broulik added a comment to D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues.

way to align Kirigami.FormLayout together in a repeater.

Tue, Apr 16, 9:25 AM · Plasma
broulik committed R856:2a8ac45707bd: Set Breeze scrollbars only on HTML tag (authored by broulik).
Set Breeze scrollbars only on HTML tag
Tue, Apr 16, 9:13 AM
broulik closed D20596: Set Breeze scrollbars only on HTML tag.
Tue, Apr 16, 9:13 AM · Plasma
broulik requested review of D20596: Set Breeze scrollbars only on HTML tag.
Tue, Apr 16, 8:12 AM · Plasma
broulik added a reviewer for D20594: Fix MobileTextSelection namespacing: lbeltrame.
Tue, Apr 16, 7:50 AM · Frameworks
broulik requested review of D20594: Fix MobileTextSelection namespacing.
Tue, Apr 16, 7:49 AM · Frameworks
broulik committed R311:25f9723e87ce: Set correct kwalletd_bin_path (authored by broulik).
Set correct kwalletd_bin_path
Tue, Apr 16, 7:41 AM
broulik closed D20592: Set correct kwalletd_bin_path.
Tue, Apr 16, 7:41 AM · Frameworks
broulik requested review of D20593: Minimize code duplication between node and its children.
Tue, Apr 16, 7:40 AM · Plasma
broulik requested review of D20592: Set correct kwalletd_bin_path.
Tue, Apr 16, 7:30 AM · Frameworks
broulik added a comment to D20153: Move keep-above clients to the Normal layer when showing desktop.

-1 Yakuake is now invisible when showing desktop (and toggling it in has no visible effect) and worse: Plasma popups, like the application launcher also don't show up. I would classify this bugreport as wontfix/intentional.

Tue, Apr 16, 7:22 AM · KWin

Mon, Apr 15

broulik added inline comments to D20428: separe mobile text selection to avoid recursive imports.
Mon, Apr 15, 8:49 PM · Frameworks
broulik updated the summary of D20582: Only consider player gone if really no longer part of the visible DOM.
Mon, Apr 15, 6:07 PM · Plasma
broulik requested review of D20582: Only consider player gone if really no longer part of the visible DOM.
Mon, Apr 15, 6:04 PM · Plasma
broulik updated the diff for D19857: [DownloadJob] Report total size only if known.
Mon, Apr 15, 6:00 PM · Plasma
broulik added a comment to D20492: Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged..

I think remaining time is way too unreliable for this. We first need a way to calculate a moving average before showing it i this context imho

Mon, Apr 15, 3:58 PM · Plasma
broulik added a comment to D20533: Display a shortcut to the kcm Energy Information from the battery applet context menu.

-1 please let's cleanup / rewrite the energy info kcm first using Kirigami FormLayout and kcm components before making it prominently accessible from the UI

Mon, Apr 15, 3:56 PM · Plasma
broulik added inline comments to D20576: Add new notifications KCM.
Mon, Apr 15, 3:38 PM · Plasma
broulik updated the test plan for D20576: Add new notifications KCM.
Mon, Apr 15, 3:18 PM · Plasma
broulik added a dependent revision for D20266: Add new notification plasmoid: D20576: Add new notifications KCM.
Mon, Apr 15, 3:12 PM · Plasma
broulik requested review of D20576: Add new notifications KCM.
Mon, Apr 15, 3:12 PM · Plasma
broulik added a dependent revision for D20265: Introduce libnotificationmanager: D20576: Add new notifications KCM.
Mon, Apr 15, 3:12 PM · Plasma
broulik committed R119:004a69673ab0: Merge branch 'master' into kcm-redesign/notifications (authored by broulik).
Merge branch 'master' into kcm-redesign/notifications
Mon, Apr 15, 3:07 PM
broulik committed R119:be33b5f1665d: Finishing touches (authored by broulik).
Finishing touches
Mon, Apr 15, 3:06 PM
broulik committed R242:2a636d66712f: [FrameSvgItem] Respect smooth property (authored by broulik).
[FrameSvgItem] Respect smooth property
Mon, Apr 15, 10:46 AM
broulik closed D20570: [FrameSvgItem] Respect smooth property.
Mon, Apr 15, 10:46 AM · Frameworks
broulik updated the diff for D20570: [FrameSvgItem] Respect smooth property.
  • Also update corner nodes
Mon, Apr 15, 10:40 AM · Frameworks
broulik planned changes to D20570: [FrameSvgItem] Respect smooth property.
Mon, Apr 15, 10:37 AM · Frameworks
broulik requested review of D20570: [FrameSvgItem] Respect smooth property.
Mon, Apr 15, 10:36 AM · Frameworks
broulik added inline comments to D20569: RFC: Use more compact OSD.
Mon, Apr 15, 9:13 AM · Plasma
broulik added a comment to D20569: RFC: Use more compact OSD.

Great i hope we can make notifications more compact too

Mon, Apr 15, 8:53 AM · Plasma
broulik added a comment to D20569: RFC: Use more compact OSD.
No matter where you place it, given that you can e.g. press the volume button multiple times whilst notifications are incoming, placement will be tricky and, depending on how it is solved, jumpy.
Mon, Apr 15, 8:38 AM · Plasma
broulik requested review of D20569: RFC: Use more compact OSD.
Mon, Apr 15, 8:06 AM · Plasma
broulik committed R369:0808781d7059: Add DesktopEntry to notifyrc (authored by broulik).
Add DesktopEntry to notifyrc
Mon, Apr 15, 7:17 AM
broulik closed D20469: Add DesktopEntry to notifyrc.
Mon, Apr 15, 7:17 AM
broulik committed R7:f29a152502ce: Add DesktopEntry to notifyrc (authored by broulik).
Add DesktopEntry to notifyrc
Mon, Apr 15, 7:15 AM
broulik closed D20494: Add DesktopEntry to notifyrc.
Mon, Apr 15, 7:15 AM