broulik (Kai Uwe Broulik)
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Dec 14 2015, 3:47 PM (148 w, 6 d)
Availability
Available

Recent Activity

Yesterday

broulik added a comment to D16331: GTK theme treeview style typo/bug fix.

I noticed there's a bunch more places where seperator is used, e.g. in gtk-3.18 and dark, I guess these should be fixed as well?

Sat, Oct 20, 7:20 AM · Breeze, Plasma
broulik added a comment to D16331: GTK theme treeview style typo/bug fix.

Thanks, makes sense. Do you have commit access?

Sat, Oct 20, 7:19 AM · Breeze, Plasma
broulik accepted D16331: GTK theme treeview style typo/bug fix.
Sat, Oct 20, 7:19 AM · Breeze, Plasma
broulik added a comment to D16307: [KStandardItemListWidget] Pass icon state to overlay painter.

Not sure this is semantically correct. The fact that some emblems are white with no border is an implementation detail that Dolphin shouldn't have to care about.

Sat, Oct 20, 7:19 AM · Dolphin
broulik resigned from D16327: Update libdbusmenuqt folder.

Oh, wait, appmenu thing has its own copy of libdbusmenu-qt?

Sat, Oct 20, 7:15 AM · Plasma
broulik requested changes to D16327: Update libdbusmenuqt folder.

Can you rebase this patch? I already made it use categorized logging a few weeks ago. There's also random other bits of changes, be more specific what the change should do, "update" isn't

Sat, Oct 20, 7:15 AM · Plasma

Fri, Oct 19

acrouthamel awarded D16307: [KStandardItemListWidget] Pass icon state to overlay painter a Orange Medal token.
Fri, Oct 19, 1:42 PM · Dolphin
broulik committed R120:cd832d74c93d: Merge branch 'Plasma/5.14' (authored by broulik).
Merge branch 'Plasma/5.14'
Fri, Oct 19, 1:33 PM
broulik committed R120:5244b98d7b47: Merge branch 'Plasma/5.12' into Plasma/5.14 (authored by broulik).
Merge branch 'Plasma/5.12' into Plasma/5.14
Fri, Oct 19, 1:33 PM
broulik committed R120:be3b80e78017: Plasmashell freezes when trying to get free space info from mounted remote… (authored by McPain).
Plasmashell freezes when trying to get free space info from mounted remote…
Fri, Oct 19, 1:30 PM
broulik updated the test plan for D16316: [Kicker] Rename id column to itemColumn.
Fri, Oct 19, 1:17 PM · Plasma
broulik requested review of D16316: [Kicker] Rename id column to itemColumn.
Fri, Oct 19, 1:00 PM · Plasma
broulik accepted D16313: Use QMenu::addSeparator.
Fri, Oct 19, 12:02 PM · Frameworks
broulik retitled D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob from [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob to RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob.
Fri, Oct 19, 10:54 AM · Frameworks
broulik requested review of D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob.
Fri, Oct 19, 10:54 AM · Frameworks
broulik committed R373:edbac9239ef8: Avoid nullptr access (authored by broulik).
Avoid nullptr access
Fri, Oct 19, 9:35 AM
broulik closed D16290: Avoid nullptr access.
Fri, Oct 19, 9:35 AM
broulik committed R856:a147c5495726: Merge branch 'Plasma/5.14' (authored by broulik).
Merge branch 'Plasma/5.14'
Fri, Oct 19, 9:33 AM
broulik committed R856:9376116374ef: Lower Qt dependency to 5.9 (authored by broulik).
Lower Qt dependency to 5.9
Fri, Oct 19, 9:32 AM
broulik added a comment to T9895: Improving single-click.

Windows explorer has also a feature like this I think already since the XP era.

Fri, Oct 19, 7:32 AM · VDG
broulik added a comment to D16301: Remove ComponentInstaller.

Method InstallPackages

Fri, Oct 19, 7:26 AM · Frameworks
broulik updated the test plan for D16307: [KStandardItemListWidget] Pass icon state to overlay painter.
Fri, Oct 19, 5:54 AM · Dolphin
broulik requested review of D16307: [KStandardItemListWidget] Pass icon state to overlay painter.
Fri, Oct 19, 5:52 AM · Dolphin

Thu, Oct 18

broulik resigned from D14697: X11: set GDK_SCALE (try 2).

I guess this can go in so we can have a full cycle of testing?

Thu, Oct 18, 4:45 PM · Plasma
broulik requested review of D16301: Remove ComponentInstaller.
Thu, Oct 18, 3:02 PM · Frameworks
broulik committed R242:e92ed94d9d1a: Remove PLASMA_NO_KIO option (authored by broulik).
Remove PLASMA_NO_KIO option
Thu, Oct 18, 2:47 PM
broulik closed D16295: Remove PLASMA_NO_KIO.
Thu, Oct 18, 2:47 PM · Frameworks
broulik added a comment to D16300: Remove double underscore (__) from header include guards.

It could have just gone #pramga once

Thu, Oct 18, 2:43 PM · Frameworks, Kate
broulik added a comment to D16298: prevent avahi signal racing.

Not sure if evil or genius ;)
Looks sane, as sane as it gets, obviously.

Thu, Oct 18, 11:16 AM · Frameworks
broulik requested review of D16297: [DBusMenuImporter] Don't call removeAction() to avoid an empty QMenu.
Thu, Oct 18, 11:03 AM · Plasma
broulik requested review of D16295: Remove PLASMA_NO_KIO.
Thu, Oct 18, 10:34 AM · Frameworks
broulik committed R114:d4d12f45143e: Merge branch 'Plasma/5.14' (authored by broulik).
Merge branch 'Plasma/5.14'
Thu, Oct 18, 10:02 AM
broulik committed R114:f328668559cc: [Minimize All Plasmoid] Import QtQuick 2.7 (authored by broulik).
[Minimize All Plasmoid] Import QtQuick 2.7
Thu, Oct 18, 10:02 AM
broulik closed D16292: [Minimize All Plasmoid] Import QtQuick 2.7.
Thu, Oct 18, 10:02 AM · Plasma
broulik added a comment to D16293: [wayland] Set better placement for XDG Toplevels.

That bug number seems incorrect, did you mean Bug 393167?

Thu, Oct 18, 9:50 AM · KWin
broulik added a comment to D14830: Add "Configure Displays" context menu entry on the desktop.

Note that Microsoft removed that option in Vista in favor of a "Personalize" option but brought a dedicated Screen configuration entry back in Windows 7 which has remained to this very day.

Thu, Oct 18, 9:48 AM · Plasma
broulik requested review of D16292: [Minimize All Plasmoid] Import QtQuick 2.7.
Thu, Oct 18, 9:36 AM · Plasma
broulik closed D16291: Center icons properly if size doesn't fit.
Thu, Oct 18, 8:47 AM · Frameworks
broulik committed R302:2699d36365fa: Center icons properly if size doesn't fit (authored by broulik).
Center icons properly if size doesn't fit
Thu, Oct 18, 8:47 AM
broulik updated the diff for D16291: Center icons properly if size doesn't fit.
  • Also properly create new pixmap
Thu, Oct 18, 8:13 AM · Frameworks
broulik requested review of D16291: Center icons properly if size doesn't fit.
Thu, Oct 18, 8:08 AM · Frameworks
broulik added a reviewer for D16290: Avoid nullptr access: ngraham.
Thu, Oct 18, 7:15 AM
broulik requested review of D16290: Avoid nullptr access.
Thu, Oct 18, 7:12 AM
broulik added a comment to D16285: Remember printing option and print range in the print dialog.

This new information is saved/remembered per-document and not globally, right?

Thu, Oct 18, 6:17 AM · Okular

Wed, Oct 17

broulik added a comment to D16279: Show progress when sending a file from desktop.

Don't ask me how exactly this works.

Wed, Oct 17, 8:04 PM · KDE Connect
broulik accepted D16275: don't set a user if there is no user.

I wonder why QUrl doesn't clean that up on its own

Wed, Oct 17, 3:20 PM · Plasma
broulik accepted D16273: port knetattach from kurl to qurl.
Wed, Oct 17, 2:59 PM · Plasma
broulik accepted D16272: apply eexist workaround from listDir to stat as well.
Wed, Oct 17, 2:28 PM · Frameworks, Dolphin
broulik committed R320:a255d3d9f7f1: Merge branch 'Applications/18.08' (authored by broulik).
Merge branch 'Applications/18.08'
Wed, Oct 17, 10:32 AM
broulik committed R320:767415da97a7: Avoid crash by not checking free space for smb:// (authored by broulik).
Avoid crash by not checking free space for smb://
Wed, Oct 17, 10:32 AM
broulik added inline comments to D16266: [Extractor] Make extractor crash resilient.
Wed, Oct 17, 10:08 AM · Baloo, Frameworks
broulik accepted D16237: [Scheduler] Reuse mimetype from UnindexedFileIterator in indexer.
Wed, Oct 17, 9:54 AM · Baloo, Frameworks
broulik accepted D16269: Show correct current download and upload speed.
Wed, Oct 17, 8:22 AM · Plasma
broulik committed R228:04c3081152d4: Fix check for ASCII < 32 (authored by broulik).
Fix check for ASCII < 32
Wed, Oct 17, 7:45 AM
broulik added a comment to D16231: [ksmserver] Rewrite Startup.

Pretty cool!

Wed, Oct 17, 7:35 AM · Plasma

Mon, Oct 15

broulik accepted D16217: Do not capture 'this' as it is not used.
Mon, Oct 15, 2:50 PM
broulik committed R134:c087ee92a3c4: Merge branch 'Plasma/5.14' (authored by broulik).
Merge branch 'Plasma/5.14'
Mon, Oct 15, 7:59 AM
broulik committed R134:f237e7c0ccc8: [Discover Notifier] Open Updates page in notification (authored by broulik).
[Discover Notifier] Open Updates page in notification
Mon, Oct 15, 7:59 AM
broulik closed D16152: [Discover Notifier] Open Updates page in notification.
Mon, Oct 15, 7:59 AM · Plasma
broulik committed R120:6e74d7fbf598: Merge branch 'Plasma/5.14' (authored by broulik).
Merge branch 'Plasma/5.14'
Mon, Oct 15, 7:58 AM
broulik committed R120:824279fce904: [Global Menu Applet] Fix menu layout option being always disabled (authored by broulik).
[Global Menu Applet] Fix menu layout option being always disabled
Mon, Oct 15, 7:58 AM
broulik closed D16149: [Global Menu Applet] Fix menu layout option being always disabled.
Mon, Oct 15, 7:58 AM · Plasma
broulik added inline comments to D16204: Quick Open: Remove file:/// prefix.
Mon, Oct 15, 7:23 AM · Kate

Sun, Oct 14

broulik accepted D16154: fix Service(Type)Browser documentation.
Sun, Oct 14, 4:06 PM · Frameworks
broulik accepted D16189: kio_help: Fix crash in QCoreApplication when accessing help://.

Funny, I just noticed the same thing yesterday and was just about to make a patch but then saw this

Sun, Oct 14, 11:33 AM · Frameworks

Fri, Oct 12

broulik added a comment to D16087: RFC: Store full URL as URI.

Alright, so we have two bugs then:

Fri, Oct 12, 12:07 PM · Plasma
broulik committed R108:3d1b2381ec9d: Merge branch 'Plasma/5.14' (authored by broulik).
Merge branch 'Plasma/5.14'
Fri, Oct 12, 11:54 AM
broulik committed R108:1fe3c765cddf: Merge branch 'Plasma/5.12' into Plasma/5.14 (authored by broulik).
Merge branch 'Plasma/5.12' into Plasma/5.14
Fri, Oct 12, 11:54 AM
broulik committed R108:980e390743c1: [kcmkwin/ruleswidget] Disable "Detect" button when countdown is running (authored by broulik).
[kcmkwin/ruleswidget] Disable "Detect" button when countdown is running
Fri, Oct 12, 11:53 AM
broulik closed D16124: [kcmkwin/ruleswidget] Disable "Detect" button when countdown is running.
Fri, Oct 12, 11:53 AM · KWin
broulik committed R370:47b79eebb06c: Merge branch 'Applications/18.08' (authored by broulik).
Merge branch 'Applications/18.08'
Fri, Oct 12, 11:49 AM
broulik committed R370:930e045e8bfd: Set mime type for special text files (authored by broulik).
Set mime type for special text files
Fri, Oct 12, 11:48 AM
broulik committed R370:c6de183c2396: Merge branch 'Applications/18.08' (authored by broulik).
Merge branch 'Applications/18.08'
Fri, Oct 12, 11:46 AM
broulik committed R370:8a057ef9b865: Fix opening special text files (authored by broulik).
Fix opening special text files
Fri, Oct 12, 11:44 AM
broulik closed D16126: Fix opening special text files.
Fri, Oct 12, 11:44 AM
broulik updated the test plan for D16152: [Discover Notifier] Open Updates page in notification.
Fri, Oct 12, 9:19 AM · Plasma
broulik requested review of D16152: [Discover Notifier] Open Updates page in notification.
Fri, Oct 12, 9:19 AM · Plasma
broulik committed R370:0494eb1947d2: Merge branch 'Applications/18.08' (authored by broulik).
Merge branch 'Applications/18.08'
Fri, Oct 12, 8:44 AM
broulik committed R370:467ad9f7e017: Add Messages.sh (authored by broulik).
Add Messages.sh
Fri, Oct 12, 8:44 AM
broulik closed D16150: Add Messages.sh for KIO slave.
Fri, Oct 12, 8:44 AM
broulik updated the diff for D16150: Add Messages.sh for KIO slave.
  • Use kio5 prefix
Fri, Oct 12, 7:22 AM
broulik requested review of D16150: Add Messages.sh for KIO slave.
Fri, Oct 12, 7:00 AM
broulik requested review of D16149: [Global Menu Applet] Fix menu layout option being always disabled.
Fri, Oct 12, 6:56 AM · Plasma
broulik added a comment to D16141: Disable unmount option for / or /home.

Why would you be unable to unmount /home? If you're logged in as root (not saying that one should or can), whose home is /root you can surely unmount /home

Fri, Oct 12, 6:31 AM · Frameworks
broulik added a comment to D16125: Add QCoreApplication.

Fixed, sorry https://cgit.kde.org/kamera.git/commit/?id=e22151ed9e61693d4e1e6275745ed09804ffb687

Fri, Oct 12, 6:19 AM
broulik committed R370:9d6acf614c11: Merge branch 'Applications/18.08' (authored by broulik).
Merge branch 'Applications/18.08'
Fri, Oct 12, 6:18 AM
broulik committed R370:e22151ed9e61: Fix build (authored by broulik).
Fix build
Fri, Oct 12, 6:18 AM

Thu, Oct 11

broulik committed R370:9f272d40ef3c: Merge branch 'Applications/18.08' (authored by broulik).
Merge branch 'Applications/18.08'
Thu, Oct 11, 1:30 PM
broulik committed R370:b17dd284090f: Add QCoreApplication (authored by broulik).
Add QCoreApplication
Thu, Oct 11, 1:30 PM
broulik closed D16125: Add QCoreApplication.
Thu, Oct 11, 1:30 PM
broulik added a comment to D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg.

QMetaObject::invokeMethod takes function pointers since Qt 5.10

Thu, Oct 11, 10:26 AM · Gwenview
broulik requested review of D16126: Fix opening special text files.
Thu, Oct 11, 9:20 AM
broulik requested review of D16125: Add QCoreApplication.
Thu, Oct 11, 9:07 AM
broulik requested review of D16124: [kcmkwin/ruleswidget] Disable "Detect" button when countdown is running.
Thu, Oct 11, 8:12 AM · KWin
broulik committed R111:956c9f29b9b9: Add ifdef for webengine (authored by broulik).
Add ifdef for webengine
Thu, Oct 11, 6:10 AM

Wed, Oct 10

broulik requested review of D16108: When re-using runners when reloading, reload their configuration .
Wed, Oct 10, 3:42 PM · Frameworks
broulik committed R320:ec93501d3318: [AppImage Thumbnailer] Avoid creating QTemporaryFile (authored by broulik).
[AppImage Thumbnailer] Avoid creating QTemporaryFile
Wed, Oct 10, 3:09 PM
broulik closed D15417: [AppImage Thumbnailer] Avoid creating QTemporaryFile.
Wed, Oct 10, 3:09 PM · Frameworks, Dolphin
broulik accepted D16060: Reduce double and triple lookups to the frames hash.
Wed, Oct 10, 2:48 PM · Frameworks
broulik added inline comments to D16060: Reduce double and triple lookups to the frames hash.
Wed, Oct 10, 2:44 PM · Frameworks