- User Since
- Dec 14 2015, 3:47 PM (192 w, 1 d)
I don't really see the point in this cleanup as it only messes up git history and doesn't actually follow coding style better
Can we keep it on mobile?
Theres's also the directory icon reading which potentially blocks, so doing both in the KIO slave improves the situation without having to introduce new API and rewrite everything and the kitchen sink.
Whatever happened to m_iconName?
Mon, Aug 19
Fix it, then shipit!
It literally says in the commit message that this will be moved exactly there.
You cannot remove those from the dataengine, which is "Public API", there might be other users of that.
Instead, remove them from the battery monitor UI. And while at it maybe show the details always even if there are multiple batteries.
Capacity is also used in battery monitor to show a hint like "Your battery is broken"
I think a warning is appropriate as opening a gazillion applications could lead to an unresponsive system.
Not a fan.
Fri, Aug 16
Working very nice now! Just some minor nitpicks then this can go in
fileSystemType calls statvfs which might also block, so I don't think this helps.
Thu, Aug 15
- Reset to -1
- Use urls again
- Address comments
Wed, Aug 14
We agreed that code-wise a multiplier is easier but then the name of the group should be adjusted to reflect that.
- Remove leftover testing code
- Check the right thing...
- redundant check
- ret var
Depends on the
Then please investigate what's going on there.
- use new promise-based reply message API
That property is whether the selected battery powers the computer or is just a peripheral. Perhaps just the label must be changed?
I think this is a bug in KDE Connect? I've seen numerous people complain about that in the new notification system that didn't filter them out originally.
Tue, Aug 13
- We're signed int :)
- Properly support zero as serial
- Wrap int max properly
Didn't add it to settings as I have some follow-up patches that will actually use the other overload, too
- Silence method hidden warning
- Don't write config keys for which we don't have a default
Mon, Aug 12
- address review comments
- Register ourselves before passing on to the browser which may throw
Can you check out the KBookmarks framework which has classes for processing xbel files