broulik (Kai Uwe Broulik)
User

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Dec 14 2015, 3:47 PM (104 w, 12 h)
Availability
Available

Recent Activity

Yesterday

broulik committed R40:ed2382545acd: Fix build with Qt < 5.7 (authored by broulik).
Fix build with Qt < 5.7
Mon, Dec 11, 10:06 AM
broulik closed D9283: Fix build with Qt < 5.7.
Mon, Dec 11, 10:06 AM · Kate

Sun, Dec 10

broulik updated the diff for D9283: Fix build with Qt < 5.7.

Disable feature for Qt 5.7
This feature requires a change in Plasma 5.11 task manager and distros shipping Qt 5.6 cannot have it

Sun, Dec 10, 9:29 PM · Kate
broulik created D9283: Fix build with Qt < 5.7.
Sun, Dec 10, 9:27 PM · Kate
Restricted Application edited projects for D9136: Add support for version 3 of data device manager interface, added: Plasma on Wayland; removed Plasma.

lgtm

Sun, Dec 10, 4:56 PM · Plasma on Wayland, Frameworks

Sat, Dec 9

broulik added a comment to D9255: [Notifications] Add visible menu button to thumbnail strip.

Or should we remove the "Öffnen/Open" button?

Sat, Dec 9, 10:29 PM · Plasma

Fri, Dec 8

broulik accepted D9258: Disconnect shortcutedit slot on widget destruction.
Fri, Dec 8, 3:48 PM · Frameworks, Plasma
broulik added a comment to D9255: [Notifications] Add visible menu button to thumbnail strip.

put it right under the existing Open button

Fri, Dec 8, 2:53 PM · Plasma
broulik created D9255: [Notifications] Add visible menu button to thumbnail strip.
Fri, Dec 8, 2:21 PM · Plasma

Thu, Dec 7

broulik closed D9240: [RunnerManager] Don't mess with ThreadWeaver thread count.
Thu, Dec 7, 4:15 PM · Plasma, Frameworks
broulik committed R308:98aa41f388f4: [RunnerManager] Don't mess with ThreadWeaver thread count (authored by broulik).
[RunnerManager] Don't mess with ThreadWeaver thread count
Thu, Dec 7, 4:15 PM
broulik updated the diff for D9240: [RunnerManager] Don't mess with ThreadWeaver thread count.
Thu, Dec 7, 2:59 PM · Plasma, Frameworks
broulik added inline comments to D9240: [RunnerManager] Don't mess with ThreadWeaver thread count.
Thu, Dec 7, 2:29 PM · Plasma, Frameworks
broulik added reviewers for D9240: [RunnerManager] Don't mess with ThreadWeaver thread count: Plasma, Frameworks.
Thu, Dec 7, 2:28 PM · Plasma, Frameworks
broulik created D9240: [RunnerManager] Don't mess with ThreadWeaver thread count.
Thu, Dec 7, 2:21 PM · Plasma, Frameworks
broulik committed R119:f9a2da9a6eaf: Merge branch 'Plasma/5.11' (authored by broulik).
Merge branch 'Plasma/5.11'
Thu, Dec 7, 12:52 PM
broulik committed R119:7e2801974ab5: [Folder View] Show "Widgets unlocked" help only for containment (authored by broulik).
[Folder View] Show "Widgets unlocked" help only for containment
Thu, Dec 7, 12:51 PM
broulik closed D9222: [Folder View] Show "Widgets unlocked" help only for containment.
Thu, Dec 7, 12:51 PM · Plasma
broulik added a comment to D9227: [Breeze widget style] Override QLineEditIconButton paint event to force Active icon on press.

Patch submitted to remove the workaround in QLineEditIconButton: https://codereview.qt-project.org/#/c/213798/

Thu, Dec 7, 10:34 AM · Plasma
broulik added a comment to D9227: [Breeze widget style] Override QLineEditIconButton paint event to force Active icon on press.
to asign the icon to the clear button
Thu, Dec 7, 10:00 AM · Plasma
broulik added a comment to D9227: [Breeze widget style] Override QLineEditIconButton paint event to force Active icon on press.

So that in polish() I change the icon for QLineEditIconButton to be a QIcon which has manually put the QIcon::Active pixmaps in QIcon::Selected category? However what are the implications of this wrt speed (how often is polish called, I don't think I can "mark" the icon as "already tampered with") and when app changes the icon (need to update the thing)?

Thu, Dec 7, 9:35 AM · Plasma
broulik added inline comments to D9237: port wallpaper config fialog to Package::fileUrl.
Thu, Dec 7, 9:32 AM · Plasma

Wed, Dec 6

broulik added a comment to D9227: [Breeze widget style] Override QLineEditIconButton paint event to force Active icon on press.

Doesn't the icon not matter but it creates a pixmap with the given (wrong) state? If you find a better / easier solution I'm all for it ;)

Wed, Dec 6, 6:03 PM · Plasma
broulik added a comment to D9227: [Breeze widget style] Override QLineEditIconButton paint event to force Active icon on press.

The problem is that the button is entirely custom-painted by Qt:

void QLineEditIconButton::paintEvent(QPaintEvent *)
{
    [...]
Wed, Dec 6, 3:49 PM · Plasma
broulik updated the test plan for D9227: [Breeze widget style] Override QLineEditIconButton paint event to force Active icon on press.
Wed, Dec 6, 3:17 PM · Plasma
broulik created D9227: [Breeze widget style] Override QLineEditIconButton paint event to force Active icon on press.
Wed, Dec 6, 3:16 PM · Plasma
broulik created D9226: [Folder View] Don't let rubber band get null size.
Wed, Dec 6, 2:09 PM · Plasma
broulik created D9223: [Plasma Dialog] Call window effects only if visible.
Wed, Dec 6, 10:20 AM · Frameworks, Plasma
broulik created D9222: [Folder View] Show "Widgets unlocked" help only for containment.
Wed, Dec 6, 10:00 AM · Plasma
broulik added a comment to D9215: Make Appmenu work based on the presence of a visual representation.

+1 to the idea

Wed, Dec 6, 9:52 AM · Plasma
broulik created D9221: WIP: [KLineEdit] Use Qt's built-in clear button functionality.
Wed, Dec 6, 9:42 AM · Frameworks

Tue, Dec 5

broulik added a comment to D9217: KUriFilter: don't return an error on non-existing files..

https://bugs.kde.org/show_bug.cgi?id=372813

Tue, Dec 5, 11:01 PM
broulik committed R242:3ad4798ca683: [AppletQuickItem] Only set QtQuick Controls 1 style once per engine (authored by broulik).
[AppletQuickItem] Only set QtQuick Controls 1 style once per engine
Tue, Dec 5, 10:36 PM
broulik closed D4362: [AppletQuickItem] Only set QtQuick Controls 1 style once per engine.
Tue, Dec 5, 10:36 PM · Frameworks, Plasma
broulik added a comment to D9217: KUriFilter: don't return an error on non-existing files..

Will this fix typing ~/foo when foo does not exist return an invalid URL?

Tue, Dec 5, 10:29 PM
Restricted Application edited projects for D9216: export org.kde.appmenuview, added: KWin; removed Plasma.

Which means unless a user edited this, it's not in their config unless they explicitly added it.

Tue, Dec 5, 10:28 PM · KWin
Restricted Application edited projects for D9216: export org.kde.appmenuview, added: KWin; removed Plasma.

I'm not saying the current way it's to be configured is good, it's not, it's terrible. I really like the applet approach indeed. Mostly I'm concerned about what'll happen to existing setups when this lands, I certainly don't want appmenu to suddenly be enabled just because the appmenu button is present on the title bar (I made it the default).

Tue, Dec 5, 9:59 PM · KWin
Restricted Application edited projects for D9216: export org.kde.appmenuview, added: KWin; removed Plasma.

Not sure. Imho the button should be there by default and shown if global menu is enabled in settings. I wouldn't want people manually having to fiddle that title bar menu button in there in order for global menu to work let alone suddenly having it use it once the button is there (update case)

Tue, Dec 5, 8:45 PM · KWin
broulik added a comment to D4362: [AppletQuickItem] Only set QtQuick Controls 1 style once per engine.

Ping. (Stupid Phab doesn't move this thing to the top in search result because it'd ooooold)

Tue, Dec 5, 5:22 PM · Frameworks, Plasma
broulik added a comment to D9209: Don't set a window icon in Plasma::Dialog.

I still get an icon for plasma popups in tabbox and present windows

Tue, Dec 5, 5:20 PM · Frameworks, Plasma
broulik added a comment to D9184: Get rid of Q_FOREACH.

You probably want to be porting to range-based for loop for (foo : bar) instead. Why all these unrelated auto changes?

Tue, Dec 5, 1:04 PM
broulik added inline comments to D9194: Don't load KDE platform module in xembedsniproxy.
Tue, Dec 5, 12:17 PM · Plasma
broulik added a comment to D9195: port logout screen to kpackage fileUrl.

Can we please not mingle three separate things into one commit

Tue, Dec 5, 12:16 PM · Plasma

Mon, Dec 4

broulik committed R31:fc30704cc892: [Breeze window decoration] Use intersects instead of contains (authored by broulik).
[Breeze window decoration] Use intersects instead of contains
Mon, Dec 4, 4:07 PM
broulik added inline comments to D9152: Save an object per panel applet.
Mon, Dec 4, 2:30 PM · Plasma
broulik added a comment to D9126: [RTL] - align properly the selected text for RTL.

I don't understand. Isn't this the default and doesn't it automatically mirror it (effectiveHorizontalAlignment)? (I'd be fine with this one liner going in but I'm wondering why it would be needed in the first place)

Mon, Dec 4, 9:36 AM · Frameworks, Plasma
broulik added inline comments to D9141: Setup QQmlEngine only once in QmlObject.
Mon, Dec 4, 9:30 AM · Frameworks, Plasma

Sun, Dec 3

broulik accepted D9133: set default action when trash applet activated.
Sun, Dec 3, 10:18 PM · Plasma
broulik created D9141: Setup QQmlEngine only once in QmlObject.
Sun, Dec 3, 3:49 PM · Frameworks, Plasma
broulik committed R108:545dda720870: [PaintClipper::Iterator] Operate on QRegion instead of QVector of rects (authored by broulik).
[PaintClipper::Iterator] Operate on QRegion instead of QVector of rects
Sun, Dec 3, 3:15 PM
broulik closed D9135: [PaintClipper::Iterator] Operate on QRegion instead of QVector of rects.
Sun, Dec 3, 3:15 PM · KWin
broulik created D9135: [PaintClipper::Iterator] Operate on QRegion instead of QVector of rects.
Sun, Dec 3, 2:44 PM · KWin
broulik committed R112:18a00828675d: [ResultDelegate] Silence i18n when ListView.section is empty (authored by broulik).
[ResultDelegate] Silence i18n when ListView.section is empty
Sun, Dec 3, 2:07 PM
broulik committed R242:fae6558dae6a: Move if check inside #ifdef (authored by broulik).
Move if check inside #ifdef
Sun, Dec 3, 2:00 PM
broulik added a comment to D9122: Implement QQmlParserStatus in FolderModel.

+1

Sun, Dec 3, 11:42 AM · Plasma
broulik committed R242:ab8915bc12b4: [FrameSvgItem] Don't create unneccessary nodes (authored by broulik).
[FrameSvgItem] Don't create unneccessary nodes
Sun, Dec 3, 11:41 AM
broulik closed D9121: [FrameSvgItem] Don't create unneccessary nodes.
Sun, Dec 3, 11:41 AM · Frameworks, Plasma
broulik created D9121: [FrameSvgItem] Don't create unneccessary nodes.
Sun, Dec 3, 11:13 AM · Frameworks, Plasma
broulik committed R31:f0709ccc26c3: [Breeze window decoration] Don't repaint title bar if not damaged (authored by broulik).
[Breeze window decoration] Don't repaint title bar if not damaged
Sun, Dec 3, 10:20 AM
broulik closed D9114: [Breeze window decoration] Don't repaint title bar if not damaged.
Sun, Dec 3, 10:20 AM · Plasma
broulik updated the summary of D4362: [AppletQuickItem] Only set QtQuick Controls 1 style once per engine.
Sun, Dec 3, 10:14 AM · Frameworks, Plasma
broulik updated the diff for D4362: [AppletQuickItem] Only set QtQuick Controls 1 style once per engine.
Sun, Dec 3, 10:13 AM · Frameworks, Plasma

Sat, Dec 2

broulik accepted D9115: Don't tear down renderer and other busy work when Svg::setImagePath is invoked with the same arg.
Sat, Dec 2, 9:45 PM · Frameworks, Plasma
broulik added inline comments to D9114: [Breeze window decoration] Don't repaint title bar if not damaged.
Sat, Dec 2, 9:37 PM · Plasma
broulik updated the diff for D9114: [Breeze window decoration] Don't repaint title bar if not damaged.
  • Fix logic error
Sat, Dec 2, 5:50 PM · Plasma
broulik planned changes to D9114: [Breeze window decoration] Don't repaint title bar if not damaged.

Breaks rendering of title bar buttons on hover

Sat, Dec 2, 5:48 PM · Plasma
broulik created D9114: [Breeze window decoration] Don't repaint title bar if not damaged.
Sat, Dec 2, 5:42 PM · Plasma
broulik closed D9111: [IconItem] Use ItemSceneHasChanged rather than connect on windowChanged.
Sat, Dec 2, 5:14 PM · Frameworks, Plasma
broulik committed R242:f8e3a16040a7: [IconItem] Use ItemSceneHasChanged rather than connect on windowChanged (authored by broulik).
[IconItem] Use ItemSceneHasChanged rather than connect on windowChanged
Sat, Dec 2, 5:14 PM
broulik committed R242:da2b6e270fb6: [Icon Item] Explicitly emit overlaysChanged in the setter rather than… (authored by broulik).
[Icon Item] Explicitly emit overlaysChanged in the setter rather than…
Sat, Dec 2, 5:14 PM
broulik closed D9112: Explicitly emit overlaysChanged in the setter rather than connecting to it.
Sat, Dec 2, 5:14 PM · Frameworks, Plasma
broulik created D9112: Explicitly emit overlaysChanged in the setter rather than connecting to it.
Sat, Dec 2, 5:10 PM · Frameworks, Plasma
broulik created D9111: [IconItem] Use ItemSceneHasChanged rather than connect on windowChanged.
Sat, Dec 2, 5:03 PM · Frameworks, Plasma
broulik committed R292:f3342f4ccaba: Port from QDom to QXmlStreamReader (authored by broulik).
Port from QDom to QXmlStreamReader
Sat, Dec 2, 4:41 PM
broulik committed R292:d636f414dc75: Use https for downloading currency exchange rates (authored by broulik).
Use https for downloading currency exchange rates
Sat, Dec 2, 4:41 PM
broulik closed D8971: Port from QDom to QXmlStreamReader.
Sat, Dec 2, 4:41 PM · Frameworks
broulik closed D8970: Use https for downloading currency exchange rates.
Sat, Dec 2, 4:41 PM · Frameworks
broulik committed R108:9e8773cb43e2: [Contrast / Blur Effects] Port from QRegion::rects() to QRegion iterators (authored by broulik).
[Contrast / Blur Effects] Port from QRegion::rects() to QRegion iterators
Sat, Dec 2, 4:38 PM
broulik closed D9101: [Contrast / Blur Effects] Port from QRegion::rects() to QRegion iterators.
Sat, Dec 2, 4:38 PM · KWin
broulik added a comment to D9106: Create d-pointer for MyMoneyObject.

Instead of comparing to QString() check isEmpty()

Sat, Dec 2, 1:59 PM · KMyMoney
broulik added inline comments to D9101: [Contrast / Blur Effects] Port from QRegion::rects() to QRegion iterators.
Sat, Dec 2, 1:58 PM · KWin
broulik added inline comments to D9104: Properly do strings in the kpackage framework.
Sat, Dec 2, 12:57 PM · Frameworks, Plasma
broulik committed R120:cf86c7ffef13: [PanelView] Use KWindowSystem::isPlatformX11() instead of QX11Info (authored by broulik).
[PanelView] Use KWindowSystem::isPlatformX11() instead of QX11Info
Sat, Dec 2, 12:00 PM
broulik committed R242:cfcf8a61d552: [Dialog] Use KWindowSystem::isPlatformX11() (authored by broulik).
[Dialog] Use KWindowSystem::isPlatformX11()
Sat, Dec 2, 11:55 AM
broulik closed D9105: [Dialog] Use KWindowSystem::isPlatformX11().
Sat, Dec 2, 11:55 AM · Frameworks, Plasma
broulik created D9105: [Dialog] Use KWindowSystem::isPlatformX11().
Sat, Dec 2, 11:30 AM · Frameworks, Plasma
broulik committed R112:20375964c626: [ResultDelegate] Workaround subtextLabel leaking outside its container (authored by broulik).
[ResultDelegate] Workaround subtextLabel leaking outside its container
Sat, Dec 2, 10:50 AM
broulik committed R242:9066c232b403: [Icon Item] Emit validChanged only if it actually changed (authored by broulik).
[Icon Item] Emit validChanged only if it actually changed
Sat, Dec 2, 10:40 AM
broulik closed D9102: [Icon Item] Emit validChanged only if it actually changed.
Sat, Dec 2, 10:40 AM · Frameworks, Plasma
broulik created D9102: [Icon Item] Emit validChanged only if it actually changed.
Sat, Dec 2, 10:34 AM · Frameworks, Plasma
broulik created D9101: [Contrast / Blur Effects] Port from QRegion::rects() to QRegion iterators.
Sat, Dec 2, 10:09 AM · KWin
broulik committed R108:e9a21246698b: [SceneOpenGL] Port from QRegion::rects() to QRegion iterators (authored by broulik).
[SceneOpenGL] Port from QRegion::rects() to QRegion iterators
Sat, Dec 2, 9:07 AM
broulik committed R108:c3d41046a1a5: [Scene] Port from QRegion::rects() to QRegion iterators (authored by broulik).
[Scene] Port from QRegion::rects() to QRegion iterators
Sat, Dec 2, 9:07 AM
broulik closed D9087: [Scene] Port from QRegion::rects() to QRegion iterators.
Sat, Dec 2, 9:07 AM · KWin
broulik closed D9081: [SceneOpenGL] Port from QRegion::rects() to QRegion iterators.
Sat, Dec 2, 9:07 AM · KWin
broulik committed R108:873d38225e18: [GLVertexBuffer] Port from QRegion::rects() to QRegion iterators (authored by broulik).
[GLVertexBuffer] Port from QRegion::rects() to QRegion iterators
Sat, Dec 2, 9:07 AM
broulik closed D9082: [GLVertexBuffer] Port from QRegion::rects() to QRegion iterators.
Sat, Dec 2, 9:07 AM · KWin

Fri, Dec 1

broulik committed R116:a53821ba368c: Context menus typically open on pressed rather than on clicked (authored by broulik).
Context menus typically open on pressed rather than on clicked
Fri, Dec 1, 10:15 PM
broulik updated the diff for D9082: [GLVertexBuffer] Port from QRegion::rects() to QRegion iterators.
  • Use range for
Fri, Dec 1, 9:46 PM · KWin
broulik updated the diff for D9081: [SceneOpenGL] Port from QRegion::rects() to QRegion iterators.
  • Use range for
Fri, Dec 1, 9:44 PM · KWin