- User Since
- Dec 14 2015, 3:47 PM (166 w, 16 h)
I would have prefered nobody touching the color KCM until D18646 was merged..
Perhaps but it's only recently become an issue since kioslaves now support KCrash. Previously such thumbnailer crashes just went unnoticed.
However, you will get a Dr Konqi each time it encounters that file as it will try to generate a thumbnail for it every time you open the folder.
Sun, Feb 17
Bonus points if we could check for whether user has actually configured a "standard menu" action so we could show a big fat warning that they would lock themselves out now if they did that. Preferably even with a button to auto-assign it back if it is missing.
Fri, Feb 15
isn't QIcon::fromTheme buggy when passed an absolute path to an SVG file?
If you grep for DEBUG_ there's still plenty in Kolourpaint code
Only actual windows have PIDs, the role isn't implemented for startup tasks or launchers iirc
What's the air conditioning do? suspend to disk?
I have seen reports of powerdevil sometimes not properly starting, but that's probably unrelated to this? It's started by an autostart file I think and isn't dbus-activated
5.15 branch please
Thu, Feb 14
Please fix the warnings this now causes separately
Wed, Feb 13
The do a proper proposal (I bet you already have a task about that) instead of just slipping things in one by one in unrelated reviews
The battery icon is composited of multiple SVG items layered ontop of each other, it doesn't just load a single icon.
maybe we can port the code to use these as icons from the icon theme rather than SVGs from the Plasma theme and then delete them from the Plasma theme
Mon, Feb 11
It does kind of beg the question of why this is the only grid view that has a search, of course.
Is this good now?
Sun, Feb 10
So you had all these comments changed to be "more natural" and now you change them back to how they were before?
This breaks the font tool, can no longer change font style or font size
Sat, Feb 9
But that will create additional, potentially defunct entries in Previewer settings?
Ah, yeah, it tries and if it fails, it aborts, it doesn't try every thumbnailer that claims to support a format.
OTOH this will not work if kimageformats is not installed, and the thumbnailer gives no hint about that.
- Render image at desired size already
- Remove unused include
You'll get a thumbnail either way \o/
- Remove mimetypes left from testing
- Don't encode filename (missed that there's one other than the QByteArray one)
Can we also make KWin smarter and try to fall back to the default theme (which may also be broken, sure, but because of distro not GHNS)?
Fri, Feb 8
- Read thumbnail location from rels
- Add .xps file format (used in Windows for printing, I believe) which also follows the spec and qualifies as "office document"
If you open multiple KCMs switching between QML- and Widget-ones leads to awkward outside margin changes with this patch.
kcmshell5 icons style
Switch between the two and observe how the sidebar dances (this is likely the same issue as when doing the same in System Settings in Icons mode rather than Sidebar)
The call on line 141 looks superfluous - if there's any change to checked we modify cfg_sources which should trigger the reload.
Why is this neccessary? The other places work just fine without a domain
Thu, Feb 7
What about non-SVG icon themes like Oxygen? They will look awful when downscaled from 32 to 24.
Wed, Feb 6
- Use proper cmake thing
Tue, Feb 5
+1 I think this is a fine tradeoff between aesthetics and usability