broulik (Kai Uwe Broulik)
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Dec 14 2015, 3:47 PM (122 w, 5 d)
Availability
Available

Recent Activity

Yesterday

broulik committed R856:4c358de9a3d7: Remove shelf permission (authored by broulik).
Remove shelf permission
Sat, Apr 21, 3:45 PM

Fri, Apr 20

broulik added a comment to D12385: Thumbnail smooth scaling in filepicker.

What's the performance penalty of that? Does the file dialog request the correct size from the preview job? It shouldn't have to end up in this codepath that often, I think.

Fri, Apr 20, 5:14 PM · Frameworks
broulik updated the diff for D12380: [Containment Interface] Honor plasma/containment_context_menu restriction.
  • Also reject QMouseEvent
Fri, Apr 20, 12:47 PM · Frameworks
broulik requested review of D12380: [Containment Interface] Honor plasma/containment_context_menu restriction.
Fri, Apr 20, 12:44 PM · Frameworks
broulik requested review of D12379: [Containment Interface] Don't enter edit mode when immutable.
Fri, Apr 20, 12:20 PM · Frameworks
broulik added a comment to D12373: Klipper: Remove first history item on clipboard clear.

Ideally, there was a mime data flag an application could set to indicate it wouldn't want it to end up in clipboard history but this is probably impossible to get applications to use..

Fri, Apr 20, 11:22 AM · Plasma
broulik requested review of D12376: [ContextMenu Containment Action] Fix checking for KIOSK.
Fri, Apr 20, 11:15 AM · Plasma
broulik requested review of D12375: [Power Management Engine] Fix kiosk restriction for lockscreen.
Fri, Apr 20, 11:11 AM · Plasma
broulik committed R241:73d2036b09a9: [KUrlNavigatorButton] Also don't stat MTP (authored by broulik).
[KUrlNavigatorButton] Also don't stat MTP
Fri, Apr 20, 9:53 AM
broulik closed D12339: [KUrlNavigatorButton] Also don't stat MTP.
Fri, Apr 20, 9:53 AM · Frameworks

Thu, Apr 19

broulik added a comment to D12337: Give the file dialogs a "Sort by" menu button on the toolbar.

I don't like how the button floats in "mid air" between the two sides of the toolbar

Thu, Apr 19, 1:41 PM · Frameworks
broulik added a comment to D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does.

+1 for consistency

Thu, Apr 19, 1:40 PM · Frameworks
broulik abandoned D12273: [KCMControls GridDelegate] Show tooltip only if one is set.

My checkout wasnt up to date, this was already fixed

Thu, Apr 19, 12:52 PM · Frameworks
broulik added a reviewer for D12339: [KUrlNavigatorButton] Also don't stat MTP: Frameworks.
Thu, Apr 19, 7:11 AM · Frameworks
broulik requested review of D12339: [KUrlNavigatorButton] Also don't stat MTP.
Thu, Apr 19, 7:08 AM · Frameworks

Wed, Apr 18

broulik moved T7325: Window Decorations from Medium priority to WIP on the Plasma: KCM Redesign board.
Wed, Apr 18, 9:10 PM · Plasma: KCM Redesign
broulik moved T7243: Colors from High priority to WIP on the Plasma: KCM Redesign board.
Wed, Apr 18, 9:10 PM · Plasma: KCM Redesign
broulik added inline comments to D12293: Add actions to notifications.
Wed, Apr 18, 8:09 PM · KDE Connect
broulik added a reviewer for D12290: Don't draw list dividers: VDG.
Wed, Apr 18, 8:03 PM · KDE Connect
broulik added a comment to D12281: Enable (de)selecting all apps in notification filter.

Thanks a lot!

Wed, Apr 18, 8:02 PM · KDE Connect
broulik added a comment to D12311: Align lock icon with bold message text; reduce overall size of dialog.

I think there's something severly wrong with the dialog's size hints if we need to add arbitrary numbers all over the place. Can you make sure this doesn't break with

  • different font
  • larger font
  • screen scaling
  • different widget style
  • ...
Wed, Apr 18, 7:59 PM · Plasma
broulik accepted D12313: Consistently use text "Configure..." for applet configure buttons.

Can we fix configurationNeeded in the desktop/panel containment, please? :P

Wed, Apr 18, 7:57 PM · Plasma
broulik added a comment to D12314: expose the wallpaper config to the lockscreen.

Hmm I think it would make for a nicer API to expose wallpaperPluginName and wallpaperConfiguration directly? I find doing wallpaper.something and wallpaperIntegration.pluginName a bit awkward, but fine with me.

Wed, Apr 18, 7:55 PM · Plasma
broulik accepted D12324: Sort top-level entries as well when sorting is enabled.
Wed, Apr 18, 7:53 PM · Plasma
broulik accepted D12284: Clean up kwindecoration KCM qml code.
Wed, Apr 18, 9:55 AM · KWin
broulik updated subscribers of T7238: Lookandfeel (kinda done).

I think it could be somehow done to start a separate plasma windowed instance and tell it to temporarily load the layout JS, not sure it'll be worth the effort. @mart what do you think?

Wed, Apr 18, 9:17 AM · Plasma: KCM Redesign
broulik added a comment to T7325: Window Decorations.

How would one switch to the "Fine tuning" view? I mean, how to achieve that in Kirigami? Use a horizontally paginated thing, an overlay, a StackView, …?

Wed, Apr 18, 8:56 AM · Plasma: KCM Redesign
broulik added a comment to T7238: Lookandfeel (kinda done).

It's missing the destructive hint about the "use desktop layout from theme"

Wed, Apr 18, 7:44 AM · Plasma: KCM Redesign
broulik closed T7241: Splash Screen (kinda done) as Resolved.
Wed, Apr 18, 7:43 AM · Plasma: KCM Redesign

Tue, Apr 17

broulik added a comment to D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin.

This is master-only code, right? The upcoming Plasma 5.13 will depend on KF 5.46 so this should be fine.

Tue, Apr 17, 12:41 PM · Plasma
broulik added a comment to D12270: Create a public function to access the actionMenu.

This bug is 15 years old and no proof to this claim was provided.
Also, the wording as "subclasses can add" suggests a virtual method

Tue, Apr 17, 12:21 PM · Frameworks
broulik requested review of D12278: WIP: [Colors KCM] Port to new design.
Tue, Apr 17, 11:37 AM · Plasma
broulik claimed T7243: Colors.
Tue, Apr 17, 11:26 AM · Plasma: KCM Redesign
broulik requested review of D12273: [KCMControls GridDelegate] Show tooltip only if one is set.
Tue, Apr 17, 10:21 AM · Frameworks
broulik renamed T7239: Desktop Theme (done) from Desktop Theme (kinda done) to Desktop Theme (done).
Tue, Apr 17, 8:45 AM · Plasma: KCM Redesign
broulik committed R119:6ecb40efcd7e: [Desktop Theme KCM] Port to new design (authored by broulik).
[Desktop Theme KCM] Port to new design
Tue, Apr 17, 6:35 AM
broulik closed D12248: [Desktop Theme KCM] Port to new design.
Tue, Apr 17, 6:35 AM · Plasma

Mon, Apr 16

broulik updated the test plan for D12248: [Desktop Theme KCM] Port to new design.
Mon, Apr 16, 3:53 PM · Plasma
broulik requested review of D12248: [Desktop Theme KCM] Port to new design.
Mon, Apr 16, 3:52 PM · Plasma
broulik accepted D12148: update the wallpaper dialog to the new design.
Mon, Apr 16, 2:52 PM · Plasma
broulik added a comment to D12244: new resize policy.

Fine in principle but it doesn't enforce any minimum spacing

Mon, Apr 16, 2:47 PM · Frameworks
broulik committed R119:254c14469101: Merge branch 'Plasma/5.12' (authored by broulik).
Merge branch 'Plasma/5.12'
Mon, Apr 16, 2:42 PM
broulik committed R119:eaa5b4364f8b: [Window List] Show pin icon only when in panel (authored by broulik).
[Window List] Show pin icon only when in panel
Mon, Apr 16, 2:42 PM
broulik closed D12146: [Window List] Show pin icon only when in panel.
Mon, Apr 16, 2:42 PM · Plasma
broulik accepted D8626: DDCUtil: Improved DDCUtil support for brightness control.
Mon, Apr 16, 10:18 AM · Plasma
broulik added a comment to D8626: DDCUtil: Improved DDCUtil support for brightness control.

lgtm

Mon, Apr 16, 10:18 AM · Plasma
broulik added a comment to D12218: Remove Reload button from the file dialogs' toolbar.

Is it also accessible from the menu in the top right?

Mon, Apr 16, 8:05 AM · Frameworks
broulik committed R241:57b6b2d10131: [KFileWidget] Hardcode example user name (authored by broulik).
[KFileWidget] Hardcode example user name
Mon, Apr 16, 6:02 AM
broulik closed D11948: [KFileWidget] Hardcode example user name.
Mon, Apr 16, 6:02 AM · Frameworks
broulik committed R120:2082cfcbfa33: [Workspace Scripting] Turn "gridUnit" into a property getter function (authored by broulik).
[Workspace Scripting] Turn "gridUnit" into a property getter function
Mon, Apr 16, 5:50 AM
broulik closed D12173: [Workspace Scripting] Turn "gridUnit" into a property getter function.
Mon, Apr 16, 5:50 AM · Plasma

Fri, Apr 13

broulik requested review of D12173: [Workspace Scripting] Turn "gridUnit" into a property getter function.
Fri, Apr 13, 2:46 PM · Plasma
broulik added a comment to D12164: Add overloads to Value/Unit::toString/toSymbolString taking a QLocale.

+1 always annoyed me that the converter runner didn't use localed decimal points

Fri, Apr 13, 8:12 AM · Frameworks

Thu, Apr 12

broulik added a comment to D12148: update the wallpaper dialog to the new design.

Now I don't see any wallpapers in the list

GridDelegate.qml:63: ReferenceError: view is not defined

I did update kdeclarative and kirigami before

Thu, Apr 12, 7:51 PM · Plasma
broulik committed R119:c8080e5c95a8: [Kickoff] Support non-square icons (authored by broulik).
[Kickoff] Support non-square icons
Thu, Apr 12, 7:38 PM
broulik closed D12161: [Kickoff] Support non-square icons.
Thu, Apr 12, 7:38 PM · Plasma
broulik requested review of D12161: [Kickoff] Support non-square icons.
Thu, Apr 12, 7:22 PM · Plasma
broulik planned changes to D12067: [Okular Part] Add "Print" action.
Thu, Apr 12, 12:55 PM · Okular
broulik added a comment to D12067: [Okular Part] Add "Print" action.

Oh, I see. So Okular's Print action must go then. There is currently no way to print a PDF file from within Ark.

Thu, Apr 12, 12:55 PM · Okular
broulik accepted D12126: Invalidate property cache when an interface is removed.
Thu, Apr 12, 12:39 PM · Frameworks
broulik accepted D12124: Avoid creating duplicate property entries in the cache.

Wouldn't make a big difference, would it?

Thu, Apr 12, 12:39 PM · Frameworks
broulik requested review of D12146: [Window List] Show pin icon only when in panel.
Thu, Apr 12, 12:16 PM · Plasma
broulik added a comment to D12127: Do not query properties when no interfaces are left.

Lgtm.
But do we remove the offending properties when the interface is removed? Not sure, is probably unrelated bug

Thu, Apr 12, 10:51 AM · Frameworks
broulik accepted D12123: [UDisks] Optimize several property checks.
Thu, Apr 12, 10:12 AM · Frameworks
broulik added inline comments to D12125: Avoid inserting an invalid "Size" property from the Filesystem interface.
Thu, Apr 12, 10:05 AM · Frameworks

Wed, Apr 11

broulik accepted D11513: DBus runner servicename wildcard support.
Wed, Apr 11, 10:37 AM · Frameworks
broulik committed R120:4a541edfcd66: Merge branch 'Plasma/5.12' (authored by broulik).
Merge branch 'Plasma/5.12'
Wed, Apr 11, 10:19 AM
broulik committed R120:d78f80350eea: Merge branch 'Plasma/5.8' into Plasma/5.12 (authored by broulik).
Merge branch 'Plasma/5.8' into Plasma/5.12
Wed, Apr 11, 10:18 AM
broulik committed R120:d5a98be7b642: [OSD] Enforce plain text (authored by broulik).
[OSD] Enforce plain text
Wed, Apr 11, 10:15 AM
broulik closed D12086: [OSD] Enforce plain text.
Wed, Apr 11, 10:15 AM · Plasma
broulik added a comment to D12086: [OSD] Enforce plain text.

Worth changing, but not cve and urgent release worthy.

Wed, Apr 11, 10:15 AM · Plasma
broulik committed R120:ffa23acf440b: [Digital Clock] Allow copying current date and time to clipboard (authored by bschiffner).
[Digital Clock] Allow copying current date and time to clipboard
Wed, Apr 11, 8:28 AM
broulik closed D6183: [Digital Clock] Allow copying current date and time to clipboard.
Wed, Apr 11, 8:28 AM · Plasma
broulik accepted D11993: Tweak column widths in tree view of file open/save dialogs.

The only downside this has is that you can longer resize the column wider manually but then you might as well resize the window and actually see more :)

Wed, Apr 11, 6:08 AM · Frameworks
broulik added a comment to D12086: [OSD] Enforce plain text.

where do we put third party data in an OSDItem

Wed, Apr 11, 5:58 AM · Plasma

Tue, Apr 10

broulik requested review of D12086: [OSD] Enforce plain text.
Tue, Apr 10, 1:40 PM · Plasma
broulik added a comment to T8420: Suspend to disk offered.

the session is defunct after resume

Tue, Apr 10, 1:05 PM · KDE Neon : bionic
broulik committed R120:d34a9e23eddd: [Image Wallpaper] Fix blur (authored by broulik).
[Image Wallpaper] Fix blur
Tue, Apr 10, 12:47 PM
broulik closed D11981: [Image Wallpaper] Fix blur.
Tue, Apr 10, 12:47 PM · Plasma
broulik committed R115:893ee005b120: Show OSD when default output changes (authored by broulik).
Show OSD when default output changes
Tue, Apr 10, 12:35 PM
broulik closed D12083: Show OSD when default output changes.
Tue, Apr 10, 12:35 PM · Plasma
broulik added a comment to D11948: [KFileWidget] Hardcode example user name.

Ping, if no one objects I'll push this once next FW is released

Tue, Apr 10, 12:27 PM · Frameworks
broulik updated the diff for D12083: Show OSD when default output changes.
  • Use default sink instead of preferred sink as the latter also changes depending on where music is being played
Tue, Apr 10, 12:21 PM · Plasma
broulik updated the test plan for D12083: Show OSD when default output changes.
Tue, Apr 10, 10:53 AM · Plasma
broulik requested review of D12083: Show OSD when default output changes.
Tue, Apr 10, 10:38 AM · Plasma
broulik added a comment to D12077: Show view mode buttons in the open/save dialog's toolbar.

Can we arrange them so that they're more consistent with Dolphin? i.e. put the Preview button at right-most

Tue, Apr 10, 7:38 AM · Frameworks

Mon, Apr 9

broulik requested changes to D12072: use ConstrainedSquare as formFactor.

This doesn't work.

  • `Containment::restore(KConfigGroup&)` overwrites it with the form factor stored in config
  • `SystemTrayContainer``` also overwrites it depending on the container's form factor
Mon, Apr 9, 5:09 PM · Plasma
broulik added inline comments to D12069: Implement a keyboard selector plasmoid.
Mon, Apr 9, 3:04 PM · Plasma
broulik planned changes to D11955: [Folder View] Set Refresh shortcut on Refresh/Reload.

I just noticed that setUsedByContainment actually renames the "reload" action to "Refresh desktop", so "refresh" is essentially useless.
Will refactor this to get rid of the dedicated "Refresh" action and just use "Reload" everywhere (with appropriate name as is currently done in the code already)

Mon, Apr 9, 2:26 PM · Plasma
broulik requested review of D12067: [Okular Part] Add "Print" action.
Mon, Apr 9, 1:47 PM · Okular
broulik committed R111:705dc856db88: Merge branch 'Plasma/5.12' (authored by broulik).
Merge branch 'Plasma/5.12'
Mon, Apr 9, 9:57 AM
broulik committed R111:e3ea3c840d6f: [ProcessModel] Return invalid QVariant() for when window is not known (authored by broulik).
[ProcessModel] Return invalid QVariant() for when window is not known
Mon, Apr 9, 9:57 AM
broulik closed D12000: [ProcessModel] Return invalid QVariant() for when window is not known.
Mon, Apr 9, 9:57 AM · Plasma

Sun, Apr 8

broulik accepted D6183: [Digital Clock] Allow copying current date and time to clipboard.

Let's go for it now! Thanks for patience and apologies it took so long :/
Do you have commit access? else I need your email address and can push it on your behalf.

Sun, Apr 8, 8:46 PM · Plasma
broulik added a comment to D12050: Make automounting work even if StorageAccess is ignored.

I did the KF5 port but I don't recall doing that or why it would be there, so +1 from me if it fixes that. I don't use automounter so I don't know

Sun, Apr 8, 8:40 PM · Plasma

Fri, Apr 6

broulik requested review of D12000: [ProcessModel] Return invalid QVariant() for when window is not known.
Fri, Apr 6, 9:48 PM · Plasma
broulik added a comment to D11993: Tweak column widths in tree view of file open/save dialogs.

Thanks for updating! I think this patch makes sense (and seems to work well) but I'm not too familiar with QTreeView, let's wait a bit for further feedback and merge it once Frameworks 5.45 has been tagged.

Fri, Apr 6, 8:12 PM · Frameworks
broulik added inline comments to D11993: Tweak column widths in tree view of file open/save dialogs.
Fri, Apr 6, 8:03 PM · Frameworks
broulik updated the diff for D11989: [Notifications] Always scroll to the top when opening.
  • Also use positionViewAtBeginning as contentY alone doesn't really work with the way ListView works
Fri, Apr 6, 3:44 PM · Plasma
broulik requested review of D11989: [Notifications] Always scroll to the top when opening.
Fri, Apr 6, 3:39 PM · Plasma