broulik (Kai Uwe Broulik)
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Dec 14 2015, 3:47 PM (156 w, 2 d)
Availability
Available

Recent Activity

Today

broulik accepted D17173: Add error value for job owner dying.
Wed, Dec 12, 3:55 PM · Frameworks
broulik added a reviewer for D17173: Add error value for job owner dying: dfaure.
Wed, Dec 12, 3:31 PM · Frameworks
broulik added a comment to D17173: Add error value for job owner dying.

Now that ERR_FILE_TOO_LARGE_FOR_FAT32 is in you can rebase this

Wed, Dec 12, 3:31 PM · Frameworks
broulik added a comment to D17545: Do not stat move/copy job if the destination file system does not support writing.

The bug report is about checking whether it's writable, you're checking the protocol here, and file will always "support writing". This patch could still make sense, though.

Wed, Dec 12, 3:25 PM · Frameworks
broulik committed R120:93bd4cdbddcd: Merge branch 'Plasma/5.14' (authored by broulik).
Merge branch 'Plasma/5.14'
Wed, Dec 12, 3:04 PM
broulik committed R120:fb918b6440ce: Don't exec() hint about deactivating URL grabber (authored by broulik).
Don't exec() hint about deactivating URL grabber
Wed, Dec 12, 3:04 PM
broulik closed D17531: Don't exec() hint about deactivating URL grabber.
Wed, Dec 12, 3:04 PM · Plasma
broulik accepted D17505: Add preferences-system-bluetooth-battery to preferences.svgz.

Thanks!

Wed, Dec 12, 2:50 PM · Frameworks
broulik requested review of D17543: [Dialog] Don't alter mainItem's visibility.
Wed, Dec 12, 2:44 PM · Frameworks
broulik requested review of D17542: Reset parentItem when mainItem changes.
Wed, Dec 12, 2:31 PM · Frameworks
broulik added a comment to D17532: Show tooltip for pinning system tray and calendar.

Keep instead of Leave?

Wed, Dec 12, 11:05 AM · Plasma
broulik requested review of D17531: Don't exec() hint about deactivating URL grabber.
Wed, Dec 12, 10:03 AM · Plasma
broulik requested review of D17527: [Chrome Bookmark Runner] Use QJsonObject directly.
Wed, Dec 12, 9:20 AM · Plasma
broulik added a comment to D17518: Adapt favicon test to www.kde.org changes.

I also thought the favicon was too large for FavIconJob to download

Wed, Dec 12, 7:49 AM · Frameworks

Yesterday

broulik requested changes to D17505: Add preferences-system-bluetooth-battery to preferences.svgz.

The stylesheet stuff doesn't work, ie. the icon stays black in Breeze dark.
Also, should it maybe have a "bolt" or something next to it as that's what we normally have for the batteries (optional)

Tue, Dec 11, 2:21 PM · Frameworks
broulik requested changes to D17482: Upload new screenshots in the documentation and uncomment a section.
Tue, Dec 11, 1:21 PM · Documentation, Plasma
broulik reopened D17482: Upload new screenshots in the documentation and uncomment a section.

Breaks build of plasma-desktoop:

index.docbook:104: parser error : Opening and ending tag mismatch: variablelist line 53 and article
</article>
          ^
index.docbook:118: parser error : Premature end of data in tag article line 7
Tue, Dec 11, 1:21 PM · Documentation, Plasma
broulik added a comment to D17346: Support Bluetooth batteries.

No. Can we not digress from this, I just need an icon...

Tue, Dec 11, 11:35 AM · Plasma
broulik added a comment to D17493: [WIP] Implementation of an Easy Mode in KCM fonts module.

Is there another way to mark this as "not ready"?

Tue, Dec 11, 11:32 AM · Plasma

Mon, Dec 10

broulik added a reviewer for D17479: Fix build without phonon: sitter.
Mon, Dec 10, 3:24 PM · Frameworks
broulik accepted D17480: Fix warnings.
Mon, Dec 10, 3:23 PM · Plasma
broulik added a comment to D17458: Add help button to KCMs where it was missing.

Then why was launch wrong?

Mon, Dec 10, 1:26 PM · Plasma
broulik added a comment to D17346: Support Bluetooth batteries.

Does it have to be in the Plasma theme?

Mon, Dec 10, 12:56 PM · Plasma
broulik committed R133:3a861da21fbf: Merge branch 'Plasma/5.14' (authored by broulik).
Merge branch 'Plasma/5.14'
Mon, Dec 10, 10:15 AM
broulik committed R133:30f0dc0d5a3a: Merge branch 'Plasma/5.12' into Plasma/5.14 (authored by broulik).
Merge branch 'Plasma/5.12' into Plasma/5.14
Mon, Dec 10, 10:15 AM
broulik committed R133:e1d676c46e50: Force software rendering when greeter crashed (authored by broulik).
Force software rendering when greeter crashed
Mon, Dec 10, 10:14 AM
broulik added a comment to D17458: Add help button to KCMs where it was missing.

You beat me to it :( I think one can just remove the buttons meddling, the default is Help | Defaults | Apply as far as I can tell.

Mon, Dec 10, 8:52 AM · Plasma
broulik added inline comments to D17467: digital-clock: Show events on initial expansion for all time zones.
Mon, Dec 10, 8:48 AM · Plasma

Sat, Dec 8

broulik added a comment to D17438: [folder] Initialise LabelGenerator::m_labelMode.

Do you have 98d38f9ffb607cebe439a5a8f9ed8e464db417c0?

Sat, Dec 8, 8:36 PM · Plasma
broulik added a comment to D17440: Rotate busy indicator clockwise.

Did we ever have a busy indicator that rotated counter-clockwise? +1

Sat, Dec 8, 8:35 PM · VDG, Breeze, Plasma

Fri, Dec 7

broulik committed R824:3695e0b0dc81: Initialize m_metaData (authored by broulik).
Initialize m_metaData
Fri, Dec 7, 1:49 PM
broulik closed D17348: Initialize m_metaData.
Fri, Dec 7, 1:48 PM · Baloo
broulik added a comment to D17402: [Device Notifier] Disable the possibility to unmount the root partition.

I'm not very happy with all this root and home special casing all over the place (e.g. Places panel now also has something like this, etc)

Fri, Dec 7, 12:54 PM · Plasma
broulik accepted D16299: fallback to dnssd service discovery if smb listDir failed on root.
Fri, Dec 7, 12:53 PM · Frameworks, Dolphin
broulik added a comment to D17383: Don't use kcmshell5 for opening the KCM.

I think this is fine as a temporary solution but we should look into fixing kcmshell dependencies. It uses KWorkspace lib from plasma-workspace for determining the Qt platform to use. And that ends up pulling in everything and the kitchen sink :/

Fri, Dec 7, 11:48 AM · KDE Connect
broulik added a comment to D17394: [Device Notifier] Fix transition animation.

Is this Bug 379759?

Fri, Dec 7, 11:37 AM · Plasma

Wed, Dec 5

broulik accepted D17365: Round label width.

Cool! Stable branch pls

Wed, Dec 5, 9:53 AM · Plasma
broulik added inline comments to D17365: Round label width.
Wed, Dec 5, 9:48 AM · Plasma

Tue, Dec 4

broulik updated the summary of D17348: Initialize m_metaData.
Tue, Dec 4, 4:05 PM · Baloo
broulik requested review of D17348: Initialize m_metaData.
Tue, Dec 4, 4:05 PM · Baloo
broulik added a comment to D17347: Translate color scheme names.

making strings translatable does not break the string freeze

Tue, Dec 4, 3:57 PM · Plasma
broulik committed R119:4087961586e4: Translate color scheme names (authored by broulik).
Translate color scheme names
Tue, Dec 4, 3:52 PM
broulik closed D17347: Translate color scheme names.
Tue, Dec 4, 3:52 PM · Plasma
broulik committed R31:da5fbe7f18ff: Translate color scheme names (authored by broulik).
Translate color scheme names
Tue, Dec 4, 3:47 PM
broulik committed R245:b983836f05cd: Support Bluetooth batteries (authored by broulik).
Support Bluetooth batteries
Tue, Dec 4, 3:28 PM
broulik closed D17345: Support Bluetooth batteries.
Tue, Dec 4, 3:28 PM · Frameworks
broulik updated the test plan for D17347: Translate color scheme names.
Tue, Dec 4, 3:25 PM · Plasma
broulik requested review of D17347: Translate color scheme names.
Tue, Dec 4, 3:25 PM · Plasma
broulik added a dependent revision for D17345: Support Bluetooth batteries: D17346: Support Bluetooth batteries.
Tue, Dec 4, 2:31 PM · Frameworks
broulik requested review of D17346: Support Bluetooth batteries.
Tue, Dec 4, 2:31 PM · Plasma
broulik added a reviewer for D17345: Support Bluetooth batteries: bshah.
Tue, Dec 4, 2:22 PM · Frameworks
broulik requested review of D17345: Support Bluetooth batteries.
Tue, Dec 4, 2:22 PM · Frameworks
broulik accepted D17213: Add support for settings portal.
Tue, Dec 4, 10:57 AM · Plasma

Mon, Dec 3

broulik committed R856:cf6d43ac6054: Install message handler after QApplication (authored by broulik).
Install message handler after QApplication
Mon, Dec 3, 4:40 PM
broulik closed D17335: Install message handler after QApplication.
Mon, Dec 3, 4:40 PM · Plasma
broulik requested review of D17335: Install message handler after QApplication.
Mon, Dec 3, 4:06 PM · Plasma
broulik committed R856:ee0070a6bd03: Make media session property setter more resilient (authored by broulik).
Make media session property setter more resilient
Mon, Dec 3, 8:37 AM
broulik closed D17326: Make media session property setter more resilient.
Mon, Dec 3, 8:37 AM · Plasma
broulik added a comment to D17326: Make media session property setter more resilient.

Yes, but in there it calls data.value for multiple keys without checking anything

Because it doesn't need to. It makes no difference whether the object is empty or has only one of the keys I read.

Mon, Dec 3, 8:33 AM · Plasma
broulik added a comment to D17326: Make media session property setter more resilient.

It can, processMetadata(data.value(QStringLiteral("metadata")).toObject()); turns it into an empty object when null (or anything but an Object)

Mon, Dec 3, 8:29 AM · Plasma
broulik requested review of D17326: Make media session property setter more resilient.
Mon, Dec 3, 8:10 AM · Plasma

Sat, Dec 1

broulik committed R856:e647708f9f01: Merge branch 'Plasma/5.14' (authored by broulik).
Merge branch 'Plasma/5.14'
Sat, Dec 1, 11:51 AM
broulik committed R856:90400518efcd: Only cancel job when an "error" is set and ignore "interrupted" (authored by broulik).
Only cancel job when an "error" is set and ignore "interrupted"
Sat, Dec 1, 11:50 AM
broulik closed D17233: Only cancel job when an "error" is set and ignore "interrupted".
Sat, Dec 1, 11:50 AM · Plasma

Fri, Nov 30

broulik added inline comments to D17260: Port some core Q_PRIVATE_SLOTS to new connect syntax.
Fri, Nov 30, 3:30 PM · Frameworks
broulik committed R229:1ae00e8667cb: Set window icon with --icon argument (authored by broulik).
Set window icon with --icon argument
Fri, Nov 30, 1:08 PM
broulik closed D17208: Set window icon with --icon argument.
Fri, Nov 30, 1:08 PM
broulik updated the diff for D17233: Only cancel job when an "error" is set and ignore "interrupted".
Fri, Nov 30, 9:02 AM · Plasma
broulik added a comment to D17248: Add Rectangular Region mode on wayland [RFC].

An application cannot position itself on Wayland. What instead should be done is implement a region selector in KWin's screenshot interface that returns a cropped pixmap.
There is currently a window and color picker in KWin but no region selector.

Fri, Nov 30, 8:04 AM · Spectacle

Thu, Nov 29

broulik committed R241:a9592e0b69c9: Explicitly create QDateTime with UTC time (authored by broulik).
Explicitly create QDateTime with UTC time
Thu, Nov 29, 4:41 PM
broulik closed D17238: Explicitly create QDateTime with UTC time.
Thu, Nov 29, 4:41 PM · Frameworks
broulik requested review of D17238: Explicitly create QDateTime with UTC time.
Thu, Nov 29, 4:17 PM · Frameworks
broulik updated the diff for D17233: Only cancel job when an "error" is set and ignore "interrupted".
  • Set no error explicitly when completing, just in case
Thu, Nov 29, 2:31 PM · Plasma
broulik added inline comments to D17216: Move the about page from Discover to Kirigami.
Thu, Nov 29, 12:11 PM · Kirigami
broulik updated the diff for D17233: Only cancel job when an "error" is set and ignore "interrupted".
  • Update comment, originally had singleShot(0 but that wasn't enough
Thu, Nov 29, 11:16 AM · Plasma
broulik requested review of D17233: Only cancel job when an "error" is set and ignore "interrupted".
Thu, Nov 29, 11:15 AM · Plasma
broulik added a comment to D17213: Add support for settings portal.

Good stuff!

Thu, Nov 29, 8:20 AM · Plasma
broulik committed R121:a13b84e326e1: Use KPasswordLineEdit (authored by broulik).
Use KPasswordLineEdit
Thu, Nov 29, 8:14 AM
broulik closed D17207: Use KPasswordLineEdit.
Thu, Nov 29, 8:14 AM · Plasma

Wed, Nov 28

broulik accepted D17219: Fix group popup dialog.
Wed, Nov 28, 3:25 PM · Plasma
broulik added a reviewer for D17167: Provide a method of assigning custom default icons for non-XDG dirs: dfaure.
Wed, Nov 28, 3:18 PM · Frameworks
broulik added a comment to D16425: Added new Suspend then Hibernate option.

I think that's because we're iterating m_cookieToBusService in that method and at the same time have ReleaseInhibition tamper with it. Perhaps taking a copy should fix that already:

void PolicyAgent::onServiceUnregistered(const QString& serviceName)
{
    // Ouch - the application quit or crashed without releasing its inhibitions. Let's fix that.
    const auto cookieToBusService = m_cookieToBusService;
    for (auto it = cookieToBusService.constBegin(); it != cookieToBusService.constEnd(); ++it) {
        if (it.value() == serviceName) {
            ReleaseInhibition(it.key());
        }
    }
    m_cookieToBusService.clear();
}
Wed, Nov 28, 3:05 PM · Plasma
broulik added inline comments to D17216: Move the about page from Discover to Kirigami.
Wed, Nov 28, 2:53 PM · Kirigami
broulik added a comment to D17211: Port applet/containment configs to qqc2.

+1

Wed, Nov 28, 1:39 PM · Plasma
broulik added a comment to D17211: Port applet/containment configs to qqc2.

Quirks I have found:

  • The "Filters" page in Folder View configuration doesn't get a size initially and only does when I resize the window
  • The transition animation is buggy, the "enterItem" isn't properly animated from what I can tell, just pops up right away with the old KCM moving away
  • The "Positioning" combobox for the wallpaper disappears when FormLayout is narrow and starts laying out items below eath other

Otherwise pretty good

Wed, Nov 28, 11:34 AM · Plasma
broulik added a comment to D17177: Drop tab-based UI for the about page.

Wouldn't it make sense to provide an AboutPage in Kirigami (KF5::kirigami-whatever-that-can-be-tier-2 :D) like kxmlgui has it, for use in e.g. Itinerary and what not?

Wed, Nov 28, 10:47 AM · Plasma
broulik requested review of D17208: Set window icon with --icon argument.
Wed, Nov 28, 9:19 AM
broulik accepted D17206: Rename NotifyByFlatpak to NotifyByPortal.
Wed, Nov 28, 8:44 AM · Frameworks
broulik requested review of D17207: Use KPasswordLineEdit.
Wed, Nov 28, 8:30 AM · Plasma
broulik committed R228:e7d011c9aa67: Merge branch 'Applications/18.12' (authored by broulik).
Merge branch 'Applications/18.12'
Wed, Nov 28, 8:26 AM

Tue, Nov 27

broulik added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

"Include mouse pointer" setting now blends the cursor into the screenshot right away, letting the user see it while cropping, rather than blending it in after cropping

Tue, Nov 27, 7:59 PM · Spectacle
broulik added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

Thanks a lot! It seems to be working well and starting a lot quicker than the QML based one, good job!
I have a bunch of minor coding style nitpicks but nothing serious.
In any case you might want to look at the code KSnapshot used for some further inspiration [1].
Also, the current editor has a magnifier that shows up when you hit Shift while drawing a selection that was probably added after you started working on this. Any chance you could implement this as well?

Tue, Nov 27, 7:56 PM · Spectacle
broulik added a comment to D17189: [useractions] Use checkable actions in the multiple desktops popup.

Also see Bug 401437

Tue, Nov 27, 4:31 PM · KWin
broulik added a comment to D17189: [useractions] Use checkable actions in the multiple desktops popup.

Wasn't that done on purpose so the menu stays open when you interact with any of the checkboxes? The same applies also to the "Move to Activities" menu. Given we don't have that anywhere else, might be sensible to just use a regular menu entry instead.

Tue, Nov 27, 3:59 PM · KWin
broulik added a comment to D17188: Notification portal: support pixmaps in notifications.

+1

Tue, Nov 27, 3:13 PM · Frameworks
broulik added a comment to D17187: Set the default cursor theme to breeze_cursors.

+1

Tue, Nov 27, 2:51 PM · Plasma
broulik added a comment to D17184: Explicitly import Qt 5.7's QtQuick for Connections.enabled.

Qt 5.12 seems to be somewhat stricter with that, only started happening there.

Tue, Nov 27, 1:59 PM · KDE PIM
broulik accepted D17184: Explicitly import Qt 5.7's QtQuick for Connections.enabled.

Had to do the same in various other places, e.g. f328668559cc56a8a32f52932873554af8b4f5da

Tue, Nov 27, 1:38 PM · KDE PIM
broulik committed R115:d25f35d00b37: Merge branch 'Plasma/5.14' (authored by broulik).
Merge branch 'Plasma/5.14'
Tue, Nov 27, 8:52 AM
broulik committed R856:51fd56b00819: Bump manifest version (authored by broulik).
Bump manifest version
Tue, Nov 27, 7:57 AM