broulik (Kai Uwe Broulik)
User

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Dec 14 2015, 3:47 PM (96 w, 1 d)
Availability
Available

Recent Activity

Yesterday

broulik committed R119:41ba081db1a3: Merge branch 'Plasma/5.11' (authored by broulik).
Merge branch 'Plasma/5.11'
Mon, Oct 16, 12:42 PM
broulik committed R119:a1a85f95bb48: [Task Manager] Understand applications: URLs in Unity launchers (authored by broulik).
[Task Manager] Understand applications: URLs in Unity launchers
Mon, Oct 16, 12:42 PM
broulik closed D8327: [Task Manager] Understand applications: URLs in Unity launchers.
Mon, Oct 16, 12:41 PM · Plasma
broulik added inline comments to D8327: [Task Manager] Understand applications: URLs in Unity launchers.
Mon, Oct 16, 10:11 AM · Plasma
broulik added inline comments to D8327: [Task Manager] Understand applications: URLs in Unity launchers.
Mon, Oct 16, 10:06 AM · Plasma
broulik committed R242:dea8a1ed5f2f: [FrameSvg] Optimize updateSizes (authored by broulik).
[FrameSvg] Optimize updateSizes
Mon, Oct 16, 9:40 AM
broulik closed D8135: [FrameSvg] Optimize updateSizes.
Mon, Oct 16, 9:39 AM · Frameworks, Plasma
broulik created D8327: [Task Manager] Understand applications: URLs in Unity launchers.
Mon, Oct 16, 9:02 AM · Plasma
broulik committed R120:27014d12b9a8: Merge branch 'Plasma/5.11' (authored by broulik).
Merge branch 'Plasma/5.11'
Mon, Oct 16, 8:48 AM
broulik committed R120:5fee12f8bee6: [LauncherTasksModel] Try resolving absolute path to applications: URL before… (authored by broulik).
[LauncherTasksModel] Try resolving absolute path to applications: URL before…
Mon, Oct 16, 8:48 AM
broulik committed R120:88dbb40ddede: [Task Tools] Treat applications: and respective absolute path equal in… (authored by broulik).
[Task Tools] Treat applications: and respective absolute path equal in…
Mon, Oct 16, 8:48 AM
broulik closed D8260: [LauncherTasksModel] Try resolving absolute path to applications: URL before adding launcher.
Mon, Oct 16, 8:48 AM · Plasma
broulik closed D8258: [Task Tools] Treat applications: and respective absolute path equal in launcherUrlsMatch.
Mon, Oct 16, 8:48 AM · Plasma
broulik committed R120:9a257ab60b91: [StartupTasksModel] Try resolving startup application id to applications: URL (authored by broulik).
[StartupTasksModel] Try resolving startup application id to applications: URL
Mon, Oct 16, 8:48 AM
broulik closed D8257: [StartupTasksModel] Try resolving startup application id to applications: URL.
Mon, Oct 16, 8:47 AM · Plasma

Sun, Oct 15

broulik added a comment to D8318: KRunner: fix runtime warning when a runner links to QtWebEngine.

Can't we fix the root-cause you mentioned? I still have memories of Akonadi runner trying to *initialize* Qt Web Engine and that blowing up miserably.

Sun, Oct 15, 9:13 PM · Plasma
broulik added a comment to D8208: Add Duplicate feature.

I actually find myself quite often using Ctrl+C and then Ctrl+V, I would like a "duplicate" option.

Sun, Oct 15, 8:19 PM · Dolphin
broulik added a comment to D8306: Fix padding of "Fit Width" button.

Yeah, we'd rather do one review "too much" than one too little ;)

Sun, Oct 15, 12:48 PM
broulik accepted D8306: Fix padding of "Fit Width" button.

This has annoyed me for quite some time :) I think the ability to *read* the buttons is more important than a unified width.

Sun, Oct 15, 12:37 PM
broulik accepted D8309: Modernize: Use nullptr where possible.
Sun, Oct 15, 12:31 PM · Plasma

Sat, Oct 14

broulik added a comment to D8296: Use Alt+, as the standard shortcut for "Configure <Program>".

However I fear this might cause "shortcut xyz is ambiguous" messages after update for some users :/

Sat, Oct 14, 2:49 PM · Frameworks

Fri, Oct 13

broulik added a comment to D8277: Background color for sidebar headers.

Me too.

Fri, Oct 13, 5:13 PM · Plasma
broulik added inline comments to D8258: [Task Tools] Treat applications: and respective absolute path equal in launcherUrlsMatch.
Fri, Oct 13, 10:45 AM · Plasma

Thu, Oct 12

broulik accepted D8252: Make calendar pin persistent across sessions.
Thu, Oct 12, 1:52 PM · Plasma
broulik added inline comments to D8252: Make calendar pin persistent across sessions.
Thu, Oct 12, 1:20 PM · Plasma
broulik accepted D8261: Change kcm header "Screen Locking Timeouts" to "Configure Screen Locking".
Thu, Oct 12, 11:25 AM · Plasma
broulik created D8260: [LauncherTasksModel] Try resolving absolute path to applications: URL before adding launcher.
Thu, Oct 12, 9:14 AM · Plasma
broulik updated the diff for D8258: [Task Tools] Treat applications: and respective absolute path equal in launcherUrlsMatch.
  • Use same approach as appDataFromUrl (ie. KDesktopFile::isDesktopFile and then KDesktopFile fileName
Thu, Oct 12, 9:12 AM · Plasma
broulik updated the test plan for D8258: [Task Tools] Treat applications: and respective absolute path equal in launcherUrlsMatch.
Thu, Oct 12, 9:12 AM · Plasma
broulik created D8258: [Task Tools] Treat applications: and respective absolute path equal in launcherUrlsMatch.
Thu, Oct 12, 9:12 AM · Plasma
broulik updated the test plan for D8257: [StartupTasksModel] Try resolving startup application id to applications: URL.
Thu, Oct 12, 9:12 AM · Plasma
broulik created D8257: [StartupTasksModel] Try resolving startup application id to applications: URL.
Thu, Oct 12, 9:11 AM · Plasma

Wed, Oct 11

broulik added a comment to D8252: Make calendar pin persistent across sessions.

Should we do the same for System Tray? I don't think anybody would do this but it should be consistent

Wed, Oct 11, 6:10 PM · Plasma
broulik committed R120:f36591699cb9: Merge branch 'Plasma/5.11' (authored by broulik).
Merge branch 'Plasma/5.11'
Wed, Oct 11, 2:08 PM
broulik committed R120:ac40f7dec47d: Revert "Remove pointless data copy in lockscreen delegate" (authored by broulik).
Revert "Remove pointless data copy in lockscreen delegate"
Wed, Oct 11, 2:06 PM
broulik added a reverting commit for R120:cc8647481095: Remove pointless data copy in lockscreen delegate: R120:ac40f7dec47d: Revert "Remove pointless data copy in lockscreen delegate".
Wed, Oct 11, 2:06 PM

Tue, Oct 10

broulik added inline comments to D8234: Fix system settings binding loop.
Tue, Oct 10, 12:16 PM · Plasma

Sun, Oct 8

broulik accepted D8210: Use KWindowSystem's own platform detection API instead of duplicated code.
Sun, Oct 8, 8:24 PM · Frameworks

Fri, Oct 6

broulik added inline comments to D8159: Add API for setting server decoration palettes.
Fri, Oct 6, 2:28 PM · Frameworks, Plasma on Wayland
broulik added a comment to D8159: Add API for setting server decoration palettes.

This is getting deprecated

yay...

Fri, Oct 6, 12:05 PM · Frameworks, Plasma on Wayland

Wed, Oct 4

broulik added a comment to D8077: Fix org.kde.plasma.calendar with Qt 5.10.

Despite just having built p-f from git I still get

Error loading QML file: file:///usr/share/plasma/plasmoids/org.kde.plasma.fuzzyclock/contents/ui/main.qml:51:34: Type PlasmaCalendar.MonthView unavailable
file:///usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/calendar/MonthView.qml:222:22: DaysCalendar is not a type

Do I need a newer Qt 5.10 snapshot for this?

Wed, Oct 4, 9:36 PM · Frameworks, Plasma
broulik created D8135: [FrameSvg] Optimize updateSizes.
Wed, Oct 4, 10:07 AM · Frameworks, Plasma

Sun, Oct 1

broulik accepted D8077: Fix org.kde.plasma.calendar with Qt 5.10.

I suspect there are other modules affected as well?

Sun, Oct 1, 8:33 PM · Frameworks, Plasma
broulik added inline comments to D8060: allow to set a custom palette instead of colorSets.
Sun, Oct 1, 9:13 AM · Frameworks
broulik accepted D8082: Also send Wayland clients to a new desktop if their desktop was removed.
Sun, Oct 1, 9:09 AM · KWin

Fri, Sep 29

broulik committed R242:c1e432065ffc: sceneGraphBackend() is new in Qt 5.9 (authored by broulik).
sceneGraphBackend() is new in Qt 5.9
Fri, Sep 29, 8:49 AM

Thu, Sep 28

broulik committed R242:bb6b17051673: [FrameSvgItem] Iterate child nodes properly (authored by broulik).
[FrameSvgItem] Iterate child nodes properly
Thu, Sep 28, 9:06 PM
broulik closed D8046: [FrameSvgItem] Iterate child nodes properly.
Thu, Sep 28, 9:06 PM · Frameworks, Plasma
broulik created D8046: [FrameSvgItem] Iterate child nodes properly.
Thu, Sep 28, 8:46 PM · Frameworks, Plasma
broulik accepted D8031: Fix icon colors of inline context buttons also in full screen mode.

Lovely :)

Thu, Sep 28, 5:55 PM
broulik added a comment to D8031: Fix icon colors of inline context buttons also in full screen mode.

Will using QIcon::fromTheme instead of SmallIcon (which returns a QPixmap not a QIcon) help here? QIcon also stores the name of the icon.

Thu, Sep 28, 1:50 PM
broulik committed R242:cab8fd916079: [Containment Interface] Don't add containment actions to applet actions on… (authored by broulik).
[Containment Interface] Don't add containment actions to applet actions on…
Thu, Sep 28, 12:12 PM
broulik closed D8009: [Containment Interface] Don't add containment actions to applet actions on desktop.
Thu, Sep 28, 12:11 PM · Frameworks, Plasma
broulik created D8026: [Activity KCM] Disallow adding/removing activity when restricted.
Thu, Sep 28, 11:52 AM · Plasma
broulik added a comment to D8021: Don't switch Location Bar mode with Escape key.

If it were done that way, I could agree to the patch.

Thu, Sep 28, 9:46 AM · Frameworks
broulik added a comment to D8021: Don't switch Location Bar mode with Escape key.

The question is: why? I find Escape a natural way to exit editing and never used Ctrl+L. I don't fully understand the bug report. If Ctrl+L should only switch to edit mode, how would you exit again if you remove Escape handling?

Thu, Sep 28, 8:29 AM · Frameworks
broulik committed R119:8abee08b0e81: [Folder View] Turn MenuHelper into a singleton type (authored by broulik).
[Folder View] Turn MenuHelper into a singleton type
Thu, Sep 28, 8:24 AM
broulik closed D8008: [Folder View] Turn MenuHelper into a singleton type.
Thu, Sep 28, 8:23 AM · Plasma
broulik committed R108:a7c396caeb29: [ScreenEdgeEffect] Create glow Svg on demand (authored by broulik).
[ScreenEdgeEffect] Create glow Svg on demand
Thu, Sep 28, 8:20 AM
broulik closed D8011: [ScreenEdgeEffect] Create glow Svg on demand.
Thu, Sep 28, 8:19 AM · KWin

Wed, Sep 27

broulik accepted D8013: Fix FrameSVGItem with the software renderer.
Wed, Sep 27, 2:46 PM · Frameworks, Plasma
broulik accepted D8014: Don't animate IconItem in software mode.
Wed, Sep 27, 2:46 PM · Frameworks, Plasma
broulik accepted D8012: Only assert on broken GL when we're rendering using GL.
Wed, Sep 27, 2:38 PM · Plasma
broulik created D8011: [ScreenEdgeEffect] Create glow Svg on demand.
Wed, Sep 27, 2:28 PM · KWin
broulik committed R120:e79bf9e1949f: static_cast QPlatformSurfaceEvent instead of dynamic_cast (authored by broulik).
static_cast QPlatformSurfaceEvent instead of dynamic_cast
Wed, Sep 27, 1:59 PM
broulik closed D8005: static_cast QPlatformSurfaceEvent instead of dynamic_cast.
Wed, Sep 27, 1:59 PM · Plasma
broulik created D8009: [Containment Interface] Don't add containment actions to applet actions on desktop.
Wed, Sep 27, 1:27 PM · Frameworks, Plasma
broulik updated the diff for D8005: static_cast QPlatformSurfaceEvent instead of dynamic_cast.

Drop if check

Wed, Sep 27, 1:11 PM · Plasma
broulik created D8008: [Folder View] Turn MenuHelper into a singleton type.
Wed, Sep 27, 12:38 PM · Plasma
broulik committed R260:c281bf829764: Apply full screen color scheme also to window decoration (authored by broulik).
Apply full screen color scheme also to window decoration
Wed, Sep 27, 11:12 AM
broulik closed D7994: Apply full screen color scheme also to window decoration.
Wed, Sep 27, 11:12 AM
broulik created D8005: static_cast QPlatformSurfaceEvent instead of dynamic_cast.
Wed, Sep 27, 10:19 AM · Plasma
broulik accepted D5032: drop examples dir.
Wed, Sep 27, 8:42 AM · Frameworks

Tue, Sep 26

broulik accepted D7997: [tabbox] Create X11Filter on establishKeyboardGrab.

On X verified that Meta now opens Kickoff again and that Alt+Tab and Alt+Backtab and Mousewheel and selecting windows whilst in tabbox still work.

Tue, Sep 26, 7:02 PM · KWin
broulik updated the diff for D7994: Apply full screen color scheme also to window decoration.
  • Set property before changing palette so it also applies it to the main window
Tue, Sep 26, 1:52 PM
broulik created D7994: Apply full screen color scheme also to window decoration.
Tue, Sep 26, 1:39 PM
broulik updated subscribers of D7988: Use standard QToolButtons so that their icons use the right colors.

@mart Is there a way to tamper into KIconLoader's coloring, so we can override the color palette used for icons in this case?

Tue, Sep 26, 8:41 AM

Mon, Sep 25

broulik accepted D7965: Drop the ObscurringWindow functionality on desktop switching.
Mon, Sep 25, 2:04 PM · KWin
broulik accepted D7853: Add a dedicated X11EventFilter for forwarding property events to the effect system.
Mon, Sep 25, 2:03 PM · KWin
broulik accepted D7924: Support starting kwin_wayland without XWayland support.
Mon, Sep 25, 2:01 PM · KWin
broulik accepted D7897: Move X11 specific Workspace initialization code into dedicated method.
Mon, Sep 25, 1:59 PM · KWin
broulik accepted D7857: Change default argument of grabXKeyboard to XCB_WINDOW_NONE.
Mon, Sep 25, 1:58 PM · KWin
broulik committed R120:602e93dfdb10: [TasksModel] Use std::acumulate on the QHash directly (authored by broulik).
[TasksModel] Use std::acumulate on the QHash directly
Mon, Sep 25, 12:32 PM
broulik committed R120:4174ceb76219: [PowerDevil Runner] Obliterate traces of power profiles (authored by broulik).
[PowerDevil Runner] Obliterate traces of power profiles
Mon, Sep 25, 12:32 PM
broulik committed R120:3cad8d22ce79: Merge branch 'Plasma/5.11' (authored by broulik).
Merge branch 'Plasma/5.11'
Mon, Sep 25, 12:32 PM
broulik closed D7919: [PowerDevil Runner] Obliterate traces of power profiles.
Mon, Sep 25, 12:32 PM · Plasma
broulik closed D7917: [TasksModel] Use std::acumulate on the QHash directly.
Mon, Sep 25, 12:32 PM · Plasma
broulik added a comment to D7971: Add a "Show in folder" button to the notification.

I'll try to squeeze that into Plasma 5.11, stay tuned :)

Mon, Sep 25, 10:08 AM · Spectacle

Sun, Sep 24

broulik added a comment to D7971: Add a "Show in folder" button to the notification.

I'll add a visible "menu" button to the notification preview just like the volume applet has for its outputs. I think this would please us both? ;)

Sun, Sep 24, 6:43 PM · Spectacle
broulik added a comment to D7971: Add a "Show in folder" button to the notification.

I'd actually rather want to get rid of the "Open" button (but for that we would need to detect if the notification server supports previews which we currently can't). And I've been through a gazillion discussions on how context menus are supposedly bad and I'm tired of that.

Sun, Sep 24, 4:43 PM · Spectacle
broulik added a comment to D7971: Add a "Show in folder" button to the notification.

Just right click the preview in the notification.

Sun, Sep 24, 4:38 PM · Spectacle

Sat, Sep 23

broulik added a comment to D7957: Turn on frames around dock widgets by default.

-1 on the side panel frame

Sat, Sep 23, 8:24 PM · Breeze, Plasma
broulik accepted D7956: Drop unused functions from utils.
Sat, Sep 23, 7:40 PM · KWin

Fri, Sep 22

broulik accepted D7743: Always show image rotation buttons in Image Operations sidebar when other operations are available.

Let's go for it.

Fri, Sep 22, 3:46 PM
broulik accepted D7938: Drop useless XCB_DESTROY_NOTIFY from big event switch statement.
Fri, Sep 22, 3:22 PM · KWin
broulik added inline comments to D7934: Add KCM for adjusting QtQuick Rendering in Plasma.
Fri, Sep 22, 9:56 AM · Plasma

Thu, Sep 21

broulik accepted D7926: Remove pf.path() from container before the reference got screwed up by it.remove().
Thu, Sep 21, 8:15 PM · Frameworks
broulik created D7919: [PowerDevil Runner] Obliterate traces of power profiles.
Thu, Sep 21, 3:26 PM · Plasma
broulik created D7917: [TasksModel] Use std::acumulate on the QHash directly.
Thu, Sep 21, 3:02 PM · Plasma
broulik added a comment to D7916: Introduce MimeTypeChecker::hasWantedMimeTypes.

+1

Thu, Sep 21, 2:56 PM · KDE PIM