broulik (Kai Uwe Broulik)
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Dec 14 2015, 3:47 PM (166 w, 16 h)
Availability
Available

Recent Activity

Today

broulik added a comment to D19038: Make Appearance KCM tooltip texts consistent.

I would have prefered nobody touching the color KCM until D18646 was merged..

Tue, Feb 19, 8:21 AM · Plasma
broulik added a comment to D18883: Add PDF thumbnailer.

Perhaps but it's only recently become an issue since kioslaves now support KCrash. Previously such thumbnailer crashes just went unnoticed.

Tue, Feb 19, 8:16 AM · Frameworks, Dolphin

Yesterday

broulik added a comment to D18883: Add PDF thumbnailer.

However, you will get a Dr Konqi each time it encounters that file as it will try to generate a thumbnail for it every time you open the folder.

Mon, Feb 18, 2:14 PM · Frameworks, Dolphin

Sun, Feb 17

broulik added a comment to D18991: [containment] Show an inline message when the Desktop Toolbox is hidden.

Bonus points if we could check for whether user has actually configured a "standard menu" action so we could show a big fat warning that they would lock themselves out now if they did that. Preferably even with a button to auto-assign it back if it is missing.

Sun, Feb 17, 12:00 PM · Plasma

Fri, Feb 15

broulik added inline comments to D19036: [notifications] Lift up notification content if one line of body text droops.
Fri, Feb 15, 2:38 PM · Plasma
broulik added a comment to D19033: [about-distro] run absolute paths through qicon intead of qpixmap.

isn't QIcon::fromTheme buggy when passed an absolute path to an SVG file?

Fri, Feb 15, 12:35 PM · Plasma
broulik added a comment to D19015: This is a followup review for the removal of ifdefs before debug.

If you grep for DEBUG_ there's still plenty in Kolourpaint code

Fri, Feb 15, 11:49 AM
broulik added inline comments to D19011: Thunderbolt KCM and KDED module.
Fri, Feb 15, 8:07 AM · Plasma
broulik added a comment to D19019: Verify that model.AppPid is defined.

Only actual windows have PIDs, the role isn't implemented for startup tasks or launchers iirc

Fri, Feb 15, 7:53 AM · Plasma
broulik added a comment to D19020: [breeze-icons] Revamp system.svgz.

What's the air conditioning do? suspend to disk?

Fri, Feb 15, 7:52 AM · Frameworks
broulik accepted D19024: Exclude powerdevil from session management.

I have seen reports of powerdevil sometimes not properly starting, but that's probably unrelated to this? It's started by an autostart file I think and isn't dbus-activated

Fri, Feb 15, 7:50 AM · Plasma
broulik accepted D19025: Exclude kscreen backend launcher from session management.
Fri, Feb 15, 7:50 AM · Plasma
broulik accepted D19026: Exclude kuiserver from session management.
Fri, Feb 15, 7:49 AM · Plasma
broulik accepted D19028: [ksmserver] Restore legacy sessions.

5.15 branch please

Fri, Feb 15, 7:49 AM · Plasma

Thu, Feb 14

broulik accepted D18930: Remove conditional debug output.

Please fix the warnings this now causes separately

Thu, Feb 14, 2:34 PM
broulik added a comment to D18883: Add PDF thumbnailer.

Ping

Thu, Feb 14, 9:55 AM · Frameworks, Dolphin

Wed, Feb 13

broulik added a comment to D18940: Add battery icons.

The do a proper proposal (I bet you already have a task about that) instead of just slipping things in one by one in unrelated reviews

Wed, Feb 13, 3:36 PM · Frameworks
broulik added a comment to D18940: Add battery icons.

The battery icon is composited of multiple SVG items layered ontop of each other, it doesn't just load a single icon.

Wed, Feb 13, 9:24 AM · Frameworks
broulik added a comment to D18940: Add battery icons.

Won't 3rd party themes contain their own icons?

Wed, Feb 13, 9:17 AM · Frameworks
broulik added a comment to D18940: Add battery icons.

maybe we can port the code to use these as icons from the icon theme rather than SVGs from the Plasma theme and then delete them from the Plasma theme

Wed, Feb 13, 8:37 AM · Frameworks

Mon, Feb 11

broulik committed R120:b884003bebd7: [Icon Applet] Parse jump list actions and open with actions on demand (authored by broulik).
[Icon Applet] Parse jump list actions and open with actions on demand
Mon, Feb 11, 7:36 PM
broulik closed D18925: [Icon Applet] Parse jump list actions and open with actions on demand.
Mon, Feb 11, 7:36 PM · Plasma
broulik added a comment to D18646: [Colors KCM] Add search and filter.

It does kind of beg the question of why this is the only grid view that has a search, of course.

Mon, Feb 11, 3:05 PM · Plasma
broulik updated the summary of D18925: [Icon Applet] Parse jump list actions and open with actions on demand.
Mon, Feb 11, 2:36 PM · Plasma
broulik requested review of D18925: [Icon Applet] Parse jump list actions and open with actions on demand.
Mon, Feb 11, 2:36 PM · Plasma
broulik added a comment to D18646: [Colors KCM] Add search and filter.

Is this good now?

Mon, Feb 11, 8:07 AM · Plasma
broulik committed R858:33bd78afd4a8: Support icon on ComboBox (authored by broulik).
Support icon on ComboBox
Mon, Feb 11, 8:06 AM
broulik closed D18718: Support icon on ComboBox.
Mon, Feb 11, 8:06 AM · Plasma
broulik committed R119:ca113afa5028: [Folder View] Assume root of a protocol is always a folder (authored by broulik).
[Folder View] Assume root of a protocol is always a folder
Mon, Feb 11, 8:05 AM
broulik closed D18721: [Folder View] Assume root of a protocol is always a folder.
Mon, Feb 11, 8:05 AM · Plasma
broulik committed R343:85bb58992d53: Register all codecs and muxers before trying to generate thumbnail (authored by broulik).
Register all codecs and muxers before trying to generate thumbnail
Mon, Feb 11, 8:04 AM
broulik closed D18749: Register all codecs and muxers before trying to generate thumbnail.
Mon, Feb 11, 8:04 AM
broulik committed R856:4ae87a3757ca: Remove unused dependencies (authored by broulik).
Remove unused dependencies
Mon, Feb 11, 8:03 AM
broulik closed D18886: Remove unused dependencies.
Mon, Feb 11, 8:03 AM · Plasma

Sun, Feb 10

broulik added a comment to D18903: Make Appearance KCMs' labels consistent.

So you had all these comments changed to be "more natural" and now you change them back to how they were before?

Sun, Feb 10, 6:34 PM · Plasma
broulik reopened D18741: Convert old style to Qt5 style connection.

This breaks the font tool, can no longer change font style or font size

Sun, Feb 10, 5:15 PM
broulik added inline comments to D18883: Add PDF thumbnailer.
Sun, Feb 10, 11:18 AM · Frameworks, Dolphin

Sat, Feb 9

broulik added a comment to D18882: [Image Thumbnailer] Support eps files.

But that will create additional, potentially defunct entries in Previewer settings?

Sat, Feb 9, 11:01 PM · Frameworks, Dolphin
broulik planned changes to D18882: [Image Thumbnailer] Support eps files.
Sat, Feb 9, 10:49 PM · Frameworks, Dolphin
broulik added a comment to D18882: [Image Thumbnailer] Support eps files.

Ah, yeah, it tries and if it fails, it aborts, it doesn't try every thumbnailer that claims to support a format.

Sat, Feb 9, 10:49 PM · Frameworks, Dolphin
broulik added a comment to D18882: [Image Thumbnailer] Support eps files.

OTOH this will not work if kimageformats is not installed, and the thumbnailer gives no hint about that.

Sat, Feb 9, 10:47 PM · Frameworks, Dolphin
broulik updated the diff for D18883: Add PDF thumbnailer.
  • Render image at desired size already
  • Remove unused include
Sat, Feb 9, 10:46 PM · Frameworks, Dolphin
broulik added a comment to D18882: [Image Thumbnailer] Support eps files.

You'll get a thumbnail either way \o/

Sat, Feb 9, 10:26 PM · Frameworks, Dolphin
broulik added inline comments to D18883: Add PDF thumbnailer.
Sat, Feb 9, 9:56 PM · Frameworks, Dolphin
broulik updated the diff for D18883: Add PDF thumbnailer.
  • Remove mimetypes left from testing
  • Don't encode filename (missed that there's one other than the QByteArray one)
Sat, Feb 9, 9:54 PM · Frameworks, Dolphin
broulik requested review of D18886: Remove unused dependencies.
Sat, Feb 9, 9:12 PM · Plasma
broulik added a comment to T10464: Move "KWin Switching Layouts" designed for KWin 4.x to it's own category.

Can we also make KWin smarter and try to fall back to the default theme (which may also be broken, sure, but because of distro not GHNS)?

Sat, Feb 9, 6:40 PM · KDE Store
broulik requested review of D18883: Add PDF thumbnailer.
Sat, Feb 9, 6:09 PM · Frameworks, Dolphin
broulik requested review of D18882: [Image Thumbnailer] Support eps files.
Sat, Feb 9, 5:56 PM · Frameworks, Dolphin

Fri, Feb 8

broulik accepted D18849: [KPropertiesDialog] Fix group combobox.
Fri, Feb 8, 1:44 PM · Frameworks
broulik committed R320:c6da4dabf635: Extend Open Document thumbnailer to Open Packaging Conventions format (authored by broulik).
Extend Open Document thumbnailer to Open Packaging Conventions format
Fri, Feb 8, 1:18 PM
broulik closed D18768: Extend Open Document thumbnailer to Open Packaging Conventions format.
Fri, Feb 8, 1:18 PM · Frameworks, Dolphin
broulik accepted D18739: Sync QML module padding to reflect system setting pages.
Fri, Feb 8, 12:12 PM · Frameworks
broulik updated the test plan for D18768: Extend Open Document thumbnailer to Open Packaging Conventions format.
Fri, Feb 8, 12:06 PM · Frameworks, Dolphin
broulik updated the diff for D18768: Extend Open Document thumbnailer to Open Packaging Conventions format.
  • Read thumbnail location from rels
  • Add .xps file format (used in Windows for printing, I believe) which also follows the spec and qualifies as "office document"
Fri, Feb 8, 12:02 PM · Frameworks, Dolphin
broulik committed R119:c03dbde20c32: Merge branch 'Plasma/5.15' (authored by broulik).
Merge branch 'Plasma/5.15'
Fri, Feb 8, 11:23 AM
broulik committed R119:a958bafc6c87: Merge branch 'Plasma/5.12' into Plasma/5.15 (authored by broulik).
Merge branch 'Plasma/5.12' into Plasma/5.15
Fri, Feb 8, 11:23 AM
broulik committed R119:67d8ac416ff6: Use Dialog's visibility directly rather than relying on the mainItem's (authored by broulik).
Use Dialog's visibility directly rather than relying on the mainItem's
Fri, Feb 8, 11:23 AM
broulik closed D18844: Fix opening toolbox button.
Fri, Feb 8, 11:23 AM · Plasma
broulik requested review of D18844: Fix opening toolbox button.
Fri, Feb 8, 10:07 AM · Plasma
broulik committed R119:48a538ab3b2b: Merge branch 'Plasma/5.15' (authored by broulik).
Merge branch 'Plasma/5.15'
Fri, Feb 8, 9:56 AM
broulik committed R119:42fb1de1b3fa: [Containment Actions Configuration] Fix changing plugin (authored by broulik).
[Containment Actions Configuration] Fix changing plugin
Fri, Feb 8, 9:55 AM
broulik closed D18840: [Containment Actions Configuration] Fix changing plugin.
Fri, Feb 8, 9:55 AM · Plasma
broulik added inline comments to D18840: [Containment Actions Configuration] Fix changing plugin.
Fri, Feb 8, 9:30 AM · Plasma
broulik added a comment to D18739: Sync QML module padding to reflect system setting pages.

If you open multiple KCMs switching between QML- and Widget-ones leads to awkward outside margin changes with this patch.

kcmshell5 icons style

Switch between the two and observe how the sidebar dances (this is likely the same issue as when doing the same in System Settings in Icons mode rather than Sidebar)

Fri, Feb 8, 9:26 AM · Frameworks
broulik added a comment to D17796: Show accurate checked state for system monitor configuration pages.

The call on line 141 looks superfluous - if there's any change to checked we modify cfg_sources which should trigger the reload.

Fri, Feb 8, 9:04 AM · Plasma
broulik updated the test plan for D18840: [Containment Actions Configuration] Fix changing plugin.
Fri, Feb 8, 8:59 AM · Plasma
broulik requested review of D18840: [Containment Actions Configuration] Fix changing plugin.
Fri, Feb 8, 8:58 AM · Plasma
broulik requested review of D18838: Fix opening http links in browser.
Fri, Feb 8, 8:20 AM · Dolphin
broulik committed R318:585cc994e6c5: [DolphinView] Use correct color group (authored by broulik).
[DolphinView] Use correct color group
Fri, Feb 8, 8:02 AM
broulik committed R318:d5744305f6fa: Merge branch 'Applications/18.12' (authored by broulik).
Merge branch 'Applications/18.12'
Fri, Feb 8, 8:02 AM
broulik closed D18811: [DolphinView] Use correct color group.
Fri, Feb 8, 8:02 AM · Dolphin
broulik added a comment to D18836: Make the button tooltips on the "Configure Virtual Desktops" page translatable.

Why is this neccessary? The other places work just fine without a domain

Fri, Feb 8, 7:45 AM · KWin

Thu, Feb 7

broulik committed R242:7ca1f01ea91a: Do background contrast fallback at runtime (authored by broulik).
Do background contrast fallback at runtime
Thu, Feb 7, 3:43 PM
broulik closed D18487: Do background contrast fallback at runtime.
Thu, Feb 7, 3:43 PM · Frameworks
broulik committed R119:e8e141ff13a4: Merge branch 'Plasma/5.15' (authored by broulik).
Merge branch 'Plasma/5.15'
Thu, Feb 7, 3:34 PM
broulik committed R119:6835000906d3: Sort setting grid views alphabetically (authored by broulik).
Sort setting grid views alphabetically
Thu, Feb 7, 3:34 PM
broulik closed D18815: Sort setting grid views alphabetically.
Thu, Feb 7, 3:34 PM · Plasma
broulik added a comment to D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter.

Doesn't look terrible with Oxygen icons to me.

Thu, Feb 7, 2:44 PM · Plasma
broulik requested review of D18815: Sort setting grid views alphabetically.
Thu, Feb 7, 2:15 PM · Plasma
broulik requested review of D18811: [DolphinView] Use correct color group.
Thu, Feb 7, 1:00 PM · Dolphin
broulik added inline comments to D18646: [Colors KCM] Add search and filter.
Thu, Feb 7, 12:47 PM · Plasma
broulik updated the diff for D18487: Do background contrast fallback at runtime.
Thu, Feb 7, 12:10 PM · Frameworks
broulik committed R320:db7e30823b8a: Add eBook thumbnailer (authored by broulik).
Add eBook thumbnailer
Thu, Feb 7, 8:26 AM
broulik closed D18738: Add ebook thumbnailer.

https://cgit.kde.org/kio-extras.git/commit/?id=db7e30823b8a26b1f8bec721f2079bed6132a155

Thu, Feb 7, 8:11 AM · Frameworks, Dolphin
broulik added a comment to D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter.

What about non-SVG icon themes like Oxygen? They will look awful when downscaled from 32 to 24.

Thu, Feb 7, 8:00 AM · Plasma

Wed, Feb 6

broulik committed R111:87c2028856a1: Better window title display (authored by broulik).
Better window title display
Wed, Feb 6, 4:03 PM
broulik closed D18779: Better window title display.

https://cgit.kde.org/libksysguard.git/commit/?id=87c2028856a1b924cdf86b5b258b642394dd7b13

Wed, Feb 6, 3:44 PM · Plasma
broulik committed R318:9da33680ad7b: Merge branch 'Applications/18.12' (authored by broulik).
Merge branch 'Applications/18.12'
Wed, Feb 6, 3:24 PM
broulik committed R318:bf44548ad154: Sort preview plugins case-insensitively (authored by broulik).
Sort preview plugins case-insensitively
Wed, Feb 6, 3:24 PM
broulik closed D18787: Sort preview plugins case-insensitively.
Wed, Feb 6, 3:24 PM · Dolphin
broulik updated the diff for D18738: Add ebook thumbnailer.
  • Use proper cmake thing
Wed, Feb 6, 3:21 PM · Frameworks, Dolphin
broulik requested review of D18787: Sort preview plugins case-insensitively.
Wed, Feb 6, 3:18 PM · Dolphin
broulik committed R126:9282d20d1b15: [KEditFileType] Make heading with mime type selectable (authored by broulik).
[KEditFileType] Make heading with mime type selectable
Wed, Feb 6, 3:10 PM
broulik closed D18767: [KEditFileType] Make heading with mime type selectable.
Wed, Feb 6, 3:10 PM · Plasma
broulik requested review of D18779: Better window title display.
Wed, Feb 6, 8:32 AM · Plasma

Tue, Feb 5

broulik added a comment to D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons.

+1 I think this is a fine tradeoff between aesthetics and usability

Tue, Feb 5, 8:36 PM · Frameworks
acrouthamel awarded D18768: Extend Open Document thumbnailer to Open Packaging Conventions format a Yellow Medal token.
Tue, Feb 5, 8:03 PM · Frameworks, Dolphin
broulik requested review of D18768: Extend Open Document thumbnailer to Open Packaging Conventions format.
Tue, Feb 5, 7:38 PM · Frameworks, Dolphin
broulik requested review of D18767: [KEditFileType] Make heading with mime type selectable.
Tue, Feb 5, 6:47 PM · Plasma