broulik (Kai Uwe Broulik)
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Dec 14 2015, 3:47 PM (139 w, 4 d)
Availability
Available

Recent Activity

Today

broulik committed R31:cc24d25a5962: [kstyle] Create shadow tiles on demand (authored by broulik).
[kstyle] Create shadow tiles on demand
Fri, Aug 17, 2:23 PM
broulik closed D14898: Create shadow tiles on demand.
Fri, Aug 17, 2:23 PM · Plasma
broulik committed R242:e143f7d457f6: [Icon Item] Use ItemEnabledHasChanged (authored by broulik).
[Icon Item] Use ItemEnabledHasChanged
Fri, Aug 17, 1:46 PM
broulik closed D14531: [Icon Item] Use ItemEnabledHasChanged.
Fri, Aug 17, 1:46 PM · Frameworks
broulik committed R242:938cef210c79: Get rid of deprecated QWeakPointer usage (authored by broulik).
Get rid of deprecated QWeakPointer usage
Fri, Aug 17, 1:44 PM
broulik closed D14819: Get rid of deprecated QWeakPointer usage.
Fri, Aug 17, 1:44 PM · Frameworks
broulik added a comment to D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.

It is just a question. I think since you call setData when the job finishes anyway, it should be fine but I don't really know the architecture of that stuff either, so it might be fine to just trigger a free space job in updateSourceEvent

Fri, Aug 17, 12:06 PM · Plasma
broulik added a comment to D14898: Create shadow tiles on demand.

I found Breeze's ShadowHelper::loadConfig() stick out in hotspot on Dolphin startup, so I investigated what it did and found it would needlessly load the shadows.

Fri, Aug 17, 12:05 PM · Plasma
broulik added inline comments to D14855: Add applet with screen layouts and presentation mode.
Fri, Aug 17, 11:23 AM · Plasma
broulik committed R241:64ba67d0acc4: [KUrlComboBox] Fix KIcon porting error (authored by broulik).
[KUrlComboBox] Fix KIcon porting error
Fri, Aug 17, 11:19 AM
broulik closed D14899: [KUrlComboBox] Fix KIcon porting error.
Fri, Aug 17, 11:19 AM · Frameworks
broulik requested review of D14899: [KUrlComboBox] Fix KIcon porting error.
Fri, Aug 17, 11:11 AM · Frameworks
broulik added a comment to F6196713: Screenshot_20180815_095827.png.

The icons do have a tooltip

Fri, Aug 17, 10:59 AM
broulik requested review of D14898: Create shadow tiles on demand.
Fri, Aug 17, 10:56 AM · Plasma
broulik added a comment to D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.

Yes, please use KIO::FileSystemFreeSpaceJob which is a lot simpler than all of this manually added threading code.

Fri, Aug 17, 9:57 AM · Plasma
broulik committed R242:4bda8ec0b74b: Fix style sheet for 22-22-system-suspend (authored by broulik).
Fix style sheet for 22-22-system-suspend
Fri, Aug 17, 9:51 AM
broulik committed R120:499d145e1a36: Label job notifications with destination file name (authored by karthikp).
Label job notifications with destination file name
Fri, Aug 17, 9:46 AM
broulik closed D14857: Label job notifications with destination file name.
Fri, Aug 17, 9:46 AM · Plasma

Yesterday

broulik committed R318:523c95bed0bf: Merge branch 'Applications/18.08' (authored by broulik).
Merge branch 'Applications/18.08'
Thu, Aug 16, 2:29 PM
broulik committed R318:f75b8a4287f9: Pretty-print "creationtime" role (authored by broulik).
Pretty-print "creationtime" role
Thu, Aug 16, 2:28 PM
broulik closed D14878: Pretty-print "creationtime" role.
Thu, Aug 16, 2:28 PM · Dolphin
broulik retitled D14880: Read UDS entry times directly and pretty-print on-demand from Read USD entry times directly and pretty-print on-demand to Read UDS entry times directly and pretty-print on-demand.
Thu, Aug 16, 2:22 PM · Dolphin
broulik requested review of D14880: Read UDS entry times directly and pretty-print on-demand.
Thu, Aug 16, 2:22 PM · Dolphin
broulik updated the test plan for D14878: Pretty-print "creationtime" role.
Thu, Aug 16, 2:13 PM · Dolphin
broulik requested review of D14878: Pretty-print "creationtime" role.
Thu, Aug 16, 2:13 PM · Dolphin
broulik added a comment to D14243: Fix bad model hygiene in Positioner::move().

Alright, just important to get this fixed for 5.14, if all else fails we can still revert this, as it only asserts on debug builds

Thu, Aug 16, 9:33 AM · Plasma
broulik committed R320:1e44637d0315: [Activities Linking] Don't offer for non-local URLs (authored by broulik).
[Activities Linking] Don't offer for non-local URLs
Thu, Aug 16, 9:01 AM
broulik closed D14843: [Activities Linking] Don't offer for non-local URLs.
Thu, Aug 16, 9:01 AM
broulik added a reviewer for D14830: Add "Display Configuration" context menu entry on the desktop: harmathy.
Thu, Aug 16, 8:41 AM · Plasma
broulik added a reviewer for D14855: Add applet with screen layouts and presentation mode: harmathy.
Thu, Aug 16, 8:41 AM · Plasma

Wed, Aug 15

broulik added a comment to D14850: [effects] Turn off Translucency by default.

! In D14850#309479, @zzag wrote:
I think one could achieve that by taking screenshots and using gimp.

Wed, Aug 15, 10:36 AM · KWin
broulik added a comment to D14850: [effects] Turn off Translucency by default.

I used to do that to compare layouts and metrics of different applications or images but that doesn't really justify being enabled for everyone by default

Wed, Aug 15, 10:10 AM · KWin
broulik added a reviewer for D14857: Label job notifications with destination file name: VDG.
Wed, Aug 15, 9:50 AM · Plasma
broulik added a comment to D14857: Label job notifications with destination file name.

Thanks for your patch and explanation on the mailing list!

Wed, Aug 15, 9:49 AM · Plasma
broulik updated the diff for D14855: Add applet with screen layouts and presentation mode.
  • Use "application enforce presentation mode" to communicate better that the checkbox might be overruled
Wed, Aug 15, 9:38 AM · Plasma
broulik accepted D14856: Search: Add workaround for missing icons in Gnome icon-theme.
Wed, Aug 15, 9:23 AM · Frameworks, Kate
broulik added inline comments to D14856: Search: Add workaround for missing icons in Gnome icon-theme.
Wed, Aug 15, 8:54 AM · Frameworks, Kate
broulik added a comment to D14850: [effects] Turn off Translucency by default.

I used to disable that effect back in the days but now couldn't be bothered anymore. I don't particularly mind either way. :)

Wed, Aug 15, 8:40 AM · KWin
broulik added inline comments to D14854: Switch to the new connect() API.
Wed, Aug 15, 8:39 AM · Localization
broulik requested review of D14855: Add applet with screen layouts and presentation mode.
Wed, Aug 15, 8:13 AM · Plasma
broulik closed D14844: [CompressFileItemAction] Don't offer for non-local URLs.
Wed, Aug 15, 7:40 AM · Ark
broulik committed R36:e88ac5ff962e: [CompressFileItemAction] Don't offer for non-local URLs (authored by broulik).
[CompressFileItemAction] Don't offer for non-local URLs
Wed, Aug 15, 7:40 AM

Tue, Aug 14

broulik requested review of D14844: [CompressFileItemAction] Don't offer for non-local URLs.
Tue, Aug 14, 3:55 PM · Ark
broulik requested review of D14843: [Activities Linking] Don't offer for non-local URLs.
Tue, Aug 14, 3:41 PM
broulik added inline comments to D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine.
Tue, Aug 14, 2:13 PM · Plasma
broulik added a comment to D10937: Retouching of Screen Layout Selection OSD Icons.

While you're at it can't you move them to plasma-framework? Having them in Breeze makes it not work with other themes and also they are only shown in the context of Plasma anyway

Tue, Aug 14, 1:56 PM · Frameworks, VDG
broulik added a comment to D14830: Add "Display Configuration" context menu entry on the desktop.

The text needs to start with a verb and end with an ellipsis, E.g. "Configure Display Settings..." or even "Configure Displays..."

Tue, Aug 14, 1:41 PM · Plasma
broulik requested review of D14830: Add "Display Configuration" context menu entry on the desktop.
Tue, Aug 14, 1:04 PM · Plasma
broulik accepted D14829: Remove warning about old kiosk feature that no longer applies..
Tue, Aug 14, 12:35 PM · Frameworks
broulik requested review of D14819: Get rid of deprecated QWeakPointer usage.
Tue, Aug 14, 8:45 AM · Frameworks
broulik accepted D14661: Force reevaluation of Predicates if interfaces are removed.

Not pretty but if it works.. Thanks!

Tue, Aug 14, 8:02 AM · Frameworks

Mon, Aug 13

broulik added a comment to D14810: Improve Widgets' removal and configure text.

+1

Mon, Aug 13, 9:36 PM · Frameworks
broulik updated the summary of D14308: [Exe Thumbnailer] Improve icon selection algorithm.
Mon, Aug 13, 9:01 PM
broulik updated the diff for D14308: [Exe Thumbnailer] Improve icon selection algorithm.
  • Fix top, should have worn my glasses when reading that
Mon, Aug 13, 9:01 PM
broulik updated the summary of D14308: [Exe Thumbnailer] Improve icon selection algorithm.
Mon, Aug 13, 9:00 PM
broulik added a comment to D14308: [Exe Thumbnailer] Improve icon selection algorithm.

Should be "Prefer higher BPP"

Mon, Aug 13, 8:32 PM
broulik requested changes to D14697: X11: set GDK_SCALE (try 2).

Please hang on, we need to more thorougly test this.

Mon, Aug 13, 1:46 PM · Plasma
broulik committed R872:8022c10a8c4e: Fix archive name in README.md (authored by broulik).
Fix archive name in README.md
Mon, Aug 13, 1:46 PM
broulik closed D14786: Fix archive name in README.md.
Mon, Aug 13, 1:46 PM · Plasma
broulik requested review of D14786: Fix archive name in README.md.
Mon, Aug 13, 11:32 AM · Plasma
broulik added a comment to D14770: Generate file thumbnails before folder thumbnails.

Did you check the updated version with stable_partition? It makes the folders generate in the correct order as well.

Mon, Aug 13, 8:14 AM · Dolphin
broulik added a comment to D14770: Generate file thumbnails before folder thumbnails.

Is this about generating the thumbnails for the first time or displaying them?

Mon, Aug 13, 7:54 AM · Dolphin
broulik updated the diff for D14770: Generate file thumbnails before folder thumbnails.
  • Use stable_partition so the order of elements is preserved
Mon, Aug 13, 7:53 AM · Dolphin

Sun, Aug 12

broulik requested review of D14770: Generate file thumbnails before folder thumbnails.
Sun, Aug 12, 2:52 PM · Dolphin
broulik updated the diff for D14308: [Exe Thumbnailer] Improve icon selection algorithm.

I found a way to get the actual depth of the icon extracted

  • Prefer higher DPI as well
Sun, Aug 12, 1:23 PM
broulik added a comment to D14243: Fix bad model hygiene in Positioner::move().

This actually seems to break re-arranging files, at least on Qt 5.11.1:


Reverting this patch makes it work again

Sun, Aug 12, 8:33 AM · Plasma

Sat, Aug 11

broulik committed R120:f326b1435a71: [Shell Corona] Don't create ScriptingEngine if there are no update scripts (authored by broulik).
[Shell Corona] Don't create ScriptingEngine if there are no update scripts
Sat, Aug 11, 10:02 PM
broulik closed D14751: [Shell Corona] Don't create ScriptingEngine if there are no update scripts.
Sat, Aug 11, 10:02 PM · Plasma
broulik requested review of D14751: [Shell Corona] Don't create ScriptingEngine if there are no update scripts.
Sat, Aug 11, 9:12 PM · Plasma
broulik committed R119:15ca6121a33f: Merge branch 'Plasma/5.13' (authored by broulik).
Merge branch 'Plasma/5.13'
Sat, Aug 11, 9:01 PM
broulik committed R119:974bd7b47c4f: Merge branch 'Plasma/5.12' into Plasma/5.13 (authored by broulik).
Merge branch 'Plasma/5.12' into Plasma/5.13
Sat, Aug 11, 9:01 PM
broulik committed R119:8ed77e53af33: [Style KCM] Use "configure" icon (authored by broulik).
[Style KCM] Use "configure" icon
Sat, Aug 11, 9:01 PM
broulik closed D14746: [Style KCM] Use "configure" icon.
Sat, Aug 11, 9:01 PM · Plasma
broulik added a comment to D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line..

You can't and I don't see why you can't just use Home/End. Sorry.

Sat, Aug 11, 6:47 PM · Plasma
broulik added a comment to D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line..

I don't understand. Also, you can change the default shortcut from Home/End to whatever you like.

Sat, Aug 11, 6:38 PM · Plasma
broulik added a comment to D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line..

Can you explain the rationale behind this? Since you've seemingly randomly changed the shortcut, it doesn't seem like a "common" shortcut sheme?

Sat, Aug 11, 5:53 PM · Plasma
broulik requested review of D14747: [Exe Thumbnailer] Don't generate QTemporaryFile.
Sat, Aug 11, 4:16 PM
broulik updated the diff for D14308: [Exe Thumbnailer] Improve icon selection algorithm.
  • Use algorithm suggested by Stefan, thanks.
Sat, Aug 11, 3:46 PM
broulik abandoned D12380: [Containment Interface] Honor plasma/containment_context_menu restriction.
Sat, Aug 11, 3:39 PM · Frameworks
broulik edited reviewers for D14746: [Style KCM] Use "configure" icon, added: ngraham; removed: grahamperrin.
Sat, Aug 11, 2:50 PM · Plasma
broulik requested review of D14746: [Style KCM] Use "configure" icon.
Sat, Aug 11, 2:50 PM · Plasma
broulik added a reviewer for D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.: Plasma.
Sat, Aug 11, 2:42 PM · Plasma
broulik added a comment to D14737: Move "update" button from the left side to the right side in NIC module.

Shouldn't it rather be called "Reload" with the appropriate icon?
Checkout KStandardAction or KGuiItem

Sat, Aug 11, 1:30 PM · Plasma
broulik added a comment to D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line..

Ctrl+A is reserved for "Select All"

Sat, Aug 11, 7:43 AM · Plasma

Thu, Aug 9

broulik committed R241:3b39f63af50b: [KFileItem] Don't read directory comment on slow mounts (authored by broulik).
[KFileItem] Don't read directory comment on slow mounts
Thu, Aug 9, 2:25 PM
broulik closed D14689: [KFileItem] Don't read directory comment on slow mounts.
Thu, Aug 9, 2:25 PM · Frameworks
broulik accepted D14708: Load QtQuickSettings for software rendering We had support for falling back on errors yet somehow the initial basic loading was missing..
Thu, Aug 9, 2:24 PM · Plasma
broulik added a comment to D14561: [kcmkwin/compositing] Rename Candy category to Eye Candy.

Wouldn't that break third party effects that have "Candy" in their manifest? Perhaps only change the user-visible string?

Thu, Aug 9, 11:52 AM · KWin
broulik updated the diff for D14689: [KFileItem] Don't read directory comment on slow mounts.
  • Move check

isDirectoryMounted creates a QFileInfo on the url anyway, so both are prone to block, doesn't really matter which way round, does it?

Thu, Aug 9, 11:44 AM · Frameworks
broulik committed R856:389bd34ff513: Also register players immediately in addition to DOMContentLoaded (authored by broulik).
Also register players immediately in addition to DOMContentLoaded
Thu, Aug 9, 11:31 AM
broulik committed R856:183c91c6bb93: Install MutationObserver immediately (authored by broulik).
Install MutationObserver immediately
Thu, Aug 9, 11:26 AM
broulik closed D14217: Install MutationObserver immediately.
Thu, Aug 9, 11:26 AM · Plasma
broulik added inline comments to D13782: Ignore NTFS hidden flag for root volume.
Thu, Aug 9, 9:12 AM · Frameworks
broulik committed R241:4376c0dd4173: Use QDir::canonicalPath instead (authored by broulik).
Use QDir::canonicalPath instead
Thu, Aug 9, 9:11 AM
broulik committed R241:f6df95e595ee: Ignore NTFS hidden flag for root volume (authored by broulik).
Ignore NTFS hidden flag for root volume
Thu, Aug 9, 7:47 AM
broulik closed D13782: Ignore NTFS hidden flag for root volume.
Thu, Aug 9, 7:47 AM · Frameworks
broulik updated the diff for D13782: Ignore NTFS hidden flag for root volume.
  • Rebase
  • use QDir().absoluteFilePath()
Thu, Aug 9, 6:44 AM · Frameworks

Wed, Aug 8

broulik added a comment to D14689: [KFileItem] Don't read directory comment on slow mounts.

Even isSlow() causes blockage as that does KFileSystemType::fileSystemType which then blocks in statfs64 :( (this patch still makes sense imho)

Wed, Aug 8, 12:31 PM · Frameworks
broulik accepted D14533: [autotests] Test ScriptedEffects stackingOrder stackingOrder is an interesting property which needed special handling in the port. Add an explicit test..
Wed, Aug 8, 10:55 AM · KWin
broulik accepted D13032: Fix cleanup of kconfigtest kdeglobals.
Wed, Aug 8, 10:53 AM · Frameworks