broulik (Kai Uwe Broulik)
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Dec 14 2015, 3:47 PM (114 w, 6 d)
Availability
Available

Recent Activity

Today

broulik added a comment to D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM.

Also I think all of this will become obsolete with Qt 5.11 where it supports multiple platform plugins as a fallback chain: https://codereview.qt-project.org/#/c/220294/

Sun, Feb 25, 5:47 PM · Plasma
broulik added inline comments to D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM.
Sun, Feb 25, 5:44 PM · Plasma
broulik added a comment to D10804: Show "Empty trash" button inside trash directory.

I'm not too fond of that extra button on its own line. Can we perhaps add a "Empty Trash" (also capitalize the T) button to the tool bar dynamically like it's done with the "Control" button (only shown when menu is hidden, could take some code inspiration from it)

Sun, Feb 25, 5:43 PM · Dolphin
broulik accepted D10802: Fix the userswitcher when using the mouse for switching.
Sun, Feb 25, 5:41 PM · Plasma
broulik accepted D10800: Plasma browser MPRIS canPlay shouldn't depend on the actual playing status.

Makes sense. Thanks!

Sun, Feb 25, 5:40 PM · Plasma
broulik added a comment to D10835: [kicker] Never execute recent documents.

Can you check whether this affects Task manager also?

Sun, Feb 25, 5:37 PM · Plasma

Yesterday

broulik added a comment to D9713: Add script to unlock a broken session via ConsoleKit..

Framework for […] tracking users

Sat, Feb 24, 8:21 AM · Plasma

Fri, Feb 23

broulik updated the diff for D10774: [Shell Handler] Port from own QQmlEngine to using QmlObjectSharedEngine.
  • Remove debug
Fri, Feb 23, 4:43 PM · Plasma
broulik requested review of D10774: [Shell Handler] Port from own QQmlEngine to using QmlObjectSharedEngine.
Fri, Feb 23, 4:39 PM · Plasma
broulik requested review of D10773: Port to QmlObjectSharedEngine in all remaining places.
Fri, Feb 23, 4:29 PM · Plasma
broulik requested review of D10769: [Dialog] Remove now obsolete KWindowSystem::setState calls.
Fri, Feb 23, 3:16 PM · Frameworks, Plasma
broulik committed R242:48b62d1a2763: [AppletQuickItem] Preload applet expander only if not already expanded (authored by broulik).
[AppletQuickItem] Preload applet expander only if not already expanded
Fri, Feb 23, 12:00 PM
broulik closed D10764: [AppletQuickItem] Preload applet expander only if not already expanded.
Fri, Feb 23, 12:00 PM · Frameworks, Plasma
broulik accepted D10692: parent full representation to the proper window at start.
Fri, Feb 23, 10:48 AM · Plasma
broulik committed R119:b2588104cc56: Place toolbox in the top right corner of the screen (authored by broulik).
Place toolbox in the top right corner of the screen
Fri, Feb 23, 10:38 AM
broulik closed D10563: Place toolbox in the top right corner of the screen.
Fri, Feb 23, 10:38 AM · Plasma
broulik updated the summary of D10660: [Weather applet] Let Return invoke search.
Fri, Feb 23, 10:24 AM · Plasma
broulik committed R245:14e104f801bf: [UDisksDeviceBackend] Avoid multiple lookup (authored by broulik).
[UDisksDeviceBackend] Avoid multiple lookup
Fri, Feb 23, 10:06 AM
broulik closed D10658: [UDisksDeviceBackend] Avoid double lookup.
Fri, Feb 23, 10:06 AM · Frameworks
broulik requested review of D10764: [AppletQuickItem] Preload applet expander only if not already expanded.
Fri, Feb 23, 9:47 AM · Frameworks, Plasma

Thu, Feb 22

broulik added inline comments to D10692: parent full representation to the proper window at start.
Thu, Feb 22, 5:19 PM · Plasma
broulik accepted D10722: other preload microoptimizations.
Thu, Feb 22, 5:17 PM · Frameworks, Plasma
broulik accepted D10736: Do clamping in the model and add missing lower bound check.
Thu, Feb 22, 9:00 AM · Plasma

Wed, Feb 21

broulik added inline comments to D10722: other preload microoptimizations.
Wed, Feb 21, 5:04 PM · Frameworks, Plasma
broulik committed R241:a3e2b24b17ee: [KFileWidget] Hide places frame and header (authored by broulik).
[KFileWidget] Hide places frame and header
Wed, Feb 21, 4:46 PM
broulik closed D10325: [KFileWidget] Hide places frame and header.
Wed, Feb 21, 4:46 PM · Frameworks, Plasma
broulik committed R119:f856027b8694: Merge branch 'Plasma/5.12' (authored by broulik).
Merge branch 'Plasma/5.12'
Wed, Feb 21, 4:37 PM
broulik committed R120:7c644c4499c8: [Clipboard plasmoid] Split delegate into separate files (authored by broulik).
[Clipboard plasmoid] Split delegate into separate files
Wed, Feb 21, 4:37 PM
broulik closed D10557: [Clipboard plasmoid] Split delegate into separate files.
Wed, Feb 21, 4:37 PM · Plasma
broulik committed R119:3b526a3a2aa9: [Task Manager] Limit badge label to a sane size (authored by broulik).
[Task Manager] Limit badge label to a sane size
Wed, Feb 21, 4:37 PM
broulik closed D10586: [Task Manager] Limit badge label to a sane size.
Wed, Feb 21, 4:37 PM · Plasma
broulik added a comment to D10710: update appMenu status only from qml side.

This was to keep an auto-hidden panel visible but I think the panel (at least Plasma, dunno about latte) is smart enough to stay open when a transient child is open, see 2d8b4e1dec26c5976dd75c238c3ae8a4700b8dd9

Wed, Feb 21, 1:00 PM · Plasma
broulik accepted D10710: update appMenu status only from qml side.

BUG: 390271

Wed, Feb 21, 12:57 PM · Plasma
broulik accepted D10695: dont initialize app menu index in every hiding.

Makes sense

Wed, Feb 21, 10:07 AM · Plasma
broulik added a comment to D10705: UI improvement - add expandable line edit widget.

Could that be a candidate for KWidgetsAddons? Though, perhaps if it turns out to be useful elsewhere it can still be moved there.

Wed, Feb 21, 8:35 AM
broulik added inline comments to D10512: try to preload certain applets in a smart way.
Wed, Feb 21, 8:09 AM · Frameworks, Plasma
firef awarded D9984: WIP: Add bookmarks runner a Yellow Medal token.
Wed, Feb 21, 12:56 AM · Plasma

Tue, Feb 20

broulik added inline comments to D10681: preload the expander (the dialog) too.
Tue, Feb 20, 10:53 PM · Frameworks, Plasma
broulik added inline comments to D10692: parent full representation to the proper window at start.
Tue, Feb 20, 10:49 PM · Plasma
broulik updated the diff for D10557: [Clipboard plasmoid] Split delegate into separate files.

Remove debug

Tue, Feb 20, 10:47 PM · Plasma
broulik added a comment to D10591: forcefully activate popup windows when they open.

If we were to do this, we need to first make Device Notifier not freak out when you have a wonky USB cable.

Tue, Feb 20, 10:43 PM · Frameworks, Plasma
broulik accepted D10499: [spellcheck runner] Make each suggestion copyable as separate item.
and then copy the correct or suggested into the clipboard for further usage?
Tue, Feb 20, 10:37 PM · Plasma
broulik accepted D10697: Make the badge text readable on dark color schemes.

Thanks! I assume you tested it with a light color scheme also. 5.12 branch pls

Tue, Feb 20, 10:33 PM · Plasma
broulik requested review of D10686: [DesktopNotifier] Notify change for any link to trash:/.
Tue, Feb 20, 3:46 PM · Plasma
broulik added a comment to D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948.

See D10684 to make it easy for users to bring it back

Tue, Feb 20, 3:27 PM · Plasma
broulik requested review of D10684: [Drop Job] Create proper trash file on linking.
Tue, Feb 20, 3:27 PM · Frameworks, Plasma
firef awarded D10652: [Run Command] Add history drop down button a Yellow Medal token.
Tue, Feb 20, 2:08 PM · Plasma
mbele awarded R120:8227e4e2b7f0: [Run Command] Add history drop down button a Love token.
Tue, Feb 20, 1:38 PM
broulik accepted D10668: Fix PowerDevil shortcuts migration.

shipit once you addressed the other comments

Tue, Feb 20, 12:08 PM · Plasma
broulik committed R242:fa9d4be5d166: [AppletQuickItem] Fix setting default preload policy if no environment variable… (authored by broulik).
[AppletQuickItem] Fix setting default preload policy if no environment variable…
Tue, Feb 20, 10:18 AM
broulik accepted D10671: [UDisks] Fix auto-mount regression.

I added a similar check in Storage Volume but did not here.. :/

Tue, Feb 20, 8:53 AM · Frameworks
broulik added a comment to D10659: [AppletConfiguration] Let applet override Return closing the dialog.

Can this property become something more official, with real documentation

Tue, Feb 20, 8:45 AM · Plasma
broulik requested changes to D10672: Set screen bounds for active window grab when compositor is disabled.

Thanks for this patch! It does not take into account device pixel ratio, ie. screen scaling. Here the screenshots turn into half (a quarter) the size they should have since I'm on a 2x scaled screen.

Tue, Feb 20, 8:42 AM · Spectacle

Mon, Feb 19

broulik added a comment to D10512: try to preload certain applets in a smart way.

lgtm

Mon, Feb 19, 5:17 PM · Frameworks, Plasma
broulik added inline comments to D10512: try to preload certain applets in a smart way.
Mon, Feb 19, 4:58 PM · Frameworks, Plasma
broulik planned changes to D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader.

Good idea

Mon, Feb 19, 3:15 PM · Frameworks
broulik updated the summary of D10660: [Weather applet] Let Return invoke search.
Mon, Feb 19, 3:07 PM · Plasma
broulik updated the summary of D10660: [Weather applet] Let Return invoke search.
Mon, Feb 19, 3:07 PM · Plasma
broulik requested review of D10660: [Weather applet] Let Return invoke search.
Mon, Feb 19, 3:06 PM · Plasma
broulik added a dependent revision for D10659: [AppletConfiguration] Let applet override Return closing the dialog: D10660: [Weather applet] Let Return invoke search.
Mon, Feb 19, 3:06 PM · Plasma
broulik requested review of D10659: [AppletConfiguration] Let applet override Return closing the dialog.
Mon, Feb 19, 3:04 PM · Plasma
broulik requested review of D10658: [UDisksDeviceBackend] Avoid double lookup.
Mon, Feb 19, 2:35 PM · Frameworks
broulik requested review of D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader.
Mon, Feb 19, 2:34 PM · Frameworks
broulik committed R120:8227e4e2b7f0: [Run Command] Add history drop down button (authored by broulik).
[Run Command] Add history drop down button
Mon, Feb 19, 2:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Mon, Feb 19, 2:09 PM · Plasma
broulik added a comment to D10652: [Run Command] Add history drop down button.

Those magic values are copied straight from Plasma TextFieldStyle

Mon, Feb 19, 2:06 PM · Plasma
broulik requested review of D10654: [KUrlNavigatorPlacesSelector] Use KFilePlacesModel::convertedUrl.
Mon, Feb 19, 11:44 AM · Frameworks
broulik added a comment to D10532: [Information Panel] Adjust painting icons for high dpi scaling.

Shouldn't we fix it?

Mon, Feb 19, 11:35 AM
broulik added a comment to D10563: Place toolbox in the top right corner of the screen.

What xml file? If it's not used, delete it.

containments/desktop/package/contents/config/main.xml

It certainly was NOT ignored for me and Kubuntu users since Plasma 5.9, in a default setup at least.

Mon, Feb 19, 10:39 AM · Plasma
broulik requested review of D10652: [Run Command] Add history drop down button.
Mon, Feb 19, 10:36 AM · Plasma
broulik added a comment to D10629: Avoid a double emitResult().

Okay, nevermind. Go for it then!

Mon, Feb 19, 10:20 AM · Plasma
broulik abandoned D9227: [Breeze widget style] Override QLineEditIconButton paint event to force Active icon on press.

I just received a +2 for my Qt patch and will merge it. This is obsolete then. Thanks, Hugo!

Mon, Feb 19, 10:18 AM · Plasma
broulik added a comment to D10629: Avoid a double emitResult().

dataengines/places/setupdevicejob.cpp
dataengines/mpris2/playeractionjob.cpp
dataengines/applicationjobs/jobaction.cpp

Mon, Feb 19, 9:41 AM · Plasma
broulik added a comment to D10325: [KFileWidget] Hide places frame and header.

If no Frameworks dev objects within next few days this will be pushed

Mon, Feb 19, 9:39 AM · Frameworks, Plasma
broulik committed R120:093da790ba02: Split constructor with tons of arguments into separate setters (authored by broulik).
Split constructor with tons of arguments into separate setters
Mon, Feb 19, 9:27 AM
broulik committed R241:03be39f3709e: [KUrlNavigatorPlacesSelector] Put categories into submenus (authored by broulik).
[KUrlNavigatorPlacesSelector] Put categories into submenus
Mon, Feb 19, 9:09 AM
broulik closed D10329: [KUrlNavigatorPlacesSelector] Put categories into submenus.
Mon, Feb 19, 9:09 AM · Frameworks

Sun, Feb 18

broulik added a comment to D10627: Reduce plasmashell frozen time to almost nothing.
Sun, Feb 18, 4:47 PM · Plasma
broulik accepted D10629: Avoid a double emitResult().

A quick search through plasma codebase reveals that setResult followed by emitResult is done quite often. Care to fix these, too? :)

Sun, Feb 18, 4:45 PM · Plasma

Fri, Feb 16

broulik requested review of D10586: [Task Manager] Limit badge label to a sane size.
Fri, Feb 16, 4:11 PM · Plasma
broulik committed R120:a42ccf51c3c5: [Clipboard plasmoid] Support Aztec barcode (authored by broulik).
[Clipboard plasmoid] Support Aztec barcode
Fri, Feb 16, 10:10 AM
broulik closed D10560: [Clipboard plasmoid] Support Aztec barcode.
Fri, Feb 16, 10:10 AM · Plasma
broulik requested review of D10571: [AppletAppearance] Remove d QtObject.
Fri, Feb 16, 9:25 AM · Plasma
broulik committed R120:34454b17f3c5: Cleanup and fix things (authored by broulik).
Cleanup and fix things
Fri, Feb 16, 9:04 AM
broulik added a comment to D10560: [Clipboard plasmoid] Support Aztec barcode.

There surely needs to be some CMake change somewhere with the version?

Fri, Feb 16, 8:34 AM · Plasma

Thu, Feb 15

broulik added a comment to D10563: Place toolbox in the top right corner of the screen.

If and when this goes in, any chance you could land it for 5.12.x?

Strictly speaking, this is a behavior change, feature, not a bugfix per se.

This would let Kubuntu get rid of a downstream override, and help other distros planning to package 5.12.

They could have told us earlier that they're patching it… distros could also just apply this patch if they want to.

Thu, Feb 15, 10:45 PM · Plasma
broulik committed R120:7ef47a72bffc: [Clipboard plasmoid] Improved barcode selection button (authored by broulik).
[Clipboard plasmoid] Improved barcode selection button
Thu, Feb 15, 10:20 PM
broulik closed D10562: [Clipboard plasmoid] Improved barcode selection button.
Thu, Feb 15, 10:20 PM · Plasma
broulik updated the test plan for D10563: Place toolbox in the top right corner of the screen.
Thu, Feb 15, 10:15 PM · Plasma
broulik requested review of D10563: Place toolbox in the top right corner of the screen.
Thu, Feb 15, 10:14 PM · Plasma
broulik requested review of D10562: [Clipboard plasmoid] Improved barcode selection button.
Thu, Feb 15, 9:40 PM · Plasma
broulik requested review of D10560: [Clipboard plasmoid] Support Aztec barcode.
Thu, Feb 15, 9:32 PM · Plasma
broulik requested review of D10557: [Clipboard plasmoid] Split delegate into separate files.
Thu, Feb 15, 9:20 PM · Plasma
broulik accepted D10552: Keep item highlighted when context menu opens.

and others excluding Kickoff :P

Thu, Feb 15, 8:50 PM · Plasma
broulik accepted D10259: [Look and feel KCM] Fix copying color scheme data.

Looks good to me but I don't feel confident enough to give it a shipit but if it fixes the unittest and works..

Thu, Feb 15, 8:42 PM · Plasma
broulik added a comment to D10554: Change include namespace from KRunner/ to Plasma/, to match C++ ns.

I would actually prefer the class to be KRunner::AbstractRunner but that's obviously not something we could change.

Thu, Feb 15, 8:39 PM · Frameworks
broulik committed R119:df0e74966623: [KickoffItem] Remove wrapper Item (authored by broulik).
[KickoffItem] Remove wrapper Item
Thu, Feb 15, 2:30 PM
broulik closed D10545: [KickoffItem] Remove wrapper Item.
Thu, Feb 15, 2:30 PM · Plasma
broulik abandoned D10546: [Kickoff] Turn ActionMenu into a QtObject.

PlasmaComponents.MenuItem is a QQuickItem, for whatever reason, I suspect for recursive enabled/visible handling, and with my patch it then complains about not having been placed in a scene.

Thu, Feb 15, 2:29 PM · Plasma
broulik requested review of D10546: [Kickoff] Turn ActionMenu into a QtObject.
Thu, Feb 15, 2:23 PM · Plasma