Feed All Stories

Today

scripty committed R883:1542366: check_po_files.
check_po_files
Wed, May 22, 4:59 AM
yurchor committed R883:1542365: SVN_SILENT Ukrainian translation update.
SVN_SILENT Ukrainian translation update
Wed, May 22, 4:57 AM
mlaurent updated the diff for D21313: Create specific directory for kdebugsettings categories file.

Use DEBUGCATEGORIESDIR and debug-categories5

Wed, May 22, 4:55 AM · Build System, Frameworks
ngraham added inline comments to D21329: Correctly crop embedded thumbs for Canon JPEGs.
Wed, May 22, 4:53 AM · Gwenview
vpinon committed R883:1542364: Fr reservations & stats auto update.
Fr reservations & stats auto update
Wed, May 22, 4:44 AM
aspotashev committed R1045:36787d54476f: Do not store tasks and events in KCalCore::Calendar to simplify code (authored by aspotashev).
Do not store tasks and events in KCalCore::Calendar to simplify code
Wed, May 22, 4:42 AM
Zren added a comment to D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.

We disabled this feature because KDiskFreeSpaceInfo caused hangs for offline network mounts. Has this changed?

Wed, May 22, 4:39 AM · Dolphin
yurchor committed R321:567ea63366a4: Fix minor typo (authored by yurchor).
Fix minor typo
Wed, May 22, 4:15 AM
tommo updated the summary of D21329: Correctly crop embedded thumbs for Canon JPEGs.
Wed, May 22, 3:56 AM · Gwenview
tommo added a comment to D21329: Correctly crop embedded thumbs for Canon JPEGs.

Example Canon thumbnail attached:

Wed, May 22, 3:50 AM · Gwenview
tommo requested review of D21329: Correctly crop embedded thumbs for Canon JPEGs.
Wed, May 22, 3:49 AM · Gwenview
scripty committed R883:1542363: SVN_SILENT regenerate from .po.
SVN_SILENT regenerate from .po
Wed, May 22, 3:31 AM
scripty committed R883:1542362: SVN_SILENT made messages (x-test).
SVN_SILENT made messages (x-test)
Wed, May 22, 3:29 AM
l10n daemon script <scripty@kde.org> committed R161:bf7810efce0c: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Wed, May 22, 3:26 AM
l10n daemon script <scripty@kde.org> committed R134:9a9738711b1f: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Wed, May 22, 3:26 AM
l10n daemon script <scripty@kde.org> committed R97:997d65f208dc: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Wed, May 22, 3:26 AM
l10n daemon script <scripty@kde.org> committed R456:a33cf070ff96: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Wed, May 22, 3:23 AM
l10n daemon script <scripty@kde.org> committed R383:1afb51bdc615: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Wed, May 22, 3:22 AM
l10n daemon script <scripty@kde.org> committed R381:1f4dad79eec8: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Wed, May 22, 3:21 AM
l10n daemon script <scripty@kde.org> committed R374:79e9dcc5fca2: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Wed, May 22, 3:21 AM
l10n daemon script <scripty@kde.org> committed R373:30ca377df93f: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Wed, May 22, 3:21 AM
l10n daemon script <scripty@kde.org> committed R372:79061a1dda5e: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Wed, May 22, 3:21 AM
l10n daemon script <scripty@kde.org> committed R371:26d7e971f223: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Wed, May 22, 3:21 AM
l10n daemon script <scripty@kde.org> committed R370:8f4f85d1273f: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Wed, May 22, 3:21 AM
l10n daemon script <scripty@kde.org> committed R260:94dfaece4274: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Wed, May 22, 3:21 AM
l10n daemon script <scripty@kde.org> committed R34:debc0c90982f: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Wed, May 22, 3:20 AM
l10n daemon script <scripty@kde.org> committed R318:22f78c474ace: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Wed, May 22, 3:17 AM
l10n daemon script <scripty@kde.org> committed R226:b59ef1ff9f8b: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Wed, May 22, 3:17 AM
l10n daemon script <scripty@kde.org> committed R40:07ab2e7cb916: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Wed, May 22, 3:14 AM
l10n daemon script <scripty@kde.org> committed R824:8aea8d99149c: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Wed, May 22, 3:14 AM
mpolicht committed R1037:fa4aca15a903: Autogenerate documentation. (authored by mpolicht).
Autogenerate documentation.
Wed, May 22, 3:05 AM
scripty committed R883:1542361: SVN_SILENT made messages (.po file).
SVN_SILENT made messages (.po file)
Wed, May 22, 3:02 AM
cfeck added a comment to D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.

We disabled this feature because KDiskFreeSpaceInfo caused hangs for offline network mounts. Has this changed?

Wed, May 22, 2:22 AM · Dolphin
ngraham added a comment to D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.

I think what bugs me is the fact that the bar is below Root as well. If the only Places panel entries to get capacity bars were actual devices, I think it might feel better. And we're actually planning to remove the Root entry soon anyway: D15739. I just need to get around to fixing the test...

Wed, May 22, 2:02 AM · Dolphin
Zren updated the diff for D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.

Use KColorScheme's NegativeText color

Wed, May 22, 1:59 AM · Dolphin
Zren added a comment to D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.

Can you use the NegativeText color from the colorscheme instead of a custom danger color?

Wed, May 22, 1:56 AM · Dolphin
ngraham added a comment to T10891: Breeze theme evolution.

Go right ahead!

Wed, May 22, 1:50 AM · VDG, Breeze
scripty committed R883:1542360: SVN_SILENT made messages (svn:executable).
SVN_SILENT made messages (svn:executable)
Wed, May 22, 1:37 AM
scripty committed R883:1542359: SVN_SILENT made messages (*._desktop_.pot file committed).
SVN_SILENT made messages (*._desktop_.pot file committed)
Wed, May 22, 1:29 AM
scripty committed R883:1542358: SVN_SILENT made messages (.pot file).
SVN_SILENT made messages (.pot file)
Wed, May 22, 1:25 AM
davidedmundson updated the diff for D21326: Make limtedrowcountproxymodel usable from QML.

update

Wed, May 22, 1:24 AM · Plasma
l10n daemon script <scripty@kde.org> committed R856:e4e4c5aa0b09: GIT_SILENT Add new file (after extraction) (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Add new file (after extraction)
Wed, May 22, 1:23 AM
l10n daemon script <scripty@kde.org> committed R1012:178db841d895: GIT_SILENT made messages (after extraction) (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT made messages (after extraction)
Wed, May 22, 1:22 AM
l10n daemon script <scripty@kde.org> committed R97:f305b6d904bb: GIT_SILENT made messages (after extraction) (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT made messages (after extraction)
Wed, May 22, 1:21 AM
davidedmundson committed R120:a282bc9d612a: Don't assign a QtObject to a model (authored by davidedmundson).
Don't assign a QtObject to a model
Wed, May 22, 1:13 AM
davidedmundson closed D21274: Don't assign a QtObject to a model.
Wed, May 22, 1:13 AM · Plasma
mpolicht committed R1036:5746fd955eb9: Update Doxygen documentation submodule. (authored by mpolicht).
Update Doxygen documentation submodule.
Wed, May 22, 1:12 AM
l10n daemon script <scripty@kde.org> committed R166:8af892ed44d9: GIT_SILENT made messages (after extraction) (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT made messages (after extraction)
Wed, May 22, 1:10 AM
l10n daemon script <scripty@kde.org> committed R223:a7742d460490: GIT_SILENT made messages (after extraction) (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT made messages (after extraction)
Wed, May 22, 1:10 AM
enolp committed R883:1542357: More updates for Asturian.
More updates for Asturian
Wed, May 22, 12:58 AM
enolp committed R883:1542356: More updates for Asturian.
More updates for Asturian
Wed, May 22, 12:43 AM
apol added a comment to D21328: Add qml import for KItemModels.

I wonder if it was necessary to do the whole move into core :P.

Wed, May 22, 12:12 AM · Frameworks

Yesterday

mglb added a comment to T10891: Breeze theme evolution.

Would it be possible in this evolution to explore more streamlined spin boxes? I have always felt, our current version mixes the control with the content and it would probably be cooler to have them look separate. Maybe more like this:

https://images.app.goo.gl/TmNs1cWBrH2oyiRc7

Or this

https://images.app.goo.gl/PLed1isQZcSMwGiE9

Tue, May 21, 11:58 PM · VDG, Breeze
davidedmundson updated the diff for D21328: Add qml import for KItemModels.

Sync copyright headers to existing style

Tue, May 21, 11:54 PM · Frameworks
davidedmundson updated the summary of D21328: Add qml import for KItemModels.
Tue, May 21, 11:50 PM · Frameworks
davidedmundson requested review of D21328: Add qml import for KItemModels.
Tue, May 21, 11:43 PM · Frameworks
apol added a comment to D21327: Support installing multiple Samba packages.

Hope this helps ^^'

Tue, May 21, 11:33 PM
apol added inline comments to D21326: Make limtedrowcountproxymodel usable from QML.
Tue, May 21, 11:23 PM · Plasma
feverfew updated the diff for D16648: Open externally called files/directories in new tabs.
  • Addressing code review comments
  • Adding back macro
  • Allow window activation without forceActiveWindow()
  • Avoiding duplication of tabs
  • Distributing URLs among all instances
  • Making ShowFolders/ShowItems also check if URLs are open in other tabs
  • Ensuring current instance is considered when needed
  • Removing unnecessary include
  • Overloading openFiles/openDirectories
  • Removing unnecessary new line
  • Amend test
  • Fixing header file
Tue, May 21, 11:12 PM · Dolphin
nicolasfella committed R225:8a2cc4a84145: remove unused ImagesHelper (authored by nicolasfella).
remove unused ImagesHelper
Tue, May 21, 10:51 PM
nibags added a comment to D20959: Allow to change the Mode, after changing the Highlighting.

errata: the setDontChangeHlOnSave() function has nothing to do here.
more time I upload a patch.

Tue, May 21, 10:50 PM · Frameworks, Kate
azurmendi committed R883:1542355: (aurretik: To-12, Tr-11, F-0, U-1) --> %100.
(aurretik: To-12, Tr-11, F-0, U-1) --> %100
Tue, May 21, 10:40 PM
azurmendi committed R883:1542354: (aurretik: To-12, Tr-11, F-0, U-1) --> %100.
(aurretik: To-12, Tr-11, F-0, U-1) --> %100
Tue, May 21, 10:40 PM
David Nelband <dnelband@gmail.com> committed R767:762ac934c048: pms fixes (authored by David Nelband <dnelband@gmail.com>).
pms fixes
Tue, May 21, 10:40 PM
aacid committed R340:4a42d1fb6149: Fix for memory leak in SessionManagerFixed (authored by hriesenbeck).
Fix for memory leak in SessionManagerFixed
Tue, May 21, 10:28 PM
aacid closed D17201: Fix for memory leak in SessionManagerFixed.
Tue, May 21, 10:28 PM · KDE Edu
aacid accepted D17201: Fix for memory leak in SessionManagerFixed.
Tue, May 21, 10:28 PM · KDE Edu
nicolasfella committed R225:a53bf9b1917c: Simplify condition (authored by nicolasfella).
Simplify condition
Tue, May 21, 10:24 PM
aacid committed R340:07fccf921ab8: Fix faulty number of new words counting (authored by hriesenbeck).
Fix faulty number of new words counting
Tue, May 21, 10:22 PM
aacid closed D17180: Fix faulty number of new words counting.
Tue, May 21, 10:22 PM · KDE Edu
aacid accepted D17180: Fix faulty number of new words counting.
Tue, May 21, 10:22 PM · KDE Edu
aacid added a comment to D17180: Fix faulty number of new words counting.

I'm not going to pretend i understand the code, but you wrote lots of unittests, so that's good, let's get this in :)

Tue, May 21, 10:22 PM · KDE Edu
azurmendi committed R883:1542353: (aurretik: To-480, Tr-436, F-34, U-10) --> %100.
(aurretik: To-480, Tr-436, F-34, U-10) --> %100
Tue, May 21, 10:20 PM
davidhurka added a comment to D21195: [RFC] Create a Change Colors menu (with toolbar button).

So I will keep it this way.

Tue, May 21, 10:17 PM · Okular
davidhurka updated the summary of D21195: [RFC] Create a Change Colors menu (with toolbar button).
Tue, May 21, 10:16 PM · Okular
lavender added a comment to T10046: Improve the colors, color consistency and colorscheme compatibility of Breeze.

This article on designing systemic colours (and comment) explores some of the challenges faced with designing color palettes. Example implementation in JS

Tue, May 21, 10:13 PM · KDE Human Interface Guidelines, VDG, Plasma, Breeze
ngraham added a comment to D21195: [RFC] Create a Change Colors menu (with toolbar button).

Their user interfaces are different; the selection button offers three different types of selections, but allows a click-and-don't-hold to activate the last one. I'm not the hugest fan of this UI; I would prefer three different buttons or a dropdown menu that opens on click-and-don't-hold. But there's no reason to emulate it since the UI you have here is different.

Tue, May 21, 9:57 PM · Okular
lsegovia added a comment to T10935: Need testing for WinInk tablet support.

The bugs Alvin reported are fixed in this version. As for item no. 4 in my previous comment, it only works if I use WinTab as the source API. Windows Ink still doesn't work.

Tue, May 21, 9:55 PM · Krita: Next Features (Needs Testing)
davidhurka added a comment to D21195: [RFC] Create a Change Colors menu (with toolbar button).

+1 for this. I think it makes sense. Trying it out, I like it a lot.

Tue, May 21, 9:53 PM · Okular
tusooaw added a comment to T10935: Need testing for WinInk tablet support.

I'm on Surface Pro 4/Windows 10 and everything goes well except for (2):

Tue, May 21, 9:52 PM · Krita: Next Features (Needs Testing)
aacid committed R883:1542352: put more kf5 stuff in front of kde4 stuff.
put more kf5 stuff in front of kde4 stuff
Tue, May 21, 9:36 PM
ngraham requested review of D21327: Support installing multiple Samba packages.
Tue, May 21, 9:35 PM
aacid committed R883:1542351: put the kf5 stuff in front of the kde4 stuff.
put the kf5 stuff in front of the kde4 stuff
Tue, May 21, 9:35 PM
filipf added a comment to D20585: [FormLayout] Use even top and bottom spacing for separator.
In D20585#465924, @mart wrote:

I don't like adding a new property to separator for doing duck typing...

even is really ugly and errorprone as well, but i would prefer
Layout.topMargin: item.toString().indexOf("Separator")===0 ? Kirigami.Units.smallSpacing : 0

with a comment:
// FIXME: use item instanceof Kirigami.Separator when we can depend from Qt 5.11

Tue, May 21, 9:34 PM · Kirigami
filipf updated the diff for D20585: [FormLayout] Use even top and bottom spacing for separator.

minor fix

Tue, May 21, 9:32 PM · Kirigami
nicolasfella committed R225:2d3b0e764110: Extract conversations from conversation notification style (authored by nicolasfella).
Extract conversations from conversation notification style
Tue, May 21, 9:32 PM
davidedmundson committed R244:6a686c28d386: Fix compliation for python bindings (authored by davidedmundson).
Fix compliation for python bindings
Tue, May 21, 9:32 PM
filipf updated the diff for D20585: [FormLayout] Use even top and bottom spacing for separator.

use mart's solution

Tue, May 21, 9:28 PM · Kirigami
dhaumann added a comment to D21287: Try to find always an unique visible document name without a number suffix.

There even is a bug report about this: https://bugs.kde.org/show_bug.cgi?id=381532
In this bug report, there is also an example of how sublime text handles this, namely "Document name - path/bla", i.e. the path is appended behind the document name. What about this solution?

Tue, May 21, 9:28 PM · Frameworks, Kate
davidedmundson requested review of D21326: Make limtedrowcountproxymodel usable from QML.
Tue, May 21, 9:27 PM · Plasma
patrickelectric committed R319:8ba91ade5518: template: check order before access (authored by patrickelectric).
template: check order before access
Tue, May 21, 9:24 PM
patrickelectric closed D21325: template: check order before access.
Tue, May 21, 9:24 PM · Konsole
aacid added a comment to D21202: Added basic JavaScript functions to support animated PDF.

Do you have some files that exercise this?

Who would we autotest this?

I intend to test this when all the functions needed to work are implemented.

Or would you like a test for every function?

Tue, May 21, 9:23 PM · Okular
tcanabrava accepted D21325: template: check order before access.
Tue, May 21, 9:21 PM · Konsole
patrickelectric added a reviewer for D21325: template: check order before access: tcanabrava.
Tue, May 21, 9:21 PM · Konsole
patrickelectric requested review of D21325: template: check order before access.
Tue, May 21, 9:21 PM · Konsole
filipf added a comment to D20972: [sidebar] Make search field not glued to the separator.

When anchors.margins is removed we see that the ToolButton still has 1px of its own margin around it

From what? Should they be there?

Tue, May 21, 9:19 PM · Plasma
patrickelectric abandoned D21324: Move from Qt foreach to C++11 for loop.

Closed because of: https://phabricator.kde.org/D21123

Tue, May 21, 9:17 PM · Konsole
ngraham committed R223:e971c67ce10d: Make selection scrolling go at 60 fps (authored by Kezi Olio <keziolio123@gmail.com>).
Make selection scrolling go at 60 fps
Tue, May 21, 9:15 PM
ngraham closed D20437: Make selection scrolling go at 60 fps.
Tue, May 21, 9:15 PM · Okular