Feed All Stories

Today

yurchor committed R412:7f19a159ffad: Use URLs with transport encryption (authored by yurchor).
Use URLs with transport encryption
Fri, Nov 15, 5:58 PM
felixernst added a comment to T11925: Breeze Desktop Theme Transparency.

Between opaqueness, blur, contrast and saturation it might be quite hard to figure out the best settings but this definitely already seems like a big step in the right direction to me. So many options!

Fri, Nov 15, 5:56 PM · VDG
ngraham requested changes to D25111: Implement KMessageWidget to report import errors..

Thanks again for the patch!

Fri, Nov 15, 5:53 PM · Gwenview
niccolove added a comment to T11925: Breeze Desktop Theme Transparency.

Why the bottom panel and tray popups have such a wierd color transition?



Fri, Nov 15, 5:52 PM · VDG
winterz added a comment to D25289: Read floating date time as LocalTime..

I will apply the patch locally and see what happens.

Fri, Nov 15, 5:51 PM · KDE PIM
cgilles committed R850:b3b9ba05f181: Update krazy static analyzer report digiKam-master-rev-04e9d01b67. See https… (authored by cgilles).
Update krazy static analyzer report digiKam-master-rev-04e9d01b67. See https…
Fri, Nov 15, 5:50 PM
cgilles committed R850:b45a2cec8ebd: update krazy static analyzer report digiKam-master-rev-04e9d01b67. (authored by cgilles).
update krazy static analyzer report digiKam-master-rev-04e9d01b67.
Fri, Nov 15, 5:50 PM
laissus committed R883:1556260: fr summit scatter.
fr summit scatter
Fri, Nov 15, 5:42 PM
laissus committed R883:1556259: fr summit merge.
fr summit merge
Fri, Nov 15, 5:37 PM
vkrause accepted D25330: Expose KNumberModel to QML.
Fri, Nov 15, 5:31 PM · Frameworks
frederico committed R883:1556258: Inclusão da verificação se o software Subversion está instalado no sistema..
Inclusão da verificação se o software Subversion está instalado no sistema.
Fri, Nov 15, 5:25 PM
ngraham added a comment to T12040: "Resolution Dependent" cursor setting: fix it or delete it?.

We changed that to make specific values effectively be the default font anti-aliasing settings, for similar reasons (it was buggy and confusing). Could we do the same thing for the Cursors KCM?

Fri, Nov 15, 5:22 PM · KWin
ognarb accepted D25116: Changed the order of initialization for the statistics window..

The change looks good. I will merge it tomorrow if nobody complains :)

Fri, Nov 15, 5:21 PM · KDE Edu
vkrause committed R1032:e14767d73908: Add network configurations for Luxembourg and Austria (authored by vkrause).
Add network configurations for Luxembourg and Austria
Fri, Nov 15, 5:18 PM
vkrause committed R1032:d52f50efab35: Allow to specify additional Hafas authentication parameters (authored by vkrause).
Allow to specify additional Hafas authentication parameters
Fri, Nov 15, 5:18 PM
aacid added a comment to T12002: Create branch for 19.12 releases.

That's part of releasing not of branching

Fri, Nov 15, 5:11 PM
ngraham added a comment to T11925: Breeze Desktop Theme Transparency.

LGTM. Honestly I don't think I would even notice the changes if they weren't pointed out to me. I think these kinds of really subtle changes are likely to go un-noticed by most people, for better or worse.

Fri, Nov 15, 5:10 PM · VDG
cgilles committed R850:0d6e889a529e: Update clang static analyzer report digiKam-master-rev-04e9d01b67. See https… (authored by cgilles).
Update clang static analyzer report digiKam-master-rev-04e9d01b67. See https…
Fri, Nov 15, 5:03 PM
cgilles committed R850:bbe8c4b75fa7: update clang static analyzer report digiKam-master-rev-04e9d01b67. (authored by cgilles).
update clang static analyzer report digiKam-master-rev-04e9d01b67.
Fri, Nov 15, 5:03 PM
siyuandong committed R767:19584ae5ab1b: related (authored by siyuandong).
related
Fri, Nov 15, 5:02 PM
KonqiDragon added a comment to T11925: Breeze Desktop Theme Transparency.

Those screenshots look pretty good to me. I might prefer a liiiiiiitle bit less of the background showing through, like maybe only 0.25, not 0.3. But it looks good, I'll admit.

.25 (using the shadows from the other patch, btw):





But I would suggest that you try it yourself on an actual machine. The screenshots (unless you display them fullscreen, I guess) make the effect appear stronger than it actually is. If you go ahead and try even contrast=0.4 out, you will see that it's not that crazy at all, and really pretty. Also, if you don't want the background to show less, I think that could also be helped by having a stronger blur, which will make the blurred area look like they are simply a gradient opaque background rather than the background showing through. Right now I'm using the highest blur that the desktop effect setting allows me, but there should be a way to change the maximum value. Finally, it's also possible to lower the saturation desktop effect to avoid giving the idea of desktop effect showing through.

Also keep in mind that the text color is global. Last time I increased the darkness of the text, people complained that the contrast would be too stark for apps that have text over a white/off-white background, such as document readers. Now history has proven them wrong since I have not seen a single complaint about the change (to the contrary, I have received multiple comments to the effect that it was a positive change) since it was done almost two years ago IIRC, but it's something that will come up if we propose making the text pure black.

I think that the fact that users did not complain shows that's not a problem to make the text black. Alternatively, the text could made to something like #131416.

The contrast effect is user-configurable

Is it? I'm unable to change it via SySe, only by editing the desktop theme metadata file.

Oh, by the way, keep in mind that a .2 => .25 change is similiar to changing the transparency from 10% to 12.5%, which is just slightly noticeable. I'm more a fan of .3/.4, but most users won't even notice moving to .25.

Fri, Nov 15, 4:56 PM · VDG
laane committed R883:1556257: asju juurde.
asju juurde
Fri, Nov 15, 4:44 PM
siyuandong committed R767:d505de64d838: related (authored by siyuandong).
related
Fri, Nov 15, 4:41 PM
niccolove added a comment to T11925: Breeze Desktop Theme Transparency.

Those screenshots look pretty good to me. I might prefer a liiiiiiitle bit less of the background showing through, like maybe only 0.25, not 0.3. But it looks good, I'll admit.

Fri, Nov 15, 4:37 PM · VDG
alvarenga committed R883:1556256: Update pt_BR translations.
Update pt_BR translations
Fri, Nov 15, 4:36 PM
alvarenga committed R883:1556255: Update pt_BR translations.
Update pt_BR translations
Fri, Nov 15, 4:36 PM
anthonyfieroni added inline comments to D25308: when kioslave5 couldn't be found in libexec-ish locations try $PATH.
Fri, Nov 15, 4:35 PM · Frameworks
alvarenga committed R883:1556254: Update pt_BR translations.
Update pt_BR translations
Fri, Nov 15, 4:28 PM
jjorge added a comment to D25018: Move ACPI battery information from /proc/acpi to /sys.

Do you have a developer account to push the changes? Otherwise I can do that for you.

Fri, Nov 15, 4:25 PM · Plasma
dkardarakos committed R169:55cd76337897: Fix cmake project command position (authored by dkardarakos).
Fix cmake project command position
Fri, Nov 15, 4:22 PM
dkardarakos closed D25327: Fix cmake project command position.
Fri, Nov 15, 4:22 PM · Kirigami
pelcak committed R883:1556253: Update of Summit.
Update of Summit
Fri, Nov 15, 4:21 PM
siyuandong committed R767:44b33e6a09c7: related (authored by siyuandong).
related
Fri, Nov 15, 4:14 PM
sander committed R223:51b90ecd73e3: Add kinetic scrolling & smooth navigation with cursor keys (authored by kezik).
Add kinetic scrolling & smooth navigation with cursor keys
Fri, Nov 15, 4:08 PM
alvarenga committed R883:1556252: Update pt_BR translations.
Update pt_BR translations
Fri, Nov 15, 4:05 PM
siyuandong committed R767:cc87f785a35f: related (authored by siyuandong).
related
Fri, Nov 15, 4:00 PM
davidedmundson requested review of D25331: Duplicate QML installation for unit tests.
Fri, Nov 15, 3:59 PM · Frameworks
ngraham updated the diff for D25296: [RFC] Fix Display Configuration icon margins.
  • Fix stylesheet and color-changing ability
  • Vertical lines still blurry; not sure why
Fri, Nov 15, 3:57 PM · Frameworks
siyuandong committed R767:27c46b7e78d0: Merge branch 'master' of git://anongit.kde.org/ocs-webserver (authored by siyuandong).
Merge branch 'master' of git://anongit.kde.org/ocs-webserver
Fri, Nov 15, 3:45 PM
siyuandong committed R767:1497c4d51f02: related (authored by siyuandong).
related
Fri, Nov 15, 3:45 PM
davidedmundson committed R304:0099d090be51: Correctly set i18n arguments in one pass (authored by davidedmundson).
Correctly set i18n arguments in one pass
Fri, Nov 15, 3:42 PM
davidedmundson closed D25270: Correctly set i18n arguments in one pass.
Fri, Nov 15, 3:42 PM · Frameworks
davidedmundson requested review of D25330: Expose KNumberModel to QML.
Fri, Nov 15, 3:42 PM · Frameworks
davidedmundson committed R275:4b1e1b44ef9f: Add new class that is a model of numbers between two values (authored by davidedmundson).
Add new class that is a model of numbers between two values
Fri, Nov 15, 3:40 PM
davidedmundson closed D13358: Add new class that is a model of numbers between two values.
Fri, Nov 15, 3:40 PM · Frameworks
ognarb updated subscribers of T12043: Kubuntu Laptop Promotion Project.

Suscribing KDE Promo ;)

Fri, Nov 15, 3:40 PM · Kubuntu
pelcak committed R883:1556251: Update of Summit.
Update of Summit
Fri, Nov 15, 3:39 PM
mpolicht committed R1036:67f9cf25588c: Merge branch 'master' of invent.kde.org:kde/cutehmi (authored by mpolicht).
Merge branch 'master' of invent.kde.org:kde/cutehmi
Fri, Nov 15, 3:36 PM
mpolicht committed R1036:7af5f0cae0a7: Use relative paths for type entries and provide 'exclude' property. (authored by mpolicht).
Use relative paths for type entries and provide 'exclude' property.
Fri, Nov 15, 3:36 PM
mutlaqja added a comment to D25318: Update the auto-stretch scheme and UI.

This is great thanks! It fails to compile:

Fri, Nov 15, 3:35 PM · KDE Edu
apol accepted D25327: Fix cmake project command position.
Fri, Nov 15, 3:35 PM · Kirigami
dvratil committed R665:25f880240983: Properly publicize and document waitForCompletion() (authored by dvratil).
Properly publicize and document waitForCompletion()
Fri, Nov 15, 3:32 PM
dvratil committed R665:4643e13d6358: Remove unused traits, inline others (authored by dvratil).
Remove unused traits, inline others
Fri, Nov 15, 3:32 PM
dvratil committed R665:e2bff63a76ed: Clean up bits of job_impl (authored by dvratil).
Clean up bits of job_impl
Fri, Nov 15, 3:32 PM
dvratil committed R665:5e224f0178c1: Inline async.cpp into job_impl.h (authored by dvratil).
Inline async.cpp into job_impl.h
Fri, Nov 15, 3:32 PM
apol accepted D25270: Correctly set i18n arguments in one pass.
Fri, Nov 15, 3:31 PM · Frameworks
trufanov committed R472:f8358c81d1b2: Fix KIO errors text formatting (authored by trufanov).
Fix KIO errors text formatting
Fri, Nov 15, 3:31 PM
trufanov closed D25329: Fix KIO errors text formatting.
Fri, Nov 15, 3:31 PM
apol accepted D25308: when kioslave5 couldn't be found in libexec-ish locations try $PATH.
Fri, Nov 15, 3:30 PM · Frameworks
mutlaqja committed R321:34ffb6db5bc7: Disable the move to polar message action and just display it as a message… (authored by mutlaqja).
Disable the move to polar message action and just display it as a message…
Fri, Nov 15, 3:29 PM
tymond triaged T12044: Tagging rewrite as High priority.
Fri, Nov 15, 3:25 PM · Krita: Abyss
apol added inline comments to D25265: Support adding a contact to a specific backend.
Fri, Nov 15, 3:19 PM · Frameworks
stikonas accepted D25329: Fix KIO errors text formatting.

Looks good

Fri, Nov 15, 3:18 PM
vkrause added a comment to D25311: Add KColumnHeadersProxyModel.

I'm wondering if this is technically a proxy model, or rather a QAbstractListModel? Its content is not representing cells in the source model after all, which mapTo/FromSource assumes I think.

Yeah I'm not entirely sure. If it was possible I would probably have based this on QTransposeProxyModel, but that is Qt 5.13+ stuff.

Fri, Nov 15, 3:18 PM · Frameworks
davidedmundson added inline comments to D22684: [Klipper] Fix clipboard history management.
Fri, Nov 15, 3:13 PM · Plasma
trufanov requested review of D25329: Fix KIO errors text formatting.
Fri, Nov 15, 3:12 PM
rempt committed R37:2bfce87d6add: Add API for managing tags to KisTagModel (authored by rempt).
Add API for managing tags to KisTagModel
Fri, Nov 15, 3:12 PM
alvarenga committed R883:1556250: Update pt_BR translations.
Update pt_BR translations
Fri, Nov 15, 3:09 PM
alvarenga committed R883:1556249: Update pt_BR translations.
Update pt_BR translations
Fri, Nov 15, 3:09 PM
kossebau added a comment to D25323: [text thumbnail] Force Syntax Highligthing when no definition for file was found.

Thanks for looking at the issue. No time to look closer the next days, but curious about this partial change (which has been discussed before and discarded):
changing QColor ( 245, 245, 245 ); // light-grey background to highlightingTheme.editorColor(KSyntaxHighlighting::Theme::EditorColorRole::BackgroundColor) implies, one cannot use KSyntaxHighlighting to render text highlighted e.g. for a print-out on a paper (or only for a PDF). Compare e.g. the example https://phabricator.kde.org/source/syntax-highlighting/browse/master/examples/codepdfprinter/.

I don't think it implies this, and I don't see the point here, textCreator makes thumbnails for text files only anyway.
The change is just so that the background follows the user theme and avoids an hardcoded value that is not good practice.

Fri, Nov 15, 3:00 PM · Frameworks, Dolphin
alvarenga committed R883:1556248: Update pt_BR translations.
Update pt_BR translations
Fri, Nov 15, 2:57 PM
alvarenga committed R883:1556247: Update pt_BR translations.
Update pt_BR translations
Fri, Nov 15, 2:57 PM
ngraham added inline comments to D22684: [Klipper] Fix clipboard history management.
Fri, Nov 15, 2:54 PM · Plasma
ahiemstra added a comment to D25311: Add KColumnHeadersProxyModel.

We should probably have a unit test, even if it just covers the basic case.

Fri, Nov 15, 2:54 PM · Frameworks
ngraham added a reviewer for D25280: [Baloo KCM] Purge index when disabling indexing: VDG.
Fri, Nov 15, 2:51 PM · Plasma
ngraham updated the test plan for D25280: [Baloo KCM] Purge index when disabling indexing.
Fri, Nov 15, 2:51 PM · Plasma
ngraham updated the diff for D25280: [Baloo KCM] Purge index when disabling indexing.

Improve string

Fri, Nov 15, 2:49 PM · Plasma
ahiemstra updated the diff for D25311: Add KColumnHeadersProxyModel.
  • Add a unit test for KColumnHeadersProxyModel
Fri, Nov 15, 2:46 PM · Frameworks
ahiemstra updated the diff for D25311: Add KColumnHeadersProxyModel.
  • Forward column change singals as row change signals
  • Forward header data change signals as dataChanged
  • Add a unit test for KColumnHeadersProxyModel
Fri, Nov 15, 2:43 PM · Frameworks
ronaldv committed R767:ef8b8bb02947: imprint (authored by ronaldv).
imprint
Fri, Nov 15, 2:42 PM
ngraham added a comment to D25015: Update breeze theme shadows.

What do you think of:

Fri, Nov 15, 2:41 PM · Frameworks
ngraham added a comment to D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before.

Hmm, reading the code more closely, it looks like it should already work. In fact, when I remove all my changes... it does work! I could have sworn that it didn't work before though.

Fri, Nov 15, 2:41 PM · Plasma
ronaldv committed R767:7219d4277db3: imprint (authored by ronaldv).
imprint
Fri, Nov 15, 2:37 PM
davidedmundson accepted D25290: KCM launchfeedback : port to KConfig XT.
Fri, Nov 15, 2:32 PM · Plasma
cgilles committed R850:8eabdcc253dc: Update cppcheck static analyzer report digiKam-master-rev-04e9d01b67. See https… (authored by cgilles).
Update cppcheck static analyzer report digiKam-master-rev-04e9d01b67. See https…
Fri, Nov 15, 2:30 PM
cgilles committed R850:ae5c29d9578c: update cppcheck static analyzer report digiKam-master-rev-04e9d01b67. (authored by cgilles).
update cppcheck static analyzer report digiKam-master-rev-04e9d01b67.
Fri, Nov 15, 2:30 PM
ricktimmis updated the task description for T12043: Kubuntu Laptop Promotion Project.
Fri, Nov 15, 2:30 PM · Kubuntu
camilo higuita <milo.h@aol.com> committed R899:f55f49453f1f: add windows files (authored by camilo higuita <milo.h@aol.com>).
add windows files
Fri, Nov 15, 2:30 PM
camilo higuita <milo.h@aol.com> committed R899:69d0616ae720: Merge branch 'dev-win32-wip' of https://invent.kde.org/kde/vvave into dev-win32… (authored by camilo higuita <milo.h@aol.com>).
Merge branch 'dev-win32-wip' of https://invent.kde.org/kde/vvave into dev-win32…
Fri, Nov 15, 2:30 PM
cgilles committed R482:04e9d01b6720: cppcheck++ (authored by cgilles).
cppcheck++
Fri, Nov 15, 2:21 PM
aspotashev added a comment to D25319: Fix issues from D24798 comments by @davidedmundson.

toFixed() makes decimal separator always a point, thus not localizable. We need something else to support point or comma depending on the locale.

Fri, Nov 15, 2:18 PM · Plasma
ricktimmis triaged T12043: Kubuntu Laptop Promotion Project as Normal priority.
Fri, Nov 15, 2:17 PM · Kubuntu
niccolove added a comment to D25015: Update breeze theme shadows.

This is what you think ends too early (for comparison):


What do you think of:

Fri, Nov 15, 2:16 PM · Frameworks
cgilles committed R482:9c690f0f8f66: cppcheck++ (authored by cgilles).
cppcheck++
Fri, Nov 15, 2:12 PM
camiloh committed R1019:329b95bdc8f9: add kquicksyntaxhighligher sources until they are officially released into some… (authored by camiloh).
add kquicksyntaxhighligher sources until they are officially released into some…
Fri, Nov 15, 2:12 PM
meven updated the summary of D25323: [text thumbnail] Force Syntax Highligthing when no definition for file was found.
Fri, Nov 15, 2:10 PM · Frameworks, Dolphin
meven added a comment to D25323: [text thumbnail] Force Syntax Highligthing when no definition for file was found.

Thanks for looking at the issue. No time to look closer the next days, but curious about this partial change (which has been discussed before and discarded):
changing QColor ( 245, 245, 245 ); // light-grey background to highlightingTheme.editorColor(KSyntaxHighlighting::Theme::EditorColorRole::BackgroundColor) implies, one cannot use KSyntaxHighlighting to render text highlighted e.g. for a print-out on a paper (or only for a PDF). Compare e.g. the example https://phabricator.kde.org/source/syntax-highlighting/browse/master/examples/codepdfprinter/.

Fri, Nov 15, 2:10 PM · Frameworks, Dolphin
davidedmundson committed R108:c22546868d75: [effects] fix mouse wheel detection (authored by davidedmundson).
[effects] fix mouse wheel detection
Fri, Nov 15, 2:10 PM
camiloh committed R899:6e71fd5a6696: fixes on some basic properties for main playlist and fix issue with taglib file… (authored by camiloh).
fixes on some basic properties for main playlist and fix issue with taglib file…
Fri, Nov 15, 2:09 PM
meven updated the test plan for D25328: Always rehiglhight() after definition was changed.
Fri, Nov 15, 2:09 PM · Frameworks, Kate