- User Since
- Apr 15 2017, 7:18 PM (122 w, 5 d)
Don't use width: and height: on items in a Layout
Abandoning in favor of the vastly superior D23357.
Yeah, this is my fault, sorry. I only recently learned that setting height and width directly on items in layouts is a bad idea. Feel free to fix other occurrences too with no review.
What happens when this is set but the view isn't an expandable tree view?
Yup. I was going to do this but you beat me to it. :)
Yes, @davidre is amazing.
Probably best to get this in rather than making it perfect first. Iteration can come later.
So much better!
followDirectories() seems somewhat ambiguous to me. How about the old one, or else, openNewlyCreatedDirectories()?
+1, but you need to add @since 5.62 to the new public functions.
Do you need someone to commit this for you? If so, can you please provide an email address?
LGTM, just fix the whitespace issue
Just wanted to chime in and say that this is looking super-great!
That looks fantastic to me!
So this is a complaint that comes up a lot. I do see what you mean, and in my opinion, what we need is a dual-mode size control UI that lets you switch between "scale icons to fit in panel", "static icon size", and "n columns". However we don't have a UI that implements this. I would be happy to entertain a patch that added that though.
The text "change password" is not accurate when you're setting up a new user. For that case, it should say "set password". But the new user creation process is really weird and needs to be redone anyway, so maybe that's the better approach.
Looks to me that scaling is working just fine for system tray items in your screenshot. It's deliberate that they have that much padding on the top and bottom (at least with the default size settings).
The label says:
On high DPI systems those values would be scaled up, depending on the DPI
Thanks, this looks so much nicer now!
Wed, Aug 21
Actually I was envisioning something even simpler:
It works perfectly. Nicely done. The circle sizes seem just right, too.
Is redshift -P -O fully backwards-compatible with older versions of redshift? If not, then this will just break everyone not using >=1.12.
IIRC the objection was that making press-and-hold always mean right-click at the toolkit level could interfere with apps that want to re-implement the press-and-hold behavior for some other behavior. For example a lot of Android apps use press-and-hold to mean "make this list/view editable".
All right, hopefully the third time's the charm: D23328
You assume far too much competance on my part :)
Needs a rebase
And finally, it would be nice to display the text + progress indicator in the center of the view, not at the very top.
Also hide the placeholder icon while the progress indicator is visible so this doesn't happen:
Oh good. :) Is there anywhere I can follow the progress?
In testing it out, I really like it! I might even make the handles a bit larger for more touch-friendliness. Not a lot larger, just a bit.
There we go, much better. Congrats on the nice big patch landed!
Thanks for the patch! There are some formatting and whitespace issues here; could you fix those up first?
Adjust to the fact that the Switch user button is always visible now
Remove unnecessary X-AppStream-Ignore property
Yep, according to @mak, this should work.
Haha that pink might be a bit too un-brutalist. :) Orange-on-pink isn't exactly the best color combination. A blue background of some sort might be nicer with the orange polygon.
Looks like you have some non-UNIX line endings that our commit hookscript complains about when I try to land the patch:
Very nice work.
After living with this for a bit, I feel like maybe the following UI changes might be good to make the effect a bit more subtle:
- Reduce the opacity of the gray background bit so the header doesn't feel like "a hole in the view"
- Experiment with removing or reducing the strength of the horizontal line separators above and below the header text
Better, thanks! Any chance you could make the gray background color a bit different? Maybe lighter, or some other color? That particular gray isn't a very attractive color IMO. It's very brutalist. :)