- User Since
- Apr 15 2017, 7:18 PM (122 w, 4 d)
The text "change password" is not accurate when you're setting up a new user. For that case, it should say "set password". But the new user creation process is really weird and needs to be redone anyway, so maybe that's the better approach.
Looks to me that scaling is working just fine for system tray items in your screenshot. It's deliberate that they have that much padding on the top and bottom (at least with the default size settings).
The label says:
On high DPI systems those values would be scaled up, depending on the DPI
Thanks, this looks so much nicer now!
Actually I was envisioning something even simpler:
It works perfectly. Nicely done. The circle sizes seem just right, too.
Is redshift -P -O fully backwards-compatible with older versions of redshift? If not, then this will just break everyone not using >=1.12.
IIRC the objection was that making press-and-hold always mean right-click at the toolkit level could interfere with apps that want to re-implement the press-and-hold behavior for some other behavior. For example a lot of Android apps use press-and-hold to mean "make this list/view editable".
All right, hopefully the third time's the charm: D23328
You assume far too much competance on my part :)
Needs a rebase
And finally, it would be nice to display the text + progress indicator in the center of the view, not at the very top.
Also hide the placeholder icon while the progress indicator is visible so this doesn't happen:
Oh good. :) Is there anywhere I can follow the progress?
In testing it out, I really like it! I might even make the handles a bit larger for more touch-friendliness. Not a lot larger, just a bit.
There we go, much better. Congrats on the nice big patch landed!
Thanks for the patch! There are some formatting and whitespace issues here; could you fix those up first?
Adjust to the fact that the Switch user button is always visible now
Remove unnecessary X-AppStream-Ignore property
Yep, according to @mak, this should work.
Haha that pink might be a bit too un-brutalist. :) Orange-on-pink isn't exactly the best color combination. A blue background of some sort might be nicer with the orange polygon.
Looks like you have some non-UNIX line endings that our commit hookscript complains about when I try to land the patch:
Very nice work.
After living with this for a bit, I feel like maybe the following UI changes might be good to make the effect a bit more subtle:
- Reduce the opacity of the gray background bit so the header doesn't feel like "a hole in the view"
- Experiment with removing or reducing the strength of the horizontal line separators above and below the header text
Better, thanks! Any chance you could make the gray background color a bit different? Maybe lighter, or some other color? That particular gray isn't a very attractive color IMO. It's very brutalist. :)
Tue, Aug 20
Re-add other conditions
No, you're right, those should still be there.
Always show the button
Add project_group and compulsory_for_desktop tags
@mak The link https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-compulsory_for_desktop seems broken. I found a reference to compulsory_for_desktop at https://www.freedesktop.org/software/appstream/docs/chap-CollectionData.html, but it points to a nonexistent page.
Then there are multiple sessions because you're already logged-in, so the button will be visible and you'll be able to get to your session. Or are you thinking with a multi-user system where user A logs in and locks the screen, and then user B wants to log in? Hmm.
In fact there are three possible relationships:
- App is associated with desktop, but not required by it or limited to it (e.g. Dolphin, Gwenview, Nautilus, GNOME Music)
- App requires desktop (e.g. KDE System Settings, GNOME System Settings, GNOME Tweaks)
- Desktop requires app (e.g. KDE System Settings, GNOME System Settings)
Add <provides> tag so searching for it from the old URLs still works
Thanks for the into @mak, that's very helpful. I've removed one of the launchable tags since only one .desktop file has the info that you would want to use to launch it as a KDE user. And I've added X-AppStream-Ignore=true to one of the .desktop files.
Adjust according to review comments
Change "rainshowers" to "rain showers" ("rainshower" isn't a word)
Interesting design! However having that triangular part jutting out of the side is pretty unusual, and not seen in any other MimeType icons. Maybe move that shape fully inside and copy the visual style of existing book-style icons, such as application-pdf application-epub+zip . Generally they have a sort of book-like appearance with a line on the left side for the book's spine.
Abandoning in favor of D23306, which adds an AppStream metadata file with multiple launchable tags. If I'm reading the docs right, this should allow the information from the referenced .desktop files to NOT be merged into the data from the appdata.xml file, which, if it works, should be the right approach for KDevelop too. Hopefully @mak will chime in regarding whether this is accurate or not.
Those are excellent questions. Reading through https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html, it seems like .desktop files only get parsed if there's no appdata.xml file--which indeed, System Settings lacks. Maybe that's the right approach here...
If there's a way to show an actual progress indicator in a way that ensures its accuracy, that would be much better, yeah. I'll be happy to abandon this patch if you can do that (I don't know how, sorry).