ngraham (Nathaniel Graham)
User

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2017, 7:18 PM (104 w, 6 d)
Availability
Available

Recent Activity

Today

ngraham added a comment to D16138: Create the default profile if it doesn't exist.

If we wanted a default profile, it would be better to just ship one.

Sat, Apr 20, 2:09 AM · Konsole

Yesterday

ngraham planned changes to D20689: Elide tab titles left so key information at the end of the string doesn't get cut off.

Yeah, that makes sense. I'll make it only elide left when showing the full path.

Fri, Apr 19, 4:46 PM · Dolphin
ngraham requested review of D20689: Elide tab titles left so key information at the end of the string doesn't get cut off.
Fri, Apr 19, 4:29 PM · Dolphin
ngraham added a comment to D19011: Thunderbolt KCM and KDED module.

New icon just landed in D20672. The name is preferences-desktop-thunderbolt.

Fri, Apr 19, 3:52 PM · Plasma
ngraham added a comment to D20301: Ensure to add a trailing / at the end of fstab mounted devices..

I've been told that @bruns can review this sometime next week. :)

Fri, Apr 19, 2:39 PM · Frameworks
ngraham added inline comments to D20533: Display a shortcut to the kcm Energy Information from the battery applet context menu.
Fri, Apr 19, 2:39 PM · Plasma
ngraham accepted D20672: Add an icon for Thunderbolt KCM.

Wow, that's quite beautiful. Thumbs up from me now!

Fri, Apr 19, 2:36 PM · Frameworks
ngraham updated subscribers of D20672: Add an icon for Thunderbolt KCM.

+1. @ndavis, @GB_2, or @filipf, any thoughts on this version?

Fri, Apr 19, 4:52 AM · Frameworks
ngraham added a comment to D20679: Hide unfinished vector pattern fill feature.

If you tag VDG, it's nice to add screenshots. :)

Fri, Apr 19, 4:49 AM · Krita
ngraham committed R370:c3a2dd14f88f: Give the Solid action a more descriptive name (authored by ngraham).
Give the Solid action a more descriptive name
Fri, Apr 19, 4:44 AM
ngraham added a comment to T10812: KDE Applications.

Yes, we have been trying hard, but did we succeed? Would someone just stop using Okular, because it is shipped with the Plasma bundle instead of the KDE Applications bundle?

I fear it will happen, yes.

Fri, Apr 19, 12:39 AM

Thu, Apr 18

ngraham accepted D20676: [Kickoff] Make the tabbar separator width consistent with tab selection line.
Thu, Apr 18, 11:03 PM · Plasma
ngraham accepted D20675: LoadingPage: Use Kirigami.Heading.

And we also need to give this page a spinner, just like the Updates page has.

Thu, Apr 18, 10:08 PM · Plasma
ngraham added a comment to T10812: KDE Applications.

If you are asking for my personal opinion, I propose to split current KDE Applications into parts:

  • Base/essential applications (Dolphin, Ark, KCharSelect, KCalc, Kate/KWrite, Konsole, Spectacle, Gwenview, Okular, thumbnailers, more?). Ship them together with Plasma[1]. I really love the Fibonacci release cycles of Plasma for bug fixes. Also, Plasma developers sometimes decide to do an LTS release, and the base applications would also benefit from LTS support. All of them should use the same 5.x (later 6.x) version number.
Thu, Apr 18, 10:06 PM
ngraham accepted D20674: Word wrap "No backends found" error message.
Thu, Apr 18, 9:47 PM · Plasma
ngraham added a comment to T10812: KDE Applications.

No, we just need to get users away from bad distros.

Thu, Apr 18, 9:47 PM
ngraham accepted D17936: Rewrite the front-end of docs.kde.org.

Looks fantastic visually!

Thu, Apr 18, 9:08 PM · VDG, Documentation
ngraham committed R241:f8328c008e01: [Properties dialog] Use the string "Free space" instead of "Disk usage" (authored by ngraham).
[Properties dialog] Use the string "Free space" instead of "Disk usage"
Thu, Apr 18, 9:05 PM
ngraham closed D20673: [Properties dialog] Use the string "Free space" instead of "Disk usage".
Thu, Apr 18, 9:05 PM · Frameworks
ngraham updated the test plan for D20612: [Kickoff] Modernize settings window layout.
Thu, Apr 18, 9:04 PM · Plasma
ngraham updated the diff for D20612: [Kickoff] Modernize settings window layout.

largeSpacing -> smallSpacing

Thu, Apr 18, 9:04 PM · Plasma
ngraham added inline comments to D20612: [Kickoff] Modernize settings window layout.
Thu, Apr 18, 9:03 PM · Plasma
ngraham added a comment to T10812: KDE Applications.

Apps that are in the bundle have inconsistent versioning; most use the bundle's own versioning scheme, but others use their own

I personally disagree this is a problem. It let's applications hop on and off the release and keep their versioning number intact.

Thu, Apr 18, 8:45 PM
ngraham added a comment to D20672: Add an icon for Thunderbolt KCM.

Even better! I think that gradient ends up a bit too light on top though. Let's make it a bit more subtle.

Thu, Apr 18, 8:21 PM · Frameworks
ngraham accepted D20668: [InformationPanel] Remove obsolete intermediate wrapper widget/layout The Baloo::MetaDataWidget is now able to stretch in a meaningful way by itself, remove the wrapper..
Thu, Apr 18, 7:56 PM · Dolphin
ngraham accepted D20667: Make the FileMetadataWidget stretch vertically in a sensible way.
Thu, Apr 18, 7:55 PM · Baloo
ngraham accepted D20524: [FileMetaDataWidget] Allow inline configuration of visible properties.
Thu, Apr 18, 7:54 PM · Baloo
ngraham added a comment to D20672: Add an icon for Thunderbolt KCM.

Ooh, I like that! Maybe make the thunderbolt a bit smaller inside the circle though?

Thu, Apr 18, 7:49 PM · Frameworks
ngraham closed T10755: Unifying Applications' release versions as Invalid.

From this discussion as well as comments in #kde-devel and elsewhere, it seems like there's a deeper issue: dissatisfaction with how the KDE Applications bundle is handled. The question of "what should apps' version numbers be?" seems impossible to even discuss properly before we've resolved people's concerns with the bundle. Let's break that out into a new discussion.

Thu, Apr 18, 7:43 PM
ngraham created T10812: KDE Applications.
Thu, Apr 18, 7:43 PM
ngraham committed R318:546ff9a19e17: Merge branch 'Applications/19.04' (authored by ngraham).
Merge branch 'Applications/19.04'
Thu, Apr 18, 7:17 PM
ngraham added a comment to D16005: Add test cases for enabled status of DolphinNewFileMenu.

Fixed that in D20664.

Thu, Apr 18, 7:17 PM · Dolphin
ngraham committed R318:48c082767e31: Fix adding "Create New..." menu to toolbar (authored by ngraham).
Fix adding "Create New..." menu to toolbar
Thu, Apr 18, 7:17 PM
ngraham closed D20664: Fix adding "Create New..." menu to toolbar.
Thu, Apr 18, 7:17 PM · Dolphin
ngraham requested review of D20673: [Properties dialog] Use the string "Free space" instead of "Disk usage".
Thu, Apr 18, 7:03 PM · Frameworks
ngraham added a comment to D20672: Add an icon for Thunderbolt KCM.

Thanks! Generally we use colorful icons for KCMs. I think this could use a bit more pizazz. :) Maybe make it yellow, and/or put it on top of a circular colored background or something?

Thu, Apr 18, 6:53 PM · Frameworks
ngraham added a reviewer for D20672: Add an icon for Thunderbolt KCM: VDG.
Thu, Apr 18, 6:51 PM · Frameworks
ngraham added a comment to D19011: Thunderbolt KCM and KDED module.

Submit it in a patch to breeze-icons! :)

Thu, Apr 18, 6:37 PM · Plasma
ngraham added a comment to D17105: Add a new lookandfeel runner.
In D17105#452140, @apol wrote:

Maybe what would make sense is to define an alternative Look and Feel theme for every theme, and have Breeze dark point at Breeze and vice-versa. This could then be easily toggled then from a keyboard or using fancy hardware.

Thu, Apr 18, 6:36 PM · Plasma
ngraham committed R255:8847e836f168: Fix enqueue operations on double-click and keyboard selection for tracks (authored by ngraham).
Fix enqueue operations on double-click and keyboard selection for tracks
Thu, Apr 18, 5:46 PM
ngraham updated the test plan for D20612: [Kickoff] Modernize settings window layout.
Thu, Apr 18, 4:30 PM · Plasma
ngraham updated the diff for D20612: [Kickoff] Modernize settings window layout.
  • Fix button height issue
  • Add padding between sections
  • Add vertical spacing between button categories
  • Rename to "General" and use appropriate icon
Thu, Apr 18, 4:30 PM · Plasma
ngraham added a comment to D20670: automatically hide undo notification 3 seconds after it has been shown.

Thanks for this!

Thu, Apr 18, 4:22 PM
ngraham added a comment to D20659: Copy container in Component::cleanUp before interating.

Did this fix https://bugs.kde.org/show_bug.cgi?id=406642?

Thu, Apr 18, 3:48 PM · Frameworks
ngraham accepted D20619: [balooctl] Use new helper in json output.
Thu, Apr 18, 3:30 PM · Baloo, Frameworks
ngraham accepted D20620: [balooctl] Switch multiline output to new helper.
Thu, Apr 18, 3:30 PM · Baloo, Frameworks
ngraham accepted D20650: Don't set Breeze as icon theme.
Thu, Apr 18, 3:29 PM
ngraham updated the test plan for D20581: Revamp grid browser delegates to improve UI.
Thu, Apr 18, 3:28 PM
ngraham updated the diff for D20581: Revamp grid browser delegates to improve UI.

Revert single/double-click changes

Thu, Apr 18, 3:27 PM
ngraham abandoned D20283: [RFC] [SimpleKCM] Fix height calculation.

@mart did this in the correct way instead!

Thu, Apr 18, 3:00 PM · Frameworks
ngraham accepted D20665: use the base implementation hints.

+1 shipit!

Thu, Apr 18, 2:50 PM · Frameworks
ngraham updated the summary of D20665: use the base implementation hints.
Thu, Apr 18, 2:48 PM · Frameworks
ngraham added a comment to D20581: Revamp grid browser delegates to improve UI.

I can split the diff to remove the click changes, sure.

Thu, Apr 18, 2:04 PM
ngraham added a comment to D20650: Don't set Breeze as icon theme.

Does this app always have to run as root? If so, that would be why that code is in there. If not, then yeah, it's superfluous now.

Thu, Apr 18, 1:56 PM
ngraham requested review of D20664: Fix adding "Create New..." menu to toolbar.
Thu, Apr 18, 1:46 PM · Dolphin

Wed, Apr 17

ngraham added a comment to D16005: Add test cases for enabled status of DolphinNewFileMenu.

Unfortunately this caused https://bugs.kde.org/show_bug.cgi?id=405780. Specifically, the change to src/dolphinmainwindow.cpp.

Wed, Apr 17, 9:12 PM · Dolphin
ngraham added a comment to D17105: Add a new lookandfeel runner.

That's all true, yeah. I see more and more people asking for an automatic color scheme switching system these days. So we might want to consider adding this feature in some manner.

Wed, Apr 17, 6:32 PM · Plasma
ngraham committed R119:7cb8db2d1b30: [Widget Explorer] Continue using a trash can icon for deleting delegates (authored by ngraham).
[Widget Explorer] Continue using a trash can icon for deleting delegates
Wed, Apr 17, 6:08 PM
ngraham committed R119:4df1b94cfdd2: Merge branch 'Plasma/5.15' (authored by ngraham).
Merge branch 'Plasma/5.15'
Wed, Apr 17, 6:08 PM
ngraham closed D20638: [Widget Explorer] Continue using a trash can icon for deleting delegates.
Wed, Apr 17, 6:08 PM · Plasma
ngraham committed R120:63ac63ca757f: Merge branch 'Plasma/5.15' (authored by ngraham).
Merge branch 'Plasma/5.15'
Wed, Apr 17, 6:07 PM
ngraham committed R120:3cbd317a3d38: [Widget Explorer] Continue using a trash can icon for "Uninstallable" category (authored by ngraham).
[Widget Explorer] Continue using a trash can icon for "Uninstallable" category
Wed, Apr 17, 6:07 PM
ngraham closed D20637: [Widget Explorer] Continue using a trash can icon for "Uninstallable" category.
Wed, Apr 17, 6:06 PM · Plasma
ngraham updated the diff for D20283: [RFC] [SimpleKCM] Fix height calculation.

arc, you are driving me crazy

Wed, Apr 17, 5:57 PM · Frameworks
ngraham updated the diff for D20283: [RFC] [SimpleKCM] Fix height calculation.

Remove unintentional change

Wed, Apr 17, 5:56 PM · Frameworks
ngraham updated the diff for D20283: [RFC] [SimpleKCM] Fix height calculation.

Use implicitHeights for headers and footers

Wed, Apr 17, 5:55 PM · Frameworks
ngraham updated the diff for D20283: [RFC] [SimpleKCM] Fix height calculation.

Remove accidentally added change

Wed, Apr 17, 5:49 PM · Frameworks
ngraham updated the test plan for D20283: [RFC] [SimpleKCM] Fix height calculation.
Wed, Apr 17, 5:47 PM · Frameworks
ngraham updated the diff for D20283: [RFC] [SimpleKCM] Fix height calculation.

Take headers and padding into account for height calculation

Wed, Apr 17, 5:43 PM · Frameworks
ngraham updated the diff for D20612: [Kickoff] Modernize settings window layout.

Use onPressed And Layout.preferredHeight (still doesn't fix the button height though)

Wed, Apr 17, 5:27 PM · Plasma
ngraham added a comment to D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons.

Submitted D20637 and D20638 to keep the Widget Explorer using the correct icons after this patch lands.

Wed, Apr 17, 5:17 PM · Frameworks
ngraham requested review of D20638: [Widget Explorer] Continue using a trash can icon for deleting delegates.
Wed, Apr 17, 5:16 PM · Plasma
ngraham requested review of D20637: [Widget Explorer] Continue using a trash can icon for "Uninstallable" category.
Wed, Apr 17, 5:16 PM · Plasma
ngraham accepted D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons.
Wed, Apr 17, 5:00 PM · Frameworks
ngraham added a comment to D20581: Revamp grid browser delegates to improve UI.

For user interfaces where you want single-click-to-open, but allow multi-item selection, I think a dedicated selection mode is generally the way to go. On mobile, entering this mode is accomplished by pressing -and-holding on an item (Android) or tapping the Select button on a toolbar somewhere (iOS). On the desktop, those would be supplemented by the typical ctrl+click selection method for expert users who use keyboards shortcuts.

Wed, Apr 17, 4:39 PM
ngraham added inline comments to D20620: [balooctl] Switch multiline output to new helper.
Wed, Apr 17, 4:33 PM · Baloo, Frameworks
ngraham added inline comments to D20619: [balooctl] Use new helper in json output.
Wed, Apr 17, 4:32 PM · Baloo, Frameworks
ngraham accepted D20618: [balooctl] Use new helper for simple format output.
Wed, Apr 17, 4:31 PM · Baloo, Frameworks
ngraham accepted D20617: [balooctl] Factor out file index status collection from output.
Wed, Apr 17, 4:31 PM · Baloo, Frameworks
ngraham added a comment to D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons.

This looks fine to me, but let's let a Plasma person weigh in too. :)

Wed, Apr 17, 4:12 PM · Frameworks
ngraham added a comment to D20636: allow to activate/deactivate the progress indicator on task bar entry.

I can wait, it's hardly urgent. :)

Wed, Apr 17, 3:50 PM
ngraham added a comment to D20636: allow to activate/deactivate the progress indicator on task bar entry.

Thanks! Given that Elisa has a settings window, I would recommend locating the setting there rather than having a menu item for it in the hamburger menu.

Wed, Apr 17, 3:42 PM
ngraham accepted D20635: Show Vaults action only for local folders.
Wed, Apr 17, 3:39 PM · Plasma
ngraham added inline comments to D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI.
Wed, Apr 17, 3:35 PM · Plasma
ngraham accepted D17410: Add alternatives button to applet configuration in panel edit mode.
Wed, Apr 17, 1:57 PM · VDG, Plasma
ngraham updated subscribers of D20576: Add new notifications KCM.
In D20576#451796, @GB_2 wrote:

Hmm, it seems like the Plasma theme list-remove is different from the normal Breeze icon theme list-remove. I think we should have the icon from the Plasma theme in the Breeze icon theme too, but with a different name, so we don't overwrite the existing one.

Wed, Apr 17, 1:45 PM · Plasma

Tue, Apr 16

ngraham added a task to D20612: [Kickoff] Modernize settings window layout: T10586: Modernize plasmoid configuration settings.
Tue, Apr 16, 9:38 PM · Plasma
ngraham added a revision to T10586: Modernize plasmoid configuration settings: D20612: [Kickoff] Modernize settings window layout.
Tue, Apr 16, 9:38 PM · VDG
ngraham requested review of D20612: [Kickoff] Modernize settings window layout.
Tue, Apr 16, 9:38 PM · Plasma
ngraham committed R119:7659a96e772c: [Folder View] Allow icon size slider to horizontally stretch if space permits… (authored by ngraham).
[Folder View] Allow icon size slider to horizontally stretch if space permits…
Tue, Apr 16, 8:37 PM
ngraham added a comment to D20532: Proof of Concept: Add double click actions to empty space in the folder view.

I'm afraid I don't have the answers to those questions. :(

Tue, Apr 16, 5:51 PM · Dolphin
ngraham committed R255:debeff777c3c: Don't adjust the sidebar size with the window size, and reduce the text size a… (authored by ngraham).
Don't adjust the sidebar size with the window size, and reduce the text size a…
Tue, Apr 16, 4:12 PM
ngraham closed D20577: Don't adjust the sidebar size with the window size, and reduce the text size a bit.
Tue, Apr 16, 4:12 PM
ngraham added a comment to D20283: [RFC] [SimpleKCM] Fix height calculation.

Good idea, but the problem I keep running into is that flickable.contentHeight is set to 0 here.

Tue, Apr 16, 2:07 PM · Frameworks
ngraham added a comment to D18744: Add action in Edit menu to select the text on current page.

You've already got my approval. :)

Tue, Apr 16, 12:51 PM · Documentation, Okular
ngraham accepted D20597: Align z's to pixel grid in system.svg.
Tue, Apr 16, 12:40 PM · Frameworks
ngraham added a comment to D20576: Add new notifications KCM.

The trash icons in the app list make me think that it's going to uninstall those apps lol

Suggestions welcome.

Tue, Apr 16, 12:21 PM · Plasma
ngraham added a comment to D20577: Don't adjust the sidebar size with the window size, and reduce the text size a bit.

Thank you :) I don't have a detailed experience of the program yet, but I caught one thing that I felt silly posting a diff for (and it seemed inappropriate to do a git push). Here it should be "tracks" instead of "track" I think: https://lxr.kde.org/source/extragear/multimedia/elisa/src/musiclistenersmanager.cpp#0380

Tue, Apr 16, 2:15 AM
ngraham accepted D20586: Sharpen Z's in system-suspend* icons.
Tue, Apr 16, 1:42 AM · Frameworks
ngraham accepted D20589: Add QML to source code types.
Tue, Apr 16, 1:40 AM · Baloo, Frameworks