ngraham (Nathaniel Graham)
User

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2017, 7:18 PM (113 w, 1 d)
Availability
Available

Recent Activity

Today

ngraham accepted D21859: [RFC] Use view-media-lyrics for Now Playing View.

+1, makes sense!

Sun, Jun 16, 7:59 PM · Elisa
ngraham added a comment to D21860: Set a font for gtk applications in the fonts kcm.

Wow, thanks very much! To answer some questions:

Sun, Jun 16, 7:56 PM · Plasma
ngraham added a reviewer for D21524: Keep existing configurations' strings               : Plasma.
Sun, Jun 16, 7:56 PM · Plasma
ngraham added a comment to D19011: Thunderbolt KCM and KDED module.

Ah OK, I hadn't realized it got moved there yet. I guess this revision can be abandoned then, and we should lobby distros to ship with the new repo/package.

Sun, Jun 16, 7:42 PM · Plasma
ngraham accepted D21855: [IdUtils] Fix aliasing warning.
Sun, Jun 16, 5:41 PM · Baloo, Frameworks
ngraham requested review of D21856: [Task manager] Use consistent menu items for "pin/unpin" actions.
Sun, Jun 16, 5:26 PM · Plasma
ngraham closed D21690: Only show system total cpu usage by default on high core count machines.
Sun, Jun 16, 5:15 PM · Plasma
ngraham committed R120:9fde98302e91: Only show system total cpu usage by default on high core count machines (authored by rappelman).
Only show system total cpu usage by default on high core count machines
Sun, Jun 16, 5:15 PM
ngraham added a comment to D21690: Only show system total cpu usage by default on high core count machines.

Thanks very much for the nice patch! May it be the first of many. :) Let me know if you need a hand with anything.

Sun, Jun 16, 5:14 PM · Plasma
ngraham accepted D21835: [PostingIterator] Move positions() method to VectorPositionInfoIterator.
Sun, Jun 16, 5:12 PM · Baloo, Frameworks
ngraham accepted D21839: [TermGenerator] Use UTF-8 ByteArray for termList.
Sun, Jun 16, 5:12 PM · Baloo, Frameworks
ngraham accepted D21844: [WriteTransactionTest] Clear mixup of QString and QByteArray.

Whoops!

Sun, Jun 16, 5:07 PM · Baloo, Frameworks
ngraham accepted D21832: [sddm-kcm] Write settings to /etc/sddm.conf.d instead of etc/sddm.conf.

Nice work!

Sun, Jun 16, 4:40 PM · Plasma
ngraham added inline comments to D20816: Configure Konsole dialog GUI redesign.
Sun, Jun 16, 4:38 PM · VDG, Konsole
ngraham committed R120:ef94854ef049: Merge branch 'Plasma/5.16' (authored by ngraham).
Merge branch 'Plasma/5.16'
Sun, Jun 16, 4:17 PM
ngraham committed R120:6a5a38f1281f: [Powerdevil runner] Make Sleep/Suspend command work again BUG: 408735 FIXED-IN… (authored by ngraham).
[Powerdevil runner] Make Sleep/Suspend command work again BUG: 408735 FIXED-IN…
Sun, Jun 16, 4:17 PM
ngraham added reviewers for D21831: Move Kruler from 'Graphics' category to 'Utilities': KDE Applications, cfeck.
Sun, Jun 16, 3:53 PM
ngraham committed R111:cf1791d752b0: Invert controls direction for process priority slider (authored by kishoreg).
Invert controls direction for process priority slider
Sun, Jun 16, 3:53 PM
ngraham closed D21828: Invert controls direction for process priority slider.
Sun, Jun 16, 3:53 PM · Plasma
ngraham added inline comments to D20816: Configure Konsole dialog GUI redesign.
Sun, Jun 16, 2:19 PM · VDG, Konsole
ngraham added reviewers for D21781: Fix for Tree: elvisangelaccio, aacid.
Sun, Jun 16, 2:18 PM
ngraham added a comment to D19011: Thunderbolt KCM and KDED module.

Plasma 5.16 has been released and master is wide open for new features. Can we get this landed in some capacity soon? It would be great to have more testing time.

Sun, Jun 16, 2:17 PM · Plasma
ngraham added inline comments to D21736: Adding option to open externally called folder in a new tab.
Sun, Jun 16, 2:13 PM · Dolphin
ngraham added a dependent revision for D21345: Backport Night Color feature to X11: D21346: [libcolorcorrect] Allow color correction on X.
Sun, Jun 16, 2:10 PM · KWin
ngraham added a dependency for D21346: [libcolorcorrect] Allow color correction on X: D21345: Backport Night Color feature to X11.
Sun, Jun 16, 2:10 PM · Plasma
ngraham added a dependency for D21347: [Night Light KCM] Display the kcm on X11 platform: D21345: Backport Night Color feature to X11.
Sun, Jun 16, 2:10 PM · Plasma
ngraham added a dependent revision for D21345: Backport Night Color feature to X11: D21347: [Night Light KCM] Display the kcm on X11 platform.
Sun, Jun 16, 2:10 PM · KWin
ngraham added a comment to D21666: Do not match daemonized dolphin instances.

This does not actually fix https://bugs.kde.org/show_bug.cgi?id=408244:

  1. Open Dolphin
  2. Use that Dolphin window to navigate to an image
  3. Open the image in Gwenview
  4. in Gwenview, go to FileOpen Containing Folder

    Nothing happens.

Actually, I cannot reproduce this issue. At step 4, Dolphin gets raised as expected for me.

Sun, Jun 16, 2:09 PM · Dolphin

Yesterday

ngraham added a comment to T11068: Solve important long term problems better than add new features.

So you think we should prioritize better prioritization? :)

Sat, Jun 15, 11:18 PM · Goal Setting 2019
ngraham added a comment to D21592: Added audio capture channels & sample rate selection.

You need to "abandon" it yourself using the Add Action... menu.

Sat, Jun 15, 11:15 PM
ngraham added a comment to D21736: Adding option to open externally called folder in a new tab.

Just tried out that patch and it fixes both bugs! Let's get it in. :)

Sat, Jun 15, 11:09 PM · Dolphin
ngraham accepted D21691: Open new instance of Dolphin if no URLs are given.

Looks like this also fixes 408244! Please address @elvisangelaccio's comment, then I think this can land.

Sat, Jun 15, 11:09 PM · Dolphin
ngraham updated the summary of D21691: Open new instance of Dolphin if no URLs are given.
Sat, Jun 15, 11:08 PM · Dolphin
ngraham added a comment to T11054: Make Input Methods Just Work.
In T11054#188801, @hein wrote:

"there's a minor thing about XYZ that we don't like, so instead of working together we'll do our own thing". That way nothing ever gets great in the end! There's not enough manpower in this area to spread it so thinly.

Sat, Jun 15, 4:26 PM · Goal Setting 2019
ngraham merged T11055: Integrate SMB/NFS Share Mounting into T11080: KDE for Big Enterprise.
Sat, Jun 15, 4:24 PM · Goal Setting 2019
ngraham merged task T11055: Integrate SMB/NFS Share Mounting into T11080: KDE for Big Enterprise.
Sat, Jun 15, 4:24 PM · Goal Setting 2019
ngraham changed the status of T11058: Port Amarok to Plasma 5+ from Resolved to Invalid.
Sat, Jun 15, 4:22 PM · Goal Setting 2019
ngraham closed T11058: Port Amarok to Plasma 5+ as Resolved.

Too micro, sorry. :)

Sat, Jun 15, 4:22 PM · Goal Setting 2019
ngraham merged T11086: Integrate smart dynamic tiling into KWin into T11067: Better tiling window manager.
Sat, Jun 15, 4:21 PM · Goal Setting 2019
ngraham merged task T11086: Integrate smart dynamic tiling into KWin into T11067: Better tiling window manager.
Sat, Jun 15, 4:21 PM · Goal Setting 2019
ngraham added a comment to T11086: Integrate smart dynamic tiling into KWin.

I think this can be considered a subtask or duplicate of T11067.

Sat, Jun 15, 4:21 PM · Goal Setting 2019
ngraham added a comment to T11072: Make Plasmashell more stable and predictable.

IMO this should be closed as it's basically a bug report, not really a long-term goal.

Sat, Jun 15, 4:19 PM · Goal Setting 2019
ngraham added a comment to T11099: Service based multimedia desktop.

I'm afraid I don't actually understand what's being proposed here. :)

Sat, Jun 15, 4:16 PM · Goal Setting 2019
ngraham accepted D20816: Configure Konsole dialog GUI redesign.

LGTM! Thanks very much for this.

Sat, Jun 15, 4:15 PM · VDG, Konsole
ngraham added a comment to T11096: First-class user & developer documentation centralized on a portal.

I personally think the biggest problem with our docs is not necessarily the content, but the organization. API docs in particular are very hard to find. And if I Google some class name in desperation, I get the old KDE4 era docs, not the KF5 stuff. https://api.kde.org doesn't seem to be linked to in many places. And then of course there's all the duplication.

Sat, Jun 15, 4:14 PM · Goal Setting 2019
ngraham added a comment to T11068: Solve important long term problems better than add new features.

One problem I see here is that "important long term problems" means something different to everyone who reads it. I think you need to be more specific or else this will become a "fix all the things" task that's impossible to achieve (if we had the resources to fix everything, we wouldn't need to set goals for prioritizing where our limited resources need to be spent).

Sat, Jun 15, 4:08 PM · Goal Setting 2019
ngraham added a comment to T11102: KDE cli-gui interface and it's integration in KDE ecosystem.

Indeed. GUI tools that are thin wrappers around CLI programs generally fail because they have no ideal user: people who are comfortable with the CLI prefer the actual CLI, and people who don't like it want a GUI tool that's specifically designed to be a GUI tool. There are very very few people who want to interact with a CLI tool using a thin GUI wrapper.

Sat, Jun 15, 4:01 PM · Goal Setting 2019
ngraham added a comment to D21345: Backport Night Color feature to X11.
In D21345#480141, @zzag wrote:

If you need this patch in master right now, feel free to land it for me. I got sick with the flu so it might take some time before I do this.

Though I advise you to wait until p-w and p-d patches are accepted.

Sat, Jun 15, 3:58 PM · KWin
ngraham accepted D21709: [PendingFileQueue] Avoid delete + create / create + delete race.
Sat, Jun 15, 12:30 AM · Baloo, Frameworks
ngraham added a comment to D21813: RFC: Consider adding more padding to the desktop theme.

I like the rounder corners! :)

Sat, Jun 15, 12:10 AM · Frameworks

Fri, Jun 14

ngraham added a comment to T11093: Consistency & Redundancy.

+1 just for the amount of work you put into the proposal. It's clear you've been thinking about this for quite some time, and the problems are laid out very clearly. I agree with almost everything you say. It's these kinds of little inconsistencies that hurt KDE has a brand and makes the whole KDE ecosystem feel fragmented and unreliable, like nobody's coordinating everything. ...probably because it's true! Just a heads-up though: by far the biggest part of this goal is that coordination. If it's chosen, you're basically signing up to do it. :)

Fri, Jun 14, 10:25 PM · Goal Setting 2019
ngraham accepted D21807: [PendingFileQueueTest] Verify delete + create actually works.
Fri, Jun 14, 10:13 PM · Baloo, Frameworks
ngraham accepted D21809: [PendingFileQueueTest] Verify create + delete do not emit extra events.
Fri, Jun 14, 10:13 PM · Baloo, Frameworks
ngraham added a comment to D21690: Only show system total cpu usage by default on high core count machines.

@rappelman can you please provide your email address so we can land this patch with correct authorship information? Thanks!

Fri, Jun 14, 10:12 PM · Plasma
ngraham updated the summary of D21808: [platforms/X11] Disable VSync for QtQuick Windows.
Fri, Jun 14, 10:04 PM · KWin
ngraham added a comment to D21771: Polish Context View.

Also, take your time, no rush. :)

Fri, Jun 14, 10:02 PM
ngraham updated the diff for D21771: Polish Context View.

Make the MetaDataDelegate labels bold again

Fri, Jun 14, 10:02 PM
ngraham added a comment to D21771: Polish Context View.

I can add back the bold:

Fri, Jun 14, 10:01 PM
ngraham accepted D21810: [desktoppackage] Re-add spacing between inline message and first UI element.
Fri, Jun 14, 9:51 PM · Plasma
ngraham added a comment to D21776: Implement new Header toolbar style for main view.

I was also not sure about removing information. An idea I had was to make the actual toolbar itself very minimal and only show the category name + toolbar buttons. Then all the fancy information could be below that, visible in the view itself, separated in a pretty way like how I did with the context view.

Fri, Jun 14, 9:50 PM
ngraham added a comment to D21503: [Calculator] Make buttons' text labels scale in size along with the widget.

Patch to fix: D21811

Fri, Jun 14, 9:46 PM · Plasma
ngraham requested review of D21811: [Calculator] Fix popup size and minimum size for expanded version.
Fri, Jun 14, 9:45 PM · Plasma
ngraham requested changes to D21810: [desktoppackage] Re-add spacing between inline message and first UI element.

TBH I really don't like this message anyway. It's so in-your-face. But while it exists, I guess we should make it look prettier. :)

Fri, Jun 14, 9:44 PM · Plasma
ngraham added inline comments to D21794: [sddm-theme] Style the session and keyboard layout selectors to be more Breeze.
Fri, Jun 14, 6:00 PM · Plasma
ngraham added a comment to T11094: Improve discoverability of widget configuration.

Yeah, this stuff is all second nature to us developers but to users--even potentially experienced users--it's not clear.

Fri, Jun 14, 5:48 PM · VDG, Plasma
ngraham added a reviewer for D19265: [KWin] Skip fall apart effect on virtual desktop change: KWin.

@matthieugras Ping! :)

Fri, Jun 14, 5:31 PM · KWin
ngraham added a comment to D19237: [Yakuake] Use the svg icons instead of the png icons for the default theme.

Sorry this took so long @matthieugras! Since you've gotten several patches accepted now, please feel free to apply: https://techbase.kde.org/Contribute/Get_a_Contributor_Account

Fri, Jun 14, 5:16 PM
ngraham committed R369:e631915b2ff8: [Yakuake] Use the svg icons instead of the png icons for the default theme (authored by matthieugras).
[Yakuake] Use the svg icons instead of the png icons for the default theme
Fri, Jun 14, 5:14 PM
ngraham closed D19237: [Yakuake] Use the svg icons instead of the png icons for the default theme.
Fri, Jun 14, 5:14 PM
ngraham added a comment to D19732: [KWidgetAddons] Fix build with Qt 5.13.

@apol @matthieugras is this still needed? If so we need to land it...

Fri, Jun 14, 5:12 PM · Frameworks
ngraham updated the task description for T10891: Breeze theme evolution.
Fri, Jun 14, 4:43 PM · VDG, Breeze
ngraham accepted D21759: Hold zoom center below center/mouse position.

Interactivity is great, a big improvement! Code looks sane to me too but I'd like a review from a Okular person before we land this.

Fri, Jun 14, 4:33 PM · Okular
ngraham added a comment to D9341: Port kprinter4 to Qt 5/KDE 5.

Is this still relevant?

Fri, Jun 14, 4:01 PM
ngraham accepted D21793: [PendingFileQueueTest] Use synthetic timer events to speedup test.
Fri, Jun 14, 2:37 PM · Baloo, Frameworks
ngraham accepted D21792: [PendingFileQueue] Refactor for easier and faster unit testing.
Fri, Jun 14, 2:35 PM · Baloo, Frameworks
ngraham added a comment to D21709: [PendingFileQueue] Avoid delete + create / create + delete race.

Awesome, thanks!

Fri, Jun 14, 2:35 PM · Baloo, Frameworks
ngraham accepted D21791: [PendingFileQueueTest] Shorten timeouts, verify tracking time.
Fri, Jun 14, 2:21 PM · Baloo, Frameworks
ngraham accepted D21790: [PendingFileQueue] Use more accurate calculation of remaining time.

+1, makes sense!

Fri, Jun 14, 2:20 PM · Baloo, Frameworks
ngraham added a comment to T11096: First-class user & developer documentation centralized on a portal.

I'm a bit torn. For all the documentation I've updated that that's on a wiki, I seriously doubt I would have made the change if I'd needed to submit a patch, deal with bikeshedding, request commit access, etc. The barrier to entry for a wiki is just so low that it's a real advantage IMO.

Fri, Jun 14, 2:18 PM · Goal Setting 2019
ngraham added a comment to D21789: Fix tests relating to the removal of the Root Place in D15739.

I may need to add some sort of "#if KIO_VERSION < QT_VERSION_CHECK(5,60,0)" all over the place.
I have tried it but I haven't found similar patterns to base upon.
If I don't, it will make dolphin tests depends on kio master/5.60, unless this is tolerable.
I don't know the expectancies on tests.
Your call @elvisangelaccio.

Fri, Jun 14, 1:27 PM · Dolphin
ngraham updated the task description for T11069: Improve KDE PIM.
Fri, Jun 14, 12:12 PM · Goal Setting 2019
ngraham added a comment to T11083: Make Kmail setup and usage stable.

I would recommend merging this into T11069, which is broader and more ambitious. :)

Fri, Jun 14, 12:12 PM · Goal Setting 2019
ngraham updated the task description for T11093: Consistency & Redundancy.
Fri, Jun 14, 12:00 PM · Goal Setting 2019
ngraham removed a parent task for T10028: Individual KScreen output data retention: T10488: Plasma 5.16.
Fri, Jun 14, 4:32 AM · VDG, Plasma
ngraham removed a subtask for T10488: Plasma 5.16: T10028: Individual KScreen output data retention.
Fri, Jun 14, 4:32 AM · Plasma

Thu, Jun 13

ngraham accepted D21789: Fix tests relating to the removal of the Root Place in D15739.
Thu, Jun 13, 9:38 PM · Dolphin
ngraham accepted D15739: [Places panel] Don't show Root by default.

Lovely. :)

Thu, Jun 13, 9:38 PM · Frameworks
ngraham added a comment to T11094: Improve discoverability of widget configuration.
In T11094#188663, @hein wrote:
  • I think the "a System Settings window open on that screen configures that screen" is pretty confusing. It's inconsistent with how most of System Settings works - e.g. the display KCM. And what should happen when the user moves the window to another screen? This all gets pretty confusing and messy fast.

It was just a thought; the thing in System Settings could itself have a chooser for the instances in different activities and instead. I think it's worth keeping in mind that the common case is one screen and one activity. For the majority of our users, the configuration UI would be very simple. It would need to accommodate advanced use cases, but the simple one-screen-one-activity use case would be by far the most common one.

Thu, Jun 13, 9:13 PM · VDG, Plasma
ngraham accepted D21774: simplify management of list and grid views and keep only one kind.

Code change looks sane, and I also can detect no regressions!

Thu, Jun 13, 8:18 PM
ngraham updated the task description for T11094: Improve discoverability of widget configuration.
Thu, Jun 13, 7:37 PM · VDG, Plasma
ngraham created T11094: Improve discoverability of widget configuration.
Thu, Jun 13, 7:29 PM · VDG, Plasma
ngraham added a comment to D15739: [Places panel] Don't show Root by default.

Nice huge diff! You see why I had trouble with it, maybe. :) I am very impressed that you pulled this off so quickly though!

Thu, Jun 13, 7:25 PM · Frameworks
ngraham added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

So um, any chance we can move forward with this in some capacity?

Thu, Jun 13, 7:05 PM · Plasma
ngraham added a comment to T9040: Improve navigation on Kickoff's Applications page.

This new Applications tab is basically a clone of SimpleMenu, XFCE's Whisker menu, or Excalibur Menu: https://store.kde.org/p/1172867/

Thu, Jun 13, 7:04 PM · Plasma, VDG
ngraham added a comment to D21787: Update plasma-desktop.php.

👌

Thu, Jun 13, 6:48 PM
ngraham added a comment to D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation.

Totally awesome :)

Thu, Jun 13, 6:42 PM · Frameworks
ngraham added a comment to D14467: Auth Support: Drop privileges if target is not owned by root.

@mgerstner How is this looking now? Yea/nay?

Thu, Jun 13, 6:41 PM · Frameworks
ngraham added a comment to D14464: Cancel privilege operation for read-only target with the current user as owner.

@chinmoyr can you address @dfaure's remaining comments so we can get this in?

Thu, Jun 13, 6:40 PM · Frameworks
ngraham added a comment to D21782: Add a warning dialog with details, continue, and cancel button.
In D21782#479190, @GB_2 wrote:

I think a KCollapsibleGroupBox would fit here: http://blog.davidedmundson.co.uk/blog/my-new-widget-in-frameworks/

Thu, Jun 13, 6:35 PM · Frameworks
ngraham updated the diff for D21134: [Notifications] Tweak paddings.

Fix RTL paddings

Thu, Jun 13, 6:22 PM · Plasma