- User Since
- Apr 15 2017, 7:18 PM (31 w, 5 d)
Visually, it looks great to me!
I'm going to land this on 11/25/17 unless I hear any more objections from anyone.
Can you resign from the revision then so you're not leaving unresolved negative feedback?
After a lot of design work in VDG, we all agreed on the following:
Probably redo the patch so that it can apply to any theme.
Fantastic, that's perfect!
@ivan, what do you think?
@graesslin, is this looking okay now?
@dfaure, does this look sane and sensible to you?
Tue, Nov 21
I like it.
Could we possibly take the opportunity to turn font anti-aliasing on by default instead of leaving it with "Vendor Default" (a string that doesn't have any meaning to most users)?
I'm sorry @hein. I understand that this is pretty frustrating. Sometimes there's no substitute for seeing the actual implementation, I guess!
Needs more screenshots! :-)
Also as discussed in the VDG room this morning, there's the open question of whether we actually need a launch feedback KCM or whether these settings should be in the Task Manager's own settings.
- I think the labels with controls next to them need colons. It looks weird otherwise.
- We should vertically align the labels and their controls, just like @mmustac showed. That looks radically better.
Mon, Nov 20
My mistake, sorry.
Can you mark this as resolving T7244, so that task will be automatically closed when this goes in?
@ivan? I know you had some reservations about the UI, but can we discuss those and either merge or abandon this?
Can you add "Resolves T7284" so this it will close that Maniphest task once this goes in?
Sun, Nov 19
This is in stark contrast to Kate and LibreOffice, where you are allowed to save back to disk:
Sat, Nov 18
Not to throw cold water on your patch (it's nice to see someone working on Baloo!), but perhaps we should continue @cullmann's work to move over to Tracker instead. It's an active project, and we would benefit from all the work that the GNOME people are putting into it. I fear that Baloo is destined to suffer a slow death from bitrot unless it gains at least one full-time maintainer. If that happens, Elisa won't be able to rely on it anyway, and that code will need to be removed or ported over to use Tracker (or whatever else we use instead).
@ervin and @dvratil, I'd like to land this in one week, since it's an open dependency blocking a lot of great work in Dolphin. Please respond if you have any remaining concerns, and preferably update your status if you don't.
The problem with that approach is that you'll wind up with a large number of number of panels to manage (Places, Devices, Search For, Recently Saved, Tags...) . Each one can have a scrollbar since its content is scrollable, so you'd wind up with four or five scrollviews immediately above one another, which is a poorer UX compared to the single scrollable view that the Places panel already offers. If we re-implement everything such that each panel never has a scrollview and has to be fit inside a master scrollview... then we've re-implemented exactly what we already have with the places panel.
@rkflx, any remaining concerns, or should we land this?
Fri, Nov 17
$ kcmshell5 touchpad kcm_touchpad: Using X11 backend
Thanks, looks good. Might wanna wait for at least one more review before committing.
@xuetianweng any update?
@apol Thanks! I made one more change (the text of the "Info") button; does your approval still hold?
Also change "Open" button to say "More Information..." (it's not clear what you were opening before)
Add a frame around the text if the box is extended
IMHO the open button is superfluous for package updates anyway. It takes you to a view that doesn't even show you the changelogs.
Hmm, yeah, perhaps a frame around all the text would look nicer. It
would look a bit off if there was only a frame around one of the three
bold-headered sections IMHO. I'll play with that a bit.
If the changelog is like a thousand lines long, you can always just close it again. And I think it would actually be easier to read as one huge box than a tiny scrollview that only shows like 5 lines at a time.
Thu, Nov 16
If the ability to add a custom path is important, maybe we should put that under "Terminal options". I don't think we're ever going to figure out a functional UI for that single text field to work equally well for searching and entering a path with history.
Awesome. Please make sure to mark any dependent revisions.
A scrollbar to show hidden buttons is a pretty bad UX. We should aim for something better in the new version. Perhaps the buttons should lose their text and become icons-only when the window is too narrow to show them all with icons and text.
Wed, Nov 15
Actually use the value of Plugins specified in the config, if it's present (this makes saving user plugin selections work again)
Yeah, putting workarounds everywhere isn't so appealing. My preference would be for a Qt fix, otherwise we'll be playing whack-a-mole here forever.
I've tested this and it works great. As soon as the unnecessary new function is removed, I'll approve it and will wait for @rkflx to review as well.
Thanks for the approval. I'll land this, then the refactoring onto my to-do list. I agree that the current code is a bit stinky and could benefit from a more direct approach.
Restore correct diff
Rely on KF 5.40 and simplify the code a ton
Rely on KF 5.40 and simplify the code a ton
Consider any source file in /tmp/ to be a temp file that we should clear, so we don't leak files when run by kcmshell5 (or anything similar)
Tue, Nov 14
@davidedmundson, does your approval still hold with the new change to clean up /tmp?
Actually @trufanov, would you mind doing it? I'd rather not commandeer your revision or commit it by hand, both of which will break the history here on phabricator.