ngraham (Nathaniel Graham)
User

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2017, 7:18 PM (86 w, 5 d)
Availability
Available

Recent Activity

Today

ngraham added a comment to D17496: Change network/web color icons to consistent style.

Now that this is landed, feel free to change the symlinks by hand.

Thu, Dec 13, 4:18 PM · Frameworks
ngraham accepted D17496: Change network/web color icons to consistent style.

Thanks!

Thu, Dec 13, 3:33 PM · Frameworks
ngraham committed R266:f7fe6d889ae6: Add new name for sqlite files, so the icons actually show up BUG: 402095 FIXED… (authored by ngraham).
Add new name for sqlite files, so the icons actually show up BUG: 402095 FIXED…
Thu, Dec 13, 3:32 PM
ngraham added a comment to D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space.

Actually I feel like this regressed the visuals for the file dialog itself in the name of improving the situation for apps that use this view in a sidebar.

Thu, Dec 13, 3:25 PM · Frameworks
ngraham accepted D17551: Take the scrollbar into account for the ScrollablePage margin.
Thu, Dec 13, 3:05 PM · Kirigami
ngraham added a comment to D17551: Take the scrollbar into account for the ScrollablePage margin.

This fixes the issue in Discover for me and doesn't seem to regress anything in Gallery.

Thu, Dec 13, 3:05 PM · Kirigami
ngraham added a comment to D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space.
In D17461#376509, @apol wrote:

Hey, this change makes the file dialog crawl on big directories.
For me, going into /usr/include makes the whole application freeze.

We should consider reverting and trying a different approach.

Thu, Dec 13, 2:08 PM · Frameworks
ngraham accepted D17552: Fix 2 typos.
Thu, Dec 13, 5:35 AM · Kirigami
ngraham accepted D17550: Make the open url in tab feature a bit more discoverable.

+1 for the idea and the UX as texted. No comment on the code change; I'm definitely not smart enough to understand it all!

Thu, Dec 13, 5:12 AM · Frameworks
ngraham committed R883:1530644: Make the translations appear.
Make the translations appear
Thu, Dec 13, 12:19 AM

Yesterday

ngraham committed R883:1530643: Remove height tags so the new images aren't squished.
Remove height tags so the new images aren't squished
Wed, Dec 12, 11:29 PM
ngraham committed R883:1530642: Add images from Promo team.
Add images from Promo team
Wed, Dec 12, 11:27 PM
ngraham committed R883:1530638: Applying patch from the promo team.
Applying patch from the promo team
Wed, Dec 12, 8:46 PM
ngraham added a comment to T10047: Guerilla UX testing: a GNOME switcher.
In T10047#170029, @GB_2 wrote:

Can D17323 and D17321 be landed?

Wed, Dec 12, 6:25 PM · VDG, Plasma
ngraham accepted D17505: Add preferences-system-bluetooth-battery to preferences.svgz.
Wed, Dec 12, 3:02 PM · Frameworks
ngraham added a comment to M144: New panel right click context menu.

Your proposed "Application Launcher Settings" Needs to stay as it it ("Configure Application Launcher") for consistency and HIG adherence. Also, "Alternative Widgets" needs to start with an action verb. Maybe "Show Alternative Widgets" or "Switch to an Alternative" or something like that?

Wed, Dec 12, 2:19 PM · VDG, Plasma
ngraham accepted D17518: Adapt favicon test to www.kde.org changes.
Wed, Dec 12, 4:22 AM · Frameworks
ngraham requested changes to D17496: Change network/web color icons to consistent style.

Looks good visually, but the scalable test now fails:

Wed, Dec 12, 4:21 AM · Frameworks

Tue, Dec 11

ngraham requested changes to D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

I can confirm @zzag's bug.

Tue, Dec 11, 11:45 PM · KWin
ngraham added a comment to D17469: applications-games icon for dark theme.

That's much better! I think I would still prefer a bit more slope on the sides though. However at this point it's just aesthetic quibbling. :)

Tue, Dec 11, 3:57 PM · Frameworks
ngraham added a comment to D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI.

and some users report that it actually does the wrong thing for certain URLs.

Bug reports are also an indication people use it.

Tue, Dec 11, 3:49 PM · Plasma
ngraham added a comment to D17469: applications-games icon for dark theme.

@ndavis To be honest, I liked the shape and composition of the original icon better than your proposed new one. I'm not a huge fan of the flat sides and lack of visual distinction between the body and handles. +1 on removing the superfluous Plasma logo though.

Tue, Dec 11, 3:16 PM · Frameworks
ngraham added a comment to D16694: Improve visibility for Konsole icon when using Breeze Dark.

App icons shouldn't have monochrome versions except for very limited exceptions like on the system tray. The issue being solved here is a general problem that we have when a dark icon is used with a dark color scheme. It's by no means limited to this icon (see also D17469), but we have some visual restrictions on resolving it since this is an app icon and we can't really redesign the icon like we can in D17469.

Tue, Dec 11, 3:16 PM · Frameworks
ngraham added a comment to T9658: Rethink blur-by-default for Breeze SDDM login screen theme for Plasma 5.15.

On a technical note:
I do want SDDM to support plasma wallpapers (there's some semantics that make that technically ... interesting, but it's not impossible)

I don't really like how the old blur was done, being directly in the login screen, I would much rather have seen it added as a wallpaper type.
That way in system settings -> screen locker -> background you would see wallpaper type: colour / image / blurred image / whatever and there'd be a way to turn it off without cluttering the config UI.

Tue, Dec 11, 3:08 PM · Plasma, VDG
ngraham accepted D17495: [KMessageBox] Fix minimum dialog size when details are requested.
Tue, Dec 11, 3:06 PM · Frameworks
ngraham closed D17416: [kcmkwin/compositing] Remove effect list item selection, fix list item size after hiding the effect video, use a real button as the play button and use the right busy indicator.
Tue, Dec 11, 3:05 PM · VDG, KWin
ngraham committed R108:787c39cd420a: [kcmkwin/compositing] Remove effect list item selection, fix list item size… (authored by GB_2).
[kcmkwin/compositing] Remove effect list item selection, fix list item size…
Tue, Dec 11, 3:05 PM
ngraham added a comment to D17496: Change network/web color icons to consistent style.
Checking patch icons-dark/preferences/32/applications-internet.svg...
Checking patch dev/null => icons-dark/categories/32/applications-internet.svg...
error: dev/null: does not exist in index
Checking patch icons-dark/apps/48/internet-web-browser.svg...
Applied patch icons/preferences/32/preferences-web-browser-stylesheets.svg cleanly.
Tue, Dec 11, 2:48 PM · Frameworks

Mon, Dec 10

ngraham added a comment to D17493: [WIP] Implementation of an Easy Mode in KCM fonts module.
  1. This needs screenshots. :)
  2. Don't you think it's premature to submit code before we've settled on what it is we actually want? I don't see any consensus in T7927. Personally I am not at all sold on the idea of presenting users with ten font rendering options and expecting them to be able to choose their favorite. The differences between most of them are minuscule and seem all but impossible for someone who's not a font nerd to distinguish. The idea of visual previews seems sound, but I think we would need to limit them to choices that lay people actually have a chance of understanding and distinguishing between.
Mon, Dec 10, 7:44 PM · Plasma
ngraham accepted D17423: Added statement about aiming for perfection.

Thanks!

Mon, Dec 10, 7:03 PM · KDE Human Interface Guidelines
ngraham added a comment to D17441: tune editing actions for large number of small edits.

I guess it's ok to have this in. But please use this version at your daily work ;) I think we don't have many testers...

Mon, Dec 10, 6:50 PM · Frameworks, Kate
ngraham added a comment to D17490: Add an icon for "restore" action.

Um, the diff is now different, and it looks like the wrong patch was committed: https://cgit.kde.org/dolphin.git/commit/?id=55db38d5ecc1f13e17fecd7f3a5ea24421080b77

Mon, Dec 10, 6:03 PM · Dolphin
ngraham accepted D17490: Add an icon for "restore" action.

Semantically, this is the correct icon, though the actual imagery isn't super applicable. We can fix that with a better icon though.

Mon, Dec 10, 5:54 PM · Dolphin
ngraham added a comment to D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required.

The lock and login screens are already subtly inconsistent with one another, so changing that isn't currently on the table.

Mon, Dec 10, 2:51 PM · Plasma
ngraham updated subscribers of D17469: applications-games icon for dark theme.

This is another example where a subtle outline could help visibility for dark themes, without having to resort to drawing a whole new version of it.

Mon, Dec 10, 2:47 PM · Frameworks
ngraham accepted D17421: Add drive-* icons for YaST Partitioner.

Looks great now!

Mon, Dec 10, 6:19 AM · Frameworks
ngraham added a comment to D17421: Add drive-* icons for YaST Partitioner.

How is this? Monochrome icons typically don't use multiple shades of gray or transparency, but some do. Going clockwise, 100%, 67%, 33% and 0% opacity.

Mon, Dec 10, 5:03 AM · Frameworks
ngraham committed R241:f28e34306378: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal… (authored by ngraham).
[KDirOperator] Don't squeeze Name column when there isn't enough horizontal…
Mon, Dec 10, 4:48 AM
ngraham closed D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space.
Mon, Dec 10, 4:48 AM · Frameworks
ngraham updated the summary of D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space.
Mon, Dec 10, 4:47 AM · Frameworks
ngraham added a comment to D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space.

Cool, landing now. If I can get some assistance, I might try my hand at submitting a Qt patch to add the requested resize mode.

Mon, Dec 10, 4:45 AM · Frameworks

Sun, Dec 9

ngraham added a comment to D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space.

Yeah, I do too. It's certainly more functional. Do you think I should just commit this now?

Sun, Dec 9, 11:19 PM · Frameworks
ngraham added a comment to D17244: Edit Profile Dialog UI redesign.
In D17244#371489, @mglb wrote:

New widget would be nice. The information here is not that important (for advanced user) and is not an indicator (where kmessagewidget is perfect) but more like an one-time hint. The warning icon indicates that the option should be used with caution, or that the configuration is somehow risky. Someone who cares about it can just click and read a message.

Sun, Dec 9, 9:42 PM · Konsole
ngraham added a comment to D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space.

A slightly nicer solution would appear to be to keep column 0 using QHeaderView::Stretch like it already is, but give only that column a minimum size equal to the longest item. That way the name column would dynamically expand as the view was enlarged which keeps the other columns aligned to the right side, but would not compress as the view shrinks. Unfortunately this doesn't appear to be easily possible: https://bugreports.qt.io/browse/QTBUG-1248

Sun, Dec 9, 9:07 PM · Frameworks
ngraham updated the test plan for D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space.
Sun, Dec 9, 8:29 PM · Frameworks
ngraham requested review of D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space.
Sun, Dec 9, 8:28 PM · Frameworks
ngraham accepted D17458: Add help button to KCMs where it was missing.
Sun, Dec 9, 7:49 PM · Plasma
ngraham added a comment to D17421: Add drive-* icons for YaST Partitioner.

Maybe the problem is with the monochrome version, not the color one. To me, that "half filled balls connected with struts" icon looks like something more related to chemistry than disk management.

Sun, Dec 9, 7:39 PM · Frameworks
ngraham added a comment to D17288: Fix hardcoded private browsing icon.

@drosca, you'll need to land this for @GB_ with authorship information Björn Feber <feber70@gmail.com>.

Sun, Dec 9, 7:37 PM · Falkon
ngraham committed R266:b849a63cefb3: Add view-private icon (authored by GB_2).
Add view-private icon
Sun, Dec 9, 7:01 PM
ngraham closed D17419: Add view-private icon.
Sun, Dec 9, 7:01 PM · VDG, Breeze, Frameworks
ngraham added a comment to D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate.

Sorry, please ignore me...

Sun, Dec 9, 7:00 PM · Frameworks, Kate
ngraham accepted D17419: Add view-private icon.

Ah yeah, I guess that makes sense.

Sun, Dec 9, 6:49 PM · VDG, Breeze, Frameworks
ngraham added a comment to D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate.

I always re-bind Find Next and and Find Previous to use Ctrl+G and Ctrl++G. These are the shortcuts that are used by most 3rd-party apps, as well as all GNOME and macOS apps. It might make more sense to standardize on those.

Just to clarify: F3/Shift+F3 would stay the same, right?

Yeah, as backup/additional shortcuts so we don't break workflows for people who currently use them.

Sun, Dec 9, 6:29 PM · Frameworks, Kate
ngraham added a comment to D17321: Change panel edit mode icon from from a hamburger icon to a configure icon.

Plasma folks, any comments, or shall we land this?

Sun, Dec 9, 6:27 PM · VDG, Plasma
ngraham added inline comments to D17416: [kcmkwin/compositing] Remove effect list item selection, fix list item size after hiding the effect video, use a real button as the play button and use the right busy indicator.
Sun, Dec 9, 6:26 PM · VDG, KWin
ngraham added inline comments to D17416: [kcmkwin/compositing] Remove effect list item selection, fix list item size after hiding the effect video, use a real button as the play button and use the right busy indicator.
Sun, Dec 9, 5:55 PM · VDG, KWin
ngraham accepted D17416: [kcmkwin/compositing] Remove effect list item selection, fix list item size after hiding the effect video, use a real button as the play button and use the right busy indicator.

Ah, much better! This looks great to me now. KWin folks, any any concerns, or should we land this?

Sun, Dec 9, 5:47 PM · VDG, KWin
ngraham committed R858:56fb6a3de989: Rotate busy indicator clockwise (authored by GB_2).
Rotate busy indicator clockwise
Sun, Dec 9, 5:45 PM
ngraham closed D17440: Rotate busy indicator clockwise.
Sun, Dec 9, 5:45 PM · VDG, Breeze, Plasma
ngraham added a comment to D17440: Rotate busy indicator clockwise.

Yep, the PC one already does go clockwise

Sun, Dec 9, 5:36 PM · VDG, Breeze, Plasma
ngraham added a comment to D17137: KTextEditor: File menu: Put Save, Print and Export in submenus.

In terms of the submenu text, I just noticed that we already have "Find Variants" in the Edit menu, so I'm okay with using "Save Variants" and "Close variants" for consistency. We can decide later whether we want to keep that style.

Sun, Dec 9, 5:26 PM · Frameworks, Kate
ngraham committed R166:dcb36a2fd3ad: Add keywords to .desktop file (authored by brettco).
Add keywords to .desktop file
Sun, Dec 9, 5:24 PM
ngraham closed D17396: Add keywords to .desktop file.
Sun, Dec 9, 5:24 PM · Spectacle
ngraham added a comment to D17396: Add keywords to .desktop file.

Thanks for contributing to Spectacle! May it be the first of many more. :)

Sun, Dec 9, 5:24 PM · Spectacle
ngraham added a comment to D17421: Add drive-* icons for YaST Partitioner.

For drive-multipartition, maybe a disk with lines that make it look like it's internally divided into four pieces?

Wasn't quite sure how to do that, so I made this:

Sun, Dec 9, 5:20 PM · Frameworks
ngraham added a comment to D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate.

I always re-bind Find Next and and Find Previous to use Ctrl+G and Ctrl++G. These are the shortcuts that are used by most 3rd-party apps, as well as all GNOME and macOS apps. It might make more sense to standardize on those.

Sun, Dec 9, 1:56 AM · Frameworks, Kate

Sat, Dec 8

ngraham added a comment to D17419: Add view-private icon.

If view-private-symbolic is just a symlink to the regular icon, do we really need it?

Sat, Dec 8, 9:08 PM · VDG, Breeze, Frameworks
ngraham added inline comments to D17314: Projects Plugin: Add ShellCheck analyzer.
Sat, Dec 8, 3:48 PM · Kate
ngraham added inline comments to D17314: Projects Plugin: Add ShellCheck analyzer.
Sat, Dec 8, 3:39 PM · Kate
ngraham accepted D15999: Add icons with added background to system.svgz.

Can you also bump the version numbers in the metadata.desktop files?

Sat, Dec 8, 3:34 PM · Frameworks
ngraham added a comment to D17416: [kcmkwin/compositing] Remove effect list item selection, fix list item size after hiding the effect video, use a real button as the play button and use the right busy indicator.

Hmm, why did you change the busy indicator? I think the current one is fine. The new one is something I haven't seen used anywhere else.

Sat, Dec 8, 3:29 PM · VDG, KWin
ngraham added a comment to D17423: Added statement about aiming for perfection.

Good idea! I might suggest rewriting it as follows:

Sat, Dec 8, 2:59 PM · KDE Human Interface Guidelines
ngraham added a comment to D17375: Don't automatically refresh if the user already asked apt to do so.

That's what I thought. Then it doesn't fully fix 401810, since people not using Kubuntu or Neon will still not have a way to change the update frequency.

Sat, Dec 8, 2:50 PM · Plasma
ngraham added a comment to D17419: Add view-private icon.

Oh, probably a Cuttlefish bug then.

Sat, Dec 8, 2:46 PM · VDG, Breeze, Frameworks
ngraham added a comment to D17393: [Folder View] make file context menu consistent with Dolphin's.

Hmm, I prefer the Dolphin one for the following reasons:

  1. Having the the "open with" item near the top makes sense because it's likely the most commonly used item
  2. Having the "open" items grouped together makes sense, since they're both similar actions, and all other platforms I'm familiar with have their context menu's "open" items on the top too
  3. The greater use of separators is an asset, not a drawback: separators provide structure and help the mind distinguish between logical groups. In particular having cut/copy/paste separated from other items makes sense.
  4. The current FV menu has bugs:
    1. The top item is Open, but it uses an inappropriate icon and is duplicated by another superior Open with [app name] item buried in the middle of the context menu.
    2. It doesn't show the Paste item unless there's something to paste. This is a HIG violation; we don't recommend modifying the visibility of inapplicable menu items; instead they should be disabled.
    3. The Properties item doesn't have a keyboard shortcut
Sat, Dec 8, 2:38 PM · Plasma
ngraham added a comment to D17419: Add view-private icon.

Hmm, now it seems like his hat gets flat at the 48px size:

Sat, Dec 8, 2:26 PM · VDG, Breeze, Frameworks
ngraham added a comment to D17375: Don't automatically refresh if the user already asked apt to do so.

This helps for Kubuntu (and Neon ?) users, but what about everyone else?

Sat, Dec 8, 4:40 AM · Plasma
ngraham added a comment to D17416: [kcmkwin/compositing] Remove effect list item selection, fix list item size after hiding the effect video, use a real button as the play button and use the right busy indicator.

Should these list items even become selected when clicked? Typically items are only selectable when there are some actions you can apply to selected items, which isn't the case here.

Sat, Dec 8, 4:19 AM · VDG, KWin
ngraham added a comment to D17421: Add drive-* icons for YaST Partitioner.

They generally look very good.

Sat, Dec 8, 4:16 AM · Frameworks
ngraham accepted D17396: Add keywords to .desktop file.

Looks great, thanks! Can you provide your email address so I can land this patch with correct authorship information?

Sat, Dec 8, 4:09 AM · Spectacle
ngraham added a comment to D16694: Improve visibility for Konsole icon when using Breeze Dark.

We had a big discussion in the VDG room and concluded that Konsole shouldn't even use this icon for its tabs by default (https://bugs.kde.org/show_bug.cgi?id=401864), which partially solves the problem.

Sat, Dec 8, 4:08 AM · Frameworks
ngraham accepted D17420: [Device Notifier] Fix action button vertical alignment.

Works flawlessly! Very nice.

Sat, Dec 8, 3:45 AM · Plasma
ngraham added a comment to D17410: Add alternatives button to applet configuration in panel edit mode.

Neat, it seems to generally work well. I notice that when I click the new menu item, it somewhat unexpectedly exits from panel edit mode. I wonder if we could make it not do that, so it would stay in panel edit mode if invoked while in panel edit mode.

Sat, Dec 8, 3:37 AM · VDG, Plasma
ngraham added a comment to D17410: Add alternatives button to applet configuration in panel edit mode.

I think we should be using a monochrome icon here.

Sat, Dec 8, 3:31 AM · VDG, Plasma
ngraham accepted D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.
Sat, Dec 8, 12:35 AM · VDG, Plasma
ngraham accepted D17412: [kcms/fonts] Don't set minimium DPI value.

Works great!

Sat, Dec 8, 12:07 AM · Plasma

Fri, Dec 7

ngraham accepted D17419: Add view-private icon.

Looks great to me! Thanks for embedding the CSS stylesheet too. Falkon or other VDG folks, any comments?

Fri, Dec 7, 11:42 PM · VDG, Breeze, Frameworks
ngraham added reviewers for D17419: Add view-private icon: VDG, Falkon.
Fri, Dec 7, 11:41 PM · VDG, Breeze, Frameworks
ngraham added inline comments to D17420: [Device Notifier] Fix action button vertical alignment.
Fri, Dec 7, 10:40 PM · Plasma
ngraham added a comment to D17418: SearchView: Harmonize text in searchPlaceCombo.

Please add

BUG: 389181

To its own line in the Summary section. See https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch

I was about to do it, but after a short look there...

Either of these tags will cause that Bugzilla ticket to be automatically closed when the patch is committed.

... I think that's not correct. This patch fix not the main issue, only that extra hint.

Fri, Dec 7, 10:23 PM · Kate
ngraham added a comment to D17419: Add view-private icon.

I like it! What do you think about making the bottom line of the hat a bit wider, so it's more clear that it's a hat?

Fri, Dec 7, 10:14 PM · VDG, Breeze, Frameworks
ngraham accepted D17418: SearchView: Harmonize text in searchPlaceCombo.

Please add

BUG: 389181
Fri, Dec 7, 9:35 PM · Kate
ngraham added a comment to T10165: Category icons should all be colorful.

I would even go as far as changing the left column where the icons are to some other color too. However, I think this is sensible. It breaks monochrome glyphs that can be confused.

Fri, Dec 7, 5:32 PM · Plasma, VDG
ngraham updated the task description for T10165: Category icons should all be colorful.
Fri, Dec 7, 4:58 PM · Plasma, VDG
ngraham created T10165: Category icons should all be colorful.
Fri, Dec 7, 4:51 PM · Plasma, VDG
ngraham added a comment to T9658: Rethink blur-by-default for Breeze SDDM login screen theme for Plasma 5.15.

Thanks! :)

Fri, Dec 7, 4:35 PM · Plasma, VDG
ngraham added a comment to T9658: Rethink blur-by-default for Breeze SDDM login screen theme for Plasma 5.15.

If they will work with what you're trying to implement,

Fri, Dec 7, 4:28 PM · Plasma, VDG
ngraham added a comment to T9658: Rethink blur-by-default for Breeze SDDM login screen theme for Plasma 5.15.

My objective is a win-win situation not a win-loose situation. I don't want either of the parties end up frustrated. I favor mitigation over exclusion. The thing is all desktops that are popular and/or have a significant market share use blur at login one way or the other. Would it be possible for those who favor full-screen blur to easily tweak their login (say via a third-party theme), should the proposed login pass?

Fri, Dec 7, 4:04 PM · Plasma, VDG
ngraham added a comment to T9658: Rethink blur-by-default for Breeze SDDM login screen theme for Plasma 5.15.

I gotta say, these ideas are super sexy! I would not at all mind doing this. However since they all require removing the blur, maybe we should focus on getting that done first.

Fri, Dec 7, 3:07 PM · Plasma, VDG