- User Since
- Apr 15 2017, 7:18 PM (138 w, 12 h)
Hmm, I'm not seeing any change, and the difference between open and maximized items is still too subtle IMO:
I really like the idea of making Files a tab that shows all the files from various places. Could you also add a "Recent" category for the file list?
Yep, in fact I mentioned this in the description section of the patch:
All right, sounds like I'm fighting the tide on this one. :)
Fri, Dec 6
I guess I should change my status to accepted given that I think this is good enough and already an improvement. But I think we can do even better, @niccolove. :)
There was a bug report about it that had some people agreeing with it. I think it makes a bit of sense because yes, this dialog is indeed only about keyboard shortcuts, and at least to my ears, the phrase "keyboard shortcuts" instantly connotes what this is about, while "shortcuts" is a more generic term that doesn't have such an instantly recognizable computer-related meaning.
Can we push this forward? I just triaged a bunch of bugs and found that https://bugs.kde.org/show_bug.cgi?id=370465 now has five duplicates. There seems to be quite a bit of demand for this.
No worries, we all miss things. :)
Maybe instead of "Unavailable", it could say "Not Running"?
We decided not to do this. There are now quite a few items in here and it seems like they're fine there.
I just landed an old patch of mine that adds a dedicated "focus/de-focus terminal panel" action to Dolphin: D10959
Should be fully completed with D24247.
Yeah, let's keep this the way it is. I think it's plenty comprehensible, and we never managed to come up with a good place to move them anyway.
ReviewBoard has been closed down now.
This is currently in progress and I don't think we need this task open anymore. The patches are scattered across various bits of infrastructure so it won't be useful for linking them here.
Very nice! I wonder if the symbol's meaning might be too obscure though (icons with no labels generally have poor usability; see https://www.nngroup.com/articles/icon-usability/). It's good to have a tooltip, but this won't help for the touch use case, or for the desktop.laptop users who don't think to hover the icon. Maybe a label in the KCM's footer explaining what that symbol means might help? There's room to the left of the buttons, so it wouldn't take up any additional vertical space.
Now the KCM doesn't load:
Oh that's the easy part. Check out the code in KScreen to see how it's possible to export values under a "kcm" namespace.
Cool, llet me know if you need a hand with anything, or would like like someone else to take over.
Awesome, this is super-dee-duper useful! +1!
Address review comments
https://bugs.kde.org/show_bug.cgi?id=369542 isn't closed, though. Should this be merged as-is, or does it need more review?
To me it makes sense to ship an internal profile that's equal to the default settings. That's kinda what profiles are, so it's a little odd to have the feature but not ship with one.
Thanks @davidedmundson. There's one more FIXME in the code that I could use your help with, if you don't mind.
Adjust to D25743 some more
You can see the name at https://cgit.kde.org/plasma-desktop.git/commit/?id=1db79dc54c464d159d4ff8e8c91452758c9aa220
Thu, Dec 5
@pavelmos would you like to continue working on this or should someone else take it over?
Haha yes almost exactly like that! Maybe today I'd use a sheet instead of a separate dialog window. But I have great faith that the 2019 David is able to conquer the challenges of 2009. :)
I think what was not working before was in fact a Konsole bug that has since been fixed in https://bugs.kde.org/show_bug.cgi?id=411181. Landing this now.
Oops, sorry! I added comments to D8773.
@lydia, is this something the Board could support?
All functionality works perfectly for me. However this regressed the default width of the settings window. Not it's not wide enough to accommodate all controls without an ugly horizontal scrollbar:
Thanks so much for this very nice contribution, @jguidon!
@davidre, is this okay now?
@sefaeyeoglu would yo like to continue working on this? Or should someone take it over?
@siddharthasahu would you like to continue working on this?
I guess it depends on whether you see pinned apps as clutter. Personally, I think these are useful, especially for less experienced users. And we have anecdotal evidence that experienced users (e.g. us) add these to their task managers manually. So I don't think this would harm anyone.
Looks like this guideline has since been added to the HIG. Sorry this patch sat here for ages like this!
Thanks, now it compiles! I'm not sure it's working perfectly though. I updated D25447 to use this, but it's claiming that my indexer is suspended, while balooctl status disagrees.
Update to work with D25743
Hmm, this doesn't look so great all on its own:
@apol does this still make sense to do in org.kde.discover.notifier.desktop.cmake?
@vpilo to move this forward, maybe just remove the header/title in the menu entirely. It's not really necessary after all.
@apol we have a duplicate test in breeze-icons now; is this still relevant?
Is this still relevant?
You can land this now, @shubham.