ngraham (Nathaniel Graham)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2017, 7:18 PM (31 w, 5 d)
Availability
Available

Recent Activity

Today

ngraham added a comment to D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.

Visually, it looks great to me!

Thu, Nov 23, 5:44 PM · Plasma
ngraham added a comment to D8332: Added baloo urls into places model.

I'm going to land this on 11/25/17 unless I hear any more objections from anyone.

Thu, Nov 23, 5:42 PM · Frameworks

Yesterday

ngraham added a comment to D8682: Improve some strings and UI elements in KWin KCM.

Can you resign from the revision then so you're not leaving unresolved negative feedback?

Wed, Nov 22, 6:30 PM · KWin
ngraham added a comment to D8798: Add xf86-input-libinput support for X11 mouse backend..

on kcm touchpad I still get "No touchpad found" (on my KDE Slimbook), this isn't a surprise as your patch doesn't touch the touchpad kcm. Should it?

Wed, Nov 22, 5:39 PM · Plasma
ngraham added a comment to D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.

After a lot of design work in VDG, we all agreed on the following:

Wed, Nov 22, 3:59 PM · Plasma
ngraham added a comment to D7246: Tooltips in Breeze theme.

Probably redo the patch so that it can apply to any theme.

Wed, Nov 22, 3:25 PM · Breeze, Plasma
ngraham updated the summary of D7246: Tooltips in Breeze theme.
Wed, Nov 22, 2:22 PM · Breeze, Plasma
ngraham accepted D8939: Offset the scrollbar by the header size.

Fantastic, that's perfect!

Wed, Nov 22, 2:19 PM · Kirigami
ngraham added a comment to D8787: Fix PWD dialog.

@ivan, what do you think?

Wed, Nov 22, 4:10 AM · Plasma
ngraham added a comment to D8682: Improve some strings and UI elements in KWin KCM.

@graesslin, is this looking okay now?

Wed, Nov 22, 3:59 AM · KWin
ngraham added a comment to D8791: Avoid inconsistent passworddialog.

@dfaure, does this look sane and sensible to you?

Wed, Nov 22, 3:36 AM · Frameworks
ngraham committed R318:a99348551676: Elide the label text on the statusbar in the middle (authored by ahmadsamir).
Elide the label text on the statusbar in the middle
Wed, Nov 22, 1:19 AM
ngraham closed D8927: Elide the label text on the statusbar in the middle.
Wed, Nov 22, 1:19 AM

Tue, Nov 21

ngraham added a comment to D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.
Tue, Nov 21, 10:40 PM · Plasma
ngraham accepted D8927: Elide the label text on the statusbar in the middle.

I like it.

Tue, Nov 21, 9:40 PM
ngraham updated the summary of D8927: Elide the label text on the statusbar in the middle.
Tue, Nov 21, 6:45 PM
ngraham added a comment to D8916: QML port of fonts kcm.

Could we possibly take the opportunity to turn font anti-aliasing on by default instead of leaving it with "Vendor Default" (a string that doesn't have any meaning to most users)?

Tue, Nov 21, 6:03 PM · Plasma
ngraham added a comment to D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.

I'm sorry @hein. I understand that this is pretty frustrating. Sometimes there's no substitute for seeing the actual implementation, I guess!

Tue, Nov 21, 3:54 PM · Plasma
ngraham added a comment to D8916: QML port of fonts kcm.

Needs more screenshots! :-)

Tue, Nov 21, 3:04 PM · Plasma
ngraham added a comment to D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.

Also as discussed in the VDG room this morning, there's the open question of whether we actually need a launch feedback KCM or whether these settings should be in the Task Manager's own settings.

Tue, Nov 21, 3:03 PM · Plasma
ngraham added a comment to D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.
  1. I think the labels with controls next to them need colons. It looks weird otherwise.
  2. We should vertically align the labels and their controls, just like @mmustac showed. That looks radically better.
Tue, Nov 21, 3:01 PM · Plasma

Mon, Nov 20

ngraham added a comment to D8822: Fix scrolling during inline renaming causes rename of wrong file.

My mistake, sorry.

Mon, Nov 20, 10:34 PM
ngraham added a comment to D8916: QML port of fonts kcm.

Can you mark this as resolving T7244, so that task will be automatically closed when this goes in?

Mon, Nov 20, 5:24 PM · Plasma
ngraham added a comment to D8449: Have a default backend (if one available).

@ivan? I know you had some reservations about the UI, but can we discuss those and either merge or abandon this?

Mon, Nov 20, 2:20 PM · Plasma
ngraham accepted D8791: Avoid inconsistent passworddialog.
Mon, Nov 20, 2:17 PM · Frameworks
ngraham added inline comments to D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.
Mon, Nov 20, 2:10 PM · Plasma
ngraham added a comment to D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.

Can you add "Resolves T7284" so this it will close that Maniphest task once this goes in?

Mon, Nov 20, 2:06 PM · Plasma

Sun, Nov 19

ngraham created D8893: By default, capture the cursor when invoking Active Window method with the global hotkey via Dbus.
Sun, Nov 19, 4:53 AM
ngraham added a comment to D8863: Give warnings when the file is modified externally.

This is in stark contrast to Kate and LibreOffice, where you are allowed to save back to disk:

Sun, Nov 19, 3:40 AM · Okular
ngraham committed R318:5bee1889e168: Fix scrolling during inline renaming causes rename of wrong file (authored by akrutzler).
Fix scrolling during inline renaming causes rename of wrong file
Sun, Nov 19, 3:37 AM
ngraham closed D8822: Fix scrolling during inline renaming causes rename of wrong file.
Sun, Nov 19, 3:37 AM
ngraham closed T7443: Rename inline: UI glitch during scrolling with mouse wheel as Resolved by committing R318:5bee1889e168: Fix scrolling during inline renaming causes rename of wrong file.
Sun, Nov 19, 3:37 AM · Dolphin
ngraham accepted D8822: Fix scrolling during inline renaming causes rename of wrong file.
Sun, Nov 19, 3:32 AM

Sat, Nov 18

ngraham added a comment to D4911: add Baloo DBus signals for moved or removed files.

Not to throw cold water on your patch (it's nice to see someone working on Baloo!), but perhaps we should continue @cullmann's work to move over to Tracker instead. It's an active project, and we would benefit from all the work that the GNOME people are putting into it. I fear that Baloo is destined to suffer a slow death from bitrot unless it gains at least one full-time maintainer. If that happens, Elisa won't be able to rely on it anyway, and that code will need to be removed or ported over to use Tracker (or whatever else we use instead).

Sat, Nov 18, 6:24 PM · Frameworks
ngraham added a comment to D8332: Added baloo urls into places model.

@ervin and @dvratil, I'd like to land this in one week, since it's an open dependency blocking a lot of great work in Dolphin. Please respond if you have any remaining concerns, and preferably update your status if you don't.

Sat, Nov 18, 2:57 PM · Frameworks
ngraham added a comment to D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.

The problem with that approach is that you'll wind up with a large number of number of panels to manage (Places, Devices, Search For, Recently Saved, Tags...) . Each one can have a scrollbar since its content is scrollable, so you'd wind up with four or five scrollviews immediately above one another, which is a poorer UX compared to the single scrollable view that the Places panel already offers. If we re-implement everything such that each panel never has a scrollview and has to be fit inside a master scrollview... then we've re-implemented exactly what we already have with the places panel.

Sat, Nov 18, 2:54 PM
ngraham added a comment to D8822: Fix scrolling during inline renaming causes rename of wrong file.

@rkflx, any remaining concerns, or should we land this?

Sat, Nov 18, 2:31 AM

Fri, Nov 17

ngraham added a comment to D8798: Add xf86-input-libinput support for X11 mouse backend..
$ kcmshell5 touchpad
kcm_touchpad: Using X11 backend
Fri, Nov 17, 9:14 PM · Plasma
ngraham added inline comments to D8863: Give warnings when the file is modified externally.
Fri, Nov 17, 8:23 PM · Okular
ngraham accepted D8798: Add xf86-input-libinput support for X11 mouse backend..

Thanks, looks good. Might wanna wait for at least one more review before committing.

Fri, Nov 17, 8:14 PM · Plasma
ngraham accepted D8822: Fix scrolling during inline renaming causes rename of wrong file.
Fri, Nov 17, 7:09 PM
ngraham added inline comments to D8822: Fix scrolling during inline renaming causes rename of wrong file.
Fri, Nov 17, 7:09 PM
ngraham added inline comments to D8822: Fix scrolling during inline renaming causes rename of wrong file.
Fri, Nov 17, 6:44 PM
ngraham added a comment to D8798: Add xf86-input-libinput support for X11 mouse backend..

@xuetianweng any update?

Fri, Nov 17, 6:07 PM · Plasma
ngraham added a comment to D8798: Add xf86-input-libinput support for X11 mouse backend..
Fri, Nov 17, 4:52 PM · Plasma
ngraham committed R134:732a0ffb2ab0: Don't use a scrollview to display package changelogs (authored by ngraham).
Don't use a scrollview to display package changelogs
Fri, Nov 17, 4:20 PM
ngraham closed D8869: Don't use a scrollview to display package changelogs.
Fri, Nov 17, 4:20 PM · Plasma
ngraham added a comment to D8869: Don't use a scrollview to display package changelogs.

@apol Thanks! I made one more change (the text of the "Info") button; does your approval still hold?

Fri, Nov 17, 4:13 PM · Plasma
ngraham updated the summary of D8869: Don't use a scrollview to display package changelogs.
Fri, Nov 17, 4:11 PM · Plasma
ngraham updated the diff for D8869: Don't use a scrollview to display package changelogs.

Also change "Open" button to say "More Information..." (it's not clear what you were opening before)

Fri, Nov 17, 4:10 PM · Plasma
ngraham updated the test plan for D8869: Don't use a scrollview to display package changelogs.
Fri, Nov 17, 4:00 PM · Plasma
ngraham updated the diff for D8869: Don't use a scrollview to display package changelogs.

Add a frame around the text if the box is extended

Fri, Nov 17, 4:00 PM · Plasma
ngraham added inline comments to D8863: Give warnings when the file is modified externally.
Fri, Nov 17, 3:54 PM · Okular
ngraham added a comment to D8692: QML mouse cursor KCM and components.
In D8692#168596, @mart wrote:

or perhaps relayout to 2 lines...

Fri, Nov 17, 3:45 PM · Plasma
ngraham updated the diff for D8869: Don't use a scrollview to display package changelogs.

Updating diff

Fri, Nov 17, 3:30 PM · Plasma
ngraham added a comment to D8869: Don't use a scrollview to display package changelogs.

IMHO the open button is superfluous for package updates anyway. It takes you to a view that doesn't even show you the changelogs.

Fri, Nov 17, 3:29 PM · Plasma
ngraham added a comment to F5495476: changelogs outside scrollview.png.

Hmm, yeah, perhaps a frame around all the text would look nicer. It
would look a bit off if there was only a frame around one of the three
bold-headered sections IMHO. I'll play with that a bit.

Fri, Nov 17, 3:23 PM
ngraham added a comment to D8869: Don't use a scrollview to display package changelogs.

If the changelog is like a thousand lines long, you can always just close it again. And I think it would actually be easier to read as one huge box than a tiny scrollview that only shows like 5 lines at a time.

Fri, Nov 17, 3:21 PM · Plasma
ngraham updated the summary of D8869: Don't use a scrollview to display package changelogs.
Fri, Nov 17, 3:09 PM · Plasma
ngraham created D8869: Don't use a scrollview to display package changelogs.
Fri, Nov 17, 3:07 PM · Plasma

Thu, Nov 16

ngraham committed R320:75a3723c45e3: Depend on KIO::PreviewJob::defaultPlugins() and KF 5.40 (authored by ngraham).
Depend on KIO::PreviewJob::defaultPlugins() and KF 5.40
Thu, Nov 16, 11:41 PM
ngraham closed D8847: Depend on KIO::PreviewJob::defaultPlugins() and KF 5.40.
Thu, Nov 16, 11:41 PM
ngraham added a comment to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.

If the ability to add a custom path is important, maybe we should put that under "Terminal options". I don't think we're ever going to figure out a functional UI for that single text field to work equally well for searching and entering a path with history.

Thu, Nov 16, 10:18 PM · Frameworks
ngraham added a comment to D8332: Added baloo urls into places model.

@ervin and @dvratil, any remaining concerns?

Thu, Nov 16, 8:46 PM · Frameworks
ngraham added a comment to D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.

Awesome. Please make sure to mark any dependent revisions.

Thu, Nov 16, 8:42 PM
ngraham committed R318:e60e3f07cf00: Use KConfig::readEntry()'s default argument properly (authored by ngraham).
Use KConfig::readEntry()'s default argument properly
Thu, Nov 16, 3:51 PM
ngraham closed D8846: Use KConfig::readEntry()'s default argument properly.
Thu, Nov 16, 3:51 PM
ngraham added a comment to D8692: QML mouse cursor KCM and components.

A scrollbar to show hidden buttons is a pretty bad UX. We should aim for something better in the new version. Perhaps the buttons should lose their text and become icons-only when the window is too narrow to show them all with icons and text.

Thu, Nov 16, 3:26 PM · Plasma
ngraham created D8847: Depend on KIO::PreviewJob::defaultPlugins() and KF 5.40.
Thu, Nov 16, 3:21 PM
ngraham created D8846: Use KConfig::readEntry()'s default argument properly.
Thu, Nov 16, 2:25 PM
ngraham committed R480:647ad063846b: Move sendImages plugin back to the Export category (authored by ngraham).
Move sendImages plugin back to the Export category
Thu, Nov 16, 4:46 AM
ngraham closed D8762: Move sendImages plugin back to the Export category.
Thu, Nov 16, 4:46 AM
ngraham added a comment to D8762: Move sendImages plugin back to the Export category.

Thanks!

Thu, Nov 16, 4:43 AM
ngraham added a comment to D8762: Move sendImages plugin back to the Export category.

@cgilles?

Thu, Nov 16, 3:08 AM
ngraham committed R128:472f9a7446da: Fix using avatars from the gallery and from local files (authored by ngraham).
Fix using avatars from the gallery and from local files
Thu, Nov 16, 2:53 AM
ngraham closed D8793: Fix using avatars from the gallery and from local files.
Thu, Nov 16, 2:53 AM · Plasma
ngraham committed R318:bebcf035d264: Turn on Dolphin icon previews by default (authored by ngraham).
Turn on Dolphin icon previews by default
Thu, Nov 16, 2:49 AM
ngraham closed D7440: Turn on Dolphin icon previews by default.
Thu, Nov 16, 2:49 AM · Dolphin

Wed, Nov 15

ngraham updated the diff for D7440: Turn on Dolphin icon previews by default.

Actually use the value of Plugins specified in the config, if it's present (this makes saving user plugin selections work again)

Wed, Nov 15, 11:45 PM · Dolphin
ngraham added a comment to D5109: [Kicker/App Entry] Try QIcon with path if no theme icon is found.

Yeah, putting workarounds everywhere isn't so appealing. My preference would be for a Qt fix, otherwise we'll be playing whack-a-mole here forever.

Wed, Nov 15, 9:40 PM · Plasma
ngraham accepted D8822: Fix scrolling during inline renaming causes rename of wrong file.
Wed, Nov 15, 7:39 PM
ngraham added a reviewer for D8822: Fix scrolling during inline renaming causes rename of wrong file: Dolphin.
Wed, Nov 15, 7:39 PM
ngraham added a comment to D8822: Fix scrolling during inline renaming causes rename of wrong file.

I've tested this and it works great. As soon as the unnecessary new function is removed, I'll approve it and will wait for @rkflx to review as well.

Wed, Nov 15, 6:53 PM
ngraham added a comment to D8793: Fix using avatars from the gallery and from local files.

Thanks for the approval. I'll land this, then the refactoring onto my to-do list. I agree that the current code is a bit stinky and could benefit from a more direct approach.

Wed, Nov 15, 4:04 PM · Plasma
ngraham accepted D8434: Created 'remote' section.
Wed, Nov 15, 2:24 PM · Frameworks
ngraham requested changes to D8798: Add xf86-input-libinput support for X11 mouse backend..
Wed, Nov 15, 2:18 PM · Plasma
ngraham accepted D8348: Add a section for removable devices.

This is not related with the change. I am working on that in a different branch.

Wed, Nov 15, 1:54 PM · Frameworks
ngraham accepted D8332: Added baloo urls into places model.
Wed, Nov 15, 6:17 AM · Frameworks
ngraham added a comment to D8434: Created 'remote' section.

@dfaure?

Wed, Nov 15, 6:13 AM · Frameworks
ngraham updated subscribers of D8793: Fix using avatars from the gallery and from local files.
Wed, Nov 15, 5:50 AM · Plasma
ngraham updated the diff for D8793: Fix using avatars from the gallery and from local files.

Restore correct diff

Wed, Nov 15, 5:49 AM · Plasma
ngraham updated the diff for D7440: Turn on Dolphin icon previews by default.

Rely on KF 5.40 and simplify the code a ton

Wed, Nov 15, 5:43 AM · Dolphin
ngraham updated the diff for D8793: Fix using avatars from the gallery and from local files.

Rely on KF 5.40 and simplify the code a ton

Wed, Nov 15, 5:37 AM · Plasma
ngraham updated the diff for D8793: Fix using avatars from the gallery and from local files.

Consider any source file in /tmp/ to be a temp file that we should clear, so we don't leak files when run by kcmshell5 (or anything similar)

Wed, Nov 15, 2:20 AM · Plasma

Tue, Nov 14

ngraham added inline comments to D8822: Fix scrolling during inline renaming causes rename of wrong file.
Tue, Nov 14, 11:46 PM
ngraham added a comment to D8793: Fix using avatars from the gallery and from local files.

@davidedmundson, does your approval still hold with the new change to clean up /tmp?

Tue, Nov 14, 8:48 PM · Plasma
ngraham updated the summary of D8793: Fix using avatars from the gallery and from local files.
Tue, Nov 14, 3:50 AM · Plasma
ngraham added a comment to D8415: Soften correctness of image file open check.

Actually @trufanov, would you mind doing it? I'd rather not commandeer your revision or commit it by hand, both of which will break the history here on phabricator.

Tue, Nov 14, 3:49 AM · Okular
ngraham committed R266:cb168d3a0bd5: Add missing icon sizes (authored by ngraham).
Add missing icon sizes
Tue, Nov 14, 3:02 AM
ngraham closed D7810: Add missing icon sizes.
Tue, Nov 14, 3:02 AM · Breeze, Frameworks