- User Since
- Apr 15 2017, 7:18 PM (78 w, 3 d)
Works and looks good to me!
+1 from me too.
Fix the Text Lines label and spinbox
Actually, the original wording is correct--or at least more correct.
Oops, found a few visual glitches. Will fix today.
Note: I know the width: 500 is a horrible hack that is certainly the wrong way to do this, but I couldn't figure out how else to get the Labels' width to be long enough so that Layout.alignment: Qt.AlignRight worked. Layout.fillWidth: true had no effect. I look forward to learning the correct way to handle this situation. :)
Improve another string
That worked, thanks! I've landed this for you.
Address review comments
Sun, Oct 14
Rather than making it optional and user-facing, how about automatically encrypting the if the user does not have an encrypted disk/homedir (if we can detect that), and never encrypting if they do?
Go for it!
"Safely remove all?" "Remove all"?
Since the icon is identical to others used on the same pop-up, and there is no real universal "Unmount all" icon, I would support the use of a text label for this button to go along with the icon.
+1, nice to see this. Once it lands, feel free to start porting apps to use it--for the ones where it'll be acceptable to depend on Frameworks 5.52 as a minimum version.
I'll be happy to do all the UI testing if you can do the code review!
"but you can just use SHIFT + PRT SC"
I like the separate window you've implemented, that seems like a good approach and then we can use the standard dialog.
Why can't we use the native KF5 one?
No longer needed with D15935 (or at least, the pressure is off).
Sat, Oct 13
Use safer static_cast<int>() instead of plain old int()
It may be defined, but it's not exactly clear. If we're going to allow an empty text field, we should set a placeholder string so that people can see what the actual pattern will be when the text field is empty. Also, this needs to be documented in the docbook.
Sorry, I'm not sure I understand. :(
Note: I'm not an expert at localization, so I'd appreciate a thorough review from the Localization folks to make sure I did the right thing. Thanks!
+1, this seems sensible.
Yeah, and I extended that to simply make it always visible (if it exists; apparently it only does when there's more than one Activity). That's what we want here too.
Yep, it works! Thanks @alexeymin!
Ah, I see. That seems like a fairly well-thought-out proposal!
Ah, I didn't even know that the Activity Switcher had a search field. I suspect that @sharvey, the fellow who did most of the work to improve the Widget Explorer's search field, didn't know either.
Nope, you're good. After @colomar changes his status to "Accepted", this can land.
Fri, Oct 12
[Just as a reminder: this is only for the login screen; the lock screen is not being touched]
I have no understanding of this code, but am adding some reviewers who do. :)
+1 for implementing the feature.
As far as I can tell, the blur won't work barring code changes to plasma-framework due to https://bugs.kde.org/show_bug.cgi?id=399686
Thu, Oct 11
I agree, if we keep the Dolphin-style menu-in-a-toolbar-button, we need to radically alter how it's generated, because right now it has many problems. Right now Dolphin just has a bunch of custom code to build it up form scratch, and it actually omits quite a few of the items in the real menu (e.g. see D15609). Obviously it is not ideal for functionality to be invisible like this, which runs counter to the entire purpose of having a main menu.
Bugzilla ticket: https://bugs.kde.org/show_bug.cgi?id=308331
This doesn't work for me. If I delete ~/.config/konsolerc* and ~/.local/share/konsole/*.profile, apply the patch, build konsole, and run it clean, I still see no profiles in Settings → Configure Konsole → Profiles.
Can you add CCBUG: 399659 to this so that bug report reflects that two commits were necessary to fully resolve it? Thanks!
We just got a bug report for this: https://bugs.kde.org/show_bug.cgi?id=399659
Please feel free!
@egorov, are you still around?
Sorry, it didn't work. I get the same merge failure.
Wed, Oct 10
Thanks! I'm working on the blur now. You also brought up in the VDG chat that the Virtual Keyboard, session chooser, and battery indicator icons need some better contrast too. Will also work on that.
I've updated the shadows and text according to VDG feedback from this morning and I'm feeling pretty good about the current state. Will try to work on blurry backgrounds for the icons now.
- Reduce shadow darkness
- Add subtle outlines
- Increase text size a bit
If we just shipped the largest size for each of them, it wouldn't amount to much more than 2 or 3 MB per wallpaper.
All right, ship it! Let's improve the icon in https://bugs.kde.org/show_bug.cgi?id=399613
If we don't want to do this, we should close the bug. If we don't want to do that, we should seriously evaluate whether or not to accept this patch.