ngraham (Nathaniel Graham)
User

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2017, 7:18 PM (122 w, 4 d)
Availability
Available

Recent Activity

Today

ngraham updated subscribers of D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses.

The text "change password" is not accurate when you're setting up a new user. For that case, it should say "set password". But the new user creation process is really weird and needs to be redone anyway, so maybe that's the better approach.

Thu, Aug 22, 3:13 PM · VDG, Plasma
ngraham added a comment to D23350: Chaning default iconSize in systemtray.

Looks to me that scaling is working just fine for system tray items in your screenshot. It's deliberate that they have that much padding on the top and bottom (at least with the default size settings).

Thu, Aug 22, 3:09 PM · Plasma
ngraham committed R134:1ce1bfa44b8e: Make on-page staus messages less huge so they don't compete with page titles (authored by ngraham).
Make on-page staus messages less huge so they don't compete with page titles
Thu, Aug 22, 2:59 PM
ngraham requested changes to D23350: Chaning default iconSize in systemtray.

The label says:

On high DPI systems those values would be scaled up, depending on the DPI

Thu, Aug 22, 2:50 PM · Plasma
ngraham accepted D23324: Show progress for PackageKit update fetching.

Thanks, this looks so much nicer now!

Thu, Aug 22, 2:11 PM · Plasma
ngraham added a comment to D22514: Show if KRunner is still searching for more things.
In D22514#502062, @apol wrote:

Please review D22540 so I can offer a better solution for @broulik's concerns.

You already fixed all of those, right?

IMHO the busy indicator should appear next to the results list, for example right on top of it, because the busy indicator is related to the results, not to the input text. A busy indicator in TextField might be understood as if something is going to happen inside that text field.

Thu, Aug 22, 1:21 AM · Plasma

Yesterday

ngraham added a comment to D23210: Add autosave feature.

Actually I was envisioning something even simpler:

Wed, Aug 21, 10:49 PM · Spectacle
ngraham added a comment to D23210: Add autosave feature.

Works great.

Wed, Aug 21, 9:54 PM · Spectacle
ngraham accepted D23307: [weather] [envcan] Add additional current condition icon mappings.
Wed, Aug 21, 9:44 PM · Plasma
ngraham accepted D23322: Add new touch-friendly drag handlers.

It works perfectly. Nicely done. The circle sizes seem just right, too.

Wed, Aug 21, 9:44 PM · Spectacle
ngraham added a comment to D23330: Make manual control compatible with redshift >= 1.12.

Is redshift -P -O fully backwards-compatible with older versions of redshift? If not, then this will just break everyone not using >=1.12.

Wed, Aug 21, 8:55 PM · Plasma
ngraham committed R124:0405685ddbbd: Merge branch 'Plasma/5.16' (authored by ngraham).
Merge branch 'Plasma/5.16'
Wed, Aug 21, 7:24 PM
ngraham committed R124:7f8d58958df9: Exclude other desktop file from AppStream metadata generation (authored by ngraham).
Exclude other desktop file from AppStream metadata generation
Wed, Aug 21, 7:24 PM
ngraham closed D23328: Exclude other desktop file from AppStream metadata generation.
Wed, Aug 21, 7:24 PM · Plasma
ngraham added a comment to D23328: Exclude other desktop file from AppStream metadata generation.
In D23328#516191, @mak wrote:

Effect is kdesystemsettings.desktop not being shown in any software center.
LGTM

Wed, Aug 21, 7:15 PM · Plasma
ngraham added a comment to T10783: Right-click on touch.

IIRC the objection was that making press-and-hold always mean right-click at the toolkit level could interfere with apps that want to re-implement the press-and-hold behavior for some other behavior. For example a lot of Android apps use press-and-hold to mean "make this list/view editable".

Wed, Aug 21, 7:07 PM · Plasma, VDG
ngraham added a comment to D23306: Add AppStream metadata file.

All right, hopefully the third time's the charm: D23328

Wed, Aug 21, 7:02 PM · Plasma
ngraham requested review of D23328: Exclude other desktop file from AppStream metadata generation.
Wed, Aug 21, 7:02 PM · Plasma
ngraham committed R124:7e018de5d771: Merge branch 'Plasma/5.16' (authored by ngraham).
Merge branch 'Plasma/5.16'
Wed, Aug 21, 6:59 PM
ngraham committed R124:16a43f64532b: Use non-deprecated .metainfo.xml filename extension (authored by ngraham).
Use non-deprecated .metainfo.xml filename extension
Wed, Aug 21, 6:58 PM
ngraham closed D23325: Use non-deprecated .metainfo.xml filename extension.
Wed, Aug 21, 6:58 PM · Plasma
ngraham updated the diff for D23325: Use non-deprecated .metainfo.xml filename extension.

You assume far too much competance on my part :)

Wed, Aug 21, 6:57 PM · Plasma
ngraham added a comment to D23306: Add AppStream metadata file.

@ngraham You used the "appdata.xml" file suffix here. I noticed yesterday when reading the spec that it now declares that as legacy suffix:

While desktop-application metadata is commonly stored in /usr/share/metainfo/%{id}.metainfo.xml (with a .metainfo.xml extension), using a .appdata.xml extension is also permitted for this component type for legacy compatibility.

From https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html

Given Plasma targets newer system, perhaps it makes sense to start right away with a metainfo.xml suffix?

Wed, Aug 21, 6:23 PM · Plasma
ngraham requested review of D23325: Use non-deprecated .metainfo.xml filename extension.
Wed, Aug 21, 6:23 PM · Plasma
ngraham committed R124:b01fc96fb932: fix XML syntax (authored by jriddell).
fix XML syntax
Wed, Aug 21, 6:21 PM
ngraham added a comment to D23210: Add autosave feature.

Needs a rebase

Wed, Aug 21, 5:53 PM · Spectacle
ngraham added a comment to D23322: Add new touch-friendly drag handlers.

There is actually one "problem" I noticed. If you resize the rectangle from big to small (where the handles become free-floating), the cursor is at the end still there, where the handler should be in the normal mode. So the handler moved away from the cursor and you have to move the cursor back to the drag handler, if you want to resize the rectangle again. I'm actually not quite sure if that's a problem, but it's definitely different to how it behaved before the patch. One possible solution would be to move the cursor automatically to the drag handler it grabbed before. But it might look strange if the cursor suddenly jumps somewhere else?
Some opinions on this would be great!

Wed, Aug 21, 5:48 PM · Spectacle
ngraham added a comment to D22708: [WIP] Add a kded module infra for fuse mount services.

Oh good. :) Is there anywhere I can follow the progress?

All my work goes on KIOFuse goes into review here:
https://gitlab.com/Vogtinator/kio-fuse/merge_requests

Thanks!

Wed, Aug 21, 5:41 PM · Frameworks
ngraham added a comment to D23324: Show progress for PackageKit update fetching.

And finally, it would be nice to display the text + progress indicator in the center of the view, not at the very top.

Wed, Aug 21, 5:39 PM · Plasma
ngraham added a comment to D23324: Show progress for PackageKit update fetching.

Also hide the placeholder icon while the progress indicator is visible so this doesn't happen:

Wed, Aug 21, 5:38 PM · Plasma
ngraham added a comment to D22708: [WIP] Add a kded module infra for fuse mount services.

Oh good. :) Is there anywhere I can follow the progress?

Wed, Aug 21, 5:35 PM · Frameworks
ngraham added inline comments to D23322: Add new touch-friendly drag handlers.
Wed, Aug 21, 5:16 PM · Spectacle
ngraham added a comment to D23322: Add new touch-friendly drag handlers.

In testing it out, I really like it! I might even make the handles a bit larger for more touch-friendliness. Not a lot larger, just a bit.

Wed, Aug 21, 4:28 PM · Spectacle
ngraham updated the summary of D23283: When asked to switch sessions, jump to session creation if there's nothing to switch to.
Wed, Aug 21, 4:22 PM · Plasma
ngraham updated subscribers of D23300: Add FictionBook 2 icons.

LGTM. @ndavis?

Wed, Aug 21, 4:21 PM · Frameworks
ngraham committed R166:172e40bd9835: Add option to additionally save screenshot to clipboard (authored by aprcela).
Add option to additionally save screenshot to clipboard
Wed, Aug 21, 4:20 PM
ngraham closed D23162: Add option to additionally save screenshot to clipboard.
Wed, Aug 21, 4:20 PM · Spectacle
ngraham added a comment to D23162: Add option to additionally save screenshot to clipboard.

There we go, much better. Congrats on the nice big patch landed!

Wed, Aug 21, 4:20 PM · Spectacle
ngraham added a comment to D23322: Add new touch-friendly drag handlers.

Thanks for the patch! There are some formatting and whitespace issues here; could you fix those up first?

Wed, Aug 21, 4:19 PM · Spectacle
ngraham added reviewers for D23322: Add new touch-friendly drag handlers: Spectacle, VDG.
Wed, Aug 21, 4:16 PM · Spectacle
ngraham updated the summary of D23322: Add new touch-friendly drag handlers.
Wed, Aug 21, 4:15 PM · Spectacle
ngraham updated the diff for D23283: When asked to switch sessions, jump to session creation if there's nothing to switch to.

Adjust to the fact that the Switch user button is always visible now

Wed, Aug 21, 4:14 PM · Plasma
ngraham updated the diff for D23283: When asked to switch sessions, jump to session creation if there's nothing to switch to.

Rebase

Wed, Aug 21, 3:46 PM · Plasma
ngraham committed R120:de409edb4900: [Lock screen] Always show "Switch User" button regardless of whether fake… (authored by ngraham).
[Lock screen] Always show "Switch User" button regardless of whether fake…
Wed, Aug 21, 3:40 PM
ngraham closed D23279: [Lock screen] Always show "Switch User" button regardless of whether fake "switch user" item is shown.
Wed, Aug 21, 3:40 PM · Plasma
ngraham committed R120:41d59d6cdbda: Merge branch 'Plasma/5.16' (authored by ngraham).
Merge branch 'Plasma/5.16'
Wed, Aug 21, 3:27 PM
ngraham committed R120:d753fa01679d: Tell AppStream generators not to index Klipper .desktop files (authored by ngraham).
Tell AppStream generators not to index Klipper .desktop files
Wed, Aug 21, 3:26 PM
ngraham closed D23320: Tell AppStream generators not to index Klipper .desktop files.
Wed, Aug 21, 3:26 PM · Plasma
ngraham committed R124:1746125e6e41: Merge branch 'Plasma/5.16' (authored by ngraham).
Merge branch 'Plasma/5.16'
Wed, Aug 21, 3:22 PM
ngraham committed R124:b249a3d4e76e: Add AppStream metadata file (authored by ngraham).
Add AppStream metadata file
Wed, Aug 21, 3:22 PM
ngraham closed D23306: Add AppStream metadata file.
Wed, Aug 21, 3:22 PM · Plasma
ngraham updated the diff for D23306: Add AppStream metadata file.

Remove unnecessary X-AppStream-Ignore property

Wed, Aug 21, 3:16 PM · Plasma
ngraham updated the summary of D23321: Indicate appsteam the ps desktop file isn't a separate application.
Wed, Aug 21, 3:02 PM · KDevelop
ngraham accepted D23321: Indicate appsteam the ps desktop file isn't a separate application.

Yep, according to @mak, this should work.

Wed, Aug 21, 3:02 PM · KDevelop
ngraham requested review of D23320: Tell AppStream generators not to index Klipper .desktop files.
Wed, Aug 21, 2:55 PM · Plasma
ngraham added a comment to D23300: Add FictionBook 2 icons.

Haha that pink might be a bit too un-brutalist. :) Orange-on-pink isn't exactly the best color combination. A blue background of some sort might be nicer with the orange polygon.

Wed, Aug 21, 2:17 PM · Frameworks
ngraham added a comment to D23162: Add option to additionally save screenshot to clipboard.

Looks like you have some non-UNIX line endings that our commit hookscript complains about when I try to land the patch:

Wed, Aug 21, 2:15 PM · Spectacle
ngraham accepted D23162: Add option to additionally save screenshot to clipboard.

Very nice work.

Wed, Aug 21, 2:12 PM · Spectacle
ngraham added a comment to D23049: Add Kirigami ListSectionHeader component.

After living with this for a bit, I feel like maybe the following UI changes might be good to make the effect a bit more subtle:

  • Reduce the opacity of the gray background bit so the header doesn't feel like "a hole in the view"
  • Experiment with removing or reducing the strength of the horizontal line separators above and below the header text
Wed, Aug 21, 1:40 PM · Kirigami
ngraham added a comment to D23300: Add FictionBook 2 icons.

Better, thanks! Any chance you could make the gray background color a bit different? Maybe lighter, or some other color? That particular gray isn't a very attractive color IMO. It's very brutalist. :)

Wed, Aug 21, 1:36 PM · Frameworks

Tue, Aug 20

ngraham updated the summary of D23279: [Lock screen] Always show "Switch User" button regardless of whether fake "switch user" item is shown.
Tue, Aug 20, 9:45 PM · Plasma
ngraham updated the diff for D23279: [Lock screen] Always show "Switch User" button regardless of whether fake "switch user" item is shown.

Re-add other conditions

Tue, Aug 20, 9:45 PM · Plasma
ngraham updated the summary of D23279: [Lock screen] Always show "Switch User" button regardless of whether fake "switch user" item is shown.
Tue, Aug 20, 9:45 PM · Plasma
ngraham added a comment to D23279: [Lock screen] Always show "Switch User" button regardless of whether fake "switch user" item is shown.

No, you're right, those should still be there.

Tue, Aug 20, 9:44 PM · Plasma
ngraham added reviewers for D23117: kcmlookandfeel - Correctly set the Splash Screen to what the Look & Feel intends for it to be set to: davidedmundson, mart.
Tue, Aug 20, 9:29 PM · Plasma
ngraham updated the test plan for D23279: [Lock screen] Always show "Switch User" button regardless of whether fake "switch user" item is shown.
Tue, Aug 20, 9:28 PM · Plasma
ngraham updated the diff for D23279: [Lock screen] Always show "Switch User" button regardless of whether fake "switch user" item is shown.

Always show the button

Tue, Aug 20, 9:25 PM · Plasma
ngraham updated the diff for D23306: Add AppStream metadata file.

Add project_group and compulsory_for_desktop tags

Tue, Aug 20, 9:21 PM · Plasma
ngraham added a comment to D23306: Add AppStream metadata file.

@mak The link https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-compulsory_for_desktop seems broken. I found a reference to compulsory_for_desktop at https://www.freedesktop.org/software/appstream/docs/chap-CollectionData.html, but it points to a nonexistent page.

Tue, Aug 20, 9:16 PM · Plasma
ngraham added a comment to D23279: [Lock screen] Always show "Switch User" button regardless of whether fake "switch user" item is shown.

What if someone else is logged in, they locked their screen and I want to switch the session?

Then there are multiple sessions because you're already logged-in, so the button will be visible and you'll be able to get to your session. Or are you thinking with a multi-user system where user A logs in and locks the screen, and then user B wants to log in? Hmm.

Tue, Aug 20, 9:05 PM · Plasma
ngraham updated the test plan for D23279: [Lock screen] Always show "Switch User" button regardless of whether fake "switch user" item is shown.
Tue, Aug 20, 9:03 PM · Plasma
ngraham updated the summary of D23283: When asked to switch sessions, jump to session creation if there's nothing to switch to.
Tue, Aug 20, 8:43 PM · Plasma
ngraham added a comment to D23306: Add AppStream metadata file.

In fact there are three possible relationships:

  • App is associated with desktop, but not required by it or limited to it (e.g. Dolphin, Gwenview, Nautilus, GNOME Music)
  • App requires desktop (e.g. KDE System Settings, GNOME System Settings, GNOME Tweaks)
  • Desktop requires app (e.g. KDE System Settings, GNOME System Settings)
Tue, Aug 20, 8:34 PM · Plasma
ngraham added a comment to D23306: Add AppStream metadata file.
In D23306#515589, @mak wrote:

Adjust according to review comments

This will work. I would change <name>System Settings</name> to <name> KDE System Settings</name> or <name>Plasma System Settings</name>, just like GNOME sets a name like "GNOME Videos" instead of "Videos" in their metadata. Otherwise this name will confuse users of GNOME, I guess.

Tue, Aug 20, 8:18 PM · Plasma
ngraham updated the diff for D23306: Add AppStream metadata file.

Add <provides> tag so searching for it from the old URLs still works

Tue, Aug 20, 8:06 PM · Plasma
ngraham added a comment to D23306: Add AppStream metadata file.

Thanks for the into @mak, that's very helpful. I've removed one of the launchable tags since only one .desktop file has the info that you would want to use to launch it as a KDE user. And I've added X-AppStream-Ignore=true to one of the .desktop files.

Tue, Aug 20, 8:03 PM · Plasma
ngraham updated the diff for D23306: Add AppStream metadata file.

Adjust according to review comments

Tue, Aug 20, 8:02 PM · Plasma
ngraham added a reviewer for D23307: [weather] [envcan] Add additional current condition icon mappings: kossebau.
Tue, Aug 20, 7:51 PM · Plasma
ngraham added a comment to D23286: Prevent dragging SimpleKCM contents outside view.

Ah ok.

Tue, Aug 20, 7:48 PM · Frameworks
ngraham resigned from D23307: [weather] [envcan] Add additional current condition icon mappings.

Ah ok.

Tue, Aug 20, 7:47 PM · Plasma
ngraham requested changes to D23307: [weather] [envcan] Add additional current condition icon mappings.

Change "rainshowers" to "rain showers" ("rainshower" isn't a word)

Tue, Aug 20, 7:46 PM · Plasma
ngraham requested changes to D23300: Add FictionBook 2 icons.

Interesting design! However having that triangular part jutting out of the side is pretty unusual, and not seen in any other MimeType icons. Maybe move that shape fully inside and copy the visual style of existing book-style icons, such as application-pdf application-epub+zip . Generally they have a sort of book-like appearance with a line on the left side for the book's spine.

Tue, Aug 20, 7:44 PM · Frameworks
ngraham updated the test plan for D23306: Add AppStream metadata file.
Tue, Aug 20, 7:38 PM · Plasma
ngraham updated the test plan for D23306: Add AppStream metadata file.
Tue, Aug 20, 7:36 PM · Plasma
ngraham abandoned D23302: Stop installing two desktop files.
Tue, Aug 20, 7:34 PM · Plasma
ngraham updated subscribers of D23302: Stop installing two desktop files.

Abandoning in favor of D23306, which adds an AppStream metadata file with multiple launchable tags. If I'm reading the docs right, this should allow the information from the referenced .desktop files to NOT be merged into the data from the appdata.xml file, which, if it works, should be the right approach for KDevelop too. Hopefully @mak will chime in regarding whether this is accurate or not.

Tue, Aug 20, 7:34 PM · Plasma
ngraham requested review of D23306: Add AppStream metadata file.
Tue, Aug 20, 7:32 PM · Plasma
ngraham added a comment to D23302: Stop installing two desktop files.

Those are excellent questions. Reading through https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html, it seems like .desktop files only get parsed if there's no appdata.xml file--which indeed, System Settings lacks. Maybe that's the right approach here...

Tue, Aug 20, 7:17 PM · Plasma
ngraham requested review of D23302: Stop installing two desktop files.
Tue, Aug 20, 6:54 PM · Plasma
ngraham closed D23301: [Cuttlefish] Use only a single AppStream ID.
Tue, Aug 20, 6:39 PM · Plasma
ngraham committed R118:06912303ea4b: [Cuttlefish] Use only a single AppStream ID (authored by ngraham).
[Cuttlefish] Use only a single AppStream ID
Tue, Aug 20, 6:39 PM
ngraham committed R118:8b3e70d0f3b7: Merge branch 'Plasma/5.16' (authored by ngraham).
Merge branch 'Plasma/5.16'
Tue, Aug 20, 6:39 PM
ngraham added a comment to D23298: Unify busy spinner appearance on update page.

If there's a way to show an actual progress indicator in a way that ensures its accuracy, that would be much better, yeah. I'll be happy to abandon this patch if you can do that (I don't know how, sorry).

Tue, Aug 20, 6:38 PM · Plasma
ngraham requested review of D23301: [Cuttlefish] Use only a single AppStream ID.
Tue, Aug 20, 6:35 PM · Plasma
ngraham committed R120:a1654867e784: [Battery Monitor] Call battery capacity "Capacity degradation" for better… (authored by ngraham).
[Battery Monitor] Call battery capacity "Capacity degradation" for better…
Tue, Aug 20, 5:46 PM
ngraham closed D23271: [Battery Monitor] Call battery capacity "Capacity degradation" for better clarity.
Tue, Aug 20, 5:46 PM · Plasma
ngraham committed R102:c7984fa8548c: [Energy] Put battery capacity info in battery section and call it "Capacity… (authored by ngraham).
[Energy] Put battery capacity info in battery section and call it "Capacity…
Tue, Aug 20, 5:46 PM
ngraham closed D23270: [Energy] Put battery capacity info in battery section and call it "Capacity degradation".
Tue, Aug 20, 5:46 PM · Plasma
ngraham updated the summary of D23271: [Battery Monitor] Call battery capacity "Capacity degradation" for better clarity.
Tue, Aug 20, 5:45 PM · Plasma
ngraham updated the test plan for D23271: [Battery Monitor] Call battery capacity "Capacity degradation" for better clarity.
Tue, Aug 20, 5:44 PM · Plasma