- User Since
- Apr 15 2017, 7:18 PM (130 w, 1 d)
Could also port entirely away from PlasmaComponents and PlasmaExtras without too much effort. I suppose that's best done on a separate patch though.
Typically the color chooser includes a "transparent" item.
Do we know why it's rendered incorrectly when not opaque? Is this a bug in Okular or Poppler?
I think that makes sense.
Can you make the gradient extend all the way to the top of the white center area?
So what happens when the user clicks the 90 and 270 degree rotation icons in the KScreen KCM with this change applied? Nothing? If so, I would recommend disabling or remove those buttons instead. You don't want to have UI elements that do nothing.
This is a lot nicer. I think we could even get rid of the More Options/Fewer Options toggle button and just always show the search options now that they don't take up much space.
This results in the purpose functionality disappearing even though I have Purpose installed.
This fixes the issue for the preview image of the currently-viewed theme, but not for the thumbnail images:
Fri, Oct 11
Please feel free to send a Plasma patch!
@mglb would you be interesting in submitting patches with those new icons?
Interesting, this sorta-kinda implements what's requested in 412483.
The new button in the toolbar should hide the search field if it's visible (i.e. it should be a toggle action), and the search field should be inside its own background or toolbar with appropriate padding, not just floating there in space.
Heh the sidebar ampersand fix appears to have had a side effect:
Oh one final thing I just thought of: it would be great if the search field could be in the main toolbar rather than in the sidebar, because this makes it inaccessible when the sidebar is collapsed, as it is by default. People might mistakenly assume that there's no search.
Great, that's fixed the ampersand.
Yeah there are windy and rainy conditions too. I expect we can handle those as well once we get appropriate icons.
Thanks! I'll wait for the icon patch to land before landing this.
All right, sure.
Oh and one more: ampersands aren't appearing in the category text in the sidebar:
A few more:
- List the categories in a more common order rather than alphabetical (i.e. first smilies, then nature, then food & drink, etc. Basically copy the mobile emoji pickers)
- The window needs a proper icon, not the generic X11 icon
- This might be in Kirigami, but the header text jumps around when I click on the X button to hide the drawer entirely:
- For the first-run use case, show the All category instead of Recent, or any other time when "Recent" is empty
- How does it work? When I click on an emoji, the window disappears but nothing appears to happen. Its not in the clipboard either?
- Every time I move the cursor over an emoji, file:///usr/lib/qt/qml/QtQuick/Controls.2/org.kde.desktop/ToolTip.qml:48:5: Unable to assign [undefined] to bool is printed to the console
We don't have any KCMs that are duplicated in both locations though, right? What's the harm in looking in kcms/ first, and then if nothing is found, looking ine level below that?
Nice. Can you make this the preferred path for KCMs, in fact? That would improve life when testing a patch that moves a KCM to the kcms/ sub-folder.
Nice. We'll also need a patch to remove icon theme configuration from the GTK KCM that depends on this patch so we can land that as soon as this lands.
The idea is to move all the functionality in kde-gtk-config here, then delete it. See the parent Phab task for details.
How can I test this out? Do I need to have IBus set up?
Thu, Oct 10
@bruns, does this make sense to you?
This doesn't apply cleanly on master. Can you rebase it?
Remove old unused enum from the first revision
Handle windy + cloudy conditions as well now that we have appropriate icons
That was my impression too, but upon further examination, the noaa_i18n.dat file has strings that indicate windyness in addition to other conditions, and if I add a complex conditional to the data engine, I can see that the windy + cloudy condition is getting hit (it is in fact windy and partly cloudy today, lucky me):
Also one more thing, sorry: -wind should go before -night in the night versions.
Looks like there are some gaps in the windy overcast icon:
FWIW Plasma 5.17 tars were already made so if we want this in Plasma 5.17.0, in addition to landing it on the stable branch, @jriddell will have to do some release magic to include it and you'll want to ping him about that.
Idea for a better string: "Fill each row/column before adding tasks to the next row/column"
Thanks David, that's very helpful. Let's revert this in Plasma 5.17 for now (if translators approve) and work on a better string (or even a better UI) for Plasma 5.18.
After playing around with this option with my IOTM at various panel widths and various "maximum rows/columns" values, I still cannot for the life of me figure out what on earth it does--or else the feature is so buggy I'm unable to discover the pattern.
@cameronrodgers I think renaming the variable is OK. Please feel free to continue the work on this.
Do you mean the equivalent of a column layout, with a horizontal line under the title?
I had a feeling. I say let's land this, then fix that. Do you agree?
That should be fixed by D24402, in plasma-framework. Can you verify that it's fixed if you apply that or build plasma-framework from master?
"rows of as many columns"
Thanks for testing that, @sefaeyeoglu. I don't actually have a combination of devices that makes the combobox appear so that's much appreciated.
Fix overflow in the applet and poor alignment in the KCM when the combobox is visible
Wed, Oct 9
LGTM! Would be nice to fix some of these bugs in follow-up patches too: https://bugs.kde.org/buglist.cgi?component=kcm_baloo&list_id=1669138&product=systemsettings&resolution=---
Why is kcms/colors/CMakeLists.txt being changed? Looks unrelated.