- User Since
- Apr 15 2017, 7:18 PM (104 w, 6 d)
Yeah, that makes sense. I'll make it only elide left when showing the full path.
New icon just landed in D20672. The name is preferences-desktop-thunderbolt.
I've been told that @bruns can review this sometime next week. :)
Wow, that's quite beautiful. Thumbs up from me now!
If you tag VDG, it's nice to add screenshots. :)
Thu, Apr 18
And we also need to give this page a spinner, just like the Updates page has.
Looks fantastic visually!
largeSpacing -> smallSpacing
Even better! I think that gradient ends up a bit too light on top though. Let's make it a bit more subtle.
Ooh, I like that! Maybe make the thunderbolt a bit smaller inside the circle though?
From this discussion as well as comments in #kde-devel and elsewhere, it seems like there's a deeper issue: dissatisfaction with how the KDE Applications bundle is handled. The question of "what should apps' version numbers be?" seems impossible to even discuss properly before we've resolved people's concerns with the bundle. Let's break that out into a new discussion.
Fixed that in D20664.
Thanks! Generally we use colorful icons for KCMs. I think this could use a bit more pizazz. :) Maybe make it yellow, and/or put it on top of a circular colored background or something?
Submit it in a patch to breeze-icons! :)
- Fix button height issue
- Add padding between sections
- Add vertical spacing between button categories
- Rename to "General" and use appropriate icon
Thanks for this!
Did this fix https://bugs.kde.org/show_bug.cgi?id=406642?
Revert single/double-click changes
@mart did this in the correct way instead!
I can split the diff to remove the click changes, sure.
Does this app always have to run as root? If so, that would be why that code is in there. If not, then yeah, it's superfluous now.
Wed, Apr 17
Unfortunately this caused https://bugs.kde.org/show_bug.cgi?id=405780. Specifically, the change to src/dolphinmainwindow.cpp.
That's all true, yeah. I see more and more people asking for an automatic color scheme switching system these days. So we might want to consider adding this feature in some manner.
arc, you are driving me crazy
Remove unintentional change
Use implicitHeights for headers and footers
Remove accidentally added change
Take headers and padding into account for height calculation
Use onPressed And Layout.preferredHeight (still doesn't fix the button height though)
For user interfaces where you want single-click-to-open, but allow multi-item selection, I think a dedicated selection mode is generally the way to go. On mobile, entering this mode is accomplished by pressing -and-holding on an item (Android) or tapping the Select button on a toolbar somewhere (iOS). On the desktop, those would be supplemented by the typical ctrl+click selection method for expert users who use keyboards shortcuts.
This looks fine to me, but let's let a Plasma person weigh in too. :)
I can wait, it's hardly urgent. :)
Thanks! Given that Elisa has a settings window, I would recommend locating the setting there rather than having a menu item for it in the hamburger menu.
Tue, Apr 16
I'm afraid I don't have the answers to those questions. :(
Good idea, but the problem I keep running into is that flickable.contentHeight is set to 0 here.
You've already got my approval. :)