ngraham (Nathaniel Graham)
User

Projects (15)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2017, 7:18 PM (130 w, 1 d)
Availability
Available

Recent Activity

Yesterday

ngraham accepted D24616: [applets/systemtray] Remove unused imports.

Could also port entirely away from PlasmaComponents and PlasmaExtras without too much effort. I suppose that's best done on a separate patch though.

Sun, Oct 13, 6:23 PM · Plasma
ngraham added a dependent revision for D24612: Use the text rather than highlight color for rating/star emblem: D24613: Use a lighter star color for non-default devices.
Sun, Oct 13, 4:20 PM · Frameworks
ngraham requested review of D24613: Use a lighter star color for non-default devices.
Sun, Oct 13, 4:20 PM · Plasma
ngraham requested review of D24612: Use the text rather than highlight color for rating/star emblem.
Sun, Oct 13, 4:10 PM · Frameworks
ngraham updated the task description for T8552: Polish Open/Save dialogs.
Sun, Oct 13, 3:23 PM · Frameworks, VDG
ngraham added a comment to D15580: [WIP] New annotation toolbar.

Typically the color chooser includes a "transparent" item.

Sun, Oct 13, 2:26 PM · Okular
ngraham added a comment to D24606: Prevent user changing the stamp opacity.

Do we know why it's rendered incorrectly when not opaque? Is this a bug in Okular or Poppler?

Sun, Oct 13, 2:25 PM · Okular
ngraham added a comment to T11746: Make it possible to only apply certain parts of a Global Theme.

I think that makes sense.

Sun, Oct 13, 2:00 PM · VDG, Plasma
ngraham accepted D24598: Update elisa icon.

Lovely!

Sun, Oct 13, 1:39 PM · Elisa, Frameworks
ngraham added a comment to D24598: Update elisa icon.

Can you make the gradient extend all the way to the top of the white center area?

Sun, Oct 13, 2:47 AM · Elisa, Frameworks
ngraham added a comment to D24112: [platforms/drm] Disable transformations.

So what happens when the user clicks the 90 and 270 degree rotation icons in the KScreen KCM with this change applied? Nothing? If so, I would recommend disabling or remove those buttons instead. You don't want to have UI elements that do nothing.

Sun, Oct 13, 2:45 AM · KWin
ngraham added a comment to D24602: New design for extended search options.

This is a lot nicer. I think we could even get rid of the More Options/Fewer Options toggle button and just always show the search options now that they don't take up much space.

Sun, Oct 13, 2:39 AM · Dolphin
ngraham added reviewers for D24576: Don't link directly against Purpose for sharing: nicolasfella, apol.

This results in the purpose functionality disappearing even though I have Purpose installed.

Sun, Oct 13, 2:23 AM · Gwenview
ngraham added a reviewer for D24564: Fix warning when we're not hovering a Control: mart.
Sun, Oct 13, 2:21 AM · Plasma
ngraham added a comment to D24537: Icons for windy weather.

Sadly the weather applet is pretty low on my interest, actually would be happy to have someone take over maintainance/care.

Sun, Oct 13, 2:20 AM · Frameworks
ngraham added a comment to D24593: Modified breeze shadows.

I'm sorry, when I use scour on svg files, it looks like git does not recognize that the file has changed. How can I fix that?

Sun, Oct 13, 2:16 AM · Frameworks
ngraham added a comment to D24591: Set preview to correct device size.

This fixes the issue for the preview image of the currently-viewed theme, but not for the thumbnail images:

Sun, Oct 13, 2:11 AM · Plasma
ngraham added a comment to D17732: Respect animation settings.

Please feel free to send a Plasma patch!

That was the plan, but I don't have a dev environment for plasma set up, and submitting patches that don't even compile is a bit embarrassing. :-)

But fixing that should fix animations in other Qt apps with custom widgets as well.

Sun, Oct 13, 2:08 AM · Gwenview
ngraham added a comment to D24454: Include an emoji picker.
In D24454#545543, @apol wrote:

Fix on wayland (and x11?)

Don't ever close the process, leave it on background

Sun, Oct 13, 2:07 AM · VDG, Plasma

Fri, Oct 11

ngraham added inline comments to D24567: WIP: Implement sidebar mode for system tray plasmoid popups.
Fri, Oct 11, 8:08 PM · Plasma
ngraham added a comment to D17732: Respect animation settings.

Please feel free to send a Plasma patch!

Fri, Oct 11, 8:01 PM · Gwenview
ngraham added a comment to T10243: Some KDE applications could use better icons.

@mglb would you be interesting in submitting patches with those new icons?

Fri, Oct 11, 7:11 PM · KDE Applications, VDG
ngraham added a comment to D24567: WIP: Implement sidebar mode for system tray plasmoid popups.

Interesting, this sorta-kinda implements what's requested in 412483.

Fri, Oct 11, 6:49 PM · Plasma
ngraham added a project to T11859: Understanding and reducing bad performance impact of running Baloo under certain conditions: Frameworks.
Fri, Oct 11, 6:13 PM · Frameworks, Baloo
ngraham added a comment to D24454: Include an emoji picker.

The new button in the toolbar should hide the search field if it's visible (i.e. it should be a toggle action), and the search field should be inside its own background or toolbar with appropriate padding, not just floating there in space.

Fri, Oct 11, 5:06 PM · VDG, Plasma
ngraham added a comment to D24454: Include an emoji picker.

Heh the sidebar ampersand fix appears to have had a side effect:

Fri, Oct 11, 4:49 PM · VDG, Plasma
ngraham updated the summary of D24540: [Database] Disable read-ahead to reduce thrashing.
Fri, Oct 11, 4:34 PM · Baloo, Frameworks
ngraham committed R293:198f82eb511f: [Database] Rework handling environment flags (authored by hurikhan77).
[Database] Rework handling environment flags
Fri, Oct 11, 4:32 PM
ngraham closed D24539: [Database] Rework handling environment flags.
Fri, Oct 11, 4:32 PM · Baloo, Frameworks
ngraham accepted D24539: [Database] Rework handling environment flags.
Fri, Oct 11, 4:31 PM · Baloo, Frameworks
ngraham added a comment to D24454: Include an emoji picker.

Oh one final thing I just thought of: it would be great if the search field could be in the main toolbar rather than in the sidebar, because this makes it inaccessible when the sidebar is collapsed, as it is by default. People might mistakenly assume that there's no search.

Fri, Oct 11, 4:29 PM · VDG, Plasma
ngraham accepted D24265: support global edit mode.

LGTM now!

Fri, Oct 11, 4:26 PM · Plasma
ngraham added a comment to D24454: Include an emoji picker.

Great, that's fixed the ampersand.

Fri, Oct 11, 4:16 PM · VDG, Plasma
ngraham added a comment to D24483: [Weather data engine] Handle windy conditions in NOAA backend.

Yeah there are windy and rainy conditions too. I expect we can handle those as well once we get appropriate icons.

Fri, Oct 11, 4:15 PM · Plasma
ngraham added a comment to D24483: [Weather data engine] Handle windy conditions in NOAA backend.

Thanks! I'll wait for the icon patch to land before landing this.

Fri, Oct 11, 4:02 PM · Plasma
ngraham added a comment to D24543: Set an icon theme for gtk applications in the icons kcm.

All right, sure.

Fri, Oct 11, 3:58 PM · Plasma
ngraham added a comment to D24454: Include an emoji picker.

Oh and one more: ampersands aren't appearing in the category text in the sidebar:

Fri, Oct 11, 3:55 PM · VDG, Plasma
ngraham added a comment to D24454: Include an emoji picker.

A few more:

  • List the categories in a more common order rather than alphabetical (i.e. first smilies, then nature, then food & drink, etc. Basically copy the mobile emoji pickers)
  • The window needs a proper icon, not the generic X11 icon
  • This might be in Kirigami, but the header text jumps around when I click on the X button to hide the drawer entirely:
Fri, Oct 11, 3:52 PM · VDG, Plasma
ngraham updated the test plan for D24454: Include an emoji picker.
Fri, Oct 11, 3:42 PM · VDG, Plasma
ngraham added a comment to D24454: Include an emoji picker.
  1. For the first-run use case, show the All category instead of Recent, or any other time when "Recent" is empty
  2. How does it work? When I click on an emoji, the window disappears but nothing appears to happen. Its not in the clipboard either?
  3. Every time I move the cursor over an emoji, file:///usr/lib/qt/qml/QtQuick/Controls.2/org.kde.desktop/ToolTip.qml:48:5: Unable to assign [undefined] to bool is printed to the console
Fri, Oct 11, 3:42 PM · VDG, Plasma
ngraham accepted D24263: edit mode action.
Fri, Oct 11, 3:27 PM · Frameworks
ngraham accepted D24264: edit mode action and dbus.
Fri, Oct 11, 3:26 PM · Plasma
ngraham added a comment to D24265: support global edit mode.
In D24265#545400, @GB_2 wrote:

It would be nice if the desktop toolbox had a shadow and had the standard background.

Fri, Oct 11, 3:00 PM · Plasma
ngraham added a comment to D24557: [kcminit] Additionally look in kcms/ folder for KCM plugins.

Ah OK

Fri, Oct 11, 1:07 PM · Plasma
ngraham added a comment to D24557: [kcminit] Additionally look in kcms/ folder for KCM plugins.

We don't have any KCMs that are duplicated in both locations though, right? What's the harm in looking in kcms/ first, and then if nothing is found, looking ine level below that?

Fri, Oct 11, 1:05 PM · Plasma
ngraham added a comment to D24557: [kcminit] Additionally look in kcms/ folder for KCM plugins.

Nice. Can you make this the preferred path for KCMs, in fact? That would improve life when testing a patch that moves a KCM to the kcms/ sub-folder.

Fri, Oct 11, 12:48 PM · Plasma
ngraham added a comment to D24543: Set an icon theme for gtk applications in the icons kcm.

Nice. We'll also need a patch to remove icon theme configuration from the GTK KCM that depends on this patch so we can land that as soon as this lands.

Fri, Oct 11, 12:35 PM · Plasma
ngraham added a comment to D24265: support global edit mode.
In D24265#545274, @mart wrote:

tough i think then it should be there also for pure touch events as well (as opposed to clicks)

As any change i'll do in plasma is primarly be in the direction of making touch a first class citizen on normal plasma shell

Fri, Oct 11, 12:27 PM · Plasma
ngraham added a comment to D24454: Include an emoji picker.
In D24454#545325, @mart wrote:

I think entries should have icons and the sidebar be collapsible with just icons

Fri, Oct 11, 12:24 PM · VDG, Plasma
ngraham added a comment to D21860: Set a font for gtk applications in the fonts kcm.

The idea is to move all the functionality in kde-gtk-config here, then delete it. See the parent Phab task for details.

Fri, Oct 11, 12:23 PM · Plasma
ngraham added a comment to D24454: Include an emoji picker.

How can I test this out? Do I need to have IBus set up?

Fri, Oct 11, 12:22 PM · VDG, Plasma

Thu, Oct 10

ngraham added a reviewer for D24540: [Database] Disable read-ahead to reduce thrashing: bruns.

@bruns, does this make sense to you?

Thu, Oct 10, 8:04 PM · Baloo, Frameworks
ngraham added a comment to D24539: [Database] Rework handling environment flags.

This doesn't apply cleanly on master. Can you rebase it?

Thu, Oct 10, 8:03 PM · Baloo, Frameworks
ngraham updated the task description for T10611: Set options for GTK apps in the respective KCMs.
Thu, Oct 10, 7:16 PM · Plasma: KCM Redesign
ngraham added a task to D22877: Convert colors into GTK colordefs: T10611: Set options for GTK apps in the respective KCMs.
Thu, Oct 10, 7:16 PM · Plasma
ngraham added a revision to T10611: Set options for GTK apps in the respective KCMs: D22877: Convert colors into GTK colordefs.
Thu, Oct 10, 7:16 PM · Plasma: KCM Redesign
ngraham added a revision to T10611: Set options for GTK apps in the respective KCMs: D24543: Set an icon theme for gtk applications in the icons kcm.
Thu, Oct 10, 7:16 PM · Plasma: KCM Redesign
ngraham added a task to D24543: Set an icon theme for gtk applications in the icons kcm: T10611: Set options for GTK apps in the respective KCMs.
Thu, Oct 10, 7:16 PM · Plasma
ngraham updated the task description for T10611: Set options for GTK apps in the respective KCMs.
Thu, Oct 10, 7:15 PM · Plasma: KCM Redesign
ngraham added a dependency for D24483: [Weather data engine] Handle windy conditions in NOAA backend: D24537: Icons for windy weather.
Thu, Oct 10, 7:04 PM · Plasma
ngraham added a dependent revision for D24537: Icons for windy weather: D24483: [Weather data engine] Handle windy conditions in NOAA backend.
Thu, Oct 10, 7:04 PM · Frameworks
ngraham updated the diff for D24483: [Weather data engine] Handle windy conditions in NOAA backend.

Remove old unused enum from the first revision

Thu, Oct 10, 7:01 PM · Plasma
ngraham updated the diff for D24483: [Weather data engine] Handle windy conditions in NOAA backend.

Handle windy + cloudy conditions as well now that we have appropriate icons

Thu, Oct 10, 6:59 PM · Plasma
ngraham added a comment to D24537: Icons for windy weather.

That was my impression too, but upon further examination, the noaa_i18n.dat file has strings that indicate windyness in addition to other conditions, and if I add a complex conditional to the data engine, I can see that the windy + cloudy condition is getting hit (it is in fact windy and partly cloudy today, lucky me):

Thu, Oct 10, 6:58 PM · Frameworks
ngraham added a comment to D24537: Icons for windy weather.

Also one more thing, sorry: -wind should go before -night in the night versions.

Thu, Oct 10, 6:32 PM · Frameworks
ngraham added a comment to D24537: Icons for windy weather.

Looks like there are some gaps in the windy overcast icon:

Thu, Oct 10, 6:23 PM · Frameworks
ngraham updated the summary of D24537: Icons for windy weather.
Thu, Oct 10, 6:06 PM · Frameworks
ngraham updated subscribers of D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change.

FWIW Plasma 5.17 tars were already made so if we want this in Plasma 5.17.0, in addition to landing it on the stable branch, @jriddell will have to do some release magic to include it and you'll want to ping him about that.

Thu, Oct 10, 5:11 PM · Plasma
ngraham added a comment to D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change.

Idea for a better string: "Fill each row/column before adding tasks to the next row/column"

Thu, Oct 10, 4:44 PM · Plasma
ngraham accepted D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change.

Thanks David, that's very helpful. Let's revert this in Plasma 5.17 for now (if translators approve) and work on a better string (or even a better UI) for Plasma 5.18.

Thu, Oct 10, 4:42 PM · Plasma
ngraham added a comment to D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change.

After playing around with this option with my IOTM at various panel widths and various "maximum rows/columns" values, I still cannot for the life of me figure out what on earth it does--or else the feature is so buggy I'm unable to discover the pattern.

Thu, Oct 10, 3:59 PM · Plasma
ngraham added a comment to D23480: [kwin/effects/presentwindows] Remove window dimming and move title bars to bottom.

@cameronrodgers I think renaming the variable is OK. Please feel free to continue the work on this.

Thu, Oct 10, 3:48 PM · KWin
ngraham added a comment to D24533: Draw categories in iconview in a similiar style as Kirigami and new KCategoryDrawer.

Do you mean the equivalent of a column layout, with a horizontal line under the title?

Thu, Oct 10, 3:47 PM · Plasma
ngraham committed R115:fb5631928121: Increase UI commonality between KCM and applet (authored by ngraham).
Increase UI commonality between KCM and applet
Thu, Oct 10, 3:20 PM
ngraham closed D24407: Increase UI commonality between KCM and applet.
Thu, Oct 10, 3:20 PM · Plasma
ngraham updated the summary of D24530: [XembedSNIProxy] If available, always use 32-bit color..
Thu, Oct 10, 3:09 PM · Plasma
ngraham committed R120:af1e75da1f83: Merge branch 'Plasma/5.17' (authored by ngraham).
Merge branch 'Plasma/5.17'
Thu, Oct 10, 2:43 PM
ngraham closed D24514: [XembedSNIProxy] Do not crash on null pointer.
Thu, Oct 10, 2:43 PM · Plasma
ngraham committed R120:741441765601: [XembedSNIProxy] Do not crash on null pointer (authored by kmaterka).
[XembedSNIProxy] Do not crash on null pointer
Thu, Oct 10, 2:43 PM
ngraham committed R120:3374c6fd020c: Merge branch 'Plasma/5.17' (authored by ngraham).
Merge branch 'Plasma/5.17'
Thu, Oct 10, 2:40 PM
ngraham committed R120:13efbfca67f8: [XembedSNIProxy] Scale only big icons (authored by kmaterka).
[XembedSNIProxy] Scale only big icons
Thu, Oct 10, 2:40 PM
ngraham closed D24531: [XembedSNIProxy] Scale only big icons.
Thu, Oct 10, 2:40 PM · Plasma
ngraham added a comment to D24407: Increase UI commonality between KCM and applet.

I had a feeling. I say let's land this, then fix that. Do you agree?

Thu, Oct 10, 2:37 PM · Plasma
ngraham updated the summary of D24531: [XembedSNIProxy] Scale only big icons.
Thu, Oct 10, 2:36 PM · Plasma
ngraham added a comment to D24407: Increase UI commonality between KCM and applet.

That should be fixed by D24402, in plasma-framework. Can you verify that it's fixed if you apply that or build plasma-framework from master?

Sorry that I didn't really make it obvious what I was referring to. For some reason I can check multiple PA sources as default. Sinks on the other hand behave as they should and change their checked state.

P.S. I am master of all repos right now (using kdesrc-build)

Thu, Oct 10, 2:34 PM · Plasma
ngraham committed R120:ae2a7eca3798: Merge branch 'Plasma/5.17' (authored by ngraham).
Merge branch 'Plasma/5.17'
Thu, Oct 10, 2:34 PM
ngraham committed R120:acf91005b60c: [XembedSNIProxy] Check size in each update() (authored by kmaterka).
[XembedSNIProxy] Check size in each update()
Thu, Oct 10, 2:32 PM
ngraham closed D24529: [XembedSNIProxy] Check size in each update().
Thu, Oct 10, 2:32 PM · Plasma
ngraham updated the summary of D24529: [XembedSNIProxy] Check size in each update().
Thu, Oct 10, 2:31 PM · Plasma
ngraham added a comment to D24407: Increase UI commonality between KCM and applet.

That should be fixed by D24402, in plasma-framework. Can you verify that it's fixed if you apply that or build plasma-framework from master?

Thu, Oct 10, 2:28 PM · Plasma
ngraham added a comment to D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change.

"rows of as many columns"

Thu, Oct 10, 2:13 PM · Plasma
ngraham added a comment to D24407: Increase UI commonality between KCM and applet.

Thanks for testing that, @sefaeyeoglu. I don't actually have a combination of devices that makes the combobox appear so that's much appreciated.

Thu, Oct 10, 2:11 PM · Plasma
ngraham updated the diff for D24407: Increase UI commonality between KCM and applet.

Fix overflow in the applet and poor alignment in the KCM when the combobox is visible

Thu, Oct 10, 2:10 PM · Plasma
ngraham added a comment to D24265: support global edit mode.
In D24265#544549, @mart wrote:

I actually like that a lot, to me is really the click anywhere to dismiss pattern all over the place in modal dialogs, websites and what not.
If I have to remove it, i would at least keep it for touch events, as i really want it in plasma mobile (and is harder to exit from edit mode there)

Thu, Oct 10, 1:34 PM · Plasma
ngraham updated the summary of D24514: [XembedSNIProxy] Do not crash on null pointer.
Thu, Oct 10, 1:27 PM · Plasma
ngraham updated the summary of D24514: [XembedSNIProxy] Do not crash on null pointer.
Thu, Oct 10, 1:26 PM · Plasma
ngraham added a comment to D24483: [Weather data engine] Handle windy conditions in NOAA backend.

'breez' or breeze' just curious here

Thu, Oct 10, 3:57 AM · Plasma

Wed, Oct 9

ngraham accepted D23718: WIP: Beginning of the Baloo/Search KCM Rewrite.

LGTM! Would be nice to fix some of these bugs in follow-up patches too: https://bugs.kde.org/buglist.cgi?component=kcm_baloo&list_id=1669138&product=systemsettings&resolution=---

Wed, Oct 9, 7:10 PM · Plasma
ngraham requested changes to D24224: Start of the accessibility KCM.

Why is kcms/colors/CMakeLists.txt being changed? Looks unrelated.

Wed, Oct 9, 6:39 PM · Plasma
ngraham added a dependency for D24224: Start of the accessibility KCM: D23835: Add TabKCM.
Wed, Oct 9, 5:18 PM · Plasma