ngraham (Nathaniel Graham)
User

Projects (16)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2017, 7:18 PM (149 w, 6 d)
Availability
Available

Recent Activity

Today

ngraham added a comment to D27523: Add an option to use a KUrlNavigator on the toolbar instead.

I have a confession to make: after living with the URL navigator in the toolbar for a few days, I'm feeling less sure about it. Putting the it there takes up all the remaining horizontal space in the toolbar, which reduces pretty substantially the amount of space available for toolbar buttons and makes it almost impossible to have any buttons with text, especially on small, narrow, or side-tiled windows. And without the visual changes proposed in T11662, the URL navigator's breadcrumbs mode looks visually muddy, and there's a large amount of space in the toolbar that looks draggable but actually isn't because it belongs to the URL Navigator.

Fri, Feb 28, 5:27 AM · Dolphin
ngraham added a comment to D22074: Add image annotation via libKImageAnnotator.

@nicolasfella ping! Any chance of getting this in for 20.04?

Fri, Feb 28, 4:08 AM · Spectacle
ngraham added a reviewer for D14631: Adds a new RenameDialog to KIO with more options for batch renaming: Dolphin.
Fri, Feb 28, 4:01 AM · Frameworks
ngraham added a reviewer for D14631: Adds a new RenameDialog to KIO with more options for batch renaming: meven.

@emateli are you going to be able to finish this? Should someone take over? It would be a shame for such great work to get stalled so close to the finish line.

Fri, Feb 28, 4:00 AM · Frameworks
ngraham added a comment to D27669: WIP: [kstyle] Tools area.

Overall, this is good stuff I think (although we should also discuss whether this should be part of breeze or rather a next-gen theme).

Fri, Feb 28, 3:50 AM · Plasma
ngraham added a comment to D27711: [Applet]Use gridLayout for details.

Yeah, that's fine.

Fri, Feb 28, 3:35 AM · Plasma
ngraham added a comment to D27711: [Applet]Use gridLayout for details.

Even better than a GridLayout is a `Kirigami.FormLayout! That's what's being approximated here, so why not use the real thing? :)

Fri, Feb 28, 12:48 AM · Plasma

Yesterday

ngraham added a comment to D27669: WIP: [kstyle] Tools area.

Looking pretty great. The appearance of the Tools Area itself is good in all KDE apps tested. Visually, I only see a few remaining issues:

Thu, Feb 27, 10:22 PM · Plasma
ngraham committed R119:bf098f92b667: Merge branch 'Plasma/5.18' (authored by ngraham).
Merge branch 'Plasma/5.18'
Thu, Feb 27, 9:38 PM
ngraham committed R119:3b2e4ddaa01a: [applets/taskmanager] Show PA-related features even when audio indicators are… (authored by ngraham).
[applets/taskmanager] Show PA-related features even when audio indicators are…
Thu, Feb 27, 9:38 PM
ngraham closed D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled.
Thu, Feb 27, 9:38 PM · Plasma
ngraham added a project to T8569: Redesign Policy Kit Authorization dialog: VDG.
Thu, Feb 27, 8:33 PM · VDG, Plasma
ngraham added a comment to D10041: Decode full monitor vendor name from EDID using hwdata.

This causes a build failure for me:

Thu, Feb 27, 4:45 PM · KWin
ngraham committed R134:2dca85b46280: Adjust UI for version numbers in reviews (authored by ngraham).
Adjust UI for version numbers in reviews
Thu, Feb 27, 4:34 PM
ngraham added a dependent revision for D27695: WIP: Create a new TopArea element using widgets/toparea svg: D27697: WIP: Added top area to notification header.
Thu, Feb 27, 3:51 PM · Frameworks
ngraham added a dependency for D27697: WIP: Added top area to notification header: D27695: WIP: Create a new TopArea element using widgets/toparea svg.
Thu, Feb 27, 3:51 PM · Plasma
ngraham accepted D27199: [Applet]Update layout based on T10470.

LGTM! Nice work.

Thu, Feb 27, 3:05 PM · Plasma
ngraham added a comment to D27669: WIP: [kstyle] Tools area.

Okular and Gwenview are now fixed for me. KMag and Filelight still consider the toolbar to be outside of the Tools Area for some reason. Awesome progress though. It looks so good!

Thu, Feb 27, 3:00 AM · Plasma
ngraham added a comment to D27380: [GTK Config] Construct font style by hand instead of relying on Qt function.

So, I need to mention two bug reports: Qt one and GTK one. And should I create both of them? In case of GTK everything is somewhat clear, but in case of Qt I do not even know what to report (or how to do that correctly, or where it is broken): font picker just gives you a font with style name in local language, which is correctly applied for Qt applications, but not for GTK ones.

Thu, Feb 27, 2:46 AM · Plasma

Wed, Feb 26

ngraham added a reviewer for D27669: WIP: [kstyle] Tools area: VDG.
Wed, Feb 26, 9:37 PM · Plasma
ngraham updated the diff for D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled.

Brain fart; do it right

Wed, Feb 26, 8:45 PM · Plasma
ngraham updated the diff for D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled.

Also check audioIndicatorsEnabled for safety

Wed, Feb 26, 8:43 PM · Plasma
ngraham added a task to D27669: WIP: [kstyle] Tools area: T11661: Replace framed views with single-pixel separator lines.
Wed, Feb 26, 8:08 PM · Plasma
ngraham added a revision to T11661: Replace framed views with single-pixel separator lines: D27669: WIP: [kstyle] Tools area.
Wed, Feb 26, 8:08 PM · Goal: Consistency, Breeze, VDG
ngraham added a revision to T11661: Replace framed views with single-pixel separator lines: D27685: Remove extra top and bottom padding from dock widgets.
Wed, Feb 26, 8:07 PM · Goal: Consistency, Breeze, VDG
ngraham requested review of D27685: Remove extra top and bottom padding from dock widgets.
Wed, Feb 26, 8:07 PM · Plasma
ngraham updated the summary of D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled.
Wed, Feb 26, 7:56 PM · Plasma
ngraham requested review of D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled.
Wed, Feb 26, 7:55 PM · Plasma
ngraham added a comment to D27380: [GTK Config] Construct font style by hand instead of relying on Qt function.

Prior to 5.18, you had to set the GTK font separately; now it's auto-synced.

Right, so that's the difference in font style names between Qt and GTK that caused the problem?

Wed, Feb 26, 6:42 PM · Plasma
ngraham accepted D27577: [KCM]Fix content below scrollbars.
Wed, Feb 26, 6:40 PM · Plasma
ngraham added a comment to D27380: [GTK Config] Construct font style by hand instead of relying on Qt function.

Prior to 5.18, you had to set the GTK font separately; now it's auto-synced.

Wed, Feb 26, 6:37 PM · Plasma
ngraham added a comment to D27523: Add an option to use a KUrlNavigator on the toolbar instead.

@manueljlin: Thanks! I hope so too.

@ngraham: Thanks! Heavy split view users are also the only user group that came to my mind who would have a real reason to be upset if this wasn't optional. Maybe second-hand experience is the best we have to think about this change because no vocal split view user showed up in these discussions yet. Workflow example: I once had a lecturer (literally this guy) who used a split view file manager (Total Commander or something, don't remember) fullscreen and keyboard-only as his primary means to interact with his notebook. He opened up presentations, pictures and GeoGebra-files to show them in the lecture. I think for such a use case having only one path visible at a time would probably be a big step down.

Other than that we would lose the feature of putting the toolbar vertically to the side (without it becoming very wide). Not a huge loss I think because the primary reason for doing this is probably vertical space concern which is also alleviated by this change.

Wed, Feb 26, 6:35 PM · Dolphin
ngraham added a comment to D27380: [GTK Config] Construct font style by hand instead of relying on Qt function.

Agreed. Otherwise it does work and fixes the bug, and the code looks sensible to me.

Wed, Feb 26, 6:26 PM · Plasma
ngraham added a comment to D27673: [applets/notes] Fix drag&drop links and cursor shape regression .

Nice job, and nice first patch! May it be the first of many. :)

Wed, Feb 26, 6:19 PM · Plasma
ngraham committed R114:35e82f6dbfe0: Merge branch 'Plasma/5.18' (authored by ngraham).
Merge branch 'Plasma/5.18'
Wed, Feb 26, 6:18 PM
ngraham committed R114:b03539a0d8d3: [applets/notes] Fix drag&drop links and cursor shape regression (authored by Luca Pedrielli <luca.pedrielli@gmail.com>).
[applets/notes] Fix drag&drop links and cursor shape regression
Wed, Feb 26, 6:17 PM
ngraham closed D27673: [applets/notes] Fix drag&drop links and cursor shape regression .
Wed, Feb 26, 6:17 PM · Plasma
ngraham added a comment to D17816: Support for xattrs on kio copy/move.

@tmarshall would you like to finish this up?

Wed, Feb 26, 6:08 PM · Frameworks
ngraham updated the test plan for D27673: [applets/notes] Fix drag&drop links and cursor shape regression .
Wed, Feb 26, 4:28 PM · Plasma
ngraham accepted D27673: [applets/notes] Fix drag&drop links and cursor shape regression .
Wed, Feb 26, 4:28 PM · Plasma
ngraham accepted D27679: [emojier] Set minimum window height and width.

Stable branch

Wed, Feb 26, 3:41 PM · Plasma
ngraham added a comment to D27673: [applets/notes] Fix drag&drop links and cursor shape regression .

Nice job. Just two very minor comments:

Wed, Feb 26, 3:09 PM · Plasma
ngraham added a comment to D27669: WIP: [kstyle] Tools area.

Looks like there are some QWidgets apps that aren't getting the new style.

Wed, Feb 26, 2:49 PM · Plasma
ngraham added a comment to D27669: WIP: [kstyle] Tools area.

Could we draw the line in the window decoration theme then? Could it communicate in some way with the widgets theme to know what's beneath it?

Wed, Feb 26, 3:31 AM · Plasma
ngraham added a revision to T10201: Window titlebars: D27669: WIP: [kstyle] Tools area.
Wed, Feb 26, 3:17 AM · KDE Applications, VDG
ngraham added a task to D27669: WIP: [kstyle] Tools area: T10201: Window titlebars.
Wed, Feb 26, 3:17 AM · Plasma
ngraham added a comment to D27669: WIP: [kstyle] Tools area.

Obviously this needs to be paired with appropriate changes to the default Breeze color scheme to replicate the desired look in T10201 :) Here's a quick-and-dirty version of the Breeze Evolved color scheme: {F8132321 (note VERY quick-and-dirty, not to be taken literally). Since the color scheme is shipped in the same repo, maybe we should polish it up and add it to this patch, or do it in another patch and make it a dependency.

Wed, Feb 26, 3:17 AM · Plasma
ngraham accepted D27667: Align wallpaper dialog button to bottom.

Stable branch

Wed, Feb 26, 3:14 AM · Plasma

Tue, Feb 25

ngraham requested review of D27664: Improve layout and appearance of app details view.
Tue, Feb 25, 9:45 PM · Plasma
ngraham added a dependent revision for D27663: Show tooltip with full URL for URL button with overridden text: D27664: Improve layout and appearance of app details view.
Tue, Feb 25, 9:45 PM · Kirigami
ngraham requested review of D27663: Show tooltip with full URL for URL button with overridden text.
Tue, Feb 25, 9:39 PM · Kirigami
ngraham added a comment to D27380: [GTK Config] Construct font style by hand instead of relying on Qt function.

You're right, it does work for GTK2 apps on my system, but not GTK3 apps. :/

Tue, Feb 25, 8:56 PM · Plasma
ngraham added a comment to D27380: [GTK Config] Construct font style by hand instead of relying on Qt function.

So what kind of font styles do work?

Tue, Feb 25, 8:34 PM · Plasma
ngraham added a comment to D27380: [GTK Config] Construct font style by hand instead of relying on Qt function.

All fonts tested. :(

Tue, Feb 25, 8:13 PM · Plasma
ngraham added a comment to D27523: Add an option to use a KUrlNavigator on the toolbar instead.

In terms of the user interaction, I'm impressed. I really like the appearance and also the interaction. IMO it's fine for split view too but I'll admit I'm not a heavy user of split view so it would be nice to get opinions from others.

Tue, Feb 25, 7:58 PM · Dolphin
ngraham committed R108:04aff77f9426: Remove the "Candy" category and fold its contents into "Appearance" (authored by ngraham).
Remove the "Candy" category and fold its contents into "Appearance"
Tue, Feb 25, 6:26 PM
ngraham closed D27658: Remove the "Candy" category and fold its contents into "Appearance".
Tue, Feb 25, 6:26 PM · Documentation, KWin
ngraham added a comment to D27643: FileChooser: download remote files to a cache location to open them through the portal.
In D27643#617800, @apol wrote:

This really isn't ideal. It means we can't deal with any biggish files without having to cache them first.
Also saving back (e.g. in kate) won't work, right?

Maybe we can come up with a solution with fuse?

Tue, Feb 25, 5:50 PM · Plasma
ngraham committed R255:635de46578e5: Shrinks the minimums from the 1110 by 600 to 720 by 393 (which keeps the aspect… (authored by daerny).
Shrinks the minimums from the 1110 by 600 to 720 by 393 (which keeps the aspect…
Tue, Feb 25, 5:17 PM
ngraham added a comment to D27380: [GTK Config] Construct font style by hand instead of relying on Qt function.

So if I set the general font to 9pt Ubuntu Italic, then in the config file I see gtk-font-name=Ubuntu, Italic 9 and Thunderbird respects the font, and the size, but not the style; it's not italic. :(

Tue, Feb 25, 5:13 PM · Plasma
ngraham requested review of D27658: Remove the "Candy" category and fold its contents into "Appearance".
Tue, Feb 25, 5:09 PM · Documentation, KWin
ngraham added a comment to D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground.

Tue, Feb 25, 5:00 PM · VDG, Plasma, Frameworks
ngraham committed R108:1d7202af50f6: Improve strings for "Show Desktop" effects (authored by ngraham).
Improve strings for "Show Desktop" effects
Tue, Feb 25, 4:37 PM
ngraham closed D27630: Improve strings for "Show Desktop" effects.
Tue, Feb 25, 4:37 PM · KWin
ngraham accepted D27636: Remove redundant match for mountpoints.
Tue, Feb 25, 4:34 PM · Plasma
ngraham added a comment to D27608: Fixes for applet configuration layout..

I'm starting to agree that this is the wrong place to add the titlebar separator.

Tue, Feb 25, 4:29 PM · Plasma
ngraham added a comment to D27380: [GTK Config] Construct font style by hand instead of relying on Qt function.

Do you need to reload any daemon to get this to work?

Tue, Feb 25, 4:12 PM · Plasma
ngraham accepted D27647: throw out the windows variant of the smb slave.
Tue, Feb 25, 4:05 PM · Frameworks, Dolphin
ngraham accepted D27648: [KCM]Set implicitWidth for main page.

Stable branch please!

Tue, Feb 25, 4:04 PM · Plasma
ngraham accepted D27646: smb: apply a whole bunch of static analyzer improvements.
Tue, Feb 25, 4:00 PM · Frameworks, Dolphin
ngraham accepted D27644: do not hide enum warnings via switch default label.
Tue, Feb 25, 3:58 PM · Frameworks, Dolphin
ngraham added reviewers for D27100: [GTK Config] Parameterise GTK config editing: Plasma, cblack.
Tue, Feb 25, 3:32 PM · Plasma
ngraham added reviewers for D27643: FileChooser: download remote files to a cache location to open them through the portal: feverfew, fvogt.

Shouldn't KIO take care of this stuff automatically? I wouldn't want to lose streaming support for Flatpak apps.

Tue, Feb 25, 2:52 PM · Plasma
ngraham retitled D27540: KCModule: Indicate when a setting has been changed from the default or previous value from KCModule: Indicate when a setting has been changed from the default value to KCModule: Indicate when a setting has been changed from the default or previous value.
Tue, Feb 25, 2:40 PM · Frameworks
ngraham retitled D27540: KCModule: Indicate when a setting has been changed from the default or previous value from Status indicator for individual widgets in KCModule to KCModule: Indicate when a setting has been changed from the default value.
Tue, Feb 25, 2:24 PM · Frameworks
ngraham created T12744: Consider increasing the default fixed width font size by 1 (9 -> 10).
Tue, Feb 25, 12:28 AM · Konsole, Kate, VDG

Mon, Feb 24

ngraham added a comment to D27557: Auto-generate 24px monochrome icons.

Thanks so much everyone! @sitter I'll read up on CMake a bit and try to implement your suggestions.

Mon, Feb 24, 9:50 PM · Frameworks
ngraham added a reviewer for D27608: Fixes for applet configuration layout.: filipf.

Looks quite sane overall, modulo a few questions and comments. Adding @filipf as a reviewer since I know he's done some work here too.

Mon, Feb 24, 9:39 PM · Plasma
ngraham committed R266:332b87eabdd6: Fix old text color values for osd-* icons (authored by ngraham).
Fix old text color values for osd-* icons
Mon, Feb 24, 9:30 PM
ngraham added a comment to T12743: Tweak Breeze and Breeze Dark color schemes.

With regards to the default Breeze color scheme, I agree that it doesn't need much. To support the "Tools area" idea, we would need to lighten the titlebar color to a light-medium gray, since this would become the background color for the entire tools area. What we do with other colors is something I'm happy leaving up to you guys.

Mon, Feb 24, 9:12 PM · VDG
ngraham requested review of D27630: Improve strings for "Show Desktop" effects.
Mon, Feb 24, 7:20 PM · KWin
ngraham committed R114:35bd616bcd3a: [applets/notes] Rename to "Sticky Note" (authored by ngraham).
[applets/notes] Rename to "Sticky Note"
Mon, Feb 24, 5:13 PM
ngraham closed D27532: [applets/notes] Rename to "Sticky Note".
Mon, Feb 24, 5:13 PM · Plasma
ngraham committed R120:05353f12e8fe: Merge branch 'Plasma/5.18' (authored by ngraham).
Merge branch 'Plasma/5.18'
Mon, Feb 24, 5:10 PM
ngraham committed R120:cb46e52aad66: Use appropriate icon for unconfigured applets' "Configure..." buttons (authored by ngraham).
Use appropriate icon for unconfigured applets' "Configure..." buttons
Mon, Feb 24, 5:10 PM
ngraham closed D27530: Use appropriate icon for unconfigured applets' "Configure..." buttons.
Mon, Feb 24, 5:10 PM · Plasma
ngraham updated the diff for D27530: Use appropriate icon for unconfigured applets' "Configure..." buttons.

settings-configure -> configure (they're the same icon, but configure is the parent while the other is a symlink to it

Mon, Feb 24, 5:06 PM · Plasma
ngraham accepted D27612: Remove unused functions.
Mon, Feb 24, 5:04 PM · Plasma
ngraham accepted D27613: Remove bogus mount points check when starting baloo on save.
Mon, Feb 24, 5:03 PM · Plasma
ngraham accepted D27611: Invert logic of shouldShowMountPoint -> ignoredMountPoint.
Mon, Feb 24, 5:03 PM · Plasma
ngraham added a comment to D25743: Expose IndexerState enum to QML.

Ping.

Mon, Feb 24, 4:52 PM · Baloo, Frameworks
ngraham added a comment to D27260: [applets/systemtray] Set pin button's size correctly.

Fixed better in D27628

Mon, Feb 24, 4:50 PM · Plasma
ngraham abandoned D27449: [applets/mediacontroller] Fix Playback button icon sizes.

Fixed better in D27628

Mon, Feb 24, 4:50 PM · Plasma
ngraham added a comment to D27628: Buttons: allow to scale up icons.

+1 visually and behaviorally; fixes the issues described in D27260 and D27449.

Mon, Feb 24, 4:50 PM · Frameworks
ngraham added a comment to D27577: [KCM]Fix content below scrollbars.

We can wait a bit to get more eyes on it and target 5.18.3.

Mon, Feb 24, 4:36 PM · Plasma
ngraham added a comment to D27617: [breeze-icons] Add telegram-desktop tray icons.

Yes, I have 1.9.12. I don't yet have an available update to 1.19.14 or later, sadly.

Mon, Feb 24, 4:33 PM · Frameworks
ngraham accepted D27577: [KCM]Fix content below scrollbars.

The other change to center labels

They were already centered.

Mon, Feb 24, 2:40 PM · Plasma
ngraham added a comment to T11661: Replace framed views with single-pixel separator lines.

Oh I see what you mean: an alternate background color, not alternating background colors.

Mon, Feb 24, 2:37 PM · Goal: Consistency, Breeze, VDG
ngraham added a comment to D27617: [breeze-icons] Add telegram-desktop tray icons.

Thanks for the patch!

Mon, Feb 24, 2:35 PM · Frameworks
ngraham added a comment to T11661: Replace framed views with single-pixel separator lines.

One way we could get views next to other views to look right is to use the alternate view background color for sidebars

Mon, Feb 24, 2:28 PM · Goal: Consistency, Breeze, VDG