ngraham (Nathaniel Graham)
User

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2017, 7:18 PM (122 w, 5 d)
Availability
Available

Recent Activity

Yesterday

ngraham updated the diff for D23368: [Energy KCM] Port away from WorkspaceComponents.BatteryIcon.

Don't use width: and height: on items in a Layout

Thu, Aug 22, 11:02 PM · Plasma
ngraham closed D23365: Add battery-ups icons.
Thu, Aug 22, 10:59 PM · Frameworks
ngraham committed R266:69fd363b6412: Add battery-ups icons (authored by ngraham).
Add battery-ups icons
Thu, Aug 22, 10:59 PM
ngraham added a dependent revision for D23365: Add battery-ups icons: D23368: [Energy KCM] Port away from WorkspaceComponents.BatteryIcon.
Thu, Aug 22, 10:51 PM · Frameworks
ngraham added a dependency for D23368: [Energy KCM] Port away from WorkspaceComponents.BatteryIcon: D23365: Add battery-ups icons.
Thu, Aug 22, 10:51 PM · Plasma
ngraham requested review of D23368: [Energy KCM] Port away from WorkspaceComponents.BatteryIcon.
Thu, Aug 22, 10:51 PM · Plasma
ngraham abandoned D23298: Unify busy spinner appearance on update page.

Abandoning in favor of the vastly superior D23357.

Thu, Aug 22, 10:22 PM · Plasma
ngraham requested review of D23365: Add battery-ups icons.
Thu, Aug 22, 10:22 PM · Frameworks
ngraham accepted D23363: Avoid anchor loop in NavigationActionBar.

Yeah, this is my fault, sorry. I only recently learned that setting height and width directly on items in layouts is a bad idea. Feel free to fix other occurrences too with no review.

Thu, Aug 22, 9:59 PM · Elisa
ngraham committed R266:5115bfe7d713: Make "monitor" a link to "computer" icon (authored by ngraham).
Make "monitor" a link to "computer" icon
Thu, Aug 22, 9:56 PM
ngraham added a comment to D23336: KDirOperator: Add follow new directories option.

What happens when this is set but the view isn't an expandable tree view?

Thu, Aug 22, 8:29 PM · Frameworks
ngraham accepted D23359: Always open menu at the same position.

Yup. I was going to do this but you beat me to it. :)

Thu, Aug 22, 8:27 PM · Elisa
ngraham added a comment to D23210: Add autosave feature.

Yes, @davidre is amazing.

Thu, Aug 22, 8:25 PM · Spectacle
ngraham added a comment to D21006: Add global menu by using qml native menu components.

Probably best to get this in rather than making it perfect first. Iteration can come later.

Thu, Aug 22, 8:22 PM · Elisa
ngraham added a comment to D22144: Add kio recentlyused:/ to access KActivityStats data.
In D22144#514633, @ivan wrote:

Looks OK to me, I guess some of our resident KIO experts should review it. What do you think?

Thu, Aug 22, 8:20 PM · Frameworks, Dolphin
ngraham accepted D22922: Implement writing of images.
Thu, Aug 22, 8:19 PM · Baloo, Frameworks
ngraham assigned T11117: KDE is All About the Apps to jriddell.
Thu, Aug 22, 8:04 PM · Goal Setting 2019
ngraham committed R128:cc809e09f348: Attach labels to their checkboxes BUG: 411142 FIXED-IN: 5.17.0 (authored by ngraham).
Attach labels to their checkboxes BUG: 411142 FIXED-IN: 5.17.0
Thu, Aug 22, 7:48 PM
ngraham committed R241:2e9cae63d141: KDirOperator: Only enable "Create New" menu if the selected item is a directory (authored by daandemeyer).
KDirOperator: Only enable "Create New" menu if the selected item is a directory
Thu, Aug 22, 6:17 PM
ngraham closed D23333: KDirOperator: Only enable "Create New" menu if the selected item is a directory.
Thu, Aug 22, 6:17 PM · Frameworks
ngraham accepted D23357: Show update issues on a popup instead of as passive messages.

So much better!

Thu, Aug 22, 6:06 PM · Plasma
ngraham added a comment to D23336: KDirOperator: Add follow new directories option.

I changed the option to apply to directories that are double clicked as well. Previously, double clicking a directory would also change the listed url which now depends on whether the option is enabled. Since it applies to both new and existing directories, followDirectories seemed more apt. I'm open to other name suggestions but your suggestions seem to only consider the new directory case (perhaps you missed the added behaviour in the latest revision?).

Thu, Aug 22, 6:03 PM · Frameworks
ngraham updated the summary of D23357: Show update issues on a popup instead of as passive messages.
Thu, Aug 22, 5:39 PM · Plasma
ngraham committed R134:8c5c988db183: Make "up to date" icon match size of other centered icons on pages (authored by ngraham).
Make "up to date" icon match size of other centered icons on pages
Thu, Aug 22, 5:31 PM
ngraham added a comment to D23336: KDirOperator: Add follow new directories option.

followDirectories() seems somewhat ambiguous to me. How about the old one, or else, openNewlyCreatedDirectories()?

Thu, Aug 22, 5:23 PM · Frameworks
ngraham added a comment to D23346: Fix Quickeditor only be shown on one screen on Wayland.

Stable branch?

Thu, Aug 22, 5:11 PM · Spectacle
ngraham accepted D23346: Fix Quickeditor only be shown on one screen on Wayland.

Whoops.

Thu, Aug 22, 5:11 PM · Spectacle
ngraham added a comment to D23336: KDirOperator: Add follow new directories option.

+1, but you need to add @since 5.62 to the new public functions.

Thu, Aug 22, 5:08 PM · Frameworks
ngraham accepted D23333: KDirOperator: Only enable "Create New" menu if the selected item is a directory.

Do you need someone to commit this for you? If so, can you please provide an email address?

Thu, Aug 22, 5:06 PM · Frameworks
ngraham accepted D23349: Krita has split from Calligra and now uses Krita name instead of calligrakrita.
Thu, Aug 22, 5:01 PM · Frameworks
ngraham added a comment to D23350: Chaning default iconSize in systemtray.

So this is a complaint that comes up a lot. I do see what you mean, and in my opinion, what we need is a dual-mode size control UI that lets you switch between "scale icons to fit in panel", "static icon size", and "n columns".

That was i think dated, also i'm pretty sure it has a review that doing it, but it makes things complicated and was reviled.

Thu, Aug 22, 4:42 PM · Plasma
ngraham accepted D23352: make button icons follow a reasonable size and layout.

LGTM, just fix the whitespace issue

Thu, Aug 22, 4:38 PM · Frameworks
ngraham updated the summary of D23352: make button icons follow a reasonable size and layout.
Thu, Aug 22, 4:34 PM · Frameworks
ngraham added a comment to D23210: Add autosave feature.

Just wanted to chime in and say that this is looking super-great!

Thu, Aug 22, 4:33 PM · Spectacle
ngraham committed R116:fdc8edb1e89e: Merge branch 'Plasma/5.16' (authored by ngraham).
Merge branch 'Plasma/5.16'
Thu, Aug 22, 4:29 PM
ngraham committed R116:b8e7d4c03b39: Make "Network Disconnected" notification low priority (authored by ngraham).
Make "Network Disconnected" notification low priority
Thu, Aug 22, 4:28 PM
ngraham closed D23248: Make "Network Disconnected" notification low priority.
Thu, Aug 22, 4:28 PM · Plasma
ngraham accepted D23152: [energy kcm] Display Vendor and model.

That looks fantastic to me!

Thu, Aug 22, 3:35 PM · Plasma
ngraham added a comment to D23350: Chaning default iconSize in systemtray.

So this is a complaint that comes up a lot. I do see what you mean, and in my opinion, what we need is a dual-mode size control UI that lets you switch between "scale icons to fit in panel", "static icon size", and "n columns". However we don't have a UI that implements this. I would be happy to entertain a patch that added that though.

Thu, Aug 22, 3:22 PM · Plasma
ngraham updated subscribers of D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses.

The text "change password" is not accurate when you're setting up a new user. For that case, it should say "set password". But the new user creation process is really weird and needs to be redone anyway, so maybe that's the better approach.

Thu, Aug 22, 3:13 PM · VDG, Plasma
ngraham added a comment to D23350: Chaning default iconSize in systemtray.

Looks to me that scaling is working just fine for system tray items in your screenshot. It's deliberate that they have that much padding on the top and bottom (at least with the default size settings).

Thu, Aug 22, 3:09 PM · Plasma
ngraham committed R134:1ce1bfa44b8e: Make on-page staus messages less huge so they don't compete with page titles (authored by ngraham).
Make on-page staus messages less huge so they don't compete with page titles
Thu, Aug 22, 2:59 PM
ngraham requested changes to D23350: Chaning default iconSize in systemtray.

The label says:

On high DPI systems those values would be scaled up, depending on the DPI

Thu, Aug 22, 2:50 PM · Plasma
ngraham accepted D23324: Show progress for PackageKit update fetching.

Thanks, this looks so much nicer now!

Thu, Aug 22, 2:11 PM · Plasma
ngraham added a comment to D22514: Show if KRunner is still searching for more things.
In D22514#502062, @apol wrote:

Please review D22540 so I can offer a better solution for @broulik's concerns.

You already fixed all of those, right?

IMHO the busy indicator should appear next to the results list, for example right on top of it, because the busy indicator is related to the results, not to the input text. A busy indicator in TextField might be understood as if something is going to happen inside that text field.

Thu, Aug 22, 1:21 AM · Plasma

Wed, Aug 21

ngraham added a comment to D23210: Add autosave feature.

Actually I was envisioning something even simpler:

Wed, Aug 21, 10:49 PM · Spectacle
ngraham added a comment to D23210: Add autosave feature.

Works great.

Wed, Aug 21, 9:54 PM · Spectacle
ngraham accepted D23307: [weather] [envcan] Add additional current condition icon mappings.
Wed, Aug 21, 9:44 PM · Plasma
ngraham accepted D23322: Add new touch-friendly drag handlers.

It works perfectly. Nicely done. The circle sizes seem just right, too.

Wed, Aug 21, 9:44 PM · Spectacle
ngraham added a comment to D23330: Make manual control compatible with redshift >= 1.12.

Is redshift -P -O fully backwards-compatible with older versions of redshift? If not, then this will just break everyone not using >=1.12.

Wed, Aug 21, 8:55 PM · Plasma
ngraham committed R124:0405685ddbbd: Merge branch 'Plasma/5.16' (authored by ngraham).
Merge branch 'Plasma/5.16'
Wed, Aug 21, 7:24 PM
ngraham committed R124:7f8d58958df9: Exclude other desktop file from AppStream metadata generation (authored by ngraham).
Exclude other desktop file from AppStream metadata generation
Wed, Aug 21, 7:24 PM
ngraham closed D23328: Exclude other desktop file from AppStream metadata generation.
Wed, Aug 21, 7:24 PM · Plasma
ngraham added a comment to D23328: Exclude other desktop file from AppStream metadata generation.
In D23328#516191, @mak wrote:

Effect is kdesystemsettings.desktop not being shown in any software center.
LGTM

Wed, Aug 21, 7:15 PM · Plasma
ngraham added a comment to T10783: Right-click on touch.

IIRC the objection was that making press-and-hold always mean right-click at the toolkit level could interfere with apps that want to re-implement the press-and-hold behavior for some other behavior. For example a lot of Android apps use press-and-hold to mean "make this list/view editable".

Wed, Aug 21, 7:07 PM · Plasma, VDG
ngraham added a comment to D23306: Add AppStream metadata file.

All right, hopefully the third time's the charm: D23328

Wed, Aug 21, 7:02 PM · Plasma
ngraham requested review of D23328: Exclude other desktop file from AppStream metadata generation.
Wed, Aug 21, 7:02 PM · Plasma
ngraham committed R124:7e018de5d771: Merge branch 'Plasma/5.16' (authored by ngraham).
Merge branch 'Plasma/5.16'
Wed, Aug 21, 6:59 PM
ngraham committed R124:16a43f64532b: Use non-deprecated .metainfo.xml filename extension (authored by ngraham).
Use non-deprecated .metainfo.xml filename extension
Wed, Aug 21, 6:58 PM
ngraham closed D23325: Use non-deprecated .metainfo.xml filename extension.
Wed, Aug 21, 6:58 PM · Plasma
ngraham updated the diff for D23325: Use non-deprecated .metainfo.xml filename extension.

You assume far too much competance on my part :)

Wed, Aug 21, 6:57 PM · Plasma
ngraham added a comment to D23306: Add AppStream metadata file.

@ngraham You used the "appdata.xml" file suffix here. I noticed yesterday when reading the spec that it now declares that as legacy suffix:

While desktop-application metadata is commonly stored in /usr/share/metainfo/%{id}.metainfo.xml (with a .metainfo.xml extension), using a .appdata.xml extension is also permitted for this component type for legacy compatibility.

From https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html

Given Plasma targets newer system, perhaps it makes sense to start right away with a metainfo.xml suffix?

Wed, Aug 21, 6:23 PM · Plasma
ngraham requested review of D23325: Use non-deprecated .metainfo.xml filename extension.
Wed, Aug 21, 6:23 PM · Plasma
ngraham committed R124:b01fc96fb932: fix XML syntax (authored by jriddell).
fix XML syntax
Wed, Aug 21, 6:21 PM
ngraham added a comment to D23210: Add autosave feature.

Needs a rebase

Wed, Aug 21, 5:53 PM · Spectacle
ngraham added a comment to D23322: Add new touch-friendly drag handlers.

There is actually one "problem" I noticed. If you resize the rectangle from big to small (where the handles become free-floating), the cursor is at the end still there, where the handler should be in the normal mode. So the handler moved away from the cursor and you have to move the cursor back to the drag handler, if you want to resize the rectangle again. I'm actually not quite sure if that's a problem, but it's definitely different to how it behaved before the patch. One possible solution would be to move the cursor automatically to the drag handler it grabbed before. But it might look strange if the cursor suddenly jumps somewhere else?
Some opinions on this would be great!

Wed, Aug 21, 5:48 PM · Spectacle
ngraham added a comment to D22708: [WIP] Add a kded module infra for fuse mount services.

Oh good. :) Is there anywhere I can follow the progress?

All my work goes on KIOFuse goes into review here:
https://gitlab.com/Vogtinator/kio-fuse/merge_requests

Thanks!

Wed, Aug 21, 5:41 PM · Frameworks
ngraham added a comment to D23324: Show progress for PackageKit update fetching.

And finally, it would be nice to display the text + progress indicator in the center of the view, not at the very top.

Wed, Aug 21, 5:39 PM · Plasma
ngraham added a comment to D23324: Show progress for PackageKit update fetching.

Also hide the placeholder icon while the progress indicator is visible so this doesn't happen:

Wed, Aug 21, 5:38 PM · Plasma
ngraham added a comment to D22708: [WIP] Add a kded module infra for fuse mount services.

Oh good. :) Is there anywhere I can follow the progress?

Wed, Aug 21, 5:35 PM · Frameworks
ngraham added inline comments to D23322: Add new touch-friendly drag handlers.
Wed, Aug 21, 5:16 PM · Spectacle
ngraham added a comment to D23322: Add new touch-friendly drag handlers.

In testing it out, I really like it! I might even make the handles a bit larger for more touch-friendliness. Not a lot larger, just a bit.

Wed, Aug 21, 4:28 PM · Spectacle
ngraham updated the summary of D23283: When asked to switch sessions, jump to session creation if there's nothing to switch to.
Wed, Aug 21, 4:22 PM · Plasma
ngraham updated subscribers of D23300: Add FictionBook 2 icons.

LGTM. @ndavis?

Wed, Aug 21, 4:21 PM · Frameworks
ngraham committed R166:172e40bd9835: Add option to additionally save screenshot to clipboard (authored by aprcela).
Add option to additionally save screenshot to clipboard
Wed, Aug 21, 4:20 PM
ngraham closed D23162: Add option to additionally save screenshot to clipboard.
Wed, Aug 21, 4:20 PM · Spectacle
ngraham added a comment to D23162: Add option to additionally save screenshot to clipboard.

There we go, much better. Congrats on the nice big patch landed!

Wed, Aug 21, 4:20 PM · Spectacle
ngraham added a comment to D23322: Add new touch-friendly drag handlers.

Thanks for the patch! There are some formatting and whitespace issues here; could you fix those up first?

Wed, Aug 21, 4:19 PM · Spectacle
ngraham added reviewers for D23322: Add new touch-friendly drag handlers: Spectacle, VDG.
Wed, Aug 21, 4:16 PM · Spectacle
ngraham updated the summary of D23322: Add new touch-friendly drag handlers.
Wed, Aug 21, 4:15 PM · Spectacle
ngraham updated the diff for D23283: When asked to switch sessions, jump to session creation if there's nothing to switch to.

Adjust to the fact that the Switch user button is always visible now

Wed, Aug 21, 4:14 PM · Plasma
ngraham updated the diff for D23283: When asked to switch sessions, jump to session creation if there's nothing to switch to.

Rebase

Wed, Aug 21, 3:46 PM · Plasma
ngraham committed R120:de409edb4900: [Lock screen] Always show "Switch User" button regardless of whether fake… (authored by ngraham).
[Lock screen] Always show "Switch User" button regardless of whether fake…
Wed, Aug 21, 3:40 PM
ngraham closed D23279: [Lock screen] Always show "Switch User" button regardless of whether fake "switch user" item is shown.
Wed, Aug 21, 3:40 PM · Plasma
ngraham committed R120:41d59d6cdbda: Merge branch 'Plasma/5.16' (authored by ngraham).
Merge branch 'Plasma/5.16'
Wed, Aug 21, 3:27 PM
ngraham committed R120:d753fa01679d: Tell AppStream generators not to index Klipper .desktop files (authored by ngraham).
Tell AppStream generators not to index Klipper .desktop files
Wed, Aug 21, 3:26 PM
ngraham closed D23320: Tell AppStream generators not to index Klipper .desktop files.
Wed, Aug 21, 3:26 PM · Plasma
ngraham committed R124:1746125e6e41: Merge branch 'Plasma/5.16' (authored by ngraham).
Merge branch 'Plasma/5.16'
Wed, Aug 21, 3:22 PM
ngraham committed R124:b249a3d4e76e: Add AppStream metadata file (authored by ngraham).
Add AppStream metadata file
Wed, Aug 21, 3:22 PM
ngraham closed D23306: Add AppStream metadata file.
Wed, Aug 21, 3:22 PM · Plasma
ngraham updated the diff for D23306: Add AppStream metadata file.

Remove unnecessary X-AppStream-Ignore property

Wed, Aug 21, 3:16 PM · Plasma
ngraham updated the summary of D23321: Indicate appsteam the ps desktop file isn't a separate application.
Wed, Aug 21, 3:02 PM · KDevelop
ngraham accepted D23321: Indicate appsteam the ps desktop file isn't a separate application.

Yep, according to @mak, this should work.

Wed, Aug 21, 3:02 PM · KDevelop
ngraham requested review of D23320: Tell AppStream generators not to index Klipper .desktop files.
Wed, Aug 21, 2:55 PM · Plasma
ngraham added a comment to D23300: Add FictionBook 2 icons.

Haha that pink might be a bit too un-brutalist. :) Orange-on-pink isn't exactly the best color combination. A blue background of some sort might be nicer with the orange polygon.

Wed, Aug 21, 2:17 PM · Frameworks
ngraham added a comment to D23162: Add option to additionally save screenshot to clipboard.

Looks like you have some non-UNIX line endings that our commit hookscript complains about when I try to land the patch:

Wed, Aug 21, 2:15 PM · Spectacle
ngraham accepted D23162: Add option to additionally save screenshot to clipboard.

Very nice work.

Wed, Aug 21, 2:12 PM · Spectacle
ngraham added a comment to D23049: Add Kirigami ListSectionHeader component.

After living with this for a bit, I feel like maybe the following UI changes might be good to make the effect a bit more subtle:

  • Reduce the opacity of the gray background bit so the header doesn't feel like "a hole in the view"
  • Experiment with removing or reducing the strength of the horizontal line separators above and below the header text
Wed, Aug 21, 1:40 PM · Kirigami
ngraham added a comment to D23300: Add FictionBook 2 icons.

Better, thanks! Any chance you could make the gray background color a bit different? Maybe lighter, or some other color? That particular gray isn't a very attractive color IMO. It's very brutalist. :)

Wed, Aug 21, 1:36 PM · Frameworks

Tue, Aug 20

ngraham updated the summary of D23279: [Lock screen] Always show "Switch User" button regardless of whether fake "switch user" item is shown.
Tue, Aug 20, 9:45 PM · Plasma