ngraham (Nathaniel Graham)
User

Projects (15)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2017, 7:18 PM (138 w, 12 h)
Availability
Available

Recent Activity

Yesterday

ngraham moved T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent from Reported to Apps Implementation on the Goal: Consistency board.
Sat, Dec 7, 10:40 PM · Goal: Consistency, Dolphin, Kate
ngraham claimed T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent.
Sat, Dec 7, 10:39 PM · Goal: Consistency, Dolphin, Kate
ngraham updated the summary of D25805: Open/close and focus/defocus terminal using the same shortcuts as Dolphin.
Sat, Dec 7, 10:38 PM · Kate
ngraham added a revision to T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent: D25805: Open/close and focus/defocus terminal using the same shortcuts as Dolphin.
Sat, Dec 7, 10:38 PM · Goal: Consistency, Dolphin, Kate
ngraham requested review of D25805: Open/close and focus/defocus terminal using the same shortcuts as Dolphin.
Sat, Dec 7, 10:38 PM · Kate
ngraham committed R120:d46b0186655c: Revert "Revert "[sddm-theme] Fix initial focus after SDDM QQC2 Port"" (authored by ngraham).
Revert "Revert "[sddm-theme] Fix initial focus after SDDM QQC2 Port""
Sat, Dec 7, 10:19 PM
ngraham added a reverting change for R120:c2bc5243d460: Revert "[sddm-theme] Fix initial focus after SDDM QQC2 Port": R120:d46b0186655c: Revert "Revert "[sddm-theme] Fix initial focus after SDDM QQC2 Port"".
Sat, Dec 7, 10:19 PM
ngraham committed R120:c1bb6e2c6263: Merge branch 'Plasma/5.17' (authored by ngraham).
Merge branch 'Plasma/5.17'
Sat, Dec 7, 10:19 PM
ngraham committed R120:c2bc5243d460: Revert "[sddm-theme] Fix initial focus after SDDM QQC2 Port" (authored by ngraham).
Revert "[sddm-theme] Fix initial focus after SDDM QQC2 Port"
Sat, Dec 7, 10:19 PM
ngraham added a reverting change for R120:e7803ecc5827: [sddm-theme] Fix initial focus after SDDM QQC2 Port: R120:c2bc5243d460: Revert "[sddm-theme] Fix initial focus after SDDM QQC2 Port".
Sat, Dec 7, 10:19 PM
ngraham added a comment to D25340: Added background colors to active and inactive icon view.

Hmm, I'm not seeing any change, and the difference between open and maximized items is still too subtle IMO:

Sat, Dec 7, 4:40 PM · Frameworks
ngraham accepted D25428: Improved support for desktop "Folder View".

Yay, it works perfectly for me now! This patch has become quite large so I'd definitely like @hein's input before it lands (and preferably other Plasma people too, maybe @mart?)

Sat, Dec 7, 4:11 PM · Plasma
ngraham added a comment to T12192: Tweak SimpleMenu layout and replace Kickoff.

I really like the idea of making Files a tab that shows all the files from various places. Could you also add a "Recent" category for the file list?

Sat, Dec 7, 4:01 PM · Plasma, VDG
lots0logs awarded D19190: Improve scroll wheel speed by basing it on label height, not icon height a Love token.
Sat, Dec 7, 1:46 AM · Dolphin
ngraham added a comment to D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts".

Yep, in fact I mentioned this in the description section of the patch:

Sat, Dec 7, 12:13 AM · Frameworks
ngraham abandoned D25278: [Baloo KCM] Mention the brand name "Baloo" in user-visible strings.

All right, sounds like I'm fighting the tide on this one. :)

Sat, Dec 7, 12:12 AM · Plasma

Fri, Dec 6

ngraham accepted D25340: Added background colors to active and inactive icon view.

I guess I should change my status to accepted given that I think this is good enough and already an improvement. But I think we can do even better, @niccolove. :)

Fri, Dec 6, 11:01 PM · Frameworks
ngraham committed R985:4b5ee2545247: Replace Grey with Gray (authored by ngraham).
Replace Grey with Gray
Fri, Dec 6, 8:30 PM
ngraham committed R318:9c7e196bddd6: Merge branch 'release/19.12' (authored by ngraham).
Merge branch 'release/19.12'
Fri, Dec 6, 7:42 PM
ngraham committed R318:2310e33b7a43: Correct invalid homepage URL (authored by ngraham).
Correct invalid homepage URL
Fri, Dec 6, 7:42 PM
ngraham added a comment to D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts".

There was a bug report about it that had some people agreeing with it. I think it makes a bit of sense because yes, this dialog is indeed only about keyboard shortcuts, and at least to my ears, the phrase "keyboard shortcuts" instantly connotes what this is about, while "shortcuts" is a more generic term that doesn't have such an instantly recognizable computer-related meaning.

Fri, Dec 6, 7:26 PM · Frameworks
ngraham requested review of D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts".
Fri, Dec 6, 7:06 PM · Frameworks
ngraham added a comment to D25340: Added background colors to active and inactive icon view.

Can we push this forward? I just triaged a bunch of bugs and found that https://bugs.kde.org/show_bug.cgi?id=370465 now has five duplicates. There seems to be quite a bit of demand for this.

Fri, Dec 6, 6:33 PM · Frameworks
ngraham added a comment to D24563: Standardize the database upgrade mechanism.

No worries, we all miss things. :)

Fri, Dec 6, 5:55 PM
ngraham accepted D25788: Initialise QML monitor values.
Fri, Dec 6, 5:33 PM · Baloo, Frameworks
ngraham added a comment to D25789: Correctly report if baloo_file is unavailable.

Maybe instead of "Unavailable", it could say "Not Running"?

Fri, Dec 6, 5:32 PM · Baloo, Frameworks
ngraham changed the status of T5970: NaturalSorting option needs a place in system settings from Resolved to Wontfix.
Fri, Dec 6, 5:04 PM · Dolphin, Frameworks
ngraham closed T8136: Investigate relocating content in General > Confirmations tab as Wontfix.

We decided not to do this. There are now quite a few items in here and it seems like they're fine there.

Fri, Dec 6, 5:04 PM · Dolphin
ngraham added a project to T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent: Goal: Consistency.

I just landed an old patch of mine that adds a dedicated "focus/de-focus terminal panel" action to Dolphin: D10959

Fri, Dec 6, 5:03 PM · Goal: Consistency, Dolphin, Kate
ngraham added a task to D10959: Add action for focusing Terminal Panel: T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent.
Fri, Dec 6, 5:00 PM · Dolphin
ngraham added a revision to T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent: D10959: Add action for focusing Terminal Panel.
Fri, Dec 6, 5:00 PM · Goal: Consistency, Dolphin, Kate
ngraham closed T9932: [ConfirmationsSettingsPage] behaviourOnLaunch setting needs a tri-state as Resolved.

Should be fully completed with D24247.

Fri, Dec 6, 5:00 PM · Dolphin
ngraham closed T5970: NaturalSorting option needs a place in system settings as Resolved.

Yeah, let's keep this the way it is. I think it's plenty comprehensible, and we never managed to come up with a good place to move them anyway.

Fri, Dec 6, 4:59 PM · Dolphin, Frameworks
ngraham closed T11600: Cleanup ReviewBoard as Resolved.

ReviewBoard has been closed down now.

Fri, Dec 6, 4:58 PM · Dolphin
ngraham closed T10262: Integrate KIO Slaves into file system using FUSE gateway as Resolved.

This is currently in progress and I don't think we need this task open anymore. The patches are scattered across various bits of infrastructure so it won't be useful for linking them here.

Fri, Dec 6, 4:55 PM · Dolphin
ngraham committed R120:dcd3117ef563: [Language KCM] Use correct mesage type and improve text for error message (authored by ngraham).
[Language KCM] Use correct mesage type and improve text for error message
Fri, Dec 6, 4:48 PM
ngraham added a comment to D25278: [Baloo KCM] Mention the brand name "Baloo" in user-visible strings.

What about "Baloo file search"?

Fri, Dec 6, 4:45 PM · Plasma
ngraham updated the summary of D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS.
Fri, Dec 6, 4:12 PM · Plasma
ngraham added a comment to D23316: Port towards KConfig XT.

Youre font seems bolder? Anyways we can easily increase the height.

Fri, Dec 6, 4:02 PM · Spectacle
ngraham added a comment to D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme.

Alternatively, maybe we need a second line of label text?
so it is
Breeze
[lighter gray text] Follows system colors [/lighter gray text]

Fri, Dec 6, 3:57 PM · Plasma
ngraham added a comment to D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme.

Very nice! I wonder if the symbol's meaning might be too obscure though (icons with no labels generally have poor usability; see https://www.nngroup.com/articles/icon-usability/). It's good to have a tooltip, but this won't help for the touch use case, or for the desktop.laptop users who don't think to hover the icon. Maybe a label in the KCM's footer explaining what that symbol means might help? There's room to the left of the buttons, so it wouldn't take up any additional vertical space.

Fri, Dec 6, 3:53 PM · Plasma
ngraham added a comment to D25278: [Baloo KCM] Mention the brand name "Baloo" in user-visible strings.

I would also say that 'Baloo' means nothing to users, and File search should be used instead. It's an internal name, not really a brand.

Fri, Dec 6, 2:38 PM · Plasma
ngraham requested changes to D25375: Start of the accessibility KCM.

Now the KCM doesn't load:

Fri, Dec 6, 2:15 PM · Plasma
ngraham added a comment to D13243: [applet] Add checkbox to show virtual streams.

Oh that's the easy part. Check out the code in KScreen to see how it's possible to export values under a "kcm" namespace.

Fri, Dec 6, 2:02 PM · Plasma
ngraham added a comment to D18000: Tweak slidingpopups effect to make animation smoother.

Cool, llet me know if you need a hand with anything, or would like like someone else to take over.

Fri, Dec 6, 2:01 PM · KWin
ngraham added reviewers for D25682: [WIP] add initial wsdiscovery support: dfaure, Frameworks, Dolphin.
Fri, Dec 6, 2:00 PM · Frameworks, Dolphin
ngraham accepted D25782: [Notifications] Add draggable file icon when single file job finishes.
Fri, Dec 6, 1:58 PM · Plasma
ngraham added a comment to D25782: [Notifications] Add draggable file icon when single file job finishes.

Awesome, this is super-dee-duper useful! +1!

Fri, Dec 6, 1:58 PM · Plasma
ngraham added inline comments to D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing.
Fri, Dec 6, 1:45 PM · Baloo, Plasma
ngraham updated the diff for D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing.

Address review comments

Fri, Dec 6, 1:44 PM · Baloo, Plasma
ngraham added a comment to D9645: Bug fix 369542.

https://bugs.kde.org/show_bug.cgi?id=369542 isn't closed, though. Should this be merged as-is, or does it need more review?

Fri, Dec 6, 1:39 PM · KDE Applications
ngraham committed R166:02f51eb2652f: Save image to clipboard if --nonotify is used (authored by aprcela).
Save image to clipboard if --nonotify is used
Fri, Dec 6, 1:37 PM
ngraham closed D23723: Save image to clipboard if --nonotify is used.
Fri, Dec 6, 1:37 PM · Spectacle
ngraham updated subscribers of D25296: [RFC] Fix Display Configuration icon margins.

@ndavis or @trickyricky26, could I ping you on this?

Fri, Dec 6, 1:06 PM · Frameworks
ngraham added a comment to D16138: Create the default profile if it doesn't exist.

To me it makes sense to ship an internal profile that's equal to the default settings. That's kinda what profiles are, so it's a little odd to have the feature but not ship with one.

Fri, Dec 6, 2:57 AM · Konsole
ngraham added a comment to D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing.

Thanks @davidedmundson. There's one more FIXME in the code that I could use your help with, if you don't mind.

Fri, Dec 6, 2:55 AM · Baloo, Plasma
ngraham updated the test plan for D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing.
Fri, Dec 6, 2:54 AM · Baloo, Plasma
ngraham updated the diff for D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing.

Adjust to D25743 some more

Fri, Dec 6, 2:53 AM · Baloo, Plasma
ngraham added a comment to D11748: Assign notification area category.

You can see the name at https://cgit.kde.org/plasma-desktop.git/commit/?id=1db79dc54c464d159d4ff8e8c91452758c9aa220

Fri, Dec 6, 1:14 AM · Plasma

Thu, Dec 5

ngraham added a comment to D20222: Plasma-Workspace. The last checkbox in the widget settings.

@pavelmos would you like to continue working on this or should someone else take it over?

Thu, Dec 5, 11:30 PM · Plasma
ngraham added a comment to D8773: Improve discoverability of drag-and-drop of toolbar actions.

Haha yes almost exactly like that! Maybe today I'd use a sheet instead of a separate dialog window. But I have great faith that the 2019 David is able to conquer the challenges of 2009. :)

Thu, Dec 5, 11:28 PM · Frameworks
ngraham committed R318:69838a1cdd6a: Add action for focusing Terminal Panel (authored by ngraham).
Add action for focusing Terminal Panel
Thu, Dec 5, 10:53 PM
ngraham closed D10959: Add action for focusing Terminal Panel.
Thu, Dec 5, 10:53 PM · Dolphin
ngraham updated the summary of D10959: Add action for focusing Terminal Panel.
Thu, Dec 5, 10:50 PM · Dolphin
ngraham added a comment to D10959: Add action for focusing Terminal Panel.

I think what was not working before was in fact a Konsole bug that has since been fixed in https://bugs.kde.org/show_bug.cgi?id=411181. Landing this now.

Thu, Dec 5, 10:49 PM · Dolphin
ngraham updated the diff for D10959: Add action for focusing Terminal Panel.

Rebase

Thu, Dec 5, 10:48 PM · Dolphin
ngraham added a comment to D8774: Show Configure Toolbars dialog as modal.

Oops, sorry! I added comments to D8773.

Thu, Dec 5, 10:47 PM · Frameworks
ngraham requested changes to D8773: Improve discoverability of drag-and-drop of toolbar actions.

What I would like to see is that when you open the "Edit Toolbar" dialog that you then can drag around tool bar buttons and drag them from and to the dialog, like Firefox does it and how @colomar suggested. Given you can already re-arrange toolbar buttons whilst said dialog is open, what needs to be added is the ability to drag those from and to the dialog.

Yes, exactly. The closer to Firefox' "Customize" UX, the better. No more separate dialogs, just one mode where you configure your UI.

Thu, Dec 5, 10:46 PM · Frameworks
ngraham updated subscribers of T11878: Fix sponsor logo size for kde.org.

@lydia, is this something the Board could support?

Thu, Dec 5, 10:43 PM · VDG, KDE e.V., Websites
ngraham requested changes to D23316: Port towards KConfig XT.

All functionality works perfectly for me. However this regressed the default width of the settings window. Not it's not wide enough to accommodate all controls without an ugly horizontal scrollbar:

Thu, Dec 5, 10:36 PM · Spectacle
ngraham committed R255:977c002b6f43: Standardize the database upgrade mechanism (authored by jguidon).
Standardize the database upgrade mechanism
Thu, Dec 5, 10:20 PM
ngraham added a comment to D24563: Standardize the database upgrade mechanism.

Thanks so much for this very nice contribution, @jguidon!

Thu, Dec 5, 10:20 PM
ngraham closed D24563: Standardize the database upgrade mechanism.
Thu, Dec 5, 10:20 PM
ngraham added a comment to D23723: Save image to clipboard if --nonotify is used.

@davidre, is this okay now?

Thu, Dec 5, 10:19 PM · Spectacle
ngraham added a comment to D18000: Tweak slidingpopups effect to make animation smoother.

@sefaeyeoglu would yo like to continue working on this? Or should someone take it over?

Thu, Dec 5, 10:13 PM · KWin
ngraham added a dependency for D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else: D25772: [Notifications] Add ServerInfo class.
Thu, Dec 5, 10:08 PM · Plasma
ngraham added a dependent revision for D25772: [Notifications] Add ServerInfo class: D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else.
Thu, Dec 5, 10:08 PM · Plasma
ngraham added a comment to D24563: Standardize the database upgrade mechanism.

Sure thing!

Thu, Dec 5, 10:06 PM
ngraham added a comment to D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end.

@siddharthasahu would you like to continue working on this?

Thu, Dec 5, 10:06 PM · Plasma
ngraham added a comment to D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default.

I guess it depends on whether you see pinned apps as clutter. Personally, I think these are useful, especially for less experienced users. And we have anecdotal evidence that experienced users (e.g. us) add these to their task managers manually. So I don't think this would harm anyone.

Thu, Dec 5, 10:02 PM · Plasma
ngraham closed D16907: Always provide an icon for toolbar and maybe a label.

Looks like this guideline has since been added to the HIG. Sorry this patch sat here for ages like this!

Thu, Dec 5, 9:58 PM
ngraham added a comment to D25743: Expose IndexerState enum to QML.

Thanks, now it compiles! I'm not sure it's working perfectly though. I updated D25447 to use this, but it's claiming that my indexer is suspended, while balooctl status disagrees.

Thu, Dec 5, 9:52 PM · Baloo, Frameworks
ngraham updated the diff for D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing.

Update to work with D25743

Thu, Dec 5, 9:45 PM · Baloo, Plasma
ngraham requested changes to D12851: Change preview text background color to match with default combobox background color.

Hmm, this doesn't look so great all on its own:

Thu, Dec 5, 9:37 PM · Plasma
ngraham added a comment to D21091: Try a standardised versioning scheme using KDE Apps version.

@jriddell ping.

Thu, Dec 5, 9:28 PM
ngraham added a comment to D16138: Create the default profile if it doesn't exist.

Ping.

Thu, Dec 5, 9:25 PM · Konsole
ngraham committed R114:d744370117be: Assign notification area category for Keyboard indicator (authored by wsdfhjxc).
Assign notification area category for Keyboard indicator
Thu, Dec 5, 9:23 PM
ngraham closed D11750: Assign notification area category for Keyboard indicator.
Thu, Dec 5, 9:23 PM · Plasma
ngraham updated subscribers of D11748: Assign notification area category.

@apol does this still make sense to do in org.kde.discover.notifier.desktop.cmake?

Thu, Dec 5, 9:22 PM · Plasma
ngraham committed R119:1db79dc54c46: Assign notification area category for Touchpad indicator (authored by wsdfhjxc).
Assign notification area category for Touchpad indicator
Thu, Dec 5, 9:20 PM
ngraham closed D11749: Assign notification area category for Touchpad indicator.
Thu, Dec 5, 9:20 PM · Plasma
ngraham added a comment to D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection.

@vpilo to move this forward, maybe just remove the header/title in the menu entirely. It's not really necessary after all.

Thu, Dec 5, 9:17 PM · Plasma
ngraham added a comment to D14218: Introduce a test to make sure we're not offering duplicated icons.

@apol we have a duplicate test in breeze-icons now; is this still relevant?

Thu, Dec 5, 9:15 PM · Frameworks
ngraham added a comment to D19947: systray: show a small animation on the icons when activated.

@apol Ping!

Thu, Dec 5, 9:14 PM · Plasma
ngraham added a comment to D5346: DigitalClock: Use correct language for month and day names.

Is this still relevant?

Thu, Dec 5, 9:12 PM · Plasma
ngraham committed R116:0b3ae9737cc8: [Applet] Show more information in the Details tab (authored by mibofra).
[Applet] Show more information in the Details tab
Thu, Dec 5, 9:10 PM
ngraham closed D24940: [Applet] Show more information in the Details tab.
Thu, Dec 5, 9:10 PM · Plasma
ngraham retitled D24940: [Applet] Show more information in the Details tab from Enchanting/Showing more informations on the info section of plasma-nm plasmoid to [Applet] Show more information in the Details tab.
Thu, Dec 5, 9:09 PM · Plasma
ngraham added a comment to D23837: Rename action name to make it consistent with other applications.

You can land this now, @shubham.

Thu, Dec 5, 9:07 PM · Documentation
ngraham added a comment to D25462: [Colors KCM] Use Kirigami.SearchField.

@broulik ping!

Thu, Dec 5, 9:05 PM · Plasma