ngraham (Nathaniel Graham)
User

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2017, 7:18 PM (78 w, 3 d)
Availability
Available

Recent Activity

Today

ngraham accepted D15980: Warn user before renaming the file/folder to start with a ' . '.

Works and looks good to me!

Tue, Oct 16, 9:44 PM · Dolphin
ngraham added a comment to D15763: Set correct image attributes on directory thumbnail.

+1 from me too.

Tue, Oct 16, 9:31 PM · Frameworks, Dolphin
ngraham updated the test plan for D16241: [Folder View] Improve layout and formatting of Icons page.
Tue, Oct 16, 9:16 PM · Plasma
ngraham updated the diff for D16241: [Folder View] Improve layout and formatting of Icons page.

Fix the Text Lines label and spinbox

Tue, Oct 16, 9:15 PM · Plasma
ngraham requested changes to D16257: Use correct wording, since it is an action word(not a noun).

Actually, the original wording is correct--or at least more correct.

Tue, Oct 16, 6:06 PM · Plasma
ngraham planned changes to D16241: [Folder View] Improve layout and formatting of Icons page.

Oops, found a few visual glitches. Will fix today.

Tue, Oct 16, 2:15 PM · Plasma
ngraham added a comment to D16241: [Folder View] Improve layout and formatting of Icons page.

Note: I know the width: 500 is a horrible hack that is certainly the wrong way to do this, but I couldn't figure out how else to get the Labels' width to be long enough so that Layout.alignment: Qt.AlignRight worked. Layout.fillWidth: true had no effect. I look forward to learning the correct way to handle this situation. :)

Tue, Oct 16, 3:18 AM · Plasma
ngraham updated the test plan for D16241: [Folder View] Improve layout and formatting of Icons page.
Tue, Oct 16, 3:18 AM · Plasma
ngraham updated the diff for D16241: [Folder View] Improve layout and formatting of Icons page.

Improve another string

Tue, Oct 16, 3:18 AM · Plasma
ngraham added a comment to D16241: [Folder View] Improve layout and formatting of Icons page.
Tue, Oct 16, 3:15 AM · Plasma
ngraham updated the test plan for D16241: [Folder View] Improve layout and formatting of Icons page.
Tue, Oct 16, 3:13 AM · Plasma
ngraham requested review of D16241: [Folder View] Improve layout and formatting of Icons page.
Tue, Oct 16, 3:12 AM · Plasma
ngraham added a comment to D16235: [Extractor] Exclude Postscript from being indexed.

What?

Tue, Oct 16, 12:15 AM · Baloo, Frameworks

Yesterday

ngraham added a comment to D15908: clarify logic for openScreenshotsFolder, refactor preferences access, and clarify method names.

That worked, thanks! I've landed this for you.

Mon, Oct 15, 7:54 PM · Spectacle
ngraham committed R166:74a2df918f87: clarify logic for openScreenshotsFolder, refactor preferences access, and… (authored by utecht).
clarify logic for openScreenshotsFolder, refactor preferences access, and…
Mon, Oct 15, 7:52 PM
ngraham closed D15908: clarify logic for openScreenshotsFolder, refactor preferences access, and clarify method names.
Mon, Oct 15, 7:52 PM · Spectacle
ngraham added a reviewer for D15842: Lower log level for X-KDE-DBus-ServiceName missing message: davidedmundson.
Mon, Oct 15, 2:19 PM · Frameworks
ngraham added a reviewer for D16220: Add feature to save sensor displays as images: Plasma.
Mon, Oct 15, 1:42 PM · Plasma
ngraham updated the diff for D16186: Fix localization for number of seconds in spinbox.

Address review comments

Mon, Oct 15, 2:29 AM · Spectacle

Sun, Oct 14

ngraham added a comment to D16134: Secure history file.

Rather than making it optional and user-facing, how about automatically encrypting the if the user does not have an encrypted disk/homedir (if we can detect that), and never encrypting if they do?

Sun, Oct 14, 9:56 PM · Konsole
ngraham added a comment to D11869: epubextractor: Add property ReleaseYear.

Go for it!

Sun, Oct 14, 9:53 PM · Baloo, Frameworks
ngraham added a comment to D16212: [Device Notifier] Add a button to unmount all devices.

"Safely remove all?" "Remove all"?

Sun, Oct 14, 9:29 PM · Plasma
ngraham added a comment to D16212: [Device Notifier] Add a button to unmount all devices.

Since the icon is identical to others used on the same pop-up, and there is no real universal "Unmount all" icon, I would support the use of a text label for this button to go along with the icon.

Sun, Oct 14, 9:18 PM · Plasma
ngraham committed R985:62f17e9b6176: Simplify, clarify, and de-jargonize the Convergence page (authored by ngraham).
Simplify, clarify, and de-jargonize the Convergence page
Sun, Oct 14, 8:32 PM
ngraham committed R985:4db76574a128: Clean up and clarify Device Types page (authored by ngraham).
Clean up and clarify Device Types page
Sun, Oct 14, 8:32 PM
ngraham committed R985:f78abb1205a0: Rename "Device Type UX" page to be less jargonistic (authored by ngraham).
Rename "Device Type UX" page to be less jargonistic
Sun, Oct 14, 8:32 PM
ngraham added a comment to T9855: What should happen when you hit PrScr when Spectacle is already running?.
In T9855#164009, @rooty wrote:

"but you can just use SHIFT + PRT SC"

Wow, I didn't know about that!!!!

actually there was a reddit thread about that.... we were talking about how it'd be nice for the meta+print, meta+shift+print keyboard shortcuts to store screenshots in the clipboard vs just saving them in ~/Pictures (so it'd be easier to paste them into a web browser or chat), but that's another issue altogether :D

Sun, Oct 14, 4:28 PM · VDG, Spectacle
ngraham committed R985:6018b061688d: Improve convergence info and include device types (authored by Arucard).
Improve convergence info and include device types
Sun, Oct 14, 4:27 PM
ngraham added a comment to D16137: Add an option to KConfigDialog to fit page contents horizontally.

+1, nice to see this. Once it lands, feel free to start porting apps to use it--for the ones where it'll be acceptable to depend on Frameworks 5.52 as a minimum version.

Sun, Oct 14, 4:25 PM · Frameworks
ngraham closed D15385: Improve convergence info and include device types.
Sun, Oct 14, 4:09 PM · KDE Human Interface Guidelines
ngraham added a comment to D12162: Add support for touch scrolling in Dolphin.

I'll be happy to do all the UI testing if you can do the code review!

Sun, Oct 14, 4:02 PM · Dolphin
ngraham added a comment to T9855: What should happen when you hit PrScr when Spectacle is already running?.

"but you can just use SHIFT + PRT SC"

Sun, Oct 14, 3:53 PM · VDG, Spectacle
ngraham added a comment to D15355: Port KolourPaint away from deprecated KFileDialog.

I like the separate window you've implemented, that seems like a good approach and then we can use the standard dialog.

Sun, Oct 14, 3:51 PM
ngraham added a comment to D15355: Port KolourPaint away from deprecated KFileDialog.

Why can't we use the native KF5 one?

Sun, Oct 14, 3:39 PM
ngraham updated the summary of D16189: kio_help: Fix crash in QCoreApplication when accessing help://.
Sun, Oct 14, 5:06 AM · Frameworks
ngraham abandoned D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon.

No longer needed with D15935 (or at least, the pressure is off).

Sun, Oct 14, 4:06 AM · Frameworks
ngraham added reviewers for D16190: Respect user-specified filetype for Save As... operations: broulik, utecht.
Sun, Oct 14, 4:04 AM · Spectacle
ngraham updated the test plan for D16191: Don't save to a temp file if exporting to another app.
Sun, Oct 14, 4:03 AM · Spectacle
ngraham requested review of D16191: Don't save to a temp file if exporting to another app.
Sun, Oct 14, 4:02 AM · Spectacle
ngraham updated the test plan for D16190: Respect user-specified filetype for Save As... operations.
Sun, Oct 14, 3:28 AM · Spectacle
ngraham added a member for KDE Applications: ngraham.
Sun, Oct 14, 3:27 AM
ngraham requested review of D16190: Respect user-specified filetype for Save As... operations.
Sun, Oct 14, 3:26 AM · Spectacle
ngraham committed R166:b8a40c5775cd: Modernize Settings dialog layout to conform to the HIG (authored by ngraham).
Modernize Settings dialog layout to conform to the HIG
Sun, Oct 14, 2:29 AM

Sat, Oct 13

ngraham committed R31:018844d05a35: Improve accuracy of some window decoration options' labels BUG: 399602 FIXED-IN… (authored by ngraham).
Improve accuracy of some window decoration options' labels BUG: 399602 FIXED-IN…
Sat, Oct 13, 10:25 PM
ngraham updated the diff for D16186: Fix localization for number of seconds in spinbox.

Use safer static_cast<int>() instead of plain old int()

Sat, Oct 13, 10:05 PM · Spectacle
ngraham added a comment to D10099: Use single number as filename for screenshot with empty filename template.

It may be defined, but it's not exactly clear. If we're going to allow an empty text field, we should set a placeholder string so that people can see what the actual pattern will be when the text field is empty. Also, this needs to be documented in the docbook.

Sat, Oct 13, 9:22 PM · Spectacle
ngraham added a comment to D10099: Use single number as filename for screenshot with empty filename template.

Sorry, I'm not sure I understand. :(

Sat, Oct 13, 8:52 PM · Spectacle
ngraham added a comment to D16186: Fix localization for number of seconds in spinbox.

Note: I'm not an expert at localization, so I'd appreciate a thorough review from the Localization folks to make sure I did the right thing. Thanks!

Sat, Oct 13, 8:36 PM · Spectacle
ngraham requested review of D16186: Fix localization for number of seconds in spinbox.
Sat, Oct 13, 8:35 PM · Spectacle
ngraham committed R166:e1cc203525b3: Add ellipsis to "Save As" action on button text BUG: 399765 FIXED-IN: 18.12.0 (authored by ngraham).
Add ellipsis to "Save As" action on button text BUG: 399765 FIXED-IN: 18.12.0
Sat, Oct 13, 8:08 PM
ngraham updated the task description for T9855: What should happen when you hit PrScr when Spectacle is already running?.
Sat, Oct 13, 7:47 PM · VDG, Spectacle
ngraham updated the task description for T9855: What should happen when you hit PrScr when Spectacle is already running?.
Sat, Oct 13, 7:45 PM · VDG, Spectacle
ngraham triaged T9855: What should happen when you hit PrScr when Spectacle is already running? as Wishlist priority.
Sat, Oct 13, 7:41 PM · VDG, Spectacle
ngraham accepted D16171: Move "erase drawing" action to last position and change its icon.

+1, this seems sensible.

Sat, Oct 13, 7:06 PM · Okular
ngraham added a comment to D10099: Use single number as filename for screenshot with empty filename template.

What happens if user deletes filename template in Spectacle settings? Does new token help?

Sat, Oct 13, 7:02 PM · Spectacle
ngraham added a comment to D15011: [Kickoff] Make the search field always look like a search field.

Yeah, and I extended that to simply make it always visible (if it exists; apparently it only does when there's more than one Activity). That's what we want here too.

Sat, Oct 13, 4:13 PM · Plasma
ngraham accepted D16178: i18n: Add semantic context @title:window.
Sat, Oct 13, 4:12 PM · Spectacle
ngraham accepted D16152: [Discover Notifier] Open Updates page in notification.

Thanks Kai!

Sat, Oct 13, 3:31 PM · Plasma
ngraham updated subscribers of D10099: Use single number as filename for screenshot with empty filename template.

Yep, it works! Thanks @alexeymin!

Sat, Oct 13, 3:27 PM · Spectacle
ngraham added a comment to T9830: Application Menubar states and usability.

Ah, I see. That seems like a fairly well-thought-out proposal!

Sat, Oct 13, 2:39 PM · Plasma, VDG
ngraham added a comment to D15011: [Kickoff] Make the search field always look like a search field.

Ah, I didn't even know that the Activity Switcher had a search field. I suspect that @sharvey, the fellow who did most of the work to improve the Widget Explorer's search field, didn't know either.

Sat, Oct 13, 2:38 PM · Plasma
ngraham added a comment to D15385: Improve convergence info and include device types.

Nope, you're good. After @colomar changes his status to "Accepted", this can land.

Sat, Oct 13, 2:28 PM · KDE Human Interface Guidelines
ngraham added a comment to T9830: Application Menubar states and usability.

Sat, Oct 13, 2:36 AM · Plasma, VDG

Fri, Oct 12

ngraham renamed T9226: Unify icon/folder views from Unifiy folder views to Unify icon/folder views.
Fri, Oct 12, 11:39 PM · Frameworks, VDG, Digikam, Gwenview, Dolphin, Plasma
ngraham added a comment to D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required.

[Just as a reminder: this is only for the login screen; the lock screen is not being touched]

Fri, Oct 12, 10:54 PM · Plasma
ngraham created T9847: Fix high-profile System Tray bugs.
Fri, Oct 12, 10:49 PM · Plasma
ngraham accepted D16168: [Tags] Lower default log level to warning, add to categories file.

Thanks!

Fri, Oct 12, 10:11 PM · Baloo, Frameworks
ngraham added reviewers for D16170: [Device Notifier] Restore busy indicator: broulik, bruns.

I have no understanding of this code, but am adding some reviewers who do. :)

Fri, Oct 12, 10:07 PM · Plasma
ngraham added a comment to D16169: Add option to close Kate when last file closes.

+1 for implementing the feature.

Fri, Oct 12, 10:02 PM · Kate
ngraham updated the summary of D16159: Fix double click can only select text within visible region.
Fri, Oct 12, 4:45 PM · Konsole
ngraham added a comment to D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required.

Why should the login screen look different to the lock screen?

Fri, Oct 12, 1:55 AM · Plasma
ngraham updated the summary of D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required.
Fri, Oct 12, 12:54 AM · Plasma
ngraham added a comment to D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required.

As far as I can tell, the blur won't work barring code changes to plasma-framework due to https://bugs.kde.org/show_bug.cgi?id=399686

Fri, Oct 12, 12:54 AM · Plasma

Thu, Oct 11

ngraham added a comment to T9830: Application Menubar states and usability.

I agree, if we keep the Dolphin-style menu-in-a-toolbar-button, we need to radically alter how it's generated, because right now it has many problems. Right now Dolphin just has a bunch of custom code to build it up form scratch, and it actually omits quite a few of the items in the real menu (e.g. see D15609). Obviously it is not ideal for functionality to be invisible like this, which runs counter to the entire purpose of having a main menu.

Thu, Oct 11, 11:10 PM · Plasma, VDG
ngraham added a comment to T9221: Consistent app closing from task switchers.

Bugzilla ticket: https://bugs.kde.org/show_bug.cgi?id=308331

Thu, Oct 11, 11:04 PM · Plasma
ngraham moved T9658: Rethink blur-by-default for Breeze SDDM login screen theme for Plasma 5.15 from To Do to Work in Progress on the Plasma board.
Thu, Oct 11, 11:02 PM · Plasma, VDG
ngraham committed R120:99fa6ccc57c5: KRunner: remove no longer existant and unused column from SQL query (authored by bruns).
KRunner: remove no longer existant and unused column from SQL query
Thu, Oct 11, 10:55 PM
ngraham requested changes to D16138: Create the default profile if it doesn't exist.

This doesn't work for me. If I delete ~/.config/konsolerc* and ~/.local/share/konsole/*.profile, apply the patch, build konsole, and run it clean, I still see no profiles in SettingsConfigure KonsoleProfiles.

Thu, Oct 11, 10:46 PM · Konsole
ngraham requested changes to D16141: Disable unmount option for / or /home.

Can you add CCBUG: 399659 to this so that bug report reflects that two commits were necessary to fully resolve it? Thanks!

Thu, Oct 11, 10:15 PM · Frameworks
ngraham added a comment to D15989: Disable unmount option for / or /home.

We just got a bug report for this: https://bugs.kde.org/show_bug.cgi?id=399659

Thu, Oct 11, 3:38 PM · Dolphin
ngraham added a comment to D10099: Use single number as filename for screenshot with empty filename template.

Please feel free!

Thu, Oct 11, 3:29 PM · Spectacle
ngraham added a comment to D10099: Use single number as filename for screenshot with empty filename template.

@egorov, are you still around?

Thu, Oct 11, 2:59 PM · Spectacle
ngraham added a comment to D15908: clarify logic for openScreenshotsFolder, refactor preferences access, and clarify method names.

Sorry, it didn't work. I get the same merge failure.

Thu, Oct 11, 3:51 AM · Spectacle

Wed, Oct 10

ngraham added a comment to D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required.

Thanks! I'm working on the blur now. You also brought up in the VDG chat that the Virtual Keyboard, session chooser, and battery indicator icons need some better contrast too. Will also work on that.

Wed, Oct 10, 11:39 PM · Plasma
ngraham updated the summary of D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required.
Wed, Oct 10, 11:24 PM · Plasma
ngraham added a comment to D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required.

I've updated the shadows and text according to VDG feedback from this morning and I'm feeling pretty good about the current state. Will try to work on blurry backgrounds for the icons now.

Wed, Oct 10, 11:23 PM · Plasma
ngraham updated the test plan for D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required.
Wed, Oct 10, 11:22 PM · Plasma
ngraham updated the diff for D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required.
  • Reduce shadow darkness
  • Add subtle outlines
  • Increase text size a bit
Wed, Oct 10, 11:17 PM · Plasma
ngraham updated the summary of D13425: File indexer closing improvements..
Wed, Oct 10, 9:30 PM · Baloo, Frameworks
ngraham added a comment to D15580: New annotation toolbar.

To test this revision
Temporary move the file .config/okularpartrc or the annotation tools may not match the ones in the buttons.

This won't be a necessity for the final version, right? We wouldn't want users to have to do this.

That is a good point. If I am not wrong there is a tool to update the configurations file of KDE apps during an upgrade (I think someone told me that in a phabricator discussion). Maybe we can use that tool. Otherwise I can store the same settings using a different key in the the configuration file (less clean solution) in order to not conflict with the existing settings of the users.

Wed, Oct 10, 9:24 PM · Okular
ngraham added reviewers for D13425: File indexer closing improvements.: Baloo, poboiko.

Does this fix https://bugs.kde.org/show_bug.cgi?id=373430 and/or https://bugs.kde.org/show_bug.cgi?id=353559?

Wed, Oct 10, 9:16 PM · Baloo, Frameworks
ngraham added a comment to D15278: Close Dolphin if last tab closed.

Maybe we can change the text of the action from "Close Tab" to "Close Window" if there is only one tab ?

Wed, Oct 10, 9:10 PM · Dolphin
ngraham added reviewers for D15047: Export the StorageDevices object.: Baloo, bruns, poboiko.
Wed, Oct 10, 9:03 PM · Baloo, Frameworks
ngraham added a comment to T9817: Consider shipping some of the best prior Plasma wallpapers.

If we just shipped the largest size for each of them, it wouldn't amount to much more than 2 or 3 MB per wallpaper.

Wed, Oct 10, 3:23 PM · Breeze, Plasma, VDG
ngraham updated the task description for T9830: Application Menubar states and usability.
Wed, Oct 10, 3:05 PM · Plasma, VDG
ngraham updated the task description for T9830: Application Menubar states and usability.
Wed, Oct 10, 3:05 PM · Plasma, VDG
ngraham triaged T9830: Application Menubar states and usability as Normal priority.
Wed, Oct 10, 2:46 PM · Plasma, VDG
ngraham accepted D15589: Add proper labels to Trash Emptied notification.

All right, ship it! Let's improve the icon in https://bugs.kde.org/show_bug.cgi?id=399613

Wed, Oct 10, 2:25 PM · Dolphin
ngraham added a reviewer for D15278: Close Dolphin if last tab closed: VDG.

If we don't want to do this, we should close the bug. If we don't want to do that, we should seriously evaluate whether or not to accept this patch.

Wed, Oct 10, 2:37 AM · Dolphin
ngraham updated the test plan for D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required.
Wed, Oct 10, 2:14 AM · Plasma