ngraham (Nathaniel Graham)
User

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2017, 7:18 PM (69 w, 3 d)
Availability
Available

Recent Activity

Today

ngraham added a comment to D14850: [effects] Turn off Translucency by default.

OK, so that will have the effect of turning translucency off in Plasma 5.14 for the 95+% of people who don't manually turn the effect off or fiddle with its settings. I'm okay with this, but I want to make sure everyone else is too before we do that.

Wed, Aug 15, 4:05 PM · KWin
ngraham added a comment to D14850: [effects] Turn off Translucency by default.

Thanks for doing all the work. :p

Wed, Aug 15, 3:21 PM · KWin
ngraham added a comment to D14850: [effects] Turn off Translucency by default.
  • otherwise, if there is Effect-kwin4_effect_translucency config group, set kwin4_effect_translucencyEnabled=true.
Wed, Aug 15, 11:33 AM · KWin
ngraham added a comment to D14850: [effects] Turn off Translucency by default.

Do we have any documentation for these? I've never written one before.

Wed, Aug 15, 11:32 AM · KWin
ngraham added a comment to D14850: [effects] Turn off Translucency by default.

I think the point is that people who do like this effect and benefit in some way from its characteristics can register that preference by turning it on. Nobody is proposing getting rid of it, just that it isn't really an appropriate default for most people.

Wed, Aug 15, 10:39 AM · KWin
ngraham added a comment to D14849: [Labels] Make the Ellipses section more clear.

Looks like I don't have commit rights:

Wed, Aug 15, 10:36 AM
ngraham updated the diff for D14849: [Labels] Make the Ellipses section more clear.

Address review comments

Wed, Aug 15, 7:10 AM

Yesterday

ngraham added a comment to T9273: Announcement text for the Applications 18.08 release.

None here! Looks great.

Tue, Aug 14, 11:04 PM · KDE Promo, KDE Applications
ngraham added a comment to T9273: Announcement text for the Applications 18.08 release.

Beautiful.

Tue, Aug 14, 10:48 PM · KDE Promo, KDE Applications
ngraham added a comment to T9273: Announcement text for the Applications 18.08 release.

I hope it's not nitpicking too much but could we have a screenshot taken with Spectacle's Active Window mode so that we get the window shadow and it matches all the other images in the announcement? Also if you can open just the email in a separate window, that would make for a better screenshot as well as inherently preserve more of your privacy.

Tue, Aug 14, 10:20 PM · KDE Promo, KDE Applications
ngraham added a comment to T9273: Announcement text for the Applications 18.08 release.

Thanks, anything is better than nothing! :) Any chance we could get a full app window screenshot so the context is a bit clearer?

Tue, Aug 14, 10:02 PM · KDE Promo, KDE Applications
ngraham added a comment to D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button.

Ah, I'm sorry. I'm getting my patches confused. The PC2 TextField's bug is that it doesn't show placeholder text properly with light themes when software rendering isn't being used. I'm open to other ways of fixing that.

Tue, Aug 14, 9:18 PM · Frameworks
ngraham added a comment to D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button.

To back up a bit, the issue is that we currently have no TextField with has the following characteristics:

  1. Has built-in functionality for clear and password reveal buttons, so each client doesn't need to re-invent the wheel (PC2 one has this, PC3, QQC1, and QQC2 ones do not)
  2. Placeholder text looks good with fractional scale factors (PC3 and QQC2 ones have this, PC2 and QQC1 ones do not)
Tue, Aug 14, 9:07 PM · Frameworks
ngraham accepted D14755: Allow to double-click to accelerate crop and red-eye modifications.

+1 ship it!

Tue, Aug 14, 8:50 PM
ngraham added inline comments to D14755: Allow to double-click to accelerate crop and red-eye modifications.
Tue, Aug 14, 8:42 PM
ngraham added a comment to D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button.

So from in-person conversations this week, it seems like we have a few paths forward here:

  • Upstream the features we wrote into our PlasmaComponents TextField and then just use that. Downsides: lengthy process, will take forever before we can actually use it here.
  • Finally fix the Qt bug that prevents QQC1 and PC2 components with text from working properly. Downsides: we already tried this and accidentally made it worse. Seems tricky.
  • Work around the text rendering issue in the QQC1 style as well so that all QQC1 and PC2 components with text look fine with no other modifications. Downsides: maybe none? Am I not seeing them? @davidedmundson?
Tue, Aug 14, 8:34 PM · Frameworks
ngraham added a comment to T9273: Announcement text for the Applications 18.08 release.

This announcement is looking more professional all the time. Kudos to all who have contributed here.

Tue, Aug 14, 8:23 PM · KDE Promo, KDE Applications
ngraham added inline comments to D7087: Add "Copy Info" button to the About System KCM.
Tue, Aug 14, 8:15 PM · Plasma
ngraham updated the diff for D14849: [Labels] Make the Ellipses section more clear.

Remove reference to "in a separate window", since that's not true

Tue, Aug 14, 8:12 PM
ngraham requested review of D14851: Update Ubuntu build instructions.
Tue, Aug 14, 7:59 PM
ngraham updated the summary of D14850: [effects] Turn off Translucency by default.
Tue, Aug 14, 7:36 PM · KWin
ngraham requested review of D14850: [effects] Turn off Translucency by default.
Tue, Aug 14, 7:28 PM · KWin
ngraham added a reviewer for D14836: Kicker: Reset re-used menu width to default one: hein.

Works well for me, FWIW. But I seem to remember that that the original patch had some logic specifically to enable this behavior that we're now trying to turn off... can we now simplify all that?

Tue, Aug 14, 6:37 PM · Plasma
ngraham updated the summary of D14849: [Labels] Make the Ellipses section more clear.
Tue, Aug 14, 6:13 PM
ngraham updated the diff for D14849: [Labels] Make the Ellipses section more clear.

Unify wording for two sections

Tue, Aug 14, 6:10 PM
ngraham updated the diff for D14849: [Labels] Make the Ellipses section more clear.

Remove "Check Spelling..." since its title alone isn't enoughh information to determine whether it meets the criteria; implementation detauls could make it go either way

Tue, Aug 14, 6:09 PM
ngraham requested review of D14849: [Labels] Make the Ellipses section more clear.
Tue, Aug 14, 6:07 PM
ngraham requested review of D14834: [Labels] Correct typo in title.
Tue, Aug 14, 2:05 PM
ngraham updated subscribers of D14830: Add "Display Configuration" context menu entry on the desktop.

The text needs to start with a verb and end with an ellipsis, E.g. "Configure Display Settings..." or even "Configure Displays..."

According to HIG:

Do not use an ellipsis for selections which […] do not require user input (such as configuration dialogs).
[…]
Do not use an ellipsis for the following menu items and buttons:
[…]
Preferences

Tue, Aug 14, 1:42 PM · Plasma
ngraham added a comment to D14830: Add "Display Configuration" context menu entry on the desktop.

The text needs to start with a verb and end with an ellipsis, E.g. "Configure Display Settings..." or even "Configure Displays..."

Tue, Aug 14, 1:37 PM · Plasma
ngraham added a comment to D14511: [TerminalDisplay] Handle forward/backward buttons to switch tabs.

Do we have to add an option right now from the get-go? I have a hard time imagining that anyone will complain, since (and correct me if I'm wrong) the side buttons currently do nothing in Konsole. Can we wait to add an option until we get a Bugzilla tickets with complaints?

Tue, Aug 14, 1:25 PM · Konsole
ngraham added a comment to T8753: Launcher Menus Convergence.

We discussed this in the VDG BoF today in Akademy and the idea as originally articulated here did not prove to be very popular. Arguments against it includes the following:

  • We already have a more general way to switch between alternatives, even if it's not as polished or discoverable as it should be
  • Kicker, Kickoff, and Application Dashboard are not fungible; they target different use cases, so it doesn't make sense to make one easily able to morph into another
  • Since people don't switch launchers frequently (or ever), it doesn't make sense to put a button right there visible in the main UI to do it
Tue, Aug 14, 9:49 AM · Plasma, VDG
ngraham added a comment to D10298: Fix searching in RTL PDFs.

Thanks! Just so you know, the work in this patch moved to D10455: Add RTL support for search, copy & paste in pdf.

Tue, Aug 14, 8:27 AM · Okular

Mon, Aug 13

ngraham committed R242:2e640ce13a37: Improve Widgets' removal and configure text (authored by ngraham).
Improve Widgets' removal and configure text
Mon, Aug 13, 10:19 PM
ngraham closed D14810: Improve Widgets' removal and configure text.
Mon, Aug 13, 10:19 PM · Frameworks
ngraham added a comment to D14810: Improve Widgets' removal and configure text.

Thanks!

Mon, Aug 13, 10:19 PM · Frameworks
This is a test notification, sent at Mon, Aug 13, 3:42 PM.
Mon, Aug 13, 9:42 PM
This is a test notification, sent at Mon, Aug 13, 3:42 PM.
Mon, Aug 13, 9:42 PM
This is a test notification, sent at Mon, Aug 13, 3:42 PM.
Mon, Aug 13, 9:42 PM
ngraham abandoned D14118: Improve "Remove this [widget]" text.

Dangit, git. Let's try again: D14810: Improve Widgets' removal and configure text

Mon, Aug 13, 9:36 PM · Frameworks
ngraham updated the test plan for D14810: Improve Widgets' removal and configure text.
Mon, Aug 13, 9:35 PM · Frameworks
ngraham requested review of D14810: Improve Widgets' removal and configure text.
Mon, Aug 13, 9:34 PM · Frameworks
ngraham added a comment to D11838: Turn on line numbers by default.

Thanks so much, guys! So much improvement in so little time. It's very impressive.

Mon, Aug 13, 9:25 PM · Frameworks, Kate
ngraham added a comment to D14310: Fixes url whitespaces in epub documents.

Yes he can.

@ngraham when you want to check if someone has commit rights you can check https://websvn.kde.org/trunk/kde-common/accounts?view=markup

Mon, Aug 13, 9:21 PM · Okular
ngraham updated the diff for D14118: Improve "Remove this [widget]" text.

Make the text consistent

Mon, Aug 13, 3:20 PM · Frameworks
ngraham added a comment to D14310: Fixes url whitespaces in epub documents.

Can you commit this yourself, @gassaf?

Mon, Aug 13, 3:01 PM · Okular
ngraham added inline comments to D14755: Allow to double-click to accelerate crop and red-eye modifications.
Mon, Aug 13, 3:00 PM
ngraham added a comment to D9572: [platforms/fbdev] Attempt to set the framebuffer color layout on the framebuffer device.

Thanks for your patience here, @nerdopolist.

Mon, Aug 13, 2:56 PM · KWin
ngraham added a comment to D13880: [KMoreTools] Reduce menu hierarchy.

I'm okay with this patch as a first step, FWIW.

Mon, Aug 13, 2:13 PM · Frameworks
ngraham added a reviewer for D14787: Fix 'ThemeTest::testCompositingChange() fails if windows manager is running': Plasma.
Mon, Aug 13, 1:59 PM · Frameworks
ngraham closed T9215: Give Nate Graham moderation rights as Resolved.

Yep, I can see it! Sorry for taking so long on this.

Mon, Aug 13, 1:58 PM · KDE Store
ngraham accepted D14697: X11: set GDK_SCALE (try 2).

Tested this out and it works flawlessly for Firefox, Lollypop, and GIMP (to the extent that GIMP does support HiDPI) with the integer scale factor use case as long as the Font DPI settings haven't been monkeyed with. But that would be a separate issue, since they are known to conflict.

Mon, Aug 13, 1:24 PM · Plasma
ngraham added a reviewer for D14785: Fix DialogNativeTest in multi screen configuration: Plasma.
Mon, Aug 13, 12:09 PM · Frameworks
ngraham added a comment to D14243: Fix bad model hygiene in Positioner::move().

This actually seems to break re-arranging files, at least on Qt 5.11.1:


Reverting this patch makes it work again

All files right-of the one inserted disappear until Plasma is restarted

Mon, Aug 13, 10:54 AM · Plasma
ngraham added inline comments to D14755: Allow to double-click to accelerate crop and red-eye modifications.
Mon, Aug 13, 10:53 AM
ngraham added a comment to D14755: Allow to double-click to accelerate crop and red-eye modifications.

Very nice improvement. Seems to work perfectly in my testing. I have a string change request below:

Mon, Aug 13, 9:54 AM
ngraham added a comment to D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized..

I'm doing all my testing in a KDE Neon VM, FWIW. Would you be able to set that one up and try it there to see if you can reproduce it?

Mon, Aug 13, 9:27 AM · Plasma
ngraham added a comment to T9177: Splitting Touchpad KCM.

Great, glad to see you again! Let us know if we can help.

Mon, Aug 13, 9:26 AM · Plasma
ngraham added a comment to D14692: Use custom QScrollArea with size hint not limited by font size.

Thanks so much!

Mon, Aug 13, 9:03 AM · Frameworks
ngraham added reviewers for D14778: Disable loading of translations when using 'C' locale: Frameworks, apol.
Mon, Aug 13, 8:54 AM · Build System, Frameworks
ngraham updated the summary of D14778: Disable loading of translations when using 'C' locale.
Mon, Aug 13, 8:53 AM · Build System, Frameworks
ngraham added reviewers for D14779: Fix 'kformattest fails with installed kcoreaddons language package': Frameworks, cfeck.
Mon, Aug 13, 8:53 AM · Frameworks
ngraham updated the summary of D14779: Fix 'kformattest fails with installed kcoreaddons language package'.
Mon, Aug 13, 8:53 AM · Frameworks
ngraham added a comment to T9273: Announcement text for the Applications 18.08 release.

Here's an image for Dolphin of the redesigned settings window:

Mon, Aug 13, 8:44 AM · KDE Promo, KDE Applications
ngraham added a comment to D14692: Use custom QScrollArea with size hint not limited by font size.

Yes please.

Mon, Aug 13, 8:30 AM · Frameworks
ngraham added a comment to D14758: use view lines for wheel scrolling, not real lines.

+1, will do.

Mon, Aug 13, 8:26 AM · Frameworks, Kate
ngraham added a comment to D14758: use view lines for wheel scrolling, not real lines.

Will do!

Mon, Aug 13, 8:25 AM · Frameworks, Kate
ngraham added a comment to D14758: use view lines for wheel scrolling, not real lines.

The "overly sensitive touchpad" issue seems to be missing accumulation of scroll events, so this patch to my understanding should not have it.

Yeah, I don't think that's our bug, and we shouldn't work around it here. The reporter should file a bug against libinput.

Hmm, I understood this differently. I thought this happens when you react to each input event sent by the kernel, regardless of its delta, like e.g. the old gwenview code did which you linked: it just zooms in once per event. Thus devices which generate more events with smaller deltas zoom in faster, which is not good. And this bug is definitely at the application level, not in libinput.

Mon, Aug 13, 8:24 AM · Frameworks, Kate
ngraham added a comment to D14770: Generate file thumbnails before folder thumbnails.

Yes, I used the latest version of the patch. My comments are still:

  • With folders interspersed within the files: big improvement
  • With folders first:
    • Small number of sub-folders: big improvement
    • Medium number of sub-folders: a wash
    • Enough sub-folders so that you need to scroll to see any files: regression since it seems for a moment that nothing's happening
Mon, Aug 13, 8:19 AM · Dolphin
ngraham added a comment to D14770: Generate file thumbnails before folder thumbnails.

Just gave this a try on my pictures folder, with "Folders first" turned on (it's the default setting). Observations:

  • In a folder with a small number of sub-folders and a large number of images, it's nicer, since the fime thumbnails show up faster
  • In a folder with a medium number of sub-folders, it's tiny bit odd but mostly fine.
  • In a folder with a large number of sub-folders (more than will fit on the screen at once), it's very odd since it looks like nothing it happening for a few moments.

What would happen if the user selects a view mode that is contrary to the arrangement of Folders > Thumbnails and instead arranged the sorting to be Thumbnails (Images) > Folders ? Would this mean that folders load first still?

Mon, Aug 13, 8:07 AM · Dolphin
ngraham added a comment to D14661: Force reevaluation of Predicates if interfaces are removed.

This works for me, FWIW. I've bee running with it for several days. Haven't found any regressions yet with other use cases.

Mon, Aug 13, 8:06 AM · Frameworks
ngraham added a comment to D14770: Generate file thumbnails before folder thumbnails.

Just gave this a try on my pictures folder, with "Folders first" turned on (it's the default setting). Observations:

  • In a folder with a small number of sub-folders and a large number of images, it's nicer, since the fime thumbnails show up faster
  • In a folder with a medium number of sub-folders, it's tiny bit odd but mostly fine.
  • In a folder with a large number of sub-folders (more than will fit on the screen at once), it's very odd since it looks like nothing it happening for a few moments.
Mon, Aug 13, 8:02 AM · Dolphin
ngraham added a comment to D14770: Generate file thumbnails before folder thumbnails.

Is this about generating the thumbnails for the first time or displaying them?

Mon, Aug 13, 7:53 AM · Dolphin
ngraham added a comment to D14758: use view lines for wheel scrolling, not real lines.

The "overly sensitive touchpad" issue seems to be missing accumulation of scroll events, so this patch to my understanding should not have it.

Mon, Aug 13, 7:49 AM · Frameworks, Kate
bencreasy awarded T6831: Top-notch usability and productivity for basic software a Like token.
Mon, Aug 13, 5:38 AM · Goal settings 2017
bencreasy awarded T6831: Top-notch usability and productivity for basic software a Like token.
Mon, Aug 13, 5:38 AM · Goal settings 2017

Sun, Aug 12

ngraham added a comment to D14758: use view lines for wheel scrolling, not real lines.

Thanks for the patch, Sven!

Sun, Aug 12, 10:09 PM · Frameworks, Kate
ngraham added a comment to D10298: Fix searching in RTL PDFs.
Sun, Aug 12, 7:51 AM · Okular
ngraham added a comment to D14692: Use custom QScrollArea with size hint not limited by font size.

Are you waiting for another review before landing this?

Sun, Aug 12, 5:08 AM · Frameworks
ngraham added a comment to D14746: [Style KCM] Use "configure" icon.

Retroactive +1!

Sun, Aug 12, 4:32 AM · Plasma

Sat, Aug 11

ngraham requested changes to D14737: Move "update" button from the left side to the right side in NIC module .

What branch did you make this patch against? It doesn't apply for me against master:

Sat, Aug 11, 8:17 PM · Plasma
ngraham requested changes to D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line..

Sorry, I'm with Kai on this, aspecially because one of the proposed new shortcuts conflicts with an existing shortcut that it's possible to use here.

Sat, Aug 11, 7:23 PM · Plasma

Fri, Aug 10

ngraham added a comment to T7927: Fonts “easy mode”.
In T7927#154291, @rkflx wrote:

it will always produce incorrect output for the Fixed Width

Again, not true! Did you actually try this or look at the code before commenting? Changing the font name of all fonts via the button won't change the fixed font. (The only oddity is that changing the size will make the small font the same size as the other fonts.)

Fri, Aug 10, 6:49 PM · VDG, Plasma: KCM Redesign
ngraham added a reviewer for D14736: Add a mode where all the bottom part can be hidden: Elisa.
Fri, Aug 10, 6:42 PM
ngraham added a comment to T7927: Fonts “easy mode”.

I wonder why one would like to use a non-fixed-width font for text that is supposed to be used with such fonts…

Fri, Aug 10, 5:53 PM · VDG, Plasma: KCM Redesign
ngraham added a comment to T7927: Fonts “easy mode”.

Absolutely!

Fri, Aug 10, 4:56 PM · VDG, Plasma: KCM Redesign
ngraham accepted D14700: Bump QT_MIN_VERSION and KF5_MIN_VERSION.

+1 for me. I don't see anything wrong with depending on an LTS Qt version. Distros that are still shipping very old versions of Qt aren't going to be shipping bleeding-edge versions of Gwenview--or KDE Applications more generally.

Fri, Aug 10, 4:54 PM
ngraham added a comment to T7927: Fonts “easy mode”.
In T7927#154109, @rkflx wrote:

How about a simple plus/minus button, which affects all different font types at once? (IOW, providing an inline "easy" alternative to the Adjust All button for a single topic.)

Fri, Aug 10, 4:53 PM · VDG, Plasma: KCM Redesign
ngraham added a comment to D14702: Java: add binaries & hex-float, and support underscores in numbers.
  • BUG 386391
Fri, Aug 10, 4:46 PM · Frameworks, Kate
ngraham accepted D14588: Deduplicate default filename template code.

+1, nice refactoring. I approve of the code changes, and the user-facing behavior isn't impacted.

Fri, Aug 10, 4:44 PM
ngraham accepted D14716: Fix missing notification title found by -Wswitch-enum.
Fri, Aug 10, 2:51 PM
ngraham added a comment to D14723: Add option to disable KWallet entirely in the new wallet dialog.

+1 conceptually, as this seems relevant to the privacy initiative as well.

Fri, Aug 10, 1:01 PM · Frameworks

Wed, Aug 8

ngraham added a comment to D13782: Ignore NTFS hidden flag for root volume.

@broulik? Is it ready to land?

Wed, Aug 8, 10:43 PM · Frameworks
ngraham added a comment to D14442: Unify window and tab title.

Thanks for the ping, sometimes things get lost when everyone's busy!

Conceptually, I am in strong agreement with this. It makes sense that the tab title is the same as the window title.

However, this introduces a slight regression in tab names for certain use cases: KIOSlaves now have a trailing - / at the end of them. E.g. open a new tab and go to tags:// before and after applying your patch, then compare the tab titles. This is a pre-existing issue for the window title, but by using that window title for the tab title, we inherit the issue. The old tab title handling code handled that; do you think you could update the diff to handle it for the window title too so that the tab titles re-inherit the behavior?

No worries :)

Thanks for the feedback, I will look into this issue and see if I can fix it.

So just to clarify the behavior; there should never be a - / in the window title or the tab title? This seems to be added specifically by line 416-421 and then appending the fileName or '/' if it is empty, so should this code simply be removed? What information is relevant for the user in this case? Maybe just showing the URL as the user has typed it is the most sane, so in the example you provide, the window title and tab title would simply be tags:// ? Personally I prefer this simple behavior of showing the short hand URL or the full path, depending on your settings (GeneralSettings::showFullPathInTitlebar).

Wed, Aug 8, 9:26 PM · Dolphin
ngraham updated subscribers of T7927: Fonts “easy mode”.
In T7927#154103, @rkflx wrote:

Have you thought about how to keep the simple and the advanced tabs in sync, in particular when the user chooses conflicting options in both of them at the same time?

This might become hairy and confusing very fast, and might not be what users are expecting in some cases.

Wed, Aug 8, 8:39 PM · VDG, Plasma: KCM Redesign
ngraham added a comment to T7927: Fonts “easy mode”.

+1

Wed, Aug 8, 7:30 PM · VDG, Plasma: KCM Redesign
ngraham requested changes to D14442: Unify window and tab title.

Thanks for the ping, sometimes things get lost when everyone's busy!

Wed, Aug 8, 2:34 PM · Dolphin
ngraham added a comment to D14161: [KStyle] Use dialog-question for question icon.

Thanks for noticing, LGTM and restores the proper icon indeed.

This was changed in KMessageBox in 9b05a12a43dbe2b31a4655052f20de0832ac7a61 but never "upstreamed" to KStyle

Sorry, did not know about this, and neither did the reviewer notice.

Should I submit Diffs (or commit directly?) where the wrong icon is still in use, e.g. here, here, here and/or here?

Wed, Aug 8, 1:57 PM · Frameworks
ngraham accepted D14692: Use custom QScrollArea with size hint not limited by font size.

Thanks!

Wed, Aug 8, 1:46 PM · Frameworks
ngraham committed R241:295cdcac733a: Clean up whitespace (authored by ngraham).
Clean up whitespace
Wed, Aug 8, 1:44 PM