ngraham (Nathaniel Graham)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2017, 7:18 PM (53 w, 1 d)
Availability
Available

Recent Activity

Yesterday

ngraham accepted D12446: Update window title after closing split view.

Thanks, this fixes the issue for me! I played around with split view a lot and wasn't able to find any regressions. Other Dolphin folks, does this look sane?

Sun, Apr 22, 10:52 PM
ngraham added a comment to D12458: Overhaul image resize dialog.

Hm, maybe I should change it back to a fixed size? Let's wait what people think.

Is there any HIG recommendation for this?

Reverting the combobox size change might yield that.

Not sure what you mean by that?

Sun, Apr 22, 9:36 PM
ngraham added a comment to D12458: Overhaul image resize dialog.

I would prefer a non-resizable dialog whose UI can't possibly be too small. Reverting the combobox size change might yield that. But it's a minor thing and I won't press, so this is the last I'll say on the subject.

Sun, Apr 22, 9:32 PM
ngraham added a comment to D12458: Overhaul image resize dialog.

Right, because I see that you made it horizontally resizable. What was the reason for that?

Sun, Apr 22, 9:28 PM
ngraham added a comment to D12458: Overhaul image resize dialog.

Looks like this change resulted in the dialog gain a maximize button. Intentional?

Sun, Apr 22, 9:11 PM
ngraham updated the task description for T8552: Polish Open/Save dialogs.
Sun, Apr 22, 9:07 PM · VDG
ngraham added a comment to D12459: WIP: [Icon KCM] Port to new design.

Oh my god, this looks so, so good. I love the icon size slider panel.

Sun, Apr 22, 8:57 PM · Plasma
ngraham added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

Anyhow, here another solution, the one that you mentioned last. It's the same approach that Microsoft uses in PowerPoint, there you can have multiple items selected and you can select one by one

I'm still refactoring that thing but the visual should not change.

Sun, Apr 22, 5:50 PM · Spectacle
ngraham added a comment to D11137: overflow-menu as view-more-symbolic, and horizontal.

This change broke the CI: https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/76/

Sun, Apr 22, 5:45 PM · Frameworks
ngraham added a comment to D12446: Update window title after closing split view.

Thanks for the patch! Please add "BUG: <number of bug> somewhere to the Summary text. https://community.kde.org/Infrastructure/Phabricator#Add_special_keywords

Sun, Apr 22, 5:42 PM
ngraham updated the task description for T8552: Polish Open/Save dialogs.
Sun, Apr 22, 5:20 PM · VDG
ngraham committed R241:b9a2ec685e7f: Filepicker reads thumbs preview from Dolphin settings (authored by anemeth).
Filepicker reads thumbs preview from Dolphin settings
Sun, Apr 22, 5:18 PM
ngraham closed D12389: Filepicker reads thumbs preview from Dolphin settings.
Sun, Apr 22, 5:18 PM · Frameworks
ngraham committed R318:b9143a55a7ea: Move "Open" actions to the top of the context menu for files (authored by ngraham).
Move "Open" actions to the top of the context menu for files
Sun, Apr 22, 3:47 PM
ngraham closed D11884: Move "Open" actions to the top of the context menu for files.
Sun, Apr 22, 3:41 PM
ngraham accepted D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..

@davidedmundson?

Sun, Apr 22, 3:32 PM · Plasma
ngraham committed R241:ed714cb876bc: Add Desktop and Downloads to the default list of Places (authored by ngraham).
Add Desktop and Downloads to the default list of Places
Sun, Apr 22, 3:24 PM
ngraham updated the task description for T8349: Improve Places panel usability and presentation.
Sun, Apr 22, 3:24 PM · Dolphin
ngraham closed D11768: Add Desktop and Downloads to the default list of Places.
Sun, Apr 22, 3:24 PM · Frameworks
ngraham removed a dependency for D11768: Add Desktop and Downloads to the default list of Places: D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default.
Sun, Apr 22, 3:21 PM · Frameworks
ngraham removed a dependent revision for D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default: D11768: Add Desktop and Downloads to the default list of Places.
Sun, Apr 22, 3:21 PM · Frameworks
ngraham updated the summary of D11768: Add Desktop and Downloads to the default list of Places.
Sun, Apr 22, 3:20 PM · Frameworks
ngraham added a task to D11768: Add Desktop and Downloads to the default list of Places: T8349: Improve Places panel usability and presentation.
Sun, Apr 22, 3:19 PM · Frameworks
ngraham added a revision to T8349: Improve Places panel usability and presentation: D11768: Add Desktop and Downloads to the default list of Places.
Sun, Apr 22, 3:18 PM · Dolphin
ngraham added a comment to D11768: Add Desktop and Downloads to the default list of Places.

Heh, thanks. Renato said he'd fix the tests soon, FWIW.

Sun, Apr 22, 3:17 PM · Frameworks
ngraham added a comment to D11884: Move "Open" actions to the top of the context menu for files.

Yeah, I'm gonna land this today.

Sun, Apr 22, 2:38 PM
ngraham updated the task description for T7682: Proposed look-and-feel changes.
Sun, Apr 22, 2:32 PM · VDG
ngraham updated the task description for T7682: Proposed look-and-feel changes.
Sun, Apr 22, 2:32 PM · VDG
ngraham added a comment to D11308: Use the default Plasma wallpaper on the lock screen.

Landing per Marco's instructions, since the whole lockscreen thingy is going in.

Sun, Apr 22, 2:28 PM · Plasma
ngraham committed R133:6e5e6adad191: Use the default Plasma wallpaper on the lock screen (authored by ngraham).
Use the default Plasma wallpaper on the lock screen
Sun, Apr 22, 2:28 PM
ngraham closed T7914: Use a prettier background for the lock & login screens as Resolved by committing R133:6e5e6adad191: Use the default Plasma wallpaper on the lock screen.
Sun, Apr 22, 2:28 PM · VDG
ngraham closed D11308: Use the default Plasma wallpaper on the lock screen.
Sun, Apr 22, 2:28 PM · Plasma
ngraham added a comment to D12278: WIP: [Colors KCM] Port to new design.

I also don't like "Default" either. What does that even mean to a regular user?

That basically reloads the "no config" case hardcoded in KColorScheme. I think we should drop that and then make sure the "Default" button works well (as in: select Breeze).

Sun, Apr 22, 2:23 PM · Plasma
ngraham added a comment to D10980: updated hanle icon.
In D10980#251709, @mart wrote:

Maybe less dots?:

(Not sure yet about the size of the triangle.)

i like this more :)
(proportionally the size of the triangle seems ok?)

Sun, Apr 22, 2:15 PM · Frameworks
ngraham updated the task description for T8349: Improve Places panel usability and presentation.
Sun, Apr 22, 2:05 PM · Dolphin
ngraham abandoned D8206: Add Duplicate feature.

Oops, re-opened the wrong revision.

Sun, Apr 22, 1:17 PM · Dolphin
ngraham added inline comments to D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
Sun, Apr 22, 1:15 PM · Plasma
ngraham added reviewers for D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available: Frameworks, Dolphin.
Sun, Apr 22, 4:32 AM · Frameworks
ngraham added a comment to D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available.

I took a crack at accessing statx directly, but I'm waaaaaay out of my depth here and will need some help making this actually work. There doesn't seem to be a glibc wrapper for statx yet, so we have to access it directly, which is messy and I haven't figured out how to make it work yet, though I think I might be on the right track.

Sun, Apr 22, 4:29 AM · Frameworks
ngraham updated the test plan for D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available.
Sun, Apr 22, 4:23 AM · Frameworks
ngraham updated the diff for D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available.

Attempt so far unsuccessfully to use statx directly

Sun, Apr 22, 4:21 AM · Frameworks

Sat, Apr 21

ngraham updated the diff for D11884: Move "Open" actions to the top of the context menu for files.

Simplify this code a bit

Sat, Apr 21, 9:34 PM
ngraham updated the test plan for D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility.
Sat, Apr 21, 9:16 PM · Frameworks
ngraham updated the diff for D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility.

Move the warnings to their own line so they're not missed, and also to improve the presentation

Sat, Apr 21, 9:16 PM · Frameworks
ngraham updated the test plan for D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file.
Sat, Apr 21, 9:11 PM · Frameworks
ngraham updated the diff for D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file.

Move the warnings to their own line so they're not missed, and also to improve the presentation

Sat, Apr 21, 9:09 PM · Frameworks
Restricted Application added a project to D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file: Frameworks.
Sat, Apr 21, 8:44 PM · Frameworks
ngraham added a dependent revision for D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility: D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file.
Sat, Apr 21, 8:44 PM · Frameworks
ngraham requested review of D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file.
Sat, Apr 21, 8:42 PM · Frameworks
ngraham reclaimed D8206: Add Duplicate feature.

Re-opening to restart the discussion since apparently now it's not just me; we got a user request for this feature: https://bugs.kde.org/show_bug.cgi?id=393367

Sat, Apr 21, 8:35 PM · Dolphin
ngraham updated the summary of D8206: Add Duplicate feature.
Sat, Apr 21, 8:33 PM · Dolphin
ngraham added a comment to D12278: WIP: [Colors KCM] Port to new design.
In D12278#251210, @mart wrote:

It would be really cool if the delegates would show a little preview of a window actually using these colors, instead of the current grid of colored squares.

it's probably not trivial with how colors are done in qqc2 right now.. i plan to add more custom colors for kirigami, but non essential for now?

Sat, Apr 21, 8:01 PM · Plasma
ngraham added a comment to D12278: WIP: [Colors KCM] Port to new design.

-1 for "current" here too.

Sat, Apr 21, 8:00 PM · Plasma
ngraham added a comment to D10980: updated hanle icon.

I really don't like that icon at all, I'm afraid. It has no meaning to me. It doesn't suggest directionality, movement, or dragging.

Sat, Apr 21, 7:56 PM · Frameworks
ngraham added a comment to D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS.

+1 for not letting the perfect be the enemy of the good here. Multi-monitor support is a pain point for many of our users.

Sat, Apr 21, 7:47 PM · Plasma
ngraham updated the test plan for D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility.
Sat, Apr 21, 7:41 PM · Frameworks
ngraham requested review of D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility.
Sat, Apr 21, 7:40 PM · Frameworks
ngraham added a comment to D12306: Filepicker dialog proper grid icon layout.

Me too. Let's not let the perfect be the enemy of the good here. @rkflx, are you satisfied with this now?

Sat, Apr 21, 7:27 PM · Frameworks
ngraham added a comment to D12102: Port Language KCM to Qt Quick.

+1 for putting the text on the top rather than the bottom. Once we make the list draggable, it might be nice to incorporate that into the text too, e.g "drag languages into your preferred order" or something like that.

Sat, Apr 21, 7:21 PM · Kirigami, Plasma
ngraham added a comment to D12102: Port Language KCM to Qt Quick.

For this list, where the items themselves don't do anything on click, I think it's sane to allow the whole list item to be a drag area. There's more of a challenge to allow re-ordering items that do something when you click on them, but we don't have that issue here.

Sat, Apr 21, 3:00 PM · Kirigami, Plasma
ngraham added a comment to D7929: [WIP] Add new Column View option to KDirOperator.

Ah, what a shame.

Sat, Apr 21, 2:56 PM · Frameworks
ngraham added a comment to D12102: Port Language KCM to Qt Quick.

Lookin' pretty sharp!

Sat, Apr 21, 2:55 PM · Kirigami, Plasma
ngraham added a task to D7929: [WIP] Add new Column View option to KDirOperator: T8552: Polish Open/Save dialogs.
Sat, Apr 21, 2:40 PM · Frameworks
ngraham added a revision to T8552: Polish Open/Save dialogs: D7929: [WIP] Add new Column View option to KDirOperator.
Sat, Apr 21, 2:40 PM · VDG
ngraham updated the task description for T8552: Polish Open/Save dialogs.
Sat, Apr 21, 2:40 PM · VDG
ngraham added a comment to D12102: Port Language KCM to Qt Quick.
In D12102#251008, @hein wrote:

Yeah, I think duplicating the button text is goofy. I'm OK with the first sentence.

Otherwise, personally I would like the list to be like this:

(a) Have a drag handle and be drag-reorderable (missing in Kirigami
(b) On hover, show icon-based "Move to top" (using the go-top icon) and remove actions

That'd address @rkflx "make changing the default super easy" thing.

Sat, Apr 21, 2:36 PM · Kirigami, Plasma
ngraham added a comment to D7929: [WIP] Add new Column View option to KDirOperator.

We're doing a UI and usability overhaul of the Open & Save dialogs in T8552: Polish Open/Save dialogs, and I think perhaps we should revisit this. I'm very strongly in favor of adding column-based navigation to both KDirOperator and also Dolphin (though I understand that's much more difficult). However I don't think it's the end of the world if we can only add it to the open/save dialogs for now, since navigation is the primary use case for these dialogs. On MacOS, column view is practically the only mode I use for navigation, since it's so much faster than the others.

Sat, Apr 21, 2:33 PM · Frameworks
ngraham added a comment to D12102: Port Language KCM to Qt Quick.

Pick your default language by moving topmost. To add more languages, click on the right.

Sat, Apr 21, 2:30 PM · Kirigami, Plasma
ngraham added a comment to D12327: Show Detailed Tree View by default.

In fact, if we integrated the Up button into the KURLNavigator widget, it would solve some issues automatically (e.g. lack of up button in Gwenview). I could see some people complaining about it though, because then the navigation buttons would be in two different vertical planes (since the URL navigator is always below the toolbar). Maybe we could live with that though?

One plane for history-related navigation (back, forward), and one plane for navigation related to directory hierarchy (up, breadcrumb). Seems even more logical to me than grouping back/forward/up.


Let's wait until @elvisangelaccio has had time to comment again on the matter.

Sat, Apr 21, 2:16 PM · Frameworks
ngraham added a comment to D12389: Filepicker reads thumbs preview from Dolphin settings.

Stupid question, what happens if dolphin is not installed?

Sat, Apr 21, 1:54 PM · Frameworks
ngraham added a comment to D12327: Show Detailed Tree View by default.
  • Bandwagon: Windows and macOS's default details style views allow expansion by default too

I'm all for going tree-style, but honestly I don't see expansion in Windows? Are we testing different versions? (In case they are fictitious, that would not help your point.)

Sat, Apr 21, 1:51 PM · Frameworks
ngraham accepted D12385: Thumbnail smooth scaling in filepicker.

Definitely a visual improvement! Let's wait for a few more opinions regarding whether this is the right approach technically.

Sat, Apr 21, 1:34 PM · Frameworks
ngraham added a comment to D12327: Show Detailed Tree View by default.

Or, a compromise: If we wanted to go all the way and have Dolphin-style options (Icons View, Compact view, Detailed view), I could support that for consistency's sake as long as we have three buttons like Dolphin does, rather than a combobox or a drop-down menu. That would still run into the technical challenges that I outlined above though.

Sat, Apr 21, 1:29 PM · Frameworks
ngraham added a comment to D12327: Show Detailed Tree View by default.

Reasons to change the default to Detailed View or Detailed Tree View:

  • Ergonomics: the current default requires side-scrolling for long lists, which is almost never ideal
  • Usefulness: by showing the details columns by default (which also makes sorting more discoverable for this view), we're helping users find their content by more than just the filename
  • Bandwagon: Windows and GNOME do it (macOS probably would if they didn't have column view)
Sat, Apr 21, 1:23 PM · Frameworks
ngraham added a comment to D12306: Filepicker dialog proper grid icon layout.

Ooh, centering when there's only one column is a nice touch.

Sat, Apr 21, 4:34 AM · Frameworks
ngraham added a revision to T8552: Polish Open/Save dialogs: D12389: Filepicker reads thumbs preview from Dolphin settings.
Sat, Apr 21, 4:28 AM · VDG
ngraham added a task to D12389: Filepicker reads thumbs preview from Dolphin settings: T8552: Polish Open/Save dialogs.
Sat, Apr 21, 4:28 AM · Frameworks
ngraham updated the summary of D12392: Fix the "Default" color scheme to match Breeze again.
Sat, Apr 21, 4:14 AM · Frameworks
ngraham updated the test plan for D12392: Fix the "Default" color scheme to match Breeze again.
Sat, Apr 21, 4:13 AM · Frameworks
ngraham requested review of D12392: Fix the "Default" color scheme to match Breeze again.
Sat, Apr 21, 4:13 AM · Frameworks

Fri, Apr 20

ngraham added a comment to D12385: Thumbnail smooth scaling in filepicker.

I too cannot reproduce the performance issue, even after nuking ~/.cache/thumbnails and having it regenerate the thumbnails. Can you, @cfeck?

Fri, Apr 20, 11:14 PM · Frameworks
ngraham accepted D12389: Filepicker reads thumbs preview from Dolphin settings.

Wow, a truly trivial fix! Since Dolphin is currently where the config UI for this lives, I think it makes sense to re-use that information here.

Fri, Apr 20, 11:05 PM · Frameworks
ngraham added a comment to D11155: handle zip files embedded within zip files.

Does this resolve https://bugs.kde.org/show_bug.cgi?id=73821?

Fri, Apr 20, 9:37 PM · Frameworks
ngraham added a comment to D12311: Align lock icon with bold message text; reduce overall size of dialog.

So right now, we have two strings of text:

  • The top bold string comes from the app and differs on a per-app basis
  • The bottom long boilerplate string is from us, and shown all the time
Fri, Apr 20, 9:17 PM · Plasma
ngraham added a comment to D12311: Align lock icon with bold message text; reduce overall size of dialog.

In general it's okay to display nerdy technical information hidden away like this--as long as it's actually useful information! That's the real question. If it's of no real value to anyone for any use case that we can imaging, we can probably safely remove it. Otherwise, it should probably stay in.

Fri, Apr 20, 5:55 PM · Plasma
ngraham updated the task description for T8552: Polish Open/Save dialogs.
Fri, Apr 20, 5:49 PM · VDG
ngraham added a comment to D12385: Thumbnail smooth scaling in filepicker.

Could we use the fast scaling while resizing, then change to the smooth scaling once the resize operation is done?

Fri, Apr 20, 5:48 PM · Frameworks
ngraham added a revision to T8552: Polish Open/Save dialogs: D12385: Thumbnail smooth scaling in filepicker.
Fri, Apr 20, 5:26 PM · VDG
ngraham added a task to D12385: Thumbnail smooth scaling in filepicker: T8552: Polish Open/Save dialogs.
Fri, Apr 20, 5:26 PM · Frameworks
ngraham updated the summary of D12385: Thumbnail smooth scaling in filepicker.
Fri, Apr 20, 5:26 PM · Frameworks
ngraham added a comment to D12130: Use the more user-friendly string "File type" in the save dialogs.

I might need some help with this. It seems that the apps whose save dialogs show a combobox in place of a filter list are creating a QDialog and setting the Mime types list with QDialog::setMimeTypeFilter(). I haven't yet managed to figure out how this call is intercepted and replaced with a KFileDialog, or how KFileDialog can detect that there's a combobox of MIME types instead of a filter widget.

In Gwenview, grep for "Save Image" (has prepopulated combobox) and "Open Image" (does not have combobox, but editable and prepopulated filter). The difference seems to be the missing selectMimeTypeFilter for the latter.

Note than in your comment you are referring to setMimeTypeFilter[s], which for Gwenview is called in both cases, thus not leading into a code path you are interested in.

Did not yet have the time (with all the other Diffs to comment on ;) to look into how this translates to KFileDialog, but does this help already?

Fri, Apr 20, 4:18 PM · Frameworks
ngraham added a comment to D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does.

Sorry, I don't really get what you mean. I'm not proposing going back to KDE3, Nate is proposing going back to the KDE3 design! (In KDE4 this was improved to what we have in KF5, FYI.) Also, I don't see where you get from that I'm proposing to follow any "law"? Not sure what you mean with "2 sets of navigation buttons" which are "together in one horizontal plane", either. If you are referring to Nate's mockup, I'm the wrong person to ask. Comparisons to Windows are moot, because there you have different design constraints due to the position of the breadcrumb bar. Lastly, I don't get the connection between your example and the title of the Diff.

@ngraham Do we need to take a decision right now, or are you willing to wait until some of the other stuff has cleared up?

Fri, Apr 20, 4:15 PM · Frameworks
ngraham added a comment to D12102: Port Language KCM to Qt Quick.

Perhaps I'm blind, but in the latest screenshot it looks like there's already a white background.

Fri, Apr 20, 3:05 PM · Kirigami, Plasma
ngraham added a comment to D12102: Port Language KCM to Qt Quick.

And if this is a Kirigami convergence thing, IMHO we should think about having Kirigami automatically add a frame and some side padding when on desktop platforms, where having a list span the entire horizontal width rarely looks good.

Fri, Apr 20, 2:32 PM · Kirigami, Plasma
ngraham added a comment to D12102: Port Language KCM to Qt Quick.

I'm not a huge fan of the fact that the list items take up the entire horizontal width and have no side borders. Makes things feel rather visually muddy, like things are too big and flowing into one another. Could we put that whole list inside a frame with a reasonable maximum width to give it some visual containment and structure, and have at least a bit of side padding between the edges of that frame and the edges of the KCM?

Fri, Apr 20, 2:30 PM · Kirigami, Plasma
ngraham added a comment to D12317: implement and enable sorting in the views.

I sticked to the current icon until we get a better one. An arrow alone is also not very meaningful

Fri, Apr 20, 1:40 PM · Elisa
ngraham added a comment to T8552: Polish Open/Save dialogs.

Make the toolbar editable (fixes https://bugs.kde.org/show_bug.cgi?id=137837)

It wouldn't be possible to show the same toolbar like it was configured in dolphin already, is it ?

Fri, Apr 20, 1:14 PM · VDG
ngraham added a comment to T8187: Single click vs double-click.

The GNOME Folks are considering adding a contextual action bar to Nautilus just like I proposed for Dolphin and Gwenview et al:

Fri, Apr 20, 4:31 AM · VDG
ngraham added a dependency for D12327: Show Detailed Tree View by default: D12326: In Short View, display icons on top and increase icon size.
Fri, Apr 20, 3:46 AM · Frameworks
ngraham added a dependent revision for D12326: In Short View, display icons on top and increase icon size: D12327: Show Detailed Tree View by default.
Fri, Apr 20, 3:46 AM · Frameworks