ngraham (Nathaniel Graham)
User

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2017, 7:18 PM (96 w, 4 d)
Availability
Available

Recent Activity

Yesterday

ngraham requested changes to D19077: Redesign the theme preview window.

With the default System Settings window size (and default font & size), the URLs now get cut off at the bottom nearly all the time. Also, having all the metadata in a stacked list of strings isn't as nice as I think it could be. We could save a lot of space by combining things, like this:

Wed, Feb 20, 10:11 PM · Plasma
ngraham added inline comments to D18915: Fix batchrename changing extension to lower case.
Wed, Feb 20, 9:45 PM · Frameworks
ngraham added inline comments to D19077: Redesign the theme preview window.
Wed, Feb 20, 9:44 PM · Plasma
ngraham requested changes to D19077: Redesign the theme preview window.

Neato, getting there...

Wed, Feb 20, 9:38 PM · Plasma
ngraham added a comment to D19185: [KRunner, SDDM theme, Logout screen, Login widget] Use the word "Sleep" instead of "Suspend".

Even if we do change it, krunner should still match for search queries "suspend" and "sleep"

Wed, Feb 20, 9:25 PM · Plasma
ngraham added a comment to D19153: [WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running.

Yeah, I think Take a new screenshot makes sense as the default option.

Wed, Feb 20, 8:26 PM · Spectacle
ngraham requested review of D19192: [Updates page] Improve selected/unselected explanation view.
Wed, Feb 20, 8:05 PM · Plasma
ngraham added a comment to D19077: Redesign the theme preview window.

Hmm, you might have to keep the hardcoded height, given that the QWidgets container expects the QML view to have a certain size.

Wed, Feb 20, 8:00 PM · Plasma
ngraham accepted D19183: Use logically correct icon for direction arrows.

Makes sense to me. Seems to make more sense when using an RTL layout too. Okular folks, are you good with this?

Wed, Feb 20, 7:02 PM · Okular
ngraham updated the test plan for D19190: Improve scroll wheel speed by basing it on label height, not icon height.
Wed, Feb 20, 5:37 PM · Dolphin
ngraham added inline comments to D19190: Improve scroll wheel speed by basing it on label height, not icon height.
Wed, Feb 20, 5:36 PM · Dolphin
ngraham updated the summary of D19190: Improve scroll wheel speed by basing it on label height, not icon height.
Wed, Feb 20, 5:31 PM · Dolphin
ngraham updated the diff for D19190: Improve scroll wheel speed by basing it on label height, not icon height.

Use font metrics

Wed, Feb 20, 5:29 PM · Dolphin
ngraham requested review of D19190: Improve scroll wheel speed by basing it on label height, not icon height.
Wed, Feb 20, 5:11 PM · Dolphin
ngraham added inline comments to D19014: [plasma-pa] Add command to switch all applications to the selected device.
Wed, Feb 20, 5:04 PM · Plasma
ngraham added a comment to D18716: Add an ActionTextField component.

Then again there's an argument to be made for consistency. I would be okay with using clickable icons instead of toolbuttons as long as we make sure to use a pointing hand cursor when hovered.

Wed, Feb 20, 4:52 PM · Kirigami
ngraham added a comment to D19153: [WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running.

However in our case we would call this only if configured by the user to do so and explicitly requested by the user by pressing the Print key. Also if spectacle isn't running and the Print key is pressed , currently Spectacle will open and steal the focus even if I'm typing in another application for example Konsole. Considering these two points I think it's reasonable to argue that this behavior would be acceptable.

Wed, Feb 20, 4:49 PM · Spectacle
ngraham committed R260:fe0dbadaecc5: Compile tests files with enabled exceptions, required for exiv2 0.27 (authored by tgurr).
Compile tests files with enabled exceptions, required for exiv2 0.27
Wed, Feb 20, 4:22 PM
ngraham closed D19169: Compile tests files with enabled exceptions, required for exiv2 0.27.
Wed, Feb 20, 4:22 PM · Gwenview
ngraham added a comment to D19169: Compile tests files with enabled exceptions, required for exiv2 0.27.

Oh no, you didn't do anything wrong at all. It's a Phabricator bug that your authorship information gets discarded when if you use git format-patch (Phab wants everyone to use arc; see https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist).

Wed, Feb 20, 4:20 PM · Gwenview
ngraham added a comment to D18716: Add an ActionTextField component.

Even though we use clickable icons rather than toolbuttons in the QWidgets version, I think we should use ToolButtons if the visual style isn't too bad. People complained about the lack of pressed and hover states when the SwipeListItem used clickable icons instead of toolbuttons.

Wed, Feb 20, 4:15 PM · Kirigami
ngraham added a comment to T10402: The Desktop Toolbox.

Not being a user of Activities myself, I have a hard time commenting on whether it's really necessary or not, but I suspect it is just a nice-to-have since the Desktop Toolbox only fulfills this function when it's been deliberately dragged out of the corner.

Wed, Feb 20, 4:09 PM · Plasma, VDG
ngraham updated the diff for D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend".

Add context

Wed, Feb 20, 4:05 PM · Documentation, Plasma
ngraham accepted D18986: [breeze-icons] Add video camera icons.

Now that's what I'm talkin' about!!! I love these!

Wed, Feb 20, 4:03 PM · Frameworks
ngraham updated the diff for D19185: [KRunner, SDDM theme, Logout screen, Login widget] Use the word "Sleep" instead of "Suspend".

Add context

Wed, Feb 20, 4:03 PM · Plasma
ngraham updated the diff for D19184: [Kicker, Kickoff & Dash] Use the word "Sleep" instead of "Suspend".

Add context

Wed, Feb 20, 3:54 PM · Plasma
ngraham moved T10500: Use the word "Sleep" instead of "Suspend" from To Do to Needs Review on the Plasma board.
Wed, Feb 20, 2:42 PM · Plasma, VDG
ngraham moved T10500: Use the word "Sleep" instead of "Suspend" from Backlog/Planned to Sent to dev on the VDG board.
Wed, Feb 20, 2:42 PM · Plasma, VDG
ngraham added a revision to T10500: Use the word "Sleep" instead of "Suspend": D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend".
Wed, Feb 20, 2:42 PM · Plasma, VDG
ngraham requested review of D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend".
Wed, Feb 20, 2:42 PM · Documentation, Plasma
ngraham added a revision to T10500: Use the word "Sleep" instead of "Suspend": D19185: [KRunner, SDDM theme, Logout screen, Login widget] Use the word "Sleep" instead of "Suspend".
Wed, Feb 20, 2:42 PM · Plasma, VDG
ngraham requested review of D19185: [KRunner, SDDM theme, Logout screen, Login widget] Use the word "Sleep" instead of "Suspend".
Wed, Feb 20, 2:42 PM · Plasma
ngraham added a revision to T10500: Use the word "Sleep" instead of "Suspend": D19184: [Kicker, Kickoff & Dash] Use the word "Sleep" instead of "Suspend".
Wed, Feb 20, 2:42 PM · Plasma, VDG
ngraham requested review of D19184: [Kicker, Kickoff & Dash] Use the word "Sleep" instead of "Suspend".
Wed, Feb 20, 2:42 PM · Plasma
ngraham updated the task description for T10500: Use the word "Sleep" instead of "Suspend".
Wed, Feb 20, 6:09 AM · Plasma, VDG
ngraham updated the summary of D19023: [Kickoff] Don't respond to window resizing/tiling shortcuts.
Wed, Feb 20, 6:00 AM · Plasma
ngraham updated the task description for T10500: Use the word "Sleep" instead of "Suspend".
Wed, Feb 20, 4:32 AM · Plasma, VDG
ngraham accepted D19169: Compile tests files with enabled exceptions, required for exiv2 0.27.

Thanks. Can you please provide your real name and email address so I can land your patch with correct authorship information?

Wed, Feb 20, 3:56 AM · Gwenview
ngraham added a comment to T10402: The Desktop Toolbox.

Currently the only place that we use long press (to my knowledge) is to enter the Widget's own private edit mode. I'm not real thrilled about that TBH, but I could accept it as a secondary, touch-centric UI once we have a better desktop-specific UI for it (See T10190: (Re)define modes when editing panels and widgets)

Wed, Feb 20, 3:55 AM · Plasma, VDG
ngraham added a comment to D19148: Make shadow sizes linear.

...Looks better on my non-cheap display, too. :)

Wed, Feb 20, 3:16 AM · Plasma
ngraham added a comment to D15742: Add close tab and create new tab on middle click event.

Nice job, @shubham. Wanna do the same thing for Okular next? https://bugs.kde.org/show_bug.cgi?id=361756. Probably doesn't need an option there.

Wed, Feb 20, 3:16 AM · Konsole
ngraham added a comment to D18975: [PotD] Port mostly to QQC2.

Friendly ping!

Wed, Feb 20, 12:20 AM · Plasma
ngraham added a comment to T9041: New "Home" tab for Kickoff.

Thanks for that very valuable information, @anemeth. It's great to hear from someone in the trenches, so to speak. Your reasoning is exactly why I wanted to put the power- and user-related buttons front and center. Sometimes we forget just how confusing it can be for normal users when something commonly-used isn't front-and-center, and how unlabeled icons-only ToolButtons can cause problems even when they use a nearly universal icon.

Wed, Feb 20, 12:19 AM · Plasma, VDG
ngraham accepted D19148: Make shadow sizes linear.

This is much better. I think this is a visual improvement. Please make sure @zzag is good with the code before landing, and also let's maybe wait for a few more VDG opinions. :)

Wed, Feb 20, 12:11 AM · Plasma
ngraham added a comment to D19163: Make it possible to show all spaces in the document.

I have wanted this for so long!

Wed, Feb 20, 12:03 AM · Frameworks, Kate

Tue, Feb 19

ngraham added a comment to T10497: Clean up the default color scheme selection.

I don't personally use a dark theme, so I'll leave this to you guys. :) But I think editing the colors to be more modern and visually appealing makes sense.

Tue, Feb 19, 11:49 PM · VDG
ngraham added a comment to T10495: wallpaper cache.

I don't have a very strong opinion but I kind of like the idea of each one being its own plugin. That way you could see and choose a POTD provider in one step rather than two (1. choose POTD plugin -> 2. then go through list of POTD options)

Tue, Feb 19, 11:45 PM · Plasma
ngraham updated subscribers of D19173: [InlineMessage] Tint icon and text color.

Also as @mart pointed out in D19044, it might make sense to do all the styling in the qqc2 desktop style theme for this control, rather than here in Kirigami itself.

Tue, Feb 19, 11:43 PM · Kirigami
ngraham requested changes to D19173: [InlineMessage] Tint icon and text color.

I'm not in favor of this at all in its current form. Any tinting of the text with the background color under it reduces legibility. I'm as in favor of aesthetically appealing user interfaces as anyone, but not at the expense of usability.

Tue, Feb 19, 11:39 PM · Kirigami
ngraham added a comment to D16648: Open externally called files/directories in new tabs.

@feverfew, are you still around to work on these issues?

Tue, Feb 19, 11:36 PM · Dolphin
ngraham added a comment to T10497: Clean up the default color scheme selection.

Maybe we should just update the Breeze Dark color scheme instead? People who want something dark want something dark, if you know what I mean.

Tue, Feb 19, 6:22 PM · VDG
ngraham accepted D15742: Add close tab and create new tab on middle click event.

@hindenburg?

Tue, Feb 19, 5:58 PM · Konsole
ngraham updated subscribers of D19153: [WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running.

Nice! So now the only problem I can still find is that the "Return focus to Spectacle" option doesn't work, just like you said. I don't know enough about how Spectacle interacts with the window manager to help with that, but maybe @zzag or @davidedmundson can offer some insight here?

Tue, Feb 19, 5:52 PM · Spectacle
ngraham updated the summary of D19153: [WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running.
Tue, Feb 19, 5:52 PM · Spectacle
ngraham added a revision to T9855: What should happen when you hit PrScr when Spectacle is already running?: D19153: [WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running.
Tue, Feb 19, 5:51 PM · VDG, Spectacle
ngraham added a task to D19153: [WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running: T9855: What should happen when you hit PrScr when Spectacle is already running?.
Tue, Feb 19, 5:51 PM · Spectacle
ngraham updated subscribers of D19150: Dolphin single instance tabbed navigation.

Hmm, we already had a patch to do this: D16648: Open externally called files/directories in new tabs.

Tue, Feb 19, 5:13 PM · Dolphin
ngraham added a comment to D19134: Multiply radius by 0.5 in calculateBlurStdDev().

Sorry, we had discussed this with @zzag in the VDG room and I (perhaps erroneously?) left with the impression that this was set at its previous value to preserve a certain look-and-feel, and was therefore something we could change since we were adjusting that look-and-feel elsewhere. I did test it and didn't notice any visual regressions.

Tue, Feb 19, 4:44 PM · Plasma
ngraham created T10500: Use the word "Sleep" instead of "Suspend".
Tue, Feb 19, 4:37 PM · Plasma, VDG
ngraham added a comment to D19153: [WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running.

OK cool, let's give that a try. I think it could work nicely.

Tue, Feb 19, 4:08 PM · Spectacle
ngraham added a comment to D19153: [WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running.

So like this?

Tue, Feb 19, 4:05 PM · Spectacle
ngraham committed R260:5ae28dadba06: Allow Gwenview to be able to open .kra (Krita) files (authored by ngraham).
Allow Gwenview to be able to open .kra (Krita) files
Tue, Feb 19, 3:40 PM
ngraham closed D19121: Allow Gwenview to be able to open .kra (Krita) files.
Tue, Feb 19, 3:40 PM · Gwenview
ngraham accepted D19154: [Kickoff] remove hint state.

Works for me. Probably a candidate for the Plasma/5.15 branch. @hein?

Tue, Feb 19, 3:35 PM · Plasma
ngraham added a comment to D19121: Allow Gwenview to be able to open .kra (Krita) files.

Sweet, will add the dep in another patch.

Tue, Feb 19, 3:33 PM · Gwenview
ngraham added inline comments to D19162: Add KAboutData.
Tue, Feb 19, 3:33 PM · Plasma
ngraham assigned T10497: Clean up the default color scheme selection to filipf.

+1; Colors is the only KCM where we ship random stuff like this.

Tue, Feb 19, 3:06 PM · VDG
ngraham added a comment to D19148: Make shadow sizes linear.

I kind of agree. I like the new size for Medium, and I think the default should maybe be a bit smaller (halfway between the current medium and the current large) but I also don't see the great value in adding more sizes. I think we can probably accomplish the visual goals we have in mind by tweaking the existing sizes to be less power-of-two-ey.

Tue, Feb 19, 1:35 PM · Plasma
ngraham assigned T8400: Make buttons more consistent to GB_2.
Tue, Feb 19, 1:32 PM · VDG, Plasma
ngraham moved T8400: Make buttons more consistent from Backlog/Planned to Sent to dev on the VDG board.
Tue, Feb 19, 1:32 PM · VDG, Plasma
ngraham added reviewers for D19154: [Kickoff] remove hint state: Plasma, hein.
Tue, Feb 19, 1:28 PM · Plasma
ngraham closed T7326: Virtual Desktops, a subtask of T9887: Plasma 5.15 release, as Resolved.
Tue, Feb 19, 1:13 PM · Plasma
ngraham closed T7326: Virtual Desktops as Resolved.
Tue, Feb 19, 1:13 PM · Plasma: KCM Redesign
ngraham added a parent task for T7326: Virtual Desktops: T9887: Plasma 5.15 release.
Tue, Feb 19, 1:12 PM · Plasma: KCM Redesign
ngraham added a subtask for T9887: Plasma 5.15 release: T7326: Virtual Desktops.
Tue, Feb 19, 1:12 PM · Plasma
ngraham added a subtask for T10488: Plasma 5.16: T7243: Colors.
Tue, Feb 19, 1:11 PM · Plasma
ngraham added a parent task for T7243: Colors: T10488: Plasma 5.16.
Tue, Feb 19, 1:11 PM · Plasma: KCM Redesign
ngraham added a parent task for T7255: Audio Volume: T10488: Plasma 5.16.
Tue, Feb 19, 1:11 PM · Plasma: KCM Redesign
ngraham added a subtask for T10488: Plasma 5.16: T7255: Audio Volume.
Tue, Feb 19, 1:11 PM · Plasma
ngraham renamed T7255: Audio Volume from Audio Volume (kinda done) to Audio Volume.
Tue, Feb 19, 1:11 PM · Plasma: KCM Redesign
ngraham closed T7255: Audio Volume as Resolved.

Calling this done as the current version uses modern APIs and more-or-less matches the mockups.

Tue, Feb 19, 1:10 PM · Plasma: KCM Redesign
ngraham added a revision to T7255: Audio Volume: D15304: [KCM] Port to QQC2.
Tue, Feb 19, 1:08 PM · Plasma: KCM Redesign
ngraham added a task to D15304: [KCM] Port to QQC2: T7255: Audio Volume.
Tue, Feb 19, 1:08 PM · Plasma
ngraham reassigned T7270: Boot splash (kinda done) from davidedmundson to GB_2.

@GB_2 is porting this to use the new visual style.

Tue, Feb 19, 1:01 PM · Plasma: KCM Redesign
ngraham added a task to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule: T7325: Window Decorations.
Tue, Feb 19, 12:59 PM · KWin
ngraham added a revision to T7325: Window Decorations: D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.
Tue, Feb 19, 12:59 PM · Plasma: KCM Redesign
ngraham closed T7325: Window Decorations, a subtask of T10488: Plasma 5.16, as Resolved.
Tue, Feb 19, 12:59 PM · Plasma
ngraham closed T7325: Window Decorations as Resolved.
Tue, Feb 19, 12:59 PM · Plasma: KCM Redesign
ngraham added a subtask for T10488: Plasma 5.16: T7325: Window Decorations.
Tue, Feb 19, 12:57 PM · Plasma
ngraham added a parent task for T7325: Window Decorations: T10488: Plasma 5.16.
Tue, Feb 19, 12:57 PM · Plasma: KCM Redesign
ngraham assigned T9012: Thunderbolt 3 Security Plasma Integration to dvratil.
Tue, Feb 19, 12:40 PM · Plasma
ngraham assigned T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible to GB_2.
Tue, Feb 19, 12:39 PM · Plasma, VDG
ngraham reassigned T10325: 5.16 Login screen improvements from ngraham to rooty.
Tue, Feb 19, 12:38 PM · Plasma, VDG
ngraham added a comment to D19153: [WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running.

Are the Summary section and title accurate?

Tue, Feb 19, 12:34 PM · Spectacle
ngraham triaged T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible as Normal priority.
Tue, Feb 19, 12:34 PM · Plasma, VDG
ngraham updated the task description for T10325: 5.16 Login screen improvements.
Tue, Feb 19, 12:20 PM · Plasma, VDG
ngraham renamed T10325: 5.16 Login screen improvements from 5.16 Login screen redesign to 5.16 Login screen improvements.
Tue, Feb 19, 12:19 PM · Plasma, VDG
ngraham updated subscribers of D19011: Thunderbolt KCM and KDED module.

Thanks for the feedback, I'll look into it asap. In the meantime, could I ask the VDG to create a Breeze icon for Thunderbolt? @abetts, maybe?

Tue, Feb 19, 11:16 AM · Plasma
ngraham added a reviewer for D19152: Resurrect show tooltips option: broulik.

+1, I find these really annoying and want to turn them off.

Tue, Feb 19, 11:13 AM · KWin

Mon, Feb 18

ngraham accepted D19134: Multiply radius by 0.5 in calculateBlurStdDev().

Makes sense to do this while we're tweaking the appearance of the shadows for 5.16 anyway.

Mon, Feb 18, 10:35 PM · Plasma