ndavis (Noah Davis)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Sep 6 2017, 10:33 AM (129 w, 2 d)
Availability
Available

Recent Activity

Today

ndavis added a comment to D24706: [RFC] Change button style.
In D24706#619482, @mart wrote:

hmm, buttons look quite.. flat now? there was a lot of discussion on what should be flat and what not. while i think having things a bit flatter doesn't actually hurt, could this be considered an usability issue?

Fri, Feb 28, 3:04 PM · Breeze, VDG, Plasma
ndavis committed R266:8fa51b3e5665: Fix inconsistencies and duplicates in network-wired/wireless icons (authored by ndavis).
Fix inconsistencies and duplicates in network-wired/wireless icons
Fri, Feb 28, 2:49 PM

Yesterday

ndavis updated subscribers of D27669: WIP: [kstyle] Tools area.

Adding Hugo as a subscriber since he might have some advice.

Thu, Feb 27, 11:38 PM · Plasma

Wed, Feb 26

ndavis updated the test plan for D24706: [RFC] Change button style.
Wed, Feb 26, 6:44 PM · Breeze, VDG, Plasma
ndavis updated the test plan for D24706: [RFC] Change button style.
Wed, Feb 26, 6:35 PM · Breeze, VDG, Plasma
ndavis updated the diff for D24706: [RFC] Change button style.

Update

Wed, Feb 26, 6:29 PM · Breeze, VDG, Plasma

Tue, Feb 25

ndavis accepted D27663: Show tooltip with full URL for URL button with overridden text.
Tue, Feb 25, 11:26 PM · Kirigami
ndavis accepted D27664: Improve layout and appearance of app details view.
Tue, Feb 25, 10:02 PM · Plasma
ndavis added a comment to T12743: Tweak Breeze and Breeze Dark color schemes.

Just to repost and add a bit from the darker breeze dark diff:

Tue, Feb 25, 6:43 PM · VDG
ndavis added a comment to D27540: KCModule: Indicate when a setting has been changed from the default or previous value.

I can see the utility in indicating non-default values in some cases, particularly with software that has a lot of necessary complexity in the settings or where non-default values can cause problems (see SVG Cleaner GUI for an example of both). However, I don't think it's necessary for most software to indicate non-default values or even dirty values.

Tue, Feb 25, 2:43 PM · Frameworks
ndavis added a comment to T12744: Consider increasing the default fixed width font size by 1 (9 -> 10).

+1

Tue, Feb 25, 5:04 AM · Konsole, Kate, VDG

Mon, Feb 24

ndavis accepted D27530: Use appropriate icon for unconfigured applets' "Configure..." buttons.
Mon, Feb 24, 5:09 PM · Plasma
ndavis accepted D27532: [applets/notes] Rename to "Sticky Note".
Mon, Feb 24, 4:56 PM · Plasma
ndavis added a comment to D27617: [breeze-icons] Add telegram-desktop tray icons.

Thanks for the patch!

But...it's blue: :)

Mon, Feb 24, 2:40 PM · Frameworks
ndavis added a comment to T11661: Replace framed views with single-pixel separator lines.

What I'm saying is that doing something like what VS Code does could work for making views next to views look good, like a sidebar next to a list view.

Mon, Feb 24, 2:34 PM · Goal: Consistency, Breeze, VDG
ndavis added a comment to T11661: Replace framed views with single-pixel separator lines.

One way we could get views next to other views to look right is to use the alternate view background color for sidebars

Mon, Feb 24, 2:25 PM · Goal: Consistency, Breeze, VDG
ndavis added a parent task for T11661: Replace framed views with single-pixel separator lines: T10891: Breeze theme evolution.
Mon, Feb 24, 2:23 PM · Goal: Consistency, Breeze, VDG
ndavis added a subtask for T10891: Breeze theme evolution: T11661: Replace framed views with single-pixel separator lines.
Mon, Feb 24, 2:23 PM · Plasma 6, Plasma, VDG, Breeze
ndavis added a comment to D27557: Auto-generate 24px monochrome icons.

Should we just revert for now?

Mon, Feb 24, 11:33 AM · Frameworks
ndavis added a comment to D27557: Auto-generate 24px monochrome icons.

looks like it's not posix sh, but bash code

Mon, Feb 24, 10:38 AM · Frameworks
ndavis added a comment to D24009: RFC: Make Breeze Dark darker.

I think these 4 colors could be used for backgrounds in Breeze Dark:

Mon, Feb 24, 2:20 AM · Plasma
ndavis added a comment to D24009: RFC: Make Breeze Dark darker.

The problem with having dark separators is that they disappear if you set the background color to black. That isn't an unreasonable thing for a user to want to do. It's also arguable that it isn't unreasonable for a user to want dark separators, so they could be an option, but last time I tried that for colorschemes, it didn't get a lot of support (D25814). It could be an option in the Breeze widget style settings, but I really don't want to start stuffing options in obscure places...

Mon, Feb 24, 2:14 AM · Plasma

Sun, Feb 23

ndavis committed R266:67f60a7322ac: Also auto-generate 24@2x compatibility symlinks (authored by ngraham).
Also auto-generate 24@2x compatibility symlinks
Sun, Feb 23, 6:55 PM
ndavis closed D27605: Also auto-generate 24@2x compatibility symlinks.
Sun, Feb 23, 6:55 PM · Frameworks
ndavis accepted D27605: Also auto-generate 24@2x compatibility symlinks.

LGTM

Sun, Feb 23, 5:33 PM · Frameworks

Sat, Feb 22

ndavis accepted D27557: Auto-generate 24px monochrome icons.

After you rebase this, I'd say this patch is ready to go.

Sat, Feb 22, 6:29 PM · Frameworks
ndavis added a comment to D27557: Auto-generate 24px monochrome icons.

I've added the icons that were only in actions/24 to actions/22.

Sat, Feb 22, 6:27 PM · Frameworks
ndavis committed R266:b42f44143503: Add icons that were only in actions/24 to actions/22 (authored by ndavis).
Add icons that were only in actions/24 to actions/22
Sat, Feb 22, 6:26 PM
ndavis committed R266:285c99055831: Set document scale to 1.0 for all actions/22 icons (authored by ndavis).
Set document scale to 1.0 for all actions/22 icons
Sat, Feb 22, 5:17 PM
ndavis added a comment to D27557: Auto-generate 24px monochrome icons.

I've fixed the 22px files that had height/width and viewbox set.

Sat, Feb 22, 5:15 PM · Frameworks
ndavis added a comment to D27557: Auto-generate 24px monochrome icons.

The following 24px icon symlinks are linked to 22px icons. Maybe it's material for another patch, but I figured I'd bring it up.

Sat, Feb 22, 10:02 AM · Frameworks
ndavis added a comment to D27557: Auto-generate 24px monochrome icons.

draw-highlight got a bit mangled:

Sat, Feb 22, 9:50 AM · Frameworks
ndavis added a comment to D27557: Auto-generate 24px monochrome icons.

Out of the ones listed above, these are symlinks:

Sat, Feb 22, 9:00 AM · Frameworks
ndavis added a comment to D27557: Auto-generate 24px monochrome icons.

Looking pretty good so far. The only icons that have 24px versions but no 22px versions are the following from the actions category:

24/align-horizontal-node.svg
24/align-vertical-node.svg
24/audio-volume-high.svg
24/audio-volume-low.svg
24/audio-volume-medium.svg
24/audio-volume-muted.svg
24/distribute-horizontal-node.svg
24/distribute-vertical-node.svg
24/font.svg
24/gnumeric-autofilter-delete.svg
24/gnumeric-autosum.svg
24/gnumeric-bucket.svg
24/gnumeric-cells-merge.svg
24/gnumeric-column-size.svg
24/gnumeric-component-insert-shaped.svg
24/gnumeric-data-slicer.svg
24/gnumeric-font.svg
24/gnumeric-format-border-all.svg
24/gnumeric-format-accounting.svg
24/gnumeric-format-border-double-bottom.svg
24/gnumeric-format-border-none.svg
24/gnumeric-format-border-outside.svg
24/gnumeric-format-border-thick-bottom.svg
24/gnumeric-format-border-thick-outside.svg
24/gnumeric-format-border-top-n-bottom.svg
24/gnumeric-format-border-top-n-thick-bottom.svg
24/gnumeric-format-border-top-n-double-bottom.svg
24/gnumeric-format-percentage.svg
24/gnumeric-format-precision-decrease.svg
24/gnumeric-format-precision-increase.svg
24/gnumeric-format-thousand-separator.svg
24/gnumeric-formulaguru.svg
24/gnumeric-link-external.svg
24/gnumeric-link-internal.svg
24/gnumeric-link-url.svg
24/gnumeric-object-arrow.svg
24/gnumeric-object-button.svg
24/gnumeric-object-checkbox.svg
24/gnumeric-object-combo.svg
24/gnumeric-object-ellipse.svg
24/gnumeric-object-label.svg
24/gnumeric-object-line.svg
24/gnumeric-object-list.svg
24/gnumeric-object-rectangle.svg
24/gnumeric-object-scrollbar.svg
24/gnumeric-object-spinbutton.svg
24/gnumeric-pagesetup-hf-cell.svg
24/gnumeric-protection-no.svg
24/gnumeric-pagesetup-hf-time.svg
24/gnumeric-protection-yes.svg
24/gnumeric-row-size.svg
24/gtk-tab-duplicate.svg
24/snap-nodes-cusp.svg
24/snap-nodes-midpoint.svg
24/snap-nodes-path.svg
24/snap-nodes-smooth.svg
24/transform-scale-horizontal.svg
24/transform-scale-vertical.svg
24/y-zoom-in.svg
24/zoom-in-x.svg
24/zoom-out-x.svg
24/zoom-out-y.svg
24/gtk-tab-new.svg
24/media-mout.svg
Sat, Feb 22, 8:57 AM · Frameworks

Fri, Feb 21

ndavis accepted D27527: Add new `smiley-add` icons.
Fri, Feb 21, 1:41 PM · Frameworks
ndavis added a comment to D27508: Remove unnecessary monochrome app icons.

T10413

Fri, Feb 21, 7:02 AM · Frameworks

Thu, Feb 20

ndavis added a comment to D27508: Remove unnecessary monochrome app icons.

Removing the monochrome system-help icon is what's needed to fix 417879, though. If we can't do that, then we can't fix the bug.

Thu, Feb 20, 10:55 PM · Frameworks
ndavis added a reviewer for D27522: Fix date-label size in vertical layout: VDG.
Thu, Feb 20, 3:46 PM · Plasma
ndavis added a comment to D27522: Fix date-label size in vertical layout.

Does this work well with vertical panels?

Thu, Feb 20, 3:45 PM · Plasma
ndavis added a comment to D27508: Remove unnecessary monochrome app icons.

I don't know what hotspot is used for, but the other ones are probably used by 3rd party apps. The virt-manager and system-help icons are definitely used by 3rd party apps in places where monochrome icons should be.

Thu, Feb 20, 8:35 AM · Frameworks

Mon, Feb 17

ndavis committed R266:d0354de47817: Replace <use/> with <path/> in muondiscover.svg (authored by ndavis).
Replace <use/> with <path/> in muondiscover.svg
Mon, Feb 17, 12:08 AM

Sun, Feb 16

ndavis added a comment to D27445: Move tasks from 3px to 2px.

This change is purely visual and I don't think that usability is affected. I personally find the 2px version prettier and more consistent with T11124

Sun, Feb 16, 11:04 PM · Frameworks
ndavis added a comment to D27445: Move tasks from 3px to 2px.

I don't think it's really worth it to do this patch for the same reasons as Nate.

Sun, Feb 16, 11:02 PM · Frameworks
ndavis added a comment to D27438: Increase System Tray Plasmoid spacing value slightly.

Please check how this looks with a vertical panel.

Sun, Feb 16, 6:44 PM · Plasma
ndavis added a comment to D27438: Increase System Tray Plasmoid spacing value slightly.

Which one would people prefer?
Units.smallSpacing:

Units.smallSpacing / 2:

Sun, Feb 16, 6:43 PM · Plasma
ndavis added a comment to D19947: systray: show a small animation on the icons when activated.
Sun, Feb 16, 9:25 AM · Plasma

Sat, Feb 15

ndavis requested changes to D27223: add kirigami-gallery icon.

You've got a duplicate copy of the icon in there. The bottom shadow should also be changed to be dark gray, like a darker version of the normal background color rather than a dark blue.

Sat, Feb 15, 6:00 PM · Frameworks
ndavis requested changes to D27224: add Kongress icon.

The pixel alignment for all parts of the inner symbol is off. The style of the inner symbol is a bit too rounded for the breeze style as well. For instance, the podium should have sharper corners in order to look more like other breeze icons. I know it's not really easy to tell what can be rounded and what can't. That's something we need to nail down in the HIG. In general, use roundness where appropriate for a given shape, not as a general style. Objects that typically have sharp corners should generally be represented with sharp corners.

Sat, Feb 15, 5:36 PM · Frameworks

Fri, Feb 14

ndavis accepted D27321: Add status icons: data-error, data-warning, data-information.
Fri, Feb 14, 7:22 AM · Frameworks
ndavis accepted D27272: Add status icons: data-error, data-warning, data-information.

Personally, I think emblems are fine, but I'm not going to hold up the KDevelop patch just because of that. They already existed in Papirus, the most popular 3rd party theme.

Fri, Feb 14, 7:21 AM · Frameworks
ndavis accepted D27390: [GTK3] Fix menubar colours.
Fri, Feb 14, 7:05 AM · Plasma

Thu, Feb 13

ndavis added a comment to D27246: add buho icon.

What is buho?

Thu, Feb 13, 1:33 PM · Frameworks

Wed, Feb 12

ndavis added a comment to D27218: Add icon for org.kde.Ikona.

please update the test plan before landing though

Wed, Feb 12, 11:59 PM · Frameworks
ndavis accepted D27218: Add icon for org.kde.Ikona.
Wed, Feb 12, 11:58 PM · Frameworks
ndavis requested changes to D27246: add buho icon.

the shadow on the folded corners needs to be changed. diagonal shadows only go down and to the right

Wed, Feb 12, 9:22 PM · Frameworks
ndavis accepted D27354: Remove hardcoded colors.
Wed, Feb 12, 9:21 PM · Frameworks
ndavis added a comment to D27318: Swap "Open in New Window" and "Open in New Tab" in context menus.

I'm not against this, but I wonder if it might make sense to conditionally swap the items only when the "open folders in tabs" is active? Or would that be more confusing?

Wed, Feb 12, 3:48 AM · Dolphin

Tue, Feb 11

ndavis committed R266:6063eb838d9b: add vvave icon (authored by mbruchert).
add vvave icon
Tue, Feb 11, 12:01 PM
ndavis closed D27215: add vvave icon.
Tue, Feb 11, 12:01 PM · Frameworks
ndavis closed D27214: add puremaps icon.
Tue, Feb 11, 11:58 AM · Frameworks
ndavis committed R266:c5835b98d666: add puremaps icon (authored by mbruchert).
add puremaps icon
Tue, Feb 11, 11:58 AM
ndavis accepted D27214: add puremaps icon.
Tue, Feb 11, 11:56 AM · Frameworks
ndavis accepted D25123: New yakuake logo/icon.
Tue, Feb 11, 11:53 AM · Yakuake, Frameworks
ndavis committed R266:61247fff3c48: Unify the look of all icons containing 🚫 (no sign) (authored by mthw).
Unify the look of all icons containing 🚫 (no sign)
Tue, Feb 11, 11:50 AM
ndavis closed D27247: Unify the look of all icons containing 🚫 (no sign).
Tue, Feb 11, 11:50 AM · Frameworks
ndavis accepted D27318: Swap "Open in New Window" and "Open in New Tab" in context menus.

+1

Tue, Feb 11, 11:48 AM · Dolphin
ndavis added a comment to D27247: Unify the look of all icons containing 🚫 (no sign).

You need to set your full name as your git user name. Otherwise, the system won't let me land it.

Tue, Feb 11, 7:47 AM · Frameworks

Mon, Feb 10

ndavis added a comment to D27303: [applets/taskmanager] Add a bit more padding around album/artist info in tooltip.

I agree with @filipf

Mon, Feb 10, 10:15 PM · Plasma
ndavis added a comment to D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground.

I think rather than adjusting hardcoded opacity in the SVGs, we need to make configurable plasmashell opacity a reality. Then, if we want to do an effect like what Nate described, we could have a way to automatically adjust the global plasmashell opacity.

Mon, Feb 10, 9:27 PM · VDG, Plasma, Frameworks
ndavis accepted D27301: [applets/taskmanager] Make launcher item tooltips look identical to panel widget tooltips.
Mon, Feb 10, 8:03 PM · Plasma
ndavis accepted D27247: Unify the look of all icons containing 🚫 (no sign).
Mon, Feb 10, 8:00 PM · Frameworks
ndavis added inline comments to D27299: Vertically center tooltip icon/image.
Mon, Feb 10, 6:01 PM · Frameworks
ndavis accepted D27299: Vertically center tooltip icon/image.
Mon, Feb 10, 6:00 PM · Frameworks
ndavis added a comment to D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground.

Using Background for panels would break the visual integration with dialogs, so I would avoid doing that.

Regarding panel popups / dialogs; I'm already working on the toparea patch - https://phabricator.kde.org/D27189 - but I was thinking, the problem with using Background is the controls on top of it e.g. kickoff search. Since the transparency makes the background color not as gray, the only problem is when things are opaque (I remember we talked about this in the VDG chat). Now, *there is* a version of Breeze opaque in the breeze/opaque/ directory which is used when compositing is disabled. For that one, I did leave ColorScheme-Background, so the problem is not there when the actual opaque version is used. I think that people who want things to be 100% opaque will install a theme rather than manually editing the svg, so they would not have that problem as well. That isn't to say that I won't work on the top area, just that I would not make the this patch dependent on it.

I also tried to tweak the intensity value to make the normal ColorScheme-Background fine, but I did not have any success. It seems like it's not a color which manages to work in this usecase, while ColorScheme-ViewBackground is okay.

Mon, Feb 10, 4:57 PM · VDG, Plasma, Frameworks
ndavis accepted D27215: add vvave icon.
Mon, Feb 10, 3:52 PM · Frameworks

Sun, Feb 9

ndavis accepted D27267: Restore former position of "Create New" menu item in viewport context menu.
Sun, Feb 9, 4:18 PM · Dolphin
ndavis accepted D27262: Reduce blank space inside tooltip's header.
Sun, Feb 9, 2:39 PM · Plasma
ndavis accepted D27260: [applets/systemtray] Set pin button's size correctly.
Sun, Feb 9, 9:10 AM · Plasma
ndavis requested changes to D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground.

Still uses ViewBackground on panels. For panel popups, you wanted to use a header area like the systray mockups, right? If so, the dialog SVG could use ViewBackground and you should mark this patch as dependent on the toparea patch.

Sun, Feb 9, 9:00 AM · VDG, Plasma, Frameworks
ndavis added a comment to D27262: Reduce blank space inside tooltip's header.

+1

Sun, Feb 9, 8:50 AM · Plasma
ndavis added a comment to D27263: RFC: Accent colour for KColorScheme.

I know this isn't the final version, but I'm not a fan of this idea. It feels like we'd just piling new stuff on top without properly using the old stuff that is already usable. I think if we're not careful, it'll just make color customization more confusing and difficult to work with by causing unexpected behavior where the old and new systems collide and one overrides the other.

Sun, Feb 9, 8:40 AM · Frameworks

Sat, Feb 8

ndavis added a comment to D27222: [applets/taskmanager] increase size of tooltip playback ToolButton sizes.

Now it's unable to apply the patch because a commit it uses isn't present in my local git repo. Even if I create another branch based on D27221 and then fetch the patch with --nobranch, I get the same error.

Sat, Feb 8, 6:52 PM · Plasma
ndavis accepted D27219: Center placeholder texts in system tray popups.

Visually, LGTM

Sat, Feb 8, 9:16 AM · Plasma
ndavis added a comment to D27218: Add icon for org.kde.Ikona.

JFYI, the 64px versions of app icons are currently unused.

Sat, Feb 8, 9:14 AM · Frameworks
ndavis added a comment to D27222: [applets/taskmanager] increase size of tooltip playback ToolButton sizes.

Arc's cherry picking fails when this patch tries to cherry pick from my arcpatch-D27221 branch.

Sat, Feb 8, 9:07 AM · Plasma

Fri, Feb 7

ndavis accepted D27221: Make PC3 ToolButton use SmallMedium icon size by default, to match other versions.
Fri, Feb 7, 11:09 PM · Frameworks
ndavis accepted D26441: New icon for KTimeTracker.

I think I'll just accept this as it is.

Fri, Feb 7, 11:01 PM · Frameworks
ndavis commandeered D26595: Add network-wireless-hotspot icon.

sure

Fri, Feb 7, 10:59 PM · Frameworks

Thu, Feb 6

ndavis awarded D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles a Like token.
Thu, Feb 6, 8:22 PM · Kirigami
ndavis committed R266:80561a58837c: Optimize KTrip and KDE Itinerary icons (authored by ndavis).
Optimize KTrip and KDE Itinerary icons
Thu, Feb 6, 8:15 PM
ndavis committed R266:cf10c681f350: update travel-family icons (authored by mbruchert).
update travel-family icons
Thu, Feb 6, 8:08 PM
ndavis closed D27187: update travel-family icons.
Thu, Feb 6, 8:08 PM · Frameworks
ndavis accepted D27187: update travel-family icons.

This looks ready to go. I'll do some additional optimization later.

Thu, Feb 6, 8:06 PM · Frameworks
ndavis added a comment to D27187: update travel-family icons.

Much better. Now the margins need to be 4px rather than 3px. If you haven't already, make sure you read the HIG section on icons and the workflow tips wiki page it links to.
https://hig.kde.org/style/icons/index.html
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips

Thu, Feb 6, 6:38 PM · Frameworks
ndavis committed R273:2dc164e18a95: [KColorUtils] Change getHcy() hue range to [0.0, 1.0) (authored by ndavis).
[KColorUtils] Change getHcy() hue range to [0.0, 1.0)
Thu, Feb 6, 6:00 PM
ndavis closed D27192: [KColorUtils] Change getHcy() hue range to [0.0, 1.0).
Thu, Feb 6, 6:00 PM · Frameworks
ndavis committed R273:4de9a9318e61: [KColorUtils] Add hue(), chroma(), hcyColor() and update documentation (authored by ndavis).
[KColorUtils] Add hue(), chroma(), hcyColor() and update documentation
Thu, Feb 6, 5:59 PM
ndavis closed D27017: [KColorUtils] Add hue(), chroma(), hcyColor() and update documentation.
Thu, Feb 6, 5:59 PM · Frameworks
ndavis accepted D27195: Change "Redisplay" to "Refresh".
Thu, Feb 6, 5:38 PM · Frameworks
ndavis added a comment to D27138: [Applet] Display device name when there is than one device.

no objections :)

Thu, Feb 6, 4:36 PM · Plasma