ndavis (Noah Davis)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Sep 6 2017, 10:33 AM (76 w, 1 d)
Availability
Available

Recent Activity

Today

ndavis added a comment to D19148: Make shadow sizes linear.
In D19148#416749, @zzag wrote:

kstyle uses entirely different shadows, even more so compared to the original values for kdecoration. Should it not be that way?

Well, my concern was that now decoration shadows are way too black in comparison to kstyle shadows.

Also, I have a question about shadow that comes from directional light, why opacity decreases as size increases? Shouldn't it be vice versa?

Fri, Feb 22, 4:52 AM · Plasma

Yesterday

ndavis added a comment to T10034: Attract existing FLOSS software projects to KDE and incorporate their members into our community.

Maybe KeepassXC? It's a Qt based client for Keepass password databases. They seem interested in using Breeze as their default icon theme as well. They currently use Oxygen.

Thu, Feb 21, 8:07 AM · KDE Promo
ndavis added a comment to T10506: Define Tablet IOUP.

Scale

  • For 1080p it is 2?
Thu, Feb 21, 6:00 AM · Plasma

Wed, Feb 20

ndavis added a comment to D18986: [breeze-icons] Add video camera icons.

@ngraham If you include this in TWIP&U, use this image since it's slightly sharper on the 64px icon. @trickyricky26's montage is screwing up even though he's using the same command as me.

Wed, Feb 20, 4:59 PM · Frameworks
ndavis accepted D18986: [breeze-icons] Add video camera icons.

LGTM! I really like how the 64px version turned out, especially that shotgun mic.

Wed, Feb 20, 4:56 PM · Frameworks
ndavis added a comment to D19096: Improvements for long label items in Application Dashboard.

+1 from me

Wed, Feb 20, 1:58 PM · Plasma
ndavis added a comment to T10201: Window titlebar colors.

SierraBreezeEnhanced to the rescue again - what about different window buttons if the window is active or inactive?

Obviously this exact solution would be seen as copying macOS, but maybe just having circles or rings in the active window would help.

Wed, Feb 20, 1:31 PM · KDE Applications, VDG
ndavis added a comment to D19148: Make shadow sizes linear.
In D19148#415929, @zzag wrote:

What about kstyle? Is it okay?

Wed, Feb 20, 12:59 PM · Plasma
ndavis updated the summary of D19148: Make shadow sizes linear.
Wed, Feb 20, 1:01 AM · Plasma

Tue, Feb 19

ndavis added a comment to D19148: Make shadow sizes linear.

Small and Medium are the same sizes they originally were, Large is 1.5x Medium and Very large is now the same size that Large was. I've also adjusted the starting opacity of the shadows a bit more.

Tue, Feb 19, 8:10 PM · Plasma
ndavis retitled D19148: Make shadow sizes linear from Add ShadowVerySmall, linear shadow sizes and set Medium as default size to Make shadow sizes linear.
Tue, Feb 19, 8:08 PM · Plasma
ndavis updated the test plan for D19148: Make shadow sizes linear.
Tue, Feb 19, 8:08 PM · Plasma
ndavis updated the diff for D19148: Make shadow sizes linear.

Remove ShadowVerySmall

Tue, Feb 19, 8:05 PM · Plasma
ndavis added a comment to D19148: Make shadow sizes linear.

I like this idea, more variety
Especially considering that the default setting doesn't really change, just gets renamed essentially?

Tue, Feb 19, 3:02 AM · Plasma
ndavis updated the test plan for D19148: Make shadow sizes linear.
Tue, Feb 19, 2:11 AM · Plasma
ndavis updated the test plan for D19148: Make shadow sizes linear.
Tue, Feb 19, 2:07 AM · Plasma
ndavis updated the summary of D19148: Make shadow sizes linear.
Tue, Feb 19, 2:02 AM · Plasma
ndavis updated the diff for D19148: Make shadow sizes linear.

Change default shadow size to medium

Tue, Feb 19, 2:01 AM · Plasma
ndavis requested review of D19148: Make shadow sizes linear.
Tue, Feb 19, 2:00 AM · Plasma

Mon, Feb 18

ndavis committed R31:cd04f42432a6: Multiply radius by 0.5 in calculateBlurStdDev() (authored by ndavis).
Multiply radius by 0.5 in calculateBlurStdDev()
Mon, Feb 18, 10:35 PM
ndavis closed D19134: Multiply radius by 0.5 in calculateBlurStdDev().
Mon, Feb 18, 10:35 PM · Plasma
ndavis added a comment to D19044: [InlineMessage] Do not draw shadows around the message.

TBH, I like the shadow. Breeze as a widget theme tends to be a bit too flat. Here's how it looks with Breeze Dark.

Mon, Feb 18, 10:26 PM · Kirigami
ndavis retitled D19134: Multiply radius by 0.5 in calculateBlurStdDev() from Multiply radius by 0.5 in calculateBlurStdDev to Multiply radius by 0.5 in calculateBlurStdDev().
Mon, Feb 18, 10:06 PM · Plasma
ndavis requested review of D19134: Multiply radius by 0.5 in calculateBlurStdDev().
Mon, Feb 18, 10:06 PM · Plasma
ndavis committed R31:3e78fa28585e: Change shadow color to 0,0,0 for KStyle (authored by ndavis).
Change shadow color to 0,0,0 for KStyle
Mon, Feb 18, 7:24 PM
ndavis closed D19125: Change shadow color to 0,0,0 for KStyle.
Mon, Feb 18, 7:24 PM · Plasma
ndavis added a comment to D19125: Change shadow color to 0,0,0 for KStyle.

Nah, I think that would begin to re-introduce the bug we're trying to solve (shadows not being visible in Breeze Dark).

Mon, Feb 18, 7:19 PM · Plasma
ndavis added a comment to D19125: Change shadow color to 0,0,0 for KStyle.
In D19125#414786, @zzag wrote:

Should we adjust opacity as well?

Mon, Feb 18, 7:18 PM · Plasma
ndavis requested review of D19125: Change shadow color to 0,0,0 for KStyle.
Mon, Feb 18, 7:05 PM · Plasma
ndavis added a comment to D19124: Change shadow color to 0,0,0.

alright

Mon, Feb 18, 7:03 PM · Plasma
ndavis committed R31:dce32ce1e0ed: Change shadow color to 0,0,0 (authored by ndavis).
Change shadow color to 0,0,0
Mon, Feb 18, 6:49 PM
ndavis closed D19124: Change shadow color to 0,0,0.
Mon, Feb 18, 6:49 PM · Plasma
ndavis updated the test plan for D19124: Change shadow color to 0,0,0.
Mon, Feb 18, 6:44 PM · Plasma
ndavis updated the test plan for D19124: Change shadow color to 0,0,0.
Mon, Feb 18, 6:41 PM · Plasma
ndavis requested review of D19124: Change shadow color to 0,0,0.
Mon, Feb 18, 6:34 PM · Plasma
ndavis added a comment to D19020: [breeze-icons] Revamp system.svgz.

Well, maybe it is time to call it and be done. I don't think we are going to please everyone right now. Maybe our best option is to have you, as the proponent of this idea, make the decision after long debate.

You're right, and thanks for giving me the nudge I needed :D

Okay so, I propose the icon remain the way it is right now:


because
(1) we can't use an I beam with or without dots (the label is too vague)
(2) we could use a long bar, but it looks kind of like a progress bar
(3) we could use a circle, but we technically don't need to - and this sort of stresses the fact that it's an entirely different login screen that it'll take you to

Mon, Feb 18, 6:12 AM · Frameworks

Sat, Feb 16

ndavis updated the task description for T10046: Improve the colors, color consistency and colorscheme compatibility of Breeze.
Sat, Feb 16, 1:25 AM · KDE Human Interface Guidelines, VDG, Plasma, Breeze

Fri, Feb 15

ndavis added a comment to D19030: Add 16 px and 22 px versions of the gamepad icon to devices/.
Fri, Feb 15, 10:16 PM · Frameworks
ndavis added a comment to D19020: [breeze-icons] Revamp system.svgz.

What's the air conditioning do? suspend to disk?

+1 on the moon for suspend

Fri, Feb 15, 9:38 AM · Frameworks
ndavis committed R266:b04959059668: Add battery icons (authored by ndavis).
Add battery icons
Fri, Feb 15, 2:54 AM
ndavis closed D18940: Add battery icons.
Fri, Feb 15, 2:54 AM · Frameworks

Thu, Feb 14

ndavis added a comment to T10165: Category icons should all be colorful.

@dariuszdeoniziak I agree that monochrome icons for preference categories could look great, but it would take a lot more effort to get it right. It's much easier to make readable color icons and preferences are one of the hardest categories to design (try differentiating Look and Feel themes, Plasma themes, Qt Widget themes and GTK themes in monochrome). Most of the existing preference icons have no monochrome version, so a lot of icons would need to be created as well. We can get a similarly good looking result by consistently using color icons designed for Breeze and Breeze Dark.

Thu, Feb 14, 9:31 PM · Plasma, VDG
ndavis updated the summary of D18940: Add battery icons.
Thu, Feb 14, 8:23 PM · Frameworks
ndavis updated the diff for D18940: Add battery icons.

Change status/22 and status/22@2x from Scalable to Fixed

Thu, Feb 14, 8:21 PM · Frameworks
ndavis added a comment to D18940: Add battery icons.

Would changing status/22 to Fixed cause a problem? It doesn't appear to cause any real issue when I look at the change through Cuttlefish.

Run dolphin with QT_SCALE_FACTOR=2 in the environment and see if the Places panel icons are still monochrome.

Thu, Feb 14, 8:13 PM · Frameworks
ndavis added a comment to D18940: Add battery icons.

This is the configuration for status/32:

[status/32]
Size=32
Context=Status
Type=Fixed
Thu, Feb 14, 5:42 AM · Frameworks
ndavis added a comment to D18986: [breeze-icons] Add video camera icons.

Should it be a head on view? Or should it be a side view?

Head on if you're going to use this style. Side if you're going to use the first style.

Thu, Feb 14, 1:12 AM · Frameworks
ndavis added a comment to D18986: [breeze-icons] Add video camera icons.

Well, we can't use that exact icon, but you can make something similar

Still a work in progress, but... what do you think

Thu, Feb 14, 12:29 AM · Frameworks

Wed, Feb 13

ndavis added a comment to D18986: [breeze-icons] Add video camera icons.
Wed, Feb 13, 11:38 PM · Frameworks
ndavis added a comment to D18986: [breeze-icons] Add video camera icons.

Because of camera-photo.svg, and I also really like Plasma Blue. I'm open to suggestions, mockups, anything that would look better than the current 64 px icon.

Wed, Feb 13, 10:39 PM · Frameworks
ndavis added a comment to D18986: [breeze-icons] Add video camera icons.

For the color icon:
Avoid using the plasma logo unnecessarily. In existing device icons that use it (I want to move away from using it), it's usually placed where a brand logo would go on a real product.

Wed, Feb 13, 9:51 PM · Frameworks
ndavis added a comment to D18986: [breeze-icons] Add video camera icons.

How about now?

I made the monochrome version a little taller

Wed, Feb 13, 8:50 PM · Frameworks
ndavis added a comment to D18940: Add battery icons.

The battery icon is composited of multiple SVG items layered ontop of each other, it doesn't just load a single icon.

I'm in favor of adding proper battery icons to the Breeze iconset, definitely need "battery", "battery-caution", "battery-low" icons (from the freedesktop icon spec) but we cannot remove them from the Plasma theme.

Wed, Feb 13, 9:27 AM · Frameworks
ndavis added a comment to D18940: Add battery icons.

Won't 3rd party themes contain their own icons?

Sure but in the style of a Plasma battery.svgz, so if we change the BatteryIcon to use icon theme instead of Plasma theme icons (which none of the other tray icons do, btw) we'll effectively break third party themes.

Wed, Feb 13, 9:19 AM · Frameworks
ndavis added a comment to D18940: Add battery icons.

maybe we can port the code to use these as icons from the icon theme rather than SVGs from the Plasma theme and then delete them from the Plasma theme

And in the process break all third party Plasma themes?

Wed, Feb 13, 9:16 AM · Frameworks
ndavis added a comment to D18940: Add battery icons.

So I guess this means some duplication between the Breeze icon theme and the Breeze Plasma theme for a while, right?

Wed, Feb 13, 6:11 AM · Frameworks

Tue, Feb 12

ndavis added a comment to D18940: Add battery icons.

I like it!
Would you consider moving the green charging to either the filled-in or the white part where the symbol is currently above the line where the filled-in part ends?

Tue, Feb 12, 7:34 PM · Frameworks
ndavis added a comment to D18940: Add battery icons.

Nice. Shouldn't the plug here be green, same as everywhere else?

Tue, Feb 12, 7:13 PM · Frameworks
ndavis updated the summary of D18940: Add battery icons.
Tue, Feb 12, 6:46 AM · Frameworks
ndavis updated the diff for D18940: Add battery icons.

Fix missing PositiveText stylesheet for battery-020-charging

Tue, Feb 12, 6:36 AM · Frameworks
ndavis added a comment to D18940: Add battery icons.

Not certain if I've got the index.themes right

Tue, Feb 12, 6:31 AM · Frameworks
ndavis updated the diff for D18940: Add battery icons.

Add status/32 to index.theme

Tue, Feb 12, 6:31 AM · Frameworks
ndavis updated the test plan for D18940: Add battery icons.
Tue, Feb 12, 6:27 AM · Frameworks
ndavis requested review of D18940: Add battery icons.
Tue, Feb 12, 6:22 AM · Frameworks

Fri, Feb 8

ndavis closed D18865: Change C/C++ header/source mimetype icons to circle/line style.
Fri, Feb 8, 10:01 PM · Frameworks
ndavis committed R266:fdf910145bef: Change C/C++ header/source mimetype icons to circle/line style (authored by ndavis).
Change C/C++ header/source mimetype icons to circle/line style
Fri, Feb 8, 10:01 PM
ndavis added a comment to D18861: Improve the look of the Fonts KCM UI.

Personally my preference would be for the strings to be like this: 10 pt Noto Sans

Fri, Feb 8, 9:46 PM · Plasma
ndavis added a comment to D18861: Improve the look of the Fonts KCM UI.

I don't like the look of the | character between the font name and the font size. I think the existing "Noto Sans 10" format looked better, but I'm not going to formally request changes.

Fri, Feb 8, 9:40 PM · Plasma
ndavis updated the test plan for D18865: Change C/C++ header/source mimetype icons to circle/line style.
Fri, Feb 8, 9:33 PM · Frameworks
ndavis requested review of D18865: Change C/C++ header/source mimetype icons to circle/line style.
Fri, Feb 8, 9:26 PM · Frameworks
ndavis committed R266:0eea3019324f: Fix missing shadows on C/C++ header mimetype icons (authored by ndavis).
Fix missing shadows on C/C++ header mimetype icons
Fri, Feb 8, 6:30 PM
ndavis closed D18837: Fix missing shadows on C/C++ header mimetype icons.
Fri, Feb 8, 6:30 PM · Frameworks
ndavis committed R242:054b494bb3f2: Change glowbar.svgz to smoother style (authored by ndavis).
Change glowbar.svgz to smoother style
Fri, Feb 8, 8:57 AM
ndavis closed D18834: Change glowbar.svgz to smoother style.
Fri, Feb 8, 8:57 AM · Frameworks
ndavis added a comment to D18834: Change glowbar.svgz to smoother style.

Well, there's nothing wrong within the patch itself, so I'll land it.

Fri, Feb 8, 8:56 AM · Frameworks
ndavis requested review of D18837: Fix missing shadows on C/C++ header mimetype icons.
Fri, Feb 8, 8:15 AM · Frameworks
ndavis added a comment to D18834: Change glowbar.svgz to smoother style.

You could make it smaller? It looks fine to me at the corners, it's the actual sidebar that's a little thick.

I still like this diff though, I think that the master's too stippled/dotted.

Fri, Feb 8, 2:46 AM · Frameworks
ndavis added a comment to D18834: Change glowbar.svgz to smoother style.

I suppose it's this, but it's somehow even worse with this patch: https://bugs.kde.org/show_bug.cgi?id=337712

Fri, Feb 8, 1:10 AM · Frameworks
ndavis added a comment to D18834: Change glowbar.svgz to smoother style.

For some reason, this version looks much larger in the corners. Was there a change to how the screen edge effect works? I didn't change the size of the corners in the SVGZ.

Fri, Feb 8, 12:44 AM · Frameworks
ndavis updated the test plan for D18834: Change glowbar.svgz to smoother style.
Fri, Feb 8, 12:42 AM · Frameworks
ndavis added a comment to D18834: Change glowbar.svgz to smoother style.

Wait I can do that? I didn't know I could do that :D

Fri, Feb 8, 12:40 AM · Frameworks
ndavis added a comment to D18834: Change glowbar.svgz to smoother style.

If you like it, don't be afraid to hit "Approve" ;)

Fri, Feb 8, 12:31 AM · Frameworks
ndavis updated the summary of D18834: Change glowbar.svgz to smoother style.
Fri, Feb 8, 12:15 AM · Frameworks
ndavis updated the test plan for D18834: Change glowbar.svgz to smoother style.
Fri, Feb 8, 12:08 AM · Frameworks
ndavis updated the test plan for D18834: Change glowbar.svgz to smoother style.
Fri, Feb 8, 12:08 AM · Frameworks
ndavis updated the test plan for D18834: Change glowbar.svgz to smoother style.
Fri, Feb 8, 12:06 AM · Frameworks

Thu, Feb 7

ndavis added a comment to D18834: Change glowbar.svgz to smoother style.

JFYI, the whole embedded stylesheet thing doesn't work on gradients, so it doesn't matter if colors are hardcoded.

Thu, Feb 7, 11:39 PM · Frameworks
ndavis requested review of D18834: Change glowbar.svgz to smoother style.
Thu, Feb 7, 11:38 PM · Frameworks
ndavis accepted D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg.
Thu, Feb 7, 4:25 PM · Frameworks
ndavis requested changes to D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg.
Thu, Feb 7, 7:36 AM · Frameworks
ndavis added a comment to D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg.

Now that I've had a look at the icon, it's not aligned with the pixel grid. The original icon wasn't very well aligned either, but at least the top and bottom were. Shrinking down from one monochrome size to another without adjusting to fit the grid generally doesn't work very well.

Thu, Feb 7, 7:36 AM · Frameworks
ndavis added a comment to D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg.

Wow thanks @ndavis, scour shrinks it even more than svgcleaner does

Thu, Feb 7, 6:53 AM · Frameworks
ndavis added a comment to D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter.

Oh I understand now. These sizes are user configurable. In that case, I suppose it doesn't make sense to add a 24px option and hardcoding is probably fine as long as it's compatible with UI scaling for HiDPI screens.

Thu, Feb 7, 6:12 AM · Plasma
ndavis added a comment to T10450: Konqi the voice assistant.

https://mycroft.ai/ is an option. I believe it can be customized so that it uses custom wake words and there is already a Plasma widget for it.

Thu, Feb 7, 2:41 AM · Plasma: Mobile, Plasma, KDE Developers, KDE Connect, VDG
ndavis added inline comments to D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg.
Thu, Feb 7, 2:27 AM · Frameworks
ndavis added a comment to D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg.

Hmm somehow I missed this. Here's a way to optimize it with a utility that's available in most distro repos (scour, python-scour):

Thu, Feb 7, 2:24 AM · Frameworks

Wed, Feb 6

ndavis added a comment to D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter.

The idea would be that 16 and 22px are for monochrome and 24px and above could be for color.

Wed, Feb 6, 10:55 PM · Plasma
ndavis added a comment to D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter.

Next question: KInfoCenter's version of this tooltip currently hardcodes 32x32 for the size of the parent icon above it rather than using the KIconLoader::Dialog size (which defaults to 32x32).. Should we do that here too so that there's never a case where the parent icon could be smaller than the child icon for the corner case of a user who has set the KIconLoader::Dialog size to something smaller than its default?

Wed, Feb 6, 10:47 PM · Plasma
ndavis accepted D18800: Use colorful icon in KCM.
Wed, Feb 6, 10:44 PM · Plasma
ndavis added a comment to D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter.

I thought we primarily used 22px and not 24px? While it does make the icons look more consistent as long as there are no monochrome 24px versions (there are some) should there be an exception to the norm? If so, we would have to remove all 24px monochrome icons.

No, just all monochrome 24px versions of color preferences-* icons, of which there are only two:

/usr/share/icons/breeze$  find */24/ | grep -i preferences-
actions/24/preferences-activities.svg
actions/24/preferences-other.svg

None of these are currently used by any KCMs (Activities uses your nice new preferences-desktop-activities icon).

Wed, Feb 6, 10:18 PM · Plasma