- User Since
- Sep 6 2017, 10:33 AM (129 w, 2 d)
Adding Hugo as a subscriber since he might have some advice.
Wed, Feb 26
Tue, Feb 25
Just to repost and add a bit from the darker breeze dark diff:
I can see the utility in indicating non-default values in some cases, particularly with software that has a lot of necessary complexity in the settings or where non-default values can cause problems (see SVG Cleaner GUI for an example of both). However, I don't think it's necessary for most software to indicate non-default values or even dirty values.
Mon, Feb 24
What I'm saying is that doing something like what VS Code does could work for making views next to views look good, like a sidebar next to a list view.
One way we could get views next to other views to look right is to use the alternate view background color for sidebars
Should we just revert for now?
looks like it's not posix sh, but bash code
I think these 4 colors could be used for backgrounds in Breeze Dark:
The problem with having dark separators is that they disappear if you set the background color to black. That isn't an unreasonable thing for a user to want to do. It's also arguable that it isn't unreasonable for a user to want dark separators, so they could be an option, but last time I tried that for colorschemes, it didn't get a lot of support (D25814). It could be an option in the Breeze widget style settings, but I really don't want to start stuffing options in obscure places...
Sun, Feb 23
Sat, Feb 22
After you rebase this, I'd say this patch is ready to go.
I've added the icons that were only in actions/24 to actions/22.
I've fixed the 22px files that had height/width and viewbox set.
The following 24px icon symlinks are linked to 22px icons. Maybe it's material for another patch, but I figured I'd bring it up.
draw-highlight got a bit mangled:
Out of the ones listed above, these are symlinks:
Looking pretty good so far. The only icons that have 24px versions but no 22px versions are the following from the actions category:
24/align-horizontal-node.svg 24/align-vertical-node.svg 24/audio-volume-high.svg 24/audio-volume-low.svg 24/audio-volume-medium.svg 24/audio-volume-muted.svg 24/distribute-horizontal-node.svg 24/distribute-vertical-node.svg 24/font.svg 24/gnumeric-autofilter-delete.svg 24/gnumeric-autosum.svg 24/gnumeric-bucket.svg 24/gnumeric-cells-merge.svg 24/gnumeric-column-size.svg 24/gnumeric-component-insert-shaped.svg 24/gnumeric-data-slicer.svg 24/gnumeric-font.svg 24/gnumeric-format-border-all.svg 24/gnumeric-format-accounting.svg 24/gnumeric-format-border-double-bottom.svg 24/gnumeric-format-border-none.svg 24/gnumeric-format-border-outside.svg 24/gnumeric-format-border-thick-bottom.svg 24/gnumeric-format-border-thick-outside.svg 24/gnumeric-format-border-top-n-bottom.svg 24/gnumeric-format-border-top-n-thick-bottom.svg 24/gnumeric-format-border-top-n-double-bottom.svg 24/gnumeric-format-percentage.svg 24/gnumeric-format-precision-decrease.svg 24/gnumeric-format-precision-increase.svg 24/gnumeric-format-thousand-separator.svg 24/gnumeric-formulaguru.svg 24/gnumeric-link-external.svg 24/gnumeric-link-internal.svg 24/gnumeric-link-url.svg 24/gnumeric-object-arrow.svg 24/gnumeric-object-button.svg 24/gnumeric-object-checkbox.svg 24/gnumeric-object-combo.svg 24/gnumeric-object-ellipse.svg 24/gnumeric-object-label.svg 24/gnumeric-object-line.svg 24/gnumeric-object-list.svg 24/gnumeric-object-rectangle.svg 24/gnumeric-object-scrollbar.svg 24/gnumeric-object-spinbutton.svg 24/gnumeric-pagesetup-hf-cell.svg 24/gnumeric-protection-no.svg 24/gnumeric-pagesetup-hf-time.svg 24/gnumeric-protection-yes.svg 24/gnumeric-row-size.svg 24/gtk-tab-duplicate.svg 24/snap-nodes-cusp.svg 24/snap-nodes-midpoint.svg 24/snap-nodes-path.svg 24/snap-nodes-smooth.svg 24/transform-scale-horizontal.svg 24/transform-scale-vertical.svg 24/y-zoom-in.svg 24/zoom-in-x.svg 24/zoom-out-x.svg 24/zoom-out-y.svg 24/gtk-tab-new.svg 24/media-mout.svg
Fri, Feb 21
Thu, Feb 20
Does this work well with vertical panels?
I don't know what hotspot is used for, but the other ones are probably used by 3rd party apps. The virt-manager and system-help icons are definitely used by 3rd party apps in places where monochrome icons should be.
Mon, Feb 17
Sun, Feb 16
This change is purely visual and I don't think that usability is affected. I personally find the 2px version prettier and more consistent with T11124
I don't think it's really worth it to do this patch for the same reasons as Nate.
Please check how this looks with a vertical panel.
Sat, Feb 15
You've got a duplicate copy of the icon in there. The bottom shadow should also be changed to be dark gray, like a darker version of the normal background color rather than a dark blue.
The pixel alignment for all parts of the inner symbol is off. The style of the inner symbol is a bit too rounded for the breeze style as well. For instance, the podium should have sharper corners in order to look more like other breeze icons. I know it's not really easy to tell what can be rounded and what can't. That's something we need to nail down in the HIG. In general, use roundness where appropriate for a given shape, not as a general style. Objects that typically have sharp corners should generally be represented with sharp corners.
Fri, Feb 14
Personally, I think emblems are fine, but I'm not going to hold up the KDevelop patch just because of that. They already existed in Papirus, the most popular 3rd party theme.
Thu, Feb 13
Wed, Feb 12
please update the test plan before landing though
the shadow on the folded corners needs to be changed. diagonal shadows only go down and to the right
Tue, Feb 11
You need to set your full name as your git user name. Otherwise, the system won't let me land it.
Mon, Feb 10
I agree with @filipf
I think rather than adjusting hardcoded opacity in the SVGs, we need to make configurable plasmashell opacity a reality. Then, if we want to do an effect like what Nate described, we could have a way to automatically adjust the global plasmashell opacity.
Sun, Feb 9
Still uses ViewBackground on panels. For panel popups, you wanted to use a header area like the systray mockups, right? If so, the dialog SVG could use ViewBackground and you should mark this patch as dependent on the toparea patch.
I know this isn't the final version, but I'm not a fan of this idea. It feels like we'd just piling new stuff on top without properly using the old stuff that is already usable. I think if we're not careful, it'll just make color customization more confusing and difficult to work with by causing unexpected behavior where the old and new systems collide and one overrides the other.
Sat, Feb 8
Now it's unable to apply the patch because a commit it uses isn't present in my local git repo. Even if I create another branch based on D27221 and then fetch the patch with --nobranch, I get the same error.
JFYI, the 64px versions of app icons are currently unused.
Arc's cherry picking fails when this patch tries to cherry pick from my arcpatch-D27221 branch.
Fri, Feb 7
I think I'll just accept this as it is.
Thu, Feb 6
This looks ready to go. I'll do some additional optimization later.
Much better. Now the margins need to be 4px rather than 3px. If you haven't already, make sure you read the HIG section on icons and the workflow tips wiki page it links to.
no objections :)