ndavis (Noah Davis)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Sep 6 2017, 10:33 AM (117 w, 3 d)
Availability
Available

Recent Activity

Yesterday

ndavis added a comment to D25340: Added background colors to active and inactive icon view.

@niccolove Do you mind if I commandeer this? I know dealing with these kinds of issues can be super annoying and I'm already used to it.

Sat, Dec 7, 7:56 PM · Frameworks
ndavis added a comment to T12192: Tweak SimpleMenu layout and replace Kickoff.

Something else to think about:
The search bar is put on the same side of the screen as the content area on the right. Should it only search for content related to the selected tab or search for all content at once? I feel like the layout in the most recent mockup works best for finding content related to the selected tab.

Sat, Dec 7, 5:54 PM · Plasma, VDG
ndavis added a comment to T12192: Tweak SimpleMenu layout and replace Kickoff.

I really like the idea of making Files a tab that shows all the files from various places. Could you also add a "Recent" category for the file list?

Or actually, maybe the Favorite categories for both apps and files should be merged and be "Recent & Favorite", showing both, separated into different sections, like this:

Favorites
=========
- Discover
- Dolphin
- Firefox
- System Settings

Recently used
=============
- Kate
- Konsole
- Elisa
- etc

Thoughts?

Sat, Dec 7, 5:48 PM · Plasma, VDG
ndavis added a comment to D25340: Added background colors to active and inactive icon view.

It's still going to be a PITA with manual editing. Maybe there's a way to automate it with awk, but I don't know that tool well enough. This should at least make the deleting part easier: sed --follow-symlinks -i 's/style="opacity:0.05"//' tasks.svg

Sat, Dec 7, 5:26 PM · Frameworks
ndavis requested changes to D25340: Added background colors to active and inactive icon view.
Sat, Dec 7, 5:20 PM · Frameworks
ndavis added a comment to D25340: Added background colors to active and inactive icon view.

Oh wait, here's the problem

Sat, Dec 7, 5:20 PM · Frameworks
ndavis added a comment to D25340: Added background colors to active and inactive icon view.

Hmm, I'm not seeing any change, and the difference between open and maximized items is still too subtle IMO:

If the background is a different color/opacity, I can't tell.

Sat, Dec 7, 5:14 PM · Frameworks
ndavis added a comment to T12192: Tweak SimpleMenu layout and replace Kickoff.

So something like this, right?

Sat, Dec 7, 2:17 PM · Plasma, VDG
ndavis accepted D25340: Added background colors to active and inactive icon view.
Sat, Dec 7, 11:40 AM · Frameworks
ndavis requested changes to D25340: Added background colors to active and inactive icon view.

Wait, is a change to tabbar.svg supposed to be in this diff?

Sat, Dec 7, 11:25 AM · Frameworks
ndavis accepted D25340: Added background colors to active and inactive icon view.
Sat, Dec 7, 11:23 AM · Frameworks
ndavis added a comment to T12192: Tweak SimpleMenu layout and replace Kickoff.

What if we just drop the A-Z tab or put it in the sidebar with the rest of the categories?

Or how about making it a switchable setting? I'm sure some users prefer just having categories and couldn't care less about a A-Z order appearing while others are the opposite of that and then there are some who don't care at all.
Benefit of making that a setting is a decluttering of the interface (which is shaping up really nice, btw, great job @manueljlin ).

Sat, Dec 7, 11:22 AM · Plasma, VDG

Fri, Dec 6

ndavis added a comment to T12192: Tweak SimpleMenu layout and replace Kickoff.

Or rather than being Categories/A-Z, do Applications/Files with places in the sidebar and folder contents in the main area, like a built in folder view. That could actually be super convenient, but I don't know if it's really needed.

Fri, Dec 6, 8:22 PM · Plasma, VDG
ndavis added a comment to T12192: Tweak SimpleMenu layout and replace Kickoff.

What if we just drop the A-Z tab or put it in the sidebar with the rest of the categories?

Fri, Dec 6, 8:16 PM · Plasma, VDG
ndavis accepted D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts".

Welp, there's nothing objectively wrong with making this patch. LGTM

Fri, Dec 6, 7:43 PM · Frameworks
ndavis added a comment to D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts".

This doesn't seem wrong, but why is it needed? Do people get confused about the type of shortcuts? Are there non-keyboard shortcuts? If there are, would we put their configuration menu under a different menu option?

Fri, Dec 6, 7:11 PM · Frameworks
ndavis added a comment to D25296: [RFC] Fix Display Configuration icon margins.

Never mind, I wasn't deleting the cache files properly after rebuilding. When I do that, the monochrome icons don't get used at all and it reverts to the colorful one:

Fri, Dec 6, 4:27 PM · Frameworks

Thu, Dec 5

ndavis added a comment to D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default.

I personally prefer file manager, web browser for the order.

Thu, Dec 5, 8:16 PM · Plasma
ndavis accepted D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default.
Thu, Dec 5, 8:14 PM · Plasma

Wed, Dec 4

ndavis added a comment to T12192: Tweak SimpleMenu layout and replace Kickoff.

I could agree with using a grid view for Favorites and a list view for browsing through app categories. We could also put the app comment/generic name near the app name in the list view like Kickoff.

Wed, Dec 4, 7:46 PM · Plasma, VDG
ndavis added a comment to T12192: Tweak SimpleMenu layout and replace Kickoff.
In T12192#212728, @mart wrote:

@mart, I think the mockups on the right are actually the A-Z list (notice where the separators are placed), not a separate version of the mockup. I think @manueljlin just forgot to highlight the A-Z tab. It's the top and bottom rows that are different versions.

well... i would love to have the possibility of having lists in general view somehow then.. i really don't like grids on my desktop, they are slower on mouse systems and demonstrately quite bad for big sets of items where the spatial memory can't help you.
https://stample.com/link/stamples/53b2e194e4b0ab5d1e429db8/list-beats-grid-linear-feeds-perform-two-to-three-times-better-than-grids (it may be better for small and known sets.. on touch. so like favorites in tablet mode would perform better, but that's about it)

I get that it somehow a grid view needs to be the default because it does look better... but is really a case of looking better at the price of actual usability (same thing for dolphin.. the default kinda has to be the icon view for first impact, but then its detailed list view is just so much better to use in the end)

Wed, Dec 4, 7:35 PM · Plasma, VDG
ndavis accepted D25740: Add item spacing to size hint.
Wed, Dec 4, 2:25 PM · Plasma
ndavis added a comment to T12192: Tweak SimpleMenu layout and replace Kickoff.

@mart, I think the mockups on the right are actually the A-Z list (notice where the separators are placed), not a separate version of the mockup. I think @manueljlin just forgot to highlight the A-Z tab. It's the top and bottom rows that are different versions.

Wed, Dec 4, 10:48 AM · Plasma, VDG

Tue, Dec 3

ndavis added a comment to T12308: Dolphin UI redesign.

I'm thinking maybe the breadcrumb shouldn't go in the toolbar. If you have to make all toolbuttons icons only to get the breadcrumb to fit, it's not good. There is real usability research that shows how labels are important for buttons with non-standard icons: https://www.nngroup.com/articles/icon-usability/

Tue, Dec 3, 8:44 PM · VDG
ndavis committed R265:21ac4b09b242: [KColorScheme] Make order of decoration colors match DecorationRole enum (authored by ndavis).
[KColorScheme] Make order of decoration colors match DecorationRole enum
Tue, Dec 3, 5:34 PM
ndavis committed R265:7bd649ee1c0a: [KColorScheme] Fix mistake in NShadeRoles comment (authored by ndavis).
[KColorScheme] Fix mistake in NShadeRoles comment
Tue, Dec 3, 9:32 AM
ndavis committed R265:45b6460b0c09: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items (authored by ndavis).
[KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items
Tue, Dec 3, 9:26 AM
ndavis closed D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items.
Tue, Dec 3, 9:26 AM · Frameworks
ndavis updated the diff for D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items.

More code formatting

Tue, Dec 3, 9:24 AM · Frameworks

Mon, Dec 2

ndavis updated the diff for D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items.
  • [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items
  • fix code style
Mon, Dec 2, 11:53 PM · Frameworks
ndavis committed R265:38b02c1baa84: [KColorScheme] Add items to ColorSet and Role enums for the total number of… (authored by ndavis).
[KColorScheme] Add items to ColorSet and Role enums for the total number of…
Mon, Dec 2, 11:37 PM
ndavis closed D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items.
Mon, Dec 2, 11:37 PM · Frameworks
ndavis added a comment to T10201: Window titlebars.

The Aurorae engine is a more popular and easy but limited way to make custom window decorations. I don't think it would be able to do what you're talking about.

I didn't mean to ask for a solution using Aurorae. I'm currently working on a decoration and QStyle set which is based on a fork of Breeze, so it's good to know I can pass information from one to the other. Helps me out a ton for some fun ideas.
Thanks!

Mon, Dec 2, 9:43 PM · KDE Applications, VDG
ndavis added a comment to T10201: Window titlebars.

I haven't dug too deep into KFrameworks stuff, but is the decoration able to detect if the QStyle has to render a toolbar? I'm asking because on macOS for example the gradient is always the same, just more or less stretched depending on the size of the titlebar. This creates a very consistent look over all. This could also be used to draw or hide a titlebar seperator depending on wether or not a toolbar will be drawn in the window.

Mon, Dec 2, 9:31 PM · KDE Applications, VDG
ndavis added a comment to D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items.

This also replaces some for-loops with C++11 range based for-loops and switches for simpler if/else control blocks.

Seems like these changes are unrelated and should maybe be in a separate commit?

Mon, Dec 2, 4:32 PM · Frameworks
ndavis added a comment to T10201: Window titlebars.

One question that came up in my mind: how would this new "combine area for titlebar and toolbar" affect themes that draw gradients on the titlebar?

Mon, Dec 2, 3:49 PM · KDE Applications, VDG
ndavis added a reviewer for D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items: dfaure.
Mon, Dec 2, 3:35 PM · Frameworks
ndavis added a reviewer for D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items: dfaure.
Mon, Dec 2, 3:35 PM · Frameworks
ndavis updated the summary of D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items.
Mon, Dec 2, 7:15 AM · Frameworks
ndavis added a reviewer for D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items: Frameworks.
Mon, Dec 2, 7:05 AM · Frameworks
ndavis added a dependent revision for D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items: D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items.
Mon, Dec 2, 7:04 AM · Frameworks
ndavis added a dependency for D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items: D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items.
Mon, Dec 2, 7:04 AM · Frameworks
ndavis requested review of D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items.
Mon, Dec 2, 7:04 AM · Frameworks
ndavis updated the test plan for D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items.
Mon, Dec 2, 6:59 AM · Frameworks
ndavis updated the diff for D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items.
  • Split up Effects enum
Mon, Dec 2, 6:44 AM · Frameworks
ndavis retitled D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items from Add items to ColorSet and Role enums for the total number of items to [KColorScheme] Add items to ColorSet and Role enums for the total number of items.
Mon, Dec 2, 6:35 AM · Frameworks
ndavis updated the summary of D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items.
Mon, Dec 2, 5:38 AM · Frameworks
ndavis updated the diff for D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items.
  • Also do Effects enum
Mon, Dec 2, 5:35 AM · Frameworks
ndavis updated the summary of D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items.
Mon, Dec 2, 5:20 AM · Frameworks
ndavis updated the summary of D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items.
Mon, Dec 2, 5:19 AM · Frameworks
ndavis updated the summary of D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items.
Mon, Dec 2, 5:17 AM · Frameworks
ndavis added a reviewer for D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items: Frameworks.
Mon, Dec 2, 5:15 AM · Frameworks
ndavis requested review of D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items.
Mon, Dec 2, 5:15 AM · Frameworks

Sat, Nov 30

ndavis added a comment to T11915: Commission new official version of the KDE logo with the word "KDE" next to it or below it.

close tie between Noto and Lato for me
-1 to Deja

Sat, Nov 30, 5:24 PM · VDG, KDE Promo
ndavis added a comment to D25628: FEATURE: 414688 Add support for alternative scrolling method (prototype).

It took me a while to realize what the feature was, but now that I do, I might prefer to using it.

Sat, Nov 30, 3:47 PM · Okular
ndavis added a reviewer for D25628: FEATURE: 414688 Add support for alternative scrolling method (prototype): Okular.
Sat, Nov 30, 3:43 PM · Okular

Fri, Nov 29

ndavis accepted D25593: [kdecoration] Use QVariantAnimation instead of QPropertyAnimation.
Fri, Nov 29, 3:27 AM · Plasma
ndavis added inline comments to D25590: support for user removing background and automatic shadow.
Fri, Nov 29, 3:20 AM · Frameworks

Thu, Nov 28

ndavis added a comment to D25539: feat(kcm): add revert timer.

Is there a way to tell the revert timer not to be used if the user only makes a change that requires a session restart? It wouldn't be very useful to ask a user to confirm if the screen is displaying correctly if the change can't be seen.

Thu, Nov 28, 3:43 AM · Plasma
ndavis added inline comments to D25539: feat(kcm): add revert timer.
Thu, Nov 28, 3:39 AM · Plasma

Wed, Nov 27

ndavis abandoned D25543: Split Style & Helper into files by widget type.

I'll abandon this and see how starting my own theme goes.

Wed, Nov 27, 6:14 AM · Plasma
ndavis added a comment to D25543: Split Style & Helper into files by widget type.

Also (and somewhat independently from this patch): with Qt6/KF6 being around the corner, I somewhat wonder about the utility of rewritting and hacking breeze at that time. Would this make sense to actually leave breeze (which is a rather well-working theme, with very little bug reports) unchanged, and start working anew on a new widget style targeting KF6 ? Would that not be more exciting, bring more people in, trigger new ideas, give more freedom ? And be a more ambitious task all in all ?
One could of course start from breeze, and apply all the new ideas about how the code should be organized, how highlight should look, and checkboxes, without disturbance for something which has lived largely unchanged (and with not so many complains) for all the kf5 lifetime ...

My two cents.

Wed, Nov 27, 4:13 AM · Plasma
ndavis added a comment to D25543: Split Style & Helper into files by widget type.

You are missing copyright information and license in all the newly created files.

Wed, Nov 27, 4:10 AM · Plasma

Tue, Nov 26

ndavis updated the diff for D25543: Split Style & Helper into files by widget type.
  • Actually rename all occurrences of combobox.h and tabbar.h
Tue, Nov 26, 11:07 PM · Plasma
ndavis updated the diff for D25543: Split Style & Helper into files by widget type.
  • Rename combobox.h and tabbar.h to be like private headers
Tue, Nov 26, 11:01 PM · Plasma
ndavis updated subscribers of D25543: Split Style & Helper into files by widget type.
Tue, Nov 26, 10:31 PM · Plasma
ndavis added a comment to D25543: Split Style & Helper into files by widget type.

I plan to do the existing files in another patch

Tue, Nov 26, 10:24 PM · Plasma
ndavis updated the diff for D25543: Split Style & Helper into files by widget type.
  • Move renderSidePanelFrame and renderSelection into itemview.cpp
  • Move renderDecorationButton into mdi.cpp
Tue, Nov 26, 10:15 PM · Plasma
ndavis added a comment to D25543: Split Style & Helper into files by widget type.

Very nice, I applaud the goal. However it looks like on net a lot more lines of code were added than were removed, which suggests the addition of redundant boilerplate or unrelated style refactoring. In the former case, can we factor out some of it into additional helper functions?

Tue, Nov 26, 9:53 PM · Plasma
ndavis updated the test plan for D25543: Split Style & Helper into files by widget type.
Tue, Nov 26, 11:30 AM · Plasma
ndavis added a comment to D25543: Split Style & Helper into files by widget type.

Please say if something about the structure does not make sense to you or if you think improvements could be made.

Tue, Nov 26, 11:22 AM · Plasma
ndavis requested review of D25543: Split Style & Helper into files by widget type.
Tue, Nov 26, 11:21 AM · Plasma
ndavis added a comment to D25539: feat(kcm): add revert timer.

One of the key ideas of KScreen was that it will *not* have a revert timer.

Tue, Nov 26, 7:56 AM · Plasma
ndavis added a comment to D25539: feat(kcm): add revert timer.

+1 for this safety feature
It would be nice to have a visible countdown timer though.

Tue, Nov 26, 4:38 AM · Plasma
ndavis added a comment to T11662: Improve visual appeal for KUrlNavigator when in Breadcrumbs mode.
In T11662#211545, @mglb wrote:

I understand, but I was referring to following mockup, where the button has input field background, so I perceive it as in-field icon like "clear" with separator :)

Connected button outside is technically OK, but... not in Breeze style. So either we change it everywhere, or add little spacing between input field and button. Right now you can't even draw this connection nicely using QStyle.

Tue, Nov 26, 4:23 AM · Breeze, VDG

Mon, Nov 25

ndavis added a comment to D25334: Added transparent blue background to tabbars.

Yes that's right, the Kickoff tabs are fine, it's the panel that doesn't look right. It just doesn't look good with that kind of highlight to me. Or maybe the highlight background is too bright.

To me it looks fine with Breeze light IMO. If you think it looks bad with Breeze Dark, that seems like kind of a problem since as far as I was aware, this is the proposed new highlight style that you're working on, right? It definitely needs to look good with Breeze Dark, or at least no worse than the status quo.

Mon, Nov 25, 1:36 AM · Frameworks

Sat, Nov 23

ndavis added a comment to D25334: Added transparent blue background to tabbars.


I'm sorry, isn't this right?
The top one was like that before, and I just edited the bottom one, and they seem to be the same; shouldn't it be right then?

Sat, Nov 23, 7:46 PM · Frameworks
ndavis added a comment to D25340: Added background colors to active and inactive icon view.

In that case, maybe 5% opacity for minimized?

Sat, Nov 23, 5:51 PM · Frameworks
ndavis added a comment to T11662: Improve visual appeal for KUrlNavigator when in Breadcrumbs mode.

I'm not convinced that we need arrows pointing to the right between the separating lines, even if they rotate to down arrows on hover. With touch screens, they won't rotate at all unless clicked anyway. The original mockup design, while not as clean looking, made it perfectly clear what the hierarchy was and the non-rotating down arrows make it clear that a menu exists there. Even just straight lines as separators with no arrows is good enough for GNOME's Nautilus file browser because most people read from left to right (Qt can reverse the layout for RTL languages). The names in the breadcrumb match the folder names, so the hierarchy should still be pretty clear.

Sat, Nov 23, 11:35 AM · Breeze, VDG
ndavis added a comment to D25484: Enable closing a tab by middle click.
In D25484#566490, @pino wrote:
In D25484#566477, @pino wrote:

Do people frequently misclick with the middle mouse button?

It can happen, and more often with a touchpad.

I hadn't considered that. By default, you have to tap with 3 fingers to middle click. What are you doing with the touchpad when this happens? [...]

One use case is clickpads. However, it can happen also with classic mice, especially the small ones where the buttons are close.

Sat, Nov 23, 11:16 AM · Okular
ndavis added a comment to D25484: Enable closing a tab by middle click.

The solution to accidentally clicks is not disabling it by default and making it configurable, but providing the functionality to "restore" a tab after closing it accidentally. Dolphin and Chrome allow me to restore the last closed tab with Ctrl+Shift+T. Does Okular the same?

Sat, Nov 23, 11:02 AM · Okular
ndavis added a comment to D25484: Enable closing a tab by middle click.
In D25484#566477, @pino wrote:

Do people frequently misclick with the middle mouse button?

It can happen, and more often with a touchpad.

Sat, Nov 23, 10:55 AM · Okular
ndavis added a comment to D25484: Enable closing a tab by middle click.
In D25484#566470, @pino wrote:

Please make it configurable, and off by default (otherwise it is too easy to mis-click and close a document).

Sat, Nov 23, 10:25 AM · Okular
ndavis added a comment to T9041: New "Home" tab for Kickoff.

Rather than requiring a click to go back and then another click to go into another category, create a way for categories to be hovered through like the tabs. Those usually useless subcategories shouldn't appear by default. Favorites, History and Often Used can be split into optional categories under the Applications and Computer tabs. Then you're left with just Applications, Computer and Leave.

Sat, Nov 23, 4:36 AM · Plasma, VDG
ndavis added a comment to T9041: New "Home" tab for Kickoff.

I'd be all for making something similar to Simple Menu the default menu.

Sat, Nov 23, 4:33 AM · Plasma, VDG
ndavis accepted D25476: [GTK3] Fix invalid colour name in treeview.
Sat, Nov 23, 12:13 AM · Plasma

Fri, Nov 22

ndavis added a comment to T10413: Specify how to use and classify monochrome vs color icons.

The idea of using two themes seems sort of over-complicated and over-engineered to me.

Fri, Nov 22, 11:36 PM · Plasma, VDG, Breeze
ndavis added a comment to D25381: Make QPushButton/QToolButton the same height as QLineEdit.

Yes, this patch needs minimization. What is the software in your screenshot? @ndavis

Fri, Nov 22, 1:28 PM · Plasma
ndavis committed R266:07a7d129a920: Pixel align color-picker (authored by ndavis).
Pixel align color-picker
Fri, Nov 22, 1:12 PM
ndavis added a comment to T11662: Improve visual appeal for KUrlNavigator when in Breadcrumbs mode.

Here's a mockup with straight lines:

Fri, Nov 22, 10:08 AM · Breeze, VDG
ndavis added a comment to T11662: Improve visual appeal for KUrlNavigator when in Breadcrumbs mode.

Windows may do it that way, but I don't find it intuitive have the order of UI elements changed.

Absolute agreement on that part.

In terms of confusing behaviour, how about highlighting would work like this:

Fri, Nov 22, 10:08 AM · Breeze, VDG
ndavis added a comment to T11662: Improve visual appeal for KUrlNavigator when in Breadcrumbs mode.

I see how you were thinking of rotate on hover now and I agree that it would be effective for showing both hierarchy and the control for switching to nearby folders. It still has the problem of having arrows to the left of the labels they affect though.

Fri, Nov 22, 9:10 AM · Breeze, VDG
ndavis added a comment to T11662: Improve visual appeal for KUrlNavigator when in Breadcrumbs mode.

I played with the margins on the original mockup style a bit:


Played with the strength of the inner arrow separators a bit too:

Fri, Nov 22, 7:33 AM · Breeze, VDG
ndavis added a comment to T11662: Improve visual appeal for KUrlNavigator when in Breadcrumbs mode.

That's the point of breadcrumb - to allow single click to navigate.

The current implementation uses the tiny arrow to trigger the "change directory" drop down menu while clicking the text part will trigger the edit mode. My question was targeted to whether this should be kept, or if the trigger for the dropdown would be widened to include the text part as well.

Fri, Nov 22, 7:14 AM · Breeze, VDG

Thu, Nov 21

ndavis added a comment to D25334: Added transparent blue background to tabbars.

Here's the fixed file:


Unfortunately, it still doesn't look right.

Thu, Nov 21, 9:10 PM · Frameworks
ndavis added inline comments to D25334: Added transparent blue background to tabbars.
Thu, Nov 21, 8:57 PM · Frameworks
ndavis added inline comments to D25334: Added transparent blue background to tabbars.
Thu, Nov 21, 8:56 PM · Frameworks
ndavis added a comment to D25334: Added transparent blue background to tabbars.

Are you talking about the effect itself in terms of its background color, or how it fits in the space available when displayed by widgets? The latter will require many complicated changes in various places to fix, but can't the former be fixed in this patch?

Thu, Nov 21, 8:50 PM · Frameworks
ndavis added a comment to D25334: Added transparent blue background to tabbars.

Honestly I think this is fine to land now. We can incrementally improve things with patches to individual widgets, but for the most part I think this is a big improvement already.

Thu, Nov 21, 8:21 PM · Frameworks
ndavis requested changes to D25381: Make QPushButton/QToolButton the same height as QLineEdit.

This is what happens when icon size is set to 32px or more (48px here):


size.setHeight(toolButtonOption->fontMetrics.height()); doesn't take icon size into account.
Also, still -1 to making flat buttons and non-flat buttons the same size at the same icon sizes in this patch. That change has potential consequences that can reach much farther than the button vs line edit height inconsistency that originally needed to be solved.

Thu, Nov 21, 11:33 AM · Plasma