ndavis (Noah Davis)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Sep 6 2017, 10:33 AM (109 w, 4 d)
Availability
Available

Recent Activity

Today

ndavis updated the test plan for D24625: Fill middle mouse button area.
Mon, Oct 14, 8:18 AM · Frameworks
ndavis requested review of D24625: Fill middle mouse button area.
Mon, Oct 14, 8:15 AM · Frameworks
ndavis accepted D24612: Use the text rather than highlight color for rating/star emblem.

This icon never needed to be blue. I think I just kept it blue because that's what it was originally.

Mon, Oct 14, 6:35 AM · Frameworks
ndavis accepted D24613: Use a lighter star color for non-default devices.
Mon, Oct 14, 6:29 AM · Plasma
ndavis added a comment to D24621: [RFC] New Konsole and Yakuake icons.

The Yakuake icon is a major improvement. The little angled rectangle making the prompt arrow look like a Y is a little distracting, but also kind of charming and helps to distinguish it from Konsole. I kind of still prefer the plainer ">_" version though.

Mon, Oct 14, 5:16 AM · Frameworks
ndavis added a comment to D24537: Icons for windy weather.

I think cyan is an appropriate choice considering that people tend to associate air with shades of blue, even if air is transparent and that's just the colour of the sky. The shade could be changed if necessary, but I personally think it looks fine.

Mon, Oct 14, 3:47 AM · Frameworks

Yesterday

ndavis added a comment to T10997: Improve check box design.
In T10997#203339, @mglb wrote:

Which ones? I know only check mark icon (no size related problem, as the mark is smaller) and emblem-checked (they come in 8, 16, 22 px, and dont look exactly as checkboxes in the style)

Sun, Oct 13, 4:49 PM · VDG, Breeze
ndavis added a comment to D24602: New design for extended search options.

Why do the comboboxes look so thin in the video?

Sun, Oct 13, 6:13 AM · Dolphin

Fri, Oct 11

ndavis added a comment to D24537: Icons for windy weather.

BTW, when it come to weather status icon, I dream of the possibility to simply compose the current status from base elements, instead of having pre-rendered icons.

So there would be iconic elements for "cloud", "rain cloud", "snow cloud" etc. as well as "sun" & "moon" (later could be even rendered to match moon phase). And those would be composed on drawing :)

Fri, Oct 11, 9:38 PM · Frameworks
ndavis accepted D24555: Add draw-arrow icons.

The design is based on draw-line with an arrowhead.

Fri, Oct 11, 6:16 PM · Frameworks
ndavis requested changes to D24537: Icons for windy weather.
Fri, Oct 11, 8:21 AM · Frameworks
ndavis added a comment to D24537: Icons for windy weather.

That cyan looks odd. It sticks out way too much and AFAIK, it isn't commonly used to represent wind. Gray on more gray is going to be tricky as well though, especially when you've got partly cloudy vs cloudy. What if the wind was a bit more monochromatic? Wind is invisible, so it only really has shapes that are associated with how it moves around objects to represent it. Perhaps we can use darker colors for lighter backgrounds and lighter colors for darker backgrounds then?

Fri, Oct 11, 8:21 AM · Frameworks

Thu, Oct 10

ndavis added a comment to D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer.
Thu, Oct 10, 7:24 AM · Frameworks
ndavis added a comment to D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer.
Thu, Oct 10, 7:18 AM · Frameworks
ndavis added a comment to D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation.

Thanks

Thu, Oct 10, 2:07 AM · Frameworks
ndavis committed R266:7fea43c57c59: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation (authored by ndavis).
Add PATH/LD_LIBRARY_PATH to qrcAlias invocation
Thu, Oct 10, 2:06 AM
ndavis closed D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation.
Thu, Oct 10, 2:06 AM · Frameworks
ndavis retitled D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation from [PATCH] Add PATH/LD_LIBRARY_PATH to qrcAlias invocation to Add PATH/LD_LIBRARY_PATH to qrcAlias invocation.
Thu, Oct 10, 2:05 AM · Frameworks
ndavis accepted D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation.
Thu, Oct 10, 2:05 AM · Frameworks

Tue, Oct 8

ndavis accepted D24493: Add draw-highlight action icons.
Tue, Oct 8, 8:36 PM · Frameworks

Sun, Oct 6

ndavis accepted D24436: Add applications-network icon for renaming Internet category to Network.

Eh, it doesn't bother me that much. If you think this is the right thing to do, go ahead.

Sun, Oct 6, 9:17 PM · Frameworks
ndavis added a comment to D24436: Add applications-network icon for renaming Internet category to Network.

If we're just renaming the category, we don't need to also rename the icon in this case. It would break compatibility with 3rd party icon themes and the only upside is a semantically better name.

Sun, Oct 6, 4:22 PM · Frameworks

Sat, Oct 5

ndavis accepted D24412: Add edit-line-width icons.
Sat, Oct 5, 7:54 PM · Frameworks

Fri, Oct 4

ndavis added inline comments to D24415: Add standard icons to support to all entries in QDialogButtonBox.
Fri, Oct 4, 11:17 PM · Frameworks
ndavis added a comment to D24412: Add edit-line-width icons.

I think something similar to this line width icon would work well:


Inkscape uses a similar icon, but for all line styles:

Fri, Oct 4, 6:37 PM · Frameworks
ndavis added a comment to D24318: Make 32px document-save icon colorful.

How about this?


Should the metal tab on the top cast a shadow this long? It looks strange to me.

The tab is normally perfectly flush with the non-indented region of the cover (picture).

Fri, Oct 4, 3:59 PM · Frameworks
ndavis added a comment to D24318: Make 32px document-save icon colorful.

@ndavis You wanna just submit a patch with that and I'll abandon this?

Fri, Oct 4, 3:58 PM · Frameworks
ndavis added a comment to D24318: Make 32px document-save icon colorful.

How about this?


Fri, Oct 4, 7:28 AM · Frameworks

Thu, Oct 3

ndavis added a comment to D24276: Add text to speech functionality to klipper..

This seems like a good idea to me

Thu, Oct 3, 5:45 PM · Plasma
ndavis committed R206:a4d8546a23a0: Show the correct delete icons in/out of the trash (authored by ndavis).
Show the correct delete icons in/out of the trash
Thu, Oct 3, 4:30 PM
ndavis closed D24377: Show the correct delete icons in/out of the trash.
Thu, Oct 3, 4:30 PM · KDE PIM
ndavis added a reviewer for D24377: Show the correct delete icons in/out of the trash: KDE PIM: KMail.
Thu, Oct 3, 6:22 AM · KDE PIM
ndavis requested review of D24377: Show the correct delete icons in/out of the trash.
Thu, Oct 3, 6:17 AM · KDE PIM
ndavis accepted D24371: [KCM] Make the warning message wider.
Thu, Oct 3, 6:02 AM · Plasma
ndavis accepted D24370: [KCM] Display scale factor as a percentage, not a decimal.

+1. I find this a bit easier on the eyes.

Thu, Oct 3, 6:00 AM · Plasma
ndavis added a comment to D24324: [GTK2] Add program to libexec for GTK2 recoloration.

I'm not sure how to verify if the assets have been generated correctly. What GTK2 programs did you test with?

Look for a theme in ~/.local/share/themes called Breeze 🎨. The reason why it has a 🎨 is to distinguish it from the system Breeze GTK2 theme. Otherwise,
there'd be two Breeze entries listed in the user's GTK2 theme list in syse5. Yes, it's clunky, but this is a toolkit older than me, so clunkiness is expected.

I would probably add a "if the user has GTK2 theme set to Breeze/Breeze Dark change the GTK2 theme to the recoloured one" but I'm not sure
what direction GTK configuration is heading with that configuration daemon being worked on, so I'd rather not mess with GTK configuration until that's ironed out.

Thu, Oct 3, 3:06 AM · Plasma
ndavis added a comment to D24324: [GTK2] Add program to libexec for GTK2 recoloration.

I'm not sure how to verify if the assets have been generated correctly. What GTK2 programs did you test with?

Thu, Oct 3, 1:24 AM · Plasma

Wed, Oct 2

ndavis added a comment to T10997: Improve check box design.
In T10997#203309, @mglb wrote:

they have a visible area of 20px vs 16px for the older version.

Yes. Labels have similar height (with default font size), so UIs won't grow much (if at all) and distances between checkboxes/radios are now similar to distances between other controls.

Wed, Oct 2, 3:55 AM · VDG, Breeze
ndavis accepted D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox.

Visually, this looks fine. I'll leave the technical review to those who know more about that.

Wed, Oct 2, 2:22 AM · Plasma

Tue, Oct 1

ndavis committed R266:e0ef6b7ed41a: Make 22px squiggle more like 16px squiggle (authored by ndavis).
Make 22px squiggle more like 16px squiggle
Tue, Oct 1, 5:23 PM
ndavis closed D24253: Make 22px squiggle more like 16px squiggle.
Tue, Oct 1, 5:22 PM · Frameworks

Mon, Sep 30

ndavis added a comment to T11805: SimpleScreenRecorder Breeze icon.

This should be a Bugzilla ticket in Breeze | Icons. Thanks!

Also, maybe you'd like to try your hand at it and submit the new icon? :)

I was trying to make an icon, but it wasn't pretty.

Mon, Sep 30, 8:55 PM · VDG
ndavis added a comment to D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox.

And the custom scale factor dialog really should have some warning text like on Windows ;=)

see e.g.

https://www.pcworld.com/article/2953978/use-windows-10s-individual-display-scaling-to-perfect-your-multi-monitor-setup.html

(custom scale factor not recommended)

Mon, Sep 30, 8:43 PM · Plasma
ndavis added a comment to D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox.
Mon, Sep 30, 8:35 PM · Plasma
ndavis added a comment to D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox.

what would be wrong with replacing the label with the spinbox? For normal control, use the slider. For fine control, use the spinbox. Then we wouldn't need an extra dialog.

Mon, Sep 30, 8:30 PM · Plasma
ndavis requested changes to D24318: Make 32px document-save icon colorful.
  • I think this doesn't look enough like the monochrome versions and it looks too much like the KFloppy icon.
    • Make the label area more similar to the monochrome icons.
    • Maybe choose a darker set of grays. These are based on the current Breeze colors. You might already know, but avoid going too close to #fcfcfc, #eff0f1, #31363b and #232629.
  • Margins need to be 2px, not 4px. 4px was for monochrome 32px.
  • The corners of the hole in the metal slide don't quite reach the nearest grid snapping points.
Mon, Sep 30, 8:18 PM · Frameworks
ndavis accepted D24314: Improve KFloppy icon.

LGTM

Mon, Sep 30, 5:39 PM · Frameworks
ndavis added a comment to T10997: Improve check box design.

This looks really nice. Do you think you could reverse the animation when unchecking? I think it might be a good idea to speed up the animation a bit too.

Mon, Sep 30, 3:48 AM · VDG, Breeze

Sat, Sep 28

ndavis added a comment to T8749: Handles, more options buttons and right click menu.

about the draggable hand: can people actually guess what the button does? Maybe we should us an arrow next to the 3 vertical dots instead of another dot?

Sat, Sep 28, 6:28 PM · VDG, KDE Human Interface Guidelines
ndavis added a comment to D24273: Use colorful icon for "Profiles" in settings window sidebar.

maybe instead of the users icon, use preferences-system-profiles? it would fallback to preferences-system until the icon is created.

Sat, Sep 28, 5:56 PM · Konsole

Fri, Sep 27

ndavis added a comment to D24273: Use colorful icon for "Profiles" in settings window sidebar.

the users icon doesn't seem quite right

Fri, Sep 27, 9:00 PM · Konsole
ndavis added a comment to T2027: VDG: Add high contrast cursor theme.

I still would like to know what a high contrast cursor theme looks like, and how our current theme fails to be it. :)

Fri, Sep 27, 8:47 PM · Plasma, VDG
ndavis accepted D24272: Use non-pixmap colorful icons from the icon theme in settings window's sidebar.
Fri, Sep 27, 8:35 PM
ndavis added a comment to T10578: Figma KDE UI (VDGMockupToolkit-V4).

If the proposal is to use Figma for mockups, I'd have to -1 that. Figma is a proprietary online service that we can't control and the free tier is far too limited for a project of our scope.

Fri, Sep 27, 6:37 PM · VDG
ndavis added a comment to D24253: Make 22px squiggle more like 16px squiggle.

Visually I think this is fine and a good improvement.

I wonder why your SVGs have two seperate paths as opposed to unifying them into one path (as I usually do)? Just curious if there is any benefit to using one approach above the other.
Also, judging by the MDN Page I don't think the fill-rule="evenodd" does anything here.

Fri, Sep 27, 3:01 PM · Frameworks
ndavis added a comment to M156: Dolphin.

@voidfragment,
Yes, but what is the logical connection between a filter and an address bar? If you wanted to combine something with the address bar, search would make more sense because web browsers already do that.

Fri, Sep 27, 1:27 PM
ndavis added a comment to M156: Dolphin.

@voidfragment why would we do that though? An address bar has nothing to do with searching or filtering.

Fri, Sep 27, 5:09 AM
ndavis added a comment to T11153: Unify sidebar appearance.

@niccolove KSysGuard has tabs because you can add and edit as many views as you want.

Fri, Sep 27, 5:05 AM · Goal: Consistency, VDG, Breeze

Thu, Sep 26

ndavis updated the test plan for D24253: Make 22px squiggle more like 16px squiggle.
Thu, Sep 26, 9:31 PM · Frameworks
ndavis updated the test plan for D24253: Make 22px squiggle more like 16px squiggle.
Thu, Sep 26, 9:30 PM · Frameworks
ndavis requested review of D24253: Make 22px squiggle more like 16px squiggle.
Thu, Sep 26, 9:27 PM · Frameworks
ndavis committed R94:4e6e5b3db8f3: Make *DefaultMessageColor use semantically correct colorscheme colors (authored by ndavis).
Make *DefaultMessageColor use semantically correct colorscheme colors
Thu, Sep 26, 8:44 PM
ndavis closed D24230: Make *DefaultMessageColor use semantically correct colorscheme colors.
Thu, Sep 26, 8:44 PM · VDG, KDE PIM
ndavis added a comment to T11661: Replace framed views with single-pixel separator lines.

How much of this is up to breeze and how much is up to the application? This looks pretty, but if too much of it depends on breeze, it may fall apart when 3rd party apps are thrown into the mix.

Thu, Sep 26, 7:38 AM · Goal: Consistency, Breeze, VDG

Wed, Sep 25

ndavis added a comment to D24230: Make *DefaultMessageColor use semantically correct colorscheme colors.

Please show a screenshot about before/after as it was changed because it was too difficult to important message.

Wed, Sep 25, 7:31 PM · VDG, KDE PIM
ndavis updated the test plan for D24230: Make *DefaultMessageColor use semantically correct colorscheme colors.
Wed, Sep 25, 7:28 PM · VDG, KDE PIM
ndavis updated the test plan for D24230: Make *DefaultMessageColor use semantically correct colorscheme colors.
Wed, Sep 25, 7:27 PM · VDG, KDE PIM
ndavis added a project to D24230: Make *DefaultMessageColor use semantically correct colorscheme colors: VDG.
Wed, Sep 25, 5:21 PM · VDG, KDE PIM
ndavis added a reviewer for D24230: Make *DefaultMessageColor use semantically correct colorscheme colors: KDE PIM: KMail.
Wed, Sep 25, 4:32 PM · VDG, KDE PIM
ndavis requested review of D24230: Make *DefaultMessageColor use semantically correct colorscheme colors.
Wed, Sep 25, 4:30 PM · VDG, KDE PIM
ndavis added a comment to D24185: Add format-text-underline-squiggle actions icons.

16px

Wed, Sep 25, 2:43 AM · Frameworks
ndavis added a comment to D24185: Add format-text-underline-squiggle actions icons.


Wed, Sep 25, 2:36 AM · Frameworks
ndavis added a comment to D24185: Add format-text-underline-squiggle actions icons.
Wed, Sep 25, 2:17 AM · Frameworks
ndavis added a comment to D24185: Add format-text-underline-squiggle actions icons.
Wed, Sep 25, 2:16 AM · Frameworks
ndavis added a comment to D24185: Add format-text-underline-squiggle actions icons.

I have some improvement to the squiggle, but unfortunately, I have no internet in my house except on my phone until the 27th.

Wed, Sep 25, 1:11 AM · Frameworks

Mon, Sep 23

ndavis added a comment to D24127: Fix toggle button colours.

@cblack if we're going to use this patch to do that, then the same treatment needs to be done for other buttonlike controls like comboboxes (with and without text entry), font buttons, file picker buttons, etc. Also I feel like maybe the border thickness of the highlight could stand to be increased so it's more visible.

@ndavis, if we're going to do this, can you make the same change in Breeze itself so the themes are consistent?

Mon, Sep 23, 11:02 PM · Plasma

Sun, Sep 22

ndavis added a watcher for Plasma Accessibility: ndavis.
Sun, Sep 22, 8:11 PM
ndavis added a comment to D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size".

Is there any way we can preserve the original goal of using a monochrome icon here for small sizes?

Sun, Sep 22, 6:48 PM · Plasma
ndavis added a comment to D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size".

Those are in the System Tray, which always shows monochrome icons. Show Desktop is a standalone widget, which has logic to switch its icon between monochrome and colorful icons depending on the size of the container that the icon is inside.

Sun, Sep 22, 6:29 PM · Plasma
ndavis added a comment to D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size".

Is there any way we can preserve the original goal of using a monochrome icon here for small sizes?

Yes, it is already done. Lower the panel icon size to 16 or 22 px.

That doesn't help the huge fraction of people who never touch the default settings though. What's especially silly IMO is that the default panel height is 36px, at which size everything with a colorful icon version gets the colorful version... but if you reduce the panel height just one tick to 34px, the icons get smaller and everything becomes monochrome and it all looks great.

I feel like we should either slightly reduce the default height of the panel to 34px, or change its icon sizing logic so that the threshold for everything turning colorful happens at some size that's greater than 36px.

Why the Notifications, Volume, Network, etc. icons are monochrome, but "Show desktop" and "Minimize all" icons is hard to make a monochrome?
Colored icon of "Show desktop" and "Minimize all" is bigger that other monochrome icons.

Sun, Sep 22, 6:27 PM · Plasma
ndavis added a comment to D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size".

I really don't like that in the Plasma 5.17 Beta you returned a colored icon, when in Plasma 5.16 you added a monochrome icon i was glad. I don't like this regression. We need to talk with Goal: Consistency and VDG about how to return and make a monochrome icon better.

Sun, Sep 22, 6:00 PM · Plasma
ndavis added a comment to D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size".

Is there any way we can preserve the original goal of using a monochrome icon here for small sizes?

Sun, Sep 22, 5:13 PM · Plasma
ndavis added a comment to D24127: Fix toggle button colours.

@cblack Can you change the focus state to only have a blue outline? This behavior is really confusing, even though it seems consistent with Breeze: -snip-

I'd rather not diverge from the Breeze here for a few reasons:

  • I don't have a guarantee that Breeze is going to have the exact same change
  • Breeze GTK is supposed to look like the current state of Breeze, with adaptations where necessary due to differences between GTK and Qt

    If Breeze gets the change, I'll add it.
Sun, Sep 22, 5:59 AM · Plasma

Sat, Sep 21

ndavis added a subtask for T11316: Systematic KCM reorganisation: Workspace section: T11730: Move desktop effects out of the Desktop Effects KCM and into KCMs related to their functions.
Sat, Sep 21, 7:44 AM · Plasma, VDG
ndavis added a parent task for T11730: Move desktop effects out of the Desktop Effects KCM and into KCMs related to their functions: T11316: Systematic KCM reorganisation: Workspace section.
Sat, Sep 21, 7:44 AM · Plasma, VDG
ndavis edited projects for T11730: Move desktop effects out of the Desktop Effects KCM and into KCMs related to their functions, added: Plasma; removed KWin.
Sat, Sep 21, 7:31 AM · Plasma, VDG
ndavis created T11730: Move desktop effects out of the Desktop Effects KCM and into KCMs related to their functions.
Sat, Sep 21, 7:30 AM · Plasma, VDG
ndavis added a comment to D24127: Fix toggle button colours.

This behavior is really confusing, even though it seems consistent with Breeze

I really dislike this about Breeze itself and would welcome a fix there too. Then maybe we can make the default button actually be blue, rather than an almost-indistinguishable shade of gray (See https://bugs.kde.org/show_bug.cgi?id=386158).

Sat, Sep 21, 2:01 AM · Plasma
ndavis added a comment to D24127: Fix toggle button colours.

In the beginning of the video where it looks like I'm just hovering, I'm actually clicking once a second.

Sat, Sep 21, 1:57 AM · Plasma
ndavis requested changes to D24127: Fix toggle button colours.
Sat, Sep 21, 1:56 AM · Plasma
ndavis added a comment to D24127: Fix toggle button colours.

@cblack Can you change the focus state to only have a blue outline? This behavior is really confusing, even though it seems consistent with Breeze:

Sat, Sep 21, 1:56 AM · Plasma
ndavis added a comment to D24127: Fix toggle button colours.

Ah, I only tested Breeze Dark, which uses the same white text color for everything.

Sat, Sep 21, 1:52 AM · Plasma
ndavis accepted D24127: Fix toggle button colours.
Sat, Sep 21, 1:51 AM · Plasma
ndavis added a comment to D12992: New elisa icon.

icons/apps/22/elisa.svg does not apply cleanly. Not sure why.

Sat, Sep 21, 1:44 AM · Frameworks, Elisa
ndavis added a comment to D24125: [GTK3] Scrollbars now have proper states.

Sliders look fixed, but the scrollbar still isn't right. The scrollbar should have the same groove color as the sliders.

Sat, Sep 21, 1:34 AM · Plasma
ndavis added a comment to D24125: [GTK3] Scrollbars now have proper states.

Nothing changed

Sat, Sep 21, 1:19 AM · Plasma
ndavis accepted D24126: [GTK3] CSD windows show handles on .solid-csd.
Sat, Sep 21, 1:17 AM · Plasma
ndavis added a comment to D24126: [GTK3] CSD windows show handles on .solid-csd.

Looks fixed on my end

Sat, Sep 21, 1:17 AM · Plasma
ndavis added a comment to D24125: [GTK3] Scrollbars now have proper states.

I think the alpha levels need to be swapped.

Sat, Sep 21, 1:13 AM · Plasma
ndavis added a comment to D24125: [GTK3] Scrollbars now have proper states.

The slider backgrounds are too bright on Breeze

Sat, Sep 21, 1:09 AM · Plasma