ndavis (Noah Davis)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Sep 6 2017, 10:33 AM (148 w, 2 d)
Availability
Available

Recent Activity

Mon, Jul 6

ndavis added a comment to T10413: Find a way to specify whether to use monochrome or color icons in applications.

What if we also had another suffix for requesting color icons when a theme defaults to using symbolic icons? I think that unless we have a way to specifically ask for color, we might run into different problems.

Mon, Jul 6, 3:09 PM · Plasma, VDG, Breeze

Sat, Jul 4

ndavis added a comment to T13260: Unify AboutPage behaviour.

Sounds like a good idea.

Sat, Jul 4, 1:06 PM · Goal: Consistency

Thu, Jul 2

ndavis added a comment to T10413: Find a way to specify whether to use monochrome or color icons in applications.

Looks like Marco isn't actually against it.

Thu, Jul 2, 3:46 PM · Plasma, VDG, Breeze

Fri, Jun 26

ndavis updated the task description for T10891: Breeze theme evolution.
Fri, Jun 26, 2:26 PM · Plasma 6, Plasma, VDG, Breeze
ndavis added a comment to T10891: Breeze theme evolution.

I am not sure if this is the correct place to ask this question. Sorry, if it is not. This is unrelated to the theme.

I am foreign to KDE and Plasma but I noticed that in the Plasma settings mockup, the title "Icons" is separate from the content. Why this is the case? Wouldn't it be better if the title and the settings were somehow more together. For instance, the title would be centered too. I don't know but if every other program uses left aligned titles, maybe, this left aligned way is more consistent.

Fri, Jun 26, 2:25 PM · Plasma 6, Plasma, VDG, Breeze

Tue, Jun 23

ndavis added a comment to T10413: Find a way to specify whether to use monochrome or color icons in applications.

Also, do we need to implement this separately for QML apps, Qt Widgets apps and Plasmashell?

Tue, Jun 23, 5:35 PM · Plasma, VDG, Breeze
ndavis added a comment to T10413: Find a way to specify whether to use monochrome or color icons in applications.

:/ I was about to say how glad I was to hear that we have a clear path forward. @mart What didn't you like about it and what would you suggest doing instead?

Tue, Jun 23, 5:35 PM · Plasma, VDG, Breeze

Mon, Jun 22

ndavis claimed T10997: Improve check box design.
Mon, Jun 22, 11:43 PM · VDG, Breeze
ndavis added a comment to T10997: Improve check box design.

alright

Mon, Jun 22, 11:43 PM · VDG, Breeze

Sat, Jun 20

ndavis added a comment to T12789: Unify list icon sizes.

When you have a list of items where some have a subtitle and some do not, maybe all of the list items should have the same height anyway. Lists of items with different heights is really weird looking.

But probably all of them should have a subtitle, or none of them should.

Sat, Jun 20, 7:51 AM · VDG, Goal: Consistency

Wed, Jun 17

ndavis accepted D29154: Use QWindow overload of QIcon::pixmap.

Giving this a +1 just for consistency with the kirigami and plasma-framework changes. I can't really test this since I don't have any screens with different DPIs though.

Wed, Jun 17, 5:45 AM · Plasma

Mon, Jun 15

ndavis added a comment to T12789: Unify list icon sizes.

I like the idea of having a larger icon when there is a subtitle. However when trying to do it for all items with more than one line it leads to a somewhat awkward look with mixed line heights

Mon, Jun 15, 10:10 AM · VDG, Goal: Consistency
ndavis added a comment to T12789: Unify list icon sizes.
  • For 2 lines of text with color icons, use 32px.
  • For 1 line of text with monochrome icons, use 22px.
  • For 1 line of text with a logo, maybe use 32px so that the logo is easier to see?
Mon, Jun 15, 10:09 AM · VDG, Goal: Consistency
ndavis added a comment to T13158: Define a reference appearance and help users have a consistent experience of on-screen object sizes.

@churaev Please don't derail the discussion.

Mon, Jun 15, 6:01 AM · KWin, VDG

Sun, Jun 14

ndavis added a comment to T13158: Define a reference appearance and help users have a consistent experience of on-screen object sizes.

I think I agree with the general idea, but it's a bit hard to fully grasp the scope of what must be done and I'm not sure what our first steps should be.

Sun, Jun 14, 6:09 AM · KWin, VDG

Jun 10 2020

ndavis committed R1014:3cc5ddeef39d: Fix SliderGallery layout (authored by ndavis).
Fix SliderGallery layout
Jun 10 2020, 4:04 AM
ndavis committed R1014:a449b668fb7f: Fix SliderGallery layout (authored by ndavis).
Fix SliderGallery layout
Jun 10 2020, 4:01 AM
ndavis committed R1014:59cdb610860f: Convert SliderGallery to a FormLayout (authored by ndavis).
Convert SliderGallery to a FormLayout
Jun 10 2020, 3:54 AM

Jun 9 2020

ndavis committed R858:c24970122af4: Fix Slider vertical implicitWidth and a binding loop (authored by ndavis).
Fix Slider vertical implicitWidth and a binding loop
Jun 9 2020, 7:50 AM
ndavis committed R858:219650fd515c: Fix Slider vertical implicitWidth and a binding loop (authored by ndavis).
Fix Slider vertical implicitWidth and a binding loop
Jun 9 2020, 5:39 AM
ndavis committed R858:5b890249dede: Fix binding loop in Slider (authored by ndavis).
Fix binding loop in Slider
Jun 9 2020, 12:35 AM

Jun 8 2020

ndavis committed R858:1560f9a992ee: Make ToolTips more consistent with Breeze widget style tooltips (authored by ndavis).
Make ToolTips more consistent with Breeze widget style tooltips
Jun 8 2020, 6:29 PM
ndavis committed R858:147f49df3596: Make ToolTips more consistent with Qt Widgets tooltips (authored by ndavis).
Make ToolTips more consistent with Qt Widgets tooltips
Jun 8 2020, 6:27 PM
ndavis added a comment to D27223: add kirigami-gallery icon.

I think I'd prefer to keep this similar to the original Kirigami icon. Do you mind if I commandeer this? I've already made the changes.

Jun 8 2020, 4:54 PM · Frameworks
ndavis added a comment to D27223: add kirigami-gallery icon.

I noticed that the lighting in this version of the Kirigami is flipped. Is that intentional? I don't think it makes sense for the top of the K popout to be darker than the bottom. Since the light in Breeze icons comes from the top left, the top should be light, like in the original Kirigami icon.

Jun 8 2020, 4:51 PM · Frameworks

Jun 6 2020

ndavis committed R858:ac81ee851961: Add ToolSeparator styling (authored by ndavis).
Add ToolSeparator styling
Jun 6 2020, 5:24 AM

Jun 4 2020

ndavis committed R119:1a1b55498f0c: [Colors KCM] Support Header ColorSet (authored by ndavis).
[Colors KCM] Support Header ColorSet
Jun 4 2020, 4:58 AM
ndavis committed R119:73d04bc06d36: [Colors KCM] Support Header ColorSet (authored by ndavis).
[Colors KCM] Support Header ColorSet
Jun 4 2020, 4:54 AM

Jun 3 2020

ndavis committed R265:b827e0c435ca: [KColorScheme] Remove duplicated code (authored by ndavis).
[KColorScheme] Remove duplicated code
Jun 3 2020, 12:53 AM
ndavis committed R265:38f000f82ee5: [KColorScheme] Remove duplicated code (authored by ndavis).
[KColorScheme] Remove duplicated code
Jun 3 2020, 12:52 AM

Jun 2 2020

ndavis committed R119:96f4ab7f7122: [Colors KCM] Support Header ColorSet (authored by ndavis).
[Colors KCM] Support Header ColorSet
Jun 2 2020, 8:00 AM
ndavis committed R119:ca37548c5d58: [Colors KCM] Support Header ColorSet (authored by ndavis).
[Colors KCM] Support Header ColorSet
Jun 2 2020, 8:00 AM
ndavis abandoned D17253: Fix colors for vector image mimetypes.

will move to invent.kde.org

Jun 2 2020, 2:25 AM · Frameworks
ndavis abandoned D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key.

will move to invent.kde.org

Jun 2 2020, 2:25 AM · Frameworks

Jun 1 2020

merritt awarded T12068: Combine the UIs for Virtual Desktop and Activities a Like token.
Jun 1 2020, 10:02 PM · VDG, Plasma
ndavis committed R1014:78933ad88611: Add header color set support to Colors and ColorSet galleries (authored by ndavis).
Add header color set support to Colors and ColorSet galleries
Jun 1 2020, 6:32 PM
ndavis committed R119:cc28b7fdbd29: [Colors KCM] Support Header ColorSet (authored by ndavis).
[Colors KCM] Support Header ColorSet
Jun 1 2020, 5:23 AM

May 31 2020

ndavis committed R31:c553e431bede: [kstyle] Use Header ColorSet instead of WM group (authored by ndavis).
[kstyle] Use Header ColorSet instead of WM group
May 31 2020, 10:30 PM

May 30 2020

ndavis committed R119:4e3c4552abbd: [Colors KCM] Support Header ColorSet (authored by ndavis).
[Colors KCM] Support Header ColorSet
May 30 2020, 6:16 AM
ndavis committed R31:8ebe7c05e578: [kstyle] Use Header ColorSet instead of WM group (authored by ndavis).
[kstyle] Use Header ColorSet instead of WM group
May 30 2020, 6:09 AM
ndavis committed R119:c5b45936cc99: [Colors KCM] Support Header ColorSet (authored by ndavis).
[Colors KCM] Support Header ColorSet
May 30 2020, 6:03 AM

May 29 2020

ndavis committed R119:fff032a952d0: [Colors KCM] Use Header ColorSet instead of WM group (authored by ndavis).
[Colors KCM] Use Header ColorSet instead of WM group
May 29 2020, 10:01 PM

May 28 2020

ndavis committed R265:d82db2903eb0: Make Header backwards compatible with titlebar colors (authored by ndavis).
Make Header backwards compatible with titlebar colors
May 28 2020, 1:45 PM
ndavis committed R265:fbbaf58a1320: Make Header backwards compatible with titlebar colors (authored by ndavis).
Make Header backwards compatible with titlebar colors
May 28 2020, 1:41 PM

May 27 2020

ndavis committed R265:7412efd39471: Make Header backwards compatible with titlebar colors (authored by ndavis).
Make Header backwards compatible with titlebar colors
May 27 2020, 9:22 PM
ndavis committed R265:5b371115f994: Make Header colors fallback to Window colors first (authored by ndavis).
Make Header colors fallback to Window colors first
May 27 2020, 2:52 PM
ndavis committed R119:3b5a1d7ecbc6: [Colors KCM] Use Colors:Header instead of WM group (authored by ndavis).
[Colors KCM] Use Colors:Header instead of WM group
May 27 2020, 2:26 PM
ndavis committed R265:b976d4711fd9: Make Header ColorSet compatible with existing titlebar colors (authored by ndavis).
Make Header ColorSet compatible with existing titlebar colors
May 27 2020, 2:10 PM
ndavis committed R265:cd81b40da1f4: Make Header ColorSet compatible with existing titlebar colors (authored by ndavis).
Make Header ColorSet compatible with existing titlebar colors
May 27 2020, 4:41 AM

May 26 2020

ndavis committed R482:fd3a1eb4d9c1: Revert "Revert "Change MetaModifier to AltModifier"" (authored by ndavis).
Revert "Revert "Change MetaModifier to AltModifier""
May 26 2020, 10:57 PM
ndavis added a reverting change for R482:664cc104fe2b: Revert "Change MetaModifier to AltModifier": R482:fd3a1eb4d9c1: Revert "Revert "Change MetaModifier to AltModifier"".
May 26 2020, 10:57 PM

May 25 2020

ndavis added a comment to D25814: [KColorScheme] Add SeparatorColor.

How would we add the separator role to color scheme files if separator color was added to upstream Qt? Wouldn't we still need to add a separator role to KColorScheme so that we could map the color in the color scheme file to the equivalent QPalette ColorRole?

May 25 2020, 9:20 PM · Frameworks
ndavis committed R134:d6c03c4ec3b4: Replace flatpak icon with monochrome version (authored by ndavis).
Replace flatpak icon with monochrome version
May 25 2020, 5:45 PM

May 24 2020

ndavis committed R482:65613ff92b6c: Revert "Revert "Change MetaModifier to AltModifier"" (authored by ndavis).
Revert "Revert "Change MetaModifier to AltModifier""
May 24 2020, 9:57 PM
ndavis added a reverting change for R482:664cc104fe2b: Revert "Change MetaModifier to AltModifier": R482:65613ff92b6c: Revert "Revert "Change MetaModifier to AltModifier"".
May 24 2020, 9:57 PM

May 23 2020

ndavis committed R482:4d4898c8c93a: Change MetaModifier to AltModifier (authored by ndavis).
Change MetaModifier to AltModifier
May 23 2020, 5:15 AM
ndavis committed R482:57a496778653: Change MetaModifier to AltModifier (authored by ndavis).
Change MetaModifier to AltModifier
May 23 2020, 5:08 AM
ndavis committed R108:f474686a584a: Change CommandAllKey to Meta (authored by ndavis).
Change CommandAllKey to Meta
May 23 2020, 2:40 AM

May 22 2020

ndavis committed R108:e923e81656ea: Change CommandAllKey to Meta (authored by ndavis).
Change CommandAllKey to Meta
May 22 2020, 10:47 PM
ndavis committed R108:72eb319da2a8: update comments and documentation (authored by ndavis).
update comments and documentation
May 22 2020, 10:47 PM
ndavis added a comment to D29477: Change CommandAllKey to Meta.

Resuming this on invent

link ?

May 22 2020, 10:29 PM · KWin
ndavis committed R108:52a1ea9b9825: Change CommandAllKey to Meta (authored by ndavis).
Change CommandAllKey to Meta
May 22 2020, 3:53 PM

May 21 2020

ndavis committed R108:57723b7de982: Change CommandAllKey to Meta (authored by ndavis).
Change CommandAllKey to Meta
May 21 2020, 10:44 AM

May 20 2020

ndavis committed R108:23913586ee15: Change CommandAllKey to Meta (authored by ndavis).
Change CommandAllKey to Meta
May 20 2020, 10:49 PM
ndavis abandoned D25351: [Style KCM] Change name to KDE/Qt Application Style.
May 20 2020, 10:46 PM · Plasma
ndavis committed R31:eeaad95cf30c: fix complementary breeze light link color (authored by ndavis).
fix complementary breeze light link color
May 20 2020, 9:10 PM
ndavis committed R31:e8ae9b0f7ded: Change button alt backgrounds (authored by ndavis).
Change button alt backgrounds
May 20 2020, 3:00 PM
ndavis accepted D29263: Position OSD a bit farther down.
May 20 2020, 2:43 PM · KWin
ndavis committed R31:540e6ed9c7b3: Change breeze light link color (authored by ndavis).
Change breeze light link color
May 20 2020, 2:35 PM
ndavis accepted D29232: Introduce the Header color set.
May 20 2020, 2:20 PM · Frameworks
ndavis added a comment to D29232: Introduce the Header color set.

Suggested colors are based on https://invent.kde.org/plasma/breeze/-/merge_requests/2

May 20 2020, 1:33 PM · Frameworks
ndavis added a comment to T13156: Better support for ultra-wide screens.

Is there a way to set the default panel based on info about the user's screen?

May 20 2020, 12:26 PM · VDG
ndavis added a comment to D27669: [kstyle] Tools area.

The line seems to stop just short of the sidebar:

May 20 2020, 4:11 AM · Plasma
ndavis added a comment to D27669: [kstyle] Tools area.

what are some ways the issue of toolbar colors not being perfectly in sync with titlebar colors could be fixed or worked around?

May 20 2020, 4:07 AM · Plasma

May 19 2020

ndavis committed R31:e6905b2c378b: Add Breeze.colors back and fix BreezeLight names (authored by ndavis).
Add Breeze.colors back and fix BreezeLight names
May 19 2020, 10:52 PM
ndavis committed R31:60c805a195ba: Cmake fix (authored by ndavis).
Cmake fix
May 19 2020, 10:52 PM
ndavis committed R31:f32a7facc348: Change color schemes for tools area/Breeze evolution (authored by ndavis).
Change color schemes for tools area/Breeze evolution
May 19 2020, 10:52 PM
ndavis committed R31:8632718b959a: change light theme hover colors (authored by ndavis).
change light theme hover colors
May 19 2020, 10:52 PM
ndavis committed R31:f1145515f8ca: [kstyle] Increase tab height to 30px (authored by ndavis).
[kstyle] Increase tab height to 30px
May 19 2020, 10:46 PM
ndavis committed R31:ec278b19ea49: Cmake fix (authored by ndavis).
Cmake fix
May 19 2020, 9:44 PM
ndavis committed R31:0eb89632a34b: Add Breeze.colors back and fix BreezeLight names (authored by ndavis).
Add Breeze.colors back and fix BreezeLight names
May 19 2020, 9:38 PM
ndavis committed R31:cee8bd2c3f22: change light theme hover colors (authored by ndavis).
change light theme hover colors
May 19 2020, 9:34 PM
ndavis committed R31:054cf779f427: Change color schemes for tools area/Breeze evolution (authored by ndavis).
Change color schemes for tools area/Breeze evolution
May 19 2020, 9:34 PM
ndavis committed R31:dcbc65e02b92: change light theme hover colors (authored by ndavis).
change light theme hover colors
May 19 2020, 9:31 PM
ndavis committed R31:35364f1e04c0: Change color schemes for tools area/Breeze evolution (authored by ndavis).
Change color schemes for tools area/Breeze evolution
May 19 2020, 9:31 PM
ndavis requested changes to D29263: Position OSD a bit farther down.
May 19 2020, 9:06 PM · KWin
ndavis added a comment to D29263: Position OSD a bit farther down.

It might be best not to change anything about the position until we can come up with a significantly better solution.

May 19 2020, 8:57 PM · KWin
ndavis added a comment to D29263: Position OSD a bit farther down.

In the absence of a way for the Global Theme or (proposed-but-not-yet-existing OSD themes) to set a custom OSD position, are KWin people okay with this patch to improve the positioning of the new OSD?

May 19 2020, 8:52 PM · KWin
ndavis committed R266:305a7e5f3110: Change mouse icon to have better dark theme contrast (authored by ndavis).
Change mouse icon to have better dark theme contrast
May 19 2020, 7:55 PM
ndavis closed D29095: Change mouse icon to have better dark theme contrast.
May 19 2020, 7:55 PM · Frameworks
ndavis abandoned D24975: Change some 32px action icons to color style.

Saving this for later on invent.

May 19 2020, 7:53 PM · Frameworks
ndavis abandoned D29477: Change CommandAllKey to Meta.

Resuming this on invent

May 19 2020, 7:52 PM · KWin
ndavis abandoned D25814: [KColorScheme] Add SeparatorColor.

Abandoning this since others would rather have this in QPalette

May 19 2020, 7:52 PM · Frameworks
ndavis abandoned D29439: [RFC] Adjust color schemes for tools area/Breeze evolution.

Resuming this on invent

May 19 2020, 7:51 PM · Plasma
ndavis abandoned D27874: Disable the audio stream indicator for IOTM by default.

Abandoning this since nobody wanted it.

May 19 2020, 7:51 PM · Plasma
ndavis abandoned D24706: [RFC] Change button style.

Resuming this on invent

May 19 2020, 7:50 PM · Breeze, VDG, Plasma
ndavis added inline comments to D29263: Position OSD a bit farther down.
May 19 2020, 6:57 PM · KWin
ndavis accepted D29263: Position OSD a bit farther down.
May 19 2020, 6:55 PM · KWin
ndavis accepted D20569: Use more compact OSD.

I have no problem with this.

May 19 2020, 6:31 PM · Plasma
ndavis added a comment to D29263: Position OSD a bit farther down.

I'm feeling pretty lukewarm about this idea. It's maybe slightly better in some situations, but with the smaller size, I think it'll also be easier to miss if it's not in the center. Since the OSD is smaller, being exactly in the center isn't such a huge problem either. Although, I suppose it would still get in the way of crosshairs if the user was playing a shooter game.

May 19 2020, 6:27 PM · KWin