ndavis (Noah Davis)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Sep 6 2017, 10:33 AM (66 w, 2 d)
Availability
Available

Recent Activity

Yesterday

ndavis accepted D17393: [Folder View] make file context menu consistent with Dolphin's.
Fri, Dec 14, 8:04 PM · Plasma
ndavis added a comment to D17393: [Folder View] make file context menu consistent with Dolphin's.

+1 to making the menus the same.

Fri, Dec 14, 5:02 PM · Plasma

Thu, Dec 13

ndavis committed R266:50077910f783: Change network/web color icons to consistent style (authored by ndavis).
Change network/web color icons to consistent style
Thu, Dec 13, 4:16 PM
ndavis closed D17496: Change network/web color icons to consistent style.
Thu, Dec 13, 4:16 PM · Frameworks
ndavis updated the diff for D17496: Change network/web color icons to consistent style.

Re-add applications-internet symlink to preferences/32

Thu, Dec 13, 9:07 AM · Frameworks
ndavis committed R242:2f99869c1071: Add preferences-system-bluetooth-battery to preferences.svgz (authored by ndavis).
Add preferences-system-bluetooth-battery to preferences.svgz
Thu, Dec 13, 7:18 AM
ndavis closed D17505: Add preferences-system-bluetooth-battery to preferences.svgz.
Thu, Dec 13, 7:18 AM · Frameworks

Wed, Dec 12

ndavis added a comment to D17496: Change network/web color icons to consistent style.

I did notice that symlinks for applications-internet exist in apps/16 and apps/22, so maybe there needs to be a scalable version in the same category? There was no apps/48/applications-internet, but there was a preferences/32/applications-internet. I removed that because it seemed redundant and out of place. Are applications able to specify which Context an icon they want to use comes from?

Wed, Dec 12, 9:30 AM · Frameworks
ndavis added a comment to D17496: Change network/web color icons to consistent style.

Looks good visually, but the scalable test now fails:

$ grep -A 1 FAIL.*scalable Testing/Temporary/LastTest.log 
FAIL!  : ScalableTest::test_scalable(icons:Applications) The following icons are not available in a scalable directory:
  applications-internet
--
FAIL!  : ScalableTest::test_scalable(icons-dark:Applications) The following icons are not available in a scalable directory:
  applications-internet
Wed, Dec 12, 9:17 AM · Frameworks

Tue, Dec 11

ndavis added a comment to T7927: Fonts “easy mode”.

In blind listening tests, a common practice is to play 2 files and ask which version the listener preferred. I think that approach could work for this if we only presented 2 options at a time. It would need to go through multiple rounds to get through all of the combinations though, so it would have to be a configuration wizard. Not really an easy mode in the sense that it isn't quick, but it could be useful for helping the user find what they like the most.

Tue, Dec 11, 4:36 PM · VDG, Plasma: KCM Redesign
ndavis added a comment to D17469: applications-games icon for dark theme.

I made a more detailed version, but I'm not sure if it's going overboard.

Tue, Dec 11, 4:11 PM · Frameworks
ndavis added a comment to D17469: applications-games icon for dark theme.

@ndavis To be honest, I liked the shape and composition of the original icon better than your proposed new one. I'm not a huge fan of the flat sides and lack of visual distinction between the body and handles. +1 on removing the superfluous Plasma logo though.

Tue, Dec 11, 3:51 PM · Frameworks
ndavis updated the diff for D17496: Change network/web color icons to consistent style.

Change applications-internet back into a duplicate of preferences-system-network

Tue, Dec 11, 3:19 PM · Frameworks
ndavis added a comment to D17505: Add preferences-system-bluetooth-battery to preferences.svgz.

The stylesheet stuff doesn't work, ie. the icon stays black in Breeze dark.

Tue, Dec 11, 3:16 PM · Frameworks
ndavis updated the diff for D17505: Add preferences-system-bluetooth-battery to preferences.svgz.

Fix stylesheet

Tue, Dec 11, 3:13 PM · Frameworks
ndavis added a reviewer for D17505: Add preferences-system-bluetooth-battery to preferences.svgz: broulik.
Tue, Dec 11, 2:05 PM · Frameworks
ndavis requested review of D17505: Add preferences-system-bluetooth-battery to preferences.svgz.
Tue, Dec 11, 2:04 PM · Frameworks
ndavis updated the test plan for D17496: Change network/web color icons to consistent style.
Tue, Dec 11, 5:54 AM · Frameworks
ndavis requested review of D17496: Change network/web color icons to consistent style.
Tue, Dec 11, 5:36 AM · Frameworks

Mon, Dec 10

ndavis added a comment to D17469: applications-games icon for dark theme.

Here's a rough draft of something similar to the Logitech F 710, but with colors that are more similar to the original gray DualShock controller:

100%

200%

Maybe it is better to remove the dark sides? Only F710 has this design. Most controllers, including PS4 and XBox One, are pure white or black or other colors.

Mon, Dec 10, 3:09 PM · Frameworks
ndavis added a comment to D17469: applications-games icon for dark theme.

This is another example where a subtle outline could help visibility for dark themes, without having to resort to drawing a whole new version of it.

Mon, Dec 10, 3:02 PM · Frameworks
ndavis added a comment to D17346: Support Bluetooth batteries.

Does it have to be in the Plasma theme? I want to move all icons into breeze-icons eventually.

Mon, Dec 10, 11:35 AM · Plasma
ndavis added a comment to D17469: applications-games icon for dark theme.

Here's a rough draft of something similar to the Logitech F 710, but with colors that are more similar to the original DualShock controller and white Xbox 360 controller:

Mon, Dec 10, 11:29 AM · Frameworks
ndavis added a comment to D17419: Add view-private icon.
Mon, Dec 10, 11:28 AM · VDG, Frameworks, Breeze
ndavis added reviewers for D17469: applications-games icon for dark theme: VDG, ndavis.
Mon, Dec 10, 9:39 AM · Frameworks
ndavis added a comment to D17469: applications-games icon for dark theme.

In general, color icons are the same in Breeze and Breeze Dark while monochrome icons change their primary color. I think the light and dark versions of this icons should be the same.

Mon, Dec 10, 9:36 AM · Frameworks
ndavis committed R266:eb16fb872125: Add drive-* icons for YaST Partitioner (authored by ndavis).
Add drive-* icons for YaST Partitioner
Mon, Dec 10, 6:34 AM
ndavis closed D17421: Add drive-* icons for YaST Partitioner.
Mon, Dec 10, 6:34 AM · Frameworks
ndavis updated the diff for D17421: Add drive-* icons for YaST Partitioner.

Add drive-multidisk-symbolic and drive-multipartition-symbolic

Mon, Dec 10, 6:32 AM · Frameworks
ndavis updated the diff for D17421: Add drive-* icons for YaST Partitioner.

Remove stray point from 64px drive-multipartition

Mon, Dec 10, 5:32 AM · Frameworks
ndavis updated the test plan for D17421: Add drive-* icons for YaST Partitioner.
Mon, Dec 10, 5:30 AM · Frameworks
ndavis updated the diff for D17421: Add drive-* icons for YaST Partitioner.

Update dark theme

Mon, Dec 10, 5:24 AM · Frameworks
ndavis updated the diff for D17421: Add drive-* icons for YaST Partitioner.

Change monochrome drive-multipartition style and add color version

Mon, Dec 10, 5:22 AM · Frameworks
ndavis added a comment to D17421: Add drive-* icons for YaST Partitioner.

Maybe the problem is with the monochrome version, not the color one. To me, that "half filled balls connected with struts" icon looks like something more related to chemistry than disk management.

Mon, Dec 10, 5:01 AM · Frameworks

Sun, Dec 9

ndavis added a comment to D17421: Add drive-* icons for YaST Partitioner.

For drive-multipartition, maybe a disk with lines that make it look like it's internally divided into four pieces?

Wasn't quite sure how to do that, so I made this:

That looks great!

Sun, Dec 9, 6:25 PM · Frameworks
ndavis accepted D17440: Rotate busy indicator clockwise.
Sun, Dec 9, 1:18 AM · VDG, Breeze, Plasma

Sat, Dec 8

ndavis added a comment to D17419: Add view-private icon.

If view-private-symbolic is just a symlink to the regular icon, do we really need it?

Sat, Dec 8, 9:17 PM · VDG, Frameworks, Breeze
ndavis added a comment to D17440: Rotate busy indicator clockwise.

Makes sense to me. Time moves clockwise on a clock.

Sat, Dec 8, 8:06 PM · VDG, Breeze, Plasma
ndavis accepted D17419: Add view-private icon.

Looks right. I might prefer a wider hat brim or a mask like @filipf suggested, but I'm not going to make that a requirement since it seems more like a matter of taste.

Sat, Dec 8, 8:01 PM · VDG, Frameworks, Breeze
ndavis requested changes to D17419: Add view-private icon.

I noticed that the 24px version is now aligned to the grid, but the margins aren't right. The 16 and 22px versions are still not aligned to the grid.

Sat, Dec 8, 6:09 PM · VDG, Frameworks, Breeze
ndavis added a comment to D17421: Add drive-* icons for YaST Partitioner.

They generally look very good.

I'm wondering if it might be worth it to get rid of those semicircular bumps on the inside for the 16px and maybe even 24px version too. They seem to interfere with any symbol inside the disk at really small sizes.

Sat, Dec 8, 5:20 AM · Frameworks
ndavis added a comment to D17419: Add view-private icon.

I would like if it was more aligned with the grid:

Sat, Dec 8, 3:12 AM · VDG, Frameworks, Breeze
ndavis retitled D17421: Add drive-* icons for YaST Partitioner from Add new drive-* icons to Add drive-* icons for YaST Partitioner.
Sat, Dec 8, 2:50 AM · Frameworks
ndavis updated the summary of D17421: Add drive-* icons for YaST Partitioner.
Sat, Dec 8, 2:48 AM · Frameworks
ndavis updated the summary of D17421: Add drive-* icons for YaST Partitioner.
Sat, Dec 8, 2:47 AM · Frameworks
ndavis updated the test plan for D17421: Add drive-* icons for YaST Partitioner.
Sat, Dec 8, 2:45 AM · Frameworks
ndavis updated the test plan for D17421: Add drive-* icons for YaST Partitioner.
Sat, Dec 8, 2:42 AM · Frameworks
ndavis requested review of D17421: Add drive-* icons for YaST Partitioner.
Sat, Dec 8, 2:28 AM · Frameworks
ndavis added a comment to D17410: Add alternatives button to applet configuration in panel edit mode.

I think we should be using a monochrome icon here. An equivalent monochrome icon would be favorite, but I don't think "favorite" is a good symbol for "alternatives". Maybe preferences-other/application-menu (same icon) would be good? It might be outside the scope of this patch anyway since this means the alternatives icon needs to be changed outside the edit mode as well.

Sat, Dec 8, 1:48 AM · VDG, Plasma
ndavis added a comment to D17310: Improve Kile icon with LaTeX font.

The proposed icons in my dock:

The biggest issue that I have with the square root icon is that it doesn't symbolize enough that it's the icon of an application. To me, it just looks like the application of a file type. Some dynamic element is missing, like a pencil, for example, to indicate that it's an application for editing such files.

I have experimented with adding a black pen to the icon:


Do you think this looks more like an application? It could be added to all of the proposed designs.

Sat, Dec 8, 12:06 AM · Frameworks

Fri, Dec 7

ndavis added a comment to D16694: Improve visibility for Konsole icon when using Breeze Dark.

Why are we using a color icon at such a small size? Wouldn't it make more sense to make a monochrome icon at that size?

Fri, Dec 7, 3:27 PM · Frameworks

Thu, Dec 6

ndavis added a comment to D17310: Improve Kile icon with LaTeX font.

With a small "k" in the equation:

With a capital "K":

What do you think?

Thu, Dec 6, 8:07 PM · Frameworks

Wed, Dec 5

ndavis accepted D17309: Add flashlight action icons.
Wed, Dec 5, 7:11 PM · Frameworks
ndavis added a comment to T10085: Redesign - Refactored Timeline.

I see a problem reappearing with the unlock/lock icons which I fought I had squashed before. The open lock is barely distinguishable on higher resolution screens from the locked one, as there's not enough visual difference. On purpose back then I reworked Kdenlive icons to use the slash when unlocked, as this gives much more visual difference than just a small break in the lock's shackle. So, please keep in mind higher res displays, and make things clearly visually different!

Wed, Dec 5, 2:31 AM · Kdenlive
ndavis added a comment to T10085: Redesign - Refactored Timeline.

In general, monochrome style icons should not be colored (compare action icons to emblem icons). What do you mean by 2 icons for each state and highlighted if active?

In the previous case only the lock icon changes (Opened/Closed). Should the others change as well? See example:

With the recent mute icons changes how can we proceed?

Maintain as the proposal above or we should add color?

Wed, Dec 5, 1:38 AM · Kdenlive

Tue, Dec 4

ndavis added a comment to T10085: Redesign - Refactored Timeline.

The A# and V# leds are very important. They are used to target which tracks you will move the selected clips to from the Project Bin. Here you can find examples of how other programs work: https://www.reddit.com/r/editlines/

Of course our method is simpler...

Tue, Dec 4, 5:06 PM · Kdenlive
ndavis added a comment to T10085: Redesign - Refactored Timeline.

Here's what I've got right now. I thought the A# and V# labels were redundant, so I removed them.

Tue, Dec 4, 3:56 PM · Kdenlive
ndavis added a comment to T10085: Redesign - Refactored Timeline.

More ideas for locked tracks. I cannot see orange working though in this case. What do you think @ndavis?

Tue, Dec 4, 12:09 AM · Kdenlive

Mon, Dec 3

ndavis added a comment to D17310: Improve Kile icon with LaTeX font.

What if instead of using 'a' as a variable in the equation, we used 'k'?

Mon, Dec 3, 10:12 PM · Frameworks
ndavis added a comment to D17309: Add flashlight action icons.

Do you think this style is better (16px versions shown):

Mon, Dec 3, 10:06 PM · Frameworks
ndavis added a comment to D17309: Add flashlight action icons.

Reminds me of these: http://store.t-studious.com/wp-content/uploads/2016/12/Maglite-2D-LED-Torch-.jpg

Mon, Dec 3, 12:38 AM · Frameworks

Sun, Dec 2

ndavis added a comment to D17310: Improve Kile icon with LaTeX font.

The original design was more consistent with the usual style for text characters used in Breeze icons, but I think using actual LaTeX fonts in this context works just as well or better for LaTeX users.

Sun, Dec 2, 7:24 PM · Frameworks

Sat, Dec 1

ndavis accepted D17220: Improve symbolism for off and muted status icon.

I've checked it out and it looks good!

Sat, Dec 1, 9:30 PM · Frameworks
ndavis accepted D15999: Add icons with added background to system.svgz.

Looks like you've addressed all of my concerns, so I'll accept this. @ngraham ?

Sat, Dec 1, 9:25 PM · Frameworks
ndavis added a comment to D15999: Add icons with added background to system.svgz.

Is the home button in go.svgz meant to be partially transparent?

Sat, Dec 1, 8:25 PM · Frameworks
ndavis added a comment to D15999: Add icons with added background to system.svgz.

With colorschemes applied, these will be your colors:

            | Ring    | Background | Symbol  |
            | ------- | ---------- | ------- |
     Breeze | #fcfcfc | #eff0f1    | #232627 |
Breeze Dark | #232629 | #31363b    | #eff0f1 |

Why would the ring and the background have different colors? They both have the same class attribute.

I must have had a slightly older version of the patch because I swear I saw the ring using ViewBackground and the background using Background. I downloaded the patch again and everything looks fine there. go.svgz still has #31363b and #232629 as the default colors for the background and ring. Is this intentional?

They do not have a default color for me.

Sat, Dec 1, 6:38 AM · Frameworks
ndavis added a comment to D15999: Add icons with added background to system.svgz.

With colorschemes applied, these will be your colors:

            | Ring    | Background | Symbol  |
            | ------- | ---------- | ------- |
     Breeze | #fcfcfc | #eff0f1    | #232627 |
Breeze Dark | #232629 | #31363b    | #eff0f1 |

Why would the ring and the background have different colors? They both have the same class attribute.

Sat, Dec 1, 5:40 AM · Frameworks

Fri, Nov 30

ndavis added a comment to D15999: Add icons with added background to system.svgz.

With colorschemes applied, these will be your colors:

Fri, Nov 30, 11:07 PM · Frameworks
ndavis added a comment to T10085: Redesign - Refactored Timeline.

When you lock it it will disable that track, you wont be able to move clips in the track anymore.

Fri, Nov 30, 10:50 PM · Kdenlive
ndavis retitled D17253: Fix colors for vector image mimetypes from Fix inconsistent x-office-drawing icon color to Fix colors for vector image mimetypes.
Fri, Nov 30, 11:58 AM · Frameworks
ndavis planned changes to D17253: Fix colors for vector image mimetypes.
Fri, Nov 30, 11:57 AM · Frameworks
ndavis added a comment to D17253: Fix colors for vector image mimetypes.

I just ran into 2 other issues.

Fri, Nov 30, 11:56 AM · Frameworks
ndavis updated the summary of D17253: Fix colors for vector image mimetypes.
Fri, Nov 30, 11:36 AM · Frameworks
ndavis updated the test plan for D17253: Fix colors for vector image mimetypes.
Fri, Nov 30, 11:34 AM · Frameworks
ndavis requested review of D17253: Fix colors for vector image mimetypes.
Fri, Nov 30, 11:32 AM · Frameworks
ndavis requested changes to D15999: Add icons with added background to system.svgz.

It appears that the background colors are hardcoded. If they are meant to be dark with the Breeze Light Plasma theme and light with Breeze Dark, then they should use the ColorScheme-Text class and the inner symbols should use the ColorScheme-Background class.

Fri, Nov 30, 12:28 AM · Frameworks
ndavis added a comment to D15999: Add icons with added background to system.svgz.

Could these icons be moved into the breeze-icons repo? That would make it simpler to edit and review these in the future.

Fri, Nov 30, 12:16 AM · Frameworks
ndavis added a comment to T10085: Redesign - Refactored Timeline.

I noticed you used green as the color for "Target". What is a "Target"? Is that the current selection? If so, the color should be Plasma Blue (#3daee9). Green should generally be used for positive things or successful operations while Plasma Blue is used for selections.

Fri, Nov 30, 12:05 AM · Kdenlive

Thu, Nov 29

ndavis added a comment to T10085: Redesign - Refactored Timeline.

I think the locked track stuff should be orange. Red should generally be reserved for things that can be destructive or errors.

Thu, Nov 29, 10:58 PM · Kdenlive
ndavis added a comment to D17220: Improve symbolism for off and muted status icon.

Also, here's the 16px muted icon with the "No" symbol moved out to the right by 1px and then 2px compared to the 16px full volume icon

Thu, Nov 29, 10:17 PM · Frameworks
ndavis added a comment to D17220: Improve symbolism for off and muted status icon.

Also, the semi-transparent sound waves on the audio icons in the Breeze Plasma theme use 25% opacity, not 50% opacity. I think 25% looks better anyway.

Thu, Nov 29, 9:56 PM · Frameworks
ndavis added a comment to D17220: Improve symbolism for off and muted status icon.

I'm not sure about this, but I think increasing the size of the red no symbol from 6px to 8px on the 22px mute icon might be a good idea. At 6px, it just seems to lack visual weight.

Thu, Nov 29, 9:49 PM · Frameworks
ndavis added a comment to D17220: Improve symbolism for off and muted status icon.

Should this style then also be applied to other "off" status icons like touchpad and camera?

Thu, Nov 29, 9:36 PM · Frameworks
ndavis added a reviewer for D17220: Improve symbolism for off and muted status icon: ndavis.
Thu, Nov 29, 7:19 AM · Frameworks
ndavis added a comment to D17220: Improve symbolism for off and muted status icon.

Here's what the Breeze Plasma desktop theme uses for the network-wireless-off icon:

That fact that slightly different versions those icons live in two places (Breeze plasma icon theme & general Breeze icon theme) is... not ideal. :/

Thu, Nov 29, 3:44 AM · Frameworks
ndavis added a comment to D17220: Improve symbolism for off and muted status icon.

Could a distinction between "off" and "muted" be useful? If that is true, then we should keep the red horizontal dash for muted and use a red slash through the whole icon for off/disabled. In general, I think a red X should mean "error", but we're not consistent about that yet. I also think the sound waves should be reversed on the microphone icon since microphones don't normally make noise.

Thu, Nov 29, 1:49 AM · Frameworks

Sun, Nov 25

ndavis added a comment to D17152: Hide the badge if number too big.

Why not abbreviate the number and round the abbreviated number instead? Instead of using "9,999+" for 11000, use "11K".

Sun, Nov 25, 5:40 PM · Plasma

Fri, Nov 23

ndavis added a comment to D17073: Do not crop albumArt.

That blur looks nice, but I think the background should be more opaque like the Elisa header background.

Do you want to suggest some numbers ?

Fri, Nov 23, 2:27 PM · Plasma

Thu, Nov 22

ndavis committed R266:7e27acf7e1a8: Move firewall-applet icons to status category (authored by ndavis).
Move firewall-applet icons to status category
Thu, Nov 22, 8:27 PM
ndavis closed D16983: Move firewall-applet icons to status category.
Thu, Nov 22, 8:27 PM · Frameworks
ndavis closed D17062: Fix angle and margin of 32px dialog-ok-apply.
Thu, Nov 22, 8:11 PM · Frameworks
ndavis committed R266:e1375f0efcdf: Fix angle and margin of 32px dialog-ok-apply (authored by trickyricky26).
Fix angle and margin of 32px dialog-ok-apply
Thu, Nov 22, 8:11 PM
ndavis accepted D17062: Fix angle and margin of 32px dialog-ok-apply.

All correct!

Thu, Nov 22, 8:10 PM · Frameworks
ndavis added a comment to D17073: Do not crop albumArt.

That blur looks nice, but I think the background should be more opaque like the Elisa header background.

Thu, Nov 22, 7:26 PM · Plasma
ndavis added a comment to D17073: Do not crop albumArt.

If you want to try adding blur to the background, check out the code here: https://cgit.kde.org/elisa.git/tree/src/qml/HeaderBar.qml#n53

Thu, Nov 22, 9:06 AM · Plasma
ndavis added a comment to D17073: Do not crop albumArt.

How about this ?

Thu, Nov 22, 8:59 AM · Plasma
ndavis requested changes to D17062: Fix angle and margin of 32px dialog-ok-apply.

Actually, I do need you to do something, but the icons themselves are fine. I need to to rebase this patch onto master. I can walk you through it here or in a chat room if you need help.

Thu, Nov 22, 12:12 AM · Frameworks
ndavis closed D16951: Resolve merge conflict.
Thu, Nov 22, 12:05 AM · Frameworks
ndavis committed R266:2a85454d7a42: Resolve merge conflict (authored by ndavis).
Resolve merge conflict
Thu, Nov 22, 12:05 AM
ndavis retitled D16951: Resolve merge conflict from Add mouse button icons to Resolve merge conflict.
Thu, Nov 22, 12:03 AM · Frameworks