ndavis (Noah Davis)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Sep 6 2017, 10:33 AM (85 w, 1 d)
Availability
Available

Recent Activity

Today

ndavis added a comment to D19812: Add a web page to view and compare icons of different sizes.

TBH I wonder how useful this actually is. Hopefully some of the other folks involved in making icons (@ndavis, @GB_2, @trickyricky26) can comment on whether or not this would be useful for them.

Fri, Apr 26, 12:13 AM · Frameworks

Yesterday

ndavis committed R242:176643f48c84: Fix wrong group names for 22, 32 px in audio.svg (authored by ndavis).
Fix wrong group names for 22, 32 px in audio.svg
Thu, Apr 25, 6:01 PM
ndavis closed D20825: Fix wrong group names for 22, 32 px in audio.svg.
Thu, Apr 25, 6:01 PM · Frameworks
ndavis requested review of D20825: Fix wrong group names for 22, 32 px in audio.svg.
Thu, Apr 25, 5:55 PM · Frameworks

Tue, Apr 23

ndavis accepted D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".

LGTM

Tue, Apr 23, 5:03 PM · Frameworks
ndavis added a comment to D20746: Remove disable for showing only minimized tasks on Icons only task manager.

@hein You appear to have been the one who created the first version of this line, but I can't figure out why it was added.

Tue, Apr 23, 4:48 PM · Plasma
ndavis abandoned D20654: Update elevation.rst to match default shadow settings.

The change has been commited.

Tue, Apr 23, 3:27 PM
ndavis added a comment to D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".

More like center version in this SVG:

Tue, Apr 23, 10:00 AM · Frameworks
ndavis added a comment to D20693: Remove pixelated border.

+1 for the change to the large thumbnail, but I think the smaller thumbnails need something to show that they can be clicked.

Tue, Apr 23, 9:38 AM · KNewStuff, Frameworks

Mon, Apr 22

ndavis committed R242:b5ec56091ed3: Add more icon sizes for audio, configure, distribute (authored by ndavis).
Add more icon sizes for audio, configure, distribute
Mon, Apr 22, 12:42 PM
ndavis closed D20695: Add more icon sizes for audio, configure, distribute.
Mon, Apr 22, 12:42 PM · Frameworks
ndavis added a comment to D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".

The 22px version needs to have 1px thick lines and 3px margins on each side.

Mon, Apr 22, 12:36 PM · Frameworks
ndavis requested changes to D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".

I'll accept this if you also make 22px versions.

Mon, Apr 22, 6:44 AM · Frameworks
ndavis added a comment to D20708: Change input-* device icon styles, add 16px icons.

Actually, dialog-input-devices is used by inkscape for configuring pointing devices and tablets. AFAIK, only Inkscape uses that icon. If I made it show more types of devices, it would be more accurate to use a tablet. Looking at the Input Devices dock in Inkscape, it doesn't seem like it would be used much for configuring mice, so it might be better if it was just a symlink to the input-tablet icon.

Mon, Apr 22, 2:26 AM · Frameworks
ndavis added a comment to D20708: Change input-* device icon styles, add 16px icons.

Overall very nice.

Instead of symlinking input-mouse to dialog-input-devices, I think it might make more sense to rename dialog-input-devices to be input-mouse and then change the dialog-input-devices so that it depicts more than one input device, to reinforce its name. Maybe a mouse + keyboard?

Mon, Apr 22, 2:01 AM · Frameworks

Sun, Apr 21

ndavis added a comment to D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".
In D20700#453565, @GB_2 wrote:

list-remove is just a minus icon, which has no context and looks weird when used alone, without list-add next to it. An example where the new icon can be used is D20576.

Sun, Apr 21, 4:25 PM · Frameworks
ndavis updated the test plan for D20708: Change input-* device icon styles, add 16px icons.
Sun, Apr 21, 1:17 PM · Frameworks
ndavis requested review of D20708: Change input-* device icon styles, add 16px icons.
Sun, Apr 21, 1:13 PM · Frameworks
ndavis added a comment to D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".

Why does list-remove need an alternative?

Sun, Apr 21, 12:22 PM · Frameworks

Sat, Apr 20

ndavis updated the diff for D20695: Add more icon sizes for audio, configure, distribute.

Fix 16-16-audio-volume-muted

Sat, Apr 20, 11:03 AM · Frameworks
ndavis updated the test plan for D20695: Add more icon sizes for audio, configure, distribute.
Sat, Apr 20, 11:02 AM · Frameworks
ndavis updated the test plan for D20695: Add more icon sizes for audio, configure, distribute.
Sat, Apr 20, 10:57 AM · Frameworks
ndavis updated the diff for D20695: Add more icon sizes for audio, configure, distribute.

Add 16px audio icons

Sat, Apr 20, 10:56 AM · Frameworks
ndavis planned changes to D20695: Add more icon sizes for audio, configure, distribute.

Oops, looks like I need 16px audio icons as well for the volume/mute icons inside the opened audio widget.

Sat, Apr 20, 10:37 AM · Frameworks
ndavis updated the test plan for D20695: Add more icon sizes for audio, configure, distribute.
Sat, Apr 20, 10:22 AM · Frameworks
ndavis requested review of D20695: Add more icon sizes for audio, configure, distribute.
Sat, Apr 20, 10:19 AM · Frameworks

Fri, Apr 19

ndavis accepted D20672: Add an icon for Thunderbolt KCM.
Fri, Apr 19, 3:15 PM · Frameworks
ndavis requested changes to D20672: Add an icon for Thunderbolt KCM.

Actually, one last thing. Can you save it as a plain SVG so that it isn't filled with Inkscape metadata?

Fri, Apr 19, 2:44 PM · Frameworks
ndavis accepted D20672: Add an icon for Thunderbolt KCM.

I like the new top color.

Fri, Apr 19, 2:40 PM · Frameworks
ndavis requested changes to D20672: Add an icon for Thunderbolt KCM.

A few problems:

Fri, Apr 19, 11:12 AM · Frameworks

Thu, Apr 18

ndavis added a reviewer for D20654: Update elevation.rst to match default shadow settings: KDE Human Interface Guidelines.
Thu, Apr 18, 9:01 AM
ndavis requested review of D20654: Update elevation.rst to match default shadow settings.
Thu, Apr 18, 9:00 AM

Wed, Apr 17

ndavis committed R242:cdad9c38c110: Fix stylesheet support for audio-volume-medium (authored by ndavis).
Fix stylesheet support for audio-volume-medium
Wed, Apr 17, 6:11 PM
ndavis committed R242:bd8264e92869: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze… (authored by ndavis).
Update audio, drive, edit, go, list, media, plasmavault icons to match breeze…
Wed, Apr 17, 5:53 PM
ndavis closed D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons.
Wed, Apr 17, 5:52 PM · Frameworks
ndavis added a comment to D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons.

One concern:

Wed, Apr 17, 2:44 AM · Frameworks
ndavis added a reviewer for D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons: Plasma.
Wed, Apr 17, 2:43 AM · Frameworks
ndavis updated the test plan for D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons.
Wed, Apr 17, 2:40 AM · Frameworks
ndavis requested review of D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons.
Wed, Apr 17, 2:36 AM · Frameworks

Tue, Apr 16

ndavis committed R242:0ff81fe4c728: Align z's to pixel grid in system.svg (authored by ndavis).
Align z's to pixel grid in system.svg
Tue, Apr 16, 12:46 PM
ndavis closed D20597: Align z's to pixel grid in system.svg.
Tue, Apr 16, 12:46 PM · Frameworks
ndavis updated the summary of D20597: Align z's to pixel grid in system.svg.
Tue, Apr 16, 8:28 AM · Frameworks
ndavis requested review of D20597: Align z's to pixel grid in system.svg.
Tue, Apr 16, 8:26 AM · Frameworks
ndavis committed R266:db9fdceac1ac: Sharpen Z's in system-suspend* icons (authored by ndavis).
Sharpen Z's in system-suspend* icons
Tue, Apr 16, 8:23 AM
ndavis closed D20586: Sharpen Z's in system-suspend* icons.
Tue, Apr 16, 8:23 AM · Frameworks

Mon, Apr 15

ndavis updated the test plan for D20586: Sharpen Z's in system-suspend* icons.
Mon, Apr 15, 10:21 PM · Frameworks
ndavis updated the test plan for D20586: Sharpen Z's in system-suspend* icons.
Mon, Apr 15, 10:21 PM · Frameworks
ndavis requested review of D20586: Sharpen Z's in system-suspend* icons.
Mon, Apr 15, 10:20 PM · Frameworks
ndavis added a comment to D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight.
In D20140#450349, @GB_2 wrote:

Ping

Mon, Apr 15, 5:52 PM · Frameworks

Sat, Apr 13

ndavis accepted D20426: Improve "widget-alternatives" icon.

I can't think of any more suggestions that would be an obvious improvement, so I'll accept this.

Sat, Apr 13, 12:51 PM · Frameworks
ndavis added a comment to D20426: Improve "widget-alternatives" icon.

Can you flip the direction of the 16px version? I know the icon you're copying the design of is also like this, but I think it needs to be fixed.

Sat, Apr 13, 10:18 AM · Frameworks

Wed, Apr 10

ndavis committed R266:aaa6451d308e: Add go-up/down/next/previous-skip (authored by ndavis).
Add go-up/down/next/previous-skip
Wed, Apr 10, 9:10 PM
ndavis closed D20435: Add go-up/down/next/previous-skip.
Wed, Apr 10, 9:10 PM · Frameworks
ndavis updated the summary of D20435: Add go-up/down/next/previous-skip.
Wed, Apr 10, 9:09 PM · Frameworks
ndavis updated the diff for D20435: Add go-up/down/next/previous-skip.
  • Turn window-keep-* into symlinks to go-up/down-skip
Wed, Apr 10, 9:08 PM · Frameworks
ndavis added a comment to D20435: Add go-up/down/next/previous-skip.

Now I'll need to turn window-keep-above and window-keep-below into symlinks to go-up-skip and go-down-skip. arc patch hates it when files or symlinks are converted to each other, so I'll hold off doing that until this gets accepted.

Wed, Apr 10, 2:24 PM · Frameworks
ndavis updated the summary of D20435: Add go-up/down/next/previous-skip.
Wed, Apr 10, 2:10 PM · Frameworks
ndavis updated the test plan for D20435: Add go-up/down/next/previous-skip.
Wed, Apr 10, 2:09 PM · Frameworks
ndavis requested review of D20435: Add go-up/down/next/previous-skip.
Wed, Apr 10, 2:04 PM · Frameworks

Tue, Apr 9

ndavis committed R119:e09cc99b5250: [Kickoff] Anchor right of subTitleElement in KickoffItem to arrow.right (authored by ndavis).
[Kickoff] Anchor right of subTitleElement in KickoffItem to arrow.right
Tue, Apr 9, 5:18 PM
ndavis closed D20399: [Kickoff] Anchor right of subTitleElement in KickoffItem to arrow.right.
Tue, Apr 9, 5:18 PM · Plasma
ndavis updated the test plan for D19736: Add view-orientation-auto/landscape/portrait.
Tue, Apr 9, 9:34 AM · Frameworks
ndavis updated the diff for D19736: Add view-orientation-auto/landscape/portrait.
  • Change to 3 icons
Tue, Apr 9, 9:32 AM · Frameworks
ndavis retitled D20399: [Kickoff] Anchor right of subTitleElement in KickoffItem to arrow.right from [Kickoff] Anchor subtitle in KickoffItem to arrow.right to [Kickoff] Anchor right of subTitleElement in KickoffItem to arrow.right.
Tue, Apr 9, 4:28 AM · Plasma
ndavis requested review of D20399: [Kickoff] Anchor right of subTitleElement in KickoffItem to arrow.right.
Tue, Apr 9, 4:27 AM · Plasma

Fri, Apr 5

ndavis committed R119:51f7912368e6: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use… (authored by ndavis).
[Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use…
Fri, Apr 5, 9:30 PM
ndavis closed D19874: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use smallSpacing.
Fri, Apr 5, 9:30 PM · Plasma
ndavis added a comment to D19874: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use smallSpacing.

This makes Kickoff even a bit more more left-centered = looking like it's wasting horizontal space. That's why I prefer the way it was before, but I tested the patch and everything seems symmetric at least.

It seems that in the screenshots the "Small" font is set to be bigger than normal. With default font sizes Kickoff can end up looking like this (ignore the lack of few other patches):

That's a lot of unused horizontal space, while the benefits of reduced padding are only for apps with really long descriptions (which are minority) or for people using a bigger font size for "Small" text.

If everyone else is on board I won't object though.

Fri, Apr 5, 9:27 PM · Plasma
ndavis added a comment to D19874: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use smallSpacing.

I haven't tested this with many different fonts, but the current version works well for Noto Sans at 10, 11 and 12 pts.

Fri, Apr 5, 9:21 PM · Plasma
ndavis updated the summary of D19874: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use smallSpacing.
Fri, Apr 5, 9:19 PM · Plasma
ndavis updated the diff for D19874: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use smallSpacing.
  • Remove commented out bit of old code
Fri, Apr 5, 9:15 PM · Plasma
ndavis updated the test plan for D19874: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use smallSpacing.
Fri, Apr 5, 9:09 PM · Plasma
ndavis updated the diff for D19874: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use smallSpacing.

Use smallSpacing for KickoffItem and KickoffHighlight

Fri, Apr 5, 8:54 PM · Plasma
ndavis accepted D20226: Add "notifications" and "notifications-disabled" icons.

Those curves are perfect 👌

Fri, Apr 5, 2:02 AM · Frameworks

Wed, Apr 3

ndavis commandeered D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key.

Alright. I'll finish it when I have time.

Wed, Apr 3, 10:46 PM · Frameworks
ndavis added a comment to D20226: Add "notifications" and "notifications-disabled" icons.

Diagonal or round shapes are not required to be pixel grid aligned. Actually, it is not even possible, as there is always some antialiasing. It even helps to make round shapes a little bit bit larger than the pixel grid, so some of the corner/edge pixels are solid color.

Wed, Apr 3, 4:04 PM · Frameworks
ndavis added a comment to D20226: Add "notifications" and "notifications-disabled" icons.
In D20226#442906, @GB_2 wrote:

Also, could we create a 22x22 version too?

How can you efficiently do that without having to realign everything to the new grid manually?

Wed, Apr 3, 3:34 PM · Frameworks
ndavis added a comment to D20226: Add "notifications" and "notifications-disabled" icons.

The proportions aren't quite right.

Wed, Apr 3, 3:27 PM · Frameworks

Tue, Apr 2

ndavis added a comment to D20189: Change default Yakuake skin to breeze compact.

I've already made Qt Widget-like tabs for Breeze and Breeze Dark at these repos, so you can just borrow from those:

Tue, Apr 2, 8:31 PM

Mon, Apr 1

ndavis added a comment to D20189: Change default Yakuake skin to breeze compact.

Does the theme have to use PNGs? It would also be nice if the tabs could look more like Qt tabs like in https://store.kde.org/p/1193435/

Mon, Apr 1, 10:44 PM
ndavis added a comment to D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz.

IMHO the SVG files in the repo may contain comments and metadatas, for further work on them. Like source code also has all the oomments and metadata.
Only the deployed graphics resource should then be limited and optimized for what is needed at runtime.

At least I had dealt with quite some "final rendered" SVG files I would have liked to modify for some needs, but could hardly as the base resources where not available (and if it was only guides & Co.).

Mon, Apr 1, 10:36 PM · Frameworks
ndavis added a comment to D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz.

Strictly speaking, there's no need to optimize the SVGs as a part of this, so maybe, yeah, let's split that out into a separate feature (and one that the Breeze Icons repo would ultimately be interested in as well).

Mon, Apr 1, 8:29 PM · Frameworks
ndavis added a comment to D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz.

Be careful that you are not stripping stylesheets when you use SVG Cleaner. scour is less effective than SVG Cleaner, but it doesn't strip stylesheets and it's available in more distros.

Mon, Apr 1, 5:30 PM · Frameworks

Sun, Mar 31

ndavis accepted D20147: Improve executable dialog buttons' icons.

Yes, this is much better. Wow, that application-x-executable icon is really blurry.

Sun, Mar 31, 7:27 PM · Frameworks
ndavis added a comment to D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight.

Another alternative would be to turn the thumbnail outline into a real outline instead of a rounded rectangle behind the thumbnailArea. Then it could go on top of the thumbnailArea and the thumbnail highlight could fit perfectly inside of it. This would give previews of rectangular images rounded corners and is significantly more complicated than the current change, but I feel like it should be possible.

Sun, Mar 31, 5:24 PM · Frameworks
ndavis added a comment to D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight.

Here is how no radius for the thumbnailArea and thumbnail highlight looks:

Sun, Mar 31, 5:18 PM · Frameworks
ndavis committed R266:69d7182daffc: Sublime Merge Icon. (authored by otavva).
Sublime Merge Icon.
Sun, Mar 31, 5:17 PM
ndavis closed D20063: Sublime Merge Icon..
Sun, Mar 31, 5:16 PM · Frameworks, VDG
ndavis added a comment to D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight.

It's probably going to be more noticeable for High DPI users. It seems like there must be a way to fix this rather than just removing the thumbnail radius.

Sun, Mar 31, 4:38 PM · Frameworks
ndavis updated the test plan for D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight.
Sun, Mar 31, 4:33 AM · Frameworks
ndavis updated the diff for D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight.
  • Remove radius from thumbnailArea highlight
Sun, Mar 31, 4:30 AM · Frameworks
ndavis updated the test plan for D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight.
Sun, Mar 31, 4:09 AM · Frameworks
ndavis requested review of D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight.
Sun, Mar 31, 4:09 AM · Frameworks

Fri, Mar 29

ndavis accepted D20063: Sublime Merge Icon..

@otavva I need your email and real name to land your patch with the correct author. If you use the Arcanist tool for patches in the future, you will need to make sure that your real name is set as your Git user name.

Fri, Mar 29, 10:10 PM · Frameworks, VDG

Wed, Mar 27

ndavis added a comment to D20063: Sublime Merge Icon..

Oh wait no, it's not there yet, but it still looks pretty good.

Wed, Mar 27, 10:30 PM · Frameworks, VDG
ndavis added a comment to D20063: Sublime Merge Icon..

I don't that version is actually in the patch though. @otavva can you update this patch to have that version of the icon? Then we can get it landed for you.

Wed, Mar 27, 10:20 PM · Frameworks, VDG
ndavis accepted D20063: Sublime Merge Icon..

This is very nice.

Wed, Mar 27, 6:35 PM · Frameworks, VDG

Mar 27 2019

ndavis added a comment to D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key.

The rounded corners and bold 1 are not very breeze like, so I don't think so, unless he changes his design. Unless you still plan to do the icon yourself, you should probably hand off responsibility for the patch to someone else.

Sorry for the confusion, as I'm new to this I really need help and aren't able to do this alone, just just wanted to bring some attention to this and learn how to work with KDE. Thanks for all help, should we now use t-ask's first icon(the right one) or something else?

Mar 27 2019, 1:34 AM · Frameworks

Mar 26 2019

ndavis added a comment to D8388: Do not hardcode unhovered windows brightness on present windows effect.

What if:

Mar 26 2019, 8:57 PM · KWin
ndavis added a comment to D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key.

The rounded corners and bold 1 are not very breeze like, so I don't think so, unless he changes his design. Unless you still plan to do the icon yourself, you should probably hand off responsibility for the patch to someone else.

Mar 26 2019, 8:43 PM · Frameworks