ndavis (Noah Davis)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Sep 6 2017, 10:33 AM (92 w, 3 d)
Availability
Available

Recent Activity

Today

ndavis added a comment to T10046: Improve the colors, color consistency and colorscheme compatibility of Breeze.

[...] I like what Deepin does with its deepin-dark icon theme, it mutes icons as well:

Sun, Jun 16, 1:40 AM · KDE Human Interface Guidelines, VDG, Plasma, Breeze
ndavis added a comment to T10046: Improve the colors, color consistency and colorscheme compatibility of Breeze.

I don't think it's a particularly good thing to have the folder colors the same color as the highlight color. Also, if we are going to make the folder color match the highlight color, it would make sense to make the folder color change with the colorscheme. People have requested that and I tried that already, but it just doesn't work well. Folders end up looking way too dark on colorschemes with dark highlights and dark background colors.

Sun, Jun 16, 1:36 AM · KDE Human Interface Guidelines, VDG, Plasma, Breeze

Yesterday

ndavis added a comment to D21813: RFC: Consider adding more padding to the desktop theme.

Hmm. I don't think we should increase the padding on the desktop theme. That kind of approach seems like it would work best once we know the contents of notifications and OSDs are aligned how we want them to be in the code.

Sat, Jun 15, 12:46 AM · Frameworks
ndavis added a comment to D21813: RFC: Consider adding more padding to the desktop theme.

I like the rounder corners! :)

Sat, Jun 15, 12:12 AM · Frameworks
ndavis added a comment to D21813: RFC: Consider adding more padding to the desktop theme.

Besides the notifications, where does this add padding?

Sat, Jun 15, 12:09 AM · Frameworks

Thu, Jun 13

ndavis requested changes to D21656: Create a breeze icon for kfourinline.
Thu, Jun 13, 11:08 PM · Frameworks
ndavis added a comment to D21656: Create a breeze icon for kfourinline.

I just tried the patch on my own computer and I noticed a few more things that need to be changed:

Thu, Jun 13, 11:08 PM · Frameworks

Wed, Jun 12

ndavis updated the description for M151: Dynamic Locally Integrated Menu.
Wed, Jun 12, 10:05 PM · Breeze, VDG, KWin
ndavis added a project to M151: Dynamic Locally Integrated Menu: Breeze.
Wed, Jun 12, 9:25 PM · Breeze, VDG, KWin
ndavis updated the description for M151: Dynamic Locally Integrated Menu.
Wed, Jun 12, 9:06 PM · Breeze, VDG, KWin
ndavis added a comment to T10201: Window titlebars.

@davidhurka Here's my go at making something like what you described:

Wed, Jun 12, 9:05 PM · KDE Applications, VDG
ndavis updated the description for M151: Dynamic Locally Integrated Menu.
Wed, Jun 12, 9:02 PM · Breeze, VDG, KWin
ndavis created M151: Dynamic Locally Integrated Menu.
Wed, Jun 12, 8:54 PM · Breeze, VDG, KWin
ndavis added a comment to T11082: Buttons look in Breeze window title bar.

We also need multiple fixed button sizes instead of having a single QPainter definition for each button that is scaled up and down. The way we do it right now leads to blurry button symbols at some non-default sizes.

Wed, Jun 12, 6:37 PM · Breeze, VDG

Tue, Jun 11

ndavis committed R119:fff556af1939: [minimzeall] Change panel icon size to smallMedium (authored by ndavis).
[minimzeall] Change panel icon size to smallMedium
Tue, Jun 11, 6:37 PM

Mon, Jun 10

ndavis committed R119:5de082c39b91: [minimzeall] Actually change max panel icon size to smallMedium (authored by ndavis).
[minimzeall] Actually change max panel icon size to smallMedium
Mon, Jun 10, 8:19 AM
ndavis closed D21685: [minimzeall] Actually change max panel icon size to smallMedium.
Mon, Jun 10, 8:19 AM · Plasma

Sun, Jun 9

ndavis retitled D21685: [minimzeall] Actually change max panel icon size to smallMedium from [minimzeall] Actually change panel icon size to smallMedium to [minimzeall] Actually change max panel icon size to smallMedium.
Sun, Jun 9, 12:06 PM · Plasma
ndavis retitled D21685: [minimzeall] Actually change max panel icon size to smallMedium from [minimzeall] Change panel icon size to smallMedium to [minimzeall] Actually change panel icon size to smallMedium.
Sun, Jun 9, 12:05 PM · Plasma
ndavis requested review of D21685: [minimzeall] Actually change max panel icon size to smallMedium.
Sun, Jun 9, 8:29 AM · Plasma

Sat, Jun 8

ndavis added a comment to D21656: Create a breeze icon for kfourinline.

We don't normally do the gloss wave in Breeze. That's more of a Tango/Oxygen thing. How about adding some holes instead to make it look more like the real thing? https://www.gamesworld.com.au/wp-content/uploads/2015/10/cardinal-four-in-a-row.jpg

Sat, Jun 8, 10:12 AM · Frameworks

Fri, Jun 7

ndavis accepted D21639: Remove background from scrollbars when hovering on them.
In D21639#475696, @mthw wrote:

This seems inconsistent with our Qt Widget scrollbars...

Do you mean by this, that there should be a "rail" behind the scrollbar? Or what else seems to be the problem?

Fri, Jun 7, 11:43 AM · Plasma
ndavis added a comment to D21639: Remove background from scrollbars when hovering on them.

This seems inconsistent with our Qt Widget scrollbars. Is there no chance that the scrollbar would be hard to see against some backgrounds? What GTK themed apps did you test with? How does it affect Firefox?

Fri, Jun 7, 8:58 AM · Plasma

Thu, Jun 6

ndavis added a comment to T10201: Window titlebars.

I really hope that's not how FreeCad actually looks by default...

Thu, Jun 6, 9:35 PM · KDE Applications, VDG
ndavis added a comment to D21630: Change Browse icon back to the hand shape.

@aacid transform-move is less correct, but it's in Oxygen and Papirus (not Adwaita). Would you prefer if that icon was used?

Thu, Jun 6, 9:22 PM · Okular
ndavis added a comment to D21630: Change Browse icon back to the hand shape.

wow Not even one minute to review things

I don't particularly like this, input-mouse is an icon that exists in most icon themes
extra/adwaita-icon-theme
extra/breeze-icons
extra/efl
extra/gnome-icon-theme
extra/gnome-icon-theme-symbolic
extra/gnome-themes-extra
extra/oxygen-icons
extra/oxygen-icons-svg
extra/qt5-doc
extra/xf86-input-mouse
extra/xfce4-power-manager
community/arc-icon-theme
community/elementary-icon-theme
community/faba-icon-theme
community/faenza-icon-theme
community/lxinput
community/lxinput-gtk3
community/mate-icon-theme
community/mate-icon-theme-faenza
community/mate-themes
community/moka-icon-theme
community/papirus-icon-theme

transform-browse exists only in breeze-icons

but 🤷‍♂️ i guess

Thu, Jun 6, 8:57 PM · Okular
ndavis accepted D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement.
Thu, Jun 6, 7:32 PM · Okular
ndavis added a comment to T10870: Consider using colorful rather than monochrome icons for small places, devices, and mimetype icons.

I prefer monochrome icons... again as I've been in favour of monochrome icons for system settings too, where I listed few benefits. This time I can only speak for my personal preference, current variant is clearer for me.

Just making sure, all sidebar (F9) icons would stay monochrome?

Thu, Jun 6, 7:10 PM · VDG
ndavis committed R223:2c39981b21d9: Change Text Selection icon to edit-select-text (authored by ndavis).
Change Text Selection icon to edit-select-text
Thu, Jun 6, 6:58 PM
ndavis closed D21633: Change Text Selection icon to edit-select-text.
Thu, Jun 6, 6:58 PM · Okular
ndavis updated the test plan for D21633: Change Text Selection icon to edit-select-text.
Thu, Jun 6, 6:58 PM · Okular
ndavis committed R266:6227d63efa20: Add edit-select-text, make 16px draw-text like 22px (authored by ndavis).
Add edit-select-text, make 16px draw-text like 22px
Thu, Jun 6, 6:57 PM
ndavis closed D21632: Add edit-select-text, make 16px draw-text like 22px.
Thu, Jun 6, 6:57 PM · Frameworks
ndavis updated the summary of D21633: Change Text Selection icon to edit-select-text.
Thu, Jun 6, 6:51 PM · Okular
ndavis added a dependency for D21633: Change Text Selection icon to edit-select-text: D21632: Add edit-select-text, make 16px draw-text like 22px.
Thu, Jun 6, 6:47 PM · Okular
ndavis added a dependent revision for D21632: Add edit-select-text, make 16px draw-text like 22px: D21633: Change Text Selection icon to edit-select-text.
Thu, Jun 6, 6:47 PM · Frameworks
ndavis updated the summary of D21633: Change Text Selection icon to edit-select-text.
Thu, Jun 6, 6:45 PM · Okular
ndavis requested review of D21633: Change Text Selection icon to edit-select-text.
Thu, Jun 6, 6:43 PM · Okular
ndavis updated the test plan for D21632: Add edit-select-text, make 16px draw-text like 22px.
Thu, Jun 6, 6:39 PM · Frameworks
ndavis requested review of D21632: Add edit-select-text, make 16px draw-text like 22px.
Thu, Jun 6, 6:38 PM · Frameworks
ndavis committed R223:9310bed61621: Change Browse icon back to the hand shape (authored by ndavis).
Change Browse icon back to the hand shape
Thu, Jun 6, 5:48 PM
ndavis closed D21630: Change Browse icon back to the hand shape.
Thu, Jun 6, 5:48 PM · Okular
ndavis updated the test plan for D21630: Change Browse icon back to the hand shape.
Thu, Jun 6, 5:44 PM · Okular
ndavis requested review of D21630: Change Browse icon back to the hand shape.
Thu, Jun 6, 5:43 PM · Okular
ndavis added a comment to D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon.

BTW when talking about consistency, do we also apply this change to the media player applet?

Thu, Jun 6, 5:25 PM · Plasma
ndavis accepted D21622: Use a more conventional dropdown menu style instead of press-and-hold.
Thu, Jun 6, 5:23 PM · Okular
ndavis accepted D21624: In Toolbar's selection mode menu, show "Text Selection" tool by default.
Thu, Jun 6, 5:22 PM · Okular
ndavis accepted D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon.

Makes sense to be consistent about how we present buttons.

Thu, Jun 6, 5:08 PM · Plasma
ndavis accepted D21627: [Task manager] Use Windows-style middle-click behaviors for entries and thumbnails.
Thu, Jun 6, 5:06 PM · Plasma
ndavis added a comment to D21622: Use a more conventional dropdown menu style instead of press-and-hold.

+1, pressing and holding feels unnecessarily slow.

Thu, Jun 6, 5:03 PM · Okular
ndavis added a comment to D21627: [Task manager] Use Windows-style middle-click behaviors for entries and thumbnails.

Is the current default group/ungroup or is the current default none? If the former is true, why is this better? If the latter, then +1 because it's useful.

Thu, Jun 6, 4:57 PM · Plasma
ndavis added a comment to D21624: In Toolbar's selection mode menu, show "Text Selection" tool by default.

+1. Text selection is what I want most of the time and having to switch back to it whenever I'm done with the annotation tools is annoying.

Thu, Jun 6, 4:53 PM · Okular
ndavis committed R119:33be0f5b8b87: [showdesktop][minimzeall] Reduce the maximum panel icon size (authored by ndavis).
[showdesktop][minimzeall] Reduce the maximum panel icon size
Thu, Jun 6, 11:16 AM
ndavis committed R119:f4fe4a65de85: [showdesktop][minimizeall] Reduce the maximum panel icon size (authored by ndavis).
[showdesktop][minimizeall] Reduce the maximum panel icon size
Thu, Jun 6, 11:13 AM
ndavis closed D21593: [showdesktop][minimzeall] Reduce the maximum panel icon size.
Thu, Jun 6, 11:13 AM · Plasma
ndavis updated the summary of D21593: [showdesktop][minimzeall] Reduce the maximum panel icon size.
Thu, Jun 6, 11:08 AM · Plasma
ndavis retitled D21593: [showdesktop][minimzeall] Reduce the maximum panel icon size from [showdesktop] Reduce the maximum panel icon size to [showdesktop][minimzeall] Reduce the maximum panel icon size.
Thu, Jun 6, 11:08 AM · Plasma

Wed, Jun 5

ndavis accepted D21609: Add "Safe Landing" wallpaper.
Wed, Jun 5, 5:59 PM · Plasma
ndavis added a comment to D21593: [showdesktop][minimzeall] Reduce the maximum panel icon size.

Did the approach of twiddling with the icons not work?

Wed, Jun 5, 1:35 PM · Plasma
ndavis accepted D21574: Update KBruch icon.

LGTM

Wed, Jun 5, 12:02 PM · Frameworks
ndavis updated the diff for D21593: [showdesktop][minimzeall] Reduce the maximum panel icon size.

Add changes to minimizeall as well

Wed, Jun 5, 9:28 AM · Plasma
ndavis accepted D21595: [CompactRepresentation] Glow on hover.
Wed, Jun 5, 9:26 AM · Plasma
ndavis accepted D21596: [CompactRepresentation] Glow on hover.

LGTM

Wed, Jun 5, 9:23 AM · Plasma
ndavis added a comment to D21593: [showdesktop][minimzeall] Reduce the maximum panel icon size.

This also needs to be applied to the minimizeall widget, as this is the directly (right click) selectable alternative to showdesktop widget, so the icon size change would revert if a user switched the panel widget to this.

Wed, Jun 5, 9:14 AM · Plasma
ndavis added a comment to D21593: [showdesktop][minimzeall] Reduce the maximum panel icon size.

While I'm all for making the show desktop icon stick out less I don't think randomly limiting the size of one particular applet is a good approach. The iconSizeHints is there for a reason, defining the maximum size of icons in the panel.

The problem with the panel size hint is if you want a small showdesktop icon, you also get a small application launcher icon.

Wed, Jun 5, 9:14 AM · Plasma
ndavis updated the test plan for D21593: [showdesktop][minimzeall] Reduce the maximum panel icon size.
Wed, Jun 5, 8:48 AM · Plasma
ndavis requested review of D21593: [showdesktop][minimzeall] Reduce the maximum panel icon size.
Wed, Jun 5, 8:42 AM · Plasma
ndavis added a comment to D21525: Add support for radio streams.

@jguidon, I'm going to change the existing radio icon, so you won't need to change your code to get the new monochrome version.

Wed, Jun 5, 4:19 AM

Tue, Jun 4

ndavis added a comment to D21574: Update KBruch icon.

Sorry it arc who also uploaded the png that I created for the review, I will fix it.

Tue, Jun 4, 4:03 PM · Frameworks
ndavis added a comment to D21574: Update KBruch icon.

Once you're done with the SVG, make sure you clean it: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization

Tue, Jun 4, 3:57 PM · Frameworks
ndavis added a comment to D21574: Update KBruch icon.

Wait, is this a PNG? This needs to be an SVG.

Tue, Jun 4, 3:54 PM · Frameworks
ndavis requested changes to D21574: Update KBruch icon.

There needs to be a copy in breeze dark as well. Nice job though!

Tue, Jun 4, 3:52 PM · Frameworks

Mon, Jun 3

ndavis committed R266:e759724fab78: Add help-donate-[currency] icons (authored by ndavis).
Add help-donate-[currency] icons
Mon, Jun 3, 11:51 AM
ndavis closed D21526: Add help-donate-[currency] icons.
Mon, Jun 3, 11:51 AM · Frameworks

Sun, Jun 2

ndavis added a comment to D21525: Add support for radio streams.

For the radio icon, I tried to use one from the system icons, but I do not know yet why it is blue and where it comes from in the system.

Sun, Jun 2, 12:05 PM
ndavis added reviewers for D21525: Add support for radio streams: Elisa, VDG.
Sun, Jun 2, 11:31 AM
ndavis added a comment to T10891: Breeze theme evolution.

Here's another idea I've heard bandied about: create new "whitespace" and "expanding whitespace" items that can be added to toolbars so it's possible to have layouts of toolbar buttons that are centered or justified rather than left-aligned, and that use whitespace to separate logical groups rather than vertical separators. macOS has had this for ages and it results in some very aesthetically pleasing toolbars IMO:

Sun, Jun 2, 2:10 AM · VDG, Breeze

Sat, Jun 1

ndavis committed R266:ff72016e444c: Make Breeze Dark use same Kolourpaint icon as Breeze (authored by ndavis).
Make Breeze Dark use same Kolourpaint icon as Breeze
Sat, Jun 1, 11:20 PM
ndavis closed D21521: Make Breeze Dark use same Kolourpaint icon as Breeze.
Sat, Jun 1, 11:20 PM · Frameworks
ndavis updated the summary of D21526: Add help-donate-[currency] icons.
Sat, Jun 1, 11:17 PM · Frameworks
ndavis committed R266:cdd90177d393: Add 22px notifications icons (authored by ndavis).
Add 22px notifications icons
Sat, Jun 1, 11:17 PM
ndavis closed D21523: Add 22px notifications icons.
Sat, Jun 1, 11:17 PM · Frameworks
ndavis added a comment to D21523: Add 22px notifications icons.

done

Sat, Jun 1, 11:15 PM · Frameworks
ndavis updated the summary of D21523: Add 22px notifications icons.
Sat, Jun 1, 11:15 PM · Frameworks
ndavis retitled D21526: Add help-donate-[currency] icons from Add more help-donate currencies to Add help-donate-[currency] icons.
Sat, Jun 1, 6:19 PM · Frameworks
ndavis updated the test plan for D21526: Add help-donate-[currency] icons.
Sat, Jun 1, 6:09 PM · Frameworks
ndavis requested review of D21526: Add help-donate-[currency] icons.
Sat, Jun 1, 6:08 PM · Frameworks
ndavis updated the test plan for D21523: Add 22px notifications icons.
Sat, Jun 1, 2:16 PM · Frameworks
ndavis requested review of D21523: Add 22px notifications icons.
Sat, Jun 1, 2:15 PM · Frameworks
ndavis updated the test plan for D21521: Make Breeze Dark use same Kolourpaint icon as Breeze.
Sat, Jun 1, 9:57 AM · Frameworks
ndavis updated the test plan for D21521: Make Breeze Dark use same Kolourpaint icon as Breeze.
Sat, Jun 1, 9:57 AM · Frameworks
ndavis updated the diff for D21521: Make Breeze Dark use same Kolourpaint icon as Breeze.
  • Stop top edge of wood from bleeding around the colors
Sat, Jun 1, 9:56 AM · Frameworks
ndavis updated the test plan for D21521: Make Breeze Dark use same Kolourpaint icon as Breeze.
Sat, Jun 1, 9:35 AM · Frameworks
ndavis updated the test plan for D21521: Make Breeze Dark use same Kolourpaint icon as Breeze.
Sat, Jun 1, 9:35 AM · Frameworks
ndavis requested review of D21521: Make Breeze Dark use same Kolourpaint icon as Breeze.
Sat, Jun 1, 9:32 AM · Frameworks

Fri, May 31

ndavis committed R266:ac701bd091cf: Make falkon icon a real SVG (authored by ndavis).
Make falkon icon a real SVG
Fri, May 31, 1:29 PM
ndavis closed D21511: Make falkon icon a real SVG.
Fri, May 31, 1:29 PM · Frameworks
ndavis updated the test plan for D21511: Make falkon icon a real SVG.
Fri, May 31, 12:19 PM · Frameworks
ndavis requested review of D21511: Make falkon icon a real SVG.
Fri, May 31, 12:18 PM · Frameworks

Thu, May 30

ndavis committed R242:fb8f02de76d5: Make Breeze Light/Dark use more system colors (authored by ndavis).
Make Breeze Light/Dark use more system colors
Thu, May 30, 12:47 AM