- User Since
- Sep 6 2017, 10:33 AM (102 w, 1 d)
Much better. There is only one thing left that I think should be done for 32 and 64 px. Rather than having a black "fb" for Breeze and and a white "fb" for Breeze Dark, use either white for both with a drop shadow under the "fb" or just black for both and no drop shadow. I only used different colors on the 16 and 22 px icons because they don't have a background.
Upon closer inspection, I found a few issues that need to be fixed.
Reduce the size of the SVGs by optimizing them with one of these tools: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization
Let's abandon it for now. We can always come back if we change our minds.
Hmm. I was thinking about doing something like this mockup:
Mon, Aug 19
I also think that using toggle for search makes more sense. It would be nice to have a general pattern of using toggle buttons in the toolbar for things that can be opened and closed, especially when they're activated via the toolbar in the first place.
Sun, Aug 18
Sat, Aug 17
Considering the changes were already agreed upon before I made this diff, it seem safe to land without further review.
Fri, Aug 16
Anyone want to accept this?
I think I'm going to continue using the outline/sideline+fainter background style. With simple solid highlights, there is a contrast issue where the highlight color either doesn't contrast well with the text or doesn't contrast well with the window background. With a strong highlight outline/sideline and weaker highlight background, we can have good text contrast and good window background contrast.
Alright, problem fixed.
Thu, Aug 15
I thought the hex values were used because it's also supposed to be possible to compile Breeze for Qt 4? I remember reading that Qt 4 needs hex numbers for some reason.
Add event filter for Qt < 5.13
How likely is it for distros using Qt < 5.13 to receive an update to Breeze?
Wed, Aug 14
We don't strictly adhere to outline or filled style (for better or worse), sometimes making use of both styles in the same icon (e.g., view-list-icons). I think the general idea is that we normally use the line/outline style unless that puts the designer at a disadvantage. Icons can look messy with the outline style sometimes.
Tue, Aug 13
Not having id="current-color-scheme" causes stylesheets to not work correctly.
Mon, Aug 12
Sun, Aug 11
I still think 3 horizontal dots is the best form of half checked state proposed here.
We should probably keep the show preview button unless we want to enable previews by default.
Sat, Aug 10
Make sure the default layout doesn't look lopsided when the application menu is enabled instead of the control button.
+1, seems like a good idea.
So what do you think about these colors? I chose them by taking Plasma Blue (#3daee9) from the KDE HIG and adjusting the brightness with HSLuv.org. The selection background color is 1/2 the brightness and the hover background is 2/3. I don't really know how to pick colors, so I'm taking a somewhat conservative approach where new colors are at least somewhat based on existing ones.
Fri, Aug 9
Thu, Aug 8
- Don't change default icon
- Hide label by default