ndavis (Noah Davis)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Sep 6 2017, 10:33 AM (102 w, 1 d)
Availability
Available

Recent Activity

Today

ndavis accepted D23300: Add FictionBook 2 icons.

LGTM

Thu, Aug 22, 10:56 AM · Frameworks
ndavis added a comment to D23300: Add FictionBook 2 icons.

Much better. There is only one thing left that I think should be done for 32 and 64 px. Rather than having a black "fb" for Breeze and and a white "fb" for Breeze Dark, use either white for both with a drop shadow under the "fb" or just black for both and no drop shadow. I only used different colors on the 16 and 22 px icons because they don't have a background.

Thu, Aug 22, 10:30 AM · Frameworks
ndavis requested changes to D23300: Add FictionBook 2 icons.

Upon closer inspection, I found a few issues that need to be fixed.

Thu, Aug 22, 7:37 AM · Frameworks

Yesterday

ndavis added a comment to D23300: Add FictionBook 2 icons.

Reduce the size of the SVGs by optimizing them with one of these tools: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization

Wed, Aug 21, 4:35 PM · Frameworks
ndavis committed R856:6a6e3ac78efb: Add dark theme icons (authored by ndavis).
Add dark theme icons
Wed, Aug 21, 2:42 PM
ndavis closed D23319: Add dark theme icons.
Wed, Aug 21, 2:42 PM · Plasma
ndavis requested review of D23319: Add dark theme icons.
Wed, Aug 21, 2:37 PM · Plasma
ndavis committed R856:78ef72d5ba5b: Change icon colors, add disabled icons (authored by ndavis).
Change icon colors, add disabled icons
Wed, Aug 21, 1:38 PM
ndavis closed D23317: Change icon colors, add disabled icons.
Wed, Aug 21, 1:38 PM · Plasma
ndavis updated the summary of D23317: Change icon colors, add disabled icons.
Wed, Aug 21, 1:38 PM · Plasma
ndavis updated the diff for D23317: Change icon colors, add disabled icons.

rename svgs

Wed, Aug 21, 1:36 PM · Plasma
ndavis updated the diff for D23317: Change icon colors, add disabled icons.

undo rename

Wed, Aug 21, 1:35 PM · Plasma
ndavis requested review of D23317: Change icon colors, add disabled icons.
Wed, Aug 21, 1:26 PM · Plasma
ndavis added a comment to D23296: Simplify rendering of raised toolbuttons with menu.

Let's abandon it for now. We can always come back if we change our minds.

Wed, Aug 21, 11:15 AM · Plasma
ndavis added a comment to D23296: Simplify rendering of raised toolbuttons with menu.

Hmm. I was thinking about doing something like this mockup:

Wed, Aug 21, 12:40 AM · Plasma

Mon, Aug 19

ndavis added a comment to T11124: Unify highlight effect style.
In T11124#195731, @mglb wrote:

The line is used only in a sidebar, which is used mainly (or only?) in an application's configuration windows and system settings. I guess configuration windows are not maximized very often, so the shadow is not a problem.
System settings is probably maximized on smaller screens, but I don't think the shadow is a big problem - there is regular blue background as a main highlight indicator.

Mon, Aug 19, 5:31 PM · VDG
ndavis added a comment to D23232: [dolphin] Add an action to toggle the searchbar.

I also think that using toggle for search makes more sense. It would be nice to have a general pattern of using toggle buttons in the toolbar for things that can be opened and closed, especially when they're activated via the toolbar in the first place.

Mon, Aug 19, 1:38 PM · Dolphin
ndavis committed R266:5637b119d95d: Change radio to device icon, add more sizes (authored by ndavis).
Change radio to device icon, add more sizes
Mon, Aug 19, 12:00 AM
ndavis closed D23249: Change radio to device icon, add more sizes.
Mon, Aug 19, 12:00 AM · Frameworks

Sun, Aug 18

ndavis updated the summary of D23249: Change radio to device icon, add more sizes.
Sun, Aug 18, 11:17 PM · Frameworks
ndavis updated the test plan for D23249: Change radio to device icon, add more sizes.
Sun, Aug 18, 11:16 PM · Frameworks
ndavis updated the test plan for D23249: Change radio to device icon, add more sizes.
Sun, Aug 18, 11:12 PM · Frameworks
ndavis requested review of D23249: Change radio to device icon, add more sizes.
Sun, Aug 18, 11:10 PM · Frameworks

Sat, Aug 17

ndavis committed R31:f803a89e2443: Fix colors from KStatefulBrushes not using application colorschemes (authored by ndavis).
Fix colors from KStatefulBrushes not using application colorschemes
Sat, Aug 17, 11:35 PM
ndavis closed D23170: Fix colors from KStatefulBrushes not using application colorschemes.
Sat, Aug 17, 11:35 PM · Plasma
ndavis updated the summary of D23170: Fix colors from KStatefulBrushes not using application colorschemes.
Sat, Aug 17, 11:30 PM · Plasma
ndavis added a comment to D23170: Fix colors from KStatefulBrushes not using application colorschemes.

Considering the changes were already agreed upon before I made this diff, it seem safe to land without further review.

Sat, Aug 17, 11:30 PM · Plasma

Fri, Aug 16

ndavis added a comment to T11124: Unify highlight effect style.

There's a white line, which contains a blue line under the "about" tab.

  1. Has that been changed recently, because under Plasma 5.16.4 it looks different:
  2. Is the white line necessary at all? When I now checked Breeze light, it found that the white line is there as well but hardly visible at all:


    Personally, I would drop it, as having two lines or a bicolor line looks kind of wrong to me.
Fri, Aug 16, 8:09 PM · VDG
ndavis added a comment to D23170: Fix colors from KStatefulBrushes not using application colorschemes.

Anyone want to accept this?

Fri, Aug 16, 7:52 PM · Plasma
ndavis added a comment to T11124: Unify highlight effect style.

I think I'm going to continue using the outline/sideline+fainter background style. With simple solid highlights, there is a contrast issue where the highlight color either doesn't contrast well with the text or doesn't contrast well with the window background. With a strong highlight outline/sideline and weaker highlight background, we can have good text contrast and good window background contrast.

Fri, Aug 16, 7:10 PM · VDG
ndavis abandoned D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu.

Alright, problem fixed.

Fri, Aug 16, 5:37 PM · Plasma
ndavis committed R31:6b63429fa9e5: Move drawIndicatorButtonDropDownPrimitive separator when sunken (authored by ndavis).
Move drawIndicatorButtonDropDownPrimitive separator when sunken
Fri, Aug 16, 5:36 PM
ndavis committed R31:a98d21b567f4: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu (authored by ndavis).
Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu
Fri, Aug 16, 5:32 PM
ndavis committed R31:b5af1e947d25: Revert "Fix width and separator of ToolButtonComplexControl outline w/ dropdown… (authored by ndavis).
Revert "Fix width and separator of ToolButtonComplexControl outline w/ dropdown…
Fri, Aug 16, 5:26 PM
ndavis added a reverting change for R31:b43e19e3e13c: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu: R31:b5af1e947d25: Revert "Fix width and separator of ToolButtonComplexControl outline w/ dropdown….
Fri, Aug 16, 5:26 PM
ndavis added a comment to D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu.

Hi Noah
Thanks for the patch, however, it is not the right fix to the issue. If you use a light color scheme (like the default breeze), you will see that the shadow below the part of the button that corresponds to the arrow is darker than below the rest of the button. This is because the frame is actually rendered twice.

Now, the bug you try to fix is real, and as I was 100% sure that it was not there in the past, I used git bisect to track it down to this commit:

32d8b02880a237e6de415861500a018a5cd09781

The corresponding diff contains
@@ -5988,7 +5988,6 @@ namespace Breeze

// frame
if( toolButtonOption->subControls & SC_ToolButton )
{
  • copy.rect = buttonRect; if( inTabBar ) drawTabBarPanelButtonToolPrimitive( &copy, painter, widget ); else drawPrimitive( PE_PanelButtonTool, &copy, painter, widget); }

    Which is what causes the issue. Could you revert this commit, and push instead the proper fix that I will post in another comment ?

    Alternatively, I can do it myself. Note that your changes on the separator position is legit, but should be a different patch
Fri, Aug 16, 5:24 PM · Plasma
ndavis added a comment to D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu.
Fri, Aug 16, 5:03 PM · Plasma

Thu, Aug 15

ndavis added a comment to D23170: Fix colors from KStatefulBrushes not using application colorschemes.

Sounds like you know more than me. Still, the top one is inside a no-KDE4 ifdef, if I'm reading the code right.

Thu, Aug 15, 7:50 PM · Plasma
ndavis committed R31:b43e19e3e13c: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu (authored by ndavis).
Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu
Thu, Aug 15, 7:30 PM
ndavis closed D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu.
Thu, Aug 15, 7:30 PM · Plasma
ndavis added a comment to D23170: Fix colors from KStatefulBrushes not using application colorschemes.

I thought the hex values were used because it's also supposed to be possible to compile Breeze for Qt 4? I remember reading that Qt 4 needs hex numbers for some reason.

Thu, Aug 15, 7:26 PM · Plasma
ndavis updated the diff for D23170: Fix colors from KStatefulBrushes not using application colorschemes.

Add event filter for Qt < 5.13

Thu, Aug 15, 7:22 PM · Plasma
ndavis added a comment to D23170: Fix colors from KStatefulBrushes not using application colorschemes.

How likely is it for distros using Qt < 5.13 to receive an update to Breeze that isn't a backport?

Do you mean to say that this is fixed already in Qt 5.13?

Thu, Aug 15, 6:28 PM · Plasma
ndavis updated the summary of D23170: Fix colors from KStatefulBrushes not using application colorschemes.
Thu, Aug 15, 9:15 AM · Plasma
ndavis updated the test plan for D23170: Fix colors from KStatefulBrushes not using application colorschemes.
Thu, Aug 15, 9:13 AM · Plasma
ndavis added a comment to D23170: Fix colors from KStatefulBrushes not using application colorschemes.

How likely is it for distros using Qt < 5.13 to receive an update to Breeze?

Thu, Aug 15, 9:08 AM · Plasma
ndavis updated the summary of D23170: Fix colors from KStatefulBrushes not using application colorschemes.
Thu, Aug 15, 9:07 AM · Plasma
ndavis requested review of D23170: Fix colors from KStatefulBrushes not using application colorschemes.
Thu, Aug 15, 9:05 AM · Plasma
ndavis updated the summary of D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu.
Thu, Aug 15, 8:54 AM · Plasma
ndavis updated the test plan for D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu.
Thu, Aug 15, 8:47 AM · Plasma
ndavis updated the test plan for D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu.
Thu, Aug 15, 8:46 AM · Plasma
ndavis requested review of D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu.
Thu, Aug 15, 8:43 AM · Plasma
ndavis added a comment to D23075: Change default Dolphin toolbar layout.

Wow, this is quite a radical change :)

I'm not against changing the default layout, but we should be 100% sure to get it right. It would be very annoying if we have to change it again in six months because people didn't like it.

My comments after a quick try:

  1. I don't think we should add the "Go Up" button because you can already achieve the same action by using the url navigator buttons.
Thu, Aug 15, 12:21 AM · VDG, Dolphin

Wed, Aug 14

ndavis requested changes to D23161: Make media control icons outline style instead of solid style.

We don't strictly adhere to outline or filled style (for better or worse), sometimes making use of both styles in the same icon (e.g., view-list-icons). I think the general idea is that we normally use the line/outline style unless that puts the designer at a disadvantage. Icons can look messy with the outline style sometimes.

Wed, Aug 14, 8:19 PM · Frameworks
ndavis added a comment to T11124: Unify highlight effect style.
In T11124#195358, @mglb wrote:

List view/sidebar highlight: why the vertical bright line is on right (internal) side? Wouldn't it look better on left (outside)?

Wed, Aug 14, 12:05 AM · VDG

Tue, Aug 13

ndavis accepted D23116: Fix missing digit and pixel-perfect alignment of depth action icons.

I thought about that, too, and while the red used in the icon is exactly NegativeText, the blue in the current icon is darker and has a less vibrant hue than ButtonFocus, so I'm not quite comfortable with using that for the blue color. Do we have this darker blue as a CSS color that we can use in this way? I see this dark blue is also used in the channelmixer icon, which has its colors hardcoded as well. I also don't think it would make sense to only use stylesheet colors for only one of these two colors.

Tue, Aug 13, 11:08 PM · Frameworks
ndavis requested changes to D23116: Fix missing digit and pixel-perfect alignment of depth action icons.

Not having id="current-color-scheme" causes stylesheets to not work correctly.

Tue, Aug 13, 5:43 AM · Frameworks

Mon, Aug 12

ndavis added a comment to D23075: Change default Dolphin toolbar layout.
In D23075#510697, @GB_2 wrote:


This is my final proposal with a category structure.

Mon, Aug 12, 5:48 PM · VDG, Dolphin
ndavis added a comment to D23075: Change default Dolphin toolbar layout.
In D23075#510680, @GB_2 wrote:
In D23075#510674, @GB_2 wrote:


Is this better?

I think the view mode buttons should be replaced by the single View Mode menu button. Unlabelled icons are a bad idea unless the symbol is very common and very distinct. I don't think it's reasonable to expect people to understand the compact mode and icon mode icons without looking at the tooltip.

I think the Sort By button should also be on the left.

If a Create New button is also added after more discussion, I think it should also be on the left.

Did you read my comments about the view mode button?

Mon, Aug 12, 8:37 AM · VDG, Dolphin
ndavis added a comment to D23075: Change default Dolphin toolbar layout.
In D23075#510674, @GB_2 wrote:


Is this better?

Mon, Aug 12, 7:57 AM · VDG, Dolphin
ndavis added a comment to D23075: Change default Dolphin toolbar layout.

Make sure the default layout doesn't look lopsided when the application menu is enabled instead of the control button.

It does look kinda lopsided but I am not sure if it is worth it to change the default look because of that.

Mon, Aug 12, 2:05 AM · VDG, Dolphin
ndavis added a comment to D23075: Change default Dolphin toolbar layout.

They are enabled by default.

Mon, Aug 12, 1:53 AM · VDG, Dolphin

Sun, Aug 11

ndavis committed R266:18c7af79891c: Make 16px folder-activites look more like larger sizes (authored by ndavis).
Make 16px folder-activites look more like larger sizes
Sun, Aug 11, 9:52 PM
ndavis closed D23104: Make 16px folder-activites look more like larger sizes.
Sun, Aug 11, 9:52 PM · Frameworks
ndavis updated the test plan for D23104: Make 16px folder-activites look more like larger sizes.
Sun, Aug 11, 8:39 PM · Frameworks
ndavis updated the test plan for D23104: Make 16px folder-activites look more like larger sizes.
Sun, Aug 11, 8:38 PM · Frameworks
ndavis updated the test plan for D23104: Make 16px folder-activites look more like larger sizes.
Sun, Aug 11, 8:38 PM · Frameworks
ndavis requested review of D23104: Make 16px folder-activites look more like larger sizes.
Sun, Aug 11, 8:28 PM · Frameworks
ndavis added a comment to T10997: Improve check box design.

I still think 3 horizontal dots is the best form of half checked state proposed here.

Sun, Aug 11, 7:01 PM · VDG, Breeze
ndavis added a comment to D23075: Change default Dolphin toolbar layout.

We should probably keep the show preview button unless we want to enable previews by default.

Sun, Aug 11, 6:44 PM · VDG, Dolphin

Sat, Aug 10

ndavis added a comment to D23075: Change default Dolphin toolbar layout.

Make sure the default layout doesn't look lopsided when the application menu is enabled instead of the control button.

Sat, Aug 10, 7:44 PM · VDG, Dolphin
ndavis committed R31:40c8d2d805ee: Update colorschemes (authored by ndavis).
Update colorschemes
Sat, Aug 10, 7:06 PM
ndavis added a comment to T10891: Breeze theme evolution.

The first highlighted pushbutton (where the cursor is) is less visible in your version than noah's due to the contrast.

Sat, Aug 10, 11:12 AM · VDG, Breeze
ndavis added a comment to D23063: [lockscreen] Fit album art to defined geometry.

+1, seems like a good idea.

Sat, Aug 10, 1:55 AM · Plasma
ndavis added a comment to T10891: Breeze theme evolution.

So what do you think about these colors? I chose them by taking Plasma Blue (#3daee9) from the KDE HIG and adjusting the brightness with HSLuv.org. The selection background color is 1/2 the brightness and the hover background is 2/3. I don't really know how to pick colors, so I'm taking a somewhat conservative approach where new colors are at least somewhat based on existing ones.

Sat, Aug 10, 1:50 AM · VDG, Breeze

Fri, Aug 9

ndavis added a comment to T10891: Breeze theme evolution.

Here's another set of dark theme mockups (and some miscellaneous modifications to tabs, sidebars, title bars) :

And the original screenshots I used as a base, for comparison:

Fri, Aug 9, 11:02 PM · VDG, Breeze
ndavis committed R31:584d38f47400: Change toolbutton style (authored by ndavis).
Change toolbutton style
Fri, Aug 9, 5:49 AM
ndavis committed R120:c4b360dda360: [notifications] Remove unread counter, use icon instead (authored by ndavis).
[notifications] Remove unread counter, use icon instead
Fri, Aug 9, 5:43 AM
ndavis closed D23018: [notifications] Remove unread counter, use icon instead.
Fri, Aug 9, 5:43 AM · Plasma
ndavis committed R120:63680780bb4c: Merge branch 'Plasma/5.16' (authored by ndavis).
Merge branch 'Plasma/5.16'
Fri, Aug 9, 2:09 AM
ndavis committed R120:4c11f4cd2e92: [notifications] Change default icon to notification-inactive (authored by ndavis).
[notifications] Change default icon to notification-inactive
Fri, Aug 9, 2:03 AM
ndavis closed D23033: [notifications] Change default icon to notification-inactive.
Fri, Aug 9, 2:03 AM · Plasma
ndavis added a comment to D23019: Make notification icons look like bells.

@broulik With D23033, the notification-disabled element will be unused. Do you still require changes to this patch?

Fri, Aug 9, 2:00 AM · Frameworks

Thu, Aug 8

ndavis updated the summary of D23018: [notifications] Remove unread counter, use icon instead.
Thu, Aug 8, 11:19 PM · Plasma
ndavis retitled D23018: [notifications] Remove unread counter, use icon instead from [notifications] Remove unread counter, use icons instead to [notifications] Remove unread counter, use icon instead.
Thu, Aug 8, 11:19 PM · Plasma
ndavis updated the test plan for D23018: [notifications] Remove unread counter, use icon instead.
Thu, Aug 8, 10:23 PM · Plasma
ndavis updated the test plan for D23033: [notifications] Change default icon to notification-inactive.
Thu, Aug 8, 10:20 PM · Plasma
ndavis updated the test plan for D23018: [notifications] Remove unread counter, use icon instead.
Thu, Aug 8, 10:19 PM · Plasma
ndavis updated the summary of D23033: [notifications] Change default icon to notification-inactive.
Thu, Aug 8, 10:18 PM · Plasma
ndavis updated the test plan for D23033: [notifications] Change default icon to notification-inactive.
Thu, Aug 8, 10:17 PM · Plasma
ndavis edited dependencies for D23019: Make notification icons look like bells, added: 1; removed: 1.
Thu, Aug 8, 10:15 PM · Frameworks
ndavis removed a dependent revision for D23018: [notifications] Remove unread counter, use icon instead: D23019: Make notification icons look like bells.
Thu, Aug 8, 10:15 PM · Plasma
ndavis added a dependent revision for D23033: [notifications] Change default icon to notification-inactive: D23019: Make notification icons look like bells.
Thu, Aug 8, 10:15 PM · Plasma
ndavis requested review of D23033: [notifications] Change default icon to notification-inactive.
Thu, Aug 8, 10:15 PM · Plasma
ndavis updated the diff for D23018: [notifications] Remove unread counter, use icon instead.
  • Don't change default icon
Thu, Aug 8, 7:24 PM · Plasma
ndavis added a comment to D23019: Make notification icons look like bells.

You can't repurpose icon ids for different meanings:


This is what the "no notifications" case looks like now with the old applet.

Thu, Aug 8, 7:51 AM · Frameworks
ndavis updated the diff for D23018: [notifications] Remove unread counter, use icon instead.
  • Hide label by default
Thu, Aug 8, 7:15 AM · Plasma
ndavis updated the test plan for D23018: [notifications] Remove unread counter, use icon instead.
Thu, Aug 8, 7:11 AM · Plasma
ndavis added a comment to D23019: Make notification icons look like bells.

Screenshots, please.
The question is what about the transition when this is released in Frameworks but the Plasma version with the change isn't yet.

Thu, Aug 8, 7:03 AM · Frameworks
ndavis updated the test plan for D23019: Make notification icons look like bells.
Thu, Aug 8, 7:01 AM · Frameworks