FrameworksRelease
ActivePublic

Watchers

  • This project does not have any watchers.

Recent Activity

Today

apol created D9292: Remove premise that doesn't apply anymore.
Tue, Dec 12, 1:03 AM · Frameworks
apol abandoned D9167: Improve string handling.

:( when I rebased to current master I realized that @mlaurent worked on a very similar patch without going through review (which btw is policy in KDE Frameworks).

Tue, Dec 12, 1:02 AM · Frameworks
apol added a comment to D9167: Improve string handling.

Thanks!

Tue, Dec 12, 12:57 AM · Frameworks

Yesterday

dhaumann updated the diff for D9257: MessageInterface: Add CenterInView as additional position.
  • Honor spacing for message widgets
Mon, Dec 11, 10:23 PM · Frameworks, Kate
dhaumann updated the diff for D9257: MessageInterface: Add CenterInView as additional position.
  • Remove unneeded include
Mon, Dec 11, 10:18 PM · Frameworks, Kate
dhaumann updated the diff for D9257: MessageInterface: Add CenterInView as additional position.
  • Simplify MessageWidget member variable handling
Mon, Dec 11, 10:16 PM · Frameworks, Kate
dhaumann added a comment to D9219: WIP: Extend Scripting API.

@cullmann Did you intentionally request changes or was that by accident and you meant Accept?

Mon, Dec 11, 9:38 PM · Frameworks, Kate
dhaumann added a comment to D9211: Iterate over initializer_lists to avoid mem allocs.

@mwolff I still would like to know from you whether you think this patch makes thinks better: I need additional helper functions etc. just to use the STL to avoid these allocs. Additional helper functions are added complexity, since it's not standard Qt stuff that everyone typically knows out of the box. That's why I am asking :-) So I for one see benefits and drawbacks ;)

Mon, Dec 11, 9:35 PM · Frameworks, Kate
rjvbb added a comment to D9289: KCompletionBox: restore proper layering behaviour on Mac.

kurlrequestertest_gui on Mac, unpatched frameworks 5.38, Qt 5.8.0:

Mon, Dec 11, 8:33 PM · Frameworks
petermajchrak updated the diff for D8536: Add more hashing algorithms to KPropertiesDialog.

Small code tweaks, nothing that changes functionality

Mon, Dec 11, 8:31 PM · Frameworks
graesslin added a comment to D9207: Don't load KDE platform module in kglobalaccel5.
In D9207#178257, @apol wrote:

I'm against a risky change here. Especially as this becomes irrelevant with Wayland.

What makes it risky?

Mon, Dec 11, 8:30 PM · Frameworks, Plasma
dfaure added a comment to D9290: [filewidgets] Fix create path.

Yes, QUrl::addPath would really be convenient.
Meanwhile, make an addPath helper that just does if !endsWith('/') append('/')

Mon, Dec 11, 8:19 PM · Frameworks
anthonyfieroni added a comment to D9290: [filewidgets] Fix create path.

Something like

QString makePath(QString path)
{
    return QDir::cleanPath(path);
}
Mon, Dec 11, 8:08 PM · Frameworks
ltoscano updated the summary of D9289: KCompletionBox: restore proper layering behaviour on Mac.
Mon, Dec 11, 7:59 PM · Frameworks
anthonyfieroni created D9290: [filewidgets] Fix create path.
Mon, Dec 11, 7:44 PM · Frameworks
rjvbb edited reviewers for D9289: KCompletionBox: restore proper layering behaviour on Mac, added: Frameworks; removed: Framework: Syntax Highlighting.
Mon, Dec 11, 7:25 PM · Frameworks
rjvbb updated the summary of D9289: KCompletionBox: restore proper layering behaviour on Mac.
Mon, Dec 11, 7:25 PM · Frameworks
rjvbb created D9289: KCompletionBox: restore proper layering behaviour on Mac.
Mon, Dec 11, 7:23 PM · Frameworks
davidedmundson added a comment to D9287: disappearing scrollbars on mobile.

If we have a runtime dep, we need to make it explicit in CMakeLists.txt.

Mon, Dec 11, 1:37 PM · Frameworks, Plasma
mart created D9287: disappearing scrollbars on mobile.
Mon, Dec 11, 1:27 PM · Frameworks, Plasma
mart created D9286: don't multiply svg sizes by devicepixelratio.
Mon, Dec 11, 1:05 PM · Frameworks, Plasma
davidedmundson requested changes to D9197: experimental support for rcc files loading in kpackage.

Needs tests and docs

Mon, Dec 11, 9:18 AM · Frameworks, Plasma
mlaurent added a comment to D9277: Remove cmake warning about generating moc file.

@dfaure yep I rebuild all qt5.10 so yep :)

Mon, Dec 11, 8:24 AM · Frameworks
dfaure added a comment to D9277: Remove cmake warning about generating moc file.

Do you have qtbase commit b71b7461b0 ?

Mon, Dec 11, 8:09 AM · Frameworks
dfaure closed D9213: KUriFilter: port away from KServiceTypeTrader.
Mon, Dec 11, 8:02 AM · Frameworks
dfaure closed D9213: KUriFilter: port away from KServiceTypeTrader.
Mon, Dec 11, 8:02 AM · Frameworks
mlaurent added a comment to D9277: Remove cmake warning about generating moc file.

@apol do you have cmake >= 3.10 ?

Mon, Dec 11, 5:45 AM · Frameworks
mlaurent added a comment to D9277: Remove cmake warning about generating moc file.

@apol do you have an example of class which generate signal/slot ?

Mon, Dec 11, 5:42 AM · Frameworks
anthonyfieroni closed D9128: [knewstuff] Respect global variable.
Mon, Dec 11, 4:46 AM · Frameworks
mpyne added a comment to D9277: Remove cmake warning about generating moc file.

@aacid you might be thinking of my KI18n fix for ui*.h files in D9118, but I'm sure there's other examples.

Mon, Dec 11, 3:03 AM · Frameworks
mpyne added a comment to D9128: [knewstuff] Respect global variable.

OK, if no one else has objections I'd say to commit.

Mon, Dec 11, 3:02 AM · Frameworks
apol accepted D9223: [Plasma Dialog] Call window effects only if visible.
Mon, Dec 11, 1:07 AM · Frameworks, Plasma

Sun, Dec 10

apol added a comment to D9277: Remove cmake warning about generating moc file.

Can you confirm that it still compiles properly in the cases where the class generates signals/slots/properties?

Sun, Dec 10, 11:54 PM · Frameworks
apol accepted D9213: KUriFilter: port away from KServiceTypeTrader.

LGTM

Sun, Dec 10, 11:40 PM · Frameworks
apol accepted D9211: Iterate over initializer_lists to avoid mem allocs.
Sun, Dec 10, 11:33 PM · Frameworks, Kate
apol added a comment to D9207: Don't load KDE platform module in kglobalaccel5.

I'm against a risky change here. Especially as this becomes irrelevant with Wayland.

Sun, Dec 10, 11:28 PM · Frameworks, Plasma
apol added a comment to D9197: experimental support for rcc files loading in kpackage.

What's the plan here?

Sun, Dec 10, 11:26 PM · Frameworks, Plasma
Restricted Application edited projects for D9136: Add support for version 3 of data device manager interface, added: Plasma on Wayland; removed Plasma.
Sun, Dec 10, 10:45 PM · Plasma on Wayland, Frameworks
Restricted Application edited projects for D9136: Add support for version 3 of data device manager interface, added: Plasma; removed Plasma on Wayland.
Sun, Dec 10, 7:23 PM · Plasma on Wayland, Frameworks
mlaurent added a comment to D9277: Remove cmake warning about generating moc file.

it's seems that it was not fixed as I updated my kde last friday afternoon.
and this morning I was this problem.

Sun, Dec 10, 5:39 PM · Frameworks
Restricted Application edited projects for D9136: Add support for version 3 of data device manager interface, added: Plasma on Wayland; removed Plasma.

lgtm

Sun, Dec 10, 4:56 PM · Plasma on Wayland, Frameworks
Restricted Application edited projects for D9136: Add support for version 3 of data device manager interface, added: Plasma; removed Plasma on Wayland.

ping

Sun, Dec 10, 4:50 PM · Plasma on Wayland, Frameworks
elvisangelaccio updated the diff for D8336: Improve apidox of KJobTrackerInterface.
  • Dropped TODO, there is not enough evidence that this method should become protected.
Sun, Dec 10, 3:42 PM · Frameworks
aacid added a comment to D9277: Remove cmake warning about generating moc file.

Wasn't this fixed recently in ecm? Or does kconfig needs an extra fix in addition to the fix in ecm?

Sun, Dec 10, 3:01 PM · Frameworks
rkflx added a comment to D8296: Use Ctrl+Shift+, as the standard shortcut for "Configure <Program>".
In D8296#162352, @rkflx wrote:

As mentioned in the bug, we should wait until after digiKam has had a release containing the change, i.e. 5.8.0. Provoking the dreaded shortcut warning dialog would be a bad way to say "thank you". Roadmap and NEWS say the release was planned for 2017-10-29, but it is still not tagged.

Sun, Dec 10, 11:47 AM · Frameworks
dhaumann added a comment to D8371: Support for underscores in numeric literals (Python 3.6).

Btw: To update the reference, you can simply execute

Sun, Dec 10, 11:43 AM · Frameworks, Framework: Syntax Highlighting
mlaurent added reviewers for D9277: Remove cmake warning about generating moc file: kfunk, dfaure.
Sun, Dec 10, 11:31 AM · Frameworks
mlaurent created D9277: Remove cmake warning about generating moc file.
Sun, Dec 10, 11:30 AM · Frameworks
cullmann added a comment to D8371: Support for underscores in numeric literals (Python 3.6).
In D8371#178009, @januz wrote:

b) an extended unit test would be nice, to really show that the regex are right.

Hi, sure. Is there any documentation on how to make those tests? I noticed there are some ref and input files, do I just modify those and run the tests?

Sun, Dec 10, 10:40 AM · Frameworks, Framework: Syntax Highlighting
dfaure closed D8545: kio: fix handling of KCookieAdvice::AcceptForSession.

https://commits.kde.org/kio/efeda6c1cc905913ef8cf587d966264d0135aba0

Sun, Dec 10, 9:23 AM · Frameworks