FrameworksRelease
ActivePublic

Recent Activity

Today

This revision was not accepted when it landed; it landed in state Needs Review.
Sun, Feb 25, 9:23 PM · Frameworks
kmorwinski removed a watcher for Frameworks: kmorwinski.
Sun, Feb 25, 8:58 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Sun, Feb 25, 8:58 PM · Frameworks
kossebau added a comment to D10732: Help automoc to find metadata JSON files referenced in the code.

Given there was no principal objection and this code is following the pattern of D10724, going to push now as well, so it gets some more field-testing before next weeks tagging.

Sun, Feb 25, 8:49 PM · Frameworks
kossebau added a comment to D10733: Help automoc to find metadata JSON files referenced in the code.

Given this code is the same as D10724, going to push now as well, so it gets some more field-testing before next weeks tagging.

Sun, Feb 25, 8:36 PM · Frameworks
markg added a comment to D10414: Add move semantics support to KIO::UDSEntry..

I seem to be making a mess of this commit. Sorry for that.
https://p.sc2.nl/B13Etcldf with the changes.

Sun, Feb 25, 8:16 PM · Frameworks
dfaure added inline comments to D10414: Add move semantics support to KIO::UDSEntry..
Sun, Feb 25, 8:02 PM · Frameworks
michaelh added a comment to D10826: Introduce DocumentId class.

@svuorela: Thank you very much. I will try you suggestion as soon as I'm able to get the tests compiled.

Sun, Feb 25, 7:41 PM · Frameworks, Baloo
dfaure added a comment to D10124: Faster simplejob start.

This commit leads to

Sun, Feb 25, 7:36 PM · Frameworks
dfaure requested changes to D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying.

I don't like the idea of a flag for this in the API. It just moves the problem (of whether it's safe / a good idea to clean up) to the applications, who are not in a better place to decide about this. Better make it happen all the time, and better make it work right. A flag almost sounds like a excuse for a half-hearted feature ("if it works badly in case XYZ, then apps can just opt out"). I don't see why the app would care, really. It wants to copy A to B, and wants to know if it worked or not; details like cleaning up on cancel are best handled by the KIO library.

Sun, Feb 25, 7:13 PM · Frameworks
markg added a comment to D10702: Always use a job to delete files to avoid freezing process waiting on IO.

"unlink() in most of the modern filesystems is not affected by the size of the file" doesn't match my experience, I have seen konqueror/dolphin freeze for 10s while deleting a 8GB file (on a somewhat old system, no SSD). And that would actually be the reason for this patch to go in. But on the other hand, I have a hard time believing that this patch doesn't make things slower for the case of many small files, due to the communication overhead with the kioslave (and that's the reason I wrote this code in the first place).

Maybe the right solution is to use QFile::remove if the file is small, and use the kioslave if the file is big. But finding the file size in the first place takes a little bit of time too :-)

Sun, Feb 25, 6:42 PM · Frameworks
dfaure requested changes to D10702: Always use a job to delete files to avoid freezing process waiting on IO.

"unlink() in most of the modern filesystems is not affected by the size of the file" doesn't match my experience, I have seen konqueror/dolphin freeze for 10s while deleting a 8GB file (on a somewhat old system, no SSD). And that would actually be the reason for this patch to go in. But on the other hand, I have a hard time believing that this patch doesn't make things slower for the case of many small files, due to the communication overhead with the kioslave (and that's the reason I wrote this code in the first place).

Sun, Feb 25, 6:23 PM · Frameworks
svuorela added a comment to D10826: Introduce DocumentId class.

A quick review of some quirks and weirdnesses in c++

Sun, Feb 25, 5:48 PM · Frameworks, Baloo
michaelh added a comment to D10803: handle more tags in taglibextractor.

I don't know dolphin works, but given how KFileMetadata is designed, the new tags should be ignored until explicit support is added in dolphin.

Please try that. For unknown types baloo-widgets (responsible for infopanel/tooltips) falls back to value.toString(), no idea what will happen when you feed it with binary data. The cover properties return binary data, right?

Sun, Feb 25, 5:31 PM · Frameworks
mgallien updated subscribers of D10803: handle more tags in taglibextractor.
Sun, Feb 25, 5:22 PM · Frameworks
astippich added a comment to D10803: handle more tags in taglibextractor.

I don't know dolphin works, but given how KFileMetadata is designed, the new tags should be ignored until explicit support is added in dolphin.

Sun, Feb 25, 5:04 PM · Frameworks
michaelh added a comment to D10803: handle more tags in taglibextractor.

Nice! How do the infopanel or tooltips of dolphin look with this?

Sun, Feb 25, 4:05 PM · Frameworks
mgallien added a comment to D10694: epubextractor: Handle multiple subjects better.

The only component I could find to be affected by this change is baloo-widgets. I have already adapted it to this change. And yes, it will handle both.
It will take a some time to publish it because some other stuff has to get reviewed first.
I you know of any component or application using the epub-extractor of KFileMetadata apart from baloo-widgets please let me know.

Sun, Feb 25, 3:15 PM · Frameworks, Dolphin, Baloo
michaelh added a comment to D10807: fileindexerconfig: Exclude Vaults by default.

What about users who manually create and mount FUSE-type encrypted directories? Plasma Vault is just a nice interface for this workflow, after all.

Good point.

Sun, Feb 25, 2:40 PM · Plasma, Frameworks, Baloo
michaelh closed D10823: idutils: Fix typo.
Sun, Feb 25, 1:24 PM · Frameworks, Baloo
graesslin closed D10142: [server] Properly handle the situation when the DataSource for a drag gets destroyed.
Sun, Feb 25, 1:15 PM · Plasma, Frameworks
adridg accepted D10823: idutils: Fix typo.

I'm so happy :)

Sun, Feb 25, 12:33 PM · Frameworks, Baloo
michaelh added a comment to D10829: Use DocumentId class.

That's great. Any clues to solve this?

[ 35%] Building CXX object src/file/extractor/autotests/CMakeFiles/extractorIOTest.dir/__/iohandler.cpp.o
[ 35%] Linking CXX executable ../../../../bin/extractorIOTest
CMakeFiles/extractorIOTest.dir/__/iohandler.cpp.o: In function `Baloo::IOHandler::nextId()':
/home/super/devel/kde/src/frameworks/baloo-flex/src/file/extractor/iohandler.cpp:46: undefined reference to `Baloo::DocumentId::DocumentId(unsigned long long)'
/home/super/devel/kde/src/frameworks/baloo-flex/src/file/extractor/iohandler.cpp:49: undefined reference to `Baloo::DocumentId::operator unsigned long long() const'
collect2: error: ld returned 1 exit status
Sun, Feb 25, 12:23 PM · Frameworks, Baloo
michaelh updated the diff for D10829: Use DocumentId class.
  • idutils: Use DocumentId constructor
  • DocumentId: Add 'QDebug operator<<'
Sun, Feb 25, 12:17 PM · Frameworks, Baloo
chinmoyr edited dependencies for D10437: Update file ioslave's temporary authorization list, added: 1; removed: 1.
Sun, Feb 25, 12:01 PM · Frameworks
chinmoyr added a dependent revision for D10818: Store PolicyKit action which the slave is authorized to perform: D10437: Update file ioslave's temporary authorization list.
Sun, Feb 25, 12:01 PM · Frameworks
chinmoyr removed a dependent revision for D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave: D10437: Update file ioslave's temporary authorization list.
Sun, Feb 25, 12:01 PM · Frameworks
chinmoyr added a dependent revision for D10568: Handle privilege operation confirmation prompts in SlaveBase: D10818: Store PolicyKit action which the slave is authorized to perform.
Sun, Feb 25, 11:59 AM · Frameworks
chinmoyr added a dependency for D10818: Store PolicyKit action which the slave is authorized to perform: D10568: Handle privilege operation confirmation prompts in SlaveBase.
Sun, Feb 25, 11:59 AM · Frameworks
chinmoyr removed a dependency for D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave: D10568: Handle privilege operation confirmation prompts in SlaveBase.
Sun, Feb 25, 11:58 AM · Frameworks
chinmoyr removed a dependent revision for D10568: Handle privilege operation confirmation prompts in SlaveBase: D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave.
Sun, Feb 25, 11:58 AM · Frameworks
chinmoyr added a dependent revision for D10820: Send slave's polkit authorization status to the host: D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave.
Sun, Feb 25, 11:56 AM · Frameworks
chinmoyr added a dependency for D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave: D10820: Send slave's polkit authorization status to the host.
Sun, Feb 25, 11:56 AM · Frameworks
michaelh added a comment to D10829: Use DocumentId class.

@alexeymin: Could you use inline comments, please. That would help me a lot. And: thank you for your comments. It is really nice to have someone commenting without me poking first. ;-)

Sun, Feb 25, 11:56 AM · Frameworks, Baloo
chinmoyr updated the summary of D10820: Send slave's polkit authorization status to the host.
Sun, Feb 25, 11:52 AM · Frameworks
chinmoyr added a dependent revision for D10818: Store PolicyKit action which the slave is authorized to perform: D10820: Send slave's polkit authorization status to the host.
Sun, Feb 25, 11:52 AM · Frameworks
chinmoyr added a dependent revision for D10820: Send slave's polkit authorization status to the host: D10822: Store temporary authorization status in IdleSlave.
Sun, Feb 25, 11:49 AM · Frameworks
chinmoyr updated the summary of D10822: Store temporary authorization status in IdleSlave.
Sun, Feb 25, 11:49 AM · Frameworks
chinmoyr triaged T8075: Fix security issues with KAuth support in KIO as High priority.
Sun, Feb 25, 11:44 AM · Frameworks
alexeymin added a comment to D10829: Use DocumentId class.

To solve this warning you need to fix DocumentId class, add operator<<() for QDebug.

Sun, Feb 25, 11:43 AM · Frameworks, Baloo
dhaumann closed D9211: Iterate over initializer_lists to avoid mem allocs.

Committed with https://cgit.kde.org/ktexteditor.git/commit/?id=ac8f9f61a0d160a04fd46cb7f87b1509987892aa

Sun, Feb 25, 11:42 AM · Frameworks, Kate
dhaumann added a comment to D9211: Iterate over initializer_lists to avoid mem allocs.

Mark comments as done.

Sun, Feb 25, 11:40 AM · Frameworks, Kate
michaelh added inline comments to D10825: Introduce aliases DocId, DeviceId and Inode.
Sun, Feb 25, 11:39 AM · Frameworks, Baloo
michaelh added a comment to D10825: Introduce aliases DocId, DeviceId and Inode.

This gives a bunch of warnings like

src/engine/idutils.h:48:43: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
     return *(reinterpret-cast<DocId*>(arr));

Were these before...?

Sun, Feb 25, 11:34 AM · Frameworks, Baloo
alexeymin added a comment to D10825: Introduce aliases DocId, DeviceId and Inode.

This gives a bunch of warnings like

src/engine/idutils.h:48:43: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
    return *(reinterpret-cast<DocId*>(arr));

Were these before...?

Sun, Feb 25, 11:30 AM · Frameworks, Baloo
chinmoyr updated the diff for D10437: Update file ioslave's temporary authorization list.

Updated function name.
Updated title and summary.
With this it is the third time I am completely changing the title and summary. When will it be too much? Or should I create a new patch everytime there's a change in approach?

Sun, Feb 25, 11:28 AM · Frameworks
michaelh added a comment to D10823: idutils: Fix typo.

Maybe such kinds of changes can be committed without review? ;)

This is to make @adridg happy. The real fun starts, when you take a look at the stack of this.

Sun, Feb 25, 11:27 AM · Frameworks, Baloo
michaelh added a dependency for D10829: Use DocumentId class: D10826: Introduce DocumentId class.
Sun, Feb 25, 11:17 AM · Frameworks, Baloo
michaelh added a dependent revision for D10826: Introduce DocumentId class: D10829: Use DocumentId class.
Sun, Feb 25, 11:17 AM · Frameworks, Baloo
michaelh updated the summary of D10829: Use DocumentId class.
Sun, Feb 25, 11:16 AM · Frameworks, Baloo