FrameworksRelease
ActivePublic

Recent Activity

Today

chinmoyr added a comment to D12291: Accept file descriptor only from root owned process.

@ossi would you mind reviewing this patch?

Sun, May 27, 11:34 AM · Frameworks
chinmoyr updated the diff for D12291: Accept file descriptor only from root owned process.

I only realized now that after making the previous change I forgot to rebase.
So uploading correct patch.

Sun, May 27, 11:31 AM · Frameworks
ossi accepted D12745: Unify API for file descriptor sharing.
Sun, May 27, 11:28 AM · Frameworks
chinmoyr updated the diff for D12745: Unify API for file descriptor sharing.

Used std::string

Sun, May 27, 11:20 AM · Frameworks
chinmoyr removed a dependency for D10409: In linux don't use abstract socket to share file descriptor: D10273: Create proper SocketAddress.
Sun, May 27, 11:14 AM · Frameworks
chinmoyr removed a dependent revision for D10273: Create proper SocketAddress: D10409: In linux don't use abstract socket to share file descriptor.
Sun, May 27, 11:14 AM · Frameworks
chinmoyr removed a dependent revision for D9966: [KIO] Fix issues with sharing of file descriptor: D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver.
Sun, May 27, 11:13 AM · Frameworks
chinmoyr removed a dependency for D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver: D9966: [KIO] Fix issues with sharing of file descriptor.
Sun, May 27, 11:13 AM · Frameworks
ossi added a comment to D9966: [KIO] Fix issues with sharing of file descriptor.

this dependency tree is a mess. please remove deps to abandoned changes or unabandon what you actually still need, and linearize the history.

Sun, May 27, 11:10 AM · Frameworks
lueck closed D13120: fix i18n issues in framworks/purpose/plugins.
Sun, May 27, 11:08 AM · Frameworks
elvisangelaccio requested review of D13146: Drop old QString::null usage.
Sun, May 27, 11:08 AM · Frameworks
ossi accepted D12744: Add null pointer check when creating SocketAddress.
Sun, May 27, 11:04 AM · Frameworks
elvisangelaccio requested review of D13145: Check if destination exists also when pasting binary data.
Sun, May 27, 11:01 AM · Frameworks
ossi accepted D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver.

note that the commit message needs a minor adjustment now.

Sun, May 27, 11:00 AM · Frameworks
chinmoyr updated the diff for D12744: Add null pointer check when creating SocketAddress.

fixed the issues mentioned

Sun, May 27, 10:57 AM · Frameworks
chinmoyr updated the diff for D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver.

corrected the unlink position

Sun, May 27, 10:44 AM · Frameworks
chinmoyr updated the diff for D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver.

Do the first unlink in FdReceiver constructor

Sun, May 27, 10:41 AM · Frameworks
chinmoyr added a dependent revision for D9966: [KIO] Fix issues with sharing of file descriptor: D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver.
Sun, May 27, 10:41 AM · Frameworks
chinmoyr added a comment to D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver.

SocketAddress is used only in FdSender and FdRecevier.

Sun, May 27, 10:40 AM · Frameworks
ossi added a comment to D12745: Unify API for file descriptor sharing.

but so does using raw pointers. as the stl is available here anyway, it seems like the preferable abstraction layer.

Sun, May 27, 10:32 AM · Frameworks
chinmoyr added a comment to D12745: Unify API for file descriptor sharing.
In D12745#268946, @ossi wrote:

why aren't you standardizing on std::string? that's cleaner than raw char pointers.
i know we discussed this before to some degree, but i don't remember the particulars.

Sun, May 27, 10:27 AM · Frameworks
ossi added a comment to D12745: Unify API for file descriptor sharing.

why aren't you standardizing on std::string? that's cleaner than raw char pointers.
i know we discussed this before to some degree, but i don't remember the particulars.

Sun, May 27, 10:12 AM · Frameworks
nicolasfella added a comment to D13124: [RFC] Add Share action to Dolphin context menu.

Have you seen D12895?

Sun, May 27, 10:11 AM · Frameworks, Dolphin
ossi requested changes to D12744: Add null pointer check when creating SocketAddress.
Sun, May 27, 10:09 AM · Frameworks
ossi accepted D10411: Create socket file in user's runtime directory.
Sun, May 27, 10:00 AM · Frameworks
ossi requested changes to D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver.

did you make sure that this is the only place where SocketAddress is used?

Sun, May 27, 9:59 AM · Frameworks
broulik added a comment to D13124: [RFC] Add Share action to Dolphin context menu.

Have you seen D12895?

Sun, May 27, 8:48 AM · Frameworks, Dolphin

Yesterday

nicolasfella updated the diff for D13124: [RFC] Add Share action to Dolphin context menu.
  • Set mimetype to */* if reported mimetype is empty
Sat, May 26, 6:15 PM · Frameworks, Dolphin
nicolasfella updated the diff for D13124: [RFC] Add Share action to Dolphin context menu.

Make it a FileItemActionPlugin

Sat, May 26, 6:07 PM · Frameworks, Dolphin
alex-l added a comment to D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays.

Gray seems OK to me. And I confirm the bug with Saturday column.

Sat, May 26, 5:59 PM · Frameworks
drosca added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.

Looks fine, except some issues with methods that should be hidden:

Sat, May 26, 5:59 PM · Plasma, KDE Connect, Frameworks
alex-l updated the summary of D13137: Updated handles and overflow-menu-*.
Sat, May 26, 5:45 PM · Frameworks
alex-l requested review of D13137: Updated handles and overflow-menu-*.
Sat, May 26, 5:44 PM · Frameworks
elvisangelaccio closed D12728: KFileItemActions: fallback to default mimetype when selecting only files.
Sat, May 26, 4:46 PM · Frameworks
elvisangelaccio closed D12727: Introduce KFileItemListProperties::isFile().
Sat, May 26, 4:45 PM · Frameworks
ngraham added a comment to D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays.

I don't know. Perhaps it's time to involve more VDG people. VDG, how should we style weekend days and day names? Currently we draw them in dark red, which is problematic for a few reasons:

Sat, May 26, 1:55 PM · Frameworks
aacid added a comment to D13120: fix i18n issues in framworks/purpose/plugins.

if there's other places using the backslash it's fine, no need to change :)

Sat, May 26, 9:11 AM · Frameworks
jgrulich accepted D13117: Don't set custom domain filter rules.
Sat, May 26, 7:40 AM · Frameworks
lueck added a comment to D13120: fix i18n issues in framworks/purpose/plugins.

Are you sure you need the backslashes in add_definitions?

Sat, May 26, 7:00 AM · Frameworks
damienclochard requested review of D13131: Add general purpose data types for PostgreSQL.
Sat, May 26, 6:45 AM · Frameworks
damienclochard requested review of D13130: Add new DDL partitioning keywords.
Sat, May 26, 6:40 AM · Frameworks
rkflx added a comment to D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays.

Use conditional grays instead of reds (red was never an appropriate color anyway)

Sat, May 26, 6:20 AM · Frameworks
ngraham added reviewers for D13128: Make sure ungrab keyboard request is processed before emitting shortcut: Frameworks, Plasma.
Sat, May 26, 4:25 AM · Frameworks
sontolbonggol updated the summary of D13128: Make sure ungrab keyboard request is processed before emitting shortcut.
Sat, May 26, 4:08 AM · Frameworks
sontolbonggol requested review of D13128: Make sure ungrab keyboard request is processed before emitting shortcut.
Sat, May 26, 4:00 AM · Frameworks
ngraham updated the summary of D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays.
Sat, May 26, 3:12 AM · Frameworks
smithjd updated the diff for D11529: Balooctl: Deindex unfound files with check command..
  • Uniformly use storageDevices.
Sat, May 26, 12:55 AM · Baloo, Frameworks

Fri, May 25

dfaure accepted D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver.
Fri, May 25, 11:08 PM · Frameworks
dfaure requested changes to D12945: kcoredirlister lstItems benchmark.
Fri, May 25, 11:06 PM · Frameworks
dfaure accepted D12728: KFileItemActions: fallback to default mimetype when selecting only files.

It should be easy to use lxr to see which KDE applications uses KFileItemListProperties::mimeType(), but OK, your solution is safer in case of third-party applications.

Fri, May 25, 10:54 PM · Frameworks