FrameworksRelease
ActivePublic

Watchers

  • This project does not have any watchers.

Recent Activity

Today

davidedmundson added a comment to D8346: Remove blocking call in KStatusNotifierItem.

I've realised there's much more to do:

Tue, Oct 17, 6:13 PM · Frameworks
xuetianweng added inline comments to D8346: Remove blocking call in KStatusNotifierItem.
Tue, Oct 17, 5:58 PM · Frameworks
davidedmundson planned changes to D8346: Remove blocking call in KStatusNotifierItem.
Tue, Oct 17, 5:52 PM · Frameworks
xuetianweng added inline comments to D8346: Remove blocking call in KStatusNotifierItem.
Tue, Oct 17, 5:49 PM · Frameworks
davidedmundson created D8346: Remove blocking call in KStatusNotifierItem.
Tue, Oct 17, 5:41 PM · Frameworks
usta added inline comments to D8332: Added baloo urls into places model.
Tue, Oct 17, 5:01 PM · Frameworks
davidedmundson added a comment to D8321: Only check for legacy system tray icons if we're going to make one.

Trace is different, so ...progress!

Tue, Oct 17, 4:05 PM · Frameworks, Plasma
graesslin added a comment to D8321: Only check for legacy system tray icons if we're going to make one.

I'm sorry but it still deadlocks, see https://bugs.kde.org/show_bug.cgi?id=385867

Tue, Oct 17, 3:52 PM · Frameworks, Plasma
ngraham added a comment to D8296: Use Alt+, as the standard shortcut for "Configure <Program>".

Any objections to Alt+, ?

Tue, Oct 17, 3:32 PM · Frameworks
renatoo updated the diff for D8332: Added baloo urls into places model.

Fixed typos
Use QStringLiteral when possible

Tue, Oct 17, 1:44 PM · Frameworks
renatoo updated the diff for D8332: Added baloo urls into places model.

Fixed typos

Tue, Oct 17, 1:43 PM · Frameworks
helio closed D7884: - Increase size of trailing mark.
Tue, Oct 17, 11:46 AM · Frameworks, Kate
cullmann accepted D7884: - Increase size of trailing mark.

Then I would say => merge it.
And thanks for the work!

Tue, Oct 17, 11:34 AM · Frameworks, Kate
helio added a comment to D7884: - Increase size of trailing mark.
In D7884#154232, @sars wrote:

I'm OK with an option for this. The only problem, with the option in the screen-shot, is that it could be interpreted as also effecting the tabulator mark.

Tue, Oct 17, 11:33 AM · Frameworks, Kate
mlaurent added inline comments to D8332: Added baloo urls into places model.
Tue, Oct 17, 9:25 AM · Frameworks
dvratil closed D6665: Make kssl compile against OpenSSL 1.1.0.
Tue, Oct 17, 7:43 AM · Frameworks
dvratil requested changes to D8332: Added baloo urls into places model.
Tue, Oct 17, 7:38 AM · Frameworks
davidk added a comment to D8330: Open files in TagLib extractor readonly.

I am not sure about the qWarning.
I would prefer another opinion on that.

Tue, Oct 17, 7:33 AM · Frameworks
davidedmundson closed D8321: Only check for legacy system tray icons if we're going to make one.
Tue, Oct 17, 7:08 AM · Frameworks, Plasma
ngraham added a comment to D7130: KMoreTools: Update and fix desktopfiles.

I can confirm that this fixes https://bugs.kde.org/show_bug.cgi?id=384682. Updating that accordingly.

Tue, Oct 17, 1:25 AM · Frameworks

Yesterday

cfeck added a comment to D7130: KMoreTools: Update and fix desktopfiles.

This probably also fixes bug 384682. Can someone confirm?

Mon, Oct 16, 11:30 PM · Frameworks
renatoo updated the diff for D8332: Added baloo urls into places model.

Does not load baloo urls if file index is disabled

Mon, Oct 16, 9:18 PM · Frameworks
ngraham added reviewers for D8332: Added baloo urls into places model: Frameworks, Dolphin, KDE Applications.
Mon, Oct 16, 8:28 PM · Frameworks
cullmann reopened D8333: fix some indenters from randomly invoking indent.

Thanks for the fix!
Just one thing: could we in addition have an addition indentation test that uses the trigger chars? Its amazing we seem to have none for this as otherwise this problem would have been fixed during the port.

Mon, Oct 16, 7:58 PM · Frameworks, Kate
brauch closed D8333: fix some indenters from randomly invoking indent.
Mon, Oct 16, 7:35 PM · Frameworks, Kate
brauch added a comment to D8333: fix some indenters from randomly invoking indent.

Yes, at least the ones I'm aware of. Thanks for the review, I'll push it in a moment.

Mon, Oct 16, 7:33 PM · Frameworks, Kate
apol added inline comments to D8336: Improve apidox of KJobTrackerInterface.
Mon, Oct 16, 7:19 PM · Frameworks
renatoo updated the diff for D8332: Added baloo urls into places model.

Removed baloo dependency

Mon, Oct 16, 7:09 PM · Frameworks
renatoo updated the summary of D8332: Added baloo urls into places model.
Mon, Oct 16, 7:08 PM · Frameworks
dhaumann accepted D8333: fix some indenters from randomly invoking indent.

That makes a lot of sense. Please commit. Does that fix the indentation problems reported about Python?

Mon, Oct 16, 6:48 PM · Frameworks, Kate
elvisangelaccio closed D8334: Fix display name of Generator property.
Mon, Oct 16, 6:41 PM · Frameworks
elvisangelaccio created D8336: Improve apidox of KJobTrackerInterface.
Mon, Oct 16, 6:38 PM · Frameworks
mgallien accepted D8334: Fix display name of Generator property.

Thanks

Mon, Oct 16, 6:23 PM · Frameworks
brauch added inline comments to D8333: fix some indenters from randomly invoking indent.
Mon, Oct 16, 6:09 PM · Frameworks, Kate
anthonyfieroni added inline comments to D8333: fix some indenters from randomly invoking indent.
Mon, Oct 16, 6:04 PM · Frameworks, Kate
elvisangelaccio created D8334: Fix display name of Generator property.
Mon, Oct 16, 5:51 PM · Frameworks
ngraham added a comment to D7130: KMoreTools: Update and fix desktopfiles.

My pleasure. It's always nice to get bugs fixed. :)

Mon, Oct 16, 5:06 PM · Frameworks
brauch created D8333: fix some indenters from randomly invoking indent.
Mon, Oct 16, 4:37 PM · Frameworks, Kate
gregormi added a comment to D7130: KMoreTools: Update and fix desktopfiles.

Thanks for committing, Nate.

Mon, Oct 16, 4:33 PM · Frameworks
renatoo planned changes to D8332: Added baloo urls into places model.

Remove baloon dependency using KConfig API to query if it is enable, and hard-code search url with a fixed string.

Mon, Oct 16, 4:03 PM · Frameworks
renatoo created D8332: Added baloo urls into places model.
Mon, Oct 16, 3:42 PM · Frameworks
mgallien added a comment to D8330: Open files in TagLib extractor readonly.

Thanks, I tested it and it works.
I am not sure about the qWarning.
I would prefer another opinion on that.

Mon, Oct 16, 3:28 PM · Frameworks
mgallien added a reviewer for D8330: Open files in TagLib extractor readonly: Frameworks.
Mon, Oct 16, 3:22 PM · Frameworks
davidk created D8330: Open files in TagLib extractor readonly.
Mon, Oct 16, 11:46 AM · Frameworks
broulik closed D8135: [FrameSvg] Optimize updateSizes.
Mon, Oct 16, 9:39 AM · Frameworks, Plasma
rkflx added a comment to D7164: KSqueezedTextLabel: Respect indent, margin and frame width.

Looks like the CI issue is gone?

Mon, Oct 16, 8:10 AM · Frameworks
dfaure added a comment to D7164: KSqueezedTextLabel: Respect indent, margin and frame width.

Looks like the CI issue is gone?
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20XenialQt5.7/ looks green to me (well, blue, the jenkins people got daltonism issues lately).

Mon, Oct 16, 8:03 AM · Frameworks
dfaure accepted D6665: Make kssl compile against OpenSSL 1.1.0.

Now is the right time ;)

Mon, Oct 16, 7:52 AM · Frameworks
kfunk closed D8314: Fix deprecation warning.
Mon, Oct 16, 6:33 AM · Frameworks, Kate
kfunk closed D8315: CMake cleanup: Don't hardcode -std=c++0x.
Mon, Oct 16, 6:30 AM · Frameworks