For the calendarevents/ part (that is also spread into plasma-framework) I'm working on a replacement based on KCalendarCore
Actually use KICONTHEMES_NO_DEPRECATED correctly.
I have been resurrecting this patch again :) and have run into an issue I need some guidance on. To be able to parse the ~/.mtab.fuseiso file I would like to use the KMountPoint class, but this class currently resides in KIO which Solid doesn't depend on. But, KIO actually depends on Solid so would it be an option to move this class from KIO to Solid?
kio/src/widgets/ksslinfodialog.cpp also has 7 uses of BarIcon.
(and that's all I can find in all of KF5)
LOL I had no idea that one could do SmallIcon("foo", KIconLoader::SizeLarge) ;-)
- A tiny bit more optimized
kde.org/applications use the icons from breeze-icons. So I think it's worth adding to breeze-icons or improving how the icon are fetched in kde.org/applications.
Should I land this or abandon it?
It doesn't really make a difference if the icon is in Breeze in addition to being shipped with the app, but IMO it would also be strange to not have this Breeze-style icon for a KDE app in Breeze.
I completly forgot about this patch and since KHTML is dead and is getting removed from most of our apps, it doesn't makes sence to land this patch.
Isn't KHTML deprecated at this point? Does this actually need to happen?
Note that there is KFileItem::cmp for a more thorough comparison of two fileitems. But it only looks at some UDS fields -- those that matter at the KDirLister level.
Or maybe it shows that UDSEntry::operator== was missing so KFileItem::cmp uses a poor man's version of that ;)
This confirms the need for such an operator== indeed (though I wouldn't change the implementation of KFileItem::cmp until we see a need to do that).
That's bug 362484, please close. Merci!
icons/apps/22/elisa.svg does not apply cleanly. Not sure why.
Fri, Sep 20
By the way I guess the reason why only the PrimarySelectionOfferV1InterfaceVersion is there without the patch is that the other interfaces are created through the manager on request of the client while the offer is created server-side and then sent through an event to client.
Header output with the patch:
#ifndef KWAYLAND_SERVER_WP_PRIMARY_SELECTION_UNSTABLE_V1_H #define KWAYLAND_SERVER_WP_PRIMARY_SELECTION_UNSTABLE_V1_H