FrameworksRelease
ActivePublic

Recent Activity

Today

davidedmundson updated the diff for D16883: Add VirtualDesktops to PlasmaWindowModel.

update the plasma virtual desktop test at the same time

Wed, Nov 14, 8:08 PM · Frameworks
davidedmundson requested review of D16883: Add VirtualDesktops to PlasmaWindowModel.
Wed, Nov 14, 7:32 PM · Frameworks
bruns added a comment to D16876: [balooctl] Add possibility to create a copy of the index without freelist.

You are replicating mdb_copy -c here.

Wed, Nov 14, 6:13 PM · Baloo, Frameworks
shubham updated the diff for D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB).

Now patch applies cleanly

Wed, Nov 14, 6:05 PM · Frameworks
bruns added a comment to D16878: Resolve symlinks in exclude folders.

IMHO we should just disallow specifying symlinks in both include/excludeFolders. The user can just use exludeFolders = /storage/stuff if he wants to exclude it.

Wed, Nov 14, 5:55 PM · Baloo, Frameworks
davidedmundson requested review of D16880: Update PlasmaWindowManagementTest for VirtualDesktop changes.
Wed, Nov 14, 4:16 PM · Frameworks
poboiko accepted D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript.

Apart from trivial comment, this looks fine. I've tested it on my setup (with bunch of (e)ps files), and randomly chosen files seems to be indexed nicely. It also reduced the size of the index by almost 50MB, because those are not indexed as plaintext anymore :)
Yet I would also vote for replacing it (eventually) with a full-featured extractor based on libspectre
(I'm not a security specialist in any way, but that CVE doesn't look too harmful, and from my point of view it's not worth to abandon full support of (E)PS because of it)

Wed, Nov 14, 3:50 PM · Baloo, Frameworks
poboiko requested review of D16878: Resolve symlinks in exclude folders.
Wed, Nov 14, 3:14 PM · Baloo, Frameworks
davidedmundson updated subscribers of D16877: Cleanup windowInterface in tests before windowManagement is destroyed.
Wed, Nov 14, 2:50 PM · Frameworks
davidedmundson requested review of D16877: Cleanup windowInterface in tests before windowManagement is destroyed.
Wed, Nov 14, 2:50 PM · Frameworks
poboiko requested review of D16876: [balooctl] Add possibility to create a copy of the index without freelist.
Wed, Nov 14, 2:10 PM · Baloo, Frameworks
poboiko updated the diff for D15983: React to config updates inside indexer.

It's a bad idea to removeRecursively starting from root of the tree (documentid 0).
If user has indexed /home/username folder, there is also an index entry for /home (that's how IdTreeDB works).
However, /home should not be indexed, according to checks (because it's not in includeFolders, while /home/username is)
This will lead to removeRecursively("/home") call, which will wipe index for /home/username as well.

Wed, Nov 14, 1:47 PM · Baloo, Frameworks
poboiko updated the diff for D15983: React to config updates inside indexer.

Rebase on master

Wed, Nov 14, 1:11 PM · Baloo, Frameworks
ndavis closed D8912: Added a set of Game Folder icons.
Wed, Nov 14, 8:11 AM · Frameworks
ndavis added a comment to D8912: Added a set of Game Folder icons.

It's been 3 days and no response, so I guess I'll land it.

Wed, Nov 14, 8:10 AM · Frameworks
nicolasfella updated the task description for T9094: Improve Dolphin's tag support.
Wed, Nov 14, 12:05 AM · VDG, Baloo, Frameworks, Dolphin
nicolasfella updated the task description for T9094: Improve Dolphin's tag support.
Wed, Nov 14, 12:03 AM · VDG, Baloo, Frameworks, Dolphin
nicolasfella updated the task description for T9094: Improve Dolphin's tag support.
Wed, Nov 14, 12:03 AM · VDG, Baloo, Frameworks, Dolphin

Yesterday

nicolasfella updated the task description for T9094: Improve Dolphin's tag support.
Tue, Nov 13, 11:52 PM · VDG, Baloo, Frameworks, Dolphin
apol accepted D16825: Export again KFilePlaceEditDialog.
Tue, Nov 13, 11:46 PM · Frameworks
emateli updated the diff for D14631: Adds a new RenameDialog to KIO with more options for batch renaming.
  • create on stack
  • upd define
  • remove unused import
  • use qstringliteral
  • remove unused export
  • match file name
  • remove import prefixes
  • remove q_unused on used parameter
  • use fwd class declaration
  • reserve space for items
  • Do not use _p for cpp files
  • simplify expressions
  • add cpp files w/o _p
  • optimize imports
Tue, Nov 13, 11:28 PM · Frameworks
thsurrel closed D16141: Disable unmount option for / or /home.
Tue, Nov 13, 10:55 PM · Frameworks
ngraham accepted D16825: Export again KFilePlaceEditDialog.
Tue, Nov 13, 8:45 PM · Frameworks
ngraham updated the summary of D16832: fix empty runner list after switching to new locale.
Tue, Nov 13, 7:12 PM · Frameworks, Localization
ngraham accepted D16867: Don't generate appstream data for files that lack a description.

Thanks, this looks like a good fix.

Tue, Nov 13, 6:14 PM · Frameworks
achauvel added a comment to D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior.

Is anybody interested in helping me figure out how I can implement that properly? I would be glad to start working again on it, but I don’t know enough about KIO right now.

Tue, Nov 13, 6:13 PM · Frameworks
nicolasfella updated the task description for T9094: Improve Dolphin's tag support.
Tue, Nov 13, 5:30 PM · VDG, Baloo, Frameworks, Dolphin
astippich abandoned D11365: also test for value types in taglibextractortest and fix errors.
Tue, Nov 13, 5:16 PM · Baloo, Frameworks
nicolasfella closed D7700: Show list of tags in PlacesView.
Tue, Nov 13, 5:06 PM · Frameworks, Dolphin
nicolasfella added inline comments to D7700: Show list of tags in PlacesView.
Tue, Nov 13, 5:05 PM · Frameworks, Dolphin
davidedmundson closed D16686: Cleanup Virtual Desktop Manager list entry in PlasmaVirtualDesktop destructor.
Tue, Nov 13, 4:36 PM · Frameworks
apol requested review of D16867: Don't generate appstream data for files that lack a description.
Tue, Nov 13, 4:11 PM · Frameworks
mart accepted D16686: Cleanup Virtual Desktop Manager list entry in PlasmaVirtualDesktop destructor.
Tue, Nov 13, 4:09 PM · Frameworks
ngraham added a task to D7700: Show list of tags in PlacesView: T8349: Improve Places panel usability and presentation.
Tue, Nov 13, 2:36 PM · Frameworks, Dolphin
ngraham accepted D7700: Show list of tags in PlacesView.

A surprisingly small amount of code for a nice feature. Code looks good to me except for one minor thing. This works great in my testing now. I say let's ship it, especially because it won't result in any UI changes at all for people who don't use tags.

Tue, Nov 13, 2:35 PM · Frameworks, Dolphin
harald abandoned D16801: Fix build on macOS.

Abandoned, already fixed by https://phabricator.kde.org/D16862

Tue, Nov 13, 2:15 PM · Frameworks
apol added a comment to D15479: fix for macOS.
Tue, Nov 13, 1:42 PM · Frameworks
D16801: Fix build on macOS now requires review to proceed.
Tue, Nov 13, 1:31 PM · Frameworks
nicolasfella updated the diff for D7700: Show list of tags in PlacesView.
  • Merge branch 'master' into arcpatch-D7700
Tue, Nov 13, 1:13 PM · Frameworks, Dolphin
vonreth closed D16862: Fix CMake condition.
Tue, Nov 13, 1:02 PM · Frameworks
cgiboudeaux accepted D16862: Fix CMake condition.
Tue, Nov 13, 12:27 PM · Frameworks
ngraham added a comment to D7700: Show list of tags in PlacesView.

Me neither. Can you rebase this on current master?

Tue, Nov 13, 12:02 PM · Frameworks, Dolphin
vonreth updated subscribers of D16862: Fix CMake condition.

Maybe we should look into the non Linux backends too...

Tue, Nov 13, 12:01 PM · Frameworks
vonreth requested review of D16862: Fix CMake condition.
Tue, Nov 13, 12:00 PM · Frameworks
ngraham added a task to D16852: Add Documents to the default list of Places: T8349: Improve Places panel usability and presentation.
Tue, Nov 13, 11:12 AM · Frameworks
davidc added a comment to D16852: Add Documents to the default list of Places.

Just wanted to say thanks for this. Adding Documents is the first thing I do when I open Dolphin on a fresh install.

Tue, Nov 13, 11:10 AM · Frameworks
ngraham added a comment to D16141: Disable unmount option for / or /home.

Cool, go for it!

Tue, Nov 13, 11:10 AM · Frameworks
rjvbb retitled D13777: KMessageWidget : revert to using highlight colour for Information style from KMessageWidget : revert to using highlight colour for Information style (WIP) to KMessageWidget : revert to using highlight colour for Information style.
Tue, Nov 13, 10:37 AM · Frameworks
rjvbb retitled D7283: KIO/Mac : move LaunchServices code to shared library and make kioslave an agent too from WIP: KIO/Mac : move LaunchServices code to shared library and make kioslave an agent too to KIO/Mac : move LaunchServices code to shared library and make kioslave an agent too.
Tue, Nov 13, 10:30 AM · Frameworks
rjvbb retitled D5070: Allow to play the default system sound (beep) instead of a specific sound file from Allow to play the default system sound (beep) instead of a specific sound file (WIP) to Allow to play the default system sound (beep) instead of a specific sound file.
Tue, Nov 13, 10:27 AM · Frameworks