FrameworksRelease
ActivePublic

Recent Activity

Today

nicolasfella updated the diff for D7700: Show list of tags in PlacesView.

Actually save tag bookmark and check if it already exists before adding

Thu, Jul 19, 3:54 PM · Frameworks, Dolphin
jtamate requested review of D14231: Slightly faster UDS constructor.
Thu, Jul 19, 11:58 AM · Frameworks
vkrause added a comment to D14218: Introduce a test to make sure we're not offering duplicated icons.

+1 on the test, can't comment on how to resolve this unfortunately

Thu, Jul 19, 7:56 AM · Frameworks
arojas closed D13990: Honor BUILD_TESTING.
Thu, Jul 19, 6:58 AM · Frameworks
broulik accepted D13990: Honor BUILD_TESTING.
Thu, Jul 19, 6:50 AM · Frameworks
bcooksley added a comment to D14131: Add enum alias Property::Language for typo Property::Langauge.

There is no KDE wide service to indicate absences or unavailability at the moment i'm afraid.

Thu, Jul 19, 6:22 AM · Baloo, Frameworks
tmarshall updated the diff for D13805: Present error dialog when user tries to create directory named "." or "..".

I've made the requested changes.

Thu, Jul 19, 4:49 AM · Frameworks, Dolphin
mgallien added a comment to D14131: Add enum alias Property::Language for typo Property::Langauge.

Looks good to me. If @mgallien doesn't give you an "accept" in a reasonable timeframe i guess you can count this as me accepting it ;)

Thu, Jul 19, 2:26 AM · Baloo, Frameworks

Yesterday

rkflx added a comment to T9226: Unifiy folder views.

@nicolasfella Speaking for Gwenview: That sounds just like an idea I had a couple of months ago (I might even have mentioned it here and there). However, in the meantime I read more of the codebase and realized it's not as easy as it sounds.

Wed, Jul 18, 10:49 PM · Frameworks, VDG, Digikam, Gwenview, Dolphin, Plasma
aacid added a comment to D14131: Add enum alias Property::Language for typo Property::Langauge.

Looks good to me. If @mgallien doesn't give you an "accept" in a reasonable timeframe i guess you can count this as me accepting it ;)

Wed, Jul 18, 10:48 PM · Baloo, Frameworks
aacid added a comment to D13808: Fix KMainWindow saving incorrect widget settings.

Events from the window system seem to be handled after normal events.
http://code.qt.io/cgit/qt/qtbase.git/tree/src/platformsupport/eventdispatchers/qeventdispatcher_glib.cpp#n70
Is there a way to send the event so qt processes it as window system event? Have tried looking through code and documentation, but everything that deals with window system events is private.

Wed, Jul 18, 10:38 PM · Frameworks
apol added reviewers for D14218: Introduce a test to make sure we're not offering duplicated icons: andreaska, mart, vkrause, Framework: Syntax Highlighting.
Wed, Jul 18, 10:35 PM · Frameworks
apol requested review of D14218: Introduce a test to make sure we're not offering duplicated icons.
Wed, Jul 18, 10:34 PM · Frameworks
ngraham added a comment to D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app.

Thanks! BTW, It's now technically acceptable for the BUG: keyword to go at the beginning. Sysadmins fixed the bug that was preventing this from working before.

Wed, Jul 18, 10:00 PM · Frameworks
cfeck accepted D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app.
Wed, Jul 18, 9:56 PM · Frameworks
cfeck updated the summary of D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app.
Wed, Jul 18, 9:56 PM · Frameworks
ngraham added a comment to D13805: Present error dialog when user tries to create directory named "." or "..".

Thanks for the update!

Wed, Jul 18, 6:27 PM · Frameworks, Dolphin
tmarshall added a comment to D13805: Present error dialog when user tries to create directory named "." or "..".

Sorry for the delay @ngraham . I've been traveling. I'll have these changes complete by the end of today.

Wed, Jul 18, 6:25 PM · Frameworks, Dolphin
ngraham added a comment to D13805: Present error dialog when user tries to create directory named "." or "..".

@tmarshall, any update on this?

Wed, Jul 18, 6:21 PM · Frameworks, Dolphin
nicolasfella updated the task description for T9226: Unifiy folder views.
Wed, Jul 18, 3:01 PM · Frameworks, VDG, Digikam, Gwenview, Dolphin, Plasma
ngraham added a project to T9226: Unifiy folder views: Frameworks.
Wed, Jul 18, 2:55 PM · Frameworks, VDG, Digikam, Gwenview, Dolphin, Plasma
mart added a comment to D12820: Add KWayland virtual desktop protocol.

classes renamed to fooUnstableV1, but i need comments, i'm not sure about the naming or how to manage the fact that's unstable..
‎‎Most of the unstable protocols just have the protocol implementation as unstable, but already kinda commit to stability to the c++ interface (as opposed to have a name which has unstable, and an incompatible version would have another class that can be as incompatible as it wants)

Wed, Jul 18, 2:32 PM · Frameworks
mart updated the diff for D12820: Add KWayland virtual desktop protocol.
  • fix initial state on createresource
  • send done to new clients
  • desktops shouldn't be deleted when the clients go away
  • iget rid of setActiveDesktop
  • rename the virtual desktop to Unstable
Wed, Jul 18, 2:29 PM · Frameworks
muhlenpfordt requested review of D14201: Set system default shortcut Ctrl+0 for "Actual Size" action.
Wed, Jul 18, 10:08 AM · Frameworks
romangg closed D14184: Reduce unnecessary long wait times on failing signal spies.
Wed, Jul 18, 9:03 AM · Frameworks
romangg closed D14183: Fix selection and seat auto tests.
Wed, Jul 18, 9:01 AM · Frameworks
vkrause closed D14194: Fix the configure check for _nl_msg_cat_cntr.
Wed, Jul 18, 7:29 AM · Frameworks
vkrause closed D14193: Don't generate files in the source directory.
Wed, Jul 18, 7:29 AM · Frameworks

Tue, Jul 17

rkflx added a comment to D14160: [KMessageBox] Call style for icon.

Dialog icons are correct on Linux with Breeze

Tue, Jul 17, 11:52 PM · Frameworks
rkflx accepted D14161: [KStyle] Use dialog-question for question icon.

Thanks for noticing, LGTM and restores the proper icon indeed.

Tue, Jul 17, 11:52 PM · Frameworks
apol accepted D14193: Don't generate files in the source directory.
Tue, Jul 17, 11:18 PM · Frameworks
apol closed D14187: Fix variable definition check.
Tue, Jul 17, 11:17 PM · Build System, Frameworks
apol accepted D14194: Fix the configure check for _nl_msg_cat_cntr.

Thanks! Had to workaround this earlier today.

Tue, Jul 17, 11:17 PM · Frameworks
kossebau closed D13926: Avoid warnings for PolkitQt5-1 headers.
Tue, Jul 17, 9:22 PM · Frameworks
gladhorn accepted D14118: Improve "Remove this [widget]" text.

I'd say make the casing consistent, otherwise it's a clear improvement in my opinion.

Tue, Jul 17, 7:11 PM · Frameworks
ngraham added a comment to D14118: Improve "Remove this [widget]" text.

Ping? Is the proposed wording good enough, or should we maybe instead just remove the word "this" and make it use "Remove <widget name>?

Tue, Jul 17, 7:04 PM · Frameworks
vkrause accepted D14187: Fix variable definition check.
Tue, Jul 17, 5:47 PM · Build System, Frameworks
vkrause requested review of D14194: Fix the configure check for _nl_msg_cat_cntr.
Tue, Jul 17, 5:15 PM · Frameworks
vkrause requested review of D14193: Don't generate files in the source directory.
Tue, Jul 17, 5:13 PM · Frameworks
davidedmundson accepted D14175: Support cursor hints on locked pointer.
Tue, Jul 17, 4:26 PM · Frameworks
romangg updated the diff for D14175: Support cursor hints on locked pointer.
  • Add hint getter
  • Add since keyword
Tue, Jul 17, 4:25 PM · Frameworks
nicolasfella closed D14052: Add bluetooth plugin.
Tue, Jul 17, 4:09 PM · Frameworks
apol added a comment to D14052: Add bluetooth plugin.

Yes, I can reproduce too. qmlplugindump-qt5 org.kde.bluezqt 1.0 returns 2 for some reason. Will have to investigate.

Tue, Jul 17, 4:05 PM · Frameworks
apol requested review of D14187: Fix variable definition check.
Tue, Jul 17, 2:38 PM · Build System, Frameworks
maxrd2 added a comment to D13808: Fix KMainWindow saving incorrect widget settings.

Events from the window system seem to be handled after normal events.
http://code.qt.io/cgit/qt/qtbase.git/tree/src/platformsupport/eventdispatchers/qeventdispatcher_glib.cpp#n70
Is there a way to send the event so qt processes it as window system event? Have tried looking through code and documentation, but everything that deals with window system events is private.

Tue, Jul 17, 2:22 PM · Frameworks
broulik closed D14045: [Containment] Don't load containment actions with plasma/containment_actions KIOSK restriction.
Tue, Jul 17, 2:20 PM · Frameworks
maxrd2 added a comment to D13808: Fix KMainWindow saving incorrect widget settings.

@dfaure great.. thanks

Tue, Jul 17, 2:03 PM · Frameworks
maxrd2 updated the diff for D13808: Fix KMainWindow saving incorrect widget settings.

Rebased to master

Tue, Jul 17, 1:57 PM · Frameworks
broulik added inline comments to D14009: [Plasma PluginLoader] Cache plugins during startup.
Tue, Jul 17, 1:42 PM · Frameworks
davidedmundson added inline comments to D14009: [Plasma PluginLoader] Cache plugins during startup.
Tue, Jul 17, 1:22 PM · Frameworks