FrameworksRelease
ActivePublic

Recent Activity

Today

meven updated subscribers of D26113: Places: Use Solid::Device::DisplayName for DisplayRole.

This should be ready to land @dfaure @ngraham

Thu, May 28, 6:50 AM · Frameworks

Yesterday

jpalecek added a comment to D29814: Fix segfault on no restart args.

I'm a bit confused by the bug this is fixing. Surely this doesn't happen to all cases of crashes without autorestart enabled??

Also, it sounds like a null check might be enough.

Wed, May 27, 10:22 PM · Frameworks
bruns requested changes to D17816: Support for xattrs on kio copy/move.
Wed, May 27, 9:43 PM · Frameworks
dfaure requested changes to D29814: Fix segfault on no restart args.

I'm a bit confused by the bug this is fixing. Surely this doesn't happen to all cases of crashes without autorestart enabled??

Wed, May 27, 9:40 PM · Frameworks
dfaure accepted D29810: Don't use the setenv function after fork.
Wed, May 27, 9:21 PM · Frameworks
dfaure added a comment to D29809: Don't invoke qstring localized stuff in critical section.

Makes sense; just two minor things.

Wed, May 27, 9:12 PM · Frameworks
arrowd added a comment to D17816: Support for xattrs on kio copy/move.

Mark stale command as done.

Wed, May 27, 8:59 PM · Frameworks
arrowd updated the diff for D17816: Support for xattrs on kio copy/move.
  • Use std::function to store a generator function for m_setXattrCmd's arguments.
Wed, May 27, 8:57 PM · Frameworks
brute4s99 closed D29461: Fix kio-extras build on Windows.
Wed, May 27, 4:30 PM · Frameworks, Dolphin
alex closed D29050: KRunner fix prepare/teardown signals.
Wed, May 27, 7:43 AM · Plasma, Frameworks
meven updated the diff for D26113: Places: Use Solid::Device::DisplayName for DisplayRole.

Update to new Solid::Device::DisplayName

Wed, May 27, 5:44 AM · Frameworks
meven accepted D29461: Fix kio-extras build on Windows.
Wed, May 27, 5:34 AM · Frameworks, Dolphin
jpalecek added a reviewer for D29809: Don't invoke qstring localized stuff in critical section: dfaure.
Wed, May 27, 12:27 AM · Frameworks
jpalecek added a reviewer for D29810: Don't use the setenv function after fork: dfaure.
Wed, May 27, 12:26 AM · Frameworks
jpalecek added a reviewer for D29814: Fix segfault on no restart args: dfaure.
Wed, May 27, 12:26 AM · Frameworks
jpalecek added inline comments to D29810: Don't use the setenv function after fork.
Wed, May 27, 12:25 AM · Frameworks
jpalecek updated the diff for D29810: Don't use the setenv function after fork.

Change remove_if and copy to copy_if, per suggestion

Wed, May 27, 12:20 AM · Frameworks

Tue, May 26

dfaure requested changes to D29668: Do not reject icon theme dir with invalid context/type..
Tue, May 26, 11:02 PM · Frameworks
brute4s99 added a comment to D29461: Fix kio-extras build on Windows.

updated libssh to use version 0.9.4 by default in Craft. We can merge this and get 🟢 for kio-extras builds. \o/

Tue, May 26, 10:19 PM · Frameworks, Dolphin
brute4s99 added inline comments to D29461: Fix kio-extras build on Windows.
Tue, May 26, 7:10 PM · Frameworks, Dolphin
brute4s99 added a dependency for D29461: Fix kio-extras build on Windows: D29835: Add libssh 0.9.4 to fix kio-extras on windows.
Tue, May 26, 7:07 PM · Frameworks, Dolphin
brute4s99 updated the diff for D29461: Fix kio-extras build on Windows.
Tue, May 26, 7:06 PM · Frameworks, Dolphin
xuetianweng added a comment to D29668: Do not reject icon theme dir with invalid context/type..

You can try to install one from your distro to check the actual content. index.theme is generated during the "configure & make".

Tue, May 26, 3:33 PM · Frameworks
xuetianweng added a comment to D29668: Do not reject icon theme dir with invalid context/type..

What are the values of Context and Type?

"Legacy" and "UI" ?

I can't see anything in index.theme https://ftp.gnome.org/pub/GNOME/sources/adwaita-icon-theme/3.36/

Tue, May 26, 3:31 PM · Frameworks
vkrause added a comment to D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler.

PIM has been fully adapted meanwhile, only https://phabricator.kde.org/D29478 missing I think.

Tue, May 26, 3:31 PM · Frameworks
chriscz added a comment to D29832: Fix Endianness issue during wallet decryption.

Hi @ngraham Thanks for letting me know! I've opened the PR over on gitlab: https://invent.kde.org/frameworks/kwallet/-/merge_requests/1. It must be quite a mission getting everyone over to new platforms 😓 😄

Tue, May 26, 7:16 AM · Frameworks
junghans added a comment to D29003: Use Q_EMIT and build with QT_NO_KEYWORDS.

Thank you for committing! Although I recently gained push rights, I did not have time yet to dig into the details of how to create/push commit respecting the KDE standards etc. Next time, I'll try on my own :)

Tue, May 26, 6:06 AM · Frameworks
bruns added inline comments to D17816: Support for xattrs on kio copy/move.
Tue, May 26, 12:53 AM · Frameworks
ngraham added a comment to D29397: KPreviewJob : Support for DeviceRatioPixel.

Here's where the spec lives, FWIW: https://gitlab.freedesktop.org/xdg/xdg-specs

Tue, May 26, 12:47 AM · Frameworks
ngraham added a reviewer for D29832: Fix Endianness issue during wallet decryption: aacid.

Thanks for the patch! FWIW we have moved patch review to GitLab; consider abandoning this and re-submitting it as a merge request at https://invent.kde.org/frameworks/kwallet/-/merge_requests

Tue, May 26, 12:44 AM · Frameworks
chriscz added a comment to D29832: Fix Endianness issue during wallet decryption.

This stack overflow answer has a more exhaustive approach to determining endianness. It may be worth extracting this code into a more appropriate header file though. Also here's the issue on the bugzilla tracker

Tue, May 26, 12:06 AM · Frameworks
chriscz requested review of D29832: Fix Endianness issue during wallet decryption.
Tue, May 26, 12:02 AM · Frameworks

Mon, May 25

kossebau closed D29003: Use Q_EMIT and build with QT_NO_KEYWORDS.
Mon, May 25, 11:24 PM · Frameworks
kossebau added a comment to D29003: Use Q_EMIT and build with QT_NO_KEYWORDS.

Looking at D28915, seems you are only collecting to earn push rights so far :), so going to push for you with the author info taken from there.

Mon, May 25, 11:23 PM · Frameworks
ndavis added a comment to D25814: [KColorScheme] Add SeparatorColor.

How would we add the separator role to color scheme files if separator color was added to upstream Qt? Wouldn't we still need to add a separator role to KColorScheme so that we could map the color in the color scheme file to the equivalent QPalette ColorRole?

Mon, May 25, 9:20 PM · Frameworks
kossebau added a comment to D29397: KPreviewJob : Support for DeviceRatioPixel.

The approach makes sense then. I agree that making high DPI a part of the FDO spec would be nice, but IMO that shouldn't block this. The approach currently taken is logical and it could be submitted as an extension to the spec later.

Mon, May 25, 3:27 PM · Frameworks
meven added inline comments to D29397: KPreviewJob : Support for DeviceRatioPixel.
Mon, May 25, 3:12 PM · Frameworks
ngraham added a comment to D29397: KPreviewJob : Support for DeviceRatioPixel.

The approach makes sense then. I agree that making high DPI a part of the FDO spec would be nice, but IMO that shouldn't block this. The approach currently taken is logical and it could be submitted as an extension to the spec later.

Mon, May 25, 2:58 PM · Frameworks
anthonyfieroni added a comment to D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag.

Wait @davidedmundson to accept it.

Mon, May 25, 2:35 PM · Frameworks
mthw added a comment to D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag.

Do I need to change anything or is this acceptable?

Mon, May 25, 2:31 PM · Frameworks
kossebau added a comment to D29397: KPreviewJob : Support for DeviceRatioPixel.

@meven Have you already got in contact with the other users/maintainers of he thumnbail cache spec about the idea to extend it with support for high dpi? If not, please consider to do so, so things will also work cross-toolkit/platforms in the future there, by being based on an agreed & formalized specification. Not being involved here or having full understanding of the topic, but I would guess your approach with the separate x2 should run into "make sense" responses, so the additional effort might be low for the gain of being based on an official spec.

Mon, May 25, 10:35 AM · Frameworks
ervin added inline comments to D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts.
Mon, May 25, 8:17 AM · Frameworks
meven added a comment to D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts.

The patch currently does not work.

Mon, May 25, 6:47 AM · Frameworks
meven retitled D26113: Places: Use Solid::Device::DisplayName for DisplayRole from Places: For mounted volume display mount points instead of description to Places: Use Solid::Device::DisplayName for DisplayRole.
Mon, May 25, 6:10 AM · Frameworks
meven updated the summary of D26113: Places: Use Solid::Device::DisplayName for DisplayRole.
Mon, May 25, 6:08 AM · Frameworks
meven closed D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts.
Mon, May 25, 6:06 AM · Frameworks
meven added a comment to D29397: KPreviewJob : Support for DeviceRatioPixel.

Overall seems sane. Two questions though:

Mon, May 25, 4:28 AM · Frameworks

Sun, May 24

bruns accepted D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts.
Sun, May 24, 7:41 PM · Frameworks
ngraham accepted D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts.

LGTM. @bruns?

Sun, May 24, 7:11 PM · Frameworks
ngraham added a comment to D29397: KPreviewJob : Support for DeviceRatioPixel.

Overall seems sane. Two questions though:

Sun, May 24, 7:10 PM · Frameworks