FrameworksRelease
ActivePublic

Recent Activity

Today

broulik added a comment to D18450: Add extractor for AppImage files.

Cool!

Tue, Jan 22, 10:26 AM · Baloo, Frameworks
kossebau added a comment to D18450: Add extractor for AppImage files.

Example screenshot:

Tue, Jan 22, 9:57 AM · Baloo, Frameworks
kossebau requested review of D18450: Add extractor for AppImage files.
Tue, Jan 22, 9:55 AM · Baloo, Frameworks
rjvbb added a comment to D18380: KIO: make file dialog columns resizable again (and movable).

Yikes, and I can reproduce that. Did you notice this with previous versions that used font stretch? (Probably not if stretch had no effect for the font(s) you tried it with...)

Tue, Jan 22, 9:22 AM · Frameworks
mart updated the diff for D17691: Add rows info to the plasma virtual desktop protocol.
  • bump versions
Tue, Jan 22, 9:19 AM · Frameworks
zzag closed D18440: [client] Wrap wl_shell_surface_set_{class,title}.
Tue, Jan 22, 8:54 AM · Frameworks
ahmadsamir added a comment to D18163: KateRenderer: when printing initially set the color scheme to Printing.

A gentle ping.

Tue, Jan 22, 7:35 AM · Frameworks, Kate

Yesterday

ngraham updated the summary of D7446: [Places panel] Revamp the Recently Saved section.
Mon, Jan 21, 11:44 PM · Frameworks, Dolphin
ngraham requested changes to D18380: KIO: make file dialog columns resizable again (and movable).

Sorry, I really don't think this text squeezing feature is actually desirable. Here's how it works in Kate:

Mon, Jan 21, 11:08 PM · Frameworks
rjvbb set the repository for D18380: KIO: make file dialog columns resizable again (and movable) to R241 KIO.
Mon, Jan 21, 10:55 PM · Frameworks
rjvbb updated the diff for D18380: KIO: make file dialog columns resizable again (and movable).

This version uses letterspacing rather than font stretch, so works regardless of whether a stylename has been set on the font.

Mon, Jan 21, 10:55 PM · Frameworks
dhaumann added a comment to D18116: Don't show document load trouble twice.

Just for info: If openingErrorMessage is indeed not set anymore, this is a behavior change, since KTextEditor::Document::openingErrorMessage() is public API. Looking at lxr.kde.org, it seems this is not used (but ->openingError() is used, see https://lxr.kde.org/source/kde/applications/kate/addons/filetree/katefiletreemodel.cpp#0554).

Mon, Jan 21, 10:11 PM · Frameworks, Kate
zzag added a comment to D18440: [client] Wrap wl_shell_surface_set_{class,title}.

ShellSurface is super-duper deprecated. I wouldn't invest too much time on it.

Mon, Jan 21, 9:54 PM · Frameworks
davidedmundson accepted D18440: [client] Wrap wl_shell_surface_set_{class,title}.

ShellSurface is super-duper deprecated. I wouldn't invest too much time on it.

Mon, Jan 21, 9:54 PM · Frameworks
zzag requested review of D18440: [client] Wrap wl_shell_surface_set_{class,title}.
Mon, Jan 21, 9:44 PM · Frameworks
trickyricky26 planned changes to D18439: Add proper edit-delete-shred icons.

I will experiment with some more pattern for the shredded part.

Mon, Jan 21, 9:35 PM · Frameworks
loh.tar updated the diff for D18116: Don't show document load trouble twice.
  • Don't set m_openingErrorMessage in KateBuffer::openFile
  • m_openingErrorMessage is now nowhere set
Mon, Jan 21, 9:34 PM · Frameworks, Kate
ngraham added a comment to D18439: Add proper edit-delete-shred icons.

Also, visually speaking, I think that the checkerboard grid on the bottom is too fine. Making it a bit more coarse might improve things. Also have you experimented with using vertical lines instead of a checkerboard? Or maybe a checkerboard of vertical lines rather than squares? What's what my shredder does.

Mon, Jan 21, 9:30 PM · Frameworks
ngraham added a comment to D18439: Add proper edit-delete-shred icons.

Symlink shenanigans make the patch not apply due to that Phab bug. :(

Mon, Jan 21, 9:29 PM · Frameworks
trickyricky26 added a reviewer for D18439: Add proper edit-delete-shred icons: VDG.
Mon, Jan 21, 9:26 PM · Frameworks
trickyricky26 requested review of D18439: Add proper edit-delete-shred icons.
Mon, Jan 21, 9:24 PM · Frameworks
rjvbb added a comment to D18380: KIO: make file dialog columns resizable again (and movable).

The discussion in that bug kind of petered out, unfortunately.

Mon, Jan 21, 8:46 PM · Frameworks
ngraham closed D18433: Add a Plasma Theme Preferences Icon.
Mon, Jan 21, 8:08 PM · Frameworks
ngraham accepted D18433: Add a Plasma Theme Preferences Icon.
Mon, Jan 21, 8:06 PM · Frameworks
ngraham added a comment to D18433: Add a Plasma Theme Preferences Icon.

After some discussion, we decided to keep this name to ensure a proper fallback path for themes without this icon.

Mon, Jan 21, 8:06 PM · Frameworks
GB_2 added a comment to D18433: Add a Plasma Theme Preferences Icon.

It should fall back to preferences-desktop-plasma-theme, because it fits better than preferences-desktop-theme and it is also what we use now.

Mon, Jan 21, 7:11 PM · Frameworks
kossebau requested review of D18434: exiv2extractor: add support for bmp, gif, webp, tga.
Mon, Jan 21, 6:38 PM · Baloo, Frameworks
ngraham added a comment to D18380: KIO: make file dialog columns resizable again (and movable).

If this code depends on https://bugs.kde.org/show_bug.cgi?id=378523 being fixed, then we need to fix that first. The discussion in that bug kind of petered out, unfortunately. I think you're the only one who understands what's going on there, so would you care to have another go at fixing it?

Mon, Jan 21, 6:28 PM · Frameworks
ngraham requested changes to D18433: Add a Plasma Theme Preferences Icon.

Please change the name to preferences-desktop-theme-plasma, and then I'll land it!

Mon, Jan 21, 6:14 PM · Frameworks
ndavis added a comment to D18433: Add a Plasma Theme Preferences Icon.

We have preferences-desktop-theme-global; shouldn't this be preferences-desktop-theme-plasma?

Mon, Jan 21, 6:12 PM · Frameworks
ngraham closed D18432: Improve contrast of preferences-system-time.
Mon, Jan 21, 6:11 PM · Frameworks
ngraham accepted D18432: Improve contrast of preferences-system-time.
Mon, Jan 21, 6:09 PM · Frameworks
ngraham added a comment to D18433: Add a Plasma Theme Preferences Icon.

We have preferences-desktop-theme-global; shouldn't this be preferences-desktop-theme-plasma?

Mon, Jan 21, 6:06 PM · Frameworks
ngraham accepted D18433: Add a Plasma Theme Preferences Icon.
Mon, Jan 21, 6:03 PM · Frameworks
GB_2 accepted D18433: Add a Plasma Theme Preferences Icon.

+1

Mon, Jan 21, 5:55 PM · Frameworks
ndavis accepted D18432: Improve contrast of preferences-system-time.
Mon, Jan 21, 5:53 PM · Frameworks
trickyricky26 updated the diff for D18432: Improve contrast of preferences-system-time.
  • Make the outline a solid circle behind the black on to avoid weird aliasing issues
Mon, Jan 21, 5:51 PM · Frameworks
ndavis accepted D18433: Add a Plasma Theme Preferences Icon.

Looks good to me!

Mon, Jan 21, 5:50 PM · Frameworks
trickyricky26 updated the test plan for D18433: Add a Plasma Theme Preferences Icon.
Mon, Jan 21, 5:47 PM · Frameworks
trickyricky26 updated the test plan for D18433: Add a Plasma Theme Preferences Icon.
Mon, Jan 21, 5:46 PM · Frameworks
trickyricky26 updated the diff for D18433: Add a Plasma Theme Preferences Icon.
  • Make the Plasma Logo the same size as the Plasma Preferences Icon
Mon, Jan 21, 5:46 PM · Frameworks
ndavis requested changes to D18432: Improve contrast of preferences-system-time.

Make the outline a solid circle behind the clock part instead of just an outline. The reason for this is that the edges between the outline and the clock look worse if the outline isn't a solid circle in the background. Notice how the left side has rougher edges:


In general, it's a good idea to not make 2 shapes meet exactly at the edges due to issues with how SVGs are displayed. This isn't an Inkscape only either. It doesn't always need to be done that way, but it's especially necessary with shapes that have round edges.

Mon, Jan 21, 5:44 PM · Frameworks
trickyricky26 planned changes to D18433: Add a Plasma Theme Preferences Icon.

I will make the Plasma logo the same size as the one in preferences-desktop-plasma.

Mon, Jan 21, 5:38 PM · Frameworks
trickyricky26 added a reviewer for D18433: Add a Plasma Theme Preferences Icon: VDG.
Mon, Jan 21, 5:36 PM · Frameworks
trickyricky26 requested review of D18433: Add a Plasma Theme Preferences Icon.
Mon, Jan 21, 5:35 PM · Frameworks
ngraham accepted D18432: Improve contrast of preferences-system-time.

Looks good to me! Other VDG folks, shall we land this?

Mon, Jan 21, 5:11 PM · Frameworks
trickyricky26 added a reviewer for D18432: Improve contrast of preferences-system-time: VDG.
Mon, Jan 21, 5:09 PM · Frameworks
zzag added inline comments to D17691: Add rows info to the plasma virtual desktop protocol.
Mon, Jan 21, 5:08 PM · Frameworks
bruns added a comment to D13216: Overhaul the file index scheduler..

"Locking" the scheduler is simpler here than identifying that it "has gone idle". "Locking" only happens here for a small number of runnables (two) that can't run concurrently.

Mon, Jan 21, 5:05 PM · Baloo, Frameworks
trickyricky26 requested review of D18432: Improve contrast of preferences-system-time.
Mon, Jan 21, 5:04 PM · Frameworks