Yikes, and I can reproduce that. Did you notice this with previous versions that used font stretch? (Probably not if stretch had no effect for the font(s) you tried it with...)
- bump versions
A gentle ping.
Sorry, I really don't think this text squeezing feature is actually desirable. Here's how it works in Kate:
This version uses letterspacing rather than font stretch, so works regardless of whether a stylename has been set on the font.
Just for info: If openingErrorMessage is indeed not set anymore, this is a behavior change, since KTextEditor::Document::openingErrorMessage() is public API. Looking at lxr.kde.org, it seems this is not used (but ->openingError() is used, see https://lxr.kde.org/source/kde/applications/kate/addons/filetree/katefiletreemodel.cpp#0554).
ShellSurface is super-duper deprecated. I wouldn't invest too much time on it.
I will experiment with some more pattern for the shredded part.
- Don't set m_openingErrorMessage in KateBuffer::openFile
- m_openingErrorMessage is now nowhere set
Also, visually speaking, I think that the checkerboard grid on the bottom is too fine. Making it a bit more coarse might improve things. Also have you experimented with using vertical lines instead of a checkerboard? Or maybe a checkerboard of vertical lines rather than squares? What's what my shredder does.
Symlink shenanigans make the patch not apply due to that Phab bug. :(
The discussion in that bug kind of petered out, unfortunately.
After some discussion, we decided to keep this name to ensure a proper fallback path for themes without this icon.
It should fall back to preferences-desktop-plasma-theme, because it fits better than preferences-desktop-theme and it is also what we use now.
If this code depends on https://bugs.kde.org/show_bug.cgi?id=378523 being fixed, then we need to fix that first. The discussion in that bug kind of petered out, unfortunately. I think you're the only one who understands what's going on there, so would you care to have another go at fixing it?
Please change the name to preferences-desktop-theme-plasma, and then I'll land it!
We have preferences-desktop-theme-global; shouldn't this be preferences-desktop-theme-plasma?
- Make the outline a solid circle behind the black on to avoid weird aliasing issues
Looks good to me!
- Make the Plasma Logo the same size as the Plasma Preferences Icon
Make the outline a solid circle behind the clock part instead of just an outline. The reason for this is that the edges between the outline and the clock look worse if the outline isn't a solid circle in the background. Notice how the left side has rougher edges:
In general, it's a good idea to not make 2 shapes meet exactly at the edges due to issues with how SVGs are displayed. This isn't an Inkscape only either. It doesn't always need to be done that way, but it's especially necessary with shapes that have round edges.
I will make the Plasma logo the same size as the one in preferences-desktop-plasma.
Looks good to me! Other VDG folks, shall we land this?