FrameworksRelease
ActivePublic

Recent Activity

Today

tcanabrava added inline comments to D25149: Add a new template for KCMs.
Thu, Nov 14, 7:42 AM · Plasma, Frameworks
ngraham requested review of D25296: [RFC] Fix Display Configuration icon margins.
Thu, Nov 14, 4:00 AM · Frameworks

Yesterday

ervin requested changes to D25149: Add a new template for KCMs.
Wed, Nov 13, 9:59 PM · Plasma, Frameworks
ngraham accepted D24957: Add new baloo icons.
Wed, Nov 13, 9:33 PM · Frameworks
ngraham closed D25132: Use an eyedropper for color-picker icons.
Wed, Nov 13, 9:27 PM · Frameworks
trickyricky26 accepted D24959: Add new preferences search icons.

Sorry, I kind of forgot about this revision.
But looks all good now!

Wed, Nov 13, 9:21 PM · Frameworks
ndavis accepted D25132: Use an eyedropper for color-picker icons.

LGTM, but I noticed that there is a 32px monochrome icon. Should we keep using 32px monochrome icons for now? It seems like we can't make up our minds on this issue and the amount of work required to complete a move in either direction leads to us not wanting to commit to either direction.

Wed, Nov 13, 9:08 PM · Frameworks
ngraham accepted D24959: Add new preferences search icons.

LGTM, let's try not to torture this icon to death. :)

Wed, Nov 13, 8:50 PM · Frameworks
mart accepted D25149: Add a new template for KCMs.
Wed, Nov 13, 8:23 PM · Plasma, Frameworks
astippich added a comment to D24959: Add new preferences search icons.

any more comments?

Wed, Nov 13, 7:05 PM · Frameworks
ngraham updated the test plan for D25132: Use an eyedropper for color-picker icons.
Wed, Nov 13, 7:02 PM · Frameworks
ngraham updated the diff for D25132: Use an eyedropper for color-picker icons.

Thicken side lines

Wed, Nov 13, 7:01 PM · Frameworks
ngraham closed D25291: Add "all applications" category icon.
Wed, Nov 13, 5:53 PM · Frameworks
ndavis accepted D25291: Add "all applications" category icon.
Wed, Nov 13, 5:41 PM · Frameworks
ngraham updated the diff for D25291: Add "all applications" category icon.

Optimize icons with scour

Wed, Nov 13, 5:04 PM · Frameworks
ngraham added a reviewer for D25291: Add "all applications" category icon: broulik.
Wed, Nov 13, 5:03 PM · Frameworks
ngraham requested review of D25291: Add "all applications" category icon.
Wed, Nov 13, 5:02 PM · Frameworks
ngraham added a comment to D25226: [KPropertiesDialog] provide a way of showing the target of a symlink.

Last question: give the button text, or stick with the icon only? I ask because go-jump is kind of an odd icon IMO:

Wed, Nov 13, 4:33 PM · Frameworks
ngraham updated the diff for D25226: [KPropertiesDialog] provide a way of showing the target of a symlink.

Use more semantically correct icon

Wed, Nov 13, 4:29 PM · Frameworks
ngraham added a comment to D25226: [KPropertiesDialog] provide a way of showing the target of a symlink.

Actually I played with that and in retrospect I don't think it would work. If we give it a "link-like" appearance, that would suggest that clicking on it would actually open the destination file/folder (i.e. the typical link behavior), which is not what we want here. We want to show it in the file manager, not open it. I'll stay with the current approach and change the icon as @ndavis requested.

Wed, Nov 13, 4:22 PM · Frameworks
rjvbb added a comment to D22801: [KIO] silence a QFileInfo warning.

Are you not seeing these for instance when browsing an MSWin share in Dolphin (with the same or newer versions of kio-extras, Samba and MSWin)?

Wed, Nov 13, 3:21 PM · Frameworks
ervin closed D25286: Allow to disable autosave behavior in ConfigPropertyMap.
Wed, Nov 13, 2:42 PM · Frameworks
mart accepted D25286: Allow to disable autosave behavior in ConfigPropertyMap.
Wed, Nov 13, 2:41 PM · Frameworks
ervin requested review of D25286: Allow to disable autosave behavior in ConfigPropertyMap.
Wed, Nov 13, 2:39 PM · Frameworks
ervin closed D25211: Add KPropertySkeletonItem.
Wed, Nov 13, 2:35 PM · Frameworks
ervin closed D25210: Prepare KConfigSkeletonItem to allow inheriting its private class.
Wed, Nov 13, 2:35 PM · Frameworks
poboiko updated the summary of D23787: [baloo_file_extractor] Improve handling of large plain-text files.
Wed, Nov 13, 1:11 PM · Baloo, Frameworks
poboiko added a comment to D23787: [baloo_file_extractor] Improve handling of large plain-text files.

@bruns: I've missed D16593: [ExtractorCollection] Use only best matching extractor plugin, and had in mind previous situation where we've matched all extractors based on inheritance. In that case, "Secondly" part indeed does not seem to apply anymore.
(as for my previous answer: I misunderstood you, thought you were asking about the case where PlainTextExtractor did not match & matched afterwards)

Wed, Nov 13, 1:08 PM · Baloo, Frameworks
meven added a comment to D22801: [KIO] silence a QFileInfo warning.

The issue could be as well located in previewjob.cpp.
Could you debug why KMountPoint::List::findByPath is called with an empty string or non-existing file.
We might want to prevent this to happen instead.

Wed, Nov 13, 12:35 PM · Frameworks
bruns added a comment to D23787: [baloo_file_extractor] Improve handling of large plain-text files.

Can you please provide an example which:

  • is currently indexed though it should be skipped due to size
  • is skipped after this change

Sure. Any mimetype inherited from "text/plain", but starting with "text/" counts. I've made an actual list:


(using simple python script, which iterates over QMimeDatabase().allMimeTypes(), checks if type.inherits("text/plain") and is not already excluded by default Baloo config from file/fileexcludefilters.cpp)

Wed, Nov 13, 12:32 PM · Baloo, Frameworks
bruns added a comment to D23787: [baloo_file_extractor] Improve handling of large plain-text files.

and another example which:

  • is currently skipped though it should be indexed
  • is indexed after this change

There shouldn't be any. I mean, "PlaintextExtractor" should be inside exList for anything that starts with text/...

Wed, Nov 13, 12:27 PM · Baloo, Frameworks
poboiko added a comment to D23787: [baloo_file_extractor] Improve handling of large plain-text files.

Ping?

Wed, Nov 13, 10:02 AM · Baloo, Frameworks

Tue, Nov 12

aacid added a comment to D25267: Improve XCF support.

this very much needs test files :)

Tue, Nov 12, 10:44 PM · Frameworks
tcanabrava updated the diff for D25149: Add a new template for KCMs.
  • Add KConfigXT
  • Remove wrong icon
Tue, Nov 12, 6:45 PM · Plasma, Frameworks
adrianchavesfernandez requested review of D25276: reStructuredText: Fix inline literals highlighting preceding characters.
Tue, Nov 12, 6:00 PM · Frameworks, Kate
ngraham closed D20508: [udisks2] fix media change detection for external optical drives.
Tue, Nov 12, 5:38 PM · Frameworks
ngraham updated the summary of D20508: [udisks2] fix media change detection for external optical drives.
Tue, Nov 12, 5:33 PM · Frameworks
dfaure closed D25249: KDirModel: port to qCDebug, with its own category.
Tue, Nov 12, 2:24 PM · Frameworks
leinir updated the test plan for D25272: Turn KNewStuffQuick::CommentsModel into a SortFilterProxy for reviews.
Tue, Nov 12, 1:35 PM · Frameworks
leinir added reviewers for D25272: Turn KNewStuffQuick::CommentsModel into a SortFilterProxy for reviews: Plasma, KNewStuff, Frameworks.
Tue, Nov 12, 1:34 PM · Frameworks
leinir requested review of D25272: Turn KNewStuffQuick::CommentsModel into a SortFilterProxy for reviews.
Tue, Nov 12, 1:32 PM · Frameworks
meven abandoned D10702: Always use a job to delete files to avoid freezing process waiting on IO.

Abandoned in favor of D24962

Tue, Nov 12, 12:33 PM · Frameworks
jbbgameich closed D15364: Plasma style: Remove hardcoded textFormat.

I think this was fixed in another way already.

Tue, Nov 12, 12:11 PM · Frameworks
jbbgameich abandoned D22599: Make first and last name available separately.
Tue, Nov 12, 12:10 PM · Frameworks
davidedmundson requested review of D25270: Correctly set i18n arguments in one pass.
Tue, Nov 12, 11:58 AM · Frameworks
davidedmundson accepted D25211: Add KPropertySkeletonItem.
Tue, Nov 12, 11:30 AM · Frameworks
ervin updated the diff for D25211: Add KPropertySkeletonItem.

Avoid potential ownership problem on the propertyName

Tue, Nov 12, 10:41 AM · Frameworks

Mon, Nov 11

bruns updated subscribers of D24433: Move URL parsing methods from kioslave to query object.
Mon, Nov 11, 11:30 PM · Baloo, Frameworks
sandsmark updated the diff for D25267: Improve XCF support.

Fixed masks as well, now even some more complex XCF files work again.

Mon, Nov 11, 11:28 PM · Frameworks
sandsmark updated the diff for D25267: Improve XCF support.

Forgot to fix the layer offset reading, and read the precision after instead of before the image properties

Mon, Nov 11, 11:08 PM · Frameworks