FrameworksRelease
ActivePublic

Watchers

  • This project does not have any watchers.

Recent Activity

Today

nibags added a comment to D7461: Add syntax highlighting for AppArmor Profiles..

OK, I'll correct it.

Tue, Aug 22, 10:59 AM · Framework: Syntax Hightlighting, Frameworks
sitter added a comment to D7462: [kiocore] assert that klauncher is running or not.

Also can confirm this fixes the original problem of defunct kfileopen dialogs.

Tue, Aug 22, 10:50 AM · Frameworks
dhaumann added a comment to D7245: Improve reStructuredText highlighting.

Looks better, but still, could you provide an autotest case for unit testing, licensed under MIT ?

Tue, Aug 22, 10:20 AM · Frameworks
dhaumann requested changes to D7461: Add syntax highlighting for AppArmor Profiles..

See Christoph's comments. And indeed, please remove all hard-coded colors. Also, please provide a test file that is preferrably licensed under MIT.

Tue, Aug 22, 10:17 AM · Framework: Syntax Hightlighting, Frameworks
cullmann added a comment to D7461: Add syntax highlighting for AppArmor Profiles..

Three things I see ATM:

Tue, Aug 22, 10:12 AM · Framework: Syntax Hightlighting, Frameworks
bshah created D7462: [kiocore] assert that klauncher is running or not.
Tue, Aug 22, 10:00 AM · Frameworks
nibags added a reviewer for D7461: Add syntax highlighting for AppArmor Profiles.: Framework: Syntax Hightlighting.
Tue, Aug 22, 9:42 AM · Framework: Syntax Hightlighting, Frameworks
nibags created D7461: Add syntax highlighting for AppArmor Profiles..
Tue, Aug 22, 9:28 AM · Framework: Syntax Hightlighting, Frameworks
davidedmundson created D7460: Treat input RGB buffers as premultiplied.
Tue, Aug 22, 9:20 AM · Frameworks, Plasma on Wayland
kfunk closed D7459: Use config.h more by committing R39:0ee0be681108: Use config.h more.
Tue, Aug 22, 8:47 AM · Frameworks
fvogt added a comment to D7318: KFileItemDelegate: Always reserve space for icons.

Ping?

Tue, Aug 22, 8:11 AM · Frameworks
cullmann accepted D7459: Use config.h more.

Looks reasonable.

Tue, Aug 22, 7:56 AM · Frameworks
kfunk created D7459: Use config.h more.
Tue, Aug 22, 7:21 AM · Frameworks
kfunk closed D7443: Fix compilation on windows with editorconfig-c-core available by committing R39:ab503ec944fe: Fix compilation on windows with editorconfig-c-core available.
Tue, Aug 22, 7:18 AM · Frameworks
kfunk added a comment to D7458: Show icons in icon border context menu.

Other than that the patch looks sensible to me.

Tue, Aug 22, 6:44 AM · Frameworks

Yesterday

croick created D7458: Show icons in icon border context menu.
Mon, Aug 21, 10:34 PM · Frameworks
cullmann accepted D7367: Added Intel HEX file support for the Syntax highlighting database.

Ok, I am happy with that ;=)

Mon, Aug 21, 10:11 PM · Frameworks, Framework: Syntax Hightlighting
martonmiklos added a comment to D7367: Added Intel HEX file support for the Syntax highlighting database.

Hmm, the diff still looks like it has the old names, perhaps the update went wrong somehow?

Mon, Aug 21, 6:49 PM · Frameworks, Framework: Syntax Hightlighting
martonmiklos updated the diff for D7367: Added Intel HEX file support for the Syntax highlighting database.
Mon, Aug 21, 6:48 PM · Frameworks, Framework: Syntax Hightlighting
elvisangelaccio closed D7391: Replace KStandardAction::PasteText with KStandardAction::Paste by committing R39:b53e6d04cf09: Replace KStandardAction::PasteText with KStandardAction::Paste.
Mon, Aug 21, 5:58 PM · Frameworks
chinmoyr updated the diff for D6829: Add ability to use the new kauth helper in file ioslave.
  • Added new variable m_failure to PrivilegeOperationReturnValue so that we can directly check for failed state rather than depending upon fallacy of other variables.
  • Added check for chmod, chown and utime operation in execWithElevatedPrivilege method
  • Added code to serialize FdReceiver's (socket) path if the requested action is either OPEN or OPENDIR.
Mon, Aug 21, 5:57 PM · Frameworks
cullmann added a comment to D7367: Added Intel HEX file support for the Syntax highlighting database.

Hmm, the diff still looks like it has the old names, perhaps the update went wrong somehow?

Mon, Aug 21, 5:39 PM · Frameworks, Framework: Syntax Hightlighting
martonmiklos added a comment to D7367: Added Intel HEX file support for the Syntax highlighting database.

I am happy beside one thing I missed: I think the file should be called intelhex.xml, given its for the intel hex format only (the name is already fine, did miss that the filename is only hex).
Otherwise: very nice, thanks again for the contribution.

Mon, Aug 21, 5:38 PM · Frameworks, Framework: Syntax Hightlighting
chinmoyr updated the diff for D6197: Add kauth helper to file ioslave.
  • Minor changes in sendFileDescriptor function because constructor of FdSender changed in D6709.
Mon, Aug 21, 4:45 PM · Frameworks
chinmoyr updated the diff for D6709: [RFC] Add support for sharing file descriptor between KIO slave and KAuth helper.
Mon, Aug 21, 4:32 PM · Frameworks
vkrause closed D7439: Don't clear Qt's SSL CA certificate store by committing R241:5947eeb5f5aa: Don't clear Qt's SSL CA certificate store.
Mon, Aug 21, 4:15 PM · Frameworks
dfaure accepted D7439: Don't clear Qt's SSL CA certificate store.

Yep. We don't even have our own set of CA certificates, anymore, so clearing the Qt ones makes no sense anymore. Maybe this is why I was getting lots of SSL errors in konqueror-kf5...

Mon, Aug 21, 2:12 PM · Frameworks
davidedmundson closed D7402: Use QUrls from match to create mimeData in base implementation by committing R308:b0421c21867b: Use QUrls from match to create mimeData in base implementation.
Mon, Aug 21, 11:41 AM · Frameworks, Plasma
davidedmundson closed D6390: Add remote runners over DBus by committing R308:8389c530e531: Add remote runners over DBus.
Mon, Aug 21, 11:41 AM · Frameworks, Plasma
guoyunhe abandoned D5431: New LESS syntax based on SCSS.
Mon, Aug 21, 8:52 AM · Frameworks
cullmann added a comment to D5431: New LESS syntax based on SCSS.

Ok, thanks for comparing it.
Sorry that I didn't look at it earlier, my fault :/
You can abandon this change then.

Mon, Aug 21, 8:51 AM · Frameworks
guoyunhe added a comment to D5431: New LESS syntax based on SCSS.

They didn't include any screenshots in https://phabricator.kde.org/D5799 so I make my own:

Mon, Aug 21, 8:50 AM · Frameworks
dhaumann updated subscribers of D5431: New LESS syntax based on SCSS.

In that case, can you judge whether your patch or the other one is better?

Mon, Aug 21, 8:19 AM · Frameworks
guoyunhe added a comment to D5431: New LESS syntax based on SCSS.

Hm, just yesterday we committed https://phabricator.kde.org/D5799, which seems to do the same thing. Can you compare this and possibly update your patch? Sorry we did not notice this earlier...

Mon, Aug 21, 8:15 AM · Frameworks
anthonyfieroni added a comment to D5656: Adds method to force the reloading of a document.

Make a protected constructor

Document::Document(DocumentPrivate &dd) : d(dd) {}

In KateDocument extend DocumentPrivate with KateDocumentPrivate, override documentReload and give it to base Document

KateDocument(...) : Document(*new KateDocumentPrivate)

Then make documentReload public non-virtual in Document with implementation

d->documentReload(...) => which will call KateDocumentPrivate override function
Mon, Aug 21, 7:29 AM · Frameworks
dhaumann added a comment to D5431: New LESS syntax based on SCSS.

Hm, just yesterday we committed https://phabricator.kde.org/D5799, which seems to do the same thing. Can you compare this and possibly update your patch? Sorry we did not notice this earlier...

Mon, Aug 21, 6:20 AM · Frameworks
cullmann requested changes to D5431: New LESS syntax based on SCSS.

Hi, given I have no real idea about this HL, looks not wrong, but could you add/extend a unit test?
Then this can go in I would say.
Thanks for the change!

Mon, Aug 21, 6:13 AM · Frameworks
cullmann requested changes to D5656: Adds method to force the reloading of a document.

Please go the non-virtual way, thanks. Or has somebody else a better idea (or dislikes the whole additional API function).

Mon, Aug 21, 6:12 AM · Frameworks
cullmann accepted D7391: Replace KStandardAction::PasteText with KStandardAction::Paste.

Sounds reasonable!

Mon, Aug 21, 6:11 AM · Frameworks
cullmann requested changes to D7367: Added Intel HEX file support for the Syntax highlighting database.

I am happy beside one thing I missed: I think the file should be called intelhex.xml, given its for the intel hex format only (the name is already fine, did miss that the filename is only hex).
Otherwise: very nice, thanks again for the contribution.

Mon, Aug 21, 5:48 AM · Frameworks, Framework: Syntax Hightlighting
cullmann accepted D7443: Fix compilation on windows with editorconfig-c-core available.

I think this is more correct, just writing the unix libname was no good idea.

Mon, Aug 21, 5:47 AM · Frameworks

Sun, Aug 20

ngraham retitled D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it from Populate UDS_CREATION_TIME on Linux if Qt version and kernel support it to Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it.
Sun, Aug 20, 9:46 PM · Frameworks
ngraham added a comment to D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it.

Great, thanks guys. Thanks for bearing with me here. I'll see if I can test with the unreleased qtbase.

Sun, Aug 20, 9:33 PM · Frameworks
ngraham retitled D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it from Populate UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect if they don't) BUG: 286689 to Populate UDS_CREATION_TIME on Linux if Qt version and kernel support it.
Sun, Aug 20, 9:32 PM · Frameworks
dhaumann added a comment to D7367: Added Intel HEX file support for the Syntax highlighting database.

@cullmann Since you seem to know this, please take care of this change request :-)

Sun, Aug 20, 9:05 PM · Frameworks, Framework: Syntax Hightlighting
dhaumann added a comment to D7443: Fix compilation on windows with editorconfig-c-core available.

@cullmann Is this the right fix, or could this also be fixed in FindEditorConfig.cmake?

Sun, Aug 20, 9:02 PM · Frameworks
dhaumann closed D7280: Add syntax highlighting for Metamath by committing R216:2baf9eb98c4e: Add syntax highlighting for Metamath.
Sun, Aug 20, 8:58 PM · Frameworks
dhaumann accepted D7280: Add syntax highlighting for Metamath.

Looks good to me. Will integrate this soon.

Sun, Aug 20, 8:55 PM · Frameworks
dfaure added a comment to D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it.

Ah, OK, I see.
Well, still, you could test the patch by compiling qtbase dev (or by applying whichever Qt patch is necessary).

Sun, Aug 20, 8:48 PM · Frameworks
ltoscano added a comment to D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it.

The title of the revision becomes the first line; all the rest (summary, test, reviewers) become the rest of the content, a blank separator line is added automatically. Please add the BUG: line in the summary, not in the title.
Also, as the title becomes the first line, it would be nice to follow the usual git rules of length.

Sun, Aug 20, 8:40 PM · Frameworks