FrameworksRelease
ActivePublic

Recent Activity

Today

cmollekopf added a comment to D20059: Take clang-cl into account..

There was already an earlier (abandoned) attempt at this: https://git.reviewboard.kde.org/r/128779

Tue, Mar 26, 9:11 AM · Build System, Frameworks
cmollekopf requested review of D20059: Take clang-cl into account..
Tue, Mar 26, 9:09 AM · Build System, Frameworks
aspotashev closed D20005: Report human-readable error if Qt5Widgets is required but is not found.
Tue, Mar 26, 7:29 AM · Frameworks
hallas added a comment to D20007: Add GetProcessList for retrieving the list of currently active processes.

Ok, I have implemented all the review feedback you gave, I have also done some unit tests. Some of the unit tests or Unix specific though, I still don't know what to do about Windows since I don't have a development environment. Please give it a good look :D

Tue, Mar 26, 5:27 AM · Frameworks
hallas updated the diff for D20007: Add GetProcessList for retrieving the list of currently active processes.

Updated with review comments

Tue, Mar 26, 5:25 AM · Frameworks

Yesterday

apol accepted D20047: Add X-GNOME-UsesNotifications as recognized key.
Mon, Mar 25, 11:40 PM · Frameworks
arvidhansson added a comment to D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key.

This can be done in the system tray widget instead of making a separate icon for off. Ever notice how the notifications icon is grey when it's not active?

Sorry, I don't understand, never had noticed anything special with the notifications.

Top icon is for notifications (partly transparent), bottom icon is for Redshift (100% opacity)

[...] is it just me or is the transparent icon more like grey?

It's not just you, but that's how partly transparent black on a white background is supposed to look.

Okay, I get it, what should we do now?

We only make input-numlock-on, no off version

Mon, Mar 25, 10:30 PM · Frameworks
krutovmikhail updated the diff for D20026: Bug 195801 - go up in folder hierachy when in "edit mode".

Upated - Working variant with proper widgets - amending due to lost changes

Mon, Mar 25, 9:10 PM · Frameworks
broulik closed D19985: [KStatusNotifierItem] Send desktop-entry hint.
Mon, Mar 25, 9:02 PM · Frameworks
krutovmikhail updated the diff for D20026: Bug 195801 - go up in folder hierachy when in "edit mode".

Updated - Working variant with proper widgets

Mon, Mar 25, 9:01 PM · Frameworks
davidedmundson accepted D19985: [KStatusNotifierItem] Send desktop-entry hint.
Mon, Mar 25, 8:59 PM · Frameworks
krutovmikhail updated the summary of D20026: Bug 195801 - go up in folder hierachy when in "edit mode".
Mon, Mar 25, 8:59 PM · Frameworks
krutovmikhail added a comment to D20026: Bug 195801 - go up in folder hierachy when in "edit mode".

After bit digging, found out a proper-er solution to both questions.

Mon, Mar 25, 8:58 PM · Frameworks
krutovmikhail updated the diff for D20026: Bug 195801 - go up in folder hierachy when in "edit mode".

Updated - Working variant with proper widgets

Mon, Mar 25, 8:57 PM · Frameworks
ndavis added a comment to D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key.

This can be done in the system tray widget instead of making a separate icon for off. Ever notice how the notifications icon is grey when it's not active?

Sorry, I don't understand, never had noticed anything special with the notifications.

Top icon is for notifications (partly transparent), bottom icon is for Redshift (100% opacity)

[...] is it just me or is the transparent icon more like grey?

It's not just you, but that's how partly transparent black on a white background is supposed to look.

Okay, I get it, what should we do now?

Mon, Mar 25, 8:32 PM · Frameworks
aacid accepted D7732: Force KAuth helpers to have UTF-8 support.
Mon, Mar 25, 7:29 PM · Frameworks
aacid accepted D19903: Fix build with msvc.

I don't know who is responsible for this, but noone seems to disagree, so if this fixes the build for MSVC and doesn't break other platforms let's go for it?

Mon, Mar 25, 7:29 PM · Frameworks
vkrause closed D20018: Update URLs to use https.
Mon, Mar 25, 6:39 PM · Documentation, Frameworks
yurchor accepted D20018: Update URLs to use https.
Mon, Mar 25, 6:26 PM · Documentation, Frameworks
vkrause updated the diff for D20018: Update URLs to use https.

Integrate review comments.

Mon, Mar 25, 6:25 PM · Documentation, Frameworks
broulik updated the summary of D20047: Add X-GNOME-UsesNotifications as recognized key.
Mon, Mar 25, 5:23 PM · Frameworks
broulik requested review of D20047: Add X-GNOME-UsesNotifications as recognized key.
Mon, Mar 25, 5:22 PM · Frameworks
bruns added a dependent revision for D20045: Add helper function to determine mime type based on content and extension: D20046: Verify mimetypes for all existing sample files, add some more.
Mon, Mar 25, 5:11 PM · Baloo, Frameworks
bruns requested review of D20046: Verify mimetypes for all existing sample files, add some more.
Mon, Mar 25, 5:11 PM · Baloo, Frameworks
bruns requested review of D20045: Add helper function to determine mime type based on content and extension.
Mon, Mar 25, 5:07 PM · Baloo, Frameworks
arvidhansson added a comment to D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key.

This can be done in the system tray widget instead of making a separate icon for off. Ever notice how the notifications icon is grey when it's not active?

Sorry, I don't understand, never had noticed anything special with the notifications.

Top icon is for notifications (partly transparent), bottom icon is for Redshift (100% opacity)

[...] is it just me or is the transparent icon more like grey?

It's not just you, but that's how partly transparent black on a white background is supposed to look.

Mon, Mar 25, 4:22 PM · Frameworks
apol updated the diff for D20042: Show the plasmoid context menu on long tap.

polish

Mon, Mar 25, 3:34 PM · Frameworks
apol requested review of D20042: Show the plasmoid context menu on long tap.
Mon, Mar 25, 3:16 PM · Frameworks
bruns requested changes to D20012: Fix number localization for properties.

Please drop the changes in the unit test.

Mon, Mar 25, 2:44 PM · Baloo, Frameworks
nibags updated the diff for D19876: Fix: apply correctly the text colors of the chosen scheme.
  • Use QStringLiteral
Mon, Mar 25, 2:26 PM · Frameworks, Kate
knauss moved T10725: Evaluate different internet stacks for modern recommendations from incoming to Technical on the KDE Privacy Goal board.
Mon, Mar 25, 2:23 PM · Frameworks, KDE Privacy Goal
knauss created T10725: Evaluate different internet stacks for modern recommendations.
Mon, Mar 25, 2:23 PM · Frameworks, KDE Privacy Goal
apol added a comment to D7732: Force KAuth helpers to have UTF-8 support.

LGTM +1
I've dealt with such issues when working on samba-mounter, there we ended up encoding everything as base64 and using QString::fromUtf8 like maniacs.

Mon, Mar 25, 2:08 PM · Frameworks
vonreth added a comment to D19903: Fix build with msvc.

So then the workaround is correct, I haven't tried whether the original code compiles with CMAKE_CXX_STANDARD=17

Mon, Mar 25, 2:06 PM · Frameworks
bruns added inline comments to D20032: Convert string formatting tests to be data driven.
Mon, Mar 25, 2:06 PM · Baloo, Frameworks
bruns requested changes to D20011: Be more precise with mimetype detection.
Mon, Mar 25, 1:59 PM · Baloo, Frameworks
apol added inline comments to D20032: Convert string formatting tests to be data driven.
Mon, Mar 25, 1:58 PM · Baloo, Frameworks
davidedmundson added a reviewer for D7732: Force KAuth helpers to have UTF-8 support: apol.
Mon, Mar 25, 1:50 PM · Frameworks
davidedmundson updated the diff for D7732: Force KAuth helpers to have UTF-8 support.

update docs

Mon, Mar 25, 1:50 PM · Frameworks
bruns requested review of D20041: [balooctl] Reduce nesting level for addOption arguments, cleanup.
Mon, Mar 25, 1:39 PM · Baloo, Frameworks
bruns updated the diff for D19087: Add standalone conversion functions for PropertyMap to Json and vice versa.

add list tests

Mon, Mar 25, 1:36 PM · Baloo, Frameworks
bruns requested changes to D20013: Use Qt function for string list formatting.
Mon, Mar 25, 12:42 PM · Baloo, Frameworks
bruns added a comment to D20013: Use Qt function for string list formatting.

I think this should go in before D19445.

Mon, Mar 25, 12:41 PM · Baloo, Frameworks
mlaurent closed D19967: [kpeople] make it compile without foreach.
Mon, Mar 25, 12:28 PM · Frameworks
bruns added inline comments to D20032: Convert string formatting tests to be data driven.
Mon, Mar 25, 12:27 PM · Baloo, Frameworks
davidedmundson accepted D20039: [KConfig] Add Notify capability for revertToDefault.

Thanks.

Mon, Mar 25, 11:59 AM · Frameworks
broulik requested review of D20039: [KConfig] Add Notify capability for revertToDefault.
Mon, Mar 25, 11:46 AM · Frameworks
apol added a comment to D20032: Convert string formatting tests to be data driven.

+1 to _data splitting, makes a lot of sense.

Mon, Mar 25, 11:25 AM · Baloo, Frameworks
krutovmikhail added a comment to D20026: Bug 195801 - go up in folder hierachy when in "edit mode".

I've updated the diff with a couple questions I have (about UI mostly). Still WIP.

Mon, Mar 25, 10:45 AM · Frameworks
krutovmikhail updated the diff for D20026: Bug 195801 - go up in folder hierachy when in "edit mode".
  • initial take at dropdown list
Mon, Mar 25, 10:41 AM · Frameworks