FrameworksRelease
ActivePublic

Recent Activity

Today

ngraham requested changes to D15718: Do not index the path if the path has no execute permissions..

Wouldn't this have the effect of un-indexing most files? A quick check of my documents (text, word processing, excel, etc) reveals that none of them have the execute bit set. As-is, I think this would render Baloo mostly useless.

Mon, Sep 24, 12:51 AM · Baloo, Frameworks
smithjd added a comment to D15718: Do not index the path if the path has no execute permissions..

Files/folders should not be automatically indexed if the execute bit is unset. Downloads from most if not all popular browsers are not executable by default.

Mon, Sep 24, 12:15 AM · Baloo, Frameworks
smithjd requested review of D15718: Do not index the path if the path has no execute permissions..
Mon, Sep 24, 12:00 AM · Baloo, Frameworks

Yesterday

ndavis added a comment to D11880: Add firewall-config and firewall-applet icons.

Here's how the checkmark idea looks. I prefer the plain wall since it fits in with the other icons better.

Sun, Sep 23, 11:16 PM · Frameworks
akrutzler added a comment to D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module.

Thanks for the review. I will address your comments and hopefully have a patch ready in the next days. :)

Sun, Sep 23, 10:39 PM · Frameworks, Dolphin
smithjd added inline comments to D15714: add a string suffix to test data and use for unicode testing of taglibwriter.
Sun, Sep 23, 10:35 PM · Baloo, Frameworks
ndavis added a comment to D11880: Add firewall-config and firewall-applet icons.

I like firewall-config and firewall-applet-error as they are.

I think that firewall-applet looks maybe a bit too plain at its 22px size. The wall seems to need something.

Sun, Sep 23, 10:10 PM · Frameworks
smithjd added a comment to D15583: [Balooctl] remove directory parent check.

Technically, this check isn't actually needed, though it does prevent the user from entering a path more than once. At first glance this looks like it should work:

if (folder.startsWith(path))
Sun, Sep 23, 9:46 PM · Baloo, Frameworks
ngraham added a comment to D11880: Add firewall-config and firewall-applet icons.

For the benefit of others, here's what they look like now:

Sun, Sep 23, 9:27 PM · Frameworks
mgallien added a comment to D8532: [WIP] Restrict file extractor with Seccomp.

I was asked in private about the current state of libseccomp integration and why there was no progress in a long time.
The current state is, that I have implemented seccomp support in kfilemetadata using this API:

bool setProcessReadOnly(uint32_t defaultAction, std::vector<SeccompFilter> addionalWhitelist)

But there are two blockers, related to external plugins:

  • External plugins based on interpreters like python/lua/perl etc. need a huge whitelist. This is problematic as I want to keep the list of allowed syscalls as small as possible (the list would be huge). Additionally, it would be difficult to get a list of all needed syscalls. Thus, we would break many external plugins.
  • Baloo is basically unmaintained. Thus, if something breaks, fixing it should be as easy as possible. But what if QT requires a new syscall and thus, the tests (and deployments) are failing? We need a way to know which syscall failed. This works for kfilemetadata plugins, but not for external plugins (because they are separate processes). The only way I can image, would be running the whole test with strace.

    So, if anyone is willing to continue this work, I would be happy to share my current state. Otherwise, if everyone agrees that we don't care about external plugins (users of external plugins can disable Seccomp support with an environment variable), I can finish the patches.
Sun, Sep 23, 9:14 PM · Baloo, Frameworks
bruns added inline comments to D15714: add a string suffix to test data and use for unicode testing of taglibwriter.
Sun, Sep 23, 9:08 PM · Baloo, Frameworks
ngraham added reviewers for D8532: [WIP] Restrict file extractor with Seccomp: Frameworks, smithjd, bruns.

+1 for something rather than nothing. No comment on the technical aspect, but I'm adding more reviewers who can hopefully help un-wedge this patch.

Sun, Sep 23, 7:47 PM · Baloo, Frameworks
svuorela added inline comments to D15714: add a string suffix to test data and use for unicode testing of taglibwriter.
Sun, Sep 23, 7:25 PM · Baloo, Frameworks
svuorela added a comment to D15715: remove own implementation of QString to TString conversion for taglibwriter.

since I'm still unsure about those things: the q2t function was not declared static, but was never exported. It is still safe to remove, right?

Sun, Sep 23, 7:23 PM · Baloo, Frameworks
astippich added a dependency for D15715: remove own implementation of QString to TString conversion for taglibwriter: D15220: implement more basic tags for taglibwriter.
Sun, Sep 23, 7:07 PM · Baloo, Frameworks
astippich added a dependent revision for D15220: implement more basic tags for taglibwriter: D15715: remove own implementation of QString to TString conversion for taglibwriter.
Sun, Sep 23, 7:07 PM · Baloo, Frameworks
astippich added a comment to D15715: remove own implementation of QString to TString conversion for taglibwriter.

since I'm still unsure about those things: the q2t function was not declared static, but was never exported. It is still safe to remove, right?

Sun, Sep 23, 7:07 PM · Baloo, Frameworks
astippich requested review of D15715: remove own implementation of QString to TString conversion for taglibwriter.
Sun, Sep 23, 7:05 PM · Baloo, Frameworks
astippich added inline comments to D15714: add a string suffix to test data and use for unicode testing of taglibwriter.
Sun, Sep 23, 7:03 PM · Baloo, Frameworks
astippich closed D15614: remove usage of own TString to QString conversion function.
Sun, Sep 23, 7:00 PM · Baloo, Frameworks
astippich closed D15615: bump required taglib version to 1.11.1.
Sun, Sep 23, 6:59 PM · Baloo, Frameworks
astippich retitled D15615: bump required taglib version to 1.11.1 from bump required taglib version to bump required taglib version to 1.11.1.
Sun, Sep 23, 6:59 PM · Baloo, Frameworks
svuorela added inline comments to D15714: add a string suffix to test data and use for unicode testing of taglibwriter.
Sun, Sep 23, 6:56 PM · Baloo, Frameworks
bruns added inline comments to D15714: add a string suffix to test data and use for unicode testing of taglibwriter.
Sun, Sep 23, 6:51 PM · Baloo, Frameworks
svuorela added inline comments to D15714: add a string suffix to test data and use for unicode testing of taglibwriter.
Sun, Sep 23, 5:52 PM · Baloo, Frameworks
svuorela added a comment to D15704: increase test coverage of taglibwriter.

Looks good to me. A nice and simple way to drastically increase test coverage.

Sun, Sep 23, 5:49 PM · Baloo, Frameworks
astippich added a dependent revision for D15704: increase test coverage of taglibwriter: D15714: add a string suffix to test data and use for unicode testing of taglibwriter.
Sun, Sep 23, 5:40 PM · Baloo, Frameworks
astippich added a dependency for D15714: add a string suffix to test data and use for unicode testing of taglibwriter: D15704: increase test coverage of taglibwriter.
Sun, Sep 23, 5:40 PM · Baloo, Frameworks
astippich requested review of D15714: add a string suffix to test data and use for unicode testing of taglibwriter.
Sun, Sep 23, 5:39 PM · Baloo, Frameworks
astippich updated the diff for D15704: increase test coverage of taglibwriter.
  • don't change test strings for now
Sun, Sep 23, 5:13 PM · Baloo, Frameworks
dvratil closed D15697: Fix deletion of files from DAV.
Sun, Sep 23, 4:17 PM · Frameworks
kossebau added a comment to D14530: Fix crash when save a QImage to the eps format file.

@zccrs Hi. Does D15405 fix things for you, so is this patch here no longer needed? If so, please close this review request by selecting and submitting the action "Abandon Revision", so it does no longer appear in our "Please review" list :)

Sun, Sep 23, 12:04 PM · Frameworks
bruns added a comment to D15704: increase test coverage of taglibwriter.

In general this looks good, but I would like two changes:

  1. Do the conversion to QTest first, and leave out the change for unicode testing (e.g. Title1 -> Title €)
  2. Add a third column like "stringsuffix", and then add another test (row) for each format. QStringLiteral("Title1") then becomes QStringLiteral("Title1") + stringsuffix
Sun, Sep 23, 11:52 AM · Baloo, Frameworks
broulik requested review of D15705: Also raise configuration window when reusing it.
Sun, Sep 23, 11:01 AM · Frameworks
dfaure accepted D15697: Fix deletion of files from DAV.
Sun, Sep 23, 10:28 AM · Frameworks
dvratil updated the summary of D15697: Fix deletion of files from DAV.
Sun, Sep 23, 10:27 AM · Frameworks
dvratil updated the diff for D15697: Fix deletion of files from DAV.

Improve commit message

Sun, Sep 23, 10:26 AM · Frameworks
astippich added a dependency for D15704: increase test coverage of taglibwriter: D15220: implement more basic tags for taglibwriter.
Sun, Sep 23, 10:25 AM · Baloo, Frameworks
astippich added a dependent revision for D15220: implement more basic tags for taglibwriter: D15704: increase test coverage of taglibwriter.
Sun, Sep 23, 10:25 AM · Baloo, Frameworks
astippich requested review of D15704: increase test coverage of taglibwriter.
Sun, Sep 23, 10:24 AM · Baloo, Frameworks
dfaure added a comment to D15697: Fix deletion of files from DAV.

Patch looks ok but I'm surprised by the commit log. Doesn't this method also work for directories, even after the patch?

Sun, Sep 23, 10:09 AM · Frameworks
elvisangelaccio accepted D15611: [KCollapsibleGroupBox] Respect style's widget animation duration.
Sun, Sep 23, 9:57 AM · Frameworks
amhndu updated the diff for D15645: [WIP] Add scheme selection menu with a "System" entry..

Updated with styling suggestions.

Sun, Sep 23, 7:16 AM · Frameworks
shubham added inline comments to D15645: [WIP] Add scheme selection menu with a "System" entry..
Sun, Sep 23, 4:52 AM · Frameworks
ngraham added a comment to D15645: [WIP] Add scheme selection menu with a "System" entry..

Very much +1 on the end goal!

Sun, Sep 23, 3:52 AM · Frameworks

Sat, Sep 22

ngraham added a comment to D15426: Avoid QByteArray::remove in AccessManagerReply::readData.

So this doesn't completely fix https://bugs.kde.org/show_bug.cgi?id=375765? More is needed?

Sat, Sep 22, 8:56 PM · Frameworks
svuorela accepted D15615: bump required taglib version to 1.11.1.
Sat, Sep 22, 8:44 PM · Baloo, Frameworks
svuorela accepted D15614: remove usage of own TString to QString conversion function.
Sat, Sep 22, 8:43 PM · Baloo, Frameworks
ngraham updated the test plan for D15583: [Balooctl] remove directory parent check.
Sat, Sep 22, 8:28 PM · Baloo, Frameworks
ngraham updated the diff for D15583: [Balooctl] remove directory parent check.

Remove parent directory check entirely; it's not necessary

Sat, Sep 22, 8:25 PM · Baloo, Frameworks