update the plasma virtual desktop test at the same time
You are replicating mdb_copy -c here.
Now patch applies cleanly
IMHO we should just disallow specifying symlinks in both include/excludeFolders. The user can just use exludeFolders = /storage/stuff if he wants to exclude it.
Apart from trivial comment, this looks fine. I've tested it on my setup (with bunch of (e)ps files), and randomly chosen files seems to be indexed nicely. It also reduced the size of the index by almost 50MB, because those are not indexed as plaintext anymore :)
Yet I would also vote for replacing it (eventually) with a full-featured extractor based on libspectre
(I'm not a security specialist in any way, but that CVE doesn't look too harmful, and from my point of view it's not worth to abandon full support of (E)PS because of it)
It's a bad idea to removeRecursively starting from root of the tree (documentid 0).
If user has indexed /home/username folder, there is also an index entry for /home (that's how IdTreeDB works).
However, /home should not be indexed, according to checks (because it's not in includeFolders, while /home/username is)
This will lead to removeRecursively("/home") call, which will wipe index for /home/username as well.
Rebase on master
It's been 3 days and no response, so I guess I'll land it.
- create on stack
- upd define
- remove unused import
- use qstringliteral
- remove unused export
- match file name
- remove import prefixes
- remove q_unused on used parameter
- use fwd class declaration
- reserve space for items
- Do not use _p for cpp files
- simplify expressions
- add cpp files w/o _p
- optimize imports
Thanks, this looks like a good fix.
Is anybody interested in helping me figure out how I can implement that properly? I would be glad to start working again on it, but I don’t know enough about KIO right now.
A surprisingly small amount of code for a nice feature. Code looks good to me except for one minor thing. This works great in my testing now. I say let's ship it, especially because it won't result in any UI changes at all for people who don't use tags.
Abandoned, already fixed by https://phabricator.kde.org/D16862
- Merge branch 'master' into arcpatch-D7700
Me neither. Can you rebase this on current master?
Maybe we should look into the non Linux backends too...
Just wanted to say thanks for this. Adding Documents is the first thing I do when I open Dolphin on a fresh install.
Cool, go for it!