Sorry, I kind of forgot about this revision.
But looks all good now!
LGTM, but I noticed that there is a 32px monochrome icon. Should we keep using 32px monochrome icons for now? It seems like we can't make up our minds on this issue and the amount of work required to complete a move in either direction leads to us not wanting to commit to either direction.
LGTM, let's try not to torture this icon to death. :)
any more comments?
Thicken side lines
Optimize icons with scour
Last question: give the button text, or stick with the icon only? I ask because go-jump is kind of an odd icon IMO:
Use more semantically correct icon
Actually I played with that and in retrospect I don't think it would work. If we give it a "link-like" appearance, that would suggest that clicking on it would actually open the destination file/folder (i.e. the typical link behavior), which is not what we want here. We want to show it in the file manager, not open it. I'll stay with the current approach and change the icon as @ndavis requested.
Are you not seeing these for instance when browsing an MSWin share in Dolphin (with the same or newer versions of kio-extras, Samba and MSWin)?
@bruns: I've missed D16593: [ExtractorCollection] Use only best matching extractor plugin, and had in mind previous situation where we've matched all extractors based on inheritance. In that case, "Secondly" part indeed does not seem to apply anymore.
(as for my previous answer: I misunderstood you, thought you were asking about the case where PlainTextExtractor did not match & matched afterwards)
The issue could be as well located in previewjob.cpp.
Could you debug why KMountPoint::List::findByPath is called with an empty string or non-existing file.
We might want to prevent this to happen instead.
Tue, Nov 12
this very much needs test files :)
- Add KConfigXT
- Remove wrong icon
Abandoned in favor of D24962
I think this was fixed in another way already.
Avoid potential ownership problem on the propertyName
Mon, Nov 11
Fixed masks as well, now even some more complex XCF files work again.