FrameworksRelease
ActivePublic

Recent Activity

Today

asemke added a comment to D23119: Fix dates being on the wrong locale when setting an application language individually.

The original problem in LabPlot was reported by a windows user. The proposed fix won't fix the problem on windows. I think the only way to get the proper strings on Windows is to get the current language of the application, to create a QLocale with the proper language and to use QLocale::toString(const QDateTime &dateTime, const QString &format)... If this is correct, then we're are back to my original question I asked on IRC/Matrix - how to determine the current application language?

Sun, Sep 22, 3:58 PM · Frameworks
ahmadsamir added inline comments to D23902: [KCoreDirLister] replace deprecated foreach with range-for.
Sun, Sep 22, 3:09 PM · Frameworks
arojas closed D24020: Support NetworkManager 1.20 and do actually compile the NM backend.
Sun, Sep 22, 2:28 PM · Frameworks
nicolasfella added a comment to T11536: KDeclarative breakup plan.

For the calendarevents/ part (that is also spread into plasma-framework) I'm working on a replacement based on KCalendarCore

Sun, Sep 22, 2:02 PM · Frameworks, KF6
vkrause closed D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods.
Sun, Sep 22, 1:31 PM · Frameworks
vkrause closed D24138: Port away from deprecated KIconThemes methods.
Sun, Sep 22, 1:30 PM · Frameworks
bruns added a comment to D21235: Add handling of fuseiso filesystem type.

I have been resurrecting this patch again :) and have run into an issue I need some guidance on. To be able to parse the ~/.mtab.fuseiso file I would like to use the KMountPoint class, but this class currently resides in KIO which Solid doesn't depend on. But, KIO actually depends on Solid so would it be an option to move this class from KIO to Solid?

Sun, Sep 22, 1:17 PM · Frameworks
dfaure accepted D24138: Port away from deprecated KIconThemes methods.

Thanks!

Sun, Sep 22, 12:52 PM · Frameworks
dfaure accepted D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods.
Sun, Sep 22, 12:49 PM · Frameworks
vkrause requested review of D24138: Port away from deprecated KIconThemes methods.
Sun, Sep 22, 8:46 AM · Frameworks
vkrause updated the diff for D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods.

Actually use KICONTHEMES_NO_DEPRECATED correctly.

Sun, Sep 22, 8:33 AM · Frameworks
vkrause updated the diff for D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods.

Use KICONTHEMES_NO_DEPRECATED.

Sun, Sep 22, 8:28 AM · Frameworks
vkrause added a task to D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods: T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API.
Sun, Sep 22, 8:21 AM · Frameworks
vkrause added a comment to D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods.

kio/src/widgets/ksslinfodialog.cpp also has 7 uses of BarIcon.
(and that's all I can find in all of KF5)

Sun, Sep 22, 8:20 AM · Frameworks
hallas added a comment to D21235: Add handling of fuseiso filesystem type.

I have been resurrecting this patch again :) and have run into an issue I need some guidance on. To be able to parse the ~/.mtab.fuseiso file I would like to use the KMountPoint class, but this class currently resides in KIO which Solid doesn't depend on. But, KIO actually depends on Solid so would it be an option to move this class from KIO to Solid?

Sun, Sep 22, 6:08 AM · Frameworks
dfaure accepted D24020: Support NetworkManager 1.20 and do actually compile the NM backend.
Sun, Sep 22, 12:18 AM · Frameworks
dfaure added a comment to D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods.

kio/src/widgets/ksslinfodialog.cpp also has 7 uses of BarIcon.
(and that's all I can find in all of KF5)

Sun, Sep 22, 12:15 AM · Frameworks
dfaure requested changes to D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods.

LOL I had no idea that one could do SmallIcon("foo", KIconLoader::SizeLarge) ;-)

Sun, Sep 22, 12:14 AM · Frameworks

Yesterday

Diffusion closed D21169: Add app icon for the Kirogi Drone control app.
Sat, Sep 21, 5:29 PM · Frameworks
trickyricky26 updated the diff for D21169: Add app icon for the Kirogi Drone control app.
  • A tiny bit more optimized
Sat, Sep 21, 5:25 PM · Frameworks
ngraham added a comment to D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods.

+1

Sat, Sep 21, 5:24 PM · Frameworks
ngraham accepted D21169: Add app icon for the Kirogi Drone control app.

Shipit!

Sat, Sep 21, 5:16 PM · Frameworks
ognarb added a comment to D21169: Add app icon for the Kirogi Drone control app.

kde.org/applications use the icons from breeze-icons. So I think it's worth adding to breeze-icons or improving how the icon are fetched in kde.org/applications.

Sat, Sep 21, 5:09 PM · Frameworks
trickyricky26 added a comment to D21169: Add app icon for the Kirogi Drone control app.

Should I land this or abandon it?
It doesn't really make a difference if the icon is in Breeze in addition to being shipped with the app, but IMO it would also be strange to not have this Breeze-style icon for a KDE app in Breeze.

Sat, Sep 21, 5:06 PM · Frameworks
vkrause requested review of D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods.
Sat, Sep 21, 4:29 PM · Frameworks
ognarb abandoned D19620: Use a searchbar similar to the one in okular.

I completly forgot about this patch and since KHTML is dead and is getting removed from most of our apps, it doesn't makes sence to land this patch.

Sat, Sep 21, 4:06 PM · Frameworks
ngraham added a comment to D19620: Use a searchbar similar to the one in okular.

Isn't KHTML deprecated at this point? Does this actually need to happen?

Sat, Sep 21, 2:56 PM · Frameworks
elvisangelaccio added inline comments to D21897: Address some issues reported by Krazy analysis.
Sat, Sep 21, 1:31 PM · Frameworks
dfaure added inline comments to D23902: [KCoreDirLister] replace deprecated foreach with range-for.
Sat, Sep 21, 12:17 PM · Frameworks
GB_2 added a comment to D19620: Use a searchbar similar to the one in okular.

Ping.

Sat, Sep 21, 11:48 AM · Frameworks
arojas added a reviewer for D24020: Support NetworkManager 1.20 and do actually compile the NM backend: Frameworks.
Sat, Sep 21, 11:13 AM · Frameworks
vkrause added a task to D24060: Make KColorScheme compatible with QVariant: T8837: QColor support for Grantlee.
Sat, Sep 21, 8:35 AM · Frameworks
pino added inline comments to D23579: WIP: port ftp slave to new error reporting system.
Sat, Sep 21, 5:48 AM · Frameworks
anthonyfieroni added inline comments to D23579: WIP: port ftp slave to new error reporting system.
Sat, Sep 21, 5:42 AM · Frameworks
dfaure added a comment to D23667: Add == and != operators to KIO::UDSEntry.

Note that there is KFileItem::cmp for a more thorough comparison of two fileitems. But it only looks at some UDS fields -- those that matter at the KDirLister level.
Or maybe it shows that UDSEntry::operator== was missing so KFileItem::cmp uses a poor man's version of that ;)
This confirms the need for such an operator== indeed (though I wouldn't change the implementation of KFileItem::cmp until we see a need to do that).

Sat, Sep 21, 3:56 AM · Frameworks
dfaure requested changes to D23579: WIP: port ftp slave to new error reporting system.

Nice work!

Sat, Sep 21, 3:50 AM · Frameworks
cfeck added a comment to D24113: xcf: Properly read image resolution.

That's bug 362484, please close. Merci!

Sat, Sep 21, 3:37 AM · Frameworks
ndavis added a comment to D12992: New elisa icon.

icons/apps/22/elisa.svg does not apply cleanly. Not sure why.

Sat, Sep 21, 1:44 AM · Frameworks, Elisa

Fri, Sep 20

aacid closed D24114: xcf: Fix regression when reading files with "unsupported" properties.
Fri, Sep 20, 8:41 PM · Frameworks
aacid closed D24113: xcf: Properly read image resolution.
Fri, Sep 20, 8:41 PM · Frameworks
meven added a comment to D23667: Add == and != operators to KIO::UDSEntry.

Looks ok, but I'm just curious about the use case. "I felt it was missing" doesn't sound as strong an argument as "I need this"...

Slaves are supposed to mostly create those, not compare them, and apps are supposed to use KFileItem rather than UDSEntry directly.

Fri, Sep 20, 6:52 PM · Frameworks
fvogt added a reviewer for D23692: kdesu: set kernel flags to prevent ptrace instead of relying on setgid: Frameworks.
Fri, Sep 20, 6:02 PM · Frameworks
ngraham closed D24091: Move "Full Screen Mode" item from Settings menu to View menu.
Fri, Sep 20, 5:09 PM · Frameworks
vkrause accepted D24113: xcf: Properly read image resolution.
Fri, Sep 20, 4:46 PM · Frameworks
vkrause accepted D24114: xcf: Fix regression when reading files with "unsupported" properties.
Fri, Sep 20, 4:44 PM · Frameworks
dfaure accepted D24076: add a simple smoke test for slaves by using kioclient5.
Fri, Sep 20, 4:31 PM · Frameworks, Dolphin
vkrause closed D24059: Replace KSslError::errorString with QSslError::errorString.
Fri, Sep 20, 4:01 PM · Frameworks
romangg added a comment to D24003: kwaylandScanner produce version enum per class.

By the way I guess the reason why only the PrimarySelectionOfferV1InterfaceVersion is there without the patch is that the other interfaces are created through the manager on request of the client while the offer is created server-side and then sent through an event to client.

Fri, Sep 20, 2:49 PM · Frameworks
romangg added a comment to D24003: kwaylandScanner produce version enum per class.

Header output with the patch:

#ifndef KWAYLAND_SERVER_WP_PRIMARY_SELECTION_UNSTABLE_V1_H
#define KWAYLAND_SERVER_WP_PRIMARY_SELECTION_UNSTABLE_V1_H
Fri, Sep 20, 2:40 PM · Frameworks
pajamapants3000 added inline comments to D21897: Address some issues reported by Krazy analysis.
Fri, Sep 20, 2:36 PM · Frameworks