I've realised there's much more to do:
Trace is different, so ...progress!
I'm sorry but it still deadlocks, see https://bugs.kde.org/show_bug.cgi?id=385867
Any objections to Alt+, ?
Use QStringLiteral when possible
Then I would say => merge it.
And thanks for the work!
I can confirm that this fixes https://bugs.kde.org/show_bug.cgi?id=384682. Updating that accordingly.
This probably also fixes bug 384682. Can someone confirm?
Does not load baloo urls if file index is disabled
Thanks for the fix!
Just one thing: could we in addition have an addition indentation test that uses the trigger chars? Its amazing we seem to have none for this as otherwise this problem would have been fixed during the port.
Yes, at least the ones I'm aware of. Thanks for the review, I'll push it in a moment.
Removed baloo dependency
That makes a lot of sense. Please commit. Does that fix the indentation problems reported about Python?
My pleasure. It's always nice to get bugs fixed. :)
Thanks for committing, Nate.
Remove baloon dependency using KConfig API to query if it is enable, and hard-code search url with a fixed string.
Thanks, I tested it and it works.
I am not sure about the qWarning.
I would prefer another opinion on that.
Looks like the CI issue is gone?
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20XenialQt5.7/ looks green to me (well, blue, the jenkins people got daltonism issues lately).
Now is the right time ;)