FrameworksRelease
ActivePublic

Recent Activity

Today

poboiko updated the summary of D21427: Always skip trailing slashes in FilderedDirIterator.
Mon, May 27, 10:45 AM · Baloo, Frameworks
poboiko updated the summary of D21427: Always skip trailing slashes in FilderedDirIterator.
Mon, May 27, 10:44 AM · Baloo, Frameworks
poboiko requested review of D21427: Always skip trailing slashes in FilderedDirIterator.
Mon, May 27, 10:44 AM · Baloo, Frameworks
broulik requested review of D21425: [UDev Backend] Filter for ID_MEDIA_PLAYER already when querying.
Mon, May 27, 9:53 AM · Frameworks
broulik added a dependent revision for D21379: [UDev Backend] Narrow subsystems queried for cameras: D21425: [UDev Backend] Filter for ID_MEDIA_PLAYER already when querying.
Mon, May 27, 9:53 AM · Frameworks
meven added inline comments to D17595: Upstream Dolphin's file rename dialog.
Mon, May 27, 9:08 AM · Frameworks
Lekensteyn updated the diff for D21367: kioexec: change the scary debug messages for delayed deletion.

Using camelCase now.

Mon, May 27, 8:56 AM · Frameworks
davidre added a comment to T10873: Make QML tooltips consistent.

If I remember correctly in D18809 there was problem I had when using this style. There two tooltips would be visible and overlap eacht other (the tooltip of the listitem and the action tooltip). So this style doesn't work everywhere

Mon, May 27, 8:51 AM · Frameworks, VDG, Plasma
meven closed D21401: Use native dialog overwrite check.
Mon, May 27, 8:29 AM · Frameworks, Kate
meven added a comment to D21401: Use native dialog overwrite check.

Good part is that the overwrite check dialog will now be a native one analog to other apps instead of a KMessageBox, providing consistency outside of KDE.

Mon, May 27, 8:26 AM · Frameworks, Kate
meven updated the diff for D21401: Use native dialog overwrite check.

Remove decl of removed function checkOverwrite

Mon, May 27, 8:24 AM · Frameworks, Kate
broulik updated the diff for D21379: [UDev Backend] Narrow subsystems queried for cameras.
  • Limit to usb subsystem only
  • Add docs
Mon, May 27, 8:04 AM · Frameworks
aacid closed D21418: KCompressionDevice::seek: Fix previous fix ^_^.
Mon, May 27, 7:19 AM · Frameworks
davidedmundson closed D21419: Export SortFilterModel sort column to QML.
Mon, May 27, 7:03 AM · Frameworks
cullmann added a comment to D21401: Use native dialog overwrite check.

I think this is fine then, please remove the decl. of bool KTextEditor::DocumentPrivate::checkOverwrite(QUrl u, QWidget *parent), too and push this, thanks!

Mon, May 27, 5:50 AM · Frameworks, Kate
cullmann accepted D21421: Tcsh: fix operators and keywords.

Change looks reasonable + test case => thanks, please push

Mon, May 27, 5:45 AM · Frameworks, Kate, Framework: Syntax Highlighting
hallas added inline comments to D21235: Add handling of fuseiso filesystem type.
Mon, May 27, 5:41 AM · Frameworks

Yesterday

apol accepted D21418: KCompressionDevice::seek: Fix previous fix ^_^.
Sun, May 26, 11:09 PM · Frameworks
jpoelen requested review of D21421: Tcsh: fix operators and keywords.
Sun, May 26, 9:39 PM · Frameworks, Kate, Framework: Syntax Highlighting
bruns added a comment to D21290: kio_ftp: improve error handling when copying to FTP fails.

LGTM

Sun, May 26, 8:49 PM · Frameworks
dfaure updated the diff for D21290: kio_ftp: improve error handling when copying to FTP fails.

Don't leak the file descriptor on error. Thanks for catching!

Sun, May 26, 8:36 PM · Frameworks
broulik accepted D21419: Export SortFilterModel sort column to QML.
Sun, May 26, 8:20 PM · Frameworks
bruns added inline comments to D21290: kio_ftp: improve error handling when copying to FTP fails.
Sun, May 26, 8:20 PM · Frameworks
davidedmundson requested review of D21419: Export SortFilterModel sort column to QML.
Sun, May 26, 6:31 PM · Frameworks
aacid requested review of D21418: KCompressionDevice::seek: Fix previous fix ^_^.
Sun, May 26, 5:51 PM · Frameworks
GB_2 added a comment to T10862: Make QML imports consistent.

I saw the script extras/scripts/checkqmlimports.py in D20953. Maybe this can be helpful and could be moved to ECM.

Sun, May 26, 4:35 PM · Frameworks, Plasma
GB_2 added a project to T10873: Make QML tooltips consistent: Frameworks.
Sun, May 26, 4:35 PM · Frameworks, VDG, Plasma
GB_2 added a project to T10862: Make QML imports consistent: Frameworks.
Sun, May 26, 4:35 PM · Frameworks, Plasma
dkardarakos updated the test plan for D21415: Fix the alignment of the label of the toolbutton.
Sun, May 26, 4:12 PM · Frameworks
ndavis added a comment to D21378: Make Breeze Light/Dark use more system colors.

@mart If you're not opposed to this patch, I'll go ahead and land this.

Sun, May 26, 3:50 PM · Frameworks
dfaure updated the diff for D21290: kio_ftp: improve error handling when copying to FTP fails.

keep error code; mention pure-ftpd in the commit log

Sun, May 26, 3:46 PM · Frameworks
ngraham added a comment to D19254: [RFC] KateRenderer: Show tabs and space characters the smart way.

I'm wondering if this really needs to be configurable, and if it really needs to exist as described here.

Sun, May 26, 3:19 PM · Frameworks, Kate
ngraham added reviewers for D21415: Fix the alignment of the label of the toolbutton: Plasma, VDG.

Before-and-after screenshots in the Test Plan section are very helpful for patches like this. :)

Sun, May 26, 3:16 PM · Frameworks
dkardarakos requested review of D21415: Fix the alignment of the label of the toolbutton.
Sun, May 26, 2:38 PM · Frameworks
cullmann updated subscribers of D19254: [RFC] KateRenderer: Show tabs and space characters the smart way.

At the moment we have one combobox "Whitespaces" and one checkbox "Highlight tabulators" in "Whitespace Highlighting".

Sun, May 26, 1:45 PM · Frameworks, Kate
loh.tar added a comment to D19254: [RFC] KateRenderer: Show tabs and space characters the smart way.

What would be the concrete content of the combobox then?

What? Which box? These box can became these 4th "Smart" option but the code should then only work on spaces....to be "correct/right".

Sun, May 26, 1:42 PM · Frameworks, Kate
cullmann added a comment to D19254: [RFC] KateRenderer: Show tabs and space characters the smart way.

Ah, you mean because of the "show tabs" extra option, yeah, forgot that :/
What would be the concrete content of the combobox then?

Sun, May 26, 1:31 PM · Frameworks, Kate
loh.tar added a comment to D19254: [RFC] KateRenderer: Show tabs and space characters the smart way.

Given we already have now some enum for the show spaces stuff (None/Trailing/All) I would just vote to have some "Smart" 4th variant inside

Sun, May 26, 1:27 PM · Frameworks, Kate
loh.tar closed D19785: DocumentPrivate: Review del/backspace.
Sun, May 26, 12:52 PM · Frameworks, Kate
cullmann closed D21412: Add action to reset font size.
Sun, May 26, 11:56 AM · Frameworks, Kate
cullmann added a comment to D21412: Add action to reset font size.

Thank you for providing the patch!
Helping a bit to bring it up to speed is much easier and more motivating than to start from scratch for a thing one doesn't need oneself that much.

Sun, May 26, 11:54 AM · Frameworks, Kate
kishoreg added a comment to D21412: Add action to reset font size.

I don't think I have the permissions for that. Could you please do it for me?

Sun, May 26, 11:49 AM · Frameworks, Kate
cullmann added a comment to D21412: Add action to reset font size.

Btw., if should push, I would need your name + email address for the git commit, thanks.

Sun, May 26, 11:42 AM · Frameworks, Kate
cullmann accepted D21412: Add action to reset font size.

I think this look OK.
Can you commit yourself? Or shall I push for you?

Sun, May 26, 11:36 AM · Frameworks, Kate
kishoreg updated the diff for D21412: Add action to reset font size.

I've made the suggested changes (use standard reset zoom shortcut, and move zoom option to a submenu). Everything seems to work now.

Sun, May 26, 11:33 AM · Frameworks, Kate
cullmann added a comment to D19771: Use placeholder instead of label.

I think then it is a bit inconsistent.
Would it really be that confusing, given until you write your find/replace stuff inside, you have the labels?

Sun, May 26, 11:15 AM · Frameworks, Kate
cullmann added a comment to D21412: Add action to reset font size.

Could you try: KStandardShortcut::shortcut(KStandardShortcut::ActualSize)

Sun, May 26, 10:57 AM · Frameworks, Kate
kishoreg added a comment to D21412: Add action to reset font size.

For the shortcut: I guess you should use KStandardShortcut::ActualSize().

I initially tried using this, but it doesn't compile. It complains that ‘ActualSize’ cannot be used as a function. Just using KStandardShortcut::ActualSize results in the shortcut being set to '8' on my machine.

Sun, May 26, 10:54 AM · Frameworks, Kate
kishoreg updated the diff for D21412: Add action to reset font size.

Get the default font size correctly.

Sun, May 26, 10:51 AM · Frameworks, Kate
cullmann accepted D19785: DocumentPrivate: Review del/backspace.
Sun, May 26, 10:38 AM · Frameworks, Kate