@ossi would you mind reviewing this patch?
I only realized now that after making the previous change I forgot to rebase.
So uploading correct patch.
this dependency tree is a mess. please remove deps to abandoned changes or unabandon what you actually still need, and linearize the history.
note that the commit message needs a minor adjustment now.
fixed the issues mentioned
corrected the unlink position
Do the first unlink in FdReceiver constructor
SocketAddress is used only in FdSender and FdRecevier.
but so does using raw pointers. as the stl is available here anyway, it seems like the preferable abstraction layer.
why aren't you standardizing on std::string? that's cleaner than raw char pointers.
i know we discussed this before to some degree, but i don't remember the particulars.
did you make sure that this is the only place where SocketAddress is used?
Have you seen D12895?
- Set mimetype to */* if reported mimetype is empty
Make it a FileItemActionPlugin
Gray seems OK to me. And I confirm the bug with Saturday column.
Looks fine, except some issues with methods that should be hidden:
I don't know. Perhaps it's time to involve more VDG people. VDG, how should we style weekend days and day names? Currently we draw them in dark red, which is problematic for a few reasons:
if there's other places using the backslash it's fine, no need to change :)
- Uniformly use storageDevices.
Fri, May 25
It should be easy to use lxr to see which KDE applications uses KFileItemListProperties::mimeType(), but OK, your solution is safer in case of third-party applications.