FrameworksRelease
ActivePublic

Recent Activity

Yesterday

dfaure updated the diff for D26900: Support multiple values in XDG_CURRENT_DESKTOP.

use splitRef and QVector<QStringRef>

Fri, Jan 24, 11:31 PM · Frameworks
apol accepted D26903: allow programLogo property to be a QIcon, too.
Fri, Jan 24, 10:49 PM · Frameworks
apol added inline comments to D26900: Support multiple values in XDG_CURRENT_DESKTOP.
Fri, Jan 24, 10:46 PM · Frameworks
dfaure updated the diff for D25698: New query mechanism for applications: KApplicationTrader.

improve unittest, let the name match more queries

Fri, Jan 24, 10:11 PM · Frameworks
dfaure updated the diff for D25698: New query mechanism for applications: KApplicationTrader.

Port to erase(remove_if), add unittest for OnlyShowIn, which showed inconsistencies => now removed from results of both methods.

Fri, Jan 24, 10:06 PM · Frameworks
ngraham added a comment to D25798: Deprecated allowAsDefault.

Thanks!

Fri, Jan 24, 9:29 PM · Frameworks
hein added a comment to D26564: Clean kbuildsycoca4 support.

Let's wait until branching, there's still some KDE 4 apps people use.

Fri, Jan 24, 8:59 PM · Frameworks
brauch added a comment to D26840: Correctly set underMouse() for inline notes.

I'm sorry, updateView is the wrong function to call, you need updateDirty. I tried it out, like this it works:

Fri, Jan 24, 8:56 PM · Frameworks, Kate
dhaumann added a comment to D26903: allow programLogo property to be a QIcon, too.

Looks good to me, and very much in line with the other canConvert statements before.

Fri, Jan 24, 8:43 PM · Frameworks
cullmann requested review of D26903: allow programLogo property to be a QIcon, too.
Fri, Jan 24, 8:31 PM · Frameworks
dfaure added a comment to D25798: Deprecated allowAsDefault.

Removed: https://commits.kde.org/kde-cli-tools/e435a827bba9ebfbe7f988fe063b5848f5ff524b
(also merged to master)

Fri, Jan 24, 7:37 PM · Frameworks
ngraham added a comment to D25798: Deprecated allowAsDefault.

This makes kde-cli-tools fail to build for me with Qt 5.14 on openSUSE Tumbleweed:

Fri, Jan 24, 7:20 PM · Frameworks
davidre added a comment to D26840: Correctly set underMouse() for inline notes.

Then it seems like the line is not tagged correctly. Maybe try tagLines(note.position.line(), note.position.line())? I think the column being the same is not what the function being called expects.

Fri, Jan 24, 6:49 PM · Frameworks, Kate
dfaure requested review of D26900: Support multiple values in XDG_CURRENT_DESKTOP.
Fri, Jan 24, 6:46 PM · Frameworks
meven closed D26878: Add missing renamed event when a destination file already existed.
Fri, Jan 24, 6:24 PM · Frameworks
meven updated the diff for D26878: Add missing renamed event when a destination file already existed.

Clean up + QVERIFY

Fri, Jan 24, 6:23 PM · Frameworks
apol accepted D26876: Remove the Enum hack: finish lists with a comma, it's valid c++.
Fri, Jan 24, 6:17 PM · Frameworks
dfaure accepted D26878: Add missing renamed event when a destination file already existed.

Nice work! Thanks for the unittest extension.

Fri, Jan 24, 5:51 PM · Frameworks
tcanabrava added reviewers for D26131: Braces around for, break early.: ervin, dfaure.
Fri, Jan 24, 5:43 PM · Frameworks
tcanabrava added reviewers for D26867: New class: KConfigTypeInformation: ervin, dfaure.
Fri, Jan 24, 5:43 PM · Frameworks
tcanabrava added reviewers for D26868: Move newItem to private method in KConfigSourceGenerator: ervin, dfaure.
Fri, Jan 24, 5:43 PM · Frameworks
tcanabrava added reviewers for D26876: Remove the Enum hack: finish lists with a comma, it's valid c++: ervin, dfaure.
Fri, Jan 24, 5:43 PM · Frameworks
tcanabrava added reviewers for D26877: Simplify calls to whitespace() and use it in more places.: dfaure, ervin.
Fri, Jan 24, 5:42 PM · Frameworks
mart updated the diff for D26898: expose an id for the wallpaper.

plasmoidId to avoid potential future clashes with QML id

Fri, Jan 24, 4:55 PM · Frameworks
mart requested review of D26898: expose an id for the wallpaper.
Fri, Jan 24, 4:50 PM · Frameworks
meven updated the diff for D26878: Add missing renamed event when a destination file already existed.

Remove a bad unused

Fri, Jan 24, 4:09 PM · Frameworks
apol added a comment to D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader.

Looks good otherwise, this code is pretty well tested too, so I quite trust we aren't breaking it horribly.

Fri, Jan 24, 2:33 PM · Frameworks
meven closed D26897: Fix two warnings, missing Q_FALLTHROUGH.
Fri, Jan 24, 2:33 PM · Frameworks
davidedmundson accepted D26897: Fix two warnings, missing Q_FALLTHROUGH.
Fri, Jan 24, 2:02 PM · Frameworks
meven requested review of D26897: Fix two warnings, missing Q_FALLTHROUGH.
Fri, Jan 24, 1:59 PM · Frameworks
meven updated the test plan for D26878: Add missing renamed event when a destination file already existed.
Fri, Jan 24, 1:50 PM · Frameworks
meven updated the diff for D26878: Add missing renamed event when a destination file already existed.

Avoid touching a line

Fri, Jan 24, 1:50 PM · Frameworks
meven updated the diff for D26878: Add missing renamed event when a destination file already existed.

Add tests, add renamed events when autorename was selected, handle another case

Fri, Jan 24, 1:49 PM · Frameworks
meven retitled D26878: Add missing renamed event when a destination file already existed from Add missing renamed event when a destination file already existed to Add missing renamed events when a destination file already existed.
Fri, Jan 24, 1:48 PM · Frameworks
meven updated the summary of D26878: Add missing renamed event when a destination file already existed.
Fri, Jan 24, 1:42 PM · Frameworks
davidedmundson added a comment to D25583: Quit baloo_file_extractor if DB transaction fails.

I will try to cook up a more complete solution over the weekend.

Fri, Jan 24, 10:59 AM · Baloo, Frameworks
bruns added a comment to D25583: Quit baloo_file_extractor if DB transaction fails.

... and sorry for the late answer ...

Fri, Jan 24, 9:34 AM · Baloo, Frameworks
bruns added a comment to D25583: Quit baloo_file_extractor if DB transaction fails.

I will try to cook up a more complete solution over the weekend.

Fri, Jan 24, 9:33 AM · Baloo, Frameworks
mlaurent added a reviewer for D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader: dfaure.
Fri, Jan 24, 7:18 AM · Frameworks
mlaurent requested review of D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader.
Fri, Jan 24, 7:18 AM · Frameworks
cblack updated the test plan for D26441: New icon for KTimeTracker.
Fri, Jan 24, 4:37 AM · Frameworks
cblack updated the diff for D26441: New icon for KTimeTracker.

Use a rich grey instead of a rich mahogany

Fri, Jan 24, 4:37 AM · Frameworks
brute4s99 requested review of D26888: work around to fully support the windows backend.
Fri, Jan 24, 3:37 AM · Frameworks
ndavis requested changes to D26441: New icon for KTimeTracker.

I have to agree with what @hellcp said in the VDG chat earlier, the mahogany really does not fit. It draws attention to the wrong places and is confusing.

Fri, Jan 24, 1:38 AM · Frameworks
davidedmundson added a comment to D25583: Quit baloo_file_extractor if DB transaction fails.

One more ping.

Fri, Jan 24, 12:55 AM · Baloo, Frameworks
gassaf closed D26677: Port away from KLineEdit and KComboBox to Q equivalent.
Fri, Jan 24, 12:32 AM · Frameworks
cblack updated the diff for D26441: New icon for KTimeTracker.

Adjust colour from blue to mahogany

Fri, Jan 24, 12:28 AM · Frameworks

Thu, Jan 23

nicolasfella closed D25798: Deprecated allowAsDefault.
Thu, Jan 23, 10:51 PM · Frameworks
nicolasfella closed D26771: Add new signal for default action activation.
Thu, Jan 23, 10:50 PM · Frameworks
dfaure accepted D26623: KEMailSettings: group names in kconfig files should not be localized.

OK. I'm pretty sure this used to be shown "as is" in kmail, VERY LONG ago.

Thu, Jan 23, 9:46 PM · Frameworks