DolphinProject
ActivePublic

Recent Activity

Today

hallas added a comment to D19311: Add navigation history to forward/back buttons.

Just noticed that Alt+left/right shortcuts for back and forward are now broken.

Sun, Sep 22, 5:59 AM · Dolphin
hallas updated the diff for D19311: Add navigation history to forward/back buttons.

Fix Back/Forward shortcuts

Sun, Sep 22, 5:58 AM · Dolphin

Yesterday

elvisangelaccio closed D23538: [dolphin] Animate gifs on preview.
Sat, Sep 21, 2:28 PM · Dolphin
elvisangelaccio accepted D23538: [dolphin] Animate gifs on preview.

Thanks, cool stuff :)

Sat, Sep 21, 2:28 PM · Dolphin

Fri, Sep 20

dfaure accepted D24076: add a simple smoke test for slaves by using kioclient5.
Fri, Sep 20, 4:31 PM · Frameworks, Dolphin

Thu, Sep 19

ngraham requested changes to D19311: Add navigation history to forward/back buttons.

Just noticed that Alt+left/right shortcuts for back and forward are now broken.

Thu, Sep 19, 4:04 PM · Dolphin
feverfew added a comment to D24076: add a simple smoke test for slaves by using kioclient5.

I won't review, but would like to note I think that with KIOFuse, in conjuction with fio we can do some really complex testing on KIO, correct me if I'm wrong.

Thu, Sep 19, 3:08 PM · Frameworks, Dolphin
sitter requested review of D24076: add a simple smoke test for slaves by using kioclient5.
Thu, Sep 19, 1:04 PM · Frameworks, Dolphin
hallas updated the diff for D19311: Add navigation history to forward/back buttons.

Restrict the number of navigation entries to 12

Thu, Sep 19, 11:24 AM · Dolphin

Tue, Sep 17

ngraham added inline comments to D19311: Add navigation history to forward/back buttons.
Tue, Sep 17, 1:03 PM · Dolphin
hallas added inline comments to D19311: Add navigation history to forward/back buttons.
Tue, Sep 17, 11:13 AM · Dolphin

Mon, Sep 16

broulik closed D23145: [Exe Thumbnailer] Match 16 bit executables and don't request icon types wrestool cannot handle.
Mon, Sep 16, 3:41 PM · Frameworks, Dolphin
ngraham added a comment to D7446: [Places panel] Revamp the Recently Saved section.

Ooh, I'm so excited that this will be landing soon!

Mon, Sep 16, 3:22 PM · Frameworks, Dolphin
broulik closed D22116: [KStandardItemListWidget] Request the pixmap size we want and let the icon loader scale it.
Mon, Sep 16, 6:52 AM · Dolphin

Sun, Sep 15

pdabrowski updated the diff for D22594: [Dolphin] Open Preferred Search Tool action.

Rebased.

Sun, Sep 15, 9:38 PM · Documentation, Dolphin
ltoscano added a comment to T11663: Move URL Navigator into toolbar.

If the URL Navigator is moved into the toolbar, isn't it more likely to observe a shortened URL Navigator when the path is barely more than two levels deep?
Would such a move allow people to partially restore the old behavior by creating a separate toolbar? (partially because it won't be possible to have the URL Navigator at the same level of the Places panel as it is now)

Sun, Sep 15, 7:52 PM · VDG, Dolphin
elvisangelaccio accepted D22116: [KStandardItemListWidget] Request the pixmap size we want and let the icon loader scale it.

Sorry for the delay.

Sun, Sep 15, 6:51 PM · Dolphin
squeakypancakes added a comment to T11663: Move URL Navigator into toolbar.

Would it be too noisy if we did something like [ ... > dir1 ] | [ ... > dir2 ] for split views?

Sun, Sep 15, 6:50 PM · VDG, Dolphin
elvisangelaccio closed D23706: Fix wrong window titles.
Sun, Sep 15, 6:40 PM · Dolphin
elvisangelaccio accepted D23706: Fix wrong window titles.
Sun, Sep 15, 6:40 PM · Dolphin
ngraham added a comment to T11663: Move URL Navigator into toolbar.

Just to make sure, do you imagine tab bar placed above the toolbar? That is a familiar browser-like presentation.

Sun, Sep 15, 6:39 PM · VDG, Dolphin
ngraham added a comment to T11663: Move URL Navigator into toolbar.

I agree, we don't have to do this to make the buttons more discoverable. That's mostly tracked by https://phabricator.kde.org/T11662 anyway.

Sun, Sep 15, 6:38 PM · VDG, Dolphin
IlyaBizyaev added a comment to T11663: Move URL Navigator into toolbar.
  1. Cool :)
  2. Just to make sure, do you imagine tab bar placed above the toolbar? That is a familiar browser-like presentation.
Sun, Sep 15, 6:37 PM · VDG, Dolphin
elvisangelaccio added a comment to T11663: Move URL Navigator into toolbar.

It seems to me that making the URL navigator buttons more discoverable and moving the URL navigator to the toolbar are two orthogonal things.

Sun, Sep 15, 6:35 PM · VDG, Dolphin
ngraham added a comment to T11663: Move URL Navigator into toolbar.
  1. Sure, we could do that.
  2. The location displayed in the URL bar would change when the active tab changes. This is what other file managers already do and it's fine IMO.
Sun, Sep 15, 6:32 PM · VDG, Dolphin
GB_2 closed D23969: [kpropertiesdialog] add icons for the size section.
Sun, Sep 15, 6:28 PM · VDG, Dolphin, Frameworks
GB_2 accepted D23969: [kpropertiesdialog] add icons for the size section.
Sun, Sep 15, 6:27 PM · VDG, Dolphin, Frameworks
IlyaBizyaev added a comment to T11663: Move URL Navigator into toolbar.

Couple of questions:

  1. Can we keep the URL navigator left-aligned or make it filling width? Unclear what jumps and resizes will happen when a user enters or leaves a subdirectory.
  2. How will you handle tabs? They are not a very discoverable feature now (sadly), and with this change integrating them looks even less promising.
Sun, Sep 15, 6:26 PM · VDG, Dolphin
ngraham accepted D23969: [kpropertiesdialog] add icons for the size section.

Nice!

Sun, Sep 15, 5:52 PM · VDG, Dolphin, Frameworks
ngraham triaged T11663: Move URL Navigator into toolbar as Normal priority.
Sun, Sep 15, 5:42 PM · VDG, Dolphin
ngraham added a comment to D23757: Clean up hamburger menu and viewport and single-folder context menus.
In D23757#531196, @GB_2 wrote:

Would be nice if you could also made a KIO patch that changes the icon for "Open With" to system-run and the icon for "Actions" to view-more-symbolic.

Sun, Sep 15, 5:01 PM · Dolphin
broulik added a comment to D23145: [Exe Thumbnailer] Match 16 bit executables and don't request icon types wrestool cannot handle.

Ping

Sun, Sep 15, 4:52 PM · Frameworks, Dolphin
ngraham added a comment to D23965: [Dolphin] Add icons for "Go" and "Tools".

No worries! And sorry for rejecting your first patch. D23969 looks much more promising. :)

Sun, Sep 15, 4:24 PM · Dolphin
nazark updated the diff for D23706: Fix wrong window titles.
Sun, Sep 15, 3:55 PM · Dolphin
tienisto retitled D23969: [kpropertiesdialog] add icons for the size section from add icons for kpropertiesdialog to [kpropertiesdialog] add icons for the size section.
Sun, Sep 15, 3:39 PM · VDG, Dolphin, Frameworks
tienisto added projects to D23969: [kpropertiesdialog] add icons for the size section: Dolphin, VDG.
Sun, Sep 15, 3:38 PM · VDG, Dolphin, Frameworks
iasensio added a comment to D23538: [dolphin] Animate gifs on preview.

Thanks for the review and the hints @elvisangelaccio.
Those were some issues I tried to explore when starting the patch but didn't get to work, so I went the hardcoded way.
I hope it is in a better shape now.

Sun, Sep 15, 3:17 PM · Dolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Remove unrelated changes
  • Reuse QMovie instance
  • Check supported formats instead of hardcoded mimetypes
Sun, Sep 15, 3:07 PM · Dolphin
tienisto abandoned D23965: [Dolphin] Add icons for "Go" and "Tools".

Okay, I've seen your change. Well, those 2 icons are not needed anymore I think.

Sun, Sep 15, 1:55 PM · Dolphin
elvisangelaccio added a comment to D22594: [Dolphin] Open Preferred Search Tool action.

Needs one more rebase, sorry

Sun, Sep 15, 1:28 PM · Documentation, Dolphin
ngraham requested changes to D23965: [Dolphin] Add icons for "Go" and "Tools".

I'm afraid you're slightly too late! :) I just removed those menus from the hamburger menu entirely, replacing them with curated subsets of their content. Rebase on master and you'll see.

Sun, Sep 15, 1:20 PM · Dolphin
tienisto retitled D23965: [Dolphin] Add icons for "Go" and "Tools" from Add icons for "Go" and "Tools" to [Dolphin] Add icons for "Go" and "Tools".
Sun, Sep 15, 1:18 PM · Dolphin
tienisto added a reviewer for D23965: [Dolphin] Add icons for "Go" and "Tools": ngraham.
Sun, Sep 15, 1:14 PM · Dolphin
tienisto requested review of D23965: [Dolphin] Add icons for "Go" and "Tools".
Sun, Sep 15, 1:10 PM · Dolphin
ngraham closed D23757: Clean up hamburger menu and viewport and single-folder context menus.
Sun, Sep 15, 1:06 PM · Dolphin
elvisangelaccio accepted D23757: Clean up hamburger menu and viewport and single-folder context menus.
Sun, Sep 15, 10:10 AM · Dolphin
elvisangelaccio added a comment to D23706: Fix wrong window titles.

Nice, this seems to do the trick :)

Sun, Sep 15, 9:57 AM · Dolphin
elvisangelaccio added inline comments to D23557: Update dolphin tests following place changes D7446.
Sun, Sep 15, 8:33 AM · Dolphin

Sat, Sep 14

pdabrowski added a comment to D22594: [Dolphin] Open Preferred Search Tool action.

Done.

Sat, Sep 14, 11:05 PM · Documentation, Dolphin
pdabrowski updated the diff for D22594: [Dolphin] Open Preferred Search Tool action.
Sat, Sep 14, 11:03 PM · Documentation, Dolphin