DolphinProject
ActivePublic

Recent Activity

Today

ngraham accepted D21590: Fix rubber band not going away after right-click.
Tue, Jul 16, 3:03 AM · Dolphin
jacksonmcneill added a comment to D21590: Fix rubber band not going away after right-click.

Thanks, I missed that

Tue, Jul 16, 2:57 AM · Dolphin
jacksonmcneill updated the diff for D21590: Fix rubber band not going away after right-click.

Fix code style

Tue, Jul 16, 2:56 AM · Dolphin

Yesterday

aspotashev closed D22465: servicemenuinstaller: Use QMimeDatabase instead of running xdg-mime.
Mon, Jul 15, 8:52 PM · Dolphin
elvisangelaccio requested changes to D22444: Add zoom reset action.

Please use a descriptive commit message: https://community.kde.org/Policies/Commit_Policy#Always_add_descriptive_log_messages

Mon, Jul 15, 8:25 PM · Documentation, Dolphin
elvisangelaccio added inline comments to D21878: Rewrite servicemenu helper utility in C++.
Mon, Jul 15, 8:12 PM · Dolphin
elvisangelaccio accepted D22465: servicemenuinstaller: Use QMimeDatabase instead of running xdg-mime.

Thanks :)

Mon, Jul 15, 8:10 PM · Dolphin
ngraham added a comment to D22444: Add zoom reset action.

Cool, it works and the code is looking pretty good. Now I think the new action needs to be added to the View menu too, between the zoom in and zoom out menu items. The place where you've added it in dolphinui.rc doesn't actually do that.

Mon, Jul 15, 7:49 PM · Documentation, Dolphin
aspotashev updated the diff for D22466: servicemenuinstaller: Run installation scripts with cwd in their parent directories.
  • servicemenuinstaller test: Make sure uninstall script is run from its parent dir
Mon, Jul 15, 7:17 PM · Dolphin
aspotashev updated the diff for D22466: servicemenuinstaller: Run installation scripts with cwd in their parent directories.
  • servicemenuinstaller test: Make sure uninstall script is run from its parent dir
Mon, Jul 15, 7:14 PM · Dolphin
meven closed D22473: Fix a regression preventing previews to be resized.
Mon, Jul 15, 4:40 PM · Dolphin
meven retitled D22473: Fix a regression preventing previews to be resized from Fix a rgression preventing previews to be resized to Fix a regression preventing previews to be resized.
Mon, Jul 15, 4:39 PM · Dolphin
anthonyfieroni added a comment to D22386: Fix an issue with a new tab focus.

It does not look correct either, the problem is that the focus on location bar is delayed and setActive(false) isn't applied, this is workaround. But we have problems on that before, exactly that part with focusIn on location bar. You should correct there but it can break something other.

Mon, Jul 15, 4:16 PM · Dolphin
ngraham accepted D22473: Fix a regression preventing previews to be resized.
Mon, Jul 15, 3:14 PM · Dolphin
AndreyYashkin updated the diff for D22386: Fix an issue with a new tab focus.

Equivalent solution

Mon, Jul 15, 2:46 PM · Dolphin
meven requested review of D22473: Fix a regression preventing previews to be resized.
Mon, Jul 15, 2:21 PM · Dolphin
ngraham added a comment to D22183: Add click to play/play feature on previews for audio/video.

Much better! UI-wide, I think this is almost there. As a final thing, can you add a white outline around the play icon that's on top of the preview image? Without this, it barely shows up against dark backgrounds.

Mon, Jul 15, 2:17 PM · Dolphin
ngraham requested changes to D22469: Don't use "Unlimited" number of lines in Icon View by default.

This may be an appropriate change, but we can't do it without first fixing https://bugs.kde.org/show_bug.cgi?id=404625. Without a fix for that issue, there's no way to see the full text of an elided label, so eliding long labels can't be the default setting.

Mon, Jul 15, 2:14 PM · Dolphin
sitter added a comment to D22466: servicemenuinstaller: Run installation scripts with cwd in their parent directories.

Did this case not have a test? Shouldn't it be getting one if it didn't have one?

Mon, Jul 15, 1:56 PM · Dolphin
AndreyYashkin added a comment to D22420: Fix an issue with focus lost after closing terminal panel.

This issue was supposed to be fixed by commit 4e40fe810d324 but it seems it got reintroduced in the past months.

Could you try to git bisect it to figure out when this happend?

Mon, Jul 15, 1:08 PM · Dolphin
mthw added a comment to D22469: Don't use "Unlimited" number of lines in Icon View by default.

I agree that it shouldn't be unlimited, but I would suggest at least 5, or even 10 lines.

Mon, Jul 15, 9:24 AM · Dolphin
mthw added a comment to D22469: Don't use "Unlimited" number of lines in Icon View by default.

I agree with what you said. I'd suggest the value be bumped up to 3; it still looks good.

Mon, Jul 15, 9:23 AM · Dolphin
shubham added inline comments to D22183: Add click to play/play feature on previews for audio/video.
Mon, Jul 15, 8:23 AM · Dolphin
meven updated the diff for D22183: Add click to play/play feature on previews for audio/video.

Let the video player use the pointing hand cursor

Mon, Jul 15, 8:12 AM · Dolphin
meven updated the diff for D22183: Add click to play/play feature on previews for audio/video.

Add an arrow on videos to let the user know he can click to preview it, add a Pointing Hand cursor when hover the preview for audio and video

Mon, Jul 15, 8:07 AM · Dolphin
shubham updated the summary of D22444: Add zoom reset action.
Mon, Jul 15, 7:54 AM · Documentation, Dolphin
shubham updated the diff for D22444: Add zoom reset action.

Get default icon size

Mon, Jul 15, 7:54 AM · Documentation, Dolphin
filipf added a comment to D22469: Don't use "Unlimited" number of lines in Icon View by default.

I agree with what you said. I'd suggest the value be bumped up to 3; it still looks good.

Mon, Jul 15, 7:42 AM · Dolphin
broulik added a comment to D22469: Don't use "Unlimited" number of lines in Icon View by default.

I agree that it shouldn't be unlimited, but I would suggest at least 5, or even 10 lines.

Mon, Jul 15, 7:42 AM · Dolphin
mthw added reviewers for D22469: Don't use "Unlimited" number of lines in Icon View by default: Dolphin, VDG.
Mon, Jul 15, 7:23 AM · Dolphin
meven added a comment to D22183: Add click to play/play feature on previews for audio/video.

+1 for this feature. However, I feel like as implemented, it won't be very discoverable. To improve this, how about doing one of the following:

  • Use a pointing hand cursor when hovering over the preview, to show that something will happen on click
  • Show a play button in the center of the preview on hover, and make it look clicked and then disappear when the preview is clicked
  • A combination of both
  • Something else?
  • etc.
Mon, Jul 15, 7:19 AM · Dolphin
mthw requested review of D22469: Don't use "Unlimited" number of lines in Icon View by default.
Mon, Jul 15, 7:15 AM · Dolphin
ngraham added a comment to D22144: Add kio recentlyused:/ to access KactivitytStats data.

Thanks, got it built. However unfortunately it didn't help.

Mon, Jul 15, 1:57 AM · Frameworks, Dolphin
ngraham accepted D22465: servicemenuinstaller: Use QMimeDatabase instead of running xdg-mime.
Mon, Jul 15, 1:10 AM · Dolphin

Sun, Jul 14

aspotashev requested review of D22466: servicemenuinstaller: Run installation scripts with cwd in their parent directories.
Sun, Jul 14, 11:44 PM · Dolphin
aspotashev added inline comments to D21878: Rewrite servicemenu helper utility in C++.
Sun, Jul 14, 11:39 PM · Dolphin
aspotashev closed D21878: Rewrite servicemenu helper utility in C++.
Sun, Jul 14, 11:30 PM · Dolphin
aspotashev requested review of D22465: servicemenuinstaller: Use QMimeDatabase instead of running xdg-mime.
Sun, Jul 14, 11:27 PM · Dolphin
aspotashev updated the diff for D21878: Rewrite servicemenu helper utility in C++.
  • servicemenuinstaller: Fix build
Sun, Jul 14, 9:15 PM · Dolphin
elvisangelaccio accepted D21878: Rewrite servicemenu helper utility in C++.
Sun, Jul 14, 9:12 PM · Dolphin
elvisangelaccio added a comment to D22420: Fix an issue with focus lost after closing terminal panel.

This issue was supposed to be fixed by commit 4e40fe810d324 but it seems it got reintroduced in the past months.

Sun, Jul 14, 9:08 PM · Dolphin
elvisangelaccio requested changes to D22386: Fix an issue with a new tab focus.

Hmm, this feels like a work-around because we initialize m_active(true) everywhere else (DolphinView, DolphinSearchBox).

Sun, Jul 14, 8:58 PM · Dolphin
aspotashev updated the diff for D21878: Rewrite servicemenu helper utility in C++.
  • servicemenuinstaller: Use qAsConst
Sun, Jul 14, 8:54 PM · Dolphin
elvisangelaccio requested changes to D21878: Rewrite servicemenu helper utility in C++.
Sun, Jul 14, 8:32 PM · Dolphin
shubham updated the summary of D22444: Add zoom reset action.
Sun, Jul 14, 3:35 PM · Documentation, Dolphin
shubham added inline comments to D22444: Add zoom reset action.
Sun, Jul 14, 3:35 PM · Documentation, Dolphin
shubham retitled D22444: Add zoom reset action from Add zoom reset action to [RFC]: Add zoom reset action.
Sun, Jul 14, 3:33 PM · Documentation, Dolphin
shubham updated the diff for D22444: Add zoom reset action.

use default value

Sun, Jul 14, 3:33 PM · Documentation, Dolphin
meven added a comment to D22144: Add kio recentlyused:/ to access KactivitytStats data.

I wonder if this is the problem:

ls /home/nate/kde/usr/bin/kioclient5
ls: cannot access '/home/nate/kde/usr/bin/kioclient5': No such file or directory

What actually builds that binary? My KIO doesn't seem to do it.

Sun, Jul 14, 1:48 PM · Frameworks, Dolphin
ngraham added a comment to D22144: Add kio recentlyused:/ to access KactivitytStats data.

I wonder if this is the problem:

Sun, Jul 14, 11:30 AM · Frameworks, Dolphin