Please wait for @bruns approval too.
Instructions for how to do this can be found here: https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22
Should I push this also to release/19.12?
Please push to the release/19.12 branch. Thanks!
- Fix extra space
Seems sane to me and nice since it removes some code.
- Do not trim search terms
- Fix comment in CMakeLists.txt
- Fix comment in CMakeLists
- Proper arc diff
- Move to a different test unit
- Address comments
Will have to be rebased after D25260
Abandon in favor of D25255
Tue, Nov 12
Superseded by D25258
Proper diff from D25255
- Rename also in dox comment
Otherwise, LGTM now.
Please remove the Depends D25255 from the summary, this one is independent.
- Update method signatures
- Clarification for text() method
I changed the filenames to address a change in the class name, and it seems that phab didn't preserve the inline comments, sorry.
I've tried to address the majority of them, now with better understanding of @bruns intentions about the refactor itself.
Thanks for the insightful reviews.