Mon, Apr 23
Sorry for the confusion. Let's take all of our comments to D8208.
Address some review comments
Rebase on master in preparation for some refactoring
Sun, Apr 22
Pinging @asensi on whether this would be a good addition to the Krusader project so then we can consider moving it to KIO).
(writing it in this revision as well ;))
Please add option for adding splitters into Places panel.
Oops, re-opened the wrong revision.
Just saw this updated review - please see my comments in https://phabricator.kde.org/D8206.
Duplicate feature is something very interesting that i would like to see as well available in dolphin.
It's extremely useful for people to create copy so they can safety works on original and not using a version system like git or svn.
To be useful, the feature as to be able to operate on files and folders with one or many selected items in a passive way (ie, don't ask for user a file name).
By the way, you can abandon again this one, the correct review is https://phabricator.kde.org/D8208
Rename the "Rename" tab to be "Sequential numbering" or something like that
The issue with this is that there are more tokens now than just "#", so perhaps that could be misleading in a way?
- use a list to keep track of items to be renamed.
- handle update preview on tab change
- Add "Insert token"
- fix check whether file already exists or not
- wrap strings w/ QStringliteral
- show captured groups text
- table column width fits to content
- update labels
- Add help button
- encode new name using KIO::encodeFileName
- make const
- hide "ready to rename" message
- use monospace font for group names
- show status icon when there is an empty filename
- remove empty line
Sat, Apr 21
Re-opening to restart the discussion since apparently now it's not just me; we got a user request for this feature: https://bugs.kde.org/show_bug.cgi?id=393367
Thu, Apr 19
And it looks great!
@ngraham Quick reminder: You can now mark this task as resolved as the 18.04 release happened today. Wohoo! ;)
- Bump minimum required version of baloo-widgets
Wed, Apr 18
Tue, Apr 17
- Minor fixes and cleanup
Mon, Apr 16
Sun, Apr 15
This patch should have bumped the minimum required version of baloo-widgets.
Sorry to join late here ...
Sat, Apr 14
- Touch double click
Hmm, I had to get rid of the touch-hold-drag thing because earlier I was just adapting the existing mouse event handlers with touch, but because multitouch caused issues with that, I've now had to setAcceptTouchEvents(true) on the KItemListView, which means Qt will no longer emit fake mouse events on touch, and that also means no drag and drop because it seems that only works with mouse events. I also disabled rubberbands on touch so I'm seeing any on my end. What kind of touchscreen do you have? Can you verify if touchBeginEvent, touchUpdateEvent, and touchEndEvent are all firing for you?
Getting better! The click/tap issue is gone. But now touch-and-drag in an empty area always starts a rubber band selection, and touch-and-drag on an item immediately starts to drag it--though in both cases, the view is scrolled too, if it's scrollable.
Now using arc
Thanks! I'll use that from now on. I've just been using git format-patch so far.
To change the diff, just issue arc diff. You are using arc, right? ;) ) If not, see:
Okay, so that seems to have fixed that. Is there a cleaner way to append a diff rather than squashing commits together? Can I just push to a branch or something?
Squash diffs together
Remove tests from epubextractortest use multivaluetest instead
Depends on D12197
Uh-oh, it looks like most of the diff got wiped out by that update...
Simplify some if-else statements
Due to the limitations of detecting multiple touches with "fake" mouse events triggered by automatically by Qt on touch, I've had to implement real touch event handlers and which means goodbye drag and drop because after some digging it seems that touch events and native drag n drop don't work well with each other. I've also added the touch gesture to the information panel which is partly broken right because of the "Drag windows by empty space" feature discussed before