DolphinProject
ActivePublic

Recent Activity

Mon, Apr 23

ngraham retitled D8208: [WIP] Add Duplicate feature from Add Duplicate feature to [WIP] Add Duplicate feature.
Mon, Apr 23, 2:32 PM · Dolphin
ngraham added a comment to D8206: Add Duplicate feature.

Sorry for the confusion. Let's take all of our comments to D8208.

Mon, Apr 23, 2:31 PM · Dolphin
ngraham updated the diff for D8208: [WIP] Add Duplicate feature.

Address some review comments

Mon, Apr 23, 2:30 PM · Dolphin
ngraham updated the diff for D8208: [WIP] Add Duplicate feature.

Rebase on master in preparation for some refactoring

Mon, Apr 23, 2:28 PM · Dolphin

Sun, Apr 22

asensi added a comment to D10698: Adds a new RenameDialog to Dolphin with more options for batch renaming.

Pinging @asensi on whether this would be a good addition to the Krusader project so then we can consider moving it to KIO).

Sun, Apr 22, 4:35 PM · Dolphin
markg added a comment to D8208: [WIP] Add Duplicate feature.

(writing it in this revision as well ;))

Sun, Apr 22, 3:27 PM · Dolphin
ngraham updated the task description for T8349: Improve Places panel usability and presentation.
Sun, Apr 22, 3:24 PM · Dolphin
markg added inline comments to D8206: Add Duplicate feature.
Sun, Apr 22, 3:23 PM · Dolphin
ngraham added a revision to T8349: Improve Places panel usability and presentation: D11768: Add Desktop and Downloads to the default list of Places.
Sun, Apr 22, 3:18 PM · Dolphin
ngraham updated the task description for T8349: Improve Places panel usability and presentation.
Sun, Apr 22, 2:05 PM · Dolphin
tomsk added a comment to T8349: Improve Places panel usability and presentation.

Please add option for adding splitters into Places panel.

Sun, Apr 22, 1:41 PM · Dolphin
ngraham abandoned D8206: Add Duplicate feature.

Oops, re-opened the wrong revision.

Sun, Apr 22, 1:17 PM · Dolphin
fazevedo added a comment to D8208: [WIP] Add Duplicate feature.

Just saw this updated review - please see my comments in https://phabricator.kde.org/D8206.
Duplicate feature is something very interesting that i would like to see as well available in dolphin.
It's extremely useful for people to create copy so they can safety works on original and not using a version system like git or svn.
To be useful, the feature as to be able to operate on files and folders with one or many selected items in a passive way (ie, don't ask for user a file name).

Sun, Apr 22, 11:37 AM · Dolphin
fazevedo added a comment to D8206: Add Duplicate feature.

By the way, you can abandon again this one, the correct review is https://phabricator.kde.org/D8208

Sun, Apr 22, 11:32 AM · Dolphin
fazevedo added inline comments to D8206: Add Duplicate feature.
Sun, Apr 22, 11:30 AM · Dolphin
emateli updated subscribers of D10698: Adds a new RenameDialog to Dolphin with more options for batch renaming.

Rename the "Rename" tab to be "Sequential numbering" or something like that

The issue with this is that there are more tokens now than just "#", so perhaps that could be misleading in a way?

Sun, Apr 22, 9:44 AM · Dolphin
emateli updated the summary of D10698: Adds a new RenameDialog to Dolphin with more options for batch renaming.
Sun, Apr 22, 9:34 AM · Dolphin
emateli updated the diff for D10698: Adds a new RenameDialog to Dolphin with more options for batch renaming.
  • use a list to keep track of items to be renamed.
  • handle update preview on tab change
  • Add "Insert token"
  • fix check whether file already exists or not
  • wrap strings w/ QStringliteral
  • show captured groups text
  • table column width fits to content
  • update labels
  • Add help button
  • encode new name using KIO::encodeFileName
  • make const
  • hide "ready to rename" message
  • use monospace font for group names
  • show status icon when there is an empty filename
  • remove empty line
Sun, Apr 22, 9:33 AM · Dolphin

Sat, Apr 21

ngraham reclaimed D8206: Add Duplicate feature.

Re-opening to restart the discussion since apparently now it's not just me; we got a user request for this feature: https://bugs.kde.org/show_bug.cgi?id=393367

Sat, Apr 21, 8:35 PM · Dolphin
ngraham updated the summary of D8206: Add Duplicate feature.
Sat, Apr 21, 8:33 PM · Dolphin

Thu, Apr 19

bruns added inline comments to D10694: epubextractor: Handle multiple subjects better.
Thu, Apr 19, 7:24 PM · Frameworks, Dolphin, Baloo
michaelh added inline comments to D10694: epubextractor: Handle multiple subjects better.
Thu, Apr 19, 6:15 PM · Frameworks, Dolphin, Baloo
ngraham closed T8428: Update release notes for Dolphin 18.04 release as Resolved.

And it looks great!

Thu, Apr 19, 4:22 PM · Dolphin
xyquadrat added a comment to T8428: Update release notes for Dolphin 18.04 release.

@ngraham Quick reminder: You can now mark this task as resolved as the 18.04 release happened today. Wohoo! ;)

Thu, Apr 19, 4:22 PM · Dolphin
bruns added inline comments to D10694: epubextractor: Handle multiple subjects better.
Thu, Apr 19, 4:07 PM · Frameworks, Dolphin, Baloo
michaelh updated the summary of D11245: infopanel: Add choice of date display formats.
Thu, Apr 19, 11:30 AM · KDE Applications, Dolphin
michaelh updated the diff for D11245: infopanel: Add choice of date display formats.
  • Bump minimum required version of baloo-widgets
Thu, Apr 19, 11:29 AM · KDE Applications, Dolphin
michaelh added a dependency for D11245: infopanel: Add choice of date display formats: D12342: Update CMakeLists.txt.
Thu, Apr 19, 11:20 AM · KDE Applications, Dolphin

Wed, Apr 18

mgallien accepted D10694: epubextractor: Handle multiple subjects better.

Thanks

Wed, Apr 18, 7:52 PM · Frameworks, Dolphin, Baloo

Tue, Apr 17

abalaji updated the diff for D12162: Support for touch scrolling in Dolphin.
  • Minor fixes and cleanup
Tue, Apr 17, 11:51 PM · Dolphin

Mon, Apr 16

elvisangelaccio added a comment to D11245: infopanel: Add choice of date display formats.

This patch should have bumped the minimum required version of baloo-widgets.

The current baloo-widgets version 5.0.0 (build/baloowidgets_version.h) has not been changed since April 2014 (https://cgit.kde.org/baloo-widgets.git/diff/CMakeLists.txt?id=a62a6a223b7927bcc18c625f436e454b6601255e). Shouldn't that be bumped first?
Contrary to baloo it seems not to be bumped automatically.

Mon, Apr 16, 9:03 PM · KDE Applications, Dolphin
michaelh added a comment to D11245: infopanel: Add choice of date display formats.

This patch should have bumped the minimum required version of baloo-widgets.

Mon, Apr 16, 2:32 PM · KDE Applications, Dolphin

Sun, Apr 15

elvisangelaccio requested changes to D11245: infopanel: Add choice of date display formats.
Sun, Apr 15, 9:06 PM · KDE Applications, Dolphin
elvisangelaccio reopened D11245: infopanel: Add choice of date display formats.

This patch should have bumped the minimum required version of baloo-widgets.

Sun, Apr 15, 9:06 PM · KDE Applications, Dolphin
bruns added a comment to D10694: epubextractor: Handle multiple subjects better.

Sorry to join late here ...

Sun, Apr 15, 2:59 AM · Frameworks, Dolphin, Baloo

Sat, Apr 14

abalaji updated the diff for D12162: Support for touch scrolling in Dolphin.
  • Touch double click
Sat, Apr 14, 9:54 PM · Dolphin
abalaji added a comment to D12162: Support for touch scrolling in Dolphin.

Hmm, I had to get rid of the touch-hold-drag thing because earlier I was just adapting the existing mouse event handlers with touch, but because multitouch caused issues with that, I've now had to setAcceptTouchEvents(true) on the KItemListView, which means Qt will no longer emit fake mouse events on touch, and that also means no drag and drop because it seems that only works with mouse events. I also disabled rubberbands on touch so I'm seeing any on my end. What kind of touchscreen do you have? Can you verify if touchBeginEvent, touchUpdateEvent, and touchEndEvent are all firing for you?

Sat, Apr 14, 7:51 PM · Dolphin
ngraham added a comment to D12162: Support for touch scrolling in Dolphin.

Getting better! The click/tap issue is gone. But now touch-and-drag in an empty area always starts a rubber band selection, and touch-and-drag on an item immediately starts to drag it--though in both cases, the view is scrolled too, if it's scrollable.

Sat, Apr 14, 7:34 PM · Dolphin
abalaji updated the diff for D12162: Support for touch scrolling in Dolphin.

Now using arc

Sat, Apr 14, 6:23 PM · Dolphin
abalaji added a comment to D12162: Support for touch scrolling in Dolphin.

Thanks! I'll use that from now on. I've just been using git format-patch so far.

Sat, Apr 14, 6:03 PM · Dolphin
ngraham added a comment to D12162: Support for touch scrolling in Dolphin.

To change the diff, just issue arc diff. You are using arc, right? ;) ) If not, see:

Sat, Apr 14, 6:01 PM · Dolphin
abalaji added a comment to D12162: Support for touch scrolling in Dolphin.

Okay, so that seems to have fixed that. Is there a cleaner way to append a diff rather than squashing commits together? Can I just push to a branch or something?

Sat, Apr 14, 5:59 PM · Dolphin
abalaji updated the diff for D12162: Support for touch scrolling in Dolphin.

Squash diffs together

Sat, Apr 14, 5:58 PM · Dolphin
michaelh updated the summary of D10694: epubextractor: Handle multiple subjects better.
Sat, Apr 14, 4:16 PM · Frameworks, Dolphin, Baloo
michaelh added a dependency for D10694: epubextractor: Handle multiple subjects better: D12197: autotests: Test for multiple values.
Sat, Apr 14, 4:15 PM · Frameworks, Dolphin, Baloo
michaelh updated the diff for D10694: epubextractor: Handle multiple subjects better.

Remove tests from epubextractortest use multivaluetest instead
Depends on D12197

Sat, Apr 14, 4:15 PM · Frameworks, Dolphin, Baloo
ngraham added a comment to D12162: Support for touch scrolling in Dolphin.

Uh-oh, it looks like most of the diff got wiped out by that update...

Sat, Apr 14, 1:49 PM · Dolphin
abalaji updated the diff for D12162: Support for touch scrolling in Dolphin.

Simplify some if-else statements

Sat, Apr 14, 7:40 AM · Dolphin
anthonyfieroni added inline comments to D12162: Support for touch scrolling in Dolphin.
Sat, Apr 14, 5:58 AM · Dolphin
abalaji updated the diff for D12162: Support for touch scrolling in Dolphin.

Due to the limitations of detecting multiple touches with "fake" mouse events triggered by automatically by Qt on touch, I've had to implement real touch event handlers and which means goodbye drag and drop because after some digging it seems that touch events and native drag n drop don't work well with each other. I've also added the touch gesture to the information panel which is partly broken right because of the "Drag windows by empty space" feature discussed before

Sat, Apr 14, 2:26 AM · Dolphin