Dolphin side panel to show AppImage information.
@alexeymin, can you try this patch as well, it's pretty annoying to have 5+ versioned tabs, error in one to be shown in others.
Sun, Jan 20
ping, issue is real and annoying.
@elvisangelaccio would you be okay with changing the behavior to always focus the view upon opening a new tab as @emateli requests? I'm pretty much fine with anything, but I'd rather we decide on something so this poor patch can come to the end of its end its identity crisis. :-)
Sat, Jan 19
Chiming in here as the author of the bug report mentioned in this patch.
- Added set_package_properties to explain the optional feature
Fri, Jan 18
Thu, Jan 17
Is there any reason not to commit this now?
Wed, Jan 16
- Rebase preland
+1 it looks good to me.
- Better filter for activeView update
I have no clue what KActivities::ResourceInstance actually does, but it doesn't seem to break anything either.
Tue, Jan 15
Note: I have no clue what KActivities::ResourceInstance actually does, but it doesn't seem to break anything either.
Sorry but I can't reproduce the bug you put in the commit message.
Searchbar propagates events even it's not visible, you can add check for visibility in focusin event.
Is this good to merge?
Mon, Jan 14
- Rebase to master
Rebase on master
Sun, Jan 13
What should I be using as a base for this code? Its currently based upon the Applications/18.12 branch
Elvis' suggestion to use const QString for newTitle
For some reason Phabricator created a second commit for this patch and now the diff shown is only the contents of the second one; replace it with the full diff that spans both commits
Didnt you rebase it?
Address all remaining review comments