DolphinProject
ActivePublic

Recent Activity

Yesterday

astippich added a comment to D21157: handle maps with multiple or single entries from Baloo.

Don't forget to adjust @since 5.xx

Sun, May 26, 7:41 AM · Dolphin
ngraham closed D21177: When filter bar is focused, switch to view when tab key is pressed.
Sun, May 26, 3:32 AM · Dolphin

Sat, May 25

bruns accepted D21157: handle maps with multiple or single entries from Baloo.

Don't forget to adjust @since 5.xx

Sat, May 25, 3:30 PM · Dolphin
elvisangelaccio accepted D21157: handle maps with multiple or single entries from Baloo.
Sat, May 25, 3:25 PM · Dolphin
elvisangelaccio added a comment to D20471: Add "What's This?" to nearly everything in the main window.

Patch looks almost ready now.

Sat, May 25, 3:20 PM · Dolphin
elvisangelaccio accepted D21177: When filter bar is focused, switch to view when tab key is pressed.
Sat, May 25, 3:01 PM · Dolphin
elvisangelaccio added a comment to D16648: Open externally called files/directories in new tabs.

Hmm, I just noticed that KWindowSystem::activateWindow() doesn't seem to work on Wayland.

Sat, May 25, 10:36 AM · Dolphin
elvisangelaccio added a comment to D16648: Open externally called files/directories in new tabs.

Almost there :)

Sat, May 25, 10:11 AM · Dolphin

Fri, May 24

feverfew added inline comments to D16648: Open externally called files/directories in new tabs.
Fri, May 24, 6:03 PM · Dolphin
feverfew updated the diff for D16648: Open externally called files/directories in new tabs.
  • Coding style change
Fri, May 24, 6:02 PM · Dolphin
feverfew updated the diff for D16648: Open externally called files/directories in new tabs.
  • Simplifying conditional
Fri, May 24, 5:56 PM · Dolphin
feverfew updated the diff for D16648: Open externally called files/directories in new tabs.
  • Styling fixes
Fri, May 24, 5:53 PM · Dolphin

Thu, May 23

elvisangelaccio requested changes to D16648: Open externally called files/directories in new tabs.
Thu, May 23, 8:40 PM · Dolphin
feverfew added inline comments to D16648: Open externally called files/directories in new tabs.
Thu, May 23, 10:54 AM · Dolphin

Wed, May 22

fvogt added a comment to D16648: Open externally called files/directories in new tabs.

IMO some of the slots taking a QString/QStringList instead of their QUrl counterpart should have a comment why this is the case.
From a first glance a method isUrlOpen(QString) looks weird, but with a comment that would be come clearer.

Wed, May 22, 7:02 AM · Dolphin
Zren added a comment to D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.

We disabled this feature because KDiskFreeSpaceInfo caused hangs for offline network mounts. Has this changed?

Wed, May 22, 4:39 AM · Dolphin
cfeck added a comment to D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.

We disabled this feature because KDiskFreeSpaceInfo caused hangs for offline network mounts. Has this changed?

Wed, May 22, 2:22 AM · Dolphin
ngraham added a comment to D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.

I think what bugs me is the fact that the bar is below Root as well. If the only Places panel entries to get capacity bars were actual devices, I think it might feel better. And we're actually planning to remove the Root entry soon anyway: D15739. I just need to get around to fixing the test...

Wed, May 22, 2:02 AM · Dolphin
Zren updated the diff for D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.

Use KColorScheme's NegativeText color

Wed, May 22, 1:59 AM · Dolphin
Zren added a comment to D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.

Can you use the NegativeText color from the colorscheme instead of a custom danger color?

Wed, May 22, 1:56 AM · Dolphin

Tue, May 21

feverfew updated the diff for D16648: Open externally called files/directories in new tabs.
  • Addressing code review comments
  • Adding back macro
  • Allow window activation without forceActiveWindow()
  • Avoiding duplication of tabs
  • Distributing URLs among all instances
  • Making ShowFolders/ShowItems also check if URLs are open in other tabs
  • Ensuring current instance is considered when needed
  • Removing unnecessary include
  • Overloading openFiles/openDirectories
  • Removing unnecessary new line
  • Amend test
  • Fixing header file
Tue, May 21, 11:12 PM · Dolphin
astippich updated the diff for D21157: handle maps with multiple or single entries from Baloo.
  • rename variables
Tue, May 21, 6:27 PM · Dolphin
fvogt added a comment to D16648: Open externally called files/directories in new tabs.

It looks like several QUrls were changed to QString here, why? Most of those QStrings, if not all, actually contain URLs.

If I remember correctly Qt methods that are publicised on DBus cannot have parameters as QList<QUrl>, hence I had to use QStringList. This seems to happen often enough that Qt even has helper functions to do the conversion. There are some more conversions to avoid unnecessarily changing method signatures of existing functions.

Not quite sure whether Qt supports that, but you could overload the methods of MainWindow so that the slots accept a QStringList and just pass it on.

QUrl::fromStringList and QUrl::toStringList were created for the express purpose of dealing with DBus calls: https://gitlab.com/pteam/pteam-qtbase/commit/6b9545a980f09d8fb034d930cfe67f6110357d0c.
In fact @dfaure was the one who created these functions himself :)
I think I'll stick with using those static methods unless there is a different reason to objection.

Tue, May 21, 5:57 PM · Dolphin
feverfew updated subscribers of D16648: Open externally called files/directories in new tabs.

It looks like several QUrls were changed to QString here, why? Most of those QStrings, if not all, actually contain URLs.

If I remember correctly Qt methods that are publicised on DBus cannot have parameters as QList<QUrl>, hence I had to use QStringList. This seems to happen often enough that Qt even has helper functions to do the conversion. There are some more conversions to avoid unnecessarily changing method signatures of existing functions.

Not quite sure whether Qt supports that, but you could overload the methods of MainWindow so that the slots accept a QStringList and just pass it on.

Tue, May 21, 5:45 PM · Dolphin
fvogt added a comment to D16648: Open externally called files/directories in new tabs.

It looks like several QUrls were changed to QString here, why? Most of those QStrings, if not all, actually contain URLs.

If I remember correctly Qt methods that are publicised on DBus cannot have parameters as QList<QUrl>, hence I had to use QStringList. This seems to happen often enough that Qt even has helper functions to do the conversion. There are some more conversions to avoid unnecessarily changing method signatures of existing functions.

Tue, May 21, 5:35 PM · Dolphin
ngraham added a comment to D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.

Do you think this and other metrics could just be optional and enabled in settings, for example?

Tue, May 21, 5:32 PM · Dolphin
abetts added a comment to D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.

+1 for restoring the feature, which is very useful! I've wanted this myself many times, so thanks for submitting this! However I'll admit I'm not super thrilled about having the capacity indicator bar always visible. I can't quite put my finger on why, but something about it feels a bit off. Maybe that's why the original only appeared on hover? But that's problematic in an era where we need to be designing for touch-friendliness. Maybe it could be a pie chart to the right of the icon but left of the text? Or maybe it's fine as-is and I'm just being a stick-in-the-mud.

Either way, adding VDG for comment.

I agree that there's something off about it - to me it is the fact that it's a lot of visual clutter that does not give actionable information. It relies on the user knowing how big the volumes are because for example a 90% filled bar is very different to someone with a 100 GiB volume than someone with a 1TiB volume. I don't have any data on this but I have a feeling most people don't care about how full all their volumes are until it hinders them so how I suggest we do it is for it to stay out of the user's way until the volumes are almost full, when there is a reason to present the information and possible actions the user can take.

Or at least vastly reduce how much attention it grabs because it could just be me but it distracts from reading the volume labels, I imagine it can get draining if you have to scan through a lot to find the one you want.

Tue, May 21, 2:36 PM · Dolphin
feverfew added a comment to D16648: Open externally called files/directories in new tabs.

It looks like several QUrls were changed to QString here, why? Most of those QStrings, if not all, actually contain URLs.

Tue, May 21, 1:48 PM · Dolphin
fvogt added a comment to D16648: Open externally called files/directories in new tabs.

It looks like several QUrls were changed to QString here, why? Most of those QStrings, if not all, actually contain URLs.

Tue, May 21, 12:17 PM · Dolphin
feverfew updated the diff for D16648: Open externally called files/directories in new tabs.
  • Removing unnecessary include
Tue, May 21, 11:38 AM · Dolphin
feverfew updated the summary of D16648: Open externally called files/directories in new tabs.
Tue, May 21, 11:31 AM · Dolphin
feverfew updated the diff for D16648: Open externally called files/directories in new tabs.
  • Allow window activation without forceActiveWindow()
  • Avoiding duplication of tabs
  • Distributing URLs among all instances
  • Making ShowFolders/ShowItems also check if URLs are open in other tabs
  • Ensuring current instance is considered when needed
Tue, May 21, 11:28 AM · Dolphin
lavender added a comment to D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.

+1 for restoring the feature, which is very useful! I've wanted this myself many times, so thanks for submitting this! However I'll admit I'm not super thrilled about having the capacity indicator bar always visible. I can't quite put my finger on why, but something about it feels a bit off. Maybe that's why the original only appeared on hover? But that's problematic in an era where we need to be designing for touch-friendliness. Maybe it could be a pie chart to the right of the icon but left of the text? Or maybe it's fine as-is and I'm just being a stick-in-the-mud.

Either way, adding VDG for comment.

Tue, May 21, 9:36 AM · Dolphin
ndavis added a comment to D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.

+1 for restoring the feature, which is very useful! I've wanted this myself many times, so thanks for submitting this! However I'll admit I'm not super thrilled about having the capacity indicator bar always visible. I can't quite put my finger on why, but something about it feels a bit off. Maybe that's why the original only appeared on hover? But that's problematic in an era where we need to be designing for touch-friendliness. Maybe it could be a pie chart to the right of the icon but left of the text? Or maybe it's fine as-is and I'm just being a stick-in-the-mud.

Either way, adding VDG for comment.

Tue, May 21, 5:00 AM · Dolphin

Mon, May 20

filipf added a comment to D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.

Can you use the NegativeText color from the colorscheme instead of a custom danger color?

Mon, May 20, 11:52 PM · Dolphin
abetts added a comment to D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.

I love this idea visually. I would even say that if you enable this on the sidebar, that maybe it should not repeat itself on the bottom bar on the same window.

Mon, May 20, 11:31 PM · Dolphin
ndavis added a comment to D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.

Can you use the NegativeText color from the colorscheme instead of a custom danger color?

Mon, May 20, 11:28 PM · Dolphin
ngraham added reviewers for D10453: Show space left bar for folderw which are mount points instead of "X items": Dolphin, VDG.
Mon, May 20, 11:12 PM · Dolphin
ngraham closed D16967: Add Documents shortcut detection.
Mon, May 20, 10:59 PM · Dolphin
ngraham commandeered D16967: Add Documents shortcut detection.

Needs changes; will make them

Mon, May 20, 10:40 PM · Dolphin
acrouthamel added a comment to D16967: Add Documents shortcut detection.

@ngraham I'm assuming this should be committed since you just committed D16852?

Mon, May 20, 10:10 PM · Dolphin
ngraham updated the task description for T8349: Improve Places panel usability and presentation.
Mon, May 20, 9:57 PM · VDG, Dolphin
Restricted Application added a project to D10453: Show space left bar for folderw which are mount points instead of "X items": Dolphin.

overall it looks nice, but for the icon view, it looks like the progress bar overlap with the dir name. I don't really know how to resolve this problem, displaying it under the text would make the icon+text+progress bar taking to much vertical space. Maybe this information, is not as important in the icon view as in the 2 other views and shouldn't be displayed in the icon view.

Mon, May 20, 9:43 PM · Dolphin
ngraham added a comment to D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.

+1 for restoring the feature, which is very useful! I've wanted this myself many times, so thanks for submitting this! However I'll admit I'm not super thrilled about having the capacity indicator bar always visible. I can't quite put my finger on why, but something about it feels a bit off. Maybe that's why the original only appeared on hover? But that's problematic in an era where we need to be designing for touch-friendliness. Maybe it could be a pie chart to the right of the icon but left of the text? Or maybe it's fine as-is and I'm just being a stick-in-the-mud.

Mon, May 20, 9:41 PM · Dolphin
ngraham updated the summary of D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.
Mon, May 20, 9:33 PM · Dolphin
ngraham added reviewers for D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points: Dolphin, VDG.
Mon, May 20, 9:33 PM · Dolphin
Zren updated the summary of D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.
Mon, May 20, 8:57 PM · Dolphin
Zren requested review of D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.
Mon, May 20, 8:51 PM · Dolphin
Zren added a comment to T9795: Use Places Panel code from KIO instead of private implementation.

I've personally abandoned attempts to merge KIO's Places view in Dolphin for now. Upstreaming those features to KIO is good code practice in the long term though. I've copied the existing KFilePlacesView from KIO and embeded them in this dolphin branch for easy development:

Mon, May 20, 5:32 PM · Frameworks, Dolphin
hallas added a comment to D19989: Unmounting busy device doesn't tell who is blocking.

@davidedmundson - Hi David! I am (finally) starting to look at implementing the lsof functionality in Solid, but I am unsure of where exactly to place it in Solid? Also, currently Solid does not depend on any KF5 libraries, this would be the first, is that ok?

Mon, May 20, 5:24 PM · Dolphin