DolphinProject
ActivePublic

Recent Activity

Today

meven updated the diff for D26732: Use QDesktopServices to open urls not supported by dolphin.

Ensure the url navigator matches the current path

Mon, Jan 20, 9:43 AM · Dolphin
meven updated the summary of D26732: Use QDesktopServices to open urls not supported by dolphin.
Mon, Jan 20, 9:29 AM · Dolphin
meven updated the summary of D18838: Fix opening http links in browser.
Mon, Jan 20, 9:29 AM · Dolphin
meven updated the summary of D18838: Fix opening http links in browser.
Mon, Jan 20, 9:28 AM · Dolphin
gvgeo updated the test plan for D25741: Add natural sorting and case-insensitive sorting for all role-types.
Mon, Jan 20, 7:23 AM · Dolphin
nikolaik updated the diff for D26721: Fixes multiple VCS plugin calls on single directory update..

Added new private slot instead of lambda.

Mon, Jan 20, 7:20 AM · Dolphin
gvgeo updated the diff for D25741: Add natural sorting and case-insensitive sorting for all role-types.

Made requested change.
Removed 1 empty line from header.

Mon, Jan 20, 7:20 AM · Dolphin

Yesterday

iasensio closed D26369: (search) Fix searching tags with spaces.
Sun, Jan 19, 10:17 PM · Dolphin
elvisangelaccio accepted D26732: Use QDesktopServices to open urls not supported by dolphin.
Sun, Jan 19, 10:10 PM · Dolphin
meven added inline comments to D23505: added sorting benchmark.
Sun, Jan 19, 9:54 PM · Dolphin
meven added a comment to D26732: Use QDesktopServices to open urls not supported by dolphin.

Very nice, much simpler than D18838 ;)

This should fix https://bugs.kde.org/show_bug.cgi?id=372642 right?

Sun, Jan 19, 9:46 PM · Dolphin
meven updated the summary of D26732: Use QDesktopServices to open urls not supported by dolphin.
Sun, Jan 19, 9:45 PM · Dolphin
elvisangelaccio accepted D26369: (search) Fix searching tags with spaces.
Sun, Jan 19, 9:37 PM · Dolphin
elvisangelaccio requested changes to D26721: Fixes multiple VCS plugin calls on single directory update..
Sun, Jan 19, 9:15 PM · Dolphin
elvisangelaccio requested changes to D25741: Add natural sorting and case-insensitive sorting for all role-types.

Sorry for the delay, patch looks good but needs some polish.

Sun, Jan 19, 9:09 PM · Dolphin
elvisangelaccio requested changes to D23505: added sorting benchmark.
Sun, Jan 19, 7:23 PM · Dolphin
elvisangelaccio requested changes to D8208: Add Duplicate feature.

Well, that depends on the current sorting mode, right? If I have sort-by-modified then the duplicate file will jump to the top of the view even if it has the "copy" suffix rather than the "Copy of" prefix, no?

If you prepend "Copy of," then it jumps around when you're sorting by Name or Creation Date.

If you append "copy," then it only jumps around when you're sorting by Creation Date.

Sun, Jan 19, 4:12 PM · Dolphin
elvisangelaccio added a comment to D26732: Use QDesktopServices to open urls not supported by dolphin.

Very nice, much simpler than D18838 ;)

Sun, Jan 19, 3:11 PM · Dolphin

Sat, Jan 18

nikolaik updated the diff for D26721: Fixes multiple VCS plugin calls on single directory update..

Updated in response to review comments.

Sat, Jan 18, 12:52 PM · Dolphin
meven added a comment to D25741: Add natural sorting and case-insensitive sorting for all role-types.

ping @elvisangelaccio

Sat, Jan 18, 8:04 AM · Dolphin

Fri, Jan 17

nicolasfella added a comment to D26732: Use QDesktopServices to open urls not supported by dolphin.

+1

Fri, Jan 17, 5:20 PM · Dolphin
meven requested review of D26732: Use QDesktopServices to open urls not supported by dolphin.
Fri, Jan 17, 5:12 PM · Dolphin
ngraham added a comment to D8208: Add Duplicate feature.

Friendly Dolphin ping. :)

Fri, Jan 17, 2:33 PM · Dolphin
meven added a comment to D26721: Fixes multiple VCS plugin calls on single directory update..

Seems fine

Fri, Jan 17, 11:32 AM · Dolphin
meven added inline comments to D26721: Fixes multiple VCS plugin calls on single directory update..
Fri, Jan 17, 11:31 AM · Dolphin
nikolaik retitled D26721: Fixes multiple VCS plugin calls on single directory update. from Partially fixes https://bugs.kde.org/show_bug.cgi?id=415698. to Fixes multiple VCS plugin calls on single directory update..
Fri, Jan 17, 10:09 AM · Dolphin
nikolaik updated the diff for D26721: Fixes multiple VCS plugin calls on single directory update..
Fri, Jan 17, 10:07 AM · Dolphin
nikolaik added reviewers for D26721: Fixes multiple VCS plugin calls on single directory update.: Dolphin, meven, ngraham, elvisangelaccio.
Fri, Jan 17, 9:49 AM · Dolphin
nikolaik requested review of D26721: Fixes multiple VCS plugin calls on single directory update..
Fri, Jan 17, 9:45 AM · Dolphin

Thu, Jan 16

ngraham closed D26648: Improved quality of JPEG thumbnails.
Thu, Jan 16, 5:17 PM · Frameworks, Dolphin
ngraham added a comment to D26648: Improved quality of JPEG thumbnails.

Very nice first patch. May it be the first of many! :)

Thu, Jan 16, 5:17 PM · Frameworks, Dolphin
ngraham added a comment to D26648: Improved quality of JPEG thumbnails.

no in a comment is fine

Thu, Jan 16, 5:16 PM · Frameworks, Dolphin
chroniceel added a comment to D26648: Improved quality of JPEG thumbnails.

... unless you wanted that in the summary?

Thu, Jan 16, 5:15 PM · Frameworks, Dolphin
ngraham accepted D26648: Improved quality of JPEG thumbnails.

@chroniceel Can you provid an email address so we can land this patch with correct authorship information?

Thu, Jan 16, 5:13 PM · Frameworks, Dolphin
cfeck accepted D26648: Improved quality of JPEG thumbnails.

Thanks for the detailed investigation, Stefan!

Thu, Jan 16, 5:11 PM · Frameworks, Dolphin
chroniceel added a comment to D26648: Improved quality of JPEG thumbnails.

Updated diff. It's setting the quality now, and added a brief comment.

Thu, Jan 16, 5:05 PM · Frameworks, Dolphin
chroniceel updated the diff for D26648: Improved quality of JPEG thumbnails.
Thu, Jan 16, 5:03 PM · Frameworks, Dolphin
bruns added a comment to D26648: Improved quality of JPEG thumbnails.

Having had a look at https://code.woboq.org/qt5/qtbase/src/plugins/imageformats/jpeg/qjpeghandler.cpp.html#_M/HIGH_QUALITY_THRESHOLD, the jpeg handler actually know two different quality settings, < 50 and > 50, the default being 75, i.e. high.

Thu, Jan 16, 4:24 PM · Frameworks, Dolphin
meven added a comment to D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.

Could you please first update the code here to request feedback? I still see new_palette.setBrush(QPalette::Highlight, colorScheme.foreground(KColorScheme::ActiveText)) which is wrong, because QPalette::Highlight is a background color role, not a foreground color role.

Thu, Jan 16, 3:44 PM · Dolphin
meven updated the diff for D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.

Support fusion style based KCapacityBar

Thu, Jan 16, 3:43 PM · Dolphin
meven updated the test plan for D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.
Thu, Jan 16, 3:40 PM · Dolphin
chroniceel added a comment to D26648: Improved quality of JPEG thumbnails.

Ping! I think this got buried. Unless someone else is testing this?

Thu, Jan 16, 3:32 PM · Frameworks, Dolphin
ahmadsamir planned changes to D26215: Port QRegExp to QRegularExpression.
Thu, Jan 16, 3:10 PM · Dolphin
cfeck added a comment to D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.

Could you please first update the code here to request feedback? I still see new_palette.setBrush(QPalette::Highlight, colorScheme.foreground(KColorScheme::ActiveText)) which is wrong, because QPalette::Highlight is a background color role, not a foreground color role.

Thu, Jan 16, 2:57 PM · Dolphin
sitter updated the diff for D25682: add initial wsdiscovery support.

redesign finish system

Thu, Jan 16, 2:06 PM · Frameworks, Dolphin
meven added a comment to D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.

You marked my issues as Done but didn't change the code there. Please test with CheckColorRoles on Fusion widget style.

Thank you for pointing this out.

Default KCapactityBar style uses palette().window().color() to get its filling color (QPalette::Base color).

But breeze uses:

//! styled painting for KCapacityBar
QStyle::ControlElement CE_CapacityBar;

from breeze/kstyle/breezestyle.h

My curront code works for breeze but not for Fusion.

Using for fusion :

new_palette.setBrush(QPalette::Base, colorScheme.foreground(KColorScheme::NegativeText));

Works.

So I guess I have to cover the two cases, breeze and more fusion like themes.

Thu, Jan 16, 1:51 PM · Dolphin

Wed, Jan 15

dfaure added inline comments to D25682: add initial wsdiscovery support.
Wed, Jan 15, 9:41 PM · Frameworks, Dolphin

Tue, Jan 14

chroniceel updated the summary of D26648: Improved quality of JPEG thumbnails.
Tue, Jan 14, 4:22 PM · Frameworks, Dolphin
chroniceel added a comment to D26648: Improved quality of JPEG thumbnails.

It's not overly scientific, but with this little fix, it can gen ~10 thumbnails a second on my system (1.6 Ghz pentium, ~10MP). This seems on par with png files of a similar size. As far as I can tell, there is not a super huge performance decrease. Please note, I use a potato.

Tue, Jan 14, 4:11 PM · Frameworks, Dolphin
bruns added a comment to D26648: Improved quality of JPEG thumbnails.

But as I mentioned there, it doesn't really influence on the decoding speed, and it was only needed to preserve the old behavior as much as possible.

Tue, Jan 14, 3:33 PM · Frameworks, Dolphin