DolphinProject
ActivePublic

Recent Activity

Today

kossebau added a comment to T9356: AppImage Awarness in plasma Desktop.

Dolphin side panel to show AppImage information.

Tue, Jan 22, 10:33 AM · Baloo, VDG, Plasma, Dolphin

Yesterday

ngraham updated the summary of D7446: [Places panel] Revamp the Recently Saved section.
Mon, Jan 21, 11:44 PM · Frameworks, Dolphin
anthonyfieroni updated subscribers of D17640: [versioncontrolobserver] Do not use static plugin objects.

@alexeymin, can you try this patch as well, it's pretty annoying to have 5+ versioned tabs, error in one to be shown in others.

Mon, Jan 21, 7:26 PM · Dolphin

Sun, Jan 20

anthonyfieroni added a comment to D17640: [versioncontrolobserver] Do not use static plugin objects.

ping, issue is real and annoying.

Sun, Jan 20, 5:27 PM · Dolphin
ngraham added a comment to D17635: Refine focus behavior after opening a new tab.

@elvisangelaccio would you be okay with changing the behavior to always focus the view upon opening a new tab as @emateli requests? I'm pretty much fine with anything, but I'd rather we decide on something so this poor patch can come to the end of its end its identity crisis. :-)

Sun, Jan 20, 1:49 AM · Dolphin

Sat, Jan 19

emateli added a comment to D17635: Refine focus behavior after opening a new tab.

Chiming in here as the author of the bug report mentioned in this patch.

Sat, Jan 19, 5:31 PM · Dolphin
ngraham closed D13316: manually set format in jpeg thumbnail creator.
Sat, Jan 19, 4:00 PM · Frameworks, Dolphin
ngraham updated the test plan for D17635: Refine focus behavior after opening a new tab.
Sat, Jan 19, 3:57 PM · Dolphin
ngraham closed D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program.
Sat, Jan 19, 3:15 PM · Dolphin
elvisangelaccio added inline comments to D17635: Refine focus behavior after opening a new tab.
Sat, Jan 19, 11:43 AM · Dolphin
elvisangelaccio accepted D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program.

LGTM now.

Sat, Jan 19, 11:35 AM · Dolphin
elvisangelaccio accepted D13316: manually set format in jpeg thumbnail creator.
Sat, Jan 19, 11:19 AM · Frameworks, Dolphin
elvisangelaccio updated the diff for D18273: Bring back KActivities support.
  • Added set_package_properties to explain the optional feature
Sat, Jan 19, 11:12 AM · Dolphin

Fri, Jan 18

ngraham added a comment to D17635: Refine focus behavior after opening a new tab.

Friendly ping.

Fri, Jan 18, 6:12 PM · Dolphin
ngraham added a comment to D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program.

Friendly ping.

Fri, Jan 18, 6:10 PM · Dolphin

Thu, Jan 17

Restricted Application added projects to D13316: manually set format in jpeg thumbnail creator: Dolphin, Frameworks.

Is there any reason not to commit this now?

Thu, Jan 17, 2:39 AM · Frameworks, Dolphin

Wed, Jan 16

aacid closed D13416: image thumbnailer: instruct Qt to look at the file contents when detecting its format.
Wed, Jan 16, 11:54 PM · Frameworks, Dolphin
Restricted Application added projects to D13416: image thumbnailer: instruct Qt to look at the file contents when detecting its format: Dolphin, Frameworks.

I pushed this at https://commits.kde.org/kio-extras/0be80392f01e0ec01174990c430dcd8f1ed35d9e

Wed, Jan 16, 11:54 PM · Frameworks, Dolphin
rizzitello closed D17882: Abort updateWindowTitle and activeViewChanged if not changed..
Wed, Jan 16, 10:34 PM · Dolphin
rizzitello updated the diff for D17882: Abort updateWindowTitle and activeViewChanged if not changed..
  • Rebase preland
Wed, Jan 16, 10:34 PM · Dolphin
elvisangelaccio accepted D17882: Abort updateWindowTitle and activeViewChanged if not changed..
Wed, Jan 16, 6:17 PM · Dolphin
anthonyfieroni added a comment to D17882: Abort updateWindowTitle and activeViewChanged if not changed..

+1 it looks good to me.

Wed, Jan 16, 2:22 PM · Dolphin
rizzitello updated the diff for D17882: Abort updateWindowTitle and activeViewChanged if not changed..
  • Better filter for activeView update
Wed, Jan 16, 2:12 PM · Dolphin
rizzitello added a comment to D17882: Abort updateWindowTitle and activeViewChanged if not changed..

Searchbar propagates events even it's not visible, you can add check for visibility in focusin event.

Wed, Jan 16, 2:12 PM · Dolphin
broulik added a comment to D18273: Bring back KActivities support.
I have no clue what KActivities::ResourceInstance actually does, but it doesn't seem to break anything either.
Wed, Jan 16, 9:29 AM · Dolphin
anthonyfieroni added a comment to D17640: [versioncontrolobserver] Do not use static plugin objects.

Sorry but I can't reproduce the bug you put in the commit message.

I tried to do a git checkout on a dirty repo, but the error message only shows up in the versioned tab (not in all tabs).

Wed, Jan 16, 5:48 AM · Dolphin
anthonyfieroni updated the summary of D17640: [versioncontrolobserver] Do not use static plugin objects.
Wed, Jan 16, 5:47 AM · Dolphin

Tue, Jan 15

ngraham added a reviewer for D18273: Bring back KActivities support: ivan.
Tue, Jan 15, 6:54 PM · Dolphin
elvisangelaccio added a comment to D18273: Bring back KActivities support.

Note: I have no clue what KActivities::ResourceInstance actually does, but it doesn't seem to break anything either.

Tue, Jan 15, 6:04 PM · Dolphin
elvisangelaccio requested review of D18273: Bring back KActivities support.
Tue, Jan 15, 6:02 PM · Dolphin
elvisangelaccio requested changes to D17640: [versioncontrolobserver] Do not use static plugin objects.

Sorry but I can't reproduce the bug you put in the commit message.

Tue, Jan 15, 4:22 PM · Dolphin
anthonyfieroni added a comment to D17882: Abort updateWindowTitle and activeViewChanged if not changed..

Searchbar propagates events even it's not visible, you can add check for visibility in focusin event.

Tue, Jan 15, 4:03 PM · Dolphin
elvisangelaccio accepted D17882: Abort updateWindowTitle and activeViewChanged if not changed..
Tue, Jan 15, 3:56 PM · Dolphin
rizzitello added a comment to D17882: Abort updateWindowTitle and activeViewChanged if not changed..

Is this good to merge?

Tue, Jan 15, 2:21 PM · Dolphin
sukalyanbanga removed a watcher for Dolphin: sukalyanbanga.
Tue, Jan 15, 6:19 AM

Mon, Jan 14

anthonyfieroni added inline comments to D17640: [versioncontrolobserver] Do not use static plugin objects.
Mon, Jan 14, 6:25 PM · Dolphin
sukalyanbanga added a watcher for Dolphin: sukalyanbanga.
Mon, Jan 14, 12:06 PM
rizzitello updated the diff for D17882: Abort updateWindowTitle and activeViewChanged if not changed..
  • Rebase to master
Mon, Jan 14, 1:55 AM · Dolphin
rizzitello updated the diff for D17882: Abort updateWindowTitle and activeViewChanged if not changed..
  • Rebase
Mon, Jan 14, 1:46 AM · Dolphin
rizzitello updated the diff for D17882: Abort updateWindowTitle and activeViewChanged if not changed..

Rebase on master

Mon, Jan 14, 1:41 AM · Dolphin

Sun, Jan 13

elvisangelaccio added a comment to D17882: Abort updateWindowTitle and activeViewChanged if not changed..

What should I be using as a base for this code? Its currently based upon the Applications/18.12 branch

Sun, Jan 13, 3:02 PM · Dolphin
rizzitello added a comment to D17882: Abort updateWindowTitle and activeViewChanged if not changed..

What should I be using as a base for this code? Its currently based upon the Applications/18.12 branch

Sun, Jan 13, 2:26 PM · Dolphin
rizzitello added inline comments to D17882: Abort updateWindowTitle and activeViewChanged if not changed..
Sun, Jan 13, 2:25 PM · Dolphin
rizzitello updated the diff for D17882: Abort updateWindowTitle and activeViewChanged if not changed..

Elvis' suggestion to use const QString for newTitle

Sun, Jan 13, 2:25 PM · Dolphin
elvisangelaccio accepted D17882: Abort updateWindowTitle and activeViewChanged if not changed..
Sun, Jan 13, 9:28 AM · Dolphin
ngraham updated the summary of D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program.
Sun, Jan 13, 2:38 AM · Dolphin
ngraham added inline comments to D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program.
Sun, Jan 13, 2:30 AM · Dolphin
ngraham updated the diff for D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program.

For some reason Phabricator created a second commit for this patch and now the diff shown is only the contents of the second one; replace it with the full diff that spans both commits

Sun, Jan 13, 2:30 AM · Dolphin
shubham added a comment to D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program.

Didnt you rebase it?

Sun, Jan 13, 2:30 AM · Dolphin
ngraham updated the diff for D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program.

Address all remaining review comments

Sun, Jan 13, 2:27 AM · Dolphin