I'm not an expert in dolphin but other than that it looks good to me. +1
Thanks for noticing! I've updated the patch to fix the crash.
I get a crash if I run dolphin /etc/fstab:
Please push to master only.
- Update with requested changes
@elvisangelaccio I could use home help on this. After rebasing on the stable branch and testing again, the menu item does not toggle the focus like it should. I swear this worked before but now it doesn't anymore. :( m_terminalPanel->terminalHasFocus() does not seem to return the correct result and I'm having trouble figuring out why.
Sun, Mar 24
That said, the fix looks correct. An unit test for this crash would be awesome, you have spare time.
Hmm, I can't reproduce the crash following the test plan.
Thanks, that's perfect. The UI for this is now flawless in my opinion. :) I'll hand this show back over to @elvisangelaccio for code review.
Thanks @elvisangelaccio about EventFilter I had never used it before, still getting used to to Qt Api.
Use event filter to handle clicks, use enum instead of booleans, better ifs
Avoid unneeded changes
Rebase on master
Yes please. :)
Alright, I'll re-open this vs KUrlNavigator soon. Thanks!
Yes please, this feature really belongs to KUrlNavigator.
Considering that right now the up arrow key does nothing at all when in editable mode, I think this makes a lot of sense. However what do you think about adding this functionality to the URL Navigator widget itself? That way clients like Dolphin wouldn't have to implement a custom behavior, and all would get it for free.
Fixed through D19844
Should it go to stable Applications/19.04 ?
Makes sense to me and works properly.