DolphinProject
ActivePublic

Recent Activity

Today

amhndu closed D19904: Prompt user to save/discard changes upon closing config dialog.
Tue, Mar 26, 8:54 AM · Dolphin
pino added inline comments to D20049: Fix unexpected behaviour when calling dolphin with a file as an argument.
Tue, Mar 26, 5:32 AM · Dolphin

Yesterday

apol added a comment to D20049: Fix unexpected behaviour when calling dolphin with a file as an argument.

I'm not an expert in dolphin but other than that it looks good to me. +1

Mon, Mar 25, 11:36 PM · Dolphin
krutovmikhail added a reviewer for D20052: BUG: 197009 - Enchancement: Add tab names: Dolphin.
Mon, Mar 25, 10:44 PM · Dolphin
krutovmikhail requested review of D20052: BUG: 197009 - Enchancement: Add tab names.
Mon, Mar 25, 10:39 PM · Dolphin
krutovmikhail added a comment to D20049: Fix unexpected behaviour when calling dolphin with a file as an argument.

Thanks for noticing! I've updated the patch to fix the crash.

Mon, Mar 25, 9:24 PM · Dolphin
krutovmikhail updated the diff for D20049: Fix unexpected behaviour when calling dolphin with a file as an argument.

Fixed crash

Mon, Mar 25, 9:23 PM · Dolphin
elvisangelaccio requested changes to D20049: Fix unexpected behaviour when calling dolphin with a file as an argument.

I get a crash if I run dolphin /etc/fstab:

Mon, Mar 25, 9:05 PM · Dolphin
elvisangelaccio accepted D19904: Prompt user to save/discard changes upon closing config dialog.

Please push to master only.

Mon, Mar 25, 8:55 PM · Dolphin
ngraham updated the summary of D20049: Fix unexpected behaviour when calling dolphin with a file as an argument.
Mon, Mar 25, 7:30 PM · Dolphin
krutovmikhail added a reviewer for D20049: Fix unexpected behaviour when calling dolphin with a file as an argument: Dolphin.
Mon, Mar 25, 6:13 PM · Dolphin
krutovmikhail requested review of D20049: Fix unexpected behaviour when calling dolphin with a file as an argument.
Mon, Mar 25, 6:12 PM · Dolphin
amhndu updated the diff for D19904: Prompt user to save/discard changes upon closing config dialog.
  • Update with requested changes
Mon, Mar 25, 10:12 AM · Dolphin
ngraham added a comment to D10959: Add action for focusing Terminal Panel.

@elvisangelaccio I could use home help on this. After rebasing on the stable branch and testing again, the menu item does not toggle the focus like it should. I swear this worked before but now it doesn't anymore. :( m_terminalPanel->terminalHasFocus() does not seem to return the correct result and I'm having trouble figuring out why.

Mon, Mar 25, 8:23 AM · Dolphin

Sun, Mar 24

elvisangelaccio added a comment to D20024: Fixes crash when hiding devices.

That said, the fix looks correct. An unit test for this crash would be awesome, you have spare time.

Sun, Mar 24, 8:39 PM · Dolphin
elvisangelaccio added a comment to D20024: Fixes crash when hiding devices.

Hmm, I can't reproduce the crash following the test plan.

Sun, Mar 24, 8:34 PM · Dolphin
knauss added a project to T8807: Metadata Anonymisation Toolkit integration in Dolphin: KDE Privacy Goal.
Sun, Mar 24, 8:21 PM · KDE Privacy Goal, Dolphin
knauss removed a parent task for T8807: Metadata Anonymisation Toolkit integration in Dolphin: T7050: Privacy Software.
Sun, Mar 24, 8:21 PM · KDE Privacy Goal, Dolphin
ngraham accepted D19311: Add navigation history to forward/back buttons.

Thanks, that's perfect. The UI for this is now flawless in my opinion. :) I'll hand this show back over to @elvisangelaccio for code review.

Sun, Mar 24, 8:12 PM · Dolphin
meven added a comment to D19782: Allow dolphin to auto-play previewed media file, click on preview to play/pause videos or audio.

Thanks @elvisangelaccio about EventFilter I had never used it before, still getting used to to Qt Api.

Sun, Mar 24, 7:48 PM · Dolphin
meven updated the diff for D19782: Allow dolphin to auto-play previewed media file, click on preview to play/pause videos or audio.

Clean up

Sun, Mar 24, 7:46 PM · Dolphin
meven updated the diff for D19782: Allow dolphin to auto-play previewed media file, click on preview to play/pause videos or audio.

Clean up

Sun, Mar 24, 7:44 PM · Dolphin
meven updated the diff for D19782: Allow dolphin to auto-play previewed media file, click on preview to play/pause videos or audio.

Add comments

Sun, Mar 24, 7:43 PM · Dolphin
meven updated the diff for D19782: Allow dolphin to auto-play previewed media file, click on preview to play/pause videos or audio.

Clean up

Sun, Mar 24, 7:39 PM · Dolphin
meven updated the diff for D19782: Allow dolphin to auto-play previewed media file, click on preview to play/pause videos or audio.

Use event filter to handle clicks, use enum instead of booleans, better ifs

Sun, Mar 24, 7:39 PM · Dolphin
hallas requested review of D20024: Fixes crash when hiding devices.
Sun, Mar 24, 7:00 PM · Dolphin
elvisangelaccio requested changes to D19782: Allow dolphin to auto-play previewed media file, click on preview to play/pause videos or audio.
Sun, Mar 24, 6:58 PM · Dolphin
ngraham retitled D19782: Allow dolphin to auto-play previewed media file, click on preview to play/pause videos or audio from BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio to Allow dolphin to auto-play previewed media file, click on preview to play/pause videos or audio.
Sun, Mar 24, 6:24 PM · Dolphin
meven updated the diff for D19782: Allow dolphin to auto-play previewed media file, click on preview to play/pause videos or audio.

Fix building

Sun, Mar 24, 6:22 PM · Dolphin
meven added a comment to D19782: Allow dolphin to auto-play previewed media file, click on preview to play/pause videos or audio.

ping @elvisangelaccio

Sun, Mar 24, 6:12 PM · Dolphin
meven updated the diff for D19782: Allow dolphin to auto-play previewed media file, click on preview to play/pause videos or audio.

Avoid unneeded changes

Sun, Mar 24, 6:11 PM · Dolphin
meven updated the diff for D19782: Allow dolphin to auto-play previewed media file, click on preview to play/pause videos or audio.

Rebase on master

Sun, Mar 24, 6:05 PM · Dolphin
ngraham added a comment to D20004: Add "Up" action to editable mode, accessible via Key_Up press while focus is on lineEdit.

Yes please. :)

Sun, Mar 24, 6:03 PM · Dolphin
krutovmikhail abandoned D20004: Add "Up" action to editable mode, accessible via Key_Up press while focus is on lineEdit.

Alright, I'll re-open this vs KUrlNavigator soon. Thanks!

Sun, Mar 24, 6:02 PM · Dolphin
elvisangelaccio added a comment to D20004: Add "Up" action to editable mode, accessible via Key_Up press while focus is on lineEdit.

Yes please, this feature really belongs to KUrlNavigator.

Sun, Mar 24, 5:55 PM · Dolphin
ngraham added a comment to D20004: Add "Up" action to editable mode, accessible via Key_Up press while focus is on lineEdit.

Considering that right now the up arrow key does nothing at all when in editable mode, I think this makes a lot of sense. However what do you think about adding this functionality to the URL Navigator widget itself? That way clients like Dolphin wouldn't have to implement a custom behavior, and all would get it for free.

Sun, Mar 24, 5:46 PM · Dolphin
ngraham added a reviewer for D20004: Add "Up" action to editable mode, accessible via Key_Up press while focus is on lineEdit: VDG.
Sun, Mar 24, 5:43 PM · Dolphin
ngraham closed D19950: Move Safely Remove down in places context menu.
Sun, Mar 24, 5:41 PM · Dolphin
meven abandoned D19910: Hide the phonon widget when preview gets disabled.

Fixed through D19844

Sun, Mar 24, 5:40 PM · Dolphin
meven updated the summary of D19782: Allow dolphin to auto-play previewed media file, click on preview to play/pause videos or audio.
Sun, Mar 24, 5:39 PM · Dolphin
meven closed D19936: When hovering over a file on the not-focus view panel, the information panel gets updated.
Sun, Mar 24, 5:38 PM · Dolphin
ngraham added inline comments to D19904: Prompt user to save/discard changes upon closing config dialog.
Sun, Mar 24, 5:38 PM · Dolphin
elvisangelaccio requested changes to D19904: Prompt user to save/discard changes upon closing config dialog.
Sun, Mar 24, 5:36 PM · Dolphin
ngraham added a comment to D19936: When hovering over a file on the not-focus view panel, the information panel gets updated.

Yes please!

Sun, Mar 24, 5:36 PM · Dolphin
meven added a comment to D19936: When hovering over a file on the not-focus view panel, the information panel gets updated.

Should it go to stable Applications/19.04 ?

Sun, Mar 24, 5:33 PM · Dolphin
meven closed D19844: [InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled.
Sun, Mar 24, 5:33 PM · Dolphin
ngraham accepted D19936: When hovering over a file on the not-focus view panel, the information panel gets updated.

Makes sense to me and works properly.

Sun, Mar 24, 4:55 PM · Dolphin
ngraham added a comment to D19904: Prompt user to save/discard changes upon closing config dialog.

Should that really prompt the user? I expect clicking Cancel to close the dialog

Sun, Mar 24, 4:26 PM · Dolphin
ngraham accepted D19844: [InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled.
Sun, Mar 24, 4:03 PM · Dolphin
davidedmundson added a comment to D19831: Create a global launch shortcut (Meta+E).

Careful with konsole, we have to do a migration as AFAIK it's been released with the khotkeys file.

Sun, Mar 24, 3:51 PM · Dolphin