DolphinProject
ActivePublic

Recent Activity

Today

acrouthamel added a comment to D12162: Add support for touch scrolling in Dolphin.

How cool is this, how have I not seen this yet?

Thu, Sep 20, 2:52 AM · Dolphin
ngraham updated subscribers of D12162: Add support for touch scrolling in Dolphin.

@broulik, any chance you could help out with the code review for this? My sense is that a lot of people would really love touch support in Dolphin.

Thu, Sep 20, 2:27 AM · Dolphin

Yesterday

ngraham updated the test plan for D15610: Add "Create Folder" action to default toolbar.
Wed, Sep 19, 11:11 PM · Dolphin
ngraham requested review of D15610: Add "Create Folder" action to default toolbar.
Wed, Sep 19, 11:10 PM · Dolphin
ngraham updated the test plan for D15609: Add "Create New" menu to "Control" button.
Wed, Sep 19, 11:07 PM · Dolphin
ngraham requested review of D15609: Add "Create New" menu to "Control" button.
Wed, Sep 19, 11:06 PM · Dolphin
abetts added a comment to D15591: Add Open Document thumbnailer.

+1

Wed, Sep 19, 2:02 PM · Frameworks, Dolphin
Restricted Application added a project to D7647: Two clicks on file/folder to rename: Dolphin.

This apparently caused regressions as I noticed:

Wed, Sep 19, 12:44 PM · Dolphin
broulik closed D15591: Add Open Document thumbnailer.
Wed, Sep 19, 11:22 AM · Frameworks, Dolphin
Restricted Application added projects to D15591: Add Open Document thumbnailer: Dolphin, Frameworks.
Wed, Sep 19, 11:11 AM · Frameworks, Dolphin
broulik closed D15508: Update disk space info on refresh.
Wed, Sep 19, 8:20 AM · Dolphin
ngraham added a comment to D15579: RFC: Use full-sized highlight.

Does the hit-box match the highlight region? Please also test with wide icon texts.

Wed, Sep 19, 3:28 AM · Dolphin
ngraham requested changes to D15579: RFC: Use full-sized highlight.

Tried this out and there's a little problem: the underline looks bad for us low-DPI folks. It takes a chunk out of the bottom edge of the highlight:

Wed, Sep 19, 3:24 AM · Dolphin
ngraham updated the summary of D15579: RFC: Use full-sized highlight.
Wed, Sep 19, 3:11 AM · Dolphin

Tue, Sep 18

cfeck added a comment to D15579: RFC: Use full-sized highlight.

See also discussion at bug 309722.

Tue, Sep 18, 11:52 PM · Dolphin
cfeck added a comment to D15579: RFC: Use full-sized highlight.

Does the hit-box match the highlight region? Please also test with wide icon texts.

Tue, Sep 18, 11:44 PM · Dolphin
broulik requested review of D15589: Add proper labels to Trash Emptied notification.
Tue, Sep 18, 1:08 PM · Dolphin
wbauer added inline comments to D15147: Correctly save behaviourOnLaunch.
Tue, Sep 18, 12:58 PM · Dolphin
broulik added a comment to D15506: RFC: [StatusBarSpaceInfo] Only update when window is active.

https://doc.qt.io/qt-5/qwidget.html#visibleRegion would be more reliable and also work for not visible tabs I think.

Tue, Sep 18, 8:37 AM · Dolphin
broulik updated the diff for D15507: [MountPointObserverCache] Update mounts less frequently.
  • Just bump interval to 60 seconds
Tue, Sep 18, 8:30 AM · Dolphin
ngraham added a comment to D15507: [MountPointObserverCache] Update mounts less frequently.

+1 to always reducing the interval to one minute.

Tue, Sep 18, 3:28 AM · Dolphin

Mon, Sep 17

ngraham accepted D15579: RFC: Use full-sized highlight.

Technically that is correct--Breeze widget theme vs Breeze Plasma theme. But from a user perspective, it's a needless inconsistency. The fact that Folder view is a Plasma widget rather than an extension of Dolphin is an implementation detail lost on people who aren't power users or developers. And even for someone who understands the distinction, they might (not unreasonably) think, Why should the Breeze widget theme look different from the Breeze Plasma theme? Aren't they both Breeze?

Mon, Sep 17, 4:07 PM · Dolphin
broulik added a comment to D15579: RFC: Use full-sized highlight.

In that case, Folder View is inconsistent because it uses rounded corners...

Mon, Sep 17, 3:47 PM · Dolphin
ngraham added a comment to D15579: RFC: Use full-sized highlight.

It might be nice to round the corners a bit, if that's not too hard--and then make the same change for the open/save dialogs too.

That's governed by the widget style. Breeze uses square corners, Oxygen, for instance uses round ones, so doing that should be easy, and will affect all places, so any change there must be done carefully.

Mon, Sep 17, 3:41 PM · Dolphin
abetts added a comment to D15579: RFC: Use full-sized highlight.

It might be nice to round the corners a bit, if that's not too hard--and then make the same change for the open/save dialogs too.

That's governed by the widget style. Breeze uses square corners, Oxygen, for instance uses round ones, so doing that should be easy, and will affect all places, so any change there must be done carefully.

Mon, Sep 17, 3:39 PM · Dolphin
broulik added a comment to D15579: RFC: Use full-sized highlight.

It might be nice to round the corners a bit, if that's not too hard--and then make the same change for the open/save dialogs too.

Mon, Sep 17, 3:37 PM · Dolphin
broulik updated the test plan for D15579: RFC: Use full-sized highlight.
Mon, Sep 17, 3:37 PM · Dolphin
abetts added a comment to D15579: RFC: Use full-sized highlight.

What to we think of a split highlight? Something like a rounded square for the icon and a rounded square for the labels?

Mon, Sep 17, 3:36 PM · Dolphin
ngraham added a comment to D15579: RFC: Use full-sized highlight.

+1 because this makes Dolphin's Icon View visually consistent with the file open/save dialogs, and at least conceptually consistent with Folder View, which also uses a full-sized highlight (even though it looks different there).

Mon, Sep 17, 3:27 PM · Dolphin
broulik requested review of D15579: RFC: Use full-sized highlight.
Mon, Sep 17, 2:52 PM · Dolphin
broulik closed D15237: [ViewProperties] Check part of home first before doing file system stuff.
Mon, Sep 17, 2:03 PM · Dolphin
sitter added a comment to D15506: RFC: [StatusBarSpaceInfo] Only update when window is active.

https://doc.qt.io/qt-5/qwidget.html#visibleRegion would be more reliable and also work for not visible tabs I think.

Mon, Sep 17, 12:50 PM · Dolphin
anthonyfieroni added inline comments to D15507: [MountPointObserverCache] Update mounts less frequently.
Mon, Sep 17, 11:47 AM · Dolphin
broulik added a comment to D15507: [MountPointObserverCache] Update mounts less frequently.

Also note that Plasma's "disk low" warning only polls every minute either.

Mon, Sep 17, 11:42 AM · Dolphin
sitter added a comment to D15507: [MountPointObserverCache] Update mounts less frequently.

As mentioned on IRC I was thinking that we should simply bump the overall poll interval to 1 minute instead of splitting timers. The additional code seems hardly worthwhile considering the original 10s value is really odd if you do some quick maths... from IRC:

Mon, Sep 17, 11:41 AM · Dolphin
davidedmundson closed D15539: Keep org.freedesktop.FileManager1 registered across processes.
Mon, Sep 17, 10:04 AM · Dolphin
broulik updated the diff for D15508: Update disk space info on refresh.
  • Make SpaceInfoObserver::update a slot
Mon, Sep 17, 9:42 AM · Dolphin

Sun, Sep 16

broulik abandoned D15516: Don't set window icon in daemon mode.
Sun, Sep 16, 5:39 PM · Dolphin
elvisangelaccio accepted D15539: Keep org.freedesktop.FileManager1 registered across processes.

Thanks

Sun, Sep 16, 8:47 AM · Dolphin

Sat, Sep 15

davidedmundson added a comment to D15516: Don't set window icon in daemon mode.

(imho the "daemon" should quit after having fullfilled the dbus activation request but that's an unrelated issue)

Sat, Sep 15, 5:15 PM · Dolphin
davidedmundson requested review of D15539: Keep org.freedesktop.FileManager1 registered across processes.
Sat, Sep 15, 5:00 PM · Dolphin
elvisangelaccio added a comment to D15278: Close Dolphin if last tab closed.

Let's not make this an option, please :/

Sat, Sep 15, 11:26 AM · Dolphin
elvisangelaccio added a comment to D15404: [KFileItemModelRolesUpdater] Avoid duplicate indexes to resolve.

@broulik Can you please "plan changes" or abandon it then?

Sat, Sep 15, 11:05 AM · Dolphin
elvisangelaccio added a comment to D15506: RFC: [StatusBarSpaceInfo] Only update when window is active.

+1 for D15507 and D15508

Sat, Sep 15, 10:56 AM · Dolphin
elvisangelaccio added inline comments to D15508: Update disk space info on refresh.
Sat, Sep 15, 10:52 AM · Dolphin
elvisangelaccio accepted D15237: [ViewProperties] Check part of home first before doing file system stuff.
Sat, Sep 15, 10:39 AM · Dolphin
broulik added inline comments to D15507: [MountPointObserverCache] Update mounts less frequently.
Sat, Sep 15, 7:20 AM · Dolphin
ngraham accepted D15508: Update disk space info on refresh.
Sat, Sep 15, 2:07 AM · Dolphin

Fri, Sep 14

broulik updated the test plan for D15516: Don't set window icon in daemon mode.
Fri, Sep 14, 10:03 PM · Dolphin
broulik requested review of D15516: Don't set window icon in daemon mode.
Fri, Sep 14, 10:00 PM · Dolphin