DolphinProject
ActivePublic

Recent Activity

Today

nicolasfella updated the task description for T9094: Improve Dolphin's tag support.
Tue, Nov 13, 5:30 PM · VDG, Baloo, Frameworks, Dolphin
nicolasfella updated the task description for T8349: Improve Places panel usability and presentation.
Tue, Nov 13, 5:29 PM · VDG, Dolphin
nicolasfella closed D7700: Show list of tags in PlacesView.
Tue, Nov 13, 5:06 PM · Frameworks, Dolphin
nicolasfella added inline comments to D7700: Show list of tags in PlacesView.
Tue, Nov 13, 5:05 PM · Frameworks, Dolphin
ngraham updated subscribers of T8349: Improve Places panel usability and presentation.
Tue, Nov 13, 2:38 PM · VDG, Dolphin
ngraham added a revision to T8349: Improve Places panel usability and presentation: D7700: Show list of tags in PlacesView.
Tue, Nov 13, 2:36 PM · VDG, Dolphin
ngraham added a task to D7700: Show list of tags in PlacesView: T8349: Improve Places panel usability and presentation.
Tue, Nov 13, 2:36 PM · Frameworks, Dolphin
ngraham accepted D7700: Show list of tags in PlacesView.

A surprisingly small amount of code for a nice feature. Code looks good to me except for one minor thing. This works great in my testing now. I say let's ship it, especially because it won't result in any UI changes at all for people who don't use tags.

Tue, Nov 13, 2:35 PM · Frameworks, Dolphin
nicolasfella updated the diff for D7700: Show list of tags in PlacesView.
  • Merge branch 'master' into arcpatch-D7700
Tue, Nov 13, 1:13 PM · Frameworks, Dolphin
ngraham added a comment to D7700: Show list of tags in PlacesView.

Me neither. Can you rebase this on current master?

Tue, Nov 13, 12:02 PM · Frameworks, Dolphin
ngraham updated the task description for T8349: Improve Places panel usability and presentation.
Tue, Nov 13, 11:13 AM · VDG, Dolphin
ngraham added a revision to T8349: Improve Places panel usability and presentation: D16852: Add Documents to the default list of Places.
Tue, Nov 13, 11:12 AM · VDG, Dolphin
ngraham edited reviewers for D16857: Do not disconnect all StorageAccess signals when unmounting, added: Frameworks, bruns; removed: VDG.
Tue, Nov 13, 11:04 AM · Dolphin
thsurrel requested review of D16857: Do not disconnect all StorageAccess signals when unmounting.
Tue, Nov 13, 10:11 AM · Dolphin

Yesterday

ngraham accepted D16767: Improve Ux for the places panel's hidden items.

Thanks, this is great UI-wise now! Big thumbs up.

Mon, Nov 12, 4:13 AM · Dolphin

Sun, Nov 11

nicolasfella added a comment to D7700: Show list of tags in PlacesView.

Results of testing:

  • After I create a new tag, it doesn't show up in the Places panel tag list or under the tags:/ ioslave until I restart Dolphin.
  • When I navigate to tags:/ ioslave using the All Tags item in the Places panel and I click on a tag, its icon disappears.
  • When I remove a tag from an item and navigate to that tag entry on the Places panel, the un-tagged item still shows up there until I restart Dolphin.
  • When I add a tag to an item and navigate to that tag entry on the Places panel, the item does not show up there until I restart Dolphin.

    Some of these issues may be issues with the tags:/ ioslave or in Baloo, but I think they need to be fixed before we push this feature front-and-center, or else we'll get a ton of bug reports.
Sun, Nov 11, 10:59 PM · Frameworks, Dolphin
rizzitello updated the diff for D16767: Improve Ux for the places panel's hidden items.
  • rebase
Sun, Nov 11, 9:08 PM · Dolphin
rizzitello updated the diff for D16767: Improve Ux for the places panel's hidden items.
  • Use correct signing info
Sun, Nov 11, 9:04 PM · Dolphin
rizzitello updated the summary of D16767: Improve Ux for the places panel's hidden items.
Sun, Nov 11, 8:18 PM · Dolphin
rizzitello updated the diff for D16767: Improve Ux for the places panel's hidden items.
  • Clean commits
Sun, Nov 11, 8:12 PM · Dolphin
rizzitello added a comment to D16767: Improve Ux for the places panel's hidden items.

ONE PROBLEM HERE: Can not get a count of hidden Items on start up. the count for hidden items is always 0. So the Menu entry always starts enabled. Any help here would be great.

Try to delay the menu initialization using a QTimer::singleShot(0, ...). The places model gets populated asynchronously.

Sun, Nov 11, 7:51 PM · Dolphin
rizzitello updated the summary of D16767: Improve Ux for the places panel's hidden items.
Sun, Nov 11, 7:49 PM · Dolphin
rizzitello updated the diff for D16767: Improve Ux for the places panel's hidden items.
  • Fix issues, thanks for the idea nate
Sun, Nov 11, 7:48 PM · Dolphin
elvisangelaccio added a comment to D16767: Improve Ux for the places panel's hidden items.

ONE PROBLEM HERE: Can not get a count of hidden Items on start up. the count for hidden items is always 0. So the Menu entry always starts enabled. Any help here would be great.

Sun, Nov 11, 7:39 PM · Dolphin
rizzitello updated the summary of D16767: Improve Ux for the places panel's hidden items.
Sun, Nov 11, 7:07 PM · Dolphin
rizzitello updated the test plan for D16767: Improve Ux for the places panel's hidden items.
Sun, Nov 11, 7:06 PM · Dolphin
rizzitello updated the diff for D16767: Improve Ux for the places panel's hidden items.
  • disable instead of hide.
Sun, Nov 11, 6:59 PM · Dolphin
elvisangelaccio added inline comments to D16767: Improve Ux for the places panel's hidden items.
Sun, Nov 11, 6:38 PM · Dolphin
elvisangelaccio added a task to D16824: [PlacesPanel] Port to KFilePlaceEditDialog: T9795: Use Places Panel code from KIO instead of private implementation.
Sun, Nov 11, 6:18 PM · Dolphin
elvisangelaccio added a revision to T9795: Use Places Panel code from KIO instead of private implementation: D16824: [PlacesPanel] Port to KFilePlaceEditDialog.
Sun, Nov 11, 6:18 PM · Frameworks, Dolphin
elvisangelaccio added a revision to T8349: Improve Places panel usability and presentation: D16824: [PlacesPanel] Port to KFilePlaceEditDialog.
Sun, Nov 11, 6:17 PM · VDG, Dolphin
elvisangelaccio added a task to D16824: [PlacesPanel] Port to KFilePlaceEditDialog: T8349: Improve Places panel usability and presentation.
Sun, Nov 11, 6:17 PM · Dolphin
elvisangelaccio added a dependency for D16824: [PlacesPanel] Port to KFilePlaceEditDialog: D16825: Export again KFilePlaceEditDialog.
Sun, Nov 11, 6:16 PM · Dolphin
elvisangelaccio requested review of D16824: [PlacesPanel] Port to KFilePlaceEditDialog.
Sun, Nov 11, 6:14 PM · Dolphin
veqz added a comment to D16767: Improve Ux for the places panel's hidden items.

I'm fully behind Nate on this one.

Sun, Nov 11, 5:01 PM · Dolphin
ngraham added inline comments to D16767: Improve Ux for the places panel's hidden items.
Sun, Nov 11, 4:44 PM · Dolphin
elvisangelaccio added inline comments to D16767: Improve Ux for the places panel's hidden items.
Sun, Nov 11, 4:39 PM · Dolphin
ngraham requested changes to D16767: Improve Ux for the places panel's hidden items.
Sun, Nov 11, 4:28 PM · Dolphin
rizzitello updated the diff for D16767: Improve Ux for the places panel's hidden items.
  • Elvis' suggestions
Sun, Nov 11, 1:18 PM · Dolphin
elvisangelaccio added inline comments to D16767: Improve Ux for the places panel's hidden items.
Sun, Nov 11, 11:45 AM · Dolphin
elvisangelaccio requested changes to D16767: Improve Ux for the places panel's hidden items.
Sun, Nov 11, 10:58 AM · Dolphin
elvisangelaccio created T10020: Investigate kdirwatch not refreshing the dolphin view.
Sun, Nov 11, 9:54 AM · Dolphin

Sat, Nov 10

dfaure closed D16674: MTP: fix runtime warning when showing a warning to the user..
Sat, Nov 10, 10:19 PM · Frameworks, Dolphin
asn closed D16538: [sftp] Add additional sftpProtocol::openConnection() for libssh 0.8.3+.
Sat, Nov 10, 8:29 PM · Frameworks, Dolphin
ggrysuk renamed M141: Dolphin from Dolphing to Dolphin.
Sat, Nov 10, 7:26 PM · Dolphin
ggrysuk created M141: Dolphin.
Sat, Nov 10, 7:16 PM · Dolphin

Fri, Nov 9

rizzitello updated the summary of D16767: Improve Ux for the places panel's hidden items.
Fri, Nov 9, 8:36 PM · Dolphin
ngraham added a task to D16767: Improve Ux for the places panel's hidden items: T8349: Improve Places panel usability and presentation.
Fri, Nov 9, 12:20 AM · Dolphin
ngraham added a revision to T8349: Improve Places panel usability and presentation: D16767: Improve Ux for the places panel's hidden items.
Fri, Nov 9, 12:20 AM · VDG, Dolphin
ngraham accepted D16767: Improve Ux for the places panel's hidden items.

Lovely. Consider it VDG-approved! I'll let @elvisangelaccio handle the remainder of the code review.

Fri, Nov 9, 12:18 AM · Dolphin