DolphinProject
ActivePublic

Recent Activity

Sat, Jan 20

michaelh removed a watcher for Dolphin: michaelh.
Sat, Jan 20, 7:06 PM

Thu, Jan 18

adrianchavesfernandez placed T7784: Fix TerminalPanel usage in dolphinmainwindow up for grabs.
Thu, Jan 18, 7:24 PM · Dolphin
adrianchavesfernandez claimed T7784: Fix TerminalPanel usage in dolphinmainwindow.
Thu, Jan 18, 7:24 PM · Dolphin
elvisangelaccio triaged T7784: Fix TerminalPanel usage in dolphinmainwindow as Normal priority.
Thu, Jan 18, 7:17 PM · Dolphin
michaelh added a member for Dolphin: michaelh.
Thu, Jan 18, 2:57 PM
michaelh closed D9911: Folderspanel's context-menu option "Limit to Home Directory" is always visible.
Thu, Jan 18, 8:11 AM · KDE Applications, Dolphin
ngraham accepted D9911: Folderspanel's context-menu option "Limit to Home Directory" is always visible.

Looks good to me.

Thu, Jan 18, 12:12 AM · KDE Applications, Dolphin

Tue, Jan 16

michaelh added a reviewer for D9911: Folderspanel's context-menu option "Limit to Home Directory" is always visible: Dolphin.
Tue, Jan 16, 10:02 PM · KDE Applications, Dolphin
michaelh added a comment to D9662: folderspanel context-menu option "Limit to Home Directory" should be always visible.

Continued here D9911

Tue, Jan 16, 2:24 PM · KDE Applications, Dolphin
michaelh added inline comments to D9911: Folderspanel's context-menu option "Limit to Home Directory" is always visible.
Tue, Jan 16, 9:42 AM · KDE Applications, Dolphin

Mon, Jan 15

michaelh added a comment to D9662: folderspanel context-menu option "Limit to Home Directory" should be always visible.

The new diff is prepared. To be safe I did

$ git pull
$ git checkout -b folderpanel-refac origin/Applications/17.12

(made changes)
git diff looks ok

Mon, Jan 15, 11:01 AM · KDE Applications, Dolphin
ngraham added a comment to D9662: folderspanel context-menu option "Limit to Home Directory" should be always visible.

@michaelh, would you care to prepare another patch to address @elvisangelaccio's comments?

Mon, Jan 15, 2:53 AM · KDE Applications, Dolphin

Sun, Jan 14

elvisangelaccio added a comment to D9662: folderspanel context-menu option "Limit to Home Directory" should be always visible.

I'm late to the party, but oh well.

Sun, Jan 14, 10:37 PM · KDE Applications, Dolphin
ngraham closed D9662: folderspanel context-menu option "Limit to Home Directory" should be always visible.
Sun, Jan 14, 6:03 PM · KDE Applications, Dolphin
michaelh updated the diff for D9662: folderspanel context-menu option "Limit to Home Directory" should be always visible.

Documented allowJumpHome Param

Sun, Jan 14, 5:42 PM · KDE Applications, Dolphin
michaelh updated the diff for D9662: folderspanel context-menu option "Limit to Home Directory" should be always visible.

cleanup

Sun, Jan 14, 5:40 PM · KDE Applications, Dolphin
michaelh updated the diff for D9662: folderspanel context-menu option "Limit to Home Directory" should be always visible.

revert more

Sun, Jan 14, 4:33 PM · KDE Applications, Dolphin
michaelh updated the diff for D9662: folderspanel context-menu option "Limit to Home Directory" should be always visible.

revert

Sun, Jan 14, 4:19 PM · KDE Applications, Dolphin
michaelh updated the diff for D9662: folderspanel context-menu option "Limit to Home Directory" should be always visible.

Documented allowJumpHome param

Sun, Jan 14, 3:59 PM · KDE Applications, Dolphin
michaelh added a comment to D9662: folderspanel context-menu option "Limit to Home Directory" should be always visible.

What about 'Show hidden folders'?

Sun, Jan 14, 3:11 PM · KDE Applications, Dolphin
michaelh added a comment to D9662: folderspanel context-menu option "Limit to Home Directory" should be always visible.

Reminder: no write access.
Request: land it for me, please.

Sun, Jan 14, 3:09 PM · KDE Applications, Dolphin
ngraham accepted D9662: folderspanel context-menu option "Limit to Home Directory" should be always visible.

Much better. Now the menu item is always available, and activating it jumps you to the home directory if you're outside of it. And you even checked for the case where's you're inside a subdirectory of ~.

Sun, Jan 14, 2:57 PM · KDE Applications, Dolphin
michaelh updated the diff for D9662: folderspanel context-menu option "Limit to Home Directory" should be always visible.
  • Introduced optional parameter to FoldersPanel::loadTree()
  • Added navigate home functionality
  • Reordered if.. block
  • Condition to enable 'Limit to...' option
Sun, Jan 14, 2:17 PM · KDE Applications, Dolphin

Sat, Jan 13

michaelh added a comment to D9662: folderspanel context-menu option "Limit to Home Directory" should be always visible.

Cannot find the dolphin API Documentation, specially FoldersPanel class. Where is it?

Sat, Jan 13, 5:15 PM · KDE Applications, Dolphin
michaelh added a comment to D9662: folderspanel context-menu option "Limit to Home Directory" should be always visible.
Sat, Jan 13, 5:13 PM · KDE Applications, Dolphin
michaelh added a comment to D9662: folderspanel context-menu option "Limit to Home Directory" should be always visible.

Does a protocol (except 'file://') exist that relies on/utilizes the 'Show hidden folders'-option?
I've checked some but didn't find any.
If none exists, 'Show hidden folders'-option should behave same way as 'Limit to...'.

Sat, Jan 13, 4:21 PM · KDE Applications, Dolphin
ngraham added a comment to D9662: folderspanel context-menu option "Limit to Home Directory" should be always visible.

I see, the menu item iss only active when you right-click on a path in your home directory. I would support making it always active and jumping you back to your home directory if you're outside it.

Sat, Jan 13, 3:54 PM · KDE Applications, Dolphin
michaelh added a comment to D9662: folderspanel context-menu option "Limit to Home Directory" should be always visible.

Even when you right-click home or a folder inside of it?
I re-checked and it still works as expected here.

Sat, Jan 13, 3:05 PM · KDE Applications, Dolphin
ngraham requested changes to D9662: folderspanel context-menu option "Limit to Home Directory" should be always visible.

Doesn't work 100% for me: After I uncheck "Limit to home directory", the menu item becomes permanently disabled and I can't re-enable it.

Sat, Jan 13, 12:15 AM · KDE Applications, Dolphin

Thu, Jan 11

michaelh added a comment to D9826: [dolphin] Let users search everywhere.

Thanks, I'm in already in (konversation worked).

Thu, Jan 11, 10:04 PM · KDE Applications, Dolphin
nicolasfella added a comment to D9826: [dolphin] Let users search everywhere.

Do I need a smartphone for that? Believe or not, I don't own one.

Thu, Jan 11, 9:28 PM · KDE Applications, Dolphin
ltoscano added a comment to D9826: [dolphin] Let users search everywhere.

No. IRC is IRC, with all its clients. Matrix.org has various clients, including a web frontend (through riot.im). Telegram has a web client.

Thu, Jan 11, 9:26 PM · KDE Applications, Dolphin
michaelh added a comment to D9826: [dolphin] Let users search everywhere.

Do I need a smartphone for that? Believe or not, I don't own one.

Thu, Jan 11, 9:22 PM · KDE Applications, Dolphin
ltoscano added a comment to D9826: [dolphin] Let users search everywhere.
Thu, Jan 11, 9:20 PM · KDE Applications, Dolphin
michaelh added a comment to D9826: [dolphin] Let users search everywhere.
Thu, Jan 11, 9:17 PM · KDE Applications, Dolphin
ngraham added a comment to D9826: [dolphin] Let users search everywhere.

We don't need an extra button to search home. If you want to search home. Go to home and search from there.

Thu, Jan 11, 8:59 PM · KDE Applications, Dolphin
michaelh added a comment to D9826: [dolphin] Let users search everywhere.

I think wanting to use a GUI search tool to look through all of / actually is fairly rare

For experienced users. But newbies who don't know where to look for logs or config files and don't know what to expect...?
I, at least was hit by this and it confused me.

Thu, Jan 11, 6:26 PM · KDE Applications, Dolphin
michaelh added a comment to D9826: [dolphin] Let users search everywhere.

The current behaviour is one of the reasons why I preferred find or baloosearch on the command line.
We don't need an extra button to search home. If you want to search home. Go to home and search from there.

Thu, Jan 11, 6:19 PM · KDE Applications, Dolphin
anthonyfieroni added a reviewer for D9826: [dolphin] Let users search everywhere: elvisangelaccio.

This is not good idea at all. In Linux we have many virtual FS that is not good to look in (or you can wait forever). Furthermore Dolphin does not search in hidden folders, so *everywhere* is quite relative.

Thu, Jan 11, 6:14 PM · KDE Applications, Dolphin
ngraham added a comment to D9826: [dolphin] Let users search everywhere.

I think wanting to use a GUI search tool to look through all of / actually is fairly rare--though I think we should expose the capability anyway for those who want it. The issue is that for users who dowant to only search their home folders, this patch makes it more difficult, because they no longer have an option to search ~ from a folder that's not ~ without searching through all of /, which will make the search take much longer.

Thu, Jan 11, 5:20 PM · KDE Applications, Dolphin

Wed, Jan 10

akrutzler added inline comments to D9802: Avoid Dolphin crash .
Wed, Jan 10, 10:11 PM · KDE Applications, Frameworks, Dolphin
michaelh added inline comments to D9802: Avoid Dolphin crash .
Wed, Jan 10, 8:03 PM · KDE Applications, Frameworks, Dolphin
michaelh abandoned D9802: Avoid Dolphin crash .
Wed, Jan 10, 7:56 PM · KDE Applications, Frameworks, Dolphin
akrutzler added inline comments to D9802: Avoid Dolphin crash .
Wed, Jan 10, 7:56 PM · KDE Applications, Frameworks, Dolphin
michaelh added inline comments to D9802: Avoid Dolphin crash .
Wed, Jan 10, 7:50 PM · KDE Applications, Frameworks, Dolphin
akrutzler added inline comments to D9802: Avoid Dolphin crash .
Wed, Jan 10, 7:44 PM · KDE Applications, Frameworks, Dolphin
ngraham added a comment to D9802: Avoid Dolphin crash .

Hmm, I can't reproduce the crash with Dolphin and KIO from git master. dolphin tags:/Genre/Drama/ (after created a nested tag Genre/Drama) works fine for me.

Wed, Jan 10, 7:42 PM · KDE Applications, Frameworks, Dolphin
michaelh added a comment to D9802: Avoid Dolphin crash .

Reason:
dolphin crashes when navigation to a nested tag e.g.

tags:/Genre/Drama/
Wed, Jan 10, 7:39 PM · KDE Applications, Frameworks, Dolphin
michaelh added a reviewer for D9662: folderspanel context-menu option "Limit to Home Directory" should be always visible: ngraham.
Wed, Jan 10, 3:40 PM · KDE Applications, Dolphin

Mon, Jan 8

michaelh added a comment to D9701: Info panel and tooltips: Concise date display.

Remotely related: Bug 358571

Mon, Jan 8, 1:19 PM · KDE Applications, Dolphin