DolphinProject
ActivePublic

Recent Activity

Today

broulik requested review of D25297: Add guards for m_terminalPanel.
Thu, Nov 14, 7:49 AM · Dolphin
bruns accepted D25258: test(search): Add test case for baloo parsing model.
Thu, Nov 14, 12:15 AM · Dolphin

Yesterday

iasensio closed D25255: fix(search): Allow to set empty type.
Wed, Nov 13, 9:55 PM · Dolphin
elvisangelaccio added a comment to D25255: fix(search): Allow to set empty type.

Sure ;)

Wed, Nov 13, 9:52 PM · Dolphin
elvisangelaccio added a comment to D25255: fix(search): Allow to set empty type.

Sure ;)

Wed, Nov 13, 9:45 PM · Dolphin
elvisangelaccio accepted D25258: test(search): Add test case for baloo parsing model.

Please wait for @bruns approval too.

Wed, Nov 13, 9:44 PM · Dolphin
iasensio added a comment to D25257: refactor(search): De-couple baloo URL parsing logic from UI.

Instructions for how to do this can be found here: https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

Wed, Nov 13, 9:40 PM · Dolphin
iasensio added a comment to D25255: fix(search): Allow to set empty type.

Should I push this also to release/19.12?

Wed, Nov 13, 9:38 PM · Dolphin
iasensio updated the diff for D25258: test(search): Add test case for baloo parsing model.

Address comments

Wed, Nov 13, 9:35 PM · Dolphin
iasensio closed D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Wed, Nov 13, 9:24 PM · Dolphin
ngraham added a comment to D25257: refactor(search): De-couple baloo URL parsing logic from UI.

Please push to the release/19.12 branch. Thanks!

Wed, Nov 13, 8:57 PM · Dolphin
elvisangelaccio added a comment to D11382: Add an option to show tabs from last time when Dolphin starts.

19.12 has branched so we can target 20.04 for this and have time for lots and lots of testing. Can I request a review, @elvisangelaccio?

Wed, Nov 13, 8:52 PM · Dolphin
elvisangelaccio added inline comments to D25258: test(search): Add test case for baloo parsing model.
Wed, Nov 13, 8:50 PM · Dolphin
elvisangelaccio accepted D25255: fix(search): Allow to set empty type.
Wed, Nov 13, 8:48 PM · Dolphin
elvisangelaccio accepted D25257: refactor(search): De-couple baloo URL parsing logic from UI.

Please push to the release/19.12 branch. Thanks!

Wed, Nov 13, 8:48 PM · Dolphin
iasensio updated the diff for D25257: refactor(search): De-couple baloo URL parsing logic from UI.
  • Fix extra space
Wed, Nov 13, 7:26 PM · Dolphin
bruns added inline comments to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Wed, Nov 13, 1:19 PM · Dolphin
meven added a comment to D23507: Replace custom single threaded merge sort with std::stable_sort.

Seems sane to me and nice since it removes some code.

Wed, Nov 13, 12:43 PM · Dolphin
iasensio updated the test plan for D25260: fix(search): Fix baloo searchString parsing.
Wed, Nov 13, 1:38 AM · Dolphin
iasensio updated the diff for D25260: fix(search): Fix baloo searchString parsing.

Rebase

Wed, Nov 13, 1:37 AM · Dolphin
iasensio added a comment to D25257: refactor(search): De-couple baloo URL parsing logic from UI.

Without D25255, the type will not be reset to "Any", just as before.

After this has landed, the unit tests should go in, then D25255 (amended by the unit test change, XFAIL--).

Wed, Nov 13, 1:27 AM · Dolphin
iasensio removed a dependency for D25257: refactor(search): De-couple baloo URL parsing logic from UI: D25255: fix(search): Allow to set empty type.
Wed, Nov 13, 1:22 AM · Dolphin
iasensio removed a dependent revision for D25255: fix(search): Allow to set empty type: D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Wed, Nov 13, 1:22 AM · Dolphin
iasensio updated the summary of D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Wed, Nov 13, 1:22 AM · Dolphin
iasensio added inline comments to D25258: test(search): Add test case for baloo parsing model.
Wed, Nov 13, 12:46 AM · Dolphin
iasensio updated the diff for D25258: test(search): Add test case for baloo parsing model.
  • Do not trim search terms
Wed, Nov 13, 12:45 AM · Dolphin
bruns added a comment to D25257: refactor(search): De-couple baloo URL parsing logic from UI.

Please remove the Depends D25255 from the summary, this one is independent.

I'm afraid it won't work well without that, because it handles the empty case for type().
For the sake of simplicity, I could also abandon D25255 and keep the change here.

Wed, Nov 13, 12:38 AM · Dolphin
iasensio updated the diff for D25258: test(search): Add test case for baloo parsing model.
  • Fix comment in CMakeLists.txt
Wed, Nov 13, 12:31 AM · Dolphin
iasensio updated the diff for D25258: test(search): Add test case for baloo parsing model.
  • Fix comment in CMakeLists
Wed, Nov 13, 12:30 AM · Dolphin
iasensio updated the test plan for D25258: test(search): Add test case for baloo parsing model.
Wed, Nov 13, 12:28 AM · Dolphin
iasensio updated the diff for D25258: test(search): Add test case for baloo parsing model.
  • Proper arc diff
Wed, Nov 13, 12:27 AM · Dolphin
iasensio updated the diff for D25258: test(search): Add test case for baloo parsing model.
  • Move to a different test unit
  • Address comments
Wed, Nov 13, 12:26 AM · Dolphin
iasensio planned changes to D25130: [dolphin/search] Search by (multiple) tags.

Will have to be rebased after D25260

Wed, Nov 13, 12:04 AM · Dolphin
iasensio abandoned D24422: [dolphin] Improve parsing of Baloo query searchString.

Abandon in favor of D25255

Wed, Nov 13, 12:02 AM · Dolphin

Tue, Nov 12

iasensio abandoned D25135: [dolphin] Add test case baloo search parsing.

Superseded by D25258

Tue, Nov 12, 11:59 PM · Dolphin
iasensio updated the diff for D25257: refactor(search): De-couple baloo URL parsing logic from UI.

Proper diff from D25255

Tue, Nov 12, 11:41 PM · Dolphin
iasensio updated the diff for D25257: refactor(search): De-couple baloo URL parsing logic from UI.
  • Rename also in dox comment
Tue, Nov 12, 11:37 PM · Dolphin
iasensio added a comment to D25257: refactor(search): De-couple baloo URL parsing logic from UI.

Please remove the Depends D25255 from the summary, this one is independent.

Tue, Nov 12, 11:15 PM · Dolphin
bruns accepted D25257: refactor(search): De-couple baloo URL parsing logic from UI.

Otherwise, LGTM now.

Tue, Nov 12, 11:11 PM · Dolphin
bruns added a comment to D25257: refactor(search): De-couple baloo URL parsing logic from UI.

Please remove the Depends D25255 from the summary, this one is independent.

Tue, Nov 12, 11:10 PM · Dolphin
elvisangelaccio added inline comments to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Tue, Nov 12, 11:08 PM · Dolphin
bruns added inline comments to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Tue, Nov 12, 11:08 PM · Dolphin
iasensio updated the diff for D25257: refactor(search): De-couple baloo URL parsing logic from UI.
  • Update method signatures
Tue, Nov 12, 11:07 PM · Dolphin
bruns added inline comments to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Tue, Nov 12, 10:56 PM · Dolphin
elvisangelaccio added inline comments to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Tue, Nov 12, 10:54 PM · Dolphin
bruns requested changes to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Tue, Nov 12, 10:51 PM · Dolphin
iasensio updated the diff for D25257: refactor(search): De-couple baloo URL parsing logic from UI.
  • Clarification for text() method
Tue, Nov 12, 10:44 PM · Dolphin
elvisangelaccio added inline comments to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Tue, Nov 12, 10:27 PM · Dolphin
iasensio added a comment to D25257: refactor(search): De-couple baloo URL parsing logic from UI.

I changed the filenames to address a change in the class name, and it seems that phab didn't preserve the inline comments, sorry.
I've tried to address the majority of them, now with better understanding of @bruns intentions about the refactor itself.
Thanks for the insightful reviews.

Tue, Nov 12, 10:24 PM · Dolphin
iasensio added inline comments to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Tue, Nov 12, 10:20 PM · Dolphin