DolphinProject
ActivePublic

Recent Activity

Yesterday

brute4s99 closed D29461: Fix kio-extras build on Windows.
Wed, May 27, 4:30 PM · Frameworks, Dolphin
meven added a comment to D26114: Places: Use Solid::Device::DisplayName for DisplayRole.

Will land after KF 5.71 release

Wed, May 27, 5:41 AM · Dolphin
meven updated the diff for D26114: Places: Use Solid::Device::DisplayName for DisplayRole.

Update patch to new dependency

Wed, May 27, 5:40 AM · Dolphin
meven accepted D29461: Fix kio-extras build on Windows.
Wed, May 27, 5:34 AM · Frameworks, Dolphin

Tue, May 26

brute4s99 added a comment to D29461: Fix kio-extras build on Windows.

updated libssh to use version 0.9.4 by default in Craft. We can merge this and get 🟢 for kio-extras builds. \o/

Tue, May 26, 10:19 PM · Frameworks, Dolphin
brute4s99 added inline comments to D29461: Fix kio-extras build on Windows.
Tue, May 26, 7:10 PM · Frameworks, Dolphin
brute4s99 added a dependency for D29461: Fix kio-extras build on Windows: D29835: Add libssh 0.9.4 to fix kio-extras on windows.
Tue, May 26, 7:07 PM · Frameworks, Dolphin
brute4s99 updated the diff for D29461: Fix kio-extras build on Windows.
Tue, May 26, 7:06 PM · Frameworks, Dolphin
meven added a comment to D29169: Reuse DolphinContextMenu in FoldersPanel.

It will need quite some work to rebase indded, since this introduce the concept of having context menu actions in DolphinViewActionHandler and this is now a few weeks old...
I might rename DolphinViewActionHandler to simply DolphinActionHandler since this will be more relevant.
I believe the code will overall be in better shape that previous with more code delegated to DolphinViewActionHandler rather that bloating forever DolphinView and DolphinMainWindow.
Might move to gitlab directly as this is just in the infancy of the review.

Tue, May 26, 2:55 PM · Dolphin
ngraham added a comment to D29169: Reuse DolphinContextMenu in FoldersPanel.

This has some merge conflicts if I try to rebase it on current master Can you rebase it?

Tue, May 26, 2:15 PM · Dolphin

Mon, May 25

meven retitled D26114: Places: Use Solid::Device::DisplayName for DisplayRole from Places: For mounted volume display mount points instead of description to Places: Use Solid::Device::DisplayName for DisplayRole.
Mon, May 25, 6:13 AM · Dolphin
meven added a comment to D29169: Reuse DolphinContextMenu in FoldersPanel.

Sorry for the delay in reviewing. This is a large and somewhat intimidating patch :) I will check it out soon.

Mon, May 25, 4:33 AM · Dolphin
meven added inline comments to D26114: Places: Use Solid::Device::DisplayName for DisplayRole.
Mon, May 25, 4:30 AM · Dolphin
ngraham added a comment to D29169: Reuse DolphinContextMenu in FoldersPanel.

Sorry for the delay in reviewing. This is a large and somewhat intimidating patch :) I will check it out soon.

Mon, May 25, 4:03 AM · Dolphin

Sun, May 24

ngraham accepted D26114: Places: Use Solid::Device::DisplayName for DisplayRole.

(once the dependent patch lands)

Sun, May 24, 7:12 PM · Dolphin
ngraham accepted D29525: Make Previews devicePixelRatio aware.

(once the dependent patches have landed)

Sun, May 24, 7:10 PM · Dolphin
ngraham closed D29568: use KSycoca for updating OpenPreferredSearchTool action.
Sun, May 24, 2:27 PM · Dolphin

Sat, May 23

elvisangelaccio accepted D29568: use KSycoca for updating OpenPreferredSearchTool action.

Not sure if this should go to release/20.04, but I guess it shouldn't hurt.

Sat, May 23, 9:41 PM · Dolphin
meven added a comment to D29169: Reuse DolphinContextMenu in FoldersPanel.

ping reviewers

Sat, May 23, 2:06 PM · Dolphin
meven planned changes to D26114: Places: Use Solid::Device::DisplayName for DisplayRole.

Blocked by D28590

Sat, May 23, 11:13 AM · Dolphin

Fri, May 22

meven added a comment to D29805: Thumbnail djvu: Avoid a crash when djvu is not installed.

@pino ping

Fri, May 22, 2:09 PM · Frameworks, Dolphin
alnikiforov added a comment to D28337: Fix unmounting during preview generation.
Solid only sends broadcast notification and doesn't wait for any reply, thus unmounting may fail due to preview jobs not stopping in time.

That points to a solid shortcoming worth fixing. Adding a wait for apps to ask solid to wait or to wait by default for instance 20-50ms between tearDownRequested and teardownDone

Fri, May 22, 1:12 PM · Dolphin

Thu, May 21

pdabrowski updated the test plan for D29568: use KSycoca for updating OpenPreferredSearchTool action.
Thu, May 21, 8:46 PM · Dolphin
pdabrowski updated the summary of D29568: use KSycoca for updating OpenPreferredSearchTool action.
Thu, May 21, 8:44 PM · Dolphin
pdabrowski updated the summary of D29568: use KSycoca for updating OpenPreferredSearchTool action.
Thu, May 21, 8:41 PM · Dolphin
pdabrowski updated the summary of D29568: use KSycoca for updating OpenPreferredSearchTool action.
Thu, May 21, 8:40 PM · Dolphin

Wed, May 20

ngraham added a comment to D29419: Improved Touch support.

Great job, that's perfect! You can close this now.

Wed, May 20, 5:34 PM · Dolphin
steffenh added a comment to D29419: Improved Touch support.

In terms of interaction, this feels great to me! I wonder, do you think you could move the patch to https://invent.kde.org/system/dolphin/-/merge_requests/? We've recently migrated to GitLab and are trying to stop using Phabricator.

Wed, May 20, 5:32 PM · Dolphin
ngraham added a comment to D29419: Improved Touch support.

In terms of interaction, this feels great to me! I wonder, do you think you could move the patch to https://invent.kde.org/system/dolphin/-/merge_requests/? We've recently migrated to GitLab and are trying to stop using Phabricator.

Wed, May 20, 3:26 PM · Dolphin
steffenh updated the diff for D29419: Improved Touch support.
  • fix the stuck TapAndHold indicator
  • add a small animation to TapAndHold indicator
  • set minimal speed, lower for swipe gesture
Wed, May 20, 1:35 PM · Dolphin
sitter added a comment to D29381: Thumbnail text: use libmagic to detect encoding.

Browsing the code it looks like it mmaps the file though? And when I add some strategic sleeping I can verify that file goes towards shared memory.

Wed, May 20, 9:52 AM · Frameworks, Dolphin

Tue, May 19

meven added a comment to D29381: Thumbnail text: use libmagic to detect encoding.

I am only half satisfied by the patch.
Mostly because of libmagic magic_load that loads a 5M file each time which is not needed to detect encoding.

Tue, May 19, 4:44 PM · Frameworks, Dolphin
sitter added a comment to D29381: Thumbnail text: use libmagic to detect encoding.

LGTM. Seeing as I don't have much background knowledge I'm not comfortable accepting though. I guess if nobody comes up with better options by next week feel free to land.

Tue, May 19, 1:29 PM · Frameworks, Dolphin
meven updated the diff for D29381: Thumbnail text: use libmagic to detect encoding.

Use QByteArray, find typo, code style and naming

Tue, May 19, 6:45 AM · Frameworks, Dolphin
meven abandoned D29562: KDirectoryContentsCounter: Avoid scanning twice the same dir, prioritise path not in cache.

Second commit :
https://invent.kde.org/system/dolphin/-/merge_requests/3

Tue, May 19, 6:10 AM · Dolphin
meven added a comment to D29562: KDirectoryContentsCounter: Avoid scanning twice the same dir, prioritise path not in cache.

Atomic first commit in :
https://invent.kde.org/system/dolphin/-/merge_requests/2

Tue, May 19, 5:56 AM · Dolphin

Mon, May 18

meven planned changes to D29806: Thumbnail folders: scale down sub image when their height is too big.

Will probably send to gitlab ;)

Mon, May 18, 4:22 PM · Frameworks, Dolphin
ngraham added a comment to D29806: Thumbnail folders: scale down sub image when their height is too big.

Haha the "before" image is hilarious!

Mon, May 18, 2:45 PM · Frameworks, Dolphin
ngraham closed D29693: Move search and filter bar close buttons to the right.
Mon, May 18, 1:30 PM · Dolphin
meven added inline comments to D29794: Left-elide file/folders while keeping their extension visible.
Mon, May 18, 12:21 PM · Dolphin
cfeck added inline comments to D29794: Left-elide file/folders while keeping their extension visible.
Mon, May 18, 10:21 AM · Dolphin
niccolove added a comment to D29419: Improved Touch support.

Can confirm. Also, I'd make the tap and hold indicator a bit smaller, maybe half of the size it currently has :-)

I want to see the indicator under my finger, at the current size I can almost see it (maybe my fingers are too thick)

Mon, May 18, 9:40 AM · Dolphin
GB_2 accepted D29693: Move search and filter bar close buttons to the right.
Mon, May 18, 8:52 AM · Dolphin
meven planned changes to D29562: KDirectoryContentsCounter: Avoid scanning twice the same dir, prioritise path not in cache.
Mon, May 18, 6:43 AM · Dolphin
meven added a comment to D29794: Left-elide file/folders while keeping their extension visible.

Landed in release/20.04
https://invent.kde.org/system/dolphin/commit/99cf24c03def1c0722ba8dbd86a27b9dbc521f43
And synched in master:
https://invent.kde.org/system/dolphin/commit/a058c64eba30f11bfa87ac097371c04437d0471e

Mon, May 18, 6:21 AM · Dolphin
meven closed D29794: Left-elide file/folders while keeping their extension visible.
Mon, May 18, 6:16 AM · Dolphin

Sun, May 17

elvisangelaccio added a comment to D29562: KDirectoryContentsCounter: Avoid scanning twice the same dir, prioritise path not in cache.

@meven Yes please. The patch may be small, but it's not trivial. Smaller atomic changes are always easier to review.

Sun, May 17, 11:14 PM · Dolphin
elvisangelaccio accepted D29693: Move search and filter bar close buttons to the right.
Sun, May 17, 10:03 PM · Dolphin
elvisangelaccio accepted D29794: Left-elide file/folders while keeping their extension visible.

Very nice. Please push to release/20.04. Thanks!

Sun, May 17, 9:10 PM · Dolphin
meven updated the diff for D29805: Thumbnail djvu: Avoid a crash when djvu is not installed.

fix indentation

Sun, May 17, 3:56 PM · Frameworks, Dolphin