DolphinProject
ActivePublic

Recent Activity

Sat, Jul 14

ngraham closed D13768: Modernize View Properties window.
Sat, Jul 14, 7:55 PM · Dolphin
ngraham added a comment to D13768: Modernize View Properties window.

Thanks!

Sat, Jul 14, 7:54 PM · Dolphin
elvisangelaccio accepted D13768: Modernize View Properties window.
Sat, Jul 14, 7:31 PM · Dolphin
ngraham added a comment to D13768: Modernize View Properties window.

Ping! @elvisangelaccio or anyone else in Dolphin? Tagging is fast approaching, and I think it would be nice to get this into 18.08.

Sat, Jul 14, 3:58 PM · Dolphin
bruns added a comment to D13814: Speedup sort.

Also amended the commit message.

Sat, Jul 14, 2:28 PM · Dolphin
jtamate added a comment to D13814: Speedup sort.

Also amended the commit message.

Sat, Jul 14, 2:23 PM · Dolphin
jtamate updated the summary of D13814: Speedup sort.
Sat, Jul 14, 2:17 PM · Dolphin
bruns added a comment to D13814: Speedup sort.

Any reason why you have pushed this with an obviously wrong commit message?

Because I though the commit message was right.

What should it be?

Sat, Jul 14, 1:09 PM · Dolphin
jtamate added a comment to D13814: Speedup sort.

Any reason why you have pushed this with an obviously wrong commit message?

Sat, Jul 14, 6:49 AM · Dolphin

Fri, Jul 13

bruns added a comment to D13814: Speedup sort.

Any reason why you have pushed this with an obviously wrong commit message?

Fri, Jul 13, 8:09 PM · Dolphin
jtamate closed D13814: Speedup sort.
Fri, Jul 13, 4:55 PM · Dolphin

Thu, Jul 12

bruns added a comment to D13814: Speedup sort.

Is there even a need to have n QCollator objects?
I'm talking about a QCollator _within_ a given view. Each view could obviously have it's own collator due to different view settings.

Thu, Jul 12, 11:22 AM · Dolphin

Wed, Jul 11

jtamate updated the summary of D13814: Speedup sort.
Wed, Jul 11, 6:53 PM · Dolphin
markg added a comment to D13814: Speedup sort.

The code looks fine now, but the summary is incorrect.

The savings is not from using a lambda, but caused by initializing it once. If the old code had used m_collator(other.m_collator) in the copy constructor, construction would have been just a ref count increment and each of the following m_collator.setFoo(...) would have been noops (QCollator checks if the new value is different to its current value).

Of course this would have triggered the QCollator bug as well.

Wed, Jul 11, 4:19 PM · Dolphin
bruns added a comment to D13814: Speedup sort.

The code looks fine now, but the summary is incorrect.

Wed, Jul 11, 3:06 PM · Dolphin
broulik closed D14047: [KFileItemModelRolesUpdater] Fix preview scaling for frameless previews.
Wed, Jul 11, 1:43 PM · Dolphin
broulik closed D11319: [KStandardItemListWidget] Avoid needless image resizing.
Wed, Jul 11, 1:43 PM · Dolphin
davidedmundson accepted D14047: [KFileItemModelRolesUpdater] Fix preview scaling for frameless previews.
Wed, Jul 11, 1:37 PM · Dolphin
broulik requested review of D14047: [KFileItemModelRolesUpdater] Fix preview scaling for frameless previews.
Wed, Jul 11, 1:36 PM · Dolphin
davidedmundson accepted D11319: [KStandardItemListWidget] Avoid needless image resizing.

Needs a comment in the code explaining why.

Wed, Jul 11, 1:28 PM · Dolphin
broulik updated the diff for D11319: [KStandardItemListWidget] Avoid needless image resizing.
  • Fix suggested by David
Wed, Jul 11, 1:27 PM · Dolphin
ngraham assigned T9094: Improve Dolphin's tag support to nicolasfella.
Wed, Jul 11, 1:14 PM · VDG, Baloo, Frameworks, Dolphin
jtamate updated the diff for D13814: Speedup sort.

Apply the workaround in loadSortingSettings.
It is applied in the constructor and when the type of sorting is changed by the user.

Wed, Jul 11, 12:58 PM · Dolphin
bruns requested changes to D13814: Speedup sort.
Wed, Jul 11, 12:46 PM · Dolphin
jtamate updated the diff for D13814: Speedup sort.

I've applied some of @bruns suggestions.
Just use QString(), less filesize and memory.
Move the comparison after loadSortingSettings();
Change the comment from Force the cleanup of to Force the clean state of. @bruns comment is already in the bug.

Wed, Jul 11, 7:48 AM · Dolphin

Tue, Jul 10

bruns added inline comments to D13814: Speedup sort.
Tue, Jul 10, 11:38 PM · Dolphin
elvisangelaccio accepted D13814: Speedup sort.

Thanks for filing the upstream bug. Looks good to me now.

Tue, Jul 10, 8:25 PM · Dolphin

Mon, Jul 9

Restricted Application added a project to D11319: [KStandardItemListWidget] Avoid needless image resizing: Dolphin.

Ping

Mon, Jul 9, 12:38 PM · Dolphin
jtamate updated the diff for D13814: Speedup sort.

Created the bug report referenced in the summary and code.
Changed the strings to compare, they can be anything.

Mon, Jul 9, 7:18 AM · Dolphin

Sun, Jul 8

ngraham updated the diff for D13768: Modernize View Properties window.

Use Dolphin::VERTICAL_SPACER_HEIGHT instead of a hardcoded value

Sun, Jul 8, 6:15 PM · Dolphin
elvisangelaccio requested changes to D13814: Speedup sort.
Sun, Jul 8, 5:17 PM · Dolphin
elvisangelaccio reopened D13814: Speedup sort.
Sun, Jul 8, 5:16 PM · Dolphin
elvisangelaccio added a comment to D13814: Speedup sort.

Hmm, so the crash is in ucol_close() (aka in ICU) and we are working around it by forcing the cleanup in the KFileItemModel ctor (= single thread).

Sun, Jul 8, 5:16 PM · Dolphin
jtamate added a comment to D13814: Speedup sort.

Reading the source of QCollator*, I guess the hack works because I get a collator where d->dirty is true,
and in compare there is this code

Sun, Jul 8, 4:33 PM · Dolphin
jtamate added a comment to D13814: Speedup sort.

@jtamate Can you show a complete gdb backtrace + valgrind log of this crash?

Sun, Jul 8, 4:15 PM · Dolphin
elvisangelaccio requested changes to D13768: Modernize View Properties window.
Sun, Jul 8, 1:57 PM · Dolphin
elvisangelaccio added a comment to D13814: Speedup sort.

@jtamate Can you show a complete gdb backtrace + valgrind log of this crash?

Sun, Jul 8, 1:22 PM · Dolphin
markg added a comment to D13814: Speedup sort.

Somehow i'm inclined to think that m_collator is wrong.
But inspecting the code shows no issue as far as i can tell. It's a normal class member that lives as long as the KFileItemModel instance lives.

Sun, Jul 8, 10:00 AM · Dolphin
jtamate updated the diff for D13814: Speedup sort.

My crashes are gone just doing a single comparison using the collator at the constructor.

Sun, Jul 8, 8:39 AM · Dolphin
jtamate added a comment to D13814: Speedup sort.

Perhaps it's a local issue on your side? Have you tried cleaning your dolphin build (and perhaps KIO as well) and re-run it to see if it still happens?

I've done a kdesrc-build from empty sources directory and empty build directory, but not empty install directory and it still happens. I will try later after I get enough free space with an empty install directory.

Sun, Jul 8, 6:31 AM · Dolphin
nicolasfella updated the diff for D7700: Show list of tags in PlacesView.

Add tags places in KIO

Sun, Jul 8, 12:42 AM · Frameworks, Dolphin

Sat, Jul 7

jtamate added a comment to D13814: Speedup sort.

I just cloned dolphin with your changes.
It compiled just fine.
Starting it with and without arguments also worked just fine.

Perhaps it's a local issue on your side? Have you tried cleaning your dolphin build (and perhaps KIO as well) and re-run it to see if it still happens?

I've done a kdesrc-build from empty sources directory and empty build directory, but not empty install directory and it still happens. I will try later after I get enough free space with an empty install directory.

Sat, Jul 7, 5:05 PM · Dolphin
markg added a comment to D13814: Speedup sort.

I really, really hate these things.
I've been testing this patch more than one month without any problem.
And now, after pushing it, I got crashes everytime I start dolphin without parameters (user home).
But not if I start it in / and keep changing directories, including user home.

Please, test dolphin with latest sources.

#6 0x00007fc0ba4e5904 in icu_61_1::RuleBasedCollator::getAttribute(UColAttribute, UErrorCode&) const () from /usr/lib64/libicui18n.so.61.1
#7 0x00007fc0ba4e6dc6 in icu_61_1::RuleBasedCollator::setAttribute(UColAttribute, UColAttributeValue, UErrorCode&) () from /usr/lib64/libicui18n.so.61.1
#8 0x00007fc0c0dfec25 in QCollatorPrivate::init() () at tools/qcollator_icu.cpp:82
#9 0x00007fc0c0dfedab in QCollator::compare (this=0x1928070, s1=0x1bd6b98, len1=19, s2=0x1d70af8, len2=17) at tools/qcollator_icu.cpp:109
#10 0x00007fc0c880ac30 in KFileItemModel::sortRoleCompare (this=this@entry=0x1928040, a=a@entry=0x1c0e1f0, b=b@entry=0x1cfbdf0, collator=...) at /g/5kde/kde/applications/dolphin/src/kitemviews/kfileitemmodel.cpp:1836
#11 0x00007fc0c880b2a2 in KFileItemModel::lessThan (this=this@entry=0x1928040, a=0x1c0e1f0, b=0x1cfbdf0, collator=...) at /g/5kde/kde/applications/dolphin/src/kitemviews/kfileitemmodel.cpp:1707
#12 0x00007fc0c8811715 in KFileItemModel::<lambda(const KFileItemModel::ItemData*, const KFileItemModel::ItemData*)>::operator() (__closure=0x7ffe8d4307a8, b=<optimized out>, a=<optimized out>) at /g/5kde/kde/applications/dolphin/src/kitemviews/kfileitemmodel.cpp:1717

Sat, Jul 7, 1:27 PM · Dolphin
ngraham updated the test plan for D13768: Modernize View Properties window.
Sat, Jul 7, 1:05 AM · Dolphin
ngraham updated the diff for D13768: Modernize View Properties window.

Add a label to help people understand what the metadata list is for

Sat, Jul 7, 1:02 AM · Dolphin
abetts added a comment to D13768: Modernize View Properties window.

Like this?

Sat, Jul 7, 1:01 AM · Dolphin
ngraham added a comment to D13768: Modernize View Properties window.

Like this?

Sat, Jul 7, 12:55 AM · Dolphin

Fri, Jul 6

jtamate added a comment to D13814: Speedup sort.

I really, really hate these things.
I've been testing this patch more than one month without any problem.
And now, after pushing it, I got crashes everytime I start dolphin without parameters (user home).
But not if I start it in / and keep changing directories, including user home.

Fri, Jul 6, 9:53 PM · Dolphin
abetts added a comment to D13768: Modernize View Properties window.

That would be good too. Yes!

Fri, Jul 6, 7:25 PM · Dolphin
ngraham added a comment to D13768: Modernize View Properties window.

Maybe "Additional information to show" or "Show additional information" or even "Additional information"?I'm not yet convinced this really needs to be changed at all, though.

Here I was thinking that the triangle button caused an effect. It was like a button so I wanted the string to start with an active verb.

Fri, Jul 6, 6:14 PM · Dolphin