romangg (Roman Gilg)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 21 2016, 2:20 PM (147 w, 6 d)
Availability
Available

Recent Activity

Yesterday

romangg added a comment to T10462: Define input-output usage patterns.

What's missing here is the Tablet use-case since I'm not sure if Phone and Tablet are just the same thing or should be treated as separate patterns.

That depends a bit on your definition of Tablet.

A 7'' tablet is not much different than a phone, but a larger tablet with an attachable keyboard is a very different device

Wed, Feb 20, 9:56 AM · Plasma
romangg triaged T10506: Define Tablet IOUP as Normal priority.
Wed, Feb 20, 9:53 AM · Plasma
romangg updated the task description for T10502: Define Phone IOUP.
Wed, Feb 20, 9:51 AM · Plasma
romangg added inline comments to R127:b2f67e1db7ea: Add explicit SurfaceInterface::commited signal.
Wed, Feb 20, 1:22 AM
romangg accepted D19177: [wayland] Fix typo in method name.
Wed, Feb 20, 12:52 AM · KWin
romangg added a comment to D18570: EGLStream DRM Backend Initial Implementation.

In this case it seems better to me to not write the EGLStreams support directly into the DRM Backend at all, but create a new EGLStream Backend on same level as DRM Backend. Th

That sounds pointless.
There's less of a difference between EGL streams and GBM than there is between GBM and QPainter.

Wed, Feb 20, 12:49 AM · KWin

Tue, Feb 19

romangg added a comment to D18570: EGLStream DRM Backend Initial Implementation.

Other aspect which is important to me long-term: is multi-GPU support of different vendors possible with the current patches or a separate backend? Current patches don't seem to allow that easily to add later on. Depending on DRM access in a separate backend it might be simpler to do later.

Tue, Feb 19, 9:37 PM · KWin
romangg added a comment to T10502: Define Phone IOUP.

For a large tablet a 3x2 split is also thinkable. What changes with the number of splits is the way they are controlled.

Right, but how is the way changed?

Other cases where the window geometry on the phone changes is when the screen is rotated or the virtual keyboard is pushing the window like @mart proposed

Tue, Feb 19, 9:05 PM · Plasma
romangg added a comment to D18570: EGLStream DRM Backend Initial Implementation.

First off: a driver not supporting Atomic Mode Setting is nothing modern. Does Nvidia has a plan to improve in this regard?

I'm really not happy, that the DrmOutput::present is not run and we have to export these internals from DrmOutput to the EglStreamBackend, which replaces the flip with an EGL function call. Why does the Nvidia driver not integrate with the libdrm API in regards to page flipping? It should be possible to at least offer a wrapper around it or not?

Well, our DRM-KMS driver technically does support atomic modesetting, however currently we only allow the presentation of GPU-accessible buffers through the EGLDevice / EGLOutput extensions. In fact, these use atomic modesetting capabilities in their implementation. As far as I know this will remain the case until work on the Unix device memory allocation library is complete and while this is still on the table it's a ways off yet. The new backend really just uses DrmOutputs to track whether a page flip is pending. If we don't want to expose these internals, an alternative might be to track this separately from DrmOutput::m_pageFlipPending and maybe install a different page flip handler when using EGL streams that would just clear this flag (and re-start the compositor). I'll see if I can get something like that thrown together, it might be a bit cleaner, actually.

Tue, Feb 19, 8:58 PM · KWin
romangg added a comment to T10501: Define Desktop IOUP.

FYI there is previous discussion in T9780 in regards to touch window resize/move. The goal must be that whatever is he result here is usable in all IOUPs with primary or additional touch input. Therefore let us continue discussion there.

Tue, Feb 19, 8:28 PM · Plasma
romangg added a comment to T10503: Define TV IOUP.

True. Anyway I'm not sure if changing the scale is something we want or if the KWin internal scale should really only be influenced by the resolution/size in a uniform way over all devices.

Tue, Feb 19, 7:02 PM · Plasma
romangg added a comment to T10501: Define Desktop IOUP.

Because of the low to middle viewing distance and primary input device being keyboard and mouse the window border size can be "None" till "Normal". Currently it's "Normal" per default I believe but there was some discussion to set it to "None" in the past. Another topic is the buttons sizes, which is independent of this value.

Tue, Feb 19, 6:57 PM · Plasma
romangg added a comment to T10462: Define input-output usage patterns.

I've created some sub-tasks to discuss definition of some common usage patterns we might want to concentrate first: Desktop, Phone, TV.

Tue, Feb 19, 6:44 PM · Plasma
romangg added a comment to T10462: Define input-output usage patterns.

...
That's not quite right, there are many cases when the usage patterns change, but the output doesn't. Some examples:

  • tablet has a keyboard attached,
  • convertible switches modes,
  • a gamer picks up a controller and moves from the keyboard chair to a couch farther away.

That's true. So the Wayland event message must be sent also on these hot-plug events or when the user does a manual override, what maybe warrants a separate protocol.

Tue, Feb 19, 6:43 PM · Plasma
romangg claimed T10501: Define Desktop IOUP.
Tue, Feb 19, 6:39 PM · Plasma
romangg edited projects for T10462: Define input-output usage patterns, added: Plasma; removed KWin.
Tue, Feb 19, 6:38 PM · Plasma
romangg triaged T10501: Define Desktop IOUP as Normal priority.
Tue, Feb 19, 6:38 PM · Plasma
romangg edited projects for T10503: Define TV IOUP, added: Plasma; removed KWin.
Tue, Feb 19, 6:37 PM · Plasma
romangg triaged T10503: Define TV IOUP as Normal priority.
Tue, Feb 19, 6:31 PM · Plasma
romangg added a comment to T10502: Define Phone IOUP.

Window geometry can not be changed

Android has a split screen mode where two windows are tiled. In this case this assumption would not be true.

Tue, Feb 19, 6:10 PM · Plasma
romangg triaged T10502: Define Phone IOUP as Normal priority.
Tue, Feb 19, 6:01 PM · Plasma
romangg added a subtask for T10462: Define input-output usage patterns: T10501: Define Desktop IOUP.
Tue, Feb 19, 5:49 PM · Plasma
romangg added a parent task for T10501: Define Desktop IOUP: T10462: Define input-output usage patterns.
Tue, Feb 19, 5:49 PM · Plasma
romangg created T10501: Define Desktop IOUP.
Tue, Feb 19, 5:49 PM · Plasma
romangg renamed T10462: Define input-output usage patterns from Defining output-input usage patterns to Define input-output usage patterns.
Tue, Feb 19, 5:13 PM · Plasma
romangg requested review of D15907: Compare float values in DecorationButton contains check.
Tue, Feb 19, 1:40 PM · Plasma
romangg added a comment to D15907: Compare float values in DecorationButton contains check.

ping

Tue, Feb 19, 1:40 PM · Plasma
romangg edited projects for T6084: Omit Touchpad KCM init on startup, added: Plasma on Wayland; removed Plasma.
Tue, Feb 19, 1:33 PM · Plasma on Wayland
romangg placed T9233: Wayland Thumbnails up for grabs.
Tue, Feb 19, 1:21 PM · Plasma on Wayland
romangg abandoned D16791: [drm] On update always emit screensQueried.

The problem is not so easy to solve I believe now and needs a more holistic approach. Let's go back to the drawing board.

Tue, Feb 19, 1:18 PM · KWin
romangg added a revision to T10028: Individual KScreen output data retention: D16991: Introduce concept of global and individual output data retention.
Tue, Feb 19, 12:57 PM · VDG, Plasma
romangg added a task to D16991: Introduce concept of global and individual output data retention: T10028: Individual KScreen output data retention.
Tue, Feb 19, 12:57 PM · Plasma
romangg moved T4611: Drag and drop from XWayland to Wayland windows and vice versa from Under Review to Done on the KWin board.
Tue, Feb 19, 12:47 PM · KWin, Plasma on Wayland
romangg added inline comments to D15628: [xwl] Support stack optimizing X drag source clients.
Tue, Feb 19, 12:29 PM · KWin
romangg committed R108:4c18d156e2fb: [xwl] Support stack optimizing X drag source clients (authored by romangg).
[xwl] Support stack optimizing X drag source clients
Tue, Feb 19, 12:24 PM
romangg closed D15628: [xwl] Support stack optimizing X drag source clients.
Tue, Feb 19, 12:24 PM · KWin
romangg committed R108:522d2935e661: [xwl] text/x-uri converter for selected X url list format targets (authored by romangg).
[xwl] text/x-uri converter for selected X url list format targets
Tue, Feb 19, 12:17 PM
romangg closed D15629: [xwl] text/x-uri converter for selected X url list format targets.
Tue, Feb 19, 12:17 PM · KWin
romangg committed R108:548978bfe1f7: [xwl] Drag and drop between Xwayland and Wayland native clients (authored by romangg).
[xwl] Drag and drop between Xwayland and Wayland native clients
Tue, Feb 19, 12:09 PM
romangg closed D15627: [xwl] Drag and drop between Xwayland and Wayland native clients.
Tue, Feb 19, 12:09 PM · KWin
romangg committed R108:ad1bcbecc789: [xwl] Add Xwayland interface class (authored by romangg).
[xwl] Add Xwayland interface class
Tue, Feb 19, 11:59 AM
romangg closed D15419: [xwl] Add Xwayland interface class.
Tue, Feb 19, 11:59 AM · KWin
romangg committed R108:2776f829efbd: Remove X clipboard sync helper and rename its autotest (authored by romangg).
Remove X clipboard sync helper and rename its autotest
Tue, Feb 19, 11:30 AM
romangg closed D15063: Remove X clipboard sync helper and rename its autotest.
Tue, Feb 19, 11:30 AM · KWin
romangg committed R108:6e08fb2fa5f6: [xwl] Generic X selections translation mechanism with Clipboard support (authored by romangg).
[xwl] Generic X selections translation mechanism with Clipboard support
Tue, Feb 19, 11:24 AM
romangg closed D15061: [xwl] Generic X selections translation mechanism with Clipboard support.
Tue, Feb 19, 11:24 AM · KWin
romangg committed R108:608a89a85b31: [autotests] Use Xwayland class in WaylandTestApplication (authored by romangg).
[autotests] Use Xwayland class in WaylandTestApplication
Tue, Feb 19, 11:18 AM
romangg closed D15022: [autotests] Use Xwayland class in WaylandTestApplication.
Tue, Feb 19, 11:18 AM · KWin
romangg committed R108:050cf0451e2b: [xwl] Move Xwayland parts into separate class (authored by romangg).
[xwl] Move Xwayland parts into separate class
Tue, Feb 19, 11:10 AM
romangg closed D15020: [xwl] Move Xwayland parts into separate class.
Tue, Feb 19, 11:10 AM · KWin
romangg raised a concern with R108:7b20e1f66f83: Overhaul doxygen comments.

I only saw this commit now through other review.

Tue, Feb 19, 9:49 AM
romangg added a comment to D18810: [platforms/hwcomposer] Add scaling support.

One thing we should keep in mind: at some point we want multi-screen support on Plasma Mobile / convergence. For that we will probably just use KScreen as well.

Tue, Feb 19, 8:47 AM · KWin
romangg updated the summary of D15061: [xwl] Generic X selections translation mechanism with Clipboard support.
Tue, Feb 19, 8:22 AM · KWin
romangg updated the summary of D15061: [xwl] Generic X selections translation mechanism with Clipboard support.
Tue, Feb 19, 8:21 AM · KWin

Tue, Feb 12

romangg added a comment to D18810: [platforms/hwcomposer] Add scaling support.

21:01 <bshah> current kwinwrapper script is used for both normal drm and normal hwcomposer supported devices
21:01 <bshah> I can't just pass a random scale argument to call of kwin_wayland

Tue, Feb 12, 4:39 PM · KWin

Mon, Feb 11

romangg accepted D18810: [platforms/hwcomposer] Add scaling support.
Mon, Feb 11, 2:24 PM · KWin
romangg added a comment to D18818: virtualkeyboard: resize the focused window to make room for the keyboard.

I'll outline an idea how this could work: When virtual keyboard opens the focused window gets maximized and the virtual keyboard acts like a panel with strut - but just for the active window. Then we could use existing KWin functionality without having to track the geometry again.

Mon, Feb 11, 12:28 PM · KWin

Sat, Feb 9

romangg added a comment to D18570: EGLStream DRM Backend Initial Implementation.

First off: a driver not supporting Atomic Mode Setting is nothing modern. Does Nvidia has a plan to improve in this regard?

Sat, Feb 9, 9:10 PM · KWin
romangg requested changes to D18570: EGLStream DRM Backend Initial Implementation.
Sat, Feb 9, 8:22 PM · KWin
romangg requested changes to D18824: Implement wl_eglstream_controller Server Interface.

Impressive. Some small issues to resolve.

Sat, Feb 9, 2:16 PM · Frameworks
romangg added inline comments to D18824: Implement wl_eglstream_controller Server Interface.
Sat, Feb 9, 2:15 PM · Frameworks
romangg accepted D18818: virtualkeyboard: resize the focused window to make room for the keyboard.

There are some open questions still:

  • How to deal with desktop containments in a sensible way. With this patch applets and the launcher are moved above the virtual keyboard, which is already a great improvement. But we might want to deal with them in a more nicer way.
  • Doe we want to expose the virtual keyboard position information somehow to the clients? The old text-input v2 protocol provided this information. We might want to let clients opt-in to not being size-changed, but placing the keyboard into their window instead at some proposed coordinates. I could imagine this could be nice on larger screens with multiple windows open. But this would need a text-input v4 protocol version or a separate protocol.
  • Talking about multiple windows open: currently only the input focus window is moved. What's with other windows? I might be interested in them as well on a large screen while typing into the focused window.
Sat, Feb 9, 10:09 AM · KWin
romangg added a comment to T10462: Define input-output usage patterns.

Define a Wayland protocol to inform interested clients per surface, when this surface changes output.

wl_surface already has a protocol to informs clients when their surface changes output. It supports a surface being on N at once.
It should work right now.

From the sounds of it we just want to decorate either the wl_output/xdg_output/kde_output with some extra semantic values. Should be doable.

Sat, Feb 9, 9:41 AM · Plasma

Fri, Feb 8

romangg updated the task description for T10462: Define input-output usage patterns.
Fri, Feb 8, 5:33 PM · Plasma
romangg triaged T10462: Define input-output usage patterns as Normal priority.
Fri, Feb 8, 5:15 PM · Plasma
romangg added a comment to D18810: [platforms/hwcomposer] Add scaling support.

I can do, but I'll explain my rationale for this first.

When running nested it tends to be the user typing "kwin_wayland --scale" directly into a terminal.
On deployment it's hidden behind the startplasmamobile script.

Fri, Feb 8, 3:38 PM · KWin
romangg abandoned D15512: [startplasmacompositor] Add Wayland socket argument.

Superseded by D17122.

Fri, Feb 8, 3:30 PM · Plasma
romangg requested changes to D18810: [platforms/hwcomposer] Add scaling support.
Fri, Feb 8, 1:44 PM · KWin
romangg accepted D18808: [backends/hwcomposer] Port to AbstractOutput.

Code looks fine. Scrolling through the git history, as Vlad said, the prefix should be [platforms/hwcomposer].

Fri, Feb 8, 1:01 PM · KWin
romangg added inline comments to D18818: virtualkeyboard: resize the focused window to make room for the keyboard.
Fri, Feb 8, 10:45 AM · KWin
romangg updated the task description for T9815: Improve touch/virtual keyboard.
Fri, Feb 8, 10:21 AM · KWin
romangg added a revision to T9815: Improve touch/virtual keyboard: D18818: virtualkeyboard: resize the focused window to make room for the keyboard.
Fri, Feb 8, 10:21 AM · KWin
romangg added a task to D18818: virtualkeyboard: resize the focused window to make room for the keyboard: T9815: Improve touch/virtual keyboard.
Fri, Feb 8, 10:21 AM · KWin

Wed, Feb 6

romangg closed D15421: [server] Add surface data proxy mechanism.
Wed, Feb 6, 9:52 AM · Frameworks
romangg committed R127:0b33f078bd1d: [server] Add surface data proxy mechanism (authored by romangg).
[server] Add surface data proxy mechanism
Wed, Feb 6, 9:52 AM
romangg closed D15023: [server] Add selectionChanged signal.
Wed, Feb 6, 8:52 AM · Frameworks
romangg committed R127:8caff837109c: [server] Add selectionChanged signal (authored by romangg).
[server] Add selectionChanged signal
Wed, Feb 6, 8:52 AM

Tue, Feb 5

romangg moved T4449: [kwayland] Clipboard Manager protocol from Work In Progress to Backlog on the Plasma on Wayland board.
Tue, Feb 5, 4:24 PM · Plasma on Wayland

Thu, Jan 31

romangg added inline comments to D18570: EGLStream DRM Backend Initial Implementation.
Thu, Jan 31, 7:02 AM · KWin

Mon, Jan 28

romangg requested changes to D18570: EGLStream DRM Backend Initial Implementation.

Context is missing. Do git diff -U 99999 to include it.

Mon, Jan 28, 11:40 AM · KWin

Fri, Jan 25

romangg committed R108:4729a42c34b6: Name Wayland socket automatically when no socket name was specified (authored by romangg).
Name Wayland socket automatically when no socket name was specified
Fri, Jan 25, 12:39 PM
romangg closed D18522: Name Wayland socket automatically when no socket name was specified.
Fri, Jan 25, 12:39 PM · KWin
romangg added a comment to D18522: Name Wayland socket automatically when no socket name was specified.

Let's test it on master then.

Fri, Jan 25, 12:38 PM · KWin
romangg accepted D17122: Add option to use wl_display_add_socket_auto.
Fri, Jan 25, 12:30 PM · Frameworks
romangg added a dependency for D18522: Name Wayland socket automatically when no socket name was specified: D17122: Add option to use wl_display_add_socket_auto.
Fri, Jan 25, 12:28 PM · KWin
romangg added a dependent revision for D17122: Add option to use wl_display_add_socket_auto: D18522: Name Wayland socket automatically when no socket name was specified.
Fri, Jan 25, 12:28 PM · Frameworks
romangg requested review of D18522: Name Wayland socket automatically when no socket name was specified.
Fri, Jan 25, 12:27 PM · KWin
romangg added inline comments to D17122: Add option to use wl_display_add_socket_auto.
Fri, Jan 25, 12:24 PM · Frameworks
romangg requested changes to D17122: Add option to use wl_display_add_socket_auto.
Fri, Jan 25, 12:12 PM · Frameworks

Thu, Jan 24

romangg updated the diff for D18486: [RFC] XWayland Multi DPI support.
  • Use QPainter render hint
  • Remove ceil scale deduction
  • rename Xwl arg according to fdo merge request change
Thu, Jan 24, 12:11 PM · KWin
romangg added inline comments to D18486: [RFC] XWayland Multi DPI support.
Thu, Jan 24, 12:09 PM · KWin

Wed, Jan 23

romangg updated the summary of D18486: [RFC] XWayland Multi DPI support.
Wed, Jan 23, 7:51 PM · KWin
romangg requested review of D18486: [RFC] XWayland Multi DPI support.
Wed, Jan 23, 7:45 PM · KWin
romangg added a comment to D18453: Reload Shm texture when buffer size changes.

romangg added a dependent revision: D18465: [platforms/wayland] Multi output support.

They don't seem dependent.

Wed, Jan 23, 12:59 PM · KWin
romangg added inline comments to D18465: [platforms/wayland] Multi output support.
Wed, Jan 23, 11:26 AM · KWin
romangg added a dependent revision for D18453: Reload Shm texture when buffer size changes: D18465: [platforms/wayland] Multi output support.
Wed, Jan 23, 10:57 AM · KWin
romangg added a dependency for D18465: [platforms/wayland] Multi output support: D18453: Reload Shm texture when buffer size changes.
Wed, Jan 23, 10:57 AM · KWin
romangg updated the summary of D18465: [platforms/wayland] Multi output support.
Wed, Jan 23, 10:41 AM · KWin
romangg requested review of D18465: [platforms/wayland] Multi output support.
Wed, Jan 23, 10:35 AM · KWin

Tue, Jan 22

romangg added a comment to D18452: [autotests] Sub-surface resize test.

Cool stuff! I assume you want to push together with a patch fixing this?

Tue, Jan 22, 9:40 PM · KWin