People romangg

romangg (Roman Gilg)
User

Projects

Calendar

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 21 2016, 2:20 PM (164 w, 3 d)
Availability
Available

Recent Activity
View All

Today

romangg accepted D21345: Backport Night Color feature to X11.

Next time just add the diffs from p-w / p-d as dependent ones or better create an overview task linking the relevant diffs, so there are none to be missed by reviewers.

Sun, Jun 16, 10:46 AM · KWin
romangg accepted D21347: [Night Light KCM] Display the kcm on X11 platform.
Sun, Jun 16, 10:46 AM · Plasma
romangg accepted D21346: [libcolorcorrect] Allow color correction on X.
Sun, Jun 16, 10:46 AM · Plasma

Fri, Jun 14

romangg added inline comments to D21808: [platforms/X11] Disable VSync for QtQuick Windows.
Fri, Jun 14, 10:10 PM · KWin
romangg moved T11098: Replace Screens class from Backlog to Work In Progress on the KWin board.
Fri, Jun 14, 6:40 PM · KWin
romangg updated the diff for D18185: Rework Client fullscreen control.

Rebase on master.

Fri, Jun 14, 6:28 PM · KWin
romangg updated the diff for D18157: Remove Client fullscreen hack.

Rebase on master.

Fri, Jun 14, 6:01 PM · KWin
romangg added a comment to D18153: Correct code style of Client fullscreen control.

There will be larger changes to legacy code in the near future as of T11098. That means git history will be fucked up anyway. Better clear house beforehand.

Fri, Jun 14, 5:50 PM · KWin
romangg updated the diff for D18153: Correct code style of Client fullscreen control.

Rebase on master.

Fri, Jun 14, 5:39 PM · KWin
romangg added a comment to T11098: Replace Screens class.

For the implementation strategy a somewhat relevant question on a longer time scale is how we want to handle multi-platform in the future. Currently there is only one Platform instance active per session and in the important use case this is mostly the Drm backend. But is there still a case to be made, where more than one Platform at the same time could make sense?

Fri, Jun 14, 5:38 PM · KWin
romangg moved T4465: [kwin] Gamma correction from Done to Backlog on the Plasma on Wayland board.

Mistakenly moved the task to Done on Plasma on Wayland board? The task is not yet fully done.

Fri, Jun 14, 5:06 PM · KWin, Plasma on Wayland
romangg updated the diff for D18132: Rework ShellClient fullscreen control.
  • Rebase on master
  • Remove function definition in header
Fri, Jun 14, 4:56 PM · KWin
romangg updated the diff for D18128: Split up fullscreen able check into AbstractClient subclasses.

Rebase on master.

Fri, Jun 14, 4:23 PM · KWin
romangg added a task to D18185: Rework Client fullscreen control: T11098: Replace Screens class.
Fri, Jun 14, 4:23 PM · KWin
romangg added a revision to T11098: Replace Screens class: D18185: Rework Client fullscreen control.
Fri, Jun 14, 4:23 PM · KWin
romangg updated the task description for T11098: Replace Screens class.
Fri, Jun 14, 4:23 PM · KWin
romangg added revisions to T11098: Replace Screens class: D18128: Split up fullscreen able check into AbstractClient subclasses, D18132: Rework ShellClient fullscreen control, D18153: Correct code style of Client fullscreen control, D18157: Remove Client fullscreen hack.
Fri, Jun 14, 3:57 PM · KWin
romangg added a task to D18132: Rework ShellClient fullscreen control: T11098: Replace Screens class.
Fri, Jun 14, 3:57 PM · KWin
romangg added a task to D18128: Split up fullscreen able check into AbstractClient subclasses: T11098: Replace Screens class.
Fri, Jun 14, 3:57 PM · KWin
romangg added a task to D18157: Remove Client fullscreen hack: T11098: Replace Screens class.
Fri, Jun 14, 3:57 PM · KWin
romangg added a task to D18153: Correct code style of Client fullscreen control: T11098: Replace Screens class.
Fri, Jun 14, 3:57 PM · KWin
romangg updated the task description for T11098: Replace Screens class.
Fri, Jun 14, 3:55 PM · KWin
romangg committed R108:a39c74059e4a: Remove BasicScreens class (authored by romangg).
Remove BasicScreens class
Fri, Jun 14, 12:22 PM
romangg closed D21800: Remove BasicScreens class.
Fri, Jun 14, 12:22 PM · KWin
romangg added a revision to T11098: Replace Screens class: D21800: Remove BasicScreens class.
Fri, Jun 14, 12:08 PM · KWin
romangg added a task to D21800: Remove BasicScreens class: T11098: Replace Screens class.
Fri, Jun 14, 12:08 PM · KWin
romangg triaged T11098: Replace Screens class as Normal priority.
Fri, Jun 14, 12:08 PM · KWin
romangg requested review of D21800: Remove BasicScreens class.
Fri, Jun 14, 12:04 PM · KWin
romangg committed R108:6ac1585e122e: Fix xdg-output creation (authored by romangg).
Fix xdg-output creation
Fri, Jun 14, 10:19 AM

Thu, Jun 13

romangg updated the task description for T11095: Further KScreen / multi-display improvements.
Thu, Jun 13, 10:14 PM · Plasma
romangg added a comment to D21082: Fix lid open/closed configurations, OSD actions, more than 2 screens.

I added your diff to a task I created for tracking some improvements to KScreen.

Thu, Jun 13, 10:11 PM · Plasma
romangg added a revision to T11095: Further KScreen / multi-display improvements: D21082: Fix lid open/closed configurations, OSD actions, more than 2 screens.
Thu, Jun 13, 9:59 PM · Plasma
romangg added a task to D21082: Fix lid open/closed configurations, OSD actions, more than 2 screens: T11095: Further KScreen / multi-display improvements.
Thu, Jun 13, 9:59 PM · Plasma
romangg triaged T11095: Further KScreen / multi-display improvements as Normal priority.
Thu, Jun 13, 9:56 PM · Plasma
romangg added a task to D21110: On config read adjust outputs positions to global value changes: T10028: Individual KScreen output data retention.
Thu, Jun 13, 9:39 PM · Plasma
romangg added a revision to T10028: Individual KScreen output data retention: D21110: On config read adjust outputs positions to global value changes.
Thu, Jun 13, 9:39 PM · VDG, Plasma
romangg committed R104:2f26bf7fd758: On config read adjust outputs positions to global value changes (authored by romangg).
On config read adjust outputs positions to global value changes
Thu, Jun 13, 9:37 PM
romangg closed D21110: On config read adjust outputs positions to global value changes.
Thu, Jun 13, 9:37 PM · Plasma
romangg committed R104:62837af06b2b: [kcm] Expose interface to control output property retention (authored by romangg).
[kcm] Expose interface to control output property retention
Thu, Jun 13, 9:34 PM
romangg closed T10028: Individual KScreen output data retention as Resolved by committing R104:62837af06b2b: [kcm] Expose interface to control output property retention.
Thu, Jun 13, 9:34 PM · VDG, Plasma
romangg closed D16997: [kcm] Expose interface to control output property retention.
Thu, Jun 13, 9:34 PM · Plasma
romangg closed T10028: Individual KScreen output data retention, a subtask of T10488: Plasma 5.16, as Resolved.
Thu, Jun 13, 9:34 PM · Plasma
romangg committed R104:06b90b31068e: Add method to write retention to configuration control files (authored by romangg).
Add method to write retention to configuration control files
Thu, Jun 13, 9:28 PM
romangg closed D16996: Add method to write retention to configuration control files.
Thu, Jun 13, 9:28 PM · Plasma
romangg committed R104:153e6e5fbafa: Consider identical display models in ControlConfig (authored by romangg).
Consider identical display models in ControlConfig
Thu, Jun 13, 9:20 PM
romangg closed D16995: Consider identical display models in ControlConfig.
Thu, Jun 13, 9:20 PM · Plasma
romangg committed R104:18bc53a34016: Split Control class into configurations and outputs control classes (authored by romangg).
Split Control class into configurations and outputs control classes
Thu, Jun 13, 9:16 PM
romangg closed D16994: Split Control class into configurations and outputs control classes.
Thu, Jun 13, 9:16 PM · Plasma
romangg committed R104:ba9681bfd757: Add a common directory for functionality being used by kcm and daemon (authored by romangg).
Add a common directory for functionality being used by kcm and daemon
Thu, Jun 13, 9:13 PM
romangg closed D16993: Add a common directory for functionality being used by kcm and daemon.
Thu, Jun 13, 9:13 PM · Plasma
romangg committed R104:466c278f9bef: Introduce secondary control channel of the KScreen daemon (authored by romangg).
Introduce secondary control channel of the KScreen daemon
Thu, Jun 13, 9:10 PM
romangg closed D16992: Introduce secondary control channel of the KScreen daemon.
Thu, Jun 13, 9:10 PM · Plasma
romangg committed R104:979e43f99be4: Introduce concept of global and individual output data retention (authored by romangg).
Introduce concept of global and individual output data retention
Thu, Jun 13, 9:06 PM
romangg closed D16991: Introduce concept of global and individual output data retention.
Thu, Jun 13, 9:06 PM · Plasma
romangg committed R104:a17ccc22c886: [kded] Separate configuration storage path (authored by romangg).
[kded] Separate configuration storage path
Thu, Jun 13, 9:02 PM
romangg closed D16990: [kded] Separate configuration storage path.
Thu, Jun 13, 9:02 PM · Plasma
romangg committed R104:9e34fd814f90: [kded] Introduce Config wrapper class (authored by romangg).
[kded] Introduce Config wrapper class
Thu, Jun 13, 8:56 PM
romangg closed D16989: [kded] Introduce Config wrapper class.
Thu, Jun 13, 8:56 PM · Plasma
romangg updated the diff for D21110: On config read adjust outputs positions to global value changes.

Rebase on series changes.

Thu, Jun 13, 11:49 AM · Plasma
romangg updated the diff for D16997: [kcm] Expose interface to control output property retention.

Rebase on series changes.

Thu, Jun 13, 11:47 AM · Plasma
romangg updated the diff for D16996: Add method to write retention to configuration control files.

Fix newline

Thu, Jun 13, 11:45 AM · Plasma
romangg updated the diff for D16996: Add method to write retention to configuration control files.

Rebase on series changes.

Thu, Jun 13, 11:43 AM · Plasma
romangg updated the diff for D16995: Consider identical display models in ControlConfig.

Rebase on series changes.

Thu, Jun 13, 11:42 AM · Plasma
romangg updated the diff for D16994: Split Control class into configurations and outputs control classes.

Rebase on series changes.

Thu, Jun 13, 11:34 AM · Plasma
romangg updated the diff for D16993: Add a common directory for functionality being used by kcm and daemon.

Rebase on series changes.

Thu, Jun 13, 11:31 AM · Plasma
romangg updated the diff for D16992: Introduce secondary control channel of the KScreen daemon.
  • Fix newline at end of files
Thu, Jun 13, 11:29 AM · Plasma
romangg updated the diff for D16992: Introduce secondary control channel of the KScreen daemon.
  • Root dictionary in control files
Thu, Jun 13, 11:27 AM · Plasma
romangg added a comment to D16997: [kcm] Expose interface to control output property retention.

I leave the text as is for now. Let's discuss next week at Plasma Sprint.

Thu, Jun 13, 11:24 AM · Plasma
romangg updated the test plan for D16995: Consider identical display models in ControlConfig.
Thu, Jun 13, 10:41 AM · Plasma
romangg committed R110:5e1934de3bbb: Do hash and hex name based output hashes (authored by romangg).
Do hash and hex name based output hashes
Thu, Jun 13, 9:50 AM
romangg closed D17007: Do hash and hex name based output hashes.
Thu, Jun 13, 9:50 AM · Plasma
romangg committed R108:1a11abc821f4: [platforms/x11/standalone] Port to AbstractOutput (authored by romangg).
[platforms/x11/standalone] Port to AbstractOutput
Thu, Jun 13, 9:39 AM
romangg closed D19208: [platforms/x11/standalone] Port to AbstractOutput.
Thu, Jun 13, 9:39 AM · KWin
romangg committed R108:8040c559cb71: [platforms/x11/windowed] Port to AbstractOutput (authored by romangg).
[platforms/x11/windowed] Port to AbstractOutput
Thu, Jun 13, 9:28 AM
romangg closed D19207: [platforms/x11/windowed] Port to AbstractOutput.
Thu, Jun 13, 9:28 AM · KWin

Wed, Jun 12

romangg added a comment to D21668: Modernize and redesign the Night Color config window.

Looks nice! :)

Wed, Jun 12, 10:09 PM · Plasma
romangg updated the diff for D21110: On config read adjust outputs positions to global value changes.

Rebase on master.

Wed, Jun 12, 5:09 PM · Plasma
romangg updated the diff for D16997: [kcm] Expose interface to control output property retention.

Rebase on master.

Wed, Jun 12, 5:06 PM · Plasma
romangg updated the diff for D16996: Add method to write retention to configuration control files.

Rebase on master.

Wed, Jun 12, 4:59 PM · Plasma
romangg updated the diff for D16995: Consider identical display models in ControlConfig.

Rebase on master.

Wed, Jun 12, 4:56 PM · Plasma
romangg updated the diff for D16994: Split Control class into configurations and outputs control classes.

Rebase on master.

Wed, Jun 12, 4:50 PM · Plasma
romangg updated the diff for D16993: Add a common directory for functionality being used by kcm and daemon.

Rebase on master.

Wed, Jun 12, 4:38 PM · Plasma
romangg updated the diff for D16992: Introduce secondary control channel of the KScreen daemon.

Rebase on master.

Wed, Jun 12, 4:35 PM · Plasma
romangg updated the diff for D16991: Introduce concept of global and individual output data retention.

Rebase on master.

Wed, Jun 12, 4:31 PM · Plasma
romangg updated the diff for D16990: [kded] Separate configuration storage path.

Rebase on master.

Wed, Jun 12, 4:29 PM · Plasma
romangg updated the diff for D16989: [kded] Introduce Config wrapper class.

Rebase on master.

Wed, Jun 12, 2:19 PM · Plasma
romangg resigned from R216:deeace3d6b30: CMake: Highlight the standard CMake environment variables.

Fixed by 63404b960a3b. Thx @vkrause.

Wed, Jun 12, 2:12 PM
romangg updated the summary of D17007: Do hash and hex name based output hashes.
Wed, Jun 12, 2:07 PM · Plasma
romangg updated the summary of D17007: Do hash and hex name based output hashes.
Wed, Jun 12, 2:07 PM · Plasma

Tue, Jun 11

romangg updated the diff for D17007: Do hash and hex name based output hashes.

Rebase on master.

Tue, Jun 11, 9:31 PM · Plasma
romangg raised a concern with R216:deeace3d6b30: CMake: Highlight the standard CMake environment variables.

Why was there no prior review?

Tue, Jun 11, 8:47 PM
romangg updated the diff for D19207: [platforms/x11/windowed] Port to AbstractOutput.
  • Rebase on master
  • Adjust raw physical size
Tue, Jun 11, 2:49 PM · KWin
romangg added inline comments to D21746: [autotests] Fix remaining autotests with failing border calculation.
Tue, Jun 11, 2:18 PM · KWin
romangg requested review of D21746: [autotests] Fix remaining autotests with failing border calculation.
Tue, Jun 11, 1:29 PM · KWin
romangg added a comment to T11054: Make Input Methods Just Work.

! In T11054#187995, @hein wrote:
Some the details of the proposal are a bit wrong though, although the brunt of it has the right goals. Here's my talk that lays out the todo:

https://youtu.be/wE0KDabPfsQ

Tue, Jun 11, 12:02 PM · Goal Setting 2019
romangg added a comment to T11071: Rework compositing pipeline.
In T11071#187996, @zzag wrote:

One thread per output

Is it possible though? It would be nice, but kwin is synchronous up to the teeth.

Tue, Jun 11, 11:09 AM · KWin
romangg added a comment to D19207: [platforms/x11/windowed] Port to AbstractOutput.

Is there something to change in regards to DPI now here or somewhere else in a separate Patch?

Tue, Jun 11, 11:04 AM · KWin
romangg added a comment to D21655: KSelectionOwner usage in ApplicationX11 and Compositor classes.
In D21655#478044, @zzag wrote:

Hmm, I wonder whether Application or Platform could provide/create desired Compositor instance. So, there's would be generic Compositor class and X11 specific CompositorX11 class with all that manager selection headache.

Tue, Jun 11, 10:55 AM · KWin
romangg added a comment to D21654: Move non-Compositor functions out of composite.cpp source file.
In D21654#478038, @zzag wrote:

In general, +1, but this sort of changes raises a dilemma: do we want to keep git history or have tidy code? If do same thing for activation.cpp and geometry.cpp a lot of git history will be lost. I think we have to keep history of geometry.cpp because geometry handling in kwin is super weird.

Tue, Jun 11, 10:52 AM · KWin
romangg added a parent task for T5710: [kwin] Pageflips per output: T11071: Rework compositing pipeline.
Tue, Jun 11, 9:42 AM · KWin