romangg (Roman Gilg)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 21 2016, 2:20 PM (112 w, 4 d)
Availability
Available

Recent Activity

Sat, Jun 16

romangg added a comment to D13535: Do not cancel old clipboard selection if it is same as the new one..

in TestDataDevice::testReplaceSource() and it fails without this patch.
With this patch however, the selection isn't offered (is that correct behaviour?) so the wait() times out.
Is there a better way to test this?

Sat, Jun 16, 11:31 PM · Frameworks
romangg added a comment to D13360: Touchpad KDED module: Convert to JSON metadata.

Should the patch be backported to 5.13 since it's a fix for the daemon according to the description?

Sat, Jun 16, 8:44 PM · Plasma
romangg added a reviewer for D13573: Touchpad KCM QtQuickControls2 Conversion: Plasma.
Sat, Jun 16, 7:35 PM · Plasma

Fri, Jun 15

romangg added inline comments to D13510: Add XDG WM Base support to our XDGShell API.
Fri, Jun 15, 5:21 PM · Frameworks

Thu, Jun 14

romangg added inline comments to D13510: Add XDG WM Base support to our XDGShell API.
Thu, Jun 14, 11:39 PM · Frameworks
romangg added a comment to D13495: Fix XDGV6 popup test.

What's with positioner2?

Thu, Jun 14, 5:55 PM · Frameworks
romangg added inline comments to D13542: [effects/slide] Add "Slide desktop background" option.
Thu, Jun 14, 5:15 PM · KWin
romangg added inline comments to D13488: Make XDGShellV5 co-compilable with XDGWMBase.
Thu, Jun 14, 4:13 PM · Frameworks
romangg accepted D13494: Fix stupid copy paste bug in XDGShellV6 Client.
Thu, Jun 14, 2:19 PM · Frameworks
romangg committed R108:ddb44b4383ac: Small code style improvement (authored by romangg).
Small code style improvement
Thu, Jun 14, 1:52 PM
romangg accepted D13526: compare doubles to doubles.
Thu, Jun 14, 8:19 AM · KWin

Wed, Jun 13

romangg closed D7629: Do not show reveal password button on login screen.

Superseded by D9040.

Wed, Jun 13, 9:52 AM · Plasma

Tue, Jun 12

romangg added a comment to D13492: Make keyboard focus a pointer constraints necessity.

Is this a rule in the spec or one you've come up with?

Tue, Jun 12, 9:56 AM · KWin
romangg added inline comments to D13492: Make keyboard focus a pointer constraints necessity.
Tue, Jun 12, 9:53 AM · KWin
romangg requested review of D13492: Make keyboard focus a pointer constraints necessity.
Tue, Jun 12, 9:45 AM · KWin

Mon, Jun 11

romangg committed R108:2694839099c3: Remove pointer constraint on resource unbind (authored by romangg).
Remove pointer constraint on resource unbind
Mon, Jun 11, 8:46 PM
romangg closed D13466: Remove pointer constraint on resource unbind.
Mon, Jun 11, 8:46 PM · KWin
romangg added inline comments to D13284: [decorations] Let KDecoration plugins recommend a border size per default.
Mon, Jun 11, 6:40 PM · KWin
romangg updated the diff for D13480: kconfig_update for auto border size introduction.
  • Use kconf_update mechanism instead of sed
Mon, Jun 11, 6:34 PM · KWin
romangg added a comment to D13480: kconfig_update for auto border size introduction.
In D13480#277125, @zzag wrote:

Why the kconf_update/ dir is in helpers/? That doesn't look like a helper.

Mon, Jun 11, 4:14 PM · KWin
romangg added a dependency for D13481: Recommend window border size "None": D13284: [decorations] Let KDecoration plugins recommend a border size per default.
Mon, Jun 11, 3:38 PM · Plasma
romangg added a dependent revision for D13284: [decorations] Let KDecoration plugins recommend a border size per default: D13481: Recommend window border size "None".
Mon, Jun 11, 3:38 PM · KWin
romangg requested review of D13481: Recommend window border size "None".
Mon, Jun 11, 3:38 PM · Plasma
romangg added a dependency for D13480: kconfig_update for auto border size introduction: D13284: [decorations] Let KDecoration plugins recommend a border size per default.
Mon, Jun 11, 3:09 PM · KWin
romangg added a dependent revision for D13284: [decorations] Let KDecoration plugins recommend a border size per default: D13480: kconfig_update for auto border size introduction.
Mon, Jun 11, 3:09 PM · KWin
romangg requested review of D13480: kconfig_update for auto border size introduction.
Mon, Jun 11, 3:08 PM · KWin
romangg added a comment to D12820: Add KWayland virtual desktop protocol.

We can remove every layout reference in the manager as well as in the VDs. I don't see the advantage then with a list in contrast to events desktopAdded / desktopRemoved and a done event. What is better about having an ordering? It's only relevant for the special case of having a "flow" of VDs over several lines, assumed we additionally share a single integer with the workspace (via config file or DBus).

Mon, Jun 11, 2:20 PM · Frameworks
romangg added inline comments to D13466: Remove pointer constraint on resource unbind.
Mon, Jun 11, 6:19 AM · KWin
romangg updated the diff for D13466: Remove pointer constraint on resource unbind.
  • Spy on SurfaceInterface signal in test
Mon, Jun 11, 6:18 AM · KWin

Sun, Jun 10

romangg accepted D13372: Mouse KCM Redesign Using Kirigami.

Please wait for @mart's ok before pushing.

Sun, Jun 10, 9:40 PM · Plasma
romangg abandoned D13037: [Dialog] Set PlasmaShellSurface on PlasmaShell being announced.

Abandoned in favor of D13084.

Sun, Jun 10, 8:06 PM · Frameworks
romangg requested changes to D13372: Mouse KCM Redesign Using Kirigami.
Sun, Jun 10, 7:39 PM · Plasma
romangg committed R108:fcfe8763f6f0: [tests] Fix unconfine Button (authored by romangg).
[tests] Fix unconfine Button
Sun, Jun 10, 5:53 PM
romangg added a comment to D13257: [server] Send frame event instead of flush on relative pointer motion.

ping

Sun, Jun 10, 4:27 PM · Frameworks
romangg committed R127:31b1c144fde7: [server] Small code cleanup in SurfaceInterface (authored by romangg).
[server] Small code cleanup in SurfaceInterface
Sun, Jun 10, 4:10 PM
romangg closed D13191: [server] Small code cleanup in SurfaceInterface.
Sun, Jun 10, 4:10 PM · Frameworks
romangg updated the task description for T8923: Improve cursor locking and confining.
Sun, Jun 10, 3:56 PM · Plasma on Wayland
romangg updated the task description for T8923: Improve cursor locking and confining.
Sun, Jun 10, 3:52 PM · Plasma on Wayland
romangg added a revision to T8923: Improve cursor locking and confining: D13439: [tests] Add pointer constraints test.
Sun, Jun 10, 3:51 PM · Plasma on Wayland
romangg added a task to D13439: [tests] Add pointer constraints test: T8923: Improve cursor locking and confining.
Sun, Jun 10, 3:51 PM · KWin
romangg added a task to D13466: Remove pointer constraint on resource unbind: T8923: Improve cursor locking and confining.
Sun, Jun 10, 3:50 PM · KWin
romangg added a revision to T8923: Improve cursor locking and confining: D13466: Remove pointer constraint on resource unbind.
Sun, Jun 10, 3:50 PM · Plasma on Wayland
romangg requested review of D13466: Remove pointer constraint on resource unbind.
Sun, Jun 10, 3:49 PM · KWin

Sat, Jun 9

romangg added inline comments to D13372: Mouse KCM Redesign Using Kirigami.
Sat, Jun 9, 2:58 PM · Plasma
romangg committed R108:497d077349c9: [tests] Add pointer constraints test (authored by romangg).
[tests] Add pointer constraints test
Sat, Jun 9, 1:24 PM
romangg closed D13439: [tests] Add pointer constraints test.
Sat, Jun 9, 1:24 PM · KWin
romangg added inline comments to D13439: [tests] Add pointer constraints test.
Sat, Jun 9, 12:01 PM · KWin

Fri, Jun 8

romangg abandoned D13238: [tests] Add pointer constraints test.

I decided to add the test to KWin instead with: D13439

Fri, Jun 8, 11:19 PM · Plasma on Wayland, Frameworks
romangg updated the summary of D13439: [tests] Add pointer constraints test.
Fri, Jun 8, 11:16 PM · KWin
romangg requested review of D13439: [tests] Add pointer constraints test.
Fri, Jun 8, 11:14 PM · KWin

Thu, Jun 7

romangg added a comment to D13155: [effects] Add Scale Out effect.

I think it makes sense to have a separate ScaleOut effect and not a monolithic Scale effect. Because a user can then select different effects for mapping/unmapping windows. So if you reclaim this diff, I'll accept it.

Thu, Jun 7, 6:53 PM · KWin
romangg added a comment to D12820: Add KWayland virtual desktop protocol.

How is a change of neighbors supposed to work for clients already bound to the proxy objects? For example consider virtual desktop grid:

Thu, Jun 7, 2:41 PM · Frameworks
romangg added a comment to D13084: Avoid invalid geometry of internal clients through plasma surface interface.

Can we get this merged now as a quick fix for the bug? In the future we might want to discuss the overall structure of internal windows and their Wayland interfaces.

Thu, Jun 7, 9:56 AM · KWin
romangg added inline comments to D13396: Set specific edge cursor shape when resizing.
Thu, Jun 7, 1:28 AM · KWin

Wed, Jun 6

romangg updated the diff for D11803: [colorcorrection] Set gamma through Output class.
  • const Gamma parameter
  • Rebase on parent revision changes
Wed, Jun 6, 5:26 PM · KWin
romangg updated the diff for D11789: [platforms/virtual] Let VirtualOutput inherit Output.

Rebase on parent revision changes

Wed, Jun 6, 5:10 PM · KWin
romangg updated the diff for D11782: Introduce OutputScreens class.

Small cleanup

Wed, Jun 6, 5:03 PM
romangg updated the diff for D11782: Introduce OutputScreens class.

Rebase on parent revision changes

Wed, Jun 6, 4:56 PM
romangg updated the diff for D11781: Introduce generic Output class.

Small cleanup

Wed, Jun 6, 4:43 PM · KWin
romangg updated the diff for D11781: Introduce generic Output class.
  • Add ctor to Output
  • Save outputs in Platform subclasses directly
  • Rename Output to AbstractOutput
  • Use std::copy for outputs getters
  • Rename output files to abstract_output
Wed, Jun 6, 3:40 PM · KWin
romangg added inline comments to D11781: Introduce generic Output class.
Wed, Jun 6, 3:40 PM · KWin
romangg accepted D13195: Fixed 2 typos.
Wed, Jun 6, 6:56 AM

Mon, Jun 4

romangg added a comment to T8501: Fractional Scaling.
  1. XDGOutput landed. What's left to do in 2. and 3.? Can you expand upon the required changes?
Mon, Jun 4, 3:29 PM · KWin
romangg added a comment to D13299: Hide decoration tooltip when the decoration gets destroyed.

Right, because it's a single tooltip instance for KWin and not per client. Ok, then let's land it like it is.

Mon, Jun 4, 3:27 PM · KWin
romangg requested changes to D13141: Touchpad KCM Redesign Using Kirigami.
Mon, Jun 4, 2:22 PM · Plasma
romangg accepted D13299: Hide decoration tooltip when the decoration gets destroyed.

Do you need the m_toolTipShowing variable at all? On destruct just always calling requestHideToolTip should be possible, not?

Mon, Jun 4, 1:47 PM · KWin
romangg updated the summary of D13191: [server] Small code cleanup in SurfaceInterface.
Mon, Jun 4, 10:34 AM · Frameworks
romangg added a comment to T8707: Window borders.
In T8707#146055, @mart wrote:

We are not going to clip anything away from the windows. Sorry, but we cannot do that. It's in IMHO absolutely evil to clip away window content. If you want round borders follow the approach I outlined.

it's really eveil as it can break random applications, yes...
but what about there is a protocol that first asks to the window if it's ok to round, and does it only if the app answers yes?

Mon, Jun 4, 9:57 AM · VDG

Sun, Jun 3

romangg added a comment to D13284: [decorations] Let KDecoration plugins recommend a border size per default.

Here's a UI idea: Instead of "Auto border size", how about inverting the logic and combining the checkbox and the combobox's label, like this:

[x] Override theme's default border size in favor of: [ Normal Borders ⮟ ]"
Sun, Jun 3, 7:55 PM · KWin
romangg added a comment to D13277: Turn off the extended resize handle/black triangle when there are no borders.

Now, no there is no reason not to turn it off by default, except that it will piss people relying on it (and now they will have to look for the option for turning it on again).

That's not a good reason against changing a default. Otherwise we could never change one.

Sun, Jun 3, 5:36 PM · Plasma
romangg accepted D13277: Turn off the extended resize handle/black triangle when there are no borders.

I think this should land independently of the other diffs. I've always used the Normal border size in the past, but now trying out "No Borders" with my patch I don't see the reason for painting this handle. Is there any reason to keep this default as it is?

Sun, Jun 3, 3:04 PM · Plasma
romangg updated the diff for D13284: [decorations] Let KDecoration plugins recommend a border size per default.
  • Better object names,
  • name combobox "Manual border size",
  • disable its label as well.
Sun, Jun 3, 2:59 PM · KWin
romangg added a comment to D13302: check for needed version of libavcode, libavformat and libavutil.

I tried this patch on Neon with FFmpeg 2.8.14.

Sun, Jun 3, 2:29 PM · Baloo, Frameworks
romangg changed the edit policy for P230 KFileMetaData cmake.log.
Sun, Jun 3, 2:16 PM · Frameworks

Sat, Jun 2

romangg added inline comments to D13284: [decorations] Let KDecoration plugins recommend a border size per default.
Sat, Jun 2, 10:19 PM · KWin
romangg added inline comments to D13284: [decorations] Let KDecoration plugins recommend a border size per default.
Sat, Jun 2, 7:15 PM · KWin
romangg updated the diff for D13284: [decorations] Let KDecoration plugins recommend a border size per default.

Fix: always fall back to normal borders when auto border size is used but the

plugin does not have a recommendation.
Sat, Jun 2, 2:25 PM · KWin
romangg added a comment to D13284: [decorations] Let KDecoration plugins recommend a border size per default.

To test this for example with Breeze you need to recompile Breeze with the following change:

diff --git a/kdecoration/breeze.json b/kdecoration/breeze.json
index ca4a4e3..bb94302 100644
--- a/kdecoration/breeze.json
+++ b/kdecoration/breeze.json
@@ -64,6 +64,7 @@
     },
     "org.kde.kdecoration2": {
         "blur": false,
+        "borderSizeRecommended": "None",
         "kcmodule": true
     }
 }
Sat, Jun 2, 12:55 PM · KWin
romangg requested review of D13284: [decorations] Let KDecoration plugins recommend a border size per default.
Sat, Jun 2, 12:52 PM · KWin

Fri, Jun 1

romangg updated the diff for D11803: [colorcorrection] Set gamma through Output class.

Rebase on parent revision changes

Fri, Jun 1, 6:48 PM · KWin
romangg updated the diff for D11789: [platforms/virtual] Let VirtualOutput inherit Output.

Rebase on parent revision changes

Fri, Jun 1, 6:43 PM · KWin
romangg updated the diff for D11782: Introduce OutputScreens class.

Rebase on parent revision changes

Fri, Jun 1, 6:34 PM
romangg added inline comments to D11781: Introduce generic Output class.
Fri, Jun 1, 6:13 PM · KWin
romangg updated the diff for D11781: Introduce generic Output class.

Rebase on master. Include XdgOutput changes.

Fri, Jun 1, 6:10 PM · KWin
romangg added a comment to D13153: WIP: [libkwineffects] Allow effects to grab windows.
In D13153#270440, @zzag wrote:

@graesslin Should I add tests? If so, where should I put them? In libkwineffects/(as Unit tests) or integration/(as Integration tests)?

Fri, Jun 1, 3:52 PM · KWin
romangg added inline comments to D13263: [effects/glide] Do not animate logout screen.
Fri, Jun 1, 3:47 PM · KWin
romangg accepted D13263: [effects/glide] Do not animate logout screen.
Fri, Jun 1, 3:20 PM · KWin
romangg accepted D13267: Don't scale resolution dependent cursor size twice.
Fri, Jun 1, 3:14 PM · KWin
romangg added a comment to D10747: Implement zwp_linux_dmabuf_v1.

What's the current state of this patch and the KWin one?

Fri, Jun 1, 3:01 PM · Plasma on Wayland, Frameworks
romangg added a comment to D13267: Don't scale resolution dependent cursor size twice.

If the scale changes now for the first screen, it wouldn't reload the theme, right? I.e. remove the multiplication but leave the connect.

scale would be the wrong thing to follow in that case
I can change it to pixelSizeChanged and keep it.

Fri, Jun 1, 2:51 PM · KWin
romangg added inline comments to D13263: [effects/glide] Do not animate logout screen.
Fri, Jun 1, 2:51 PM · KWin
romangg added a comment to D13267: Don't scale resolution dependent cursor size twice.

If the scale changes now for the first screen, it wouldn't reload the theme, right? I.e. remove the multiplication but leave the connect.

Fri, Jun 1, 2:30 PM · KWin
romangg committed R119:efd6bbdc1ee7: Merge branch 'Plasma/5.13' (authored by romangg).
Merge branch 'Plasma/5.13'
Fri, Jun 1, 2:11 PM
romangg committed R119:7a03d8d3fab0: [Mouse KCM] Fix writing selected profile value (authored by romangg).
[Mouse KCM] Fix writing selected profile value
Fri, Jun 1, 2:08 PM
romangg closed D13270: [Mouse KCM] Fix writing selected profile value.
Fri, Jun 1, 2:08 PM · Plasma
romangg added a comment to D13155: [effects] Add Scale Out effect.

I agree with you both. Long term it's right what Martin says: We want to reduce the code base in KWin to have it lean and move additional functionality out so users can extend their desktop if they wish to on a solid base.

Fri, Jun 1, 2:06 PM · KWin
romangg requested review of D13270: [Mouse KCM] Fix writing selected profile value.
Fri, Jun 1, 1:52 PM · Plasma
romangg accepted D9860: [effects] Fix several animation and reflection issues with cube effect.

I can't say much about the code, but I tried out the change and didn't notice any regressions and I assume the change does improve the overall code quality and fixes some bugs. I would say let's get this effort merged into master and see afterwards if there are regressions reported. The effect is rather rarely used so breakage shouldn't be a huge problem.

Fri, Jun 1, 12:56 PM · KWin
romangg requested changes to D10291: Add a recursion blocker in Pointer/TouchInputRedirection::update.

When you have time please address my comment. I have to say though that I can't reproduce the crash when hovering over close button in Debug console.

Fri, Jun 1, 11:12 AM · KWin
romangg raised a concern with R286:3415015e3d45: check that ffmpeg is at least version 3.1 that introduce the API we require.

On Neon (Xenial based) FFmpeg version is 2.8.14. It still doesn't fail on CMake. It maybe compares 3.1 with the version numbers of the FFmpeg modules. Their major versions are >50. Then it fails on build, because AVCodecParameters is not defined since 037208a787e0.

Fri, Jun 1, 10:56 AM