romangg (Roman Gilg)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 21 2016, 2:20 PM (120 w, 6 d)
Availability
Available

Recent Activity

Today

romangg accepted D14849: [Labels] Make the Ellipses section more clear.
Wed, Aug 15, 8:01 AM
romangg requested changes to D14849: [Labels] Make the Ellipses section more clear.

That's a very nice change. I especially like that reasons are given when ellipses should not be used. As for writing style, I always try to minimize the usage of parentheses, since too many of them are distracting when reading. Maybe state the reasons with an em dash instead (you could additionally write the reason italic):

Wed, Aug 15, 6:59 AM

Wed, Aug 8

romangg accepted D14505: Sync set/send/update methods.
Wed, Aug 8, 2:36 PM · Frameworks
romangg accepted D10040: Add serial number and EISA ID to OutputDevice interface.
Wed, Aug 8, 2:35 PM · Frameworks, Plasma on Wayland

Fri, Aug 3

romangg added a project to T8923: Improve cursor locking and confining: Plasma (Plasma 5.14).
Fri, Aug 3, 10:55 AM · Plasma (Plasma 5.14), Plasma on Wayland
romangg edited projects for T4465: [kwin] Gamma correction, added: Plasma (Plasma 5.14); removed Plasma (Plasma 5.13).
Fri, Aug 3, 10:53 AM · Plasma (Plasma 5.14), KWin, Plasma on Wayland
romangg moved T5196: Support flags/labels in keyboard layout sni from Plasma 5.13 to Backlog on the KWin board.
Fri, Aug 3, 10:51 AM · KWin, Plasma on Wayland
romangg moved T5169: Split screen virtual keyboard and window from Plasma 5.13 to Backlog on the KWin board.
Fri, Aug 3, 10:51 AM · KWin
romangg moved T5216: Support OnScreenNotification on X11 from Plasma 5.13 to Backlog on the KWin board.
Fri, Aug 3, 10:51 AM · KWin
romangg moved T5217: Use interactive window selection for "Detect window properties" in kcm rules from Plasma 5.13 to Backlog on the KWin board.
Fri, Aug 3, 10:51 AM · KWin
romangg moved T5222: Support X11 keyboard layout in Xkb from Plasma 5.13 to Backlog on the KWin board.
Fri, Aug 3, 10:51 AM · KWin
romangg moved T5360: Create LED Input Event spy from Plasma 5.13 to Backlog on the KWin board.
Fri, Aug 3, 10:51 AM · KWin
romangg closed T9232: Wayland Colour Correction as Invalid.

Already tracked with T4465.

Fri, Aug 3, 10:33 AM · Plasma on Wayland

Mon, Jul 30

romangg added a comment to D10040: Add serial number and EISA ID to OutputDevice interface.

I just removed handling of dynamically updating eisa/serialNumber it doesn't seem to be something that makes sense for it to change at runtime.

Also I don't want to copy the current setEdid pattern, which is broken ATM. Whenever any new client connects it broadcasts a change to every connected client...
I need to follow that up in another patch, possibly by making it static like these two.

Mon, Jul 30, 4:12 PM · Frameworks, Plasma on Wayland
romangg accepted D12388: Output device color curves correction.
Mon, Jul 30, 12:38 PM · Frameworks
romangg added inline comments to D10040: Add serial number and EISA ID to OutputDevice interface.
Mon, Jul 30, 12:30 PM · Frameworks, Plasma on Wayland
romangg added a comment to D14478: Do not leak all instances of QMLOutput when QMLScreen is destroyed.

I also thought the call to setParentItem would clear the output. But as @broulik says it does not delete automatically. So is this good to go? Or should we make QMLScreen really a Qt Object parent of the outputs?

Mon, Jul 30, 10:02 AM · Plasma
romangg added a comment to D14353: Improve alignment of types.

As already said on IRC and also how Vlad sees it: this optimization like for most of our classes is not worth it.

Mon, Jul 30, 7:54 AM · Plasma
romangg accepted D14477: Do not leak Widget::ui.
Mon, Jul 30, 7:31 AM · Plasma
romangg accepted D14476: QMLScreen: do not declare the engine a member.

Note, that m_engine is set in widget.cpp. But it's just a Cpp call to setEngine, which is defined extra. So removing the property macro should be fine.

Mon, Jul 30, 7:29 AM · Plasma

Fri, Jul 27

romangg closed T4693: Use cursor position hint from LockedPointerInterface as Resolved.
Fri, Jul 27, 5:25 PM · KWin, Plasma on Wayland
romangg closed T4693: Use cursor position hint from LockedPointerInterface, a subtask of T4692: [kwayland] Support cursor hint on LockedPointerInterface, as Resolved.
Fri, Jul 27, 5:25 PM · Plasma on Wayland
romangg closed T4693: Use cursor position hint from LockedPointerInterface, a subtask of T8923: Improve cursor locking and confining, as Resolved.
Fri, Jul 27, 5:25 PM · Plasma (Plasma 5.14), Plasma on Wayland
romangg claimed T4693: Use cursor position hint from LockedPointerInterface.
Fri, Jul 27, 5:25 PM · KWin, Plasma on Wayland
romangg closed T4692: [kwayland] Support cursor hint on LockedPointerInterface as Resolved.
Fri, Jul 27, 5:24 PM · Plasma on Wayland
romangg closed T4692: [kwayland] Support cursor hint on LockedPointerInterface, a subtask of T8923: Improve cursor locking and confining, as Resolved.
Fri, Jul 27, 5:24 PM · Plasma (Plasma 5.14), Plasma on Wayland
romangg accepted D14368: Let edidDecodeFraction return float.
Fri, Jul 27, 3:59 PM · Plasma
romangg committed R108:054ccc389899: Use locked cursor position hint (authored by romangg).
Use locked cursor position hint
Fri, Jul 27, 3:20 PM
romangg closed D14176: Use locked cursor position hint.
Fri, Jul 27, 3:20 PM · KWin
romangg accepted D14418: Add test for edid parsing and fix reading gamma.

The old code's output was "2.0" instead of "2.2": integer division first, then cast.

Yes, I know. But my train of thoughts was that the original value was multiplied by 100 when the raw edid data was produced, so it should be divisible by 100 again. But the original value was in general already a float, so this is indeed a bug.

Fri, Jul 27, 1:22 PM · Plasma
romangg added inline comments to D14364: Test configId in TestSerializer.
Fri, Jul 27, 10:32 AM · Plasma
romangg requested changes to D14418: Add test for edid parsing and fix reading gamma.
Fri, Jul 27, 9:35 AM · Plasma
romangg accepted D14359: Create m_saveTimer lazily.
Fri, Jul 27, 9:32 AM · Plasma
romangg added a comment to D14418: Add test for edid parsing and fix reading gamma.

I'm not sure if you could really say that the current code is with a bug, since data[GCM_EDID_OFFSET_GAMMA] should be dividable by 100. I.e. the result is again an integer and nothing gets truncated. But we can still go with the updated code, which looks nicer. Maybe one could add a comment why divide by 100 and add 1.

Fri, Jul 27, 9:15 AM · Plasma
romangg added inline comments to D14364: Test configId in TestSerializer.
Fri, Jul 27, 8:48 AM · Plasma

Thu, Jul 26

romangg accepted D14339: Change rotation icons to be a rotated preview icon.
Thu, Jul 26, 12:05 PM · Plasma
romangg added a comment to D14371: Simplify Edid::Private::parse gamma.

I do wonder if the division by 100 is right though - and where does the +1 come from?

Thu, Jul 26, 12:00 PM · Plasma
romangg added a reviewer for D14369: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone: Plasma.
Thu, Jul 26, 11:45 AM · Plasma
romangg accepted D14370: Simplify Edid::Private::edidParseString.
Thu, Jul 26, 11:43 AM · Plasma
romangg added a reviewer for D14370: Simplify Edid::Private::edidParseString: Plasma.
Thu, Jul 26, 11:43 AM · Plasma
romangg requested changes to D14368: Let edidDecodeFraction return float.

You use the result var of type float in an addition 10 times. Now the calculation is done with less precision. The git message should state why it's no problem.

Thu, Jul 26, 11:38 AM · Plasma
romangg requested changes to D14364: Test configId in TestSerializer.
Thu, Jul 26, 11:32 AM · Plasma
romangg requested changes to D14359: Create m_saveTimer lazily.

What @broulik says. It should be fine with the m_changeCompressor being startet in init, but the git message should note this. Also the git message could be a bit more descriptive on what's happening.

Thu, Jul 26, 11:26 AM · Plasma
romangg requested changes to D14353: Improve alignment of types.

Why push id down? It should stay at the top imo (or alphabetically). Rest is fine.

Thu, Jul 26, 11:23 AM · Plasma

Tue, Jul 24

romangg added a comment to T7254: Displays (WIP?).

Another point to consider is font DPI, which is currently in a different place in system settings, but very related to the scaling.

Tue, Jul 24, 6:17 PM · VDG, Plasma

Mon, Jul 23

romangg accepted D14291: Cleanup RemoteAccess buffers on aboutToBeUnbound instead of object destruction.
Mon, Jul 23, 4:15 PM · Frameworks
romangg moved T4461: [kwin] Virtual Desktops KCM needs porting from Work In Progress to Backlog on the Plasma on Wayland board.
Mon, Jul 23, 12:53 PM · Plasma on Wayland
romangg edited projects for T4457: [kwayland] Virtual Desktop protocol, added: Plasma on Wayland; removed Plasma.
Mon, Jul 23, 12:53 PM · Plasma on Wayland
romangg added a subtask for T4457: [kwayland] Virtual Desktop protocol: T4461: [kwin] Virtual Desktops KCM needs porting.
Mon, Jul 23, 12:53 PM · Plasma on Wayland
romangg added a parent task for T4461: [kwin] Virtual Desktops KCM needs porting: T4457: [kwayland] Virtual Desktop protocol.
Mon, Jul 23, 12:52 PM · Plasma on Wayland
romangg moved T4611: Drag and drop from XWayland to Wayland windows and vice versa from Backlog to Work In Progress on the Plasma on Wayland board.
Mon, Jul 23, 9:20 AM · Plasma on Wayland
romangg committed R127:cebfd2f8d2f9: Support cursor hints on locked pointer (authored by romangg).
Support cursor hints on locked pointer
Mon, Jul 23, 9:17 AM
romangg closed D14175: Support cursor hints on locked pointer.
Mon, Jul 23, 9:17 AM · Frameworks
romangg updated the test plan for D14175: Support cursor hints on locked pointer.
Mon, Jul 23, 8:53 AM · Frameworks

Sun, Jul 22

romangg added inline comments to D14251: Flush Xwayland connection only when events were filtered.
Sun, Jul 22, 11:32 PM · KWin

Fri, Jul 20

romangg requested review of D14251: Flush Xwayland connection only when events were filtered.
Fri, Jul 20, 4:24 PM · KWin
romangg committed R108:afc80f8bd5bd: Call workspaceEvent and updateX11Time only once per event (authored by romangg).
Call workspaceEvent and updateX11Time only once per event
Fri, Jul 20, 4:16 PM
romangg closed D14215: Call workspaceEvent and updateX11Time only once per event.
Fri, Jul 20, 4:16 PM · KWin
romangg added inline comments to D11781: Introduce generic Output class.
Fri, Jul 20, 4:05 PM · KWin
romangg commandeered D11781: Introduce generic Output class.

David told me to commandeer back.

Fri, Jul 20, 11:39 AM · KWin

Thu, Jul 19

romangg added inline comments to D14215: Call workspaceEvent and updateX11Time only once per event.
Thu, Jul 19, 4:36 PM · KWin
romangg added inline comments to D11781: Introduce generic Output class.
Thu, Jul 19, 4:27 PM · KWin
romangg added a comment to D11781: Introduce generic Output class.

@Roman
Check you're ok with the mod, and then I'll ack the rest.

Thu, Jul 19, 4:26 PM · KWin

Wed, Jul 18

romangg added a comment to T4611: Drag and drop from XWayland to Wayland windows and vice versa.

Selections are defined in ICCM: https://tronche.com/gui/x/icccm/sec-2.html#s-2
General introduction to X11 Selections: https://www.uninformativ.de/blog/postings/2017-04-02/0/POSTING-en.html

Wed, Jul 18, 10:37 PM · Plasma on Wayland
romangg updated the summary of D14215: Call workspaceEvent and updateX11Time only once per event.
Wed, Jul 18, 5:24 PM · KWin
romangg updated the diff for D14215: Call workspaceEvent and updateX11Time only once per event.
  • Cleanup and remove second updateX11Time call also
Wed, Jul 18, 5:23 PM · KWin
romangg requested review of D14215: Call workspaceEvent and updateX11Time only once per event.
Wed, Jul 18, 5:18 PM · KWin
romangg updated the task description for T9061: Attend External Events 2018: X.org Developer's Conference 2018.
Wed, Jul 18, 11:50 AM · KDE Promo
romangg committed R127:919ee2ac6afd: Reduce unnecessary long wait times on failing signal spies (authored by romangg).
Reduce unnecessary long wait times on failing signal spies
Wed, Jul 18, 9:03 AM
romangg closed D14184: Reduce unnecessary long wait times on failing signal spies.
Wed, Jul 18, 9:03 AM · Frameworks
romangg committed R127:36544d3dfbb9: Fix selection and seat auto tests (authored by romangg).
Fix selection and seat auto tests
Wed, Jul 18, 9:01 AM
romangg closed D14183: Fix selection and seat auto tests.
Wed, Jul 18, 9:01 AM · Frameworks
romangg added a comment to T4611: Drag and drop from XWayland to Wayland windows and vice versa.

Awaits following pr to be complete: https://github.com/swaywm/wlroots/pull/841

Wed, Jul 18, 8:59 AM · Plasma on Wayland
romangg updated the diff for D14176: Use locked cursor position hint.
  • Add comments, constify
Wed, Jul 18, 7:07 AM · KWin

Tue, Jul 17

romangg added a comment to D14176: Use locked cursor position hint.

@graesslin Thanks for review, but David wanted me to use a cached variable in KWayland. That's why I had to rework the KWin implementation as well. Sorry. Would appreciate another review for this revision.

Tue, Jul 17, 4:30 PM · KWin
romangg updated the diff for D14176: Use locked cursor position hint.
  • Use hint getter
Tue, Jul 17, 4:27 PM · KWin
romangg updated the diff for D14175: Support cursor hints on locked pointer.
  • Add hint getter
  • Add since keyword
Tue, Jul 17, 4:25 PM · Frameworks
romangg requested review of D14184: Reduce unnecessary long wait times on failing signal spies.
Tue, Jul 17, 12:10 PM · Frameworks
romangg updated the summary of D14183: Fix selection and seat auto tests.
Tue, Jul 17, 11:57 AM · Frameworks
romangg requested review of D14183: Fix selection and seat auto tests.
Tue, Jul 17, 11:56 AM · Frameworks
romangg added inline comments to D14175: Support cursor hints on locked pointer.
Tue, Jul 17, 11:17 AM · Frameworks
romangg updated the diff for D14175: Support cursor hints on locked pointer.
  • Add autotest
Tue, Jul 17, 9:12 AM · Frameworks
romangg added a task to D14176: Use locked cursor position hint: T4693: Use cursor position hint from LockedPointerInterface.
Tue, Jul 17, 12:53 AM · KWin
romangg added a revision to T4693: Use cursor position hint from LockedPointerInterface: D14176: Use locked cursor position hint.
Tue, Jul 17, 12:53 AM · KWin, Plasma on Wayland
romangg added a dependency for D14176: Use locked cursor position hint: D14175: Support cursor hints on locked pointer.
Tue, Jul 17, 12:52 AM · KWin
romangg added a dependent revision for D14175: Support cursor hints on locked pointer: D14176: Use locked cursor position hint.
Tue, Jul 17, 12:52 AM · Frameworks
romangg requested review of D14176: Use locked cursor position hint.
Tue, Jul 17, 12:51 AM · KWin
romangg added a task to D14175: Support cursor hints on locked pointer: T4692: [kwayland] Support cursor hint on LockedPointerInterface.
Tue, Jul 17, 12:47 AM · Frameworks
romangg added a revision to T4692: [kwayland] Support cursor hint on LockedPointerInterface: D14175: Support cursor hints on locked pointer.
Tue, Jul 17, 12:47 AM · Plasma on Wayland
romangg updated the diff for D14175: Support cursor hints on locked pointer.
  • Cleanup: remove hint getter
Tue, Jul 17, 12:46 AM · Frameworks
romangg requested review of D14175: Support cursor hints on locked pointer.
Tue, Jul 17, 12:42 AM · Frameworks

Jul 16 2018

romangg added a comment to T4435: [kwin] Change cursor on TabBox.

From a short test: the cursor is always the default cursor on TabBox but not above it. Changing the cursor to some other icon to indicate a click closes the TabBox could be done, but I believe wouldn't look good. Would like to close this task therefore.

Jul 16 2018, 8:54 AM · KWin, Plasma on Wayland
romangg claimed T4611: Drag and drop from XWayland to Wayland windows and vice versa.
Jul 16 2018, 8:51 AM · Plasma on Wayland
romangg updated the task description for T8923: Improve cursor locking and confining.
Jul 16 2018, 8:49 AM · Plasma (Plasma 5.14), Plasma on Wayland
romangg abandoned D13758: [tabbox] Deactivate client while switching windows on Wayland.

Because of risk of regressions abandoned. Pointer constraint deactivation on TabBox invocation was alternatively changed to be done explicitly through f0ba436c724e.

Jul 16 2018, 8:46 AM · KWin
romangg committed R108:f0ba436c724e: Explicitly disable pointer constraints on TabBox invocation (authored by romangg).
Explicitly disable pointer constraints on TabBox invocation
Jul 16 2018, 8:44 AM
romangg closed D14142: Explicitly disable pointer constraints on TabBox invocation.
Jul 16 2018, 8:43 AM · KWin
romangg updated the task description for T8923: Improve cursor locking and confining.
Jul 16 2018, 8:42 AM · Plasma (Plasma 5.14), Plasma on Wayland
romangg added a task to D14142: Explicitly disable pointer constraints on TabBox invocation: T8923: Improve cursor locking and confining.
Jul 16 2018, 8:41 AM · KWin
romangg added a revision to T8923: Improve cursor locking and confining: D14142: Explicitly disable pointer constraints on TabBox invocation.
Jul 16 2018, 8:41 AM · Plasma (Plasma 5.14), Plasma on Wayland