romangg (Roman Gilg)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 21 2016, 2:20 PM (177 w, 6 d)
Availability
Available

Recent Activity

Today

romangg accepted D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access).

Or let's just get it in. It's a small change and we still have the beta phase to test it.

Wed, Sep 18, 8:01 PM · Plasma
romangg added a comment to D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access).

Ok, you need this for 5.17?

Wed, Sep 18, 7:59 PM · Plasma
romangg added a comment to D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access).

Thanks for the patch Jason. So the GSendStr(nullptr) is called on m_password.isNull() because this aborts the current PAM session? If this is correct, patch looks good to me.

Wed, Sep 18, 7:27 PM · Plasma
romangg closed D24038: Improve output enablement recovery and config write.
Wed, Sep 18, 6:28 PM · Plasma
romangg committed R104:936d28ce8fca: Improve output enablement recovery and config write (authored by romangg).
Improve output enablement recovery and config write
Wed, Sep 18, 6:28 PM
romangg closed D24037: Add enforced mode size getter.
Wed, Sep 18, 6:26 PM · Plasma
romangg committed R110:293cb32c737a: Add enforced mode size getter (authored by romangg).
Add enforced mode size getter
Wed, Sep 18, 6:26 PM
romangg added a comment to D24051: [platforms/drm] introduce env var to select GPU.

env var should be called KWIN_DRM_DEVICE_NODE

Wed, Sep 18, 1:21 PM · KWin
romangg accepted D24051: [platforms/drm] introduce env var to select GPU.

I'm ok with having this as a short-term fix but long-term this env var should go away again and be replaced with a better selection mechanism. So no guarantee that it will be available after 5.18 LTS.

Wed, Sep 18, 1:20 PM · KWin
romangg added a comment to D24044: Emphasize minimization in MinimizeAll script.

Please more verbose summary.

Wed, Sep 18, 11:03 AM · KWin

Yesterday

romangg added a dependent revision for D24037: Add enforced mode size getter: D24038: Improve output enablement recovery and config write.
Tue, Sep 17, 11:23 PM · Plasma
romangg added a dependency for D24038: Improve output enablement recovery and config write: D24037: Add enforced mode size getter.
Tue, Sep 17, 11:23 PM · Plasma
romangg requested review of D24038: Improve output enablement recovery and config write.
Tue, Sep 17, 11:22 PM · Plasma
romangg closed D24021: Delay load on output add/remove.
Tue, Sep 17, 11:16 PM · Plasma
romangg committed R104:7efeabc5b4ac: Delay load on output add/remove (authored by romangg).
Delay load on output add/remove
Tue, Sep 17, 11:16 PM
romangg updated the summary of D24037: Add enforced mode size getter.
Tue, Sep 17, 11:09 PM · Plasma
romangg requested review of D24037: Add enforced mode size getter.
Tue, Sep 17, 11:07 PM · Plasma
romangg added a comment to D24033: Add Meta+Space as a default shortcut to activate KRunner.

I agree with Meta instead of Alt for all "system shortcuts". Hence I would like to see this as well for all window manager operations. Meta => system, Ctrl, Alt => applications.

Tue, Sep 17, 7:39 PM · Plasma
romangg accepted D23798: Polish Displays KCM UI.
Tue, Sep 17, 7:13 PM · Plasma
romangg requested review of D24021: Delay load on output add/remove.
Tue, Sep 17, 9:40 AM · Plasma
romangg added inline comments to D23798: Polish Displays KCM UI.
Tue, Sep 17, 8:09 AM · Plasma
romangg added inline comments to D23798: Polish Displays KCM UI.
Tue, Sep 17, 7:56 AM · Plasma
romangg added a comment to D23798: Polish Displays KCM UI.

The orientation toolbuttons seem oversized.

Tue, Sep 17, 7:43 AM · Plasma
romangg added a comment to D23909: Pass area by const reference to placeFoo methods.

Please next time besides a title add a meaningful description if you push a patch with more than a trivial change and without review. I assume it was just a mistake that you also didn't link back to the review in the commit bccbb8f3a5f8.

Tue, Sep 17, 7:40 AM · KWin
romangg added a comment to D23798: Polish Displays KCM UI.

Need a hand with the TODO: in main.qml.

Tue, Sep 17, 7:28 AM · Plasma

Mon, Sep 16

romangg moved T6064: Work on Qt >= 5.8 from Work In Progress to Done on the Plasma on Wayland board.
Mon, Sep 16, 8:41 PM · Plasma on Wayland
romangg moved T4688: Support surface and output scaling from Work In Progress to Done on the Plasma on Wayland board.
Mon, Sep 16, 8:41 PM · KWin, Plasma on Wayland
romangg added a comment to D23798: Polish Displays KCM UI.

Reducing the screen area height makes it difficult to place outputs on top of each other. Making it a bit smaller is fine (and improving the logic of how much this it in comparison to overall kcm size) but I think this is too much. Alternatively the size of the outputs could be reduced.

Mon, Sep 16, 8:37 PM · Plasma
romangg closed T4462: [kwin] Detect hung Wayland windows as Resolved.
Mon, Sep 16, 12:15 PM · KWin, Plasma on Wayland
romangg closed T4762: Use 2D QMl Renderer on QPainter compositor as Resolved.
Mon, Sep 16, 12:14 PM · KWin, Plasma on Wayland
romangg closed T9872: XDGPopop Positioner as Resolved.
Mon, Sep 16, 12:12 PM · Plasma on Wayland
romangg closed T4464: [kwin] Support Window Rules as Resolved.
Mon, Sep 16, 12:11 PM · KWin, Plasma on Wayland
romangg closed T4454: [frameworks] KModifierKeyInfo needs porting as Resolved.
Mon, Sep 16, 12:10 PM · Plasma on Wayland
romangg placed T7785: PipeWire support in remote access to KWin up for grabs.
Mon, Sep 16, 12:07 PM · Plasma (Plasma 5.14), KWin, Plasma on Wayland
romangg placed T4437: [kwayland] Security filter up for grabs.
Mon, Sep 16, 12:07 PM · Plasma on Wayland
romangg placed T4436: [kwin] Non-maximized windows are shown as maximized up for grabs.
Mon, Sep 16, 12:07 PM · KWin, Plasma on Wayland
romangg placed T4429: [kwin] Better announce supported Compositors up for grabs.
Mon, Sep 16, 12:06 PM · Plasma on Wayland
romangg reassigned T4453: [kwayland] Implement Protocol for exporting xdg surface handles from romangg to graesslin.
Mon, Sep 16, 12:06 PM · Plasma on Wayland
romangg closed T4453: [kwayland] Implement Protocol for exporting xdg surface handles as Resolved.
Mon, Sep 16, 12:05 PM · Plasma on Wayland
romangg closed T4437: [kwayland] Security filter as Resolved.
Mon, Sep 16, 12:04 PM · Plasma on Wayland
romangg closed T7785: PipeWire support in remote access to KWin as Resolved.
Mon, Sep 16, 12:03 PM · Plasma (Plasma 5.14), KWin, Plasma on Wayland
romangg closed T7785: PipeWire support in remote access to KWin, a subtask of T5653: [kwin] Screen recording in Wayland session, as Resolved.
Mon, Sep 16, 12:03 PM · Plasma (Plasma 5.13), Plasma on Wayland, KWin
romangg closed T5714: Fix cursor icon on window resize as Resolved.
Mon, Sep 16, 12:03 PM · KWin, Plasma on Wayland
romangg moved T5196: Support flags/labels in keyboard layout sni from Postponed to Peripheral on the Plasma on Wayland board.
Mon, Sep 16, 12:02 PM · KWin, Plasma on Wayland
romangg moved T4423: [kwindowsystem] Adjust KKeyServer from Postponed to Peripheral on the Plasma on Wayland board.
Mon, Sep 16, 12:02 PM · Plasma on Wayland
romangg added a comment to T4423: [kwindowsystem] Adjust KKeyServer.

Do we need KKeyServer at all on Wayland?

Mon, Sep 16, 12:02 PM · Plasma on Wayland
romangg updated subscribers of T4430: Export ShellClient to Scripting.

@zzag You improved the scripting on Wayland, right? Is this task resolved?

Mon, Sep 16, 11:46 AM · KWin
romangg renamed T4430: Export ShellClient to Scripting from [kwin] Export ShellClient to Scripting to Export ShellClient to Scripting.
Mon, Sep 16, 11:45 AM · KWin
romangg updated subscribers of T4440: Render decoration into OpenGL.

@zzag What's your opinion on that? Is this only relevant for Wayland?

Mon, Sep 16, 11:42 AM · KWin
romangg renamed T4440: Render decoration into OpenGL from [kwin] Render decoration into OpenGL to Render decoration into OpenGL.
Mon, Sep 16, 11:42 AM · KWin
romangg added a comment to T4438: Save window buffers to folder.

Would this really be so helpful?

Mon, Sep 16, 11:39 AM · KWin
romangg renamed T4438: Save window buffers to folder from [kwin] Save window buffers to folder to Save window buffers to folder.
Mon, Sep 16, 11:38 AM · KWin
romangg edited projects for T4433: [kwin] Don't load QML packages from $HOME, added: KWin; removed Plasma on Wayland.
Mon, Sep 16, 11:36 AM · KWin
romangg moved T4424: [kwin] Support updateXTime() on Xwayland from Postponed to Peripheral on the Plasma on Wayland board.
Mon, Sep 16, 11:35 AM · Plasma on Wayland
romangg added a comment to T4424: [kwin] Support updateXTime() on Xwayland.

See also D7524.

Mon, Sep 16, 11:35 AM · Plasma on Wayland
romangg moved T4436: [kwin] Non-maximized windows are shown as maximized from Postponed to Done on the Plasma on Wayland board.
Mon, Sep 16, 11:33 AM · KWin, Plasma on Wayland
romangg closed T4436: [kwin] Non-maximized windows are shown as maximized as Resolved.

Have not noticed this problem for ages. Above bugs seem to be closed fixed or not reproducible with latest Qt build.

Mon, Sep 16, 11:33 AM · KWin, Plasma on Wayland
romangg moved T11605: Software rotation from Peripheral to Essential on the Plasma on Wayland board.
Mon, Sep 16, 11:29 AM · Plasma on Wayland
romangg moved T11660: requirements for Krita on plasma wayland from Peripheral to Essential on the Plasma on Wayland board.
Mon, Sep 16, 11:29 AM · Plasma on Wayland
baberts awarded D23986: [plugins/scenes/opengl] Use linear filter on Wayland a Party Time token.
Mon, Sep 16, 11:26 AM · KWin
romangg moved T5709: Multi GPU output support from Essential to Peripheral on the Plasma on Wayland board.
Mon, Sep 16, 11:26 AM · KWin, Plasma on Wayland
romangg moved T4452: [kwayland] Implement Wayland protocol for graphics tablets from Peripheral to Essential on the Plasma on Wayland board.
Mon, Sep 16, 11:26 AM · Plasma on Wayland
romangg moved T5709: Multi GPU output support from Peripheral to Essential on the Plasma on Wayland board.
Mon, Sep 16, 11:26 AM · KWin, Plasma on Wayland
romangg closed T4422: [kwin] Support managing Wayland clients on kwin_x11 as Invalid.

Don't understand what the goal of this task is or how it is supposed to work. Closing as invalid because of that. I somebody can explain pls leave a comment and reopen.

Mon, Sep 16, 11:24 AM · Plasma on Wayland
romangg added a comment to T4443: [kwayland] SubSurface support in Drag'n'Drop.

What test clients there are?

Mon, Sep 16, 11:19 AM · Plasma on Wayland
romangg added a comment to T4442: [kwayland] Touch and SubSurface.

What test clients there are?

Mon, Sep 16, 11:19 AM · Plasma on Wayland
romangg updated subscribers of T4441: [kwin] WindowQuads for SubSurface.

@zzag is this task still pending? Can you add some more detail to the description what it is about?

Mon, Sep 16, 11:15 AM · KWin, Plasma on Wayland
romangg closed T10481: Improve scaled buffer rendering as Resolved.

Forcing linear filter as in D23986 looks to be enough for down-scaling. Mipmaps could still make sense for improving the quality of down-scaling further. For upscaling Lanczos filter could make sense but in perfect conditions there is no upscaling needed on Wayland.

Mon, Sep 16, 11:03 AM · KWin
romangg committed R108:5e1348c4b8f3: [plugins/scenes/opengl] Use linear filter on Wayland (authored by romangg).
[plugins/scenes/opengl] Use linear filter on Wayland
Mon, Sep 16, 11:02 AM
romangg closed D23986: [plugins/scenes/opengl] Use linear filter on Wayland.
Mon, Sep 16, 11:02 AM · KWin
romangg added a task to D23669: Generate mipmaps for image down-scaling: T10481: Improve scaled buffer rendering.
Mon, Sep 16, 10:59 AM · KWin
romangg added a revision to T10481: Improve scaled buffer rendering: D23669: Generate mipmaps for image down-scaling.
Mon, Sep 16, 10:59 AM · KWin
romangg added a revision to T10481: Improve scaled buffer rendering: D23986: [plugins/scenes/opengl] Use linear filter on Wayland.
Mon, Sep 16, 10:55 AM · KWin
romangg added a task to D23986: [plugins/scenes/opengl] Use linear filter on Wayland: T10481: Improve scaled buffer rendering.
Mon, Sep 16, 10:55 AM · KWin
romangg abandoned D23669: Generate mipmaps for image down-scaling.

Replaced by D23986 with only the filter change but without trying to generate mipmaps. Keeping this in diff separated for reference.

Mon, Sep 16, 10:54 AM · KWin
romangg added a comment to D23669: Generate mipmaps for image down-scaling.

Let's do a version with with just the gl_linear patch. As that's the only part running in your testing anyway.

Mon, Sep 16, 10:53 AM · KWin
romangg requested review of D23986: [plugins/scenes/opengl] Use linear filter on Wayland.
Mon, Sep 16, 10:52 AM · KWin
romangg moved T11670: Improve Wayland output rotation from Peripheral to Essential on the Plasma on Wayland board.
Mon, Sep 16, 10:44 AM · Plasma on Wayland, KWin
romangg added a parent task for T11605: Software rotation: T11670: Improve Wayland output rotation.
Mon, Sep 16, 10:43 AM · Plasma on Wayland
romangg added subtasks for T11670: Improve Wayland output rotation: T11605: Software rotation, T11475: Redesign orientation sensor.
Mon, Sep 16, 10:43 AM · Plasma on Wayland, KWin
romangg added a parent task for T11475: Redesign orientation sensor: T11670: Improve Wayland output rotation.
Mon, Sep 16, 10:43 AM · KWin
romangg triaged T11670: Improve Wayland output rotation as High priority.
Mon, Sep 16, 10:43 AM · Plasma on Wayland, KWin
romangg added a comment to T4459: [plasma] Font installation KCM crashes on Wayland.

Is this still relevant? Is the Font installation KCM the same as the Fonts KCM? Fonts KCM doesn't crash for me.

Mon, Sep 16, 10:40 AM · Plasma on Wayland
romangg closed T4429: [kwin] Better announce supported Compositors as Resolved.

Not completely sure about the task description but if I understand it correctly they already do that.

Mon, Sep 16, 10:29 AM · Plasma on Wayland
romangg added a comment to T10016: Improve Wayland zero output handling.

From other task:

But I heard different things about that.

Kwin's internal QPA now fakes having a screen if there's none. Same as the QtWayland and QtXCB QPAs.
It might be enough to close the crashing task.

Mon, Sep 16, 10:26 AM · KWin
romangg closed T4425: [kwin] Add physical size to KWin::Screens as Invalid.

This is an outdated task. The plan is at the moment to remove Screens global.

Mon, Sep 16, 10:23 AM · Plasma on Wayland
romangg moved T4426: [kwin] Scanout wl_buffer in DrmBackend from Postponed to Peripheral on the Plasma on Wayland board.
Mon, Sep 16, 10:21 AM · KWin, Plasma on Wayland
romangg moved T11619: Window Activation from Peripheral to Essential on the Plasma on Wayland board.
Mon, Sep 16, 10:20 AM · Plasma on Wayland
romangg moved T11641: DPMS output workspace size change from Peripheral to Essential on the Plasma on Wayland board.
Mon, Sep 16, 10:18 AM · Plasma on Wayland, KWin

Sun, Sep 15

romangg accepted D23915: Improve documentation.
Sun, Sep 15, 6:56 PM · Frameworks
romangg added a comment to D23415: Improve comprehensibility and consistency of window placement mode names.

This discussion once again consumes everyone's precious time on a minimal change. It needs to come to a conclusion.

Sun, Sep 15, 11:31 AM · Documentation, KWin
romangg accepted D23957: Fix compile failure window variable doesn't exist.
Sun, Sep 15, 10:59 AM · KWin

Sat, Sep 14

romangg added a comment to T11619: Window Activation.

@davidedmundson would be happy to work on this. Do you have the URL to the proposal on the mailing list?

See https://lists.freedesktop.org/archives/wayland-devel/2018-July/038832.html
This link should have been in here long ago for reference.

Where's the best place to get in contact to get this moving (when I have time to)?

Sat, Sep 14, 9:39 PM · Plasma on Wayland
romangg added a comment to D23918: RFC: Drop Outputs class.

In general I agree with @zzag - composition is better than inheritance since it decouples things.

The principle is not in question here. The Outputs child class provides a conversion of QVector used for output-alike classes through constructor-override. It's an implementation detail and to be honest it's a non-issue, not worth our time.

Sat, Sep 14, 9:35 PM · KWin
romangg requested changes to D23581: [platforms/wayland] Make WaylandOutput::init() private.

As already discussed in the other diff I don't want to guess all the time what private fields get manipulated by the backend somewhere. If you want to improve the code make it unnecessary that DrmBackend is friend with DrmOutput, not do it for all the other backends alike.

Sat, Sep 14, 9:19 PM · KWin
romangg requested changes to D23915: Improve documentation.

Title of this diff must be changed before push.

Sat, Sep 14, 9:27 AM · Frameworks
romangg added a comment to D23918: RFC: Drop Outputs class.
In D23918#530689, @zzag wrote:

I haven't received any strong arguments why we need a subclass of QVector<AbstractOutput *>. Outputs overloads constructor to implement some sort of covariance. However, that doesn't qualify as a good argument because the right solution would be to add a helper function that could perform these conversions.

In many cases, inheriting from a vector type is a no-no. You should do that only if there's no any other way around.

You need to provide sources for such generic statements. If you would be a computer science professor of 30 years I would believe them without asking for such but we are not.

Sat, Sep 14, 2:48 AM · KWin
romangg accepted D23921: Pass correct area to placeCascaded in cascadeDesktop.
Sat, Sep 14, 2:20 AM · KWin

Fri, Sep 13

romangg updated subscribers of D23918: RFC: Drop Outputs class.

I don't care either way. @davidedmundson came up with the Output as child of QVector construct. So it's important what he thinks.

Fri, Sep 13, 10:01 AM · KWin
romangg added a comment to D23921: Pass correct area to placeCascaded in cascadeDesktop.

Is this just a code cleanup or also logic change? There is a TODO in there. Overall difficult to review without more explanation.

Fri, Sep 13, 9:55 AM · KWin