- User Since
- Apr 21 2016, 2:20 PM (100 w, 1 d)
Wed, Mar 21
Why did you remove the override specifier? It compiles for me also with them. And they are certainly in no connection to this patch.
We postpone the punctuation and capitalization discussion for now.
Tue, Mar 20
Built it and looks great! :)
I think it is fine as it is now. We won't need it anymore anyway after we can expect Qt 5.11 and then can remove the "hack" again.
Provide a Findgbm.cmake module file. For example https://cgit.kde.org/kwin.git/tree/cmake/modules/Findgbm.cmake
Thanks for the answers. Sounds fine to me. Not sure if we only want to support the portals stuff and by that indirectly make it a standard in a broader sense, but if it works fine for everybody and there are no other solutions available, I'm certainly not against it.
Mon, Mar 19
Could we use a wrapper for QApplication being called by
QApplication app = KWorkSpace::createPlattformAwareQApplication(argc, argv);
and that sets and unsets the env variable in the wrapper call? With above code there might be a copy involved though.
Right it's a pointer array. So detectPlatform would need to do some pointer and memory rearranging, what is not worth the hassle.
KWorkSpace::detectPlatform(argc, argv); is already testing the arguments if --platform flag is set and in this case would do nothing. Therefore I think it's safe to set the flag instead of the env variable as proposed by @fvogt.
- Rename virt_output files to virtual_output
- setVirtualOutputs implementation in cpp
Thanks for your feedback guys. I maybe should have noted that I see the UI more as a placeholder right now and didn't bother about the design. This patch is only about the technical bits. Making the UI beautiful should then go in a separate one ASAP. And I hope someone else might tackle this cause I need to do some KWin work in the imminent future.
Sun, Mar 18
This is supposed to land in 5.12 as well.
Fri, Mar 16
Looking very nice. The hover color in the menu should be #93cee9 (Hover blue).
As a quick fix Dicover on master features contextual menus (the 3 dots) and System settings features a global menu top left. Maybe just take some screenshots of these for now.
There is also a quick tile up, down. Staying consistent and using Meta+↑ for up and Meta+↓ for down tiling would make sense, although minimize and maximize are of course more important. Maybe for minimize we could then use Meta+X and Meta+C, which you can reach just with one hand. Or other suggestions?
Thu, Mar 15
- Fix dummy output creation
Running all tests now show that more of them fail than I predicted. Will investigate this first.
Tue, Mar 13
Do typedefs for KWayland::Server::LinuxDmabuf in files where you use it more than once.
We wait till Xwayland has multi-buffer support to not lead to tearing here. Otherwise it's not really useful since we could use it for games mostly. Mobile in the future might be another use case to save battery.
Mon, Mar 12
Please rebase onto master (or if this leads to problems with your remote merge master).
Sun, Mar 11
Since you haven't yet addressed the punctuation in the bullet points and we use bullet points extensively here and else in the document we should maybe discuss in general how to handle punctuation and capitalization in such lists.
Fri, Mar 9
There is a small thin line at the bottom of Action_Buttons.png. Cut it out? Doesn't look so good.
Wed, Mar 7
Well we need to stop exporting the QT_QPA_PLATFORM value in startup script in any case, right? Or when we depend on Qt 5.11 and then set it to "wayland;x11" does it not break apps depending on Qt 5.y, y<11? So the question is just if we want to wait till we depend on 5.11 with this removal or do it now (and using the helper function proposed in this diff instead).
Hmm, what about application distributed as distro packages? Anyways,if you think this is a non-issue, feel free to push.
You removed accidentally all the other stuff.
Please import the context. This makes reviews more easy. Either via -U99999 flag to git diff or (for future diffs) by using arc directly on a feature branch.
Pls remove the whitespace and rebase your branch on current master (it merges without conflict).
So for an overview we now have:
Shouldn't this function go directly in KWayland as some utily function xdgSessionToQpaPlatform? I believe it's generic enough for that and even though Qt 5.11 will have detection for QT_QPA_PLATFORM the function could be of interest to other apps as well, which can't yet rely on Qt 5.11. In particular of course KDE apps themselves.
- Also change tooltip icon
Rebase on master
- Minor changes proposed by Kai
Rebased on master
Tue, Mar 6
- Comments by Kai
Mon, Mar 5
- [mediacontroller applet] App icon when cover not available