romangg (Roman Gilg)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 21 2016, 2:20 PM (129 w, 5 d)
Availability
Available

Recent Activity

Fri, Oct 12

romangg added a comment to D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required.

The shadows look now better than in the first revision. Still I find the original version with full blur and darkened background way better to read for many background pictures. I don't think it's wort it to sacrifice this usability factor to allow a better view of the background.

Fri, Oct 12, 9:11 AM · Plasma
romangg accepted R108:51a727fc6b06: Send requested size in all configure events.

Fix tested and issues are gone.

Fri, Oct 12, 7:36 AM

Thu, Oct 11

romangg added a comment to R108:51a727fc6b06: Send requested size in all configure events.

Qt 5.11.1

Thu, Oct 11, 5:15 PM
romangg raised a concern with R108:51a727fc6b06: Send requested size in all configure events.

Plasmashell background is black and its surfaces are misplaced with this commit.

Thu, Oct 11, 3:54 PM

Mon, Oct 8

romangg updated the task description for T9815: Improve touch/virtual keyboard.
Mon, Oct 8, 11:30 AM · KWin

Sun, Oct 7

romangg accepted D16023: [colorcorrection] Make GammaRamp non-copyable.
Sun, Oct 7, 5:57 PM · KWin
romangg removed a project from T4465: [kwin] Gamma correction: Plasma (Plasma 5.14).
Sun, Oct 7, 2:07 PM · KWin, Plasma on Wayland
romangg moved T4465: [kwin] Gamma correction from Work In Progress to Backlog on the KWin board.
Sun, Oct 7, 2:06 PM · KWin, Plasma on Wayland
romangg moved T4465: [kwin] Gamma correction from Work In Progress to Backlog on the Plasma on Wayland board.
Sun, Oct 7, 2:06 PM · KWin, Plasma on Wayland
romangg added a comment to T4465: [kwin] Gamma correction.

The patch to KWayland D12388 for arbitrary color curve manipulation has a problem from the start: Wayland protocol messages can only be max 4KB. Sending an array of 256 16bit colors is this. But what if a hardware supports finer curves?

Sun, Oct 7, 2:06 PM · KWin, Plasma on Wayland
romangg triaged T9815: Improve touch/virtual keyboard as Normal priority.
Sun, Oct 7, 2:01 PM · KWin

Wed, Oct 3

romangg accepted D15912: Don't silently error if damage is sent before buffer.

For 5.52.

Wed, Oct 3, 10:38 PM · Frameworks

Tue, Oct 2

romangg requested changes to D15912: Don't silently error if damage is sent before buffer.
Tue, Oct 2, 11:55 PM · Frameworks
romangg updated the diff for D15910: Implement wl_surface::damage_buffer.
  • Remove rects call
  • Respect buffer scale
  • Test damage against scaled surface
Tue, Oct 2, 11:32 PM · Frameworks
romangg added inline comments to D15907: Compare float values in DecorationButton contains check.
Tue, Oct 2, 10:45 PM · Plasma
romangg added inline comments to D15910: Implement wl_surface::damage_buffer.
Tue, Oct 2, 10:38 PM · Frameworks
romangg requested review of D15910: Implement wl_surface::damage_buffer.
Tue, Oct 2, 10:12 PM · Frameworks
romangg requested review of D15907: Compare float values in DecorationButton contains check.
Tue, Oct 2, 8:06 PM · Plasma
romangg added a dependency for D15900: Add unit test for subsurface input mask detection: D7038: [server] Respect input region of sub-surfaces on pointer surface focus.
Tue, Oct 2, 5:17 PM · Frameworks
romangg added a dependent revision for D7038: [server] Respect input region of sub-surfaces on pointer surface focus: D15900: Add unit test for subsurface input mask detection.
Tue, Oct 2, 5:17 PM · Frameworks, Plasma on Wayland
romangg updated the diff for D7038: [server] Respect input region of sub-surfaces on pointer surface focus.
  • Update version number
  • Do code duplication instead of pointers
  • Add comment about code duplication
Tue, Oct 2, 4:12 PM · Frameworks, Plasma on Wayland
romangg updated the diff for D7038: [server] Respect input region of sub-surfaces on pointer surface focus.

Rebase on master.

Tue, Oct 2, 2:37 PM · Frameworks, Plasma on Wayland
romangg added a comment to D15512: [startplasmacompositor] Add Wayland socket argument.

On the other side does it sometimes make sense to specify a port manually even if KWin could take the next free one? I would say yes if I have a client to test against, which I can provide with a socket argument (I don't need to query which free socket actually was taken by KWin). So in the end we want to have both methods anyway.

Tue, Oct 2, 2:16 PM · Plasma
romangg added inline comments to D15735: [effects/wobblywindows] Optimize wobbly windows effect.
Tue, Oct 2, 1:41 PM · KWin
romangg added a comment to D15512: [startplasmacompositor] Add Wayland socket argument.

Is there a real reason against it besides "not necessary"? Maybe that we can't remove the manual override again without breaking some API promise once we have the grand solution of automatically taking the next free Wayland socket?

Tue, Oct 2, 12:52 PM · Plasma
romangg added a comment to T9780: Find/invent interaction pattern for window touch resizing.

There is a much simpler alternative: whether borders are shown or not, when touch input is used to make contact with the screen near a screen edge, make the drag resize areas outside the window as big as the titlebar currently is (it's more or less the bare minimum size for comfortable touch). That way we don't have to answer any of the above questions and it'll behave just like people expect, with the finger basically being a virtual cursor.

Tue, Oct 2, 12:40 PM · KDE Human Interface Guidelines, VDG
romangg added a comment to D15735: [effects/wobblywindows] Optimize wobbly windows effect.

Please add the context. Either by using arc or by supplying git diff the -U99999parameter

Tue, Oct 2, 11:08 AM · KWin
romangg added a comment to D15735: [effects/wobblywindows] Optimize wobbly windows effect.

Optimization can mean many things. That's why I asked. The "+1" should then go in a separate patch.

Tue, Oct 2, 10:10 AM · KWin
romangg added a comment to D15735: [effects/wobblywindows] Optimize wobbly windows effect.

Is this a pure code cleanup, or also includes some logic change?

Tue, Oct 2, 9:23 AM · KWin

Mon, Oct 1

romangg added a comment to D14427: Add .arclint.

@zzag Do you wait for another review by @davidedmundson ?

Mon, Oct 1, 5:54 PM · KWin
romangg added a comment to T9780: Find/invent interaction pattern for window touch resizing.

One idea I had was to start a resize only when two opposing corners are dragged (from the quadrants of their outer most area). But this wouldn't work with windows adjacent to a screen border. Related would be to start a resize when one finger lasts in the window to resize (or its window bar) and a second finger is used for resize somewhere around the window..

Mon, Oct 1, 5:50 PM · KDE Human Interface Guidelines, VDG
romangg accepted D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX.
Mon, Oct 1, 5:43 PM · Frameworks
romangg added a comment to T8707: Window borders.

I created a task for brainstorming a distinct window touch resize interaction pattern: T9780

Mon, Oct 1, 5:10 PM · VDG
romangg triaged T9780: Find/invent interaction pattern for window touch resizing as Normal priority.
Mon, Oct 1, 5:09 PM · KDE Human Interface Guidelines, VDG

Sun, Sep 30

romangg added a comment to D15739: [Places panel] Don't show Root by default.

Imo this patch can go in as it is, but before that I would like to see a patch to have the disk with the root file system getting specially marked (icon, color or text) for the case that several block devices are mounted at the same time.

Sun, Sep 30, 10:38 PM · Frameworks

Mon, Sep 24

romangg added a comment to T8707: Window borders.

No, I don't remember. But I don't think it's really a problem. I have used no window borders setting now for several months and never felt annoyed with the resize area over other windows.

Mon, Sep 24, 8:31 PM · VDG

Fri, Sep 21

romangg added a comment to D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX.

Whoops, yea. My fault. I think it's fine to replace the name, since Qt/GTK use the correct one and normally apps use these libs instead of setting such properties directly.

Fri, Sep 21, 11:54 AM · Frameworks
romangg added a comment to D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX.
In D15353#323028, @zzag wrote:

I'm not a KWindowSystem developer so take this with a grain of salt, but maybe it makes sense to still support the old name in case someone is really using it and add the new one as a synonym?

Well, no, _NET_WM_WINDOW_TYPE_COMBOBOX is a KWindowSystem's specific implementation thing/typo, it's not used widely. GTK+ and Qt set _NET_WM_WINDOW_TYPE_COMBO. So, I think we shouldn't add a new synonym.

Fri, Sep 21, 11:30 AM · Frameworks

Thu, Sep 20

romangg moved T4611: Drag and drop from XWayland to Wayland windows and vice versa from Work In Progress to Under Review on the KWin board.
Thu, Sep 20, 10:43 PM · KWin, Plasma on Wayland
romangg moved T4611: Drag and drop from XWayland to Wayland windows and vice versa from Work In Progress to Under Review on the Plasma on Wayland board.
Thu, Sep 20, 10:43 PM · KWin, Plasma on Wayland
romangg added a revision to T4611: Drag and drop from XWayland to Wayland windows and vice versa: D15627: [xwl] Drag and drop between Xwayland and Wayland native clients.
Thu, Sep 20, 10:43 PM · KWin, Plasma on Wayland
romangg added a task to D15627: [xwl] Drag and drop between Xwayland and Wayland native clients: T4611: Drag and drop from XWayland to Wayland windows and vice versa.
Thu, Sep 20, 10:43 PM
romangg added a dependency for D15629: [xwl] text/x-uri converter for selected X url list format targets: D15627: [xwl] Drag and drop between Xwayland and Wayland native clients.
Thu, Sep 20, 9:59 PM · KWin
romangg added a dependent revision for D15627: [xwl] Drag and drop between Xwayland and Wayland native clients: D15629: [xwl] text/x-uri converter for selected X url list format targets.
Thu, Sep 20, 9:59 PM
romangg requested review of D15629: [xwl] text/x-uri converter for selected X url list format targets.
Thu, Sep 20, 9:58 PM · KWin
romangg added a dependent revision for D15627: [xwl] Drag and drop between Xwayland and Wayland native clients: D15628: [xwl] Support stack optimizing X drag source clients.
Thu, Sep 20, 9:40 PM
romangg added a dependency for D15628: [xwl] Support stack optimizing X drag source clients: D15627: [xwl] Drag and drop between Xwayland and Wayland native clients.
Thu, Sep 20, 9:40 PM · KWin
romangg requested review of D15628: [xwl] Support stack optimizing X drag source clients.
Thu, Sep 20, 9:39 PM · KWin
romangg added a dependent revision for D15419: [xwl] Add Xwayland interface class: D15627: [xwl] Drag and drop between Xwayland and Wayland native clients.
Thu, Sep 20, 9:32 PM · KWin
romangg added a dependent revision for D15421: [server] Add surface data proxy mechanism: D15627: [xwl] Drag and drop between Xwayland and Wayland native clients.
Thu, Sep 20, 9:32 PM · Frameworks
romangg added dependencies for D15627: [xwl] Drag and drop between Xwayland and Wayland native clients: D15419: [xwl] Add Xwayland interface class, D15421: [server] Add surface data proxy mechanism.
Thu, Sep 20, 9:32 PM
romangg requested review of D15627: [xwl] Drag and drop between Xwayland and Wayland native clients.
Thu, Sep 20, 9:28 PM
romangg updated the diff for D15419: [xwl] Add Xwayland interface class.

Rebase on master.

Thu, Sep 20, 9:17 PM · KWin
romangg updated the diff for D15063: Remove X clipboard sync helper and rename its autotest.

Rebase on master.

Thu, Sep 20, 9:14 PM · KWin
romangg updated the diff for D15061: [xwl] Generic X selections translation mechanism with Clipboard support.

Rebase on master.

Thu, Sep 20, 9:10 PM · KWin
romangg updated the diff for D15022: [autotests] Use Xwayland class in WaylandTestApplication.

Rebase on master.

Thu, Sep 20, 8:54 PM · KWin
romangg updated the diff for D15020: [xwl] Move Xwayland parts into separate class.

Rebase on master.

Thu, Sep 20, 8:42 PM · KWin
romangg added a comment to D15194: Draw a line separating PlasmaComponents tab bar from its content area.

If there are more items than space available in the list a line is drawn already now to indicate that there are more items to come by scrolling down. Does this not conflict with the new line?

Thu, Sep 20, 5:28 AM · Frameworks

Wed, Sep 19

romangg added a dependent revision for D15595: Rework InputDeviceHandler focus tracking: D15466: Add Wayland touch drag and drop support.
Wed, Sep 19, 12:42 AM · KWin
romangg added a dependency for D15466: Add Wayland touch drag and drop support: D15595: Rework InputDeviceHandler focus tracking.
Wed, Sep 19, 12:42 AM · KWin
romangg updated the diff for D15466: Add Wayland touch drag and drop support.

Rebase on InputDeviceHandler focus tracking rework.

Wed, Sep 19, 12:41 AM · KWin
Restricted Application added a project to D15595: Rework InputDeviceHandler focus tracking: KWin.
Wed, Sep 19, 12:38 AM · KWin
romangg updated the diff for D15464: [server] Touch drag support.
  • Fix id setting and cancel touch drags
  • Reapply position of first touch on drag
Wed, Sep 19, 12:34 AM · Frameworks
romangg added inline comments to D15464: [server] Touch drag support.
Wed, Sep 19, 12:33 AM · Frameworks

Tue, Sep 18

romangg updated the diff for D15443: [server] Allow multiple touch interfaces per client.

Do not forget id equals 0 check and add assert.

Tue, Sep 18, 8:16 PM · Frameworks
romangg added inline comments to D15443: [server] Allow multiple touch interfaces per client.
Tue, Sep 18, 8:15 PM · Frameworks
romangg committed R127:3cf4825c8050: [server] Do not return early on fail in touchDown fall back code (authored by romangg).
[server] Do not return early on fail in touchDown fall back code
Tue, Sep 18, 7:56 PM
romangg closed D15468: [server] Do not return early on fail in touchDown fall back code.
Tue, Sep 18, 7:56 PM · Frameworks
romangg added a comment to D15595: Rework InputDeviceHandler focus tracking.

Some more explanation:

Tue, Sep 18, 7:31 PM · KWin
romangg added a dependency for D15595: Rework InputDeviceHandler focus tracking: D15519: Privatize variables in InputDeviceHandler.
Tue, Sep 18, 7:16 PM · KWin
romangg added a dependent revision for D15519: Privatize variables in InputDeviceHandler: D15595: Rework InputDeviceHandler focus tracking.
Tue, Sep 18, 7:16 PM · KWin
romangg requested review of D15595: Rework InputDeviceHandler focus tracking.
Tue, Sep 18, 7:15 PM · KWin
romangg added a comment to T9467: Akademy Promo Post Mortem.
In T9467#160448, @paulb wrote:

This task is not about a general post mortem of Akademy, but more about Promo's activities at Akademy. Can we please restrict the conversation to that?

Tue, Sep 18, 5:49 PM · KDE Promo
romangg added a comment to D15502: Float position values in drag input filter.

Yeah, i see they are in sync but if someone sends adjustment events who contain not a *real* mouse position like these https://phabricator.kde.org/source/plasma-workspace/browse/master/shell/panelview.cpp$839 Is this can be a problem>

Tue, Sep 18, 2:24 PM · KWin
romangg added a comment to D15502: Float position values in drag input filter.

I saw one potential problem, you can clarify if it's relevant. If event is someone that resend with different position that current one, as i can see input()->globalPointer() will result in current position which can be different from event position, do you think?

Tue, Sep 18, 1:12 PM · KWin

Mon, Sep 17

romangg added a comment to T9467: Akademy Promo Post Mortem.

I wrote a blog post about stuff I liked at Akademy and what I think could be improved. Short summary of what I think could be improved:

Mon, Sep 17, 6:27 PM · KDE Promo
romangg accepted D15150: [wayland] Asyncronously update maximise flags.
Mon, Sep 17, 5:15 PM · KWin

Sep 17 2018

romangg committed R108:ff6e9c3b9235: Define ShellClient debug output (authored by romangg).
Define ShellClient debug output
Sep 17 2018, 2:11 AM
romangg closed D15560: Define ShellClient debug output.
Sep 17 2018, 2:11 AM · KWin

Sep 16 2018

romangg requested review of D15560: Define ShellClient debug output.
Sep 16 2018, 8:48 PM · KWin

Sep 15 2018

romangg added a dependency for D15519: Privatize variables in InputDeviceHandler: D15502: Float position values in drag input filter.
Sep 15 2018, 12:43 AM · KWin
romangg added a dependent revision for D15502: Float position values in drag input filter: D15519: Privatize variables in InputDeviceHandler.
Sep 15 2018, 12:43 AM · KWin
romangg requested review of D15519: Privatize variables in InputDeviceHandler.
Sep 15 2018, 12:41 AM · KWin

Sep 14 2018

romangg added a comment to D15512: [startplasmacompositor] Add Wayland socket argument.

I'm against this - kwin_wayland should just pick the next available socket if wayland-0 is not available. That's also what Xorg does and is IMO the expected behaviour.

Sep 14 2018, 7:12 PM · Plasma
romangg requested review of D15512: [startplasmacompositor] Add Wayland socket argument.
Sep 14 2018, 7:05 PM · Plasma
romangg added a comment to D15502: Float position values in drag input filter.

Also removes an unnecessary second call to SeatInterface::setPointerPos.

Sep 14 2018, 10:59 AM · KWin
romangg requested review of D15502: Float position values in drag input filter.
Sep 14 2018, 10:58 AM · KWin
romangg added a comment to D7038: [server] Respect input region of sub-surfaces on pointer surface focus.

I like that refactoring 👍 - though processAt might not be the best fitting name. Don't have a good name idea, maybe findChildSurfaceAt?

Sep 14 2018, 10:13 AM · Frameworks, Plasma on Wayland

Sep 13 2018

romangg added a comment to D15135: [wayland] Syncronise pending geometry with acked configure requests.

That's over complicating something that really doesn't need it.
XdgShellInterface in frameworks will raise an error if serials are super wrong.

Sep 13 2018, 7:53 PM · KWin
romangg added a comment to D15150: [wayland] Asyncronously update maximise flags.

Looking at the code this patch is based on the changes in D15135. Please add it as parent revision.

Sep 13 2018, 5:39 PM · KWin
romangg accepted D15135: [wayland] Syncronise pending geometry with acked configure requests.

It's missing still a cleanup in case the client is broken as in not responding to any configure events or with the wrong serials and the vector would grow limitless. But we can do this in a second patch.

Sep 13 2018, 5:35 PM · KWin
romangg added a comment to D15480: [wayland] Dismiss popups when they lose focus.

The decision to dismiss popups when a click is registered on a different surface of the same client is responsibility of the client. To fix Plasma in this regard one would need to do this somewhere in Plasma shell or frameworks therefore and not in KWin. But there a fix is badly needed for sure.

Sep 13 2018, 4:17 PM · KWin
romangg added inline comments to D15135: [wayland] Syncronise pending geometry with acked configure requests.
Sep 13 2018, 4:04 PM · KWin
romangg added inline comments to D15135: [wayland] Syncronise pending geometry with acked configure requests.
Sep 13 2018, 3:16 PM · KWin
romangg requested changes to D15135: [wayland] Syncronise pending geometry with acked configure requests.

A surface represents the last configure that was acked.

Sep 13 2018, 2:53 PM · KWin
romangg moved T4611: Drag and drop from XWayland to Wayland windows and vice versa from Backlog to Work In Progress on the KWin board.
Sep 13 2018, 12:55 PM · KWin, Plasma on Wayland
romangg added a project to T4611: Drag and drop from XWayland to Wayland windows and vice versa: KWin.
Sep 13 2018, 12:55 PM · KWin, Plasma on Wayland
romangg requested review of D15468: [server] Do not return early on fail in touchDown fall back code.
Sep 13 2018, 8:17 AM · Frameworks
romangg updated the summary of D15443: [server] Allow multiple touch interfaces per client.
Sep 13 2018, 8:09 AM · Frameworks
romangg updated the summary of D15443: [server] Allow multiple touch interfaces per client.
Sep 13 2018, 8:09 AM · Frameworks