romangg (Roman Gilg)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 21 2016, 2:20 PM (195 w, 4 d)
Availability
Available

Recent Activity

Thu, Jan 16

romangg committed R110:8cd7ff9f06be: Merge branch 'Plasma/5.18' (authored by romangg).
Merge branch 'Plasma/5.18'
Thu, Jan 16, 1:26 PM
romangg committed R110:13b631eabb98: fix(kwayland): move blocking tablet init before timer start (authored by romangg).
fix(kwayland): move blocking tablet init before timer start
Thu, Jan 16, 1:23 PM
romangg closed D26658: fix(kwayland): move blocking tablet init before timer start.
Thu, Jan 16, 1:23 PM · Plasma
romangg committed R108:b8b9f78b37d7: Revert "[platforms/x11] Remove triple buffering detection" (authored by romangg).
Revert "[platforms/x11] Remove triple buffering detection"
Thu, Jan 16, 9:07 AM
romangg added a reverting change for R108:ad892ce3a65e: [platforms/x11] Remove triple buffering detection: R108:b8b9f78b37d7: Revert "[platforms/x11] Remove triple buffering detection".
Thu, Jan 16, 9:07 AM
romangg added a reverting change for R108:285adc1950c9: [platforms/x11/standalone] Remove SGI swap control and video sync: R108:a15624dcc5fe: Revert "[platforms/x11/standalone] Remove SGI swap control and video sync".
Thu, Jan 16, 9:07 AM
romangg committed R108:a15624dcc5fe: Revert "[platforms/x11/standalone] Remove SGI swap control and video sync" (authored by romangg).
Revert "[platforms/x11/standalone] Remove SGI swap control and video sync"
Thu, Jan 16, 9:07 AM
romangg added a reverting change for R108:b3a19f9e5b77: Remove vsync detection and configurability: R108:bcf64af49bd9: Revert "Remove vsync detection and configurability".
Thu, Jan 16, 9:07 AM
romangg committed R108:bcf64af49bd9: Revert "Remove vsync detection and configurability" (authored by romangg).
Revert "Remove vsync detection and configurability"
Thu, Jan 16, 9:07 AM
romangg committed R108:ac05dd01c84a: Revert "[platforms/x11] Never block on retrace, always present after paint" (authored by romangg).
Revert "[platforms/x11] Never block on retrace, always present after paint"
Thu, Jan 16, 9:07 AM
romangg added a reverting change for R108:8d137290317a: [platforms/x11] Never block on retrace, always present after paint: R108:ac05dd01c84a: Revert "[platforms/x11] Never block on retrace, always present after paint".
Thu, Jan 16, 9:07 AM
romangg committed R108:b972159ddfa6: Revert "Add hasSwapEvent getter" (authored by romangg).
Revert "Add hasSwapEvent getter"
Thu, Jan 16, 9:07 AM
romangg added a reverting change for R108:a55dee3bd329: Add hasSwapEvent getter: R108:b972159ddfa6: Revert "Add hasSwapEvent getter".
Thu, Jan 16, 9:07 AM
romangg committed R108:fbb7c241c748: Revert "Composite without timer on swap events" (authored by romangg).
Revert "Composite without timer on swap events"
Thu, Jan 16, 9:07 AM
romangg added a reverting change for R108:00bf75d06e67: Composite without timer on swap events: R108:fbb7c241c748: Revert "Composite without timer on swap events".
Thu, Jan 16, 9:07 AM
romangg added a reverting change for R108:e7da4d65ecbd: [platforms/x11/standalone] Use intel swap events by default: R108:14702651b37e: Revert "[platforms/x11/standalone] Use intel swap events by default".
Thu, Jan 16, 9:07 AM
romangg committed R108:14702651b37e: Revert "[platforms/x11/standalone] Use intel swap events by default" (authored by romangg).
Revert "[platforms/x11/standalone] Use intel swap events by default"
Thu, Jan 16, 9:07 AM
romangg committed R108:63898fc5698d: Revert "Reset buffer swap state on stop" (authored by romangg).
Revert "Reset buffer swap state on stop"
Thu, Jan 16, 9:07 AM
romangg added a reverting change for R108:ba2c0324d2ef: Reset buffer swap state on stop: R108:63898fc5698d: Revert "Reset buffer swap state on stop".
Thu, Jan 16, 9:07 AM
romangg committed R108:2dabd0b11261: Revert "Fix buffer swap assert" (authored by romangg).
Revert "Fix buffer swap assert"
Thu, Jan 16, 9:07 AM
romangg added a reverting change for R108:be01ba0ae7c6: Fix buffer swap assert: R108:2dabd0b11261: Revert "Fix buffer swap assert".
Thu, Jan 16, 9:07 AM
romangg committed R108:a5c2f23e92b1: Revert "Flexible composite swap and timer events" (authored by romangg).
Revert "Flexible composite swap and timer events"
Thu, Jan 16, 9:07 AM
romangg added a reverting change for R108:1e3128b0db89: Flexible composite swap and timer events: R108:a5c2f23e92b1: Revert "Flexible composite swap and timer events".
Thu, Jan 16, 9:07 AM
romangg added a reverting change for R108:af3fbf343bb2: Remove buffer flip pending assert for now: R108:396ef7100ea3: Revert "Remove buffer flip pending assert for now".
Thu, Jan 16, 9:07 AM
romangg committed R108:396ef7100ea3: Revert "Remove buffer flip pending assert for now" (authored by romangg).
Revert "Remove buffer flip pending assert for now"
Thu, Jan 16, 9:07 AM

Wed, Jan 15

romangg accepted D26681: [TabBox] Thumbnail Grid window switcher.
Wed, Jan 15, 11:53 PM · Plasma
romangg updated the summary of D26658: fix(kwayland): move blocking tablet init before timer start.
Wed, Jan 15, 3:55 PM · Plasma
romangg updated the diff for D26658: fix(kwayland): move blocking tablet init before timer start.
  • Init tablet before starting KWayland timer
Wed, Jan 15, 3:50 PM · Plasma
romangg committed R104:039337cd3b1a: feat(kcm): add option for auto rotation (authored by romangg).
feat(kcm): add option for auto rotation
Wed, Jan 15, 2:38 PM
romangg closed D26038: feat(kcm): add option for auto rotation.
Wed, Jan 15, 2:38 PM · Plasma
romangg committed R104:8032881459d1: feat(kded): add orientation sensor (authored by romangg).
feat(kded): add orientation sensor
Wed, Jan 15, 2:38 PM
romangg closed D26037: feat(kded): add orientation sensor.
Wed, Jan 15, 2:38 PM · Plasma
romangg updated the summary of D26037: feat(kded): add orientation sensor.
Wed, Jan 15, 1:55 PM · Plasma
romangg removed a dependent revision for D26036: Remove orientation sensor: D26037: feat(kded): add orientation sensor.
Wed, Jan 15, 1:54 PM
romangg removed a dependency for D26037: feat(kded): add orientation sensor: D26036: Remove orientation sensor.
Wed, Jan 15, 1:54 PM · Plasma
romangg requested changes to D26681: [TabBox] Thumbnail Grid window switcher.

Nice. Let's fix these few issues and get it merged before tomorrow. Other small issues can be fixed in beta phase.

Wed, Jan 15, 1:26 PM · Plasma

Tue, Jan 14

romangg requested review of D26658: fix(kwayland): move blocking tablet init before timer start.
Tue, Jan 14, 12:10 PM · Plasma
romangg added a comment to D24281: Add default shortcut to switch to the desktop to the left/right/top/bottom.

I had already stated my opinion numerous times here in lengthy explanations and said that I don't want to continue this discussion. And my opinion has not changed. I am working on other stuff as well as you might know and don't have time for these immensely frustrating and pointless opinion battles just because KWin is a headless project with multi-stakeholders having all kinds of say into what it should maybe be or not be.

Tue, Jan 14, 11:05 AM · KWin

Mon, Jan 13

romangg updated the task description for T11520: Improve keyboard shortcuts, standardization, RSI preventability.
Mon, Jan 13, 6:12 PM · Goal: Consistency, Plasma Accessibility

Fri, Jan 10

romangg updated the diff for D26037: feat(kded): add orientation sensor.
  • Fix seg fault on orientation sensor
Fri, Jan 10, 11:12 AM · Plasma

Thu, Jan 9

romangg accepted D26553: [colormanager] Fix build on older glib.
Thu, Jan 9, 8:56 PM · KWin
romangg updated the diff for D26038: feat(kcm): add option for auto rotation.

Rebase on series changes.

Thu, Jan 9, 6:58 PM · Plasma
romangg updated the diff for D26037: feat(kded): add orientation sensor.
  • Use connectedToBackend getter
  • Replace DeviceOrientation
Thu, Jan 9, 6:55 PM · Plasma
romangg updated the diff for D26038: feat(kcm): add option for auto rotation.

Rebase on master.

Thu, Jan 9, 6:33 PM · Plasma
romangg updated the diff for D26037: feat(kded): add orientation sensor.

Rebase on master.

Thu, Jan 9, 6:24 PM · Plasma
romangg accepted D26542: Return correct shape for Unmanaged clients.
Thu, Jan 9, 12:56 PM · KWin
romangg added a task to D26308: Set output device's logical size: T11222: Reimagine output cloning.
Thu, Jan 9, 12:36 PM · Frameworks
romangg added a revision to T11222: Reimagine output cloning: D26308: Set output device's logical size.
Thu, Jan 9, 12:36 PM · VDG, Plasma

Wed, Jan 8

romangg closed T10016: Improve Wayland zero output handling as Resolved.
Wed, Jan 8, 9:21 AM · KWin
romangg added inline comments to D26037: feat(kded): add orientation sensor.
Wed, Jan 8, 9:21 AM · Plasma
romangg abandoned D17985: [platforms/drm] Mark outputs as disabled if we don't have any outputs.

Superseded with D26511.

Wed, Jan 8, 9:13 AM · KWin
romangg commandeered D17985: [platforms/drm] Mark outputs as disabled if we don't have any outputs.
Wed, Jan 8, 9:12 AM · KWin
romangg committed R108:2632e4182c65: [platforms/drm] Allow running without outputs (authored by romangg).
[platforms/drm] Allow running without outputs
Wed, Jan 8, 9:12 AM
romangg closed D26511: [platforms/drm] Allow running without outputs.
Wed, Jan 8, 9:12 AM · KWin
romangg added a reverting change for R104:6971b0a578d5: addVersionOption()/addHelpOption() already adds by KAboutData…: R104:ae5ba86821fc: Revert "addVersionOption()/addHelpOption() already adds by KAboutData….
Wed, Jan 8, 9:08 AM
romangg committed R104:ae5ba86821fc: Revert "addVersionOption()/addHelpOption() already adds by KAboutData… (authored by romangg).
Revert "addVersionOption()/addHelpOption() already adds by KAboutData…
Wed, Jan 8, 9:08 AM
romangg retitled D26511: [platforms/drm] Allow running without outputs from [platforms/drm] allow running without outputs to [platforms/drm] Allow running without outputs.
Wed, Jan 8, 2:07 AM · KWin
romangg moved T11641: DPMS output workspace size change from Essential to Done on the Plasma on Wayland board.
Wed, Jan 8, 12:37 AM · Plasma on Wayland, KWin
romangg closed T11641: DPMS output workspace size change as Invalid.

I tested this some more and it seems to actually work fine and the issue I saw was only with one specific monitor that does not disconnect correctly when switching off, which is then not a software issue.

Wed, Jan 8, 12:37 AM · Plasma on Wayland, KWin
romangg closed T11641: DPMS output workspace size change, a subtask of T11081: Finalize the transition to Wayland and embrace the future of desktop, as Invalid.
Wed, Jan 8, 12:37 AM · Goal Setting 2019
romangg updated the summary of D26511: [platforms/drm] Allow running without outputs.
Wed, Jan 8, 12:25 AM · KWin
romangg added a revision to T10016: Improve Wayland zero output handling: D26511: [platforms/drm] Allow running without outputs.
Wed, Jan 8, 12:23 AM · KWin
romangg added a task to D26511: [platforms/drm] Allow running without outputs: T10016: Improve Wayland zero output handling.
Wed, Jan 8, 12:23 AM · KWin
romangg updated the test plan for D26511: [platforms/drm] Allow running without outputs.
Wed, Jan 8, 12:23 AM · KWin
romangg requested review of D26511: [platforms/drm] Allow running without outputs.
Wed, Jan 8, 12:19 AM · KWin

Tue, Jan 7

romangg added a comment to D26038: feat(kcm): add option for auto rotation.

Note: For testing you need the patches in KWin applied and add in libkscreen in the KWayland backend the features flags for auto rotation and tablet mode detection.

Tue, Jan 7, 10:52 PM · Plasma
romangg accepted D26508: Use geometry conversion helpers from AbstractClient in InternalClient.
Tue, Jan 7, 10:30 PM · KWin
romangg added a comment to D26038: feat(kcm): add option for auto rotation.

Does this need testing on hardware at this point or has that been done?

Tue, Jan 7, 10:26 PM · Plasma
romangg committed R110:05e361e5f63f: fix(randr): make sure crtc exists (authored by romangg).
fix(randr): make sure crtc exists
Tue, Jan 7, 6:28 PM
romangg added inline comments to D25904: [libkwineffects] Set original backend framebuffer for render targets.
Tue, Jan 7, 5:40 PM · KWin
romangg updated the diff for D25904: [libkwineffects] Set original backend framebuffer for render targets.
  • Rename framebuffer setter
Tue, Jan 7, 5:38 PM · KWin
romangg updated the diff for D25906: [platforms/drm] Add hardware transformation API.
  • Fix names
Tue, Jan 7, 4:29 PM · KWin
romangg added a comment to D26310: feat: use Control and logical size APIs for replicas.

I missed to update the test plan. So for reference: this is at it landed unrelated to Wayland and instead altering the behavior on X11. This should make the saving and loading of replications there more robust.

Tue, Jan 7, 3:53 PM · Plasma
romangg added inline comments to D25906: [platforms/drm] Add hardware transformation API.
Tue, Jan 7, 3:49 PM · KWin
romangg committed R104:a5c4e9906322: feat(kcm): control scale (authored by romangg).
feat(kcm): control scale
Tue, Jan 7, 3:10 PM
romangg closed D26481: feat(kcm): control scale.
Tue, Jan 7, 3:10 PM · Plasma
romangg committed R110:50969ab6cbb7: feat: add auto rotate and tablet mode information (authored by romangg).
feat: add auto rotate and tablet mode information
Tue, Jan 7, 3:08 PM
romangg closed D26281: feat: add auto rotate and tablet mode information.
Tue, Jan 7, 3:08 PM · Plasma
romangg committed R104:b3a8dbbbb590: feat: use Control and logical size APIs for replicas (authored by romangg).
feat: use Control and logical size APIs for replicas
Tue, Jan 7, 3:04 PM
romangg closed D26310: feat: use Control and logical size APIs for replicas.
Tue, Jan 7, 3:04 PM · Plasma
romangg committed R104:19e6756fc1ae: feat: control replication (authored by romangg).
feat: control replication
Tue, Jan 7, 2:58 PM
romangg closed D26220: feat: control replication.
Tue, Jan 7, 2:58 PM · Plasma
romangg committed R110:6a5a180bbedf: feat: replace replication source with logical size API (authored by romangg).
feat: replace replication source with logical size API
Tue, Jan 7, 2:56 PM
romangg closed D26309: feat: replace replication source with logical size API.
Tue, Jan 7, 2:56 PM · Plasma
romangg added a dependency for D26481: feat(kcm): control scale: D26310: feat: use Control and logical size APIs for replicas.
Tue, Jan 7, 12:20 AM · Plasma
romangg added a dependent revision for D26310: feat: use Control and logical size APIs for replicas: D26481: feat(kcm): control scale.
Tue, Jan 7, 12:20 AM · Plasma
romangg requested review of D26481: feat(kcm): control scale.
Tue, Jan 7, 12:20 AM · Plasma

Mon, Jan 6

romangg removed a dependent revision for D26308: Set output device's logical size: D26309: feat: replace replication source with logical size API.
Mon, Jan 6, 9:29 PM · Frameworks
romangg removed a dependency for D26309: feat: replace replication source with logical size API: D26308: Set output device's logical size.
Mon, Jan 6, 9:29 PM · Plasma
romangg added a comment to D25907: [platforms/drm] Introduce Gl post-process output rotations.

I'm happy to accept this if we include D26371.

IMHO easiest is for @romangg to grab that and squash in here so history is cleanest but we can do whatever works

Mon, Jan 6, 8:52 PM · KWin
romangg updated the summary of D26309: feat: replace replication source with logical size API.
Mon, Jan 6, 2:17 PM · Plasma
romangg updated the diff for D26309: feat: replace replication source with logical size API.
  • Remove support in Wayland backend
  • Add support in RandR backend
Mon, Jan 6, 2:14 PM · Plasma

Fri, Jan 3

romangg updated the diff for D26173: WIP: [xwl] Emulate resolution changes.
  • Discard shape on XWayland surface size change
Fri, Jan 3, 6:05 PM · KWin

Thu, Jan 2

romangg added a comment to D26311: Handle output logical size changes.

Forget 2 outputs, this spec falls apart on simple scenarios.

I have a 1920x1080 monitor, I want it cropped to 1000x1000 physical pixels that represent 1000x1000 logical pixels
I have a 1920x1080 monitor, I want it cropped to 1000x1000 physical pixels that represent 500x500 logical pixels

we can't do either.

Thu, Jan 2, 10:49 PM · KWin
romangg added inline comments to D26172: Add wp_viewporter support.
Thu, Jan 2, 6:21 PM · KWin
romangg updated the diff for D26172: Add wp_viewporter support.
  • Fix Chromium in OpenGl
  • Fix decorations in QPainter
Thu, Jan 2, 6:21 PM · KWin
romangg updated the diff for D26308: Set output device's logical size.
  • Add autotest
  • Cleanup
Thu, Jan 2, 2:06 PM · Frameworks

Wed, Jan 1

romangg added a comment to D26172: Add wp_viewporter support.

What's our plan for deleted windows?

I suspect right now once a window close animation starts the buffer will suddenly jump to be the uncropped version.

Wed, Jan 1, 8:41 PM · KWin
romangg updated the diff for D26172: Add wp_viewporter support.
  • Rebase on series changes
Wed, Jan 1, 8:41 PM · KWin
romangg updated the diff for D26171: Implement wp_viewporter.
  • Cleanup
Wed, Jan 1, 8:38 PM · Frameworks