romangg (Roman Gilg)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 21 2016, 2:20 PM (156 w, 2 d)
Availability
Available

Recent Activity

Sat, Apr 13

romangg accepted D18824: Implement wl_eglstream_controller Server Interface.

Thanks. Don't forget to add the isValid check to the KWin patches now. Maybe also add a comment to the KWayland code, what's the reason for the separate create() call and that we want to change this in KF6 via a virtualized create method.

Sat, Apr 13, 5:46 PM · Frameworks

Fri, Apr 12

romangg added a comment to D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.

Nice work. Most of the stuff in libinputtouchpad.cpp and its header file are copy-paste from the Wayland backend. It would make sense to have a new abstract parent class such that the code is shared.

Initially, I also wanted to implement it that way, but it'll mess up existing code, and especially because LibinputTouchpad class already extends XlibTouchpad class. Or split out the common parts into a helper-class.

Can it multi-inherit?

Fri, Apr 12, 10:13 AM · Plasma
romangg added a comment to D18824: Implement wl_eglstream_controller Server Interface.

The xml file is missing form the diff now. Don't forget to add it when pushing.

Fri, Apr 12, 10:08 AM · Frameworks

Tue, Apr 9

romangg added a comment to T10040: add keepassxc to neon image.

Note that keepassx != keepassxc.

Tue, Apr 9, 1:22 PM · Neon

Fri, Apr 5

romangg added a comment to D20066: Use Meta+D to Show Desktop by default.

Thanks. Having a two-level structure with system defaults (that can get updated via new versions) and static user-overrides would be nice, but I assume it's not easy to do with KGlobalaccel or a "replacement"?

Fri, Apr 5, 11:30 AM · KWin
romangg added a comment to D20066: Use Meta+D to Show Desktop by default.

You are aware that kglobalaccel doesn't support removing global shortcuts?

Fri, Apr 5, 10:23 AM · KWin

Thu, Apr 4

romangg requested changes to D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.

Nice work. Most of the stuff in libinputtouchpad.cpp and its header file are copy-paste from the Wayland backend. It would make sense to have a new abstract parent class such that the code is shared.

Thu, Apr 4, 11:25 PM · Plasma

Mar 20 2019

romangg accepted R108:6bc2ddd56a09: virtualkeyboard: resize the focused window to make room for the keyboard.

Fixed with 1f3fd6379079

Mar 20 2019, 7:09 PM
romangg committed R108:7b13393b647c: [platforms/wayland] Multi output support (authored by romangg).
[platforms/wayland] Multi output support
Mar 20 2019, 1:43 PM
romangg closed D18465: [platforms/wayland] Multi output support.
Mar 20 2019, 1:43 PM · KWin
romangg updated the diff for D18465: [platforms/wayland] Multi output support.
  • Rebase on master
Mar 20 2019, 1:40 PM · KWin
romangg raised a concern with R108:6bc2ddd56a09: virtualkeyboard: resize the focused window to make room for the keyboard.
Mar 20 2019, 1:38 PM

Mar 13 2019

romangg added a comment to D13284: [decorations] Let KDecoration plugins recommend a border size per default.

@romangg, any chance you'd like to rebase the patch on current master and proceed with review?

Mar 13 2019, 10:29 PM · KWin

Mar 12 2019

romangg accepted D18570: EGLStream DRM Backend Initial Implementation.

Without going through it in detail the overall structure looks really nice now. I'm really happy with the integration in the new version, in particular that our normal AMS code path is used for mode switching. Wait for another +1 by someone who can test it on a live system. But from my side it's good to go.

Mar 12 2019, 8:47 PM · KWin

Feb 25 2019

romangg abandoned D19253: [WIP] Send xdg_output done event only when wl_output does too.

Superseded by D19255.

Feb 25 2019, 5:21 PM · KWin
romangg abandoned D15907: Compare float values in DecorationButton contains check.

No, it wouldn't. But you know what, fix your faulty patches yourselves. I have enough time wasted on this super-small issue. Get your priorities straight!

Feb 25 2019, 2:52 PM · Plasma
romangg added a comment to D19296: Allow to set quarter tiling separately.

What's the use case? Why would someone want to enable only half tiling, but not quarter tiling?

Feb 25 2019, 10:42 AM · KWin

Feb 24 2019

romangg added a comment to D18656: [wayland] Send correct current time in the frame callback.

Ok, maybe then change the wording in the paragraph a bit on comit. To me it sounded like there is still a problem going on, but it seems since the variable with improper name has been removed, everything is fine now. Your decision.

Feb 24 2019, 8:59 PM · KWin
romangg added a comment to D19255: Only commit XdgOutput::done if changed.

Maybe add a TODO comment on merge to the setLogicalSize (that it does not handle the size plus scale change correctly in every case).

Can you expand on what you mean?

Feb 24 2019, 8:16 PM · Frameworks
romangg accepted D18656: [wayland] Send correct current time in the frame callback.

Code makes sense, but what exactly do you mean by:

Feb 24 2019, 8:06 PM · KWin
romangg added a comment to D19255: Only commit XdgOutput::done if changed.

Also CCBUG: 400987

Feb 24 2019, 12:25 PM · Frameworks
romangg added a comment to D19255: Only commit XdgOutput::done if changed.

Maybe add a TODO comment on merge to the setLogicalSize (that it does not handle the size plus scale change correctly in every case).

Feb 24 2019, 12:09 PM · Frameworks
romangg accepted D19255: Only commit XdgOutput::done if changed.

I just tested it and it works. As you said in D19253 has same caveat as I pointed out not being in sync with wl_output::done event in case resolution and scale factor change at the same time such that logical size stays the same.

Feb 24 2019, 12:07 PM · Frameworks

Feb 23 2019

romangg requested review of D19262: Delayed focus updates for Toplevels without surface.
Feb 23 2019, 6:36 PM · KWin
romangg added a comment to D19253: [WIP] Send xdg_output done event only when wl_output does too.

Long-term it would be nicer to have the synchronization directly in KWayland,

In terms of long term, I want to have explicit synchronization handled by kwin.
We should expose OutputInterface::done() to be explicit rather than being done implicitly in setBlah. The attempt to make things simpler actually ends up making things a lot harder to do properly.

Feb 23 2019, 3:58 PM · KWin
romangg requested review of D19253: [WIP] Send xdg_output done event only when wl_output does too.

Although this doesn't directly work, I assume because xdg_output property changes can come in on bind, while the wl_output properties are sent explicity. I'm leaving this diff as it is now again up for review, so we can discuss a proper solution. I fear we need to remodel the XdgOutputInterface class completely.

Feb 23 2019, 3:40 PM · KWin
romangg planned changes to D19253: [WIP] Send xdg_output done event only when wl_output does too.

Instead of checking against xdg_output current values, check if wl_output's values have changed resulting in a done event.

Feb 23 2019, 3:05 PM · KWin
romangg requested review of D19253: [WIP] Send xdg_output done event only when wl_output does too.
Feb 23 2019, 3:04 PM · KWin

Feb 22 2019

romangg accepted D19232: [wayland] Keep application startup flow inside main_wayland.

Nicely structured. Great!

Feb 22 2019, 10:43 PM · KWin
romangg updated subscribers of T10503: Define TV IOUP.

@bshah noted that there is prior conceptual work about Plasma on TVs (or in general with only very few inputs) here:
https://docs.google.com/document/d/18B8GfIdLWhceTkdyxs9-I5NPbn4duni-qO8kjX_xzl4/edit#

Feb 22 2019, 12:50 PM · Plasma
romangg updated the diff for D19199: [platforms/fbdev] Port to AbstractOutput.
  • Review comments
Feb 22 2019, 12:18 PM · KWin
romangg added inline comments to D19199: [platforms/fbdev] Port to AbstractOutput.
Feb 22 2019, 12:17 PM · KWin
romangg added a comment to D15910: Implement wl_surface::damage_buffer.

Will be pushed after 5.56 branched off.

Feb 22 2019, 11:51 AM · Frameworks
romangg updated subscribers of D15907: Compare float values in DecorationButton contains check.
In D15907#417286, @zzag wrote:

Alright, I'm done.

Feb 22 2019, 11:48 AM · Plasma
romangg added a comment to D15907: Compare float values in DecorationButton contains check.

QRectF with negative size is untested.

Feb 22 2019, 10:39 AM · Plasma
romangg added inline comments to D18465: [platforms/wayland] Multi output support.
Feb 22 2019, 10:00 AM · KWin
romangg updated the diff for D18465: [platforms/wayland] Multi output support.
  • Rebase on master
  • Review comments
Feb 22 2019, 9:58 AM · KWin
romangg added inline comments to D18465: [platforms/wayland] Multi output support.
Feb 22 2019, 9:00 AM · KWin
romangg added inline comments to D18465: [platforms/wayland] Multi output support.
Feb 22 2019, 8:45 AM · KWin
romangg accepted R108:9b922f88332f: Split out a dedicated InternalClient class.

Tests fixed with e96da56f8ced.

Feb 22 2019, 8:33 AM
romangg added a comment to D15907: Compare float values in DecorationButton contains check.
In D15907#417151, @zzag wrote:

Tests are not less important than the rest of the project. It's not good that we don't care about their readability.

Oh I do care about readability. Did you notice the huge diagram so auto test readers have a picture of what the test is doing?

I'm not convinced by "current autotest fails without the change on current master and works with the patch". Please make the test simpler. I don't think that it will take too much time to reorganize the test table.

What's not to be convinced here? It's a fact, not an argument. No, I won't rewrite the test. If you want the autotest differently, do it yourself.

Feb 22 2019, 12:25 AM · Plasma

Feb 21 2019

romangg raised a concern with R108:9b922f88332f: Split out a dedicated InternalClient class.

27 autotests fail now.

Feb 21 2019, 11:39 PM
romangg added a comment to D15907: Compare float values in DecorationButton contains check.
In D15907#415347, @zzag wrote:

Looks good to me.

I think the test is too much complicated. Would it be simpler to have something like

QTest::addColumn<QRectF>("geometry");
QTest::addColumn<QPointF>("pos");
QTest::addColumn<bool>("contains");

?

Feb 21 2019, 11:13 PM · Plasma
romangg updated the diff for D15907: Compare float values in DecorationButton contains check.
  • Long variable names
Feb 21 2019, 11:08 PM · Plasma
romangg committed R108:d6f98d1ecc3a: Reload Shm texture when buffer size changes (authored by romangg).
Reload Shm texture when buffer size changes
Feb 21 2019, 10:46 PM
romangg closed D18453: Reload Shm texture when buffer size changes.
Feb 21 2019, 10:46 PM · KWin
romangg committed R108:d0422eb79f52: Remove unnecessary flushs in new buffer size change test (authored by romangg).
Remove unnecessary flushs in new buffer size change test
Feb 21 2019, 10:44 PM
romangg committed R108:06f64d5e567e: [autotests] Sub-surface resize test (authored by romangg).
[autotests] Sub-surface resize test
Feb 21 2019, 10:33 PM
romangg closed D18452: [autotests] Sub-surface resize test.
Feb 21 2019, 10:33 PM · KWin
romangg committed R108:1e6f6700f8a3: [platform/virtual] Swap buffers in EGL GBM backend (authored by romangg).
[platform/virtual] Swap buffers in EGL GBM backend
Feb 21 2019, 10:30 PM
romangg closed D18436: [platform/virtual] Swap buffers in EGL GBM backend.
Feb 21 2019, 10:30 PM · KWin
romangg accepted D18810: [platforms/hwcomposer] Add scaling support.

I'm fine with that. If later on we can use KScreen the config entry will become simply irrelevant.

Feb 21 2019, 7:50 PM · KWin
romangg requested review of D19208: [platforms/x11/standalone] Port to AbstractOutput.
Feb 21 2019, 7:14 PM · KWin
romangg requested review of D19207: [platforms/x11/windowed] Port to AbstractOutput.
Feb 21 2019, 6:43 PM · KWin
romangg requested review of D19199: [platforms/fbdev] Port to AbstractOutput.
Feb 21 2019, 12:49 PM · KWin

Feb 20 2019

romangg added a comment to T10462: Define input-output usage patterns.

What's missing here is the Tablet use-case since I'm not sure if Phone and Tablet are just the same thing or should be treated as separate patterns.

That depends a bit on your definition of Tablet.

A 7'' tablet is not much different than a phone, but a larger tablet with an attachable keyboard is a very different device

Feb 20 2019, 9:56 AM · Plasma
romangg triaged T10506: Define Tablet IOUP as Normal priority.
Feb 20 2019, 9:53 AM · Plasma
romangg updated the task description for T10502: Define Phone IOUP.
Feb 20 2019, 9:51 AM · Plasma
romangg added inline comments to R127:b2f67e1db7ea: Add explicit SurfaceInterface::commited signal.
Feb 20 2019, 1:22 AM
romangg accepted D19177: [wayland] Fix typo in method name.
Feb 20 2019, 12:52 AM · KWin
romangg added a comment to D18570: EGLStream DRM Backend Initial Implementation.

In this case it seems better to me to not write the EGLStreams support directly into the DRM Backend at all, but create a new EGLStream Backend on same level as DRM Backend. Th

That sounds pointless.
There's less of a difference between EGL streams and GBM than there is between GBM and QPainter.

Feb 20 2019, 12:49 AM · KWin

Feb 19 2019

romangg added a comment to D18570: EGLStream DRM Backend Initial Implementation.

Other aspect which is important to me long-term: is multi-GPU support of different vendors possible with the current patches or a separate backend? Current patches don't seem to allow that easily to add later on. Depending on DRM access in a separate backend it might be simpler to do later.

Feb 19 2019, 9:37 PM · KWin
romangg added a comment to T10502: Define Phone IOUP.

For a large tablet a 3x2 split is also thinkable. What changes with the number of splits is the way they are controlled.

Right, but how is the way changed?

Other cases where the window geometry on the phone changes is when the screen is rotated or the virtual keyboard is pushing the window like @mart proposed

Feb 19 2019, 9:05 PM · Plasma
romangg added a comment to D18570: EGLStream DRM Backend Initial Implementation.

First off: a driver not supporting Atomic Mode Setting is nothing modern. Does Nvidia has a plan to improve in this regard?

I'm really not happy, that the DrmOutput::present is not run and we have to export these internals from DrmOutput to the EglStreamBackend, which replaces the flip with an EGL function call. Why does the Nvidia driver not integrate with the libdrm API in regards to page flipping? It should be possible to at least offer a wrapper around it or not?

Well, our DRM-KMS driver technically does support atomic modesetting, however currently we only allow the presentation of GPU-accessible buffers through the EGLDevice / EGLOutput extensions. In fact, these use atomic modesetting capabilities in their implementation. As far as I know this will remain the case until work on the Unix device memory allocation library is complete and while this is still on the table it's a ways off yet. The new backend really just uses DrmOutputs to track whether a page flip is pending. If we don't want to expose these internals, an alternative might be to track this separately from DrmOutput::m_pageFlipPending and maybe install a different page flip handler when using EGL streams that would just clear this flag (and re-start the compositor). I'll see if I can get something like that thrown together, it might be a bit cleaner, actually.

Feb 19 2019, 8:58 PM · KWin
romangg added a comment to T10501: Define Desktop IOUP.

FYI there is previous discussion in T9780 in regards to touch window resize/move. The goal must be that whatever is he result here is usable in all IOUPs with primary or additional touch input. Therefore let us continue discussion there.

Feb 19 2019, 8:28 PM · Plasma
romangg added a comment to T10503: Define TV IOUP.

True. Anyway I'm not sure if changing the scale is something we want or if the KWin internal scale should really only be influenced by the resolution/size in a uniform way over all devices.

Feb 19 2019, 7:02 PM · Plasma
romangg added a comment to T10501: Define Desktop IOUP.

Because of the low to middle viewing distance and primary input device being keyboard and mouse the window border size can be "None" till "Normal". Currently it's "Normal" per default I believe but there was some discussion to set it to "None" in the past. Another topic is the buttons sizes, which is independent of this value.

Feb 19 2019, 6:57 PM · Plasma
romangg added a comment to T10462: Define input-output usage patterns.

I've created some sub-tasks to discuss definition of some common usage patterns we might want to concentrate first: Desktop, Phone, TV.

Feb 19 2019, 6:44 PM · Plasma
romangg added a comment to T10462: Define input-output usage patterns.

...
That's not quite right, there are many cases when the usage patterns change, but the output doesn't. Some examples:

  • tablet has a keyboard attached,
  • convertible switches modes,
  • a gamer picks up a controller and moves from the keyboard chair to a couch farther away.

That's true. So the Wayland event message must be sent also on these hot-plug events or when the user does a manual override, what maybe warrants a separate protocol.

Feb 19 2019, 6:43 PM · Plasma
romangg claimed T10501: Define Desktop IOUP.
Feb 19 2019, 6:39 PM · Plasma
romangg edited projects for T10462: Define input-output usage patterns, added: Plasma; removed KWin.
Feb 19 2019, 6:38 PM · Plasma
romangg triaged T10501: Define Desktop IOUP as Normal priority.
Feb 19 2019, 6:38 PM · Plasma
romangg edited projects for T10503: Define TV IOUP, added: Plasma; removed KWin.
Feb 19 2019, 6:37 PM · Plasma
romangg triaged T10503: Define TV IOUP as Normal priority.
Feb 19 2019, 6:31 PM · Plasma
romangg added a comment to T10502: Define Phone IOUP.

Window geometry can not be changed

Android has a split screen mode where two windows are tiled. In this case this assumption would not be true.

Feb 19 2019, 6:10 PM · Plasma
romangg triaged T10502: Define Phone IOUP as Normal priority.
Feb 19 2019, 6:01 PM · Plasma
romangg added a subtask for T10462: Define input-output usage patterns: T10501: Define Desktop IOUP.
Feb 19 2019, 5:49 PM · Plasma
romangg added a parent task for T10501: Define Desktop IOUP: T10462: Define input-output usage patterns.
Feb 19 2019, 5:49 PM · Plasma
romangg created T10501: Define Desktop IOUP.
Feb 19 2019, 5:49 PM · Plasma
romangg renamed T10462: Define input-output usage patterns from Defining output-input usage patterns to Define input-output usage patterns.
Feb 19 2019, 5:13 PM · Plasma
romangg requested review of D15907: Compare float values in DecorationButton contains check.
Feb 19 2019, 1:40 PM · Plasma
romangg added a comment to D15907: Compare float values in DecorationButton contains check.

ping

Feb 19 2019, 1:40 PM · Plasma
romangg edited projects for T6084: Omit Touchpad KCM init on startup, added: Plasma on Wayland; removed Plasma.
Feb 19 2019, 1:33 PM · Plasma on Wayland
romangg placed T9233: Wayland Thumbnails up for grabs.
Feb 19 2019, 1:21 PM · Plasma on Wayland
romangg abandoned D16791: [drm] On update always emit screensQueried.

The problem is not so easy to solve I believe now and needs a more holistic approach. Let's go back to the drawing board.

Feb 19 2019, 1:18 PM · KWin
romangg added a revision to T10028: Individual KScreen output data retention: D16991: Introduce concept of global and individual output data retention.
Feb 19 2019, 12:57 PM · VDG, Plasma
romangg added a task to D16991: Introduce concept of global and individual output data retention: T10028: Individual KScreen output data retention.
Feb 19 2019, 12:57 PM · Plasma
romangg moved T4611: Drag and drop from XWayland to Wayland windows and vice versa from Under Review to Done on the KWin board.
Feb 19 2019, 12:47 PM · KWin, Plasma on Wayland
romangg added inline comments to D15628: [xwl] Support stack optimizing X drag source clients.
Feb 19 2019, 12:29 PM · KWin
romangg committed R108:4c18d156e2fb: [xwl] Support stack optimizing X drag source clients (authored by romangg).
[xwl] Support stack optimizing X drag source clients
Feb 19 2019, 12:24 PM
romangg closed D15628: [xwl] Support stack optimizing X drag source clients.
Feb 19 2019, 12:24 PM · KWin
romangg committed R108:522d2935e661: [xwl] text/x-uri converter for selected X url list format targets (authored by romangg).
[xwl] text/x-uri converter for selected X url list format targets
Feb 19 2019, 12:17 PM
romangg closed D15629: [xwl] text/x-uri converter for selected X url list format targets.
Feb 19 2019, 12:17 PM · KWin
romangg committed R108:548978bfe1f7: [xwl] Drag and drop between Xwayland and Wayland native clients (authored by romangg).
[xwl] Drag and drop between Xwayland and Wayland native clients
Feb 19 2019, 12:09 PM
romangg closed D15627: [xwl] Drag and drop between Xwayland and Wayland native clients.
Feb 19 2019, 12:09 PM · KWin
romangg committed R108:ad1bcbecc789: [xwl] Add Xwayland interface class (authored by romangg).
[xwl] Add Xwayland interface class
Feb 19 2019, 11:59 AM
romangg closed D15419: [xwl] Add Xwayland interface class.
Feb 19 2019, 11:59 AM · KWin
romangg committed R108:2776f829efbd: Remove X clipboard sync helper and rename its autotest (authored by romangg).
Remove X clipboard sync helper and rename its autotest
Feb 19 2019, 11:30 AM
romangg closed D15063: Remove X clipboard sync helper and rename its autotest.
Feb 19 2019, 11:30 AM · KWin
romangg committed R108:6e08fb2fa5f6: [xwl] Generic X selections translation mechanism with Clipboard support (authored by romangg).
[xwl] Generic X selections translation mechanism with Clipboard support
Feb 19 2019, 11:24 AM