romangg (Roman Gilg)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 21 2016, 2:20 PM (137 w, 5 d)
Availability
Available

Recent Activity

Sun, Dec 2

romangg requested changes to D3202: [wayland] Don't use hardcoded resize cursor.

It's now just the normal cursor when resizing with Alt + Right click drag.

Sun, Dec 2, 9:05 PM · KWin
romangg committed R108:a23368d63809: Add Wayland touch drag and drop support (authored by romangg).
Add Wayland touch drag and drop support
Sun, Dec 2, 8:55 PM
romangg closed D15466: Add Wayland touch drag and drop support.
Sun, Dec 2, 8:55 PM · KWin
romangg closed D15464: [server] Touch drag support.
Sun, Dec 2, 8:44 PM · Frameworks
romangg committed R127:09b5adee94ad: [server] Touch drag support (authored by romangg).
[server] Touch drag support
Sun, Dec 2, 8:44 PM
romangg committed R127:7bb2a225521c: [server] Allow multiple touch interfaces per client (authored by romangg).
[server] Allow multiple touch interfaces per client
Sun, Dec 2, 8:38 PM
romangg closed D15443: [server] Allow multiple touch interfaces per client.
Sun, Dec 2, 8:38 PM · Frameworks
romangg committed R108:2e2971132378: Rework InputDeviceHandler focus tracking (authored by romangg).
Rework InputDeviceHandler focus tracking
Sun, Dec 2, 8:36 PM
romangg closed D15595: Rework InputDeviceHandler focus tracking.
Sun, Dec 2, 8:36 PM · KWin
romangg committed R108:eab71a8a19b2: Privatize variables in InputDeviceHandler (authored by romangg).
Privatize variables in InputDeviceHandler
Sun, Dec 2, 8:17 PM
romangg closed D15519: Privatize variables in InputDeviceHandler.
Sun, Dec 2, 8:17 PM · KWin
romangg committed R108:b5a91cdfe08c: Float position values in drag input filter (authored by romangg).
Float position values in drag input filter
Sun, Dec 2, 8:11 PM
romangg closed D15502: Float position values in drag input filter.
Sun, Dec 2, 8:11 PM · KWin

Fri, Nov 30

romangg accepted D17254: [autotests] Stabilise colorcorrect test.
Fri, Nov 30, 11:42 AM · KWin

Mon, Nov 26

romangg updated the task description for T9650: Attend External Events 2018: Qt World Summit.
Mon, Nov 26, 4:53 PM · KDE Promo

Sun, Nov 25

romangg added a comment to D16990: [kded] Change configuration storage path.

Is it fine if we keep the files in the current directory and just add the additional directories outputs and control in later patches. The hash values should never coincide with these names. So it might be ugly, but work without problems.
Moving the configuration files in a separate configs folder could then be done in KDE6 since with D17007 some of them would then be invalid anyways.

Sun, Nov 25, 12:30 PM · Plasma
romangg added a comment to D17007: Do hash and hex name based output hashes.
In D17007#364724, @mart wrote:

could a kconfigupdate script be provided to migrate config?
screwing up multiscreen config between updated is quite of an issue

Sun, Nov 25, 12:27 PM · Plasma
romangg added a comment to D16997: [kcm] Expose interface to control output property retention.

I'll admit just looking at the new UI, it's not entirely clear what either of the options do. Can you help me understand? Thanks Roman!

I replied to your mail to the plasma-devel thread. We can continue the discussion there. Maybe we find an alternative solution for the radio buttons better suited for what we want to communicate to the user.

Sun, Nov 25, 12:23 PM · Plasma

Mon, Nov 19

romangg added a comment to D17012: Show the Delete context menu entry even when disabled.

My vote is to re-work this patch to do that instead.

Dolphin does this already. Might be an idea to only disable the Delete or Move to trash entry though. Not sure.

Mon, Nov 19, 2:44 PM · Dolphin
romangg added a comment to D16988: [Kickoff] Make the visible search field unfocused by default.

Clipboard works like this but the coding is beyond my abilities. Krunner does this too except it opens up with the search field in focus. This Kickoff patched version can't do that, and I've yet to figure out how to make it be able to.

I believe in you! :) If you need quick help come join the Plasma IRC channel.

Mon, Nov 19, 2:42 PM · Plasma
romangg added a comment to D16988: [Kickoff] Make the visible search field unfocused by default.

(1) Kicker takes the focus off the search field when you go through the results by either mouse or keyboard. This makes it easy to go back to the search field by typing or using the arrow keys (to add more words etc.)

Why does it make it easy?

(2) Krunner becomes unfocused if you use the arrow keys, but not if you hover over the search results with your mouse, and it's still possible in either case to append your search same as in Kickoff.
(3) Kickoff (the old, the master and this patch) seems to leave the search field focused at all times while you go through the results, and it's possible to add more characters to the search like in (1) and (2).
(4) Clipboard behaves pretty much like this patch except pressing the Esc key doesn't make it unfocused again.

Mon, Nov 19, 2:10 PM · Plasma
romangg added a comment to D16988: [Kickoff] Make the visible search field unfocused by default.

I like all the changes, but they should go into separate patches:

Mon, Nov 19, 1:47 PM · Plasma
romangg added a comment to D17012: Show the Delete context menu entry even when disabled.

From a Ux point of view Ui elements should be disabled instead of hidden if they are not available but the user expects them to be there. The "Rename" entry currently gets disabled. You think it makes more sense to hide it instead?

Mon, Nov 19, 1:26 PM · Dolphin
romangg accepted D16937: [Kickoff] Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item).

You know what, I tried this out and I like it. The differing line widths don't actually seem all that weird when actually using it for a a bit. I think this is fine.

Other VDG and/or Plasma folks, what do you guys think?

Mon, Nov 19, 1:00 PM · Plasma
romangg added a dependency for D16991: Introduce concept of global and individual output data retention: D17007: Do hash and hex name based output hashes.
Mon, Nov 19, 9:58 AM · Plasma
romangg added a dependent revision for D17007: Do hash and hex name based output hashes: D16991: Introduce concept of global and individual output data retention.
Mon, Nov 19, 9:58 AM · Plasma
romangg requested review of D17007: Do hash and hex name based output hashes.
Mon, Nov 19, 9:55 AM · Plasma

Sun, Nov 18

romangg planned changes to D16997: [kcm] Expose interface to control output property retention.

This diff contains some fix, that need to go into earlier diffs in this patch series.

Sun, Nov 18, 11:51 PM · Plasma
romangg updated the summary of D16997: [kcm] Expose interface to control output property retention.
Sun, Nov 18, 11:49 PM · Plasma
romangg added a dependent revision for D16996: Add method to write retention to configuration control files: D16997: [kcm] Expose interface to control output property retention.
Sun, Nov 18, 11:46 PM · Plasma
romangg added a dependency for D16997: [kcm] Expose interface to control output property retention: D16996: Add method to write retention to configuration control files.
Sun, Nov 18, 11:46 PM · Plasma
romangg requested review of D16997: [kcm] Expose interface to control output property retention.
Sun, Nov 18, 11:45 PM · Plasma
romangg added a dependency for D16996: Add method to write retention to configuration control files: D16995: Consider identical display models in ControlConfig.
Sun, Nov 18, 11:35 PM · Plasma
romangg added a dependent revision for D16995: Consider identical display models in ControlConfig: D16996: Add method to write retention to configuration control files.
Sun, Nov 18, 11:35 PM · Plasma
romangg requested review of D16996: Add method to write retention to configuration control files.
Sun, Nov 18, 11:35 PM · Plasma
romangg added a dependent revision for D16994: Split Control class into configurations and outputs control classes: D16995: Consider identical display models in ControlConfig.
Sun, Nov 18, 11:25 PM · Plasma
romangg added a dependency for D16995: Consider identical display models in ControlConfig: D16994: Split Control class into configurations and outputs control classes.
Sun, Nov 18, 11:25 PM · Plasma
romangg requested review of D16995: Consider identical display models in ControlConfig.
Sun, Nov 18, 11:25 PM · Plasma
romangg added a dependency for D16994: Split Control class into configurations and outputs control classes: D16993: Add a common directory for functionality being used by kcm and daemon.
Sun, Nov 18, 11:15 PM · Plasma
romangg added a dependent revision for D16993: Add a common directory for functionality being used by kcm and daemon: D16994: Split Control class into configurations and outputs control classes.
Sun, Nov 18, 11:15 PM · Plasma
romangg requested review of D16994: Split Control class into configurations and outputs control classes.
Sun, Nov 18, 11:14 PM · Plasma
romangg added a dependent revision for D16992: Introduce secondary control channel of the KScreen daemon: D16993: Add a common directory for functionality being used by kcm and daemon.
Sun, Nov 18, 11:06 PM · Plasma
romangg added a dependency for D16993: Add a common directory for functionality being used by kcm and daemon: D16992: Introduce secondary control channel of the KScreen daemon.
Sun, Nov 18, 11:06 PM · Plasma
romangg requested review of D16993: Add a common directory for functionality being used by kcm and daemon.
Sun, Nov 18, 11:05 PM · Plasma
romangg added a dependent revision for D16991: Introduce concept of global and individual output data retention: D16992: Introduce secondary control channel of the KScreen daemon.
Sun, Nov 18, 10:58 PM · Plasma
romangg added a dependency for D16992: Introduce secondary control channel of the KScreen daemon: D16991: Introduce concept of global and individual output data retention.
Sun, Nov 18, 10:58 PM · Plasma
romangg requested review of D16992: Introduce secondary control channel of the KScreen daemon.
Sun, Nov 18, 10:57 PM · Plasma
romangg added a dependency for D16991: Introduce concept of global and individual output data retention: D16990: [kded] Change configuration storage path.
Sun, Nov 18, 10:36 PM · Plasma
romangg added a dependent revision for D16990: [kded] Change configuration storage path: D16991: Introduce concept of global and individual output data retention.
Sun, Nov 18, 10:36 PM · Plasma
romangg requested review of D16991: Introduce concept of global and individual output data retention.
Sun, Nov 18, 10:35 PM · Plasma
romangg added a dependent revision for D16989: [kded] Introduce Config wrapper class: D16990: [kded] Change configuration storage path.
Sun, Nov 18, 10:13 PM · Plasma
romangg added a dependency for D16990: [kded] Change configuration storage path: D16989: [kded] Introduce Config wrapper class.
Sun, Nov 18, 10:13 PM · Plasma
romangg requested review of D16990: [kded] Change configuration storage path.
Sun, Nov 18, 10:12 PM · Plasma
romangg requested review of D16989: [kded] Introduce Config wrapper class.
Sun, Nov 18, 10:01 PM · Plasma
romangg added a comment to D16987: Recalculate connected hash only on change and emit signal.

Checking the edid is necessary, because it might be set asynchronously and before that the hash is based on the output name only.

Sun, Nov 18, 7:28 PM · Plasma
romangg requested review of D16987: Recalculate connected hash only on change and emit signal.
Sun, Nov 18, 7:26 PM · Plasma
romangg added a comment to D16937: [Kickoff] Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item).

Eike's Simple Menu is a good example of separator use - the separator is subtle and doesn't fully break up the the plasmoid:

On top of that he made the search field unfocused by default, which can really help with transparent themes.

Sun, Nov 18, 1:30 AM · Plasma

Sat, Nov 17

romangg added a comment to D16937: [Kickoff] Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item).

FWIW make sure to test your changes with all four possible orientations.

I actually figured out how to do that just before my latest edit, my bad. It seems to work sort of fine with the tabs on the left or the right, except for the lower separator (to the left/right of the tabs on the right or left, respectively) that seems to appear shorter than the length of the separator to the left/right of the tab bar before you start scrolling to the bottom.

...

I don't know if this was on purpose or if it's a bug, but the bottom separator becomes thicker to the left/right of the tab bar before/when you start flicking through the menus in the previous design (no opacity settings / width: root.width) before reaching the end (of a given menu)

...

Sat, Nov 17, 9:49 AM · Plasma

Thu, Nov 15

romangg committed R104:af6da1146ef6: Rename config loading function (authored by romangg).
Rename config loading function
Thu, Nov 15, 4:22 PM
romangg closed D16859: Rename config loading function.
Thu, Nov 15, 4:22 PM · Plasma
romangg requested review of D16898: [kcm] Remove profiles code.
Thu, Nov 15, 2:43 PM · Plasma
romangg added a comment to T10028: Individual KScreen output data retention.

There is one other special case: a configuration with several identical displays. We maybe want the individual output data globally to be overridden, but keep the output values different in this specific configuration.

Thu, Nov 15, 12:44 PM · VDG, Plasma

Wed, Nov 14

romangg committed R108:6857fe54776b: Add output orientation size helper (authored by romangg).
Add output orientation size helper
Wed, Nov 14, 7:05 PM
romangg closed D16794: Add output orientation size helper.
Wed, Nov 14, 7:05 PM · KWin
romangg committed R108:6295d1e6a277: Move output refresh rate getter into AbstractOutput (authored by romangg).
Move output refresh rate getter into AbstractOutput
Wed, Nov 14, 7:04 PM
romangg closed D16793: Move output refresh rate getter into AbstractOutput.
Wed, Nov 14, 7:04 PM · KWin
romangg committed R108:0af57d6366e6: [drm] Code cleanup in DrmOutput class (authored by romangg).
[drm] Code cleanup in DrmOutput class
Wed, Nov 14, 7:03 PM
romangg closed D16792: [drm] Code cleanup in DrmOutput class.
Wed, Nov 14, 7:03 PM · KWin
romangg committed R108:93f78c2d2378: Set outputs enabled in AbstractOutput (authored by romangg).
Set outputs enabled in AbstractOutput
Wed, Nov 14, 7:00 PM
romangg closed D16790: Set outputs enabled in AbstractOutput.
Wed, Nov 14, 7:00 PM · KWin
romangg committed R108:32a9a618894d: Abstract OutputDevice initialization (authored by romangg).
Abstract OutputDevice initialization
Wed, Nov 14, 6:59 PM
romangg closed D16789: Abstract OutputDevice initialization.
Wed, Nov 14, 6:59 PM · KWin
romangg committed R108:27946199b6b2: Abstract output dpms handling (authored by romangg).
Abstract output dpms handling
Wed, Nov 14, 6:57 PM
romangg closed D16787: Abstract output dpms handling.
Wed, Nov 14, 6:57 PM · KWin
romangg committed R108:e2b1bcea1b1b: Set mode in AbstractOutput (authored by romangg).
Set mode in AbstractOutput
Wed, Nov 14, 6:56 PM
romangg closed D16786: Set mode in AbstractOutput.
Wed, Nov 14, 6:56 PM · KWin
romangg committed R108:254a8073746e: Handle Wayland change sets in AbstractOutput (authored by romangg).
Handle Wayland change sets in AbstractOutput
Wed, Nov 14, 6:54 PM
romangg closed D16785: Handle Wayland change sets in AbstractOutput.
Wed, Nov 14, 6:54 PM · KWin
romangg committed R104:4a177884b052: [kded] Cleanup KScreenDaemon class (authored by romangg).
[kded] Cleanup KScreenDaemon class
Wed, Nov 14, 6:04 PM
romangg closed D16875: [kded] Cleanup KScreenDaemon class.
Wed, Nov 14, 6:04 PM · Plasma
romangg committed R104:980b100770bb: [kded] Replace configReady functon with lambda (authored by romangg).
[kded] Replace configReady functon with lambda
Wed, Nov 14, 6:02 PM
romangg closed D16874: [kded] Replace configReady functon with lambda.
Wed, Nov 14, 6:02 PM · Plasma
romangg updated the diff for D16875: [kded] Cleanup KScreenDaemon class.
  • Add back Q_SLOTS specifier to be sure
Wed, Nov 14, 5:52 PM · Plasma
romangg added inline comments to D16875: [kded] Cleanup KScreenDaemon class.
Wed, Nov 14, 4:42 PM · Plasma
romangg added a comment to D16792: [drm] Code cleanup in DrmOutput class.

git history tracking

Wed, Nov 14, 3:37 PM · KWin
romangg updated the summary of D16875: [kded] Cleanup KScreenDaemon class.
Wed, Nov 14, 10:16 AM · Plasma
romangg added a dependency for D16875: [kded] Cleanup KScreenDaemon class: D16874: [kded] Replace configReady functon with lambda.
Wed, Nov 14, 10:15 AM · Plasma
romangg added a dependent revision for D16874: [kded] Replace configReady functon with lambda: D16875: [kded] Cleanup KScreenDaemon class.
Wed, Nov 14, 10:15 AM · Plasma
romangg requested review of D16875: [kded] Cleanup KScreenDaemon class.
Wed, Nov 14, 10:14 AM · Plasma
romangg retitled D16874: [kded] Replace configReady functon with lambda from [daemon] Replace configReady functon with lambda to [kded] Replace configReady functon with lambda.
Wed, Nov 14, 9:16 AM · Plasma
romangg added a comment to D16874: [kded] Replace configReady functon with lambda.

Note, that the configReady function was a public slot in an exported class, so is it safe? I would like to change other stuff in this class definition. I don't know why the class is exported and who consumes it.

Wed, Nov 14, 9:16 AM · Plasma
romangg requested review of D16874: [kded] Replace configReady functon with lambda.
Wed, Nov 14, 9:14 AM · Plasma
romangg added a comment to T10028: Individual KScreen output data retention.

In regards to backend I hit a wall in that the variable value if display properties should be saved for all configs or only for this specific one need to be communicated between the KCM and the daemon. The communication mostly uses the kscreen backend though, which means it is tunneled through the Wayland compositor or XCB.

Wed, Nov 14, 8:51 AM · VDG, Plasma

Tue, Nov 13

romangg updated the diff for D15512: [startplasmacompositor] Add Wayland socket argument.
  • Use SOCKET_OPTION variable
Tue, Nov 13, 7:12 PM · Plasma
romangg added a comment to D16789: Abstract OutputDevice initialization.

I'm not loving the name, the goal of this patchset is to move all of the wayland logic out of the platform.

initWaylandOutput/initXdgOutput are now handled in setEnabled so can be private to AbstractOutput.
We should aim for the same with outputdevice.

I'd rather this was just "AbstractOutput::init()"

Code otherwise is fine

Tue, Nov 13, 2:19 PM · KWin
romangg added a project to T10028: Individual KScreen output data retention: VDG.

When user changes properties in KCM, he might either decide to change data for the current configuration only set it as new "default" for this output on every other configuration, which does not overwrite with configuration-specific values. How should this be communicated to the user and how should he switch around for the current config operation?

Tue, Nov 13, 1:05 PM · VDG, Plasma
romangg moved T10028: Individual KScreen output data retention from To Do to Work in Progress on the Plasma board.
Tue, Nov 13, 12:59 PM · VDG, Plasma
romangg edited projects for T10028: Individual KScreen output data retention, added: Plasma; removed Plasma: Workspaces.
Tue, Nov 13, 12:59 PM · VDG, Plasma
romangg triaged T10028: Individual KScreen output data retention as Normal priority.
Tue, Nov 13, 12:58 PM · VDG, Plasma
romangg updated the diff for D16859: Rename config loading function.
  • Remove unrelated change
Tue, Nov 13, 11:14 AM · Plasma