romangg (Roman Gilg)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 21 2016, 2:20 PM (186 w, 1 d)
Availability
Available

Recent Activity

Yesterday

romangg updated the diff for D24199: Split out Wayland only source into libkwinwl.so.

Rebase on master.

Thu, Nov 14, 4:31 PM · KWin
romangg added a comment to T11886: Split KWin for Wayland and X11 at build level.
In T11886#205370, @zzag wrote:

While I'm all for building KWin w/o X11 stuff, I think it's way too early to split kwin code into different libraries. X11 is used in many places. We need to take care of that first. Once we have distinct line between X11 stuff, Wayland stuff, and stuff that doesn't use any of those two, we can proceed with discussing this task.

Thu, Nov 14, 4:21 PM · KWin
romangg added a comment to T11886: Split KWin for Wayland and X11 at build level.
In T11886#204906, @apol wrote:

A way of dealing with this without creating normal libraries would be to use add_library(OBJECT)

You can learn about them here: https://cmake.org/cmake/help/v3.8/command/add_library.html?highlight=i#object-libraries

Thu, Nov 14, 4:18 PM · KWin
romangg added inline comments to D23114: [perf] Introduce ftrace marker.
Thu, Nov 14, 11:01 AM · KWin
romangg updated the diff for D23114: [perf] Introduce ftrace marker.
  • Use DBus error message
  • No overloaded API functions
  • Check on empty dir name
Thu, Nov 14, 11:00 AM · KWin
romangg updated the diff for D23114: [perf] Introduce ftrace marker.

Rebase on master.

Thu, Nov 14, 9:14 AM · KWin
romangg updated the task description for T11071: Rework compositing pipeline.
Thu, Nov 14, 9:01 AM · KWin
romangg added a comment to D23881: Possible solution for scheduling repaints on NVIDIA.

I just pushed the rework patches. Can you rebase your patch on D25299? It allows direct repaints on swap events in the compositing pipeline.

Thu, Nov 14, 8:39 AM · KWin
romangg added a task to D25300: [platforms/x11/standalone] Use intel swap events by default: T11071: Rework compositing pipeline.
Thu, Nov 14, 8:33 AM · KWin
romangg added a revision to T11071: Rework compositing pipeline: D25300: [platforms/x11/standalone] Use intel swap events by default.
Thu, Nov 14, 8:33 AM · KWin
romangg added a task to D25299: Composite without timer on swap events: T11071: Rework compositing pipeline.
Thu, Nov 14, 8:33 AM
romangg added a revision to T11071: Rework compositing pipeline: D25299: Composite without timer on swap events.
Thu, Nov 14, 8:33 AM · KWin
romangg added a revision to T11071: Rework compositing pipeline: D25298: Add hasSwapEvent getter.
Thu, Nov 14, 8:33 AM · KWin
romangg added a task to D25298: Add hasSwapEvent getter: T11071: Rework compositing pipeline.
Thu, Nov 14, 8:33 AM · KWin
romangg added a dependency for D25300: [platforms/x11/standalone] Use intel swap events by default: D25299: Composite without timer on swap events.
Thu, Nov 14, 8:31 AM · KWin
romangg added a dependent revision for D25299: Composite without timer on swap events: D25300: [platforms/x11/standalone] Use intel swap events by default.
Thu, Nov 14, 8:31 AM
romangg requested review of D25300: [platforms/x11/standalone] Use intel swap events by default.
Thu, Nov 14, 8:29 AM · KWin
romangg added a dependency for D25299: Composite without timer on swap events: D25298: Add hasSwapEvent getter.
Thu, Nov 14, 8:16 AM
romangg added a dependent revision for D25298: Add hasSwapEvent getter: D25299: Composite without timer on swap events.
Thu, Nov 14, 8:16 AM · KWin
romangg requested review of D25299: Composite without timer on swap events.
Thu, Nov 14, 8:16 AM
romangg requested review of D25298: Add hasSwapEvent getter.
Thu, Nov 14, 8:11 AM · KWin
romangg committed R108:8d137290317a: [platforms/x11] Never block on retrace, always present after paint (authored by romangg).
[platforms/x11] Never block on retrace, always present after paint
Thu, Nov 14, 8:03 AM
romangg closed D23514: [platforms/x11] Never block on retrace, always present after paint.
Thu, Nov 14, 8:03 AM · KWin
romangg committed R108:b3a19f9e5b77: Remove vsync detection and configurability (authored by romangg).
Remove vsync detection and configurability
Thu, Nov 14, 7:55 AM
romangg closed D23511: Remove vsync detection and configurability.
Thu, Nov 14, 7:55 AM · KWin
romangg committed R108:285adc1950c9: [platforms/x11/standalone] Remove SGI swap control and video sync (authored by romangg).
[platforms/x11/standalone] Remove SGI swap control and video sync
Thu, Nov 14, 7:48 AM
romangg closed D23510: [platforms/x11/standalone] Remove SGI swap control and video sync.
Thu, Nov 14, 7:48 AM · KWin
romangg updated the diff for D23510: [platforms/x11/standalone] Remove SGI swap control and video sync.

Rebase on master.

Thu, Nov 14, 7:41 AM · KWin
romangg committed R108:ad892ce3a65e: [platforms/x11] Remove triple buffering detection (authored by romangg).
[platforms/x11] Remove triple buffering detection
Thu, Nov 14, 7:38 AM
romangg closed D23504: [platforms/x11] Remove triple buffering detection.
Thu, Nov 14, 7:38 AM · KWin

Mon, Nov 11

romangg closed T11928: KScreen: Use 0.25 slider steps also on Wayland as Resolved.
Mon, Nov 11, 9:27 PM · Plasma
romangg closed T11929: KScreen: Automatic resize of overview as Resolved.
Mon, Nov 11, 9:27 PM · Plasma
romangg committed R104:643e32c2bd2f: feat(kcm): zoom preview automatically (authored by romangg).
feat(kcm): zoom preview automatically
Mon, Nov 11, 9:18 PM
romangg closed D25027: feat(kcm): zoom preview automatically.
Mon, Nov 11, 9:18 PM · Plasma
romangg committed R104:fb170c3aa80e: feat(kcm): always use 0.25 slider scale steps (authored by romangg).
feat(kcm): always use 0.25 slider scale steps
Mon, Nov 11, 9:09 PM
romangg closed D25026: feat(kcm): always use 0.25 slider scale steps.
Mon, Nov 11, 9:09 PM · Plasma
romangg committed R104:5a410a5fe3e2: Merge branch 'Plasma/5.17' (authored by romangg).
Merge branch 'Plasma/5.17'
Mon, Nov 11, 9:08 PM
romangg committed R104:0cf25b853ae3: fix(kded): read rotated output size (authored by romangg).
fix(kded): read rotated output size
Mon, Nov 11, 9:04 PM
romangg closed D25062: fix(kded): read rotated output size.
Mon, Nov 11, 9:04 PM · Plasma
romangg committed R104:0f685b76633e: fix: use output hashMd5 for control files (authored by romangg).
fix: use output hashMd5 for control files
Mon, Nov 11, 9:03 PM
romangg closed D25021: fix: use output hashMd5 for control files.
Mon, Nov 11, 9:03 PM · Plasma
romangg closed D25020: fix: create control files only when needed.
Mon, Nov 11, 8:56 PM · Plasma
romangg committed R104:7de6c0c36d55: fix: create control files only when needed (authored by romangg).
fix: create control files only when needed
Mon, Nov 11, 8:56 PM
romangg committed R104:50cf930ec824: docs: add contributing guide (authored by romangg).
docs: add contributing guide
Mon, Nov 11, 8:53 PM
romangg closed D24068: docs: add contributing guide.
Mon, Nov 11, 8:52 PM · Plasma
romangg closed D25064: docs: add contributing guide.
Mon, Nov 11, 8:52 PM · Plasma
romangg committed R110:4e176e1d5e07: docs: add contributing guide (authored by romangg).
docs: add contributing guide
Mon, Nov 11, 8:52 PM

Fri, Nov 8

romangg added inline comments to D25020: fix: create control files only when needed.
Fri, Nov 8, 8:12 AM · Plasma

Wed, Nov 6

baberts awarded R108:b89b1d816643: [platforms/wayland] Use xdg-shell stable protocol a Love token.
Wed, Nov 6, 3:23 AM

Tue, Nov 5

romangg added a comment to T11847: Qt World Summit 2019.

Possible improvements (ongoing):

  • People very interested in Plasma Mobile. Have some takeaway material like flyers.
  • Frameworks less interesting. How to improve messaging and display of our Frameworks?
  • Frameworks flyer needs more padding on the left side and text was bit too small.
  • Update slideshow with more recent screenshots.
  • Hardware database on what hardware we have available for such events to present.
Tue, Nov 5, 4:46 PM · KDE Promo
romangg added a comment to D24068: docs: add contributing guide.
In D24068#558809, @mart wrote:

Overall most of those are sensible policies (and would really make sense globally in plasma, rather than a specific subproject)
I feel the Conventional Commit policy to rise the barrier of entry a tad too much tough (and not sure i would really want it in the resto of plasma)

Tue, Nov 5, 1:58 PM · Plasma
romangg added a comment to D24068: docs: add contributing guide.

README is really good.

Did you email kde-devel about this commit policy? I thought you did, but I can't find it.
As someone who regularly commits across many many repos if every maintainer enforced their own thing I would really struggle.

Tue, Nov 5, 6:45 AM · Plasma

Mon, Nov 4

romangg added a comment to T11936: Move Frameworks_Coding_Style wiki page w/ history: techbase->community.

Okay so, #mediawiki told me of something that might fix the import. But now this page rename happened.

What should I do now? Should I move the page back to KDELibs Coding Style, so I can then try the import?

Mon, Nov 4, 9:46 AM · Websites: general, Wiki Administrators

Sun, Nov 3

romangg accepted R108:84de8d135d58: [wayland] Process pending state and map the client on commit.

Problem solved with 932a1160f58a.

Sun, Nov 3, 6:41 PM
romangg committed R108:b89b1d816643: [platforms/wayland] Use xdg-shell stable protocol (authored by romangg).
[platforms/wayland] Use xdg-shell stable protocol
Sun, Nov 3, 6:40 PM
romangg closed D25129: [platforms/wayland] Use xdg-shell stable protocol.
Sun, Nov 3, 6:40 PM · KWin
romangg committed R108:9c0501eb8f51: [platforms/wayland] Always ack configure (authored by romangg).
[platforms/wayland] Always ack configure
Sun, Nov 3, 6:39 PM
romangg closed D25128: [platforms/wayland] Always ack configure.
Sun, Nov 3, 6:39 PM · KWin
romangg committed R108:932a1160f58a: [platforms/wayland] Do an initial xdg-surface commit (authored by romangg).
[platforms/wayland] Do an initial xdg-surface commit
Sun, Nov 3, 6:38 PM
romangg closed D25127: [platforms/wayland] Do an initial xdg-surface commit.
Sun, Nov 3, 6:38 PM · KWin
romangg added a comment to T11679: Create a designed version of kde.org/applications .

Would be also interested in making use of Vue for our websites. Also because Vue has a lovely community behind it. @joricke would you be up to join forces with @ognarb on this?

Sun, Nov 3, 6:32 PM · VDG, Websites, Goal: All About the Apps
romangg requested review of D25129: [platforms/wayland] Use xdg-shell stable protocol.
Sun, Nov 3, 4:13 PM · KWin
romangg requested review of D25128: [platforms/wayland] Always ack configure.
Sun, Nov 3, 4:07 PM · KWin
romangg updated the diff for D25127: [platforms/wayland] Do an initial xdg-surface commit.

Remove unrelated code change.

Sun, Nov 3, 3:56 PM · KWin
romangg requested review of D25127: [platforms/wayland] Do an initial xdg-surface commit.
Sun, Nov 3, 3:53 PM · KWin

Fri, Nov 1

romangg raised a concern with R108:84de8d135d58: [wayland] Process pending state and map the client on commit.

A git bisect showed that our Wayland nested session is broken at the moment because of this commit. Commit revert would be possible on current master making the nested session work again.

Fri, Nov 1, 12:27 AM

Thu, Oct 31

romangg added a comment to T11936: Move Frameworks_Coding_Style wiki page w/ history: techbase->community.

The page seems to has been moved now. Thanks!

Thu, Oct 31, 11:58 AM · Websites: general, Wiki Administrators

Wed, Oct 30

romangg added a comment to T11936: Move Frameworks_Coding_Style wiki page w/ history: techbase->community.

Is there an ETA?

Wed, Oct 30, 3:41 PM · Websites: general, Wiki Administrators
romangg updated the summary of D25062: fix(kded): read rotated output size.
Wed, Oct 30, 1:06 PM · Plasma
romangg updated the diff for D24068: docs: add contributing guide.

Fix typo

Wed, Oct 30, 12:32 AM · Plasma
romangg updated the diff for D25064: docs: add contributing guide.

Fix typo

Wed, Oct 30, 12:31 AM · Plasma
romangg requested review of D25064: docs: add contributing guide.
Wed, Oct 30, 12:29 AM · Plasma

Tue, Oct 29

romangg requested review of D25062: fix(kded): read rotated output size.
Tue, Oct 29, 10:31 PM · Plasma
romangg added inline comments to D25027: feat(kcm): zoom preview automatically.
Tue, Oct 29, 5:32 PM · Plasma
romangg accepted D24659: Store buffer geometry during geometry updates.
Tue, Oct 29, 4:48 PM · KWin
romangg accepted D24658: Use better name for geometryBeforeUpdateBlocking.
Tue, Oct 29, 4:44 PM · KWin
romangg accepted D24461: Fix coding style issues in Scene::paintSimpleScreen.
Tue, Oct 29, 3:37 PM · KWin
romangg accepted D24460: Schedule correct damage and repaints region in addDamageFull for csd clients.

Would be nice if both is with the same origin. Otherwise since this is the second time how about having a translation function doing this.

Tue, Oct 29, 3:34 PM · KWin
romangg accepted D24457: [wayland] Ensure that repaints_region is in frame-local coordinates.
Tue, Oct 29, 3:24 PM · KWin
romangg added a comment to D24455: [wayland] Implement window geometry more properly.

Please give this diff a more telling name what it is about. You introduce a new cached buffer size value and redefine geom via window geometry. What this does and how it relates to all the other sizes we have is not clear to me.

Tue, Oct 29, 3:09 PM · KWin
romangg updated the task description for T11927: KScreen for KF6.
Tue, Oct 29, 12:16 PM · Plasma, KF6
romangg added a revision to T11929: KScreen: Automatic resize of overview: D25027: feat(kcm): zoom preview automatically.
Tue, Oct 29, 11:28 AM · Plasma
romangg added a task to D25027: feat(kcm): zoom preview automatically: T11929: KScreen: Automatic resize of overview.
Tue, Oct 29, 11:28 AM · Plasma
romangg moved T11929: KScreen: Automatic resize of overview from To Do to Needs Review on the Plasma board.
Tue, Oct 29, 11:28 AM · Plasma
romangg added a revision to T11928: KScreen: Use 0.25 slider steps also on Wayland: D25026: feat(kcm): always use 0.25 slider scale steps.
Tue, Oct 29, 11:27 AM · Plasma
romangg added a task to D25026: feat(kcm): always use 0.25 slider scale steps: T11928: KScreen: Use 0.25 slider steps also on Wayland.
Tue, Oct 29, 11:27 AM · Plasma
romangg moved T11928: KScreen: Use 0.25 slider steps also on Wayland from To Do to Needs Review on the Plasma board.
Tue, Oct 29, 11:27 AM · Plasma
romangg added a comment to D24688: [KCM] Disallow dropping screen outside of reachable area.

See D25027

Tue, Oct 29, 11:23 AM · Plasma
romangg committed R108:affd44450751: Merge branch 'Plasma/5.17' (authored by romangg).
Merge branch 'Plasma/5.17'
Tue, Oct 29, 11:21 AM
romangg committed R108:7459aabcac24: Dmabuf recovery on EGL reset (authored by romangg).
Dmabuf recovery on EGL reset
Tue, Oct 29, 11:10 AM
romangg closed D24954: Dmabuf recovery on EGL reset.
Tue, Oct 29, 11:10 AM · KWin

Mon, Oct 28

romangg requested review of D25027: feat(kcm): zoom preview automatically.
Mon, Oct 28, 11:47 PM · Plasma
romangg requested review of D25026: feat(kcm): always use 0.25 slider scale steps.
Mon, Oct 28, 11:25 PM · Plasma
romangg updated the diff for D24954: Dmabuf recovery on EGL reset.

Rebase on Plasma/5.17 branch.

Mon, Oct 28, 10:28 PM · KWin
romangg requested review of D25021: fix: use output hashMd5 for control files.
Mon, Oct 28, 9:43 PM · Plasma
romangg updated the summary of D25020: fix: create control files only when needed.
Mon, Oct 28, 9:30 PM · Plasma
romangg requested review of D25020: fix: create control files only when needed.
Mon, Oct 28, 9:28 PM · Plasma
romangg updated the diff for D24068: docs: add contributing guide.

Add a minimal readme file

Mon, Oct 28, 9:24 PM · Plasma
romangg updated the diff for D24068: docs: add contributing guide.

Remove scopes common and console. Small areas, do not warrant scope on themselves. If there is a change to one of them just don't use the optional scope.

Mon, Oct 28, 8:50 PM · Plasma
romangg updated subscribers of T11222: Reimagine output cloning.

After some feedback from @davidedmundson I am trying to remodel my first approach a bit: Instead of sending the replication source to KWin, just send the logical size. In KScreen remember the replication source though by hash in the control files I introduced some time ago for the retention data. This will also improve the X11 situation where we currently can only heuristically guess if outputs are replicating other ones (per position and size).

Mon, Oct 28, 2:38 PM · VDG, Plasma