Builds fine here too, thanks!

Implement Elvis' suggestions.

Hmm, if the license is ok, perhaps the smaller RealSmaliFileTest.smali you linked above would make a better test case, >> 5000 lines is a bit large for reviewing changes later ;=)

In D19861#433859, @apol wrote:

Can you send the patch?

Can you send the patch?

Can you address the last nitpick from @chinmoyr ?

Rotate elsewhere

Thanks for the patch, and for adding a test!

While that fixes the drkonqi bug just fine I am not sure that is the best fix for the problem. As I understand it KPasswordLineEdit doesn't set itself to StrongFocus, seeing as it is a replacement for QLineEdit that seems inconsistent and should be rectified though. IOW: I think KPasswordLineEdit should be changed to set a StrongFocus by default, same as QLineEdit.

Other download managers show the downloaded amount as total amount, so it is e.g 25 MiB out of 25 MiB.

Removed the use of goto.

Remove the image filter which stopped copying images to clipboard.

In D19858#433788, @ngraham wrote:

Thanks! Makes sense, and fixes the bug. :)

Of course the underlying issue is still present. If you can't vote from the GHNS dialogs, there shouldn't be a UI for let you try; it should be strictly read-only. I suppose that's a separate matter though.

Rebase on master

The patch currently causes some flickering that I will address once D19844 is merged and this branch is rebased.

Thanks! Makes sense, and fixes the bug. :)

Copypasta error... thanks Nate :)

Please wait for @elvisangelaccio's review now. :)

A few more days of waiting may be required since most of the Plasma developers are quite busy right now. But it will get reviewed, don't worry!

GTK+ was recently renamed to GTK (https://mail.gnome.org/archives/gtk-devel-list/2019-February/msg00000.html).

We don't use goto.

In T10258#179033, @aacid wrote:

Hey, i was sent here from https://phabricator.kde.org/D19773#433272

I have some questions:

• This task says "labels throughout Plasma" but then I'm seeing patches to Cantor, Okular and other non Plasma software. Is this on purpose?

• Fix missing rewording

Land on the Plasma/5.15 stable branch please: https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22