mwolff (Milian Wolff)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 16 2015, 7:53 PM (243 w, 14 h)
Availability
Available

Recent Activity

Yesterday

mwolff committed R32:f94e6d297673: Skip clang-provided override items from code completion (authored by mwolff).
Skip clang-provided override items from code completion
Thu, Dec 12, 10:40 PM
mwolff committed R32:7be3e8b50954: Expect new failure in completion of switch labels (authored by mwolff).
Expect new failure in completion of switch labels
Thu, Dec 12, 10:40 PM
mwolff committed R32:275d8778bdc9: Unbreak move-into-source for non-class functions (authored by mwolff).
Unbreak move-into-source for non-class functions
Thu, Dec 12, 10:17 PM
mwolff committed R32:27dcd076f307: Unbreak clang test_problems when running against clang 9.0.0+ (authored by mwolff).
Unbreak clang test_problems when running against clang 9.0.0+
Thu, Dec 12, 10:17 PM
mwolff committed R32:0f271e251203: Remove expected failure for test passing with clang 9 (authored by mwolff).
Remove expected failure for test passing with clang 9
Thu, Dec 12, 10:17 PM
mwolff committed R32:84952f498d2e: lambda init captures are visited starting with clang 9.0.0 (authored by mwolff).
lambda init captures are visited starting with clang 9.0.0
Thu, Dec 12, 10:17 PM
mwolff committed R32:9cbb6f2f84f9: Try a bit harder to find types for look-ahead completion (authored by mwolff).
Try a bit harder to find types for look-ahead completion
Thu, Dec 12, 10:17 PM
mwolff committed R32:d4a791c686ff: partial clang completion tests: remove self-assignment results (authored by mwolff).
partial clang completion tests: remove self-assignment results
Thu, Dec 12, 10:17 PM

Thu, Dec 5

mwolff committed R247:ec2a3b69447d: mark 1.2 as stable (authored by mwolff).
mark 1.2 as stable
Thu, Dec 5, 8:36 PM

Mon, Dec 2

mwolff committed R45:4df3bf969d91: Set version to 1.2.80, i.e. 1.3 alpha 1 (authored by mwolff).
Set version to 1.2.80, i.e. 1.3 alpha 1
Mon, Dec 2, 4:56 PM
mwolff committed R45:9c90967be508: Copy recent elf.h into docker to get libunwind with zlib support (authored by mwolff).
Copy recent elf.h into docker to get libunwind with zlib support
Mon, Dec 2, 4:56 PM
mwolff committed R45:cb4c48b03d19: Set version to 1.2.0 (authored by mwolff).
Set version to 1.2.0
Mon, Dec 2, 4:56 PM
mwolff committed R45:4f1e9784e813: Merge branch '1.1' (authored by mwolff).
Merge branch '1.1'
Mon, Dec 2, 4:11 PM
mwolff committed R45:01a5bcdbcb6e: Fix potential source for uninitialized memory (authored by mwolff).
Fix potential source for uninitialized memory
Mon, Dec 2, 4:08 PM
mwolff committed R45:e02e1a25aa95: Use the new heaptrack icon (authored by mwolff).
Use the new heaptrack icon
Mon, Dec 2, 4:08 PM
mwolff committed R45:bbd3586cdaf2: Port away from deprecated QTreeView::sortByColumn(int) API (authored by mwolff).
Port away from deprecated QTreeView::sortByColumn(int) API
Mon, Dec 2, 4:08 PM
mwolff committed R45:857ac706587f: Port away from deprecated QModelIndex::child API (authored by mwolff).
Port away from deprecated QModelIndex::child API
Mon, Dec 2, 4:08 PM
mwolff committed R45:47692644c587: Fix compile on CentOS 7.7 (authored by mwolff).
Fix compile on CentOS 7.7
Mon, Dec 2, 4:08 PM

Sat, Nov 23

mwolff created T12140: Killing KInit With Fire.
Sat, Nov 23, 11:45 AM · Frameworks, KF6
mwolff created T12139: Cleanup API Documentation.
Sat, Nov 23, 11:37 AM · Frameworks, KF6
mwolff created T12138: QmlObjectSharedEngine.
Sat, Nov 23, 11:36 AM · Frameworks, KF6
mwolff created T12137: QmlObject.
Sat, Nov 23, 11:36 AM · Frameworks, KF6
mwolff added a comment to T12127: move ConfigModule next to KCModule widget counter part.

ConfigModule would be better somewhere else, ideally in the same repository than KCModule (since they solve the same problem, it's just Quick vs Widgets here). There are two ways forward depending on how KConfigWidgets can be realistically streamlined:

Sat, Nov 23, 11:36 AM · Frameworks, KF6
mwolff created T12136: ConfigModule.
Sat, Nov 23, 11:35 AM · Frameworks, KF6
mwolff created T12135: QtQuickSettings.
Sat, Nov 23, 11:35 AM · Frameworks, KF6
mwolff created T12134: QuickViewSharedEngine.
Sat, Nov 23, 11:34 AM · Frameworks, KF6
mwolff created T12133: ManagedTextureNode.
Sat, Nov 23, 11:34 AM · Frameworks, KF6
mwolff created T12132: ImageTexturesCache.
Sat, Nov 23, 11:34 AM · Frameworks, KF6
mwolff created T12131: ConfigPropertyMap.
Sat, Nov 23, 11:33 AM · Frameworks, KF6
mwolff created T12130: KDeclarative API Review.
Sat, Nov 23, 11:33 AM · Frameworks, KF6
mwolff created T12128: port away from Qt Quick Control 1.
Sat, Nov 23, 11:32 AM · Frameworks, KF6
mwolff created T12127: move ConfigModule next to KCModule widget counter part.
Sat, Nov 23, 11:31 AM · Frameworks, KF6
mwolff created T12126: move ConfigPropertyMap to KConfig bindings.
Sat, Nov 23, 11:31 AM · Frameworks, KF6
mwolff created T12125: Move KeySequenceItem to KGlobalAccel.
Sat, Nov 23, 11:30 AM · Frameworks, KF6
mwolff created T12124: icon theme image provider.
Sat, Nov 23, 11:27 AM · Frameworks, KF6
mwolff created T12123: move KWindowSystem bindings.
Sat, Nov 23, 11:26 AM · Frameworks, KF6
mwolff created T12122: KWidgetsAddons.
Sat, Nov 23, 11:26 AM · Frameworks, KF6
mwolff created T12121: Move K18N bindings to K18N.
Sat, Nov 23, 11:24 AM · Frameworks, KF6
mwolff created T12120: NetworkAccessManager.
Sat, Nov 23, 11:23 AM · Frameworks, KF6
mwolff created T12119: KRunProxy [KIO].
Sat, Nov 23, 11:23 AM · Frameworks, KF6

Fri, Nov 22

mwolff added a comment to T11982: KF6 and STL compatibility.

KRandom::random should be removed and QRandomGenerator should be used instead. It has a more expressive API and will actually work properly on platforms without a /dev/urandom.

Fri, Nov 22, 9:18 AM · KF6

Sat, Nov 16

mwolff committed R45:fabfdf9cca39: Remove unused include dir (authored by Volodymyr Nikolaichuk <nikolaychuk.volodymyr@gmail.com>).
Remove unused include dir
Sat, Nov 16, 10:56 PM
mwolff committed R45:1e15381f426e: Fix building heaptrack_inject (authored by Volodymyr Nikolaichuk <nikolaychuk.volodymyr@gmail.com>).
Fix building heaptrack_inject
Sat, Nov 16, 10:56 PM
mwolff committed R45:e65e358cfd45: Add heaptrack_{pause,resume}() API (authored by Volodymyr Nikolaichuk <nikolaychuk.volodymyr@gmail.com>).
Add heaptrack_{pause,resume}() API
Sat, Nov 16, 10:56 PM
mwolff committed R45:db6403f542c0: More build options HEAPTRACK_BUILD_INTERPRET, HEAPTRACK_BUILD_BACKTRACE (authored by Volodymyr Nikolaichuk <nikolaychuk.volodymyr@gmail.com>).
More build options HEAPTRACK_BUILD_INTERPRET, HEAPTRACK_BUILD_BACKTRACE
Sat, Nov 16, 10:56 PM
mwolff committed R45:ae54d99af368: Check for valloc in stdlib.h (authored by Volodymyr Nikolaichuk <nikolaychuk.volodymyr@gmail.com>).
Check for valloc in stdlib.h
Sat, Nov 16, 10:56 PM
mwolff committed R45:8023779f9a3b: Optionally use unwind_tables instead of libunwind (authored by Volodymyr Nikolaichuk <nikolaychuk.volodymyr@gmail.com>).
Optionally use unwind_tables instead of libunwind
Sat, Nov 16, 10:56 PM
mwolff committed R45:8cfa8f557fb5: Remove unused reference from libbacktrace to libunwind (authored by Volodymyr Nikolaichuk <nikolaychuk.volodymyr@gmail.com>).
Remove unused reference from libbacktrace to libunwind
Sat, Nov 16, 10:56 PM

Oct 15 2019

mwolff committed R45:2d14f5de75b9: Allow high priv user to profile low priv user process (authored by Sam Saffron <sam.saffron@gmail.com>).
Allow high priv user to profile low priv user process
Oct 15 2019, 9:07 PM
mwolff committed R45:715edab31dde: Add icons (authored by mwolff).
Add icons
Oct 15 2019, 9:27 AM

Oct 13 2019

mwolff added a comment to D24532: Declare new hash function in namespace std in order to fix build..

pushed now, thanks a lot

Oct 13 2019, 7:28 PM
mwolff closed D24532: Declare new hash function in namespace std in order to fix build..
Oct 13 2019, 7:27 PM
mwolff committed R45:983cc35dd000: Declare new hash function in namespace std in order to fix build. (authored by beischer).
Declare new hash function in namespace std in order to fix build.
Oct 13 2019, 7:27 PM
mwolff added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.
In D24568#545736, @apol wrote:

I'm not sure how this works, but would it be possible to have a target that only works on a patch? You usually want to make sure what you modified didn't diverge from the code.

I think there is some hack around that:
http://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting

But actually, if your sources are already clang-formatted, you just need to run the clang-format target once before you commit, the your new code will be the only thing altered.

Oct 13 2019, 7:24 PM · Build System, Frameworks

Oct 12 2019

mwolff accepted D24532: Declare new hash function in namespace std in order to fix build..

thanks, do you have commit rights to KDE?

Oct 12 2019, 12:30 PM

Oct 8 2019

mwolff accepted D24491: Fix build against Qt without std::hash<QString> specialization.

thanks

Oct 8 2019, 6:42 PM
mwolff committed R44:81ed5eb65459: Find boost when libkolabxml was found (authored by mwolff).
Find boost when libkolabxml was found
Oct 8 2019, 6:30 AM

Oct 7 2019

mwolff added a comment to D22158: Navigation context uses theme color..

e.g. look at https://doc.qt.io/archives/qt-4.8/qcolor.html#predefined-colors

Oct 7 2019, 8:14 PM · KDevelop
mwolff added a comment to D22158: Navigation context uses theme color..

hey! can you also show a screenshot of PHP or Qt documentation showing? these can contain arbitrary HTML and sometimes even contain colored text that expects to be shown on bright backgrounds which would break with this patch. At least that was the case years ago when I worked on this the last time.

Oct 7 2019, 8:14 PM · KDevelop

Oct 3 2019

mwolff accepted D24396: Add more tests for Parser: bottom-up and top-down data.
Oct 3 2019, 7:03 PM

Oct 2 2019

mwolff accepted D24099: Add an ID to Symbol in order to make hashing faster.
Oct 2 2019, 3:15 PM

Sep 24 2019

mwolff requested changes to D24106: Use unordered_map so it scales better.

squash please

Sep 24 2019, 9:17 AM
mwolff requested changes to D24099: Add an ID to Symbol in order to make hashing faster.

please squash with the hash map commit

Sep 24 2019, 9:17 AM
mwolff accepted D24104: Replace std::tie with == in operator==().

sad but OK :(

Sep 24 2019, 9:06 AM

Sep 21 2019

mwolff committed R32:dd2c99254a3b: Merge branch '5.4' (authored by mwolff).
Merge branch '5.4'
Sep 21 2019, 2:40 PM
mwolff committed R32:4676a7bb3e4b: Don't try to run cuda test when cuda isn't installed (authored by mwolff).
Don't try to run cuda test when cuda isn't installed
Sep 21 2019, 2:39 PM
mwolff committed R32:b740e32dec3d: Cache the defines/includes for gcc-like compilers per language type (authored by mwolff).
Cache the defines/includes for gcc-like compilers per language type
Sep 21 2019, 2:39 PM
mwolff committed R32:2d40e10b8309: Only write defines file when needed (authored by mwolff).
Only write defines file when needed
Sep 21 2019, 2:39 PM
mwolff committed R32:768c276b0078: Merge branch '5.4' (authored by mwolff).
Merge branch '5.4'
Sep 21 2019, 2:14 PM
mwolff committed R32:9a91576316ef: Don't set super long name on completely anon structs (authored by mwolff).
Don't set super long name on completely anon structs
Sep 21 2019, 2:13 PM
mwolff committed R32:caf74ff2c373: Merge branch '5.4' (authored by mwolff).
Merge branch '5.4'
Sep 21 2019, 2:00 PM
mwolff committed R32:26ee0da99a0c: Use type name as fallback ID for anon typedef'ed structs/unions etc. (authored by mwolff).
Use type name as fallback ID for anon typedef'ed structs/unions etc.
Sep 21 2019, 2:00 PM
mwolff committed R32:b2b45395dc72: Merge branch '5.4' (authored by mwolff).
Merge branch '5.4'
Sep 21 2019, 12:47 PM
mwolff committed R32:9a545cb9794b: Revert "Use type name as fallback ID for anon typedef'ed structs/unions etc." (authored by mwolff).
Revert "Use type name as fallback ID for anon typedef'ed structs/unions etc."
Sep 21 2019, 12:47 PM
mwolff added a reverting change for R32:a6df33cf7cd7: Use type name as fallback ID for anon typedef'ed structs/unions etc.: R32:9a545cb9794b: Revert "Use type name as fallback ID for anon typedef'ed structs/unions etc.".
Sep 21 2019, 12:47 PM
mwolff committed R32:b963bd861d33: Merge branch '5.4' (authored by mwolff).
Merge branch '5.4'
Sep 21 2019, 12:30 PM
mwolff committed R32:a6df33cf7cd7: Use type name as fallback ID for anon typedef'ed structs/unions etc. (authored by mwolff).
Use type name as fallback ID for anon typedef'ed structs/unions etc.
Sep 21 2019, 12:30 PM
mwolff committed R32:4d175501be3e: Merge branch '5.4' (authored by mwolff).
Merge branch '5.4'
Sep 21 2019, 12:09 AM

Sep 20 2019

mwolff accepted D24095: Use static variable for frequent i18n() call..
Sep 20 2019, 4:42 AM
mwolff accepted D24093: Add benchmark for Parser.

better use stdout/stderr "directly" instead of going through qDebug which could be disabled in a release build

Sep 20 2019, 4:41 AM
mwolff accepted D24106: Use unordered_map so it scales better.
Sep 20 2019, 4:39 AM
mwolff accepted D24105: Add unittest for Parser.
Sep 20 2019, 4:38 AM
mwolff accepted D5447: Only add auto-detected compilers to model if they actually exist.

sorry for the super long delay. I like what I'm seeing - if this works, please commit

Sep 20 2019, 4:13 AM
mwolff added a comment to D22660: Fixed crash when filtering class list.

thanks, applied to 5.4

Sep 20 2019, 4:11 AM · KDevelop
mwolff committed R32:5bff5d65a023: Fixed crash when filtering class list (authored by mdlubakowski).
Fixed crash when filtering class list
Sep 20 2019, 4:11 AM
mwolff closed D22660: Fixed crash when filtering class list.
Sep 20 2019, 4:11 AM · KDevelop
mwolff committed R32:c315333c4aa3: gcclikecompiler: properly resolve include paths with symbolic links (authored by akellermann).
gcclikecompiler: properly resolve include paths with symbolic links
Sep 20 2019, 4:11 AM
mwolff closed D23303: gcclikecompiler: properly resolve include paths containing symbolic links .
Sep 20 2019, 4:07 AM · KDevelop
mwolff accepted D23303: gcclikecompiler: properly resolve include paths containing symbolic links .

done now, thanks a lot!

Sep 20 2019, 4:07 AM · KDevelop
mwolff requested changes to D24099: Add an ID to Symbol in order to make hashing faster.
Sep 20 2019, 4:04 AM
mwolff added a comment to D23303: gcclikecompiler: properly resolve include paths containing symbolic links .

I'll commit this using QFileInfo instead of going through QDir.

Sep 20 2019, 3:51 AM · KDevelop
mwolff accepted D24088: Provide progress information during the "merging allocations" phase.

just pleaes fixup the qMax -> std::max and commit directly

Sep 20 2019, 3:50 AM
mwolff requested changes to D24088: Provide progress information during the "merging allocations" phase.

one minor nit, otherwise lgtm

Sep 20 2019, 3:50 AM

Sep 18 2019

mwolff committed R45:e2d0c0f698e2: Don't show a flame graph tooltip in the empty region (authored by mwolff).
Don't show a flame graph tooltip in the empty region
Sep 18 2019, 12:55 AM
mwolff committed R45:cb50367ac1f1: Don't show empty parens after top most flame graph item's description (authored by mwolff).
Don't show empty parens after top most flame graph item's description
Sep 18 2019, 12:55 AM

Sep 17 2019

mwolff committed R45:f33ac9f63de8: Correctly check for boost iostreams to fix zstd support (authored by mwolff).
Correctly check for boost iostreams to fix zstd support
Sep 17 2019, 7:30 PM

Sep 16 2019

mwolff committed R45:ffbccca9df28: Correctly find item under cursor for flame graph context menu (authored by mwolff).
Correctly find item under cursor for flame graph context menu
Sep 16 2019, 4:07 AM

Aug 7 2019

mwolff committed R285:d97269a6c340: Disable kcrash when running under rr (authored by mwolff).
Disable kcrash when running under rr
Aug 7 2019, 1:52 PM

Jun 25 2019

mwolff committed R216:8b7cac75a7e8: Fix and expand GDB unit test (authored by mwolff).
Fix and expand GDB unit test
Jun 25 2019, 9:27 PM
mwolff committed R216:2accc29f3fef: Add more keywords and also support rr in gdb highlighter (authored by mwolff).
Add more keywords and also support rr in gdb highlighter
Jun 25 2019, 2:10 PM