mwolff (Milian Wolff)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 16 2015, 7:53 PM (157 w, 5 d)
Availability
Available

Recent Activity

Yesterday

mwolff committed R45:215869fbd088: Don't unlock when locking failed in the timer thread (authored by mwolff).
Don't unlock when locking failed in the timer thread
Tue, Apr 24, 2:36 PM
mwolff committed R45:fc4b7ef99d3b: Optionally add helgrind annotations to the custom SpinLock (authored by mwolff).
Optionally add helgrind annotations to the custom SpinLock
Tue, Apr 24, 2:36 PM
mwolff committed R45:03f534bd31b9: Make it easily possible to use a mutex for locking internally (authored by mwolff).
Make it easily possible to use a mutex for locking internally
Tue, Apr 24, 2:36 PM
mwolff committed R45:bc1e9fabc33d: Add a block of libheaptrack API calls from multiple threads (authored by mwolff).
Add a block of libheaptrack API calls from multiple threads
Tue, Apr 24, 11:25 AM
mwolff committed R45:a5c9c9fea0ca: Add an initial test for the libheaptrack code (authored by mwolff).
Add an initial test for the libheaptrack code
Tue, Apr 24, 11:25 AM

Mon, Apr 23

mwolff added a comment to D12298: Group completion requests and only handle the last one.

@brauch did you notice any issues? if not, can you accept this then I'll push it.

Mon, Apr 23, 1:57 PM
mwolff committed R45:06ad0cffc415: Open output file with O_CLOEXEC (authored by mwolff).
Open output file with O_CLOEXEC
Mon, Apr 23, 11:45 AM
mwolff committed R45:8990817a2697: Lock the output file to ensure only one process writes to it (authored by mwolff).
Lock the output file to ensure only one process writes to it
Mon, Apr 23, 10:30 AM
mwolff committed R45:77f1e068b292: Try to handle EINTR when writing data (authored by mwolff).
Try to handle EINTR when writing data
Mon, Apr 23, 10:30 AM
mwolff committed R45:d16bcef32b0e: Handle potential write errors when printing trace indices (authored by mwolff).
Handle potential write errors when printing trace indices
Mon, Apr 23, 10:30 AM
mwolff committed R45:51f3ad78630b: Initialize the start time on first use (authored by mwolff).
Initialize the start time on first use
Mon, Apr 23, 10:30 AM
mwolff committed R45:21cc73316128: Print backtraces when encountering a write error (authored by mwolff).
Print backtraces when encountering a write error
Mon, Apr 23, 10:30 AM
mwolff committed R45:84e2e282d83c: Output elapsed time in debug messages (authored by mwolff).
Output elapsed time in debug messages
Mon, Apr 23, 10:30 AM
mwolff committed R45:a0623a3253cb: Don't handle allocations from printf calls in debugLog calls (authored by mwolff).
Don't handle allocations from printf calls in debugLog calls
Mon, Apr 23, 10:30 AM
mwolff committed R45:099bb032c224: Use check_c_source_compiles to find libunwind capabilities (authored by mwolff).
Use check_c_source_compiles to find libunwind capabilities
Mon, Apr 23, 10:30 AM
mwolff committed R45:2bf512817ce9: Print the pid and tid in heaptrack log messages (authored by mwolff).
Print the pid and tid in heaptrack log messages
Mon, Apr 23, 10:30 AM
mwolff committed R45:6ee4e3e836fd: Print heaptrack_interpret stats even when it gets terminated (authored by mwolff).
Print heaptrack_interpret stats even when it gets terminated
Mon, Apr 23, 10:30 AM

Sun, Apr 22

mwolff committed R45:dfb6123a6b1c: Do not use shell to launch new programs in debug mode (authored by mwolff).
Do not use shell to launch new programs in debug mode
Sun, Apr 22, 8:15 AM
mwolff committed R45:0a3c45c904e1: Start GDB in quiet mode to reduce amount of console output (authored by mwolff).
Start GDB in quiet mode to reduce amount of console output
Sun, Apr 22, 8:15 AM
mwolff committed R45:a6839d6f36df: Error out early during recording when receiving child process events (authored by mwolff).
Error out early during recording when receiving child process events
Sun, Apr 22, 8:15 AM
mwolff committed R45:e253b08794c6: Mark files with duplicated debuggee entries as corrupt (authored by mwolff).
Mark files with duplicated debuggee entries as corrupt
Sun, Apr 22, 7:48 AM
mwolff added a comment to D12331: Always use the clang builtin headers for the libclang version we use.

To query what include files you got, the easiest really is to define the KDEV_CLANG_DISPLAY_ARGS=1 env var. Then you'll see the command line we use for libclang, which includes the include paths. Defines could be queried by setting KDEV_CLANG_DISPLAY_DEFINES=1.

Sun, Apr 22, 7:47 AM

Thu, Apr 19

mwolff added a comment to D12331: Always use the clang builtin headers for the libclang version we use.
In D12331#249727, @apol wrote:

It broke my system... It's looking for all classes in my projects into std::, failing and complaining about it. :'(

Thu, Apr 19, 3:23 PM
mwolff added inline comments to D12331: Always use the clang builtin headers for the libclang version we use.
Thu, Apr 19, 1:00 PM
mwolff updated subscribers of D12331: Always use the clang builtin headers for the libclang version we use.

Very good. Now I'd like to get some feedback from @apol to see how this works with his android toolchain. I'll also test this later with an arm toolchain and see if it works as expected.

Thu, Apr 19, 10:02 AM

Wed, Apr 18

mwolff added a comment to D11136: Make sure we use the same compiler settings as the project is by default.

Everyone, please test https://phabricator.kde.org/D12331

Wed, Apr 18, 9:34 PM
mwolff requested review of D12331: Always use the clang builtin headers for the libclang version we use.
Wed, Apr 18, 9:33 PM
mwolff committed R32:b3f4f843df4c: Set CLANG_VERSION in FindClang.cmake (authored by mwolff).
Set CLANG_VERSION in FindClang.cmake
Wed, Apr 18, 9:32 PM
mwolff committed R32:c52e0da40911: Remove empty file (authored by mwolff).
Remove empty file
Wed, Apr 18, 9:32 PM
mwolff added a comment to D9344: [KDevelop] : consistent use of the project name (WIP).

Done, Rene - feel free to respin with the issue fixed.

Wed, Apr 18, 8:44 PM · KDevelop
mwolff added a reverting change for R32:a44554ef038a: Use the project name more consistently: R32:d92762a04184: Revert "Use the project name more consistently".
Wed, Apr 18, 8:44 PM
mwolff committed R32:d92762a04184: Revert "Use the project name more consistently" (authored by mwolff).
Revert "Use the project name more consistently"
Wed, Apr 18, 8:44 PM
mwolff committed R32:ffd253c4688d: Also handle -std=gnu++... as C++ (authored by mwolff).
Also handle -std=gnu++... as C++
Wed, Apr 18, 8:44 PM
mwolff added a comment to D9344: [KDevelop] : consistent use of the project name (WIP).

Let's revert and then we can fix it later. This patch is imo less important than a working generic manager. I'll apply the revert now.

Wed, Apr 18, 8:43 PM · KDevelop
mwolff added a comment to D12298: Group completion requests and only handle the last one.

ok let's see

Wed, Apr 18, 11:09 AM
mwolff added a reviewer for D12298: Group completion requests and only handle the last one: KDevelop.
Wed, Apr 18, 11:08 AM

Tue, Apr 17

mwolff added a comment to D12298: Group completion requests and only handle the last one.

I'd appreciate if others could give this a spin and report back whether it is improving things or not.

Tue, Apr 17, 10:24 PM
mwolff requested review of D12298: Group completion requests and only handle the last one.
Tue, Apr 17, 10:23 PM
mwolff accepted D12279: shell: Display generic project managers again.

lgtm, @kossebau?

Tue, Apr 17, 12:04 PM
mwolff committed R32:c2f335943144: Use stable sort to ensure we don't randomly reorder items (authored by mwolff).
Use stable sort to ensure we don't randomly reorder items
Tue, Apr 17, 12:00 PM

Mon, Apr 16

mwolff committed R45:1a0dabbedee8: Open heaptrack data files even when -a / --analyze are not specified (authored by mwolff).
Open heaptrack data files even when -a / --analyze are not specified
Mon, Apr 16, 6:33 PM
mwolff committed R45:70e6a1ddb221: Also properly handle whitespaces in AppImage wrapped heaptrack_gui (authored by mwolff).
Also properly handle whitespaces in AppImage wrapped heaptrack_gui
Mon, Apr 16, 5:58 PM
mwolff committed R45:5d584ed98909: Further improve handling of paths with whitespaces (authored by mwolff).
Further improve handling of paths with whitespaces
Mon, Apr 16, 3:20 PM
mwolff committed R45:c21195fe9a30: Properly handle whitespaces when invoking heaptrack --analyze (authored by mwolff).
Properly handle whitespaces when invoking heaptrack --analyze
Mon, Apr 16, 2:22 PM
mwolff added a comment to D12220: [RFC] Beautify declaration navigation context by parsing doxygen commands.

There's qdoc, doxypress, proprietary custom formatting styles... Comments are free form after all, anything might be in there.

Mon, Apr 16, 11:26 AM
mwolff committed R216:88288f834175: Add highlighting for GDB command listings and gdbinit files (authored by mwolff).
Add highlighting for GDB command listings and gdbinit files
Mon, Apr 16, 9:09 AM
mwolff closed D11902: Add highlighting for GDB command listings and gdbinit files.
Mon, Apr 16, 9:09 AM · Frameworks
mwolff added a comment to D11902: Add highlighting for GDB command listings and gdbinit files.

Ping? Or can I just commit?

Mon, Apr 16, 9:03 AM · Frameworks
mwolff added a comment to D12220: [RFC] Beautify declaration navigation context by parsing doxygen commands.

I'm very unsure about this. On one hand, this obviously looks better in your screenshots. On the other hand, what if we encounter comments that are formatted with some other syntax? Most notably consider how your code would lead to broken HTML quite easily, e.g. when only part of a match is encountered (such as only \f\[ but no \f\]).

Mon, Apr 16, 9:02 AM

Fri, Apr 13

mwolff committed R45:e1699eed9e40: update .travis.yml to fix appimage generation (authored by mwolff).
update .travis.yml to fix appimage generation
Fri, Apr 13, 8:04 PM

Tue, Apr 10

mwolff added a comment to D12016: [ktexteditor] much faster positionFromCursor.

some nits, otherwise lgtm assuming all tests pass

Tue, Apr 10, 8:13 PM · Frameworks, Kate

Mon, Apr 9

mwolff committed R32:075ef63cf296: Reformat to indent width 4 (authored by mwolff).
Reformat to indent width 4
Mon, Apr 9, 6:31 PM
mwolff committed R32:db0c63709ce1: Output paths when there's a mismatch (authored by mwolff).
Output paths when there's a mismatch
Mon, Apr 9, 6:31 PM
mwolff committed R32:a4f48fd591ed: Penalize matches in the shared project prefix path (authored by mwolff).
Penalize matches in the shared project prefix path
Mon, Apr 9, 6:31 PM
mwolff committed R32:0d38ff7cdd48: Prefer matches closer to the end of the path (authored by mwolff).
Prefer matches closer to the end of the path
Mon, Apr 9, 6:31 PM
mwolff closed D11940: Penalize matches in the shared project prefix path.
Mon, Apr 9, 6:31 PM
mwolff closed D11939: Prefer matches closer to the end of the path.
Mon, Apr 9, 6:31 PM
mwolff committed R32:490ebbc3b6df: Simplify code and remove duplicate loop to find exact matches (authored by mwolff).
Simplify code and remove duplicate loop to find exact matches
Mon, Apr 9, 6:31 PM
mwolff committed R32:80331a7dab60: Run match filter loop in reverse order from the end of the path (authored by mwolff).
Run match filter loop in reverse order from the end of the path
Mon, Apr 9, 6:31 PM
mwolff closed D11938: Simplify code and remove duplicate loop to find exact matches.
Mon, Apr 9, 6:31 PM
mwolff closed D11937: Run match filter loop in reverse order from the end of the path.
Mon, Apr 9, 6:31 PM
mwolff committed R32:a016f25bb993: Refactor matchPathFilter to enable more advanced result sorting (authored by mwolff).
Refactor matchPathFilter to enable more advanced result sorting
Mon, Apr 9, 6:31 PM
mwolff closed D11936: Refactor matchPathFilter to enable more advanced result sorting.
Mon, Apr 9, 6:31 PM
mwolff added inline comments to D11940: Penalize matches in the shared project prefix path.
Mon, Apr 9, 12:02 PM

Fri, Apr 6

mwolff updated the diff for D11940: Penalize matches in the shared project prefix path.

fix a corner case where we miscalculated the inPrefixPath

Fri, Apr 6, 10:46 AM

Thu, Apr 5

mwolff accepted D9344: [KDevelop] : consistent use of the project name (WIP).

ok, let's go for it then

Thu, Apr 5, 8:39 AM · KDevelop

Wed, Apr 4

mwolff requested review of D11940: Penalize matches in the shared project prefix path.
Wed, Apr 4, 11:34 PM
mwolff requested review of D11939: Prefer matches closer to the end of the path.
Wed, Apr 4, 11:33 PM
mwolff requested review of D11938: Simplify code and remove duplicate loop to find exact matches.
Wed, Apr 4, 11:33 PM
mwolff requested review of D11937: Run match filter loop in reverse order from the end of the path.
Wed, Apr 4, 11:32 PM
mwolff requested review of D11936: Refactor matchPathFilter to enable more advanced result sorting.
Wed, Apr 4, 11:32 PM
mwolff committed R32:9b4ef75aa73e: Don't export the matchesAbbreviationHelper function (authored by mwolff).
Don't export the matchesAbbreviationHelper function
Wed, Apr 4, 9:23 PM
mwolff committed R32:5b9b5c1e1a01: Only do fuzzy path matching on the very last path/filter segments (authored by mwolff).
Only do fuzzy path matching on the very last path/filter segments
Wed, Apr 4, 9:23 PM
mwolff closed D11933: Only do fuzzy path matching on the very last path/filter segments.
Wed, Apr 4, 9:23 PM
mwolff requested review of D11933: Only do fuzzy path matching on the very last path/filter segments.
Wed, Apr 4, 8:19 PM
mwolff committed R32:e9b0a34047dc: CMake Server: Reuse existing build directory path when available (authored by mwolff).
CMake Server: Reuse existing build directory path when available
Wed, Apr 4, 6:56 PM
mwolff closed D11921: CMake Server: Reuse existing build directory path when available.
Wed, Apr 4, 6:56 PM
mwolff added a comment to D11921: CMake Server: Reuse existing build directory path when available.

I'll push this to master then and we can cherry pick it to 5.2 after you guys did the next release

Wed, Apr 4, 6:55 PM
mwolff updated subscribers of D11921: CMake Server: Reuse existing build directory path when available.

should it go to master, or 5.2? @brauch, @kfunk? I'd like others to test this too first before landing in 5.2, since I've never used CMAKE_CACHEFILE_DIR before and am not sure if it's OK to use it like this.

Wed, Apr 4, 11:42 AM
mwolff added a comment to D11921: CMake Server: Reuse existing build directory path when available.

@rjvbb does this solve issues you are having and trying to workaround with https://phabricator.kde.org/D7930 ?

Wed, Apr 4, 11:08 AM
mwolff updated the diff for D11921: CMake Server: Reuse existing build directory path when available.

remove unrelated changes (oh how I hate arc)

Wed, Apr 4, 11:07 AM
mwolff requested review of D11921: CMake Server: Reuse existing build directory path when available.
Wed, Apr 4, 11:06 AM
mwolff committed R32:cd35dbbe4db3: De-inline path matching code from quick open filter template class (authored by mwolff).
De-inline path matching code from quick open filter template class
Wed, Apr 4, 11:01 AM
mwolff committed R32:07fb377c6444: Properly namespace abbreviation match functions (authored by mwolff).
Properly namespace abbreviation match functions
Wed, Apr 4, 11:01 AM
mwolff committed R32:85995a9cfe52: Use more specific include (authored by mwolff).
Use more specific include
Wed, Apr 4, 11:01 AM
mwolff accepted D11811: avoid Asan runtime error: shift exponent -1 is negative.

thanks

Wed, Apr 4, 10:23 AM · Frameworks, Kate
mwolff added a comment to D9344: [KDevelop] : consistent use of the project name (WIP).
In D9344#239331, @rjvbb wrote:

> projectcontroller.cpp:443

I don't get this change, can you explain? the old code checks whether the profileFileUrl (which should *always* ends on .kdev4, no?) exists. In that case, we want to ask the user if he wants to override, except if the project file is equal to what we'd write out anyways.

"Except", are you sure about that? I'm pretty certain I got the override dialog when I forced a new import from, say, the project's CMake file, and <dirname>.kdev4 existed already.

Wed, Apr 4, 10:21 AM · KDevelop
mwolff accepted D11912: Avoid emptry entries in project files filter list.

add a comment explaining why this happens, but otherwise lgtm

Wed, Apr 4, 9:53 AM

Tue, Apr 3

mwolff requested changes to D9344: [KDevelop] : consistent use of the project name (WIP).
Tue, Apr 3, 7:59 PM · KDevelop
mwolff added a comment to D11685: Implement single click on line number to select line of text.

the "also" in your commit message: can you split this commit into two parts, or is the feature addition also fixing the bug? Put differently: Could you first fix the bug, then add the feature, in separate commits?

Tue, Apr 3, 7:53 PM · Frameworks, Kate
mwolff added a comment to D11785: Add kcolorschemechooser support and related setting menu entry.

instead of duplicating it further, could we move the code into ktexteditor and make it reusable from there?

Tue, Apr 3, 7:48 PM · Kate
mwolff accepted D11823: Note org.kdevelop.IBasicVersionControl@kdevgit as dep for kdevghprovider.
Tue, Apr 3, 7:47 PM
mwolff added a comment to D11811: avoid Asan runtime error: shift exponent -1 is negative.

maybe instead make it explicit what the old code did instead? i.e. check what you get from GCC for "1 << -1" and then use that when i == 0

Tue, Apr 3, 7:46 PM · Frameworks, Kate
mwolff accepted D7909: Add syntax support for Crystal Programming Language.

we got a test file, and it seems to work for a user of the Crystal language, so +1 from my side. @dhaumann, @cullmann ?

Tue, Apr 3, 7:42 PM · Kate, Frameworks, Framework: Syntax Highlighting
mwolff accepted D11822: Make the word/char count a global preference.

I'm not using that feature, but code-wise this lgtm - but please wait for @dhaumann or @cullmann to give their +1 too

Tue, Apr 3, 7:38 PM · Frameworks, Kate
mwolff added a comment to D11487: optimization of TextLineData::attribute.

Ah, I knew it :D I suspected missing compiler optimizations from the start... But tricky indeed for you to see!

Tue, Apr 3, 4:24 PM · Frameworks, Kate
mwolff committed R45:fd2d184f0e8a: Allow to open zst files from the GUI easily (authored by mwolff).
Allow to open zst files from the GUI easily
Tue, Apr 3, 3:31 PM
mwolff committed R45:7ae3f595a0ea: Make heaptrack.sh file compatible with dash (authored by mwolff).
Make heaptrack.sh file compatible with dash
Tue, Apr 3, 1:31 PM
mwolff added reviewers for D11902: Add highlighting for GDB command listings and gdbinit files: vkrause, dhaumann, Kate.
Tue, Apr 3, 12:04 PM · Frameworks
mwolff requested review of D11902: Add highlighting for GDB command listings and gdbinit files.
Tue, Apr 3, 12:04 PM · Frameworks