mwolff (Milian Wolff)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 16 2015, 7:53 PM (105 w, 4 d)
Availability
Available

Recent Activity

Tue, Apr 18

mwolff added a comment to D5491: Improve detection of builtin defines from compiler command.

excellent test coverage, much appreciated, some nitpick notes

Tue, Apr 18, 2:59 PM

Mon, Apr 17

mwolff committed R45:3cb1b7fd2f4b: Call libc and libstdc++ freeres functions in heaptrack_preload on exit (authored by mwolff).
Call libc and libstdc++ freeres functions in heaptrack_preload on exit
Mon, Apr 17, 7:17 PM

Thu, Apr 13

mwolff requested changes to D5425: Allow disabling the git plugin with a kdevgit.disabled git config option.

can we first profile it and see if we can speed it up instead of applying such a (imo) nasty workaround?

Thu, Apr 13, 1:55 PM

Fri, Apr 7

mwolff committed R45:e203d56632b9: Disable signal handling in timer thread (authored by mwolff).
Disable signal handling in timer thread
Fri, Apr 7, 12:27 PM

Thu, Apr 6

mwolff committed R45:1bab9e49229c: Add missing include directory (authored by Erwin Jansen <jansene@google.com>).
Add missing include directory
Thu, Apr 6, 8:24 AM
mwolff committed R74:a4c9ab29ef25: Setup {DY,}LD_LIBRARY_PATH in clazy shell script (authored by mwolff).
Setup {DY,}LD_LIBRARY_PATH in clazy shell script
Thu, Apr 6, 8:22 AM
mwolff closed D5298: Setup LD_LIBRARY_PATH in clazy shell script by committing R74:a4c9ab29ef25: Setup {DY,}LD_LIBRARY_PATH in clazy shell script.
Thu, Apr 6, 8:22 AM

Wed, Apr 5

mwolff added a comment to T1841: heaptrack: support debuglink and UUID for split debug info.

A WIP for this can be found in wip/buildid, it will include the buildid in the heaptrack file. But for interpreting, it isn't enough to just load the debug file only. It has to be used in addition apparently, which isn't possible without patching libbacktrace like is done in vogl.

Wed, Apr 5, 11:09 AM · Performance Tooling, Heaptrack
mwolff committed R45:f335efc89018: WIP: Include the build-id in the heaptrack output and use it to find libs (authored by mwolff).
WIP: Include the build-id in the heaptrack output and use it to find libs
Wed, Apr 5, 11:01 AM
mwolff committed R45:44fe3887133b: Add a manual executable to investigate dl_iterate_phdr contents (authored by mwolff).
Add a manual executable to investigate dl_iterate_phdr contents
Wed, Apr 5, 11:01 AM

Tue, Apr 4

mwolff committed R45:c513793b8a43: Prefer $lib.debug files over $lib files, if available (authored by mwolff).
Prefer $lib.debug files over $lib files, if available
Tue, Apr 4, 3:40 PM
mwolff updated the diff for D5298: Setup LD_LIBRARY_PATH in clazy shell script.

also update DYLD_LIBRARY_PATH

Tue, Apr 4, 12:32 PM
mwolff created D5298: Setup LD_LIBRARY_PATH in clazy shell script.
Tue, Apr 4, 11:52 AM
mwolff committed R45:743a628be73d: Add a script to anonymize profiling data (authored by mgolov).
Add a script to anonymize profiling data
Tue, Apr 4, 7:34 AM
mwolff closed D5288: Add a script to anonymize profiling data by committing R45:743a628be73d: Add a script to anonymize profiling data (authored by mgolov).
Tue, Apr 4, 7:34 AM
mwolff committed R45:ef3632ff8fc3: Add .arcconfig file (authored by mwolff).
Add .arcconfig file
Tue, Apr 4, 7:34 AM

Mon, Apr 3

mwolff accepted D5288: Add a script to anonymize profiling data.

lgtm, I can also add the copyright header for you and submit it then later when I get the time

Mon, Apr 3, 4:26 PM

Sun, Apr 2

mwolff committed R45:aecd0c2d6162: Enable rubber-band zooming in charts (authored by mwolff).
Enable rubber-band zooming in charts
Sun, Apr 2, 6:58 PM
mwolff committed R45:ccdc14bfaa43: Properly fail to parse lines of two or one chars (authored by mwolff).
Properly fail to parse lines of two or one chars
Sun, Apr 2, 6:58 PM

Wed, Mar 29

mwolff added a comment to D5188: [WIP] Basic support for building Go projects..

can go project be detected based on some file? If so, could you add something like this to the json file please:

Wed, Mar 29, 9:23 PM
mwolff requested changes to D5210: Proper CUDA handling.
Wed, Mar 29, 9:19 PM
mwolff added a comment to D5210: Proper CUDA handling.

I think you are still abusing the code architecture for compiler support here.

Wed, Mar 29, 9:19 PM
mwolff accepted D5244: Port and reenable KGraphViewer support.

if it shows a graph, lgtm :)

Wed, Mar 29, 9:14 PM

Tue, Mar 28

mwolff added a comment to D5210: Proper CUDA handling.

the screenshot shows "c++11" as Cuda C profile - is that correct?

Tue, Mar 28, 9:07 AM
mwolff added a comment to D5139: VCS commit message width feedback.

I'm still against messing with the font styles the way you do it. simply add underlines for the part that is longer than N chars and add a tooltip for that part such that people know what's happening

Tue, Mar 28, 9:06 AM · KDevelop

Mon, Mar 27

mwolff requested changes to D5139: VCS commit message width feedback.
Mon, Mar 27, 8:20 PM · KDevelop
mwolff added a comment to D3041: Enable zoom feature in built-in documentation widgets.

still lgtm, do you have commit rights?

Mon, Mar 27, 8:15 PM
mwolff added a comment to D3040: Allow scaling documentation view (BUG 285162).

still lgtm, do you have commit rights?

Mon, Mar 27, 8:15 PM
mwolff added a comment to T5733: Better CUDA Support.

I think it's OK to rely on clang only for cuda and not support GCC emulation. This doesn't even really work properly for C++ either, so don't go down that rabbit hole.

Mon, Mar 27, 8:11 PM · KDevelop
mwolff added a comment to D5183: Reopen accidentally closed tab.

@coopht: Your points re recent files are very valid - let's not use it.

Mon, Mar 27, 8:06 PM
mwolff requested changes to D5188: [WIP] Basic support for building Go projects..
Mon, Mar 27, 8:04 PM

Sun, Mar 26

mwolff requested changes to D5183: Reopen accidentally closed tab.

I like the change in general, only wonder whether we need to introduce a new queue for that - can't we reuse the recent file mechanism instead? or do people really want to have an infinite history here?

Sun, Mar 26, 9:59 PM

Mar 23 2017

mwolff added a comment to T5733: Better CUDA Support.

We are explicitly excluding the standard includes for C and C++, so maybe something like that accidentally happens for cuda, too? Cf. nostdinc.

Mar 23 2017, 2:16 PM · KDevelop
mwolff added a comment to D5102: Add scroll-barmarks also to the built-in search&replace.

Yes, please reserve it.

Mar 23 2017, 2:11 PM · Frameworks

Mar 22 2017

mwolff committed R32:903e54347f7b: Workaround cmake server bug that gets confused on symlinks (authored by mwolff).
Workaround cmake server bug that gets confused on symlinks
Mar 22 2017, 2:50 PM
mwolff committed R32:e1500e1f382e: Use canonical paths for file-specific information from cmake server (authored by mwolff).
Use canonical paths for file-specific information from cmake server
Mar 22 2017, 2:50 PM
mwolff requested changes to D4772: projectmanagerview: Make cut-paste work by fixing project manager's Paste action.
Mar 22 2017, 8:59 AM
mwolff accepted D3040: Allow scaling documentation view (BUG 285162).

remove the moc, then feel free to push

Mar 22 2017, 8:59 AM

Mar 20 2017

mwolff committed R32:e40751cda601: Resolve {MOC,OBJECTS,UI}_DIR relative to build directory (authored by mwolff).
Resolve {MOC,OBJECTS,UI}_DIR relative to build directory
Mar 20 2017, 10:30 PM
mwolff committed R32:665385366748: Add all .pro files to qmake project root file item. (authored by mwolff).
Add all .pro files to qmake project root file item.
Mar 20 2017, 10:30 PM
mwolff committed R170:06286490b2e2: Fix build: use MailTransportAkonadi to find messagequeuejob.h (authored by mwolff).
Fix build: use MailTransportAkonadi to find messagequeuejob.h
Mar 20 2017, 10:44 AM
mwolff requested changes to D5041: Port away from QtWebKit to QtWebEngine.
Mar 20 2017, 9:12 AM
mwolff added inline comments to D4772: projectmanagerview: Make cut-paste work by fixing project manager's Paste action.
Mar 20 2017, 9:09 AM

Mar 19 2017

mwolff committed R32:73d051aa33de: Fix CMake::readCacheValues to actually read values from the cache (authored by mwolff).
Fix CMake::readCacheValues to actually read values from the cache
Mar 19 2017, 2:38 PM
mwolff accepted D5043: Split ContextMenuExtension::AnalyzeGroup to File/Project groups.
Mar 19 2017, 1:26 PM
mwolff requested changes to D4234: Change algorithm for autobrace..

I'm personally all for improving the status quo, but I think the biggest problem here is that we have no unit test coverage (or do we?). The unit tests would also clearly show the advantage of this new beheavior compared to the old one. So: Could you add unit tests?

Mar 19 2017, 1:25 PM · Frameworks
mwolff requested changes to D5044: Move "Analyze" menu items into "Code" menu.

@dfaure Is there a way to give actions in the "configure shortcuts" action a different name from what is shown by menus?

Mar 19 2017, 1:24 PM
mwolff accepted D3041: Enable zoom feature in built-in documentation widgets.

lgtm, but please ensure that you squash your commits before pushing this

Mar 19 2017, 1:22 PM
mwolff requested changes to D5041: Port away from QtWebKit to QtWebEngine.

QtWebKit is actually more alive nowadays than in a long time, so I still think the best way forward would be to wrap it in a thin KF5-material wrapper and use that here

Mar 19 2017, 1:19 PM
mwolff requested changes to D4953: Fix cleanup when tracking is interrupted by user.

Can you please add more information? I also use "^C" to interrupt tracking and that used to work just fine for me. What is going wrong? Why is your trap line required? Add all of this information to the commit message

Mar 19 2017, 1:18 PM
mwolff requested changes to D4772: projectmanagerview: Make cut-paste work by fixing project manager's Paste action.

sorry for the delay Alexander

Mar 19 2017, 1:15 PM
mwolff requested changes to D3040: Allow scaling documentation view (BUG 285162).

some minor nitpicks. imo feel free to commit after fixing those

Mar 19 2017, 1:04 PM
mwolff accepted D4995: Fix DB inconsistency due to some docterms appearing with uppercase symbols.

do you have commit rights? otherwise someone from us can commit this for you

Mar 19 2017, 12:59 PM · Frameworks
mwolff accepted D4816: Fix bug 375557 "No indication of cppcheck being run in background".

we need to wait for the other change to get in first of course

Mar 19 2017, 12:58 PM
mwolff requested changes to D4884: Add ProblemModel::setPlaceHolderText() method.
Mar 19 2017, 12:56 PM

Mar 16 2017

mwolff added a comment to D5042: Port away from QtWebKit into QtWebEngine.

QTextDocument won't be enough for our purposes. We actually embed e.g. the remote PHP documentation here. And even simple HTML features are not supported by QTextDocument.

Mar 16 2017, 12:46 PM

Mar 11 2017

mwolff added a comment to T5396: "create another" for task reports.

OK, but that's still not very user-friendly as

Mar 11 2017, 8:01 PM · Phabricator

Mar 9 2017

mwolff added a comment to T5427: allow to review commit messages.

See also: https://phabricator.kde.org/T5381

Mar 9 2017, 10:32 AM · Phabricator
mwolff added a comment to T5396: "create another" for task reports.

How did you create that? How would I create a new one? How is this accessible to new users, i.e. not me?

Mar 9 2017, 10:32 AM · Phabricator
mwolff added a comment to T5427: allow to review commit messages.

I know Phab is not Gerrit. But Gerrit is an excellent review tool, so what is wrong in making use of the good features in it? It's super ignorant to say "I'm after a Gerrit centric workflow". I'm after a _good_ review workflow. Gerrit just happens to be one.

Mar 9 2017, 10:31 AM · Phabricator
mwolff added a comment to T5437: arcanist: option to ignore untracked files.

+100 to what dfaure said, totally in sync to my view of the upstream people

Mar 9 2017, 10:28 AM · Phabricator
mwolff closed T5401: replacement for projects.kde.org as "Resolved".

works for me: https://phabricator.kde.org/tag/kdevelop/

Mar 9 2017, 10:27 AM · Phabricator
mwolff added a comment to T5407: grouped queries cannot be viewed by anonymous users.

Yes, I want to show a bucketed view for the overall project.

Mar 9 2017, 10:24 AM · Phabricator
mwolff added a comment to T5079: Differential: provide Bug and Branch fields.

See https://phabricator.kde.org/D4665 <-- so probably this is again an issue when people are not using arcanist. We must get a way to add that info for these people, too. But that will only be done once we get the proper git integration, right? Is there any ETA on it? Or will it be "sometime" and we will have to make do with the broken workflow?

Mar 9 2017, 10:22 AM · Phabricator

Mar 6 2017

mwolff added a comment to D4947: [KTextEditor] Expose additional internal View's functionality to the public API.

Milian had in mind that you can take charge of Kompare and implement your ideas rather than release new app. :)

Mar 6 2017, 1:47 PM · Frameworks

Mar 5 2017

mwolff committed R45:4d82c36360fb: Merge branch '1.0' (authored by mwolff).
Merge branch '1.0'
Mar 5 2017, 11:42 PM
mwolff committed R45:0e0d481c7177: Update README.md (authored by muo jp <muo@muo.jp>).
Update README.md
Mar 5 2017, 11:41 PM
mwolff requested changes to D4947: [KTextEditor] Expose additional internal View's functionality to the public API.

now that this API becomes public, it must be improved to make it better understandable to the public

Mar 5 2017, 10:24 PM · Frameworks
mwolff added a comment to D4914: Reorganize "Run" menu.

lgtm in principle, but I find it odd that to is lower-cased, but With is uppercased

Mar 5 2017, 10:07 PM
mwolff requested changes to D4772: projectmanagerview: Make cut-paste work by fixing project manager's Paste action.
Mar 5 2017, 10:05 PM
mwolff accepted D4912: Add KDevelop::IRunController::showConfigurationDialog() method.

lgtm

Mar 5 2017, 9:55 PM
mwolff committed R45:be0887531856: Only decrease leaked allocations counter for known allocations (authored by mwolff).
Only decrease leaked allocations counter for known allocations
Mar 5 2017, 9:54 PM
mwolff accepted D4888: Fix "Uninitialized struct member" cppcheck error.

yep, lgtm - thanks!

Mar 5 2017, 9:51 PM
mwolff accepted D4902: Support of Class::{expr}() syntax from Php 5.4.

lgtm, esp. since a test is added

Mar 5 2017, 9:50 PM · KDevelop
mwolff committed R45:932defacaa60: Improve cleanup after detaching heaptrack (authored by mwolff).
Improve cleanup after detaching heaptrack
Mar 5 2017, 9:48 PM
mwolff requested changes to D4910: Initial version of Heaptrack analyzer plugin.

cool :)

Mar 5 2017, 8:02 PM
mwolff requested changes to D4816: Fix bug 375557 "No indication of cppcheck being run in background".
Mar 5 2017, 7:42 PM
mwolff requested changes to D3040: Allow scaling documentation view (BUG 285162).

lgtm in principle, but there are two checks that imo need to be removed to cleanup the code. it's not a good idea to be overly pedantic in code, rather use assertions like we do elsewhere

Mar 5 2017, 7:39 PM
mwolff requested changes to D4884: Add ProblemModel::setPlaceHolderText() method.
Mar 5 2017, 7:34 PM
mwolff requested changes to D4883: Add new constructor for KDevelop::DetectedProblem class.

As-is, this is not a good approach imo. Either have it as generic API in iproblem.h (which would mean you'd also need to serialize the data in problem.cpp), or have it as a special case for the detected problem and only use it there

Mar 5 2017, 7:32 PM
mwolff accepted D4930: Add basic support for parsing OpenCL.

nice!

Mar 5 2017, 7:26 PM

Feb 26 2017

mwolff committed R45:2062edcd10ce: Exclude unresolved functions from recursion detection. (authored by mwolff).
Exclude unresolved functions from recursion detection.
Feb 26 2017, 9:06 PM
mwolff committed R45:2af66156ec98: Remove now-dead code (authored by mwolff).
Remove now-dead code
Feb 26 2017, 8:52 PM
mwolff committed R45:3a34d54697e2: Merge branch '1.0' (authored by mwolff).
Merge branch '1.0'
Feb 26 2017, 8:36 PM
mwolff committed R45:b77cd26eaa1b: Improve the bottom-up conversion to top-down and caller/callee data (authored by mwolff).
Improve the bottom-up conversion to top-down and caller/callee data
Feb 26 2017, 8:36 PM

Feb 23 2017

mwolff committed R33:83806b265b18: Show all KTextEditor view bars in a central location (authored by mwolff).
Show all KTextEditor view bars in a central location
Feb 23 2017, 7:48 PM
mwolff closed D4657: Show all KTextEditor view bars in a central location by committing R33:83806b265b18: Show all KTextEditor view bars in a central location.
Feb 23 2017, 7:47 PM · KDevelop
mwolff committed R45:021f593ef1ef: Enable alternating row colors for caller/callee view (authored by mwolff).
Enable alternating row colors for caller/callee view
Feb 23 2017, 9:29 AM
mwolff committed R45:e3b6d8281473: Move top-view properties to .ui file, enable alternating row colors (authored by mwolff).
Move top-view properties to .ui file, enable alternating row colors
Feb 23 2017, 9:29 AM

Feb 22 2017

mwolff committed R45:e5554a0a304d: Merge branch '1.0' (authored by mwolff).
Merge branch '1.0'
Feb 22 2017, 12:41 PM
mwolff committed R45:65c7cac98178: Fix action enabled state (authored by mwolff).
Fix action enabled state
Feb 22 2017, 12:39 PM
mwolff committed R45:e543ca681b6c: Fix compile with older KF5, as e.g. available on Ubuntu 16.04 (authored by mwolff).
Fix compile with older KF5, as e.g. available on Ubuntu 16.04
Feb 22 2017, 12:38 PM

Feb 21 2017

mwolff committed R33:2e395709921b: Merge branch '5.1' (authored by mwolff).
Merge branch '5.1'
Feb 21 2017, 11:00 PM
mwolff committed R33:2d04564d564c: HTML-escape diagnostic description before showing it in a tooltip (authored by mwolff).
HTML-escape diagnostic description before showing it in a tooltip
Feb 21 2017, 10:59 PM
mwolff updated the diff for D4657: Show all KTextEditor view bars in a central location.

use override, track view changes

Feb 21 2017, 10:47 PM · KDevelop
mwolff requested changes to D4672: Initial support for hookup of projects with general (web) services.

Tons of new files and not a single test? Can you add some?

Feb 21 2017, 10:33 PM
mwolff committed R33:9db2e709e00d: Merge branch '5.1' (authored by mwolff).
Merge branch '5.1'
Feb 21 2017, 10:07 PM
mwolff committed R33:c8180003ba1f: Fix project tree state not being saved (authored by bevendorff).
Fix project tree state not being saved
Feb 21 2017, 10:07 PM
mwolff closed D4665: Fix project tree state not being saved by committing R33:c8180003ba1f: Fix project tree state not being saved (authored by bevendorff).
Feb 21 2017, 10:07 PM
mwolff added a comment to T5079: Differential: provide Bug and Branch fields.

The existing branch field is not useful. It shows the branch the submitter has been using, which will usually be a work branch. What we need is the *target* branch.

Feb 21 2017, 10:05 PM · Phabricator