mwolff (Milian Wolff)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 16 2015, 7:53 PM (217 w, 3 d)
Availability
Available

Recent Activity

Mon, Jun 3

mwolff committed R365:d8df6b7f0d8e: Remove libkolab (authored by mwolff).
Remove libkolab
Mon, Jun 3, 11:56 AM

Wed, May 29

mwolff accepted D21458: clang: fix test bench_codecompletion compilation.

lgtm

Wed, May 29, 8:00 AM · KDevelop

Tue, May 28

mwolff committed R45:8aa97c2931d9: Add -o and --output options to heaptrack (authored by Jarle Aase <jarle@jgaa.com>).
Add -o and --output options to heaptrack
Tue, May 28, 2:10 PM

Mon, May 20

mwolff added a comment to D21306: Add converter from Linux 'perf record'.

FTR: I did give my consent, so thanks @lunakl!

Mon, May 20, 3:22 PM

May 15 2019

mwolff requested changes to D21156: Fix browse mode not disabled after Ctrl is released.

you are removing a feature, but only partially - a lot of code would become superfluous by this change and should be cleaned up accordingly

May 15 2019, 9:25 PM · KDevelop

May 7 2019

mwolff added inline comments to D5447: Only add auto-detected compilers to model if they actually exist.
May 7 2019, 12:12 PM

May 6 2019

mwolff committed R32:f6b9c44710fa: meson: Watch for introspection file changes (authored by dmensinger).
meson: Watch for introspection file changes
May 6 2019, 2:26 PM
mwolff committed R32:b306b0f7825a: meson: Only configure if necessary (authored by dmensinger).
meson: Only configure if necessary
May 6 2019, 2:26 PM
mwolff committed R32:0596b384cddd: meson: implemented project reloding (authored by dmensinger).
meson: implemented project reloding
May 6 2019, 2:26 PM
mwolff committed R32:73fb3cd625b8: Fix deadlock exception in FileManagerListJob. (authored by arrowd).
Fix deadlock exception in FileManagerListJob.
May 6 2019, 1:59 PM
mwolff committed R32:6dca2d31bbbe: clang: Fix completion tests by using documentController to create view (authored by amhndu).
clang: Fix completion tests by using documentController to create view
May 6 2019, 1:54 PM
mwolff committed R32:34c34c77b0bf: clang: Use DocumentChangeSet for code completion in some places (authored by amhndu).
clang: Use DocumentChangeSet for code completion in some places
May 6 2019, 1:54 PM

Apr 24 2019

mwolff committed R81:5425dceed29a: Use #if instead of #ifdef on #cmakedefine01 (authored by mwolff).
Use #if instead of #ifdef on #cmakedefine01
Apr 24 2019, 8:46 PM
mwolff committed R81:1bb103749940: Don't set CMake variable to itself (authored by mwolff).
Don't set CMake variable to itself
Apr 24 2019, 8:46 PM
mwolff committed R81:3c7ba66df14a: Use VERSION_GREATER instead of STRGREATER for version comparison (authored by mwolff).
Use VERSION_GREATER instead of STRGREATER for version comparison
Apr 24 2019, 8:46 PM

Apr 23 2019

mwolff committed R32:8200efc01e42: Make it possible to select -std=c++2a for our language support (authored by mwolff).
Make it possible to select -std=c++2a for our language support
Apr 23 2019, 1:17 PM
mwolff committed R32:742cef92d22d: Rename c++1z to C++17 (authored by mwolff).
Rename c++1z to C++17
Apr 23 2019, 1:17 PM

Apr 17 2019

mwolff added a comment to D20606: Add action to toggle folding of child ranges.

I would prefer a context menu that has this as action. This is much better discoverable and also extensible with more folding actions.

Apr 17 2019, 10:04 AM · Frameworks, Kate

Apr 16 2019

mwolff accepted D18224: Clang Plugin: Report some problems from included files.

patch lgtm now, many thanks!

Apr 16 2019, 1:36 PM · KDevelop
mwolff added a comment to D18224: Clang Plugin: Report some problems from included files.

Upon reopening a file, we should only update the problems of changed files that got updated. Otherwise we should only grab the TU for the main .cpp file and attach it, such that we can do code completion.

If I understand this correctly, then perhaps something does not behave as it should there, since in some cases, a lot of files' problems seem to get updated when re-opening a file, including lots of system headers that certainly haven't changed. In other cases, no calls to ParseSession::problemsForFile() are made. It seems that the first case can be triggered by making changes to a header, closing it without saving, and then re-opening it.

Apr 16 2019, 1:34 PM · KDevelop

Apr 15 2019

mwolff added a comment to D18551: clang: Create preamble only on second parse.

quite obviously libclang doesn't handle it

Apr 15 2019, 7:38 PM · KDevelop
mwolff added a comment to D18551: clang: Create preamble only on second parse.

Re: reparsing reliably each time a headerfile is changed: wouldn't the use of forwarding headers increase the chance of missing a change?

Apr 15 2019, 8:25 AM · KDevelop
mwolff added a comment to D18224: Clang Plugin: Report some problems from included files.

I re-tested the behavior on files from an actual project and it showed the same behavior when editing files as described in my last post, regardless of how many files are included from the files that are edited. I noticed that the behavior is different when re-opening files: in this case, problemsForFile() is actually called for a larger set of files (although from only looking at this set of files, it seemed a bit random and it was not clear to me how it is determined, I'll have to dig into the source code for this at some point ...).

Apr 15 2019, 8:17 AM · KDevelop
mwolff added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..
In D18758#450081, @apol wrote:

Oh, really? Hmm! I wouldn't be opposed to enable compilation with exceptions myself, what do the others say? We don't need to use them excessively, but for error handling in async promise chains, that would be quite useful I think?

That would mean adding a bunch of noexcept all over the place or risk quite some performance penalty. I'd prefer keeping it localised.

Apr 15 2019, 8:13 AM · KDevelop

Apr 14 2019

mwolff committed R32:bc13f955f3f0: Also find clang include path based on runtime libclang library path (authored by mwolff).
Also find clang include path based on runtime libclang library path
Apr 14 2019, 7:09 PM
mwolff committed R32:c88bf19be2a6: clang: add new (partially failing) test file for lambdas (authored by mwolff).
clang: add new (partially failing) test file for lambdas
Apr 14 2019, 7:09 PM
mwolff committed R32:d8119c13ab36: Simplify setting custom parser args for unit tests (authored by mwolff).
Simplify setting custom parser args for unit tests
Apr 14 2019, 7:09 PM
mwolff committed R32:bbb42a2f1f6e: clang: fix functions.cpp test (authored by mwolff).
clang: fix functions.cpp test
Apr 14 2019, 7:09 PM
mwolff requested changes to D5447: Only add auto-detected compilers to model if they actually exist.
Apr 14 2019, 8:41 AM

Apr 13 2019

mwolff added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

Oh, really? Hmm! I wouldn't be opposed to enable compilation with exceptions myself, what do the others say? We don't need to use them excessively, but for error handling in async promise chains, that would be quite useful I think?

Apr 13 2019, 4:51 PM · KDevelop
mwolff requested changes to D18224: Clang Plugin: Report some problems from included files.

Hey Thomas, please don't remove the cache. See f2a6941e086cdf506c8fb1798c52982bff43792d for why this was introduced. Your tests don't include other files, so probably that's why you didn't see any effect of the cache?

Apr 13 2019, 4:49 PM · KDevelop
mwolff accepted D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.

thanks, lgtm!

Apr 13 2019, 4:41 PM · KDevelop

Apr 1 2019

mwolff updated subscribers of D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

yes, QtPromise or AsyncFuture (https://github.com/benlau/asyncfuture) could be used - I wouldn't be opposed to introducing it as a thirdparty dependency (or git submodule)

Apr 1 2019, 4:43 PM · KDevelop
mwolff requested changes to D5447: Only add auto-detected compilers to model if they actually exist.
Apr 1 2019, 4:41 PM
mwolff committed R32:0d8a820b5eaa: Merge remote-tracking branch 'gitlab/5.3' (authored by mwolff).
Merge remote-tracking branch 'gitlab/5.3'
Apr 1 2019, 11:37 AM
mwolff added a comment to D14391: Fix random order of plugin's config pages.

if it applies cleanly, you can also push to 5.3, otherwise master is fine - it's not a really urgent bug fix after all (imo)

Apr 1 2019, 11:02 AM · KDevelop
mwolff added a comment to D5447: Only add auto-detected compilers to model if they actually exist.

I started working on it.

I added method declaration to kdevplatform/interfaces/iruntime.h and wanted to add a default implementation in iruntime.cpp, but it turned out that to use KDevelop::Path, I have to include <util/path.h>, which belongs to KDevPlatformUtil library. I take it, KDevPlatformInterfaces isn't allowed to link to KDevPlatformUtil? How should I proceed?

Apr 1 2019, 10:47 AM
mwolff accepted D14391: Fix random order of plugin's config pages.
Apr 1 2019, 10:46 AM · KDevelop

Mar 26 2019

mwolff abandoned D20040: Don't finish collection sync task too early.

your simplified patch seems to work like a charm, thanks a lot!

Mar 26 2019, 9:00 AM · KDE PIM

Mar 25 2019

mwolff added inline comments to D20040: Don't finish collection sync task too early.
Mar 25 2019, 7:51 PM · KDE PIM
mwolff requested review of D20040: Don't finish collection sync task too early.
Mar 25 2019, 1:28 PM · KDE PIM
mwolff committed R1003:666927667582: Fix compile, Qt5Widgets_VERSION isn't defined, use Qt5Core_VERSION instead (authored by mwolff).
Fix compile, Qt5Widgets_VERSION isn't defined, use Qt5Core_VERSION instead
Mar 25 2019, 9:53 AM
mwolff committed R991:aaed820eff2b: Fix compile, Qt5Widgets_VERSION isn't defined, use Qt5Core_VERSION instead (authored by mwolff).
Fix compile, Qt5Widgets_VERSION isn't defined, use Qt5Core_VERSION instead
Mar 25 2019, 9:52 AM
mwolff committed R179:318fc51956f3: Fix compile, Qt5Widgets_VERSION isn't defined, use Qt5Core_VERSION instead (authored by mwolff).
Fix compile, Qt5Widgets_VERSION isn't defined, use Qt5Core_VERSION instead
Mar 25 2019, 9:38 AM
mwolff committed R176:32547c0afd52: Fix compile: replace foreach with std::remove_if + erase (authored by mwolff).
Fix compile: replace foreach with std::remove_if + erase
Mar 25 2019, 9:28 AM
mwolff added a reverting change for R172:1d7fe72082b8: Use VERSION_GREATER for version comparisons, not STRGREATER: R172:54d02d468eb7: Revert "Use VERSION_GREATER for version comparisons, not STRGREATER".
Mar 25 2019, 9:22 AM
mwolff committed R172:54d02d468eb7: Revert "Use VERSION_GREATER for version comparisons, not STRGREATER" (authored by mwolff).
Revert "Use VERSION_GREATER for version comparisons, not STRGREATER"
Mar 25 2019, 9:22 AM
mwolff committed R174:b112bc19ad0f: Revert "Compare versions using VERSION_GREATER, not STRGREATER" (authored by mwolff).
Revert "Compare versions using VERSION_GREATER, not STRGREATER"
Mar 25 2019, 9:22 AM
mwolff added a reverting change for R174:add8e97fbe03: Compare versions using VERSION_GREATER, not STRGREATER: R174:b112bc19ad0f: Revert "Compare versions using VERSION_GREATER, not STRGREATER".
Mar 25 2019, 9:22 AM
mwolff committed R172:1d7fe72082b8: Use VERSION_GREATER for version comparisons, not STRGREATER (authored by mwolff).
Use VERSION_GREATER for version comparisons, not STRGREATER
Mar 25 2019, 9:13 AM
mwolff committed R172:e5a6069fb5ef: Fix compile, KCalCore doesn't depend on Qt5Widgets, so use Qt5Gui instead (authored by mwolff).
Fix compile, KCalCore doesn't depend on Qt5Widgets, so use Qt5Gui instead
Mar 25 2019, 9:13 AM
mwolff committed R174:8ed24aa1a5d8: Fix indentation (authored by mwolff).
Fix indentation
Mar 25 2019, 9:05 AM
mwolff committed R174:add8e97fbe03: Compare versions using VERSION_GREATER, not STRGREATER (authored by mwolff).
Compare versions using VERSION_GREATER, not STRGREATER
Mar 25 2019, 9:05 AM
mwolff committed R174:aa01d917ebb0: Make compile: kcontacts doesn't include widgets, so use Qt5Gui_VERSION (authored by mwolff).
Make compile: kcontacts doesn't include widgets, so use Qt5Gui_VERSION
Mar 25 2019, 9:05 AM

Mar 24 2019

mwolff requested changes to D19876: Fix: apply correctly the text colors of the chosen scheme.

one minor nit, otherwise looks like a good improvement

Mar 24 2019, 9:12 PM · Frameworks, Kate
mwolff committed R44:83c16b6b013f: Revert "Fix compile with CMake 3.14" (authored by mwolff).
Revert "Fix compile with CMake 3.14"
Mar 24 2019, 12:17 PM
mwolff added a reverting change for R44:d8fbd56ad0a3: Fix compile with CMake 3.14: R44:83c16b6b013f: Revert "Fix compile with CMake 3.14".
Mar 24 2019, 12:17 PM
mwolff committed R44:d8fbd56ad0a3: Fix compile with CMake 3.14 (authored by mwolff).
Fix compile with CMake 3.14
Mar 24 2019, 12:07 PM

Mar 22 2019

mwolff committed R45:a27fffe0e608: Mark overridden methods (authored by mwolff).
Mark overridden methods
Mar 22 2019, 8:49 AM

Mar 20 2019

mwolff committed R32:d5e3e27bb272: CMake: discover more unit tests (authored by tnorth).
CMake: discover more unit tests
Mar 20 2019, 6:34 PM
mwolff closed D19673: Discovered unit-tests using bracket arguments and/or listed in files other than CTestTestFile.cmake.
Mar 20 2019, 6:34 PM · KDevelop

Mar 18 2019

mwolff committed R52:8ebdd796c7ff: Always set maximum file size for internal parse job (authored by mwolff).
Always set maximum file size for internal parse job
Mar 18 2019, 2:49 PM

Mar 12 2019

mwolff accepted D19673: Discovered unit-tests using bracket arguments and/or listed in files other than CTestTestFile.cmake.

thanks, lgtm - I'll amend the last nits and apply it for you - if you give me full name and email address such that I can set you as the main author of this patch

Mar 12 2019, 8:14 PM · KDevelop
mwolff added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.

And there are probably places where the simpler QProcess API was used
instead.

But the KDevelop env. profiles are already based on or compatible with QProcess::setProcessEnvironment(), no?

Mar 12 2019, 8:02 PM · KDevelop

Mar 11 2019

mwolff accepted D17760: astyle: support the system astyle library.

ah, then let's get this in as-is

Mar 11 2019, 2:32 PM · KDevelop
mwolff requested changes to D19673: Discovered unit-tests using bracket arguments and/or listed in files other than CTestTestFile.cmake.

great! can we get a unit test for this? though I'm unsure if we ever revived the unit tests from our old cmake integration

Mar 11 2019, 9:19 AM · KDevelop

Mar 10 2019

mwolff added a comment to D14391: Fix random order of plugin's config pages.

yes I would be fine with that personally!

Mar 10 2019, 7:34 PM · KDevelop
mwolff added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.
we use CXTranslationUnit_CreatePreambleOnFirstParse to get code completion results fast. otherwise the first code completion request would create the preamble, which felt much worse

Shall we keep that discussion to D18551?

Mar 10 2019, 7:32 PM · KDevelop
mwolff added a comment to D17760: astyle: support the system astyle library.

ok cool, then please get rid of our internal copy!

Mar 10 2019, 7:27 PM · KDevelop
mwolff added a comment to D5447: Only add auto-detected compilers to model if they actually exist.

you are right, this code should essentially do if (rt->findExecutable(compiler->path().isEmpty()) continue;, could you introduce that please?

I got lost in this conversation. Let's break down all these checks.

Old code:

  • absolutePath. Always true now, so can be dropped.
Mar 10 2019, 7:24 PM
mwolff requested changes to D18224: Clang Plugin: Report some problems from included files.

nice, this is getting better! some suggestions on how to improve the code quality, and then some potential issues I can think of - please fix or document why they aren't an issue

Mar 10 2019, 7:20 PM · KDevelop
mwolff requested changes to D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.

cool, this is great! and it fixes the issue you originally found in testActiveDocumentsGetBestPriority?

Mar 10 2019, 7:01 PM · KDevelop
mwolff added a comment to D18229: Contextbrowser: Ability to show combined problems and decl tooltip.

Rene, instead of thinking about what-ifs, maybe try it out first? Most notably, the tooltips only show up when you press ALT and keep it pressed. Otherwise, the tooltips don't show up - unless you hover code with your mouse cursor. Moving the keyboard edit cursor won't ever trigger tooltips. Or are you somehow moving your mouse cursor while typing?! Don't do that :)

Mar 10 2019, 6:56 PM · KDevelop

Mar 5 2019

mwolff committed R244:29ce421aed4b: Use range-based for loop (authored by mwolff).
Use range-based for loop
Mar 5 2019, 12:52 PM

Mar 2 2019

mwolff committed R52:3431ef364495: bypass the 5 MB maximum file size limit for the phpfunctions.php internal file (authored by aanderse).
bypass the 5 MB maximum file size limit for the phpfunctions.php internal file
Mar 2 2019, 8:39 PM
mwolff committed R32:ecf5548543a4: Allow the maximum file size of parse jobs to be configurable (authored by aanderse).
Allow the maximum file size of parse jobs to be configurable
Mar 2 2019, 8:38 PM

Feb 27 2019

mwolff committed R45:f8aab10aa87a: copy zstd into correct appimage folder (authored by mwolff).
copy zstd into correct appimage folder
Feb 27 2019, 9:47 PM
mwolff committed R45:9e234f041fc9: don't build kdchart examples/tests (authored by mwolff).
don't build kdchart examples/tests
Feb 27 2019, 9:46 PM
mwolff committed R45:f1c063644514: Don't build KGantt (authored by mwolff).
Don't build KGantt
Feb 27 2019, 9:44 PM
mwolff committed R478:852436f7fb1d: Make it possible to disable kchart/kgantt compilation as-needed (authored by mwolff).
Make it possible to disable kchart/kgantt compilation as-needed
Feb 27 2019, 9:43 PM
mwolff committed R45:3ae20c056629: use git instead of https to checkout from kde (authored by mwolff).
use git instead of https to checkout from kde
Feb 27 2019, 9:34 PM
mwolff committed R45:bb21f3f89fb8: make wget less chatty (authored by mwolff).
make wget less chatty
Feb 27 2019, 9:25 PM
mwolff committed R45:9efe21c4ae40: silently copy icons (authored by mwolff).
silently copy icons
Feb 27 2019, 9:25 PM
mwolff committed R45:047ce1cb0745: build kdiagram from sources (authored by mwolff).
build kdiagram from sources
Feb 27 2019, 9:25 PM
mwolff committed R45:1dc3aead87d3: merge lines for ecm build (authored by mwolff).
merge lines for ecm build
Feb 27 2019, 9:25 PM
mwolff committed R45:6274d849be1e: use sudo for install (authored by mwolff).
use sudo for install
Feb 27 2019, 9:09 PM
mwolff committed R45:8b59d2b8f8bc: use hardcoded prefix on travis.ci (authored by mwolff).
use hardcoded prefix on travis.ci
Feb 27 2019, 9:07 PM
mwolff committed R45:c9f8e77f4053: include zstd binary in appimage (authored by mwolff).
include zstd binary in appimage
Feb 27 2019, 9:06 PM
mwolff committed R45:ba4a2991c721: try to fix kdiagram integration on travis.ci appimage (authored by mwolff).
try to fix kdiagram integration on travis.ci appimage
Feb 27 2019, 9:04 PM
mwolff committed R45:bc62fe7e01fb: build zstd on the heaptrack appimage (authored by mwolff).
build zstd on the heaptrack appimage
Feb 27 2019, 9:04 PM

Feb 21 2019

mwolff accepted D18857: optimize CMakeBuildDirChooser::buildDirSettings().
Feb 21 2019, 8:37 AM · KDevelop

Feb 19 2019

mwolff requested changes to D18793: Handle text completion with block selection mode.

we override execution in our own completion models, so this patch will only change the behavior for the builtin word and keyword completion models in ktexteditor I believe

Feb 19 2019, 12:27 PM · Frameworks, Kate
mwolff committed R32:e2b2fd2c1d22: Don't eat the backspace event when no alt modifier is set (authored by mwolff).
Don't eat the backspace event when no alt modifier is set
Feb 19 2019, 9:25 AM

Feb 18 2019

mwolff added a comment to D17599: Confirm closing muliple tabs..

+1 on reverting this, but I think we should put some thought into fixing the issue motivating the desire to do this: the fact that without manually invoking Kate's session-saving features, closing a window with multiple tabs in it results in that tab history being lost. I really think we should consider creating a session by default so tab history is remembered unless the user explicitly opts out of it.

Feb 18 2019, 9:36 AM · Kate
mwolff committed R265:f6c046e9f8bb: Skip benchmark if no scheme files can be found (authored by mwolff).
Skip benchmark if no scheme files can be found
Feb 18 2019, 9:32 AM

Feb 15 2019

mwolff added a comment to D18229: Contextbrowser: Ability to show combined problems and decl tooltip.

Done, keyboard navigation should work now - at least it does according to my testing! Please test this as well and report back if you spot any issues.

Feb 15 2019, 11:35 PM · KDevelop
mwolff committed R32:d284d5bb5f09: Introduce QuickOpenEmbeddedWidgetCombiner (authored by mwolff).
Introduce QuickOpenEmbeddedWidgetCombiner
Feb 15 2019, 11:34 PM
mwolff added inline comments to D17599: Confirm closing muliple tabs..
Feb 15 2019, 10:04 PM · Kate
mwolff committed R32:35277af94498: Add 'back' to QuickOpenEmbeddedWidgetInterface (authored by mwolff).
Add 'back' to QuickOpenEmbeddedWidgetInterface
Feb 15 2019, 9:59 PM
mwolff committed R32:db9740ef9ae1: Update documentation: the keyboard shortcuts use ALT not SHIFT (authored by mwolff).
Update documentation: the keyboard shortcuts use ALT not SHIFT
Feb 15 2019, 9:59 PM