mwolff (Milian Wolff)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 16 2015, 7:53 PM (235 w, 1 d)
Availability
Available

Recent Activity

Tue, Oct 15

mwolff committed R45:2d14f5de75b9: Allow high priv user to profile low priv user process (authored by Sam Saffron <sam.saffron@gmail.com>).
Allow high priv user to profile low priv user process
Tue, Oct 15, 9:07 PM
mwolff committed R45:715edab31dde: Add icons (authored by mwolff).
Add icons
Tue, Oct 15, 9:27 AM

Sun, Oct 13

mwolff added a comment to D24532: Declare new hash function in namespace std in order to fix build..

pushed now, thanks a lot

Sun, Oct 13, 7:28 PM
mwolff closed D24532: Declare new hash function in namespace std in order to fix build..
Sun, Oct 13, 7:27 PM
mwolff committed R45:983cc35dd000: Declare new hash function in namespace std in order to fix build. (authored by beischer).
Declare new hash function in namespace std in order to fix build.
Sun, Oct 13, 7:27 PM
mwolff added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.
In D24568#545736, @apol wrote:

I'm not sure how this works, but would it be possible to have a target that only works on a patch? You usually want to make sure what you modified didn't diverge from the code.

I think there is some hack around that:
http://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting

But actually, if your sources are already clang-formatted, you just need to run the clang-format target once before you commit, the your new code will be the only thing altered.

Sun, Oct 13, 7:24 PM · Build System, Frameworks

Sat, Oct 12

mwolff accepted D24532: Declare new hash function in namespace std in order to fix build..

thanks, do you have commit rights to KDE?

Sat, Oct 12, 12:30 PM

Tue, Oct 8

mwolff accepted D24491: Fix build against Qt without std::hash<QString> specialization.

thanks

Tue, Oct 8, 6:42 PM
mwolff committed R44:81ed5eb65459: Find boost when libkolabxml was found (authored by mwolff).
Find boost when libkolabxml was found
Tue, Oct 8, 6:30 AM

Mon, Oct 7

mwolff added a comment to D22158: Navigation context uses theme color..

e.g. look at https://doc.qt.io/archives/qt-4.8/qcolor.html#predefined-colors

Mon, Oct 7, 8:14 PM · KDevelop
mwolff added a comment to D22158: Navigation context uses theme color..

hey! can you also show a screenshot of PHP or Qt documentation showing? these can contain arbitrary HTML and sometimes even contain colored text that expects to be shown on bright backgrounds which would break with this patch. At least that was the case years ago when I worked on this the last time.

Mon, Oct 7, 8:14 PM · KDevelop

Thu, Oct 3

mwolff accepted D24396: Add more tests for Parser: bottom-up and top-down data.
Thu, Oct 3, 7:03 PM

Wed, Oct 2

mwolff accepted D24099: Add an ID to Symbol in order to make hashing faster.
Wed, Oct 2, 3:15 PM

Tue, Sep 24

mwolff requested changes to D24106: Use unordered_map so it scales better.

squash please

Tue, Sep 24, 9:17 AM
mwolff requested changes to D24099: Add an ID to Symbol in order to make hashing faster.

please squash with the hash map commit

Tue, Sep 24, 9:17 AM
mwolff accepted D24104: Replace std::tie with == in operator==().

sad but OK :(

Tue, Sep 24, 9:06 AM

Sat, Sep 21

mwolff committed R32:dd2c99254a3b: Merge branch '5.4' (authored by mwolff).
Merge branch '5.4'
Sat, Sep 21, 2:40 PM
mwolff committed R32:4676a7bb3e4b: Don't try to run cuda test when cuda isn't installed (authored by mwolff).
Don't try to run cuda test when cuda isn't installed
Sat, Sep 21, 2:39 PM
mwolff committed R32:b740e32dec3d: Cache the defines/includes for gcc-like compilers per language type (authored by mwolff).
Cache the defines/includes for gcc-like compilers per language type
Sat, Sep 21, 2:39 PM
mwolff committed R32:2d40e10b8309: Only write defines file when needed (authored by mwolff).
Only write defines file when needed
Sat, Sep 21, 2:39 PM
mwolff committed R32:768c276b0078: Merge branch '5.4' (authored by mwolff).
Merge branch '5.4'
Sat, Sep 21, 2:14 PM
mwolff committed R32:9a91576316ef: Don't set super long name on completely anon structs (authored by mwolff).
Don't set super long name on completely anon structs
Sat, Sep 21, 2:13 PM
mwolff committed R32:caf74ff2c373: Merge branch '5.4' (authored by mwolff).
Merge branch '5.4'
Sat, Sep 21, 2:00 PM
mwolff committed R32:26ee0da99a0c: Use type name as fallback ID for anon typedef'ed structs/unions etc. (authored by mwolff).
Use type name as fallback ID for anon typedef'ed structs/unions etc.
Sat, Sep 21, 2:00 PM
mwolff committed R32:b2b45395dc72: Merge branch '5.4' (authored by mwolff).
Merge branch '5.4'
Sat, Sep 21, 12:47 PM
mwolff committed R32:9a545cb9794b: Revert "Use type name as fallback ID for anon typedef'ed structs/unions etc." (authored by mwolff).
Revert "Use type name as fallback ID for anon typedef'ed structs/unions etc."
Sat, Sep 21, 12:47 PM
mwolff added a reverting change for R32:a6df33cf7cd7: Use type name as fallback ID for anon typedef'ed structs/unions etc.: R32:9a545cb9794b: Revert "Use type name as fallback ID for anon typedef'ed structs/unions etc.".
Sat, Sep 21, 12:47 PM
mwolff committed R32:b963bd861d33: Merge branch '5.4' (authored by mwolff).
Merge branch '5.4'
Sat, Sep 21, 12:30 PM
mwolff committed R32:a6df33cf7cd7: Use type name as fallback ID for anon typedef'ed structs/unions etc. (authored by mwolff).
Use type name as fallback ID for anon typedef'ed structs/unions etc.
Sat, Sep 21, 12:30 PM
mwolff committed R32:4d175501be3e: Merge branch '5.4' (authored by mwolff).
Merge branch '5.4'
Sat, Sep 21, 12:09 AM

Fri, Sep 20

mwolff accepted D24095: Use static variable for frequent i18n() call..
Fri, Sep 20, 4:42 AM
mwolff accepted D24093: Add benchmark for Parser.

better use stdout/stderr "directly" instead of going through qDebug which could be disabled in a debug build

Fri, Sep 20, 4:41 AM
mwolff accepted D24106: Use unordered_map so it scales better.
Fri, Sep 20, 4:39 AM
mwolff accepted D24105: Add unittest for Parser.
Fri, Sep 20, 4:38 AM
mwolff accepted D5447: Only add auto-detected compilers to model if they actually exist.

sorry for the super long delay. I like what I'm seeing - if this works, please commit

Fri, Sep 20, 4:13 AM
mwolff added a comment to D22660: Fixed crash when filtering class list.

thanks, applied to 5.4

Fri, Sep 20, 4:11 AM · KDevelop
mwolff committed R32:5bff5d65a023: Fixed crash when filtering class list (authored by mdlubakowski).
Fixed crash when filtering class list
Fri, Sep 20, 4:11 AM
mwolff closed D22660: Fixed crash when filtering class list.
Fri, Sep 20, 4:11 AM · KDevelop
mwolff committed R32:c315333c4aa3: gcclikecompiler: properly resolve include paths with symbolic links (authored by akellermann).
gcclikecompiler: properly resolve include paths with symbolic links
Fri, Sep 20, 4:11 AM
mwolff closed D23303: gcclikecompiler: properly resolve include paths containing symbolic links .
Fri, Sep 20, 4:07 AM · KDevelop
mwolff accepted D23303: gcclikecompiler: properly resolve include paths containing symbolic links .

done now, thanks a lot!

Fri, Sep 20, 4:07 AM · KDevelop
mwolff requested changes to D24099: Add an ID to Symbol in order to make hashing faster.
Fri, Sep 20, 4:04 AM
mwolff added a comment to D23303: gcclikecompiler: properly resolve include paths containing symbolic links .

I'll commit this using QFileInfo instead of going through QDir.

Fri, Sep 20, 3:51 AM · KDevelop
mwolff accepted D24088: Provide progress information during the "merging allocations" phase.

just pleaes fixup the qMax -> std::max and commit directly

Fri, Sep 20, 3:50 AM
mwolff requested changes to D24088: Provide progress information during the "merging allocations" phase.

one minor nit, otherwise lgtm

Fri, Sep 20, 3:50 AM

Sep 18 2019

mwolff committed R45:e2d0c0f698e2: Don't show a flame graph tooltip in the empty region (authored by mwolff).
Don't show a flame graph tooltip in the empty region
Sep 18 2019, 12:55 AM
mwolff committed R45:cb50367ac1f1: Don't show empty parens after top most flame graph item's description (authored by mwolff).
Don't show empty parens after top most flame graph item's description
Sep 18 2019, 12:55 AM

Sep 17 2019

mwolff committed R45:f33ac9f63de8: Correctly check for boost iostreams to fix zstd support (authored by mwolff).
Correctly check for boost iostreams to fix zstd support
Sep 17 2019, 7:30 PM

Sep 16 2019

mwolff committed R45:ffbccca9df28: Correctly find item under cursor for flame graph context menu (authored by mwolff).
Correctly find item under cursor for flame graph context menu
Sep 16 2019, 4:07 AM

Aug 7 2019

mwolff committed R285:d97269a6c340: Disable kcrash when running under rr (authored by mwolff).
Disable kcrash when running under rr
Aug 7 2019, 1:52 PM

Jun 25 2019

mwolff committed R216:8b7cac75a7e8: Fix and expand GDB unit test (authored by mwolff).
Fix and expand GDB unit test
Jun 25 2019, 9:27 PM
mwolff committed R216:2accc29f3fef: Add more keywords and also support rr in gdb highlighter (authored by mwolff).
Add more keywords and also support rr in gdb highlighter
Jun 25 2019, 2:10 PM
mwolff committed R216:e3bba069509e: Detect comment lines early in GDB highlighter (authored by mwolff).
Detect comment lines early in GDB highlighter
Jun 25 2019, 2:00 PM
mwolff accepted D21156: Fix browse mode not disabled after Ctrl is released.

lgtm, thanks - do you have commit rights? if so, please push to the 5.3 branch

Jun 25 2019, 11:22 AM · Documentation, KDevelop

Jun 24 2019

mwolff committed R45:c86184d9e1a6: Don't skip the whole branch when collapsing flamegraph recursion (authored by mwolff).
Don't skip the whole branch when collapsing flamegraph recursion
Jun 24 2019, 9:22 AM

Jun 18 2019

mwolff added a comment to D18758: Make Project::open() method use async KIO methods..

R32:bd048e67f056b5be25ed57fb2be947444f68c24e

so, I've now committed an alternative fix (or so I hope...) see:

commit bd048e67f056b5be25ed57fb2be947444f68c24e
Author: Milian Wolff <mail@milianw.de>
Date:   Mon Jun 17 22:26:32 2019 +0200

    Guard against crashes when IStatus object gets destroyed at bad times

I confirm this fixes the issue for me. Yay, thanks!

Jun 18 2019, 9:11 AM · KDevelop

Jun 17 2019

mwolff added a comment to D17241: WIP:Disable highlighting after 512 characters on a line..
Jun 17 2019, 9:57 PM · Frameworks, Kate
mwolff added a comment to D18758: Make Project::open() method use async KIO methods..

having looked at the raw diff quickly, I like what I'm seeing. What boilerplate are you referring to?

Jun 17 2019, 8:40 PM · KDevelop
mwolff added a comment to D18758: Make Project::open() method use async KIO methods..

so, I've now committed an alternative fix (or so I hope...) see:

Jun 17 2019, 8:32 PM · KDevelop
mwolff committed R32:bd048e67f056: Guard against crashes when IStatus object gets destroyed at bad times (authored by mwolff).
Guard against crashes when IStatus object gets destroyed at bad times
Jun 17 2019, 8:31 PM
mwolff committed R32:634c7b2d654b: Cleanup: use QHash instead of QMap when no order is required (authored by mwolff).
Cleanup: use QHash instead of QMap when no order is required
Jun 17 2019, 8:31 PM
mwolff added a comment to D18758: Make Project::open() method use async KIO methods..

ok, sorry for the rabbit hole I sent you down. I still think that long-term we will need something like QPromise, but phabricator doesn't even let me view the interesting changes in shell/... so I cannot comment on the boilerplate

Jun 17 2019, 8:14 PM · KDevelop
mwolff added a comment to D21156: Fix browse mode not disabled after Ctrl is released.

you are removing a feature, but only partially - a lot of code would become superfluous by this change and should be cleaned up accordingly

As rjvbb said, no feature have been removed. The feature is still there through the Alt key (as it was before), while not accessible anymore with the Ctrl key. There is no reason to have the same (undocumented) feature on two different keys. Moreover there is no code to cleanup, what is there is needed to have the feature working on the Alt key (at least for my understanding of the code, I have not noticed unuseful blocks).

Jun 17 2019, 7:27 PM · Documentation, KDevelop

Jun 3 2019

mwolff committed R365:d8df6b7f0d8e: Remove libkolab (authored by mwolff).
Remove libkolab
Jun 3 2019, 11:56 AM

May 29 2019

mwolff accepted D21458: clang: fix test bench_codecompletion compilation.

lgtm

May 29 2019, 8:00 AM · KDevelop

May 28 2019

mwolff committed R45:8aa97c2931d9: Add -o and --output options to heaptrack (authored by Jarle Aase <jarle@jgaa.com>).
Add -o and --output options to heaptrack
May 28 2019, 2:10 PM

May 20 2019

mwolff added a comment to D21306: Add converter from Linux 'perf record'.

FTR: I did give my consent, so thanks @lunakl!

May 20 2019, 3:22 PM

May 15 2019

mwolff requested changes to D21156: Fix browse mode not disabled after Ctrl is released.

you are removing a feature, but only partially - a lot of code would become superfluous by this change and should be cleaned up accordingly

May 15 2019, 9:25 PM · Documentation, KDevelop

May 7 2019

mwolff added inline comments to D5447: Only add auto-detected compilers to model if they actually exist.
May 7 2019, 12:12 PM

May 6 2019

mwolff committed R32:f6b9c44710fa: meson: Watch for introspection file changes (authored by dmensinger).
meson: Watch for introspection file changes
May 6 2019, 2:26 PM
mwolff committed R32:b306b0f7825a: meson: Only configure if necessary (authored by dmensinger).
meson: Only configure if necessary
May 6 2019, 2:26 PM
mwolff committed R32:0596b384cddd: meson: implemented project reloding (authored by dmensinger).
meson: implemented project reloding
May 6 2019, 2:26 PM
mwolff committed R32:73fb3cd625b8: Fix deadlock exception in FileManagerListJob. (authored by arrowd).
Fix deadlock exception in FileManagerListJob.
May 6 2019, 1:59 PM
mwolff committed R32:6dca2d31bbbe: clang: Fix completion tests by using documentController to create view (authored by amhndu).
clang: Fix completion tests by using documentController to create view
May 6 2019, 1:54 PM
mwolff committed R32:34c34c77b0bf: clang: Use DocumentChangeSet for code completion in some places (authored by amhndu).
clang: Use DocumentChangeSet for code completion in some places
May 6 2019, 1:54 PM

Apr 24 2019

mwolff committed R81:5425dceed29a: Use #if instead of #ifdef on #cmakedefine01 (authored by mwolff).
Use #if instead of #ifdef on #cmakedefine01
Apr 24 2019, 8:46 PM
mwolff committed R81:1bb103749940: Don't set CMake variable to itself (authored by mwolff).
Don't set CMake variable to itself
Apr 24 2019, 8:46 PM
mwolff committed R81:3c7ba66df14a: Use VERSION_GREATER instead of STRGREATER for version comparison (authored by mwolff).
Use VERSION_GREATER instead of STRGREATER for version comparison
Apr 24 2019, 8:46 PM

Apr 23 2019

mwolff committed R32:8200efc01e42: Make it possible to select -std=c++2a for our language support (authored by mwolff).
Make it possible to select -std=c++2a for our language support
Apr 23 2019, 1:17 PM
mwolff committed R32:742cef92d22d: Rename c++1z to C++17 (authored by mwolff).
Rename c++1z to C++17
Apr 23 2019, 1:17 PM

Apr 17 2019

mwolff added a comment to D20606: Add action to toggle folding of child ranges.

I would prefer a context menu that has this as action. This is much better discoverable and also extensible with more folding actions.

Apr 17 2019, 10:04 AM · Frameworks, Kate

Apr 16 2019

mwolff accepted D18224: Clang Plugin: Report some problems from included files.

patch lgtm now, many thanks!

Apr 16 2019, 1:36 PM · KDevelop
mwolff added a comment to D18224: Clang Plugin: Report some problems from included files.

Upon reopening a file, we should only update the problems of changed files that got updated. Otherwise we should only grab the TU for the main .cpp file and attach it, such that we can do code completion.

If I understand this correctly, then perhaps something does not behave as it should there, since in some cases, a lot of files' problems seem to get updated when re-opening a file, including lots of system headers that certainly haven't changed. In other cases, no calls to ParseSession::problemsForFile() are made. It seems that the first case can be triggered by making changes to a header, closing it without saving, and then re-opening it.

Apr 16 2019, 1:34 PM · KDevelop

Apr 15 2019

mwolff added a comment to D18551: clang: Create preamble only on second parse.

quite obviously libclang doesn't handle it

Apr 15 2019, 7:38 PM · KDevelop
mwolff added a comment to D18551: clang: Create preamble only on second parse.

Re: reparsing reliably each time a headerfile is changed: wouldn't the use of forwarding headers increase the chance of missing a change?

Apr 15 2019, 8:25 AM · KDevelop
mwolff added a comment to D18224: Clang Plugin: Report some problems from included files.

I re-tested the behavior on files from an actual project and it showed the same behavior when editing files as described in my last post, regardless of how many files are included from the files that are edited. I noticed that the behavior is different when re-opening files: in this case, problemsForFile() is actually called for a larger set of files (although from only looking at this set of files, it seemed a bit random and it was not clear to me how it is determined, I'll have to dig into the source code for this at some point ...).

Apr 15 2019, 8:17 AM · KDevelop
mwolff added a comment to D18758: Make Project::open() method use async KIO methods..
In D18758#450081, @apol wrote:

Oh, really? Hmm! I wouldn't be opposed to enable compilation with exceptions myself, what do the others say? We don't need to use them excessively, but for error handling in async promise chains, that would be quite useful I think?

That would mean adding a bunch of noexcept all over the place or risk quite some performance penalty. I'd prefer keeping it localised.

Apr 15 2019, 8:13 AM · KDevelop

Apr 14 2019

mwolff committed R32:bc13f955f3f0: Also find clang include path based on runtime libclang library path (authored by mwolff).
Also find clang include path based on runtime libclang library path
Apr 14 2019, 7:09 PM
mwolff committed R32:c88bf19be2a6: clang: add new (partially failing) test file for lambdas (authored by mwolff).
clang: add new (partially failing) test file for lambdas
Apr 14 2019, 7:09 PM
mwolff committed R32:d8119c13ab36: Simplify setting custom parser args for unit tests (authored by mwolff).
Simplify setting custom parser args for unit tests
Apr 14 2019, 7:09 PM
mwolff committed R32:bbb42a2f1f6e: clang: fix functions.cpp test (authored by mwolff).
clang: fix functions.cpp test
Apr 14 2019, 7:09 PM
mwolff requested changes to D5447: Only add auto-detected compilers to model if they actually exist.
Apr 14 2019, 8:41 AM

Apr 13 2019

mwolff added a comment to D18758: Make Project::open() method use async KIO methods..

Oh, really? Hmm! I wouldn't be opposed to enable compilation with exceptions myself, what do the others say? We don't need to use them excessively, but for error handling in async promise chains, that would be quite useful I think?

Apr 13 2019, 4:51 PM · KDevelop
mwolff requested changes to D18224: Clang Plugin: Report some problems from included files.

Hey Thomas, please don't remove the cache. See f2a6941e086cdf506c8fb1798c52982bff43792d for why this was introduced. Your tests don't include other files, so probably that's why you didn't see any effect of the cache?

Apr 13 2019, 4:49 PM · KDevelop
mwolff accepted D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.

thanks, lgtm!

Apr 13 2019, 4:41 PM · KDevelop

Apr 1 2019

mwolff updated subscribers of D18758: Make Project::open() method use async KIO methods..

yes, QtPromise or AsyncFuture (https://github.com/benlau/asyncfuture) could be used - I wouldn't be opposed to introducing it as a thirdparty dependency (or git submodule)

Apr 1 2019, 4:43 PM · KDevelop
mwolff requested changes to D5447: Only add auto-detected compilers to model if they actually exist.
Apr 1 2019, 4:41 PM
mwolff committed R32:0d8a820b5eaa: Merge remote-tracking branch 'gitlab/5.3' (authored by mwolff).
Merge remote-tracking branch 'gitlab/5.3'
Apr 1 2019, 11:37 AM
mwolff added a comment to D14391: Fix random order of plugin's config pages.

if it applies cleanly, you can also push to 5.3, otherwise master is fine - it's not a really urgent bug fix after all (imo)

Apr 1 2019, 11:02 AM · KDevelop
mwolff added a comment to D5447: Only add auto-detected compilers to model if they actually exist.

I started working on it.

I added method declaration to kdevplatform/interfaces/iruntime.h and wanted to add a default implementation in iruntime.cpp, but it turned out that to use KDevelop::Path, I have to include <util/path.h>, which belongs to KDevPlatformUtil library. I take it, KDevPlatformInterfaces isn't allowed to link to KDevPlatformUtil? How should I proceed?

Apr 1 2019, 10:47 AM