mwolff (Milian Wolff)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 16 2015, 7:53 PM (268 w, 49 m)
Availability
Available

Recent Activity

Mon, Jun 1

mwolff committed R45:d0c2e2c22cb4: Fix path for macOS caveats script (authored by Martin Juul <martin@juul.xyz>).
Fix path for macOS caveats script
Mon, Jun 1, 8:31 AM

Sun, May 17

mwolff committed R365:1b329567e723: Use `git pull --rebase` instead of `git rebase` (authored by mwolff).
Use `git pull --rebase` instead of `git rebase`
Sun, May 17, 7:39 PM

Fri, May 15

mwolff added a comment to D29578: Include all accounts in channel list.

I think this is a great step forwards. the only thing that's missing is a joined "unread" category on top. right now, one has to scroll a lot to find unread/pinged channels in other accounts, when a large account (like our kdab one) is sitting on top

Fri, May 15, 2:20 PM
mwolff committed R865:6f2c6ab94812: Use smooth transformation for avatar downscaling (authored by mwolff).
Use smooth transformation for avatar downscaling
Fri, May 15, 1:27 PM
mwolff committed R865:542991d64569: Fix hidpi issues with scaled avatars in message list delegate (authored by mwolff).
Fix hidpi issues with scaled avatars in message list delegate
Fri, May 15, 1:27 PM
mwolff closed D29768: Fix hidpi issues with scaled avatars in message list delegate.
Fri, May 15, 1:27 PM
mwolff closed D29769: Use smooth transformation for avatar downscaling.
Fri, May 15, 1:27 PM
mwolff committed R865:e9256cfb4970: Fix hidpi issues with ShowImageWidget and MessageDelegateHelperImage (authored by mwolff).
Fix hidpi issues with ShowImageWidget and MessageDelegateHelperImage
Fri, May 15, 1:27 PM
mwolff closed D29499: Fix hidpi issues with ShowImageWidget and MessageDelegateHelperImage.
Fri, May 15, 1:27 PM
mwolff committed R865:2b30d6308a52: Center align images in ShowImageWidget (authored by mwolff).
Center align images in ShowImageWidget
Fri, May 15, 1:27 PM
mwolff committed R865:8d7b7324f2c9: Centralize test account initialization (authored by mwolff).
Centralize test account initialization
Fri, May 15, 1:27 PM
mwolff closed D29746: Centralize test account initialization.
Fri, May 15, 1:27 PM
mwolff committed R865:9250d4da3aef: Use smooth transformation when scaling pixmaps (authored by mwolff).
Use smooth transformation when scaling pixmaps
Fri, May 15, 1:27 PM
mwolff closed D29498: Center align images in ShowImageWidget.
Fri, May 15, 1:27 PM
mwolff closed D29497: Use smooth transformation when scaling pixmaps.
Fri, May 15, 1:27 PM
mwolff committed R865:8be6cae42d6f: Add a spin box to control the image zoom level (authored by mwolff).
Add a spin box to control the image zoom level
Fri, May 15, 1:27 PM
mwolff closed D29496: Add a spin box to control the image zoom level.
Fri, May 15, 1:27 PM
mwolff added inline comments to D29768: Fix hidpi issues with scaled avatars in message list delegate.
Fri, May 15, 1:26 PM
mwolff updated the diff for D29768: Fix hidpi issues with scaled avatars in message list delegate.

fix ws issue and clear entries

Fri, May 15, 11:07 AM
mwolff committed R32:1a8f5d4ac99e: Initialize Signature::isConst (authored by mwolff).
Initialize Signature::isConst
Fri, May 15, 11:03 AM
mwolff committed R32:ed491e4751f1: Link all cmake tests against kdevcmakemanagernosettings (authored by mwolff).
Link all cmake tests against kdevcmakemanagernosettings
Fri, May 15, 11:03 AM
mwolff committed R32:0ffad77b9e32: Disable usage of CMakePreferences in kdevcmakemanagernosettings (authored by mwolff).
Disable usage of CMakePreferences in kdevcmakemanagernosettings
Fri, May 15, 11:03 AM
mwolff committed R32:4c8c89b6cfa1: Move gdb configpage to plugin source as it depends on that (authored by mwolff).
Move gdb configpage to plugin source as it depends on that
Fri, May 15, 11:03 AM
mwolff committed R32:84434de05fe0: Unbreak test_qmljscompletion js_skip_separators (authored by mwolff).
Unbreak test_qmljscompletion js_skip_separators
Fri, May 15, 11:03 AM
mwolff updated the diff for D29768: Fix hidpi issues with scaled avatars in message list delegate.

don't use QPixmapCache

Fri, May 15, 10:22 AM
mwolff planned changes to D29768: Fix hidpi issues with scaled avatars in message list delegate.
Fri, May 15, 10:09 AM
mwolff updated the diff for D29768: Fix hidpi issues with scaled avatars in message list delegate.

fix layouting

Fri, May 15, 8:17 AM
mwolff planned changes to D29768: Fix hidpi issues with scaled avatars in message list delegate.

the layout uses the larger scale size now for the line height which is wrong, it needs to take the dpr into account - will fix

Fri, May 15, 8:09 AM
mwolff requested review of D29769: Use smooth transformation for avatar downscaling.
Fri, May 15, 8:03 AM
mwolff requested review of D29768: Fix hidpi issues with scaled avatars in message list delegate.
Fri, May 15, 8:03 AM

Thu, May 14

mwolff committed R52:fd75455eae7b: Merge branch '5.5' (authored by mwolff).
Merge branch '5.5'
Thu, May 14, 2:24 PM
mwolff committed R52:5753d80c8921: Check type before accessing it (authored by mwolff).
Check type before accessing it
Thu, May 14, 2:24 PM
mwolff requested review of D29746: Centralize test account initialization.
Thu, May 14, 1:00 PM
mwolff updated the diff for D29499: Fix hidpi issues with ShowImageWidget and MessageDelegateHelperImage.

fix test

Thu, May 14, 12:58 PM
mwolff added a comment to D29499: Fix hidpi issues with ShowImageWidget and MessageDelegateHelperImage.

here's how it looks like with animated gifs now, the delegate is nice and sharp but the dialog is blocky but functional. QMovie lacks a DPR-setter, so there's no way for us to fix the dialog afaik, unless we do what the delegate does (extract frames on by one)

Thu, May 14, 11:50 AM
mwolff updated the diff for D29499: Fix hidpi issues with ShowImageWidget and MessageDelegateHelperImage.

remove unintended change, I hate arc/phabricator

Thu, May 14, 11:42 AM
mwolff updated the diff for D29499: Fix hidpi issues with ShowImageWidget and MessageDelegateHelperImage.

fix issues with animated gifs

Thu, May 14, 11:41 AM

Sun, May 10

mwolff updated the diff for D29496: Add a spin box to control the image zoom level.

remove unintended ws change

Sun, May 10, 12:43 PM
mwolff updated the diff for D29496: Add a spin box to control the image zoom level.

update test

Sun, May 10, 12:41 PM

Thu, May 7

mwolff added a comment to D29499: Fix hidpi issues with ShowImageWidget and MessageDelegateHelperImage.

you are right, that part has regressed. I'll look into that later

Thu, May 7, 11:57 AM

Wed, May 6

mwolff added a comment to D29499: Fix hidpi issues with ShowImageWidget and MessageDelegateHelperImage.

after:

Wed, May 6, 8:48 PM
mwolff added reviewers for D29497: Use smooth transformation when scaling pixmaps: mlaurent, dfaure.
Wed, May 6, 8:46 PM
mwolff added reviewers for D29496: Add a spin box to control the image zoom level: mlaurent, dfaure.
Wed, May 6, 8:46 PM
mwolff requested review of D29499: Fix hidpi issues with ShowImageWidget and MessageDelegateHelperImage.
Wed, May 6, 8:46 PM
mwolff requested review of D29498: Center align images in ShowImageWidget.
Wed, May 6, 8:46 PM
mwolff requested review of D29497: Use smooth transformation when scaling pixmaps.
Wed, May 6, 8:46 PM
mwolff requested review of D29496: Add a spin box to control the image zoom level.
Wed, May 6, 8:45 PM
mwolff committed R105:64d6c18c67bf: Enable hidpi pixmaps in ksshaskpass (authored by mwolff).
Enable hidpi pixmaps in ksshaskpass
Wed, May 6, 12:31 PM
mwolff closed D29460: Preselect a sane default file name when asking for save-to location.
Wed, May 6, 8:31 AM
mwolff committed R865:13653895b1bc: Preselect a sane default file name when asking for save-to location (authored by mwolff).
Preselect a sane default file name when asking for save-to location
Wed, May 6, 8:31 AM

Tue, May 5

mwolff requested review of D29460: Preselect a sane default file name when asking for save-to location.
Tue, May 5, 9:03 PM

May 5 2020

mwolff committed R739:3681f841e62a: Fix compile on ArchLinux with capstone installed (authored by mwolff).
Fix compile on ArchLinux with capstone installed
May 5 2020, 8:46 AM

May 3 2020

mwolff committed R32:0b238f2f981f: Unbreak test_gdbprinters (authored by mwolff).
Unbreak test_gdbprinters
May 3 2020, 8:14 PM
mwolff committed R32:519637dc4d9c: Fix test_gdb (authored by mwolff).
Fix test_gdb
May 3 2020, 8:13 PM
mwolff committed R32:b9078cbd4b86: Consider catchpoint to be a code breakpoint (authored by mwolff).
Consider catchpoint to be a code breakpoint
May 3 2020, 8:13 PM
mwolff committed R32:0b8788fde86a: Unbreak gdb/lldb unit tests (authored by mwolff).
Unbreak gdb/lldb unit tests
May 3 2020, 8:12 PM
mwolff committed R32:234ffb80ed1e: Unbreak test_cmakemanager testReload (authored by mwolff).
Unbreak test_cmakemanager testReload
May 3 2020, 7:20 PM
mwolff committed R32:dba3cb0c3c72: don't load plugins in test_itemrepositoryregistry_automatic (authored by mwolff).
don't load plugins in test_itemrepositoryregistry_automatic
May 3 2020, 7:19 PM

May 2 2020

mwolff committed R32:73185564fa79: Actually remove temporary item repository directories (authored by mwolff).
Actually remove temporary item repository directories
May 2 2020, 9:37 PM
mwolff committed R32:65cdabaf7dc4: Workaround behavior change in QUrl::adjusted(QUrl::NormalizePathSegments) (authored by mwolff).
Workaround behavior change in QUrl::adjusted(QUrl::NormalizePathSegments)
May 2 2020, 9:37 PM
mwolff committed R32:5b5631725bc6: Revert "kdev-clang: suspend translations units when we don't need them" (authored by mwolff).
Revert "kdev-clang: suspend translations units when we don't need them"
May 2 2020, 8:43 PM
mwolff added a reverting change for R32:66253c6df81f: kdev-clang: suspend translations units when we don't need them: R32:5b5631725bc6: Revert "kdev-clang: suspend translations units when we don't need them".
May 2 2020, 8:43 PM
mwolff committed R32:6efab5edcdca: Prevent recursion in environment variable expansion (authored by mwolff).
Prevent recursion in environment variable expansion
May 2 2020, 7:59 PM
mwolff added a comment to D18551: clang: Create preamble only on second parse.

https://invent.kde.org/kde/kdevelop/-/commit/66253c6df81fb29f60df5f88e30dc29f57cdb36e

May 2 2020, 2:09 PM · KDevelop

May 1 2020

mwolff added a comment to D18551: clang: Create preamble only on second parse.

I've now pushed another patch which will suspend TUs to reduce memory consumption further.

May 1 2020, 4:07 PM · KDevelop
mwolff committed R32:66253c6df81f: kdev-clang: suspend translations units when we don't need them (authored by mwolff).
kdev-clang: suspend translations units when we don't need them
May 1 2020, 4:06 PM
mwolff committed R32:f8c650d99fe9: Ensure validity of d before accessing it (authored by mwolff).
Ensure validity of d before accessing it
May 1 2020, 4:06 PM
mwolff committed R32:3877b083740b: Remove empty non-capturing group (authored by mwolff).
Remove empty non-capturing group
May 1 2020, 4:06 PM
mwolff committed R32:664b5496e13e: Also highlight CMake 'Generating done' messages (authored by mwolff).
Also highlight CMake 'Generating done' messages
May 1 2020, 4:06 PM

Apr 20 2020

mwolff committed R32:4f55b2e7bb9b: Allow passing custom args to clang through clang-parser utility (authored by mwolff).
Allow passing custom args to clang through clang-parser utility
Apr 20 2020, 3:25 PM
mwolff committed R32:28befed97e10: Skip unexposed DecompositionDecl (authored by mwolff).
Skip unexposed DecompositionDecl
Apr 20 2020, 3:25 PM
mwolff committed R32:64a118aaa147: Output isCursorDefinition state in the clang minimal visitor (authored by mwolff).
Output isCursorDefinition state in the clang minimal visitor
Apr 20 2020, 3:25 PM
mwolff committed R32:9898ff4bf922: Fix compiler warning about unused parameter (authored by mwolff).
Fix compiler warning about unused parameter
Apr 20 2020, 3:25 PM

Apr 17 2020

mwolff committed R865:f69e69635b79: Make Utils::convertTextWithUrl more error resilient (authored by mwolff).
Make Utils::convertTextWithUrl more error resilient
Apr 17 2020, 8:25 AM
mwolff closed D28860: Make Utils::convertTextWithUrl more error resilient.
Apr 17 2020, 8:25 AM

Apr 16 2020

mwolff abandoned D27814: Show a generic message tooltip when hovering outside text area.
Apr 16 2020, 9:23 PM
mwolff added inline comments to D28860: Make Utils::convertTextWithUrl more error resilient.
Apr 16 2020, 7:14 PM

Apr 15 2020

mwolff requested review of D28860: Make Utils::convertTextWithUrl more error resilient.
Apr 15 2020, 8:24 PM

Apr 5 2020

mwolff committed R45:eaa628d840c6: boost-zstd: Add Boost include dirs (authored by Michael Friedrich <michael.friedrich@gmail.com>).
boost-zstd: Add Boost include dirs
Apr 5 2020, 12:59 AM

Apr 4 2020

mwolff committed R230:db5c1fa9b861: Ignore races in glib event loop (authored by mwolff).
Ignore races in glib event loop
Apr 4 2020, 8:42 AM
mwolff committed R230:d3e59db95078: ignore races in QOrderedMutexLocker (authored by mwolff).
ignore races in QOrderedMutexLocker
Apr 4 2020, 8:42 AM

Mar 31 2020

mwolff committed R865:f87471b64c22: Set message ID to prevent assertion in test (authored by mwolff).
Set message ID to prevent assertion in test
Mar 31 2020, 10:57 AM

Mar 30 2020

mwolff committed R32:ccef3c77999f: Disable CSS images workaround for Qt WebEngine build (authored by igorkushnir).
Disable CSS images workaround for Qt WebEngine build
Mar 30 2020, 12:48 PM

Mar 29 2020

mwolff committed R865:66f0fbae36b7: Add LRU cache for QTextDocument to MessageDelegateHelperText (authored by mwolff).
Add LRU cache for QTextDocument to MessageDelegateHelperText
Mar 29 2020, 10:33 PM
mwolff closed D28405: Add LRU cache for QTextDocument to MessageDelegateHelperText.
Mar 29 2020, 10:33 PM
mwolff committed R865:0ecaa54e9d8c: Generalize PixmapCache implementation to LRUCache (authored by mwolff).
Generalize PixmapCache implementation to LRUCache
Mar 29 2020, 10:33 PM
mwolff closed D28404: Generalize PixmapCache implementation to LRUCache.
Mar 29 2020, 10:33 PM
mwolff committed R865:f1b1a06679e9: Remove useless include (authored by mwolff).
Remove useless include
Mar 29 2020, 10:33 PM
mwolff updated the diff for D28404: Generalize PixmapCache implementation to LRUCache.

double rotate all the way! https://cpp.godbolt.org/z/fWQ7ig

Mar 29 2020, 10:30 PM
mwolff updated the diff for D28404: Generalize PixmapCache implementation to LRUCache.

use forward iterators, see also: https://cpp.godbolt.org/z/msSQar

Mar 29 2020, 10:20 PM
mwolff updated the diff for D28404: Generalize PixmapCache implementation to LRUCache.

fixup the rotate call, thanks! also expanded the test to catch this

Mar 29 2020, 10:01 PM
mwolff updated the diff for D28404: Generalize PixmapCache implementation to LRUCache.

expand test on empty LRU cache

Mar 29 2020, 9:16 PM
mwolff added inline comments to D28404: Generalize PixmapCache implementation to LRUCache.
Mar 29 2020, 9:15 PM
mwolff updated the diff for D28405: Add LRU cache for QTextDocument to MessageDelegateHelperText.

fillTextDocument -> createTextDocument

Mar 29 2020, 8:11 PM
mwolff updated the diff for D28404: Generalize PixmapCache implementation to LRUCache.

actually update LRU order on use too, not just on insert

Mar 29 2020, 8:09 PM
mwolff added a comment to D28404: Generalize PixmapCache implementation to LRUCache.

doh yes very much, what was I thinking :D

Mar 29 2020, 3:49 PM
mwolff updated the diff for D28405: Add LRU cache for QTextDocument to MessageDelegateHelperText.

only call setTextWidth when needed

Mar 29 2020, 1:40 PM
mwolff requested review of D28405: Add LRU cache for QTextDocument to MessageDelegateHelperText.
Mar 29 2020, 1:35 PM
mwolff added reviewers for D28404: Generalize PixmapCache implementation to LRUCache: dfaure, mlaurent.
Mar 29 2020, 1:32 PM
mwolff updated the diff for D28404: Generalize PixmapCache implementation to LRUCache.

fixup

Mar 29 2020, 1:31 PM