mwolff (Milian Wolff)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 16 2015, 7:53 PM (190 w, 5 d)
Availability
Available

Recent Activity

Tue, Dec 4

mwolff requested changes to D17241: WIP:Disable highlighting for lines longer than 1024 characters..

what sven said, we should also remove the code to disable highlighting altogether when the line limit is reached, no?

Tue, Dec 4, 9:33 AM · Frameworks, Kate

Wed, Nov 28

mwolff committed R45:68fbf9d224d4: Prevent deadlock while reading RSS value from statm (authored by mwolff).
Prevent deadlock while reading RSS value from statm
Wed, Nov 28, 2:30 PM
mwolff committed R45:cca24d04d62a: Don't try to free allocations from our dummy calloc implementation (authored by mwolff).
Don't try to free allocations from our dummy calloc implementation
Wed, Nov 28, 2:30 PM

Mon, Nov 19

mwolff added a comment to D16942: CMakeCacheModel: avoid string memory duplication.

ah I see, then your code should indeed be better!

Mon, Nov 19, 3:19 PM · KDevelop

Sun, Nov 18

mwolff added inline comments to D16942: CMakeCacheModel: avoid string memory duplication.
Sun, Nov 18, 7:55 PM · KDevelop

Oct 31 2018

mwolff accepted D16356: FunctionDefinition: only look for (new/other) function definition if we don't have one.

please cleanup the test slightly and then push it directly (no need for another round of review)

Oct 31 2018, 8:25 AM · KDevelop

Oct 28 2018

mwolff added a comment to D16356: FunctionDefinition: only look for (new/other) function definition if we don't have one.

the test would go into clang's test_duchain.cpp, create a method in there with the three TestFiles with the appropriate contents. Then parse them all and finally query the functions declarations and verify that the appropriate function definition is returned always.

Oct 28 2018, 7:39 PM · KDevelop

Oct 22 2018

mwolff accepted D16356: FunctionDefinition: only look for (new/other) function definition if we don't have one.

I assume you ran the tests (esp. for clang?) and it all keeps passing? if so, then +1

Oct 22 2018, 6:22 PM · KDevelop
mwolff updated subscribers of D16326: Replace leading typed text when completing function implementation.

I'd say master personally, but @brauch or @kfunk should decide that.

Oct 22 2018, 11:10 AM · KDevelop
mwolff accepted D16326: Replace leading typed text when completing function implementation.

thanks a lot! do you have commit rights, or should we push this for you?

Oct 22 2018, 10:43 AM · KDevelop

Oct 21 2018

mwolff added inline comments to D16326: Replace leading typed text when completing function implementation.
Oct 21 2018, 7:40 PM · KDevelop
mwolff committed R32:fc68afeb8d74: Make the code compile with older Qt (authored by mwolff).
Make the code compile with older Qt
Oct 21 2018, 7:35 PM
mwolff requested changes to D16326: Replace leading typed text when completing function implementation.

can you also add a test for this new behavior with white space?

Oct 21 2018, 6:39 PM · KDevelop
mwolff added a comment to D16356: FunctionDefinition: only look for (new/other) function definition if we don't have one.

looking at the code, it really is missing there. You'll need a const cast but that's OK

Oct 21 2018, 6:36 PM · KDevelop
mwolff added a comment to D16326: Replace leading typed text when completing function implementation.

Added tests in testCompleteFunction, which already has some implements-completion
tests. Should I move them to a different test, something like testImplementExecute
in a different patch or this one ?

Completion tests are also broken, crashing after executing a single test case
because of a delayed connection, triggering the slot only after the document is closed.
As a workaround, I've used

diff --git a/plugins/clang/tests/codecompletiontestbase.cpp b/plugins/clang/tests/codecompletiontestbase.cpp
index 5b351d0d27..282f7da36e 100644
--- a/plugins/clang/tests/codecompletiontestbase.cpp
+++ b/plugins/clang/tests/codecompletiontestbase.cpp
@@ -70,6 +70,7 @@ void CodeCompletionTestBase::initTestCase()
     m_projectController = new TestProjectController(core);
     core->setProjectController(m_projectController);
     ICore::self()->documentController()->closeAllDocuments();
+    QObject::disconnect(ICore::self()->documentController(), nullptr, nullptr, nullptr);
 
     ClangSettingsManager::self()->m_enableTesting = true;
 }

Which still has a crash, but only at the very end after executing everything.

Oct 21 2018, 6:15 PM · KDevelop
mwolff committed R32:8f9f8d1c4452: Fix crashes when document gets destroyed directly after load (authored by mwolff).
Fix crashes when document gets destroyed directly after load
Oct 21 2018, 6:14 PM
mwolff requested changes to D16356: FunctionDefinition: only look for (new/other) function definition if we don't have one.
Oct 21 2018, 6:08 PM · KDevelop
mwolff added a comment to D16356: FunctionDefinition: only look for (new/other) function definition if we don't have one.

I'd say this new code should go into FunctionDefinition::definition instead, no? I.e. check there whether decl is already a definition and if so return that directly?

Oct 21 2018, 6:07 PM · KDevelop
mwolff accepted D16315: Offer completion after user types the scope resolution operator..

very good idea

Oct 21 2018, 4:04 PM · KDevelop
mwolff requested changes to D16326: Replace leading typed text when completing function implementation.

lgtm in general, three small nitpicks and I'll have a look at the broken unit test now too.

Oct 21 2018, 4:02 PM · KDevelop

Jul 27 2018

mwolff accepted D14424: Cppcheck plugin: use QPlainTextEdit for non-richtext text display.
Jul 27 2018, 12:36 PM · KDevelop
mwolff accepted D14413: subversion plugin: fix ThreadWeaver job lifetime race condition.

nasty issue, thanks for fixing it

Jul 27 2018, 8:56 AM · KDevelop

Jul 24 2018

mwolff added a comment to D13613: RFC: Fix libclang default include paths on FreeBSD..

this can now be abandoned, right? the other patch seems to supersede this?

Jul 24 2018, 8:44 PM · KDevelop
mwolff accepted D14337: Fix GdbTest::testUpdateBreakpoint from messed-up break points positions.

if it makes tests pass, I'm all for it

Jul 24 2018, 8:43 PM · KDevelop
mwolff accepted D14313: Fix clangsupport on FreeBSD..

either implement pinos variant or keep the old code and change the header name in two places

Jul 24 2018, 8:42 PM · KDevelop

Jul 2 2018

mwolff added a comment to D13613: RFC: Fix libclang default include paths on FreeBSD..

Could it be that the issue is that on your system, libc++ and the clang compiler builtin-headers are installed in the same prefix? On Linux at least, that is usually not the case afaik. Thus we didn't run into this issue yet.

Jul 2 2018, 9:07 PM · KDevelop
mwolff committed R45:57ced4818389: Merge branch '1.1' (authored by mwolff).
Merge branch '1.1'
Jul 2 2018, 9:00 PM
mwolff committed R45:5ff967ab12fd: Call libc / libstdc++ freeres function in libheaptrack's atexit (authored by mwolff).
Call libc / libstdc++ freeres function in libheaptrack's atexit
Jul 2 2018, 9:00 PM

Jun 21 2018

mwolff requested changes to D13613: RFC: Fix libclang default include paths on FreeBSD..

I also believe that this is the wrong way for fixing this.

Jun 21 2018, 3:59 PM · KDevelop

Jun 14 2018

mwolff accepted D13537: Fix definesandincludes test..

thanks for fixing the tests! much appreciated

Jun 14 2018, 2:12 PM · KDevelop

Jun 13 2018

mwolff accepted D13517: Fix QuickOpen with Qt 5.11 (bug 395039).

no clue, I wouldn't be surprised by bugs/regressions in Qt - I've seen a lot of breakage in item/view code recently

Jun 13 2018, 3:00 PM · Kate
mwolff accepted D13515: Remove KNS::Engine d-pointer hack.

this is binary compatible from what I can see

Jun 13 2018, 2:08 PM · Frameworks

Jun 12 2018

mwolff accepted D13420: Add support for the object typehint..

lgtm too - thanks Heinz

Jun 12 2018, 8:49 PM · KDevelop
mwolff accepted D13313: Fix using reserved type names in identifiers..

lgtm, thanks!

Jun 12 2018, 8:48 PM · KDevelop
mwolff added a comment to D13453: Fix build on platforms where sizeof(int) == sizeof(long).

Isn't this fixed in master and 1.1 branch (after the 1.1 release) already?
76fd2e84ba133e96d2cfdf90cb715e66e923eb8f and 49577e019ea791ee63962cdfe7e9c0c5b5c6ea4b ?

Jun 12 2018, 8:28 PM

May 29 2018

mwolff committed R45:b48befecc15c: Fix another compile error on 32bit (authored by mwolff).
Fix another compile error on 32bit
May 29 2018, 9:11 AM
mwolff accepted D12743: Unit tests fixes.

ouch, thanks a lot for the investigation. This is similar to the QStringBuilder crashes one can get... Can you simplify the line based on my suggestion? then it's a clear +2 from me, please also include the analysis and valgrind output in your commit message.

May 29 2018, 9:09 AM
mwolff committed R45:986aed02da77: Merge remote-tracking branch 'origin/1.1' (authored by mwolff).
Merge remote-tracking branch 'origin/1.1'
May 29 2018, 8:47 AM
mwolff committed R45:c456f6a1575f: Fix compile warnings about format type mismatch on 32bit (authored by mwolff).
Fix compile warnings about format type mismatch on 32bit
May 29 2018, 8:47 AM
mwolff committed R45:49577e019ea7: Fix another compile error on 32bit (authored by mwolff).
Fix another compile error on 32bit
May 29 2018, 8:42 AM

May 17 2018

mwolff closed T1841: heaptrack: support debuglink and UUID for split debug info as Resolved.

fixed by using an updated libbacktrace

May 17 2018, 8:47 PM · Performance Tooling, Heaptrack
mwolff committed R45:eaca9e15ec4c: Merge branch '1.1' (authored by mwolff).
Merge branch '1.1'
May 17 2018, 11:33 AM
mwolff committed R45:76fd2e84ba13: Fix compile on 32bit (authored by mwolff).
Fix compile on 32bit
May 17 2018, 11:33 AM

May 16 2018

mwolff committed R45:81f23394bc02: Silence compiler warnings (authored by mwolff).
Silence compiler warnings
May 16 2018, 12:31 PM
mwolff committed R45:b1deb436f2ec: Fix clang compiler warning (authored by mwolff).
Fix clang compiler warning
May 16 2018, 12:31 PM
mwolff committed R45:db70b1ea2fd8: Use "char" instead of "char *" for dummy calloc buffer elements (authored by mwolff).
Use "char" instead of "char *" for dummy calloc buffer elements
May 16 2018, 12:31 PM
mwolff committed R45:c852afd92601: silence GCC warning: ignoring attributes on template argument (authored by mwolff).
silence GCC warning: ignoring attributes on template argument
May 16 2018, 12:31 PM
mwolff committed R45:e89290ca0607: fix gcc warning: catching polymorphic type 'class std::system_error' by value… (authored by mwolff).
fix gcc warning: catching polymorphic type 'class std::system_error' by value…
May 16 2018, 12:31 PM
mwolff committed R45:6a565f9aa4f4: Fix clang warning: lambda capture 'this' is not used [-Wunused-lambda-capture] (authored by mwolff).
Fix clang warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
May 16 2018, 12:31 PM
mwolff committed R45:45a33190752a: Merge branch '1.1' (authored by mwolff).
Merge branch '1.1'
May 16 2018, 7:33 AM

May 8 2018

mwolff added a comment to D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays.

Let's try to fix the bug for real, instead of implementing half-baked workarounds that only work for the default configurations.

May 8 2018, 7:14 PM · Frameworks
mwolff added a comment to D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays.

Maybe instead use the HighlightText QPalette color? Hardcoding red may work for the two styles you present, but I could just set the view background to red and the text becomes unusable.

May 8 2018, 6:34 PM · Frameworks

May 7 2018

mwolff requested changes to D12743: Unit tests fixes.
May 7 2018, 7:17 PM
mwolff added a comment to D12746: KDevelop: alternative monolithic storage options for TopDUContexts (PoC).

so what's your plan with this now? Do you actually want to move this forward? Then we need to find a good solution that works everywhere. The numbers aren't that useful on their own, as there the current implementation which is trivial and has no external dependencies is apparently still the best by a margin...

May 7 2018, 7:15 PM · KDevelop
mwolff added a comment to D12694: Properly fix the native messaging host file.

@bshah ping? will you push this?

May 7 2018, 6:56 PM · Plasma

May 4 2018

mwolff committed R230:753cf3d8c8c1: Catch more std::atomic symbols in the suppression rules (authored by mwolff).
Catch more std::atomic symbols in the suppression rules
May 4 2018, 9:38 PM
mwolff committed R230:456a5ba2fc6b: Add suppression for C++ atomic load/store operations (authored by mwolff).
Add suppression for C++ atomic load/store operations
May 4 2018, 9:25 PM
mwolff committed R230:caa44d75d6a3: Supress data race warnings for some C atomic operations (AO_*) (authored by mwolff).
Supress data race warnings for some C atomic operations (AO_*)
May 4 2018, 9:25 PM
mwolff committed R45:97f7e115fb17: Use proper delete[] for the out buffer (authored by mwolff).
Use proper delete[] for the out buffer
May 4 2018, 8:51 PM
mwolff committed R234:d4e2ad9f56b9: Add heaptrack screenshots (authored by mwolff).
Add heaptrack screenshots
May 4 2018, 7:01 PM
mwolff added a comment to D12694: Properly fix the native messaging host file.

It compiles, how do I test it? Can you please also add a README to the root of this project that explains what this is, does and how to use it?

May 4 2018, 4:55 PM · Plasma
mwolff accepted D12511: optimization of KTextEditor::DocumentPrivate::views().

OK, cool! That clearly shows that this patch _is_ valuable: Before we have ~6% CPU cycle cost, now it's down to 1.5% (inclusively). This is a significant reduction, so I'm all for it.

May 4 2018, 4:49 PM · Frameworks, Kate
mwolff committed R45:bc3b51d9749f: Merge branch '1.1' (authored by mwolff).
Merge branch '1.1'
May 4 2018, 4:46 PM
mwolff committed R45:a44b314095d5: Fix appstream screenshot URLs (authored by mwolff).
Fix appstream screenshot URLs
May 4 2018, 4:46 PM
mwolff committed R45:aec1ea2f2b7f: Fix appstream test: (authored by mwolff).
Fix appstream test:
May 4 2018, 4:46 PM
mwolff committed R247:1ef97398a12e: Set 1.1 as stable heaptrack branch for translation (authored by mwolff).
Set 1.1 as stable heaptrack branch for translation
May 4 2018, 4:45 PM
mwolff committed R45:5fea57617737: Merge branch '1.1' (authored by mwolff).
Merge branch '1.1'
May 4 2018, 4:35 PM
mwolff committed R45:dd6a4e83ca6b: Include and find zstd in the AppImage bundle (authored by mwolff).
Include and find zstd in the AppImage bundle
May 4 2018, 4:35 PM
mwolff committed R45:bab1109ec488: Use check-c_source_compiles to find unw_set_cache_size (authored by mwolff).
Use check-c_source_compiles to find unw_set_cache_size
May 4 2018, 4:35 PM
mwolff committed R45:a3716f0965e4: Don't report a runtime error when zstd isn't found (authored by mwolff).
Don't report a runtime error when zstd isn't found
May 4 2018, 4:34 PM
mwolff added a comment to D12511: optimization of KTextEditor::DocumentPrivate::views().

perf record -g produces unusable data files, since it relies on the frame pointer which is usually not available. Use perf record --call-graph dwarf instead. https://phabricator.kde.org/file/data/w4qogv4brtxlc5p5bnwr/PHID-FILE-q62giymcptudpl5m6bt3/kwrite_perf_after_25_dwarf_caller.png shows ~1.5% in notifyAboutRangeChange (inclusively). Is that before or after your patch here?

May 4 2018, 4:17 PM · Frameworks, Kate
mwolff committed R45:ba5e14551db2: Set heaptrack version to 1.1.80 for what will become 1.2.0 eventually (authored by mwolff).
Set heaptrack version to 1.1.80 for what will become 1.2.0 eventually
May 4 2018, 3:42 PM
mwolff committed R45:2d05fe96ac4a: Update versions in preparation of heaptrack v1.1.0 release (authored by mwolff).
Update versions in preparation of heaptrack v1.1.0 release
May 4 2018, 3:42 PM
mwolff committed R45:ce2776858e12: Remove sparse hash benchmark (authored by mwolff).
Remove sparse hash benchmark
May 4 2018, 3:42 PM
mwolff committed R32:f4856697d5bc: Fix compile with Qt older than 5.10 (authored by mwolff).
Fix compile with Qt older than 5.10
May 4 2018, 3:39 PM
mwolff committed R32:169371b5d344: Allow overriding the path to the builtin clang compiler headers (authored by mwolff).
Allow overriding the path to the builtin clang compiler headers
May 4 2018, 3:35 PM
mwolff added a comment to D12511: optimization of KTextEditor::DocumentPrivate::views().

Actually, no. Ignore what I said. The pictures you are showing are pretty meaningless. Did you run perf with --call-graph dwarf? Better look at the flamegraph and search for the function you are interested in (Kate::TextBuffer::notifyAboutRangeChange) or use the Caller/Callee view to get an aggregated view of your change.

May 4 2018, 2:20 PM · Frameworks, Kate
mwolff added a comment to D12511: optimization of KTextEditor::DocumentPrivate::views().

But the hotspot screenshot clearly shows that you are spending time on optimizing things that are barely noticeable. You have optimized a function that consumes 0.3% of the CPU cycles. It now consumes only ~0.15%, at the cost of slightly higher memory consumption.

May 4 2018, 2:09 PM · Frameworks, Kate
mwolff added a comment to D12511: optimization of KTextEditor::DocumentPrivate::views().

Oh and again: please start using perf/hotspot instead of callgrind. Really, the performance numbers you get from callgrind are just *instructions*! It doesn't mean "65% of CPU". It means 65% of the instructions.

May 4 2018, 8:41 AM · Frameworks, Kate
mwolff requested changes to D12511: optimization of KTextEditor::DocumentPrivate::views().

lgtm in general, but codewise can be improved

May 4 2018, 8:38 AM · Frameworks, Kate

May 3 2018

mwolff committed R45:07d585655ebd: Add scripts to generate heaptrack AppImages in Docker (authored by mwolff).
Add scripts to generate heaptrack AppImages in Docker
May 3 2018, 8:56 PM

May 2 2018

mwolff committed R45:35a5bde9bd50: WIP: add docker and build script for app image generation (authored by mwolff).
WIP: add docker and build script for app image generation
May 2 2018, 8:43 PM

May 1 2018

mwolff committed R45:3eefe94a0829: Fix compile when option Boost dependencies are not available (authored by mwolff).
Fix compile when option Boost dependencies are not available
May 1 2018, 8:46 PM
mwolff added a reverting change for R45:232c92992d19: Fix bounds check: 0 is a valid index: R45:8aec0f5c2215: Check and override all symbols during injection.
May 1 2018, 6:50 PM
mwolff added a reverting change for R45:ab2a8222da3c: Check symbol table size before accessing it: R45:8aec0f5c2215: Check and override all symbols during injection.
May 1 2018, 6:50 PM
mwolff committed R45:8aec0f5c2215: Check and override all symbols during injection (authored by mwolff).
Check and override all symbols during injection
May 1 2018, 6:50 PM
mwolff committed R45:3907d4d5aa32: Add basic unit test coverage for runtime attaching (authored by mwolff).
Add basic unit test coverage for runtime attaching
May 1 2018, 6:50 PM
mwolff added a comment to D12016: [ktexteditor] much faster positionFromCursor.

regarding the accessibility interface, I agree that it's out of the scope of this patch. I'd say let's keep it like that for now...

May 1 2018, 6:15 PM · Frameworks, Kate

Apr 27 2018

mwolff committed R45:02a19d87f0a6: Include file/line information in heaptrack_interpret error messages (authored by mwolff).
Include file/line information in heaptrack_interpret error messages
Apr 27 2018, 11:19 AM
mwolff committed R45:0d3e48ae7f80: Add basic test coverage for the LineReader (authored by mwolff).
Add basic test coverage for the LineReader
Apr 27 2018, 11:19 AM
mwolff committed R45:60cbfffb62ae: Also use the new LineWriter for heaptrack_interpret (authored by mwolff).
Also use the new LineWriter for heaptrack_interpret
Apr 27 2018, 11:19 AM
mwolff committed R45:4e72941cd56a: Always use std::mutex for locking, never a custom spin lock (authored by mwolff).
Always use std::mutex for locking, never a custom spin lock
Apr 27 2018, 11:19 AM
mwolff committed R45:e15aee2acb9d: Introduce a custom LineWriter for high-performance hex line printing (authored by mwolff).
Introduce a custom LineWriter for high-performance hex line printing
Apr 27 2018, 11:19 AM
mwolff committed R45:95a17c6a407a: Do not use stdio for buffered I/O (authored by mwolff).
Do not use stdio for buffered I/O
Apr 27 2018, 11:18 AM
mwolff committed R32:c791359763cd: Always use the clang builtin headers for the libclang version we use (authored by mwolff).
Always use the clang builtin headers for the libclang version we use
Apr 27 2018, 10:24 AM
mwolff committed R32:e48c6265e844: Group completion requests and only handle the last one (authored by mwolff).
Group completion requests and only handle the last one
Apr 27 2018, 10:24 AM
mwolff closed D12331: Always use the clang builtin headers for the libclang version we use.
Apr 27 2018, 10:24 AM
mwolff closed D12298: Group completion requests and only handle the last one.
Apr 27 2018, 10:24 AM

Apr 24 2018

mwolff committed R45:215869fbd088: Don't unlock when locking failed in the timer thread (authored by mwolff).
Don't unlock when locking failed in the timer thread
Apr 24 2018, 2:36 PM
mwolff committed R45:fc4b7ef99d3b: Optionally add helgrind annotations to the custom SpinLock (authored by mwolff).
Optionally add helgrind annotations to the custom SpinLock
Apr 24 2018, 2:36 PM