mwolff (Milian Wolff)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 16 2015, 7:53 PM (252 w, 3 d)
Availability
Available

Recent Activity

Fri, Feb 14

mwolff committed R32:8990ab994ecc: Merge branch '5.5' (authored by mwolff).
Merge branch '5.5'
Fri, Feb 14, 10:32 AM
mwolff committed R32:f8754f08ac09: Clear selection when updating cursor position (authored by mwolff).
Clear selection when updating cursor position
Fri, Feb 14, 10:32 AM
mwolff committed R32:9de3f5b69f6d: Merge branch '5.5' (authored by mwolff).
Merge branch '5.5'
Fri, Feb 14, 10:13 AM
mwolff committed R32:aa7bc707be21: Don't crash when we fail to find a screen for the active tooltip (authored by mwolff).
Don't crash when we fail to find a screen for the active tooltip
Fri, Feb 14, 10:13 AM
mwolff committed R32:11cdf99776e4: kdev-clang: don't skip unexposed declarations from different files (authored by mwolff).
kdev-clang: don't skip unexposed declarations from different files
Fri, Feb 14, 10:13 AM
mwolff added a comment to R32:a7f7c9ac6b8f: kdev-clang: don't skip unexposed declarations from different files.

ok, done

Fri, Feb 14, 10:04 AM
mwolff added a comment to D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines.

Ok, I now fully got this, thanks for the explanation. And indeed without any left fill visual feedback is missing.

What I wonder is how much of this needs to be configurable. We could also just make the left fill of 4 default or so.

In any case, I think we should go forward with this patch. @cullmann your opinion?

Fri, Feb 14, 9:33 AM · Frameworks, Kate

Thu, Feb 13

mwolff added a comment to D27065: Fix inverted logic in IOKitStorage::isRemovable.

ping? any update?

Thu, Feb 13, 11:44 AM · Frameworks

Wed, Feb 12

mwolff added a comment to R32:a7f7c9ac6b8f: kdev-clang: don't skip unexposed declarations from different files.

Hi @mwolff . Your latest commits like this seem like bug fixes, yet they went only to master. On purpose? Which should be cherrypicked to the 5.5 branch?

Wed, Feb 12, 10:10 AM

Mon, Feb 10

mwolff added a comment to D27065: Fix inverted logic in IOKitStorage::isRemovable.

How do you connect? The Mac OS has a built-in VNC server but it has to be activated. Once it is you should be able to connect using any VNC client (possibly using ssh tunnelling?).

Mon, Feb 10, 1:25 PM · Frameworks
mwolff added a comment to D27065: Fix inverted logic in IOKitStorage::isRemovable.

I now got remote access to a macOS machine. That's where I now got the output from. How do I see all drives in finder? I.e. how could I make the association between the solid-hardware5 output and finder?

Mon, Feb 10, 11:38 AM · Frameworks
mwolff added a comment to D27065: Fix inverted logic in IOKitStorage::isRemovable.

before:

[snip]

Note the Ejectable = false (bool) vs. StorageDrive.removable = true (bool). The patch here fixes it to yield StorageDrive.removable = false (bool)

Where does this output come from, and what kind of drive does it concern (apart from some kind of Apple-branded SSD)? In other words, should removable be false, or should ejectable be true? I concur that the status quo appears inappropriate, at least in "Finder speak" which uses "Eject" for any form of unmounting regardless of whether it implies a physical eject.

Mon, Feb 10, 11:02 AM · Frameworks
mwolff added a reviewer for D27065: Fix inverted logic in IOKitStorage::isRemovable: rjvbb.
Mon, Feb 10, 10:12 AM · Frameworks
mwolff added a comment to D27065: Fix inverted logic in IOKitStorage::isRemovable.
udi = 'IOService:/AppleACPIPlatformExpert/PCI0@0/AppleACPIPCI/RP06@1C,5/IOPP/SSD0@0/AppleAHCI/PRT0@0/IOAHCIDevice@0/AppleAHCIDiskDriver/IOAHCIBlockStorageDevice/IOBlockStorageDriver/APPLE SSD SM0256F Media'
  parent = 'IOService:/AppleACPIPlatformExpert/PCI0@0/AppleACPIPCI/RP06@1C,5/IOPP/SSD0@0/AppleAHCI/PRT0@0/IOAHCIDevice@0/AppleAHCIDiskDriver/IOAHCIBlockStorageDevice/IOBlockStorageDriver'  (string)
  vendor = ''  (string)
  product = 'APPLE SSD SM0256F                       '  (string)
  description = 'APPLE SSD SM0256F Media'  (string)
  icon = 'drive-removable-media'  (string)
  Block.major = 1  (0x1)  (int)
  Block.minor = 0  (0x0)  (int)
  Block.device = '/dev/disk0'  (string)
  StorageAccess.accessible = false  (bool)
  StorageAccess.filePath = ''  (string)
  StorageAccess.ignored = false  (bool)
  StorageDrive.bus = 'Platform'  (0x5)  (enum)
  StorageDrive.driveType = 'HardDisk'  (0x0)  (enum)
  StorageDrive.removable = true  (bool)
  StorageDrive.hotpluggable = false  (bool)
  StorageDrive.inUse = true  (bool)
  StorageDrive.size = 251000193024  (0x3a70c70000)  (qulonglong)
  StorageVolume.ignored = false  (bool)
  StorageVolume.usage = 'PartitionTable'  (0x3)  (enum)
  StorageVolume.fsType = ''  (string)
  StorageVolume.label = ''  (string)
  StorageVolume.uuid = ''  (string)
  StorageVolume.size = 251000193024  (0x3a70c70000)  (qulonglong)
Mon, Feb 10, 10:11 AM · Frameworks

Fri, Feb 7

mwolff committed R175:8adbd39b10b7: Fix compile: no target named KF5KHolidays (authored by mwolff).
Fix compile: no target named KF5KHolidays
Fri, Feb 7, 1:29 PM
mwolff committed R32:e37549a4b04c: Don't crash when we fail to find a screen for the active tooltip (authored by mwolff).
Don't crash when we fail to find a screen for the active tooltip
Fri, Feb 7, 11:42 AM

Thu, Feb 6

mwolff committed R32:a7f7c9ac6b8f: kdev-clang: don't skip unexposed declarations from different files (authored by mwolff).
kdev-clang: don't skip unexposed declarations from different files
Thu, Feb 6, 7:27 PM
mwolff committed R32:e84eae141487: Unbreak duchainify (authored by mwolff).
Unbreak duchainify
Thu, Feb 6, 7:27 PM

Mon, Feb 3

mwolff added a comment to D18551: clang: Create preamble only on second parse.

To keep this short I didn't reply to the parts I completely agree with.

Now I actually have /tmp as tmpfs, and so these 400 MB don't come for free. This is perfectly fine when I'm actually working on these files, but so far I have only opened KDevelop.

I see. The problem really is that the preamble files shouldn't be written to /tmp then - it would be perfectly fine to move them to a temp dir on the disk I think - it would still be faster than having to redo the work.

There are arguments for both in-memory and on-disk, it depends on how much memory there is. I have another more more generously sized machine where the files are perfectly fine in RAM.

I think /tmp is correct by the FHS and /var/tmp wouldn't be appropriate. I could easily put this on disk if I wanted to. I just wanted to make the argument that resource usage is a concern, and that there is some benefit in limiting ourselves to the preambles that we need.

Mon, Feb 3, 8:37 PM · KDevelop

Fri, Jan 31

mwolff added a comment to D22477: With auto completion don't show completions that don't match from beginning of typed word.

I agree, this is a feature, not a bug. If people are annoyed, they are usually annoyed by other issues like the one shown by Sven

Fri, Jan 31, 8:40 PM · Frameworks, Kate
mwolff added a comment to D18551: clang: Create preamble only on second parse.

I still think this is the right change, but if there is no consensus I will implement @mwolff's suggestion. That would certainly be an improvement, but it doesn't really solve my problem. I'm currently working on Clang and have around 6 files open, which is really not a lot. I haven't changed any of them. The result:

aaron:~/src/llvm-project> ls -l /tmp/preamble-*
-rw-r--r-- 1 aaron users 73139496 Okt  9 22:27 /tmp/preamble-0e19f4.pch
-rw-r--r-- 1 aaron users 59327864 Okt  9 22:23 /tmp/preamble-2a515c.pch
-rw-r--r-- 1 aaron users 61885536 Okt  9 22:23 /tmp/preamble-2baca3.pch
-rw-r--r-- 1 aaron users 76913424 Okt  9 22:23 /tmp/preamble-9853df.pch
-rw-r--r-- 1 aaron users 64254872 Okt  9 22:23 /tmp/preamble-cbb035.pch
-rw-r--r-- 1 aaron users 64829792 Okt  9 22:24 /tmp/preamble-dd9bf1.pch
aaron:~/src/llvm-project> du -s /tmp/ 2>/dev/null
391204  /tmp/

Now I actually have /tmp as tmpfs, and so these 400 MB don't come for free. This is perfectly fine when I'm actually working on these files, but so far I have only opened KDevelop.

Fri, Jan 31, 8:38 PM · KDevelop
mwolff added a reviewer for D27065: Fix inverted logic in IOKitStorage::isRemovable: Frameworks.
Fri, Jan 31, 1:30 PM · Frameworks
mwolff requested review of D27065: Fix inverted logic in IOKitStorage::isRemovable.
Fri, Jan 31, 1:29 PM · Frameworks

Wed, Jan 29

mwolff added inline comments to R32:c7b8e7973ab0: Delay handling of KDirWatch signals.
Wed, Jan 29, 1:12 PM

Fri, Jan 24

mwolff committed R32:a5cf36fe47ab: Don't crash when signatures don't match in AdaptSignatureAssistant (authored by mwolff).
Don't crash when signatures don't match in AdaptSignatureAssistant
Fri, Jan 24, 10:51 AM

Wed, Jan 22

mwolff accepted D26568: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.

thanks, lgtm - do you have commit rights? if so, please push to master

Wed, Jan 22, 11:39 AM
mwolff committed R32:c110d8c9ec03: Merge branch '5.5' (authored by mwolff).
Merge branch '5.5'
Wed, Jan 22, 9:33 AM
mwolff committed R32:3d79085b82f7: Merge branch '5.4' into 5.5 (authored by mwolff).
Merge branch '5.4' into 5.5
Wed, Jan 22, 9:33 AM
mwolff committed R32:23c7fec54cc2: Fix build against clang built from git (authored by mwolff).
Fix build against clang built from git
Wed, Jan 22, 9:33 AM
mwolff added a comment to D26568: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.

Hey, sorry for the long delay. I'm fine with this change in principle, but please then also increase the minimum Qt version required in CMake. It's currently set to 5.2 which is far too old. Please bump it to 5.10 to support this patch.

Wed, Jan 22, 8:27 AM

Mon, Jan 20

mwolff committed R32:e3883a89853f: Don't get confused when encountering parse errors in default args (authored by mwolff).
Don't get confused when encountering parse errors in default args
Mon, Jan 20, 2:57 PM
mwolff committed R32:54585bcd0de5: Fix ClangUtils::getDefaultArguments when encountering macros (authored by mwolff).
Fix ClangUtils::getDefaultArguments when encountering macros
Mon, Jan 20, 2:06 PM

Jan 7 2020

mwolff committed R45:ecf7dfa85e67: Merge branch '1.2' (authored by mwolff).
Merge branch '1.2'
Jan 7 2020, 12:06 PM
mwolff committed R45:33da3a68d899: Prevent compiler from optimizing away allocation in tst_inject (authored by mwolff).
Prevent compiler from optimizing away allocation in tst_inject
Jan 7 2020, 12:06 PM

Dec 12 2019

mwolff committed R32:f94e6d297673: Skip clang-provided override items from code completion (authored by mwolff).
Skip clang-provided override items from code completion
Dec 12 2019, 10:40 PM
mwolff committed R32:7be3e8b50954: Expect new failure in completion of switch labels (authored by mwolff).
Expect new failure in completion of switch labels
Dec 12 2019, 10:40 PM
mwolff committed R32:275d8778bdc9: Unbreak move-into-source for non-class functions (authored by mwolff).
Unbreak move-into-source for non-class functions
Dec 12 2019, 10:17 PM
mwolff committed R32:27dcd076f307: Unbreak clang test_problems when running against clang 9.0.0+ (authored by mwolff).
Unbreak clang test_problems when running against clang 9.0.0+
Dec 12 2019, 10:17 PM
mwolff committed R32:0f271e251203: Remove expected failure for test passing with clang 9 (authored by mwolff).
Remove expected failure for test passing with clang 9
Dec 12 2019, 10:17 PM
mwolff committed R32:84952f498d2e: lambda init captures are visited starting with clang 9.0.0 (authored by mwolff).
lambda init captures are visited starting with clang 9.0.0
Dec 12 2019, 10:17 PM
mwolff committed R32:9cbb6f2f84f9: Try a bit harder to find types for look-ahead completion (authored by mwolff).
Try a bit harder to find types for look-ahead completion
Dec 12 2019, 10:17 PM
mwolff committed R32:d4a791c686ff: partial clang completion tests: remove self-assignment results (authored by mwolff).
partial clang completion tests: remove self-assignment results
Dec 12 2019, 10:17 PM

Dec 5 2019

mwolff committed R247:ec2a3b69447d: mark 1.2 as stable (authored by mwolff).
mark 1.2 as stable
Dec 5 2019, 8:36 PM

Dec 2 2019

mwolff committed R45:4df3bf969d91: Set version to 1.2.80, i.e. 1.3 alpha 1 (authored by mwolff).
Set version to 1.2.80, i.e. 1.3 alpha 1
Dec 2 2019, 4:56 PM
mwolff committed R45:9c90967be508: Copy recent elf.h into docker to get libunwind with zlib support (authored by mwolff).
Copy recent elf.h into docker to get libunwind with zlib support
Dec 2 2019, 4:56 PM
mwolff committed R45:cb4c48b03d19: Set version to 1.2.0 (authored by mwolff).
Set version to 1.2.0
Dec 2 2019, 4:56 PM
mwolff committed R45:4f1e9784e813: Merge branch '1.1' (authored by mwolff).
Merge branch '1.1'
Dec 2 2019, 4:11 PM
mwolff committed R45:01a5bcdbcb6e: Fix potential source for uninitialized memory (authored by mwolff).
Fix potential source for uninitialized memory
Dec 2 2019, 4:08 PM
mwolff committed R45:e02e1a25aa95: Use the new heaptrack icon (authored by mwolff).
Use the new heaptrack icon
Dec 2 2019, 4:08 PM
mwolff committed R45:bbd3586cdaf2: Port away from deprecated QTreeView::sortByColumn(int) API (authored by mwolff).
Port away from deprecated QTreeView::sortByColumn(int) API
Dec 2 2019, 4:08 PM
mwolff committed R45:857ac706587f: Port away from deprecated QModelIndex::child API (authored by mwolff).
Port away from deprecated QModelIndex::child API
Dec 2 2019, 4:08 PM
mwolff committed R45:47692644c587: Fix compile on CentOS 7.7 (authored by mwolff).
Fix compile on CentOS 7.7
Dec 2 2019, 4:08 PM

Nov 23 2019

mwolff created T12140: Killing KInit With Fire.
Nov 23 2019, 11:45 AM · Frameworks, KF6
mwolff created T12139: Cleanup API Documentation.
Nov 23 2019, 11:37 AM · Frameworks, KF6
mwolff created T12138: QmlObjectSharedEngine.
Nov 23 2019, 11:36 AM · Frameworks, KF6
mwolff created T12137: QmlObject.
Nov 23 2019, 11:36 AM · Frameworks, KF6
mwolff added a comment to T12127: move ConfigModule next to KCModule widget counter part.

ConfigModule would be better somewhere else, ideally in the same repository than KCModule (since they solve the same problem, it's just Quick vs Widgets here). There are two ways forward depending on how KConfigWidgets can be realistically streamlined:

Nov 23 2019, 11:36 AM · Frameworks, KF6
mwolff created T12136: ConfigModule.
Nov 23 2019, 11:35 AM · Frameworks, KF6
mwolff created T12135: QtQuickSettings.
Nov 23 2019, 11:35 AM · Frameworks, KF6
mwolff created T12134: QuickViewSharedEngine.
Nov 23 2019, 11:34 AM · Frameworks, KF6
mwolff created T12133: ManagedTextureNode.
Nov 23 2019, 11:34 AM · Frameworks, KF6
mwolff created T12132: ImageTexturesCache.
Nov 23 2019, 11:34 AM · Frameworks, KF6
mwolff created T12131: ConfigPropertyMap.
Nov 23 2019, 11:33 AM · Frameworks, KF6
mwolff created T12130: KDeclarative API Review.
Nov 23 2019, 11:33 AM · Frameworks, KF6
mwolff created T12128: port away from Qt Quick Control 1.
Nov 23 2019, 11:32 AM · Frameworks, KF6
mwolff created T12127: move ConfigModule next to KCModule widget counter part.
Nov 23 2019, 11:31 AM · Frameworks, KF6
mwolff created T12126: move ConfigPropertyMap to KConfig bindings.
Nov 23 2019, 11:31 AM · Frameworks, KF6
mwolff created T12125: Move KeySequenceItem to KGlobalAccel.
Nov 23 2019, 11:30 AM · Frameworks, KF6
mwolff created T12124: KDeclarative: Remove KIconProvider image provider.
Nov 23 2019, 11:27 AM · Frameworks, KF6
mwolff created T12123: move KWindowSystem bindings.
Nov 23 2019, 11:26 AM · Frameworks, KF6
mwolff created T12122: KWidgetsAddons.
Nov 23 2019, 11:26 AM · Frameworks, KF6
mwolff created T12121: Move K18N bindings to K18N.
Nov 23 2019, 11:24 AM · Frameworks, KF6
mwolff created T12120: NetworkAccessManager.
Nov 23 2019, 11:23 AM · Frameworks, KF6
mwolff created T12119: KRunProxy [KIO].
Nov 23 2019, 11:23 AM · Frameworks, KF6

Nov 22 2019

mwolff added a comment to T11982: KF6 and STL compatibility.

KRandom::random should be removed and QRandomGenerator should be used instead. It has a more expressive API and will actually work properly on platforms without a /dev/urandom.

Nov 22 2019, 9:18 AM · KF6

Nov 16 2019

mwolff committed R45:fabfdf9cca39: Remove unused include dir (authored by Volodymyr Nikolaichuk <nikolaychuk.volodymyr@gmail.com>).
Remove unused include dir
Nov 16 2019, 10:56 PM
mwolff committed R45:1e15381f426e: Fix building heaptrack_inject (authored by Volodymyr Nikolaichuk <nikolaychuk.volodymyr@gmail.com>).
Fix building heaptrack_inject
Nov 16 2019, 10:56 PM
mwolff committed R45:e65e358cfd45: Add heaptrack_{pause,resume}() API (authored by Volodymyr Nikolaichuk <nikolaychuk.volodymyr@gmail.com>).
Add heaptrack_{pause,resume}() API
Nov 16 2019, 10:56 PM
mwolff committed R45:db6403f542c0: More build options HEAPTRACK_BUILD_INTERPRET, HEAPTRACK_BUILD_BACKTRACE (authored by Volodymyr Nikolaichuk <nikolaychuk.volodymyr@gmail.com>).
More build options HEAPTRACK_BUILD_INTERPRET, HEAPTRACK_BUILD_BACKTRACE
Nov 16 2019, 10:56 PM
mwolff committed R45:ae54d99af368: Check for valloc in stdlib.h (authored by Volodymyr Nikolaichuk <nikolaychuk.volodymyr@gmail.com>).
Check for valloc in stdlib.h
Nov 16 2019, 10:56 PM
mwolff committed R45:8023779f9a3b: Optionally use unwind_tables instead of libunwind (authored by Volodymyr Nikolaichuk <nikolaychuk.volodymyr@gmail.com>).
Optionally use unwind_tables instead of libunwind
Nov 16 2019, 10:56 PM
mwolff committed R45:8cfa8f557fb5: Remove unused reference from libbacktrace to libunwind (authored by Volodymyr Nikolaichuk <nikolaychuk.volodymyr@gmail.com>).
Remove unused reference from libbacktrace to libunwind
Nov 16 2019, 10:56 PM

Oct 15 2019

mwolff committed R45:2d14f5de75b9: Allow high priv user to profile low priv user process (authored by Sam Saffron <sam.saffron@gmail.com>).
Allow high priv user to profile low priv user process
Oct 15 2019, 9:07 PM
mwolff committed R45:715edab31dde: Add icons (authored by mwolff).
Add icons
Oct 15 2019, 9:27 AM

Oct 13 2019

mwolff added a comment to D24532: Declare new hash function in namespace std in order to fix build..

pushed now, thanks a lot

Oct 13 2019, 7:28 PM
mwolff closed D24532: Declare new hash function in namespace std in order to fix build..
Oct 13 2019, 7:27 PM
mwolff committed R45:983cc35dd000: Declare new hash function in namespace std in order to fix build. (authored by beischer).
Declare new hash function in namespace std in order to fix build.
Oct 13 2019, 7:27 PM
mwolff added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.
In D24568#545736, @apol wrote:

I'm not sure how this works, but would it be possible to have a target that only works on a patch? You usually want to make sure what you modified didn't diverge from the code.

I think there is some hack around that:
http://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting

But actually, if your sources are already clang-formatted, you just need to run the clang-format target once before you commit, the your new code will be the only thing altered.

Oct 13 2019, 7:24 PM · Build System, Frameworks

Oct 12 2019

mwolff accepted D24532: Declare new hash function in namespace std in order to fix build..

thanks, do you have commit rights to KDE?

Oct 12 2019, 12:30 PM

Oct 8 2019

mwolff accepted D24491: Fix build against Qt without std::hash<QString> specialization.

thanks

Oct 8 2019, 6:42 PM
mwolff committed R44:81ed5eb65459: Find boost when libkolabxml was found (authored by mwolff).
Find boost when libkolabxml was found
Oct 8 2019, 6:30 AM

Oct 7 2019

mwolff added a comment to D22158: Navigation context uses theme color..

e.g. look at https://doc.qt.io/archives/qt-4.8/qcolor.html#predefined-colors

Oct 7 2019, 8:14 PM · KDevelop
mwolff added a comment to D22158: Navigation context uses theme color..

hey! can you also show a screenshot of PHP or Qt documentation showing? these can contain arbitrary HTML and sometimes even contain colored text that expects to be shown on bright backgrounds which would break with this patch. At least that was the case years ago when I worked on this the last time.

Oct 7 2019, 8:14 PM · KDevelop

Oct 3 2019

mwolff accepted D24396: Add more tests for Parser: bottom-up and top-down data.
Oct 3 2019, 7:03 PM

Oct 2 2019

mwolff accepted D24099: Add an ID to Symbol in order to make hashing faster.
Oct 2 2019, 3:15 PM

Sep 24 2019

mwolff requested changes to D24106: Use unordered_map so it scales better.

squash please

Sep 24 2019, 9:17 AM
mwolff requested changes to D24099: Add an ID to Symbol in order to make hashing faster.

please squash with the hash map commit

Sep 24 2019, 9:17 AM
mwolff accepted D24104: Replace std::tie with == in operator==().

sad but OK :(

Sep 24 2019, 9:06 AM

Sep 21 2019

mwolff committed R32:dd2c99254a3b: Merge branch '5.4' (authored by mwolff).
Merge branch '5.4'
Sep 21 2019, 2:40 PM
mwolff committed R32:4676a7bb3e4b: Don't try to run cuda test when cuda isn't installed (authored by mwolff).
Don't try to run cuda test when cuda isn't installed
Sep 21 2019, 2:39 PM