mwolff (Milian Wolff)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 16 2015, 7:53 PM (200 w, 6 d)
Availability
Available

Recent Activity

Tue, Feb 19

mwolff requested changes to D18793: Handle text completion with block selection mode.

we override execution in our own completion models, so this patch will only change the behavior for the builtin word and keyword completion models in ktexteditor I believe

Tue, Feb 19, 12:27 PM · Frameworks, Kate
mwolff committed R32:e2b2fd2c1d22: Don't eat the backspace event when no alt modifier is set (authored by mwolff).
Don't eat the backspace event when no alt modifier is set
Tue, Feb 19, 9:25 AM

Mon, Feb 18

mwolff added a comment to D17599: Confirm closing muliple tabs..

+1 on reverting this, but I think we should put some thought into fixing the issue motivating the desire to do this: the fact that without manually invoking Kate's session-saving features, closing a window with multiple tabs in it results in that tab history being lost. I really think we should consider creating a session by default so tab history is remembered unless the user explicitly opts out of it.

Mon, Feb 18, 9:36 AM · Kate
mwolff committed R265:f6c046e9f8bb: Skip benchmark if no scheme files can be found (authored by mwolff).
Skip benchmark if no scheme files can be found
Mon, Feb 18, 9:32 AM

Fri, Feb 15

mwolff added a comment to D18229: Contextbrowser: Ability to show combined problems and decl tooltip.

Done, keyboard navigation should work now - at least it does according to my testing! Please test this as well and report back if you spot any issues.

Fri, Feb 15, 11:35 PM · KDevelop
mwolff committed R32:d284d5bb5f09: Introduce QuickOpenEmbeddedWidgetCombiner (authored by mwolff).
Introduce QuickOpenEmbeddedWidgetCombiner
Fri, Feb 15, 11:34 PM
mwolff added inline comments to D17599: Confirm closing muliple tabs..
Fri, Feb 15, 10:04 PM · Kate
mwolff committed R32:35277af94498: Add 'back' to QuickOpenEmbeddedWidgetInterface (authored by mwolff).
Add 'back' to QuickOpenEmbeddedWidgetInterface
Fri, Feb 15, 9:59 PM
mwolff committed R32:db9740ef9ae1: Update documentation: the keyboard shortcuts use ALT not SHIFT (authored by mwolff).
Update documentation: the keyboard shortcuts use ALT not SHIFT
Fri, Feb 15, 9:59 PM
mwolff committed R53:9eb8dd8d7ae1: Adapt to KDevelop API changes (authored by mwolff).
Adapt to KDevelop API changes
Fri, Feb 15, 9:49 PM
mwolff committed R58:fcba641561da: Adapt to KDevelop API changes (authored by mwolff).
Adapt to KDevelop API changes
Fri, Feb 15, 9:49 PM
mwolff committed R52:af071c293b75: Adapt to KDevelop API changes (authored by mwolff).
Adapt to KDevelop API changes
Fri, Feb 15, 9:49 PM
mwolff committed R32:d9b4c14c3943: tie DUContext::createNavigationWidget to AbstractNavigationWidget (authored by mwolff).
tie DUContext::createNavigationWidget to AbstractNavigationWidget
Fri, Feb 15, 9:49 PM
mwolff committed R53:820775f33318: adapt to KDevelop API changes (authored by mwolff).
adapt to KDevelop API changes
Fri, Feb 15, 9:39 PM
mwolff committed R39:fa9e585bc557: Remove dead code (authored by mwolff).
Remove dead code
Fri, Feb 15, 9:07 PM
mwolff committed R32:f633da0d9c67: Fix up/down keyboard navigation for 'Show documentation' links (authored by mwolff).
Fix up/down keyboard navigation for 'Show documentation' links
Fri, Feb 15, 8:42 PM
mwolff committed R32:38e910bab25c: Lock duchain in AbstractIncludeNavigationContext::html (authored by mwolff).
Lock duchain in AbstractIncludeNavigationContext::html
Fri, Feb 15, 8:22 PM
mwolff committed R866:f98c2c627f41: adapt to KDevelop API changes (authored by mwolff).
adapt to KDevelop API changes
Fri, Feb 15, 8:15 PM
mwolff committed R58:76b99513855f: adapt to KDevelop API changes (authored by mwolff).
adapt to KDevelop API changes
Fri, Feb 15, 8:15 PM
mwolff committed R52:54970dabebcb: adapt to KDevelop API changes (authored by mwolff).
adapt to KDevelop API changes
Fri, Feb 15, 8:15 PM
mwolff committed R32:12e3583fb0a5: cleanup: remove html prefix/suffix feature from navigation widget (authored by mwolff).
cleanup: remove html prefix/suffix feature from navigation widget
Fri, Feb 15, 8:15 PM
mwolff committed R32:518e78712057: Remove dead code: AbstractNavigationContext::fontSize{Prefix,Suffix} (authored by mwolff).
Remove dead code: AbstractNavigationContext::fontSize{Prefix,Suffix}
Fri, Feb 15, 8:15 PM
mwolff added a comment to D18229: Contextbrowser: Ability to show combined problems and decl tooltip.

I'm looking into the keyboard navigation now

Fri, Feb 15, 7:39 PM · KDevelop
mwolff committed R32:333455ce8a8b: Reinstantiate c3c30113b "fix memleaks in duchain unittests" (authored by mwolff).
Reinstantiate c3c30113b "fix memleaks in duchain unittests"
Fri, Feb 15, 6:50 PM
mwolff committed R32:ba7f235b938a: Reinstantiate code from 3c51faa2 (authored by mwolff).
Reinstantiate code from 3c51faa2
Fri, Feb 15, 6:29 PM
mwolff added a comment to D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.

Regarding waiting for the background parser on TestFile destruction, I didn't find a way to query whether a parse job is running or to wait for it, if it was started externally, using existing code (but I'm also not familiar with the codebase). As an alternative, one can do Q_ASSERT(ICore::self()->languageController()->backgroundParser()->isIdle()); in the test cleanup function to ensure that the tests don't leave the background parser running. This might also be a good idea to ensure that the tests don't influence each other in that way.

Fri, Feb 15, 12:14 PM · KDevelop
mwolff added a comment to D18229: Contextbrowser: Ability to show combined problems and decl tooltip.

Yeah, the keyboard navigation needs some work anyways - it's buggy even without combined tooltips :) Something for the future to work on!

Fri, Feb 15, 9:54 AM · KDevelop
mwolff added a comment to D11934: KDevelop : "Reparse Entire Project" action in the project manager context menu.

auto* action = new QAction(tr("Reparse the Entire Project"), this);

Last minute check: tr instead of i18n, really?

Fri, Feb 15, 9:52 AM · KDevelop
mwolff requested changes to D18857: optimize CMakeBuildDirChooser::buildDirSettings().

using byte arrays is OK imo, but please cleanup the code overall by using a lambda instead of repeating the same thing over and over again

Fri, Feb 15, 9:51 AM · KDevelop
mwolff committed R32:c7b8e7973ab0: Delay handling of KDirWatch signals (authored by mwolff).
Delay handling of KDirWatch signals
Fri, Feb 15, 9:39 AM
mwolff committed R32:8933d89082bb: Cleanup test_projectload.cpp code (authored by mwolff).
Cleanup test_projectload.cpp code
Fri, Feb 15, 9:39 AM
mwolff committed R32:1a740ec21410: Remove obsolete code (authored by mwolff).
Remove obsolete code
Fri, Feb 15, 9:39 AM
mwolff committed R32:7661c47212b6: Simplify: use QTRY_* instead of manual waiting (authored by mwolff).
Simplify: use QTRY_* instead of manual waiting
Fri, Feb 15, 9:39 AM
mwolff committed R32:a0fd2014489c: Don't crash when background listing outlasts file manager list job (authored by mwolff).
Don't crash when background listing outlasts file manager list job
Fri, Feb 15, 9:39 AM
mwolff committed R32:3aed7ac41a67: Don't crash when project is closed before it was fully opened (authored by mwolff).
Don't crash when project is closed before it was fully opened
Fri, Feb 15, 9:39 AM
mwolff added a comment to D18551: clang: Create preamble only on second parse.

Currently we don't reparse (always?) when an included file changes. That's probably way more annoying than the first code completion having some delay.

Fri, Feb 15, 9:38 AM · KDevelop
mwolff added a comment to D18551: clang: Create preamble only on second parse.

When we didn't create the preamble, we will have to reparse the file completely. And this can easily take 1-2s per file, which is *really* annoying.

It only happens on the very first edit though, and will only be noticeable if code completion is required immediately after starting to edit the file. All following parses and code completions can use the precompiled preamble then. I don't think that's too bad. It's also not unusual, many applications have something like a "warmup phase" where not everything is loaded yet.

Fri, Feb 15, 9:35 AM · KDevelop

Mon, Feb 11

mwolff accepted D11934: KDevelop : "Reparse Entire Project" action in the project manager context menu.

could you fixup the two minor nits please? then you can push directly

Mon, Feb 11, 6:12 PM · KDevelop
mwolff committed R45:cff420dad043: Upload correct file to github (authored by mwolff).
Upload correct file to github
Mon, Feb 11, 10:24 AM
mwolff committed R45:38263a2a43b4: Use uploadtool instead of transfer.sh for deployment (authored by mwolff).
Use uploadtool instead of transfer.sh for deployment
Mon, Feb 11, 10:11 AM

Sun, Feb 10

mwolff added inline comments to D11934: KDevelop : "Reparse Entire Project" action in the project manager context menu.
Sun, Feb 10, 9:56 PM · KDevelop
mwolff added a comment to D11136: Make sure we use the same compiler settings as the project is by default.

ping? I think it would still make sense to merge this - Aleix, are you still running this? Should we revive the patch, rebase it and get it in?

Sun, Feb 10, 9:34 PM
mwolff committed R32:02b042a92355: Debugger plugin fixes (authored by igorkushnir).
Debugger plugin fixes
Sun, Feb 10, 9:33 PM
mwolff closed D18325: Debugger plugin fixes.
Sun, Feb 10, 9:33 PM · KDevelop
mwolff committed R32:e86c5a7211db: Clang CodeCompletion: No auto-completion for numbers (authored by thomassc).
Clang CodeCompletion: No auto-completion for numbers
Sun, Feb 10, 9:32 PM
mwolff closed D17915: Clang CodeCompletion: No auto-completion for numbers.
Sun, Feb 10, 9:32 PM · KDevelop
mwolff committed R32:7e4294a87824: kdevelop-msvc.bat finds VS-2017 based on a registry key on Windows. (authored by mwolff).
kdevelop-msvc.bat finds VS-2017 based on a registry key on Windows.
Sun, Feb 10, 9:32 PM
mwolff closed D17908: kdevelop-msvc.bat finds VS-2017 based on a registry key on Windows..
Sun, Feb 10, 9:32 PM · KDevelop
mwolff committed R866:ae31b102a31f: Fix override function signature of createCompletionContext() (authored by mwolff).
Fix override function signature of createCompletionContext()
Sun, Feb 10, 9:31 PM
mwolff closed D17618: Fix override function signature of createCompletionContext().
Sun, Feb 10, 9:31 PM · KDevelop
mwolff added a comment to D18551: clang: Create preamble only on second parse.

I'm fine with that, but would prefer never having it. Not all files that are opened will be edited, and the delay caused by creating the preamble after the first edit is probably negligible over the lifetime of a session. It would also allow us to just drop affected preambles when a header is edited — otherwise we might have to recreate all preambles that include the header.

Sun, Feb 10, 9:18 PM · KDevelop
mwolff added a comment to D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.

ping?

Sun, Feb 10, 8:51 PM · KDevelop
mwolff added a comment to D18224: Clang Plugin: Report some problems from included files.

ping? I'd really like to see this getting integrated, could you please fix the small issues pointed out by pino and me and resubmit?

Sun, Feb 10, 8:50 PM · KDevelop
mwolff added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

The problem with nested event loops are that they introduce execution flows that are very hard to reason about and can easily cause issues like the one you see here. Quite often, you can run into issues where an object spawns a nested eventloop, which then somehow handles a deleteLater event for the object itself, thereby destroying the object. When the nested eventloop exits, this was destroyed and anything can happen. I believe something like that happens here too.

Sun, Feb 10, 7:46 PM · KDevelop
mwolff added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

the proper way would be to have Project::open return void, and instead report failure via a new 'failedToOpen' signal. And then internally handle the async code without a nested event loop. We'll probably need this in more places, and I wonder what the current best-practice is for that. Eventually async/await can be used, but we want to have something that works with the compilers we support today. Hm. I'd like to prevent us from trying to handle async code in an adhoc fashion. Rather, we should try to adopt a proper framework like e.g. KAsync? QtPromise? Something similar?

Sun, Feb 10, 7:40 PM · KDevelop
mwolff requested changes to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

I'm afraid to say that this is just a workaround, not a proper fix... I ran into this issue recently too - the real problem - imo - is that we synchronously execute the stat jobs in KDevelop::ProjectPrivate::initProjectFiles... if you look at the ASAN report you'll see that TestCore::shutdown isn't referenced there at all!

Sun, Feb 10, 7:04 PM · KDevelop

Fri, Feb 8

mwolff committed R265:c0cc6b8a200a: Cache the default KColorScheme configuration (authored by mwolff).
Cache the default KColorScheme configuration
Fri, Feb 8, 7:27 PM
mwolff closed D18612: Cache the default KColorScheme configuration.
Fri, Feb 8, 7:27 PM · Frameworks
mwolff added a comment to D18612: Cache the default KColorScheme configuration.

pushed this now with a proper benchmark too, shows a ~10x performance win when a non-empty PATH is set

Fri, Feb 8, 6:53 PM · Frameworks

Tue, Feb 5

mwolff requested changes to D11934: KDevelop : "Reparse Entire Project" action in the project manager context menu.
Tue, Feb 5, 7:35 AM · KDevelop
mwolff requested changes to D15530: kdev-clang : somewhat more complete ObjC(++) support.
Tue, Feb 5, 7:32 AM · KDevelop
mwolff accepted D18463: Workaround the bug found by ASan, which can be seen on FreeBSD CI..

please still attach the full ASAN report to your commit - i.e. put it into your commit message

Tue, Feb 5, 7:31 AM · KDevelop
mwolff accepted D18163: Set the color scheme to Printing for Print Preview.

yes, thanks!

Tue, Feb 5, 7:30 AM · Frameworks, Kate
mwolff added a comment to D17932: Improvements to completion.

I'm in favor!

Tue, Feb 5, 7:30 AM · Frameworks, KTextEditor, Kate
mwolff added a comment to D18612: Cache the default KColorScheme configuration.

sure, but first let's get this in. @broulik or @dfaure care to give your +1?

Tue, Feb 5, 7:29 AM · Frameworks

Fri, Feb 1

mwolff added a comment to D14469: KDevelop: word wrapping the problem text in the Problem Reporter (WIP).

But for some reason I'm not getting any tooltips in that reporter at all at the moment.

Fri, Feb 1, 4:49 PM · KDevelop
mwolff committed R32:06b526e81f9f: Properly cleanup FileManagerListJob when folder items are deleted (authored by mwolff).
Properly cleanup FileManagerListJob when folder items are deleted
Fri, Feb 1, 1:46 PM
mwolff added a comment to D18551: clang: Create preamble only on second parse.

again: why don't we keep this flag when the file is opened in the editor?

Fri, Feb 1, 12:41 PM · KDevelop
mwolff requested changes to D18463: Workaround the bug found by ASan, which can be seen on FreeBSD CI..

please show the full ASAN report, but the second change looks fine to me - if we get an event during destruction of the tool view action, m_dock may be gone already and thus accessing it may be broken already

Fri, Feb 1, 12:32 PM · KDevelop
mwolff added a comment to D14469: KDevelop: word wrapping the problem text in the Problem Reporter (WIP).

tooltips don't take keyboard focus, so I don't understand your first note. also the tooltip only shows up (in the editor) while you keep ALT pressed.

Fri, Feb 1, 12:30 PM · KDevelop

Wed, Jan 30

mwolff requested changes to D18163: Set the color scheme to Printing for Print Preview.
Wed, Jan 30, 8:23 PM · Frameworks, Kate
mwolff added a comment to D18612: Cache the default KColorScheme configuration.

I see that it's faster when I profile kate/kdev, but I cannot easily write a benchmark for this. It's only noticeable when the KDE_COLOR_SCHEME_PATH variable is set, otherwise the global application config will be used afte rall, which is going to be shared most probably. Any idea how I could construct a valid KDE_COLOR_SCHEME_PATH path to e.g. the breeze color scheme from within a kcolor scheme auto test?

Wed, Jan 30, 8:52 AM · Frameworks
mwolff requested review of D18612: Cache the default KColorScheme configuration.
Wed, Jan 30, 8:44 AM · Frameworks

Tue, Jan 29

mwolff accepted D17908: kdevelop-msvc.bat finds VS-2017 based on a registry key on Windows..

you can pick whatever you prefer for the reviews for now.

Tue, Jan 29, 9:44 AM · KDevelop

Mon, Jan 28

mwolff requested changes to D17760: astyle: support the system astyle library.

do we have custom patches in our libastyle? I hope not, but it's been too long for me to remember. If not, then I guess we should get rid of our copy of lbiastyle and just disable kdevastyle if that dependency wasn't found - it's pretty optional anyways.

Mon, Jan 28, 10:36 AM · KDevelop
mwolff added a comment to D18346: Fix typo in move cursor left action in QtCreator shortcuts theme.

yes, push to 5.3 and we'll merge it to master

Mon, Jan 28, 10:21 AM · KDevelop
mwolff added a comment to D5447: Only add auto-detected compilers to model if they actually exist.

the path of the compiler is now always the path of the compiler in the local host, which breaks when you have a runtime with a different setup.

Hum. Before being passed to rt->pathInHost(), the compiler path gets wrapped into KDevelop::Path. Doesn't this make it absolute/invalid? Judging from Path::Path(QString) constructor, it should't even accept things like "gcc".

And what are we checking there? I still don't make any sense from this check.

Mon, Jan 28, 10:19 AM
mwolff accepted D17618: Fix override function signature of createCompletionContext().

lgtm now, sorry for the delay - can you push that yourself? if not, please tell us your email address and name to associate with the commit

Mon, Jan 28, 10:10 AM · KDevelop
mwolff requested changes to D18551: clang: Create preamble only on second parse.

it was measured back then:

Mon, Jan 28, 10:07 AM · KDevelop

Sun, Jan 27

mwolff committed R32:4c96d1bd8209: Fix compiler warning about comparison of different signedness (authored by mwolff).
Fix compiler warning about comparison of different signedness
Sun, Jan 27, 9:19 PM
mwolff committed R32:a6426189fe64: Remove unused variable (authored by mwolff).
Remove unused variable
Sun, Jan 27, 9:19 PM
mwolff committed R32:c8f711693ff5: Reorder members of ProjectBaseItemPrivate to decrease size (authored by mwolff).
Reorder members of ProjectBaseItemPrivate to decrease size
Sun, Jan 27, 9:19 PM
mwolff committed R32:752f184c1333: Move ProjectFileItem::indexedPath to ProjectBaseItem (authored by mwolff).
Move ProjectFileItem::indexedPath to ProjectBaseItem
Sun, Jan 27, 9:19 PM
mwolff requested changes to D17289: KDevelop/Shell: set dedicated TMPDIR.

we use CXTranslationUnit_CreatePreambleOnFirstParse to get code completion results fast. otherwise the first code completion request would create the preamble, which felt much worse

Sun, Jan 27, 9:14 PM · KDevelop
mwolff requested changes to D15530: kdev-clang : somewhat more complete ObjC(++) support.

please paste compiler errors instead of showing screenshots

Sun, Jan 27, 7:52 PM · KDevelop
mwolff requested changes to D14633: Fix drag'n'drop behaviour in ProjectTreeView plugin.
Sun, Jan 27, 7:31 PM · KDevelop
mwolff added a comment to D14633: Fix drag'n'drop behaviour in ProjectTreeView plugin.

sorry for the long delay. personally, I like what I'm seeing in the video, could you cleanup the patch a little please? and does ensureVisible help maybe?

Sun, Jan 27, 7:31 PM · KDevelop
mwolff resigned from D17137: KTextEditor: File menu: Put Save, Print and Export in submenus.
Sun, Jan 27, 7:25 PM · Frameworks, Kate
mwolff requested changes to D17908: kdevelop-msvc.bat finds VS-2017 based on a registry key on Windows..

sorry for the long delay, it sounds like a good idea but the diff is super hard to review since it contains lots of unrelated whitespace changes

Sun, Jan 27, 7:23 PM · KDevelop
mwolff requested changes to D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.

great initiative, but could you check if this could be done in a more generic way potentially? if not then I'm all for getting this in as-is otherwise

Sun, Jan 27, 7:21 PM · KDevelop
mwolff requested changes to D11934: KDevelop : "Reparse Entire Project" action in the project manager context menu.
Sun, Jan 27, 7:16 PM · KDevelop

Sat, Jan 26

mwolff accepted D15797: [kdev-clazy] : use canonical paths.

lgtm now, note that you now need to push to the new gitlab remote at git@invent.kde.org:kde/kdevelop.git

Sat, Jan 26, 11:14 PM · KDevelop
mwolff accepted D18325: Debugger plugin fixes.

lgtm, thanks. note that you now need to push to the new gitlab remote (git@invent.kde.org:kde/kdevelop.git) cf. https://invent.kde.org/kde/kdevelop for future reviews

Sat, Jan 26, 11:12 PM · KDevelop
mwolff accepted D18122: Fix Xdebug disconnecting after php finished if multiple connections are allowed.

since noone else is using this plugin, I'd say let's push this! @wcancino do you have a developer account? if not, then we can commit this for you. Please then give us your email address to associate with the commit then.

Sat, Jan 26, 11:09 PM · KDevelop
mwolff added a comment to D18218: Properly display argument names of template functions.

@thomassc: A separate context could help, yes. But if you find alternative ways to handle it, like proposed here, then not using a separate context could potentially work out too. But it feels a bit hackish to handle the template args specially everywhere instead of putting them into a proper context.

Sat, Jan 26, 11:01 PM · KDevelop
mwolff abandoned D15899: Fix segfault on project reload with cmake.
Sat, Jan 26, 10:29 PM · KDevelop
mwolff commandeered D15899: Fix segfault on project reload with cmake.

finally got it working, man that old code was broken :D I wrote most of that a really long time ago, and it shows!

Sat, Jan 26, 10:28 PM · KDevelop
mwolff committed R52:8c3648a4a8ee: Fix linking with ld.lld (authored by mwolff).
Fix linking with ld.lld
Sat, Jan 26, 7:55 PM
mwolff added a comment to D15899: Fix segfault on project reload with cmake.

sadly my initial attempt doesn't work either ;-) I'm looking at this some more now and will let you know once I've found an alternative approach

Sat, Jan 26, 7:21 PM · KDevelop
mwolff added inline comments to D18224: Clang Plugin: Report some problems from included files.
Sat, Jan 26, 1:29 PM · KDevelop