- User Since
- Apr 16 2015, 7:53 PM (101 w, 1 d)
Thu, Mar 23
We are explicitly excluding the standard includes for C and C++, so maybe something like that accidentally happens for cuda, too? Cf. nostdinc.
Yes, please reserve it.
Wed, Mar 22
remove the moc, then feel free to push
Mon, Mar 20
Sun, Mar 19
I'm personally all for improving the status quo, but I think the biggest problem here is that we have no unit test coverage (or do we?). The unit tests would also clearly show the advantage of this new beheavior compared to the old one. So: Could you add unit tests?
@dfaure Is there a way to give actions in the "configure shortcuts" action a different name from what is shown by menus?
lgtm, but please ensure that you squash your commits before pushing this
QtWebKit is actually more alive nowadays than in a long time, so I still think the best way forward would be to wrap it in a thin KF5-material wrapper and use that here
Can you please add more information? I also use "^C" to interrupt tracking and that used to work just fine for me. What is going wrong? Why is your trap line required? Add all of this information to the commit message
sorry for the delay Alexander
some minor nitpicks. imo feel free to commit after fixing those
do you have commit rights? otherwise someone from us can commit this for you
we need to wait for the other change to get in first of course
Thu, Mar 16
QTextDocument won't be enough for our purposes. We actually embed e.g. the remote PHP documentation here. And even simple HTML features are not supported by QTextDocument.
Sat, Mar 11
OK, but that's still not very user-friendly as
Thu, Mar 9
See also: https://phabricator.kde.org/T5381
How did you create that? How would I create a new one? How is this accessible to new users, i.e. not me?
I know Phab is not Gerrit. But Gerrit is an excellent review tool, so what is wrong in making use of the good features in it? It's super ignorant to say "I'm after a Gerrit centric workflow". I'm after a _good_ review workflow. Gerrit just happens to be one.
+100 to what dfaure said, totally in sync to my view of the upstream people
works for me: https://phabricator.kde.org/tag/kdevelop/
Yes, I want to show a bucketed view for the overall project.
See https://phabricator.kde.org/D4665 <-- so probably this is again an issue when people are not using arcanist. We must get a way to add that info for these people, too. But that will only be done once we get the proper git integration, right? Is there any ETA on it? Or will it be "sometime" and we will have to make do with the broken workflow?
Mon, Mar 6
Sun, Mar 5
now that this API becomes public, it must be improved to make it better understandable to the public
lgtm in principle, but I find it odd that to is lower-cased, but With is uppercased
yep, lgtm - thanks!
lgtm, esp. since a test is added
lgtm in principle, but there are two checks that imo need to be removed to cleanup the code. it's not a good idea to be overly pedantic in code, rather use assertions like we do elsewhere
As-is, this is not a good approach imo. Either have it as generic API in iproblem.h (which would mean you'd also need to serialize the data in problem.cpp), or have it as a special case for the detected problem and only use it there
Sun, Feb 26
Thu, Feb 23
Feb 23 2017
Feb 22 2017
Feb 21 2017
use override, track view changes
Tons of new files and not a single test? Can you add some?
The existing branch field is not useful. It shows the branch the submitter has been using, which will usually be a work branch. What we need is the *target* branch.
Ah, since you used arc, it does preserve it. Otherwise not: https://phabricator.kde.org/T5242
assuming you don't have commit rights, what is your email address so I can use that to attribute this patch back to you?
Feb 20 2017
some nitpicks from my side, otherwise this looks good to me
See e.g.: https://phabricator.kde.org/D3040 <-- I want to comment on the commit message, just like I can comment on the actual code changes. This is not possible.
Using some URL shortening could work, but sounds like a lot of work as then we either have short URLs only for the few projects you mention, and need to remember which they are, or we have one central URL place for all of them. So, if at all possible, can we resurrect the URLs of projects.kde.org/$... and point them to either the custom phabricator URL for a project, or the default project url source/....
I don't know - it makes a lot of sense to me but I don't know what others say to that. I plan to write a blog post about using phabricator soon, where I'll raise such points.
yes, but often the points are spread across multiple comments so "reply" is not enough.
Note that for simple snippets, using the snippets plugin would be better, not the full-blown template engine.
Feb 18 2017
@atomsymbol: Do you have commit rights? If not, what is your email address that I can use for the git commit?