- User Since
- Apr 16 2015, 7:53 PM (127 w, 2 d)
Fri, Sep 22
depend on new KMime
Done, I presume you'll merge that into master?
do I need to change anything in the CMakeLists.txt to ensure the up2date kmime is found? or are these repos all implicitly depending on each other anyways?
And btw: I'm in favor of the concept, i.e. to use canonical paths everywhere. I've run into issues myself, but I wonder why I'm not seeing the issue you are referencing here. My paths are also containing symlinks. It sounds to me like you are solving a fringe case (i.e. changing paths after the fact). I'm all for handling this gracefully, but to ensure it won't break in the future, we will need a unit test. That will also show us what actually is broken.
please write a unit test
Thu, Sep 21
what branch is "stable"? 1.9?
ah ok, and since we don't have a proper byte array view yet, there's nothing you can do (which is sad here!)
Wed, Sep 20
+1 if this improves the situation, but in general I was suspecting such issues while reviewing the initial changeset. I suspect we'll see more issues in the future, and I have no clear idea on how to handle that :(
Tue, Sep 19
I think the grouping should be moved upstream into the model, too and then be used for file open dialogs to make that visually more similar to what dolphin shows.
it would probably be a good idea to rewrite KConfigGroupPrivate::serializeList to not take a QVariantList, but rather to use a streaming API. I.e. instead of:
Mon, Sep 18
The difference you describe between cmake server mode vs. no server mode once again shows that you have not yet fully grasped what's going on here and that this patch as it stands is not the right fix. Find out why the cmake server mode degrades the performance, than fix that. You say:
Thu, Sep 14
thanks, lgtm - do you have commit rights?
Wed, Sep 13
ok, let's try this out :) What Could Possibly Go Wrong?
could we get a unit test? but otherwise lgtm, minus the one issue I found (sorry :P)
overall lgtm, I'd also like to see some unit test coverage please
Tue, Sep 12
Tue, Sep 5
Fri, Sep 1
sorry for the long delay, has this not been merged yet? I'll try to do this now
Thu, Aug 31
abandoning since https://phabricator.kde.org/D7621 got landed
taking over to close
thanks, I'll fix this up and merge this
Tue, Aug 29
Sun, Aug 27
Please also add a link to https://bugs.kde.org/show_bug.cgi?id=383889
lgtm, despite the delete this: https://isocpp.org/wiki/faq/freestore-mgmt#delete-this, esp. if you have proper unit tests and ran it through valgrind
Aug 24 2017
Note that the test passes, but I noticed that the KURLCOMPLETION_LOCAL_KIO branch is not covered by unit tests. Setting it even shows that the test is then broken (even without this patch).
Aug 8 2017
you need to wait for the job to finish, before running the other job. so just adding the document is not enough. I also don't understand why this is directly related to D7128? The change you are doing here is within a running parse job already, so D7128 on its own should be fine?