mwolff (Milian Wolff)
User

Projects

User Details

User Since
Apr 16 2015, 7:53 PM (101 w, 1 d)

Recent Activity

Thu, Mar 23

mwolff added a comment to T5733: Better CUDA Support.

We are explicitly excluding the standard includes for C and C++, so maybe something like that accidentally happens for cuda, too? Cf. nostdinc.

Thu, Mar 23, 2:16 PM · KDevelop
mwolff added a comment to D5102: Add scroll-barmarks also to the built-in search&replace.

Yes, please reserve it.

Thu, Mar 23, 2:11 PM · Frameworks

Wed, Mar 22

mwolff committed R32:903e54347f7b: Workaround cmake server bug that gets confused on symlinks (authored by mwolff).
Workaround cmake server bug that gets confused on symlinks
Wed, Mar 22, 2:50 PM
mwolff committed R32:e1500e1f382e: Use canonical paths for file-specific information from cmake server (authored by mwolff).
Use canonical paths for file-specific information from cmake server
Wed, Mar 22, 2:50 PM
mwolff requested changes to D4772: projectmanagerview: Make cut-paste work by fixing project manager's Paste action.
Wed, Mar 22, 8:59 AM
mwolff accepted D3040: Allow scaling documentation view (BUG 285162).

remove the moc, then feel free to push

Wed, Mar 22, 8:59 AM

Mon, Mar 20

mwolff committed R32:e40751cda601: Resolve {MOC,OBJECTS,UI}_DIR relative to build directory (authored by mwolff).
Resolve {MOC,OBJECTS,UI}_DIR relative to build directory
Mon, Mar 20, 10:30 PM
mwolff committed R32:665385366748: Add all .pro files to qmake project root file item. (authored by mwolff).
Add all .pro files to qmake project root file item.
Mon, Mar 20, 10:30 PM
mwolff committed R170:06286490b2e2: Fix build: use MailTransportAkonadi to find messagequeuejob.h (authored by mwolff).
Fix build: use MailTransportAkonadi to find messagequeuejob.h
Mon, Mar 20, 10:44 AM
mwolff requested changes to D5041: Port away from QtWebKit to QtWebEngine.
Mon, Mar 20, 9:12 AM
mwolff added inline comments to D4772: projectmanagerview: Make cut-paste work by fixing project manager's Paste action.
Mon, Mar 20, 9:09 AM

Sun, Mar 19

mwolff committed R32:73d051aa33de: Fix CMake::readCacheValues to actually read values from the cache (authored by mwolff).
Fix CMake::readCacheValues to actually read values from the cache
Sun, Mar 19, 2:38 PM
mwolff accepted D5043: Split ContextMenuExtension::AnalyzeGroup to File/Project groups.
Sun, Mar 19, 1:26 PM
mwolff requested changes to D4234: Change algorithm for autobrace..

I'm personally all for improving the status quo, but I think the biggest problem here is that we have no unit test coverage (or do we?). The unit tests would also clearly show the advantage of this new beheavior compared to the old one. So: Could you add unit tests?

Sun, Mar 19, 1:25 PM · Frameworks
mwolff requested changes to D5044: Move "Analyze" menu items into "Code" menu.

@dfaure Is there a way to give actions in the "configure shortcuts" action a different name from what is shown by menus?

Sun, Mar 19, 1:24 PM
mwolff accepted D3041: Enable zoom feature in built-in documentation widgets.

lgtm, but please ensure that you squash your commits before pushing this

Sun, Mar 19, 1:22 PM
mwolff requested changes to D5041: Port away from QtWebKit to QtWebEngine.

QtWebKit is actually more alive nowadays than in a long time, so I still think the best way forward would be to wrap it in a thin KF5-material wrapper and use that here

Sun, Mar 19, 1:19 PM
mwolff requested changes to D4953: Fix cleanup when tracking is interrupted by user.

Can you please add more information? I also use "^C" to interrupt tracking and that used to work just fine for me. What is going wrong? Why is your trap line required? Add all of this information to the commit message

Sun, Mar 19, 1:18 PM
mwolff requested changes to D4772: projectmanagerview: Make cut-paste work by fixing project manager's Paste action.

sorry for the delay Alexander

Sun, Mar 19, 1:15 PM
mwolff requested changes to D3040: Allow scaling documentation view (BUG 285162).

some minor nitpicks. imo feel free to commit after fixing those

Sun, Mar 19, 1:04 PM
mwolff accepted D4995: Fix DB inconsistency due to some docterms appearing with uppercase symbols.

do you have commit rights? otherwise someone from us can commit this for you

Sun, Mar 19, 12:59 PM · Frameworks
mwolff accepted D4816: Fix bug 375557 "No indication of cppcheck being run in background".

we need to wait for the other change to get in first of course

Sun, Mar 19, 12:58 PM
mwolff requested changes to D4884: Add ProblemModel::setPlaceHolderText() method.
Sun, Mar 19, 12:56 PM

Thu, Mar 16

mwolff added a comment to D5042: Port away from QtWebKit into QtWebEngine.

QTextDocument won't be enough for our purposes. We actually embed e.g. the remote PHP documentation here. And even simple HTML features are not supported by QTextDocument.

Thu, Mar 16, 12:46 PM

Sat, Mar 11

mwolff added a comment to T5396: "create another" for task reports.

OK, but that's still not very user-friendly as

Sat, Mar 11, 8:01 PM · Phabricator

Thu, Mar 9

mwolff added a comment to T5427: allow to review commit messages.

See also: https://phabricator.kde.org/T5381

Thu, Mar 9, 10:32 AM · Phabricator
mwolff added a comment to T5396: "create another" for task reports.

How did you create that? How would I create a new one? How is this accessible to new users, i.e. not me?

Thu, Mar 9, 10:32 AM · Phabricator
mwolff added a comment to T5427: allow to review commit messages.

I know Phab is not Gerrit. But Gerrit is an excellent review tool, so what is wrong in making use of the good features in it? It's super ignorant to say "I'm after a Gerrit centric workflow". I'm after a _good_ review workflow. Gerrit just happens to be one.

Thu, Mar 9, 10:31 AM · Phabricator
mwolff added a comment to T5437: arcanist: option to ignore untracked files.

+100 to what dfaure said, totally in sync to my view of the upstream people

Thu, Mar 9, 10:28 AM · Phabricator
mwolff closed T5401: replacement for projects.kde.org as "Resolved".

works for me: https://phabricator.kde.org/tag/kdevelop/

Thu, Mar 9, 10:27 AM · Phabricator
mwolff added a comment to T5407: grouped queries cannot be viewed by anonymous users.

Yes, I want to show a bucketed view for the overall project.

Thu, Mar 9, 10:24 AM · Phabricator
mwolff added a comment to T5079: Differential: provide Bug and Branch fields.

See https://phabricator.kde.org/D4665 <-- so probably this is again an issue when people are not using arcanist. We must get a way to add that info for these people, too. But that will only be done once we get the proper git integration, right? Is there any ETA on it? Or will it be "sometime" and we will have to make do with the broken workflow?

Thu, Mar 9, 10:22 AM · Phabricator

Mon, Mar 6

mwolff added a comment to D4947: [KTextEditor] Expose additional internal View's functionality to the public API.

Milian had in mind that you can take charge of Kompare and implement your ideas rather than release new app. :)

Mon, Mar 6, 1:47 PM · Frameworks

Sun, Mar 5

mwolff committed R45:4d82c36360fb: Merge branch '1.0' (authored by mwolff).
Merge branch '1.0'
Sun, Mar 5, 11:42 PM
mwolff committed R45:0e0d481c7177: Update README.md (authored by muo jp <muo@muo.jp>).
Update README.md
Sun, Mar 5, 11:41 PM
mwolff requested changes to D4947: [KTextEditor] Expose additional internal View's functionality to the public API.

now that this API becomes public, it must be improved to make it better understandable to the public

Sun, Mar 5, 10:24 PM · Frameworks
mwolff added a comment to D4914: Reorganize "Run" menu.

lgtm in principle, but I find it odd that to is lower-cased, but With is uppercased

Sun, Mar 5, 10:07 PM
mwolff requested changes to D4772: projectmanagerview: Make cut-paste work by fixing project manager's Paste action.
Sun, Mar 5, 10:05 PM
mwolff accepted D4912: Add KDevelop::IRunController::showConfigurationDialog() method.

lgtm

Sun, Mar 5, 9:55 PM
mwolff committed R45:be0887531856: Only decrease leaked allocations counter for known allocations (authored by mwolff).
Only decrease leaked allocations counter for known allocations
Sun, Mar 5, 9:54 PM
mwolff accepted D4888: Fix "Uninitialized struct member" cppcheck error.

yep, lgtm - thanks!

Sun, Mar 5, 9:51 PM
mwolff accepted D4902: Support of Class::{expr}() syntax from Php 5.4.

lgtm, esp. since a test is added

Sun, Mar 5, 9:50 PM · KDevelop
mwolff committed R45:932defacaa60: Improve cleanup after detaching heaptrack (authored by mwolff).
Improve cleanup after detaching heaptrack
Sun, Mar 5, 9:48 PM
mwolff requested changes to D4910: Initial version of Heaptrack analyzer plugin.

cool :)

Sun, Mar 5, 8:02 PM
mwolff requested changes to D4816: Fix bug 375557 "No indication of cppcheck being run in background".
Sun, Mar 5, 7:42 PM
mwolff requested changes to D3040: Allow scaling documentation view (BUG 285162).

lgtm in principle, but there are two checks that imo need to be removed to cleanup the code. it's not a good idea to be overly pedantic in code, rather use assertions like we do elsewhere

Sun, Mar 5, 7:39 PM
mwolff requested changes to D4884: Add ProblemModel::setPlaceHolderText() method.
Sun, Mar 5, 7:34 PM
mwolff requested changes to D4883: Add new constructor for KDevelop::DetectedProblem class.

As-is, this is not a good approach imo. Either have it as generic API in iproblem.h (which would mean you'd also need to serialize the data in problem.cpp), or have it as a special case for the detected problem and only use it there

Sun, Mar 5, 7:32 PM
mwolff accepted D4930: Add basic support for parsing OpenCL.

nice!

Sun, Mar 5, 7:26 PM

Sun, Feb 26

mwolff committed R45:2062edcd10ce: Exclude unresolved functions from recursion detection. (authored by mwolff).
Exclude unresolved functions from recursion detection.
Sun, Feb 26, 9:06 PM
mwolff committed R45:2af66156ec98: Remove now-dead code (authored by mwolff).
Remove now-dead code
Sun, Feb 26, 8:52 PM
mwolff committed R45:3a34d54697e2: Merge branch '1.0' (authored by mwolff).
Merge branch '1.0'
Sun, Feb 26, 8:36 PM
mwolff committed R45:b77cd26eaa1b: Improve the bottom-up conversion to top-down and caller/callee data (authored by mwolff).
Improve the bottom-up conversion to top-down and caller/callee data
Sun, Feb 26, 8:36 PM

Thu, Feb 23

mwolff committed R33:83806b265b18: Show all KTextEditor view bars in a central location (authored by mwolff).
Show all KTextEditor view bars in a central location
Thu, Feb 23, 7:48 PM
mwolff closed D4657: Show all KTextEditor view bars in a central location by committing R33:83806b265b18: Show all KTextEditor view bars in a central location.
Thu, Feb 23, 7:47 PM · KDevelop

Feb 23 2017

mwolff committed R45:021f593ef1ef: Enable alternating row colors for caller/callee view (authored by mwolff).
Enable alternating row colors for caller/callee view
Feb 23 2017, 9:29 AM
mwolff committed R45:e3b6d8281473: Move top-view properties to .ui file, enable alternating row colors (authored by mwolff).
Move top-view properties to .ui file, enable alternating row colors
Feb 23 2017, 9:29 AM

Feb 22 2017

mwolff committed R45:e5554a0a304d: Merge branch '1.0' (authored by mwolff).
Merge branch '1.0'
Feb 22 2017, 12:41 PM
mwolff committed R45:65c7cac98178: Fix action enabled state (authored by mwolff).
Fix action enabled state
Feb 22 2017, 12:39 PM
mwolff committed R45:e543ca681b6c: Fix compile with older KF5, as e.g. available on Ubuntu 16.04 (authored by mwolff).
Fix compile with older KF5, as e.g. available on Ubuntu 16.04
Feb 22 2017, 12:38 PM

Feb 21 2017

mwolff committed R33:2e395709921b: Merge branch '5.1' (authored by mwolff).
Merge branch '5.1'
Feb 21 2017, 11:00 PM
mwolff committed R33:2d04564d564c: HTML-escape diagnostic description before showing it in a tooltip (authored by mwolff).
HTML-escape diagnostic description before showing it in a tooltip
Feb 21 2017, 10:59 PM
mwolff updated the diff for D4657: Show all KTextEditor view bars in a central location.

use override, track view changes

Feb 21 2017, 10:47 PM · KDevelop
mwolff requested changes to D4672: Initial support for hookup of projects with general (web) services.

Tons of new files and not a single test? Can you add some?

Feb 21 2017, 10:33 PM
mwolff committed R33:9db2e709e00d: Merge branch '5.1' (authored by mwolff).
Merge branch '5.1'
Feb 21 2017, 10:07 PM
mwolff committed R33:c8180003ba1f: Fix project tree state not being saved (authored by bevendorff).
Fix project tree state not being saved
Feb 21 2017, 10:07 PM
mwolff closed D4665: Fix project tree state not being saved by committing R33:c8180003ba1f: Fix project tree state not being saved (authored by bevendorff).
Feb 21 2017, 10:07 PM
mwolff added a comment to T5079: Differential: provide Bug and Branch fields.

The existing branch field is not useful. It shows the branch the submitter has been using, which will usually be a work branch. What we need is the *target* branch.

Feb 21 2017, 10:05 PM · Phabricator
mwolff added a comment to D4665: Fix project tree state not being saved.

Ah, since you used arc, it does preserve it. Otherwise not: https://phabricator.kde.org/T5242

Feb 21 2017, 10:02 PM
mwolff accepted D4665: Fix project tree state not being saved.

assuming you don't have commit rights, what is your email address so I can use that to attribute this patch back to you?

Feb 21 2017, 4:26 PM
mwolff added a comment to D4665: Fix project tree state not being saved.

There's not really any point nagging about the style further, when the existing document is totally inconsistent already.

The actual changes look ok to me, and presumably to kfunk if he's also down to whitespace issues... go ahead ;-)

Feb 21 2017, 10:15 AM
mwolff accepted D4697: Show shortcuts in tooltip texts where possible.

lgtm

Feb 21 2017, 8:51 AM
mwolff committed R45:7d1098c124c5: Merge branch '1.0' (authored by mwolff).
Merge branch '1.0'
Feb 21 2017, 8:42 AM
mwolff committed R45:dca3b138cd2d: Enable wordwrap in summary labels (authored by mwolff).
Enable wordwrap in summary labels
Feb 21 2017, 8:42 AM
mwolff created T5436: Unknown Scope: whoami when logging in to userbase via phabricator.
Feb 21 2017, 8:03 AM · Phabricator
mwolff committed R45:08bdda7b322c: Merge branch '1.0' (authored by mwolff).
Merge branch '1.0'
Feb 21 2017, 7:57 AM
mwolff committed R45:75bf1ffbd34a: Document how to contribute to heaptrack (authored by mwolff).
Document how to contribute to heaptrack
Feb 21 2017, 7:56 AM

Feb 20 2017

mwolff added inline comments to D4665: Fix project tree state not being saved.
Feb 20 2017, 11:03 PM
mwolff committed R32:fcba3835397b: Improve code completion of paths with dashes in their name (authored by mwolff).
Improve code completion of paths with dashes in their name
Feb 20 2017, 11:01 PM
mwolff requested changes to D4665: Fix project tree state not being saved.

some nitpicks from my side, otherwise this looks good to me

Feb 20 2017, 9:26 PM
mwolff requested changes to D3040: Allow scaling documentation view (BUG 285162).
Feb 20 2017, 9:14 PM
mwolff added inline comments to D3040: Allow scaling documentation view (BUG 285162).
Feb 20 2017, 9:14 PM
mwolff added a comment to T5396: "create another" for task reports.

Feb 20 2017, 9:08 PM · Phabricator
mwolff added a comment to T5427: allow to review commit messages.

See e.g.: https://phabricator.kde.org/D3040 <-- I want to comment on the commit message, just like I can comment on the actual code changes. This is not possible.

Feb 20 2017, 9:04 PM · Phabricator
mwolff committed R32:a05e48ebbfa3: Avoid utimes() in custommake projects, remove unsermake support (authored by atomsymbol).
Avoid utimes() in custommake projects, remove unsermake support
Feb 20 2017, 8:55 PM
mwolff closed D4612: Avoid utimes() in custommake projects, remove unsermake support by committing R32:a05e48ebbfa3: Avoid utimes() in custommake projects, remove unsermake support (authored by atomsymbol).
Feb 20 2017, 8:55 PM
mwolff added a comment to D4612: Avoid utimes() in custommake projects, remove unsermake support.

@mwolff: I don't have commit rights. The email address is available at http://atom-symbol.net/email.html

Feb 20 2017, 8:50 PM
mwolff committed R33:2fcaccd624d4: Merge branch '5.1' (authored by mwolff).
Merge branch '5.1'
Feb 20 2017, 8:47 PM
mwolff committed R33:587972c81924: Remove useless code (authored by mwolff).
Remove useless code
Feb 20 2017, 8:47 PM
mwolff committed R33:6739aacb337e: Cleanup code, mark function as const. (authored by mwolff).
Cleanup code, mark function as const.
Feb 20 2017, 8:47 PM
mwolff committed R33:9e440fc3f5ac: Trim identifiers before triggering rename action (authored by mwolff).
Trim identifiers before triggering rename action
Feb 20 2017, 8:46 PM
mwolff created T5427: allow to review commit messages.
Feb 20 2017, 12:52 PM · Phabricator
mwolff added a comment to T5401: replacement for projects.kde.org.

Using some URL shortening could work, but sounds like a lot of work as then we either have short URLs only for the few projects you mention, and need to remember which they are, or we have one central URL place for all of them. So, if at all possible, can we resurrect the URLs of projects.kde.org/$... and point them to either the custom phabricator URL for a project, or the default project url source/....

Feb 20 2017, 12:50 PM · Phabricator
mwolff added a comment to T5394: reduce clutter on review requests.

I don't know - it makes a lot of sense to me but I don't know what others say to that. I plan to write a blog post about using phabricator soon, where I'll raise such points.

Feb 20 2017, 12:44 PM · Phabricator
mwolff added a comment to T5403: show second comment form below other comments.

yes, but often the points are spread across multiple comments so "reply" is not enough.

Feb 20 2017, 12:42 PM · Phabricator
mwolff added a comment to D4490: WIP: Some KDevelop specific file templates.

Note that for simple snippets, using the snippets plugin would be better, not the full-blown template engine.

Feb 20 2017, 12:20 PM

Feb 18 2017

mwolff created T5407: grouped queries cannot be viewed by anonymous users.
Feb 18 2017, 11:43 PM · Phabricator
mwolff added a comment to D4612: Avoid utimes() in custommake projects, remove unsermake support.

@atomsymbol: Do you have commit rights? If not, what is your email address that I can use for the git commit?

Feb 18 2017, 11:39 PM
mwolff created T5406: clarify "other reviews".
Feb 18 2017, 11:38 PM · Phabricator
mwolff added a comment to D4123: Show shortcuts on the tooltips..

tomaz, please commit

Feb 18 2017, 11:35 PM