mwolff (Milian Wolff)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 16 2015, 7:53 PM (110 w, 3 d)
Availability
Available

Recent Activity

Wed, May 24

mwolff added inline comments to D5908: Implement syntax support for function argument unpacking..
Wed, May 24, 2:52 PM
mwolff accepted D5908: Implement syntax support for function argument unpacking..

lgtm otherwise

Wed, May 24, 1:32 PM
mwolff added inline comments to D1955: projectmanagerview: Add Cut command into the context menu.
Wed, May 24, 1:12 PM
mwolff added a comment to D5908: Implement syntax support for function argument unpacking..

sorry Heinz, but I think the base for this patch is still wrong. Depending on what you did, here are some ideas on what you could try to resolve this situation:

Wed, May 24, 1:08 PM

Tue, May 23

mwolff committed R478:87131c256bb3: Optimize: do not call potentially detaching QVector::operator() (authored by mwolff).
Optimize: do not call potentially detaching QVector::operator()
Tue, May 23, 3:52 PM
mwolff committed R45:eb9c84cf7ad7: Restore the caching functionality in StringCache::location (authored by mwolff).
Restore the caching functionality in StringCache::location
Tue, May 23, 3:46 PM
mwolff committed R45:f32669fd529f: Format time values larger than 1min in terms of minutes (authored by mwolff).
Format time values larger than 1min in terms of minutes
Tue, May 23, 3:46 PM
mwolff committed R45:c98495f7e7ed: Move time-formatting code into a Util header (authored by mwolff).
Move time-formatting code into a Util header
Tue, May 23, 3:46 PM
mwolff committed R45:b32855c7538f: Further optimize handling of peak data cost (authored by mwolff).
Further optimize handling of peak data cost
Tue, May 23, 3:01 PM
mwolff committed R45:5369ee48f244: Only update peak costs on the first parse pass (authored by mwolff).
Only update peak costs on the first parse pass
Tue, May 23, 3:01 PM
mwolff committed R45:b695089353bf: Add missing license headers (authored by mwolff).
Add missing license headers
Tue, May 23, 2:34 PM
mwolff committed R45:9054e99e1994: Optimize tracking of peak costs (authored by mwolff).
Optimize tracking of peak costs
Tue, May 23, 2:14 PM
mwolff committed R45:4bf10d84391e: Always use KFormat::MetricBinaryDialect (authored by mwolff).
Always use KFormat::MetricBinaryDialect
Tue, May 23, 2:14 PM
mwolff committed R45:18de9c538590: Make peak memory consumption easier to understand (authored by mwolff).
Make peak memory consumption easier to understand
Tue, May 23, 2:14 PM

Wed, May 17

mwolff committed R33:bf183ce7a405: Cleanup implementation of CleanupThread (authored by mwolff).
Cleanup implementation of CleanupThread
Wed, May 17, 3:37 PM
mwolff committed R33:48a80f885b5c: remove dead code (authored by mwolff).
remove dead code
Wed, May 17, 3:37 PM
mwolff committed R45:cf84990f8cc9: Hide rows with less than 1% of the cost from the top proxy (authored by mwolff).
Hide rows with less than 1% of the cost from the top proxy
Wed, May 17, 1:14 PM
mwolff committed R45:ab071d9accd8: Use fixed formatting for percentages in heaptrack_print (authored by mwolff).
Use fixed formatting for percentages in heaptrack_print
Wed, May 17, 10:02 AM

Mon, May 15

mwolff committed R45:86214582550c: Update comment, this list is sorted by now (authored by mwolff).
Update comment, this list is sorted by now
Mon, May 15, 2:22 PM
mwolff committed R45:2b17e7c47595: Handle fscanf failure when reading RSS from /proc/self/statm (authored by mwolff).
Handle fscanf failure when reading RSS from /proc/self/statm
Mon, May 15, 2:22 PM
mwolff accepted D5860: backtracebrowser: Remove trailing space from widget name.

well spotted :)

Mon, May 15, 9:56 AM

Sun, May 14

mwolff added a comment to D5586: Adapt changes on kdevpatform.

qmake isn't ported yet?

Sun, May 14, 11:00 AM
mwolff requested changes to D5584: Introduction of runtimes.

overall looks OK to me, mostly nitpicks. I can't comment on the docker/flatpack magic as this goes beyond my knowledge in that area. Also make sure that the docker/flatpak plugins are only installed on linux.

Sun, May 14, 11:00 AM
mwolff accepted D5326: RFC: Update to Astyle 1.24 (latest 1.x release).

Does kdev-php and the other plugins that leverage this still work afterwards? If so, +1. That's really the only test that I'd be doing myself :) No idea about what this ASIgnore stuff is supposed to be...

Sun, May 14, 10:37 AM
mwolff added a comment to D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights.

For solarized you showed the screenshots in your original mail. I'm more concerned about backwards compatibility with other schemes. I.e. yes - we do care about the status quo. Can you give an example for a color scheme where this would break stuff? Then I can also apply the patch locally and try it out myself and maybe come up with a concrete idea to fix this all.

Sun, May 14, 10:34 AM · Frameworks
mwolff requested changes to D5707: Normalize line endings when creating ParseJob from background file..

Sorry, but I'm against pushing it as-is. Doing the optimization isn't hard, you are more or less prematurely pessimizing it here. And if you want to put this into anything but master, having a proper unit test is a must anyways I'd say.

Sun, May 14, 10:33 AM
mwolff accepted D5754: Make it possible to open directories from the command line.

please fix what kfunk pointed out, but otherwise this lgtm too

Sun, May 14, 10:24 AM
mwolff added a comment to D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights.

Hey there,

Sun, May 14, 10:22 AM · Frameworks
mwolff accepted D5188: [WIP] Basic support for building Go projects..

Ping? I think other than the mimetype issue, this is OK to get merged. Do you have commit rights?

Sun, May 14, 10:16 AM
mwolff accepted D4772: projectmanagerview: Make cut-paste work by fixing project manager's Paste action.

Sorry for the delay, and thanks for the contribution. You do have commit rights, correct? If so, please push to master.

Sun, May 14, 10:15 AM

Tue, May 9

mwolff committed R45:f8d3f2dcabb3: Do not print zero-cost sub-branches in diff mode (authored by mwolff).
Do not print zero-cost sub-branches in diff mode
Tue, May 9, 11:01 AM

Mon, May 8

mwolff committed R45:1b9a59dcc625: Show inlined frames (authored by mwolff).
Show inlined frames
Mon, May 8, 12:57 PM

Thu, May 4

mwolff accepted D5709: Implicitly shared class template: improve method declarations.
Thu, May 4, 2:17 PM
mwolff added a comment to D5707: Normalize line endings when creating ParseJob from background file..

ugh. I see it's a necessary evil. But I think it's actually going to be faster to either hand roll this replacement or use a QRegularExpression, because your code is now scanning the contents twice. Once should be enough. And a greedy pattern like "\\r\\n??" should be quite fast.

Thu, May 4, 1:48 PM
mwolff added a comment to D5584: Introduction of runtimes.

neat, sounds awesome - I'll try to find some time to try this out over the next days. But yes, without sshfs it's going to be tricky to get access to docker contents. I access them usually via, in my case, these paths:

Thu, May 4, 1:44 PM
mwolff requested changes to D5709: Implicitly shared class template: improve method declarations.

http://doc.qt.io/qt-5/qshareddatapointer.html -> your change looks sane for *explicitly* shared data members, but not for implicit ones which will call detach in non-const operator->() automatically

Thu, May 4, 1:39 PM

Wed, May 3

mwolff accepted D5644: Adds option to pass cursor line and column to external scripts.

do you have commit rights? if not, someone of us needs to commit this for you. In that case, we'll need to know your email address to properly attribute this patch set to you

Wed, May 3, 10:12 PM
mwolff committed R45:855330456d6b: Do not clear flamegraph on hide (authored by mwolff).
Do not clear flamegraph on hide
Wed, May 3, 10:08 PM
mwolff added a comment to D5584: Introduction of runtimes.

first of all, sorry for the long delay Aleix. I haven't yet had time to look at the code, just watched your videos which look pretty neat. some high-level questions:

Wed, May 3, 10:04 PM
mwolff accepted D5703: Add support for variadic functions..

lgtm, two parts can be cleaned up but otherwise feel free to commit

Wed, May 3, 9:53 PM
mwolff committed R45:4da8c450fa53: Force the fill method to never get inlined (authored by mwolff).
Force the fill method to never get inlined
Wed, May 3, 3:36 PM
mwolff committed R45:3ddc8ba3c751: Filter zero frames from the end of the stack returned by libunwind (authored by mwolff).
Filter zero frames from the end of the stack returned by libunwind
Wed, May 3, 3:36 PM

Tue, May 2

mwolff committed R45:0a481b5642b7: Disable flamegraph navigation actions when they are not applicable (authored by mwolff).
Disable flamegraph navigation actions when they are not applicable
Tue, May 2, 9:21 PM
mwolff committed R45:f31b2605fbf8: Also show tooltips with function identifiers (authored by mwolff).
Also show tooltips with function identifiers
Tue, May 2, 9:21 PM
mwolff committed R45:50f335a4801c: Add search feature to flamegraph (authored by mwolff).
Add search feature to flamegraph
Tue, May 2, 9:21 PM
mwolff committed R267:6bfdaac28028: Add icon for hotspot (https://github.com/KDAB/hotspot) (authored by Nuno Pinheiro <nuno.pinheiro@kdab.com>).
Add icon for hotspot (https://github.com/KDAB/hotspot)
Tue, May 2, 8:15 PM
mwolff committed R266:ad94a00d221f: Add icons for hotspot (https://github.com/KDAB/hotspot) (authored by Nuno Pinheiro <nuno.pinheiro@kdab.com>).
Add icons for hotspot (https://github.com/KDAB/hotspot)
Tue, May 2, 8:13 PM
mwolff committed R45:70aae68975c9: Add CMake's Copyright.txt which is referenced by FindLibunwind.cmake (authored by mwolff).
Add CMake's Copyright.txt which is referenced by FindLibunwind.cmake
Tue, May 2, 7:47 PM
mwolff committed R45:e85cba3fbfa7: Clarify licenses (authored by mwolff).
Clarify licenses
Tue, May 2, 7:37 PM
mwolff committed R45:5dd6871acf54: Remove unused ModelTest (authored by mwolff).
Remove unused ModelTest
Tue, May 2, 7:37 PM

Apr 28 2017

mwolff committed R45:103cc2a96fab: Include raw byte size in tooltips (authored by mwolff).
Include raw byte size in tooltips
Apr 28 2017, 11:35 AM
mwolff committed R45:d8a97812dc2e: Use byte size in allocated tooltip (authored by mwolff).
Use byte size in allocated tooltip
Apr 28 2017, 11:28 AM
mwolff committed R45:4f56a13fcc4b: Properly remap string indices before asserting equality (authored by mwolff).
Properly remap string indices before asserting equality
Apr 28 2017, 11:26 AM

Apr 26 2017

mwolff committed R39:c24b36b8936e: Fix assertion when applying code folding that changes cursor position (authored by mwolff).
Fix assertion when applying code folding that changes cursor position
Apr 26 2017, 3:41 PM

Apr 18 2017

mwolff added a comment to D5491: Improve detection of builtin defines from compiler command.

excellent test coverage, much appreciated, some nitpick notes

Apr 18 2017, 2:59 PM

Apr 17 2017

mwolff committed R45:3cb1b7fd2f4b: Call libc and libstdc++ freeres functions in heaptrack_preload on exit (authored by mwolff).
Call libc and libstdc++ freeres functions in heaptrack_preload on exit
Apr 17 2017, 7:17 PM

Apr 13 2017

mwolff requested changes to D5425: Allow disabling the git plugin with a kdevgit.disabled git config option.

can we first profile it and see if we can speed it up instead of applying such a (imo) nasty workaround?

Apr 13 2017, 1:55 PM

Apr 7 2017

mwolff committed R45:e203d56632b9: Disable signal handling in timer thread (authored by mwolff).
Disable signal handling in timer thread
Apr 7 2017, 12:27 PM

Apr 6 2017

mwolff committed R45:1bab9e49229c: Add missing include directory (authored by Erwin Jansen <jansene@google.com>).
Add missing include directory
Apr 6 2017, 8:24 AM
mwolff committed R74:a4c9ab29ef25: Setup {DY,}LD_LIBRARY_PATH in clazy shell script (authored by mwolff).
Setup {DY,}LD_LIBRARY_PATH in clazy shell script
Apr 6 2017, 8:22 AM
mwolff closed D5298: Setup LD_LIBRARY_PATH in clazy shell script by committing R74:a4c9ab29ef25: Setup {DY,}LD_LIBRARY_PATH in clazy shell script.
Apr 6 2017, 8:22 AM

Apr 5 2017

mwolff added a comment to T1841: heaptrack: support debuglink and UUID for split debug info.

A WIP for this can be found in wip/buildid, it will include the buildid in the heaptrack file. But for interpreting, it isn't enough to just load the debug file only. It has to be used in addition apparently, which isn't possible without patching libbacktrace like is done in vogl.

Apr 5 2017, 11:09 AM · Performance Tooling, Heaptrack
mwolff committed R45:f335efc89018: WIP: Include the build-id in the heaptrack output and use it to find libs (authored by mwolff).
WIP: Include the build-id in the heaptrack output and use it to find libs
Apr 5 2017, 11:01 AM
mwolff committed R45:44fe3887133b: Add a manual executable to investigate dl_iterate_phdr contents (authored by mwolff).
Add a manual executable to investigate dl_iterate_phdr contents
Apr 5 2017, 11:01 AM

Apr 4 2017

mwolff committed R45:c513793b8a43: Prefer $lib.debug files over $lib files, if available (authored by mwolff).
Prefer $lib.debug files over $lib files, if available
Apr 4 2017, 3:40 PM
mwolff updated the diff for D5298: Setup LD_LIBRARY_PATH in clazy shell script.

also update DYLD_LIBRARY_PATH

Apr 4 2017, 12:32 PM
mwolff created D5298: Setup LD_LIBRARY_PATH in clazy shell script.
Apr 4 2017, 11:52 AM
mwolff committed R45:743a628be73d: Add a script to anonymize profiling data (authored by mgolov).
Add a script to anonymize profiling data
Apr 4 2017, 7:34 AM
mwolff closed D5288: Add a script to anonymize profiling data by committing R45:743a628be73d: Add a script to anonymize profiling data (authored by mgolov).
Apr 4 2017, 7:34 AM
mwolff committed R45:ef3632ff8fc3: Add .arcconfig file (authored by mwolff).
Add .arcconfig file
Apr 4 2017, 7:34 AM

Apr 3 2017

mwolff accepted D5288: Add a script to anonymize profiling data.

lgtm, I can also add the copyright header for you and submit it then later when I get the time

Apr 3 2017, 4:26 PM

Apr 2 2017

mwolff committed R45:aecd0c2d6162: Enable rubber-band zooming in charts (authored by mwolff).
Enable rubber-band zooming in charts
Apr 2 2017, 6:58 PM
mwolff committed R45:ccdc14bfaa43: Properly fail to parse lines of two or one chars (authored by mwolff).
Properly fail to parse lines of two or one chars
Apr 2 2017, 6:58 PM

Mar 29 2017

mwolff added a comment to D5188: [WIP] Basic support for building Go projects..

can go project be detected based on some file? If so, could you add something like this to the json file please:

Mar 29 2017, 9:23 PM
mwolff requested changes to D5210: Proper CUDA handling.
Mar 29 2017, 9:19 PM
mwolff added a comment to D5210: Proper CUDA handling.

I think you are still abusing the code architecture for compiler support here.

Mar 29 2017, 9:19 PM
mwolff accepted D5244: Port and reenable KGraphViewer support.

if it shows a graph, lgtm :)

Mar 29 2017, 9:14 PM

Mar 28 2017

mwolff added a comment to D5210: Proper CUDA handling.

the screenshot shows "c++11" as Cuda C profile - is that correct?

Mar 28 2017, 9:07 AM
mwolff added a comment to D5139: VCS commit message width feedback.

I'm still against messing with the font styles the way you do it. simply add underlines for the part that is longer than N chars and add a tooltip for that part such that people know what's happening

Mar 28 2017, 9:06 AM · KDevelop

Mar 27 2017

mwolff requested changes to D5139: VCS commit message width feedback.
Mar 27 2017, 8:20 PM · KDevelop
mwolff added a comment to D3041: Enable zoom feature in built-in documentation widgets.

still lgtm, do you have commit rights?

Mar 27 2017, 8:15 PM
mwolff added a comment to D3040: Allow scaling documentation view (BUG 285162).

still lgtm, do you have commit rights?

Mar 27 2017, 8:15 PM
mwolff added a comment to T5733: Better CUDA Support.

I think it's OK to rely on clang only for cuda and not support GCC emulation. This doesn't even really work properly for C++ either, so don't go down that rabbit hole.

Mar 27 2017, 8:11 PM · KDevelop
mwolff added a comment to D5183: Reopen accidentally closed tab.

@coopht: Your points re recent files are very valid - let's not use it.

Mar 27 2017, 8:06 PM
mwolff requested changes to D5188: [WIP] Basic support for building Go projects..
Mar 27 2017, 8:04 PM

Mar 26 2017

mwolff requested changes to D5183: Reopen accidentally closed tab.

I like the change in general, only wonder whether we need to introduce a new queue for that - can't we reuse the recent file mechanism instead? or do people really want to have an infinite history here?

Mar 26 2017, 9:59 PM

Mar 23 2017

mwolff added a comment to T5733: Better CUDA Support.

We are explicitly excluding the standard includes for C and C++, so maybe something like that accidentally happens for cuda, too? Cf. nostdinc.

Mar 23 2017, 2:16 PM · KDevelop
mwolff added a comment to D5102: Add scroll-barmarks also to the built-in search&replace.

Yes, please reserve it.

Mar 23 2017, 2:11 PM · Frameworks

Mar 22 2017

mwolff committed R32:903e54347f7b: Workaround cmake server bug that gets confused on symlinks (authored by mwolff).
Workaround cmake server bug that gets confused on symlinks
Mar 22 2017, 2:50 PM
mwolff committed R32:e1500e1f382e: Use canonical paths for file-specific information from cmake server (authored by mwolff).
Use canonical paths for file-specific information from cmake server
Mar 22 2017, 2:50 PM
mwolff requested changes to D4772: projectmanagerview: Make cut-paste work by fixing project manager's Paste action.
Mar 22 2017, 8:59 AM
mwolff accepted D3040: Allow scaling documentation view (BUG 285162).

remove the moc, then feel free to push

Mar 22 2017, 8:59 AM

Mar 20 2017

mwolff committed R32:e40751cda601: Resolve {MOC,OBJECTS,UI}_DIR relative to build directory (authored by mwolff).
Resolve {MOC,OBJECTS,UI}_DIR relative to build directory
Mar 20 2017, 10:30 PM
mwolff committed R32:665385366748: Add all .pro files to qmake project root file item. (authored by mwolff).
Add all .pro files to qmake project root file item.
Mar 20 2017, 10:30 PM
mwolff committed R170:06286490b2e2: Fix build: use MailTransportAkonadi to find messagequeuejob.h (authored by mwolff).
Fix build: use MailTransportAkonadi to find messagequeuejob.h
Mar 20 2017, 10:44 AM
mwolff requested changes to D5041: Port away from QtWebKit to QtWebEngine.
Mar 20 2017, 9:12 AM
mwolff added inline comments to D4772: projectmanagerview: Make cut-paste work by fixing project manager's Paste action.
Mar 20 2017, 9:09 AM

Mar 19 2017

mwolff committed R32:73d051aa33de: Fix CMake::readCacheValues to actually read values from the cache (authored by mwolff).
Fix CMake::readCacheValues to actually read values from the cache
Mar 19 2017, 2:38 PM
mwolff accepted D5043: Split ContextMenuExtension::AnalyzeGroup to File/Project groups.
Mar 19 2017, 1:26 PM
mwolff requested changes to D4234: Change algorithm for autobrace..

I'm personally all for improving the status quo, but I think the biggest problem here is that we have no unit test coverage (or do we?). The unit tests would also clearly show the advantage of this new beheavior compared to the old one. So: Could you add unit tests?

Mar 19 2017, 1:25 PM · Frameworks