- User Since
- Apr 16 2015, 7:53 PM (226 w, 6 d)
Wed, Aug 7
Jun 25 2019
lgtm, thanks - do you have commit rights? if so, please push to the 5.3 branch
Jun 24 2019
Jun 18 2019
Jun 17 2019
having looked at the raw diff quickly, I like what I'm seeing. What boilerplate are you referring to?
so, I've now committed an alternative fix (or so I hope...) see:
ok, sorry for the rabbit hole I sent you down. I still think that long-term we will need something like QPromise, but phabricator doesn't even let me view the interesting changes in shell/... so I cannot comment on the boilerplate
Jun 3 2019
May 29 2019
May 28 2019
May 20 2019
FTR: I did give my consent, so thanks @lunakl!
May 15 2019
you are removing a feature, but only partially - a lot of code would become superfluous by this change and should be cleaned up accordingly
May 7 2019
May 6 2019
Apr 24 2019
Apr 23 2019
Apr 17 2019
Apr 16 2019
patch lgtm now, many thanks!
Apr 15 2019
quite obviously libclang doesn't handle it
Apr 14 2019
Apr 13 2019
Oh, really? Hmm! I wouldn't be opposed to enable compilation with exceptions myself, what do the others say? We don't need to use them excessively, but for error handling in async promise chains, that would be quite useful I think?
Hey Thomas, please don't remove the cache. See f2a6941e086cdf506c8fb1798c52982bff43792d for why this was introduced. Your tests don't include other files, so probably that's why you didn't see any effect of the cache?
Apr 1 2019
yes, QtPromise or AsyncFuture (https://github.com/benlau/asyncfuture) could be used - I wouldn't be opposed to introducing it as a thirdparty dependency (or git submodule)
if it applies cleanly, you can also push to 5.3, otherwise master is fine - it's not a really urgent bug fix after all (imo)
Mar 26 2019
your simplified patch seems to work like a charm, thanks a lot!
Mar 25 2019
Mar 24 2019
one minor nit, otherwise looks like a good improvement
Mar 22 2019
Mar 20 2019
Mar 18 2019
Mar 12 2019
thanks, lgtm - I'll amend the last nits and apply it for you - if you give me full name and email address such that I can set you as the main author of this patch
Mar 11 2019
ah, then let's get this in as-is
great! can we get a unit test for this? though I'm unsure if we ever revived the unit tests from our old cmake integration
Mar 10 2019
yes I would be fine with that personally!
ok cool, then please get rid of our internal copy!
nice, this is getting better! some suggestions on how to improve the code quality, and then some potential issues I can think of - please fix or document why they aren't an issue
cool, this is great! and it fixes the issue you originally found in testActiveDocumentsGetBestPriority?
Rene, instead of thinking about what-ifs, maybe try it out first? Most notably, the tooltips only show up when you press ALT and keep it pressed. Otherwise, the tooltips don't show up - unless you hover code with your mouse cursor. Moving the keyboard edit cursor won't ever trigger tooltips. Or are you somehow moving your mouse cursor while typing?! Don't do that :)