cullmann (Christoph Cullmann)
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 30 2015, 8:46 PM (450 w, 4 d)
Availability
Available

Recent Activity

Aug 25 2023

cullmann added a comment to T12409: Move kxmlgui files from GenericDataLocation to ConfigLocation.

The problem is that package managers will not overwrite /etc stuff on install, that will lead very easily to issues.
As said, I see the point for the user local config, why not in .config, all fine for me.
But I would like to have the shipped ones as data, that allows to be sure updates will enforce the new state is used.

Aug 25 2023, 6:22 AM · KF6

Aug 24 2023

cullmann added a comment to T12409: Move kxmlgui files from GenericDataLocation to ConfigLocation.

I think having that in /etc is very wrong as most applications totally break or even crash on any non-trivial modification of this and /etc somehow implies this is config.
The files in the config dir in the home are only meant to be written by the shortcut config and Co. and not manually altered.
In Kate and Co., if you just remove some menus or toolbars in the worst case it will just crash.

Aug 24 2023, 7:32 PM · KF6

Jul 9 2023

cullmann added a comment to T12243: KSyntaxHighlighting: Expose context in highlighting functions.

I miss what should be in that context object. If it is just something that should be passed around, I think the current code e.g. in KTextEditor is nicer the working on a void *.

Jul 9 2023, 4:54 PM · KF6
cullmann added a comment to T12244: Move enum KSyntaxHighlighting::TextStyles.

https://invent.kde.org/frameworks/syntax-highlighting/-/commit/0e959366e54dbee4855c0af6555694d26a18f530

Jul 9 2023, 4:52 PM · KF6
cullmann closed T12244: Move enum KSyntaxHighlighting::TextStyles as Resolved.
Jul 9 2023, 4:50 PM · KF6
cullmann added a comment to T12244: Move enum KSyntaxHighlighting::TextStyles.

We did remove the KTextEditor::DefaultStyles , I see no reason to move the enums beside creating porting work, there is no harm in having them in the theme.

Jul 9 2023, 4:50 PM · KF6

Jul 3 2023

cullmann added a comment to T12103: KTextEditor.

I think most stuff was already done.

Jul 3 2023, 9:54 PM · KF6

May 15 2021

cullmann added a comment to T9986: Delete "What's This" inline help functionality.

If I don't misunderstand the Qt docs:

May 15 2021, 12:12 PM · Goal: Consistency, KDE Applications, Plasma, KF6, VDG

May 7 2021

cullmann added a comment to T12154: KCModuleLoader deployment issues.

Actually, I am not sure to which code path I refer, I only know that I wasn't able to ever load my local kscreen kcm module even if QT_PLUGIN_PATH was set to the right path.

May 7 2021, 8:18 PM · KF6

Apr 23 2021

cullmann added a comment to T14380: Integrate App Store Packaging into App Repos and Release Tools.

For appimage: I would rather prefer if e.g. Craft would produce these (as it already does) and the stuff for that stays in the craft blueprints.

Apr 23 2021, 7:01 PM · Goal: All About the Apps

Apr 17 2021

cullmann closed T12242: Organize mid-2020 KF6 sprint as Resolved.

I think given 2020 is over, yes.
One can still create a new task for new meetings.

Apr 17 2021, 1:30 PM · KF6

Apr 14 2021

cullmann added a comment to T12083: Make DBus dependencies optional.

Ok, yeah, you are right that on Linux/BSD/... making DBus optional is a non-goal, I agree.
One can assume it will be usable there.
It is just a pain on other operating systems.

Apr 14 2021, 6:51 PM · KF6
cullmann added a comment to T12083: Make DBus dependencies optional.

QtKeychain uses DBus to talk to KWallet etc, so that would merely move the problem

I don't think so.

Apr 14 2021, 6:45 PM · KF6

Apr 13 2021

cullmann closed T12203: KXmlGui: Remove kpackages.h header as Resolved.

Was already done

Apr 13 2021, 11:04 AM · KF6
cullmann closed T12203: KXmlGui: Remove kpackages.h header, a subtask of T12202: KXmlGui, as Resolved.
Apr 13 2021, 11:04 AM · KF6

Apr 9 2021

cullmann added a comment to T11691: Ponder AppImage tooling within KDE.

Yes, the binary factory already outputs them, for sure on should aim to improve that method.

Apr 9 2021, 3:18 PM · Goal: All About the Apps

Mar 29 2021

cullmann added a comment to T12140: Killing KInit With Fire.

Given that is the default mode we use them on other platforms, I would love to see this more tested, thought I am not able to grasp the full impact of this.

Mar 29 2021, 7:48 AM · KF6

Mar 28 2021

cullmann added a comment to T13952: KPluginLoader.

Add application plugin path to default search path

Mar 28 2021, 10:14 AM · KF6

Mar 27 2021

cullmann moved T14297: Upstream Icon-Recoloring to Qt (perhaps XDG, too) from Backlog to Waiting on Qt Changes on the KF6 board.
Mar 27 2021, 4:59 PM · KF6
cullmann added a comment to T11637: KIconThemes Cleanups.

One remaining thing not solved by moving the 2 classes to WidgetAddons and re-coloring upstreaming is the auto-loading of the RCC stuff.

Mar 27 2021, 4:57 PM · KF6
cullmann created T14297: Upstream Icon-Recoloring to Qt (perhaps XDG, too).
Mar 27 2021, 4:57 PM · KF6
cullmann placed T14296: Split KIconThemes into GUI/Widgets libs up for grabs.
Mar 27 2021, 4:55 PM · KF6
cullmann moved T11637: KIconThemes Cleanups from In Discussion to Metatasks on the KF6 board.
Mar 27 2021, 4:55 PM · KF6
cullmann renamed T11637: KIconThemes Cleanups from Investigate if KIconThemes is needed as a framework to KIconThemes Cleanups.
Mar 27 2021, 4:55 PM · KF6
cullmann created T14296: Split KIconThemes into GUI/Widgets libs.
Mar 27 2021, 4:54 PM · KF6
cullmann added a comment to T11637: KIconThemes Cleanups.

Short dump of notes done during sprint:

Mar 27 2021, 4:50 PM · KF6
cullmann claimed T11637: KIconThemes Cleanups.

Will create actionable sub tasks.

Mar 27 2021, 4:49 PM · KF6

Mar 22 2021

cullmann added a comment to T11637: KIconThemes Cleanups.

Yeah, but that went nowhere, true, I somehow did forget about it ;=)
That would be cool to have, at the moment I still need to patch the icon themes engine "on" for Windows/macOS and in e.g. GNOME/.... Kate will just break (like any other KDE application that relies on Breeze icons for some actions).

Mar 22 2021, 7:51 PM · KF6
cullmann added a comment to T11637: KIconThemes Cleanups.

I learned the hard way in https://invent.kde.org/frameworks/kiconthemes/-/merge_requests/26 that our current KIconEngine is no proper 1:1 replacement for the QSvgIconEngine.

Mar 22 2021, 7:45 PM · KF6

Feb 25 2021

cullmann added a comment to T14154: Adapt to QTextCodec changes.

I think it at the moment is still alive in the Qt5Compat module:

Feb 25 2021, 1:34 PM · KF6

Feb 4 2021

cullmann added a comment to T14091: Improve the App Update Announcements.

I can live with "KDE Gear", but I could even live with other generic names like "KDE Bundle" or such ;)

Feb 4 2021, 7:31 PM · Goal: All About the Apps, KDE Applications, KDE Promo

Feb 2 2021

cullmann added a comment to T9986: Delete "What's This" inline help functionality.

That solution looks indeed nice, too.
I would have no issue to adopt that one. Merge requests welcome :P

Feb 2 2021, 2:45 PM · Goal: Consistency, KDE Applications, Plasma, KF6, VDG
cullmann added a comment to T9986: Delete "What's This" inline help functionality.

In the Kate/KTextEditor config dialog we tried to provide a lot of "what's this" stuff.
But I guess it would make sense to move that there just to tooltips.

Feb 2 2021, 11:49 AM · Goal: Consistency, KDE Applications, Plasma, KF6, VDG

Jan 26 2021

cullmann abandoned D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set.

I have now a working version that handles palette changes, too.

Jan 26 2021, 7:28 PM · Frameworks
cullmann added a comment to D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set.

I need to finalize this, people start to complain more and more about this missing on Windows for Kate/etc... ;(

Jan 26 2021, 10:04 AM · Frameworks

Jan 12 2021

cullmann added a comment to T12083: Make DBus dependencies optional.

kactivities & kactivities-stats => guess not that relevant, as not interesting for non-unices

Jan 12 2021, 1:34 PM · KF6

Dec 27 2020

cullmann added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

I think consistency trumps all things.

Dec 27 2020, 11:18 AM

Nov 24 2020

cullmann added a comment to D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set.

Hmm, I don't think you need a theme chooser, we just need to watch for the palette change signal and then trigger again the theme name setting based on the background palette.
That would be enough to detect bright/dark mode.

Nov 24 2020, 12:51 PM · Frameworks

Oct 31 2020

cullmann added a comment to D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set.

I think exporting some namespaced function or such that will do the setting of the theme and calling it would be ok for me.
This is anyways an "opt-in" approach people must decide to use.
Hannah, what do you think?

Oct 31 2020, 10:36 AM · Frameworks

Oct 10 2020

cullmann abandoned D25339: update lineHeight if boundingRect indicates a larger value..
Oct 10 2020, 7:13 PM · Frameworks, Kate
cullmann commandeered D25339: update lineHeight if boundingRect indicates a larger value..

I think the solution we have in current master is ok enough.

Oct 10 2020, 7:13 PM · Frameworks, Kate

Sep 8 2020

cullmann added a comment to T11589: Remove kjs.

Perhaps copying it there might be better than creating the impression that people should really use it for other stuff, if Okular is the only "big" last user of this.

Sep 8 2020, 9:40 AM · KF6

Aug 17 2020

cullmann added a comment to T12730: Rework COPYING and COPYING.LIB files.

Thanks for taking care of all this!
;=)

Aug 17 2020, 8:02 AM · KF6

Aug 11 2020

cullmann abandoned D23410: improve word completion to use highlighting to detect word boundaries.

At the moment no idea how to fix that without regressions.

Aug 11 2020, 4:22 PM · Frameworks, Kate
cullmann closed D24568: Provide clang-format target with a KDE Frameworks style file.

For my 2 wanted changes, I created a new merge request
https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/20

Aug 11 2020, 4:21 PM · Build System, Frameworks
cullmann added a comment to D24826: Enforce 100 chars line width.

As said above, I think 100 is a bad idea. Can we close this?

Aug 11 2020, 4:18 PM · Build System, Frameworks
cullmann added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

I think we went with the solution in https://phabricator.kde.org/D29789, could we close this?

Aug 11 2020, 4:16 PM · Frameworks, Kate

Jul 14 2020

cullmann added a comment to T10243: Some KDE applications could use better icons.

Hi, just to avoid any wasted work:

Jul 14 2020, 3:35 PM · KDE Applications, VDG

Jul 11 2020

cullmann added a comment to T9580: Publish KDiff3 in the Microsoft Store.

Ben activated the APPX stuff

Jul 11 2020, 3:18 PM · Windows

Jun 21 2020

cullmann added a comment to T9579: Publish Dolphin in the Microsoft Store.

I think having 44x44 and 150x150 icons is just a matter of scaling the ones we have, they are a SVG anyways.
I think the hard part is that somebody needs to check if all things work ok for the binary factory builds and later care about the reported issues.

Jun 21 2020, 12:58 PM · Dolphin, Windows

Jun 15 2020

cullmann committed R319:e6ce6b24152f: Merge branch 'fix-win-id-rendering' into 'master' (authored by cullmann).
Merge branch 'fix-win-id-rendering' into 'master'
Jun 15 2020, 3:53 AM

Jun 8 2020

cullmann added a comment to D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set.

That depends.
If somebody else would test this and we can agree that this is a nicer way to hard-code breeze icons compared to having that code in kiconthemes it would make sense.

Jun 8 2020, 10:59 AM · Frameworks

Jun 7 2020

cullmann committed R223:3ad9fc7028bb: allow unicode filenames to work on Windows, too (authored by cullmann).
allow unicode filenames to work on Windows, too
Jun 7 2020, 11:52 AM
cullmann committed R223:bb53266430ae: allow unicode filenames to work on Windows, too (authored by cullmann).
allow unicode filenames to work on Windows, too
Jun 7 2020, 11:27 AM

May 29 2020

cullmann committed R40:f63d953cc518: Use proper method to get first line (authored by mmassaro).
Use proper method to get first line
May 29 2020, 7:06 AM
cullmann committed R40:01dfda179de7: Fix "Run Current Document" so that it uses shebang or correct file path (authored by mmassaro).
Fix "Run Current Document" so that it uses shebang or correct file path
May 29 2020, 7:06 AM
cullmann committed R39:99eb9bfbb434: Add .diff to the file-changed-diff to enable mime detection on windows. (authored by sars).
Add .diff to the file-changed-diff to enable mime detection on windows.
May 29 2020, 6:33 AM
cullmann committed R40:f2016388e4e1: Preview addon: Better update delay logic. (authored by aa bb <kde@t.weebit.eu>).
Preview addon: Better update delay logic.
May 29 2020, 6:30 AM

May 28 2020

cullmann committed R216:ebb2a2da0486: Update Raku extensions in Markdown blocks (authored by nibags).
Update Raku extensions in Markdown blocks
May 28 2020, 7:19 PM
cullmann committed R216:70014ab33b16: Raku: fix fenced code blocks in Markdown (authored by nibags).
Raku: fix fenced code blocks in Markdown
May 28 2020, 7:19 PM

May 22 2020

cullmann accepted D28235: Add a simpler example.

;=) Actually, I just missed this request, sorry.

May 22 2020, 2:53 PM · Frameworks, Kate

May 20 2020

cullmann committed R216:78d207f24e43: Add collaboration guide in README (authored by nibags).
Add collaboration guide in README
May 20 2020, 3:24 PM

May 18 2020

cullmann accepted D29793: Rename Perl6 syntax to Raku.

I think it makes sense to have just "Raku", the world at large (like me) only recognizes Perl 5 as Perl .P

May 18 2020, 1:57 PM · Frameworks, Kate
cullmann added a comment to D29795: Add collaboration guide.

I think this is very good thing to have.
But perhaps we just should add that to the README.md that is prominently shown on e.g. https://invent.kde.org/frameworks/syntax-highlighting
The README anyways already contains a "Adding unit tests for a syntax definition" that could be replaced with this.

May 18 2020, 1:56 PM · Frameworks, Kate
cullmann committed R39:133b85866913: Make text always align with font base line (authored by xuetianweng).
Make text always align with font base line
May 18 2020, 1:52 PM
cullmann closed D29789: Make text always align with font base line.
May 18 2020, 1:52 PM · Frameworks, Kate
cullmann accepted D29789: Make text always align with font base line.

Hmm, looks better for me, too.
Let's go with this at the moment.
If it creates issues, we can still revert it again.
Thanks for taking care of this.

May 18 2020, 1:51 PM · Frameworks, Kate

May 15 2020

cullmann committed R216:f804af905ef3: Assign "Identifier" attribute to opening double quote instead of "Comment" (authored by cullmann).
Assign "Identifier" attribute to opening double quote instead of "Comment"
May 15 2020, 3:45 PM
cullmann closed D29735: Assign "Identifier" attribute to opening double quote instead of "Comment".
May 15 2020, 3:45 PM · Frameworks, Kate, Framework: Syntax Highlighting
cullmann added a comment to D29735: Assign "Identifier" attribute to opening double quote instead of "Comment".

Sure, thanks for the improvement!

May 15 2020, 3:45 PM · Frameworks, Kate, Framework: Syntax Highlighting
cullmann added a comment to D27844: Store and fetch complete view config in and from session config.

Hmm, right, didn't think about that :(
Guess if we want to have this, we need to improve the read/writeConfig functions.

May 15 2020, 3:43 PM · Frameworks, Kate

May 9 2020

cullmann added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

see e.g. here for a start of using the right heights inside the renderer.

May 9 2020, 2:31 PM · Frameworks, Kate
cullmann added a comment to D25339: update lineHeight if boundingRect indicates a larger value..
Looking at the code, might it make more sense to just move away from the fixed height we have?
It isn't used that often and in most cases one could just query the height of the current line.

I'd be all for that, provided it doesn't introduce any regressions in the rendered result nor in rendering time.

It could be trickier to implement than you think though?

May 9 2020, 2:16 PM · Frameworks, Kate
cullmann committed R40:2bac3af1c89f: Merge branch 'vejnar/kate-master' (authored by cullmann).
Merge branch 'vejnar/kate-master'
May 9 2020, 11:20 AM
cullmann committed R40:ba23be52ba3a: Highlighting Doc: expand explanation about XML files directory (authored by nibags).
Highlighting Doc: expand explanation about XML files directory
May 9 2020, 11:14 AM
cullmann committed R216:1e8466029c82: Bash: fix comments after escapes (authored by nibags).
Bash: fix comments after escapes
May 9 2020, 11:09 AM
cullmann closed D29354: Bash: fix comments after escapes.
May 9 2020, 11:09 AM · Frameworks, Kate
cullmann accepted D29354: Bash: fix comments after escapes.

Same here ;=) Thanks a lot for the work on all this issues!

May 9 2020, 11:09 AM · Frameworks, Kate
cullmann committed R216:0b6c88cfc167: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END (authored by nibags).
LaTeX: fix folding in \end{...} and in regions markers BEGIN-END
May 9 2020, 11:08 AM
cullmann closed D29521: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END.
May 9 2020, 11:08 AM · Frameworks, Kate
cullmann accepted D29521: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END.
May 9 2020, 11:08 AM · Frameworks, Kate
cullmann added a comment to D29521: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END.

Looks fine for me, thanks for improvement!

May 9 2020, 11:08 AM · Frameworks, Kate
cullmann added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

Looking at the code, might it make more sense to just move away from the fixed height we have?
It isn't used that often and in most cases one could just query the height of the current line.
That would solve this issue without needing any hacks for the rendering I think.

May 9 2020, 10:55 AM · Frameworks, Kate

Apr 27 2020

cullmann committed R877:9c1ca1f6065d: try 20.04.0 release (authored by cullmann).
try 20.04.0 release
Apr 27 2020, 11:10 AM

Apr 26 2020

cullmann committed R877:83f08e91e680: patch is inside all supported versions (authored by cullmann).
patch is inside all supported versions
Apr 26 2020, 3:43 PM
cullmann committed R877:d2dc5942a43f: newer versions have this inside, remove experimental patch (authored by cullmann).
newer versions have this inside, remove experimental patch
Apr 26 2020, 3:41 PM
cullmann committed R877:6079fa7337bb: purge dead patches (authored by cullmann).
purge dead patches
Apr 26 2020, 3:41 PM
cullmann committed R877:a2620078422c: up to current frameworks release 5.69.0 (authored by cullmann).
up to current frameworks release 5.69.0
Apr 26 2020, 3:36 PM
cullmann committed R39:14fef3f92144: fix drag'n'drop on left side border widget (authored by cullmann).
fix drag'n'drop on left side border widget
Apr 26 2020, 3:06 PM
cullmann added a reviewer for D25339: update lineHeight if boundingRect indicates a larger value.: Frameworks.

I tried the current version.
For me this looks OK now.
Thought I would like to have more people trying this out before we merge.
Some volunteers?

Apr 26 2020, 12:03 PM · Frameworks, Kate

Apr 25 2020

cullmann committed R40:445e826b8573: Merge branch 'gawin/kate-impr/initialize' (authored by cullmann).
Merge branch 'gawin/kate-impr/initialize'
Apr 25 2020, 1:44 PM
cullmann committed R216:7f4a425340cb: fix unit test refs (authored by cullmann).
fix unit test refs
Apr 25 2020, 1:40 PM
cullmann committed R216:559cda73cf57: Updated test file for Logtalk syntax highlighting (authored by cullmann).
Updated test file for Logtalk syntax highlighting
Apr 25 2020, 1:39 PM
cullmann closed D28870: Updated test file for Logtalk syntax highlighting.
Apr 25 2020, 1:39 PM · Frameworks, Kate
cullmann accepted D28870: Updated test file for Logtalk syntax highlighting.
Apr 25 2020, 1:39 PM · Frameworks, Kate
cullmann committed R216:d4d17b34f961: fix unit test refs (authored by cullmann).
fix unit test refs
Apr 25 2020, 1:26 PM
cullmann committed R216:bf2664ea7907: Update Logtalk language syntax support (authored by cullmann).
Update Logtalk language syntax support
Apr 25 2020, 1:25 PM
cullmann closed D28796: Update Logtalk language syntax support.
Apr 25 2020, 1:25 PM · Frameworks, Kate
cullmann accepted D28796: Update Logtalk language syntax support.

Ok, I see, there is an extra request for the new hl test file.
Then let's approve this one.

Apr 25 2020, 11:59 AM · Frameworks, Kate

Apr 19 2020

cullmann added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

Hmm, after applying this patch, for me, no text is visible at all.
By selecting a bit stuff, one at least sees an outline (CMakeLists.txt of ktexteditor toplevel dir).

Apr 19 2020, 12:55 PM · Frameworks, Kate