- User Since
- Jul 30 2015, 8:46 PM (237 w, 6 d)
Mon, Feb 17
Yes, sounds like a very good idea!
Sun, Feb 16
Hi, nice that you keep working on this and upstream your stuff ;=)
Could you provide some test file for this?
Sat, Feb 15
Thu, Feb 13
Wed, Feb 12
Thanks for the fix!
Ok, tested on Win10 => This solves the issue.
adapt api to used QMap
add missing include for windows
fix argument to create spell checker
sonnet cleanup for the dictionaries seems to be too late
any cleanup crashs silently
Ok, happy with that, thanks!
de-init com after interface got released, avoids crash
:=) I think the issue is even much smaller, I just call un-init before release, that is wrong :/
I will quickfix that and avoid other changes (beside the extra nullptr checks).
Tue, Feb 11
I played a bit with it.
No idea why I get crash reports over the store and can't see this locally.
Given the docs state one shall not do the de-init during unloading but sonnet handles the clients/spellers via some global static that could be a reason...
Hmm, not sure.
Given we have everywhere at the moment the dynamic/static word wrap wording, I would rather stick with that.
- skip com init/deinit
See crash reports in Windows store.
For me locally, it seemed to work :/
Hmm, this doesn't build due to use of an obsolete function.
Btw., for future patches, better use merge requests at https://invent.kde.org/kde/kate, thanks.
Let's to with this then for the moment.
If you find time to improve on this, further patches are welcome!
Thanks for taking care! (and that you like Kate ;=)
Ok, thanks for taking care!
Let's merge this.
I am ok with this.
Thought I would like to have a more consistent name for the config key.
We have already "dynamic-word-wrap", I would like "dynamic-word-wrap-anywhere" better than the abbreviated "dyn-wrap-anywhere"
Sun, Feb 9
Given we have now a bunch of applications in the store, it might sense to start the promotion a bit.
I reviewed the current state and there is now already icotool support in our extra-cmake-modules stuff => closing this.
@mludwig: ok with the current patch?
I think we can go with this as is.
Given we have tests for a lot of stuff, regressions shouldn't be that likely.
I will merge this, before we let that rot even more.
Thanks for the work on this, btw.!
Upsa ;) missed that this is in plasma addons, not in the session launcher applet we have in our repo, ignore my comment about the invent stuff ;=)
Btw., for Kate, we would prefer merge requests on invent.kde.org/kde/kate, but I will just apply this via arc.
Improved output seems fine for me, thanks for taking care.
Has a test, looks ok, thanks!
This is a patch for KTextEditor, that is still on phab (for good or bad ;=)
I think this is ok, accepting & merging.
Btw., for the default arguments: This is a purely internal class, therefore removing it would have been ok.
Sat, Feb 8
I guess I can trust you on the sandbox part ;=)
For Albert's question: We take a look which sessions are running in which Kate instances. If there would be a generic way to query all instances we could use this for that loop here.
Thu, Feb 6
Wed, Feb 5
Sun, Feb 2
Sat, Feb 1
Did lead to regressions, see https://bugs.kde.org/show_bug.cgi?id=412502