cullmann (Christoph Cullmann)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jul 30 2015, 8:46 PM (195 w, 1 h)
Availability
Available

Recent Activity

Yesterday

cullmann reopened D20697: Review IconBorder.

loh.tar, can you take a look?
If it is too complex to fix easily, we can still revert this and apply it again later together with a fix.
Thanks for pointing the CI fail out David!

Wed, Apr 24, 7:15 AM · Frameworks, Kate
cullmann added a comment to D20697: Review IconBorder.

:( Sorry, I didn't run them again, just tried out if it works in KDevelop.

Wed, Apr 24, 7:14 AM · Frameworks, Kate

Tue, Apr 23

cullmann accepted D20697: Review IconBorder.

This works for me fine with KDevelop.
Please commit.
Thanks

Tue, Apr 23, 7:34 PM · Frameworks, Kate
cullmann added a comment to D20697: Review IconBorder.

I am not sure one can delay the updateGeometry stuff until one paints.

Tue, Apr 23, 5:55 PM · Frameworks, Kate
cullmann requested changes to D20697: Review IconBorder.

Unfortunately, the annotation stuff regressed.
I tried KDevelop, right click on text => Git -> Annotation...
See pre-patch and post-patch pictures below, the too small one is the post patch one.


Tue, Apr 23, 5:53 PM · Frameworks, Kate
cullmann added a comment to D20766: Use appropriate background color for text previews.

I actually think the theme should contain all colors hard-coded and KTextEditor should properly use that instead of currently the mix of hardcoded/defaults.
The only automatism should be (in my eyes) to switch between a light/dark variant automatic depending on the base color of the current window.
But that is only my opinion.
I think the "we adapt to the color scheme" stuff is flawed.

Tue, Apr 23, 4:48 PM · Frameworks, Dolphin
cullmann accepted D20765: Add input methods to input method status bar button.

Good idea!

Tue, Apr 23, 10:48 AM · Frameworks, Kate
cullmann committed R40:64e1cc6bdd17: try to avoid crash during tab adding/removal (authored by cullmann).
try to avoid crash during tab adding/removal
Tue, Apr 23, 5:03 AM
cullmann closed D20722: ViewSpace: Don't ASSERT, just check for valid doc to remove from tab.
Tue, Apr 23, 5:03 AM · Kate
cullmann accepted D20722: ViewSpace: Don't ASSERT, just check for valid doc to remove from tab.

Then we try that patch in master.
I think re-shuffling the indices there is no good idea.

Tue, Apr 23, 5:00 AM · Kate

Mon, Apr 22

cullmann accepted D20742: Paint the folding marker in propper color and make it more visible .

Both diff + output change in the screenshot look reasonable for me.

Mon, Apr 22, 6:09 PM · Frameworks, Kate
cullmann committed R40:0aa7c4d383d3: Kate: Keyboard shortcuts F6/Shift+F6 for Next/Previous Match (authored by cullmann).
Kate: Keyboard shortcuts F6/Shift+F6 for Next/Previous Match
Mon, Apr 22, 5:11 PM
cullmann closed D17443: Kate: Keyboard shortcuts F6/Shift+F6 for Next/Previous Match.
Mon, Apr 22, 5:11 PM · Kate
cullmann committed R39:8193e735bca2: remove default shortcut F6 to show icon border (authored by cullmann).
remove default shortcut F6 to show icon border
Mon, Apr 22, 4:43 PM
cullmann closed D17442: KTextEditor: Tweak keyboard shortcuts to free F keys.
Mon, Apr 22, 4:43 PM · Frameworks, Kate
cullmann accepted D17443: Kate: Keyboard shortcuts F6/Shift+F6 for Next/Previous Match.

We go with the minimal needed changes.

Mon, Apr 22, 4:41 PM · Kate
cullmann accepted D17442: KTextEditor: Tweak keyboard shortcuts to free F keys.

We go with the minimal invasive effort ATM: just remove F6.
As discussed in D17443.
We can introduce the CTRL-E... stuff later.

Mon, Apr 22, 4:37 PM · Frameworks, Kate
cullmann added a comment to D20722: ViewSpace: Don't ASSERT, just check for valid doc to remove from tab.

I would propose this fix:

Mon, Apr 22, 4:29 PM · Kate
cullmann added a reviewer for D20722: ViewSpace: Don't ASSERT, just check for valid doc to remove from tab: dhaumann.

Hmm, perhaps the restore view stuff does create the issues:

Mon, Apr 22, 4:17 PM · Kate
cullmann added a comment to D20722: ViewSpace: Don't ASSERT, just check for valid doc to remove from tab.

Hmm, the internal state is really broken if that doesn't work.
I don't think this check will really solve the issue.
Had you any chance to see a backtrace with e.g. the index?

Mon, Apr 22, 4:04 PM · Kate

Fri, Apr 19

cullmann accepted D20565: Ensure not to fold the end marker.

You can submit that, perhaps with the discussed checks, thanks
And happy Easter ;=)

Fri, Apr 19, 11:31 AM · Frameworks, Kate
cullmann accepted D20606: Add action to toggle folding of child ranges.

Given we have no actions and some more proper documentation, I am in favor of this.

Fri, Apr 19, 11:31 AM · Frameworks, Kate

Wed, Apr 17

cullmann committed R40:fac21b07edf6: avoid tooltip just duplicating name of tab (authored by cullmann).
avoid tooltip just duplicating name of tab
Wed, Apr 17, 6:23 PM
cullmann requested changes to D20606: Add action to toggle folding of child ranges.

The question is: with a context menu, isn't that then already too inconvenient?
At the moment we have no context menu for the bar at all.
I could live with the right click for the moment, we can still enhance that, if we add further "actions".
But I think we need at least an action in the "Code Foldings" sub-menu that does trigger this for the current active folding region.
If that is there, more can follow in extra changes, I think.

Wed, Apr 17, 5:24 PM · Frameworks, Kate

Tue, Apr 16

cullmann closed D18996: Fix building with namespaced Qt.

The build issue got fixed.

Tue, Apr 16, 6:34 PM · Frameworks, Kate, Framework: Syntax Highlighting
cullmann added reviewers for D20606: Add action to toggle folding of child ranges: ngraham, dhaumann.

I think the feature is nice.

Tue, Apr 16, 6:21 PM · Frameworks, Kate

Mon, Apr 15

cullmann added reviewers for D20565: Ensure not to fold the end marker: dhaumann, ngraham.

I like the idea, its nice for e.g. if then else cascades, you get then out of stuff like

Mon, Apr 15, 6:26 PM · Frameworks, Kate
cullmann accepted D20542: Retitle button "Close" to "Close file" when a file has been removed on disk.
Mon, Apr 15, 3:49 AM · Frameworks, Kate

Sun, Apr 14

cullmann committed R39:893faf36662a: fix folding offset (authored by cullmann).
fix folding offset
Sun, Apr 14, 8:57 PM
cullmann added a reviewer for D20542: Retitle button "Close" to "Close file" when a file has been removed on disk: ngraham.

Perhaps Nate has feedback, too.
I have no issues with this change.

Sun, Apr 14, 5:08 PM · Frameworks, Kate
cullmann committed R40:5f0b76f2a80c: we live in a https world now (authored by cullmann).
we live in a https world now
Sun, Apr 14, 1:52 PM
cullmann added a comment to D20534: avoid conflicting shortcuts for switching tabs.

Upsa, pushed it with my copyright update :/

Sun, Apr 14, 1:50 PM · Frameworks, Kate
cullmann committed R39:59afcab3fb1b: up copy-right, perhaps that should be a define, too (authored by cullmann).
up copy-right, perhaps that should be a define, too
Sun, Apr 14, 1:49 PM
cullmann committed R39:9f2ffd36c587: avoid conflicting shortcuts for switching tabs (authored by cullmann).
avoid conflicting shortcuts for switching tabs
Sun, Apr 14, 1:49 PM
cullmann closed D20534: avoid conflicting shortcuts for switching tabs.
Sun, Apr 14, 1:49 PM · Frameworks, Kate
cullmann added a comment to D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'.

:=) Nice that it helps.

Sun, Apr 14, 1:14 PM · Frameworks, Kate
cullmann added a comment to R39:4396efe1cdce: KateIconBorder: Fix folding popup width and height.

Hmm, arc land didn't use the proper author :/
Guess I need to check that in the future more properly.

Sun, Apr 14, 12:40 PM
cullmann added reviewers for D20534: avoid conflicting shortcuts for switching tabs: Kate, ngraham, dhaumann.

Ok with that?

Sun, Apr 14, 12:39 PM · Frameworks, Kate
cullmann requested review of D20534: avoid conflicting shortcuts for switching tabs.
Sun, Apr 14, 12:38 PM · Frameworks, Kate
cullmann committed R39:4396efe1cdce: KateIconBorder: Fix folding popup width and height (authored by cullmann).
KateIconBorder: Fix folding popup width and height
Sun, Apr 14, 12:34 PM
cullmann closed D20495: KateIconBorder: Fix folding popup width and height.
Sun, Apr 14, 12:34 PM · Frameworks, Kate
cullmann accepted D20495: KateIconBorder: Fix folding popup width and height.

Works ok for me.

Sun, Apr 14, 12:34 PM · Frameworks, Kate
cullmann committed R39:a9f97f1be115: avoid view jump to bottom on folding changes (authored by cullmann).
avoid view jump to bottom on folding changes
Sun, Apr 14, 12:30 PM
cullmann added a comment to D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'.

Please try if my last commit fixed that:

Sun, Apr 14, 12:30 PM · Frameworks, Kate
cullmann added a comment to D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'.

Ok, I can reproduce the issue you mention.
I will take a look.

Sun, Apr 14, 12:18 PM · Frameworks, Kate
cullmann added a comment to D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'.

Didn't try folding :)

Sun, Apr 14, 7:45 AM · Frameworks, Kate

Sat, Apr 13

cullmann added a comment to D7497: Fix Ctrl PageUp/PageDown shortcut conflict due to KF 5.37..

Ok, that sounds like a good justification ;=)
Nate, would you be ok with this, too?

Sat, Apr 13, 9:07 PM · Kate
cullmann added a comment to D7497: Fix Ctrl PageUp/PageDown shortcut conflict due to KF 5.37..

You mean ALT-PgUp/Down, or?
Could live with moving that to ALT and the select to SHIFT-ALT.

Sat, Apr 13, 8:37 PM · Kate
cullmann added a comment to D7497: Fix Ctrl PageUp/PageDown shortcut conflict due to KF 5.37..

But as "we are all here" anyways: Any ideas for better shortcuts in KTextEditor?
We have even "ctrl + shift + pageup" to select to top of the view :P

Sat, Apr 13, 8:28 PM · Kate
cullmann accepted D19450: DocumentPrivate: Respect indention mode when block selection.
Sat, Apr 13, 5:17 PM · Frameworks, Kate
cullmann added a comment to D19450: DocumentPrivate: Respect indention mode when block selection.

Just had not looked at this.
Looks reasonable, please push that.

Sat, Apr 13, 5:14 PM · Frameworks, Kate
cullmann abandoned D17432: WIP: Add Analyzer Tool "Cppcheck (for C)".
Sat, Apr 13, 5:11 PM · Kate
cullmann commandeered D17432: WIP: Add Analyzer Tool "Cppcheck (for C)".

Please submit a new request to make the existing analysis more clever for different languages.

Sat, Apr 13, 5:11 PM · Kate
Restricted Application added a project to D7497: Fix Ctrl PageUp/PageDown shortcut conflict due to KF 5.37.: Kate.

What shall we do with this?

Sat, Apr 13, 5:10 PM · Kate
cullmann abandoned D12295: Supporting nested brackets for Kate autobrackets.
Sat, Apr 13, 5:10 PM · Frameworks, Kate, KTextEditor
cullmann commandeered D12295: Supporting nested brackets for Kate autobrackets.

We close this in favor of the other patches.

Sat, Apr 13, 5:09 PM · Frameworks, Kate, KTextEditor
cullmann accepted D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'.

5.57 released, should ne tried now.

Sat, Apr 13, 10:04 AM · Frameworks, Kate

Fri, Apr 12

cullmann added a comment to D20499: Support gzipping of svgz also on windows, using 7z.

I glanced at it, thought I have at home no Windows machine at hand to test if the command line works as planned.

Fri, Apr 12, 8:52 PM · Frameworks
cullmann added a comment to D19511: ViewPrivate: Disable read-only mode action when doc is modified.

I still think we should stay with status quo, can you drop this request?

Fri, Apr 12, 8:10 PM · Frameworks, Kate
cullmann added a comment to D15930: Add more icons to actions.

Hi, if you have no update for this, could you close the request? Thanks.

Fri, Apr 12, 8:08 PM · Falkon
cullmann requested changes to D17308: Make CTags/Projects context menu more accessible.

I reconsider, I see no real value in removing the layout beside having a more densely populated toplevel menu.
Could we close this?

Fri, Apr 12, 8:06 PM · Kate
cullmann abandoned D18090: PyFalkon build with pyside 5.12 version.
Fri, Apr 12, 8:05 PM · Falkon
cullmann commandeered D18090: PyFalkon build with pyside 5.12 version.

Please submit a new fix, if you have time.
I will close this.

Fri, Apr 12, 8:05 PM · Falkon
cullmann added a comment to D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz.

The CI is a bit unhappy with the gzip depedency on Windows.
Might one just write a minimal KArchive based gzip'er for this? gzip isn't there on any normal Windows machine, even if you have libz.

Fri, Apr 12, 8:04 PM · Frameworks
cullmann accepted D19608: DocumentPrivate: Make bracket handling smart.

Works for me, beside that the patch no longer cleanly applies.
But with some false removed and the later parts skipped, it did work as advertised.

Fri, Apr 12, 7:56 PM · Frameworks, Kate
cullmann accepted D20264: Add test for "Auto Reload Document" option.

I think this can go in as is, as long as the test works determinstically, which I assume it does.

Fri, Apr 12, 7:50 PM · Frameworks, Kate
cullmann accepted D19691: ViewInternal: Review drop event.

Played a bit here with the new behavior, MUCH better than the old one.

Fri, Apr 12, 7:46 PM · Frameworks, Kate
cullmann committed R40:45b99aa2c3ac: With Qt >= 5.10.0 use QSortFilterProxyModel instead of… (authored by ahmadsamir).
With Qt >= 5.10.0 use QSortFilterProxyModel instead of…
Fri, Apr 12, 7:41 PM
cullmann closed D20394: With Qt >= 5.10.0 use QSortFilterProxyModel instead of KRecursiveFilterProxyModel.
Fri, Apr 12, 7:41 PM · Kate
cullmann committed R216:0e2d7e61a256: Add syntax highlighting for fish shell (authored by cullmann).
Add syntax highlighting for fish shell
Fri, Apr 12, 7:39 PM
cullmann closed D20233: Add syntax highlighting for fish shell.
Fri, Apr 12, 7:39 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann committed R216:1726c4f868f6: AppArmor: don't highlight variable assignments and alias rules within profiles (authored by nibags).
AppArmor: don't highlight variable assignments and alias rules within profiles
Fri, Apr 12, 7:39 PM
cullmann closed D20221: AppArmor: don't highlight variable assignments and alias rules within profiles.
Fri, Apr 12, 7:39 PM · Frameworks, Kate
cullmann committed R39:2a0cf7044f75: Allow to close a document whose file was deleted on disk (authored by meven).
Allow to close a document whose file was deleted on disk
Fri, Apr 12, 7:38 PM
cullmann closed D20467: Allow to close a document whose file was deleted on disk.
Fri, Apr 12, 7:38 PM · Frameworks, Kate
cullmann accepted D20467: Allow to close a document whose file was deleted on disk.

I think this should go in.

Fri, Apr 12, 7:34 PM · Frameworks, Kate
cullmann added a comment to D20467: Allow to close a document whose file was deleted on disk.

The current implementation at least closes the file, in all applications.
It just doesn't remove in in all of them from the document list.
I think that is ok enough, more can't be done in KTextEditor.
Extra reviews for extending the applications are welcome.

Fri, Apr 12, 10:10 AM · Frameworks, Kate
cullmann added a comment to D20467: Allow to close a document whose file was deleted on disk.

I think the solution with the bool setting is good enough.
If nobody else disagrees, I would accept this later.

Fri, Apr 12, 8:55 AM · Frameworks, Kate
cullmann added a comment to D20467: Allow to close a document whose file was deleted on disk.

One could try to first do a closeUrl and just do the closeDocumentInApplication() in addition afterwards.

Fri, Apr 12, 8:18 AM · Frameworks, Kate
cullmann added a comment to D20467: Allow to close a document whose file was deleted on disk.

If you really want to close the document aka removing it from the application's document list, you need the interface.
If you just want to set it back to "untitled document" you can use closeUrl

Fri, Apr 12, 7:42 AM · Frameworks, Kate
cullmann added a comment to D20467: Allow to close a document whose file was deleted on disk.

That is because KWrite doesn't implement that interface function, unfortunately.

Fri, Apr 12, 7:39 AM · Frameworks, Kate

Thu, Apr 11

cullmann added reviewers for D20467: Allow to close a document whose file was deleted on disk: Kate, Frameworks.
Thu, Apr 11, 1:42 PM · Frameworks, Kate
cullmann accepted D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator.

Thanks

Thu, Apr 11, 5:34 AM · Frameworks, Kate

Wed, Apr 10

cullmann requested changes to D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator.

I think to not agonize MSVC it would be better to use the unicode code point for the QChar constructor.
After that is altered I think, too, this should go in, nice!

Wed, Apr 10, 9:44 PM · Frameworks, Kate
cullmann accepted D20233: Add syntax highlighting for fish shell.

Ok, then we keep that license and push this as is.

Wed, Apr 10, 9:00 AM · Frameworks, Framework: Syntax Highlighting, Kate

Mon, Apr 8

cullmann committed R40:aefe636289d6: Project plugin: sort the tree view case insensitively (authored by ahmadsamir).
Project plugin: sort the tree view case insensitively
Mon, Apr 8, 4:59 PM
cullmann closed D20319: Project plugin: sort the tree view case insensitively.
Mon, Apr 8, 4:59 PM · Kate
cullmann accepted D20372: [kemoticons] make it compile without foreach.

Looks reasonable.

Mon, Apr 8, 5:51 AM · Frameworks
cullmann committed R40:36b9beaa605f: improve comment (authored by cullmann).
improve comment
Mon, Apr 8, 4:59 AM
cullmann committed R40:2b6ead1d6db3: fix handling of sub modules in git rely on ls-files --recurse-submodules, there… (authored by cullmann).
fix handling of sub modules in git rely on ls-files --recurse-submodules, there…
Mon, Apr 8, 4:59 AM
cullmann added a comment to D20343: fix handling of sub modules in git rely on ls-files --recurse-submodules, there since end of 2016.

Yes, I cherry-picked the change to 19.04, will mark bug as done.

Mon, Apr 8, 4:57 AM · Kate

Sun, Apr 7

cullmann committed R954:33004e46d433: cartoonized version (authored by cullmann).
cartoonized version
Sun, Apr 7, 5:49 PM
cullmann committed R40:8911d3aa2081: improve comment (authored by cullmann).
improve comment
Sun, Apr 7, 2:21 PM
cullmann committed R40:a8ec6828ee84: fix handling of sub modules in git rely on ls-files --recurse-submodules, there… (authored by cullmann).
fix handling of sub modules in git rely on ls-files --recurse-submodules, there…
Sun, Apr 7, 2:21 PM
cullmann closed D20343: fix handling of sub modules in git rely on ls-files --recurse-submodules, there since end of 2016.
Sun, Apr 7, 2:21 PM · Kate
cullmann accepted D20221: AppArmor: don't highlight variable assignments and alias rules within profiles.

See no obvious issues, please commit, thanks!

Sun, Apr 7, 1:18 PM · Frameworks, Kate
cullmann added a comment to D20233: Add syntax highlighting for fish shell.

If you think you nearly changed everything, I guess MIT is ok.
If you think still too much is derived, I can live with LGPL ;=)
I let you decide.

Sun, Apr 7, 1:17 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann accepted D20319: Project plugin: sort the tree view case insensitively.

Guess this makes sense.

Sun, Apr 7, 1:16 PM · Kate
cullmann accepted D19446: DocumentPrivate: Support auto bracket in block selection mode.

The new functionality works ok enough for me.

Sun, Apr 7, 1:14 PM · Frameworks, Kate
cullmann added a reviewer for D20343: fix handling of sub modules in git rely on ls-files --recurse-submodules, there since end of 2016: loh.tar.
Sun, Apr 7, 11:41 AM · Kate