cullmann (Christoph Cullmann)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jul 30 2015, 8:46 PM (202 w, 2 d)
Availability
Available

Recent Activity

Today

cullmann added a comment to D17241: WIP:Disable highlighting after 512 characters on a line..
  • addConfigEntry(ConfigEntry(LineLengthLimit, "Line Length Limit", QString(), 4096));

+ addConfigEntry(ConfigEntry(LineLengthLimit, "Line Length Limit", QString(), 10000));

Sun, Jun 16, 9:12 AM · Frameworks, Kate
cullmann committed R39:4daee27406ca: raise default line length limit to 10000 (authored by cullmann).
raise default line length limit to 10000
Sun, Jun 16, 9:11 AM
cullmann committed R39:1b7a2c69e492: WIP:Disable highlighting after 512 characters on a line. (authored by cullmann).
WIP:Disable highlighting after 512 characters on a line.
Sun, Jun 16, 9:11 AM
cullmann closed D17241: WIP:Disable highlighting after 512 characters on a line..
Sun, Jun 16, 9:11 AM · Frameworks, Kate
cullmann added a comment to D17241: WIP:Disable highlighting after 512 characters on a line..

Then let's try that. Even for all cases without hitting the limit the new code is faster.

Sun, Jun 16, 9:09 AM · Frameworks, Kate

Yesterday

cullmann added a comment to D17241: WIP:Disable highlighting after 512 characters on a line..

I am not sure about the warning.
The line length limit default should be increased it think, we could just try something like 10000 for a start.
I would propose we try this without a warning and see if we get negative feedback.
Normally this should only kick in situations were before we slowed down to "unusable".
Would that be ok?

Sat, Jun 15, 9:06 PM · Frameworks, Kate

Wed, Jun 12

cullmann accepted D21712: KateModeMenuList: move to QListView.

I would say: go for it.
And thanks for taking care!

Wed, Jun 12, 6:17 PM · Frameworks, Kate

Tue, Jun 11

cullmann accepted D21400: Downgrade KDEWebKit from Tier 3 to Porting Aids.

Not that I have the most karma here, but I agree with the reasoning, dead things are dead, zombies are porting aids at best.

Tue, Jun 11, 5:21 PM · Frameworks
cullmann added a comment to D17241: WIP:Disable highlighting after 512 characters on a line..

For the outer vector, yes.

Tue, Jun 11, 10:04 AM · Frameworks, Kate
cullmann added a comment to T11064: Improve the UI for the "make the editor follow the system color scheme" feature.

Actually, before one starts to touch this for such things, I would like to have the KTextEditor stuff ported to use the "themes" as provided by KSyntaxHighlighting.

Tue, Jun 11, 5:42 AM · VDG, KTextEditor, Kate

Mon, Jun 10

cullmann added a comment to D20958: New menu of syntax highlighting in the status bar.

Coding style wise, could one change:

Mon, Jun 10, 7:56 PM · Frameworks, Kate
cullmann updated the diff for D17241: WIP:Disable highlighting after 512 characters on a line..

Remove a MASS of heap allocations.
We allocated the range on the heap and then inside we really even allocated all 16 byte KTextEditor::Range objects again on the heap.

Mon, Jun 10, 7:15 PM · Frameworks, Kate
cullmann updated the summary of D17241: WIP:Disable highlighting after 512 characters on a line..
Mon, Jun 10, 6:48 PM · Frameworks, Kate
cullmann added a comment to D17241: WIP:Disable highlighting after 512 characters on a line..

Here is my try on this.
Instead of limiting the line length, we just limit the number of attributes we are allowed to display.
That only hits stuff != selection.
e.g. for the example out of https://bugs.kde.org/show_bug.cgi?id=345775 you still see selection but not other stuff.

Mon, Jun 10, 6:47 PM · Frameworks, Kate
cullmann updated the diff for D17241: WIP:Disable highlighting after 512 characters on a line..
Mon, Jun 10, 6:45 PM · Frameworks, Kate
cullmann commandeered D17241: WIP:Disable highlighting after 512 characters on a line..

I have drafted a small limit to attributes like I proposed.

Mon, Jun 10, 6:45 PM · Frameworks, Kate
cullmann added a comment to T9577: Publish Kate in the Microsoft Store.

I played a bit around with the nightly builds from the binary factory.
Look good enough for me for normal use.
There could be some fine tunings like better styling of the status bars, but beside that, I saw no obvious issues compared to the Linux version.

Mon, Jun 10, 6:12 PM · KDE Promo, Kate, Windows
cullmann added a comment to T9577: Publish Kate in the Microsoft Store.

Hmm, somehow this got stalled :/

Mon, Jun 10, 5:52 PM · KDE Promo, Kate, Windows
cullmann committed R40:65ebef951d4e: Merge branch 'master' into lsp (authored by cullmann).
Merge branch 'master' into lsp
Mon, Jun 10, 11:13 AM
cullmann accepted D21711: Julia: update syntax and add constants keywords.

Nice, thanks.

Mon, Jun 10, 10:02 AM · Frameworks, Kate
cullmann added a comment to D21713: Fortran: implement free & fixed formats.

Nice that you take care to integrate that.

Mon, Jun 10, 9:54 AM · Frameworks, Kate

Sat, Jun 8

cullmann accepted D21409: KWrite: Implement skeleton KTextEditor::Application.

Ok for me, is a good initial start!
Thanks for the work on this.

Sat, Jun 8, 7:18 PM · Kate
cullmann added a comment to D21586: Add syntax definition for ninja build.

Perhaps we must go away from the implicit listing of the syntax files and really just add them all to the CMakeLists.txt,

Sat, Jun 8, 2:57 PM · Frameworks, Kate, Framework: Syntax Highlighting

Wed, Jun 5

cullmann accepted D21586: Add syntax definition for ninja build.

Nice, I use ninja here, cool to have!

Wed, Jun 5, 12:08 PM · Frameworks, Kate, Framework: Syntax Highlighting
cullmann requested changes to D21409: KWrite: Implement skeleton KTextEditor::Application.
Wed, Jun 5, 11:56 AM · Kate
cullmann added a comment to D21409: KWrite: Implement skeleton KTextEditor::Application.

I think as an initial version this is ok.

Wed, Jun 5, 11:56 AM · Kate

Fri, May 31

cullmann added a comment to D21411: YAML: only comments after spaces and other improvements/fixes.

Hmm, ok, anyways, this change looks ok =)
Could one adapt the theme and remove the color later?

Fri, May 31, 11:30 AM · Frameworks, Kate
cullmann accepted D21411: YAML: only comments after spaces and other improvements/fixes.

Screenshots look better!

Fri, May 31, 11:14 AM · Frameworks, Kate
cullmann accepted D21508: Jam: various improvements and fixes.

(the hard coded color was already there, therefore this doesn't block this request)

Fri, May 31, 11:11 AM · Frameworks, Kate
cullmann added a comment to D21508: Jam: various improvements and fixes.

Looks reasonable + test case, nice.
Btw., would it be possible to remove the last remaining hard coded color <itemData name="CommentTitle" defStyleNum="dsComment" color="darkorange" bold="1"/> here, too?

Fri, May 31, 11:11 AM · Frameworks, Kate

Thu, May 30

cullmann accepted D21485: Fix window activation on Windows.

Ok, seems reasonable, please push this.
Thanks for taking care of this on Windows!

Thu, May 30, 10:28 AM · Kate

Wed, May 29

cullmann committed R216:6ae1acec9ff5: fix highlighting of '\0' in C mode (authored by cullmann).
fix highlighting of '\0' in C mode
Wed, May 29, 5:06 AM
cullmann closed D21467: fix highlighting of '\0' in C mode.
Wed, May 29, 5:06 AM · Frameworks, Kate

Tue, May 28

cullmann added a comment to D19785: DocumentPrivate: Review del/backspace.

Thanks!

Tue, May 28, 6:19 PM · Frameworks, Kate
cullmann added reviewers for D21467: fix highlighting of '\0' in C mode: dhaumann, vkrause, nibags.
Tue, May 28, 6:16 PM · Frameworks, Kate
cullmann requested review of D21467: fix highlighting of '\0' in C mode.
Tue, May 28, 6:15 PM · Frameworks, Kate
cullmann added a comment to D19785: DocumentPrivate: Review del/backspace.

I ATM have no access to my compile env. here, please commit the fix.
It would be best to have some test for this, too, for future reference.

Tue, May 28, 3:28 PM · Frameworks, Kate
cullmann reopened D19785: DocumentPrivate: Review del/backspace.

See https://bugs.kde.org/show_bug.cgi?id=408016

Tue, May 28, 12:22 PM · Frameworks, Kate
cullmann added a comment to D21421: Tcsh: fix operators and keywords.

Actually the resource should be recreated on syntax file changes and be used.

Tue, May 28, 6:38 AM · Frameworks, Kate, Framework: Syntax Highlighting

Mon, May 27

cullmann added a comment to D21401: Use native dialog overwrite check.

I think this is fine then, please remove the decl. of bool KTextEditor::DocumentPrivate::checkOverwrite(QUrl u, QWidget *parent), too and push this, thanks!

Mon, May 27, 5:50 AM · Frameworks, Kate
cullmann accepted D21421: Tcsh: fix operators and keywords.

Change looks reasonable + test case => thanks, please push

Mon, May 27, 5:45 AM · Frameworks, Kate, Framework: Syntax Highlighting

Sun, May 26

cullmann accepted D21386: Hello Python: Remove semicolons from sidebar.py (E703).

My minimal Python skills say this looks ok.

Sun, May 26, 5:43 PM · Falkon
cullmann added a comment to D21409: KWrite: Implement skeleton KTextEditor::Application.

If you have the time, some proper application object should do KWrite no harm.

Sun, May 26, 5:42 PM · Kate
cullmann updated subscribers of D19254: [RFC] KateRenderer: Show tabs and space characters the smart way.

At the moment we have one combobox "Whitespaces" and one checkbox "Highlight tabulators" in "Whitespace Highlighting".

Sun, May 26, 1:45 PM · Frameworks, Kate
cullmann added a comment to D19254: [RFC] KateRenderer: Show tabs and space characters the smart way.

Ah, you mean because of the "show tabs" extra option, yeah, forgot that :/
What would be the concrete content of the combobox then?

Sun, May 26, 1:31 PM · Frameworks, Kate
cullmann closed D21412: Add action to reset font size.
Sun, May 26, 11:56 AM · Frameworks, Kate
cullmann committed R39:968af10fd4b6: Add action to reset font size (authored by kishoreg).
Add action to reset font size
Sun, May 26, 11:56 AM
cullmann added a comment to D21412: Add action to reset font size.

Thank you for providing the patch!
Helping a bit to bring it up to speed is much easier and more motivating than to start from scratch for a thing one doesn't need oneself that much.

Sun, May 26, 11:54 AM · Frameworks, Kate
cullmann added a comment to D21412: Add action to reset font size.

Btw., if should push, I would need your name + email address for the git commit, thanks.

Sun, May 26, 11:42 AM · Frameworks, Kate
cullmann accepted D21412: Add action to reset font size.

I think this look OK.
Can you commit yourself? Or shall I push for you?

Sun, May 26, 11:36 AM · Frameworks, Kate
cullmann added a comment to D19771: Use placeholder instead of label.

I think then it is a bit inconsistent.
Would it really be that confusing, given until you write your find/replace stuff inside, you have the labels?

Sun, May 26, 11:15 AM · Frameworks, Kate
cullmann added a comment to D21412: Add action to reset font size.

Could you try: KStandardShortcut::shortcut(KStandardShortcut::ActualSize)

Sun, May 26, 10:57 AM · Frameworks, Kate
cullmann accepted D19785: DocumentPrivate: Review del/backspace.
Sun, May 26, 10:38 AM · Frameworks, Kate
cullmann added a comment to D19254: [RFC] KateRenderer: Show tabs and space characters the smart way.

I think this feature is nice.
Given we already have now some enum for the show spaces stuff (None/Trailing/All) I would just vote to have some "Smart" 4th variant inside.
We can later tweak this "Smart" variant like we want it to behave, actually the "always show stuff on current line and for selections" doesn't sound that bad.

Sun, May 26, 10:36 AM · Frameworks, Kate
cullmann requested changes to D21412: Add action to reset font size.

Hi, this is a good start!

Sun, May 26, 10:30 AM · Frameworks, Kate
cullmann added a comment to D21409: KWrite: Implement skeleton KTextEditor::Application.

You are right that one needs one unique KTextEditor::Application, otherwise the semantics are bogus.
I think this patch is a good start to create one.
If you have not further time or fun to work on this, I can give it a try.

Sun, May 26, 10:24 AM · Kate

Sat, May 25

cullmann added a comment to D21401: Use native dialog overwrite check.

checkOverwrite decl. should be removed, too.

Sat, May 25, 6:25 PM · Frameworks, Kate
cullmann accepted D21401: Use native dialog overwrite check.

Sounds reasonable.

Sat, May 25, 6:23 PM · Frameworks, Kate
cullmann added a comment to D21409: KWrite: Implement skeleton KTextEditor::Application.

I think a skeleton is ok, but is quit really just close? I thought it should try to quit the app not only close one window.

Sat, May 25, 6:23 PM · Kate
cullmann accepted D21402: Avoid double overwrite check.

Ok, then lets do this.

Sat, May 25, 6:19 PM · Kate
cullmann accepted D21405: QuickOpen: Select first item on show.

Just push it.

Sat, May 25, 6:18 PM · Kate

Fri, May 24

cullmann committed R39:24fd3ca01d89: show static word wrap marker always if requested (authored by cullmann).
show static word wrap marker always if requested
Fri, May 24, 2:26 PM
cullmann closed D21380: show static word wrap marker always if requested.
Fri, May 24, 2:26 PM · Frameworks, Kate
cullmann committed R40:7ecdd0eaf94b: try a bit harder to raise window for already running application (authored by cullmann).
try a bit harder to raise window for already running application
Fri, May 24, 1:36 PM
cullmann added reviewers for D21380: show static word wrap marker always if requested: KTextEditor, Frameworks.

I think this is reasonable, if one enables this, it should be shown, people can disable it, if it doesn't look nice for their font (or alter the font).

Fri, May 24, 1:19 PM · Frameworks, Kate
cullmann requested review of D21380: show static word wrap marker always if requested.
Fri, May 24, 1:18 PM · Frameworks, Kate

Thu, May 23

cullmann accepted D21368: Add syntax definition for the Common Intermediate Language.

Why not, better bit highlighting than none.

Thu, May 23, 5:14 PM · Frameworks, Kate
cullmann accepted D20815: Ensure highlighted folding marker after unfold.

Hmm, I am fine with the change beside with the delete m_foldingPreview;, I think that is there to ensure the preview is directly hidden if one toggles a folding.
It will be later deleted by the leave of the bar but I don't think the earlier delete hurts.
Please keep that, if there is no strong reason to remove it and push that, thanks.

Thu, May 23, 1:39 PM · Frameworks, Kate

Wed, May 22

cullmann added a comment to D18295: CTRL+Q should only close current window, not all windows.

It seems nobody takes this up, shall we close it until a new proper request is submitted?

Wed, May 22, 5:01 PM · Falkon
cullmann added a comment to D19771: Use placeholder instead of label.

Hi, any more feedback on this?

Wed, May 22, 2:49 PM · Frameworks, Kate
cullmann added a comment to D20815: Ensure highlighted folding marker after unfold.

Ok, I see, I tried it a bit more and yes, now the folding start/end tokens are highlighted on unfold.
Btw., is it intentional that the folding start/end tokens are only sometimes highlighted on folding, still?

Wed, May 22, 2:48 PM · Frameworks, Kate
cullmann committed R40:39de9269add7: fix crash on CTRL-Q if quickopen is still opened (authored by cullmann).
fix crash on CTRL-Q if quickopen is still opened
Wed, May 22, 2:42 PM
cullmann committed R40:4fbe4073bb05: Fix quick open mode selection (authored by cullmann).
Fix quick open mode selection
Wed, May 22, 2:35 PM
cullmann closed D21294: Fix quick open mode selection.
Wed, May 22, 2:35 PM · Kate
cullmann closed D20959: Allow to change the Mode, after changing the Highlighting.

Ok, regression taken care of in D21331

Wed, May 22, 2:34 PM · Frameworks, Kate
cullmann added a comment to D20815: Ensure highlighted folding marker after unfold.

I must confess, I am a bit confused what this patch should improve.
Could you tell again which concrete issue it fixes?
And why is the delete not useful?

Wed, May 22, 2:33 PM · Frameworks, Kate
cullmann added a comment to D21287: Try to find always an unique visible document name without a number suffix.

I think for 2 one still needs a clever way to compute the "short" path. I think the document list tries to create shortest unique "suffixes".
For 1) to be efficient one could hash all documents with "filename" => documents with that if file names changes, that would avoid that one needs to iterate always again over all documents to collect duplicates.

Wed, May 22, 2:30 PM · Frameworks, Kate
cullmann accepted D21295: SyntaxHighlighter: Fix foreground color for text without special highlighting.

Given nobody proposes a working alternative, lets go with this.

Wed, May 22, 2:28 PM · Frameworks, Kate
cullmann accepted D21331: Fix: don't reset Highlight when saving some files.

Lets give this a try.

Wed, May 22, 9:46 AM · Frameworks, Kate

Mon, May 20

cullmann added a comment to D19367: SearchBar: Don't block GUI when enter incremental pattern.

Simple tests with an 12 million lines document (COPYING.LIB concated "a lot") show compare to the current approach usable behavior.
You start to type some word not in the document, it won't free for 10 seconds, it will just search in the background like it should.
I think the largest existing issue is IMHO the multi line stuff. Some more comments could help.

Mon, May 20, 2:06 PM · Frameworks, Kate
cullmann reopened D20959: Allow to change the Mode, after changing the Highlighting.

Hi,
could this lead to the following regression:

Mon, May 20, 1:46 PM · Frameworks, Kate
cullmann added a comment to D21280: kioslave: preserve argv[0], to fix applicationDirPath() on non-Linux.

Just out of curiosity: Does one need the exit(func(...)) call or wouldn't a return func...(); be enough?

Mon, May 20, 8:13 AM · Frameworks
cullmann added a comment to D21295: SyntaxHighlighter: Fix foreground color for text without special highlighting.

:=) You are right, without that, it might be even faster as we only do it once.

Mon, May 20, 6:06 AM · Frameworks, Kate

Sun, May 19

cullmann accepted D21294: Fix quick open mode selection.

Looks reasonable, thanks.

Sun, May 19, 7:40 PM · Kate
cullmann added a comment to D21295: SyntaxHighlighter: Fix foreground color for text without special highlighting.

I think one reason for the early out was that actually even the "isXXX" checks are very expensive, at least if I remember correctly they did show up a lot in my profiling in the past.
Perhaps one should profile this once more (and if still visible) at least skip all the isXXX checks for the isDefault... case.
Otherwise I have no issues with this.

Sun, May 19, 7:05 PM · Frameworks, Kate
cullmann accepted D21293: Markdown: Use color with higher contrast for lists.

Looks ok for me.

Sun, May 19, 4:00 PM · Frameworks, Kate
cullmann added a comment to D21287: Try to find always an unique visible document name without a number suffix.

I like the idea of having better short document names without numbers.
The algo looks a bit like what the document list tries to do with the shortest paths differentiating two files.
I think the documents stuff ignores the changed doc names as it looks for file name changes, but that might be wrong.

Sun, May 19, 1:15 PM · Frameworks, Kate
cullmann committed R39:29f1ce10e15f: remove duplicated assignment (authored by cullmann).
remove duplicated assignment
Sun, May 19, 1:06 PM
cullmann committed R39:df555c9b2e57: honor auto-bracket setting for balance check (authored by cullmann).
honor auto-bracket setting for balance check
Sun, May 19, 1:05 PM
cullmann closed D19608: DocumentPrivate: Make bracket handling smart.
Sun, May 19, 1:05 PM · Frameworks, Kate
cullmann accepted D21289: Fix: Use default indentation mode for new files.

> ok

Sun, May 19, 12:48 PM · Frameworks, Kate
cullmann added a comment to D21289: Fix: Use default indentation mode for new files.

Hmm, perhaps updateConfig would be better to not miss other stuff.

Sun, May 19, 11:50 AM · Frameworks, Kate
cullmann accepted D21288: Remove .conf extension from "INI Files" hl, to determine the highlighter using MIME type.

OK with that.

Sun, May 19, 11:41 AM · Frameworks, Kate
cullmann reopened D19608: DocumentPrivate: Make bracket handling smart.

I think moving the config check some lines up will do the trick.

Sun, May 19, 11:40 AM · Frameworks, Kate
cullmann accepted D21286: Perl: fix the // operator.

Yes, please push, thanks.

Sun, May 19, 11:38 AM · Frameworks, Kate

Sat, May 18

cullmann committed R39:e1bb897f3e53: improve invalid character check on loading don't use the ConvertInvalidToNull… (authored by cullmann).
improve invalid character check on loading don't use the ConvertInvalidToNull…
Sat, May 18, 6:43 PM
cullmann committed R216:2d8ad85ffc26: fix casing of UInt* types in Julia hl (authored by cullmann).
fix casing of UInt* types in Julia hl
Sat, May 18, 6:30 PM

May 13 2019

cullmann committed R40:d034c47da8cf: actually jump to definition (authored by cullmann).
actually jump to definition
May 13 2019, 7:46 PM

May 12 2019

cullmann committed R40:591a095d89cf: goto definition hack does return something that sometimes looks like a useful… (authored by cullmann).
goto definition hack does return something that sometimes looks like a useful…
May 12 2019, 9:36 PM
cullmann committed R40:18ee672f763f: init workspaces (authored by cullmann).
init workspaces
May 12 2019, 8:56 PM