- User Since
- Jul 30 2015, 8:46 PM (158 w, 5 d)
Given it seems nobody has time to do tests, I will merge this.
We can still remove it again but just letting rot this nice contribution in the phabricator won't help any R user.
Ok, then we just close this and wait for the next update.
Thanks for the work on that!
I don't think such a behavior change is wanted.
Better test with (a.isEmpty() && b.isEmpty()) for the special case to avoid comparing long lines again.
I needed to revert this again, as we get tests failures:
Hmm, should we not commit this state at least as is?
Or do you want to do a new request including a new state & tests?
I would be fine with just pushing this as an intermediate step, too.
As said, I agree a fix for the unsaved documents vs. no swap files problem is wanted, but a single use case is not enough to bring back the dbus overhead per document.
Mon, Aug 13
Last missing piece for KTextEditor.
IMHO makes sense and one of the last missing pieces for KTextEditor.
Does KTE only support one comment marker of each type? Then this is ok IMHO.
Yes, all others were silently discarded.
Later one should check that there is only on in the static checker.
Hi, is that change acceptable?
I would need it to continue on my other KTextEditor patches that will not work without this :=)
If there is no redundancy, I am ok with that file. The license should be stated in it explicitly, will make it later easier to understand why we can use that.
For the reference generation: after a run, you will get told that stuff diffs, e.g. you do
Hi, did you get some time to look at the remaining issues?
If they are fixed, I am happy to merge that.
Yes, and then let it run and review the results + add the reference files. That would be more than enough and we ensure with that it doesn't regress on later refactoring/bugfixes.
I will indeed blog about this. If you'd like, I can request that people specifically test it out and offer feedback.
Could you provide a test file for the autotests unit tests?
Git commit 106694b84c2baf2aa390dc17107912f0eb16f09c by Christoph Cullmann, on behalf of Miklos Marton.
Committed on 13/08/2018 at 08:21.
Pushed by cullmann into branch 'master'.
Beside the short arc confusion, the current state can go in, or?
<DetectSpaces /> is only a performance optimization, as it just skips over whitespaces before any of the costly rules are tried to match. I think that should just be added again.
Otherwise, I have no issues with this changes.
What was exactly the problem with the unit test? Having one would be nice.
Sun, Aug 12
> I think that is ok
Has tests, looks ok. Thanks!
Ok with that Volker?
I would be for merging this and later replacing with the include list stuff.
make test shall work again ;=)
:=) Perhaps I should fix the unit tests, too.
I think later we should check for not more than one marker per type in the files, but otherwise that is ok for me now.
I would like a
Looks ok, should I push that for you as "Jeffrey Arnold <email@example.com>"?
Thanks for the contribution.
I think the version=... should just be an integer, just increment it by one.
Beside that, it would be very nice to have some test file in the autotests folder like for other languages for this with the new features you cover (at least some parts would already be nice).
Fixes translation + code editor example.
No special handling needed there (+ fix for section without name)
This should not hurt ;=)