cullmann (Christoph Cullmann)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jul 30 2015, 8:46 PM (158 w, 5 d)
Availability
Available

Recent Activity

Today

cullmann committed R39:45180eacbf53: fix overpainting for _ or letters like j in the last line that was already… (authored by cullmann).
fix overpainting for _ or letters like j in the last line that was already…
Wed, Aug 15, 9:25 AM

Yesterday

cullmann committed R39:72c51e15659f: Extend Scripting API to allow executing commands (authored by dhaumann).
Extend Scripting API to allow executing commands
Tue, Aug 14, 9:55 PM
cullmann closed D9247: Extend Scripting API to allow executing commands.
Tue, Aug 14, 9:55 PM · Frameworks, Kate
cullmann committed R39:467cf37fd04f: Indentation script for R (authored by cullmann).
Indentation script for R
Tue, Aug 14, 9:52 PM
cullmann closed D12587: Indentation script for R.
Tue, Aug 14, 9:52 PM · Frameworks, Kate
cullmann accepted D12587: Indentation script for R.
Tue, Aug 14, 9:50 PM · Frameworks, Kate
cullmann added a comment to D12587: Indentation script for R.

Given it seems nobody has time to do tests, I will merge this.
We can still remove it again but just letting rot this nice contribution in the phabricator won't help any R user.

Tue, Aug 14, 9:50 PM · Frameworks, Kate
cullmann closed D7245: Improve reStructuredText highlighting.

Ok, then we just close this and wait for the next update.
Thanks for the work on that!

Tue, Aug 14, 9:39 PM · Frameworks
cullmann abandoned D12768: Allow wrapping selection off top/bottom of autocomplete results.
Tue, Aug 14, 9:30 PM · KTextEditor, Frameworks, Kate
cullmann commandeered D12768: Allow wrapping selection off top/bottom of autocomplete results.

I don't think such a behavior change is wanted.

Tue, Aug 14, 9:30 PM · KTextEditor, Frameworks, Kate
cullmann committed R40:d7b19c5abffc: turn on line numbers and line modifications per default for Kate (authored by cullmann).
turn on line numbers and line modifications per default for Kate
Tue, Aug 14, 8:52 PM
cullmann closed D11838: Turn on line numbers by default.
Tue, Aug 14, 8:52 PM · Frameworks, Kate
cullmann accepted D14847: Fix crash when replacing \n around empty lines.
Tue, Aug 14, 4:24 PM · Frameworks, Kate
cullmann requested changes to D14847: Fix crash when replacing \n around empty lines.

Better test with (a.isEmpty() && b.isEmpty()) for the special case to avoid comparing long lines again.

Tue, Aug 14, 4:22 PM · Frameworks, Kate
cullmann accepted D14847: Fix crash when replacing \n around empty lines.

Ok :P

Tue, Aug 14, 4:21 PM · Frameworks, Kate
cullmann added a reviewer for D5803: ContextBrowserPlugin: fix using selection foreground for search highlights: brauch.
Tue, Aug 14, 3:55 PM
cullmann committed R216:0df450d8b9a1: remove the no longer supported configuration part of the spellchecking that… (authored by cullmann).
remove the no longer supported configuration part of the spellchecking that…
Tue, Aug 14, 3:48 PM
cullmann accepted D9247: Extend Scripting API to allow executing commands.
Tue, Aug 14, 3:37 PM · Frameworks, Kate
cullmann committed R216:0a39f67256b3: Add syntax highlighting support for Stan (authored by cullmann).
Add syntax highlighting support for Stan
Tue, Aug 14, 3:31 PM
cullmann closed D13940: Add syntax highlighting support for Stan.
Tue, Aug 14, 3:31 PM · Kate, Frameworks
cullmann requested changes to D14274: Modelines: add byte-order-mark & small fixes.
Tue, Aug 14, 3:17 PM · Frameworks, Kate
cullmann reopened D14274: Modelines: add byte-order-mark & small fixes.

I needed to revert this again, as we get tests failures:

Tue, Aug 14, 3:16 PM · Frameworks, Kate
cullmann committed R216:c721c9f22e0a: Revert "Modelines: add byte-order-mark & small fixes" (authored by cullmann).
Revert "Modelines: add byte-order-mark & small fixes"
Tue, Aug 14, 3:15 PM
cullmann added a reverting change for R216:bffb66cb3ed8: Modelines: add byte-order-mark & small fixes: R216:c721c9f22e0a: Revert "Modelines: add byte-order-mark & small fixes".
Tue, Aug 14, 3:15 PM
cullmann committed R216:1efdfc427c3c: add back indenter (authored by cullmann).
add back indenter
Tue, Aug 14, 3:10 PM
cullmann committed R216:43396e0a9773: Optimize many syntax highlighting files and fix the '/' char of SQL (authored by cullmann).
Optimize many syntax highlighting files and fix the '/' char of SQL
Tue, Aug 14, 3:07 PM
cullmann closed D11543: Optimize many syntax highlighting files and fix the '/' char of SQL.
Tue, Aug 14, 3:07 PM · Kate, Framework: Syntax Highlighting, Frameworks
cullmann committed R216:bffb66cb3ed8: Modelines: add byte-order-mark & small fixes (authored by nibags).
Modelines: add byte-order-mark & small fixes
Tue, Aug 14, 2:55 PM
cullmann closed D14274: Modelines: add byte-order-mark & small fixes.
Tue, Aug 14, 2:55 PM · Frameworks, Kate
cullmann added a reviewer for D12295: Supporting nested brackets for Kate autobrackets: brauch.
Tue, Aug 14, 2:40 PM · Frameworks, Kate, KTextEditor
cullmann updated subscribers of D12295: Supporting nested brackets for Kate autobrackets.
Tue, Aug 14, 2:40 PM · Frameworks, Kate, KTextEditor
Restricted Application added a project to D4234: Change algorithm for autobrace.: Kate.
Tue, Aug 14, 2:38 PM · Kate, Frameworks
cullmann added a comment to D7245: Improve reStructuredText highlighting.

Hmm, should we not commit this state at least as is?
Or do you want to do a new request including a new state & tests?
I would be fine with just pushing this as an intermediate step, too.

Tue, Aug 14, 2:31 PM · Frameworks
cullmann accepted D7245: Improve reStructuredText highlighting.
Tue, Aug 14, 1:30 PM · Frameworks
cullmann abandoned D10587: Restore KTextEditor Document Dbus bindings.
Tue, Aug 14, 1:22 PM · Frameworks, Kate, KTextEditor
cullmann commandeered D10587: Restore KTextEditor Document Dbus bindings.

As said, I agree a fix for the unsaved documents vs. no swap files problem is wanted, but a single use case is not enough to bring back the dbus overhead per document.

Tue, Aug 14, 1:22 PM · Frameworks, Kate, KTextEditor
cullmann committed R39:e9fa535dadc8: move from QList to QVector in more places (authored by cullmann).
move from QList to QVector in more places
Tue, Aug 14, 1:18 PM
cullmann committed R39:809475927268: move from QList to QVector and use the new Qt API using that (authored by cullmann).
move from QList to QVector and use the new Qt API using that
Tue, Aug 14, 1:01 PM
cullmann closed D14828: remove highlighting download dialog.
Tue, Aug 14, 12:44 PM · Frameworks, Kate
cullmann committed R39:705f8e0419c4: remove highlighting download dialog (authored by cullmann).
remove highlighting download dialog
Tue, Aug 14, 12:44 PM
cullmann requested review of D14828: remove highlighting download dialog.
Tue, Aug 14, 12:30 PM · Frameworks, Kate
cullmann committed R39:e1ce198d7786: no need to new/delete hash on each doHighlight, clearing it is good enough (authored by cullmann).
no need to new/delete hash on each doHighlight, clearing it is good enough
Tue, Aug 14, 11:58 AM
cullmann committed R39:3d83dc6426f4: ensure we can handle invalid attribute indices that can happen as left overs… (authored by cullmann).
ensure we can handle invalid attribute indices that can happen as left overs…
Tue, Aug 14, 11:45 AM
cullmann accepted D14824: Relicense modelines.xml to MIT license.
Tue, Aug 14, 11:43 AM · Frameworks, Kate
cullmann committed R39:72747d4aa140: cleanup includes (authored by cullmann).
cleanup includes
Tue, Aug 14, 10:11 AM
cullmann committed R39:2a3f85634ba2: let smart pointer handle deletion of objects, less manual stuff to do (authored by cullmann).
let smart pointer handle deletion of objects, less manual stuff to do
Tue, Aug 14, 10:07 AM
cullmann committed R39:0568b82768f5: remove map to lookup additional hl properties (authored by cullmann).
remove map to lookup additional hl properties
Tue, Aug 14, 8:52 AM

Mon, Aug 13

cullmann committed R39:4f26542c9a2e: integrate syntax-highlighting branch in master (authored by cullmann).
integrate syntax-highlighting branch in master
Mon, Aug 13, 8:53 PM
cullmann committed R39:f9739095b76b: Merge branch 'master' into syntax-highlighting (authored by cullmann).
Merge branch 'master' into syntax-highlighting
Mon, Aug 13, 8:51 PM
cullmann committed R39:364ad6f578a0: use character encodings as provided by the definitions (authored by cullmann).
use character encodings as provided by the definitions
Mon, Aug 13, 8:51 PM
cullmann accepted D14808: Add QVector<QPair<QChar, QString>> Definition::characterEncodings() const.

Last missing piece for KTextEditor.

Mon, Aug 13, 8:34 PM · Frameworks, Kate
cullmann committed R39:2a9c2a28064f: fix non-bold attributes to not have thin text (authored by cullmann).
fix non-bold attributes to not have thin text
Mon, Aug 13, 8:33 PM
cullmann committed R39:35d7e8065138: fix non-bold attributes to not have thin text (authored by cullmann).
fix non-bold attributes to not have thin text
Mon, Aug 13, 8:32 PM
cullmann committed R39:ff370854c835: use foldingEnabled (authored by cullmann).
use foldingEnabled
Mon, Aug 13, 7:37 PM
cullmann accepted D14799: Add bool Definition::foldingEnabled() const.

IMHO makes sense and one of the last missing pieces for KTextEditor.

Mon, Aug 13, 6:58 PM · Frameworks, Kate
cullmann committed R39:71e461d9cb29: keep old shortcut to do nothing (authored by cullmann).
keep old shortcut to do nothing
Mon, Aug 13, 4:04 PM
cullmann committed R39:d6e5c895da66: remove EncodedCharaterInsertionPolicy (authored by cullmann).
remove EncodedCharaterInsertionPolicy
Mon, Aug 13, 4:02 PM
cullmann committed R39:12a192d20013: remove more no longer used stuff (authored by cullmann).
remove more no longer used stuff
Mon, Aug 13, 3:47 PM
cullmann committed R39:f7ea0e78a879: remove more unused things (authored by cullmann).
remove more unused things
Mon, Aug 13, 2:52 PM
cullmann committed R39:bbac2bdc87d3: remove not used things (authored by cullmann).
remove not used things
Mon, Aug 13, 2:28 PM
cullmann committed R39:fd674be9d0e1: remove not used things (authored by cullmann).
remove not used things
Mon, Aug 13, 2:21 PM
cullmann committed R39:090f995092d9: cleanup (authored by cullmann).
cleanup
Mon, Aug 13, 1:55 PM
cullmann committed R39:1e47e11351dd: remove more old API in favour of using the repository directly (authored by cullmann).
remove more old API in favour of using the repository directly
Mon, Aug 13, 1:49 PM
cullmann committed R39:2d111fe7a4ac: less workaround for None (authored by cullmann).
less workaround for None
Mon, Aug 13, 9:52 AM
cullmann committed R39:1d052ca9da77: Merge branch 'master' into syntax-highlighting (authored by cullmann).
Merge branch 'master' into syntax-highlighting
Mon, Aug 13, 9:41 AM
cullmann committed R39:d83013959c08: let syntax-highlighting framework handle all definition management now that… (authored by cullmann).
let syntax-highlighting framework handle all definition management now that…
Mon, Aug 13, 9:40 AM
cullmann committed R216:6166da7503e6: Add "None" highlighting to repository per default (authored by cullmann).
Add "None" highlighting to repository per default
Mon, Aug 13, 9:39 AM
cullmann closed D14762: Proposal: Add "None" highlighting to repository per default.
Mon, Aug 13, 9:39 AM · Frameworks, Kate
cullmann added a comment to D14763: Definition: Expose command markers.

Does KTE only support one comment marker of each type? Then this is ok IMHO.

Yes, all others were silently discarded.
Later one should check that there is only on in the static checker.

Mon, Aug 13, 9:32 AM · Frameworks, Kate
cullmann added a comment to D14762: Proposal: Add "None" highlighting to repository per default.

Hi, is that change acceptable?
I would need it to continue on my other KTextEditor patches that will not work without this :=)

Mon, Aug 13, 9:21 AM · Frameworks, Kate
cullmann accepted D14593: Update Logtalk language syntax support.
Mon, Aug 13, 9:12 AM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann added a comment to D14593: Update Logtalk language syntax support.

If there is no redundancy, I am ok with that file. The license should be stated in it explicitly, will make it later easier to understand why we can use that.
For the reference generation: after a run, you will get told that stuff diffs, e.g. you do

Mon, Aug 13, 8:53 AM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann added a comment to D7909: Add syntax support for Crystal Programming Language.

Hi, did you get some time to look at the remaining issues?
If they are fixed, I am happy to merge that.

Mon, Aug 13, 8:44 AM · Kate, Frameworks, Framework: Syntax Highlighting
cullmann added a comment to D14593: Update Logtalk language syntax support.

Yes, and then let it run and review the results + add the reference files. That would be more than enough and we ensure with that it doesn't regress on later refactoring/bugfixes.
Thanks!

Mon, Aug 13, 8:31 AM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann added a comment to D14758: use view lines for wheel scrolling, not real lines.

I will indeed blog about this. If you'd like, I can request that people specifically test it out and offer feedback.

Mon, Aug 13, 8:25 AM · Frameworks, Kate
cullmann added a comment to D14593: Update Logtalk language syntax support.

Could you provide a test file for the autotests unit tests?

Mon, Aug 13, 8:24 AM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann closed D14275: Add Autodesk EAGLE sch and brd file format to the XML category.

Git commit 106694b84c2baf2aa390dc17107912f0eb16f09c by Christoph Cullmann, on behalf of Miklos Marton.
Committed on 13/08/2018 at 08:21.
Pushed by cullmann into branch 'master'.

Mon, Aug 13, 8:22 AM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann committed R216:106694b84c2b: Add Autodesk EAGLE sch and brd file format to the XML category (authored by martonmiklos).
Add Autodesk EAGLE sch and brd file format to the XML category
Mon, Aug 13, 8:22 AM
cullmann accepted D14274: Modelines: add byte-order-mark & small fixes.

OK, thanks.

Mon, Aug 13, 7:45 AM · Frameworks, Kate
cullmann committed R39:29c7233cde22: remove syntax test, that is now tested in the syntax-highlighting framework… (authored by cullmann).
remove syntax test, that is now tested in the syntax-highlighting framework…
Mon, Aug 13, 6:39 AM
cullmann accepted D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle).

Beside the short arc confusion, the current state can go in, or?

Mon, Aug 13, 6:16 AM · Kate, Frameworks
cullmann requested changes to D14274: Modelines: add byte-order-mark & small fixes.

<DetectSpaces /> is only a performance optimization, as it just skips over whitespaces before any of the costly rules are tried to match. I think that should just be added again.
Otherwise, I have no issues with this changes.
What was exactly the problem with the unit test? Having one would be nice.

Mon, Aug 13, 6:13 AM · Frameworks, Kate

Sun, Aug 12

cullmann committed R39:7a7b2f02f89f: store KTextEditor configuration in the application config object (authored by cullmann).
store KTextEditor configuration in the application config object
Sun, Aug 12, 9:45 PM
cullmann committed R39:b87ac2736304: Merge branch 'syntax-highlighting' of git://anongit.kde.org/ktexteditor into… (authored by cullmann).
Merge branch 'syntax-highlighting' of git://anongit.kde.org/ktexteditor into…
Sun, Aug 12, 9:43 PM
cullmann committed R39:7bc88de8f64e: store KTextEditor configuration in the application config object (authored by cullmann).
store KTextEditor configuration in the application config object
Sun, Aug 12, 9:43 PM
cullmann accepted D14763: Definition: Expose command markers.

> I think that is ok

Sun, Aug 12, 9:13 PM · Frameworks, Kate
cullmann accepted D14526: AppArmor: update syntax and various improvements/fixes.

Has tests, looks ok. Thanks!

Sun, Aug 12, 4:36 PM · Frameworks, Kate
cullmann added a comment to D14763: Definition: Expose command markers.

Ok with that Volker?

Sun, Aug 12, 4:30 PM · Frameworks, Kate
cullmann accepted D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting.

I would be for merging this and later replacing with the include list stuff.

Sun, Aug 12, 2:39 PM · Frameworks, Kate
cullmann accepted D14702: Java: add binaries & hex-float, and support underscores in numbers.

Looks reasonable.

Sun, Aug 12, 2:35 PM · Frameworks, Kate
cullmann updated the diff for D14762: Proposal: Add "None" highlighting to repository per default.

make test shall work again ;=)

Sun, Aug 12, 1:53 PM · Frameworks, Kate
cullmann added a comment to D14762: Proposal: Add "None" highlighting to repository per default.

:=) Perhaps I should fix the unit tests, too.

Sun, Aug 12, 1:34 PM · Frameworks, Kate
cullmann added a comment to D14763: Definition: Expose command markers.

I think later we should check for not more than one marker per type in the files, but otherwise that is ok for me now.

Sun, Aug 12, 1:12 PM · Frameworks, Kate
cullmann added a comment to D14632: keyword rule: Spport for keywords inclusion from another language/file.

I would like a

Sun, Aug 12, 12:52 PM · Frameworks, Kate
cullmann accepted D13940: Add syntax highlighting support for Stan.

Looks ok, should I push that for you as "Jeffrey Arnold <jeffrey.anold@gmail.com>"?

Sun, Aug 12, 12:47 PM · Kate, Frameworks
cullmann requested changes to D14593: Update Logtalk language syntax support.

Thanks for the contribution.
I think the version=... should just be an integer, just increment it by one.
Beside that, it would be very nice to have some test file in the autotests folder like for other languages for this with the new features you cover (at least some parts would already be nice).

Sun, Aug 12, 12:45 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann updated the diff for D14762: Proposal: Add "None" highlighting to repository per default.

Fixes translation + code editor example.
No special handling needed there (+ fix for section without name)

Sun, Aug 12, 12:36 PM · Frameworks, Kate
cullmann accepted D14761: quickopen: optimize: remove model from SortFilter proxy model during populate.

This should not hurt ;=)

Sun, Aug 12, 11:46 AM · Kate
cullmann committed R40:cdb3da47ccda: Support activities when opening files (authored by sscalabrino).
Support activities when opening files
Sun, Aug 12, 11:43 AM
cullmann closed D13826: Support activities when opening files.
Sun, Aug 12, 11:43 AM · Kate