cullmann (Christoph Cullmann)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jul 30 2015, 8:46 PM (211 w, 6 d)
Availability
Available

Recent Activity

Today

cullmann added a comment to D23348: force applicationDirPath into first position when finding plugins.

;=) Yeah, all ugly.
Even with the above code btw. an uninstalled Kate would still not find the plugins as it wants them in some "ktexteditor" subdir in plugins but with the current CMake setup they will end in the build directory in directly the same dir as the application executable.

Thu, Aug 22, 2:32 PM · Frameworks
cullmann added a comment to D23348: force applicationDirPath into first position when finding plugins.

Yes, I have some review request that does something similar inside Kate and I am not sure that this would help us either.

Thu, Aug 22, 2:03 PM · Frameworks
cullmann added a comment to D23348: force applicationDirPath into first position when finding plugins.

Hmm, I don't think this is a good thing to do.

Thu, Aug 22, 1:49 PM · Frameworks

Tue, Aug 20

cullmann committed R40:231d52d63944: import 1:1 the Qt coding style .clang-format (authored by cullmann).
import 1:1 the Qt coding style .clang-format
Tue, Aug 20, 5:13 PM
cullmann committed R40:7954dcf395fd: Merge branch 'clang-format' into 'master' (authored by cullmann).
Merge branch 'clang-format' into 'master'
Tue, Aug 20, 5:10 PM
cullmann committed R40:b759967d8348: Update .clang-format to Qt .clang-format. (authored by daandemeyer).
Update .clang-format to Qt .clang-format.
Tue, Aug 20, 5:10 PM
cullmann committed R40:7109e5a69b98: Merge branch 'buildplugin-enhancements' into 'master' (authored by cullmann).
Merge branch 'buildplugin-enhancements' into 'master'
Tue, Aug 20, 6:53 AM

Mon, Aug 19

cullmann added a comment to D22805: set autorcc and autouic by default.

Yep, KTextEditor is broken for me, too.

Mon, Aug 19, 1:52 PM · Build System, Frameworks
cullmann committed R40:af7118726998: Revert "use non-deprecated variant of setNewStartupId" (authored by cullmann).
Revert "use non-deprecated variant of setNewStartupId"
Mon, Aug 19, 1:19 PM
cullmann added a reverting change for R40:b98dfc3b61b0: use non-deprecated variant of setNewStartupId: R40:af7118726998: Revert "use non-deprecated variant of setNewStartupId".
Mon, Aug 19, 1:19 PM
cullmann added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

We want to do the same for Kate ;=)
See https://invent.kde.org/kde/kate/merge_requests/7

Mon, Aug 19, 10:57 AM
cullmann committed R40:de2370c7d66e: remove unused captured variable (authored by cullmann).
remove unused captured variable
Mon, Aug 19, 7:19 AM
cullmann committed R40:9a89195e32a7: fix stop button of search and replace plugin (authored by cullmann).
fix stop button of search and replace plugin
Mon, Aug 19, 7:19 AM
cullmann committed R40:0e6d32562ee1: remove unused member (authored by cullmann).
remove unused member
Mon, Aug 19, 7:19 AM
cullmann committed R40:b98dfc3b61b0: use non-deprecated variant of setNewStartupId (authored by cullmann).
use non-deprecated variant of setNewStartupId
Mon, Aug 19, 7:19 AM
cullmann committed R40:5a2c14c3e0b6: fix stop button of search and replace plugin (authored by cullmann).
fix stop button of search and replace plugin
Mon, Aug 19, 7:19 AM

Sun, Aug 18

cullmann committed R39:066004396d57: fix vi mode unit test (authored by cullmann).
fix vi mode unit test
Sun, Aug 18, 10:22 AM
cullmann closed D23225: Allow 0 in line ranges in vim mode..
Sun, Aug 18, 10:22 AM · Frameworks, Kate

Sat, Aug 17

cullmann added a comment to D23225: Allow 0 in line ranges in vim mode..

Jonathan, could you take a look? Thanks.

Sat, Aug 17, 9:56 PM · Frameworks, Kate
cullmann reopened D23225: Allow 0 in line ranges in vim mode..
Sat, Aug 17, 9:56 PM · Frameworks, Kate
cullmann committed R39:622bd6c94803: Allow 0 in line ranges in vim mode. (authored by verner).
Allow 0 in line ranges in vim mode.
Sat, Aug 17, 7:57 PM
cullmann closed D23225: Allow 0 in line ranges in vim mode..
Sat, Aug 17, 7:56 PM · Frameworks, Kate
cullmann accepted D23225: Allow 0 in line ranges in vim mode..

Seems reasonable, thanks for taking care ;=)

Sat, Aug 17, 7:55 PM · Frameworks, Kate
cullmann committed R40:0ca498062d12: fix KateSessionsActionTest (authored by cullmann).
fix KateSessionsActionTest
Sat, Aug 17, 3:49 PM
cullmann committed R40:fcdf0224728f: fix KateSessionManagerTest (authored by cullmann).
fix KateSessionManagerTest
Sat, Aug 17, 3:48 PM
cullmann added a reviewer for D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859): dfaure.

Could somebody try this?
Unfortunately, neither with or without this patch I can get all kio unit tests running here properly :(

Sat, Aug 17, 3:28 PM · Frameworks
cullmann updated the diff for D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859).

Instead of changing the search paths, alter the kioslave binary name to "kioslave5" to avoid clashs with old variants.

Sat, Aug 17, 3:27 PM · Frameworks
cullmann commandeered D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859).
Sat, Aug 17, 3:11 PM · Frameworks
cullmann committed R216:635cb83670f9: Use CMake find_dependency in CMake config file instead of find_package (authored by cullmann).
Use CMake find_dependency in CMake config file instead of find_package
Sat, Aug 17, 2:51 PM
cullmann closed D23208: Use CMake find_dependency in CMake config file instead of find_package.
Sat, Aug 17, 2:51 PM · Frameworks, Kate, Framework: Syntax Highlighting
cullmann committed R39:d55e0120fdc3: Use CMake find_dependency instead of find_package in CMake config file template. (authored by cullmann).
Use CMake find_dependency instead of find_package in CMake config file template.
Sat, Aug 17, 2:50 PM
cullmann closed D23203: Use CMake find_dependency instead of find_package in CMake config file template..
Sat, Aug 17, 2:50 PM · Frameworks, KTextEditor, Kate
cullmann closed D23195: SCSS: fix interpolation (#{...}) and add the Interpolation color.
Sat, Aug 17, 2:50 PM · Frameworks, Kate
cullmann committed R216:624ba8b98dbc: SCSS: fix interpolation (#{...}) and add the Interpolation color (authored by jpoelen).
SCSS: fix interpolation (#{...}) and add the Interpolation color
Sat, Aug 17, 2:50 PM
cullmann accepted D23195: SCSS: fix interpolation (#{...}) and add the Interpolation color.

Thanks, let's merge that.

Sat, Aug 17, 2:47 PM · Frameworks, Kate

Fri, Aug 16

cullmann committed R40:d924f7effc10: Merge branch 'main-cmake-cleanup' into 'master' (authored by cullmann).
Merge branch 'main-cmake-cleanup' into 'master'
Fri, Aug 16, 3:56 PM
cullmann committed R40:db6340941a58: Merge branch 'main-cmake-cleanup' into 'master' (authored by cullmann).
Merge branch 'main-cmake-cleanup' into 'master'
Fri, Aug 16, 3:05 PM
cullmann committed R40:65ae3c289fe4: Merge branch 'addons-cmake-cleanup' into 'master' (authored by cullmann).
Merge branch 'addons-cmake-cleanup' into 'master'
Fri, Aug 16, 10:42 AM

Thu, Aug 15

cullmann added a reviewer for D23190: [take over] Add helpful buttons (mainly) for the Regular Expressions switch: gregormi.
Thu, Aug 15, 6:45 PM · Kate
cullmann abandoned D18083: Search plugin: Add helpful buttons (mainly) for the Regular Expressions switch.
Thu, Aug 15, 6:45 PM · Kate
cullmann commandeered D18083: Search plugin: Add helpful buttons (mainly) for the Regular Expressions switch.

Will be finalized in D23190

Thu, Aug 15, 6:45 PM · Kate
cullmann added a reviewer for D23190: [take over] Add helpful buttons (mainly) for the Regular Expressions switch: ngraham.

Perhaps Nate has some hints for the proper tooltip content.

Thu, Aug 15, 6:44 PM · Kate
cullmann added a comment to D23135: Gettext: fix "previous untranslated string" and other improvements/fixes.

If the highlighting still is OK after removing them, sure, but it looks like the language wanted explicitly have different colors for stuff using the same default style. Perhaps one could use some of the new default styles in some places.
And I would always update the version, to allow people to update properly.

Thu, Aug 15, 6:41 PM · Frameworks, Kate
cullmann closed D23134: fix additionalDeliminator attribute.
Thu, Aug 15, 6:37 PM · Frameworks, Kate
cullmann committed R216:ff06ba217e40: fix additionalDeliminator attribute (authored by jpoelen).
fix additionalDeliminator attribute
Thu, Aug 15, 6:37 PM
cullmann accepted D23134: fix additionalDeliminator attribute.

Thanks for the test.
With git diff -w the patch looks fine.

Thu, Aug 15, 6:37 PM · Frameworks, Kate
cullmann closed D23137: C++: contracts are not in C++20.
Thu, Aug 15, 6:35 PM · Frameworks, Kate
cullmann committed R216:f42b6130397e: C++: contracts are not in C++20 (authored by jpoelen).
C++: contracts are not in C++20
Thu, Aug 15, 6:35 PM
cullmann accepted D23137: C++: contracts are not in C++20.

I agree with this.
It wasn't accepted for C++20, we can add it with the right syntax after it got into the next standard.

Thu, Aug 15, 6:34 PM · Frameworks, Kate
cullmann added a comment to D14632: keyword rule: Spport for keywords inclusion from another language/file.

I think the current way we handle that is OK.
If people start to include keywords between "incompatible" languages, any chosen direction is not really desirable.
If somebody has time, for sure it makes sense to document the current status quo.

Thu, Aug 15, 6:33 PM · Frameworks, Kate
cullmann closed T9771: Main context can be #poped as Resolved.

Think this is closed then.

Thu, Aug 15, 6:29 PM · Framework: Syntax Highlighting
cullmann added a comment to D23190: [take over] Add helpful buttons (mainly) for the Regular Expressions switch.

Hi,
thanks for taking care of this!

Thu, Aug 15, 6:13 PM · Kate
cullmann committed R216:b65c28ceda6c: Gettext: fix "previous untranslated string" and other improvements/fixes (authored by jpoelen).
Gettext: fix "previous untranslated string" and other improvements/fixes
Thu, Aug 15, 8:17 AM
cullmann closed D23135: Gettext: fix "previous untranslated string" and other improvements/fixes.
Thu, Aug 15, 8:14 AM · Frameworks, Kate

Wed, Aug 14

cullmann committed R216:1f5f6172e88d: Jam: Fix local with variable without initilisation and highlight SubRule (authored by jpoelen).
Jam: Fix local with variable without initilisation and highlight SubRule
Wed, Aug 14, 4:56 AM
cullmann closed D23136: Jam: Fix local with variable without initilisation and highlight SubRule.
Wed, Aug 14, 4:56 AM · Frameworks, Kate
cullmann accepted D23136: Jam: Fix local with variable without initilisation and highlight SubRule.

Testcase looks ok, there we go ;=)

Wed, Aug 14, 4:54 AM · Frameworks, Kate

Tue, Aug 13

cullmann added a comment to D18083: Search plugin: Add helpful buttons (mainly) for the Regular Expressions switch.

Should someone else take over? I agree that it's a very nice addition.

Tue, Aug 13, 8:59 PM · Kate
cullmann abandoned D17137: KTextEditor: File menu: Put Save, Print and Export in submenus.
Tue, Aug 13, 8:58 PM · Frameworks, Kate
cullmann commandeered D17137: KTextEditor: File menu: Put Save, Print and Export in submenus.

I think we need to start here from scratch.
Gregor, if you have some time again, open a new request please!

Tue, Aug 13, 8:58 PM · Frameworks, Kate
cullmann abandoned D17138: Kate: File menu: Put Save, Print and Export actions into submenus.
Tue, Aug 13, 8:58 PM · Kate
cullmann commandeered D17138: Kate: File menu: Put Save, Print and Export actions into submenus.

I think we need to start here from scratch.
Gregor, if you have some time again, open a new request please!

Tue, Aug 13, 8:58 PM · Kate
cullmann committed R40:6a125835fa23: ensure m_dataChanged is false after dialog creation (authored by cullmann).
ensure m_dataChanged is false after dialog creation
Tue, Aug 13, 8:56 PM
cullmann committed R40:6f9dc51b229a: Prompt user to save or discard changes (authored by shubham).
Prompt user to save or discard changes
Tue, Aug 13, 8:55 PM
cullmann closed D22479: Prompt user to save or discard changes.
Tue, Aug 13, 8:55 PM · Kate
cullmann accepted D22479: Prompt user to save or discard changes.

Given the code is trivial (a message box with two sentences) I assume we can merge this disregarding gpl/lgpl.

Tue, Aug 13, 8:54 PM · Kate
cullmann committed R216:c885eaa69d73: implicit fallthough if there is fallthoughContext (authored by jpoelen).
implicit fallthough if there is fallthoughContext
Tue, Aug 13, 8:46 PM
cullmann closed D23034: implicit fallthough if there is fallthoughContext.
Tue, Aug 13, 8:45 PM · Frameworks, Kate
cullmann accepted D23034: implicit fallthough if there is fallthoughContext.
Tue, Aug 13, 8:45 PM · Frameworks, Kate
cullmann added a comment to D23034: implicit fallthough if there is fallthoughContext.

Some whitespace stuff, git diff -w looks OK.

Tue, Aug 13, 8:43 PM · Frameworks, Kate
cullmann committed R216:5e090cc26e76: restore right file paths (authored by cullmann).
restore right file paths
Tue, Aug 13, 8:33 PM
cullmann committed R216:6d158a96bbb1: Add common GLSL file extensions (.vs, .gs, .fs) (authored by smokris).
Add common GLSL file extensions (.vs, .gs, .fs)
Tue, Aug 13, 8:24 PM
cullmann closed D22662: Add common GLSL file extensions (.vs, .gs, .fs).
Tue, Aug 13, 8:24 PM · Frameworks, Kate
cullmann added a comment to D22662: Add common GLSL file extensions (.vs, .gs, .fs).

If you pass me name + email, will push it.

Tue, Aug 13, 8:19 PM · Frameworks, Kate
cullmann accepted D22662: Add common GLSL file extensions (.vs, .gs, .fs).

Sorry, then I did misread that in the diff, I thought QTest::newRow("fs") << QStringLiteral("test.fs") << QStringLiteral("FSharp"); enforces that FSharp is used, not the other way around ;=)

Tue, Aug 13, 8:18 PM · Frameworks, Kate
cullmann requested changes to D23035: Simplify ctors with default member initializer.

I think Dominik is right and = would be nicer.

Tue, Aug 13, 7:58 PM · Kate
cullmann requested changes to D22662: Add common GLSL file extensions (.vs, .gs, .fs).

I am not sure we want to override F# for .fs.
Either we should not add that or we shall lower the priority of this highlighting to loose against F#.

Tue, Aug 13, 7:53 PM · Frameworks, Kate
cullmann committed R40:e3d5f8c7cfe8: Merge branch 'quickopen-list-mode' into 'master' (authored by cullmann).
Merge branch 'quickopen-list-mode' into 'master'
Tue, Aug 13, 7:49 PM
cullmann committed R40:46414b8b262b: improve handler - request race condition guard (authored by cullmann).
improve handler - request race condition guard
Tue, Aug 13, 7:30 PM

Mon, Aug 12

cullmann committed R40:9e62459dfc3d: avoid crash if handlers trigger LSP actions that invalidate the handler iterator (authored by cullmann).
avoid crash if handlers trigger LSP actions that invalidate the handler iterator
Mon, Aug 12, 9:03 AM

Sun, Aug 11

cullmann added a comment to T9577: Publish Kate in the Microsoft Store.

If I can help, I have some time for this (and Windows machines at work for testing).
And I would be interested to be able to provide updated version to the store on my own if feasible.

Sun, Aug 11, 7:21 PM · KDE Promo, Kate, Windows
cullmann reassigned T9577: Publish Kate in the Microsoft Store from cullmann to lydia.

Hi, is there a way to get this going again?
Can I do that on my own? I have a Microsoft account "christoph@cullmann.io", can that one be authorized to add the application to the store under "KDE e.V."?

Sun, Aug 11, 6:11 PM · KDE Promo, Kate, Windows
cullmann committed R40:b43797350d72: Merge branch 'buildplugin-filename' into 'master' (authored by cullmann).
Merge branch 'buildplugin-filename' into 'master'
Sun, Aug 11, 10:18 AM

Sat, Aug 10

cullmann committed R954:9f9acc53ff44: missed to resize downto 80 px (authored by cullmann).
missed to resize downto 80 px
Sat, Aug 10, 9:06 PM
cullmann committed R954:382e928a4374: improve the kate news hacker gotchi (authored by cullmann).
improve the kate news hacker gotchi
Sat, Aug 10, 9:01 PM
cullmann requested changes to D23061: Possiblity to change Definition data after loading.

This looks more correct ;=)
Could you now add some test to the auto-tests? Thanks!

Sat, Aug 10, 7:24 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann added a reviewer for D23061: Possiblity to change Definition data after loading: vkrause.
Sat, Aug 10, 5:02 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann added a comment to D23061: Possiblity to change Definition data after loading.

Hmm, I think we want an unit test for this, too.
And I think it won't work like it is, before the call to initLookupForCaseSensitivity one needs to clear both m_keywordsSortedCaseSensitive and m_keywordsSortedCaseInsensitive vectors.

Sat, Aug 10, 5:01 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann committed R40:c54497958615: improve hover support (authored by cullmann).
improve hover support
Sat, Aug 10, 3:35 PM

Fri, Aug 9

cullmann added a comment to D23061: Possiblity to change Definition data after loading.

Actually, wouldn't it make more sense to just provide a way to set the full keyword list?
You can get the QStringlist will all keywords already with keywordList, a setKeywordList(...) would make more sense to me than this modifiers.
That would allow to alter it like you want and then write it back in one go with just one re-init of the mapping.

Fri, Aug 9, 9:38 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann committed R40:636af882e3c9: fix dbus session registration BUG: 410742 (authored by cullmann).
fix dbus session registration BUG: 410742
Fri, Aug 9, 7:24 PM
cullmann committed R40:bf54ad697f3d: fix dbus session registration BUG: 410742 (authored by cullmann).
fix dbus session registration BUG: 410742
Fri, Aug 9, 7:20 PM
cullmann committed R40:2ffd61a631b9: add url key for LSP server homepage url (authored by cullmann).
add url key for LSP server homepage url
Fri, Aug 9, 6:57 PM
cullmann committed R40:152bf7016107: add latex + bibtex LSP support, https://texlab.netlify.com/ (authored by cullmann).
add latex + bibtex LSP support, https://texlab.netlify.com/
Fri, Aug 9, 6:52 PM
cullmann committed R40:6ea3ff08cfbe: be consistent to use arrays for the command (authored by cullmann).
be consistent to use arrays for the command
Fri, Aug 9, 6:20 PM
cullmann committed R40:0625157e7666: initial support for go LSP server https://github.com/sourcegraph/go-langserver (authored by cullmann).
initial support for go LSP server https://github.com/sourcegraph/go-langserver
Fri, Aug 9, 6:16 PM
cullmann committed R40:ac9dabc1f42a: outsource defaults settings to json file in qrc this allows easier editing of… (authored by cullmann).
outsource defaults settings to json file in qrc this allows easier editing of…
Fri, Aug 9, 6:11 PM
cullmann accepted D23050: Highlight documentation: add include keywords.
Fri, Aug 9, 5:04 PM · Documentation, Kate
cullmann added a comment to D23034: implicit fallthough if there is fallthoughContext.

Sounds like a reasonable solution.

Fri, Aug 9, 5:03 PM · Frameworks, Kate
cullmann added a comment to D23034: implicit fallthough if there is fallthoughContext.

Hmm, isn't any file with some fallthrough=false but a fallthrough context just buggy? Did any of our files have that?

Fri, Aug 9, 7:36 AM · Frameworks, Kate