cullmann (Christoph Cullmann)
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jul 30 2015, 8:46 PM (237 w, 6 d)
Availability
Available

Recent Activity

Today

cullmann accepted D27512: README.md: fix example code & code markup.
Wed, Feb 19, 7:24 PM · Frameworks, Kate

Mon, Feb 17

cullmann added a comment to T12716: Standardize Qt logging categories used in KF.

Yes, sounds like a very good idea!
+1

Mon, Feb 17, 9:25 PM · Frameworks

Sun, Feb 16

cullmann committed R877:33786705da10: patch breeze in (authored by cullmann).
patch breeze in
Sun, Feb 16, 6:57 PM
cullmann committed R877:46694d904fd8: fix copy and paste error (authored by cullmann).
fix copy and paste error
Sun, Feb 16, 5:22 PM
cullmann committed R877:d6b3536afb8f: use icons as bundled in okular git (authored by cullmann).
use icons as bundled in okular git
Sun, Feb 16, 5:16 PM
cullmann committed R114:2c832dbdd087: Fix duplicate results for sessions, simplify and optimize (authored by alex).
Fix duplicate results for sessions, simplify and optimize
Sun, Feb 16, 3:23 PM
cullmann closed D27109: Fix duplicate results for sessions, simplify and optimize.
Sun, Feb 16, 3:23 PM · Plasma
cullmann added a comment to D27430: [PATCH] General update for CartoCSS syntax highlighting.

Hi, nice that you keep working on this and upstream your stuff ;=)
Could you provide some test file for this?

Sun, Feb 16, 12:57 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann committed R877:e2e00d1b48bc: try to skip gperf run as told on https://gitlab.freedesktop. (authored by cullmann).
try to skip gperf run as told on https://gitlab.freedesktop.
Sun, Feb 16, 12:20 PM
cullmann added a reverting change for R877:d9eac54c5e2f: Revert "Update checksum for new version": R877:46d735002be1: Revert "Revert "Update checksum for new version"".
Sun, Feb 16, 12:20 PM
cullmann committed R877:46d735002be1: Revert "Revert "Update checksum for new version"" (authored by cullmann).
Revert "Revert "Update checksum for new version""
Sun, Feb 16, 12:20 PM
cullmann added a reverting change for R877:567556bc2a12: Revert "up poppler to latest released version": R877:456b893bbc55: Revert "Revert "up poppler to latest released version"".
Sun, Feb 16, 12:19 PM
cullmann committed R877:456b893bbc55: Revert "Revert "up poppler to latest released version"" (authored by cullmann).
Revert "Revert "up poppler to latest released version""
Sun, Feb 16, 12:19 PM

Sat, Feb 15

cullmann committed R40:57f60ab132f8: try to add enough large icons for Windows (256/512 px) (authored by cullmann).
try to add enough large icons for Windows (256/512 px)
Sat, Feb 15, 4:40 PM
cullmann committed R40:ff1347a11a4a: try to add enough large icons for Windows (256/512 px) (authored by cullmann).
try to add enough large icons for Windows (256/512 px)
Sat, Feb 15, 4:22 PM

Thu, Feb 13

cullmann committed R246:6e2f32b931e3: fix segfault at exit (authored by cullmann).
fix segfault at exit
Thu, Feb 13, 10:21 PM
cullmann committed R246:816ec20e9b05: Merge branch 'arcpatch-D27332' (authored by cullmann).
Merge branch 'arcpatch-D27332'
Thu, Feb 13, 10:21 PM
cullmann closed D27332: try to fix issue with ispellchecker on windows.
Thu, Feb 13, 10:21 PM · Frameworks

Wed, Feb 12

cullmann added a reverting change for R877:1239f7e239a7: up poppler to latest released version: R877:567556bc2a12: Revert "up poppler to latest released version".
Wed, Feb 12, 8:00 PM
cullmann committed R877:567556bc2a12: Revert "up poppler to latest released version" (authored by cullmann).
Revert "up poppler to latest released version"
Wed, Feb 12, 8:00 PM
cullmann added a reverting change for R877:04271e0b0cfb: Update checksum for new version: R877:d9eac54c5e2f: Revert "Update checksum for new version".
Wed, Feb 12, 8:00 PM
cullmann committed R877:d9eac54c5e2f: Revert "Update checksum for new version" (authored by cullmann).
Revert "Update checksum for new version"
Wed, Feb 12, 8:00 PM
cullmann committed R877:5e88f879f797: add new kirigami dep (authored by cullmann).
add new kirigami dep
Wed, Feb 12, 5:03 PM
cullmann committed R216:86e132a3a829: Makefile highlight: fix variable names in "else" conditionals (authored by nibags).
Makefile highlight: fix variable names in "else" conditionals
Wed, Feb 12, 11:15 AM
cullmann closed D27343: Makefile highlight: fix variable names in "else" conditionals.
Wed, Feb 12, 11:15 AM · Frameworks, Kate
cullmann accepted D27343: Makefile highlight: fix variable names in "else" conditionals.

Thanks for the fix!

Wed, Feb 12, 11:14 AM · Frameworks, Kate
cullmann added a comment to D27332: try to fix issue with ispellchecker on windows.

Ok, tested on Win10 => This solves the issue.

Wed, Feb 12, 10:12 AM · Frameworks
cullmann committed R877:4b3b96dae294: use proper api (authored by cullmann).
use proper api
Wed, Feb 12, 9:54 AM
cullmann updated the diff for D27332: try to fix issue with ispellchecker on windows.

adapt api to used QMap

Wed, Feb 12, 9:53 AM · Frameworks
cullmann committed R877:cb177884c5e6: add missing include (authored by cullmann).
add missing include
Wed, Feb 12, 9:49 AM
cullmann updated the diff for D27332: try to fix issue with ispellchecker on windows.

add missing include for windows

Wed, Feb 12, 9:47 AM · Frameworks
cullmann committed R877:112d9739450e: try to leak the dictionaries (authored by cullmann).
try to leak the dictionaries
Wed, Feb 12, 9:30 AM
cullmann updated the diff for D27332: try to fix issue with ispellchecker on windows.

fix argument to create spell checker

Wed, Feb 12, 9:29 AM · Frameworks
cullmann updated the diff for D27332: try to fix issue with ispellchecker on windows.

sonnet cleanup for the dictionaries seems to be too late

Wed, Feb 12, 9:27 AM · Frameworks
cullmann committed R877:0bcd16875f30: use latest frameworks release 5.67, patch that, too (authored by cullmann).
use latest frameworks release 5.67, patch that, too
Wed, Feb 12, 9:01 AM
cullmann committed R877:82abee1368f0: use latest frameworks release 5.67 (authored by cullmann).
use latest frameworks release 5.67
Wed, Feb 12, 9:00 AM
cullmann committed R877:777b97bd3530: enforce patch (authored by cullmann).
enforce patch
Wed, Feb 12, 8:37 AM
cullmann committed R877:61deede3fa1c: leak resources (authored by cullmann).
leak resources
Wed, Feb 12, 8:36 AM
cullmann updated the diff for D27332: try to fix issue with ispellchecker on windows.

any cleanup crashs silently

Wed, Feb 12, 8:35 AM · Frameworks
cullmann closed D27238: Add an option to dynamic-break inside words.
Wed, Feb 12, 8:04 AM · Frameworks, KTextEditor, Kate
cullmann committed R39:0a08d45f2b56: Add an option to dynamic-break inside words (authored by cullmann).
Add an option to dynamic-break inside words
Wed, Feb 12, 8:04 AM
cullmann accepted D27238: Add an option to dynamic-break inside words.

Ok, happy with that, thanks!

Wed, Feb 12, 8:03 AM · Frameworks, KTextEditor, Kate
cullmann committed R877:a7eb4c272edc: quickfix com crash (authored by cullmann).
quickfix com crash
Wed, Feb 12, 7:38 AM
cullmann updated the diff for D27332: try to fix issue with ispellchecker on windows.

de-init com after interface got released, avoids crash

Wed, Feb 12, 7:36 AM · Frameworks
cullmann added a comment to D27332: try to fix issue with ispellchecker on windows.

:=) I think the issue is even much smaller, I just call un-init before release, that is wrong :/
I will quickfix that and avoid other changes (beside the extra nullptr checks).

Wed, Feb 12, 7:33 AM · Frameworks

Tue, Feb 11

cullmann added a comment to D27332: try to fix issue with ispellchecker on windows.

I played a bit with it.
No idea why I get crash reports over the store and can't see this locally.
Given the docs state one shall not do the de-init during unloading but sonnet handles the clients/spellers via some global static that could be a reason...

Tue, Feb 11, 10:21 PM · Frameworks
cullmann added a comment to D27238: Add an option to dynamic-break inside words.

Hmm, not sure.
Given we have everywhere at the moment the dynamic/static word wrap wording, I would rather stick with that.

Tue, Feb 11, 10:18 PM · Frameworks, KTextEditor, Kate
cullmann committed R877:98c0ae6abf4d: skip com init (authored by cullmann).
skip com init
Tue, Feb 11, 10:05 PM
cullmann committed R877:14ee967b28e2: skip com init (authored by cullmann).
skip com init
Tue, Feb 11, 10:05 PM
cullmann updated the diff for D27332: try to fix issue with ispellchecker on windows.
  • skip com init/deinit
Tue, Feb 11, 10:04 PM · Frameworks
cullmann committed R877:dd4470e0f3b1: try to avoid some com crash (authored by cullmann).
try to avoid some com crash
Tue, Feb 11, 9:24 PM
cullmann added reviewers for D27332: try to fix issue with ispellchecker on windows: Frameworks, vonreth.

See crash reports in Windows store.
For me locally, it seemed to work :/

Tue, Feb 11, 9:21 PM · Frameworks
cullmann requested review of D27332: try to fix issue with ispellchecker on windows.
Tue, Feb 11, 9:20 PM · Frameworks
cullmann reopened D27180: Add sortable columns to session manager dialog, and remove previous sorting code.

Hmm, this doesn't build due to use of an obsolete function.

Tue, Feb 11, 8:42 PM · Kate
cullmann committed R40:54b3fd74f74f: remove use of obsolete function (authored by cullmann).
remove use of obsolete function
Tue, Feb 11, 8:42 PM
cullmann committed R40:4b0260eb67bd: Add sortable columns to session manager dialog, and remove previous sorting code (authored by rrosch).
Add sortable columns to session manager dialog, and remove previous sorting code
Tue, Feb 11, 7:13 PM
cullmann closed D27180: Add sortable columns to session manager dialog, and remove previous sorting code.
Tue, Feb 11, 7:13 PM · Kate
cullmann committed R216:fd345c7338fb: Add syntax highlighting for Solidity (authored by nibags).
Add syntax highlighting for Solidity
Tue, Feb 11, 7:08 PM
cullmann closed D27313: Add syntax highlighting for Solidity.
Tue, Feb 11, 7:08 PM · Frameworks, Kate
cullmann added a comment to D27180: Add sortable columns to session manager dialog, and remove previous sorting code.

Btw., for future patches, better use merge requests at https://invent.kde.org/kde/kate, thanks.

Tue, Feb 11, 7:08 PM · Kate
cullmann accepted D27180: Add sortable columns to session manager dialog, and remove previous sorting code.

Let's to with this then for the moment.
If you find time to improve on this, further patches are welcome!
Thanks for taking care! (and that you like Kate ;=)

Tue, Feb 11, 7:04 PM · Kate
cullmann accepted D27313: Add syntax highlighting for Solidity.

Ok, thanks for taking care!
Let's merge this.

Tue, Feb 11, 7:02 PM · Frameworks, Kate
cullmann requested changes to D27238: Add an option to dynamic-break inside words.

I am ok with this.
Thought I would like to have a more consistent name for the config key.
We have already "dynamic-word-wrap", I would like "dynamic-word-wrap-anywhere" better than the abbreviated "dyn-wrap-anywhere"

Tue, Feb 11, 9:46 AM · Frameworks, KTextEditor, Kate

Sun, Feb 9

cullmann added a comment to T9583: Promote KDE apps in Microsoft Store.

Given we have now a bunch of applications in the store, it might sense to start the promotion a bit.

Sun, Feb 9, 12:11 PM · KDE Promo, Windows
cullmann abandoned D8281: Allow to use IcoTool for Windows icons.
Sun, Feb 9, 12:01 PM · Build System, Frameworks
cullmann commandeered D8281: Allow to use IcoTool for Windows icons.

I reviewed the current state and there is now already icotool support in our extra-cmake-modules stuff => closing this.

Sun, Feb 9, 12:01 PM · Build System, Frameworks
cullmann added a comment to D26342: Allow overriding to disable auto language detection.

@mludwig: ok with the current patch?

Sun, Feb 9, 11:53 AM · Frameworks
cullmann closed D26903: allow programLogo property to be a QIcon, too.

done

Sun, Feb 9, 11:51 AM · Frameworks
cullmann committed R244:7bc9d98a2144: add hint that QIcon can be used as a program logo (authored by cullmann).
add hint that QIcon can be used as a program logo
Sun, Feb 9, 11:51 AM
cullmann committed R40:4d7c67a70110: [BackTrace Plugin] QRegExp to QRegularExpression (authored by ahmadsamir).
[BackTrace Plugin] QRegExp to QRegularExpression
Sun, Feb 9, 11:45 AM
cullmann added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

For the lambda issue, I think we can add:

# keep lambda formatting multi-line if not empty
AllowShortLambdasOnASingleLine: Empty

see https://clang.llvm.org/docs/ClangFormatStyleOptions.html

That fixes for me the issue with the collapsed lambda.

For the comments, as said, we can remove

AlignTrailingComments: true

For the generic issue of stuff folded in one line, one can play with the ColumnLimit, but as said, that will still arbitrarily pack stuff as long as it fits the limit.

Kai, could you try the two changes (for lambda and comments) by just temporarily changing that in the .clang-format file locally and rerunning make clang-format?

Sun, Feb 9, 11:45 AM · Build System, Frameworks
cullmann committed R216:02a3fb1d7c39: Small improvements in some XML files (authored by nibags).
Small improvements in some XML files
Sun, Feb 9, 11:42 AM
cullmann committed R216:8069aab83116: Merge branch 'arcpatch-D24982_1' (authored by cullmann).
Merge branch 'arcpatch-D24982_1'
Sun, Feb 9, 11:42 AM
cullmann closed D24982: Small improvements in some XML files.
Sun, Feb 9, 11:42 AM · Frameworks, Kate
cullmann accepted D24982: Small improvements in some XML files.

I think we can go with this as is.
Given we have tests for a lot of stuff, regressions shouldn't be that likely.
I will merge this, before we let that rot even more.
Thanks for the work on this, btw.!

Sun, Feb 9, 11:39 AM · Frameworks, Kate
cullmann added a comment to D27109: Fix duplicate results for sessions, simplify and optimize.

Upsa ;) missed that this is in plasma addons, not in the session launcher applet we have in our repo, ignore my comment about the invent stuff ;=)

Sun, Feb 9, 11:36 AM · Plasma
cullmann added a comment to D27109: Fix duplicate results for sessions, simplify and optimize.

Btw., for Kate, we would prefer merge requests on invent.kde.org/kde/kate, but I will just apply this via arc.

Sun, Feb 9, 11:35 AM · Plasma
cullmann accepted D27109: Fix duplicate results for sessions, simplify and optimize.

Improved output seems fine for me, thanks for taking care.

Sun, Feb 9, 11:35 AM · Plasma
cullmann committed R216:5bd8719d4655: Makefile highlight: add substitutions (authored by nibags).
Makefile highlight: add substitutions
Sun, Feb 9, 11:33 AM
cullmann closed D27009: Makefile highlight: add substitutions.
Sun, Feb 9, 11:33 AM · Frameworks, Kate
cullmann accepted D27009: Makefile highlight: add substitutions.
Sun, Feb 9, 11:32 AM · Frameworks, Kate
cullmann added a comment to D27009: Makefile highlight: add substitutions.

Has a test, looks ok, thanks!

Sun, Feb 9, 11:32 AM · Frameworks, Kate
cullmann committed R39:6f39d3345273: KateModeMenuList: don't overlap the scroll bar (authored by nibags).
KateModeMenuList: don't overlap the scroll bar
Sun, Feb 9, 11:32 AM
cullmann closed D26957: KateModeMenuList: don't overlap the scroll bar.
Sun, Feb 9, 11:32 AM · Frameworks, Kate
cullmann accepted D26957: KateModeMenuList: don't overlap the scroll bar.

This is a patch for KTextEditor, that is still on phab (for good or bad ;=)
I think this is ok, accepting & merging.
Btw., for the default arguments: This is a purely internal class, therefore removing it would have been ok.

Sun, Feb 9, 11:28 AM · Frameworks, Kate

Sat, Feb 8

cullmann accepted D27208: Support services on flatpak.

I guess I can trust you on the sandbox part ;=)
For Albert's question: We take a look which sessions are running in which Kate instances. If there would be a generic way to query all instances we could use this for that loop here.

Sat, Feb 8, 4:52 PM · Kate
cullmann committed R877:b9537942f7b9: kate/kwrite need zero patches now ;=) (authored by cullmann).
kate/kwrite need zero patches now ;=)
Sat, Feb 8, 4:01 PM
cullmann committed R877:1239f7e239a7: up poppler to latest released version (authored by cullmann).
up poppler to latest released version
Sat, Feb 8, 3:54 PM
cullmann committed R877:b44316a6913c: update to release 19.12.2 (authored by cullmann).
update to release 19.12.2
Sat, Feb 8, 3:53 PM

Thu, Feb 6

cullmann added a comment to T9575: Publish more of KDE's applications in the Microsoft Store.

Nice!

Thu, Feb 6, 3:01 PM · Goal: All About the Apps, Windows

Wed, Feb 5

cullmann committed R40:d36b82f5b75e: Kate is using KUserFeedback for telemetry starting with release 20.04. (authored by cullmann).
Kate is using KUserFeedback for telemetry starting with release 20.04.
Wed, Feb 5, 8:21 PM
cullmann committed R40:ac2b9ead3ac9: Merge branch 'userfeedback' into HEAD (authored by cullmann).
Merge branch 'userfeedback' into HEAD
Wed, Feb 5, 8:15 PM

Sun, Feb 2

cullmann committed R40:d9d787e533e8: Merge branch 'release/19.12' (authored by cullmann).
Merge branch 'release/19.12'
Sun, Feb 2, 11:29 AM
cullmann committed R40:a6d1c8d3872c: Fix usage of QtSingleApplication on Windows and Apple (authored by sars).
Fix usage of QtSingleApplication on Windows and Apple
Sun, Feb 2, 11:25 AM
cullmann committed R40:fd56c5fa012d: Fix usage of QtSingleApplication on Windows and Apple (authored by sars).
Fix usage of QtSingleApplication on Windows and Apple
Sun, Feb 2, 11:25 AM

Sat, Feb 1

cullmann added a comment to D23410: improve word completion to use highlighting to detect word boundaries.

Reverted atm...

Sat, Feb 1, 8:20 PM · Frameworks, Kate
cullmann planned changes to D23410: improve word completion to use highlighting to detect word boundaries.
Sat, Feb 1, 8:20 PM · Frameworks, Kate
cullmann committed R39:6540dbf180cc: Revert "improve word completion to use highlighting to detect word boundaries" (authored by cullmann).
Revert "improve word completion to use highlighting to detect word boundaries"
Sat, Feb 1, 8:20 PM
cullmann reopened D23410: improve word completion to use highlighting to detect word boundaries.

Did lead to regressions, see https://bugs.kde.org/show_bug.cgi?id=412502

Sat, Feb 1, 8:20 PM · Frameworks, Kate
cullmann added a reverting change for R39:8d0f6ff8014c: improve word completion to use highlighting to detect word boundaries: R39:6540dbf180cc: Revert "improve word completion to use highlighting to detect word boundaries".
Sat, Feb 1, 8:20 PM