cullmann (Christoph Cullmann)
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jul 30 2015, 8:46 PM (228 w, 14 h)
Availability
Available

Recent Activity

Today

cullmann accepted D25939: TypeScript: add "bigint" primitive type.

Seems fine, thanks!

Fri, Dec 13, 6:25 AM · Frameworks, Kate

Yesterday

cullmann abandoned D25924: fix static linking on e.g. macOS.

Let's just close that.
If I have enough time somewhen, will report a Qt bug (or try .1)

Thu, Dec 12, 5:05 PM · Frameworks, Kate
cullmann added a comment to D25924: fix static linking on e.g. macOS.

If you think that is just a Qt issue, we can close this again =)
In-house we will just patch this :-0 Debugging the static linking in Qt is too much work.

Thu, Dec 12, 4:33 PM · Frameworks, Kate
cullmann added a comment to D25924: fix static linking on e.g. macOS.

Therefore I made this review request ;)
For me, for Qt 5.14 static linked, it doesn't seem to propagate.
I am not sure why that worked before thought.

Thu, Dec 12, 4:07 PM · Frameworks, Kate
cullmann requested review of D25924: fix static linking on e.g. macOS.
Thu, Dec 12, 3:59 PM · Frameworks, Kate
cullmann committed R216:a8fa59235263: Revert "fix linking with static qt" (authored by cullmann).
Revert "fix linking with static qt"
Thu, Dec 12, 3:53 PM
cullmann added a reverting change for R216:8673e27a32c0: fix linking with static qt: R216:a8fa59235263: Revert "fix linking with static qt".
Thu, Dec 12, 3:53 PM
cullmann committed R216:8673e27a32c0: fix linking with static qt (authored by cullmann).
fix linking with static qt
Thu, Dec 12, 3:46 PM

Mon, Dec 9

cullmann added a comment to D25805: Open/close and focus/defocus terminal using the same shortcuts as Dolphin.

The generic stuff will still be there, yes.
But I don't think this hurts

Mon, Dec 9, 5:36 AM · Kate

Sun, Dec 8

cullmann added a comment to D25811: cmake: Fix `CMAKE_POLICY_*_CMP<N>` regex and add special args to `get_cmake_property`.

Nice that you take care of that stuff.
Could you enhance the CMake test file, too, to cover some of the new stuff?

Sun, Dec 8, 3:10 PM · Frameworks, Kate
cullmann accepted D25805: Open/close and focus/defocus terminal using the same shortcuts as Dolphin.

Seems to be a reasonable idea for me.

Sun, Dec 8, 2:50 PM · Kate

Sat, Dec 7

cullmann committed R216:c2de17ba8342: Updates from CMake 3.16 final release (authored by cullmann).
Updates from CMake 3.16 final release
Sat, Dec 7, 4:46 PM
cullmann closed D25686: Updates from CMake 3.16 final release.
Sat, Dec 7, 4:46 PM · Frameworks, Kate

Mon, Dec 2

cullmann added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

As noted in

Mon, Dec 2, 5:49 PM
cullmann accepted D25686: Updates from CMake 3.16 final release.

Thanks for the update!

Mon, Dec 2, 5:46 PM · Frameworks, Kate

Fri, Nov 29

cullmann added a comment to D25530: Sonnet: Add locales that are missing in QLocale.

I am with Albert, that we better improve what Qt has instead of replicating this here.

Fri, Nov 29, 8:00 AM · Frameworks

Wed, Nov 27

cullmann committed R39:cee9d9642735: KateModeManager::updateFileType(): validate modes and reload menu of the status… (authored by nibags).
KateModeManager::updateFileType(): validate modes and reload menu of the status…
Wed, Nov 27, 9:22 AM
cullmann closed D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar.
Wed, Nov 27, 9:22 AM · Frameworks, Kate
cullmann accepted D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar.

I think that is nicer, not yet-an-other global hash ;=)

Wed, Nov 27, 8:45 AM · Frameworks, Kate

Tue, Nov 26

cullmann committed R216:50d3bbae7870: GIT_SILENT fix unit test (authored by cullmann).
GIT_SILENT fix unit test
Tue, Nov 26, 6:19 PM
cullmann committed R216:9c64fb507253: JavaScript: move keywords from TypeScript and other improvements (authored by nibags).
JavaScript: move keywords from TypeScript and other improvements
Tue, Nov 26, 6:19 PM
cullmann closed D25503: JavaScript: move keywords from TypeScript and other improvements.
Tue, Nov 26, 6:19 PM · Frameworks, Kate
cullmann accepted D25555: deprecate kregexpeditorinterface.

Thanks!

Tue, Nov 26, 6:13 PM · Frameworks
cullmann requested changes to D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar.

I like the overall effect, but I don't like the new static registry.
We already have some registry in KateGlobal for all views, we would just need to allow to access the KateModeMenuList for the individual view then we can use that global list of views to touch all of them.
That would be preferable to have an other global hashing.

Tue, Nov 26, 6:10 PM · Frameworks, Kate
cullmann accepted D25503: JavaScript: move keywords from TypeScript and other improvements.

Nice improvements! Thanks a lot.

Tue, Nov 26, 6:03 PM · Frameworks, Kate
cullmann accepted D25538: [kfinddialog] Remove usage of kregexpeditor plugin system.

Ok ,=)

Tue, Nov 26, 6:01 PM · Frameworks
cullmann moved T12159: KTextWidgets: Remove plugin system from Backlog to In Progress on the KF6 board.
Tue, Nov 26, 5:54 PM · KF6
cullmann requested changes to D25538: [kfinddialog] Remove usage of kregexpeditor plugin system.

Looks good in principle.

Tue, Nov 26, 5:52 PM · Frameworks

Sun, Nov 24

cullmann added a parent task for T12206: Port KFileWidget away from KToolBar: T12089: KIO for KF6.
Sun, Nov 24, 11:12 AM · KF6
cullmann added a subtask for T12089: KIO for KF6: T12206: Port KFileWidget away from KToolBar.
Sun, Nov 24, 11:12 AM · KF6
cullmann added a parent task for T12205: Port KDirModel away from KActionCollection: T12089: KIO for KF6.
Sun, Nov 24, 11:12 AM · KF6
cullmann added a subtask for T12089: KIO for KF6: T12205: Port KDirModel away from KActionCollection.
Sun, Nov 24, 11:12 AM · KF6
cullmann added a parent task for T12210: Port KIO DavJob away from QDomDocument in the public API: T12089: KIO for KF6.
Sun, Nov 24, 11:11 AM · KF6
cullmann added a subtask for T12089: KIO for KF6: T12210: Port KIO DavJob away from QDomDocument in the public API.
Sun, Nov 24, 11:11 AM · KF6
cullmann added a parent task for T12211: Deprecate KEncodingFileDialog: T12089: KIO for KF6.
Sun, Nov 24, 11:10 AM · KF6
cullmann added a subtask for T12089: KIO for KF6: T12211: Deprecate KEncodingFileDialog.
Sun, Nov 24, 11:10 AM · KF6
cullmann added a comment to T12211: Deprecate KEncodingFileDialog.

In Kate, we removed the choose encoding for open and rely on the detection and for save we have an extra action that let's you first select the encoding (which is rarely needed, just for some "convert file to X" tasks you do once a week ;=)

Sun, Nov 24, 11:02 AM · KF6
cullmann committed R40:646e0a7410fd: Read the user visible name of the default color scheme (authored by davidre).
Read the user visible name of the default color scheme
Sun, Nov 24, 10:18 AM
cullmann committed R40:ad2e9867a1de: Read the user visible name of the default color scheme (authored by davidre).
Read the user visible name of the default color scheme
Sun, Nov 24, 10:17 AM
cullmann moved T12147: KConfigWidgets from Needs Input to Backlog on the KF6 board.
Sun, Nov 24, 9:30 AM · KF6
cullmann moved T12151: KCMUtils from Needs Input to Backlog on the KF6 board.
Sun, Nov 24, 9:30 AM · KF6
cullmann moved T12202: KXmlGui from Needs Input to Backlog on the KF6 board.
Sun, Nov 24, 9:30 AM · KF6
cullmann moved T12184: Purpose from Needs Input to Backlog on the KF6 board.
Sun, Nov 24, 9:30 AM · KF6
cullmann created T12203: KXmlGui: Remove kpackages.h header.
Sun, Nov 24, 9:28 AM · KF6
cullmann added a parent task for T12195: Remove KTextWidgets dependency from KXMLGui: T12202: KXmlGui.
Sun, Nov 24, 9:27 AM · KF6
cullmann added a subtask for T12202: KXmlGui: T12195: Remove KTextWidgets dependency from KXMLGui.
Sun, Nov 24, 9:27 AM · KF6
cullmann added a parent task for T12198: KXmlGui: remove Attica dependency: T12202: KXmlGui.
Sun, Nov 24, 9:27 AM · KF6
cullmann added a subtask for T12202: KXmlGui: T12198: KXmlGui: remove Attica dependency.
Sun, Nov 24, 9:27 AM · KF6
cullmann created T12202: KXmlGui.
Sun, Nov 24, 9:26 AM · KF6

Sat, Nov 23

cullmann added a reviewer for D25495: Fix Sonnet autodetect failing on Indian langs: mludwig.
Sat, Nov 23, 7:12 PM · Frameworks
cullmann accepted D25464: Remove unused include.
Sat, Nov 23, 4:19 PM · Gwenview
cullmann renamed T12157: KXmlRpcClient deprecation + removal from KXmlRpc deprecation to KXmlRpcClient deprecation + removal.
Sat, Nov 23, 3:04 PM · KF6
cullmann created T12157: KXmlRpcClient deprecation + removal.
Sat, Nov 23, 3:03 PM · KF6
cullmann created T12154: KCModuleLoader deployment issues.
Sat, Nov 23, 2:56 PM · KF6
cullmann renamed T12153: Remove unused KCMUtils classes from Collapse KCModule and Co. from KConfigWidgets into KCMUtils to Remove unused KCMUtils classes.
Sat, Nov 23, 2:55 PM · KF6
cullmann added a comment to T12151: KCMUtils.

KCMUtils:

  • Clean up KDeclarative mess, makes for an insane dependency tree
Sat, Nov 23, 2:54 PM · KF6
cullmann added a subtask for T12151: KCMUtils: T12150: KCModule => move to KCMUtils.
Sat, Nov 23, 2:53 PM · KF6
cullmann added a parent task for T12150: KCModule => move to KCMUtils: T12151: KCMUtils.
Sat, Nov 23, 2:53 PM · KF6
cullmann created T12153: Remove unused KCMUtils classes.
Sat, Nov 23, 2:52 PM · KF6
cullmann created T12151: KCMUtils.
Sat, Nov 23, 2:52 PM · KF6
cullmann created T12150: KCModule => move to KCMUtils.
Sat, Nov 23, 2:29 PM · KF6
cullmann created T12149: KTipDialog remove or move to KWidgetAddons.
Sat, Nov 23, 2:27 PM · KF6
cullmann added a parent task for T11587: Investigate making KColorScheme tier1: T12147: KConfigWidgets.
Sat, Nov 23, 2:23 PM · KF6
cullmann added a subtask for T12147: KConfigWidgets: T11587: Investigate making KColorScheme tier1.
Sat, Nov 23, 2:23 PM · KF6
cullmann created T12148: Move KStandardActions to e.g. KGui/WidgetAddons.
Sat, Nov 23, 2:22 PM · KF6
cullmann created T12147: KConfigWidgets.
Sat, Nov 23, 2:19 PM · KF6
cullmann moved T12103: KTextEditor from Needs Input to Backlog on the KF6 board.
Sat, Nov 23, 11:08 AM · KF6
cullmann added a comment to T11591: Remove KMediaPlayer.

> Reviewed on the KF6 sprint

Sat, Nov 23, 9:19 AM · KF6
cullmann accepted D25485: Remove KIconThemes use.
Sat, Nov 23, 9:04 AM · Kate, Frameworks
cullmann created T12103: KTextEditor.
Sat, Nov 23, 9:01 AM · KF6

Fri, Nov 22

cullmann committed R216:503dab974d34: JavaScript/TypeScript React: rename syntax definitions (authored by nibags).
JavaScript/TypeScript React: rename syntax definitions
Fri, Nov 22, 10:06 AM
cullmann closed D25429: JavaScript/TypeScript React: rename syntax definitions.
Fri, Nov 22, 10:06 AM · Frameworks, Kate
cullmann added a comment to T12083: Make DBus dependencies optional.

I will create a list with the frameworks that at the moment require it, then we can work on removing this requirements step by step.

Fri, Nov 22, 9:09 AM · KF6
cullmann added a comment to D24860: Use non-deprecated KDEInstallDirs variables.

I did an arc land.

Fri, Nov 22, 8:58 AM · Kate
cullmann added a comment to T12083: Make DBus dependencies optional.

I think at the moment KIO still needs dbus for some parts.
Or KXmlGui if I am not mistaken.

Fri, Nov 22, 8:55 AM · KF6
cullmann committed R40:f8247706ec0a: Use non-deprecated KDEInstallDirs variables (authored by meven).
Use non-deprecated KDEInstallDirs variables
Fri, Nov 22, 8:55 AM
cullmann closed D24860: Use non-deprecated KDEInstallDirs variables.
Fri, Nov 22, 8:52 AM · Kate
cullmann committed R39:911b7fa44f2a: Verify modes of the session config file (authored by nibags).
Verify modes of the session config file
Fri, Nov 22, 8:48 AM
cullmann closed D25389: Verify modes of the session config file.
Fri, Nov 22, 8:48 AM · Frameworks, Kate
cullmann accepted D25429: JavaScript/TypeScript React: rename syntax definitions.

Ok for me :=)

Fri, Nov 22, 8:30 AM · Frameworks, Kate

Wed, Nov 20

cullmann created T12083: Make DBus dependencies optional.
Wed, Nov 20, 5:17 PM · KF6
cullmann added a comment to D21660: remove dbus for windows build and change audio dep logic.

That is bad, then this must be fixed.
That should happen on Windows, too.
Just like it works nicely on macOS.

Wed, Nov 20, 2:53 PM · Frameworks
cullmann added a comment to D21660: remove dbus for windows build and change audio dep logic.

No, not really, I fixed that long ago, we auto-detect this and use the KDE_FORK_SLAVES code paths for that

Wed, Nov 20, 11:45 AM · Frameworks
cullmann added a comment to D21660: remove dbus for windows build and change audio dep logic.

kio doesn't require dbus for the normal slave stuff.
It can be that it requires it for the kcookie or auth stuff.

Wed, Nov 20, 11:09 AM · Frameworks

Tue, Nov 19

cullmann accepted D25412: Respect KF5_MIN_VER and QT_MIN_VER.

Thanks

Tue, Nov 19, 9:07 PM · Kate
cullmann accepted D25411: Search for KF5I18n and KF5DocTools.

Thanks!

Tue, Nov 19, 9:06 PM · Kate
cullmann accepted D25410: Search for Qt5Widgets to make a version comparison work.
Tue, Nov 19, 9:06 PM · Kate
cullmann accepted D25389: Verify modes of the session config file.

Sounds reasonable, code looks better, too!
Thanks!

Tue, Nov 19, 12:14 PM · Frameworks, Kate

Mon, Nov 18

cullmann committed R246:16bcc94553ec: Disable ispell backend with mingw (authored by cullmann).
Disable ispell backend with mingw
Mon, Nov 18, 4:30 PM
cullmann added a comment to D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight..

Actually, I could live with:

Mon, Nov 18, 7:36 AM · Frameworks, Kate

Sun, Nov 17

cullmann added a comment to D25244: Implement ISpellChecker backend for Windows >= 8.

This allows to shrink e.g. the Kate installation on Windows from 431 MB to 274 MB, > 150 MB space less occupied ;=)

Sun, Nov 17, 6:23 PM · Frameworks
cullmann committed R877:ab2d0746bbf1: try to avoid hunspell on mac + windows, there we have own backends (authored by cullmann).
try to avoid hunspell on mac + windows, there we have own backends
Sun, Nov 17, 6:05 PM
cullmann committed R246:6bbfb5f2c8f9: fix windows compile (authored by cullmann).
fix windows compile
Sun, Nov 17, 2:08 PM
cullmann committed R246:67cbe8776a1f: Implement ISpellChecker backend for Windows >= 8 (authored by cullmann).
Implement ISpellChecker backend for Windows >= 8
Sun, Nov 17, 2:02 PM
cullmann closed D25244: Implement ISpellChecker backend for Windows >= 8.
Sun, Nov 17, 2:02 PM · Frameworks
cullmann committed R877:190d083b4ab5: use framework 5.64 (authored by cullmann).
use framework 5.64
Sun, Nov 17, 1:11 PM
cullmann added a comment to D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight..

The issue with this approach is, that you get "too high" lines for the case that none of this characters ever appear.
Beside that, unfortunately, you get rendering artifacts in addition, as Qt will not paint e.g. selection high enough for lines without such chars.

Sun, Nov 17, 12:37 PM · Frameworks, Kate
cullmann added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

Btw., I just tried e.g.

Sun, Nov 17, 12:19 PM · Build System, Frameworks
cullmann added reviewers for D24568: Provide clang-format target with a KDE Frameworks style file: broulik, davidedmundson.

For the lambda issue, I think we can add:

Sun, Nov 17, 12:05 PM · Build System, Frameworks
cullmann committed R39:b24ee34a2b9c: GIT_SILENT: clang-format (authored by cullmann).
GIT_SILENT: clang-format
Sun, Nov 17, 12:01 PM