cullmann (Christoph Cullmann)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jul 30 2015, 8:46 PM (185 w, 1 d)
Availability
Available

Recent Activity

Today

cullmann added a comment to D18734: Update octave.xml to Octave 4.2.0.

Good question:

I added a minimal howto to the README.md:

https://commits.kde.org/syntax-highlighting/9343341f91274f899f74b1ffe3fa260dadbc0978

Does that help you?

Partially. I have written the test file (test.octave), but after make test, I have errors in testhighlighter_test, htmlhighlighter_test and folding_test like this

FAIL!  : TestHighlighterTest::testHighlight(test.octave) 'ref.open(QIODevice::ReadOnly | QIODevice::Text)' returned FALSE. ()

If I change the filename to test.octave.syntax, I have only one error in testhighlighter_test:

TestHighlighterTest::cleanupTestCase() 'coveredList.open(QFile::WriteOnly)' returned FALSE. ()
   Loc: [/home/mmmm1998/Документы/Репозитории/syntax-highlighting/autotests/testhighlighter.cpp(108)]

I can't reproduce this build fail on my KDE Neon virtual machine, should I ignore this?

Also, what difference between highlight.tex and test.tex, for example? Octave have highlight_octave.m.syntax, which, I guess, is test file, should I remove it?

Fri, Feb 15, 8:06 AM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann committed R246:f49e7a6fb88c: Handle the case if createSpeller is passed an unavailable language (authored by ahmadsamir).
Handle the case if createSpeller is passed an unavailable language
Fri, Feb 15, 8:04 AM
cullmann closed D18907: Handle the case if createSpeller is passed an unavailable language.
Fri, Feb 15, 8:04 AM · Frameworks
cullmann committed R40:1fa587b0669b: Confirm closing muliple tabs. (authored by shubham).
Confirm closing muliple tabs.
Fri, Feb 15, 8:03 AM
cullmann closed D17599: Confirm closing muliple tabs..
Fri, Feb 15, 8:03 AM · Kate
cullmann accepted D17599: Confirm closing muliple tabs..

Ok with this, thanks, will apply it.
Thanks for taking into account all the feedback!

Fri, Feb 15, 8:01 AM · Kate

Yesterday

cullmann committed R216:eda235463cd2: Avoid duplicate *-php.xml files in "data/CMakeLists.txt" (authored by cullmann).
Avoid duplicate *-php.xml files in "data/CMakeLists.txt"
Thu, Feb 14, 1:18 PM
cullmann closed D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt".
Thu, Feb 14, 1:18 PM · Frameworks, Kate
cullmann added a comment to D18997: Add functions returning all definitions for a mimetype or file name.

Nice that we get the patches, then all can benefit from the improvements.

Thu, Feb 14, 9:04 AM · Frameworks, Kate, Framework: Syntax Highlighting
cullmann committed R216:0e94e0006005: Add functions returning all definitions for a mimetype or file name (authored by davschul).
Add functions returning all definitions for a mimetype or file name
Thu, Feb 14, 8:46 AM
cullmann closed D18997: Add functions returning all definitions for a mimetype or file name.
Thu, Feb 14, 8:46 AM · Frameworks, Kate, Framework: Syntax Highlighting
cullmann accepted D18997: Add functions returning all definitions for a mimetype or file name.

Thanks => will push that.

Thu, Feb 14, 8:45 AM · Frameworks, Kate, Framework: Syntax Highlighting
cullmann committed R216:96466afebf63: Fix building with namespaced Qt (authored by davschul).
Fix building with namespaced Qt
Thu, Feb 14, 8:21 AM
cullmann closed D18996: Fix building with namespaced Qt.
Thu, Feb 14, 8:21 AM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann committed R216:fe00f62078ea: update literate haskell mimetype (authored by davschul).
update literate haskell mimetype
Thu, Feb 14, 8:15 AM
cullmann closed D18998: update literate haskell mimetype.
Thu, Feb 14, 8:15 AM · Frameworks, Kate
cullmann accepted D18998: update literate haskell mimetype.

Makes sense ;=)

Thu, Feb 14, 8:14 AM · Frameworks, Kate
cullmann requested changes to D18997: Add functions returning all definitions for a mimetype or file name.

Makes sense.

Thu, Feb 14, 7:23 AM · Frameworks, Kate, Framework: Syntax Highlighting
cullmann committed R216:152968754edc: prevent assertion in regex load (authored by davschul).
prevent assertion in regex load
Thu, Feb 14, 7:20 AM
cullmann closed D18982: prevent assertion in regex load.
Thu, Feb 14, 7:20 AM · Frameworks, Kate
cullmann added a comment to D18996: Fix building with namespaced Qt.

I think target_link_libraries is the right way to fix it, that's OK.
I am not that into the QT_.... macro magic, perhaps Volker can comment if that is ok ;)

Thu, Feb 14, 7:15 AM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann added a comment to D18982: prevent assertion in regex load.

I can push that for you, which user to use? "David Schulz" <paste your mail?>

Thu, Feb 14, 7:14 AM · Frameworks, Kate
cullmann accepted D18982: prevent assertion in regex load.

I assume Volker profiled it.
I think it is ok to just check if the logging is on.
99% of the syntax definitions are anyways bundled and are checked by the indexer for such obvious faults.

Thu, Feb 14, 7:05 AM · Frameworks, Kate
cullmann added a comment to D18951: HTML: highlight JSX, TypeScript & MustacheJS code in the <script> tag.

I can add more examples in "autotests/input/highlight.php", for all the cases of languages ​​included

Thu, Feb 14, 5:32 AM · Frameworks, Kate
cullmann accepted D18995: Explicitly link against KAuth.

OK, Thanks!

Thu, Feb 14, 5:31 AM · Frameworks, Kate

Tue, Feb 12

cullmann accepted D18907: Handle the case if createSpeller is passed an unavailable language.

Ok, thought lang ist still lang.

Tue, Feb 12, 9:54 PM · Frameworks
cullmann accepted D18948: CubeScript: fixes line continuation escape in strings.
Tue, Feb 12, 9:43 PM · Frameworks, Kate
cullmann updated the diff for D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt".

I would propose this, OK for you?

Tue, Feb 12, 8:16 PM · Frameworks, Kate
cullmann commandeered D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt".
Tue, Feb 12, 8:16 PM · Frameworks, Kate
cullmann committed R216:543bc6aa1b7f: fix unit test + improve output on fail to make debugging easier (authored by cullmann).
fix unit test + improve output on fail to make debugging easier
Tue, Feb 12, 8:06 PM
cullmann added a comment to D18734: Update octave.xml to Octave 4.2.0.

Good question:

Tue, Feb 12, 7:57 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann committed R216:9343341f9127: add some minimal howto for test adding (authored by cullmann).
add some minimal howto for test adding
Tue, Feb 12, 7:56 PM
cullmann committed R216:831f316f5671: fix unit tests, just renaming of ids (authored by cullmann).
fix unit tests, just renaming of ids
Tue, Feb 12, 7:56 PM
cullmann added a comment to D18894: [RFC] General config interface.

First: the current framework for settings suck, I feel guilty.
Second: I think a QVariant based approach would be nicer.

Tue, Feb 12, 7:51 PM · Frameworks, Kate
cullmann added a reviewer for D17599: Confirm closing muliple tabs.: ngraham.

Perhaps some feedback by ngraham :=)

Tue, Feb 12, 7:49 PM · Kate
cullmann abandoned D12096: Added feature to remember the zoom set on a host.
Tue, Feb 12, 7:44 PM · Falkon
cullmann commandeered D12096: Added feature to remember the zoom set on a host.

Hi, as this is dead >> 6 months, I will now abandon it.
If you want to start working again on it, please reopen it, thanks!

Tue, Feb 12, 7:44 PM · Falkon
cullmann committed R216:7e5803a22374: R Markdown: improve folding of blocks (authored by nibags).
R Markdown: improve folding of blocks
Tue, Feb 12, 7:42 PM
cullmann committed R216:33ad9cdec824: HTML: highlight JSX, TypeScript & MustacheJS code in the <script> tag (authored by nibags).
HTML: highlight JSX, TypeScript & MustacheJS code in the <script> tag
Tue, Feb 12, 7:42 PM
cullmann closed D18949: R Markdown: improve folding of blocks.
Tue, Feb 12, 7:42 PM · Frameworks, Kate
cullmann closed D18951: HTML: highlight JSX, TypeScript & MustacheJS code in the <script> tag.
Tue, Feb 12, 7:42 PM · Frameworks, Kate
cullmann added a reviewer for D18793: Handle text completion with block selection mode: KDevelop.

KDevelop uses the completion extensively, perhaps there is some opinion about this change.

Tue, Feb 12, 7:41 PM · Frameworks, Kate
cullmann added a comment to D12131: Use file mode in Preview add-on.

Friedrich: any opinion if that should just go in to improve the status quo?

Tue, Feb 12, 7:37 PM · Kate
cullmann requested changes to D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt".

Hmm, is source == binary directory allowed at all?
I would prefer to generate the files into a different directory, e.g. ${CMAKE_CURRENT_BINARY_DIR}/syntax/generated, that would avoid them poping up at all in the search by accident, or?

Tue, Feb 12, 7:35 PM · Frameworks, Kate
cullmann requested changes to D18734: Update octave.xml to Octave 4.2.0.

I think this is fine now, but I would like to have some autotests input file to have something we can later check for regressions.
Could you provide some MIT or otherwise freely licensed test file?
It must not cover all things, but at least some basic syntax and perhaps include some of your new things.
Thanks!

Tue, Feb 12, 7:33 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann requested changes to D18907: Handle the case if createSpeller is passed an unavailable language.

I think the const at the end for the signal is not wanted, otherwise, this seems to make sense for me.

Tue, Feb 12, 7:32 PM · Frameworks
cullmann accepted D18951: HTML: highlight JSX, TypeScript & MustacheJS code in the <script> tag.

I think this is a useful addition, the license is ok, there is a test case and no old tests regress.
I am not sure how good the coverage for the generated highlightings is, but at least no obvious issues.
Thanks for the contribution.
Btw., if you have more insight about the quality of the tests for the generated hl files and can improve that, a extra patch with more autotests is appreciated.
But maybe the coverage is already good ;=)
+1 for no hard-coded colors ;=)

Tue, Feb 12, 7:29 PM · Frameworks, Kate
cullmann accepted D18949: R Markdown: improve folding of blocks.

Looks reasonable, at least as far I read the diff in the folding test.

Tue, Feb 12, 7:26 PM · Frameworks, Kate
cullmann requested changes to D18948: CubeScript: fixes line continuation escape in strings.

You can add a unit test, you just need to add a small .syntax file in addition to the test, e.g. see

Tue, Feb 12, 7:24 PM · Frameworks, Kate
cullmann added a comment to D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable.

I am ok with the change, but I would like to have one test case in

Tue, Feb 12, 7:21 PM · Frameworks, Kate
cullmann added a comment to D17599: Confirm closing muliple tabs..

I can live with this.
Have other still issues with this patch?

Tue, Feb 12, 7:17 PM · Kate

Mon, Feb 11

cullmann accepted D18864: FlatBuffers schema syntax highlighting.

I think that is ok ;=)
Thanks for the contribution, and nice to read from you Harald, too ;=)

Mon, Feb 11, 6:01 AM · Frameworks, Kate

Sat, Feb 9

cullmann committed R39:7c42ba4a1aed: Improvements to completion (authored by thomassc).
Improvements to completion
Sat, Feb 9, 4:05 PM
cullmann closed D17932: Improvements to completion.
Sat, Feb 9, 4:05 PM · Frameworks, Kate, KTextEditor
cullmann committed R40:2fbda43574c0: DocManager: Don't show load trouble popup messages (authored by loh.tar).
DocManager: Don't show load trouble popup messages
Sat, Feb 9, 4:01 PM
cullmann closed D18117: DocManager: Don't show load trouble popup messages .
Sat, Feb 9, 4:01 PM · Kate
cullmann accepted D18117: DocManager: Don't show load trouble popup messages .

Thanks!

Sat, Feb 9, 4:00 PM · Kate
cullmann abandoned D18847: remove all Q_FOREACH occurences.

Accident 😊

Sat, Feb 9, 3:31 PM

Fri, Feb 8

cullmann committed R216:b1ecf6aa60c2: allow to compile without Q_FOREACH support (authored by cullmann).
allow to compile without Q_FOREACH support
Fri, Feb 8, 12:57 PM
cullmann committed R216:9a63d86689ac: convert Q_FOREACH => for (authored by cullmann).
convert Q_FOREACH => for
Fri, Feb 8, 12:57 PM
cullmann closed D18846: allow to compile without Q_FOREACH support.
Fri, Feb 8, 12:57 PM · Frameworks, Kate
cullmann updated the diff for D18846: allow to compile without Q_FOREACH support.

Missed 2 Q_FOREACH variants

Fri, Feb 8, 11:48 AM · Frameworks, Kate
cullmann requested review of D18847: remove all Q_FOREACH occurences.
Fri, Feb 8, 11:46 AM
cullmann requested review of D18846: allow to compile without Q_FOREACH support.
Fri, Feb 8, 11:41 AM · Frameworks, Kate

Wed, Feb 6

cullmann accepted D17932: Improvements to completion.

Then I will apply this.

Wed, Feb 6, 6:20 PM · Frameworks, Kate, KTextEditor

Mon, Feb 4

cullmann added a comment to D18664: Baloo engine: treat every non-success code as a failure.

I think this is a step into the right direction.
Thought I am still not sure if we not should go away from a own storage db for all this and port that over to e.g. use the tracker stuff.
Given that fixing the issues will be more or less a complete rewrite, too.
(I have some partly working port in my aged https://cgit.kde.org/clones/baloo/cullmann/tbaloo.git/)

Mon, Feb 4, 6:26 AM · Baloo, Frameworks

Sat, Feb 2

cullmann committed R39:cd18324b584d: skip cppstyle indentation test for !t 5.12.0 which has a broken regex… (authored by cullmann).
skip cppstyle indentation test for !t 5.12.0 which has a broken regex…
Sat, Feb 2, 5:17 PM
cullmann added a comment to D17971: Revive External Tools plugin.

Template sounds better than preset ;=)

Sat, Feb 2, 3:53 PM · Kate
cullmann added a comment to D17599: Confirm closing muliple tabs..

I would say the only directly visible error is that

Sat, Feb 2, 3:44 PM · Kate
cullmann accepted D18117: DocManager: Don't show load trouble popup messages .

I think this is the best we can do with reasonable effort.

Sat, Feb 2, 3:31 PM · Kate
cullmann added a comment to D17599: Confirm closing muliple tabs..

Sorry that I didn' respond earlier.

Sat, Feb 2, 3:29 PM · Kate
cullmann added a comment to D17932: Improvements to completion.

Should we give this some try and merge it?

Sat, Feb 2, 3:26 PM · Frameworks, Kate, KTextEditor
cullmann committed R39:f2e7a22be5e5: KateSpellCheckDialog: Remove action "Spellcheck Selection" (authored by loh.tar).
KateSpellCheckDialog: Remove action "Spellcheck Selection"
Sat, Feb 2, 3:24 PM
cullmann closed D18663: KateSpellCheckDialog: Remove action "Spellcheck Selection".
Sat, Feb 2, 3:24 PM · Frameworks, Kate
cullmann committed R875:5bb7e9cfcfff: Add --wmclass argument to linux completion files (authored by cullmann).
Add --wmclass argument to linux completion files
Sat, Feb 2, 3:23 PM
cullmann closed D18667: Add --wmclass argument to linux completion files.
Sat, Feb 2, 3:23 PM · Falkon
cullmann added a comment to D18667: Add --wmclass argument to linux completion files.

Will land the patch for the account with Terminus Est avatar.

Sat, Feb 2, 3:22 PM · Falkon
cullmann requested changes to D18116: Add TODO KF6 note .

Just to be sure:

Sat, Feb 2, 3:22 PM · Frameworks, Kate
cullmann abandoned D17437: SearchBar: Avoid malfunction with very large files.
Sat, Feb 2, 3:18 PM · Frameworks, Kate
cullmann commandeered D17437: SearchBar: Avoid malfunction with very large files.

We have cancel now ;=)

Sat, Feb 2, 3:18 PM · Frameworks, Kate
cullmann committed R216:941f17e1a979: Fix end of folding region in rules with lookAhead=true (authored by nibags).
Fix end of folding region in rules with lookAhead=true
Sat, Feb 2, 3:17 PM
cullmann closed D18516: Fix end of folding region in rules with lookAhead=true.
Sat, Feb 2, 3:17 PM · Frameworks, Kate
cullmann accepted D18516: Fix end of folding region in rules with lookAhead=true.

I think that lookAhead rules don't publish their length sounds like a sane improvement.

Sat, Feb 2, 3:15 PM · Frameworks, Kate
cullmann accepted D18663: KateSpellCheckDialog: Remove action "Spellcheck Selection".
Sat, Feb 2, 3:03 PM · Frameworks, Kate
cullmann added a comment to D18663: KateSpellCheckDialog: Remove action "Spellcheck Selection".

;=) given ::spellcheck() has the same magic, I don't think we really need to rename the function.
And spellcheckSelectionOrFromCursor is a bit strange, too.

Sat, Feb 2, 3:03 PM · Frameworks, Kate

Sat, Jan 26

cullmann requested changes to D18295: CTRL+Q should only close current window, not all windows.

Set right flag ;=) this needs a revision, as that should be an option.

Sat, Jan 26, 3:37 PM · Falkon
cullmann added a comment to D18509: Fixed Bug Which Caused Infinite Loop While Highlighting Kconfig Files.

Together with my other commit, this should now be fixed for good.
Even if again some definition is bad, at least not endless looping will occur.
Thanks for the bug finding & fixing!

Sat, Jan 26, 3:35 PM · Frameworks, Kate
cullmann committed R216:e50a762599be: Fixed Bug Which Caused Infinite Loop While Highlighting Kconfig Files (authored by cullmann).
Fixed Bug Which Caused Infinite Loop While Highlighting Kconfig Files
Sat, Jan 26, 3:34 PM
cullmann closed D18509: Fixed Bug Which Caused Infinite Loop While Highlighting Kconfig Files.
Sat, Jan 26, 3:34 PM · Frameworks, Kate
cullmann committed R216:320e1bccbb68: check for endless context switches (authored by cullmann).
check for endless context switches
Sat, Jan 26, 3:34 PM
cullmann accepted D18509: Fixed Bug Which Caused Infinite Loop While Highlighting Kconfig Files.

I added a test and will push this fix now.

Sat, Jan 26, 3:33 PM · Frameworks, Kate
cullmann added a comment to D18509: Fixed Bug Which Caused Infinite Loop While Highlighting Kconfig Files.

Git commit 320e1bccbb68dc21d43be0d0c7067866b96fd7be by Christoph Cullmann.
Committed on 26/01/2019 at 15:27.
Pushed by cullmann into branch 'master'.

Sat, Jan 26, 3:28 PM · Frameworks, Kate
cullmann added a comment to D18509: Fixed Bug Which Caused Infinite Loop While Highlighting Kconfig Files.

I can reproduce it, I will add a test ;=)

Sat, Jan 26, 3:19 PM · Frameworks, Kate

Fri, Jan 25

cullmann added a comment to D18509: Fixed Bug Which Caused Infinite Loop While Highlighting Kconfig Files.

I thought I had a endless loop/recursion detection, bad :/
Will take a look.

Fri, Jan 25, 11:37 AM · Frameworks, Kate

Thu, Jan 24

cullmann added a comment to D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection.

Either one would need to expose more info from the xml highlighting definitions or as poor mans fix provide some config entry to allow people themself to specify which () "" .... pairs the want to have handled globall with minimal defaults.

Thu, Jan 24, 2:22 PM · Frameworks, Kate

Tue, Jan 22

cullmann added a comment to D18116: Add TODO KF6 note .

I would not change that here, I would just ignore it in the application, as said in the other diff.

Tue, Jan 22, 12:14 PM · Frameworks, Kate

Mon, Jan 21

cullmann added a comment to D18117: DocManager: Don't show load trouble popup messages .

Hmm, but not with the

Mon, Jan 21, 7:15 PM · Kate
cullmann added a comment to D18117: DocManager: Don't show load trouble popup messages .
  • if we just keep the code in ktexteditor as is
  • we should just set openSuccess to false if we have an doc->openingError() and the document is empty

    Um, I think that are two differend suggestions. So, well, yes, without to change the logic in D18116 (but still apply that to remove unneded text) it work as needed. On the other hand is it that way not "full right", for me is some overlenght or encoding warning not an "open error".
Mon, Jan 21, 2:36 PM · Kate

Sun, Jan 20

cullmann added a comment to D17241: WIP:Disable highlighting after 512 characters on a line..

Sorry to chime in that late ;=)

Sun, Jan 20, 1:32 PM · Frameworks, Kate
cullmann requested changes to D18125: KateStatusBar: Add dictionary button.

I played with this patch now ;)

Sun, Jan 20, 1:01 PM · Frameworks, Kate