cullmann (Christoph Cullmann)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 30 2015, 8:46 PM (167 w, 4 d)
Availability
Available

Recent Activity

Sun, Oct 14

cullmann added a comment to D16169: Add option to close Kate when last file closes.

I think that is very confusing ;=)
I can understand the logic behind: all views close => application close
But I don't really think that: all views close => empty document => that view close => application close is really something that is very understandable

Sun, Oct 14, 10:43 AM · Kate
cullmann accepted D16169: Add option to close Kate when last file closes.

Then I would say we accept this as is, default off.

Sun, Oct 14, 10:08 AM · Kate

Sat, Oct 13

cullmann accepted D16054: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files.

Looks good to me, much nicer than before.
Thanks!

Sat, Oct 13, 2:11 PM · Kate
cullmann accepted D15804: Fix Duplicates on Quick Open File.

had time to try it with my linux.git clone.
Works reasonable fast, like the last implementation.
If you add copyright headers to the new files, I think this can go in.

Sat, Oct 13, 2:09 PM · Kate
cullmann added a comment to D16169: Add option to close Kate when last file closes.

The use-case for keeping Kate open is e.g. if you have projects in the projects plugin open, then it is not that uncommon to just close all files and still wanting to have Kate stay open.
Thought, as one can enable that behavior again, I am not that against making "close on last view closed" the default.
Other opinions?

Sat, Oct 13, 1:58 PM · Kate

Thu, Oct 11

cullmann added a comment to D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer.

not that I am a expert in delegates but from a glance the interface part looks ok.
I would have no issues with merging this.
It is an optional feature, we have one user.
We can still evolve this interface with some Vx version if bad issues are discovered after some usage in KDevelop and do a cleanup for KF6.

Thu, Oct 11, 8:41 AM · Frameworks, Kate
cullmann added a comment to D15804: Fix Duplicates on Quick Open File.

@brauch: have you tried this patch and played bit if it makes it better or worse?

Thu, Oct 11, 8:39 AM · Kate
cullmann added a comment to D14632: keyword rule: Spport for keywords inclusion from another language/file.

Hi, I still need to test this.
For the enum, I have no issue with scoped enums, but I think something like

Thu, Oct 11, 8:38 AM · Frameworks, Kate
cullmann added a comment to D15804: Fix Duplicates on Quick Open File.

Sorry ;=)
I need some time to test this.
I appreciate the improvements but want to give i a try on some large projects locally.

Thu, Oct 11, 8:35 AM · Kate

Sun, Oct 7

cullmann added a comment to D16018: Fix align of doxygen comments.

Hi, thanks for the patch to improve the indentation handling.
A case to reproduce would help.
For me, the identation is messed up in Kate if I do indent/unindent of such comments and the "keep extra spaces" option is off.
But I think that has nothing to do with this bug.

Sun, Oct 7, 4:15 PM · KDevelop, Frameworks, Kate

Fri, Oct 5

cullmann added a comment to D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer.

As we have a usecase for this (the extension in KDevelop) I am ok if that goes in, if the extension in KDevelop is going in, too, as consumer.
We can still fix minor issues in the KF6 iteration, they will never be found if it is not there and used.

Fri, Oct 5, 7:53 PM · Frameworks, Kate

Sun, Sep 30

cullmann committed R40:1aa6aeca93ad: avoid 30 second timeout for tools like git (authored by cullmann).
avoid 30 second timeout for tools like git
Sun, Sep 30, 4:58 PM

Sat, Sep 29

cullmann committed R216:9e039a669f8f: avoid that the main context can be #poped (authored by cullmann).
avoid that the main context can be #poped
Sat, Sep 29, 3:47 PM
cullmann closed D15835: avoid that the main context can be #poped.
Sat, Sep 29, 3:47 PM · Frameworks, Kate
cullmann added a comment to D15773: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new Solarized schemes.

Thanks for the examples, with that I could reproduce and introduce some hard guard for such cases.
Better broken highlighting then an endless hanging application.
https://phabricator.kde.org/D15836

Sat, Sep 29, 3:43 PM · Frameworks, Kate
cullmann committed R216:899ce3e7bb6e: Endless state transition guard (authored by cullmann).
Endless state transition guard
Sat, Sep 29, 3:41 PM
cullmann closed D15836: Endless state transition guard.
Sat, Sep 29, 3:41 PM · Frameworks, Kate
cullmann added reviewers for D15835: avoid that the main context can be #poped: vkrause, nibags.
Sat, Sep 29, 3:40 PM · Frameworks, Kate
cullmann accepted D15292: Use lambdas instead of QSignalMapper.

I think it is ok, as is.
Better than the old code.

Sat, Sep 29, 3:40 PM · Kate
cullmann requested review of D15836: Endless state transition guard.
Sat, Sep 29, 3:37 PM · Frameworks, Kate
cullmann added a comment to T9771: Main context can be #poped.

see https://phabricator.kde.org/D15835

Sat, Sep 29, 3:12 PM · Framework: Syntax Highlighting
cullmann added a comment to T9771: Main context can be #poped.

I think "poping" the main context is evil ;=)

Sat, Sep 29, 3:11 PM · Framework: Syntax Highlighting
cullmann requested review of D15835: avoid that the main context can be #poped.
Sat, Sep 29, 3:11 PM · Frameworks, Kate
cullmann closed T9539: Optimize syntax highlighting framework as Resolved.

I think it is ok enough ATM ;=)

Sat, Sep 29, 2:51 PM · Framework: Syntax Highlighting

Fri, Sep 28

cullmann committed R40:72e2570fb171: handle 'on all activities' (authored by cullmann).
handle 'on all activities'
Fri, Sep 28, 12:54 PM
cullmann added a comment to D15804: Fix Duplicates on Quick Open File.

We have some bugs complaining about the quick open speed, like https://bugs.kde.org/show_bug.cgi?id=399151

Fri, Sep 28, 12:14 PM · Kate
cullmann added a comment to D15804: Fix Duplicates on Quick Open File.

Could you do some perf profile with e.g. hotspot to see what is the "slow" part?
Nothing against std::vector instead of QVector, we need no sharing here anyways.

Fri, Sep 28, 11:25 AM · Kate
cullmann added a comment to D15804: Fix Duplicates on Quick Open File.

In principle the code looks even cleaner this way, thought the speed should be profiled.
I assume it is a bit ugly to write a unit test for this.

Fri, Sep 28, 7:37 AM · Kate
cullmann committed R40:64c777bd8e55: fix handling of 'on all desktops' (authored by cullmann).
fix handling of 'on all desktops'
Fri, Sep 28, 5:34 AM

Thu, Sep 27

cullmann accepted D15773: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new Solarized schemes.

Ok,
I would say: this should go in to workaround the current issue.

Thu, Sep 27, 5:28 PM · Frameworks, Kate
cullmann added a comment to D14632: keyword rule: Spport for keywords inclusion from another language/file.

I can live with the second kind of loading state, but in any case one needs to fix the recursion detection and handling of nested included keyword lists.

Thu, Sep 27, 5:27 AM · Frameworks, Kate

Wed, Sep 26

cullmann added a comment to D15773: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new Solarized schemes.

Have you some backtrace from the crash?

Wed, Sep 26, 6:43 PM · Frameworks, Kate
cullmann accepted D15761: ECM requires CMake 3.0.

Ok ;=)

Wed, Sep 26, 10:50 AM · Kate

Tue, Sep 25

cullmann committed R216:a1806c8a75ca: Merge git://anongit.kde.org/syntax-highlighting (authored by cullmann).
Merge git://anongit.kde.org/syntax-highlighting
Tue, Sep 25, 11:59 AM

Tue, Sep 18

cullmann added a comment to D14632: keyword rule: Spport for keywords inclusion from another language/file.

I don't know if the added complexity for loading only keywords is needed, but in any case one needs some recursive keyword resolving with a cycle guard.
e.g. if you use a list that again includes another one.

Tue, Sep 18, 5:34 AM · Frameworks, Kate

Sep 15 2018

cullmann added a project to T9577: Publish Kate in the Microsoft Store: KDE Promo.

:=) Adding the promo-tag.

Sep 15 2018, 2:00 PM · KDE Promo, Kate, Windows
cullmann added a comment to T9577: Publish Kate in the Microsoft Store.

For screenshots: Are things like

Sep 15 2018, 1:51 PM · KDE Promo, Kate, Windows
cullmann added a comment to T9577: Publish Kate in the Microsoft Store.

For the icon assets, I added new exported sizes 44, 150 and 310 from the SVG to our git:

Sep 15 2018, 1:48 PM · KDE Promo, Kate, Windows
cullmann committed R40:071835f01f00: add some Windows app store compatible icons sizes (authored by cullmann).
add some Windows app store compatible icons sizes
Sep 15 2018, 1:47 PM

Sep 14 2018

cullmann claimed T9577: Publish Kate in the Microsoft Store.

Perhaps somebody needs to take care.

Sep 14 2018, 6:15 AM · KDE Promo, Kate, Windows

Sep 13 2018

cullmann accepted D15485: Paint code folding marker only for multiline code folding regions.

My fault during porting :P

Sep 13 2018, 7:02 PM · Frameworks, Kate
cullmann added a comment to D14632: keyword rule: Spport for keywords inclusion from another language/file.

If you have no time for the wanted refactoring, I can do that this weekend and commit this, the syntax highlighting format changes are good as is ;=)

Sep 13 2018, 7:00 PM · Frameworks, Kate
cullmann added a comment to D15485: Paint code folding marker only for multiline code folding regions.

The hash update in katehighlight.cpp is the issue, Dominik has a fix for that now ;)

Sep 13 2018, 6:58 PM · Frameworks, Kate

Sep 11 2018

cullmann accepted D15420: Intialize m_lastPosition.

Reasonable fix. Thanks!

Sep 11 2018, 11:24 AM · Frameworks, Kate

Sep 10 2018

cullmann requested changes to D14632: keyword rule: Spport for keywords inclusion from another language/file.

Please unite the includedDefinitions()
Beside that, I think it would make sense to have the resolveIncludeKeywords() part inside the KeywordList class, then we don't need that many friends.

Sep 10 2018, 10:11 AM · Frameworks, Kate
cullmann accepted D15397: Perl: fix brackets, variables, string references and others.

Nice, looks a lot better in the comparison screenshots.
I had this issues in my own scripts, too, but was too dumb to fix that myself, thanks ;=)

Sep 10 2018, 8:15 AM · Frameworks, Kate
cullmann added a comment to D14632: keyword rule: Spport for keywords inclusion from another language/file.

The <include>properties##CSS</include> variant is really just like what I wanted, too!
Nice.
Only nitpick API wise: I would not expose the difference between includedDefinitions and includedKeywordDefinitions, I would just like to have all included definitions in includedDefinitions (and the docs altered that this covers all kind of includes)
Beside making the API more complex I see no benefit in differentiating between that.

Sep 10 2018, 6:42 AM · Frameworks, Kate
cullmann accepted D15390: Bash: fix parameter & brace expansion.

Looks better, thanks.

Sep 10 2018, 5:14 AM · Frameworks, Kate

Sep 9 2018

cullmann accepted D15370: Scripting: isCode() returns false for dsAlert text.
Sep 9 2018, 10:36 AM · Frameworks, Kate

Sep 8 2018

cullmann accepted D15358: Unit test: Check all shipped themes for completeness.

+1 ;=)

Sep 8 2018, 9:21 PM · Frameworks, Kate
cullmann committed R39:7e6daf814524: fix ebn issues (authored by cullmann).
fix ebn issues
Sep 8 2018, 6:38 PM
cullmann committed R39:8fbc7226006e: fix ebn issues (authored by cullmann).
fix ebn issues
Sep 8 2018, 6:36 PM
cullmann committed R216:d88b84e47878: fix some ebn issues (authored by cullmann).
fix some ebn issues
Sep 8 2018, 6:30 PM
cullmann committed R39:d9161ee8ad5f: use R Script hl for R indent tests (authored by cullmann).
use R Script hl for R indent tests
Sep 8 2018, 4:03 PM
cullmann added a comment to D15350: Unit tests for the R indent script.

I needed to adjust R => r as mode, as the basename of the file is used for that, which is r.
Seems to work locally that way, otherwise I got:

Sep 8 2018, 3:57 PM · Frameworks, Kate
cullmann committed R39:4c17dde71e20: Unit tests for the R indent script (authored by cullmann).
Unit tests for the R indent script
Sep 8 2018, 3:56 PM
cullmann closed D15350: Unit tests for the R indent script.
Sep 8 2018, 3:56 PM · Frameworks, Kate
cullmann added a comment to D15350: Unit tests for the R indent script.

Ok ;=)
Have pushed the indenter change, need to rebuild my local stuff here with kdesrc-build and will apply + test this change then, too again.
Hope to see more contributions, guess R users will like improved indenting ;=)

Sep 8 2018, 3:02 PM · Frameworks, Kate
cullmann committed R39:57a531ed368c: Update of the R indent script (authored by cullmann).
Update of the R indent script
Sep 8 2018, 2:55 PM
cullmann closed D15349: Update of the R indent script.
Sep 8 2018, 2:55 PM · Frameworks, Kate
cullmann added a comment to D15350: Unit tests for the R indent script.

To push, you need some developer account, then you can just push to git.kde.org.
It is no problem for me to just do that for you, like last time.

Sep 8 2018, 2:54 PM · Frameworks, Kate
cullmann accepted D15349: Update of the R indent script.
Sep 8 2018, 2:46 PM · Frameworks, Kate
cullmann accepted D15350: Unit tests for the R indent script.

Hi, thanks for that!
Can you push yourself or shall I push your indenter + tests?
Thanks for taking the time to create some tests!

Sep 8 2018, 2:45 PM · Frameworks, Kate

Sep 3 2018

cullmann added inline comments to R216:376311622d37: forbid sub-rules.
Sep 3 2018, 7:20 AM
cullmann added a comment to T9539: Optimize syntax highlighting framework.

:=) Lets see what we get as reports after 5.50 is released in the next days.
I think the current state is already ok, should be again "as fast" as used, perhaps bit more memory overhead due to the changes in KTextEditor.
Or I did break all things :)
At least in AbsInt it now compiles & tests nightly in the CI, all fine. Static build works nicely.

Sep 3 2018, 7:18 AM · Framework: Syntax Highlighting

Sep 2 2018

cullmann added a comment to T9539: Optimize syntax highlighting framework.

Perhaps that will help, in KTextEditor we do something similar for the hash to cache folding starts/ends.

Sep 2 2018, 7:15 PM · Framework: Syntax Highlighting
cullmann added a comment to D12587: Indentation script for R.

I normally follow the steps on

Sep 2 2018, 7:13 PM · Frameworks, Kate
cullmann added a comment to D12587: Indentation script for R.

And btw., thanks that you work on that stuff!

Sep 2 2018, 6:42 PM · Frameworks, Kate
cullmann added a comment to D12587: Indentation script for R.

Hi,
the message means you need to update the extra-cmake-modules.
How did you compile the stuff? If you use kdesrc-build, I would just let that run once more.

Sep 2 2018, 6:42 PM · Frameworks, Kate
cullmann committed R39:784302a921b8: empty R test skeleton (authored by cullmann).
empty R test skeleton
Sep 2 2018, 6:40 PM
cullmann added a comment to D12587: Indentation script for R.

You might need a .kateconfig in the R folder like in e.g. the cstyle folder which tells "use R highlighting and R indenter"

Sep 2 2018, 6:37 PM · Frameworks, Kate
cullmann added a comment to D12587: Indentation script for R.

I added these lines

Sep 2 2018, 6:36 PM · Frameworks, Kate
cullmann added a comment to T9539: Optimize syntax highlighting framework.

I am still bit unhappy with the

Sep 2 2018, 6:33 PM · Framework: Syntax Highlighting
cullmann added a comment to D12587: Indentation script for R.

here the basic idea:

Sep 2 2018, 6:31 PM · Frameworks, Kate
cullmann added a comment to D12587: Indentation script for R.

You don't need to commit them.
You just can add them locally test by test and after each one run the indent test locally.

Sep 2 2018, 6:23 PM · Frameworks, Kate
cullmann added a comment to T9539: Optimize syntax highlighting framework.

With some more micro-opts we are now at:

Sep 2 2018, 6:21 PM · Framework: Syntax Highlighting
cullmann added a comment to D12587: Indentation script for R.

The easiest way is just to put the test in the autotests input like for other highlighters and then run the indent test, that will pick this up and tell you what happens.

Sep 2 2018, 6:19 PM · Frameworks, Kate
cullmann committed R216:84e5d2157fb9: more micro-optimizations for internal API, we can use inlining and we don't… (authored by cullmann).
more micro-optimizations for internal API, we can use inlining and we don't…
Sep 2 2018, 6:18 PM
cullmann added a comment to T9539: Optimize syntax highlighting framework.

(I use an optimized static build with framepointers for profiling, btw., if you wonder why the stuff is all in the benchmark binary)

Sep 2 2018, 6:06 PM · Framework: Syntax Highlighting
cullmann added a comment to T9539: Optimize syntax highlighting framework.

With the latest micro-optimizations we have this profile for the highlighter benchmark:

# Children      Self  Command          Shared Object          Symbol                                                                                                                                       
# ........  ........  ...............  .....................  .............................................................................................................................................
#
    90.32%     0.00%  highlighter_ben  highlighter_benchmark  [.] QMetaMethod::invoke
    90.32%     0.00%  highlighter_ben  highlighter_benchmark  [.] QTest::TestMethods::invokeTests
    90.32%     0.00%  highlighter_ben  highlighter_benchmark  [.] QTest::qExec
    90.32%     0.00%  highlighter_ben  highlighter_benchmark  [.] QTest::qRun
    90.32%     0.00%  highlighter_ben  highlighter_benchmark  [.] main
    90.32%     0.00%  highlighter_ben  libc-2.27.so           [.] __libc_start_main
    90.32%     0.00%  highlighter_ben  [unknown]              [.] 0x41fd89415541f689
    90.24%     0.00%  highlighter_ben  highlighter_benchmark  [.] HighlighterBenchmark::benchmarkHighlight
    90.24%     0.00%  highlighter_ben  highlighter_benchmark  [.] QTest::TestMethods::invokeTest
    90.24%     0.00%  highlighter_ben  highlighter_benchmark  [.] QTest::TestMethods::invokeTestOnData
    82.93%    23.36%  highlighter_ben  highlighter_benchmark  [.] KSyntaxHighlighting::AbstractHighlighter::highlightLine
    32.01%     1.10%  highlighter_ben  highlighter_benchmark  [.] KSyntaxHighlighting::RegExpr::doMatch
    27.51%     1.04%  highlighter_ben  highlighter_benchmark  [.] QRegularExpression::match
    18.69%     3.92%  highlighter_ben  highlighter_benchmark  [.] QRegularExpressionPrivate::doMatch
     6.87%     0.59%  highlighter_ben  highlighter_benchmark  [.] safe_pcre2_match_16
     6.28%     1.00%  highlighter_ben  highlighter_benchmark  [.] pcre2_match_16
     5.64%     1.59%  highlighter_ben  highlighter_benchmark  [.] KSyntaxHighlighting::KeywordListRule::doMatch
     5.38%     5.38%  highlighter_ben  highlighter_benchmark  [.] findChar
     4.73%     2.01%  highlighter_ben  highlighter_benchmark  [.] pcre2_jit_match_16
     4.50%     0.23%  highlighter_ben  highlighter_benchmark  [.] QRegularExpressionPrivate::compilePattern
     4.32%     3.00%  highlighter_ben  highlighter_benchmark  [.] QHash<KSyntaxHighlighting::Rule*, int>::insert
     3.86%     3.63%  highlighter_ben  libc-2.27.so           [.] malloc
     3.77%     2.54%  highlighter_ben  highlighter_benchmark  [.] KSyntaxHighlighting::StringDetect::doMatch
     3.64%     0.00%  highlighter_ben  [unknown]              [.] 0x00007ffc26c1c390
     2.88%     2.79%  highlighter_ben  libc-2.27.so           [.] cfree@GLIBC_2.2.5
     2.55%     0.68%  highlighter_ben  highlighter_benchmark  [.] pcre2_match_data_create_from_pattern_16
     2.41%     0.55%  highlighter_ben  highlighter_benchmark  [.] pcre2_compile_16
     2.36%     2.36%  highlighter_ben  libc-2.27.so           [.] _int_free
     2.27%     2.27%  highlighter_ben  highlighter_benchmark  [.] KSyntaxHighlighting::KeywordList::contains
     2.27%     2.27%  highlighter_ben  highlighter_benchmark  [.] qt_compare_strings
     2.24%     0.27%  highlighter_ben  highlighter_benchmark  [.] QRegularExpressionPrivate::optimizePattern
     2.22%     2.18%  highlighter_ben  highlighter_benchmark  [.] QReadWriteLock::unlock
     1.94%     0.32%  highlighter_ben  highlighter_benchmark  [.] _fini
     1.91%     1.91%  highlighter_ben  highlighter_benchmark  [.] QReadWriteLock::tryLockForWrite
     1.91%     0.64%  highlighter_ben  highlighter_benchmark  [.] qtPcreCallback
     1.72%     1.63%  highlighter_ben  highlighter_benchmark  [.] QRegularExpressionMatch::~QRegularExpressionMatch
     1.29%     0.04%  highlighter_ben  highlighter_benchmark  [.] KSyntaxHighlighting::Definition::formats
     1.27%     1.18%  highlighter_ben  highlighter_benchmark  [.] KSyntaxHighlighting::Context::rules
     1.25%     0.00%  highlighter_ben  highlighter_benchmark  [.] KSyntaxHighlighting::DefinitionData::load
     1.19%     0.86%  highlighter_ben  highlighter_benchmark  [.] QHashData::free_helper
     1.18%     0.82%  highlighter_ben  highlighter_benchmark  [.] compile_regex
     1.14%     1.05%  highlighter_ben  highlighter_benchmark  [.] KSyntaxHighlighting::StateData::topCaptures
     1.11%     0.00%  highlighter_ben  highlighter_benchmark  [.] KSyntaxHighlighting::DefinitionData::loadHighlighting
     1.09%     0.95%  highlighter_ben  highlighter_benchmark  [.] KSyntaxHighlighting::WordDetect::doMatch
     1.09%     0.91%  highlighter_ben  highlighter_benchmark  [.] QThreadStorageData::get
     1.05%     1.00%  highlighter_ben  highlighter_benchmark  [.] QString::midRef
     0.96%     0.91%  highlighter_ben  highlighter_benchmark  [.] KSyntaxHighlighting::StateData::topContext
     0.95%     0.32%  highlighter_ben  highlighter_benchmark  [.] KSyntaxHighlighting::AbstractHighlighterPrivate::switchContext
     0.91%     0.86%  highlighter_ben  libc-2.27.so           [.] _int_malloc
     0.91%     0.18%  highlighter_ben  highlighter_benchmark  [.] replaceCaptures
     0.87%     0.87%  highlighter_ben  highlighter_benchmark  [.] KSyntaxHighlighting::DetectChar::doMatch
     0.87%     0.87%  highlighter_ben  libc-2.27.so           [.] __memset_avx2_unaligned_erms
     0.80%     0.75%  highlighter_ben  highlighter_benchmark  [.] default_free
     0.75%     0.00%  highlighter_ben  highlighter_benchmark  [.] KSyntaxHighlighting::DefinitionData::loadContexts
     0.70%     0.00%  highlighter_ben  highlighter_benchmark  [.] KSyntaxHighlighting::Context::load
     0.69%     0.60%  highlighter_ben  highlighter_benchmark  [.] default_malloc
     0.68%     0.45%  highlighter_ben  highlighter_benchmark  [.] QStringRef::indexOf
     0.68%     0.23%  highlighter_ben  highlighter_benchmark  [.] QVector<int>::reallocData
     0.68%     0.63%  highlighter_ben  highlighter_benchmark  [.] KSyntaxHighlighting::Detect2Char::doMatch
     0.64%     0.14%  highlighter_ben  highlighter_benchmark  [.] QRegularExpressionMatch::capturedTexts
     0.59%     0.59%  highlighter_ben  highlighter_benchmark  [.] pcre2_match_context_create_16
     0.59%     0.54%  highlighter_ben  highlighter_benchmark  [.] QRegularExpression::~QRegularExpression
     0.57%     0.00%  highlighter_ben  highlighter_benchmark  [.] KSyntaxHighlighting::RegExpr::doLoad
     0.57%     0.00%  highlighter_ben  highlighter_benchmark  [.] KSyntaxHighlighting::Rule::load
     0.55%     0.55%  highlighter_ben  libc-2.27.so           [.] __memmove_avx_unaligned_erms
Sep 2 2018, 6:05 PM · Framework: Syntax Highlighting
cullmann committed R216:2e79464421af: some micro-optimizations (authored by cullmann).
some micro-optimizations
Sep 2 2018, 6:03 PM
cullmann committed R216:6616f3720811: some micro-optimizations (authored by cullmann).
some micro-optimizations
Sep 2 2018, 5:56 PM
cullmann added a comment to D15219: forbid sub-rules.

Documentation updated.
The regressions for highlightings outside the repo should be minimal, as we just ignore the suffix rules.

Sep 2 2018, 5:20 PM · Documentation, Frameworks, Kate
cullmann committed R40:8f32f2df2d7f: remove child rule description, no longer supported (authored by cullmann).
remove child rule description, no longer supported
Sep 2 2018, 5:19 PM
cullmann closed D15219: forbid sub-rules.
Sep 2 2018, 5:19 PM · Documentation, Frameworks, Kate
cullmann reopened D15219: forbid sub-rules.

Need to update the docs.

Sep 2 2018, 5:15 PM · Documentation, Frameworks, Kate
cullmann committed R216:376311622d37: forbid sub-rules (authored by cullmann).
forbid sub-rules
Sep 2 2018, 5:15 PM
cullmann closed D15219: forbid sub-rules.
Sep 2 2018, 5:15 PM · Documentation, Frameworks, Kate
cullmann added a comment to D15219: forbid sub-rules.

I will push this + adapt the kate.git docs for it.

Sep 2 2018, 5:14 PM · Documentation, Frameworks, Kate
cullmann updated subscribers of T9577: Publish Kate in the Microsoft Store.

I think the "Kate" team has no issues with this.

Sep 2 2018, 3:59 PM · KDE Promo, Kate, Windows
cullmann committed R216:1a642b017dc5: don't run the benchmark tests on the CI (authored by cullmann).
don't run the benchmark tests on the CI
Sep 2 2018, 3:52 PM
cullmann committed R216:7c08bbe690c3: highlight 20000 lines per testcase (authored by cullmann).
highlight 20000 lines per testcase
Sep 2 2018, 3:48 PM
cullmann committed R216:e435adb3e042: make highlighting benchmark more reproducable, we anyways want to measure this… (authored by cullmann).
make highlighting benchmark more reproducable, we anyways want to measure this…
Sep 2 2018, 3:24 PM
cullmann added a comment to D14632: keyword rule: Spport for keywords inclusion from another language/file.

For the keywords stuff, one must keep in mind I altered the implementation of keyword lists a lot in:

Sep 2 2018, 3:12 PM · Frameworks, Kate
cullmann committed R216:a492c36d3ca5: Tune KeywordList lookup & avoid allocations for implicit capture group (authored by cullmann).
Tune KeywordList lookup & avoid allocations for implicit capture group
Sep 2 2018, 3:11 PM
cullmann closed D15217: Tune KeywordList lookup & avoid allocations for implicit capture group.
Sep 2 2018, 3:11 PM · Frameworks, Kate
cullmann added a comment to D15219: forbid sub-rules.

::load will skip over no longer supported sub-rules, beside minimal breakage for non-shipped hls, all should be fine (the suffixes will lack HL)

Sep 2 2018, 3:03 PM · Documentation, Frameworks, Kate
cullmann added a comment to D15219: forbid sub-rules.

Done with all shipped things.

Sep 2 2018, 3:01 PM · Documentation, Frameworks, Kate
cullmann updated the diff for D15219: forbid sub-rules.

fix comments in schema, no child rules

Sep 2 2018, 3:00 PM · Documentation, Frameworks, Kate
cullmann updated the diff for D15219: forbid sub-rules.

remove sub-rules support

Sep 2 2018, 2:58 PM · Documentation, Frameworks, Kate