- User Since
- Jul 30 2015, 8:46 PM (262 w, 2 d)
Tue, Jul 14
Hi, just to avoid any wasted work:
Sat, Jul 11
Ben activated the APPX stuff
Jun 21 2020
I think having 44x44 and 150x150 icons is just a matter of scaling the ones we have, they are a SVG anyways.
I think the hard part is that somebody needs to check if all things work ok for the binary factory builds and later care about the reported issues.
Jun 15 2020
Jun 8 2020
If somebody else would test this and we can agree that this is a nicer way to hard-code breeze icons compared to having that code in kiconthemes it would make sense.
Jun 7 2020
May 29 2020
May 28 2020
May 22 2020
;=) Actually, I just missed this request, sorry.
May 20 2020
May 18 2020
I think it makes sense to have just "Raku", the world at large (like me) only recognizes Perl 5 as Perl .P
I think this is very good thing to have.
But perhaps we just should add that to the README.md that is prominently shown on e.g. https://invent.kde.org/frameworks/syntax-highlighting
The README anyways already contains a "Adding unit tests for a syntax definition" that could be replaced with this.
Hmm, looks better for me, too.
Let's go with this at the moment.
If it creates issues, we can still revert it again.
Thanks for taking care of this.
May 15 2020
Sure, thanks for the improvement!
Hmm, right, didn't think about that :(
Guess if we want to have this, we need to improve the read/writeConfig functions.
May 9 2020
see e.g. here for a start of using the right heights inside the renderer.
Same here ;=) Thanks a lot for the work on all this issues!
Looks fine for me, thanks for improvement!
Looking at the code, might it make more sense to just move away from the fixed height we have?
It isn't used that often and in most cases one could just query the height of the current line.
That would solve this issue without needing any hacks for the rendering I think.
Apr 27 2020
Apr 26 2020
I tried the current version.
For me this looks OK now.
Thought I would like to have more people trying this out before we merge.
Apr 25 2020
Ok, I see, there is an extra request for the new hl test file.
Then let's approve this one.
Apr 19 2020
Hmm, after applying this patch, for me, no text is visible at all.
By selecting a bit stuff, one at least sees an outline (CMakeLists.txt of ktexteditor toplevel dir).
Apr 18 2020
I appreciate work on this issue.
I am not sure about how well this "hack" will solve the issue, thought.
I will give it a try here in any case.
Apr 15 2020
Thanks ;=) Even with test.
Change looks reasonable, but could that testfile be added to our autotests directory? (or the file we have there extended)
The current auto test file is autotests/input/highlight.lgt I assume.
Apr 10 2020
Yes, please push, thanks!
Mar 26 2020
Thanks for the fix + regression test!
Cool +1 ;=)
Thanks for the contribution.
We use that at company, nice to have.
Mar 14 2020
True, guess I copied too large parts during my fix-up of this.
First let's have this, the current state is bad ;=)
Mar 13 2020
For the example from the bug this makes the difference between ~30 seconds on a 4 Ghz machine to << 1 second ;=)
Better, but VHDL hl is still very slow, need to take a deeper look into it :/
Yes, I will fix the issues and then commit this as one thingy.
Thanks for taking a look :=)
My colleague was very unhappy with the VHDL performance :P
The highlighting shouldn't take as long as a hardware simulator.
Mar 12 2020
remove useless output of stray azOffset var
Zoom is like all view stuff local, yes, I assume that is often not wanted.
But that is a orthogonal issue.
The same could be said for "dynamic word wrap", very seldom you want to set that for one view.
On the other side, for the global config, one has the settings dialog, same for "zoom", aka font size.
And btw., thanks a lot for taking care!
The vimode for sure has more need for love, if you have time ;=)
I think, one issue is, that <down> and <up> don't work that way in the test framework.
I reformulated the test with \down and \up and moved the asserts to verifies.
This works for me, will push this, please take a look if that is ok for you, too.
Mar 11 2020
I will try to take a look as soon as I have time, if nobody else is faster.
Just to confirm: Your newly added test case doesn't pass or some other test case randomly fails?
Mar 7 2020
Hmm, yes, seems to work again.
Let's close this then again.