cullmann (Christoph Cullmann)
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jul 30 2015, 8:46 PM (262 w, 2 d)
Availability
Available

Recent Activity

Tue, Jul 14

cullmann added a comment to T10243: Some KDE applications could use better icons.

Hi, just to avoid any wasted work:

Tue, Jul 14, 3:35 PM · KDE Applications, VDG

Sat, Jul 11

cullmann added a comment to T9580: Publish KDiff3 in the Microsoft Store.

Ben activated the APPX stuff

Sat, Jul 11, 3:18 PM · Windows

Jun 21 2020

cullmann added a comment to T9579: Publish Dolphin in the Microsoft Store.

I think having 44x44 and 150x150 icons is just a matter of scaling the ones we have, they are a SVG anyways.
I think the hard part is that somebody needs to check if all things work ok for the binary factory builds and later care about the reported issues.

Jun 21 2020, 12:58 PM · Dolphin, Windows

Jun 15 2020

cullmann committed R319:e6ce6b24152f: Merge branch 'fix-win-id-rendering' into 'master' (authored by cullmann).
Merge branch 'fix-win-id-rendering' into 'master'
Jun 15 2020, 3:53 AM

Jun 8 2020

cullmann added a comment to D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set.

That depends.
If somebody else would test this and we can agree that this is a nicer way to hard-code breeze icons compared to having that code in kiconthemes it would make sense.

Jun 8 2020, 10:59 AM · Frameworks

Jun 7 2020

cullmann committed R223:3ad9fc7028bb: allow unicode filenames to work on Windows, too (authored by cullmann).
allow unicode filenames to work on Windows, too
Jun 7 2020, 11:52 AM
cullmann committed R223:bb53266430ae: allow unicode filenames to work on Windows, too (authored by cullmann).
allow unicode filenames to work on Windows, too
Jun 7 2020, 11:27 AM

May 29 2020

cullmann committed R40:f63d953cc518: Use proper method to get first line (authored by mmassaro).
Use proper method to get first line
May 29 2020, 7:06 AM
cullmann committed R40:01dfda179de7: Fix "Run Current Document" so that it uses shebang or correct file path (authored by mmassaro).
Fix "Run Current Document" so that it uses shebang or correct file path
May 29 2020, 7:06 AM
cullmann committed R39:99eb9bfbb434: Add .diff to the file-changed-diff to enable mime detection on windows. (authored by sars).
Add .diff to the file-changed-diff to enable mime detection on windows.
May 29 2020, 6:33 AM
cullmann committed R40:f2016388e4e1: Preview addon: Better update delay logic. (authored by aa bb <kde@t.weebit.eu>).
Preview addon: Better update delay logic.
May 29 2020, 6:30 AM

May 28 2020

cullmann committed R216:ebb2a2da0486: Update Raku extensions in Markdown blocks (authored by nibags).
Update Raku extensions in Markdown blocks
May 28 2020, 7:19 PM
cullmann committed R216:70014ab33b16: Raku: fix fenced code blocks in Markdown (authored by nibags).
Raku: fix fenced code blocks in Markdown
May 28 2020, 7:19 PM

May 22 2020

cullmann accepted D28235: Add a simpler example.

;=) Actually, I just missed this request, sorry.

May 22 2020, 2:53 PM · Frameworks, Kate

May 20 2020

cullmann committed R216:78d207f24e43: Add collaboration guide in README (authored by nibags).
Add collaboration guide in README
May 20 2020, 3:24 PM

May 18 2020

cullmann accepted D29793: Rename Perl6 syntax to Raku.

I think it makes sense to have just "Raku", the world at large (like me) only recognizes Perl 5 as Perl .P

May 18 2020, 1:57 PM · Frameworks, Kate
cullmann added a comment to D29795: Add collaboration guide.

I think this is very good thing to have.
But perhaps we just should add that to the README.md that is prominently shown on e.g. https://invent.kde.org/frameworks/syntax-highlighting
The README anyways already contains a "Adding unit tests for a syntax definition" that could be replaced with this.

May 18 2020, 1:56 PM · Frameworks, Kate
cullmann committed R39:133b85866913: Make text always align with font base line (authored by xuetianweng).
Make text always align with font base line
May 18 2020, 1:52 PM
cullmann closed D29789: Make text always align with font base line.
May 18 2020, 1:52 PM · Frameworks, Kate
cullmann accepted D29789: Make text always align with font base line.

Hmm, looks better for me, too.
Let's go with this at the moment.
If it creates issues, we can still revert it again.
Thanks for taking care of this.

May 18 2020, 1:51 PM · Frameworks, Kate

May 15 2020

cullmann committed R216:f804af905ef3: Assign "Identifier" attribute to opening double quote instead of "Comment" (authored by cullmann).
Assign "Identifier" attribute to opening double quote instead of "Comment"
May 15 2020, 3:45 PM
cullmann closed D29735: Assign "Identifier" attribute to opening double quote instead of "Comment".
May 15 2020, 3:45 PM · Frameworks, Kate, Framework: Syntax Highlighting
cullmann added a comment to D29735: Assign "Identifier" attribute to opening double quote instead of "Comment".

Sure, thanks for the improvement!

May 15 2020, 3:45 PM · Frameworks, Kate, Framework: Syntax Highlighting
cullmann added a comment to D27844: Store and fetch complete view config in and from session config.

Hmm, right, didn't think about that :(
Guess if we want to have this, we need to improve the read/writeConfig functions.

May 15 2020, 3:43 PM · Frameworks, Kate

May 9 2020

cullmann added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

see e.g. here for a start of using the right heights inside the renderer.

May 9 2020, 2:31 PM · Frameworks, Kate
cullmann added a comment to D25339: update lineHeight if boundingRect indicates a larger value..
Looking at the code, might it make more sense to just move away from the fixed height we have?
It isn't used that often and in most cases one could just query the height of the current line.

I'd be all for that, provided it doesn't introduce any regressions in the rendered result nor in rendering time.

It could be trickier to implement than you think though?

May 9 2020, 2:16 PM · Frameworks, Kate
cullmann committed R40:2bac3af1c89f: Merge branch 'vejnar/kate-master' (authored by cullmann).
Merge branch 'vejnar/kate-master'
May 9 2020, 11:20 AM
cullmann committed R40:ba23be52ba3a: Highlighting Doc: expand explanation about XML files directory (authored by nibags).
Highlighting Doc: expand explanation about XML files directory
May 9 2020, 11:14 AM
cullmann committed R216:1e8466029c82: Bash: fix comments after escapes (authored by nibags).
Bash: fix comments after escapes
May 9 2020, 11:09 AM
cullmann closed D29354: Bash: fix comments after escapes.
May 9 2020, 11:09 AM · Frameworks, Kate
cullmann accepted D29354: Bash: fix comments after escapes.

Same here ;=) Thanks a lot for the work on all this issues!

May 9 2020, 11:09 AM · Frameworks, Kate
cullmann committed R216:0b6c88cfc167: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END (authored by nibags).
LaTeX: fix folding in \end{...} and in regions markers BEGIN-END
May 9 2020, 11:08 AM
cullmann closed D29521: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END.
May 9 2020, 11:08 AM · Frameworks, Kate
cullmann accepted D29521: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END.
May 9 2020, 11:08 AM · Frameworks, Kate
cullmann added a comment to D29521: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END.

Looks fine for me, thanks for improvement!

May 9 2020, 11:08 AM · Frameworks, Kate
cullmann added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

Looking at the code, might it make more sense to just move away from the fixed height we have?
It isn't used that often and in most cases one could just query the height of the current line.
That would solve this issue without needing any hacks for the rendering I think.

May 9 2020, 10:55 AM · Frameworks, Kate

Apr 27 2020

cullmann committed R877:9c1ca1f6065d: try 20.04.0 release (authored by cullmann).
try 20.04.0 release
Apr 27 2020, 11:10 AM

Apr 26 2020

cullmann committed R877:83f08e91e680: patch is inside all supported versions (authored by cullmann).
patch is inside all supported versions
Apr 26 2020, 3:43 PM
cullmann committed R877:d2dc5942a43f: newer versions have this inside, remove experimental patch (authored by cullmann).
newer versions have this inside, remove experimental patch
Apr 26 2020, 3:41 PM
cullmann committed R877:6079fa7337bb: purge dead patches (authored by cullmann).
purge dead patches
Apr 26 2020, 3:41 PM
cullmann committed R877:a2620078422c: up to current frameworks release 5.69.0 (authored by cullmann).
up to current frameworks release 5.69.0
Apr 26 2020, 3:36 PM
cullmann committed R39:14fef3f92144: fix drag'n'drop on left side border widget (authored by cullmann).
fix drag'n'drop on left side border widget
Apr 26 2020, 3:06 PM
cullmann added a reviewer for D25339: update lineHeight if boundingRect indicates a larger value.: Frameworks.

I tried the current version.
For me this looks OK now.
Thought I would like to have more people trying this out before we merge.
Some volunteers?

Apr 26 2020, 12:03 PM · Frameworks, Kate

Apr 25 2020

cullmann committed R40:445e826b8573: Merge branch 'gawin/kate-impr/initialize' (authored by cullmann).
Merge branch 'gawin/kate-impr/initialize'
Apr 25 2020, 1:44 PM
cullmann committed R216:7f4a425340cb: fix unit test refs (authored by cullmann).
fix unit test refs
Apr 25 2020, 1:40 PM
cullmann committed R216:559cda73cf57: Updated test file for Logtalk syntax highlighting (authored by cullmann).
Updated test file for Logtalk syntax highlighting
Apr 25 2020, 1:39 PM
cullmann closed D28870: Updated test file for Logtalk syntax highlighting.
Apr 25 2020, 1:39 PM · Frameworks, Kate
cullmann accepted D28870: Updated test file for Logtalk syntax highlighting.
Apr 25 2020, 1:39 PM · Frameworks, Kate
cullmann committed R216:d4d17b34f961: fix unit test refs (authored by cullmann).
fix unit test refs
Apr 25 2020, 1:26 PM
cullmann committed R216:bf2664ea7907: Update Logtalk language syntax support (authored by cullmann).
Update Logtalk language syntax support
Apr 25 2020, 1:25 PM
cullmann closed D28796: Update Logtalk language syntax support.
Apr 25 2020, 1:25 PM · Frameworks, Kate
cullmann accepted D28796: Update Logtalk language syntax support.

Ok, I see, there is an extra request for the new hl test file.
Then let's approve this one.

Apr 25 2020, 11:59 AM · Frameworks, Kate

Apr 19 2020

cullmann added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

Hmm, after applying this patch, for me, no text is visible at all.
By selecting a bit stuff, one at least sees an outline (CMakeLists.txt of ktexteditor toplevel dir).

Apr 19 2020, 12:55 PM · Frameworks, Kate

Apr 18 2020

cullmann added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

I appreciate work on this issue.
I am not sure about how well this "hack" will solve the issue, thought.
I will give it a try here in any case.

Apr 18 2020, 8:39 PM · Frameworks, Kate

Apr 15 2020

cullmann committed R216:1f1f03198aa7: TypeScript: add the "awaited" type operator (authored by nibags).
TypeScript: add the "awaited" type operator
Apr 15 2020, 6:17 PM
cullmann closed D28814: TypeScript: add the "awaited" type operator.
Apr 15 2020, 6:17 PM · Frameworks, Kate
cullmann accepted D28814: TypeScript: add the "awaited" type operator.

Thanks ;=) Even with test.

Apr 15 2020, 6:16 PM · Frameworks, Kate
cullmann requested changes to D28796: Update Logtalk language syntax support.

Change looks reasonable, but could that testfile be added to our autotests directory? (or the file we have there extended)
The current auto test file is autotests/input/highlight.lgt I assume.

Apr 15 2020, 6:16 PM · Frameworks, Kate

Apr 10 2020

cullmann added a comment to D27844: Store and fetch complete view config in and from session config.

Yes, please push, thanks!

Apr 10 2020, 11:09 AM · Frameworks, Kate

Mar 26 2020

cullmann committed R216:213d4bb197a3: LaTeX: fix math parentheses in optional labels (authored by nibags).
LaTeX: fix math parentheses in optional labels
Mar 26 2020, 3:48 PM
cullmann closed D28303: LaTeX: fix math parentheses in optional labels.
Mar 26 2020, 3:48 PM · Frameworks, Kate
cullmann accepted D28303: LaTeX: fix math parentheses in optional labels.

Thanks for the fix + regression test!

Mar 26 2020, 3:48 PM · Frameworks, Kate
cullmann committed R40:cec8df952696: [XMLTools Plugin] Port QRegExp to QRegularExpression (authored by ahmadsamir).
[XMLTools Plugin] Port QRegExp to QRegularExpression
Mar 26 2020, 3:09 PM
cullmann committed R216:517dccc95ecf: Add Inno Setup syntax, including embedded Pascal scripting (authored by zrax).
Add Inno Setup syntax, including embedded Pascal scripting
Mar 26 2020, 2:50 PM
cullmann closed D27660: Add Inno Setup syntax, including embedded Pascal scripting.
Mar 26 2020, 2:50 PM · Frameworks, Kate
cullmann accepted D27660: Add Inno Setup syntax, including embedded Pascal scripting.

Cool +1 ;=)
Thanks for the contribution.
We use that at company, nice to have.

Mar 26 2020, 2:48 PM · Frameworks, Kate

Mar 14 2020

cullmann committed R39:1527af3b5435: fix folding crash for folding of single line folds (authored by cullmann).
fix folding crash for folding of single line folds
Mar 14 2020, 6:51 PM
cullmann committed R216:b2ace3e804ad: Lua: add # as additional deliminator to activate auto-completion with… (authored by jpoelen).
Lua: add # as additional deliminator to activate auto-completion with…
Mar 14 2020, 5:11 PM
cullmann closed D28045: Lua: add # as additional deliminator to activate auto-completion with `#something`.
Mar 14 2020, 5:11 PM · Frameworks, Kate
cullmann accepted D28045: Lua: add # as additional deliminator to activate auto-completion with `#something`.

Ok ;=)

Mar 14 2020, 5:11 PM · Frameworks, Kate
cullmann committed R216:755904a6ff2e: C: remove ' as digit separator (authored by jpoelen).
C: remove ' as digit separator
Mar 14 2020, 4:22 PM
cullmann closed D28044: C: remove ' as digit separator.
Mar 14 2020, 4:22 PM · Frameworks, Kate
cullmann accepted D28044: C: remove ' as digit separator.

True, guess I copied too large parts during my fix-up of this.

Mar 14 2020, 4:21 PM · Frameworks, Kate
cullmann committed R216:c5f482ea4e82: remove stray empty line (authored by cullmann).
remove stray empty line
Mar 14 2020, 2:49 PM
cullmann committed R216:41375382ef69: add some comment about the skip offset stuff (authored by cullmann).
add some comment about the skip offset stuff
Mar 14 2020, 2:29 PM
cullmann committed R216:764957b1d23c: optimize dynamic regex matching (authored by cullmann).
optimize dynamic regex matching
Mar 14 2020, 2:27 PM
cullmann closed D28039: optimize dynamic regex matching.
Mar 14 2020, 2:27 PM · Frameworks, Kate
cullmann added a comment to D28039: optimize dynamic regex matching.

First let's have this, the current state is bad ;=)

Mar 14 2020, 2:27 PM · Frameworks, Kate

Mar 13 2020

cullmann added a comment to D28039: optimize dynamic regex matching.

For the example from the bug this makes the difference between ~30 seconds on a 4 Ghz machine to << 1 second ;=)

Mar 13 2020, 7:04 PM · Frameworks, Kate
cullmann requested review of D28039: optimize dynamic regex matching.
Mar 13 2020, 7:02 PM · Frameworks, Kate
cullmann added a comment to D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt.

Better, but VHDL hl is still very slow, need to take a deeper look into it :/

Mar 13 2020, 6:38 PM · Frameworks, Kate
cullmann committed R216:53436c13943b: fix regex rules wrongly marked as dynamic (authored by cullmann).
fix regex rules wrongly marked as dynamic
Mar 13 2020, 6:37 PM
cullmann committed R216:e6090be50f0d: extend indexer to detect dynamic=true regexes that have no place holders to… (authored by cullmann).
extend indexer to detect dynamic=true regexes that have no place holders to…
Mar 13 2020, 6:37 PM
cullmann closed D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt.
Mar 13 2020, 6:37 PM · Frameworks, Kate
cullmann added a comment to D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt.

Yes, I will fix the issues and then commit this as one thingy.
Thanks for taking a look :=)
My colleague was very unhappy with the VHDL performance :P
The highlighting shouldn't take as long as a hardware simulator.

Mar 13 2020, 4:50 PM · Frameworks, Kate

Mar 12 2020

cullmann updated the diff for D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt.

remove useless output of stray azOffset var

Mar 12 2020, 11:00 PM · Frameworks, Kate
cullmann added reviewers for D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt: nibags, dhaumann, vkrause.
Mar 12 2020, 11:00 PM · Frameworks, Kate
cullmann requested review of D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt.
Mar 12 2020, 10:59 PM · Frameworks, Kate
cullmann added a comment to D27844: Store and fetch complete view config in and from session config.

Zoom is like all view stuff local, yes, I assume that is often not wanted.
But that is a orthogonal issue.
The same could be said for "dynamic word wrap", very seldom you want to set that for one view.
On the other side, for the global config, one has the settings dialog, same for "zoom", aka font size.

Mar 12 2020, 10:40 PM · Frameworks, Kate
cullmann closed D27929: CMake syntax fixes.
Mar 12 2020, 10:38 PM · Frameworks, Kate
cullmann committed R216:39ad168cf350: CMake syntax fixes (authored by cullmann).
CMake syntax fixes
Mar 12 2020, 10:38 PM
cullmann added a comment to D27928: [VIM Mode] Add g<up> g<down> commands.

And btw., thanks a lot for taking care!
The vimode for sure has more need for love, if you have time ;=)

Mar 12 2020, 10:22 PM · Frameworks, Kate
cullmann committed R39:7fb4beff2a22: Merge branch 'arcpatch-D27928' (authored by cullmann).
Merge branch 'arcpatch-D27928'
Mar 12 2020, 10:22 PM
cullmann committed R39:33d97127f01f: fix unit test (authored by cullmann).
fix unit test
Mar 12 2020, 10:22 PM
cullmann closed D27928: [VIM Mode] Add g<up> g<down> commands.
Mar 12 2020, 10:22 PM · Frameworks, Kate
cullmann committed R39:736844969d2b: [VIM Mode] Add g<up> g<down> commands (authored by gikari).
[VIM Mode] Add g<up> g<down> commands
Mar 12 2020, 10:22 PM
cullmann accepted D27928: [VIM Mode] Add g<up> g<down> commands.
Mar 12 2020, 10:20 PM · Frameworks, Kate
cullmann added a comment to D27928: [VIM Mode] Add g<up> g<down> commands.

I think, one issue is, that <down> and <up> don't work that way in the test framework.
I reformulated the test with \down and \up and moved the asserts to verifies.
This works for me, will push this, please take a look if that is ok for you, too.

Mar 12 2020, 10:20 PM · Frameworks, Kate

Mar 11 2020

cullmann added a comment to D27928: [VIM Mode] Add g<up> g<down> commands.

I will try to take a look as soon as I have time, if nobody else is faster.
Just to confirm: Your newly added test case doesn't pass or some other test case randomly fails?

Mar 11 2020, 4:33 PM · Frameworks, Kate

Mar 7 2020

cullmann closed D27912: Draw inlineNotes after drawing word wrap marker.

Hmm, yes, seems to work again.
Let's close this then again.

Mar 7 2020, 9:09 PM · Frameworks, Kate