cullmann (Christoph Cullmann)
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 30 2015, 8:46 PM (220 w, 1 d)
Availability
Available

Recent Activity

Today

cullmann added inline comments to D24568: Provide clang-format target with a KDE Frameworks style file.
Sat, Oct 19, 3:42 PM · Build System, Frameworks
cullmann added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

Has somebody tested the current state?

Sat, Oct 19, 3:41 PM · Build System, Frameworks

Thu, Oct 17

cullmann added a comment to D24620: Windows MSVC compile fix.

Ok to push that? Would avoid the last patch in craft to build frameworks.

Thu, Oct 17, 6:37 PM · Frameworks
cullmann added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

Without the initializer change, the file works for me reasonable well, tried it again on KTextEditor.

Thu, Oct 17, 6:35 PM · Build System, Frameworks
cullmann committed R39:67a6031f0e3a: GIT_SILENT: application of coding style (authored by cullmann).
GIT_SILENT: application of coding style
Thu, Oct 17, 6:34 PM
cullmann updated the diff for D24568: Provide clang-format target with a KDE Frameworks style file.
  • avoid collapsing of constructor initializer lines
Thu, Oct 17, 6:31 PM · Build System, Frameworks
cullmann added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

you get collapsed stuff like;

Thu, Oct 17, 6:28 PM · Build System, Frameworks

Wed, Oct 16

cullmann added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

Do we want these, found in https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format?

# We use template< without space.
SpaceAfterTemplateKeyword: false

# macros for which the opening brace stays attached.
ForEachMacros:   [ foreach, Q_FOREACH, BOOST_FOREACH, forever, Q_FOREVER, QBENCHMARK, QBENCHMARK_ONCE ]

# Break constructor initializers before the colon and after the commas.
BreakConstructorInitializers: BeforeColon

added that

Wed, Oct 16, 9:21 PM · Build System, Frameworks
cullmann updated the diff for D24568: Provide clang-format target with a KDE Frameworks style file.
  • fix coding style issue, we don't want indented case labels
  • add initial docs
  • adjust style
  • just tell the user it will not work
Wed, Oct 16, 9:20 PM · Build System, Frameworks
cullmann committed R877:ae831f62a9c7: remove no longer needed patch (authored by cullmann).
remove no longer needed patch
Wed, Oct 16, 7:42 PM
cullmann committed R877:701263cb214f: update to latest plasma, no framework integration stuff on win (authored by cullmann).
update to latest plasma, no framework integration stuff on win
Wed, Oct 16, 6:48 PM

Tue, Oct 15

cullmann added a comment to D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree.

As an non-framework module, there is no need to follow the frameworks style, if not wanted.

Tue, Oct 15, 7:26 PM
cullmann committed R877:e5984a1a1fc8: enable .djvu support BUG: 412930 (authored by cullmann).
enable .djvu support BUG: 412930
Tue, Oct 15, 6:36 PM

Mon, Oct 14

cullmann added a comment to D24283: Add clang format file.

There will anyways be one "big" change in the history, but normally git will be able to handle that well by ignoring space changes for blame or diff.
I don't think without the aligning the change will be much smaller.

Mon, Oct 14, 8:28 AM · Plasma
cullmann committed R877:be5e46657785: try to blacklist less for macos (authored by cullmann).
try to blacklist less for macos
Mon, Oct 14, 7:11 AM

Sun, Oct 13

cullmann added a reviewer for D24568: Provide clang-format target with a KDE Frameworks style file: dfaure.

Perhaps David could give feedback if the file actually captures the intend to do proper KDE Frameworks/libs like formatting.
I had a mistake with the indented case statements, that should be fixed.

Sun, Oct 13, 8:25 PM · Build System, Frameworks
cullmann updated the diff for D24620: Windows MSVC compile fix.

Missed to add file with proper compiler guard :/

Sun, Oct 13, 8:17 PM · Frameworks
cullmann requested review of D24620: Windows MSVC compile fix.
Sun, Oct 13, 8:16 PM · Frameworks
cullmann committed R877:b4f92b6e5449: add patch to new 5.63, too (authored by cullmann).
add patch to new 5.63, too
Sun, Oct 13, 8:10 PM
cullmann added a comment to T11723: Translation of jekyll or hugo based websites .

:) nice!

Sun, Oct 13, 7:20 PM · Websites, Localization
cullmann committed R36:96282237fea2: properly enable hi-dpi support (authored by cullmann).
properly enable hi-dpi support
Sun, Oct 13, 5:17 PM
cullmann committed R260:37bb2e8f4d6d: properly enable hi-dpi support (authored by cullmann).
properly enable hi-dpi support
Sun, Oct 13, 5:00 PM
cullmann committed R318:0caab3c0a23c: properly enable hi-dpi support (authored by cullmann).
properly enable hi-dpi support
Sun, Oct 13, 4:34 PM
cullmann added a comment to T11723: Translation of jekyll or hugo based websites .

kate-editor.org should have the module enabled and you should be able to just add some .htaccess with such rules to the hugo static files dir.

Sun, Oct 13, 3:54 PM · Websites, Localization
cullmann added a comment to T9584: Publish Kile in the Microsoft Store.

Ah, you could add 150/310/44 icons to the icons folder, btw., that will avoid that we need to have that in the craft blueprints.

Sun, Oct 13, 3:48 PM · Kile, Windows
cullmann added a comment to T9584: Publish Kile in the Microsoft Store.

Great, the question is now: can you do some "release" that we have translations, too?
The nighlty stuff is lacking that.
Or do you think the english variant is sufficient for a start?

Sun, Oct 13, 3:40 PM · Kile, Windows
cullmann retitled D24568: Provide clang-format target with a KDE Frameworks style file from Provide clang-format target with a common KDE style file to Provide clang-format target with a KDE Frameworks style file.
Sun, Oct 13, 11:34 AM · Build System, Frameworks
cullmann accepted D24570: Fix kolflib_export.

Do you have some developer account to push that yourself? If not, I would go for applying for one, as you seem to care for this stuff and it will be much easier if you can push on your own.

Sun, Oct 13, 11:29 AM · Craft, KDE Games
cullmann added a comment to D24570: Fix kolflib_export.

Looks reasonable for me.

Sun, Oct 13, 11:27 AM · Craft, KDE Games
cullmann added a comment to T11723: Translation of jekyll or hugo based websites .

Hmm, beside that, can one not simply fix that by using a 404 handler that does the redirect? I did that once for the AbsInt page, just rewriting the url to the generic english page if the original url ended up in 404.

Sun, Oct 13, 11:24 AM · Websites, Localization
cullmann committed R877:098df5c92f4b: makes no sense to build stable releases without latest bugfixes (authored by cullmann).
makes no sense to build stable releases without latest bugfixes
Sun, Oct 13, 10:59 AM
cullmann committed R877:148f62bc637e: use frameworks 5.63 (authored by cullmann).
use frameworks 5.63
Sun, Oct 13, 10:59 AM

Sat, Oct 12

cullmann added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

I hope this file implements https://community.kde.org/Policies/Kdelibs_Coding_Style

Sat, Oct 12, 10:43 PM · Build System, Frameworks
cullmann added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

common KDE style file

There's no such thing as a common KDE style

Sat, Oct 12, 10:17 PM · Build System, Frameworks
cullmann accepted D24583: Remove Dependence on unistd.h and sys/time.h.

Looks reasonable for me, and should be C++11 API.

Sat, Oct 12, 4:19 PM · Craft, KDE Games
cullmann added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

If there are more deviations from the kdelibs/frameworks coding style, please tell me.

Sat, Oct 12, 4:16 PM · Build System, Frameworks
cullmann added a reviewer for D24568: Provide clang-format target with a KDE Frameworks style file: Frameworks.
Sat, Oct 12, 4:09 PM · Build System, Frameworks
cullmann added inline comments to D24568: Provide clang-format target with a KDE Frameworks style file.
Sat, Oct 12, 4:08 PM · Build System, Frameworks
cullmann updated the diff for D24568: Provide clang-format target with a KDE Frameworks style file.
  • add initial docs
Sat, Oct 12, 4:07 PM · Build System, Frameworks
cullmann added inline comments to D24283: Add clang format file.
Sat, Oct 12, 4:04 PM · Plasma
cullmann updated the diff for D24568: Provide clang-format target with a KDE Frameworks style file.
  • fix coding style issue, we don't want indented case labels
Sat, Oct 12, 4:03 PM · Build System, Frameworks
cullmann added inline comments to D24568: Provide clang-format target with a KDE Frameworks style file.
Sat, Oct 12, 11:17 AM · Build System, Frameworks
cullmann added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.
In D24568#545736, @apol wrote:

I'm not sure how this works, but would it be possible to have a target that only works on a patch? You usually want to make sure what you modified didn't diverge from the code.

Sat, Oct 12, 10:03 AM · Build System, Frameworks
cullmann added a comment to T11723: Translation of jekyll or hugo based websites .

Too bad that partially translated stuff doesn't work :/
I only read a bit in the above thread on discourse: is there actually a real bug report that requests support for this?

Sat, Oct 12, 10:01 AM · Websites, Localization
cullmann committed R993:c685d4d21fbd: Added KDE Games in craft(+kshisen) to craft/enabled-projects.yaml (authored by cullmann).
Added KDE Games in craft(+kshisen) to craft/enabled-projects.yaml
Sat, Oct 12, 9:53 AM

Fri, Oct 11

cullmann added a comment to D24283: Add clang format file.

This is just a base file for discussion.
Stuff like the mentioned case indentation can be adjusted to be frameworks conform.
For the alignment of comments, I am not sure, it makes the stuff a lot more readable in many cases and after the initial re-format you don't have a lot of jitter normally.

Fri, Oct 11, 7:10 PM · Plasma
cullmann added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

See D24568 for the draft of an ECM module that applies the Kate/KTextEditor/Artikulate style.
Is the same file as here, with sorting of includes, but with column limit.

Fri, Oct 11, 6:48 PM
cullmann added a comment to D24283: Add clang format file.

See D24568 for the draft of an ECM module that applies the Kate/KTextEditor/Artikulate style.
Is the same file as here, with sorting of includes, but with column limit.

Fri, Oct 11, 6:48 PM · Plasma
cullmann requested review of D24568: Provide clang-format target with a KDE Frameworks style file.
Fri, Oct 11, 6:46 PM · Build System, Frameworks
cullmann closed D24545: Add Some KDE Games to Craft Enabled Projects.

Created merge request for that

Fri, Oct 11, 3:14 PM · KDE Games, Craft
cullmann committed R877:5b499f84ccc2: Blueprint for KShisen (authored by cullmann).
Blueprint for KShisen
Fri, Oct 11, 3:10 PM
cullmann closed D24421: Blueprint for KShisen.
Fri, Oct 11, 3:10 PM · KDE Games, Craft
cullmann committed R877:4fb00dcc50fc: Add Blueprints for Dependencies for KPat (authored by cullmann).
Add Blueprints for Dependencies for KPat
Fri, Oct 11, 3:10 PM
cullmann closed D24440: Add Blueprints for Dependencies for KPat.
Fri, Oct 11, 3:10 PM · KDE Games, Craft
cullmann committed R877:e65e7cf3ccb4: use .2 (authored by cullmann).
use .2
Fri, Oct 11, 7:55 AM

Thu, Oct 10

cullmann added a comment to D24545: Add Some KDE Games to Craft Enabled Projects.

I think it would make more sense to first try this with the native msvc compiler, aka win64 as platform.
We can later still revert back to using mingw64 if that fails.

Thu, Oct 10, 7:45 PM · KDE Games, Craft
cullmann committed R877:bc907d46d566: wait for sha256 files (authored by cullmann).
wait for sha256 files
Thu, Oct 10, 7:21 PM
cullmann committed R877:b6af6fb1cd78: less patches with 19.08.2 (authored by cullmann).
less patches with 19.08.2
Thu, Oct 10, 7:19 PM
cullmann committed R877:fa2be3729100: less patches with 19.08.2 (authored by cullmann).
less patches with 19.08.2
Thu, Oct 10, 7:17 PM
cullmann committed R877:64373dfc317b: activate 19.08.2 release (authored by cullmann).
activate 19.08.2 release
Thu, Oct 10, 7:17 PM
cullmann added a comment to T11579: Unify navigation through sidebar categories/views.

I think tooltips are very disturbing for such toolview buttons.
You very often hover over them during switching and then you always get your stuff hidden by the tooltip.

Thu, Oct 10, 11:31 AM · Goal: Consistency, KDE Human Interface Guidelines, VDG
cullmann added a comment to D24440: Add Blueprints for Dependencies for KPat.

You can do that via merge request to

Thu, Oct 10, 8:57 AM · KDE Games, Craft
cullmann added a reviewer for D24440: Add Blueprints for Dependencies for KPat: vonreth.

Hannah can give perhaps some short feedback.

Thu, Oct 10, 6:57 AM · KDE Games, Craft

Wed, Oct 9

cullmann added a comment to D4363: Don't set gnu style parameter with Clang and MSVC.

Is this still relevant? If yes, from the diff, looks ok for me.

Wed, Oct 9, 6:14 PM · Build System, Frameworks
cullmann accepted D24355: TypeScript: update grammar and fixes.

Seems fine.
Does typescript-react.xml lack a version update?

Wed, Oct 9, 6:12 PM · Frameworks, Kate
cullmann accepted D24357: KateModeMenuList: force the vertical position above the button.

Ok with that.

Wed, Oct 9, 6:09 PM · Frameworks, Kate
cullmann committed R877:679a3959db6a: more hidpi stuff fixed (authored by cullmann).
more hidpi stuff fixed
Wed, Oct 9, 5:02 PM
cullmann added a reverting change for R260:769b6e17a0a1: fix fractional scaling: R260:0bdba41e1dbc: Revert "fix fractional scaling".
Wed, Oct 9, 2:06 PM
cullmann committed R260:0bdba41e1dbc: Revert "fix fractional scaling" (authored by cullmann).
Revert "fix fractional scaling"
Wed, Oct 9, 2:06 PM
cullmann committed R260:2ff212adc2ad: Revert "fix fractional scaling" (authored by cullmann).
Revert "fix fractional scaling"
Wed, Oct 9, 1:41 PM
cullmann added a reverting change for R260:113d418203aa: fix fractional scaling: R260:2ff212adc2ad: Revert "fix fractional scaling".
Wed, Oct 9, 1:41 PM
cullmann added a reverting change for R260:30014c280da0: port to non-deprecated API as told in comments: R260:964d098ff29d: Revert "port to non-deprecated API as told in comments".
Wed, Oct 9, 11:28 AM
cullmann committed R260:964d098ff29d: Revert "port to non-deprecated API as told in comments" (authored by cullmann).
Revert "port to non-deprecated API as told in comments"
Wed, Oct 9, 11:28 AM

Tue, Oct 8

cullmann committed R260:113d418203aa: fix fractional scaling (authored by cullmann).
fix fractional scaling
Tue, Oct 8, 8:25 PM
cullmann committed R260:769b6e17a0a1: fix fractional scaling (authored by cullmann).
fix fractional scaling
Tue, Oct 8, 8:22 PM
cullmann committed R260:64700e39e989: fix modify during iteration issue (authored by cullmann).
fix modify during iteration issue
Tue, Oct 8, 8:21 PM
cullmann committed R260:30014c280da0: port to non-deprecated API as told in comments (authored by cullmann).
port to non-deprecated API as told in comments
Tue, Oct 8, 7:00 PM
cullmann added a comment to T9589: Publish KDE Games Center in the Microsoft Store.

Don't you think this is a rather rude statement towards the people that contributed to these games?

Tue, Oct 8, 2:59 PM · Windows
cullmann added a comment to D24492: [FilteredDirIterator] Reduce stack pressure.

Yes, I think you want the concept of a loop with continue.

Tue, Oct 8, 12:39 PM · Baloo, Frameworks
cullmann added a comment to T9589: Publish KDE Games Center in the Microsoft Store.

?

Tue, Oct 8, 10:13 AM · Windows
cullmann committed R40:255a72f5b6b9: ensure outer layout set CCBUG: 412721 (authored by cullmann).
ensure outer layout set CCBUG: 412721
Tue, Oct 8, 8:54 AM
cullmann committed R40:d3e413fb7c9f: try to avoid nested layouts that we don't need (authored by cullmann).
try to avoid nested layouts that we don't need
Tue, Oct 8, 8:54 AM
cullmann committed R40:8b28d1e05012: ensure outer layout set CCBUG: 412721 (authored by cullmann).
ensure outer layout set CCBUG: 412721
Tue, Oct 8, 8:32 AM
cullmann committed R40:b795da45dfa6: try to avoid nested layouts that we don't need (authored by cullmann).
try to avoid nested layouts that we don't need
Tue, Oct 8, 8:14 AM

Mon, Oct 7

l10n daemon script <scripty@kde.org> committed R252:edad154d2474: ensure winId() not called on non-native widgets (authored by cullmann).
ensure winId() not called on non-native widgets
Mon, Oct 7, 8:31 PM
cullmann committed R252:93c19fbfa125: ensure winId() not called on non-native widgets (authored by cullmann).
ensure winId() not called on non-native widgets
Mon, Oct 7, 4:59 PM
cullmann closed D24442: ensure winId() not called on non-native widgets.
Mon, Oct 7, 4:59 PM · Frameworks
cullmann added a comment to D24442: ensure winId() not called on non-native widgets.

It would be great to have that in 5.63, or I am too late?

Mon, Oct 7, 3:59 PM · Frameworks
cullmann added a comment to D24442: ensure winId() not called on non-native widgets.

If nobody objects will push that later, without any window on secondary screen is garbage after palette change.

Mon, Oct 7, 3:44 PM · Frameworks

Sun, Oct 6

cullmann added a comment to T9584: Publish Kile in the Microsoft Store.

Quick look at the code tells me you need to add something like

Sun, Oct 6, 7:22 PM · Kile, Windows
cullmann added a comment to T9584: Publish Kile in the Microsoft Store.

I can handle the submission.

Sun, Oct 6, 7:20 PM · Kile, Windows
cullmann committed R877:44f10a221a12: set breeze later (authored by cullmann).
set breeze later
Sun, Oct 6, 5:34 PM
cullmann committed R877:e113bb2aaf67: we need to set breeze later (authored by cullmann).
we need to set breeze later
Sun, Oct 6, 5:33 PM
cullmann added a reverting change for R877:32a40165a3bd: results look broken, perhaps too much blacklisted: R877:ceb31f33624d: Revert "results look broken, perhaps too much blacklisted".
Sun, Oct 6, 5:32 PM
cullmann committed R877:ceb31f33624d: Revert "results look broken, perhaps too much blacklisted" (authored by cullmann).
Revert "results look broken, perhaps too much blacklisted"
Sun, Oct 6, 5:32 PM
cullmann committed R877:c145f66d1f9f: we need to set breeze later (authored by cullmann).
we need to set breeze later
Sun, Oct 6, 5:30 PM
cullmann added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

I would not spend time on Phabricator as we anyways will leave it behind not that far away ;=)

Sun, Oct 6, 5:19 PM
cullmann committed R877:d43db1ea9246: try to not set the style (authored by cullmann).
try to not set the style
Sun, Oct 6, 5:06 PM
cullmann committed R40:8c3a777a8506: GIT_SILENT: application of coding style (authored by cullmann).
GIT_SILENT: application of coding style
Sun, Oct 6, 4:09 PM
cullmann added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

:=) If there is some consensus, this can be tried.
One issue with that is that the tooling wants to have it in the source tree.
We would e.g. add some ECM magic for that, that copies a file shipped with ECM to the source tree if we agree that the style is ok.

Sun, Oct 6, 4:08 PM