Thanks for the patch, and for adding a test!

Question: how come the return/enter key currently works for this use case in the open dialog without all this extra code?

In D19824#433831, @ngraham wrote:

Thanks for the patch, and for adding a test!

Question: how come the return/enter key currently works for this use case in the open dialog without all this extra code?

In the open dialog or save dialog with select + enter or select + double/simple click cases, the event activated is emitted which triggers slotOk.
But Activated is emitted only when a file is selected.

Here we expect enter/return to work without selecting a file.
We can view the KDirOperator here as both a file selector (to overwrite a file) or a directory selector to save the file in the selected directory depending on the user interaction.

In D19824#434053, @ngraham wrote:

Makes sense, thanks. This fix works and looks sane to me.

Maybe wait until at least one more Dolphin and/or Frameworks person has reviewed before committing, though.

I still lack a bit experience with Qt, and my solution feels a bit overkill : listening to key Press and emitting a specific event.
I could be missing a more idiomatic way to do this.
I'd very much appreciate a second review.

At least now the issue at hand is evident.

I think I will clean up the test code a bit.

@dfaure is this good now?

In D19824#439896, @dfaure wrote:

Remember to update the commit log so it doesn't keep saying "First attempt, not necessarily the right one." :-)

Thanks !