bruns (Stefan Brüns)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 2 2017, 12:03 PM (98 w, 3 d)
Availability
Available

Recent Activity

Yesterday

bruns abandoned D17518: Adapt favicon test to www.kde.org changes.
Wed, Feb 20, 11:56 PM · Frameworks
bruns added inline comments to D19087: Add standalone conversion functions for PropertyMap to Json and vice versa.
Wed, Feb 20, 11:54 PM · Baloo, Frameworks
bruns added a comment to D18915: Fix batchrename changing extension to lower case.

And factor out the function, it is used in 2 places, and you can unit test it then.

Wed, Feb 20, 10:57 PM · Frameworks
bruns added a comment to D18915: Fix batchrename changing extension to lower case.

https://doc.qt.io/qt-5/qmimedatabase.html#suffixForFileName

Returns the suffix for the file fileName, as known by the MIME database.
This allows to pre-select "tar.bz2" for foo.tar.bz2, but still only "txt" for my.file.with.dots.txt.

This was the original method of getting the file extension however it was converting the file extensions to lower case.

This can be demonstrated with the following code:
QMimeDatabase db;
QUrl url = (QString) "foo.TXT";
const QString extension = db.suffixForFileName(url.toDisplayString());
qDebug(qUtf8Printable(extension)); //outputs "txt"

Wed, Feb 20, 10:55 PM · Frameworks
bruns added a comment to D18915: Fix batchrename changing extension to lower case.

Returns the suffix for the file fileName, as known by the MIME database.
This allows to pre-select "tar.bz2" for foo.tar.bz2, but still only "txt" for my.file.with.dots.txt.

Wed, Feb 20, 10:46 PM · Frameworks
bruns added a comment to D18845: authority: add support for passing details to polkit.

Does this solve part of T8075?

Wed, Feb 20, 6:55 PM
bruns added a comment to D18770: [KStatusNotifierItem] use fallback sizes when none is available.

While this may be necessary in some cases, I wonder if there shouldn't be some more emphasis on using the IconName instead of a pixmap:

  • The icon stays scalable
  • Less data to serialize/deserialize over DBus
Wed, Feb 20, 6:22 PM · Frameworks
bruns added a comment to D18873: add baloo engine debugging category.

@valeriymalov - are you going to push this?

Wed, Feb 20, 5:57 PM · Baloo, Frameworks

Tue, Feb 19

bruns accepted D19101: Increase precision of frame rate property.
Tue, Feb 19, 11:08 PM · Baloo, Frameworks
bruns accepted D19102: Fix extraction of aspect ratio property.
Tue, Feb 19, 11:08 PM · Baloo, Frameworks
bruns added a comment to D19087: Add standalone conversion functions for PropertyMap to Json and vice versa.

The stringlist case is still not handled.

Tue, Feb 19, 11:00 PM · Baloo, Frameworks
bruns added a comment to D19109: [Extractor] Add metadata to extractors.

A few general remarks:

  • I really do not like that there are two lists of supported mimetypes now which have to be kept in sync

I think this is trivial enough. Also this is covered by the unit test.

My fear is that it is easily forgotten, but I did not see the autotest. Still, do you think it is feasible to generate the mimetype stringlist from the JSON data to remove the duplication?

Tue, Feb 19, 10:16 PM · Baloo, Frameworks
bruns requested changes to D19102: Fix extraction of aspect ratio property.
Tue, Feb 19, 7:37 PM · Baloo, Frameworks
bruns requested changes to D19101: Increase precision of frame rate property.
Tue, Feb 19, 7:35 PM · Baloo, Frameworks

Mon, Feb 18

bruns accepted D19099: Add a test for ffmpeg extractor.
Mon, Feb 18, 10:18 PM · Baloo, Frameworks
bruns added a comment to D19098: Add PropertyMap to QVariantMap conversion function using names.

It already does at two different places, because it fuses different information into a single QMap later on (xattr, file size etc...)
https://phabricator.kde.org/source/baloo-widgets/browse/master/src/extractor.cpp$65
https://phabricator.kde.org/source/baloo-widgets/browse/master/src/filefetchjob.cpp$62

Mon, Feb 18, 10:17 PM · Baloo, Frameworks
bruns added a comment to D19109: [Extractor] Add metadata to extractors.

A few general remarks:

  • I really do not like that there are two lists of supported mimetypes now which have to be kept in sync
Mon, Feb 18, 10:07 PM · Baloo, Frameworks
bruns added a comment to D19098: Add PropertyMap to QVariantMap conversion function using names.

Why would we want to use a QVariantMap in baloo-widgets, and not a KFM::PropertyMap?

Mon, Feb 18, 4:45 PM · Baloo, Frameworks
bruns added a comment to D18883: Add PDF thumbnailer.

However, you will get a Dr Konqi each time it encounters that file as it will try to generate a thumbnail for it every time you open the folder.

Mon, Feb 18, 4:21 PM · Frameworks, Dolphin
bruns added inline comments to D19108: [ExternalExtractor] Provide more helpful output when extractor fails.
Mon, Feb 18, 2:19 PM · Baloo, Frameworks
bruns closed D19108: [ExternalExtractor] Provide more helpful output when extractor fails.
Mon, Feb 18, 2:16 PM · Baloo, Frameworks
bruns committed R286:36dafc3cb668: [ExternalExtractor] Provide more helpful output when extractor fails (authored by bruns).
[ExternalExtractor] Provide more helpful output when extractor fails
Mon, Feb 18, 2:16 PM
bruns retitled D19109: [Extractor] Add metadata to extractors from [Extractor] Add metadata to properties to [Extractor] Add metadata to extractors.
Mon, Feb 18, 1:17 AM · Baloo, Frameworks
bruns updated the task description for T9897: Improve and consolidate Baloo config.
Mon, Feb 18, 12:13 AM · Baloo
bruns updated the summary of D19109: [Extractor] Add metadata to extractors.
Mon, Feb 18, 12:10 AM · Baloo, Frameworks
bruns requested review of D19109: [Extractor] Add metadata to extractors.
Mon, Feb 18, 12:05 AM · Baloo, Frameworks

Sun, Feb 17

bruns requested review of D19108: [ExternalExtractor] Provide more helpful output when extractor fails.
Sun, Feb 17, 11:43 PM · Baloo, Frameworks
bruns updated the diff for D19087: Add standalone conversion functions for PropertyMap to Json and vice versa.

Add double test case
Fix double conversion
Fix nitpicks ('*')

Sun, Feb 17, 8:42 PM · Baloo, Frameworks
bruns added inline comments to D19102: Fix extraction of aspect ratio property.
Sun, Feb 17, 8:31 PM · Baloo, Frameworks
bruns added inline comments to D19101: Increase precision of frame rate property.
Sun, Feb 17, 8:28 PM · Baloo, Frameworks
bruns accepted D19100: Cleanup ffmpeg extractor.
Sun, Feb 17, 8:23 PM · Baloo, Frameworks
bruns added inline comments to D19099: Add a test for ffmpeg extractor.
Sun, Feb 17, 8:18 PM · Baloo, Frameworks
bruns added a comment to D19090: Hardcoding the Remaining Time Update Interval.

Nitpick - "Hardcoding ..." -> "Hardcode" or better "Use a fixed interval for updating the Remaining Time"

Sun, Feb 17, 4:09 PM · Baloo, Frameworks
bruns accepted D19090: Hardcoding the Remaining Time Update Interval.
Sun, Feb 17, 4:07 PM · Baloo, Frameworks
bruns requested review of D19088: Use propertymap to store properties in Baloo::Result.
Sun, Feb 17, 1:10 AM · Baloo, Frameworks
bruns added a dependent revision for D19087: Add standalone conversion functions for PropertyMap to Json and vice versa: D19088: Use propertymap to store properties in Baloo::Result.
Sun, Feb 17, 1:10 AM · Baloo, Frameworks
bruns requested review of D19087: Add standalone conversion functions for PropertyMap to Json and vice versa.
Sun, Feb 17, 1:10 AM · Baloo, Frameworks
bruns committed R293:70c859be4929: Fix regression for matching explicitly included folders (authored by bruns).
Fix regression for matching explicitly included folders
Sun, Feb 17, 12:31 AM

Sat, Feb 16

bruns committed R293:3aa11093c8e2: Cleanup idempotent entries from mimetype mapper table (authored by bruns).
Cleanup idempotent entries from mimetype mapper table
Sat, Feb 16, 11:33 PM
bruns closed D19065: Cleanup idempotent entries from mimetype mapper table.
Sat, Feb 16, 11:33 PM · Baloo, Frameworks

Fri, Feb 15

bruns requested review of D19065: Cleanup idempotent entries from mimetype mapper table.
Fri, Feb 15, 10:39 PM · Baloo, Frameworks
bruns added inline comments to D19007: Wait for DBus Reply Before Performing Computations.
Fri, Feb 15, 3:03 PM · Baloo, Frameworks
bruns accepted D18698: [baloo/KInotify] Notify if folder was moved from unwatched place.

Thanks!

Fri, Feb 15, 2:10 PM · Baloo, Frameworks
bruns added inline comments to D19007: Wait for DBus Reply Before Performing Computations.
Fri, Feb 15, 3:32 AM · Baloo, Frameworks
bruns added inline comments to D18698: [baloo/KInotify] Notify if folder was moved from unwatched place.
Fri, Feb 15, 3:11 AM · Baloo, Frameworks
bruns added a comment to D14661: Force reevaluation of Predicates if interfaces are removed.

I guess that there is a short period of time when UDisks daemon is in inconsistent state, i.e. org.freedesktop.UDisks2.Filesystem interface is removed for CD-ROM device, but the device's properties still have Optical=true.
Adding "updateBackend(udi);" before "emit deviceAdded(udi);" gives Udisks time to become consistent.

Fri, Feb 15, 3:05 AM · Frameworks
bruns added inline comments to D18845: authority: add support for passing details to polkit.
Fri, Feb 15, 2:27 AM
bruns requested changes to D19007: Wait for DBus Reply Before Performing Computations.
Fri, Feb 15, 1:54 AM · Baloo, Frameworks
bruns added a comment to D19007: Wait for DBus Reply Before Performing Computations.

good catch, but the fix is overengineered ...

Fri, Feb 15, 1:54 AM · Baloo, Frameworks

Tue, Feb 12

bruns added inline comments to D18698: [baloo/KInotify] Notify if folder was moved from unwatched place.
Tue, Feb 12, 3:47 PM · Baloo, Frameworks

Mon, Feb 11

bruns committed R293:6b58be56b380: Simplify term debug output (authored by bruns).
Simplify term debug output
Mon, Feb 11, 11:11 PM
bruns committed R293:97aa68252c4a: Handle folders matching substrings of included/excluded folders correctly (authored by bruns).
Handle folders matching substrings of included/excluded folders correctly
Mon, Feb 11, 10:53 PM
bruns closed D18830: Handle folders matching substrings of included/excluded folders correctly.
Mon, Feb 11, 10:53 PM · Baloo, Frameworks
bruns committed R293:24223306d59c: [balooctl] Normalize include/exclude pathes before using it for the config (authored by bruns).
[balooctl] Normalize include/exclude pathes before using it for the config
Mon, Feb 11, 10:53 PM
bruns closed D18829: [balooctl] Normalize include/exclude pathes before using it for the config.
Mon, Feb 11, 10:53 PM · Baloo, Frameworks
bruns added a comment to D17302: Add test for adding properties to result.

Currently, both
Result::add(prop, "value1"); Result::add(prop, "value2");
and
Result::add(prop, {"value1", "value2"});
are serialized (JSON) in the same way as {prop: ["value1", "value2"]} by Baloo, which is IMHO fine.
On the other hand,
Result::add(prop, "value1"); Result::add(prop, {"value2", "value3"});
ends up as {prop: ["value1", ["value2", "value3"] ]}, which is nonsense, should be {prop: ["value1", "value2", "value3"]}

Mon, Feb 11, 10:24 PM · Baloo, Frameworks
bruns added a comment to D18829: [balooctl] Normalize include/exclude pathes before using it for the config.

Ping!

Mon, Feb 11, 10:08 PM · Baloo, Frameworks
bruns added inline comments to D18890: Add button to reset index database and repair Baloo crashing.
Mon, Feb 11, 7:24 PM · Baloo, Plasma
bruns added a comment to D18890: Add button to reset index database and repair Baloo crashing.

Thanks! This is pretty good as-is, and I can confirm that it works just fine. However once the user presses the button, there's no further feedback, which could encourage them to repeatedly press it again--not a good idea. Maybe while the initial index is being generated, we could display a progress spinner (and a label too) and disable the button. What do you think?

Mon, Feb 11, 7:21 PM · Baloo, Plasma

Sun, Feb 10

bruns committed R293:c6fd08d4c3c9: Optimize Baloo::File copy assign operator, fix Baloo::File::load(url) (authored by bruns).
Optimize Baloo::File copy assign operator, fix Baloo::File::load(url)
Sun, Feb 10, 11:28 PM
bruns closed D18877: Optimize Baloo::File copy assign operator, fix Baloo::File::load(url).
Sun, Feb 10, 11:28 PM · Baloo, Frameworks
bruns closed D18900: Avoid side effects due to stale errno value.
Sun, Feb 10, 11:27 PM · Baloo, Frameworks
bruns committed R286:7cce4c7f7b47: Avoid side effects due to stale errno value (authored by bruns).
Avoid side effects due to stale errno value
Sun, Feb 10, 11:27 PM
bruns accepted D18873: add baloo engine debugging category.
Sun, Feb 10, 4:35 PM · Baloo, Frameworks
bruns added a comment to D18664: Baloo engine: treat every non-success code as a failure.

Also, remove the second paragraph from the summary - a commit message is not a TODO list.

Sun, Feb 10, 4:35 PM · Baloo, Frameworks
bruns added a comment to D18664: Baloo engine: treat every non-success code as a failure.

Also, these should only be CCBUG, as it is only an assumption it fixes any of these.

Sun, Feb 10, 4:34 PM · Baloo, Frameworks
bruns added a comment to D18664: Baloo engine: treat every non-success code as a failure.

looks almost good to me, can someone else please crosscheck?

Sun, Feb 10, 4:07 PM · Baloo, Frameworks
bruns requested review of D18900: Avoid side effects due to stale errno value.
Sun, Feb 10, 3:49 PM · Baloo, Frameworks
bruns closed D18891: Avoid leaking a QObject in ExternalExtractor.
Sun, Feb 10, 3:00 PM · Baloo, Frameworks
bruns committed R286:73d5fbbf5fb0: Avoid leaking a QObject in ExternalExtractor (authored by bruns).
Avoid leaking a QObject in ExternalExtractor
Sun, Feb 10, 3:00 PM
bruns added a comment to D18891: Avoid leaking a QObject in ExternalExtractor.

That looks reasonable, if ExtractorPlugin even has QObject * parent = nullptr I'd even remove nullptr as well.

Sun, Feb 10, 2:29 PM · Baloo, Frameworks
bruns requested review of D18891: Avoid leaking a QObject in ExternalExtractor.
Sun, Feb 10, 12:36 AM · Baloo, Frameworks

Sat, Feb 9

bruns accepted D17245: Add string formatting function to property info.
Sat, Feb 9, 10:48 PM · Baloo, Frameworks
bruns added a comment to D18873: add baloo engine debugging category.

Looks good to me. @mlaurent ?

Sat, Feb 9, 7:19 PM · Baloo, Frameworks
bruns added inline comments to D18664: Baloo engine: treat every non-success code as a failure.
Sat, Feb 9, 6:58 PM · Baloo, Frameworks
bruns added inline comments to D18664: Baloo engine: treat every non-success code as a failure.
Sat, Feb 9, 3:40 PM · Baloo, Frameworks
bruns added a comment to D18873: add baloo engine debugging category.

DEFAULT_SEVERITY [WARNING] is false too as you don't force it.

Sat, Feb 9, 3:17 PM · Baloo, Frameworks
bruns requested changes to D18873: add baloo engine debugging category.
Sat, Feb 9, 3:08 PM · Baloo, Frameworks
bruns requested review of D18877: Optimize Baloo::File copy assign operator, fix Baloo::File::load(url).
Sat, Feb 9, 3:01 PM · Baloo, Frameworks
bruns requested changes to D18698: [baloo/KInotify] Notify if folder was moved from unwatched place.
Sat, Feb 9, 12:12 AM · Baloo, Frameworks

Fri, Feb 8

bruns added inline comments to D18829: [balooctl] Normalize include/exclude pathes before using it for the config.
Fri, Feb 8, 11:53 PM · Baloo, Frameworks
bruns committed R293:ad4d29c4b170: Get rid of mostly unused filePathToStat overload (authored by bruns).
Get rid of mostly unused filePathToStat overload
Fri, Feb 8, 11:47 PM
bruns closed D18833: Get rid of mostly unused filePathToStat overload.
Fri, Feb 8, 11:47 PM · Baloo, Frameworks
bruns committed R286:f86639982645: Handle <a> as container element in SVG (authored by bruns).
Handle <a> as container element in SVG
Fri, Feb 8, 11:46 PM
bruns closed D18835: Handle <a> as container element in SVG.
Fri, Feb 8, 11:46 PM · Baloo, Frameworks
bruns closed D18851: [Extractor] Exclude GPG encrypted data from being indexed.
Fri, Feb 8, 2:23 PM · Baloo, Frameworks
bruns committed R293:3aa911d4a0ac: [Extractor] Exclude GPG encrypted data from being indexed (authored by bruns).
[Extractor] Exclude GPG encrypted data from being indexed
Fri, Feb 8, 2:23 PM
bruns requested review of D18851: [Extractor] Exclude GPG encrypted data from being indexed.
Fri, Feb 8, 2:16 PM · Baloo, Frameworks
bruns requested review of D18835: Handle <a> as container element in SVG.
Fri, Feb 8, 12:06 AM · Baloo, Frameworks

Thu, Feb 7

bruns requested review of D18833: Get rid of mostly unused filePathToStat overload.
Thu, Feb 7, 11:27 PM · Baloo, Frameworks
bruns committed R293:a040c71e353d: [balooctl] Actually abort a malformed command instead of just saying so (authored by bruns).
[balooctl] Actually abort a malformed command instead of just saying so
Thu, Feb 7, 11:03 PM
bruns closed D18828: [balooctl] Actually abort a malformed command instead of just saying so.
Thu, Feb 7, 11:03 PM · Baloo, Frameworks
bruns committed R293:3a31a7ed0e29: [balooctl] Add missing help for "config set", normalize string (authored by bruns).
[balooctl] Add missing help for "config set", normalize string
Thu, Feb 7, 11:02 PM
bruns committed R293:38698b1a4c9e: Replace recursive isDirHidden with iterative one, allow const argument (authored by bruns).
Replace recursive isDirHidden with iterative one, allow const argument
Thu, Feb 7, 11:02 PM
bruns closed D18827: [balooctl] Add missing help for "config set", normalize string.
Thu, Feb 7, 11:02 PM · Baloo, Frameworks
bruns closed D18825: Replace recursive isDirHidden with iterative one, allow const argument.
Thu, Feb 7, 11:02 PM · Baloo, Frameworks
bruns added a comment to D17245: Add string formatting function to property info.

src/formatstrings.h should be named src/formatstrings_p.h

Thu, Feb 7, 9:09 PM · Baloo, Frameworks
bruns added a dependent revision for D18829: [balooctl] Normalize include/exclude pathes before using it for the config: D18830: Handle folders matching substrings of included/excluded folders correctly.
Thu, Feb 7, 8:18 PM · Baloo, Frameworks
bruns requested review of D18830: Handle folders matching substrings of included/excluded folders correctly.
Thu, Feb 7, 8:18 PM · Baloo, Frameworks
bruns requested review of D18829: [balooctl] Normalize include/exclude pathes before using it for the config.
Thu, Feb 7, 8:17 PM · Baloo, Frameworks