bruns (Stefan Brüns)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 2 2017, 12:03 PM (124 w, 4 d)
Availability
Available

Recent Activity

Sat, Aug 17

bruns added inline comments to D19774: Use ellipsis in search field.
Sat, Aug 17, 1:24 PM · KDE Edu
bruns added inline comments to D17595: Upstream Dolphin's file rename dialog.
Sat, Aug 17, 3:22 AM · Frameworks
bruns added inline comments to D23112: Add a event Spy for GtkFileChooser recent files.
Sat, Aug 17, 1:22 AM · Plasma

Fri, Aug 16

bruns accepted D23200: Fixes a crash in Peruse triggered by baloo.
Fri, Aug 16, 4:00 PM · Baloo, Frameworks
bruns requested changes to D23200: Fixes a crash in Peruse triggered by baloo.

Please just return without message, and also change the one below.

Fri, Aug 16, 2:20 PM · Baloo, Frameworks

Thu, Aug 8

bruns added a comment to D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events.

@poboiko - is the problem you describe purely theoretical, or did you actually see it happen?

Thu, Aug 8, 12:37 PM · Baloo, Frameworks

Wed, Aug 7

bruns requested changes to D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events.
Wed, Aug 7, 10:35 PM · Baloo, Frameworks

Jul 19 2019

bruns added a comment to D22557: [IndexCleaner] ignore non-existent entries inside config.

Shouldn't we make sure that entries get removed from the config file properly?

Jul 19 2019, 3:27 PM · Baloo, Frameworks

Jul 17 2019

bruns added a comment to D21002: Remove kde4 migration agent completely.

It tried to install the no longer existing DBus service file. Fixup pushed.

Jul 17 2019, 11:52 PM · Frameworks
bruns committed R311:a52d3139e655: Do not try to install no longer existing file (authored by bruns).
Do not try to install no longer existing file
Jul 17 2019, 11:51 PM
bruns committed R311:dc5c7229bc4f: Remove kde4 migration agent completely (authored by bruns).
Remove kde4 migration agent completely
Jul 17 2019, 10:34 PM
bruns closed D21002: Remove kde4 migration agent completely.
Jul 17 2019, 10:34 PM · Frameworks
bruns added a comment to D22333: Move Solid::Device::listFromQuery calls to a separate thread.

Kinda, you're summary missing a key part.
(the commit description is a bit poor)

This patch does the following:

  • It does the search in the other thread. That creates and iterates every possible device. This is expensive as there are lots of potential devices. We fetch pretty much everything udisks knows.
  • From the given list we recreate the select few devices that are relevant. This is relatively cheap. It does still block as you point out, but now for a much much smaller set of objects compared to before.

    (on my laptop that's 56 devices created when searching, resulting in 8 useful devices).
Jul 17 2019, 4:41 PM · Plasma
bruns requested changes to D22502: [FileIndexerConfig] skip invalid entries from included/excludedFolders.
Jul 17 2019, 2:49 PM · Baloo, Frameworks
bruns added a comment to D22502: [FileIndexerConfig] skip invalid entries from included/excludedFolders.

The correct fix is to check the returned/calculated ID in the IndexCleaner, otherwise its racy.

Jul 17 2019, 2:49 PM · Baloo, Frameworks

Jul 16 2019

bruns added a comment to D22333: Move Solid::Device::listFromQuery calls to a separate thread.
Jul 16 2019, 2:28 PM · Plasma
bruns added a comment to D22339: Make sure solid backends are reentrant.

I would have preferred this to only land when D22333 had been addressed fully, I assumed this required no further notice.

Jul 16 2019, 2:13 PM · Frameworks
bruns added a reverting change for R293:d6d86cb86cb6: Revert "[PowerStateMonitor] Be conservative when determining power state": R293:397b4a041f2e: Revert "Revert "[PowerStateMonitor] Be conservative when determining power….
Jul 16 2019, 11:55 AM
bruns committed R293:397b4a041f2e: Revert "Revert "[PowerStateMonitor] Be conservative when determining power… (authored by bruns).
Revert "Revert "[PowerStateMonitor] Be conservative when determining power…
Jul 16 2019, 11:55 AM
bruns added a comment to D21672: [PowerStateMonitor] Be conservative when determining power state.

Why don't you notify the relevant people first

He kinda did by writing a bug report, but let's not argue but investigate and fix why this seemingly innocent patch caused the behavior described.

Jul 16 2019, 10:22 AM · Baloo, Frameworks
bruns added a comment to D21672: [PowerStateMonitor] Be conservative when determining power state.

Reverted by d6d86cb86c on master. See https://bugs.kde.org/show_bug.cgi?id=409405 for more info. Possibly a critical problem in released 5.60 @bruns.

Jul 16 2019, 10:15 AM · Baloo, Frameworks

Jul 13 2019

bruns added a comment to D22339: Make sure solid backends are reentrant.

This is inacceptable!

Jul 13 2019, 1:16 AM · Frameworks
bruns added a comment to D22333: Move Solid::Device::listFromQuery calls to a separate thread.
In D22333#494810, @apol wrote:

Also, the code is calling non-threadsafe code from multiple threads now (e.g. once from each the two dataengines helper threads). Each one will call the udisks2 Manager::deviceCache() method.

There's a Backend per-thread and deviceCache is not static so each thread will call its own.

Jul 13 2019, 1:02 AM · Plasma

Jul 12 2019

bruns added a comment to D22333: Move Solid::Device::listFromQuery calls to a separate thread.
In D22333#494415, @apol wrote:

Again, where is it blocking? Which backend?

udisks2 mainly, but every backend can block by its virtue.

Jul 12 2019, 9:03 PM · Plasma

Jul 11 2019

bruns added a comment to D22333: Move Solid::Device::listFromQuery calls to a separate thread.
In D22333#494384, @apol wrote:
In D22333#494152, @apol wrote:

Why not just a singleshot timer from the constructor? Avoids any initial blocking ...

Initial, but doesn't fix the problem. We could potentially delay this few seconds instead, but we'd still be getting an odd ~500ms freeze randomly
Or we can just decide to move blocking or heavy algorithms to separate threads and enjoy our multicore computers and a fluid experience.

Where does the blocking happen? How do you guarantee none of the later call block? Large parts of the code are executed in the main thread anyway, only the initial list creation happens in a worker thread.

listFromQuery is the big blocking call we are moving into a separate thread.

Jul 11 2019, 7:12 PM · Plasma
bruns added a comment to D22333: Move Solid::Device::listFromQuery calls to a separate thread.
In D22333#494152, @apol wrote:

Why not just a singleshot timer from the constructor? Avoids any initial blocking ...

Initial, but doesn't fix the problem. We could potentially delay this few seconds instead, but we'd still be getting an odd ~500ms freeze randomly
Or we can just decide to move blocking or heavy algorithms to separate threads and enjoy our multicore computers and a fluid experience.

Jul 11 2019, 2:29 PM · Plasma
bruns added a comment to D22339: Make sure solid backends are reentrant.
In D22339#494149, @apol wrote:

How do you guarantee *each thread local* copy now is connected to the right signals, i.e. the socket notifier for the mtab and inotify for fstab?

each backend will create things separately now, so it should work like it used to so far when there was just one thread involved.

Jul 11 2019, 2:15 PM · Frameworks
bruns added a comment to D21427: Always skip trailing slashes in FilderedDirIterator.

Ping!

Apparently, it does fix bug 409257, which is pretty serious one (db corruption, after all).

Jul 11 2019, 12:48 PM · Baloo, Frameworks
bruns requested changes to D22333: Move Solid::Device::listFromQuery calls to a separate thread.

Why not just a singleshot timer from the constructor? Avoids any initial blocking ...

Jul 11 2019, 11:39 AM · Plasma
bruns requested changes to D22339: Make sure solid backends are reentrant.

How do you guarantee *each thread local* copy now is connected to the right signals, i.e. the socket notifier for the mtab and inotify for fstab?

Jul 11 2019, 11:37 AM · Frameworks

Jul 10 2019

bruns committed R120:7fa46fa74987: [ksmserver] Remove obsolete KDELibs4Support dependency (authored by bruns).
[ksmserver] Remove obsolete KDELibs4Support dependency
Jul 10 2019, 12:26 AM
bruns closed D22296: [ksmserver] Remove obsolete KDELibs4Support dependency.
Jul 10 2019, 12:26 AM · Plasma
bruns updated subscribers of D22296: [ksmserver] Remove obsolete KDELibs4Support dependency.
Jul 10 2019, 12:22 AM · Plasma
bruns updated the diff for D22296: [ksmserver] Remove obsolete KDELibs4Support dependency.

remove inhibition

Jul 10 2019, 12:20 AM · Plasma

Jul 8 2019

bruns added inline comments to D22296: [ksmserver] Remove obsolete KDELibs4Support dependency.
Jul 8 2019, 6:35 PM · Plasma
bruns added a comment to D22296: [ksmserver] Remove obsolete KDELibs4Support dependency.
Jul 8 2019, 4:55 PM · Plasma

Jul 7 2019

bruns committed R120:bf811e448c76: [DeviceNotifications] Keep last message for each device (authored by bruns).
[DeviceNotifications] Keep last message for each device
Jul 7 2019, 7:13 PM
bruns closed D22312: [DeviceNotifications] Keep last message for each device.
Jul 7 2019, 7:13 PM · Plasma
bruns requested review of D22312: [DeviceNotifications] Keep last message for each device.
Jul 7 2019, 6:02 PM · Plasma
bruns accepted D22192: remove foreach.
Jul 7 2019, 4:56 PM · Baloo
bruns added inline comments to D22192: remove foreach.
Jul 7 2019, 4:22 PM · Baloo

Jul 6 2019

bruns added a comment to D22296: [ksmserver] Remove obsolete KDELibs4Support dependency.

After having looked into the callchain again, I am not sure what the best action here is:

Jul 6 2019, 2:22 PM · Plasma
bruns requested review of D22296: [ksmserver] Remove obsolete KDELibs4Support dependency.
Jul 6 2019, 11:02 AM · Plasma

Jul 5 2019

bruns added inline comments to D22192: remove foreach.
Jul 5 2019, 8:08 PM · Baloo
bruns added a comment to D21002: Remove kde4 migration agent completely.

Can I have a "go"?

Jul 5 2019, 7:59 PM · Frameworks
bruns accepted D20526: Fix extracting of some properties to match what was written.
Jul 5 2019, 7:56 PM · Baloo, Frameworks
bruns added a comment to D22276: Add an action to insert a non-indented newline.

Another way to avoid indented empty line is to clear the trailing spaces/indentation when pressing enter while the cursor is at the end of a line containing only spaces or \t. This can lead to a nightmare though if someone want to keep trailing spaces...

Jul 5 2019, 10:34 AM · Frameworks, Kate

Jul 1 2019

bruns added inline comments to D22147: Better use of Qt APIs in Plasma::Theme.
Jul 1 2019, 2:38 PM · Frameworks

Jun 30 2019

bruns accepted D22159: Check for DQT_NO_CAST_FROM_BYTEARRAY.
Jun 30 2019, 7:27 PM · Baloo
bruns added inline comments to D22159: Check for DQT_NO_CAST_FROM_BYTEARRAY.
Jun 30 2019, 10:57 AM · Baloo

Jun 29 2019

bruns accepted D22157: Use debugging category in taglib extractor/writer.
Jun 29 2019, 6:40 PM · Baloo, Frameworks
bruns accepted D22096: Check for DQT_NO_CAST_FROM_ASCII.
Jun 29 2019, 3:51 PM · Baloo
bruns added inline comments to D22157: Use debugging category in taglib extractor/writer.
Jun 29 2019, 3:50 PM · Baloo, Frameworks
bruns added inline comments to D20526: Fix extracting of some properties to match what was written.
Jun 29 2019, 3:35 PM · Baloo, Frameworks

Jun 27 2019

bruns added inline comments to D22096: Check for DQT_NO_CAST_FROM_ASCII.
Jun 27 2019, 9:51 PM · Baloo

Jun 26 2019

bruns added inline comments to D22096: Check for DQT_NO_CAST_FROM_ASCII.
Jun 26 2019, 2:58 PM · Baloo

Jun 25 2019

bruns committed R245:541a3d3a0573: [Fstab] Select appropriate icon for home or root directory (authored by bruns).
[Fstab] Select appropriate icon for home or root directory
Jun 25 2019, 9:02 AM
bruns closed D22081: [Fstab] Select appropriate icon for home or root directory.
Jun 25 2019, 9:02 AM · Frameworks
bruns committed R245:54a501f00bbe: [Fstab] Show mounted "overlay" filesystems (authored by bruns).
[Fstab] Show mounted "overlay" filesystems
Jun 25 2019, 9:00 AM
bruns closed D22080: [Fstab] Show mounted "overlay" filesystems.
Jun 25 2019, 9:00 AM · Frameworks

Jun 24 2019

bruns committed R623:6cff71f9dab0: Port away from KDELibs4Support, use Solid::Power interface (authored by bruns).
Port away from KDELibs4Support, use Solid::Power interface
Jun 24 2019, 5:55 PM
bruns closed D21976: Port away from KDELibs4Support, use Solid::Power interface.
Jun 24 2019, 5:55 PM
bruns committed R623:04cb8277574b: Remove explicit initialization of default constructed members (authored by bruns).
Remove explicit initialization of default constructed members
Jun 24 2019, 5:54 PM
bruns closed D21975: Remove explicit initialization of default constructed members.
Jun 24 2019, 5:54 PM
bruns closed D21974: Fix warning, remove unsigned int < 0 check.
Jun 24 2019, 5:53 PM
bruns committed R623:6214113c8a29: Fix warning, remove unsigned int < 0 check (authored by bruns).
Fix warning, remove unsigned int < 0 check
Jun 24 2019, 5:53 PM
bruns added a comment to D15739: [Places panel] Don't show Root by default.

If adding such a special case makes sense, yes. I'd even argue about 'mntent.mnt_dir == "/" && !isKnownFilesystem(mntent)' or something like that to ensure that an entry for / is always provided.

Jun 24 2019, 4:51 PM · Frameworks
bruns added a dependent revision for D22080: [Fstab] Show mounted "overlay" filesystems: D22081: [Fstab] Select appropriate icon for home or root directory.
Jun 24 2019, 4:43 PM · Frameworks
bruns requested review of D22081: [Fstab] Select appropriate icon for home or root directory.
Jun 24 2019, 4:43 PM · Frameworks
bruns requested review of D22080: [Fstab] Show mounted "overlay" filesystems.
Jun 24 2019, 4:42 PM · Frameworks
bruns added a comment to D15739: [Places panel] Don't show Root by default.

It actually already does, via the fstab backend (currently network (SMB/NFS) and various fuse mounts). Fstab in this case also includes everything in MTAB, should be quite easy to extend this.

What is the output of cat /proc/self/mounts (fell free to remove anything irrelevant, like cgroups)?

The entries involved in / are these:

/dev/sr0 /run/initramfs/live iso9660 ro,relatime 0 0
/dev/loop0 /run/initramfs/squashfs_container squashfs ro,relatime 0 0
/dev/loop1 /run/rootfsbase ext4 ro,relatime,data=ordered 0 0
LiveOS_rootfs / overlay rw,relatime,lowerdir=/run/rootfsbase,upperdir=/run/overlayfs/rw,workdir=/run/overlayfs/work 0 0
Jun 24 2019, 3:24 PM · Frameworks
bruns added a comment to D15739: [Places panel] Don't show Root by default.

Even if all (block) devices and their mountpoints were shown in the devices view, there would be no equivalent of "/". One loop device provides the read-only base for /, but that's actually more confusing than the current state as it looks like /, but is only a read-only view of "the past".

I guess solid needs to gain support for mountpoints not backed by devices?

Jun 24 2019, 2:34 PM · Frameworks

Jun 23 2019

bruns committed R623:50383c74098b: Make the notifications less obtrusive (authored by bruns).
Make the notifications less obtrusive
Jun 23 2019, 9:42 PM
bruns closed D22027: Make the notifications less obtrusive.
Jun 23 2019, 9:42 PM
bruns closed D22026: Use own eventIds and ComponentName instead of generic plasma workspace ones.
Jun 23 2019, 9:41 PM
bruns committed R623:7268a2da05f8: Use own eventIds and ComponentName instead of generic plasma workspace ones (authored by bruns).
Use own eventIds and ComponentName instead of generic plasma workspace ones
Jun 23 2019, 9:41 PM
bruns committed R623:27bcd6a78c29: Fix usage of 0 for null pointer constants (authored by bruns).
Fix usage of 0 for null pointer constants
Jun 23 2019, 9:40 PM
bruns closed D21973: Fix usage of 0 for null pointer constants.
Jun 23 2019, 9:40 PM
bruns updated the diff for D22027: Make the notifications less obtrusive.

Close update count notification when all updates were installed without involving PK

Jun 23 2019, 5:13 PM
bruns added a comment to D22024: Rework sorting of properties.

Width and height also apply to videos..
For Video, it would be nice to have properties of the video and audio tracks kept together.

Jun 23 2019, 4:53 PM · Baloo
bruns added a reviewer for D21975: Remove explicit initialization of default constructed members: ngraham.
Jun 23 2019, 12:39 PM
bruns closed D21864: [QueryTest] Test if independent phrases are really independent.
Jun 23 2019, 12:34 PM · Baloo, Frameworks
bruns committed R293:ba5de13364ed: [QueryTest] Test if independent phrases are really independent (authored by bruns).
[QueryTest] Test if independent phrases are really independent
Jun 23 2019, 12:34 PM
bruns committed R293:60e03a38ec61: [TermGenerator] Insert an empty position between independent terms (authored by bruns).
[TermGenerator] Insert an empty position between independent terms
Jun 23 2019, 12:33 PM
bruns closed D21863: [TermGenerator] Insert an empty position between independent terms.
Jun 23 2019, 12:33 PM · Baloo, Frameworks
bruns committed R293:dea183a02e2b: [QueryTest] Restructure tests to allow easier extension (authored by bruns).
[QueryTest] Restructure tests to allow easier extension
Jun 23 2019, 12:32 PM
bruns closed D21862: [QueryTest] Restructure tests to allow easier extension.
Jun 23 2019, 12:32 PM · Baloo, Frameworks
bruns added a reviewer for D21974: Fix warning, remove unsigned int < 0 check: ngraham.
Jun 23 2019, 12:29 PM
bruns added a reviewer for D21973: Fix usage of 0 for null pointer constants: ngraham.
Jun 23 2019, 12:29 PM
bruns committed R623:ed80a9912267: Replace KIconLoader + pixmaps with standard icon names (authored by bruns).
Replace KIconLoader + pixmaps with standard icon names
Jun 23 2019, 12:26 PM
bruns closed D21972: Replace KIconLoader + pixmaps with standard icon names.
Jun 23 2019, 12:26 PM
bruns added a comment to D22027: Make the notifications less obtrusive.

Old an new applet running in parallel, after multiple refreshes and after installing some updates:

Jun 23 2019, 10:46 AM
bruns added a dependent revision for D22026: Use own eventIds and ComponentName instead of generic plasma workspace ones: D22027: Make the notifications less obtrusive.
Jun 23 2019, 10:43 AM
bruns requested review of D22027: Make the notifications less obtrusive.
Jun 23 2019, 10:43 AM
bruns added a comment to D22026: Use own eventIds and ComponentName instead of generic plasma workspace ones.

Old and new popup

Jun 23 2019, 10:41 AM
bruns requested review of D22026: Use own eventIds and ComponentName instead of generic plasma workspace ones.
Jun 23 2019, 10:39 AM
bruns added a dependent revision for D21973: Fix usage of 0 for null pointer constants: D22026: Use own eventIds and ComponentName instead of generic plasma workspace ones.
Jun 23 2019, 10:39 AM

Jun 22 2019

bruns updated the diff for D21972: Replace KIconLoader + pixmaps with standard icon names.

remove static

Jun 22 2019, 10:11 AM

Jun 21 2019

bruns added a dependent revision for D21975: Remove explicit initialization of default constructed members: D21976: Port away from KDELibs4Support, use Solid::Power interface.
Jun 21 2019, 8:40 PM
bruns requested review of D21976: Port away from KDELibs4Support, use Solid::Power interface.
Jun 21 2019, 8:40 PM