- User Since
- Apr 2 2017, 12:03 PM (151 w, 5 d)
Tue, Feb 25
Mon, Feb 24
Update commit message (I hate Phabricator)
Sun, Feb 23
ignoreMountPoint -> ignoredMountPoint
move out of class
Sat, Feb 22
Sat, Feb 15
Save the comments, this looks reasonable to me.
Fri, Feb 14
From the viewpoint of baloo_file, the process just hangs, which is bad.
Tue, Feb 11
Reported on reddit:
Tue, Feb 4
Jan 27 2020
The idea was to assign a tag to a file by dropping a (multiple) file into a tag folder, and that somewhat works.
Jan 24 2020
... and sorry for the late answer ...
I will try to cook up a more complete solution over the weekend.
Jan 22 2020
Please do proper capitalization in the summary.
Jan 18 2020
and this is definitely too much code being moved around. Please split this up into multiple reviews.
Moving existing code to new files does not make you the copyright owner.
Jan 16 2020
Having had a look at https://code.woboq.org/qt5/qtbase/src/plugins/imageformats/jpeg/qjpeghandler.cpp.html#_M/HIGH_QUALITY_THRESHOLD, the jpeg handler actually know two different quality settings, < 50 and > 50, the default being 75, i.e. high.
Jan 14 2020
Unfortunately, the QImageReader documentation is not very clear about the effect of setQuality(..). There is a reference to https://doc.qt.io/qt-5/qimagereader.html#setScaledSize, and that in turn has a reference to QImage::scale() (which no longer exists in Qt5) and Qt::SmoothScaling.
Jan 10 2020
The nepomuk icon is completely inappropriate for a generic "search" icon.
Jan 8 2020
Jan 6 2020
In general I am fine with this, but we should strive for some consistency here:
Jan 5 2020
The problem is the extractor serves two different use cases:
I have thought about this and have come to the conclusion this is not really future proof.
Jan 4 2020
Dec 22 2019
No reason for being rude.
Dec 21 2019
The mount path is the only useful identifier. There is no filesystem label or similar.
I think the Summary is very poor.
I would consider an item changing its name based on the state a bug.
Dec 19 2019
Dec 18 2019
Dec 15 2019
Dec 14 2019
Dec 13 2019
just nitpicks ...
Dec 12 2019
Again, Windows does not care ...
please remove the 2 comments.
Duplicate of D25414
Dec 7 2019
Nov 29 2019
Please allow some time for reviewing ...
Nov 26 2019
The dolphin temp extractor uses KFileMetaData::ExtractionResult::ExtractMetaData explicitly.
Nov 21 2019
Or just change the direction?
Agree with David/Thomas, first we need a "Suspend" button or similar.
Nov 20 2019
This is obviously the wrong line of code for the referenced bug report.
Nov 19 2019
Also add a testcase covering this, autotests/usermetadatawritertest.cpp
wrap the summary at <80 characters
Nov 15 2019
Moving it to a separate class will also make creating a unit test trivial.