bruns (Stefan Brüns)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 2 2017, 12:03 PM (115 w, 33 m)
Availability
Available

Recent Activity

Today

bruns committed R286:d9a755d7a970: [XAttr] Probably fix build on Windows (authored by bruns).
[XAttr] Probably fix build on Windows
Sun, Jun 16, 12:34 AM
bruns requested review of D21839: [TermGenerator] Use UTF-8 ByteArray for termList.
Sun, Jun 16, 12:30 AM · Baloo, Frameworks

Yesterday

bruns added a comment to D20967: [UserMetaData] Add method to query which attributes are set.

Please note that there are very few people involved with Windows builds (despite the number of projects that make use of them in general) so people may not always have the ability to respond to every review request.
That is why the CI system monitors the state of code and can catch issues as they happen.

Sat, Jun 15, 10:18 PM · Baloo, Frameworks
bruns added a comment to D20967: [UserMetaData] Add method to query which attributes are set.

Windows - thanks for ignoring every review request!

Sat, Jun 15, 9:26 PM · Baloo, Frameworks
bruns requested review of D21835: [PostingIterator] Move positions() method to VectorPositionInfoIterator.
Sat, Jun 15, 7:34 PM · Baloo, Frameworks
bruns committed R293:13384804b501: [PositionDbTest] Fix trivial memleak in test (authored by bruns).
[PositionDbTest] Fix trivial memleak in test
Sat, Jun 15, 7:33 PM
bruns added inline comments to D21830: Format photo exposure bias value.
Sat, Jun 15, 1:24 PM · Baloo, Frameworks
bruns added inline comments to D21830: Format photo exposure bias value.
Sat, Jun 15, 12:01 PM · Baloo, Frameworks
bruns added a comment to D21830: Format photo exposure bias value.

Many cameras can be switched to 1/2 EV steps.

Damn ;) do you know any other values? In case not, I would add this case in a loop and stupidly try everything

Sat, Jun 15, 11:51 AM · Baloo, Frameworks
bruns added a comment to D21830: Format photo exposure bias value.

Many cameras can be switched to 1/2 EV steps.

Sat, Jun 15, 11:30 AM · Baloo, Frameworks
bruns committed R293:bb011d2fc034: [PendingFileQueueTest] Verify create + delete do not emit extra events (authored by bruns).
[PendingFileQueueTest] Verify create + delete do not emit extra events
Sat, Jun 15, 10:59 AM
bruns closed D21809: [PendingFileQueueTest] Verify create + delete do not emit extra events.
Sat, Jun 15, 10:59 AM · Baloo, Frameworks
bruns committed R293:309518239d77: [PendingFileQueueTest] Verify delete + create actually works (authored by bruns).
[PendingFileQueueTest] Verify delete + create actually works
Sat, Jun 15, 10:59 AM
bruns closed D21807: [PendingFileQueueTest] Verify delete + create actually works.
Sat, Jun 15, 10:59 AM · Baloo, Frameworks
bruns closed D21709: [PendingFileQueue] Avoid delete + create / create + delete race.
Sat, Jun 15, 10:57 AM · Baloo, Frameworks
bruns committed R293:9b0ecc5d41b0: [PendingFileQueue] Avoid delete + create / create + delete race (authored by bruns).
[PendingFileQueue] Avoid delete + create / create + delete race
Sat, Jun 15, 10:57 AM

Fri, Jun 14

bruns added inline comments to D21788: Make Plasma::Svg::elementRect a bit leaner.
Fri, Jun 14, 11:02 PM · Frameworks
bruns added a dependent revision for D21807: [PendingFileQueueTest] Verify delete + create actually works: D21809: [PendingFileQueueTest] Verify create + delete do not emit extra events.
Fri, Jun 14, 8:39 PM · Baloo, Frameworks
bruns requested review of D21809: [PendingFileQueueTest] Verify create + delete do not emit extra events.
Fri, Jun 14, 8:39 PM · Baloo, Frameworks
bruns requested review of D21807: [PendingFileQueueTest] Verify delete + create actually works.
Fri, Jun 14, 8:38 PM · Baloo, Frameworks
bruns committed R293:b2ebaf5293f1: [PendingFileQueueTest] Use synthetic timer events to speedup test (authored by bruns).
[PendingFileQueueTest] Use synthetic timer events to speedup test
Fri, Jun 14, 8:34 PM
bruns closed D21793: [PendingFileQueueTest] Use synthetic timer events to speedup test.
Fri, Jun 14, 8:34 PM · Baloo, Frameworks
bruns committed R293:a58296b2aa21: [XAttrIndexer] Update DocumentTime when XAttrs are updated (authored by bruns).
[XAttrIndexer] Update DocumentTime when XAttrs are updated
Fri, Jun 14, 7:55 PM
bruns closed D21707: [XAttrIndexer] Update DocumentTime when XAttrs are updated.
Fri, Jun 14, 7:55 PM · Baloo, Frameworks
bruns committed R293:b359101424d8: [PendingFileQueue] Refactor for easier and faster unit testing (authored by bruns).
[PendingFileQueue] Refactor for easier and faster unit testing
Fri, Jun 14, 7:54 PM
bruns closed D21792: [PendingFileQueue] Refactor for easier and faster unit testing.
Fri, Jun 14, 7:54 PM · Baloo, Frameworks
bruns closed D21791: [PendingFileQueueTest] Shorten timeouts, verify tracking time.
Fri, Jun 14, 7:52 PM · Baloo, Frameworks
bruns committed R293:25ae93a560aa: [PendingFileQueueTest] Shorten timeouts, verify tracking time (authored by bruns).
[PendingFileQueueTest] Shorten timeouts, verify tracking time
Fri, Jun 14, 7:52 PM
bruns committed R293:bf100941db29: [PendingFileQueue] Use more accurate calculation of remaining time (authored by bruns).
[PendingFileQueue] Use more accurate calculation of remaining time
Fri, Jun 14, 7:51 PM
bruns closed D21790: [PendingFileQueue] Use more accurate calculation of remaining time.
Fri, Jun 14, 7:51 PM · Baloo, Frameworks
bruns added inline comments to D21788: Make Plasma::Svg::elementRect a bit leaner.
Fri, Jun 14, 1:27 PM · Frameworks
bruns added inline comments to D21788: Make Plasma::Svg::elementRect a bit leaner.
Fri, Jun 14, 12:05 PM · Frameworks
bruns committed R286:bbb05dfe7f9f: [UserMetaData] Add method to query which attributes are set (authored by bruns).
[UserMetaData] Add method to query which attributes are set
Fri, Jun 14, 12:10 AM
bruns closed D20967: [UserMetaData] Add method to query which attributes are set.
Fri, Jun 14, 12:10 AM · Baloo, Frameworks
bruns added a comment to D20967: [UserMetaData] Add method to query which attributes are set.

FreeBSD and WIndows folks had their chance to speak up - Windows will just have to wait for the CI ...
FreeBSD has been reviewed, @arrowd - Thanks!

Fri, Jun 14, 12:05 AM · Baloo, Frameworks

Thu, Jun 13

bruns added a dependency for D21791: [PendingFileQueueTest] Shorten timeouts, verify tracking time: D21790: [PendingFileQueue] Use more accurate calculation of remaining time.
Thu, Jun 13, 11:48 PM · Baloo, Frameworks
bruns added a dependent revision for D21790: [PendingFileQueue] Use more accurate calculation of remaining time: D21791: [PendingFileQueueTest] Shorten timeouts, verify tracking time.
Thu, Jun 13, 11:48 PM · Baloo, Frameworks
bruns added a dependency for D21793: [PendingFileQueueTest] Use synthetic timer events to speedup test: D21792: [PendingFileQueue] Refactor for easier and faster unit testing.
Thu, Jun 13, 11:47 PM · Baloo, Frameworks
bruns added a dependent revision for D21792: [PendingFileQueue] Refactor for easier and faster unit testing: D21793: [PendingFileQueueTest] Use synthetic timer events to speedup test.
Thu, Jun 13, 11:47 PM · Baloo, Frameworks
bruns added a comment to D21709: [PendingFileQueue] Avoid delete + create / create + delete race.

LGTM, but maybe an autotest might make sense for this case.

Thu, Jun 13, 11:46 PM · Baloo, Frameworks
bruns requested review of D21793: [PendingFileQueueTest] Use synthetic timer events to speedup test.
Thu, Jun 13, 11:34 PM · Baloo, Frameworks
bruns requested review of D21792: [PendingFileQueue] Refactor for easier and faster unit testing.
Thu, Jun 13, 11:23 PM · Baloo, Frameworks
bruns requested review of D21791: [PendingFileQueueTest] Shorten timeouts, verify tracking time.
Thu, Jun 13, 11:22 PM · Baloo, Frameworks
bruns requested review of D21790: [PendingFileQueue] Use more accurate calculation of remaining time.
Thu, Jun 13, 11:22 PM · Baloo, Frameworks
bruns added a comment to D21788: Make Plasma::Svg::elementRect a bit leaner.

Please put the dead code removal in a separate review.

Thu, Jun 13, 11:15 PM · Frameworks

Wed, Jun 12

bruns committed R293:4fcbfee9b669: [ModifiedFileIndexer] Use correct mimetype for folders, delay until needed (authored by bruns).
[ModifiedFileIndexer] Use correct mimetype for folders, delay until needed
Wed, Jun 12, 7:35 PM
bruns closed D21706: [ModifiedFileIndexer] Use correct mimetype for folders, delay until needed.
Wed, Jun 12, 7:35 PM · Baloo, Frameworks
bruns added a comment to D11587: [WIP] autotests: Introduce TermGeneratorTestUTF.

queryparsertest.cpp and termgeneratortest.cpp no longer contain iso8859-* sequences, but only escaped UTF-8 sequences, see D17161

Wed, Jun 12, 7:35 AM · Baloo, Frameworks

Tue, Jun 11

bruns requested changes to D17816: Support for xattrs on kio copy/move.
Tue, Jun 11, 5:05 PM · Frameworks
bruns added a comment to D17816: Support for xattrs on kio copy/move.

There are several comments not addressed yet ...

Tue, Jun 11, 5:05 PM · Frameworks
bruns added a comment to D8532: [WIP] Restrict file extractor with Seccomp.

I totally agree with fvogt here - the extractors should just receive a readonly file descriptor.

Tue, Jun 11, 4:55 PM · Baloo, Frameworks

Mon, Jun 10

bruns updated the diff for D21706: [ModifiedFileIndexer] Use correct mimetype for folders, delay until needed.

update comment

Mon, Jun 10, 11:29 PM · Baloo, Frameworks
bruns committed R293:7b93ced321fc: [NewFileIndexer] Omit symlinks from the index (authored by bruns).
[NewFileIndexer] Omit symlinks from the index
Mon, Jun 10, 11:25 PM
bruns closed D21731: [NewFileIndexer] Omit symlinks from the index.
Mon, Jun 10, 11:25 PM · Baloo, Frameworks
bruns requested review of D21731: [NewFileIndexer] Omit symlinks from the index.
Mon, Jun 10, 6:11 PM · Baloo, Frameworks
bruns committed R293:00c75845ba43: [ModifiedFileIndexer] Avoid shadowing XAttr changes by content changes (authored by bruns).
[ModifiedFileIndexer] Avoid shadowing XAttr changes by content changes
Mon, Jun 10, 5:49 PM
bruns closed D21708: [ModifiedFileIndexer] Avoid shadowing XAttr changes by content changes.
Mon, Jun 10, 5:49 PM · Baloo, Frameworks
bruns committed R293:287d88c8becf: [NewFileIndexer] Use correct mimetype for folders, check excludeFolders (authored by bruns).
[NewFileIndexer] Use correct mimetype for folders, check excludeFolders
Mon, Jun 10, 5:47 PM
bruns closed D21705: [NewFileIndexer] Use correct mimetype for folders, check excludeFolders.
Mon, Jun 10, 5:47 PM · Baloo, Frameworks
bruns committed R293:0760b1261237: [UnindexedFileIndexer] Pick up comment, tags and rating changes (authored by bruns).
[UnindexedFileIndexer] Pick up comment, tags and rating changes
Mon, Jun 10, 5:45 PM
bruns closed D21680: [UnindexedFileIndexer] Pick up comment, tags and rating changes.
Mon, Jun 10, 5:45 PM · Baloo, Frameworks
bruns committed R293:ecc28c314e1a: [UnindexedFileIndexer] Skip filetime checks for new files (authored by bruns).
[UnindexedFileIndexer] Skip filetime checks for new files
Mon, Jun 10, 5:45 PM
bruns closed D21577: [UnindexedFileIndexer] Skip filetime checks for new files.
Mon, Jun 10, 5:45 PM · Baloo, Frameworks
bruns committed R293:7edec3499cbc: [DocumentUrlDB] Avoid manipulation of the whole tree on trivial rename (authored by bruns).
[DocumentUrlDB] Avoid manipulation of the whole tree on trivial rename
Mon, Jun 10, 5:43 PM
bruns closed D21694: [DocumentUrlDB] Avoid manipulation of the whole tree on trivial rename.
Mon, Jun 10, 5:43 PM · Baloo, Frameworks
bruns committed R293:8e7b54c54764: [DocumentUrlDB] Catch invalid URLs early (authored by bruns).
[DocumentUrlDB] Catch invalid URLs early
Mon, Jun 10, 5:42 PM
bruns closed D21693: [DocumentUrlDB] Catch invalid URLs early.
Mon, Jun 10, 5:42 PM · Baloo, Frameworks
bruns committed R293:4883ac516d5f: [DocumentUrlDB] Remove unused 'rename' method (authored by bruns).
[DocumentUrlDB] Remove unused 'rename' method
Mon, Jun 10, 5:39 PM
bruns closed D21692: [DocumentUrlDB] Remove unused 'rename' method.
Mon, Jun 10, 5:39 PM · Baloo, Frameworks
bruns committed R293:b54f8ec94ac2: [balooctl] Streamline indexer control commands (authored by bruns).
[balooctl] Streamline indexer control commands
Mon, Jun 10, 5:38 PM
bruns closed D21674: [balooctl] Streamline indexer control commands.
Mon, Jun 10, 5:38 PM · Baloo, Frameworks
bruns added inline comments to D21706: [ModifiedFileIndexer] Use correct mimetype for folders, delay until needed.
Mon, Jun 10, 3:01 PM · Baloo, Frameworks
bruns added a comment to D21671: [FileIndexScheduler] Stop the indexer when quit() is called via DBus.

Yes, mostly - the "after the current batch" caveat applies, so there may be still some delay.

Mon, Jun 10, 2:20 PM · Baloo, Frameworks
bruns committed R293:5b6fd8fe88b7: [Transaction] Replace template for functor with std::function (authored by bruns).
[Transaction] Replace template for functor with std::function
Mon, Jun 10, 2:14 PM
bruns closed D21703: [Transaction] Replace template for functor with std::function.
Mon, Jun 10, 2:14 PM · Baloo, Frameworks
bruns added a comment to D21703: [Transaction] Replace template for functor with std::function.

I thought about it myself. I googled it a bit (i.e. here) and saw that there might be some quite unwanted runtime overhead because of using std::function. It might be negligible (since we're doing some costly DB operations inside anyways), but I'd prefer if we did some profiling to make sure it's OK.

Mon, Jun 10, 1:29 PM · Baloo, Frameworks
bruns updated the diff for D20967: [UserMetaData] Add method to query which attributes are set.

initialize pos

Mon, Jun 10, 12:01 PM · Baloo, Frameworks
bruns committed R293:cb5621bb0dd7: [FirstRunIndexer] Use correct mimetype for folders (authored by bruns).
[FirstRunIndexer] Use correct mimetype for folders
Mon, Jun 10, 11:58 AM
bruns closed D21704: [FirstRunIndexer] Use correct mimetype for folders.
Mon, Jun 10, 11:58 AM · Baloo, Frameworks
bruns committed R293:b41afe1dc243: Move invariant IndexingLevel out of the loop (authored by bruns).
Move invariant IndexingLevel out of the loop
Mon, Jun 10, 11:52 AM
bruns closed D21698: Move invariant IndexingLevel out of the loop.
Mon, Jun 10, 11:52 AM · Baloo, Frameworks
bruns committed R293:9283a7e06cae: [BasicIndexingJob] Skip lookup of baloo document type for directories (authored by bruns).
[BasicIndexingJob] Skip lookup of baloo document type for directories
Mon, Jun 10, 11:50 AM
bruns closed D21697: [BasicIndexingJob] Skip lookup of baloo document type for directories.
Mon, Jun 10, 11:50 AM · Baloo, Frameworks
bruns updated the diff for D20967: [UserMetaData] Add method to query which attributes are set.

add and use split helper for BSD

Mon, Jun 10, 11:47 AM · Baloo, Frameworks
bruns added a comment to D20967: [UserMetaData] Add method to query which attributes are set.
PASS   : UserMetaDataWriterTest::initTestCase()
QDEBUG : UserMetaDataWriterTest::test() extattr_list size: 14
QDEBUG : UserMetaDataWriterTest::test() extattr_list size: 14
QDEBUG : UserMetaDataWriterTest::test() extattr_list r: 14 "\ruser.xdg.tags"
FAIL!  : UserMetaDataWriterTest::test() 'md.queryAttributes(UserMetaData::Attribute::All) & UserMetaData::Attribute::Tags' returned FALSE. ()
   Loc: [/home/arr/projects/kfilemetadata/autotests/usermetadatawritertest.cpp(55)]
Mon, Jun 10, 11:33 AM · Baloo, Frameworks
bruns accepted D21720: Enable usermetadatawritertest for all UNIXes, not only Linux..

Also matches Linux

Mon, Jun 10, 11:25 AM · Baloo, Frameworks
bruns added inline comments to D20967: [UserMetaData] Add method to query which attributes are set.
Mon, Jun 10, 11:14 AM · Baloo, Frameworks
bruns added a comment to D20967: [UserMetaData] Add method to query which attributes are set.

Apparently, the usermetadatawritertest was not executed on *BSD before, can you check if the test succeeds on the old code?

Mon, Jun 10, 11:10 AM · Baloo, Frameworks
bruns updated the diff for D20967: [UserMetaData] Add method to query which attributes are set.

update since

Mon, Jun 10, 10:55 AM · Baloo, Frameworks
bruns added inline comments to D20967: [UserMetaData] Add method to query which attributes are set.
Mon, Jun 10, 10:54 AM · Baloo, Frameworks
bruns updated the diff for D20967: [UserMetaData] Add method to query which attributes are set.

fix BSD code

Mon, Jun 10, 10:53 AM · Baloo, Frameworks
bruns committed R293:dfefd66e6e75: [FileIndexScheduler] Ensure indexer is not run in suspended state (authored by bruns).
[FileIndexScheduler] Ensure indexer is not run in suspended state
Mon, Jun 10, 10:39 AM
bruns closed D21673: [FileIndexScheduler] Ensure indexer is not run in suspended state.
Mon, Jun 10, 10:39 AM · Baloo, Frameworks
bruns closed D21672: [PowerStateMonitor] Be conservative when determining power state.
Mon, Jun 10, 10:31 AM · Baloo, Frameworks
bruns committed R293:0e6f1c923782: [PowerStateMonitor] Be conservative when determining power state (authored by bruns).
[PowerStateMonitor] Be conservative when determining power state
Mon, Jun 10, 10:31 AM
bruns committed R293:d74d1cbb65db: [FileIndexScheduler] Stop the indexer when quit() is called via DBus (authored by bruns).
[FileIndexScheduler] Stop the indexer when quit() is called via DBus
Mon, Jun 10, 10:31 AM
bruns closed D21671: [FileIndexScheduler] Stop the indexer when quit() is called via DBus.
Mon, Jun 10, 10:31 AM · Baloo, Frameworks

Sun, Jun 9

bruns added a comment to D21004: [UserMetaData] Shortcut attribute queries for the common case.

Ping!

Sun, Jun 9, 11:15 PM · Baloo
bruns updated subscribers of D20967: [UserMetaData] Add method to query which attributes are set.
Sun, Jun 9, 11:14 PM · Baloo, Frameworks
bruns added a comment to D20967: [UserMetaData] Add method to query which attributes are set.

Ping!

Sun, Jun 9, 11:13 PM · Baloo, Frameworks