bruns (Stefan Brüns)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 2 2017, 12:03 PM (106 w, 6 d)
Availability
Available

Recent Activity

Thu, Apr 18

bruns committed R293:812523dfd960: [balooctl] Switch multiline output to new helper (authored by bruns).
[balooctl] Switch multiline output to new helper
Thu, Apr 18, 3:43 PM
bruns closed D20620: [balooctl] Switch multiline output to new helper.
Thu, Apr 18, 3:43 PM · Baloo, Frameworks
bruns committed R293:d0057aebd715: [balooctl] Use new helper in json output (authored by bruns).
[balooctl] Use new helper in json output
Thu, Apr 18, 3:43 PM
bruns closed D20619: [balooctl] Use new helper in json output.
Thu, Apr 18, 3:43 PM · Baloo, Frameworks
bruns updated the diff for D20524: [FileMetaDataWidget] Allow inline configuration of visible properties.

reset column stretch

Thu, Apr 18, 3:41 PM · Baloo
bruns retitled D20667: Make the FileMetadataWidget stretch vertically in a sensible way from Make the FileMetadataWidget vertical stretch in a sensible way to Make the FileMetadataWidget stretch vertically in a sensible way.
Thu, Apr 18, 3:02 PM · Baloo
bruns added a dependency for D20667: Make the FileMetadataWidget stretch vertically in a sensible way: D20524: [FileMetaDataWidget] Allow inline configuration of visible properties.
Thu, Apr 18, 3:01 PM · Baloo
bruns added a dependent revision for D20524: [FileMetaDataWidget] Allow inline configuration of visible properties: D20667: Make the FileMetadataWidget stretch vertically in a sensible way.
Thu, Apr 18, 3:01 PM · Baloo
bruns added a dependent revision for D20667: Make the FileMetadataWidget stretch vertically in a sensible way: D20668: [InformationPanel] Remove obsolete intermediate wrapper widget/layout The Baloo::MetaDataWidget is now able to stretch in a meaningful way by itself, remove the wrapper..
Thu, Apr 18, 3:00 PM · Baloo
bruns requested review of D20668: [InformationPanel] Remove obsolete intermediate wrapper widget/layout The Baloo::MetaDataWidget is now able to stretch in a meaningful way by itself, remove the wrapper..
Thu, Apr 18, 3:00 PM · Dolphin
bruns requested review of D20667: Make the FileMetadataWidget stretch vertically in a sensible way.
Thu, Apr 18, 2:59 PM · Baloo
bruns updated the diff for D20524: [FileMetaDataWidget] Allow inline configuration of visible properties.

Layout cleanup

  • remove extra spacer
  • keep checkbox near label (align right)
Thu, Apr 18, 2:53 PM · Baloo
bruns committed R318:e26e823909f3: Fix missing update of file name label in information panel without preview (authored by bruns).
Fix missing update of file name label in information panel without preview
Thu, Apr 18, 1:45 PM
bruns closed D20660: Fix missing update of file name label in information panel without preview.
Thu, Apr 18, 1:45 PM · Dolphin
bruns committed R293:634e490b58a4: [balooctl] Use new helper for simple format output (authored by bruns).
[balooctl] Use new helper for simple format output
Thu, Apr 18, 12:45 PM
bruns committed R293:a9c230f64519: [balooctl] Factor out file index status collection from output (authored by bruns).
[balooctl] Factor out file index status collection from output
Thu, Apr 18, 12:45 PM
bruns closed D20618: [balooctl] Use new helper for simple format output.
Thu, Apr 18, 12:45 PM · Baloo, Frameworks
bruns closed D20617: [balooctl] Factor out file index status collection from output.
Thu, Apr 18, 12:45 PM · Baloo, Frameworks
bruns requested review of D20660: Fix missing update of file name label in information panel without preview.
Thu, Apr 18, 12:41 PM · Dolphin
bruns added inline comments to D20620: [balooctl] Switch multiline output to new helper.
Thu, Apr 18, 12:23 AM · Baloo, Frameworks

Wed, Apr 17

bruns added a comment to D20529: add license to python test files.

can we get the full command it's running?

ctest -V -R externalextractortest

That might be how the test is started, but how does it invoke Python?

Wed, Apr 17, 8:16 PM · Baloo, Frameworks
bruns accepted D20608: Declare properties as meta type.
Wed, Apr 17, 12:01 AM · Baloo, Frameworks

Tue, Apr 16

bruns added a comment to D20529: add license to python test files.

can we get the full command it's running?

Tue, Apr 16, 11:29 PM · Baloo, Frameworks
bruns added a comment to D20529: add license to python test files.

The Python installation on the CI nodes is most definitely complete (the CI Tooling itself used to perform the builds is written entirely in Python)

I'd therefore suggest that something isn't entirely right with how Python is being executed by the tests here... can we get the full command it's running?

Tue, Apr 16, 11:25 PM · Baloo, Frameworks
bruns updated the diff for D20525: [InformationPanel] Use the new inline configuration mode.

disable configure action when in configuration mode

Tue, Apr 16, 11:08 PM · Dolphin
bruns requested review of D20620: [balooctl] Switch multiline output to new helper.
Tue, Apr 16, 10:37 PM · Baloo, Frameworks
bruns added a dependent revision for D20617: [balooctl] Factor out file index status collection from output: D20620: [balooctl] Switch multiline output to new helper.
Tue, Apr 16, 10:37 PM · Baloo, Frameworks
bruns added a dependent revision for D20617: [balooctl] Factor out file index status collection from output: D20619: [balooctl] Use new helper in json output.
Tue, Apr 16, 10:30 PM · Baloo, Frameworks
bruns requested review of D20619: [balooctl] Use new helper in json output.
Tue, Apr 16, 10:30 PM · Baloo, Frameworks
bruns requested review of D20618: [balooctl] Use new helper for simple format output.
Tue, Apr 16, 10:28 PM · Baloo, Frameworks
bruns added a dependent revision for D20617: [balooctl] Factor out file index status collection from output: D20618: [balooctl] Use new helper for simple format output.
Tue, Apr 16, 10:28 PM · Baloo, Frameworks
bruns requested review of D20617: [balooctl] Factor out file index status collection from output.
Tue, Apr 16, 10:24 PM · Baloo, Frameworks
bruns added a comment to D20525: [InformationPanel] Use the new inline configuration mode.

+1, this is a much nicer UI. Some of the text gets cut off horizontally though when the panel is narrow:

I imagine it would be even worse in German or with a Romance language. Maybe in edit mode, you can just show the properties and not their values as well?

This is probably a caused by the minimum width calculation now being off.

I think it is quite useful to have the values, especially for some more "obscure" properties. The user gets an immediate feedback if the property is the one she/he is interested in. Maybe just cutoff or ellide the value, and make sure the label is visible.

Tue, Apr 16, 1:28 PM · Dolphin

Mon, Apr 15

bruns updated the diff for D20524: [FileMetaDataWidget] Allow inline configuration of visible properties.

correct since version

Mon, Apr 15, 11:09 PM · Baloo
bruns added inline comments to D20525: [InformationPanel] Use the new inline configuration mode.
Mon, Apr 15, 10:09 AM · Dolphin
bruns updated the diff for D20525: [InformationPanel] Use the new inline configuration mode.

bump baloo widgets version
cleanup

Mon, Apr 15, 10:09 AM · Dolphin
bruns committed R293:5a8f402b56de: Keep empty Json metadata docs out of DocumentData DB (authored by bruns).
Keep empty Json metadata docs out of DocumentData DB
Mon, Apr 15, 7:51 AM
bruns closed D20556: Keep empty Json metadata docs out of DocumentData DB.
Mon, Apr 15, 7:51 AM · Baloo, Frameworks

Sun, Apr 14

bruns requested review of D20556: Keep empty Json metadata docs out of DocumentData DB.
Sun, Apr 14, 8:13 PM · Baloo, Frameworks
bruns committed R293:d87b12fe482f: [balooshow] Allow referencing files by URL from hardlink (authored by bruns).
[balooshow] Allow referencing files by URL from hardlink
Sun, Apr 14, 8:03 PM
bruns committed R293:e8306dec225f: [balooshow] Suppress warning when URL refers to unindexed file (authored by bruns).
[balooshow] Suppress warning when URL refers to unindexed file
Sun, Apr 14, 8:03 PM
bruns updated the diff for D20524: [FileMetaDataWidget] Allow inline configuration of visible properties.

add apidox, cleanup

Sun, Apr 14, 3:01 PM · Baloo
bruns added a comment to D20524: [FileMetaDataWidget] Allow inline configuration of visible properties.

Hmm, it seems you need to rebase this patch:

Worked for me:

 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D20524.


    This diff is against commit b26a3680b04cb9877721d693eb79ccb321fe40aa, but
    the commit is nowhere in the working copy. Try to apply it against the
    current working copy state? (5f2ab5c62dd56e5a1dae468355c9e72d84d94398)
    [Y/n] y

Checking patch src/filemetadatawidget.h...
Checking patch src/filemetadatawidget.cpp...
Applied patch src/filemetadatawidget.h cleanly.
Applied patch src/filemetadatawidget.cpp cleanly.
 OKAY  Successfully committed patch.
Sun, Apr 14, 2:52 PM · Baloo
bruns added a comment to D20525: [InformationPanel] Use the new inline configuration mode.

+1, this is a much nicer UI. Some of the text gets cut off horizontally though when the panel is narrow:

I imagine it would be even worse in German or with a Romance language. Maybe in edit mode, you can just show the properties and not their values as well?

Sun, Apr 14, 2:20 PM · Dolphin
bruns added a comment to D20526: fix extracting of some properties to match what was writen.

IMHO for searching, the separation from a single string into multiple entries is the best thing to do, from a metadata editing point of view not so much.
How about inserting the TStringList entry by entry, without using the contactsFromString method? That would maintain the exact representation of metadata tags also for the baloo database.

Sun, Apr 14, 2:08 PM · Baloo, Frameworks
bruns accepted D20529: add license to python test files.
Sun, Apr 14, 1:57 PM · Baloo, Frameworks
bruns accepted D19445: Handle variant list in formatting functions.
Sun, Apr 14, 1:56 PM · Baloo, Frameworks
bruns accepted D20528: Change properties attributes for consistency.

10 lines removed, 1 added, 10 times more functionality 👍

Sun, Apr 14, 1:54 PM · Baloo, Frameworks
bruns updated the summary of D20524: [FileMetaDataWidget] Allow inline configuration of visible properties.
Sun, Apr 14, 1:51 PM · Baloo
bruns added inline comments to D20524: [FileMetaDataWidget] Allow inline configuration of visible properties.
Sun, Apr 14, 1:50 PM · Baloo
bruns updated the summary of D20525: [InformationPanel] Use the new inline configuration mode.
Sun, Apr 14, 1:49 PM · Dolphin
bruns updated subscribers of D20529: add license to python test files.

@bcooksley - these tests currently fail to run under Windows: https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5 WindowsMSVCQt5.11/149/testReport

Sun, Apr 14, 1:28 PM · Baloo, Frameworks
bruns accepted D20404: Allow the baloo widgets to display creation date and access date..
Sun, Apr 14, 1:13 PM · Baloo
bruns added inline comments to D20513: Remove last traces of KFileMetaDataWidget from information panel.
Sun, Apr 14, 1:00 PM · Dolphin
bruns updated the diff for D20525: [InformationPanel] Use the new inline configuration mode.

rebase

Sun, Apr 14, 1:00 PM · Dolphin
bruns committed R318:05a4d27813e3: Remove last traces of KFileMetaDataWidget from information panel (authored by bruns).
Remove last traces of KFileMetaDataWidget from information panel
Sun, Apr 14, 12:59 PM
bruns closed D20513: Remove last traces of KFileMetaDataWidget from information panel.
Sun, Apr 14, 12:59 PM · Dolphin
bruns updated the diff for D20513: Remove last traces of KFileMetaDataWidget from information panel.

remove one more reference in comments

Sun, Apr 14, 12:56 PM · Dolphin
bruns committed R318:3b491c3ccdad: [Information Panel] Remove nullptr checks for MetaDataWidget member (authored by bruns).
[Information Panel] Remove nullptr checks for MetaDataWidget member
Sun, Apr 14, 12:45 PM
bruns closed D20514: [Information Panel] Remove nullptr checks for MetaDataWidget member.
Sun, Apr 14, 12:45 PM · Dolphin
bruns committed R824:c51ec36cee75: Remove a dead declaration (authored by bruns).
Remove a dead declaration
Sun, Apr 14, 12:39 PM
bruns closed D20523: Remove a dead declaration.
Sun, Apr 14, 12:39 PM · Baloo
bruns added a comment to D20525: [InformationPanel] Use the new inline configuration mode.

After selecting "Configure ..." from the context menu:

Sun, Apr 14, 4:12 AM · Dolphin
bruns updated the diff for D20525: [InformationPanel] Use the new inline configuration mode.

remove obsolete include

Sun, Apr 14, 4:06 AM · Dolphin
bruns added a comment to D20525: [InformationPanel] Use the new inline configuration mode.

Sun, Apr 14, 4:02 AM · Dolphin
bruns added a dependent revision for D20524: [FileMetaDataWidget] Allow inline configuration of visible properties: D20525: [InformationPanel] Use the new inline configuration mode.
Sun, Apr 14, 4:01 AM · Baloo
bruns requested review of D20525: [InformationPanel] Use the new inline configuration mode.
Sun, Apr 14, 4:01 AM · Dolphin
bruns requested review of D20524: [FileMetaDataWidget] Allow inline configuration of visible properties.
Sun, Apr 14, 3:52 AM · Baloo
bruns requested review of D20523: Remove a dead declaration.
Sun, Apr 14, 3:51 AM · Baloo
bruns added a comment to D20513: Remove last traces of KFileMetaDataWidget from information panel.

Won't this close the door on ever being able to implement something like https://bugs.kde.org/show_bug.cgi?id=406506?

Not that the current UX is that great...

Sun, Apr 14, 3:02 AM · Dolphin

Sat, Apr 13

bruns committed R824:49e778edf7bd: Remove trailing whitespace (authored by bruns).
Remove trailing whitespace
Sat, Apr 13, 5:45 PM
bruns added a reviewer for D20513: Remove last traces of KFileMetaDataWidget from information panel: Dolphin.
Sat, Apr 13, 5:39 PM · Dolphin
bruns requested review of D20514: [Information Panel] Remove nullptr checks for MetaDataWidget member.
Sat, Apr 13, 5:39 PM · Dolphin
bruns requested review of D20513: Remove last traces of KFileMetaDataWidget from information panel.
Sat, Apr 13, 5:36 PM · Dolphin
bruns added a comment to T7878: Create or find Icon.

Scaled down and simplified SVG version

Sat, Apr 13, 2:20 PM · Baloo
bruns accepted D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28.

I think its better go give it sufficient testing time than to wait for more comments. The code has been around for sufficient time, and the last changes were just minor.

Sat, Apr 13, 1:17 PM · Frameworks

Fri, Apr 12

bruns committed R824:06a75822671b: Avoid indirection when inserting basic data (authored by bruns).
Avoid indirection when inserting basic data
Fri, Apr 12, 10:46 PM
bruns closed D20477: Avoid indirection when inserting basic data.
Fri, Apr 12, 10:46 PM · Baloo
bruns requested review of D20477: Avoid indirection when inserting basic data.
Fri, Apr 12, 12:07 AM · Baloo

Thu, Apr 11

bruns committed R824:949aff7df258: Remove trailing whitespace (authored by bruns).
Remove trailing whitespace
Thu, Apr 11, 11:48 PM
bruns committed R293:8fcd690fe853: Simplify orPostingIterator and make it faster (authored by bruns).
Simplify orPostingIterator and make it faster
Thu, Apr 11, 9:48 PM
bruns closed D11828: Simplify orPostingIterator and make it faster.
Thu, Apr 11, 9:48 PM · Baloo, Frameworks
bruns committed R293:899ed35c6872: Ensure QFileInfo is valid for the first FilteredDirIterator entry (authored by bruns).
Ensure QFileInfo is valid for the first FilteredDirIterator entry
Thu, Apr 11, 9:36 PM
bruns closed D20332: Ensure QFileInfo is valid for the first FilteredDirIterator entry.
Thu, Apr 11, 9:36 PM · Baloo, Frameworks
bruns committed R293:94c39a1d5c69: [MTimeDB] Allow timestamp newer than the newest document in range match (authored by bruns).
[MTimeDB] Allow timestamp newer than the newest document in range match
Thu, Apr 11, 9:35 PM
bruns closed D20331: [MTimeDB] Allow timestamp newer than the newest document in range match.
Thu, Apr 11, 9:35 PM · Baloo, Frameworks
bruns committed R293:c6fc67aba070: [MTimeDB] Use exact match when exact match is requested (authored by bruns).
[MTimeDB] Use exact match when exact match is requested
Thu, Apr 11, 9:28 PM
bruns closed D20330: [MTimeDB] Use exact match when exact match is requested.
Thu, Apr 11, 9:28 PM · Baloo, Frameworks
bruns committed R293:6f4f31b89b0f: [balooctl] Cleanup handling of different positional arguments (authored by bruns).
[balooctl] Cleanup handling of different positional arguments
Thu, Apr 11, 9:28 PM
bruns committed R293:f235bbf2ed93: [balooctl] Extend options help text, improve error checking (authored by bruns).
[balooctl] Extend options help text, improve error checking
Thu, Apr 11, 9:28 PM
bruns closed D20460: [balooctl] Cleanup handling of different positional arguments.
Thu, Apr 11, 9:28 PM · Baloo, Frameworks
bruns closed D20459: [balooctl] Extend options help text, improve error checking.
Thu, Apr 11, 9:28 PM · Baloo, Frameworks
bruns added a comment to D11828: Simplify orPostingIterator and make it faster.

Ping ...

Thu, Apr 11, 6:37 PM · Baloo, Frameworks
bruns added a comment to D20459: [balooctl] Extend options help text, improve error checking.

Aaargh, forgot to click submit.

Thu, Apr 11, 6:35 PM · Baloo, Frameworks
bruns accepted D20358: Force en locale for propertyinfotest.
Thu, Apr 11, 6:34 PM · Baloo, Frameworks
bruns added a comment to T9805: Overhaul Baloo database scheme.
In T9805#181576, @hyc wrote:
In T9805#181560, @bruns wrote:
In T9805#181517, @hyc wrote:

Fwiw, @poboiko is correct here.

Just because you hide the RMW, it does not mean it does not happen. For LMDB, duplicate keys are just a plain array, see e.g. MDB_APPENDDUP in http://www.lmdb.tech/doc/group__mdb.html#ga4fa8573d9236d54687c61827ebf8cac0

Nothing on that link implies use of an array anywhere.

MDB_GET_MULTIPLE returns "up to a page of duplicate data items from current cursor position", so apparently the values for DUPFIXED are packed, or is the page created during the mdb_cursor_get call?

You're mixing very separate cases. DUPFIXED is a special case of DUPSORT and yes, for DUPFIXED all of the items are packed in an array on a page with no per-item overhead.

Thu, Apr 11, 1:58 AM · Baloo
bruns committed R293:f8c51b237965: [balooctl] Use more understandable names for size in status output (authored by bruns).
[balooctl] Use more understandable names for size in status output
Thu, Apr 11, 1:02 AM
bruns closed D20458: [balooctl] Use more understandable names for size in status output.
Thu, Apr 11, 1:02 AM · Baloo, Frameworks
bruns committed R293:ceb9b3756106: [balooctl] clear command: Remove bogus check for documentData, cleanup (authored by bruns).
[balooctl] clear command: Remove bogus check for documentData, cleanup
Thu, Apr 11, 1:02 AM
bruns closed D20457: [balooctl] clear command: Remove bogus check for documentData, cleanup.
Thu, Apr 11, 1:02 AM · Baloo, Frameworks