bruns (Stefan Brüns)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 2 2017, 12:03 PM (151 w, 5 d)
Availability
Available

Recent Activity

Tue, Feb 25

bruns committed R119:0acbfba3b0e4: Remove redundant match for mountpoints (authored by bruns).
Remove redundant match for mountpoints
Tue, Feb 25, 11:52 PM
bruns closed D27636: Remove redundant match for mountpoints.
Tue, Feb 25, 11:52 PM · Plasma

Mon, Feb 24

bruns requested review of D27636: Remove redundant match for mountpoints.
Mon, Feb 24, 11:17 PM · Plasma
bruns committed R119:9dc634bdb1ec: Remove bogus mount points check when starting baloo on save (authored by bruns).
Remove bogus mount points check when starting baloo on save
Mon, Feb 24, 11:15 PM
bruns closed D27613: Remove bogus mount points check when starting baloo on save.
Mon, Feb 24, 11:15 PM · Plasma
bruns closed D27612: Remove unused functions.
Mon, Feb 24, 11:14 PM · Plasma
bruns committed R119:cd52299862ea: Remove unused functions (authored by bruns).
Remove unused functions
Mon, Feb 24, 11:14 PM
bruns closed D27611: Invert logic of shouldShowMountPoint -> ignoredMountPoint.
Mon, Feb 24, 11:12 PM · Plasma
bruns committed R119:31e823b6a67a: Invert logic of shouldShowMountPoint -> ignoredMountPoint (authored by bruns).
Invert logic of shouldShowMountPoint -> ignoredMountPoint
Mon, Feb 24, 11:12 PM
bruns updated the diff for D27611: Invert logic of shouldShowMountPoint -> ignoredMountPoint.

Update commit message (I hate Phabricator)

Mon, Feb 24, 11:12 PM · Plasma

Sun, Feb 23

bruns requested review of D27613: Remove bogus mount points check when starting baloo on save.
Sun, Feb 23, 11:46 PM · Plasma
bruns added a dependent revision for D27612: Remove unused functions: D27613: Remove bogus mount points check when starting baloo on save.
Sun, Feb 23, 11:46 PM · Plasma
bruns updated the diff for D27611: Invert logic of shouldShowMountPoint -> ignoredMountPoint.

ignoreMountPoint -> ignoredMountPoint
whitespace

Sun, Feb 23, 11:43 PM · Plasma
bruns added a comment to D27611: Invert logic of shouldShowMountPoint -> ignoredMountPoint.
In D27611#616556, @usta wrote:

2 Question :
1- isnt that method should be const'ified ?

Sun, Feb 23, 11:37 PM · Plasma
bruns updated the diff for D27612: Remove unused functions.

rebase

Sun, Feb 23, 11:32 PM · Plasma
bruns updated the diff for D27611: Invert logic of shouldShowMountPoint -> ignoredMountPoint.

move out of class

Sun, Feb 23, 11:31 PM · Plasma
bruns requested review of D27612: Remove unused functions.
Sun, Feb 23, 10:54 PM · Plasma
bruns added a dependent revision for D27611: Invert logic of shouldShowMountPoint -> ignoredMountPoint: D27612: Remove unused functions.
Sun, Feb 23, 10:54 PM · Plasma
bruns requested review of D27611: Invert logic of shouldShowMountPoint -> ignoredMountPoint.
Sun, Feb 23, 10:52 PM · Plasma
bruns committed R119:c4871cbc514f: Remove attempt to start long gone baloo_file_cleaner (authored by bruns).
Remove attempt to start long gone baloo_file_cleaner
Sun, Feb 23, 2:00 AM
bruns committed R119:616a99165eda: Remove attempt to start long gone baloo_file_cleaner (authored by bruns).
Remove attempt to start long gone baloo_file_cleaner
Sun, Feb 23, 1:58 AM
bruns closed D27579: Remove attempt to start long gone baloo_file_cleaner.
Sun, Feb 23, 1:58 AM · Plasma

Sat, Feb 22

bruns requested review of D27579: Remove attempt to start long gone baloo_file_cleaner.
Sat, Feb 22, 3:38 PM · Plasma

Sat, Feb 15

bruns added a comment to D27423: Don't show an error for a failed automatic refresh.

Save the comments, this looks reasonable to me.

Sat, Feb 15, 3:44 PM

Fri, Feb 14

bruns added a comment to D25583: Quit baloo_file_extractor if DB transaction fails.

From the viewpoint of baloo_file, the process just hangs, which is bad.

Fri, Feb 14, 3:33 PM · Baloo, Frameworks

Tue, Feb 11

bruns committed R293:bae7a9dd2361: [FileIndexScheduler] Force evaluation of indexerState after suspend/resume (authored by bruns).
[FileIndexScheduler] Force evaluation of indexerState after suspend/resume
Tue, Feb 11, 6:21 PM
bruns closed D27326: [FileIndexScheduler] Force evaluation of indexerState after suspend/resume.
Tue, Feb 11, 6:21 PM · Baloo, Frameworks
bruns added a comment to D27326: [FileIndexScheduler] Force evaluation of indexerState after suspend/resume.

Reported on reddit:
https://www.reddit.com/r/kde/comments/f1y1g0/baloo_doesnt_resume_after_suspend/

Tue, Feb 11, 3:52 PM · Baloo, Frameworks
bruns requested review of D27326: [FileIndexScheduler] Force evaluation of indexerState after suspend/resume.
Tue, Feb 11, 3:51 PM · Baloo, Frameworks

Tue, Feb 4

bruns added inline comments to D27152: Introduce FilesystemEntry class.
Tue, Feb 4, 9:48 PM · Frameworks
bruns requested changes to D27152: Introduce FilesystemEntry class.
Tue, Feb 4, 9:04 PM · Frameworks

Jan 27 2020

bruns added a comment to D26952: Make tags:/ ioslave not writable.

The idea was to assign a tag to a file by dropping a (multiple) file into a tag folder, and that somewhat works.

Jan 27 2020, 7:47 PM · Baloo, Frameworks

Jan 24 2020

bruns added a comment to D25583: Quit baloo_file_extractor if DB transaction fails.

... and sorry for the late answer ...

Jan 24 2020, 9:34 AM · Baloo, Frameworks
bruns added a comment to D25583: Quit baloo_file_extractor if DB transaction fails.

I will try to cook up a more complete solution over the weekend.

Jan 24 2020, 9:33 AM · Baloo, Frameworks

Jan 22 2020

bruns added a comment to D26841: hardware tool: define syntax via syntax arg.

Please do proper capitalization in the summary.

Jan 22 2020, 6:35 PM · Frameworks

Jan 18 2020

bruns added a comment to D26600: Refactor fstab handling.

and this is definitely too much code being moved around. Please split this up into multiple reviews.

Jan 18 2020, 9:35 PM · Frameworks
bruns requested changes to D26600: Refactor fstab handling.

Moving existing code to new files does not make you the copyright owner.

Jan 18 2020, 3:55 PM · Frameworks

Jan 16 2020

bruns added a comment to D26648: Improved quality of JPEG thumbnails.

Having had a look at https://code.woboq.org/qt5/qtbase/src/plugins/imageformats/jpeg/qjpeghandler.cpp.html#_M/HIGH_QUALITY_THRESHOLD, the jpeg handler actually know two different quality settings, < 50 and > 50, the default being 75, i.e. high.

Jan 16 2020, 4:24 PM · Frameworks, Dolphin

Jan 14 2020

bruns added a comment to D26648: Improved quality of JPEG thumbnails.

But as I mentioned there, it doesn't really influence on the decoding speed, and it was only needed to preserve the old behavior as much as possible.

Jan 14 2020, 3:33 PM · Frameworks, Dolphin
bruns added a comment to D26648: Improved quality of JPEG thumbnails.

Unfortunately, the QImageReader documentation is not very clear about the effect of setQuality(..). There is a reference to https://doc.qt.io/qt-5/qimagereader.html#setScaledSize, and that in turn has a reference to QImage::scale() (which no longer exists in Qt5) and Qt::SmoothScaling.

Jan 14 2020, 3:20 AM · Frameworks, Dolphin

Jan 10 2020

bruns requested changes to D26555: Rename 'nepomuk' Plasma Theme icons to 'search'.

The nepomuk icon is completely inappropriate for a generic "search" icon.

Jan 10 2020, 4:33 PM · Frameworks

Jan 8 2020

bruns accepted D26469: [FileMetaDataProvider] support symlinks with a new "Link to" item.
Jan 8 2020, 1:29 AM · Baloo

Jan 6 2020

bruns added a comment to D26469: [FileMetaDataProvider] support symlinks with a new "Link to" item.

In general I am fine with this, but we should strive for some consistency here:

Jan 6 2020, 8:25 PM · Baloo

Jan 5 2020

bruns added a comment to D25517: Add an option to extract image data and add front cover property.

The problem is the extractor serves two different use cases:

Jan 5 2020, 4:59 PM · Baloo, Frameworks
bruns added a comment to D25517: Add an option to extract image data and add front cover property.

I have thought about this and have come to the conclusion this is not really future proof.

Jan 5 2020, 12:25 AM · Baloo, Frameworks

Jan 4 2020

bruns added a comment to D26331: Removed reading description from .desktop files AND .directory files.

On the other hand I see that the dolphin GUI has an editable "Comment" on the right side, unfortunately it doesn't show in the treeview even after enabling the "Comments" column (bug?). And that's local, so not reusable for another user.

Jan 4 2020, 7:30 PM · Frameworks

Dec 22 2019

bruns added a comment to D26117: [solid] Clarify referencing of DeviceInterface.

No reason for being rude.

Dec 22 2019, 9:08 PM · Frameworks

Dec 21 2019

bruns added a comment to D26113: Places: For mounted volume display mount points instead of description.

The mount path is the only useful identifier. There is no filesystem label or similar.

Dec 21 2019, 7:54 PM · Frameworks
bruns added inline comments to D26099: Port QRegExp to QRegularExpression.
Dec 21 2019, 2:38 PM · Baloo, Frameworks
bruns requested changes to D26117: [solid] Clarify referencing of DeviceInterface.
Dec 21 2019, 2:16 PM · Frameworks
bruns added a comment to D26117: [solid] Clarify referencing of DeviceInterface.

I think the Summary is very poor.

Dec 21 2019, 2:15 PM · Frameworks
bruns added a comment to D26113: Places: For mounted volume display mount points instead of description.

I would consider an item changing its name based on the state a bug.

Dec 21 2019, 2:02 PM · Frameworks

Dec 19 2019

bruns added inline comments to D26098: Display first / in mounted storage access description.
Dec 19 2019, 6:17 PM · Frameworks
bruns accepted D25789: Correctly report if baloo_file is unavailable.

Thx

Dec 19 2019, 12:11 AM · Baloo, Frameworks

Dec 18 2019

bruns added a comment to D26089: baloo EBN transport protocol cleanup.

Are you meaning the whole aboutData.addAuthor line or just the change
that's in the patch?

Dec 18 2019, 7:57 PM · Baloo, Frameworks
bruns requested changes to D26089: baloo EBN transport protocol cleanup.
Dec 18 2019, 6:28 PM · Baloo, Frameworks

Dec 15 2019

bruns added inline comments to D25130: [dolphin/search] Search by (multiple) tags.
Dec 15 2019, 4:47 PM · Dolphin

Dec 14 2019

bruns requested changes to D25991: [KFilePlacesModel] Fix supported scheme check for devices.
Dec 14 2019, 4:32 PM · Frameworks, Plasma
bruns added inline comments to D25991: [KFilePlacesModel] Fix supported scheme check for devices.
Dec 14 2019, 4:32 PM · Frameworks, Plasma
bruns accepted D24433: Move URL parsing methods from kioslave to query object.
Dec 14 2019, 3:54 PM · Baloo, Frameworks

Dec 13 2019

bruns requested changes to D24433: Move URL parsing methods from kioslave to query object.

just nitpicks ...

Dec 13 2019, 1:13 AM · Baloo, Frameworks
bruns added inline comments to D24433: Move URL parsing methods from kioslave to query object.
Dec 13 2019, 1:12 AM · Baloo, Frameworks

Dec 12 2019

bruns accepted D25622: partial solution to accept accentuated characters on windows.

Again, Windows does not care ...

Dec 12 2019, 8:31 PM · Baloo, Frameworks
bruns added a comment to D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart.

please remove the 2 comments.

Dec 12 2019, 8:28 PM · Frameworks
bruns accepted D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart.
Dec 12 2019, 8:27 PM · Frameworks
bruns added a comment to D25934: [xattr] Fix passing negative size to QByteArray.

Duplicate of D25414

Dec 12 2019, 8:19 PM · Baloo, Frameworks
bruns accepted D25414: xattr: fix crash on dangling symlinks.
Dec 12 2019, 8:17 PM · Baloo, Frameworks
bruns accepted D25516: Remove unrequired private declarations for taglibextractor.
Dec 12 2019, 8:14 PM · Baloo, Frameworks

Dec 7 2019

bruns added inline comments to D25789: Correctly report if baloo_file is unavailable.
Dec 7 2019, 2:16 AM · Baloo, Frameworks

Nov 29 2019

bruns added a reviewer for D25622: partial solution to accept accentuated characters on windows: Windows.
Nov 29 2019, 11:28 PM · Baloo, Frameworks
bruns requested changes to D25583: Quit baloo_file_extractor if DB transaction fails.

Please allow some time for reviewing ...

Nov 29 2019, 6:00 PM · Baloo, Frameworks

Nov 26 2019

bruns added a comment to D25515: Only extract lyrics when the plain text flag is set.

The dolphin temp extractor uses KFileMetaData::ExtractionResult::ExtractMetaData explicitly.

Nov 26 2019, 11:49 PM · Baloo, Frameworks
bruns requested changes to D25516: Remove unrequired private declarations for taglibextractor.
Nov 26 2019, 11:39 PM · Baloo, Frameworks
bruns requested changes to D25517: Add an option to extract image data and add front cover property.
Nov 26 2019, 11:23 PM · Baloo, Frameworks

Nov 21 2019

bruns added a comment to D25443: [chmodjob] Port away from QLinkedList.

Or just change the direction?

Nov 21 2019, 8:05 PM · Frameworks
bruns added a comment to D25280: [Baloo KCM] Purge index when disabling indexing.

Agree with David/Thomas, first we need a "Suspend" button or similar.

Nov 21 2019, 4:13 PM · Plasma

Nov 20 2019

bruns requested changes to D25421: [kio_tags] improve log message when the database can't be opened.

This is obviously the wrong line of code for the referenced bug report.

Nov 20 2019, 3:42 PM · Baloo, Frameworks

Nov 19 2019

bruns added inline comments to D25414: xattr: fix crash on dangling symlinks.
Nov 19 2019, 10:54 PM · Baloo, Frameworks
bruns added a comment to D25414: xattr: fix crash on dangling symlinks.

Also add a testcase covering this, autotests/usermetadatawritertest.cpp

Nov 19 2019, 9:21 PM · Baloo, Frameworks
bruns added a comment to D25414: xattr: fix crash on dangling symlinks.

wrap the summary at <80 characters

Nov 19 2019, 9:17 PM · Baloo, Frameworks
bruns requested changes to D25414: xattr: fix crash on dangling symlinks.
Nov 19 2019, 9:16 PM · Baloo, Frameworks
bruns added inline comments to D25414: xattr: fix crash on dangling symlinks.
Nov 19 2019, 9:16 PM · Baloo, Frameworks

Nov 15 2019

bruns added inline comments to D25260: fix(search): Fix baloo searchString parsing.
Nov 15 2019, 9:44 PM · Dolphin
bruns requested changes to D25260: fix(search): Fix baloo searchString parsing.
Nov 15 2019, 9:12 PM · Dolphin
bruns added inline comments to D25260: fix(search): Fix baloo searchString parsing.
Nov 15 2019, 9:12 PM · Dolphin
bruns added a comment to D21235: Add handling of fuseiso filesystem type.

Moving it to a separate class will also make creating a unit test trivial.

Nov 15 2019, 8:14 PM · Frameworks
bruns requested changes to D21235: Add handling of fuseiso filesystem type.
Nov 15 2019, 8:07 PM · Frameworks

Nov 14 2019

bruns accepted D24959: Add new preferences search icons.
Nov 14 2019, 3:33 PM · Frameworks
bruns accepted D25258: test(search): Add test case for baloo parsing model.
Nov 14 2019, 12:15 AM · Dolphin

Nov 13 2019

bruns committed R824:a735a5ae2b5d: Remove no longer used IndexedDataRetriever (authored by bruns).
Remove no longer used IndexedDataRetriever
Nov 13 2019, 11:59 PM
bruns closed D25251: Remove no longer used IndexedDataRetriever.
Nov 13 2019, 11:59 PM · Baloo
bruns committed R824:d202cc3854c0: Use realtime indexing as fallback when DB has no property data (authored by bruns).
Use realtime indexing as fallback when DB has no property data
Nov 13 2019, 11:58 PM
bruns closed D25250: Use realtime indexing as fallback when DB has no property data.
Nov 13 2019, 11:58 PM · Baloo
bruns committed R824:064f4f2b3020: Split handling of on-demand extractor process from IndexedDataRetriever (authored by bruns).
Split handling of on-demand extractor process from IndexedDataRetriever
Nov 13 2019, 11:54 PM
bruns closed D25248: Split handling of on-demand extractor process from IndexedDataRetriever.
Nov 13 2019, 11:54 PM · Baloo
bruns committed R824:bb533b2d2ddb: Add categorized logging for baloo-widgets (authored by bruns).
Add categorized logging for baloo-widgets
Nov 13 2019, 11:53 PM
bruns closed D25247: Add categorized logging for baloo-widgets.
Nov 13 2019, 11:53 PM · Baloo
bruns added inline comments to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Nov 13 2019, 1:19 PM · Dolphin
bruns added a comment to D23787: [baloo_file_extractor] Improve handling of large plain-text files.

Can you please provide an example which:

  • is currently indexed though it should be skipped due to size
  • is skipped after this change

Sure. Any mimetype inherited from "text/plain", but starting with "text/" counts. I've made an actual list:


(using simple python script, which iterates over QMimeDatabase().allMimeTypes(), checks if type.inherits("text/plain") and is not already excluded by default Baloo config from file/fileexcludefilters.cpp)

Nov 13 2019, 12:32 PM · Baloo, Frameworks
bruns added a comment to D23787: [baloo_file_extractor] Improve handling of large plain-text files.

and another example which:

  • is currently skipped though it should be indexed
  • is indexed after this change

There shouldn't be any. I mean, "PlaintextExtractor" should be inside exList for anything that starts with text/...

Nov 13 2019, 12:27 PM · Baloo, Frameworks