bruns (Stefan Brüns)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 2 2017, 12:03 PM (88 w, 3 d)
Availability
Available

Recent Activity

Yesterday

bruns added a comment to D17518: Adapt favicon test to www.kde.org changes.

I also thought the favicon was too large for FavIconJob to download

Wed, Dec 12, 2:38 PM · Frameworks
bruns requested review of D17518: Adapt favicon test to www.kde.org changes.
Wed, Dec 12, 12:58 AM · Frameworks
bruns added a parent task for T10179: Reduce favicon.ico to a sane size: T6842: Kde.org overhaul.
Wed, Dec 12, 12:23 AM
bruns added a subtask for T6842: Kde.org overhaul: T10179: Reduce favicon.ico to a sane size.
Wed, Dec 12, 12:23 AM · KDE e.V., KDE Promo
bruns created T10179: Reduce favicon.ico to a sane size.
Wed, Dec 12, 12:23 AM

Tue, Dec 11

bruns accepted D15960: Don't check if file is directory based on mime-type.

Sorry, fell through the cracks - give a ping next time something is blocked for no apparent reason ...

Tue, Dec 11, 10:30 PM · Baloo, Frameworks

Thu, Dec 6

bruns accepted D16716: fail writing test if mime type is not supported by the extractor.
Thu, Dec 6, 8:33 PM · Baloo, Frameworks
bruns accepted D17301: add documentation to result class.
Thu, Dec 6, 8:20 PM · Baloo, Frameworks

Wed, Dec 5

bruns commandeered D10694: epubextractor: Handle multiple subjects better.

Picking this up ...

Wed, Dec 5, 8:44 PM · Frameworks, Dolphin, Baloo
bruns added a comment to D16716: fail writing test if mime type is not supported by the extractor.

I think that's my fault when I introduced the extractor for test. Apparently it is using the system libraries, and I'm looking for a solution.
I think a skip is still the right thing to do here, since we cannot determine if the tags are correctly written.

Wed, Dec 5, 2:49 PM · Baloo, Frameworks
bruns added inline comments to D17301: add documentation to result class.
Wed, Dec 5, 2:39 PM · Baloo, Frameworks
bruns accepted D16671: Refactor embedded image extractor for greater extensibility.
Wed, Dec 5, 2:38 PM · Baloo, Frameworks

Tue, Dec 4

bruns added a comment to D17301: add documentation to result class.

Thanks for your patience :)

Tue, Dec 4, 11:46 PM · Baloo, Frameworks
bruns accepted D17358: implement cover extraction for asf files.
Tue, Dec 4, 11:43 PM · Baloo, Frameworks
bruns added inline comments to D16671: Refactor embedded image extractor for greater extensibility.
Tue, Dec 4, 11:42 PM · Baloo, Frameworks
bruns accepted D17357: extend list of supported mimetypes for embedded image extractor.

Can you mention the file types and their corresponding mimetypes in the Summary? Thx.

Tue, Dec 4, 11:38 PM · Baloo, Frameworks
bruns added inline comments to D16671: Refactor embedded image extractor for greater extensibility.
Tue, Dec 4, 11:31 PM · Baloo, Frameworks
bruns committed R293:2c8d35247cae: Move internal helper from BasicIndexingJob to anonymous namespace (authored by bruns).
Move internal helper from BasicIndexingJob to anonymous namespace
Tue, Dec 4, 11:11 PM
bruns closed D17324: Move internal helper from BasicIndexingJob to anonymous namespace.
Tue, Dec 4, 11:11 PM · Baloo, Frameworks
bruns updated the diff for D17338: Move typesForMimeType helper from BasicIndexingJob to anonymous namespace.

add missing iterator increment

Tue, Dec 4, 12:02 AM · Baloo, Frameworks

Mon, Dec 3

bruns committed R293:eacc7ac92ab0: Add "image/svg" as Type::Image to the BasicIndexingJob (authored by bruns).
Add "image/svg" as Type::Image to the BasicIndexingJob
Mon, Dec 3, 11:58 PM
bruns closed D17337: Add "image/svg" as Type::Image to the BasicIndexingJob.
Mon, Dec 3, 11:58 PM · Baloo, Frameworks
bruns committed R293:c9281ac74e45: Minor optimization and cleanup for PositionCodec (authored by bruns).
Minor optimization and cleanup for PositionCodec
Mon, Dec 3, 11:57 PM
bruns closed D17332: Minor optimization and cleanup for PositionCodec.
Mon, Dec 3, 11:57 PM · Baloo, Frameworks
bruns added a comment to D17337: Add "image/svg" as Type::Image to the BasicIndexingJob.

text spans (i.e. content) in SVG.

Is indexing any of this actually useful? I worry that it would be just noise in >99% of cases.

Why should this be noise? Can you clarify?

This text in an SVG file is an implementation detail, not user content like the metadata in a JPEG. For example, here's the textual content of a random Breeze icon:

https://cgit.kde.org/breeze-icons.git/tree/icons/devices/64/computer.svg

Mon, Dec 3, 9:46 PM · Baloo, Frameworks
bruns added a comment to D17337: Add "image/svg" as Type::Image to the BasicIndexingJob.

text spans (i.e. content) in SVG.

Is indexing any of this actually useful? I worry that it would be just noise in >99% of cases.

Mon, Dec 3, 9:07 PM · Baloo, Frameworks
bruns added a comment to D17337: Add "image/svg" as Type::Image to the BasicIndexingJob.

Is indexing the contents of SVG images actually desirable? The fact that these files are internally represented by text rather than binary data is an implementation detail, and their contents are generally not useful since they're not intended to be human-readable.

Mon, Dec 3, 8:53 PM · Baloo, Frameworks
bruns updated the diff for D17338: Move typesForMimeType helper from BasicIndexingJob to anonymous namespace.

add missing closing parentheses

Mon, Dec 3, 6:53 PM · Baloo, Frameworks
bruns added a dependent revision for D17324: Move internal helper from BasicIndexingJob to anonymous namespace: D17338: Move typesForMimeType helper from BasicIndexingJob to anonymous namespace.
Mon, Dec 3, 6:49 PM · Baloo, Frameworks
bruns requested review of D17338: Move typesForMimeType helper from BasicIndexingJob to anonymous namespace.
Mon, Dec 3, 6:49 PM · Baloo, Frameworks
bruns requested review of D17337: Add "image/svg" as Type::Image to the BasicIndexingJob.
Mon, Dec 3, 6:48 PM · Baloo, Frameworks
bruns committed R293:4fa98ca84fb3: Avoid potential nullptr access for Document, use reference instead (authored by bruns).
Avoid potential nullptr access for Document, use reference instead
Mon, Dec 3, 6:48 PM
bruns closed D17315: Avoid potential nullptr access for Document, use reference instead.
Mon, Dec 3, 6:47 PM · Baloo, Frameworks
bruns requested changes to D17300: add result to baloo namespace.

Actually, this class is different - it is not part of the libraries, but statically linked into the extractor process

Mon, Dec 3, 5:16 PM · Baloo, Frameworks
bruns requested review of D17332: Minor optimization and cleanup for PositionCodec.
Mon, Dec 3, 2:55 PM · Baloo, Frameworks
bruns requested review of D17331: Extend PositionCodec unit tests, better code coverage.
Mon, Dec 3, 2:54 PM · Baloo, Frameworks
bruns committed R293:1b8904a2f2d7: RFC: Add unit test for splitting of numbers in TermGenerator (authored by bruns).
RFC: Add unit test for splitting of numbers in TermGenerator
Mon, Dec 3, 11:55 AM
bruns closed D17284: RFC: Add unit test for splitting of numbers in TermGenerator.
Mon, Dec 3, 11:55 AM · Baloo, Frameworks
bruns added inline comments to D17301: add documentation to result class.
Mon, Dec 3, 11:37 AM · Baloo, Frameworks
bruns added a comment to D16643: Correct the accept flag of the event object on DragMove .

This should not be accepted as is, it breaks the temporaryInhibition case when a DropArea is child of another

Mon, Dec 3, 11:07 AM · Frameworks

Sun, Dec 2

bruns accepted D17300: add result to baloo namespace.
Sun, Dec 2, 9:39 PM · Baloo, Frameworks
bruns added inline comments to D17245: Add string formatting function to property info.
Sun, Dec 2, 9:32 PM · Baloo, Frameworks
bruns added a dependent revision for D17315: Avoid potential nullptr access for Document, use reference instead: D17324: Move internal helper from BasicIndexingJob to anonymous namespace.
Sun, Dec 2, 9:08 PM · Baloo, Frameworks
bruns added a dependency for D17324: Move internal helper from BasicIndexingJob to anonymous namespace: D17315: Avoid potential nullptr access for Document, use reference instead.
Sun, Dec 2, 9:08 PM · Baloo, Frameworks
bruns requested review of D17324: Move internal helper from BasicIndexingJob to anonymous namespace.
Sun, Dec 2, 9:07 PM · Baloo, Frameworks
bruns updated the diff for D17315: Avoid potential nullptr access for Document, use reference instead.

reorder patches

Sun, Dec 2, 8:53 PM · Baloo, Frameworks
bruns accepted D16931: Extract more tags from exif metadata.
Sun, Dec 2, 8:08 PM · Baloo, Frameworks
bruns added a comment to D17315: Avoid potential nullptr access for Document, use reference instead.

This one doesn't apply, looks like D17824 is a dependency?

Sun, Dec 2, 8:04 PM · Baloo, Frameworks
bruns committed R293:b891716d336a: Use Compact json formatting for storing document metadata (authored by bruns).
Use Compact json formatting for storing document metadata
Sun, Dec 2, 8:01 PM
bruns closed D17313: Use Compact json formatting for storing document metadata.
Sun, Dec 2, 8:01 PM · Baloo, Frameworks
bruns committed R293:f614d56285bf: Remove unused map() getter from Result (authored by bruns).
Remove unused map() getter from Result
Sun, Dec 2, 8:00 PM
bruns closed D17312: Remove unused map() getter from Result.
Sun, Dec 2, 8:00 PM · Baloo, Frameworks
bruns added a comment to D17313: Use Compact json formatting for storing document metadata.

Might this make the DB take up less space on disk?

Sun, Dec 2, 7:46 PM · Baloo, Frameworks
bruns added a comment to D17313: Use Compact json formatting for storing document metadata.

This is backwards-compatible with the existing formal for retrieval, right?

Sun, Dec 2, 7:32 PM · Baloo, Frameworks
bruns accepted D17298: remove unused docId from result.
Sun, Dec 2, 7:30 PM · Baloo, Frameworks
bruns added a comment to D17298: remove unused docId from result.

libKF5BalooEngine is not exported to the outside world.

Sun, Dec 2, 7:28 PM · Baloo, Frameworks
bruns added a comment to D17299: move implementation of document get to cpp file.

yes, please.

Sun, Dec 2, 4:41 PM · Baloo, Frameworks
bruns added inline comments to D17302: add simple test for string merging.
Sun, Dec 2, 4:04 PM · Baloo, Frameworks
bruns requested review of D17315: Avoid potential nullptr access for Document, use reference instead.
Sun, Dec 2, 4:03 PM · Baloo, Frameworks
bruns requested changes to D17301: add documentation to result class.
Sun, Dec 2, 3:46 PM · Baloo, Frameworks
bruns added a dependent revision for D17312: Remove unused map() getter from Result: D17301: add documentation to result class.
Sun, Dec 2, 3:46 PM · Baloo, Frameworks
bruns added a dependency for D17301: add documentation to result class: D17312: Remove unused map() getter from Result.
Sun, Dec 2, 3:46 PM · Baloo, Frameworks
bruns added inline comments to D17301: add documentation to result class.
Sun, Dec 2, 3:42 PM · Baloo, Frameworks
bruns requested review of D17313: Use Compact json formatting for storing document metadata.
Sun, Dec 2, 3:40 PM · Baloo, Frameworks
bruns added a dependent revision for D17298: remove unused docId from result: D17312: Remove unused map() getter from Result.
Sun, Dec 2, 3:32 PM · Baloo, Frameworks
bruns requested review of D17312: Remove unused map() getter from Result.
Sun, Dec 2, 3:32 PM · Baloo, Frameworks
bruns committed R293:8efa39d4bbf1: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups (authored by bruns).
Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups
Sun, Dec 2, 3:17 PM
bruns closed D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups.
Sun, Dec 2, 3:17 PM · Baloo, Frameworks
bruns added a comment to D17298: remove unused docId from result.

Addition - the document id is also stored and can be retrieved from the Baloo::Document.

Sun, Dec 2, 3:12 PM · Baloo, Frameworks
bruns added inline comments to D17302: add simple test for string merging.
Sun, Dec 2, 1:56 PM · Baloo, Frameworks
bruns added a comment to D17299: move implementation of document get to cpp file.

Why?

Sun, Dec 2, 1:42 PM · Baloo, Frameworks
bruns added a comment to D17301: add documentation to result class.

I think methods reimplemented from and documented in KFileMetaData::ExtractionResult should not be documented here.

Sun, Dec 2, 1:37 PM · Baloo, Frameworks
bruns accepted D16826: Treat uints the same as ints.
Sun, Dec 2, 1:09 PM · Baloo, Frameworks
bruns added a comment to D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups.

Because the original file is latin1, thus not decodable as utf8, so it has to be binary ...
Stupid arc/phabricator

Sun, Dec 2, 1:07 PM · Baloo, Frameworks

Sat, Dec 1

bruns added a comment to D16826: Treat uints the same as ints.

Yes, UInt should be fine (actually, all our current integral numeric properties are unsigned).

Sat, Dec 1, 5:44 PM · Baloo, Frameworks
bruns added a comment to D16826: Treat uints the same as ints.

I think support for non-integers is useful in general, but there are a few things we should consider:

Sat, Dec 1, 5:26 PM · Baloo, Frameworks
bruns requested review of D17284: RFC: Add unit test for splitting of numbers in TermGenerator.
Sat, Dec 1, 5:12 PM · Baloo, Frameworks
bruns requested review of D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups.
Sat, Dec 1, 4:44 PM · Baloo, Frameworks
bruns committed R293:f0c68be03694: Add unittest to check if commiting the same change twice works (authored by bruns).
Add unittest to check if commiting the same change twice works
Sat, Dec 1, 4:32 PM
bruns closed D17199: Add unittest to check if commiting the same change twice works.
Sat, Dec 1, 4:32 PM · Baloo, Frameworks
bruns added a comment to D17199: Add unittest to check if commiting the same change twice works.

Conceptually, its independent of D17198, but there is a single line not matching in the context

Sat, Dec 1, 3:14 PM · Baloo, Frameworks
bruns committed R293:38925dd92f69: Add unit test for position DB (authored by bruns).
Add unit test for position DB
Sat, Dec 1, 3:14 PM
bruns closed D17198: Add unit test for position DB.
Sat, Dec 1, 3:14 PM · Baloo, Frameworks
bruns closed D17274: Remove duplicated code for rating property.
Sat, Dec 1, 1:51 PM · Baloo, Frameworks
bruns committed R293:49d08db3b943: Remove duplicated code for rating property (authored by bruns).
Remove duplicated code for rating property
Sat, Dec 1, 1:51 PM
bruns committed R293:8a390e188be2: Extend unit tests to check comparisons of multi-digit numeric properties (authored by bruns).
Extend unit tests to check comparisons of multi-digit numeric properties
Sat, Dec 1, 1:50 PM
bruns closed D17273: Extend unit tests to check comparisons of multi-digit numeric properties.
Sat, Dec 1, 1:50 PM · Baloo, Frameworks
bruns committed R293:e1045c4f7891: Fix searches for rating 10 (5 stars) (authored by bruns).
Fix searches for rating 10 (5 stars)
Sat, Dec 1, 1:48 PM
bruns closed D17272: Fix searches for rating 10 (5 stars).
Sat, Dec 1, 1:48 PM · Baloo, Frameworks
bruns committed R293:619547cbfefe: Remove extra spaces from Debug output, insert delimiters between fields (authored by bruns).
Remove extra spaces from Debug output, insert delimiters between fields
Sat, Dec 1, 1:48 PM
bruns closed D17160: Remove extra spaces from Debug output, insert delimiters between fields.
Sat, Dec 1, 1:48 PM · Baloo, Frameworks
bruns accepted D16617: fix extraction of GPS altitude for exif data.
Sat, Dec 1, 12:30 AM · Baloo, Frameworks

Fri, Nov 30

bruns added a dependency for D17274: Remove duplicated code for rating property: D17272: Fix searches for rating 10 (5 stars).
Fri, Nov 30, 11:41 PM · Baloo, Frameworks
bruns added a dependent revision for D17272: Fix searches for rating 10 (5 stars): D17274: Remove duplicated code for rating property.
Fri, Nov 30, 11:41 PM · Baloo, Frameworks
bruns requested review of D17274: Remove duplicated code for rating property.
Fri, Nov 30, 11:40 PM · Baloo, Frameworks
bruns updated the diff for D17272: Fix searches for rating 10 (5 stars).

Use qlonglong for comparing numeric properties

Fri, Nov 30, 11:39 PM · Baloo, Frameworks
bruns added a dependent revision for D17272: Fix searches for rating 10 (5 stars): D17273: Extend unit tests to check comparisons of multi-digit numeric properties.
Fri, Nov 30, 11:20 PM · Baloo, Frameworks
bruns added a dependency for D17273: Extend unit tests to check comparisons of multi-digit numeric properties: D17272: Fix searches for rating 10 (5 stars).
Fri, Nov 30, 11:20 PM · Baloo, Frameworks
bruns requested review of D17273: Extend unit tests to check comparisons of multi-digit numeric properties.
Fri, Nov 30, 11:19 PM · Baloo, Frameworks
bruns requested review of D17272: Fix searches for rating 10 (5 stars).
Fri, Nov 30, 11:19 PM · Baloo, Frameworks