bruns (Stefan Brüns)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 2 2017, 12:03 PM (139 w, 6 d)
Availability
Available

Recent Activity

Today

bruns added inline comments to D25789: Correctly report if baloo_file is unavailable.
Sat, Dec 7, 2:16 AM · Baloo, Frameworks

Fri, Nov 29

bruns added a reviewer for D25622: partial solution to accept accentuated characters on windows: Windows.
Fri, Nov 29, 11:28 PM · Baloo, Frameworks
bruns requested changes to D25583: Quit baloo_file_extractor if DB transaction fails.

Please allow some time for reviewing ...

Fri, Nov 29, 6:00 PM · Baloo, Frameworks

Tue, Nov 26

bruns added a comment to D25515: Only extract lyrics when the plain text flag is set.

The dolphin temp extractor uses KFileMetaData::ExtractionResult::ExtractMetaData explicitly.

Tue, Nov 26, 11:49 PM · Baloo, Frameworks
bruns requested changes to D25516: Remove unrequired private declarations for taglibextractor.
Tue, Nov 26, 11:39 PM · Baloo, Frameworks
bruns requested changes to D25517: Add an option to extract binary data and add front cover property.
Tue, Nov 26, 11:23 PM · Baloo, Frameworks

Thu, Nov 21

bruns added a comment to D25443: [chmodjob] Port away from QLinkedList.

Or just change the direction?

Thu, Nov 21, 8:05 PM · Frameworks
bruns added a comment to D25280: [Baloo KCM] Purge index when disabling indexing.

Agree with David/Thomas, first we need a "Suspend" button or similar.

Thu, Nov 21, 4:13 PM · Plasma

Wed, Nov 20

bruns requested changes to D25421: [kio_tags] improve log message when the database can't be opened.

This is obviously the wrong line of code for the referenced bug report.

Wed, Nov 20, 3:42 PM · Baloo, Frameworks

Tue, Nov 19

bruns added inline comments to D25414: xattr: fix crash on dangling symlinks.
Tue, Nov 19, 10:54 PM · Baloo, Frameworks
bruns added a comment to D25414: xattr: fix crash on dangling symlinks.

Also add a testcase covering this, autotests/usermetadatawritertest.cpp

Tue, Nov 19, 9:21 PM · Baloo, Frameworks
bruns added a comment to D25414: xattr: fix crash on dangling symlinks.

wrap the summary at <80 characters

Tue, Nov 19, 9:17 PM · Baloo, Frameworks
bruns requested changes to D25414: xattr: fix crash on dangling symlinks.
Tue, Nov 19, 9:16 PM · Baloo, Frameworks
bruns added inline comments to D25414: xattr: fix crash on dangling symlinks.
Tue, Nov 19, 9:16 PM · Baloo, Frameworks

Fri, Nov 15

bruns added inline comments to D25260: fix(search): Fix baloo searchString parsing.
Fri, Nov 15, 9:44 PM · Dolphin
bruns requested changes to D25260: fix(search): Fix baloo searchString parsing.
Fri, Nov 15, 9:12 PM · Dolphin
bruns added inline comments to D25260: fix(search): Fix baloo searchString parsing.
Fri, Nov 15, 9:12 PM · Dolphin
bruns added a comment to D21235: Add handling of fuseiso filesystem type.

Moving it to a separate class will also make creating a unit test trivial.

Fri, Nov 15, 8:14 PM · Frameworks
bruns requested changes to D21235: Add handling of fuseiso filesystem type.
Fri, Nov 15, 8:07 PM · Frameworks

Thu, Nov 14

bruns accepted D24959: Add new preferences search icons.
Thu, Nov 14, 3:33 PM · Frameworks
bruns accepted D25258: test(search): Add test case for baloo parsing model.
Thu, Nov 14, 12:15 AM · Dolphin

Wed, Nov 13

bruns committed R824:a735a5ae2b5d: Remove no longer used IndexedDataRetriever (authored by bruns).
Remove no longer used IndexedDataRetriever
Wed, Nov 13, 11:59 PM
bruns closed D25251: Remove no longer used IndexedDataRetriever.
Wed, Nov 13, 11:59 PM · Baloo
bruns committed R824:d202cc3854c0: Use realtime indexing as fallback when DB has no property data (authored by bruns).
Use realtime indexing as fallback when DB has no property data
Wed, Nov 13, 11:58 PM
bruns closed D25250: Use realtime indexing as fallback when DB has no property data.
Wed, Nov 13, 11:58 PM · Baloo
bruns committed R824:064f4f2b3020: Split handling of on-demand extractor process from IndexedDataRetriever (authored by bruns).
Split handling of on-demand extractor process from IndexedDataRetriever
Wed, Nov 13, 11:54 PM
bruns closed D25248: Split handling of on-demand extractor process from IndexedDataRetriever.
Wed, Nov 13, 11:54 PM · Baloo
bruns committed R824:bb533b2d2ddb: Add categorized logging for baloo-widgets (authored by bruns).
Add categorized logging for baloo-widgets
Wed, Nov 13, 11:53 PM
bruns closed D25247: Add categorized logging for baloo-widgets.
Wed, Nov 13, 11:53 PM · Baloo
bruns added inline comments to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Wed, Nov 13, 1:19 PM · Dolphin
bruns added a comment to D23787: [baloo_file_extractor] Improve handling of large plain-text files.

Can you please provide an example which:

  • is currently indexed though it should be skipped due to size
  • is skipped after this change

Sure. Any mimetype inherited from "text/plain", but starting with "text/" counts. I've made an actual list:


(using simple python script, which iterates over QMimeDatabase().allMimeTypes(), checks if type.inherits("text/plain") and is not already excluded by default Baloo config from file/fileexcludefilters.cpp)

Wed, Nov 13, 12:32 PM · Baloo, Frameworks
bruns added a comment to D23787: [baloo_file_extractor] Improve handling of large plain-text files.

and another example which:

  • is currently skipped though it should be indexed
  • is indexed after this change

There shouldn't be any. I mean, "PlaintextExtractor" should be inside exList for anything that starts with text/...

Wed, Nov 13, 12:27 PM · Baloo, Frameworks
bruns added a comment to D25257: refactor(search): De-couple baloo URL parsing logic from UI.

Please remove the Depends D25255 from the summary, this one is independent.

I'm afraid it won't work well without that, because it handles the empty case for type().
For the sake of simplicity, I could also abandon D25255 and keep the change here.

Wed, Nov 13, 12:38 AM · Dolphin

Tue, Nov 12

bruns accepted D25257: refactor(search): De-couple baloo URL parsing logic from UI.

Otherwise, LGTM now.

Tue, Nov 12, 11:11 PM · Dolphin
bruns added a comment to D25257: refactor(search): De-couple baloo URL parsing logic from UI.

Please remove the Depends D25255 from the summary, this one is independent.

Tue, Nov 12, 11:10 PM · Dolphin
bruns added inline comments to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Tue, Nov 12, 11:08 PM · Dolphin
bruns added inline comments to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Tue, Nov 12, 10:56 PM · Dolphin
bruns requested changes to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Tue, Nov 12, 10:51 PM · Dolphin

Mon, Nov 11

bruns updated subscribers of D24433: Move URL parsing methods from kioslave to query object.
Mon, Nov 11, 11:30 PM · Baloo, Frameworks
bruns added inline comments to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Mon, Nov 11, 10:33 PM · Dolphin
bruns added inline comments to D25258: test(search): Add test case for baloo parsing model.
Mon, Nov 11, 10:24 PM · Dolphin
bruns requested changes to D25258: test(search): Add test case for baloo parsing model.

Please move everything added to a new file, this is independent from the searchbox itself.

Mon, Nov 11, 10:15 PM · Dolphin
bruns added inline comments to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Mon, Nov 11, 9:54 PM · Dolphin
bruns added inline comments to D24433: Move URL parsing methods from kioslave to query object.
Mon, Nov 11, 3:05 PM · Baloo, Frameworks
bruns added a comment to D25257: refactor(search): De-couple baloo URL parsing logic from UI.

Please add a comment to the summary that the parser logic is exactly kept as is.

Mon, Nov 11, 2:36 PM · Dolphin
bruns added a comment to D25257: refactor(search): De-couple baloo URL parsing logic from UI.

This definitely goes in the right direction, thanks!

Mon, Nov 11, 2:11 PM · Dolphin
bruns added a dependent revision for D25250: Use realtime indexing as fallback when DB has no property data: D25251: Remove no longer used IndexedDataRetriever.
Mon, Nov 11, 3:40 AM · Baloo
bruns requested review of D25251: Remove no longer used IndexedDataRetriever.
Mon, Nov 11, 3:40 AM · Baloo
bruns requested review of D25250: Use realtime indexing as fallback when DB has no property data.
Mon, Nov 11, 3:23 AM · Baloo
bruns added a dependent revision for D25248: Split handling of on-demand extractor process from IndexedDataRetriever: D25250: Use realtime indexing as fallback when DB has no property data.
Mon, Nov 11, 3:23 AM · Baloo
bruns added a dependent revision for D25247: Add categorized logging for baloo-widgets: D25248: Split handling of on-demand extractor process from IndexedDataRetriever.
Mon, Nov 11, 1:34 AM · Baloo
bruns requested review of D25248: Split handling of on-demand extractor process from IndexedDataRetriever.
Mon, Nov 11, 1:34 AM · Baloo
bruns requested review of D25247: Add categorized logging for baloo-widgets.
Mon, Nov 11, 1:31 AM · Baloo
bruns committed R824:c20dc3cb2353: Fix value label mouse/keyboard interaction (authored by bruns).
Fix value label mouse/keyboard interaction
Mon, Nov 11, 1:28 AM
bruns closed D25241: Fix value label mouse/keyboard interaction.
Mon, Nov 11, 1:28 AM · Baloo
bruns committed R824:4cb9412920db: Prevent HTML injection in labels from unchecked sources (authored by bruns).
Prevent HTML injection in labels from unchecked sources
Mon, Nov 11, 1:27 AM
bruns closed D25240: Prevent HTML injection in labels from unchecked sources.
Mon, Nov 11, 1:27 AM · Baloo
bruns committed R824:84a0d9b23297: Do not mangle angle brackets in value widgets (authored by bruns).
Do not mangle angle brackets in value widgets
Mon, Nov 11, 1:26 AM
bruns closed D25239: Do not mangle angle brackets in value widgets.
Mon, Nov 11, 1:25 AM · Baloo
bruns committed R824:0dacef044c2f: Remove flawed noLinks handling for originUrls (authored by bruns).
Remove flawed noLinks handling for originUrls
Mon, Nov 11, 1:24 AM
bruns closed D25238: Remove flawed noLinks handling for originUrls.
Mon, Nov 11, 1:24 AM · Baloo

Sun, Nov 10

bruns added a comment to D25241: Fix value label mouse/keyboard interaction.

Bug; Only ellided URL can be copied

Sun, Nov 10, 5:27 PM · Baloo
bruns added a comment to D25240: Prevent HTML injection in labels from unchecked sources.

File with unsuspicious looking "nice" link

Sun, Nov 10, 5:22 PM · Baloo
bruns added a dependency for D25239: Do not mangle angle brackets in value widgets: D25238: Remove flawed noLinks handling for originUrls.
Sun, Nov 10, 5:19 PM · Baloo
bruns added a dependent revision for D25238: Remove flawed noLinks handling for originUrls: D25239: Do not mangle angle brackets in value widgets.
Sun, Nov 10, 5:19 PM · Baloo
bruns updated the test plan for D25238: Remove flawed noLinks handling for originUrls.
Sun, Nov 10, 5:18 PM · Baloo
bruns added a dependent revision for D25240: Prevent HTML injection in labels from unchecked sources: D25241: Fix value label mouse/keyboard interaction.
Sun, Nov 10, 5:12 PM · Baloo
bruns requested review of D25241: Fix value label mouse/keyboard interaction.
Sun, Nov 10, 5:12 PM · Baloo
bruns added a dependent revision for D25239: Do not mangle angle brackets in value widgets: D25240: Prevent HTML injection in labels from unchecked sources.
Sun, Nov 10, 5:11 PM · Baloo
bruns requested review of D25240: Prevent HTML injection in labels from unchecked sources.
Sun, Nov 10, 5:11 PM · Baloo
bruns requested review of D25239: Do not mangle angle brackets in value widgets.
Sun, Nov 10, 4:52 PM · Baloo
bruns requested review of D25238: Remove flawed noLinks handling for originUrls.
Sun, Nov 10, 4:21 PM · Baloo

Fri, Nov 8

bruns requested changes to D24422: [dolphin] Improve parsing of Baloo query searchString.

The problem with the original code is it mixes the model and the view.

Fri, Nov 8, 6:45 PM · Dolphin
bruns committed R824:4fdb2048f25d: [UserMetaData] Shortcut attribute queries for the common case (authored by bruns).
[UserMetaData] Shortcut attribute queries for the common case
Fri, Nov 8, 12:08 AM
bruns closed D21004: [UserMetaData] Shortcut attribute queries for the common case.
Fri, Nov 8, 12:08 AM · Baloo
bruns updated the diff for D21004: [UserMetaData] Shortcut attribute queries for the common case.

KF5_MIN_VERSION bump to 5.60

Fri, Nov 8, 12:07 AM · Baloo

Oct 30 2019

bruns added a comment to T9626: Fixup Chrome/Firefox Bookmarks KRunner.

I am not currently working on this, but the state is correct (temporary copies of the DBs should be avoided).

Oct 30 2019, 5:53 PM · Plasma

Oct 26 2019

bruns accepted D24958: Delete nepomuk icon.
Oct 26 2019, 2:57 PM · Frameworks
bruns added a comment to D24957: Add new baloo icons.

LGTM

Oct 26 2019, 2:56 PM · Frameworks
bruns added a comment to D24959: Add new preferences search icons.

Thats the "top level" icon, with "Krunner" and "File Search" (aka Baloo) below, correct?

Oct 26 2019, 2:48 PM · Frameworks

Oct 20 2019

bruns added inline comments to D21235: Add handling of fuseiso filesystem type.
Oct 20 2019, 1:23 PM · Frameworks
bruns added a comment to D24422: [dolphin] Improve parsing of Baloo query searchString.

Required changes for the Summary:

  • describe the issue in textual form, image references are to volatile
Oct 20 2019, 1:13 PM · Dolphin

Oct 18 2019

bruns requested changes to D21235: Add handling of fuseiso filesystem type.
Oct 18 2019, 6:03 PM · Frameworks

Oct 17 2019

bruns added a comment to T7878: Create or find Icon.

The 32px is a little bit fuzzy, but definitely betterthan what we have currently. I would say, go for it!

Oct 17 2019, 7:36 PM · VDG, Baloo
bruns added a comment to T7878: Create or find Icon.

@astippich - the circle in the background is a very nice improvement!

Oct 17 2019, 2:36 PM · VDG, Baloo

Oct 12 2019

bruns committed R293:4f131981493b: Use propertymap to store properties in Baloo::Result (authored by bruns).
Use propertymap to store properties in Baloo::Result
Oct 12 2019, 10:52 PM
bruns closed D19088: Use propertymap to store properties in Baloo::Result.
Oct 12 2019, 10:52 PM · Baloo, Frameworks
bruns committed R293:ecebbf85dc91: Add standalone conversion functions for PropertyMap to Json and vice versa (authored by bruns).
Add standalone conversion functions for PropertyMap to Json and vice versa
Oct 12 2019, 10:43 PM
bruns closed D19087: Add standalone conversion functions for PropertyMap to Json and vice versa.
Oct 12 2019, 10:43 PM · Baloo, Frameworks

Oct 9 2019

bruns committed R293:3319b6656043: Replace recursion in FilteredDirIterator with loop iteration (authored by bruns).
Replace recursion in FilteredDirIterator with loop iteration
Oct 9 2019, 4:49 PM
bruns closed D24502: Replace recursion in FilteredDirIterator with loop iteration.
Oct 9 2019, 4:49 PM · Baloo, Frameworks
bruns added a comment to D24492: [FilteredDirIterator] Reduce stack pressure.

Let me change that into a proper loop.

Oct 9 2019, 12:39 PM · Baloo, Frameworks
bruns added reviewers for D24502: Replace recursion in FilteredDirIterator with loop iteration: ngraham, astippich.
Oct 9 2019, 11:44 AM · Baloo, Frameworks

Oct 8 2019

bruns requested review of D24502: Replace recursion in FilteredDirIterator with loop iteration.
Oct 8 2019, 2:14 PM · Baloo, Frameworks

Oct 6 2019

bruns requested changes to D24422: [dolphin] Improve parsing of Baloo query searchString.

Please do one change at a time.

Oct 6 2019, 6:48 PM · Dolphin
bruns accepted D23411: Fix crash in writer collection and cleanup.
Oct 6 2019, 11:45 AM · Baloo, Frameworks

Sep 26 2019

bruns requested changes to D23787: [baloo_file_extractor] Improve handling of large plain-text files.

Can you please provide an example which:

Sep 26 2019, 12:21 AM · Baloo, Frameworks

Sep 22 2019

bruns added a comment to D21235: Add handling of fuseiso filesystem type.

I have been resurrecting this patch again :) and have run into an issue I need some guidance on. To be able to parse the ~/.mtab.fuseiso file I would like to use the KMountPoint class, but this class currently resides in KIO which Solid doesn't depend on. But, KIO actually depends on Solid so would it be an option to move this class from KIO to Solid?

Sep 22 2019, 1:17 PM · Frameworks

Sep 13 2019

bruns added inline comments to D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart.
Sep 13 2019, 1:51 PM · Frameworks
bruns requested changes to D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart.
Sep 13 2019, 12:40 AM · Frameworks