bruns (Stefan Brüns)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 2 2017, 12:03 PM (171 w, 3 d)
Availability
Available

Recent Activity

Tue, Jun 30

bruns added a comment to D28745: Skip caching thumbnails on encrypted filesystems.

How often do I have to repeat the thumbnailer has to use the canonical path anyway? Please use that.

storageAccessFromPath converts given path into canonical. I figured it should do so anyway, so I'm not doing it again here.

Tue, Jun 30, 1:56 PM · Frameworks, Dolphin

Mon, Jun 29

bruns added inline comments to D17816: Support for xattrs on kio copy/move.
Mon, Jun 29, 8:15 PM · Frameworks
bruns added a comment to D28745: Skip caching thumbnails on encrypted filesystems.
Solid::Device device = Solid::Device::storageAccessFromPath(filePath);
if (device.is<Solid::StorageVolume>()) {
    allowCache = device.as<Solid::StorageVolume>()->usage() != Solid::StorageVolume::UsageType::Encrypted;
}
Mon, Jun 29, 4:17 PM · Frameworks, Dolphin

Wed, Jun 24

bruns added inline comments to D17816: Support for xattrs on kio copy/move.
Wed, Jun 24, 12:29 PM · Frameworks

Mon, Jun 22

bruns added inline comments to D17816: Support for xattrs on kio copy/move.
Mon, Jun 22, 2:51 PM · Frameworks

Jun 10 2020

bruns closed D29207: [Indexers] Ignore name-based mimetype for initial indexing decisions.
Jun 10 2020, 11:16 PM · Baloo, Frameworks
bruns added a comment to D28745: Skip caching thumbnails on encrypted filesystems.

Solid does not provide straight folder => StorageVolume yet, but I think Solid could have such a utility feature added.
Something like Solid::Device::findByPath(), it would need to canonically and recursively resolves the path parent to pay attention to symlinks.
This would also help D26407

No recursion needed, stat provides the device.

Only when the file is not a symlink, if so we need to check the symlink target recursively, that's what I meant.

Jun 10 2020, 10:42 PM · Frameworks, Dolphin
bruns updated the summary of D29207: [Indexers] Ignore name-based mimetype for initial indexing decisions.
Jun 10 2020, 10:15 PM · Baloo, Frameworks

Jun 7 2020

bruns requested changes to D28745: Skip caching thumbnails on encrypted filesystems.
Jun 7 2020, 4:38 PM · Frameworks, Dolphin
bruns added a comment to D28745: Skip caching thumbnails on encrypted filesystems.

And can you please use arc to upload the patch - it is nearly impossible to do a review with the missing context

Jun 7 2020, 4:37 PM · Frameworks, Dolphin
bruns added a comment to D28745: Skip caching thumbnails on encrypted filesystems.
Jun 7 2020, 4:35 PM · Frameworks, Dolphin

Jun 2 2020

bruns added inline comments to D17816: Support for xattrs on kio copy/move.
Jun 2 2020, 11:13 PM · Frameworks

Jun 1 2020

bruns requested changes to D17816: Support for xattrs on kio copy/move.
Jun 1 2020, 6:24 PM · Frameworks

May 27 2020

bruns requested changes to D17816: Support for xattrs on kio copy/move.
May 27 2020, 9:43 PM · Frameworks

May 26 2020

bruns added inline comments to D17816: Support for xattrs on kio copy/move.
May 26 2020, 12:53 AM · Frameworks

May 24 2020

bruns accepted D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts.
May 24 2020, 7:41 PM · Frameworks
bruns added inline comments to D29810: Don't use the setenv function after fork.
May 24 2020, 1:55 AM · Frameworks

May 22 2020

bruns committed R111:3ddbc35189ee: Avoid double free/use-after-free of static unique_ptr<> (authored by bruns).
Avoid double free/use-after-free of static unique_ptr<>
May 22 2020, 12:06 PM

May 21 2020

bruns committed R111:9c17f75ebc43: Force en_US locale for signalplotter formatting checks (authored by bruns).
Force en_US locale for signalplotter formatting checks
May 21 2020, 8:58 PM

May 10 2020

bruns requested changes to D29597: file extractor: fix linking.

Your build system seems to be broken. The "missing" methods are statically linked, see src/file/extractor/CMakeFiles/baloo_file_extractor.dir/baloosettings.cpp.o

May 10 2020, 4:19 PM · Baloo, Frameworks
bruns added a comment to D28745: Skip caching thumbnails on encrypted filesystems.

Use Solid and ask it if the device is on an encrypted device. If Solid does not have such an API, add it.

May 10 2020, 12:02 AM · Frameworks, Dolphin

May 9 2020

bruns added a comment to D28745: Skip caching thumbnails on encrypted filesystems.

I think the patch as is has some structural problems. I think it would be significantly cleaner when:

May 9 2020, 1:42 PM · Frameworks, Dolphin

May 6 2020

bruns committed R286:0975ed45af79: [TaglibExtractor] Add support for Audible "Enhanced Audio" audio books (authored by bruns).
[TaglibExtractor] Add support for Audible "Enhanced Audio" audio books
May 6 2020, 1:22 AM
bruns closed D29454: [TaglibExtractor] Add support for Audible "Enhanced Audio" audio books.
May 6 2020, 1:22 AM · Baloo, Frameworks

May 5 2020

bruns added a comment to D29454: [TaglibExtractor] Add support for Audible "Enhanced Audio" audio books.

Nice!

May 5 2020, 9:26 PM · Baloo, Frameworks
bruns requested review of D29454: [TaglibExtractor] Add support for Audible "Enhanced Audio" audio books.
May 5 2020, 7:14 PM · Baloo, Frameworks

May 4 2020

bruns committed R293:7605f4d7f7c4: Store filename terms just once (authored by bruns).
Store filename terms just once
May 4 2020, 7:48 PM
bruns closed D28932: Store filename terms just once.
May 4 2020, 7:48 PM · Baloo, Frameworks
bruns added a comment to D28932: Store filename terms just once.

This has been pending for more than two weeks now, without any sort of review ...

May 4 2020, 4:28 PM · Baloo, Frameworks

May 2 2020

bruns updated the summary of D28932: Store filename terms just once.
May 2 2020, 12:55 PM · Baloo, Frameworks
bruns added a comment to D28932: Store filename terms just once.

Ping!

May 2 2020, 12:52 PM · Baloo, Frameworks

May 1 2020

bruns requested changes to D29326: Bookmarks Runner: Fix extraction of firefox profile.

The summary needs some text which works without any images

May 1 2020, 7:23 PM · Plasma

Apr 27 2020

bruns committed R293:1793785420b7: [FileWatch] Remove redundant watchIndexedFolders() slot (authored by bruns).
[FileWatch] Remove redundant watchIndexedFolders() slot
Apr 27 2020, 2:55 PM
bruns closed D29188: [FileWatch] Remove redundant watchIndexedFolders() slot.
Apr 27 2020, 2:55 PM · Baloo, Frameworks

Apr 26 2020

bruns accepted D29199: honor the extractMetaData flag.
Apr 26 2020, 5:04 PM · Baloo, Frameworks
bruns requested review of D29207: [Indexers] Ignore name-based mimetype for initial indexing decisions.
Apr 26 2020, 3:08 PM · Baloo, Frameworks
bruns added a dependent revision for D28932: Store filename terms just once: D29207: [Indexers] Ignore name-based mimetype for initial indexing decisions.
Apr 26 2020, 3:08 PM · Baloo, Frameworks
bruns added inline comments to D29199: honor the extractMetaData flag.
Apr 26 2020, 3:00 PM · Baloo, Frameworks
bruns committed R293:b123493d5290: [ModifiedFileIndexer] Clarify a comment (authored by bruns).
[ModifiedFileIndexer] Clarify a comment
Apr 26 2020, 2:32 PM
bruns committed R293:c76397081d1e: [FileWatch] Fix watch updates on config changes (authored by bruns).
[FileWatch] Fix watch updates on config changes
Apr 26 2020, 2:26 PM
bruns closed D29191: [FileWatch] Fix watch updates on config changes.
Apr 26 2020, 2:26 PM · Baloo, Frameworks
bruns committed R293:73183acf00a2: [KInotify] Fix path matching when removing watches (authored by bruns).
[KInotify] Fix path matching when removing watches
Apr 26 2020, 2:25 PM
bruns closed D29189: [KInotify] Fix path matching when removing watches.
Apr 26 2020, 2:25 PM · Baloo, Frameworks
bruns requested changes to D29199: honor the extractMetaData flag.
Apr 26 2020, 1:39 PM · Baloo, Frameworks
bruns added inline comments to D29199: honor the extractMetaData flag.
Apr 26 2020, 1:38 PM · Baloo, Frameworks
bruns updated the summary of D29189: [KInotify] Fix path matching when removing watches.
Apr 26 2020, 12:52 PM · Baloo, Frameworks
bruns added a dependency for D29191: [FileWatch] Fix watch updates on config changes: D29189: [KInotify] Fix path matching when removing watches.
Apr 26 2020, 12:45 PM · Baloo, Frameworks
bruns added a dependent revision for D29189: [KInotify] Fix path matching when removing watches: D29191: [FileWatch] Fix watch updates on config changes.
Apr 26 2020, 12:45 PM · Baloo, Frameworks
bruns committed R293:1a3c23f076d2: [FileWatchTest] Extend coverage to config updates (authored by bruns).
[FileWatchTest] Extend coverage to config updates
Apr 26 2020, 12:35 PM
bruns closed D29190: [FileWatchTest] Extend coverage to config updates.
Apr 26 2020, 12:35 PM · Baloo, Frameworks
bruns added inline comments to D29190: [FileWatchTest] Extend coverage to config updates.
Apr 26 2020, 12:31 PM · Baloo, Frameworks

Apr 25 2020

bruns committed R293:9fff727c6beb: [Extractor] Use categorized logging (authored by bruns).
[Extractor] Use categorized logging
Apr 25 2020, 10:48 PM
bruns updated the diff for D29190: [FileWatchTest] Extend coverage to config updates.

whitespace

Apr 25 2020, 9:16 PM · Baloo, Frameworks
bruns requested review of D29191: [FileWatch] Fix watch updates on config changes.
Apr 25 2020, 9:14 PM · Baloo, Frameworks
bruns added a dependent revision for D29190: [FileWatchTest] Extend coverage to config updates: D29191: [FileWatch] Fix watch updates on config changes.
Apr 25 2020, 9:14 PM · Baloo, Frameworks
bruns added a dependent revision for D29190: [FileWatchTest] Extend coverage to config updates: D29189: [KInotify] Fix path matching when removing watches.
Apr 25 2020, 9:13 PM · Baloo, Frameworks
bruns added a dependency for D29189: [KInotify] Fix path matching when removing watches: D29190: [FileWatchTest] Extend coverage to config updates.
Apr 25 2020, 9:13 PM · Baloo, Frameworks
bruns requested review of D29190: [FileWatchTest] Extend coverage to config updates.
Apr 25 2020, 9:12 PM · Baloo, Frameworks
bruns requested review of D29189: [KInotify] Fix path matching when removing watches.
Apr 25 2020, 9:06 PM · Baloo, Frameworks
bruns requested review of D29188: [FileWatch] Remove redundant watchIndexedFolders() slot.
Apr 25 2020, 8:32 PM · Baloo, Frameworks
bruns accepted D28972: FileMetaDataWidget: Avoid showing fields when they have no value.
Apr 25 2020, 8:11 PM · Baloo
bruns added a comment to D28972: FileMetaDataWidget: Avoid showing fields when they have no value.

Wrap at ~80 characters, please.

Apr 25 2020, 8:11 PM · Baloo
bruns added a comment to D28972: FileMetaDataWidget: Avoid showing fields when they have no value.

@bruns does this sounds good to you ?

Apr 25 2020, 8:04 PM · Baloo
bruns committed R293:774bd228b749: Use KFileMetaData for XAttr support instead of private reimplementation (authored by bruns).
Use KFileMetaData for XAttr support instead of private reimplementation
Apr 25 2020, 7:16 PM
bruns closed D29181: Use KFileMetaData for XAttr support instead of private reimplementation.
Apr 25 2020, 7:16 PM · Baloo, Frameworks
bruns added inline comments to D29138: [Solid] Replace foreach (deprecated) with range/index for.
Apr 25 2020, 5:26 PM · Frameworks
bruns requested review of D29181: Use KFileMetaData for XAttr support instead of private reimplementation.
Apr 25 2020, 5:22 PM · Baloo, Frameworks
bruns committed R293:c4ae6ff523d2: Drop old Xapian DB test case (authored by bruns).
Drop old Xapian DB test case
Apr 25 2020, 5:00 PM
bruns committed R293:c2865b207907: Revert "add Baloo DBus signals for moved or removed files" (authored by bruns).
Revert "add Baloo DBus signals for moved or removed files"
Apr 25 2020, 4:31 PM
bruns closed D28980: Revert "add Baloo DBus signals for moved or removed files".
Apr 25 2020, 4:31 PM · Baloo, Frameworks
bruns added a reverting change for R293:ef0e268c6577: add Baloo DBus signals for moved or removed files: R293:c2865b207907: Revert "add Baloo DBus signals for moved or removed files".
Apr 25 2020, 4:31 PM
bruns added a reverting change for R293:96fb5896c304: add missing license: R293:c2865b207907: Revert "add Baloo DBus signals for moved or removed files".
Apr 25 2020, 4:31 PM
bruns committed R293:60766d57999c: [QML Monitor] Show remaining time as soon as possible (authored by bruns).
[QML Monitor] Show remaining time as soon as possible
Apr 25 2020, 4:03 PM
bruns closed D28956: [QML Monitor] Show remaining time as soon as possible.
Apr 25 2020, 4:03 PM · Baloo, Frameworks
bruns added inline comments to D29138: [Solid] Replace foreach (deprecated) with range/index for.
Apr 25 2020, 3:26 PM · Frameworks
bruns added a comment to D28932: Store filename terms just once.

I'll get around to reviewing this soon. I'm trying to figure out of I think the loss is acceptable.

Apr 25 2020, 3:05 PM · Baloo, Frameworks
bruns added a comment to D28776: FstabDevice: Avoid recurrent construction of emblems QStringList.

Ping!

Apr 25 2020, 1:41 PM · Frameworks
bruns added a comment to D28777: FstabDevice: Reevaluate emblems only when state changes.

Ping!

Apr 25 2020, 1:41 PM · Frameworks
bruns added a comment to D28932: Store filename terms just once.

Ping!

Apr 25 2020, 1:36 PM · Baloo, Frameworks
bruns added a comment to D28956: [QML Monitor] Show remaining time as soon as possible.

Ping!

Apr 25 2020, 1:36 PM · Baloo, Frameworks
bruns added a comment to T8569: Redesign Policy Kit Authorization dialog.
In T8569#227195, @bruns wrote:

I like the inline password, though I have a small concern - grey on white is low contrast, what about persons with bad eyesight?

We should probably fix that in our mockup toolkit. The actual looks of the widgets and icons itself isn't a part of this task and isn't scheduled to change AFAIK.

Apr 25 2020, 1:35 PM · VDG, Plasma

Apr 24 2020

bruns added inline comments to D29138: [Solid] Replace foreach (deprecated) with range/index for.
Apr 24 2020, 7:44 PM · Frameworks
bruns added inline comments to D29138: [Solid] Replace foreach (deprecated) with range/index for.
Apr 24 2020, 6:49 PM · Frameworks
bruns added inline comments to D29138: [Solid] Replace foreach (deprecated) with range/index for.
Apr 24 2020, 4:18 PM · Frameworks
bruns added a comment to D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts.

Do not create m_storageAccess in the constructor

Hmm, you told me the f (m_displayName.isEmpty()) block belongs here, I don't see why instantiating m_storageAccess here is bad but mehh.

Apr 24 2020, 11:01 AM · Frameworks

Apr 23 2020

bruns added inline comments to D29138: [Solid] Replace foreach (deprecated) with range/index for.
Apr 23 2020, 10:53 PM · Frameworks
bruns added inline comments to D29138: [Solid] Replace foreach (deprecated) with range/index for.
Apr 23 2020, 10:51 PM · Frameworks
bruns added a comment to D29095: Change mouse icon to have better dark theme contrast.

Bruns's comment about right-handed mice (gradient) is due to the quite asymmetrical shape many modern mice use for ergonomic reasons (RSI).

Apr 23 2020, 6:32 PM · Frameworks
bruns added a comment to D29095: Change mouse icon to have better dark theme contrast.

Apr 23 2020, 4:26 PM · Frameworks
bruns added a comment to D29095: Change mouse icon to have better dark theme contrast.

The new one looks very oldschool. Some ideas how to improve that:

Apr 23 2020, 3:30 PM · Frameworks
bruns added inline comments to D29034: Add systemd user service file for kded.
Apr 23 2020, 2:38 PM · Frameworks

Apr 22 2020

bruns added inline comments to D27152: Introduce FilesystemEntry class.
Apr 22 2020, 5:50 PM · Frameworks

Apr 21 2020

bruns requested changes to D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts.

Do not create m_storageAccess in the constructor

Apr 21 2020, 10:19 PM · Frameworks
bruns added a comment to D20739: Handle multiple entries in map.

any bug reports for the Windows platform will be rejected immediately then.

Because they aren't already given that baloo only works on Linux and *BSD?

This is the sort of attitude that always makes my eyes roll whenever I see a reference to the idea of support in most KDE software.

Apr 21 2020, 2:30 PM · Baloo
bruns added a comment to D20739: Handle multiple entries in map.
Qt 5.10. is required since KF 5.55: https://kde.org/announcements/kde-frameworks-5.55.0.php.

True, but not relevant here because the issue is not with KF5 APIs but with QMap. The frameworks relevant for baloo all build against Qt 5.9 either without or with minimal patching (which in essence reintroduce removed code).

Apr 21 2020, 12:50 PM · Baloo
bruns added a comment to D20739: Handle multiple entries in map.

Hi,

I'm updating some of my packaging for a set-up that should meet the minimum requirements that were current when this commit was made (Qt 5.9 and KF5 5.60.0; baloo-widgets 19.08.3 requires Qt 5.8 and KF5 5.58.0). Evidently this change wasn't checked against those requirements; the constKeyValue* iterators were introduced in Qt 5.10 (this lack of testing is also apparent in filemetadatadatedisplaytest.cpp:57!)

I've tried to roll a Qt 5.9 implementation of the new algorithm, but apparently failed:

Can I ask some feedback (from @astippich maybe)?

Apr 21 2020, 10:34 AM · Baloo
bruns committed R245:5f97573881fe: [FstabWatcher] Fix loosing of fstab watcher (authored by bruns).
[FstabWatcher] Fix loosing of fstab watcher
Apr 21 2020, 10:18 AM
bruns closed D28780: [FstabWatcher] Fix loosing of fstab watcher.
Apr 21 2020, 10:18 AM · Frameworks

Apr 20 2020

bruns added a comment to D28776: FstabDevice: Avoid recurrent construction of emblems QStringList.

Ping!

Apr 20 2020, 5:20 PM · Frameworks
bruns added a comment to D28780: [FstabWatcher] Fix loosing of fstab watcher.

Ping!

Apr 20 2020, 5:19 PM · Frameworks