kdautovic (Karlo Dautović)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Mar 12 2019, 7:51 PM (31 w, 3 d)
Availability
Available

Recent Activity

May 11 2019

kdautovic added a comment to D19715: Add option to copy screenshot to clipboard in background mode.

I plan on fixing this before the beta release, or at least the full release. Anyone have any ideas what might be causing this?

May 11 2019, 1:39 PM · Spectacle

Apr 3 2019

kdautovic added a comment to D19715: Add option to copy screenshot to clipboard in background mode.

Oooh, yeah that's a bug. I guess we should always add x-kde-force-image-copy to the metadata of a copied screenshot? Wanna do that on the Applications/19.04 branch?

That's where my confusion here and in D20180 is coming from. Isn't it always added unconditionally in  `ExportManager::doCopyToClipboard`? And both the button regardless of quit after copy and spectacle -b -c go through that.  Or am I missing a place where copying is done?
Apr 3 2019, 8:19 PM · Spectacle

Mar 26 2019

kdautovic updated the diff for D19852: Change default Klipper behavior to accept images.

Add m_bIgnoreImage to get the correct behavior

Mar 26 2019, 5:45 PM · Plasma
kdautovic added a comment to D19852: Change default Klipper behavior to accept images.

Any updates? This is buildable and works. Is it acceptable to merge?

Mar 26 2019, 4:49 PM · Plasma

Mar 24 2019

kdautovic updated the diff for D19852: Change default Klipper behavior to accept images.

Use arcanist to get context

Mar 24 2019, 7:23 PM · Plasma
kdautovic updated the diff for D19715: Add option to copy screenshot to clipboard in background mode.

Use arcanist to get context

Mar 24 2019, 7:20 PM · Spectacle
kdautovic added inline comments to D19715: Add option to copy screenshot to clipboard in background mode.
Mar 24 2019, 7:12 PM · Spectacle
kdautovic updated the diff for D19715: Add option to copy screenshot to clipboard in background mode.

Update doCopyToClipboard function with the "x-kde-force-image-copy" mime type hint.

Mar 24 2019, 6:57 PM · Spectacle
kdautovic updated the diff for D19852: Change default Klipper behavior to accept images.

Change QString to QStringLiteral

Mar 24 2019, 6:52 PM · Plasma
kdautovic added inline comments to D19852: Change default Klipper behavior to accept images.
Mar 24 2019, 5:51 PM · Plasma
kdautovic set the repository for D19715: Add option to copy screenshot to clipboard in background mode to R166 Spectacle.
Mar 24 2019, 5:22 PM · Spectacle
kdautovic updated the diff for D19852: Change default Klipper behavior to accept images.

Formatting.

Mar 24 2019, 5:21 PM · Plasma
kdautovic updated the diff for D19852: Change default Klipper behavior to accept images.

Add the "x-kde-force-image-copy" mime type hint.

Mar 24 2019, 5:20 PM · Plasma
kdautovic added a comment to D19852: Change default Klipper behavior to accept images.

Yeah, I'll add the mime hint.

Mar 24 2019, 4:13 PM · Plasma

Mar 21 2019

kdautovic added a comment to D19852: Change default Klipper behavior to accept images.

Is this good enough to merge?

Mar 21 2019, 5:12 PM · Plasma

Mar 18 2019

kdautovic updated the diff for D19852: Change default Klipper behavior to accept images.

Removed the use of goto.

Mar 18 2019, 3:48 PM · Plasma
kdautovic updated the diff for D19852: Change default Klipper behavior to accept images.

Remove the image filter which stopped copying images to clipboard.

Mar 18 2019, 3:44 PM · Plasma
kdautovic added a comment to D19852: Change default Klipper behavior to accept images.
Mar 18 2019, 3:42 PM · Plasma
kdautovic updated the summary of D19852: Change default Klipper behavior to accept images.
Mar 18 2019, 2:31 PM · Plasma
kdautovic updated the diff for D19852: Change default Klipper behavior to accept images.

Added a special case for not saving history when the data is an image and m_bIgnoreImages is set. This allows copying images to clipboard, and keeping the current default behavior of Klipper to not save images in history when m_bIgnoreImages is set.

Mar 18 2019, 2:17 PM · Plasma
kdautovic added a comment to D19852: Change default Klipper behavior to accept images.

The problem I see with that is that memory usage wasn't solved. Regardless of whether we use my approach or your approach, they're going to use the same amount of memory if people copy screenshots to clipboard. Your approach is just going to give the data a different MIME type.

Mar 18 2019, 1:48 PM · Plasma
kdautovic added a comment to D19715: Add option to copy screenshot to clipboard in background mode.

I added a revision for Klipper. https://phabricator.kde.org/D19852

Mar 18 2019, 1:07 PM · Spectacle
kdautovic requested review of D19852: Change default Klipper behavior to accept images.
Mar 18 2019, 1:07 PM · Plasma

Mar 13 2019

kdautovic added a comment to D19715: Add option to copy screenshot to clipboard in background mode.

How much effort would it take to change the default Klipper behavior?

Mar 13 2019, 4:27 PM · Spectacle
kdautovic added a comment to D19715: Add option to copy screenshot to clipboard in background mode.

This worked out of the box for me when I was testing. I didn't change any Klipper settings, unless I am also missing something.

Mar 13 2019, 1:59 PM · Spectacle
kdautovic added a comment to D19715: Add option to copy screenshot to clipboard in background mode.

Sorry, I was using format-patch and thought that updating the diff adds to the last diff instead of uploading a completely new diff. How do you usually update a diff?

Mar 13 2019, 1:29 PM · Spectacle
kdautovic updated the diff for D19715: Add option to copy screenshot to clipboard in background mode.
Mar 13 2019, 1:27 PM · Spectacle
kdautovic updated the diff for D19715: Add option to copy screenshot to clipboard in background mode.
Mar 13 2019, 1:26 PM · Spectacle
kdautovic updated the diff for D19715: Add option to copy screenshot to clipboard in background mode.

Added notifications for copying to clipboard.

Mar 13 2019, 12:21 PM · Spectacle
kdautovic updated the diff for D19715: Add option to copy screenshot to clipboard in background mode.

Renamed the mClipboard variable to copyToClipboard

Mar 13 2019, 11:38 AM · Spectacle

Mar 12 2019

kdautovic added a comment to D19715: Add option to copy screenshot to clipboard in background mode.

Speaking of notifications. If the default behavior is to emit a notification maybe we should notify here, too. What do you think?

Mar 12 2019, 11:20 PM · Spectacle
kdautovic added a comment to D19715: Add option to copy screenshot to clipboard in background mode.

I understand what you're saying, but in the code I added there's nothing stopping the

if (!mNotify) {
    emit allDone();
}
Mar 12 2019, 10:48 PM · Spectacle
kdautovic requested review of D19715: Add option to copy screenshot to clipboard in background mode.
Mar 12 2019, 7:54 PM · Spectacle