I plan on fixing this before the beta release, or at least the full release. Anyone have any ideas what might be causing this?

In D19715#442414, @davidre wrote:

In D19715#442363, @ngraham wrote:

Oooh, yeah that's a bug. I guess we should always add x-kde-force-image-copy to the metadata of a copied screenshot? Wanna do that on the Applications/19.04 branch?

That's where my confusion here and in D20180 is coming from. Isn't it always added unconditionally in  `ExportManager::doCopyToClipboard`? And both the button regardless of quit after copy and spectacle -b -c go through that.  Or am I missing a place where copying is done?

Add m_bIgnoreImage to get the correct behavior

Any updates? This is buildable and works. Is it acceptable to merge?

Use arcanist to get context

Use arcanist to get context

Update doCopyToClipboard function with the "x-kde-force-image-copy" mime type hint.

Change QString to QStringLiteral

Formatting.

Add the "x-kde-force-image-copy" mime type hint.

Yeah, I'll add the mime hint.

Is this good enough to merge?

Removed the use of goto.

Remove the image filter which stopped copying images to clipboard.

Added a special case for not saving history when the data is an image and m_bIgnoreImages is set. This allows copying images to clipboard, and keeping the current default behavior of Klipper to not save images in history when m_bIgnoreImages is set.

The problem I see with that is that memory usage wasn't solved. Regardless of whether we use my approach or your approach, they're going to use the same amount of memory if people copy screenshots to clipboard. Your approach is just going to give the data a different MIME type.

I added a revision for Klipper. https://phabricator.kde.org/D19852

How much effort would it take to change the default Klipper behavior?

This worked out of the box for me when I was testing. I didn't change any Klipper settings, unless I am also missing something.

Sorry, I was using format-patch and thought that updating the diff adds to the last diff instead of uploading a completely new diff. How do you usually update a diff?

Added notifications for copying to clipboard.

Renamed the mClipboard variable to copyToClipboard

In D19715#429973, @davidre wrote:

Speaking of notifications. If the default behavior is to emit a notification maybe we should notify here, too. What do you think?

I understand what you're saying, but in the code I added there's nothing stopping the

if (!mNotify) {
    emit allDone();
}