mglb (Mariusz Glebocki)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Feb 28 2018, 11:25 PM (85 w, 2 d)
Availability
Available

Recent Activity

Wed, Oct 16

mglb added a comment to T11817: Make keyword parsing hook script intelligent enough to parse multiple keywords on one line.

There is no merge commit when it is not necessary, and commits are not usually squashed (at least in Konsole, quick look at Okular says the same), so a MR author should put the keywords in one of the commits. You can check commits on a branch (or in commits tab in merge request) and ask commiter to fix commit descriptions. However, force-push is not allowed in some cases, so that might be impossible (IIRC).

Wed, Oct 16, 7:56 PM
mglb committed R319:ef13a09e0178: Fix scrollbar position (authored by mglb).
Fix scrollbar position
Wed, Oct 16, 1:37 AM

Tue, Oct 15

mglb added a comment to T11817: Make keyword parsing hook script intelligent enough to parse multiple keywords on one line.

Gitlab's Merge Request description is not placed in a commit (at least when there is no merge commit, which is default). Each commit in merge request has its own independent description.
Please see "02 Oct, 2019 (5 commits)" in https://invent.kde.org/kde/okular/commits/master - this is the result of mentioned merge. Hooks didn't catch bug entries because they are not in commits.

Tue, Oct 15, 10:42 PM

Mon, Oct 14

mglb updated the summary of D24621: [RFC] New Konsole and Yakuake icons.
Mon, Oct 14, 9:46 PM · Frameworks
mglb added a comment to D24621: [RFC] New Konsole and Yakuake icons.

Please note that Konsole icon is intended to be personalized icon/"logo" (see T10243).
The prompt symbol is thick as it is main symbol (like symbols in e.g Plasma, Akregator, Kile, "K" icons/logos) - the window-like background (or just square in var C) is just secondary addition.

Mon, Oct 14, 9:44 PM · Frameworks
mglb updated the diff for D24621: [RFC] New Konsole and Yakuake icons.

Brighten background

Mon, Oct 14, 8:38 PM · Frameworks

Sun, Oct 13

mglb requested review of D24621: [RFC] New Konsole and Yakuake icons.
Sun, Oct 13, 10:10 PM · Frameworks
mglb committed R266:898410aa5515: Update Yakuake icon (48px only) (authored by mglb).
Update Yakuake icon (48px only)
Sun, Oct 13, 9:38 PM
mglb committed R266:7ad084bd276b: Add Konsole icon (48px) (authored by mglb).
Add Konsole icon (48px)
Sun, Oct 13, 9:38 PM

Sat, Oct 12

mglb added a comment to T10891: Breeze theme evolution.

Right one (larger shadow size). Plasma popups open above windows, yet they cast a lot smaller shadow than window shadow right now.

Sat, Oct 12, 5:07 PM · VDG, Breeze

Fri, Oct 11

mglb added a comment to T10243: Some KDE applications could use better icons.

Yes, I'll create review soon

Fri, Oct 11, 7:28 PM · KDE Applications, VDG

Sat, Oct 5

mglb added a comment to T10243: Some KDE applications could use better icons.

As I said in another comment an example of problem in Inkscape is ">" symbol in Konsole 48x48px icon.

Sat, Oct 5, 10:47 PM · KDE Applications, VDG
mglb committed R319:b35811084267: Add missing checkbox label on Edit Profile → Appearance page (authored by mglb).
Add missing checkbox label on Edit Profile → Appearance page
Sat, Oct 5, 9:16 PM
mglb committed R319:ce2029ed75b6: Keep empty lines when "trim leading spaces" is enabled (authored by mglb).
Keep empty lines when "trim leading spaces" is enabled
Sat, Oct 5, 8:15 PM

Fri, Oct 4

mglb committed R319:6c2a2c0184a4: Bump sessionui.rc version (authored by mglb).
Bump sessionui.rc version
Fri, Oct 4, 10:37 PM
mglb committed R319:8c6aaad3f77f: Remove "Close session" from context menu (authored by mglb).
Remove "Close session" from context menu
Fri, Oct 4, 6:37 PM

Wed, Oct 2

mglb committed R319:5e91383e3fc9: Make sure font weight value is within allowed range (authored by mglb).
Make sure font weight value is within allowed range
Wed, Oct 2, 3:08 PM
mglb added a comment to T10997: Improve check box design.
In T10997#203309, @mglb wrote:

they have a visible area of 20px vs 16px for the older version.

Yes. Labels have similar height (with default font size), so UIs won't grow much (if at all) and distances between checkboxes/radios are now similar to distances between other controls.

They do? Is this including the margins?

Wed, Oct 2, 6:17 AM · VDG, Breeze

Tue, Oct 1

mglb added a comment to T10997: Improve check box design.

I noticed that the new checkboxes/radio buttons don't apply to menus

Tue, Oct 1, 3:22 PM · VDG, Breeze

Mon, Sep 30

mglb added a comment to T11714: Redesign kde.org homepage.

@mglb You didn't read my previous reply. As I said this is not the final version, the text is a placeholder, don't you all see lorem ipsum???

Mon, Sep 30, 8:47 PM · VDG, KDE Promo, Websites
mglb added a comment to T11714: Redesign kde.org homepage.

It's beautiful, but not perfect.
As a guest, i see "Read more" buttons near different products, but i'm not interested to read it because it's hard to understand what it is.
Also i think it's kool to giving a different backgrounds to each selections, as @mglb said.

I think it makes only sense to have different backgrounds color, if there is a meaning behind it. For plasma desktop they were some distinct section with each a different wallpaper. In this case, I see less a need for it.

Mon, Sep 30, 8:29 PM · VDG, KDE Promo, Websites

Sun, Sep 29

mglb added a comment to T10997: Improve check box design.

I need some more time (~week) for fixes and cleanup.

Sun, Sep 29, 10:08 PM · VDG, Breeze
mglb committed R31:cfabc1dbc31b: WIP: Rewrite Timeline stuff (authored by mglb).
WIP: Rewrite Timeline stuff
Sun, Sep 29, 10:02 PM
mglb committed R31:8402449b66e9: Do not stop subanimations (authored by mglb).
Do not stop subanimations
Sun, Sep 29, 10:02 PM
mglb committed R31:dc35222fa975: Handle subanimations synchronously in AnimationTimeline (authored by mglb).
Handle subanimations synchronously in AnimationTimeline
Sun, Sep 29, 10:02 PM
mglb committed R31:b4ad6c0d1198: Animations fixes (authored by mglb).
Animations fixes
Sun, Sep 29, 10:02 PM
mglb committed R31:d539ee93726b: Improve AnimationTimeline (authored by mglb).
Improve AnimationTimeline
Sun, Sep 29, 10:02 PM
mglb committed R31:7ad2ed42f462: Convert all animations to animationtimeline (authored by mglb).
Convert all animations to animationtimeline
Sun, Sep 29, 10:02 PM
mglb committed R31:1c46f1ba870c: Use AnimationTimeline for OffToOn (authored by mglb).
Use AnimationTimeline for OffToOn
Sun, Sep 29, 10:02 PM
mglb committed R31:6d8ecd0eb353: Fix propertywrapper* (authored by mglb).
Fix propertywrapper*
Sun, Sep 29, 10:02 PM
mglb committed R31:dbf6a03c1645: Move animation helpers to header file (authored by mglb).
Move animation helpers to header file
Sun, Sep 29, 10:02 PM
mglb committed R31:e9d5a73cafca: Initial AnimationTimeline version (authored by mglb).
Initial AnimationTimeline version
Sun, Sep 29, 10:02 PM
mglb committed R31:f15a8486421a: More readable/compact animation code (authored by mglb).
More readable/compact animation code
Sun, Sep 29, 10:02 PM
mglb committed R31:48648a75e9af: Move WIP code to separate file for faster recompilations (authored by mglb).
Move WIP code to separate file for faster recompilations
Sun, Sep 29, 10:02 PM
mglb committed R31:88184bb73a8d: Animated check box and radio button (authored by mglb).
Animated check box and radio button
Sun, Sep 29, 10:02 PM

Fri, Sep 27

mglb added a comment to T11714: Redesign kde.org homepage.

Thank you. Looks good!

Fri, Sep 27, 3:20 PM · VDG, KDE Promo, Websites
mglb added a comment to T11714: Redesign kde.org homepage.

@vladimirmikulic can you put screenshot here?

Fri, Sep 27, 2:24 PM · VDG, KDE Promo, Websites

Wed, Sep 25

mglb added a comment to T10997: Improve check box design.
In T10997#201777, @GB_2 wrote:

I think we should start implementing this design now :-)

Wed, Sep 25, 3:26 PM · VDG, Breeze

Sun, Sep 22

mglb added a comment to T10243: Some KDE applications could use better icons.

EDIT: I have already said this here and there but please don't run any automated script to SVG icons, because when opening them back in Inkscape they are corrupted and everytime I edit a Breeze icon I have to do additional work to fix shapes and gradients corrupted by the scripts.

Sun, Sep 22, 7:22 PM · KDE Applications, VDG

Sep 18 2019

mglb added a comment to T11665: Make adjacent mutually exclusive ToolButtons look like segmented controls.

Adding border to all toolbar buttons will be super heavy in cases where there is more than a few buttons.
To do changes like this I think we should separate concept of classic toolbars (few toolbars, each with many buttons/controls) and modern "widgets row" (few controls visually aligned with window/content). Or just use QToolButtons with disabled autoRaise to get the border on them.

Sep 18 2019, 9:44 PM · Breeze, VDG

Sep 15 2019

mglb added a comment to T11665: Make adjacent mutually exclusive ToolButtons look like segmented controls.

Maybe different background instead of frame? Frame stands out too much, a bit like focus/hover.

Sep 15 2019, 6:56 PM · Breeze, VDG
mglb added a comment to T11662: Improve visual appeal for KUrlNavigator when in Breadcrumbs mode.

It's hard to tell that it's actually a clickable part of the UI. When you hover over elements of it, the hover effects look so slight, that again, it's hard to tell what it's interactive.

Sep 15 2019, 6:25 PM · Breeze, VDG

Aug 25 2019

mglb committed R319:7e701cf4b289: Reactivate previously active window after flags change (authored by mglb).
Reactivate previously active window after flags change
Aug 25 2019, 1:51 PM
mglb committed R319:b88e677bfba2: Apply new window flags only when necessary (authored by mglb).
Apply new window flags only when necessary
Aug 25 2019, 1:51 PM

Aug 17 2019

mglb updated the diff for D20263: Keep perceived contrast in random background color.

Remove static in anonymous namespace

Aug 17 2019, 7:17 PM · VDG, Konsole
mglb added a comment to T11124: Unify highlight effect style.
In T11124#195358, @mglb wrote:

List view/sidebar highlight: why the vertical bright line is on right (internal) side? Wouldn't it look better on left (outside)?

I initially used the inside because I didn't want the plasma panel shadow to make it hard to see with vertical left side panels.

Aug 17 2019, 4:26 PM · Plasma, Breeze, Goal: Consistency, VDG
mglb updated the diff for D20263: Keep perceived contrast in random background color.

s/obselote/obsolete/

Aug 17 2019, 4:02 PM · VDG, Konsole
mglb updated the diff for D20263: Keep perceived contrast in random background color.

Spaces, rebase

Aug 17 2019, 3:21 PM · VDG, Konsole
mglb abandoned D23222: Fix OSC sequence parsing.

Mistake, sorry.

Aug 17 2019, 3:18 PM · Konsole
mglb requested review of D23222: Fix OSC sequence parsing.
Aug 17 2019, 3:16 PM · Konsole
mglb updated the diff for D20263: Keep perceived contrast in random background color.
  • Randomization on/off works as intended
  • Minor fixes
Aug 17 2019, 2:56 PM · VDG, Konsole

Aug 15 2019

mglb added a comment to D23170: Fix colors from KStatefulBrushes not using application colorschemes.

Please add the workaround for a bug fixed in qt 5.13 (eventfilter and stuff). Some people would like to compile it on current systems. In such case non-system Qt is not an option, as the style plugin won't load in older Qt. Also, the code is already written with nice ifdefs and works, so why not.

Aug 15 2019, 7:19 PM · Plasma

Aug 13 2019

mglb added a comment to T11124: Unify highlight effect style.

List view/sidebar highlight: why the vertical bright line is on right (internal) side? Wouldn't it look better on left (outside)?

  • How does current version look with a scrollbar ("normal" and overlay like in system settings)?
  • Highlights on plasma panel [1] have the line on the panel edge, so having it also on window's edge could make it consistent.
  • With the line "outside" it could be possible to use this design with tabs
  • I see only one drawback - with panel placed on the left, the lines from panel and window could be mistaken for each other.
Aug 13 2019, 8:07 PM · Plasma, Breeze, Goal: Consistency, VDG

Aug 11 2019

mglb added a comment to T10997: Improve check box design.

The code (super dirty): https://cgit.kde.org/breeze.git/log/?h=mglb/checkbox-redesign
I managed to make good looking dot-line check mark for half-checked state.

Aug 11 2019, 6:47 PM · VDG, Breeze
mglb committed R31:65d3305abbad: Checkbox redesign WIP (authored by mglb).
Checkbox redesign WIP
Aug 11 2019, 5:02 PM

Aug 6 2019

mglb committed R319:c5ed6009abe2: Mark intended integer division in double context (authored by mglb).
Mark intended integer division in double context
Aug 6 2019, 2:19 AM
mglb committed R319:4793cafab6ea: Split tab bar configuration into two pages (authored by mglb).
Split tab bar configuration into two pages
Aug 6 2019, 2:07 AM
mglb committed R319:81636246ba00: Search for managed QButtonGroups recursively (authored by mglb).
Search for managed QButtonGroups recursively
Aug 6 2019, 2:07 AM

Aug 2 2019

mglb added a comment to T11052: Accent Colors, Color Ramps and other improvements to theming..

@mglb maybe the konsole code could be adapted to kcm-colorful? It has a lot of the features we want

Aug 2 2019, 2:32 PM · Plasma, VDG

Jul 27 2019

mglb added a comment to D22756: Save Image of the Current Tab.

I don't think that duplicating functions already provided by external tools on all supported platforms is good. Each feature means more code and more possible things to break.

Jul 27 2019, 10:48 PM · Konsole
mglb added a comment to T11124: Unify highlight effect style.
In T11124#193109, @mglb wrote:

The signal can be removed, as it is probably never used.

Turns out this is fixed in Qt 5.13: https://bugreports.qt.io/browse/QTBUG-71186.
Still, I think eventFilter should be used to support Qt < 5.13, at least for some time. The signal connection can be left here with ifdef for Qt 5.13 (and #else for eventFilter code to avoid double call) and mandatory comment.

Like this?
...

Jul 27 2019, 8:07 PM · Plasma, Breeze, Goal: Consistency, VDG
mglb added a comment to T11124: Unify highlight effect style.
In T11124#193005, @mglb wrote:

Mmm. Rather than installing event filter, which in some cases will be duplicated to the signal/slot handling, shouldn't we not fix the problem upstream, either in QApplication::setPalette, or in KColorShemeManager (which we own), to make sure that the paletteChanged signal is called ?
This way there would be only one code path in breeze, as well as in other styles (e.g. oxygen)

Jul 27 2019, 2:54 AM · Plasma, Breeze, Goal: Consistency, VDG

Jul 26 2019

mglb added a comment to T11124: Unify highlight effect style.

Your code is right. I just checked and turns out this is not the only problem. In void Helper::loadConfig() You have to remove last argument (_config) from KStatefulBrush:

_viewFocusBrush = KStatefulBrush( KColorScheme::View, KColorScheme::FocusColor);
_viewHoverBrush = KStatefulBrush( KColorScheme::View, KColorScheme::HoverColor);
_viewNegativeTextBrush = KStatefulBrush( KColorScheme::View, KColorScheme::NegativeText);

This way KStatefulBrush uses a config loaded from a file path stored in application's property "KDE_COLOR_SCHEME_PATH" (or user default, if missing). The property is set by KColorSchemeManager.

Jul 26 2019, 7:50 PM · Plasma, Breeze, Goal: Consistency, VDG
mglb added a comment to D20263: Keep perceived contrast in random background color.

I kind of forgot about this. Time to bump it on todo list.

Jul 26 2019, 5:18 PM · VDG, Konsole
mglb added a comment to T11124: Unify highlight effect style.

qApp will work too (qGuiApp is qApp casted to its base class).

Jul 26 2019, 4:53 PM · Plasma, Breeze, Goal: Consistency, VDG

Jul 25 2019

mglb added a comment to T11124: Unify highlight effect style.

@ndavis Install event filter on qGuiApp, handle QEvent::ApplicationPaletteChange and call configurationChanged. Should work.

Jul 25 2019, 6:35 PM · Plasma, Breeze, Goal: Consistency, VDG

Jul 24 2019

mglb added a comment to D20816: Configure Konsole dialog GUI redesign.

I planned to split this page after https://invent.kde.org/kde/konsole/merge_requests/10, but doing it now and including in 19.08 is not bad idea. I'll look at it.

Jul 24 2019, 6:29 AM · VDG, Konsole

Jul 20 2019

mglb committed R319:efb621d091c0: Fix initial terminal size (authored by mglb).
Fix initial terminal size
Jul 20 2019, 4:25 PM

Jul 13 2019

mglb added a comment to T10997: Improve check box design.

Will animations be OK?

Jul 13 2019, 8:23 PM · VDG, Breeze
mglb abandoned D20744: [WIP] Apply new window flags only when necessary.

Moved to invent: https://invent.kde.org/kde/konsole/merge_requests/16

Jul 13 2019, 5:17 PM · Konsole

Jul 8 2019

mglb requested changes to D21123: Compile without Q_FOREACH.

You can't turn QT_NO_FOREACH on without bumping KF5 version - some headers (e.g. kconfiggroup.h in KF5 Config 5.47) use Q_FOREACH.

Jul 8 2019, 8:12 PM · Konsole

Jul 7 2019

mglb committed R319:a9b1e0ae25c9: Change expanded mode button tooltip (authored by mglb).
Change expanded mode button tooltip
Jul 7 2019, 4:09 PM
mglb committed R319:576eb9c98242: Fix typo in tooltip context (authored by mglb).
Fix typo in tooltip context
Jul 7 2019, 4:09 PM
mglb committed R319:b93b0e0992c1: Use default system font for terminal header titles (authored by mglb).
Use default system font for terminal header titles
Jul 7 2019, 4:09 PM
mglb committed R319:897e581bf789: Change expanded mode button tooltip (authored by mglb).
Change expanded mode button tooltip
Jul 7 2019, 4:05 PM
mglb committed R319:eb38a31db6e5: Fix typo in tooltip context (authored by mglb).
Fix typo in tooltip context
Jul 7 2019, 4:05 PM
mglb committed R319:e4d53e57bd9d: Use default system font for terminal header titles (authored by mglb).
Use default system font for terminal header titles
Jul 7 2019, 4:05 PM
mglb committed R319:c223a1d38a8c: Splits: Fix repaint after unmaximizing (authored by mglb).
Splits: Fix repaint after unmaximizing
Jul 7 2019, 3:43 PM

Jul 6 2019

mglb accepted D22291: Fix display sometimes randomly scrolling down.

Bug confirmed with Qt 5.13.
The patch fixes it.

Jul 6 2019, 3:31 PM · Konsole

Jul 2 2019

mglb added a comment to D17374: Profile shortcuts switch profile instead of opening new tab.

Since actions: new tab with profile and switch to profile are already in menus, they could be added to Configure Shortcuts window (both actions for each profile). In such case shortcut editor in profile manager should be removed.

Jul 2 2019, 1:08 PM · Konsole

Jul 1 2019

mglb added a comment to D22102: Implement apply-on-double-click for all grid view KCM delegates.

use its hidden Alt accelerator.

Jul 1 2019, 4:16 AM · Frameworks

Jun 28 2019

mglb added a comment to T9126: Breeze scrollbar look-and-feel unification.

Why not both? Every desktop goes forward with UI design and provides limited UI versions for legacy code. By default overlay scrollbars can't be used, as Qt apps assume that nothing blocks visible content in scroll areas. Regular scrollbars have to be supported also for standalone scrollbar widgets. But when app is made to work well with overlay scrollbars and it is not disabled in breeze settings, why not turn them on on app request?

Jun 28 2019, 11:36 PM · Goal: Consistency, VDG

Jun 27 2019

mglb added a comment to D22106: [Separator] Match Breeze borders' color.

Widgets style: https://cgit.kde.org/breeze.git/tree/kstyle/breezehelper.cpp#n76

Jun 27 2019, 1:38 PM · Kirigami

Jun 26 2019

mglb added a comment to D22102: Implement apply-on-double-click for all grid view KCM delegates.

Look-and-feel

User accidentally doubleclicks item and all their look-related settings are gone. Has to configure everything again.

Jun 26 2019, 12:47 PM · Frameworks

Jun 23 2019

mglb added a comment to T10243: Some KDE applications could use better icons.

For the Konsole icon, that about putting the current breeze icon into the video-display icon.

Something like this:

Jun 23 2019, 12:00 AM · KDE Applications, VDG

Jun 22 2019

mglb added a comment to T11124: Unify highlight effect style.

Here's an example of what the full-width variant might look like:


Jun 22 2019, 10:23 PM · Plasma, Breeze, Goal: Consistency, VDG

Jun 16 2019

mglb added a comment to T10046: Improve the colors, color consistency and colorscheme compatibility of Breeze.
In T10046#188966, @mglb wrote:
  • darker highlight color in Breeze Dark means we needed changed icons -> new folder icons would be a must, but other icons using Plasma Blue should be changed as well

Why?

IMO the folders are noticeably brighter than the new highlight color. I like what Deepin does with its deepin-dark icon theme, it mutes icons as well:

They are, but I think breeze icons (especially directories) are not too bright and don't hurt eyes at night, like bright Deepin ones. If the purpose is to have everything darker, it could be better to just lower monitor brightness.
Or... did I misunderstand and you would like to just make backlight and directory icon color the same?

Jun 16 2019, 5:45 PM · KDE Human Interface Guidelines, VDG, Plasma, Breeze
mglb added inline comments to D20816: Configure Konsole dialog GUI redesign.
Jun 16 2019, 4:49 PM · VDG, Konsole
mglb requested review of D21840: Restore compatibility with Qt < 5.11.
Jun 16 2019, 9:18 AM · Konsole

Jun 15 2019

mglb added a comment to D20816: Configure Konsole dialog GUI redesign.

qt5 SUSEQt5.10/src/settings/ProfileSettings.cpp:512:26: error: ���class QFontMetrics��� has no member named ���horizontalAdvance���

Jun 15 2019, 5:28 PM · VDG, Konsole
mglb added a comment to T10046: Improve the colors, color consistency and colorscheme compatibility of Breeze.
  • darker highlight color in Breeze Dark means we needed changed icons -> new folder icons would be a must, but other icons using Plasma Blue should be changed as well
Jun 15 2019, 12:34 PM · KDE Human Interface Guidelines, VDG, Plasma, Breeze
mglb added a comment to T10201: Window titlebars.

What would this look like in a language that isn't LTR? Would it be better to maybe have it on the right side in that case?

Jun 15 2019, 11:49 AM · KDE Applications, VDG
mglb added a comment to D21282: CSI 2J: Do not append current screen to history.

Note that ncurses devs recently decided to fix clear (https://bugzilla.gnome.org/show_bug.cgi?id=506438#c19), so on newer systems it will work even with current CSI2J behavior.
This lowers reasons behind this path to compatibility with clear in older systems and compatibility with xterm. If these goals are not important, the patch can be abandoned.

Jun 15 2019, 11:31 AM · Konsole
mglb added a comment to T10870: Consider using colorful rather than monochrome icons for small places, devices, and mimetype icons.

Anyway consider that any change to mimetype icons imply a lot of work.

Scripting! <3 At least with some designs, like yours or mine

Jun 15 2019, 11:00 AM · VDG
mglb updated the diff for D20816: Configure Konsole dialog GUI redesign.
  • Fix radio button name
  • Add short info about profile shortcuts and visibility
  • Add kuit tags
  • Use modified QKeySequenceEdit for shortcut editing.
  • Use disabled text color for non visible profile's shortcut text
Jun 15 2019, 10:41 AM · VDG, Konsole

Jun 12 2019

mglb added a comment to T10201: Window titlebars.

Edit: here there is a mockup, the title bar height is the same, the icons are smaller and the clickable area is bigger and change background color when hovering. It feels better to me:

Jun 12 2019, 2:47 PM · KDE Applications, VDG

Jun 11 2019

mglb added a comment to T10201: Window titlebars.

I would like my desktop to simply tolerate applications with different interfaces.pHow about a simple approach to preserve such interfaces: Count the number of toolbar rows, and only darken the toolbars if they are not more than 2 or 3 rows. Otherwise, only darken the menubar.

Jun 11 2019, 3:20 PM · KDE Applications, VDG

Jun 10 2019

mglb added a comment to T11052: Accent Colors, Color Ramps and other improvements to theming..

Yes yes yes!

Jun 10 2019, 10:54 PM · Plasma, VDG
mglb added a comment to T10891: Breeze theme evolution.

Here's another idea I've heard bandied about: create new "whitespace" and "expanding whitespace" items that can be added to toolbars so it's possible to have layouts of toolbar buttons that are centered or justified rather than left-aligned, and that use whitespace to separate logical groups rather than vertical separators. macOS has had this for ages and it results in some very aesthetically pleasing toolbars IMO:

Jun 10 2019, 10:32 PM · VDG, Breeze
mglb added a comment to T10997: Improve check box design.

+1 for using a checkmark instead of a sqare. (Although I like the animation of folding and unfolding the sqare.)

Jun 10 2019, 5:50 PM · VDG, Breeze