- User Since
- Feb 28 2018, 11:25 PM (77 w, 16 h)
Sat, Aug 17
Remove static in anonymous namespace
- Randomization on/off works as intended
- Minor fixes
Thu, Aug 15
Please add the workaround for a bug fixed in qt 5.13 (eventfilter and stuff). Some people would like to compile it on current systems. In such case non-system Qt is not an option, as the style plugin won't load in older Qt. Also, the code is already written with nice ifdefs and works, so why not.
Tue, Aug 13
List view/sidebar highlight: why the vertical bright line is on right (internal) side? Wouldn't it look better on left (outside)?
- How does current version look with a scrollbar ("normal" and overlay like in system settings)?
- Highlights on plasma panel  have the line on the panel edge, so having it also on window's edge could make it consistent.
- With the line "outside" it could be possible to use this design with tabs
- I see only one drawback - with panel placed on the left, the lines from panel and window could be mistaken for each other.
Sun, Aug 11
The code (super dirty): https://cgit.kde.org/breeze.git/log/?h=mglb/checkbox-redesign
I managed to make good looking dot-line check mark for half-checked state.
Tue, Aug 6
Fri, Aug 2
Sat, Jul 27
I don't think that duplicating functions already provided by external tools on all supported platforms is good. Each feature means more code and more possible things to break.
Fri, Jul 26
Your code is right. I just checked and turns out this is not the only problem. In void Helper::loadConfig() You have to remove last argument (_config) from KStatefulBrush:
_viewFocusBrush = KStatefulBrush( KColorScheme::View, KColorScheme::FocusColor); _viewHoverBrush = KStatefulBrush( KColorScheme::View, KColorScheme::HoverColor); _viewNegativeTextBrush = KStatefulBrush( KColorScheme::View, KColorScheme::NegativeText);
This way KStatefulBrush uses a config loaded from a file path stored in application's property "KDE_COLOR_SCHEME_PATH" (or user default, if missing). The property is set by KColorSchemeManager.
I kind of forgot about this. Time to bump it on todo list.
qApp will work too (qGuiApp is qApp casted to its base class).
Thu, Jul 25
@ndavis Install event filter on qGuiApp, handle QEvent::ApplicationPaletteChange and call configurationChanged. Should work.
Wed, Jul 24
I planned to split this page after https://invent.kde.org/kde/konsole/merge_requests/10, but doing it now and including in 19.08 is not bad idea. I'll look at it.
Jul 20 2019
Jul 13 2019
Will animations be OK?
Moved to invent: https://invent.kde.org/kde/konsole/merge_requests/16
Jul 8 2019
You can't turn QT_NO_FOREACH on without bumping KF5 version - some headers (e.g. kconfiggroup.h in KF5 Config 5.47) use Q_FOREACH.
Jul 7 2019
Jul 6 2019
Bug confirmed with Qt 5.13.
The patch fixes it.
Jul 2 2019
Since actions: new tab with profile and switch to profile are already in menus, they could be added to Configure Shortcuts window (both actions for each profile). In such case shortcut editor in profile manager should be removed.
Jul 1 2019
Jun 28 2019
Why not both? Every desktop goes forward with UI design and provides limited UI versions for legacy code. By default overlay scrollbars can't be used, as Qt apps assume that nothing blocks visible content in scroll areas. Regular scrollbars have to be supported also for standalone scrollbar widgets. But when app is made to work well with overlay scrollbars and it is not disabled in breeze settings, why not turn them on on app request?
Jun 27 2019
Jun 26 2019
User accidentally doubleclicks item and all their look-related settings are gone. Has to configure everything again.
Jun 23 2019
Jun 22 2019
Jun 16 2019
They are, but I think breeze icons (especially directories) are not too bright and don't hurt eyes at night, like bright Deepin ones. If the purpose is to have everything darker, it could be better to just lower monitor brightness.
Or... did I misunderstand and you would like to just make backlight and directory icon color the same?
Jun 15 2019
qt5 SUSEQt5.10/src/settings/ProfileSettings.cpp:512:26: error: ���class QFontMetrics��� has no member named ���horizontalAdvance���
Note that ncurses devs recently decided to fix clear (https://bugzilla.gnome.org/show_bug.cgi?id=506438#c19), so on newer systems it will work even with current CSI2J behavior.
This lowers reasons behind this path to compatibility with clear in older systems and compatibility with xterm. If these goals are not important, the patch can be abandoned.
Scripting! <3 At least with some designs, like yours or mine
- Fix radio button name
- Add short info about profile shortcuts and visibility
- Add kuit tags
- Use modified QKeySequenceEdit for shortcut editing.
- Use disabled text color for non visible profile's shortcut text
Jun 12 2019
Jun 11 2019
Jun 10 2019
Yes yes yes!
May 31 2019
- Fix changing favorite status in profile list
- Move profile's pointer to separate hidden column
- Remove nonexisting friend class
- Minor changes in UI strings
- Improve columns width in profiles list
May 29 2019
Hmm... right. I was doing some improvements in the code, but they can go into another review.
I'll update this tomorrow.
May 27 2019
May 26 2019
May 25 2019
May 21 2019
May 20 2019
Checkboxes look nice, but they don't match other elements - everything else uses basic shapes, and the check mark on OK button is quite different.
May 19 2019
May 16 2019
Maybe like this?
Fading out solves additional use cases:
- something sometimes outputs always the same line (debug message) to a terminal. Does it spams the line in a loop right now, or I'm looking at previous lines? (for this the feature would need to work for new lines too)
- Repeated scrolling is distinguishable
May 4 2019
Fix issues from Nate's comments
May 3 2019
Is it possible (without hacks or per-application changes) to make icons colorful in a view and monochrome in a panel?
Apr 25 2019
Apr 23 2019
Sure, when missing parts will be implemented or when we decide to not implement them.
Apr 22 2019
Maybe just implement it using another letter? I guess both implementations have its fans
Apr 19 2019
Apr 18 2019
width type can be changed to int in order to fix this without reordering members.
The file is generated, so this should be changed also in the template.
Apr 12 2019
And maybe rename labels in this style (someone with better english skills than I should verify this):
- Fixed size → In memory, size:
- Unlimited → On filesystem: (or "Unlimited, on filesystem:"?) + remove "history file location" label
- Custom → Other
After thinking about scrollback a bit more I think history file path AND scrollback size should go to global settings. Does anyone use different profiles with different history sizes, or change size just for current session?
Apr 11 2019
If they doesn't care, why give them ability to change the location?
User might not know exactly what "system" and "user" location is (/tmp might be obvious, ~/.cache/konsole not so much), and on which partition it will eventually end (in case of weird partitioning).
What do you think about changing the task to be about all touch actions (and what actions we want to have)? Asking too precise questions will lead to "ok lets use A for X" and later, in another task "no, we can't use A for this, X uses it".
Apr 9 2019
I'm working on settings dialog, i'll try to upload a wip version this week. There is a problem with the fact that parts of KF5 are outdated, e.g. Kconfigdialog wraps every page in qscrollarea and kconfigdialogmanager does not support button groups.
I've (almost) implemented missing parts in Konsole for now and I'll fix it in KF5 later. The code in Konsole will allow to release it in 19.08 without bumping required kf5 version too high. When bumping will be ok it is easy to replace custom Konsole code with kf5 api.
Apr 6 2019
Sorry, I've missed Url in setDirectoryUrl :/
Apr 5 2019
Apr 4 2019
@hindenburg why is URL a list when only one entry is used? With string type homePath() could be used in readPathEntry as default value, making if...else... redundant.
Apr 3 2019
Mar 29 2019
- An escape value if you destroy the UI by accident (e.g. by deleting the default panel) without needing to right-click