- User Since
- Feb 28 2018, 11:25 PM (40 w, 5 d)
Wed, Dec 5
New widget would be nice. The information here is not that important (for advanced user) and is not an indicator (where kmessagewidget is perfect) but more like an one-time hint. The warning icon indicates that the option should be used with caution, or that the configuration is somehow risky. Someone who cares about it can just click and read a message.
Mon, Dec 3
- Remove unnecessary line from description
- Add: Use monospace font for "Word characters" text input
All suggestions applied. However, I think the "Blinking" checkbox looks a bit weird without the right label:
Thu, Nov 29
Oct 23 2018
Fix broken preview when antialiasing is disabled
Oct 21 2018
Oct 16 2018
Add printing test case
Oct 7 2018
Oct 1 2018
Set upstream to master
git rebase master
Sep 28 2018
git rebase arc/396435/Add-a-tool-for-generating-character-width-tables
git rebase master
Sep 26 2018
Jul 14 2018
Jul 11 2018
May 23 2018
May 21 2018
May 18 2018
Use QTest::newRow instead of QTest::addRow
Well... the bug was introduced by me in 17cb78cee147. I didn't see anything related on mailing list since then. Those two bugs are not related.
May 17 2018
There is one visible tab in KonsolePart now, it shouldn't be there.
Push new description
- git rebase master
- restore original implementation files
- mention original files in description
May 16 2018
Two patches together would be better. I think there might be some bugreports about a character width being wrong, which most likely would be caused by konsole_wcwidth (e.g. emoji).
May 15 2018
Use characters which work with konsole_wcwidth in a test case.
May 14 2018
Update to master
Update to master
The boxes look the same for me, both on master and master + the patch reverted:
Font: Hack; also tested Ubuntu Mono. Checked in vim and cat.
May 13 2018
- Algorithm change removed - it is actually consistent with xterm and linux console.
- Added cursor X position bounding in Screen external interface - again, to match xterm and linux console.
- Updated description.
May 10 2018
Ok, this is a bug in my code.
I've tried with custom and default konsole config, zsh with powerline as the shell. I don't have any additional space other than the area which is too narrow to be used as text column and part of the scrollbar. But those are normally there. I've tried displaying long text lines and long text lines + window scaling. TerminalCenter and TerminalMargin also works as in master.
May 7 2018
git rebase master
May 5 2018
Set upstream master
Rebase. Really fix the diff
Every reasonable code which solves this problem gives the same assembly (with -O2, used in release builds), so speed will not change.
As for "more readable" you're right. Additionally I've decided to separate the original rect. Any code added in the same line as the last QRect parameter might "disappear" during quick code scan.
May 3 2018
The language in example is Japanese. This is unrelated to last RTL-related commit.
You can't test it with anything that runs on TTY. IME pre-edit text does not interact with TTY - Konsole receives (through Qt) either "render this string in a nice way" or "use this string as regular input" message. The commit fixes the former.
May 2 2018
Apr 26 2018
This didn't crashed too. Maybe (hidden) TerminalDisplay had too small size somehow? This is the only way I was able to trigger the bug in the test.
Anyway, please check:
This will fix the problem.
Apr 20 2018
Clang, GCC, empty profile, my usual profile, adding qDebugs to track cursor position and array size, etc - always works.
Apr 19 2018
I did that, all tests pass without significant errors (only memory leaks). I am using semi-clean environment (empty directory as $HOME and bash as $SHELL). For this test I've used default configuration + blinking cursor.
Apr 16 2018
Fix 32 bit support in history
Apr 15 2018
Apr 10 2018
I guess the 'e' was removed by mistake
Apr 9 2018
Apr 6 2018
I agree. Most minimal way to fully solve the problem.
Apr 2 2018
How does this handle pasting of something like this: "\033\033[201~[201~" (I can't check right now)?
This can be defeated with \033\033[201~[201~.
Why not remove all control characters (except \n, \t, etc.) like xterm does?
Also, please link this with the bug: https://bugs.kde.org/show_bug.cgi?id=392554
Apr 1 2018
Mar 28 2018
- Removed tests for things fixed in latest commits and added one new test
- Added proper mouse clicks handling in programs with mouse support in read-only mode
currentView (exactly the same declaration) was there since 2011, declared just below 1114 ( if ( entry.command() != KeyboardTranslator::NoCommand )) , so I think it is safe to assume in this scope it is not null.
Your patch fixed it (well.. disabled), with this patch it is enabled again, without crashing. I am uploading patch which fixes scroll in read only mode, and sets currentTerminalDisplay.
No, because screen scrolling is always allowed (starts on 1114). The rest is filtered out on 1138 and 1142 when read-only is active.
I've made one more change, in separate review as this one is already on master: https://phabricator.kde.org/D11762