- User Since
- Feb 28 2018, 11:25 PM (85 w, 2 d)
Wed, Oct 16
There is no merge commit when it is not necessary, and commits are not usually squashed (at least in Konsole, quick look at Okular says the same), so a MR author should put the keywords in one of the commits. You can check commits on a branch (or in commits tab in merge request) and ask commiter to fix commit descriptions. However, force-push is not allowed in some cases, so that might be impossible (IIRC).
Tue, Oct 15
Gitlab's Merge Request description is not placed in a commit (at least when there is no merge commit, which is default). Each commit in merge request has its own independent description.
Please see "02 Oct, 2019 (5 commits)" in https://invent.kde.org/kde/okular/commits/master - this is the result of mentioned merge. Hooks didn't catch bug entries because they are not in commits.
Mon, Oct 14
Please note that Konsole icon is intended to be personalized icon/"logo" (see T10243).
The prompt symbol is thick as it is main symbol (like symbols in e.g Plasma, Akregator, Kile, "K" icons/logos) - the window-like background (or just square in var C) is just secondary addition.
Sun, Oct 13
Sat, Oct 12
Right one (larger shadow size). Plasma popups open above windows, yet they cast a lot smaller shadow than window shadow right now.
Fri, Oct 11
Yes, I'll create review soon
Sat, Oct 5
Fri, Oct 4
Wed, Oct 2
Tue, Oct 1
Mon, Sep 30
Sun, Sep 29
I need some more time (~week) for fixes and cleanup.
Fri, Sep 27
Thank you. Looks good!
@vladimirmikulic can you put screenshot here?
Wed, Sep 25
Sun, Sep 22
Sep 18 2019
Adding border to all toolbar buttons will be super heavy in cases where there is more than a few buttons.
To do changes like this I think we should separate concept of classic toolbars (few toolbars, each with many buttons/controls) and modern "widgets row" (few controls visually aligned with window/content). Or just use QToolButtons with disabled autoRaise to get the border on them.
Sep 15 2019
Maybe different background instead of frame? Frame stands out too much, a bit like focus/hover.
It's hard to tell that it's actually a clickable part of the UI. When you hover over elements of it, the hover effects look so slight, that again, it's hard to tell what it's interactive.
Aug 25 2019
Aug 17 2019
Remove static in anonymous namespace
- Randomization on/off works as intended
- Minor fixes
Aug 15 2019
Please add the workaround for a bug fixed in qt 5.13 (eventfilter and stuff). Some people would like to compile it on current systems. In such case non-system Qt is not an option, as the style plugin won't load in older Qt. Also, the code is already written with nice ifdefs and works, so why not.
Aug 13 2019
List view/sidebar highlight: why the vertical bright line is on right (internal) side? Wouldn't it look better on left (outside)?
- How does current version look with a scrollbar ("normal" and overlay like in system settings)?
- Highlights on plasma panel  have the line on the panel edge, so having it also on window's edge could make it consistent.
- With the line "outside" it could be possible to use this design with tabs
- I see only one drawback - with panel placed on the left, the lines from panel and window could be mistaken for each other.
Aug 11 2019
The code (super dirty): https://cgit.kde.org/breeze.git/log/?h=mglb/checkbox-redesign
I managed to make good looking dot-line check mark for half-checked state.
Aug 6 2019
Aug 2 2019
Jul 27 2019
I don't think that duplicating functions already provided by external tools on all supported platforms is good. Each feature means more code and more possible things to break.
Jul 26 2019
Your code is right. I just checked and turns out this is not the only problem. In void Helper::loadConfig() You have to remove last argument (_config) from KStatefulBrush:
_viewFocusBrush = KStatefulBrush( KColorScheme::View, KColorScheme::FocusColor); _viewHoverBrush = KStatefulBrush( KColorScheme::View, KColorScheme::HoverColor); _viewNegativeTextBrush = KStatefulBrush( KColorScheme::View, KColorScheme::NegativeText);
This way KStatefulBrush uses a config loaded from a file path stored in application's property "KDE_COLOR_SCHEME_PATH" (or user default, if missing). The property is set by KColorSchemeManager.
I kind of forgot about this. Time to bump it on todo list.
qApp will work too (qGuiApp is qApp casted to its base class).
Jul 25 2019
@ndavis Install event filter on qGuiApp, handle QEvent::ApplicationPaletteChange and call configurationChanged. Should work.
Jul 24 2019
I planned to split this page after https://invent.kde.org/kde/konsole/merge_requests/10, but doing it now and including in 19.08 is not bad idea. I'll look at it.
Jul 20 2019
Jul 13 2019
Will animations be OK?
Moved to invent: https://invent.kde.org/kde/konsole/merge_requests/16
Jul 8 2019
You can't turn QT_NO_FOREACH on without bumping KF5 version - some headers (e.g. kconfiggroup.h in KF5 Config 5.47) use Q_FOREACH.
Jul 7 2019
Jul 6 2019
Bug confirmed with Qt 5.13.
The patch fixes it.
Jul 2 2019
Since actions: new tab with profile and switch to profile are already in menus, they could be added to Configure Shortcuts window (both actions for each profile). In such case shortcut editor in profile manager should be removed.
Jul 1 2019
Jun 28 2019
Why not both? Every desktop goes forward with UI design and provides limited UI versions for legacy code. By default overlay scrollbars can't be used, as Qt apps assume that nothing blocks visible content in scroll areas. Regular scrollbars have to be supported also for standalone scrollbar widgets. But when app is made to work well with overlay scrollbars and it is not disabled in breeze settings, why not turn them on on app request?
Jun 27 2019
Jun 26 2019
User accidentally doubleclicks item and all their look-related settings are gone. Has to configure everything again.
Jun 23 2019
Jun 22 2019
Jun 16 2019
They are, but I think breeze icons (especially directories) are not too bright and don't hurt eyes at night, like bright Deepin ones. If the purpose is to have everything darker, it could be better to just lower monitor brightness.
Or... did I misunderstand and you would like to just make backlight and directory icon color the same?
Jun 15 2019
qt5 SUSEQt5.10/src/settings/ProfileSettings.cpp:512:26: error: ���class QFontMetrics��� has no member named ���horizontalAdvance���
Note that ncurses devs recently decided to fix clear (https://bugzilla.gnome.org/show_bug.cgi?id=506438#c19), so on newer systems it will work even with current CSI2J behavior.
This lowers reasons behind this path to compatibility with clear in older systems and compatibility with xterm. If these goals are not important, the patch can be abandoned.
Scripting! <3 At least with some designs, like yours or mine
- Fix radio button name
- Add short info about profile shortcuts and visibility
- Add kuit tags
- Use modified QKeySequenceEdit for shortcut editing.
- Use disabled text color for non visible profile's shortcut text
Jun 12 2019
Jun 11 2019
Jun 10 2019
Yes yes yes!