mglb (Mariusz Glebocki)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 28 2018, 11:25 PM (51 w, 8 h)
Availability
Available

Recent Activity

Fri, Feb 15

mglb added a comment to D18784: Extend character clipping by grouping it with spaces.

I think it should be as it is now - user will see that a space, not a symbol, is selected.

Fri, Feb 15, 6:38 PM · Konsole

Tue, Feb 12

mglb updated the diff for D18735: Improve built-in line/block characters drawing.

Restore/fix copyrights

Tue, Feb 12, 10:39 PM · Konsole

Sun, Feb 10

mglb added inline comments to D18735: Improve built-in line/block characters drawing.
Sun, Feb 10, 12:54 AM · Konsole
mglb updated the diff for D18735: Improve built-in line/block characters drawing.

More more descriptive names

Sun, Feb 10, 12:54 AM · Konsole
mglb updated the diff for D18735: Improve built-in line/block characters drawing.

autobool

Sun, Feb 10, 12:30 AM · Konsole
mglb updated the summary of D18735: Improve built-in line/block characters drawing.
Sun, Feb 10, 12:16 AM · Konsole
mglb updated the diff for D18735: Improve built-in line/block characters drawing.

Update description

Sun, Feb 10, 12:15 AM · Konsole
mglb updated the diff for D18735: Improve built-in line/block characters drawing.

Fix suggested problems

Sun, Feb 10, 12:14 AM · Konsole

Sat, Feb 9

mglb added a comment to D18735: Improve built-in line/block characters drawing.

@sandsmark I'll take care of your remarks (probably) today

Sat, Feb 9, 7:48 AM · Konsole
mglb added inline comments to D18735: Improve built-in line/block characters drawing.
Sat, Feb 9, 4:02 AM · Konsole
mglb updated the summary of D18735: Improve built-in line/block characters drawing.
Sat, Feb 9, 3:23 AM · Konsole
mglb updated the diff for D18735: Improve built-in line/block characters drawing.

Update description (I hope so)

Sat, Feb 9, 3:21 AM · Konsole
mglb updated the diff for D18735: Improve built-in line/block characters drawing.
  • Resolve problems
  • Some additional improvements
Sat, Feb 9, 3:15 AM · Konsole

Fri, Feb 8

mglb added a comment to D18606: [WIP]Close tab on middle mouse button event.

What about hidding the tab, showing kmessagewidget "Tab xxx closed. undo" + timeout, and really closing the tab after the timeout? Works well on web/mobiles.

Fri, Feb 8, 4:55 PM · Konsole

Wed, Feb 6

mglb requested review of D18784: Extend character clipping by grouping it with spaces.
Wed, Feb 6, 10:52 AM · Konsole

Mon, Feb 4

mglb requested review of D18735: Improve built-in line/block characters drawing.
Mon, Feb 4, 8:05 PM · Konsole

Wed, Jan 30

mglb added a comment to D18154: Add a "Session Switcher" via Ctrl + Tab.
  1. I'm tempted to have a way to turn off the popup.
Wed, Jan 30, 6:23 PM · Konsole
mglb added inline comments to D18154: Add a "Session Switcher" via Ctrl + Tab.
Wed, Jan 30, 3:38 PM · Konsole

Mon, Jan 28

mglb added a comment to D18587: [WIP ] terminal headers.

What about using QStyle and CC_TitleBar for drawing? http://doc.qt.io/qt-5/qstyle.html#drawComplexControl

Mon, Jan 28, 10:29 PM

Fri, Jan 25

mglb added a comment to D17643: Multiple Splits per Tab.

Dimming: I think it should be configurable (dependent on window dimming?), especially when the color is hardcoded (looks bad with e.g. light color schemes)
Headers: Again, configurable. Or at least made with configurability in mind, it can be added later.

Fri, Jan 25, 4:23 PM · Konsole
mglb added a comment to D17643: Multiple Splits per Tab.
  1. I find it difficult to tell which pane is focused when there are many splits. We should do something to make this clearer. One idea I had was to give each split its own header on top that has the pane's title plus a button on it for activating the context menu without needing to right-click. Then the background of this header could change depending on whether or not its pane has focus. Just a thought. :)
Fri, Jan 25, 1:31 AM · Konsole

Jan 19 2019

mglb added a comment to D18352: Remember last output save directory.

In case of using file URL, I would change the variable name (like _saveDialogFileURL or something) and use selectURL() after creating the dialog object. The constructor, according to documentation, takes URL to the directory. It works OK now, but in theory can change in the future.
When using selectURL(), home directory could be always used in the constructor, and the function would be called only if _saveDialogFileURL is not empty.

Jan 19 2019, 11:19 AM · Konsole

Jan 18 2019

mglb added inline comments to D18352: Remember last output save directory.
Jan 18 2019, 7:32 AM · Konsole

Jan 2 2019

mglb added a comment to T10243: Some KDE applications could use better icons.

One can think of Kate as more advanced KWrite with extra tools (which is more or less true). Maybe some notepad-like icon for KWrite (like it is now), and the same icon with extras, like: highlighter pen lying on top, paper with grid/lines, colored text, clearly visible "{}" or "</>", etc, for Kate?
I would see Okteta icon as something with 0s and 1s or a few hex digits in a segment display style.

Jan 2 2019, 9:28 PM · KDE Applications, VDG
mglb added a comment to D17643: Multiple Splits per Tab.

Do you plan to completely remove support for multiple TerminalDisplays connected to single session, or is it just a temporary change?

Jan 2 2019, 7:21 PM · Konsole
mglb added a comment to D14262: fix emoji rendering.

It is not needed anymore

Jan 2 2019, 6:50 PM · Konsole

Dec 30 2018

mglb requested review of D17867: Remove leftover ifdefs for (unsupported) Windows.
Dec 30 2018, 3:14 AM · Konsole
mglb requested review of D17866: Properly show "/" for %d tab title format.
Dec 30 2018, 3:08 AM · Konsole
mglb requested review of D17865: Show valid subprocess CWD for %D tab title format.
Dec 30 2018, 3:08 AM · Konsole

Dec 26 2018

mglb added a comment to D17744: New search result look, resurrected.
  1. Font size change (Ctrl+Scroll, Ctrl++, Ctrl+-) during search is not handled

Not sure what you mean, it seems to work here.

Dec 26 2018, 2:39 PM · Konsole

Dec 23 2018

mglb requested review of D17746: Remove code for unsupported Qt versions.
Dec 23 2018, 2:38 AM · Konsole
mglb added a reviewer for D17744: New search result look, resurrected: VDG.
Dec 23 2018, 12:58 AM · Konsole
mglb added a comment to D17744: New search result look, resurrected.

Awesome! It was a thing I wanted to be made better. But there are some problems:

Dec 23 2018, 12:55 AM · Konsole

Dec 16 2018

mglb updated the diff for D17607: Restore previous tabbar look.

git rebase master

Dec 16 2018, 4:03 PM · Konsole
mglb added a comment to D17607: Restore previous tabbar look.

@loh.tar I agree this looks bad with so small (relatively) lines. But this is a thing for separate request for VDG. In the meantime, search for konsole stylesheets.

Dec 16 2018, 12:00 AM · Konsole

Dec 15 2018

mglb added a comment to D17244: Edit Profile Dialog UI redesign.

Awesome stuff. Any chance you'd be interested in giving the rest of Konsole's Settings window the same treatment, @mglb? Right now it uses a plain old tab view instead of this more common style.

Dec 15 2018, 11:28 PM · Konsole
mglb added a comment to D17244: Edit Profile Dialog UI redesign.

@loh.tar the window heigh is lower than 600px

Dec 15 2018, 11:23 PM · Konsole
mglb updated the diff for D17244: Edit Profile Dialog UI redesign.
  • git rebase master
  • Line spacing max is now set to 20px (was 5px), which can be useful for someone with large font.
  • Align "Line spacing" and "Margins" spin boxes (suggested by @emateli) - "side effect" of the above.
Dec 15 2018, 11:17 PM · Konsole
mglb added a comment to D17607: Restore previous tabbar look.

Not sure, what seems to be the main issue?

Dec 15 2018, 7:03 PM · Konsole
mglb added a comment to D17607: Restore previous tabbar look.

There is setDocumentMode(true); in constructor already. I didn't find any non-css way to remove it.

Dec 15 2018, 5:56 PM · Konsole
mglb updated the diff for D17607: Restore previous tabbar look.

Remove redundant argument from setCss()

Dec 15 2018, 5:22 PM · Konsole
mglb added a dependent revision for D17605: Restore default tabbar style when custom stylesheet is disabled: D17607: Restore previous tabbar look.
Dec 15 2018, 5:20 PM · Konsole
mglb requested review of D17607: Restore previous tabbar look.
Dec 15 2018, 5:20 PM · Konsole
mglb requested review of D17605: Restore default tabbar style when custom stylesheet is disabled.
Dec 15 2018, 4:41 PM · Konsole

Dec 5 2018

mglb added a comment to D17244: Edit Profile Dialog UI redesign.

New widget would be nice. The information here is not that important (for advanced user) and is not an indicator (where kmessagewidget is perfect) but more like an one-time hint. The warning icon indicates that the option should be used with caution, or that the configuration is somehow risky. Someone who cares about it can just click and read a message.

Dec 5 2018, 5:44 AM · Konsole

Dec 3 2018

mglb updated the diff for D17244: Edit Profile Dialog UI redesign.
  • Remove unnecessary line from description
  • Add: Use monospace font for "Word characters" text input
Dec 3 2018, 11:53 PM · Konsole
mglb updated the diff for D17244: Edit Profile Dialog UI redesign.

All suggestions applied. However, I think the "Blinking" checkbox looks a bit weird without the right label:

Dec 3 2018, 11:48 PM · Konsole

Nov 29 2018

ngraham awarded D17244: Edit Profile Dialog UI redesign a Mountain of Wealth token.
Nov 29 2018, 9:19 PM · Konsole
mglb requested review of D17244: Edit Profile Dialog UI redesign.
Nov 29 2018, 8:54 PM · Konsole

Oct 23 2018

mglb updated the diff for D16361: Edit Profile Dialog: Fix "Smooth fonts" preview.

Fix broken preview when antialiasing is disabled

Oct 23 2018, 6:12 PM · Konsole

Oct 21 2018

mglb updated the test plan for D16361: Edit Profile Dialog: Fix "Smooth fonts" preview.
Oct 21 2018, 7:10 PM · Konsole
mglb requested review of D16361: Edit Profile Dialog: Fix "Smooth fonts" preview.
Oct 21 2018, 6:52 PM · Konsole

Oct 16 2018

mglb updated the diff for D16033: Fix double render when scrolling with visible search bar.

Add printing test case

Oct 16 2018, 2:11 AM · Konsole
mglb updated the diff for D16033: Fix double render when scrolling with visible search bar.

Fix printing

Oct 16 2018, 2:08 AM · Konsole

Oct 7 2018

mglb updated the test plan for D16033: Fix double render when scrolling with visible search bar.
Oct 7 2018, 11:43 PM · Konsole
mglb requested review of D16033: Fix double render when scrolling with visible search bar.
Oct 7 2018, 11:42 PM · Konsole

Oct 1 2018

mglb updated the diff for D15758: Use new character width code based on Unicode 11.

Set upstream to master

Oct 1 2018, 3:39 PM · Konsole
mglb updated the diff for D15758: Use new character width code based on Unicode 11.

git rebase master

Oct 1 2018, 3:33 PM · Konsole

Sep 28 2018

mglb updated the diff for D15758: Use new character width code based on Unicode 11.

git rebase arc/396435/Add-a-tool-for-generating-character-width-tables

Sep 28 2018, 5:57 PM · Konsole
mglb updated the diff for D15757: Add a tool for generating character width tables.

git rebase master

Sep 28 2018, 5:55 PM · Konsole

Sep 26 2018

mglb updated the diff for D15757: Add a tool for generating character width tables.

Language fix

Sep 26 2018, 9:52 PM · Konsole
mglb updated the diff for D15758: Use new character width code based on Unicode 11.

Language fix

Sep 26 2018, 9:47 PM · Konsole
mglb added inline comments to D15758: Use new character width code based on Unicode 11.
Sep 26 2018, 9:47 PM · Konsole
mglb updated the diff for D15757: Add a tool for generating character width tables.

Add copyrights

Sep 26 2018, 1:04 AM · Konsole
mglb updated the diff for D15757: Add a tool for generating character width tables.

Fix template.example

Sep 26 2018, 12:59 AM · Konsole
mglb requested review of D15758: Use new character width code based on Unicode 11.
Sep 26 2018, 12:56 AM · Konsole
mglb requested review of D15757: Add a tool for generating character width tables.
Sep 26 2018, 12:55 AM · Konsole
mglb added a dependent revision for D15756: Move character width functions to Character class: D15757: Add a tool for generating character width tables.
Sep 26 2018, 12:55 AM · Konsole
mglb requested review of D15756: Move character width functions to Character class.
Sep 26 2018, 12:52 AM · Konsole

Jul 14 2018

mglb updated the diff for D14106: Move search line upper bound check to less generic function.

Remove qDebugs

Jul 14 2018, 12:10 AM · Konsole
mglb requested review of D14106: Move search line upper bound check to less generic function.
Jul 14 2018, 12:09 AM · Konsole

Jul 11 2018

mglb updated the summary of D14038: IncrementalSearchBox: fix rendering during terminal scroll.
Jul 11 2018, 3:34 AM · Konsole
mglb added a reviewer for D14039: IncrementalSearchBox: use autoFillBackground: Konsole.
Jul 11 2018, 2:15 AM · Konsole
mglb added a reviewer for D14038: IncrementalSearchBox: fix rendering during terminal scroll: Konsole.
Jul 11 2018, 2:15 AM · Konsole
mglb added a reviewer for D14037: IncrementalSearchBox: do not propagate unhandled keys to parent: Konsole.
Jul 11 2018, 2:14 AM · Konsole
mglb requested review of D14039: IncrementalSearchBox: use autoFillBackground.
Jul 11 2018, 2:10 AM · Konsole
mglb requested review of D14038: IncrementalSearchBox: fix rendering during terminal scroll.
Jul 11 2018, 2:10 AM · Konsole
mglb requested review of D14037: IncrementalSearchBox: do not propagate unhandled keys to parent.
Jul 11 2018, 2:10 AM · Konsole

May 23 2018

mglb updated the test plan for D13081: Allow any character(s) as a key in key binding..
May 23 2018, 11:18 PM · Konsole
mglb requested review of D13081: Allow any character(s) as a key in key binding..
May 23 2018, 10:57 PM · Konsole
mglb requested review of D13080: Silence -Wformat-truncation warnings.
May 23 2018, 9:28 PM · Konsole

May 21 2018

mglb updated the diff for D12553: Convert loc() to function and add arguments checks.

rebase master

May 21 2018, 9:52 PM · Konsole
mglb abandoned D12238: Use libc's wcwidth() instead of own function.

On my FreeBSD, the width tests fail 20000-10 actual 1, expected 2

May 21 2018, 8:29 PM · Konsole

May 18 2018

mglb added a comment to D12238: Use libc's wcwidth() instead of own function.

Also, I'm a little concerned that we're going to start having to request what version of libc users's have in bug reports. And then have to research how that version uses wcwidth.

May 18 2018, 9:34 PM · Konsole
mglb updated the diff for D12238: Use libc's wcwidth() instead of own function.

Use QTest::newRow instead of QTest::addRow

May 18 2018, 8:08 PM · Konsole
mglb added a comment to D12939: Fix word selection mode.

Well... the bug was introduced by me in 17cb78cee147. I didn't see anything related on mailing list since then. Those two bugs are not related.

May 18 2018, 7:54 PM · Konsole
mglb added a comment to D12238: Use libc's wcwidth() instead of own function.

On the last line, the right | doesn't line up w/ the other rows

May 18 2018, 2:33 AM · Konsole
mglb updated the diff for D12939: Fix word selection mode.

Fix the fix

May 18 2018, 2:16 AM · Konsole

May 17 2018

mglb added a comment to D12942: Simplify code in Konsole.

There is one visible tab in KonsolePart now, it shouldn't be there.

May 17 2018, 11:29 PM · Konsole
mglb updated the diff for D12238: Use libc's wcwidth() instead of own function.

Push new description

May 17 2018, 11:14 PM · Konsole
mglb updated the diff for D12238: Use libc's wcwidth() instead of own function.
  • git rebase master
  • restore original implementation files
  • mention original files in description
May 17 2018, 11:13 PM · Konsole
mglb requested review of D12939: Fix word selection mode.
May 17 2018, 12:17 AM · Konsole

May 16 2018

mglb added a comment to D12236: Change internal character type size to 32 bit.

Two patches together would be better. I think there might be some bugreports about a character width being wrong, which most likely would be caused by konsole_wcwidth (e.g. emoji).

May 16 2018, 11:14 PM · Konsole

May 15 2018

mglb added a comment to D12236: Change internal character type size to 32 bit.

I assume this will increase memory/scrollback file size.

May 15 2018, 10:09 PM · Konsole
mglb updated the test plan for D12236: Change internal character type size to 32 bit.
May 15 2018, 10:01 PM · Konsole
mglb updated the diff for D12236: Change internal character type size to 32 bit.

Use characters which work with konsole_wcwidth in a test case.

May 15 2018, 10:00 PM · Konsole

May 14 2018

mglb updated the diff for D12238: Use libc's wcwidth() instead of own function.

Update to master

May 14 2018, 10:54 PM · Konsole
mglb updated the diff for D12236: Change internal character type size to 32 bit.

Update to master

May 14 2018, 10:52 PM · Konsole
mglb added a comment to D12551: Prevent invalid image array indexing.

The boxes look the same for me, both on master and master + the patch reverted:


Font: Hack; also tested Ubuntu Mono. Checked in vim and cat.

May 14 2018, 6:57 AM · Konsole

May 13 2018

mglb updated the test plan for D12554: Fix cursor advancement in last column.
May 13 2018, 11:57 PM · Konsole