mglb (Mariusz Glebocki)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Feb 28 2018, 11:25 PM (60 w, 1 d)
Availability
Available

Recent Activity

Yesterday

mglb added a comment to T10384: Unify styles for lists and their buttons.

Also rather than cramming and going icon only, I think there's room to make use of the space and stack actions vertically within the list view like this:

that then shares a familiar pattern with the actions in Kirigami's sidebar

Thu, Apr 25, 3:05 PM · Kirigami, KDE Human Interface Guidelines, VDG
mglb updated the summary of D20816: [WIP] Configure Konsole dialog GUI redesign.
Thu, Apr 25, 2:48 PM · VDG, Konsole
mglb updated the summary of D20816: [WIP] Configure Konsole dialog GUI redesign.
Thu, Apr 25, 2:38 PM · VDG, Konsole
mglb requested review of D20816: [WIP] Configure Konsole dialog GUI redesign.
Thu, Apr 25, 2:38 PM · VDG, Konsole

Tue, Apr 23

mglb added a comment to D20744: [WIP] Apply new window flags only when necessary.

Sure, when missing parts will be implemented or when we decide to not implement them.

Tue, Apr 23, 5:01 PM · Konsole

Mon, Apr 22

mglb requested review of D20744: [WIP] Apply new window flags only when necessary.
Mon, Apr 22, 6:21 PM · Konsole
mglb added a comment to D17865: Show valid subprocess CWD for %D tab title format.

Maybe just implement it using another letter? I guess both implementations have its fans

Mon, Apr 22, 6:17 PM · Konsole

Fri, Apr 19

mglb added a watcher for KDE Human Interface Guidelines: mglb.
Fri, Apr 19, 10:48 PM

Thu, Apr 18

mglb added a comment to D20439: Fix alignment boundary.

width type can be changed to int in order to fix this without reordering members.
The file is generated, so this should be changed also in the template.

Thu, Apr 18, 11:04 PM · Konsole

Fri, Apr 12

mglb added a comment to D20466: Rework scrollback settings.

And maybe rename labels in this style (someone with better english skills than I should verify this):

  • Fixed size → In memory, size:
  • Unlimited → On filesystem: (or "Unlimited, on filesystem:"?) + remove "history file location" label
  • Custom → Other
Fri, Apr 12, 8:15 PM · Konsole
mglb added a comment to D20466: Rework scrollback settings.

After thinking about scrollback a bit more I think history file path AND scrollback size should go to global settings. Does anyone use different profiles with different history sizes, or change size just for current session?

Fri, Apr 12, 4:09 PM · Konsole

Thu, Apr 11

mglb added a comment to D20466: Rework scrollback settings.

I tougth about showing the paths but my first tougth was “why do the user
cares where this is being stored”?

If they doesn't care, why give them ability to change the location?
User might not know exactly what "system" and "user" location is (/tmp might be obvious, ~/.cache/konsole not so much), and on which partition it will eventually end (in case of weird partitioning).

Thu, Apr 11, 8:17 PM · Konsole
mglb added a comment to T10783: Right-click on touch.
In T10783#181580, @mglb wrote:

As for right click/context menu... Swipe down/up from an element?

Thu, Apr 11, 4:47 PM · Plasma, VDG
mglb added a comment to T10783: Right-click on touch.

What do you think about changing the task to be about all touch actions (and what actions we want to have)? Asking too precise questions will lead to "ok lets use A for X" and later, in another task "no, we can't use A for this, X uses it".

Thu, Apr 11, 8:15 AM · Plasma, VDG

Tue, Apr 9

mglb added a comment to D20410: Display the settings as List instead of Tab.

I'm working on settings dialog, i'll try to upload a wip version this week. There is a problem with the fact that parts of KF5 are outdated, e.g. Kconfigdialog wraps every page in qscrollarea and kconfigdialogmanager does not support button groups.
I've (almost) implemented missing parts in Konsole for now and I'll fix it in KF5 later. The code in Konsole will allow to release it in 19.08 without bumping required kf5 version too high. When bumping will be ok it is easy to replace custom Konsole code with kf5 api.

Tue, Apr 9, 6:31 PM · Konsole

Sat, Apr 6

mglb added a comment to D18352: Remember last output save directory.

Sorry, I've missed Url in setDirectoryUrl :/

Sat, Apr 6, 7:45 PM · Konsole

Fri, Apr 5

mglb added reviewers for D20263: [WIP] Keep perceived contrast in random background color: Konsole, VDG.
Fri, Apr 5, 12:45 PM · VDG, Konsole
mglb requested review of D20263: [WIP] Keep perceived contrast in random background color.
Fri, Apr 5, 12:33 PM · VDG, Konsole

Thu, Apr 4

mglb added a comment to D18352: Remember last output save directory.

@hindenburg why is URL a list when only one entry is used? With string type homePath() could be used in readPathEntry as default value, making if...else... redundant.

Thu, Apr 4, 11:34 PM · Konsole
mglb added a comment to T10402: The Desktop Toolbox.

Another option:

Thu, Apr 4, 10:56 PM · Plasma, VDG
mglb added a comment to T10402: The Desktop Toolbox.

When we're at the possibility of "how to restore default panels when someone messes up things or remove all panels", why not add the option of restoring desktop/panel defaults to the desktop context menu? Of course, there would have to be confirmation pop-up (like: do you really want to do it, this action is irreversible and will bring your desktop space to default setup).

Thu, Apr 4, 3:18 PM · Plasma, VDG

Wed, Apr 3

mglb added a comment to T10402: The Desktop Toolbox.

I agree. Unfortunately it's not so easy. See https://bugs.kde.org/show_bug.cgi?id=391485

Wed, Apr 3, 8:54 PM · Plasma, VDG

Fri, Mar 29

mglb added a comment to T10402: The Desktop Toolbox.
  1. An escape value if you destroy the UI by accident (e.g. by deleting the default panel) without needing to right-click
Fri, Mar 29, 8:32 AM · Plasma, VDG

Mar 21 2019

mglb added a comment to T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG.

Are you aware that we're losing the Alt+Key focusing on the text input provided by Label->text buddy functionality? I think it's really bad that we're regressing on this accessibility feature.

Mar 21 2019, 3:15 AM · VDG, Plasma
mglb updated the diff for D19859: Fix undefined behavior and set QT_MIN_VERSION to 5.9.0.

Update description

Mar 21 2019, 2:21 AM · Konsole
mglb added a comment to D19859: Fix undefined behavior and set QT_MIN_VERSION to 5.9.0.

To get it compile w/ 5.9.4, I have to comment out all the QCOMPAREs - I thought I tested this w/ 5.9.7 but I appear to have upgraded my VMs

src/autotests/KeyboardTranslatorTest.cpp:112: error: undefined reference to 'bool QTest::qCompare<Qt::Key, int>(Qt::Key const&, int const&, char const*, char const*, char const*, int)'

Mar 21 2019, 2:19 AM · Konsole
mglb updated the diff for D19859: Fix undefined behavior and set QT_MIN_VERSION to 5.9.0.
  • Fix argument types in QCOMPARE (fixes builds)
  • Update description
Mar 21 2019, 2:19 AM · Konsole

Mar 18 2019

mglb requested review of D19859: Fix undefined behavior and set QT_MIN_VERSION to 5.9.0.
Mar 18 2019, 3:54 PM · Konsole

Mar 15 2019

mglb added a comment to D19266: Fix "Draw intense colors in bold font" feature.

@ngraham this is something else (styleName is handled in the patch). The fonts and their styles are not linked correctly, so we have fonts/styles:

Mar 15 2019, 11:10 PM · Konsole
mglb added a comment to D19266: Fix "Draw intense colors in bold font" feature.

Is this QT related issue then?

Most likely - when you open font selector in any Qt app, Plex Mono font has only 4 basic styles. To get "text" style you'll have to use Plex Mono Text font (and there is no bold).

Mar 15 2019, 11:27 AM · Konsole

Mar 12 2019

mglb added a comment to D19266: Fix "Draw intense colors in bold font" feature.

https://fonts.google.com/specimen/IBM+Plex+Mono this one?

Mar 12 2019, 9:08 AM · Konsole

Mar 2 2019

mglb requested review of D19484: Compare floats in a reliable way.
Mar 2 2019, 9:30 PM · Konsole
mglb added a comment to D17744: New search result look, resurrected.

@ngraham wrong review :)

Mar 2 2019, 9:10 PM · Konsole
mglb added inline comments to D17742: Clean up content rect in TerminalDisplay.
Mar 2 2019, 8:49 PM · Konsole
mglb abandoned D17867: Remove leftover ifdefs for (unsupported) Windows.

Abandoning it then

Mar 2 2019, 7:54 PM · Konsole

Mar 1 2019

mglb added a comment to D19364: [sddm-theme/lock screen] Add shadows to action buttons.

What about adding the same shadow under icons? Otherwise it looks like a text floating above flat background.

Mar 1 2019, 11:11 AM · Plasma

Feb 28 2019

mglb added a watcher for VDG: mglb.
Feb 28 2019, 4:40 PM

Feb 27 2019

mglb updated the diff for D19400: Resize Edit Profile dialog only when possible.

Restore normal value

Feb 27 2019, 10:09 PM · Konsole
mglb requested review of D19400: Resize Edit Profile dialog only when possible.
Feb 27 2019, 10:06 PM · Konsole

Feb 26 2019

mglb added inline comments to D17244: Edit Profile Dialog UI redesign.
Feb 26 2019, 11:03 PM · Konsole
mglb added inline comments to D17244: Edit Profile Dialog UI redesign.
Feb 26 2019, 9:39 AM · Konsole

Feb 25 2019

mglb closed D19269: Minor cleanup/optimizations in font changing code.

Pushed to master

Feb 25 2019, 5:10 AM · Konsole
mglb added a comment to D19266: Fix "Draw intense colors in bold font" feature.

A minor nitpick, if you're going to format the comments, try for < 80 column width - typically 70ish is better.

Feb 25 2019, 5:09 AM · Konsole
mglb committed R319:5a5da130c1e4: Do not filter out "too big" font sizes. (authored by mglb).
Do not filter out "too big" font sizes.
Feb 25 2019, 5:06 AM
mglb committed R319:411428baa8bd: Remove pointless checks in font match test (authored by mglb).
Remove pointless checks in font match test
Feb 25 2019, 5:06 AM
mglb committed R319:faffce94cdb0: Call a function with actual line spacing updating code (authored by mglb).
Call a function with actual line spacing updating code
Feb 25 2019, 5:06 AM
mglb committed R319:ab6cca053508: Do not process font that didn't change (authored by mglb).
Do not process font that didn't change
Feb 25 2019, 5:06 AM

Feb 24 2019

mglb added a comment to D19266: Fix "Draw intense colors in bold font" feature.

Depends on your opinion. As for me:

  • It is nice that we get all possible information about what an user selected in the font dialog - we can remove/change things we don't need/support.
  • The style name allows for most precise (afaik) style specification. Technically, there can exist two styles, with the same weight, stretch, etc, but different glyphs. However, Qt should unset styleName after manual change of particular style properties. It doesn't, so we need to do it manually (this can be considered the problem to which the patch is a workaround).
Feb 24 2019, 8:29 AM · Konsole
mglb requested review of D19269: Minor cleanup/optimizations in font changing code.
Feb 24 2019, 2:00 AM · Konsole

Feb 23 2019

mglb updated the diff for D19266: Fix "Draw intense colors in bold font" feature.

Fix diff

Feb 23 2019, 11:21 PM · Konsole
mglb retitled D19266: Fix "Draw intense colors in bold font" feature from For MacOS portion, use nullptr instead of NULL to Fix "Draw intense colors in bold font" feature.
Feb 23 2019, 11:17 PM · Konsole
mglb requested review of D19266: Fix "Draw intense colors in bold font" feature.
Feb 23 2019, 11:16 PM · Konsole

Feb 22 2019

mglb committed R319:650af4f78b9b: Replace assert with Q_ASSERT (authored by mglb).
Replace assert with Q_ASSERT
Feb 22 2019, 6:31 PM
mglb committed R319:286958f5fe10: Replace assert with Q_ASSERT (authored by mglb).
Replace assert with Q_ASSERT
Feb 22 2019, 6:26 PM
mglb committed R319:13132fc77bf9: Improve built-in line/block characters drawing (authored by mglb).
Improve built-in line/block characters drawing
Feb 22 2019, 5:52 PM
mglb closed D18735: Improve built-in line/block characters drawing.
Feb 22 2019, 5:52 PM · Konsole
mglb updated the diff for D18735: Improve built-in line/block characters drawing.

rebase master

Feb 22 2019, 4:40 PM · Konsole

Feb 15 2019

mglb added a comment to D18784: Extend character clipping by grouping it with spaces.

I think it should be as it is now - user will see that a space, not a symbol, is selected.

Feb 15 2019, 6:38 PM · Konsole

Feb 12 2019

mglb updated the diff for D18735: Improve built-in line/block characters drawing.

Restore/fix copyrights

Feb 12 2019, 10:39 PM · Konsole

Feb 10 2019

mglb added inline comments to D18735: Improve built-in line/block characters drawing.
Feb 10 2019, 12:54 AM · Konsole
mglb updated the diff for D18735: Improve built-in line/block characters drawing.

More more descriptive names

Feb 10 2019, 12:54 AM · Konsole
mglb updated the diff for D18735: Improve built-in line/block characters drawing.

autobool

Feb 10 2019, 12:30 AM · Konsole
mglb updated the summary of D18735: Improve built-in line/block characters drawing.
Feb 10 2019, 12:16 AM · Konsole
mglb updated the diff for D18735: Improve built-in line/block characters drawing.

Update description

Feb 10 2019, 12:15 AM · Konsole
mglb updated the diff for D18735: Improve built-in line/block characters drawing.

Fix suggested problems

Feb 10 2019, 12:14 AM · Konsole

Feb 9 2019

mglb added a comment to D18735: Improve built-in line/block characters drawing.

@sandsmark I'll take care of your remarks (probably) today

Feb 9 2019, 7:48 AM · Konsole
mglb added inline comments to D18735: Improve built-in line/block characters drawing.
Feb 9 2019, 4:02 AM · Konsole
mglb updated the summary of D18735: Improve built-in line/block characters drawing.
Feb 9 2019, 3:23 AM · Konsole
mglb updated the diff for D18735: Improve built-in line/block characters drawing.

Update description (I hope so)

Feb 9 2019, 3:21 AM · Konsole
mglb updated the diff for D18735: Improve built-in line/block characters drawing.
  • Resolve problems
  • Some additional improvements
Feb 9 2019, 3:15 AM · Konsole

Feb 8 2019

mglb added a comment to D18606: [WIP]Close tab on middle mouse button event.

What about hidding the tab, showing kmessagewidget "Tab xxx closed. undo" + timeout, and really closing the tab after the timeout? Works well on web/mobiles.

Feb 8 2019, 4:55 PM · Konsole

Feb 6 2019

mglb requested review of D18784: Extend character clipping by grouping it with spaces.
Feb 6 2019, 10:52 AM · Konsole

Feb 4 2019

mglb requested review of D18735: Improve built-in line/block characters drawing.
Feb 4 2019, 8:05 PM · Konsole

Jan 30 2019

mglb added a comment to D18154: Add a "Session Switcher" via Ctrl + Tab.
  1. I'm tempted to have a way to turn off the popup.
Jan 30 2019, 6:23 PM · Konsole
mglb added inline comments to D18154: Add a "Session Switcher" via Ctrl + Tab.
Jan 30 2019, 3:38 PM · Konsole

Jan 28 2019

mglb added a comment to D18587: [WIP ] terminal headers.

What about using QStyle and CC_TitleBar for drawing? http://doc.qt.io/qt-5/qstyle.html#drawComplexControl

Jan 28 2019, 10:29 PM

Jan 25 2019

mglb added a comment to D17643: Multiple Splits per Tab.

Dimming: I think it should be configurable (dependent on window dimming?), especially when the color is hardcoded (looks bad with e.g. light color schemes)
Headers: Again, configurable. Or at least made with configurability in mind, it can be added later.

Jan 25 2019, 4:23 PM · Konsole
mglb added a comment to D17643: Multiple Splits per Tab.
  1. I find it difficult to tell which pane is focused when there are many splits. We should do something to make this clearer. One idea I had was to give each split its own header on top that has the pane's title plus a button on it for activating the context menu without needing to right-click. Then the background of this header could change depending on whether or not its pane has focus. Just a thought. :)
Jan 25 2019, 1:31 AM · Konsole

Jan 19 2019

mglb added a comment to D18352: Remember last output save directory.

In case of using file URL, I would change the variable name (like _saveDialogFileURL or something) and use selectURL() after creating the dialog object. The constructor, according to documentation, takes URL to the directory. It works OK now, but in theory can change in the future.
When using selectURL(), home directory could be always used in the constructor, and the function would be called only if _saveDialogFileURL is not empty.

Jan 19 2019, 11:19 AM · Konsole

Jan 18 2019

mglb added inline comments to D18352: Remember last output save directory.
Jan 18 2019, 7:32 AM · Konsole

Jan 2 2019

mglb added a comment to T10243: Some KDE applications could use better icons.

One can think of Kate as more advanced KWrite with extra tools (which is more or less true). Maybe some notepad-like icon for KWrite (like it is now), and the same icon with extras, like: highlighter pen lying on top, paper with grid/lines, colored text, clearly visible "{}" or "</>", etc, for Kate?
I would see Okteta icon as something with 0s and 1s or a few hex digits in a segment display style.

Jan 2 2019, 9:28 PM · KDE Applications, VDG
mglb added a comment to D17643: Multiple Splits per Tab.

Do you plan to completely remove support for multiple TerminalDisplays connected to single session, or is it just a temporary change?

Jan 2 2019, 7:21 PM · Konsole
mglb added a comment to D14262: fix emoji rendering.

It is not needed anymore

Jan 2 2019, 6:50 PM · Konsole

Dec 30 2018

mglb requested review of D17867: Remove leftover ifdefs for (unsupported) Windows.
Dec 30 2018, 3:14 AM · Konsole
mglb requested review of D17866: Properly show "/" for %d tab title format.
Dec 30 2018, 3:08 AM · Konsole
mglb requested review of D17865: Show valid subprocess CWD for %D tab title format.
Dec 30 2018, 3:08 AM · Konsole

Dec 26 2018

mglb added a comment to D17744: New search result look, resurrected.
  1. Font size change (Ctrl+Scroll, Ctrl++, Ctrl+-) during search is not handled

Not sure what you mean, it seems to work here.

Dec 26 2018, 2:39 PM · Konsole

Dec 23 2018

mglb requested review of D17746: Remove code for unsupported Qt versions.
Dec 23 2018, 2:38 AM · Konsole
mglb added a reviewer for D17744: New search result look, resurrected: VDG.
Dec 23 2018, 12:58 AM · Konsole
mglb added a comment to D17744: New search result look, resurrected.

Awesome! It was a thing I wanted to be made better. But there are some problems:

Dec 23 2018, 12:55 AM · Konsole

Dec 16 2018

mglb updated the diff for D17607: Restore previous tabbar look.

git rebase master

Dec 16 2018, 4:03 PM · Konsole
mglb added a comment to D17607: Restore previous tabbar look.

@loh.tar I agree this looks bad with so small (relatively) lines. But this is a thing for separate request for VDG. In the meantime, search for konsole stylesheets.

Dec 16 2018, 12:00 AM · Konsole

Dec 15 2018

mglb added a comment to D17244: Edit Profile Dialog UI redesign.

Awesome stuff. Any chance you'd be interested in giving the rest of Konsole's Settings window the same treatment, @mglb? Right now it uses a plain old tab view instead of this more common style.

Dec 15 2018, 11:28 PM · Konsole
mglb added a comment to D17244: Edit Profile Dialog UI redesign.

@loh.tar the window heigh is lower than 600px

Dec 15 2018, 11:23 PM · Konsole
mglb updated the diff for D17244: Edit Profile Dialog UI redesign.
  • git rebase master
  • Line spacing max is now set to 20px (was 5px), which can be useful for someone with large font.
  • Align "Line spacing" and "Margins" spin boxes (suggested by @emateli) - "side effect" of the above.
Dec 15 2018, 11:17 PM · Konsole
mglb added a comment to D17607: Restore previous tabbar look.

Not sure, what seems to be the main issue?

Dec 15 2018, 7:03 PM · Konsole
mglb added a comment to D17607: Restore previous tabbar look.

There is setDocumentMode(true); in constructor already. I didn't find any non-css way to remove it.

Dec 15 2018, 5:56 PM · Konsole
mglb updated the diff for D17607: Restore previous tabbar look.

Remove redundant argument from setCss()

Dec 15 2018, 5:22 PM · Konsole
mglb added a dependent revision for D17605: Restore default tabbar style when custom stylesheet is disabled: D17607: Restore previous tabbar look.
Dec 15 2018, 5:20 PM · Konsole
mglb requested review of D17607: Restore previous tabbar look.
Dec 15 2018, 5:20 PM · Konsole