mglb (Mariusz Glebocki)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Feb 28 2018, 11:25 PM (40 w, 5 d)
Availability
Available

Recent Activity

Wed, Dec 5

mglb added a comment to D17244: Edit Profile Dialog UI redesign.

New widget would be nice. The information here is not that important (for advanced user) and is not an indicator (where kmessagewidget is perfect) but more like an one-time hint. The warning icon indicates that the option should be used with caution, or that the configuration is somehow risky. Someone who cares about it can just click and read a message.

Wed, Dec 5, 5:44 AM · Konsole

Mon, Dec 3

mglb updated the diff for D17244: Edit Profile Dialog UI redesign.
  • Remove unnecessary line from description
  • Add: Use monospace font for "Word characters" text input
Mon, Dec 3, 11:53 PM · Konsole
mglb updated the diff for D17244: Edit Profile Dialog UI redesign.

All suggestions applied. However, I think the "Blinking" checkbox looks a bit weird without the right label:

Mon, Dec 3, 11:48 PM · Konsole

Thu, Nov 29

ngraham awarded D17244: Edit Profile Dialog UI redesign a Mountain of Wealth token.
Thu, Nov 29, 9:19 PM · Konsole
mglb requested review of D17244: Edit Profile Dialog UI redesign.
Thu, Nov 29, 8:54 PM · Konsole

Oct 23 2018

mglb updated the diff for D16361: Edit Profile Dialog: Fix "Smooth fonts" preview.

Fix broken preview when antialiasing is disabled

Oct 23 2018, 6:12 PM · Konsole

Oct 21 2018

mglb updated the test plan for D16361: Edit Profile Dialog: Fix "Smooth fonts" preview.
Oct 21 2018, 7:10 PM · Konsole
mglb requested review of D16361: Edit Profile Dialog: Fix "Smooth fonts" preview.
Oct 21 2018, 6:52 PM · Konsole

Oct 16 2018

mglb updated the diff for D16033: Fix double render when scrolling with visible search bar.

Add printing test case

Oct 16 2018, 2:11 AM · Konsole
mglb updated the diff for D16033: Fix double render when scrolling with visible search bar.

Fix printing

Oct 16 2018, 2:08 AM · Konsole

Oct 7 2018

mglb updated the test plan for D16033: Fix double render when scrolling with visible search bar.
Oct 7 2018, 11:43 PM · Konsole
mglb requested review of D16033: Fix double render when scrolling with visible search bar.
Oct 7 2018, 11:42 PM · Konsole

Oct 1 2018

mglb updated the diff for D15758: Use new character width code based on Unicode 11.

Set upstream to master

Oct 1 2018, 3:39 PM · Konsole
mglb updated the diff for D15758: Use new character width code based on Unicode 11.

git rebase master

Oct 1 2018, 3:33 PM · Konsole

Sep 28 2018

mglb updated the diff for D15758: Use new character width code based on Unicode 11.

git rebase arc/396435/Add-a-tool-for-generating-character-width-tables

Sep 28 2018, 5:57 PM · Konsole
mglb updated the diff for D15757: Add a tool for generating character width tables.

git rebase master

Sep 28 2018, 5:55 PM · Konsole

Sep 26 2018

mglb updated the diff for D15757: Add a tool for generating character width tables.

Language fix

Sep 26 2018, 9:52 PM · Konsole
mglb updated the diff for D15758: Use new character width code based on Unicode 11.

Language fix

Sep 26 2018, 9:47 PM · Konsole
mglb added inline comments to D15758: Use new character width code based on Unicode 11.
Sep 26 2018, 9:47 PM · Konsole
mglb updated the diff for D15757: Add a tool for generating character width tables.

Add copyrights

Sep 26 2018, 1:04 AM · Konsole
mglb updated the diff for D15757: Add a tool for generating character width tables.

Fix template.example

Sep 26 2018, 12:59 AM · Konsole
mglb requested review of D15758: Use new character width code based on Unicode 11.
Sep 26 2018, 12:56 AM · Konsole
mglb requested review of D15757: Add a tool for generating character width tables.
Sep 26 2018, 12:55 AM · Konsole
mglb added a dependent revision for D15756: Move character width functions to Character class: D15757: Add a tool for generating character width tables.
Sep 26 2018, 12:55 AM · Konsole
mglb requested review of D15756: Move character width functions to Character class.
Sep 26 2018, 12:52 AM · Konsole

Jul 14 2018

mglb updated the diff for D14106: Move search line upper bound check to less generic function.

Remove qDebugs

Jul 14 2018, 12:10 AM · Konsole
mglb requested review of D14106: Move search line upper bound check to less generic function.
Jul 14 2018, 12:09 AM · Konsole

Jul 11 2018

mglb updated the summary of D14038: IncrementalSearchBox: fix rendering during terminal scroll.
Jul 11 2018, 3:34 AM · Konsole
mglb added a reviewer for D14039: IncrementalSearchBox: use autoFillBackground: Konsole.
Jul 11 2018, 2:15 AM · Konsole
mglb added a reviewer for D14038: IncrementalSearchBox: fix rendering during terminal scroll: Konsole.
Jul 11 2018, 2:15 AM · Konsole
mglb added a reviewer for D14037: IncrementalSearchBox: do not propagate unhandled keys to parent: Konsole.
Jul 11 2018, 2:14 AM · Konsole
mglb requested review of D14039: IncrementalSearchBox: use autoFillBackground.
Jul 11 2018, 2:10 AM · Konsole
mglb requested review of D14038: IncrementalSearchBox: fix rendering during terminal scroll.
Jul 11 2018, 2:10 AM · Konsole
mglb requested review of D14037: IncrementalSearchBox: do not propagate unhandled keys to parent.
Jul 11 2018, 2:10 AM · Konsole

May 23 2018

mglb updated the test plan for D13081: Allow any character(s) as a key in key binding..
May 23 2018, 11:18 PM · Konsole
mglb requested review of D13081: Allow any character(s) as a key in key binding..
May 23 2018, 10:57 PM · Konsole
mglb requested review of D13080: Silence -Wformat-truncation warnings.
May 23 2018, 9:28 PM · Konsole

May 21 2018

mglb updated the diff for D12553: Convert loc() to function and add arguments checks.

rebase master

May 21 2018, 9:52 PM · Konsole
mglb abandoned D12238: Use libc's wcwidth() instead of own function.

On my FreeBSD, the width tests fail 20000-10 actual 1, expected 2

May 21 2018, 8:29 PM · Konsole

May 18 2018

mglb added a comment to D12238: Use libc's wcwidth() instead of own function.

Also, I'm a little concerned that we're going to start having to request what version of libc users's have in bug reports. And then have to research how that version uses wcwidth.

May 18 2018, 9:34 PM · Konsole
mglb updated the diff for D12238: Use libc's wcwidth() instead of own function.

Use QTest::newRow instead of QTest::addRow

May 18 2018, 8:08 PM · Konsole
mglb added a comment to D12939: Fix word selection mode.

Well... the bug was introduced by me in 17cb78cee147. I didn't see anything related on mailing list since then. Those two bugs are not related.

May 18 2018, 7:54 PM · Konsole
mglb added a comment to D12238: Use libc's wcwidth() instead of own function.

On the last line, the right | doesn't line up w/ the other rows

May 18 2018, 2:33 AM · Konsole
mglb updated the diff for D12939: Fix word selection mode.

Fix the fix

May 18 2018, 2:16 AM · Konsole

May 17 2018

mglb added a comment to D12942: Simplify code in Konsole.

There is one visible tab in KonsolePart now, it shouldn't be there.

May 17 2018, 11:29 PM · Konsole
mglb updated the diff for D12238: Use libc's wcwidth() instead of own function.

Push new description

May 17 2018, 11:14 PM · Konsole
mglb updated the diff for D12238: Use libc's wcwidth() instead of own function.
  • git rebase master
  • restore original implementation files
  • mention original files in description
May 17 2018, 11:13 PM · Konsole
mglb requested review of D12939: Fix word selection mode.
May 17 2018, 12:17 AM · Konsole

May 16 2018

mglb added a comment to D12236: Change internal character type size to 32 bit.

Two patches together would be better. I think there might be some bugreports about a character width being wrong, which most likely would be caused by konsole_wcwidth (e.g. emoji).

May 16 2018, 11:14 PM · Konsole

May 15 2018

mglb added a comment to D12236: Change internal character type size to 32 bit.

I assume this will increase memory/scrollback file size.

May 15 2018, 10:09 PM · Konsole
mglb updated the test plan for D12236: Change internal character type size to 32 bit.
May 15 2018, 10:01 PM · Konsole
mglb updated the diff for D12236: Change internal character type size to 32 bit.

Use characters which work with konsole_wcwidth in a test case.

May 15 2018, 10:00 PM · Konsole

May 14 2018

mglb updated the diff for D12238: Use libc's wcwidth() instead of own function.

Update to master

May 14 2018, 10:54 PM · Konsole
mglb updated the diff for D12236: Change internal character type size to 32 bit.

Update to master

May 14 2018, 10:52 PM · Konsole
mglb added a comment to D12551: Prevent invalid image array indexing.

The boxes look the same for me, both on master and master + the patch reverted:


Font: Hack; also tested Ubuntu Mono. Checked in vim and cat.

May 14 2018, 6:57 AM · Konsole

May 13 2018

mglb updated the test plan for D12554: Fix cursor advancement in last column.
May 13 2018, 11:57 PM · Konsole
mglb updated the diff for D12554: Fix cursor advancement in last column.
  • Algorithm change removed - it is actually consistent with xterm and linux console.
  • Added cursor X position bounding in Screen external interface - again, to match xterm and linux console.
  • Updated description.
May 13 2018, 11:55 PM · Konsole

May 10 2018

mglb added a comment to D12554: Fix cursor advancement in last column.

Ok, this is a bug in my code.

May 10 2018, 1:01 AM · Konsole
mglb added a comment to D12551: Prevent invalid image array indexing.

I've tried with custom and default konsole config, zsh with powerline as the shell. I don't have any additional space other than the area which is too narrow to be used as text column and part of the scrollbar. But those are normally there. I've tried displaying long text lines and long text lines + window scaling. TerminalCenter and TerminalMargin also works as in master.

May 10 2018, 12:38 AM · Konsole

May 7 2018

mglb updated the diff for D12551: Prevent invalid image array indexing.

git rebase master

May 7 2018, 11:10 PM · Konsole

May 5 2018

mglb updated the diff for D12556: Do not paint long pre-edit text outside display.

Set upstream master

May 5 2018, 11:28 PM · Konsole
mglb updated the diff for D12556: Do not paint long pre-edit text outside display.

Rebase. Really fix the diff

May 5 2018, 11:26 PM · Konsole
mglb updated the diff for D12556: Do not paint long pre-edit text outside display.

Fix diff

May 5 2018, 11:21 PM · Konsole
mglb updated the diff for D12556: Do not paint long pre-edit text outside display.

Every reasonable code which solves this problem gives the same assembly (with -O2, used in release builds), so speed will not change.
As for "more readable" you're right. Additionally I've decided to separate the original rect. Any code added in the same line as the last QRect parameter might "disappear" during quick code scan.

May 5 2018, 11:17 PM · Konsole

May 3 2018

mglb added a comment to D12556: Do not paint long pre-edit text outside display.

The language in example is Japanese. This is unrelated to last RTL-related commit.
You can't test it with anything that runs on TTY. IME pre-edit text does not interact with TTY - Konsole receives (through Qt) either "render this string in a nice way" or "use this string as regular input" message. The commit fixes the former.

May 3 2018, 4:37 PM · Konsole
mglb updated the diff for D12555: Do not round up character coordinates for hotspots.

Rebase

May 3 2018, 3:35 PM · Konsole

May 2 2018

mglb added a comment to D12655: Restore Bi-Directional text support.

The output looks good according to BR. I wonder if adding this isRtl to Character might be an option.

May 2 2018, 2:32 PM · Konsole
mglb requested review of D12655: Restore Bi-Directional text support.
May 2 2018, 5:36 AM · Konsole

Apr 26 2018

mglb updated the test plan for D12554: Fix cursor advancement in last column.
Apr 26 2018, 10:40 PM · Konsole
mglb updated the summary of D12555: Do not round up character coordinates for hotspots.
Apr 26 2018, 10:26 PM · Konsole
mglb added a comment to D12236: Change internal character type size to 32 bit.

This didn't crashed too. Maybe (hidden) TerminalDisplay had too small size somehow? This is the only way I was able to trigger the bug in the test.
Anyway, please check:
https://phabricator.kde.org/D12551
This will fix the problem.

Apr 26 2018, 10:02 PM · Konsole
mglb requested review of D12556: Do not paint long pre-edit text outside display.
Apr 26 2018, 9:57 PM · Konsole
mglb requested review of D12555: Do not round up character coordinates for hotspots.
Apr 26 2018, 9:57 PM · Konsole
mglb requested review of D12554: Fix cursor advancement in last column.
Apr 26 2018, 9:56 PM · Konsole
mglb requested review of D12553: Convert loc() to function and add arguments checks.
Apr 26 2018, 9:55 PM · Konsole
mglb added a dependent revision for D12551: Prevent invalid image array indexing: D12553: Convert loc() to function and add arguments checks.
Apr 26 2018, 9:55 PM · Konsole
mglb requested review of D12551: Prevent invalid image array indexing.
Apr 26 2018, 9:52 PM · Konsole

Apr 20 2018

mglb added a comment to D12236: Change internal character type size to 32 bit.

Clang, GCC, empty profile, my usual profile, adding qDebugs to track cursor position and array size, etc - always works.

Apr 20 2018, 11:45 PM · Konsole

Apr 19 2018

mglb added a comment to D12236: Change internal character type size to 32 bit.

I did that, all tests pass without significant errors (only memory leaks). I am using semi-clean environment (empty directory as $HOME and bash as $SHELL). For this test I've used default configuration + blinking cursor.

Apr 19 2018, 10:59 PM · Konsole

Apr 16 2018

mglb updated the diff for D12236: Change internal character type size to 32 bit.

Fix 32 bit support in history

Apr 16 2018, 11:09 PM · Konsole

Apr 15 2018

mglb updated the test plan for D12236: Change internal character type size to 32 bit.
Apr 15 2018, 11:25 PM · Konsole
mglb requested review of D12238: Use libc's wcwidth() instead of own function.
Apr 15 2018, 11:22 PM · Konsole
mglb added a dependent revision for D12236: Change internal character type size to 32 bit: D12238: Use libc's wcwidth() instead of own function.
Apr 15 2018, 11:22 PM · Konsole
mglb requested review of D12236: Change internal character type size to 32 bit.
Apr 15 2018, 11:12 PM · Konsole

Apr 10 2018

mglb added a comment to D12058: Always preserve line breaks on "Select All" action.

I guess the 'e' was removed by mistake

Apr 10 2018, 7:23 AM · Konsole
mglb updated the test plan for D12058: Always preserve line breaks on "Select All" action.
Apr 10 2018, 7:21 AM · Konsole

Apr 9 2018

mglb requested review of D12058: Always preserve line breaks on "Select All" action.
Apr 9 2018, 2:48 AM · Konsole

Apr 6 2018

mglb added a comment to D11859: Copy&paste exploits.

I agree. Most minimal way to fully solve the problem.

Apr 6 2018, 9:23 PM · Konsole

Apr 2 2018

mglb requested review of D11893: Do not resize new screen lines.
Apr 2 2018, 11:04 PM · Konsole
mglb added a comment to D11859: Copy&paste exploits.

How does this handle pasting of something like this: "\033\033[201~[201~" (I can't check right now)?
This can be defeated with \033\033[201~[201~.
Why not remove all control characters (except \n, \t, etc.) like xterm does?
Also, please link this with the bug: https://bugs.kde.org/show_bug.cgi?id=392554

Apr 2 2018, 5:26 PM · Konsole

Apr 1 2018

mglb added a comment to D11843: Show the scrollbar only when needed.

"why is there the ugly black stripe on right"

otherwise there would be a srollbar that you can't interact with
disabling the scrollbar area for these kind of terminal programs would be a different challenge not in scope for this patch

Apr 1 2018, 1:07 AM · Konsole

Mar 28 2018

mglb added a reviewer for D11763: Properly handle mouse in read-only mode: hindenburg.
Mar 28 2018, 10:50 PM · Konsole
mglb updated subscribers of D11763: Properly handle mouse in read-only mode.

To be clear the "test" area is after applying the patch correct? I can't tell the difference following those steps

Mar 28 2018, 10:49 PM · Konsole
mglb updated the diff for D11763: Properly handle mouse in read-only mode.
  • Removed tests for things fixed in latest commits and added one new test
  • Added proper mouse clicks handling in programs with mouse support in read-only mode
Mar 28 2018, 10:45 PM · Konsole
mglb requested review of D11763: Properly handle mouse in read-only mode.
Mar 28 2018, 2:48 AM · Konsole
mglb added a comment to D11762: Process key event even without active TerminalDisplay.

currentView (exactly the same declaration) was there since 2011, declared just below 1114 ( if ( entry.command() != KeyboardTranslator::NoCommand )) , so I think it is safe to assume in this scope it is not null.

Mar 28 2018, 2:15 AM · Konsole
mglb added a comment to D11762: Process key event even without active TerminalDisplay.

Your patch fixed it (well.. disabled), with this patch it is enabled again, without crashing. I am uploading patch which fixes scroll in read only mode, and sets currentTerminalDisplay.

Mar 28 2018, 1:42 AM · Konsole
mglb added a comment to D11762: Process key event even without active TerminalDisplay.

No, because screen scrolling is always allowed (starts on 1114). The rest is filtered out on 1138 and 1142 when read-only is active.

Mar 28 2018, 1:26 AM · Konsole
mglb added a comment to D11668: Allow view-controlling keys in read-only mode.

I've made one more change, in separate review as this one is already on master: https://phabricator.kde.org/D11762

Mar 28 2018, 1:16 AM · Konsole
mglb requested review of D11762: Process key event even without active TerminalDisplay.
Mar 28 2018, 1:13 AM · Konsole