mglb (Mariusz Glebocki)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 28 2018, 11:25 PM (67 w, 3 d)
Availability
Available

Recent Activity

Today

mglb requested review of D21840: Restore compatibility with Qt < 5.11.
Sun, Jun 16, 9:18 AM · Konsole

Yesterday

mglb added a comment to D20816: Configure Konsole dialog GUI redesign.

qt5 SUSEQt5.10/src/settings/ProfileSettings.cpp:512:26: error: ���class QFontMetrics��� has no member named ���horizontalAdvance���

Sat, Jun 15, 5:28 PM · VDG, Konsole
mglb added a comment to T10046: Improve the colors, color consistency and colorscheme compatibility of Breeze.
  • darker highlight color in Breeze Dark means we needed changed icons -> new folder icons would be a must, but other icons using Plasma Blue should be changed as well
Sat, Jun 15, 12:34 PM · KDE Human Interface Guidelines, VDG, Plasma, Breeze
mglb added a comment to T10201: Window titlebars.

What would this look like in a language that isn't LTR? Would it be better to maybe have it on the right side in that case?

Sat, Jun 15, 11:49 AM · KDE Applications, VDG
mglb added a comment to D21282: CSI 2J: Do not append current screen to history.

Note that ncurses devs recently decided to fix clear (https://bugzilla.gnome.org/show_bug.cgi?id=506438#c19), so on newer systems it will work even with current CSI2J behavior.
This lowers reasons behind this path to compatibility with clear in older systems and compatibility with xterm. If these goals are not important, the patch can be abandoned.

Sat, Jun 15, 11:31 AM · Konsole
mglb added a comment to T10870: Consider using colorful rather than monochrome icons for small places, devices, and mimetype icons.

Anyway consider that any change to mimetype icons imply a lot of work.

Scripting! <3 At least with some designs, like yours or mine

Sat, Jun 15, 11:00 AM · VDG
mglb updated the diff for D20816: Configure Konsole dialog GUI redesign.
  • Fix radio button name
  • Add short info about profile shortcuts and visibility
  • Add kuit tags
  • Use modified QKeySequenceEdit for shortcut editing.
  • Use disabled text color for non visible profile's shortcut text
Sat, Jun 15, 10:41 AM · VDG, Konsole

Wed, Jun 12

mglb added a comment to T10201: Window titlebars.

Edit: here there is a mockup, the title bar height is the same, the icons are smaller and the clickable area is bigger and change background color when hovering. It feels better to me:

Wed, Jun 12, 2:47 PM · KDE Applications, VDG

Tue, Jun 11

mglb added a comment to T10201: Window titlebars.

I would like my desktop to simply tolerate applications with different interfaces.pHow about a simple approach to preserve such interfaces: Count the number of toolbar rows, and only darken the toolbars if they are not more than 2 or 3 rows. Otherwise, only darken the menubar.

Tue, Jun 11, 3:20 PM · KDE Applications, VDG

Mon, Jun 10

mglb added a comment to T11052: Accent Colors, Color Ramps and other improvements to theming..

Yes yes yes!

Mon, Jun 10, 10:54 PM · Plasma, VDG
mglb added a comment to T10891: Breeze theme evolution.

Here's another idea I've heard bandied about: create new "whitespace" and "expanding whitespace" items that can be added to toolbars so it's possible to have layouts of toolbar buttons that are centered or justified rather than left-aligned, and that use whitespace to separate logical groups rather than vertical separators. macOS has had this for ages and it results in some very aesthetically pleasing toolbars IMO:

Mon, Jun 10, 10:32 PM · VDG, Breeze
mglb added a comment to T10997: Improve check box design.

+1 for using a checkmark instead of a sqare. (Although I like the animation of folding and unfolding the sqare.)

Mon, Jun 10, 5:50 PM · VDG, Breeze

Fri, May 31

mglb updated the diff for D20816: Configure Konsole dialog GUI redesign.
  • Fix changing favorite status in profile list
  • Move profile's pointer to separate hidden column
  • Remove nonexisting friend class
  • Minor changes in UI strings
  • Improve columns width in profiles list
Fri, May 31, 3:03 PM · VDG, Konsole

Wed, May 29

mglb added a comment to D20816: Configure Konsole dialog GUI redesign.

Hmm... right. I was doing some improvements in the code, but they can go into another review.
I'll update this tomorrow.

Wed, May 29, 9:04 AM · VDG, Konsole
mglb added a comment to T10997: Improve check box design.

The "Indeterminate" state is most often represented by a square. Maybe we should do the same? That being said I didn't find a location where this state is actually used.

Wed, May 29, 9:04 AM · VDG, Breeze

Mon, May 27

mglb updated the task description for T10891: Breeze theme evolution.
Mon, May 27, 8:09 PM · VDG, Breeze
mglb updated the task description for T10997: Improve check box design.
Mon, May 27, 8:08 PM · VDG, Breeze
mglb updated the task description for T10997: Improve check box design.
Mon, May 27, 8:06 PM · VDG, Breeze
mglb created T10997: Improve check box design.
Mon, May 27, 8:05 PM · VDG, Breeze

Sun, May 26

mglb added a comment to T10891: Breeze theme evolution.

As for buttons and line edits with centered text, there could be something inside the latter that shows they're not buttons, like a button to clear the text. OSX shows it differently, by putting small lines on the sides of the line edits, with no clear text button.

Sun, May 26, 8:37 AM · VDG, Breeze

Sat, May 25

mglb added a comment to T10891: Breeze theme evolution.

Since I saw those crude mockups, I've been changing it with the suggestions I wanted to make plus others. It takes some pages taken from how other DEs do their things and some of my own preferences, while at least still trying to not deviate too wildly from the Plasma look. I've also combined it with some suggested changes to the current system settings application.

{F6844666}

(Text is a bit cut off at the end. It meant to say "as changes would be applied immediately")

Most of the reasons for the changes are to the side of the mockup. I wanted to include some other comments, like how child areas need to look more distinct from their parents (It was one of the linked reddit post's complaints: https://i.imgur.com/sJ0zE6b.png), but for now...

Sat, May 25, 1:35 AM · VDG, Breeze

Tue, May 21

mglb added a comment to T10891: Breeze theme evolution.

Would it be possible in this evolution to explore more streamlined spin boxes? I have always felt, our current version mixes the control with the content and it would probably be cooler to have them look separate. Maybe more like this:

https://images.app.goo.gl/TmNs1cWBrH2oyiRc7

Or this

https://images.app.goo.gl/PLed1isQZcSMwGiE9

Tue, May 21, 11:58 PM · VDG, Breeze

Mon, May 20

mglb added a comment to T10891: Breeze theme evolution.

Checkboxes look nice, but they don't match other elements - everything else uses basic shapes, and the check mark on OK button is quite different.

Mon, May 20, 4:52 PM · VDG, Breeze

Sun, May 19

mglb requested review of D21282: CSI 2J: Do not append current screen to history.
Sun, May 19, 1:06 AM · Konsole

May 16 2019

mglb added a comment to D21055: Highlight lines coming into view when scrolling.

Maybe like this?


Fading out solves additional use cases:

  • something sometimes outputs always the same line (debug message) to a terminal. Does it spams the line in a loop right now, or I'm looking at previous lines? (for this the feature would need to work for new lines too)
  • Repeated scrolling is distinguishable
May 16 2019, 1:45 AM · Konsole

May 4 2019

mglb added a comment to D20816: Configure Konsole dialog GUI redesign.
  1. The Manage Profile page still needs the info 'The Show column must be checked for these shortcuts to work' until it gets fixed.
May 4 2019, 4:54 PM · VDG, Konsole
mglb updated the diff for D20816: Configure Konsole dialog GUI redesign.

Fix issues from Nate's comments

May 4 2019, 4:54 PM · VDG, Konsole

May 3 2019

This is a test notification, sent at Fri, May 3, 20:52.
May 3 2019, 6:52 PM
This is a test notification, sent at Fri, May 3, 20:52.
May 3 2019, 6:52 PM
This is a test notification, sent at Fri, May 3, 20:51.
May 3 2019, 6:51 PM
mglb added a comment to T10870: Consider using colorful rather than monochrome icons for small places, devices, and mimetype icons.

Is it possible (without hacks or per-application changes) to make icons colorful in a view and monochrome in a panel?

May 3 2019, 10:43 AM · VDG
mglb added a comment to D20816: Configure Konsole dialog GUI redesign.
  1. "Rename "File Location" to "Temporary Files" - this page probably will be removed (D20466)" - This isn't going to be removed - there are valid reasons to allow users to change the file locations.
May 3 2019, 8:19 AM · VDG, Konsole

Apr 25 2019

mglb added a comment to T10384: Unify styles for lists and their buttons.

Also rather than cramming and going icon only, I think there's room to make use of the space and stack actions vertically within the list view like this:

that then shares a familiar pattern with the actions in Kirigami's sidebar

Apr 25 2019, 3:05 PM · Kirigami, KDE Human Interface Guidelines, VDG
mglb updated the summary of D20816: Configure Konsole dialog GUI redesign.
Apr 25 2019, 2:48 PM · VDG, Konsole
mglb updated the summary of D20816: Configure Konsole dialog GUI redesign.
Apr 25 2019, 2:38 PM · VDG, Konsole
mglb requested review of D20816: Configure Konsole dialog GUI redesign.
Apr 25 2019, 2:38 PM · VDG, Konsole

Apr 23 2019

mglb added a comment to D20744: [WIP] Apply new window flags only when necessary.

Sure, when missing parts will be implemented or when we decide to not implement them.

Apr 23 2019, 5:01 PM · Konsole

Apr 22 2019

mglb requested review of D20744: [WIP] Apply new window flags only when necessary.
Apr 22 2019, 6:21 PM · Konsole
mglb added a comment to D17865: Show valid subprocess CWD for %D tab title format.

Maybe just implement it using another letter? I guess both implementations have its fans

Apr 22 2019, 6:17 PM · Konsole

Apr 19 2019

mglb added a watcher for KDE Human Interface Guidelines: mglb.
Apr 19 2019, 10:48 PM

Apr 18 2019

mglb added a comment to D20439: Fix alignment boundary.

width type can be changed to int in order to fix this without reordering members.
The file is generated, so this should be changed also in the template.

Apr 18 2019, 11:04 PM · Konsole

Apr 12 2019

mglb added a comment to D20466: Rework scrollback settings.

And maybe rename labels in this style (someone with better english skills than I should verify this):

  • Fixed size → In memory, size:
  • Unlimited → On filesystem: (or "Unlimited, on filesystem:"?) + remove "history file location" label
  • Custom → Other
Apr 12 2019, 8:15 PM · Konsole
mglb added a comment to D20466: Rework scrollback settings.

After thinking about scrollback a bit more I think history file path AND scrollback size should go to global settings. Does anyone use different profiles with different history sizes, or change size just for current session?

Apr 12 2019, 4:09 PM · Konsole

Apr 11 2019

mglb added a comment to D20466: Rework scrollback settings.

I tougth about showing the paths but my first tougth was “why do the user
cares where this is being stored”?

If they doesn't care, why give them ability to change the location?
User might not know exactly what "system" and "user" location is (/tmp might be obvious, ~/.cache/konsole not so much), and on which partition it will eventually end (in case of weird partitioning).

Apr 11 2019, 8:17 PM · Konsole
mglb added a comment to T10783: Right-click on touch.
In T10783#181580, @mglb wrote:

As for right click/context menu... Swipe down/up from an element?

Apr 11 2019, 4:47 PM · Plasma, VDG
mglb added a comment to T10783: Right-click on touch.

What do you think about changing the task to be about all touch actions (and what actions we want to have)? Asking too precise questions will lead to "ok lets use A for X" and later, in another task "no, we can't use A for this, X uses it".

Apr 11 2019, 8:15 AM · Plasma, VDG

Apr 9 2019

mglb added a comment to D20410: Display the settings as List instead of Tab.

I'm working on settings dialog, i'll try to upload a wip version this week. There is a problem with the fact that parts of KF5 are outdated, e.g. Kconfigdialog wraps every page in qscrollarea and kconfigdialogmanager does not support button groups.
I've (almost) implemented missing parts in Konsole for now and I'll fix it in KF5 later. The code in Konsole will allow to release it in 19.08 without bumping required kf5 version too high. When bumping will be ok it is easy to replace custom Konsole code with kf5 api.

Apr 9 2019, 6:31 PM · Konsole

Apr 6 2019

mglb added a comment to D18352: Remember last output save directory.

Sorry, I've missed Url in setDirectoryUrl :/

Apr 6 2019, 7:45 PM · Konsole

Apr 5 2019

mglb added reviewers for D20263: [WIP] Keep perceived contrast in random background color: Konsole, VDG.
Apr 5 2019, 12:45 PM · VDG, Konsole
mglb requested review of D20263: [WIP] Keep perceived contrast in random background color.
Apr 5 2019, 12:33 PM · VDG, Konsole

Apr 4 2019

mglb added a comment to D18352: Remember last output save directory.

@hindenburg why is URL a list when only one entry is used? With string type homePath() could be used in readPathEntry as default value, making if...else... redundant.

Apr 4 2019, 11:34 PM · Konsole
mglb added a comment to T10402: The Desktop Toolbox.

Another option:

Apr 4 2019, 10:56 PM · Plasma, VDG
mglb added a comment to T10402: The Desktop Toolbox.

When we're at the possibility of "how to restore default panels when someone messes up things or remove all panels", why not add the option of restoring desktop/panel defaults to the desktop context menu? Of course, there would have to be confirmation pop-up (like: do you really want to do it, this action is irreversible and will bring your desktop space to default setup).

Apr 4 2019, 3:18 PM · Plasma, VDG

Apr 3 2019

mglb added a comment to T10402: The Desktop Toolbox.

I agree. Unfortunately it's not so easy. See https://bugs.kde.org/show_bug.cgi?id=391485

Apr 3 2019, 8:54 PM · Plasma, VDG

Mar 29 2019

mglb added a comment to T10402: The Desktop Toolbox.
  1. An escape value if you destroy the UI by accident (e.g. by deleting the default panel) without needing to right-click
Mar 29 2019, 8:32 AM · Plasma, VDG

Mar 21 2019

mglb added a comment to T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG.

Are you aware that we're losing the Alt+Key focusing on the text input provided by Label->text buddy functionality? I think it's really bad that we're regressing on this accessibility feature.

Mar 21 2019, 3:15 AM · VDG, Plasma
mglb updated the diff for D19859: Fix undefined behavior and set QT_MIN_VERSION to 5.9.0.

Update description

Mar 21 2019, 2:21 AM · Konsole
mglb added a comment to D19859: Fix undefined behavior and set QT_MIN_VERSION to 5.9.0.

To get it compile w/ 5.9.4, I have to comment out all the QCOMPAREs - I thought I tested this w/ 5.9.7 but I appear to have upgraded my VMs

src/autotests/KeyboardTranslatorTest.cpp:112: error: undefined reference to 'bool QTest::qCompare<Qt::Key, int>(Qt::Key const&, int const&, char const*, char const*, char const*, int)'

Mar 21 2019, 2:19 AM · Konsole
mglb updated the diff for D19859: Fix undefined behavior and set QT_MIN_VERSION to 5.9.0.
  • Fix argument types in QCOMPARE (fixes builds)
  • Update description
Mar 21 2019, 2:19 AM · Konsole

Mar 18 2019

mglb requested review of D19859: Fix undefined behavior and set QT_MIN_VERSION to 5.9.0.
Mar 18 2019, 3:54 PM · Konsole

Mar 15 2019

mglb added a comment to D19266: Fix "Draw intense colors in bold font" feature.

@ngraham this is something else (styleName is handled in the patch). The fonts and their styles are not linked correctly, so we have fonts/styles:

Mar 15 2019, 11:10 PM · Konsole
mglb added a comment to D19266: Fix "Draw intense colors in bold font" feature.

Is this QT related issue then?

Most likely - when you open font selector in any Qt app, Plex Mono font has only 4 basic styles. To get "text" style you'll have to use Plex Mono Text font (and there is no bold).

Mar 15 2019, 11:27 AM · Konsole

Mar 12 2019

mglb added a comment to D19266: Fix "Draw intense colors in bold font" feature.

https://fonts.google.com/specimen/IBM+Plex+Mono this one?

Mar 12 2019, 9:08 AM · Konsole

Mar 2 2019

mglb requested review of D19484: Compare floats in a reliable way.
Mar 2 2019, 9:30 PM · Konsole
mglb added a comment to D17744: New search result look, resurrected.

@ngraham wrong review :)

Mar 2 2019, 9:10 PM · Konsole
mglb added inline comments to D17742: Clean up content rect in TerminalDisplay.
Mar 2 2019, 8:49 PM · Konsole
mglb abandoned D17867: Remove leftover ifdefs for (unsupported) Windows.

Abandoning it then

Mar 2 2019, 7:54 PM · Konsole

Mar 1 2019

mglb added a comment to D19364: [sddm-theme/lock screen] Add shadows to action buttons.

What about adding the same shadow under icons? Otherwise it looks like a text floating above flat background.

Mar 1 2019, 11:11 AM · Plasma

Feb 28 2019

mglb added a watcher for VDG: mglb.
Feb 28 2019, 4:40 PM

Feb 27 2019

mglb updated the diff for D19400: Resize Edit Profile dialog only when possible.

Restore normal value

Feb 27 2019, 10:09 PM · Konsole
mglb requested review of D19400: Resize Edit Profile dialog only when possible.
Feb 27 2019, 10:06 PM · Konsole

Feb 26 2019

mglb added inline comments to D17244: Edit Profile Dialog UI redesign.
Feb 26 2019, 11:03 PM · Konsole
mglb added inline comments to D17244: Edit Profile Dialog UI redesign.
Feb 26 2019, 9:39 AM · Konsole

Feb 25 2019

mglb closed D19269: Minor cleanup/optimizations in font changing code.

Pushed to master

Feb 25 2019, 5:10 AM · Konsole
mglb added a comment to D19266: Fix "Draw intense colors in bold font" feature.

A minor nitpick, if you're going to format the comments, try for < 80 column width - typically 70ish is better.

Feb 25 2019, 5:09 AM · Konsole
mglb committed R319:5a5da130c1e4: Do not filter out "too big" font sizes. (authored by mglb).
Do not filter out "too big" font sizes.
Feb 25 2019, 5:06 AM
mglb committed R319:411428baa8bd: Remove pointless checks in font match test (authored by mglb).
Remove pointless checks in font match test
Feb 25 2019, 5:06 AM
mglb committed R319:faffce94cdb0: Call a function with actual line spacing updating code (authored by mglb).
Call a function with actual line spacing updating code
Feb 25 2019, 5:06 AM
mglb committed R319:ab6cca053508: Do not process font that didn't change (authored by mglb).
Do not process font that didn't change
Feb 25 2019, 5:06 AM

Feb 24 2019

mglb added a comment to D19266: Fix "Draw intense colors in bold font" feature.

Depends on your opinion. As for me:

  • It is nice that we get all possible information about what an user selected in the font dialog - we can remove/change things we don't need/support.
  • The style name allows for most precise (afaik) style specification. Technically, there can exist two styles, with the same weight, stretch, etc, but different glyphs. However, Qt should unset styleName after manual change of particular style properties. It doesn't, so we need to do it manually (this can be considered the problem to which the patch is a workaround).
Feb 24 2019, 8:29 AM · Konsole
mglb requested review of D19269: Minor cleanup/optimizations in font changing code.
Feb 24 2019, 2:00 AM · Konsole

Feb 23 2019

mglb updated the diff for D19266: Fix "Draw intense colors in bold font" feature.

Fix diff

Feb 23 2019, 11:21 PM · Konsole
mglb retitled D19266: Fix "Draw intense colors in bold font" feature from For MacOS portion, use nullptr instead of NULL to Fix "Draw intense colors in bold font" feature.
Feb 23 2019, 11:17 PM · Konsole
mglb requested review of D19266: Fix "Draw intense colors in bold font" feature.
Feb 23 2019, 11:16 PM · Konsole

Feb 22 2019

mglb committed R319:650af4f78b9b: Replace assert with Q_ASSERT (authored by mglb).
Replace assert with Q_ASSERT
Feb 22 2019, 6:31 PM
mglb committed R319:286958f5fe10: Replace assert with Q_ASSERT (authored by mglb).
Replace assert with Q_ASSERT
Feb 22 2019, 6:26 PM
mglb committed R319:13132fc77bf9: Improve built-in line/block characters drawing (authored by mglb).
Improve built-in line/block characters drawing
Feb 22 2019, 5:52 PM
mglb closed D18735: Improve built-in line/block characters drawing.
Feb 22 2019, 5:52 PM · Konsole
mglb updated the diff for D18735: Improve built-in line/block characters drawing.

rebase master

Feb 22 2019, 4:40 PM · Konsole

Feb 15 2019

mglb added a comment to D18784: Extend character clipping by grouping it with spaces.

I think it should be as it is now - user will see that a space, not a symbol, is selected.

Feb 15 2019, 6:38 PM · Konsole

Feb 12 2019

mglb updated the diff for D18735: Improve built-in line/block characters drawing.

Restore/fix copyrights

Feb 12 2019, 10:39 PM · Konsole

Feb 10 2019

mglb added inline comments to D18735: Improve built-in line/block characters drawing.
Feb 10 2019, 12:54 AM · Konsole
mglb updated the diff for D18735: Improve built-in line/block characters drawing.

More more descriptive names

Feb 10 2019, 12:54 AM · Konsole
mglb updated the diff for D18735: Improve built-in line/block characters drawing.

autobool

Feb 10 2019, 12:30 AM · Konsole
mglb updated the summary of D18735: Improve built-in line/block characters drawing.
Feb 10 2019, 12:16 AM · Konsole
mglb updated the diff for D18735: Improve built-in line/block characters drawing.

Update description

Feb 10 2019, 12:15 AM · Konsole
mglb updated the diff for D18735: Improve built-in line/block characters drawing.

Fix suggested problems

Feb 10 2019, 12:14 AM · Konsole

Feb 9 2019

mglb added a comment to D18735: Improve built-in line/block characters drawing.

@sandsmark I'll take care of your remarks (probably) today

Feb 9 2019, 7:48 AM · Konsole
mglb added inline comments to D18735: Improve built-in line/block characters drawing.
Feb 9 2019, 4:02 AM · Konsole
mglb updated the summary of D18735: Improve built-in line/block characters drawing.
Feb 9 2019, 3:23 AM · Konsole