mglb (Mariusz Glebocki)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Feb 28 2018, 11:25 PM (93 w, 1 d)
Availability
Available

Recent Activity

Thu, Dec 5

mglb committed R319:38def9a3a297: Fix possible null pointer dereference (authored by mglb).
Fix possible null pointer dereference
Thu, Dec 5, 3:15 AM

Tue, Nov 26

mglb added a comment to T11662: Improve visual appeal for KUrlNavigator when in Breadcrumbs mode.

Right now you can't even draw this connection nicely using QStyle.

What do you mean? Qt accepts CSS to style elements so I'm pretty sure it's possible to draw some very nice custom elements with Qt.

Tue, Nov 26, 9:15 PM · Breeze, VDG
mglb committed R319:686a14da0d54: Reconnect SessionController dropped from another window (authored by mglb).
Reconnect SessionController dropped from another window
Tue, Nov 26, 7:02 PM
mglb committed R319:8df48a8f71db: Remove SessionController from the factory during deletion (authored by mglb).
Remove SessionController from the factory during deletion
Tue, Nov 26, 2:25 PM
mglb added a comment to T11662: Improve visual appeal for KUrlNavigator when in Breadcrumbs mode.
In T11662#211545, @mglb wrote:

I understand, but I was referring to following mockup, where the button has input field background, so I perceive it as in-field icon like "clear" with separator :)

Connected button outside is technically OK, but... not in Breeze style. So either we change it everywhere, or add little spacing between input field and button. Right now you can't even draw this connection nicely using QStyle.

Most of the styling on that widget is custom right now, so it wouldn't be any worse if we kept it custom.

Tue, Nov 26, 4:32 AM · Breeze, VDG
mglb added a comment to T11662: Improve visual appeal for KUrlNavigator when in Breadcrumbs mode.

I understand, but I was referring to following mockup, where the button has input field background, so I perceive it as in-field icon like "clear" with separator :)

Tue, Nov 26, 3:57 AM · Breeze, VDG

Mon, Nov 25

mglb added a comment to T11662: Improve visual appeal for KUrlNavigator when in Breadcrumbs mode.

I'm very much in favor of having a dedicated button to enter edit mode.

Mon, Nov 25, 6:43 PM · Breeze, VDG

Sat, Nov 23

mglb added a comment to T11662: Improve visual appeal for KUrlNavigator when in Breadcrumbs mode.
  • Don't do straight vertical separators + arrow down - it looks like favorites list or something, not ordered hierarchy.
  • > doesn't make sense when placed after directory name - it means something like "next directory is...", and clicking it should modify directory on the right of the arrow.
  • Don't highlight arrow and label like it is a single thing - it is not. Clicking label has different action than clicking arrow.
  • Don't make last item (current directory) clickable/highlightable - clicking it does nothing.
Sat, Nov 23, 9:12 PM · Breeze, VDG

Fri, Nov 22

mglb committed R319:78b8b4c7a643: Change title of control characters filter window (authored by mglb).
Change title of control characters filter window
Fri, Nov 22, 2:25 PM
mglb committed R319:0b36d0aa82a9: Rename buttons in control characters filter window (authored by mglb).
Rename buttons in control characters filter window
Fri, Nov 22, 2:25 PM
mglb committed R319:3c3ec56d8bcb: Change control characters descriptions (authored by mglb).
Change control characters descriptions
Fri, Nov 22, 2:25 PM
mglb committed R319:5e142c9dadc8: Do not warn when pasting non-dangerous characters (authored by mglb).
Do not warn when pasting non-dangerous characters
Fri, Nov 22, 2:25 PM
mglb added a comment to T11662: Improve visual appeal for KUrlNavigator when in Breadcrumbs mode.

The biggest problem that I see with the breadcrumbs receiving a new coat of paint with pointy or slanted lines would be the fact that it's a UI element that doesn't exist in vanilla KDE anywhere else in that form. At least I can't think of where it shows up, but please correct me if that is wrong. Taking Gestalt theory into consideration, this might be bad UX as it exposes users to new elements that are unique to that one location.

Fri, Nov 22, 12:16 AM · Breeze, VDG

Wed, Nov 20

mglb added a comment to T11662: Improve visual appeal for KUrlNavigator when in Breadcrumbs mode.

What does this arrow-down near desktoptheme do?

Wed, Nov 20, 11:22 PM · Breeze, VDG
mglb added a comment to T11662: Improve visual appeal for KUrlNavigator when in Breadcrumbs mode.


Isn't it cleaner to just have straight lines?

Wed, Nov 20, 10:45 PM · Breeze, VDG

Sat, Nov 16

mglb added a comment to T10201: Window titlebars.

If so, Kirigami can be modified to work as needed.

Sat, Nov 16, 8:45 PM · KDE Applications, VDG
mglb added a comment to D25337: Change transparency to 10% and added blur.

Default text color and this new background blended with white still has good contrast, but it doesn't look so good when colored text is used (not that it looks perfect now).
Also, please consider how it looks with transparency but without blur (as it does not work everywhere). It can be distracting.
Konsole is sometimes used for hours for looking at text, so it have to be readable by default.

Sat, Nov 16, 8:16 PM · Konsole

Nov 12 2019

mglb added a comment to T10201: Window titlebars.

Why (assuming it would be possible to disable it)?
Example use case: there is optional feature in Konsole which randomly adjusts foreground and background colors in each session (hue and saturation; perceived lightness is kept constant). It helps with finding specific window/session, as it is easier to find window tinted to specific color than looking at content/title (when it is similar), especially when window is scaled down (present windows effect). It could be nice to extend this adjustment to whole window (and titlebar), of course with user consent.
We make titlebars blended with window for consistency, and because it looks nice. Does it make sense to prevent similar consistency with application which uses different colors (e.g. web browser)?

Nov 12 2019, 5:47 PM · KDE Applications, VDG
mglb added a comment to T10201: Window titlebars.

Application Style

Nov 12 2019, 3:45 AM · KDE Applications, VDG

Nov 10 2019

mglb added a comment to T10997: Improve check box design.

Color scheme issue. Highlight background color is used. I could change it to something like background color of selected item in unfocused sidebar, but then it won't look that good in light Breeze.

Nov 10 2019, 11:53 PM · VDG, Breeze
mglb added a comment to T10997: Improve check box design.

Commit dab7fdd with current Breeze/Breeze Dark color schemes:


Nov 10 2019, 11:26 PM · VDG, Breeze
mglb committed R31:dab7fddd25cc: Blend checked checkbox frame with WindowText color (authored by mglb).
Blend checked checkbox frame with WindowText color
Nov 10 2019, 11:26 PM
mglb committed R31:d52eab4a0277: Use blue background in checked checkboxes/radios (authored by mglb).
Use blue background in checked checkboxes/radios
Nov 10 2019, 11:10 PM
mglb committed R31:f72b303fc34e: Refactoring leftovers (authored by mglb).
Refactoring leftovers
Nov 10 2019, 11:10 PM
mglb added a comment to T10997: Improve check box design.
In T10997#207688, @mglb wrote:

I have to be honest here though: I'm having second thoughts about losing the blue background for the checked checkboxes and radio buttons. I think it makes them fade into the background more (especially with Breeze Dark)

Why should they stand out more than other controls?

Nov 10 2019, 9:52 PM · VDG, Breeze
mglb added a comment to T11979: KDE neon's Welcome Screen.

There are two groups of new users:

  • Those who install the system and use it later:
    • All this stuff should be available when the system installs itself. Users have to wait until it completes anyway, so this is probably the best moment.
    • If they had something better to do during installation, they are self-confident enough to find "New user guide", "Help" or something in application launcher.
  • Those who get already installed system:
    • Important option to have: language/region selector. I think many devices with Linux/KDE come from smaller companies, which don't have large official distributors in each region, so the system uses US English by default. The first thing we should do for people who don't know English is to talk to them in their language (and don't confuse them with inverted date format :) ).
    • You probably want to give them possibility to change their name/login, password.
Nov 10 2019, 9:29 PM · VDG
mglb added a comment to T10997: Improve check box design.

I have to be honest here though: I'm having second thoughts about losing the blue background for the checked checkboxes and radio buttons. I think it makes them fade into the background more (especially with Breeze Dark)

Nov 10 2019, 4:14 PM · VDG, Breeze
mglb added a comment to T10997: Improve check box design.

Going back to this. From visible things: implemented drawing of checkboxes/radios in menus; selected list items have checkboxes with hover&focus style.

Nov 10 2019, 3:32 AM · VDG, Breeze
mglb committed R31:4c3bd3122133: Draw check box/radio in menus (authored by mglb).
Draw check box/radio in menus
Nov 10 2019, 3:21 AM
mglb committed R31:7ff5eca01cfe: Change partial→on transition (authored by mglb).
Change partial→on transition
Nov 10 2019, 3:21 AM
mglb committed R31:6c2a5fd4effd: Refactoring, mainly animations (authored by mglb).
Refactoring, mainly animations
Nov 10 2019, 3:21 AM
mglb committed R31:c70c5856758d: Extract checkmark drawing to a function (authored by mglb).
Extract checkmark drawing to a function
Nov 10 2019, 3:21 AM
mglb committed R31:caa96e54b5b3: Remove commented code (authored by mglb).
Remove commented code
Nov 10 2019, 3:21 AM
mglb committed R31:9d81981c5147: Merge Timeline and TimelineAnimation (authored by mglb).
Merge Timeline and TimelineAnimation
Nov 10 2019, 3:21 AM
mglb committed R31:9917a2b97b83: Remove unused PropertyWrapper (authored by mglb).
Remove unused PropertyWrapper
Nov 10 2019, 3:21 AM
mglb added a comment to T11999: Unify search in applications.

There's also floating search bar in Konsole:


It have to stay floating and on top, but its contents can be changed if needed.

Nov 10 2019, 12:12 AM · VDG, Goal: Consistency

Nov 9 2019

mglb updated the diff for D25123: [WIP] New yakuake logo/icon.

switching to that system means we would need to change many icons.

Nov 9 2019, 8:00 PM · Yakuake, Frameworks

Nov 7 2019

mglb updated the test plan for D25151: Fix tabs not indicating activity.
Nov 7 2019, 2:07 PM · Konsole

Nov 4 2019

mglb added a comment to D25123: [WIP] New yakuake logo/icon.

I tried seeing how it would look extended down to the bottom margin:

Nov 4 2019, 3:18 AM · Yakuake, Frameworks

Nov 3 2019

mglb committed R319:a12359507f54: Fix copyrights (authored by mglb).
Fix copyrights
Nov 3 2019, 3:47 PM
mglb committed R319:cee2b30d1360: Fix code documentation (authored by mglb).
Fix code documentation
Nov 3 2019, 3:47 PM
mglb abandoned D24621: [RFC] New Konsole and Yakuake icons.

Yakuake icon moved to: https://phabricator.kde.org/D25123

Nov 3 2019, 1:36 AM · Frameworks
mglb requested review of D25123: [WIP] New yakuake logo/icon.
Nov 3 2019, 1:30 AM · Yakuake, Frameworks

Nov 2 2019

mglb added a comment to D24621: [RFC] New Konsole and Yakuake icons.

I'll do the split today or tomorrow.

Nov 2 2019, 6:03 PM · Frameworks

Oct 31 2019

mglb added a comment to T11950: Reduce the pain of working on monochrome Breeze icons.

Inserting and applying styles can be done with icon template file with predefined swatches. Swatches (which are internally one-stop gradients) would be converted into style later with a script. Not trivial (i.e. not one line sed) to write due to indirect gradient use in inkscape, but also not really hard. Xml parser is the way to go. For extra newbie-friendly solution, "save as monochrome breeze svg" extension could be made.
From designer point of view use is really simple - in fill and stroke dock click "swatch" type and pick named color from a list.

Oct 31 2019, 11:23 PM · Frameworks, VDG
mglb added a comment to D21055: Highlight lines coming into view when scrolling.

This looks really nice and would indeed make this patch useful in the case of scrolling. But fading based on a timer would kill the main feature I see in this: having a visual reference to be able to see what has moved. Maybe we have to find something in between the original proposal and this. What do you think ?

Oct 31 2019, 1:54 AM · Konsole

Oct 27 2019

mglb committed R319:51bcb2ebd4da: Reduce code duplication in session creating code (authored by mglb).
Reduce code duplication in session creating code
Oct 27 2019, 7:46 PM
mglb committed R319:a4c2ea7c2d33: Change option label in Edit Profile Dialog (authored by mglb).
Change option label in Edit Profile Dialog
Oct 27 2019, 7:46 PM
mglb committed R319:a16a6189efe2: Start new splits in same directory as current session (authored by mglb).
Start new splits in same directory as current session
Oct 27 2019, 7:46 PM
mglb committed R319:d7313b1083b3: Simplify setCurrentSession() (authored by mglb).
Simplify setCurrentSession()
Oct 27 2019, 7:46 PM
mglb committed R319:3be8a1482443: DBusTest: Do not verify exit status (authored by mglb).
DBusTest: Do not verify exit status
Oct 27 2019, 7:35 PM
mglb committed R319:2cda4fb1f37f: Fix currentSession() (authored by mglb).
Fix currentSession()
Oct 27 2019, 7:35 PM
mglb committed R319:0c483b6785f6: Change DBus functions order (authored by mglb).
Change DBus functions order
Oct 27 2019, 7:35 PM
mglb committed R319:eb9fc4c8bb8d: DBusTest: Add test for Window interface methods (authored by mglb).
DBusTest: Add test for Window interface methods
Oct 27 2019, 7:35 PM
mglb committed R319:7f460ea559b1: DBusTest: Do not show popup when closing multiple tabs (authored by mglb).
DBusTest: Do not show popup when closing multiple tabs
Oct 27 2019, 7:35 PM
mglb committed R319:42a972b3d35b: DBusTest: Use correct enum in title/setTitle (authored by mglb).
DBusTest: Use correct enum in title/setTitle
Oct 27 2019, 7:35 PM
mglb added a comment to D24975: Change some 32px action icons to color style.

Why do you replace action icons instead of adding separate colorful icons for use in preference dialogs? Right now all action icons are "monochrome", making few of them colorful will introduce inconsistency.

Oct 27 2019, 12:18 PM · Frameworks

Oct 25 2019

mglb committed R319:0699c1553f64: Search bar: Activate focused button when enter is pressed (authored by mglb).
Search bar: Activate focused button when enter is pressed
Oct 25 2019, 2:05 AM
mglb committed R319:d0deb3a1ba1c: Search bar: Handle Esc key in IncrementalSearchBar (authored by mglb).
Search bar: Handle Esc key in IncrementalSearchBar
Oct 25 2019, 2:05 AM
mglb committed R319:c4f56a893ab6: Search bar: Fix widgets creation order (authored by mglb).
Search bar: Fix widgets creation order
Oct 25 2019, 2:04 AM
mglb committed R319:1ad5a85cfc91: Search bar: Enable widget focus switching (authored by mglb).
Search bar: Enable widget focus switching
Oct 25 2019, 2:04 AM

Oct 16 2019

mglb added a comment to T11817: Make keyword parsing hook script intelligent enough to parse multiple keywords on one line.

There is no merge commit when it is not necessary, and commits are not usually squashed (at least in Konsole, quick look at Okular says the same), so a MR author should put the keywords in one of the commits. You can check commits on a branch (or in commits tab in merge request) and ask commiter to fix commit descriptions. However, force-push is not allowed in some cases, so that might be impossible (IIRC).

Oct 16 2019, 7:56 PM
mglb committed R319:ef13a09e0178: Fix scrollbar position (authored by mglb).
Fix scrollbar position
Oct 16 2019, 1:37 AM

Oct 15 2019

mglb added a comment to T11817: Make keyword parsing hook script intelligent enough to parse multiple keywords on one line.

Gitlab's Merge Request description is not placed in a commit (at least when there is no merge commit, which is default). Each commit in merge request has its own independent description.
Please see "02 Oct, 2019 (5 commits)" in https://invent.kde.org/kde/okular/commits/master - this is the result of mentioned merge. Hooks didn't catch bug entries because they are not in commits.

Oct 15 2019, 10:42 PM

Oct 14 2019

mglb updated the summary of D24621: [RFC] New Konsole and Yakuake icons.
Oct 14 2019, 9:46 PM · Frameworks
mglb added a comment to D24621: [RFC] New Konsole and Yakuake icons.

Please note that Konsole icon is intended to be personalized icon/"logo" (see T10243).
The prompt symbol is thick as it is main symbol (like symbols in e.g Plasma, Akregator, Kile, "K" icons/logos) - the window-like background (or just square in var C) is just secondary addition.

Oct 14 2019, 9:44 PM · Frameworks
mglb updated the diff for D24621: [RFC] New Konsole and Yakuake icons.

Brighten background

Oct 14 2019, 8:38 PM · Frameworks

Oct 13 2019

mglb requested review of D24621: [RFC] New Konsole and Yakuake icons.
Oct 13 2019, 10:10 PM · Frameworks
mglb committed R266:898410aa5515: Update Yakuake icon (48px only) (authored by mglb).
Update Yakuake icon (48px only)
Oct 13 2019, 9:38 PM
mglb committed R266:7ad084bd276b: Add Konsole icon (48px) (authored by mglb).
Add Konsole icon (48px)
Oct 13 2019, 9:38 PM

Oct 12 2019

mglb added a comment to T10891: Breeze theme evolution.

Right one (larger shadow size). Plasma popups open above windows, yet they cast a lot smaller shadow than window shadow right now.

Oct 12 2019, 5:07 PM · Plasma, VDG, Breeze

Oct 11 2019

mglb added a comment to T10243: Some KDE applications could use better icons.

Yes, I'll create review soon

Oct 11 2019, 7:28 PM · KDE Applications, VDG

Oct 5 2019

mglb added a comment to T10243: Some KDE applications could use better icons.

As I said in another comment an example of problem in Inkscape is ">" symbol in Konsole 48x48px icon.

Oct 5 2019, 10:47 PM · KDE Applications, VDG
mglb committed R319:b35811084267: Add missing checkbox label on Edit Profile → Appearance page (authored by mglb).
Add missing checkbox label on Edit Profile → Appearance page
Oct 5 2019, 9:16 PM
mglb committed R319:ce2029ed75b6: Keep empty lines when "trim leading spaces" is enabled (authored by mglb).
Keep empty lines when "trim leading spaces" is enabled
Oct 5 2019, 8:15 PM

Oct 4 2019

mglb committed R319:6c2a2c0184a4: Bump sessionui.rc version (authored by mglb).
Bump sessionui.rc version
Oct 4 2019, 10:37 PM
mglb committed R319:8c6aaad3f77f: Remove "Close session" from context menu (authored by mglb).
Remove "Close session" from context menu
Oct 4 2019, 6:37 PM

Oct 2 2019

mglb committed R319:5e91383e3fc9: Make sure font weight value is within allowed range (authored by mglb).
Make sure font weight value is within allowed range
Oct 2 2019, 3:08 PM
mglb added a comment to T10997: Improve check box design.
In T10997#203309, @mglb wrote:

they have a visible area of 20px vs 16px for the older version.

Yes. Labels have similar height (with default font size), so UIs won't grow much (if at all) and distances between checkboxes/radios are now similar to distances between other controls.

They do? Is this including the margins?

Oct 2 2019, 6:17 AM · VDG, Breeze

Oct 1 2019

mglb added a comment to T10997: Improve check box design.

I noticed that the new checkboxes/radio buttons don't apply to menus

Oct 1 2019, 3:22 PM · VDG, Breeze

Sep 30 2019

mglb added a comment to T11714: Redesign kde.org homepage.

@mglb You didn't read my previous reply. As I said this is not the final version, the text is a placeholder, don't you all see lorem ipsum???

Sep 30 2019, 8:47 PM · VDG, KDE Promo, Websites
mglb added a comment to T11714: Redesign kde.org homepage.

It's beautiful, but not perfect.
As a guest, i see "Read more" buttons near different products, but i'm not interested to read it because it's hard to understand what it is.
Also i think it's kool to giving a different backgrounds to each selections, as @mglb said.

I think it makes only sense to have different backgrounds color, if there is a meaning behind it. For plasma desktop they were some distinct section with each a different wallpaper. In this case, I see less a need for it.

Sep 30 2019, 8:29 PM · VDG, KDE Promo, Websites

Sep 29 2019

mglb added a comment to T10997: Improve check box design.

I need some more time (~week) for fixes and cleanup.

Sep 29 2019, 10:08 PM · VDG, Breeze
mglb committed R31:cfabc1dbc31b: WIP: Rewrite Timeline stuff (authored by mglb).
WIP: Rewrite Timeline stuff
Sep 29 2019, 10:02 PM
mglb committed R31:8402449b66e9: Do not stop subanimations (authored by mglb).
Do not stop subanimations
Sep 29 2019, 10:02 PM
mglb committed R31:dc35222fa975: Handle subanimations synchronously in AnimationTimeline (authored by mglb).
Handle subanimations synchronously in AnimationTimeline
Sep 29 2019, 10:02 PM
mglb committed R31:b4ad6c0d1198: Animations fixes (authored by mglb).
Animations fixes
Sep 29 2019, 10:02 PM
mglb committed R31:d539ee93726b: Improve AnimationTimeline (authored by mglb).
Improve AnimationTimeline
Sep 29 2019, 10:02 PM
mglb committed R31:7ad2ed42f462: Convert all animations to animationtimeline (authored by mglb).
Convert all animations to animationtimeline
Sep 29 2019, 10:02 PM
mglb committed R31:1c46f1ba870c: Use AnimationTimeline for OffToOn (authored by mglb).
Use AnimationTimeline for OffToOn
Sep 29 2019, 10:02 PM
mglb committed R31:6d8ecd0eb353: Fix propertywrapper* (authored by mglb).
Fix propertywrapper*
Sep 29 2019, 10:02 PM
mglb committed R31:dbf6a03c1645: Move animation helpers to header file (authored by mglb).
Move animation helpers to header file
Sep 29 2019, 10:02 PM
mglb committed R31:e9d5a73cafca: Initial AnimationTimeline version (authored by mglb).
Initial AnimationTimeline version
Sep 29 2019, 10:02 PM
mglb committed R31:f15a8486421a: More readable/compact animation code (authored by mglb).
More readable/compact animation code
Sep 29 2019, 10:02 PM
mglb committed R31:48648a75e9af: Move WIP code to separate file for faster recompilations (authored by mglb).
Move WIP code to separate file for faster recompilations
Sep 29 2019, 10:02 PM
mglb committed R31:88184bb73a8d: Animated check box and radio button (authored by mglb).
Animated check box and radio button
Sep 29 2019, 10:02 PM

Sep 27 2019

mglb added a comment to T11714: Redesign kde.org homepage.

Thank you. Looks good!

Sep 27 2019, 3:20 PM · VDG, KDE Promo, Websites
mglb added a comment to T11714: Redesign kde.org homepage.

@vladimirmikulic can you put screenshot here?

Sep 27 2019, 2:24 PM · VDG, KDE Promo, Websites

Sep 25 2019

mglb added a comment to T10997: Improve check box design.
In T10997#201777, @GB_2 wrote:

I think we should start implementing this design now :-)

Sep 25 2019, 3:26 PM · VDG, Breeze

Sep 22 2019

mglb added a comment to T10243: Some KDE applications could use better icons.

EDIT: I have already said this here and there but please don't run any automated script to SVG icons, because when opening them back in Inkscape they are corrupted and everytime I edit a Breeze icon I have to do additional work to fix shapes and gradients corrupted by the scripts.

Sep 22 2019, 7:22 PM · KDE Applications, VDG