- User Since
- Apr 15 2015, 5:07 PM (179 w, 3 d)
Fri, Sep 21
Note: The "windows" KRunner plugin needs porting to libtaskmanager as well. However, we have a problem there: KRunner is a different process, and I guess it can't bind PlasmaWindowManagement too until we figure out the privileged protocol auth stuff. KWin/KWayland maintainers?
Thu, Sep 20
Fix wrong conditional.
Wed, Sep 19
Kill more unused stuff.
Remove another unused include.
After D15599 the "Switch Window" containment action also needs updating to changed libtaskmanager API. That will be next.
Mon, Sep 17
Sorry, one more lap: Can you verify that the bug addressed in https://commits.kde.org/yakuake/e2b603d16955561540b9c194c0844ec320fc2694 doesn't happen with your patch applied?
Sun, Sep 16
Looks good. Do you have a dev account or do we need someone to land this for you?
Thu, Sep 13
Sorry if this was posted before, but looks interesting: https://whatcanidoformozilla.org/
I'm super sorry, arc patch changed authorship somehow :( It randomly sometimes does and doesn't do this and I forgot to check
Since we're in the middle of doing tarballs and I know @broulik was anxious to get this in I'm going to be proactive and land it.
Simplify patch to only what's actually needed.
I'll commandeer this rev to fix up the patch. Sorry @sitter, but then we can get this into beta still.
This makes sense. In theory this is done by this code:
Wed, Sep 12
Yeah, sounds good for now.
Tue, Sep 11
Mon, Sep 10
Add conclusion to description. Done now, promise.
Add back Nate. Now I'm committed to using arc diff --verbatim, sorry. :P
Improve description further.
Fix typo in description.
Did you forget to update the diff?
Let's not bother with it then, thanks for looking into it.
If I understood things right, prior work made sure that deactivating a client via any means (alt-tab, opening KRunner, etc.) will break a clients' pointer constraint (and hopefully recreate it when the client gets activated again). And this patch removes the previous dedicated means to do so, long-pressing ESC, and the notification informing the user of this possibility.
Fri, Sep 7
Is it worth adding QQmlParserStatus to PlacesModel at this point?
Thu, Sep 6
Wed, Sep 5
Indeed. Sorry, I introduced a small bug with a fatal copy and paste mistake just before uploading.
Tue, Sep 4
And @phuongn, I'm guessing you set all of these options to disabling wrap-around, right?
This patch is good, but I share Kai's concern that it's perhaps suboptimal we have two-three checkboxes now to control similar behavior in different places. Does the VDG have an opinion on that @ngraham?
This is a good patch, but I think it's actually doing too much :). I'd be OK with hardcoding the icon names in the code. I don't think they need to be configurable. Could you simplify the patch?
Code looks fine.
Mon, Sep 3
It's unfortunately still pre-alpha (although I used it daily).
Aug 16 2018
Oh shit, I forgot it was already commmitted, I though it was still stuck in review.
thanks for your patch.
I'll take this back up in September after my vacation (unless I get bored inbetween which is unlikely).