hein (Eike Hein)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:07 PM (205 w, 2 d)
Availability
Available

Recent Activity

Yesterday

hein accepted D19835: [Yakuake] Improve customization.
Fri, Mar 22, 10:29 PM · Yakuake

Wed, Mar 20

hein accepted D19096: [Kicker] Fix "Tooltip can not be displayed".

Yeah, this looks fine, thanks!

Wed, Mar 20, 2:24 PM · Plasma
hein committed R857:17d5e8085b2c: Fix Windows build tools ending up in .apks (authored by hein).
Fix Windows build tools ending up in .apks
Wed, Mar 20, 9:41 AM

Mon, Mar 18

hein accepted D19833: Remove double scrollbar in appearance settings.
Mon, Mar 18, 8:27 PM · Yakuake
hein accepted D19800: [Application Dashboard] Improve mouse handler.
Mon, Mar 18, 1:42 PM · Plasma

Sun, Mar 17

hein accepted D18438: [Task Manager] When closing apps, resize only when mouse is out..

Looks good now!

Sun, Mar 17, 4:29 PM · Plasma
hein added a comment to D19829: kicker: add option to make root level icons visible.

Kicker intentionally doesn't have icons on the root level to not conflict with the favorites column and reduce visual noise.

Sun, Mar 17, 4:28 PM · Plasma
hein added a comment to D19744: [taskmanager] Fix desktop file mapping for some apps.

What's the name of the .desktop file though? That's the most relevant part.

Sun, Mar 17, 4:26 PM · Plasma

Sat, Mar 16

hein accepted D19647: [sddm-theme/lock screen] Use QQC2 for the clock labels.
Sat, Mar 16, 5:55 PM · Plasma

Thu, Mar 14

hein accepted D19751: [Pager] Shrink label font size dynamically.
Thu, Mar 14, 9:11 AM · Plasma
hein requested changes to D19744: [taskmanager] Fix desktop file mapping for some apps.

Sorry, that's too fast and loose for me.

Thu, Mar 14, 7:21 AM · Plasma

Wed, Mar 13

hein accepted D19606: [Task Manager] Reorganize and improve presentation of context menu.
Wed, Mar 13, 5:35 PM · Plasma
hein added a comment to D19237: [Yakuake] Use the svg icons instead of the png icons for the default theme.

Also, maybe we can just delete the .png files then and make the tarball smaller?

Wed, Mar 13, 12:08 AM
hein accepted D19237: [Yakuake] Use the svg icons instead of the png icons for the default theme.

Looks great!

Wed, Mar 13, 12:08 AM
hein added a comment to D19606: [Task Manager] Reorganize and improve presentation of context menu.

Idea to make the menu smaller: put the Configure and Alternatives items into the sub-menu, and rename it to just More Actions...:

Thoughts?

Wed, Mar 13, 12:06 AM · Plasma

Mon, Mar 11

hein committed R857:d997974fd4e8: Do shallow clones (authored by hein).
Do shallow clones
Mon, Mar 11, 9:27 PM
hein committed R857:e941a2e2f0c6: Always pass PREFIX to qmake (authored by hein).
Always pass PREFIX to qmake
Mon, Mar 11, 5:15 PM
hein committed R119:3fc5abe1c0aa: Merge branch 'Plasma/5.15' (authored by hein).
Merge branch 'Plasma/5.15'
Mon, Mar 11, 4:48 PM
hein committed R120:169238848136: Merge branch 'Plasma/5.15' (authored by hein).
Merge branch 'Plasma/5.15'
Mon, Mar 11, 4:34 PM
hein committed R120:53290043796c: [Task Manager] Fix sorting of tasks on last desktop in sort-by-desktop mode (authored by hein).
[Task Manager] Fix sorting of tasks on last desktop in sort-by-desktop mode
Mon, Mar 11, 4:34 PM
hein closed D19259: [Task Manager] Fix sorting of tasks on last desktop in sort-by-desktop mode.
Mon, Mar 11, 4:34 PM · Plasma
hein committed R119:4d0f1a3e6ec7: Make Ctrl+A work regardless of focus and visualize active selection in search… (authored by hein).
Make Ctrl+A work regardless of focus and visualize active selection in search…
Mon, Mar 11, 4:30 PM
hein committed R119:d769b7aa8838: [Task Manager] Fix virtual desktops subtext on task tooltip (authored by hein).
[Task Manager] Fix virtual desktops subtext on task tooltip
Mon, Mar 11, 4:30 PM
hein closed D19518: Make Ctrl+A work regardless of focus and visualize active selection in search heading.
Mon, Mar 11, 4:30 PM · Plasma
hein closed D19257: [Task Manager] Fix virtual desktops subtext on task tooltip.
Mon, Mar 11, 4:30 PM · Plasma
hein committed R169:31e91fbbf7f5: kirigami_package_breeze_icons: Search among size 16 icons as well (authored by hein).
kirigami_package_breeze_icons: Search among size 16 icons as well
Mon, Mar 11, 4:25 PM
hein closed D19688: kirigami_package_breeze_icons: Search among size 16 icons as well.
Mon, Mar 11, 4:25 PM · Kirigami
hein requested review of D19688: kirigami_package_breeze_icons: Search among size 16 icons as well.
Mon, Mar 11, 4:23 PM · Kirigami

Sun, Mar 10

hein added a comment to D13335: Fix Skin validation when installed from KNS.

Boom! Landed it for you. Sorry this took so long!

Sun, Mar 10, 7:31 AM · Yakuake
hein committed R369:d9537fcba90b: Fix Skin validation when installed from KNS (authored by chauvin).
Fix Skin validation when installed from KNS
Sun, Mar 10, 7:31 AM
hein closed D13335: Fix Skin validation when installed from KNS.
Sun, Mar 10, 7:31 AM · Yakuake
hein added a comment to D19606: [Task Manager] Reorganize and improve presentation of context menu.

I'm concerned that having title labels on everything could be overdoing it a bit? It makes the context menu very large and have a lot of dead space, and adds to the noise. Isn't that rather a detriment to utility on repeated use? It's sometimes important to remember new users don't stay new users for very long, and first-time use isn't the only experience to optimize for.

Sun, Mar 10, 7:29 AM · Plasma
hein added a comment to D19096: [Kicker] Fix "Tooltip can not be displayed".
In D19096#427329, @hein wrote:

... I'll need to set some time aside to analyze what you're trying to achieve there and propose an alternative.

I just want 2 things:

  1. Display 2 lines for long labels.
  2. For labels need more than 2 lines -> display a tooltip that has the full label when hovering on it.

    That's all, no matter how you do it. Basically, I don't want to add any new feature, just want to make the existed stuff usable. (Currently it's not usable while it's existing)

    Thank you!
Sun, Mar 10, 7:28 AM · Plasma
hein added a comment to D18979: foldermodel: store information about screen used.

Can you explain more what this is trying to achieve / what it solves with an example?

Sun, Mar 10, 7:25 AM · Plasma

Sat, Mar 9

hein added a comment to T10561: Mozilla collaboration.

Note: This is a very broad/community-sweeping intiative (the ideas here touch on many teams and even the e.V.), and as such it's important that it doesn't stay bottled up inside just Promo - please make sure this finds it way to the kde-community list well before concrete actions are taken on a global scale. Promotional work is just a small aspect of what's being proposed here.

Sat, Mar 9, 10:10 AM · KDE Promo

Fri, Mar 8

hein added a comment to D19096: [Kicker] Fix "Tooltip can not be displayed".

I'm concerned that having title labels on everything could be overdoing it a bit? It makes the context menu very large and have a lot of dead space, and adds to the noise. Isn't that rather a detriment to utility on repeated use? It's sometimes important to remember new users don't stay new users for very long, and first-time use isn't the only experience to optimize for.

Fri, Mar 8, 4:53 PM · Plasma
hein added a comment to D19096: [Kicker] Fix "Tooltip can not be displayed".

I'm sorry, but I can't accept this patch as-is - the hoverArea-related changes are just wrong, it's not OK to couple a delegate to the view by making it set tons of property on an item i its parent. I'll need to set some time aside to analyze what you're trying to achieve there and propose an alternative.

Fri, Mar 8, 4:48 PM · Plasma

Thu, Mar 7

hein requested changes to D18438: [Task Manager] When closing apps, resize only when mouse is out..

Almost! This is not going to work reliably for groups, because the order in which their children are deleted is up to the client processes. That means once a group goes from two to one and morphs into a regular task item, the window id it has might not match the winIdList[0] you previously recorded. Instead, you should store the entire winIdList, and when an item is removed check whether it's winIdList[0] is in the list you saved away. You also need to do a bounds check before you access [0] though because not every task has a window id (e.g. launchers and startup notifications), so you're causing errors ATM.

Thu, Mar 7, 6:10 PM · Plasma
hein accepted D13335: Fix Skin validation when installed from KNS.

Looks good now!

Thu, Mar 7, 6:03 PM · Yakuake
hein committed R888:293c906ae7a9: Merge branch 'master' into realmaster (authored by hein).
Merge branch 'master' into realmaster
Thu, Mar 7, 4:53 PM
hein committed R888:cd73219b59a3: Adjust for v1.0.12. (authored by hein).
Adjust for v1.0.12.
Thu, Mar 7, 4:53 PM
hein committed R888:c8b6de6a5670: Always sort alphabetically (authored by hein).
Always sort alphabetically
Thu, Mar 7, 4:53 PM
hein committed R888:e1ae8b34befe: Performance optimizations; minor cleanup; adjust for v1.0.11 (authored by hein).
Performance optimizations; minor cleanup; adjust for v1.0.11
Thu, Mar 7, 4:53 PM
hein committed R888:e2efea7f36aa: Keep item highlight when opening context menu (authored by hein).
Keep item highlight when opening context menu
Thu, Mar 7, 4:53 PM
hein committed R888:2a574f1c3c2b: Fix "Add to Favorites" and adjust for v1.0.10. (authored by hein).
Fix "Add to Favorites" and adjust for v1.0.10.
Thu, Mar 7, 4:52 PM
hein committed R888:ef39b4214245: Make sure system action buttons de-highlight when the mouse pointer leaves the… (authored by hein).
Make sure system action buttons de-highlight when the mouse pointer leaves the…
Thu, Mar 7, 4:52 PM
hein committed R888:168b07cf0a46: Adjust for v1.0.9. (authored by hein).
Adjust for v1.0.9.
Thu, Mar 7, 4:52 PM
hein committed R888:691b80fccb25: Sync compact repr and config to Kicker; make hover category switch optional… (authored by hein).
Sync compact repr and config to Kicker; make hover category switch optional…
Thu, Mar 7, 4:52 PM
hein committed R888:67433cca21ae: Rework keyboard nav and adjust for v1.0.7 (authored by hein).
Rework keyboard nav and adjust for v1.0.7
Thu, Mar 7, 4:52 PM
hein committed R888:787f2d0b4a0c: Adjust for v1.0.6. (authored by hein).
Adjust for v1.0.6.
Thu, Mar 7, 4:52 PM
hein committed R888:e0209944dddf: Fix QQuickWindow hover event synthesis interfering with keyboard nav; optimize… (authored by hein).
Fix QQuickWindow hover event synthesis interfering with keyboard nav; optimize…
Thu, Mar 7, 4:52 PM
hein committed R888:efe62a0fc7d4: Adjust for v1.0.5. (authored by hein).
Adjust for v1.0.5.
Thu, Mar 7, 4:52 PM
hein committed R888:700ad935003e: Fix triggering context menu actions. (authored by hein).
Fix triggering context menu actions.
Thu, Mar 7, 4:52 PM
hein committed R888:4eebd45b9b4c: Reuse context menu for all delegates and don't pre-instanciate too many… (authored by hein).
Reuse context menu for all delegates and don't pre-instanciate too many…
Thu, Mar 7, 4:52 PM

Mon, Mar 4

hein added inline comments to D19518: Make Ctrl+A work regardless of focus and visualize active selection in search heading.
Mon, Mar 4, 7:15 PM · Plasma
hein requested review of D19518: Make Ctrl+A work regardless of focus and visualize active selection in search heading.
Mon, Mar 4, 4:15 PM · Plasma
hein updated the diff for D19259: [Task Manager] Fix sorting of tasks on last desktop in sort-by-desktop mode.

Fix sorting and fallthrough for tasks on all desktops.

Mon, Mar 4, 3:18 PM · Plasma
hein requested changes to D18438: [Task Manager] When closing apps, resize only when mouse is out..
Mon, Mar 4, 10:58 AM · Plasma
hein added a comment to D18438: [Task Manager] When closing apps, resize only when mouse is out..

Sorry for the late reply, too.

Mon, Mar 4, 10:54 AM · Plasma

Wed, Feb 27

hein requested review of D19259: [Task Manager] Fix sorting of tasks on last desktop in sort-by-desktop mode.
Wed, Feb 27, 1:17 AM · Plasma
hein updated the diff for D19259: [Task Manager] Fix sorting of tasks on last desktop in sort-by-desktop mode.

SortDesktop needs to fall through to alphabetic sorting within a desktop.

Wed, Feb 27, 1:16 AM · Plasma

Tue, Feb 26

hein accepted D19280: [TaskManager] Modernize and reorganize configuration settings.

I'm OK with this, but I'd like @ngraham to verify consistency on the indent issue.

Tue, Feb 26, 4:46 PM · Plasma
hein planned changes to D19259: [Task Manager] Fix sorting of tasks on last desktop in sort-by-desktop mode.

Needs another revision to tackle an additonal problem, as per the bug reporter's feedback in the referenced bug#.

Tue, Feb 26, 11:04 AM · Plasma
hein added inline comments to D19280: [TaskManager] Modernize and reorganize configuration settings.
Tue, Feb 26, 9:49 AM · Plasma

Mon, Feb 25

hein committed R369:4573f5f0d784: Add option to restore fullscreen state of the window (authored by fenuks).
Add option to restore fullscreen state of the window
Mon, Feb 25, 11:32 AM
hein closed D13710: Add option to restore fullscreen state of the window.
Mon, Feb 25, 11:32 AM
hein accepted D19029: Guard virtualDesktopManagement being accessed before fetched.

Does the PlasmaWindowManagement object need to be guarded in the same way?

Mon, Feb 25, 11:16 AM · Plasma
hein requested changes to D19280: [TaskManager] Modernize and reorganize configuration settings.
Mon, Feb 25, 7:45 AM · Plasma
hein added a comment to D19280: [TaskManager] Modernize and reorganize configuration settings.
  • Open groups in popups
  • Only when the Task Manager is full
Mon, Feb 25, 7:45 AM · Plasma

Sat, Feb 23

hein added a comment to D13710: Add option to restore fullscreen state of the window.

I'm ready to push this to master - are you ok with realname attribution (Władysław Wokulski)?

Sat, Feb 23, 5:13 PM
hein requested review of D19259: [Task Manager] Fix sorting of tasks on last desktop in sort-by-desktop mode.
Sat, Feb 23, 5:10 PM · Plasma
hein requested review of D19257: [Task Manager] Fix virtual desktops subtext on task tooltip.
Sat, Feb 23, 4:59 PM · Plasma
hein added a comment to D19237: [Yakuake] Use the svg icons instead of the png icons for the default theme.

Screenshot would indeed be nice, but it's a promising idea.

Sat, Feb 23, 4:14 PM

Fri, Feb 22

hein added inline comments to D19096: [Kicker] Fix "Tooltip can not be displayed".
Fri, Feb 22, 5:20 PM · Plasma

Thu, Feb 21

hein accepted D19157: Don't show entries with NoDisplay=true with the applauncher containmentaction.
Thu, Feb 21, 7:42 PM · Plasma
hein accepted D13710: Add option to restore fullscreen state of the window.

Sorry for the delay! Somehow I kept missing this. Patch looks fine, do you need help merging it or do you have write access?

Thu, Feb 21, 3:24 PM

Feb 20 2019

hein accepted D19154: [Kickoff] remove hint state.
Feb 20 2019, 9:57 PM · Plasma
hein accepted D19023: [Kickoff] Don't respond to window resizing/tiling shortcuts.
Feb 20 2019, 9:56 PM · Plasma
hein added a comment to D19096: [Kicker] Fix "Tooltip can not be displayed".

What's all the unrelated code changes about mouse handling trying to achieve?

Feb 20 2019, 9:56 PM · Plasma
hein accepted D18986: [breeze-icons] Add video camera icons.
Feb 20 2019, 5:46 PM · Frameworks
hein added a comment to D18986: [breeze-icons] Add video camera icons.

Would it be possible to also add the lineart versions as -symbolic? In my new app I rely on Kirigami's icon recoloring feature and it only works with monochrome icons, so I rely on -symbolic to request them.

Feb 20 2019, 5:17 PM · Frameworks

Feb 19 2019

hein accepted D18646: [Colors KCM] Add search and filter.

LGTM aside from the minor naming nitpick.

Feb 19 2019, 7:53 AM · Plasma

Feb 18 2019

hein accepted D19030: Add 16 px and 22 px versions of the gamepad icon to devices/.
Feb 18 2019, 1:24 PM · Frameworks
hein added a comment to D19030: Add 16 px and 22 px versions of the gamepad icon to devices/.

LGTM, thanks!

Feb 18 2019, 1:19 PM · Frameworks

Feb 17 2019

hein added a comment to D18570: EGLStream DRM Backend Initial Implementation.

The patch currently doesn't apply cleanly against master anymore, mind rebasing on the next update?

Feb 17 2019, 4:39 AM · KWin

Feb 15 2019

hein added a comment to D19030: Add 16 px and 22 px versions of the gamepad icon to devices/.

Could this maybe be input-games-symbolic (too)? Because I want a monochrome version always (my app recolors icons using the Kirigami feature, and that only works with monochrome icons).

Feb 15 2019, 7:25 AM · Frameworks

Feb 14 2019

hein added a comment to D19019: Verify that model.AppPid is defined.

Remote clients have no pid, but might be nicer to fix the model to return 0.

Feb 14 2019, 10:44 PM · Plasma

Feb 12 2019

hein added inline comments to D18938: Show assigned shortcut in drawer action delegates.
Feb 12 2019, 6:25 AM · Kirigami
hein updated the diff for D18938: Show assigned shortcut in drawer action delegates.

Fix typo.

Feb 12 2019, 12:26 AM · Kirigami
hein added a comment to D18938: Show assigned shortcut in drawer action delegates.

Screenshot showing ellision:

Feb 12 2019, 12:13 AM · Kirigami
hein requested review of D18938: Show assigned shortcut in drawer action delegates.
Feb 12 2019, 12:11 AM · Kirigami

Feb 11 2019

hein accepted D18925: [Icon Applet] Parse jump list actions and open with actions on demand.
Feb 11 2019, 5:57 PM · Plasma
hein added a comment to D18901: Add device icons for drones.

Thank you! Just what I needed.

Feb 11 2019, 5:11 PM · Frameworks
hein accepted D18929: Have task managers follow the desktop for window visibility behavior by default.
Feb 11 2019, 5:10 PM · Plasma

Feb 9 2019

hein accepted D18721: [Folder View] Assume root of a protocol is always a folder.
Feb 9 2019, 9:45 AM · Plasma

Feb 8 2019

hein accepted D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it.
Feb 8 2019, 6:13 PM · Plasma
hein added a comment to D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it.
In D18848#407838, @hein wrote:

This is a good change, but it's more worth finding out why it doesn't work already. Looking at the code, when KickoffItem is triggered it runs the switchToInitial() function in FullRepresentation.qml, which already switches tabs and is also what sets the state back to Normal. So setting the tab in the state shouldn't be necessary. Can you debug why setting currentTab in switchToInitial() apparently doesn't work?

I think it might be because of the switch from the state "Search" to the state "Normal", because this doesn't happen if the arrow keys are used to navigate to the right of Favorites, only when Search is invoked. There's a "currentTab: searchPage" (line 738) setting in the state "Search" that probably gets stuck. I didn't want to deal with changing "Search" because in my experience, Kickoff's search view can be pretty temperamental. This seemed like the safest course of action.

Feb 8 2019, 4:11 PM · Plasma
hein added a comment to D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it.

This is a good change, but it's more worth finding out why it doesn't work already. Looking at the code, when KickoffItem is triggered it runs the switchToInitial() function in FullRepresentation.qml, which already switches tabs and is also what sets the state back to Normal. So setting the tab in the state shouldn't be necessary. Can you debug why setting currentTab in switchToInitial() apparently doesn't work?

Feb 8 2019, 12:44 PM · Plasma

Feb 7 2019

hein accepted D18831: [sddm-theme] Use more precise labels for "Different User".
Feb 7 2019, 10:52 PM · Plasma

Feb 4 2019

hein accepted D18727: [Icon Applet] Use libTaskManager for startup feedback.

Feb 4 2019, 4:46 PM · Plasma