- User Since
- Apr 15 2015, 5:07 PM (284 w, 2 d)
Jul 11 2020
Overall this makes quite good sense, and I applaud the effort. Couple of thoughts and notes:
Jun 25 2020
You sure we still use a data engine here? I think I already rewrote this to libtm last time around. If there's anything left I'll take it.
May 5 2020
Mar 10 2020
Mar 5 2020
Mar 4 2020
Mar 3 2020
Feb 27 2020
Feb 25 2020
Feb 21 2020
Feb 7 2020
trmdi's point is good, otherwise I like it.
Feb 2 2020
Jan 24 2020
Let's wait until branching, there's still some KDE 4 apps people use.
So does this fall through to the dialog when the type hasn't been determined?
Just a quick note I will review this tomorrow or next week when I'm on vacation, sorry for the long wait.
Jan 21 2020
This patch is fine and in line with the existing implementation, but it occurs to me we probably should make the RecentUsageModel use FileEntry and put it centrally there at some point.
Jan 19 2020
Jan 18 2020
Jan 11 2020
Jan 7 2020
Jan 6 2020
The VDG channel somehow ended up liking "Yoto" a lot!
That's good with me, the rest of the patch is good and much appreciated.
Maybe there's a third option: Another precedent we already have is the circular carve-out we use for the notification number badge. Perhaps we could reuse that for the indicator.
I'm still not a big fan of the Glow for a number of reasons:
Jan 5 2020
Jan 4 2020
I love it.
Since we have consensus, let's expand the clipart page? :)
@chwmpfling Definitely the plan! Will appreciate your review
Jan 3 2020
We can revisit it after some more discussion.
I don't agree with this patch. Hiding a place or section from the Places panel doesn't mean the user didn't add it and it's not to be used. We don't hide it from Folder View's config or relative title generator either. Hidden is not removed. Please revert.
It should be iconName after label.
Jan 2 2020
Dec 28 2019
It's definitely a discussion I'd enjoy more :)
Ah sorry, I had a reply typed into the text field but must have botched hitting Submit.
Dec 26 2019
This is also possible in all of the other menus based on the backend, so that's sensible, yeah.