hein (Eike Hein)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:07 PM (187 w, 5 d)
Availability
Available

Recent Activity

Today

hein committed R119:7caafc8f5848: Merge branch 'Plasma/5.14' (authored by hein).
Merge branch 'Plasma/5.14'
Mon, Nov 19, 10:30 AM
hein committed R119:1ca1f240ee4a: Merge branch 'Plasma/5.12' into Plasma/5.14 (authored by hein).
Merge branch 'Plasma/5.12' into Plasma/5.14
Mon, Nov 19, 10:29 AM
hein committed R119:454347370883: Revert unintended line (authored by hein).
Revert unintended line
Mon, Nov 19, 10:28 AM
hein committed R119:ee43381ab64f: Merge branch 'Plasma/5.14' (authored by hein).
Merge branch 'Plasma/5.14'
Mon, Nov 19, 9:42 AM
hein committed R119:a3039e9f6821: Merge branch 'Plasma/5.12' into Plasma/5.14 (authored by hein).
Merge branch 'Plasma/5.12' into Plasma/5.14
Mon, Nov 19, 9:42 AM
hein committed R119:ab26ebb18b74: Compress calls to `updateSize` (authored by hein).
Compress calls to `updateSize`
Mon, Nov 19, 9:42 AM
hein closed D17006: Compress calls to `updateSize`.
Mon, Nov 19, 9:42 AM · Plasma
hein added inline comments to D17006: Compress calls to `updateSize`.
Mon, Nov 19, 9:36 AM · Plasma
hein requested review of D17006: Compress calls to `updateSize`.
Mon, Nov 19, 7:25 AM · Plasma
hein requested review of D17005: Fix dismissing the Dashboard by clicking inbetween multi-grid categories..
Mon, Nov 19, 7:16 AM · Plasma
hein added a comment to D3236: Enables grouping and sorting settings in Icons Only Task Manager.

I'm very sorry this went unanswered for so long - for some reason the patch slipped through the cracks. Unfortunately I have to continue with bad news - those behaviors being hard-chosen in the ITM widget is by design choice, so I have to reject this patch.

Mon, Nov 19, 6:49 AM · Plasma
hein requested review of D17004: Always scroll views up when the fullrepr is collapsed..
Mon, Nov 19, 6:48 AM · Plasma
hein requested review of D17003: Fix mouse events being withheld from the scrollbar..
Mon, Nov 19, 6:43 AM · Plasma
hein added a comment to D15855: Port Kickoff to shared view component using single-MouseArea pattern.

@hein This broke the scrollbar for any views that are scrollable. Now the scrollbars don't accept clicks and drags anymore, and don't change on hover. Maybe the MouseArea doesn't pass on the mouse events to the ScrollArea underneath it or something?

We can't ship 5.15 this way; please fix. Thanks!

Mon, Nov 19, 6:23 AM · Plasma

Yesterday

hein added a comment to D16968: [Folder View] improve label contrast against challenging backgrounds.

Looks ugly to me. Honestly, my stance is "use a better wallpaper". There's only so far you can compromise theme aesthetics for other people's bad taste.

Sun, Nov 18, 8:11 AM · Plasma

Fri, Nov 16

hein added a comment to D14988: Implement option to toggle page navigation wraps around for pager plasmoid.

@ngraham Let's progress this, do you want @phuongn to change the patch?

Fri, Nov 16, 8:08 AM · Plasma
hein added a comment to D16643: Correct the accept flag of the event object on DragMove .

@mart ping

Fri, Nov 16, 8:07 AM · Frameworks
hein added a comment to D16383: Add accessibility information to tabbar in dash starter.

@chempfling Do you need help pushing this?

Fri, Nov 16, 8:05 AM · Plasma Accessibility

Tue, Nov 6

hein accepted D16711: Make sure m_labelMode is initialised.

Patch is fine, but codingstyle-wise I usually do it in the constructor in the .cpp. I'd be a nice gesture if you move it before you push, but otherwise all cool.

Tue, Nov 6, 10:32 PM · Plasma

Thu, Nov 1

hein updated the diff for D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

Fix build error.

Thu, Nov 1, 8:59 PM · KWin
hein updated the diff for D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

Update the title.

Thu, Nov 1, 8:56 PM · KWin
hein updated the diff for D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.
  • Sync ids before syncing names.
  • Remove the dummy id swap, it's no longer needed given the above.
  • Add a class description comment that illuminates the sync/detach behavior.
  • Reindent headers.
Thu, Nov 1, 8:43 PM · KWin
hein added a comment to D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.
In D14542#352260, @zzag wrote:

Please wait for others.

When you're about to push, please:

  • re-title this patch to "[kcmkwin/desktop] Use new ...";
  • shift access modifiers and everything that goes below 4 spaces to the left (that's one of my inline comments).
Thu, Nov 1, 4:43 PM · KWin
hein accepted D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages.

Looks great, I'm happy to finally see this get cleaned up.

Thu, Nov 1, 4:30 PM · Plasma

Tue, Oct 30

hein added a comment to D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

Should be OK now

Tue, Oct 30, 3:55 PM · KWin
hein updated the diff for D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

Try to remove Marco's revision

Tue, Oct 30, 3:54 PM · KWin

Mon, Oct 29

hein added a comment to T9878: Default application starter menu is missing a11y Labels.

BTW guys, I am on business travel at the moment that's why I'm not super looped in or helpful.

Mon, Oct 29, 7:11 PM · Plasma Accessibility

Thu, Oct 25

hein accepted D16419: [kickoff] Wordwrap long sentence in config.
Thu, Oct 25, 9:30 AM · Plasma

Wed, Oct 24

hein committed R119:48b32259e73f: Port Kickoff to shared view component using single-MouseArea pattern (authored by hein).
Port Kickoff to shared view component using single-MouseArea pattern
Wed, Oct 24, 8:01 AM
hein closed D15855: Port Kickoff to shared view component using single-MouseArea pattern.
Wed, Oct 24, 8:01 AM · Plasma
hein committed R119:74db6d8ee24f: Merge branch 'Plasma/5.14' (authored by hein).
Merge branch 'Plasma/5.14'
Wed, Oct 24, 7:59 AM
hein closed D16368: Swap Trash/Delete when Shift is used while the menu is open.
Wed, Oct 24, 7:59 AM · Plasma
hein committed R119:c4285ed1b407: Swap Trash/Delete when Shift is used while the menu is open (authored by hein).
Swap Trash/Delete when Shift is used while the menu is open
Wed, Oct 24, 7:59 AM

Tue, Oct 23

hein updated the diff for D15599: Port the "Switch Desktop" containment action to libtaskmanager.

Fix off-by-one.

Tue, Oct 23, 8:51 AM · Plasma
hein updated the diff for D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.
  • Fix Exec
  • Clean up KCM titles
Tue, Oct 23, 8:48 AM · KWin
hein committed R119:6c4194f47c53: Merge branch 'Plasma/5.14' (authored by hein).
Merge branch 'Plasma/5.14'
Tue, Oct 23, 7:28 AM
hein committed R119:6921989484b5: Merge branch 'Plasma/5.12' into Plasma/5.14 (authored by hein).
Merge branch 'Plasma/5.12' into Plasma/5.14
Tue, Oct 23, 7:24 AM
hein committed R119:0e1aa9e046c2: Remove. (authored by hein).
Remove.
Tue, Oct 23, 7:22 AM
hein committed R119:03b17ac5ec3e: Focus handling fixes (authored by hein).
Focus handling fixes
Tue, Oct 23, 7:22 AM
hein added a comment to D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

Ping?

Tue, Oct 23, 5:58 AM · KWin
hein added a comment to D15599: Port the "Switch Desktop" containment action to libtaskmanager.

Ping?

Tue, Oct 23, 5:58 AM · Plasma
hein updated the diff for D16368: Swap Trash/Delete when Shift is used while the menu is open.

Simplify patch.

Tue, Oct 23, 5:57 AM · Plasma
hein added a comment to D14796: Port Keyboard input modules and Expand scope to cover input method configuration.
In D14796#347289, @apol wrote:

What's the status of this? The longer we wait, the harder it will be to integrate. We just branched 5.14, maybe it's time to consider doing so?

Tue, Oct 23, 5:37 AM · Plasma
hein added a comment to T5331: Keyboard Layout Plasmoid .

Yeah, it's that one.

Tue, Oct 23, 5:35 AM · Plasma

Mon, Oct 22

hein requested review of D16368: Swap Trash/Delete when Shift is used while the menu is open.
Mon, Oct 22, 8:19 AM · Plasma
hein closed D15535: Use KMainWindow instead of QMainWindow.
Mon, Oct 22, 5:22 AM
hein committed R369:0c0eb086bdc0: Use KMainWindow instead of QMainWindow (authored by mschiller).
Use KMainWindow instead of QMainWindow
Mon, Oct 22, 5:22 AM
hein requested changes to D15170: Add icon names for root level kicker, recent docs, recent apps, power and session.
Mon, Oct 22, 5:12 AM · Plasma
hein added a comment to D15170: Add icon names for root level kicker, recent docs, recent apps, power and session.

Ping?

Mon, Oct 22, 5:11 AM · Plasma
hein accepted D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages.
Mon, Oct 22, 5:08 AM · Plasma
hein added a comment to T9869: Desktop Icons should have an a11y Label.

It's in and will be in the next 5.12.x (LTS) and 5.14.x releases, and of course eventually also 5.15.

Mon, Oct 22, 5:07 AM · Plasma Accessibility
hein committed R119:a44d3039ace2: Merge branch 'Plasma/5.14' (authored by hein).
Merge branch 'Plasma/5.14'
Mon, Oct 22, 5:06 AM
hein committed R119:ca64d0e4ad2b: Merge branch 'Plasma/5.12' into Plasma/5.14 (authored by hein).
Merge branch 'Plasma/5.12' into Plasma/5.14
Mon, Oct 22, 5:05 AM
hein committed R119:498c42fed65d: Add accessibility information to desktop icons (authored by chempfling).
Add accessibility information to desktop icons
Mon, Oct 22, 5:04 AM
hein closed D16309: Add accessibility information to desktop icons.
Mon, Oct 22, 5:04 AM · Plasma
hein added a comment to D16309: Add accessibility information to desktop icons.

I'll land it for you (it needs a manual step, which requires a dev account - which you should eventually apply for if you wind up contributing regularly!).

Mon, Oct 22, 5:01 AM · Plasma
hein added a comment to T5331: Keyboard Layout Plasmoid .

@apol My GSoC student has used this code as inspiration, if you look at the review request for his work, his version of kimpanel now has layout indicator support superceding this one here.

Mon, Oct 22, 4:33 AM · Plasma

Oct 19 2018

hein accepted D16316: [Kicker] Rename id column to itemColumn.
Oct 19 2018, 1:51 PM · Plasma

Oct 17 2018

hein created T9890: test folder view keyboard nav.
Oct 17 2018, 9:05 PM · Restricted Project
hein updated the diff for D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

Drop the TODO note from the message.

Oct 17 2018, 6:22 PM · KWin
hein updated the diff for D15599: Port the "Switch Desktop" containment action to libtaskmanager.

Remove two arg() fixes in the diff that should be in the other containment action diff

Oct 17 2018, 6:14 PM · Plasma
hein updated the diff for D15599: Port the "Switch Desktop" containment action to libtaskmanager.
  • Fix another arg() call
  • Do delete+remove in one step with take()
  • Fix loop condition
Oct 17 2018, 6:11 PM · Plasma
hein added a comment to T9869: Desktop Icons should have an a11y Label.

Labels should be done in: plasma-desktop.git:containments/desktop/package/contents/ui/FolderItemDelegate.qml

Oct 17 2018, 1:54 PM · Plasma Accessibility

Oct 16 2018

hein added a comment to D15535: Use KMainWindow instead of QMainWindow.

Sorry for being incredibly slow on this, life has been so busy :/

Oct 16 2018, 8:27 PM
hein updated the diff for D15599: Port the "Switch Desktop" containment action to libtaskmanager.

Don't keep VirtualDesktopInfo as a static member to make d_ed happy

Oct 16 2018, 7:28 PM · Plasma
hein updated the diff for D15599: Port the "Switch Desktop" containment action to libtaskmanager.

Fix two more uses of arg()

Oct 16 2018, 7:21 PM · Plasma
hein updated the diff for D15642: Port "Switch Window" containment action to updated libtaskmanager API and away from KWindowSystem.
  • Make doSwitch wrap again
  • Don't keep the VirtualDesktopsInfo as a static member to make d_ed happy
  • Use the multi-argument arg()
Oct 16 2018, 7:17 PM · Plasma
hein added a comment to T9872: XDGPopop Positioner.

I like this plan a lot, including the Dialog2 one. It's always occurred to me that the XDG Popup positioning API and Plasma Dialog's are quite closely related.

Oct 16 2018, 12:08 PM · Plasma on Wayland

Oct 11 2018

hein committed R119:18c95655c381: Merge branch 'Plasma/5.14' (authored by hein).
Merge branch 'Plasma/5.14'
Oct 11 2018, 7:25 PM
hein committed R119:480962c3ff93: Focus handling fixes (authored by hein).
Focus handling fixes
Oct 11 2018, 1:36 PM
hein closed D16106: Focus handling fixes.
Oct 11 2018, 1:36 PM · Plasma

Oct 10 2018

hein updated the diff for D16106: Focus handling fixes.
  • Drop the onPress handling, it was unnecessary with the focus-forwarding I added later during development.
  • Take David's review comment into account.
Oct 10 2018, 5:28 PM · Plasma
hein added inline comments to D16106: Focus handling fixes.
Oct 10 2018, 5:25 PM · Plasma
hein updated the diff for D13745: Implement support for virtual desktops on Wayland.
  • Make TaskGroupingProxyModel::requestVirtualDesktops and similar async-safe.
  • Make TasksModel::Private::lessThan handle unsorted virtual desktops lists.
Oct 10 2018, 3:24 PM · Plasma
hein updated the diff for D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

Drop FIXME from spacer on Marco's advice.

Oct 10 2018, 2:50 PM · KWin
hein requested review of D16106: Focus handling fixes.
Oct 10 2018, 2:43 PM · Plasma
hein accepted D15840: [Folder View] Remember selected item when navigating in subfolders.

No worries, thanks for the patch :)

Oct 10 2018, 7:43 AM · Plasma
hein added inline comments to D15840: [Folder View] Remember selected item when navigating in subfolders.
Oct 10 2018, 6:23 AM · Plasma
hein accepted D15535: Use KMainWindow instead of QMainWindow.
Oct 10 2018, 6:03 AM

Oct 9 2018

hein added a comment to D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

@mart There's a last FIXME in the QML code for a spacing hack (mentioned as a todo in the description). Could you give me a hand with that one?

Oct 9 2018, 3:52 AM · KWin
hein updated the diff for D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.
  • Remove hack around Enter issue and move to onAccepted now that Marco has fixed it somewhere else.
  • Update description.
Oct 9 2018, 3:51 AM · KWin
hein added inline comments to D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.
Oct 9 2018, 3:48 AM · KWin
hein added inline comments to D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.
Oct 9 2018, 3:47 AM · KWin
hein added a comment to D13745: Implement support for virtual desktops on Wayland.

I have prepared an update with the qDebug cleanup and the virtual desktops code in TaskGroupingProxyModel, but I don't want to risk my above questions being lost, so I'll hold of on updating before the answers are in.

Oct 9 2018, 3:47 AM · Plasma
hein added inline comments to D13745: Implement support for virtual desktops on Wayland.
Oct 9 2018, 3:45 AM · Plasma
hein added inline comments to D13745: Implement support for virtual desktops on Wayland.
Oct 9 2018, 3:42 AM · Plasma
hein updated the diff for D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.
  • Swap dummy ids out for real ids, otherwise sync can't finish (review by d_ed).
  • Move hooking up state-altering signals to after initial state is in, so we don't need to guard against concurrency (review by d_ed).
  • Removed unused file (review by d_ed).
  • Various style cleanups pointed out by Vlad.
Oct 9 2018, 3:39 AM · KWin
hein added a comment to D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

QML and the rest is all fine.

I don't understand why desktopmodel is the way it is.

There are 2 DBus patterns one could do here.

  • we buffer all changes in a model locally, when the user clicks save we apply them on the server and recall initialise.
  • we do things async-realtime. The model is always in sync with remote changes. When the user clicks create/remove we send a request to the server; the model only updates when it gets the callback.

    This seems to be doing both patterns at once.
Oct 9 2018, 3:15 AM · KWin
hein added inline comments to D13745: Implement support for virtual desktops on Wayland.
Oct 9 2018, 3:08 AM · Plasma

Oct 8 2018

hein added inline comments to D15840: [Folder View] Remember selected item when navigating in subfolders.
Oct 8 2018, 11:48 PM · Plasma
hein accepted D15970: Properly look for fallback themes.
Oct 8 2018, 11:20 PM · Frameworks
hein added a comment to D15840: [Folder View] Remember selected item when navigating in subfolders.
In D15840#337446, @hein wrote:

I like the goal here, but it's not a given the stored index is still valid when navigating back - the folder contents could have changed. It'd be hygienic to bound the access when popping from the history.

Thanks for the review. I don't know if the modifications I just made correspond to what you had in mind.
But I tested both cases where A/ one of the parent folder we were into is deleted, in that case navigating back displays a message that this folder does not exist anymore, and B/ that the content of the folder changes. In case B, the Y position we are moving to might be incorrect if lots of files we added before. But I don't know what to do about that, and if it is worth the trouble ... :)

Oct 8 2018, 5:02 PM · Plasma
hein added a reviewer for D13745: Implement support for virtual desktops on Wayland: davidedmundson.
Oct 8 2018, 10:08 AM · Plasma

Oct 6 2018

hein added a reviewer for D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface: ltoscano.

Adding Luigi due to the .pot rename caused by this.

Oct 6 2018, 3:13 AM · KWin
hein added a comment to D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

Forgot to mention it, but I also did the folder move/rename so this KCM now replaces the old one.

Oct 6 2018, 3:12 AM · KWin
hein added a comment to D15840: [Folder View] Remember selected item when navigating in subfolders.

I like the goal here, but it's not a given the stored index is still valid when navigating back - the folder contents could have changed. It'd be hygienic to bound the access when popping from the history.

Oct 6 2018, 1:14 AM · Plasma
hein accepted D15824: [Folder View] Fix right/left arrow navigation in popup mode.
Oct 6 2018, 1:03 AM · Plasma
hein added inline comments to D15855: Port Kickoff to shared view component using single-MouseArea pattern.
Oct 6 2018, 12:42 AM · Plasma
hein updated the diff for D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.
  • Remove copied code.
Oct 6 2018, 12:32 AM · KWin

Oct 4 2018

hein updated the diff for D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

Update description to scratch off the done todos

Oct 4 2018, 9:50 PM · KWin