hein (Eike Hein)
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:07 PM (149 w, 4 d)
Availability
Available

Recent Activity

Thu, Feb 22

hein requested review of D10736: Do clamping in the model and add missing lower bound check.
Thu, Feb 22, 8:56 AM · Plasma

Tue, Feb 20

hein added a comment to D10691: [kactivities-stats] Fix plasmashell crash when database is broken.

@ivan So you wrote a method that can return null, but the call sites aren't actually prepared to handle that gracefully? :) But I was waiting for your review for that context.

Tue, Feb 20, 11:47 PM · Plasma, Frameworks
hein added a comment to D10692: parent full representation to the proper window at start.

It does use it btw, just not for subdialogs.

Tue, Feb 20, 7:25 PM · Plasma
hein accepted D10691: [kactivities-stats] Fix plasmashell crash when database is broken.
Tue, Feb 20, 5:08 PM · Plasma, Frameworks
hein added a comment to D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948.

No, you weren't: "What's the point of the desktop if it is not possible to place folder, pictures, music, etc on it?"

Tue, Feb 20, 4:58 PM · Plasma
hein added a comment to D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948.

This isn't about disabling support for icons (we just turned that back on in 5.10 ...), it's about not creating the Home and Trash icons by default on first login.

Tue, Feb 20, 4:32 PM · Plasma
hein added a comment to D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948.

This is just following up on a public promise we already made. When we turned Folder View into the default desktop containment, we told everyone (and got a lot of positive feedback from the users for it) that this means the desktop surface now supports icons by default again, but we don't actually place any by default so it's not having any impact on the people who prefer an empty desktop by default. Then it turns out we actually forgot to change the code.

Tue, Feb 20, 4:06 PM · Plasma
hein accepted D10684: [Drop Job] Create proper trash file on linking.
Tue, Feb 20, 3:28 PM · Frameworks, Plasma
hein added a comment to D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948.

I'll look into it, this week probably

Tue, Feb 20, 2:23 PM · Plasma
hein accepted D10586: [Task Manager] Limit badge label to a sane size.
Tue, Feb 20, 2:19 PM · Plasma

Fri, Feb 16

hein committed R119:4d229146fa4c: Keep item highlighted when context menu opens (authored by hein).
Keep item highlighted when context menu opens
Fri, Feb 16, 1:17 PM
hein closed D10552: Keep item highlighted when context menu opens.
Fri, Feb 16, 1:17 PM · Plasma

Thu, Feb 15

hein committed R241:e3a80661c9cd: Stuff the "Couldn't find executable" message box into a queued lambda (authored by hein).
Stuff the "Couldn't find executable" message box into a queued lambda
Thu, Feb 15, 6:48 PM
hein closed D10405: Stuff the "Couldn't find executable" message box into a queued lambda.
Thu, Feb 15, 6:47 PM · Frameworks
hein added a comment to D10405: Stuff the "Couldn't find executable" message box into a queued lambda.

Thanks!

Thu, Feb 15, 6:47 PM · Frameworks
hein added a comment to D10405: Stuff the "Couldn't find executable" message box into a queued lambda.

ping

Thu, Feb 15, 6:21 PM · Frameworks
hein requested review of D10552: Keep item highlighted when context menu opens.
Thu, Feb 15, 6:20 PM · Plasma
hein committed R119:17777b771cc9: Unbreak DND. (authored by hein).
Unbreak DND.
Thu, Feb 15, 6:00 PM
hein closed D10550: Unbreak DND..
Thu, Feb 15, 6:00 PM · Plasma
hein requested review of D10550: Unbreak DND..
Thu, Feb 15, 5:48 PM · Plasma
hein accepted D10539: [Task Manager] Don't delay audio indicator when task appears.
Thu, Feb 15, 12:27 PM · Plasma
hein accepted D10507: Turn code.js into a singleton.

Nice! Thanks.

Thu, Feb 15, 10:28 AM · Plasma

Wed, Feb 14

hein committed R119:31bcd0ac9590: Fix launching by touchscreen tap (authored by hein).
Fix launching by touchscreen tap
Wed, Feb 14, 3:54 PM
hein closed D10513: Fix launching by touchscreen tap.
Wed, Feb 14, 3:54 PM · Plasma
hein requested review of D10513: Fix launching by touchscreen tap.
Wed, Feb 14, 3:51 PM · Plasma
hein committed R119:840694cc5bbe: Fix window pin not showing (authored by hein).
Fix window pin not showing
Wed, Feb 14, 3:28 PM
hein closed D10510: Fix window pin not showing.
Wed, Feb 14, 3:28 PM · Plasma
hein requested review of D10510: Fix window pin not showing.
Wed, Feb 14, 3:20 PM · Plasma
hein accepted D10506: Move autopopulate to AppsModel.
Wed, Feb 14, 12:56 PM · Plasma
hein added a comment to D10063: [Yakuake] Blurs behind the window if the profile color setting is enabled.

I still feel pretty strongly that any correct version of this patch wouldn't actually add any code to Yakuake.

Wed, Feb 14, 10:27 AM

Tue, Feb 13

hein added a comment to D10405: Stuff the "Couldn't find executable" message box into a queued lambda.

(Side note: I like the idea of a KRun job - something like that could even be added without needing a KIO 6.)

Tue, Feb 13, 11:22 AM · Frameworks
hein updated the diff for D10405: Stuff the "Couldn't find executable" message box into a queued lambda.
  • Fall back to qWarning if !qGuiApp
  • Use QTimer::singleShot to work on older Qt
Tue, Feb 13, 11:06 AM · Frameworks
hein added a comment to D10405: Stuff the "Couldn't find executable" message box into a queued lambda.

There's a problem with my patch :(. QMetaObject::invokeMethod(context, functor) is new in Qt 5.10. I don't think we can depend on that yet, right?

Tue, Feb 13, 11:02 AM · Frameworks
hein retitled D10405: Stuff the "Couldn't find executable" message box into a queued lambda from Don't proceed in runCommandInternal if the executable doesn't exit to Stuff the "Couldn't find executable" message box into a queued lambda.
Tue, Feb 13, 10:41 AM · Frameworks
hein updated the diff for D10405: Stuff the "Couldn't find executable" message box into a queued lambda.

New approach.

Tue, Feb 13, 10:40 AM · Frameworks
hein added a comment to D10405: Stuff the "Couldn't find executable" message box into a queued lambda.

It's totally conceivable for e.g. a KPart or a Plasma plugin to open a QWidget-based window where the KMessageBox is appropriate, and if there's only a global interface instance and Plasma overrides it to hide all message boxes it's going to break KIO users in plugins. So I don't think going to a single global is good enough, it would have to be able to set more narrowly. This also bubbles up actually - the KRun calls we're talking about are in libtaskmanager which is technically meant to be UI-agnostic, so it'd have to also expose some way to set the interface instance. I agree all of this is in theory good (we need to make KIO more toolkit-agnostic - I have another giant patch sitting around that's almost-unfinishable that adds QWindow support to some APIs that currently only accept QWidgets I don't even have), but I think it's KIO 6 material and not the quick fix I'm looking for.

Tue, Feb 13, 10:38 AM · Frameworks
hein added a comment to D10405: Stuff the "Couldn't find executable" message box into a queued lambda.

There's a Job::setUiDelegateExtension though in addition to KIO::setDefaultJobUiDelegateExtension. A global would wreak havoc with stuff like plugins, no?

Tue, Feb 13, 10:24 AM · Frameworks
hein added a comment to D10405: Stuff the "Couldn't find executable" message box into a queued lambda.

Thanks for the solution for sure, but - it requires writing a million lines of boilerplate, extensively refactoring KRun and adding reams of new overloads to its API (there would need to be some way to pass an instance of that interface to all these - not internal - statics). It's more than I have time/energy for currently and I'm not really sure it's viable without a KIO6. I have another idea, though, let me see if it's viable ...

Tue, Feb 13, 10:18 AM · Frameworks

Mon, Feb 12

hein accepted D10420: Make sure the FrameSvg and Svg instances have the right devicePixelRatio.
Mon, Feb 12, 1:14 PM · Frameworks, Plasma
hein added a comment to D10405: Stuff the "Couldn't find executable" message box into a queued lambda.

/o\ I don't like life anymore

Mon, Feb 12, 12:14 PM · Frameworks
hein moved T2018: Per-activity favourites (kickoff) from Work in Progress to Done on the Plasma board.
Mon, Feb 12, 12:00 PM · Plasma
hein moved T2070: Agree Plasma Vision from Work in Progress to Done on the Plasma board.
Mon, Feb 12, 12:00 PM · VDG, Plasma
hein moved T2017: Global storage of Favourite applications from Work in Progress to Done on the Plasma board.
Mon, Feb 12, 12:00 PM · Plasma
hein added a comment to D10405: Stuff the "Couldn't find executable" message box into a queued lambda.

@dfaure I don't see how the virtual thing is going to work - there's numerous static affected codepaths so there's no 'this' to pass down to call the non-static error handler on.

Mon, Feb 12, 11:53 AM · Frameworks
hein committed R119:c85eb1aef49e: Implement Tab/Backtab navigation (authored by hein).
Implement Tab/Backtab navigation
Mon, Feb 12, 11:29 AM
hein closed D10456: Implement Tab/Backtab navigation.
Mon, Feb 12, 11:29 AM · Plasma
hein updated the diff for D10456: Implement Tab/Backtab navigation.

Full Tab/Backtab nav also when searching.

Mon, Feb 12, 10:31 AM · Plasma
hein requested review of D10456: Implement Tab/Backtab navigation.
Mon, Feb 12, 10:03 AM · Plasma
hein added a comment to D10405: Stuff the "Couldn't find executable" message box into a queued lambda.

Yeah, I had a feeling there were other design considerations here, but they're not documented/commented in the code so the only way to find out was to show you a patch :)

Mon, Feb 12, 7:45 AM · Frameworks

Sun, Feb 11

hein added a comment to D10383: Fix pinning apps when their .desktop file has a space in the file name..

Is this expected to fully fix https://bugs.kde.org/show_bug.cgi?id=385942?

Sun, Feb 11, 8:20 AM · Plasma
hein added a comment to D10420: Make sure the FrameSvg and Svg instances have the right devicePixelRatio.

Sanity check question: Did you make sure this doesn't introduce an extra render when things start up? (Initial vs. change.)

Sun, Feb 11, 8:18 AM · Frameworks, Plasma
hein added a comment to D10408: Add option to enable shared folderview content per desktop.

This should go into master only for now.

Sun, Feb 11, 8:12 AM · Plasma
hein added a comment to D10407: Disable positioning in popup folderviews.

This should go into 5.12 and then be merged up.

Sun, Feb 11, 8:12 AM · Plasma
hein accepted D10408: Add option to enable shared folderview content per desktop.
Sun, Feb 11, 8:12 AM · Plasma
hein accepted D10407: Disable positioning in popup folderviews.
Sun, Feb 11, 8:11 AM · Plasma
hein added a comment to D10383: Fix pinning apps when their .desktop file has a space in the file name..

@ivan Could you suggest a good testcase? I'm a bit wary of pushing this into the LTS branch with a low amount of confidence.

Sun, Feb 11, 8:01 AM · Plasma

Fri, Feb 9

hein updated the diff for D10405: Stuff the "Couldn't find executable" message box into a queued lambda.

Remove unrelated changes.

Fri, Feb 9, 1:55 PM · Frameworks
hein added a comment to D10405: Stuff the "Couldn't find executable" message box into a queued lambda.

Argh, sorry for the noisy diff, I didn't do commit -a but arc did I guess ... I'll clean this up, one sec.

Fri, Feb 9, 1:53 PM · Frameworks
hein requested review of D10405: Stuff the "Couldn't find executable" message box into a queued lambda.
Fri, Feb 9, 1:52 PM · Frameworks
hein added a comment to D10223: Improve preview thumbnail quality.

Thanks for your analysis! I actually did try roughly the same thing, but I thought keeping the behavior of having larger preview thumbs is nicer overall.

Fri, Feb 9, 12:37 PM · Plasma

Thu, Feb 8

hein added a reviewer for D10383: Fix pinning apps when their .desktop file has a space in the file name.: ivan.

Ivan, could you weigh in on the KActivities spaces angle?

Thu, Feb 8, 1:23 PM · Plasma
hein requested review of D10383: Fix pinning apps when their .desktop file has a space in the file name..
Thu, Feb 8, 9:41 AM · Plasma
hein accepted D3562: [Task Manager] Create toolTipDelegate on demand.

Sometimes I wish we'd implement lazy loading in the backends instead (e.g. why is heavy when it's never been visible). The more we optimize our QML the more we go procedural/non-declarative and hard to read sadly.

Thu, Feb 8, 8:39 AM · Plasma
hein accepted D10382: [Task Manager] Load only icons in tooltip that we end up showing.
Thu, Feb 8, 8:34 AM · Plasma
hein accepted D10038: Use QTemporaryDir::filePath() instead of path concatenation.
Thu, Feb 8, 7:27 AM · Plasma

Wed, Feb 7

hein abandoned D9207: Don't load KDE platform module in kglobalaccel5.

As mentioned, I'm OK with abandoning it. I think the change is hygienic, but it's also a micro-optimization.

Wed, Feb 7, 6:33 AM · Frameworks, Plasma

Tue, Feb 6

hein added a comment to T7284: Launch feedback.

Merged.

Tue, Feb 6, 10:42 AM · Plasma: KCM Redesign
hein committed R119:25c30932961e: Port launch feedback KCM to Qt Quick and implement VDG redesign (authored by hein).
Port launch feedback KCM to Qt Quick and implement VDG redesign
Tue, Feb 6, 10:41 AM
hein closed D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.
Tue, Feb 6, 10:41 AM · Plasma
hein committed R120:7abd8d0da447: Fix dupe handling in requestAddLauncherToActivities; improve unit test (authored by hein).
Fix dupe handling in requestAddLauncherToActivities; improve unit test
Tue, Feb 6, 10:28 AM
hein closed D10253: Fix dupe handling in requestAddLauncherToActivities; improve unit test.
Tue, Feb 6, 10:28 AM · Plasma
hein added a comment to D10263: Fix being unable to close the toolbox menu by clicking outside.

Empty desktop doesn't close it for me without this patch.

Tue, Feb 6, 10:25 AM · Plasma
hein added a comment to D9207: Don't load KDE platform module in kglobalaccel5.

Well, the maintainer spoke out against it, so not much I can do.

Tue, Feb 6, 10:18 AM · Frameworks, Plasma
hein accepted D10328: [Task Manager] Use KFilePlacesModel::isHidden.
Tue, Feb 6, 6:09 AM · Plasma
hein accepted D10327: [LauncherTasksModel] Support applications: URLs in requestOpenUrls.

I can't help but feel increasingly bad about the whole applications: URLs thing. If we have to patch 5000 places something is not right. We need to come up with a better way some time soon. What are we doing wrong? Maybe we should just pass KServices around? Hmm.

Tue, Feb 6, 6:08 AM · Plasma

Mon, Feb 5

hein committed R119:db42961ad4d8: Improve preview thumbnail quality (authored by hein).
Improve preview thumbnail quality
Mon, Feb 5, 3:09 PM
hein closed D10223: Improve preview thumbnail quality.
Mon, Feb 5, 3:09 PM · Plasma
hein added a comment to D10223: Improve preview thumbnail quality.

Before:

Mon, Feb 5, 11:37 AM · Plasma
hein accepted D10316: [Folder View] Let Alt+Enter open properties dialog.
Mon, Feb 5, 10:49 AM · Plasma

Fri, Feb 2

hein added a comment to D10251: [RFC] Use mipmap filtering in window thumbnails.

It's definitely nicer, but could we go for the full thing and make it crisper too?

Fri, Feb 2, 6:18 PM · Frameworks, Plasma

Thu, Feb 1

hein added a comment to D10223: Improve preview thumbnail quality.
Thu, Feb 1, 3:01 PM · Plasma
hein added a comment to D10223: Improve preview thumbnail quality.

Random by-passer nitpick comment: "twice as large thumbnails"... actually 4 x large in pixels, given you scale 2x in two dimensions ;)

Thu, Feb 1, 3:00 PM · Plasma

Sat, Jan 27

hein added a comment to D10118: Don't unconditionally enable the keyboard geometry parser.

I believe that port away from boost will fix the problem

IIRC the problem isn't with boost at large, it's that the code uses insanely deep recursive templates.

Sat, Jan 27, 12:01 PM · Plasma
hein added a comment to D10118: Don't unconditionally enable the keyboard geometry parser.

This looks up my PC several times a week. I lose work regularly because of it, and often can't finish compiling plasma-desktop successfully. I'm very +1 for killing it.

Sat, Jan 27, 10:52 AM · Plasma

Jan 25 2018

hein committed R108:977a5ef012c2: Reverted accidental file permission changes (authored by anemeth).
Reverted accidental file permission changes
Jan 25 2018, 6:33 PM
hein closed D10100: Reverted accidental file permission changes.
Jan 25 2018, 6:33 PM · KWin
hein accepted D10100: Reverted accidental file permission changes.
Jan 25 2018, 6:32 PM · KWin
hein committed R108:0179f741bbd4: Updated the blur method to use the more efficient dual kawase blur algorithm. (authored by anemeth).
Updated the blur method to use the more efficient dual kawase blur algorithm.
Jan 25 2018, 5:33 PM
hein closed D9848: Updated the blur method to use the more efficient dual kawase blur algorithm..
Jan 25 2018, 5:32 PM · Plasma
Restricted Application edited projects for D9848: Updated the blur method to use the more efficient dual kawase blur algorithm., added: Plasma; removed KWin.

@anemeth The patch doesn't apply cleanly to current master. Would you mind rebasing it please? I don't want to introduce errors at this stage by editing code I didn't review.

Jan 25 2018, 2:38 PM · Plasma
Restricted Application edited projects for D9848: Updated the blur method to use the more efficient dual kawase blur algorithm., added: KWin; removed Plasma.

I'll push this for you (I'm interpreting Martin's resignation as withdrawing objections, knock on wood).

Jan 25 2018, 2:24 PM · Plasma
hein added a comment to D10015: Added the option to enable blur behind the window.

Related: https://phabricator.kde.org/D10063#195943

Jan 25 2018, 2:19 PM · Konsole
hein requested changes to D10063: [Yakuake] Blurs behind the window if the profile color setting is enabled.

Identical patches to this one have been written a few times and are strewn about Phabricator and ReviewBoard (defunct), but all suffer similar problems:

Jan 25 2018, 2:19 PM

Jan 24 2018

hein accepted D10080: ensure the rounded rectangle of scrollbard stays round.

Great Yaynessings

Jan 24 2018, 4:25 PM · Plasma

Jan 23 2018

hein accepted D9325: Use QUrl in the ScreenMapper API.
Jan 23 2018, 1:06 PM · Plasma
hein accepted D10026: Fix loading NotifyByExecute.
Jan 23 2018, 12:57 PM · Frameworks

Jan 22 2018

hein committed R119:6b2996a6d10c: Merge branch 'Plasma/5.12' (authored by hein).
Merge branch 'Plasma/5.12'
Jan 22 2018, 10:36 AM
hein committed R119:19796bc57165: Make sure the search result that Return will run is highlighted (authored by hein).
Make sure the search result that Return will run is highlighted
Jan 22 2018, 10:35 AM
hein closed D9962: Make sure the search result that Return will run is highlighted.
Jan 22 2018, 10:35 AM · Plasma
hein committed R119:fc155e94457d: Don't close plasmoid when closing a subdialog (authored by hein).
Don't close plasmoid when closing a subdialog
Jan 22 2018, 10:34 AM