hein (Eike Hein)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:07 PM (248 w, 4 d)
Availability
Available

Recent Activity

Yesterday

hein committed R1034:8f10a4aef6df: Merge branch 'style' into 'master' (authored by hein).
Merge branch 'style' into 'master'
Sun, Jan 19, 4:51 PM
hein committed R1034:bbbcb78e66e7: Update gstreamerintegration.cpp (authored by hein).
Update gstreamerintegration.cpp
Sun, Jan 19, 4:50 PM
hein committed R1034:031b2a1a27e8: Merge branch 'video_tests' into 'master' (authored by hein).
Merge branch 'video_tests' into 'master'
Sun, Jan 19, 4:49 PM

Sat, Jan 18

hein committed R1034:3cafa675ff0a: Merge branch 'use_any_of' into 'master' (authored by hein).
Merge branch 'use_any_of' into 'master'
Sat, Jan 18, 4:26 PM
hein committed R1034:51035de818ba: Merge branch 'add_unused' into 'master' (authored by hein).
Merge branch 'add_unused' into 'master'
Sat, Jan 18, 4:26 PM
hein committed R1034:ecab6b426902: Merge branch 'remove_gcs' into 'master' (authored by hein).
Merge branch 'remove_gcs' into 'master'
Sat, Jan 18, 4:26 PM
hein committed R1034:7991c4cc2e39: Merge branch 'fix_setController' into 'master' (authored by hein).
Merge branch 'fix_setController' into 'master'
Sat, Jan 18, 4:25 PM

Sat, Jan 11

hein accepted D25925: Mark applications that play audio, for all task icon sizes.
Sat, Jan 11, 12:25 AM · Plasma

Tue, Jan 7

hein accepted D26386: Kicker/RecentDocuments: add icons to actions.

Good stuff!

Tue, Jan 7, 11:21 PM · Plasma
hein accepted D26482: [Folder view] Don't create a rubberband when dragging during a rename.
Tue, Jan 7, 11:20 PM · Plasma

Mon, Jan 6

hein added a comment to T12488: Use a different repo for the new version of the Breeze widget style and come up with a name for it.

The VDG channel somehow ended up liking "Yoto" a lot!

Mon, Jan 6, 6:01 PM · VDG, Plasma, Breeze
hein added a comment to T12488: Use a different repo for the new version of the Breeze widget style and come up with a name for it.

"Blast"

Mon, Jan 6, 5:26 PM · VDG, Plasma, Breeze
hein added a comment to D25925: Mark applications that play audio, for all task icon sizes.

That's good with me, the rest of the patch is good and much appreciated.

Mon, Jan 6, 5:23 PM · Plasma
hein added a comment to D25925: Mark applications that play audio, for all task icon sizes.

Maybe there's a third option: Another precedent we already have is the circular carve-out we use for the notification number badge. Perhaps we could reuse that for the indicator.

Mon, Jan 6, 3:57 PM · Plasma
hein added a comment to D25925: Mark applications that play audio, for all task icon sizes.

I'm still not a big fan of the Glow for a number of reasons:

Mon, Jan 6, 3:44 PM · Plasma

Sun, Jan 5

hein added a comment to T11915: Commission new official version of the KDE logo with the word "KDE" next to it or below it.

Thanks everyone!

Sun, Jan 5, 8:41 PM · VDG, KDE Promo

Sat, Jan 4

hein accepted D26086: Don't fetch pixmap if we have it already.
Sat, Jan 4, 11:06 PM · Plasma
hein accepted D26378: [Download Plugin] Register downloaded files as recent documents.

I love it.

Sat, Jan 4, 6:15 PM · Plasma
hein added a comment to T11915: Commission new official version of the KDE logo with the word "KDE" next to it or below it.

Since we have consensus, let's expand the clipart page? :)

Sat, Jan 4, 1:33 PM · VDG, KDE Promo
hein accepted D26409: [kicker] Use arrow functions in signal handlers.
Sat, Jan 4, 8:30 AM · Plasma
hein added a comment to T12192: Tweak SimpleMenu layout and replace Kickoff.

@chwmpfling Definitely the plan! Will appreciate your review

Sat, Jan 4, 8:25 AM · Plasma, VDG
hein accepted D26406: [kicker] Fix some unqualified root property access.
Sat, Jan 4, 12:27 AM · Plasma

Fri, Jan 3

hein added a comment to D26385: Kicker/RecentDocuments Avoid referring to hidden places.

We can revisit it after some more discussion.

Fri, Jan 3, 7:30 PM · Plasma
hein requested changes to D26385: Kicker/RecentDocuments Avoid referring to hidden places.
Fri, Jan 3, 7:09 PM · Plasma
hein reopened D26385: Kicker/RecentDocuments Avoid referring to hidden places.
Fri, Jan 3, 7:09 PM · Plasma
hein added a comment to D26385: Kicker/RecentDocuments Avoid referring to hidden places.

I don't agree with this patch. Hiding a place or section from the Places panel doesn't mean the user didn't add it and it's not to be used. We don't hide it from Folder View's config or relative title generator either. Hidden is not removed. Please revert.

Fri, Jan 3, 7:09 PM · Plasma
hein requested changes to D26386: Kicker/RecentDocuments: add icons to actions.

It should be iconName after label.

Fri, Jan 3, 7:01 PM · Plasma
hein committed R1034:279b4b017ea0: Merge branch 'parameter_model' into 'master' (authored by hein).
Merge branch 'parameter_model' into 'master'
Fri, Jan 3, 1:00 PM

Thu, Jan 2

hein accepted D26147: Kickoff computer tab : don't display filepath for places in description.
Thu, Jan 2, 6:16 PM · Plasma

Sat, Dec 28

baberts awarded T12192: Tweak SimpleMenu layout and replace Kickoff a Love token.
Sat, Dec 28, 11:22 PM · Plasma, VDG
hein added a comment to D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default.

It's definitely a discussion I'd enjoy more :)

Sat, Dec 28, 5:55 AM · Plasma
hein accepted D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default.

Ah sorry, I had a reply typed into the text field but must have botched hitting Submit.

Sat, Dec 28, 3:01 AM · Plasma
hein accepted D25762: Only serialize window pixmap if we're using it.

Nice :)

Sat, Dec 28, 2:57 AM · Plasma
hein added a comment to T12192: Tweak SimpleMenu layout and replace Kickoff.

Should it be possible to configure the icon size for grid view?

Sat, Dec 28, 1:05 AM · Plasma, VDG

Thu, Dec 26

hein committed R1034:6092b67bd747: Merge branch 'position_source' into 'master' (authored by hein).
Merge branch 'position_source' into 'master'
Thu, Dec 26, 10:21 PM
hein added a comment to T12192: Tweak SimpleMenu layout and replace Kickoff.

This is also possible in all of the other menus based on the backend, so that's sensible, yeah.

Thu, Dec 26, 9:08 PM · Plasma, VDG
hein committed R1034:8aa804e71cce: Update CMakeLists.txt (authored by hein).
Update CMakeLists.txt
Thu, Dec 26, 7:25 PM

Tue, Dec 24

hein committed R1034:9ff33b7fa6ca: Merge branch 'set_taw' into 'master' (authored by hein).
Merge branch 'set_taw' into 'master'
Tue, Dec 24, 2:58 AM
hein committed R1034:47a4d966bd53: Merge branch 'fix_pitch' into 'master' (authored by hein).
Merge branch 'fix_pitch' into 'master'
Tue, Dec 24, 2:57 AM

Mon, Dec 23

alexde awarded T12192: Tweak SimpleMenu layout and replace Kickoff a Love token.
Mon, Dec 23, 5:31 PM · Plasma, VDG
hein committed R1034:31417b502297: Merge branch 'pragma_once' into 'master' (authored by hein).
Merge branch 'pragma_once' into 'master'
Mon, Dec 23, 4:42 PM
hein committed R1034:ad8102a749f3: Merge branch 'fix_pitchbar' into 'master' (authored by hein).
Merge branch 'fix_pitchbar' into 'master'
Mon, Dec 23, 4:41 PM
hein committed R1035:991ff330b230: Update faq.md (authored by hein).
Update faq.md
Mon, Dec 23, 4:41 PM
hein committed R1034:fa0ef70dee98: Update README.md (authored by hein).
Update README.md
Mon, Dec 23, 4:39 PM
hein committed R1035:dd9c187d6308: Update faq.md (authored by hein).
Update faq.md
Mon, Dec 23, 4:39 PM
hein committed R1035:4371d96f98ae: Update index.html (authored by hein).
Update index.html
Mon, Dec 23, 4:37 PM
hein committed R1035:c8fd71f4a5d1: Update faq.md (authored by hein).
Update faq.md
Mon, Dec 23, 4:36 PM
hein committed R1035:d2854d582274: Update index.html (authored by hein).
Update index.html
Mon, Dec 23, 4:35 PM
hein committed R1034:1f4bef254bc6: Tune the language (authored by hein).
Tune the language
Mon, Dec 23, 4:33 PM
hein committed R1034:530856846251: Merge branch 'mavlink_option' into 'master' (authored by hein).
Merge branch 'mavlink_option' into 'master'
Mon, Dec 23, 4:26 PM
hein added a comment to T12192: Tweak SimpleMenu layout and replace Kickoff.

Some notes while I start working on implementation:

Mon, Dec 23, 4:20 PM · Plasma, VDG
hein committed R1034:a0a113646c61: Merge branch 'yaw' into 'master' (authored by hein).
Merge branch 'yaw' into 'master'
Mon, Dec 23, 4:00 PM
hein committed R1034:3adb663e9cf7: Merge branch 'gitignore' into 'master' (authored by hein).
Merge branch 'gitignore' into 'master'
Mon, Dec 23, 3:58 PM
hein committed R1034:f8042da6e0a5: Merge branch 'semi-circle' into 'master' (authored by hein).
Merge branch 'semi-circle' into 'master'
Mon, Dec 23, 2:46 AM
hein committed R1034:7b1192a5aa94: Disable MAVLink plugin until it's build-time optional (authored by hein).
Disable MAVLink plugin until it's build-time optional
Mon, Dec 23, 2:32 AM
hein committed R1034:5a181438a767: Update PitchBar.qml (authored by hein).
Update PitchBar.qml
Mon, Dec 23, 2:26 AM
hein committed R1034:cdad1865a1ac: Merge branch 'pitch' into 'master' (authored by hein).
Merge branch 'pitch' into 'master'
Mon, Dec 23, 2:25 AM
hein committed R1034:67b8f69f9162: Merge branch 'mavlink' into 'master' (authored by hein).
Merge branch 'mavlink' into 'master'
Mon, Dec 23, 2:20 AM
hein committed R1035:dbab17a2f116: Update contact.md (authored by hein).
Update contact.md
Mon, Dec 23, 2:16 AM
hein committed R1035:346c286f427f: Add Telegram group info (authored by hein).
Add Telegram group info
Mon, Dec 23, 2:16 AM

Sun, Dec 22

hein accepted D25844: Don't compress tasks before grouping, when task manager is vertical.
Sun, Dec 22, 9:25 PM · Plasma
hein committed R1034:29673305f932: Update CMakeLists.txt (authored by hein).
Update CMakeLists.txt
Sun, Dec 22, 9:20 PM
hein committed R1034:84d30286b6d0: Merge branch 'clang-format' into 'master' (authored by hein).
Merge branch 'clang-format' into 'master'
Sun, Dec 22, 9:20 PM
hein added inline comments to D25925: Mark applications that play audio, for all task icon sizes.
Sun, Dec 22, 9:13 PM · Plasma
hein committed R1034:1374a15e39bd: Merge branch 'appendOnTemporary' into 'master' (authored by hein).
Merge branch 'appendOnTemporary' into 'master'
Sun, Dec 22, 8:58 PM
hein committed R1034:300b303a0608: Merge branch 'add_patrick' into 'master' (authored by hein).
Merge branch 'add_patrick' into 'master'
Sun, Dec 22, 8:47 PM
hein requested changes to D26147: Kickoff computer tab : don't display filepath for places in description.

The return QString() shouldn't be necessary if we just fall through to the final return.

Sun, Dec 22, 4:22 PM · Plasma
hein accepted D26121: Kicker/RecentDocument display file path as decoration.
Sun, Dec 22, 4:20 PM · Plasma

Dec 18 2019

hein accepted D25874: [Task Manager] Consider parent PID for audio stream.
Dec 18 2019, 4:41 PM · Plasma

Dec 17 2019

hein added a comment to D25874: [Task Manager] Consider parent PID for audio stream.

Just as a sanity check: libtm knows the pid for a window. Have you checked if there might be a faster way of doing this by checking if the stream pid is among its children?

Dec 17 2019, 3:51 PM · Plasma
hein added a comment to D25762: Only serialize window pixmap if we're using it.

Ah right, I didn't look at the code context and forgot we don't just load the custom pixmap in the same function body but also in Private::icon. But we also do this there:

Dec 17 2019, 3:43 PM · Plasma
hein added a comment to D25762: Only serialize window pixmap if we're using it.

If the concern is that QIcon::name isn't good enough but we actually have an icon inside, why don't we just change the check to QIcon::isNull?

Dec 17 2019, 9:48 AM · Plasma

Dec 15 2019

hein committed R1034:4b1ad0408ce5: Merge branch 'user_feedback' into 'master' (authored by hein).
Merge branch 'user_feedback' into 'master'
Dec 15 2019, 3:19 PM
hein committed R1034:742f8405e7eb: Coding style cleanups. (authored by hein).
Coding style cleanups.
Dec 15 2019, 3:07 PM
hein committed R1034:38e21aa716c9: Minor cleanup. (authored by hein).
Minor cleanup.
Dec 15 2019, 3:05 PM
hein committed R1034:2f392434a3d2: Copy-edit comment. (authored by hein).
Copy-edit comment.
Dec 15 2019, 3:04 PM
hein committed R1034:fe1254fad326: Copy-edit comment. (authored by hein).
Copy-edit comment.
Dec 15 2019, 3:03 PM
hein committed R1034:f96ffe13099d: Merge branch 'joystick' into 'master' (authored by hein).
Merge branch 'joystick' into 'master'
Dec 15 2019, 3:00 PM
hein committed R1034:067082dbc558: Merge branch 'help_dev' into 'master' (authored by hein).
Merge branch 'help_dev' into 'master'
Dec 15 2019, 2:57 PM

Dec 12 2019

hein added a comment to D23242: Add grouping and "Show Only Minimized" options to icons-only task manager.

Let's go for it, it's fairly in line with the TM applet refectoring we planned in Valencia at the end of the day

Dec 12 2019, 5:53 PM · Plasma
hein accepted D23039: Make Kickoff restore favorites order when dragging an item to desktop.

Good one, thanks!

Dec 12 2019, 5:51 PM · Plasma

Dec 10 2019

The-Feren-OS-Dev awarded T12192: Tweak SimpleMenu layout and replace Kickoff a Love token.
Dec 10 2019, 3:34 PM · Plasma, VDG

Dec 8 2019

romangg awarded T12192: Tweak SimpleMenu layout and replace Kickoff a Love token.
Dec 8 2019, 10:43 AM · Plasma, VDG
hein added a comment to T12192: Tweak SimpleMenu layout and replace Kickoff.

No, Recently Used works via KActivitiesStats.

Dec 8 2019, 12:48 AM · Plasma, VDG

Dec 5 2019

hein added a comment to D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default.

I don't really understand why the panel being bare by default is a problem. Isn't it nicer when users don't have to opt out of clutter like this?

Dec 5 2019, 10:00 PM · Plasma
hein added a comment to T12322: Add additional filters to planet.kde.org.
Dec 5 2019, 4:18 PM · Websites
hein added a comment to T12322: Add additional filters to planet.kde.org.

In the discussion you said you don't read the Planet, but when you were pointed at this post it lead you to complain about politics on the Planet, so the post seems relevant and this solution doesn't address the cause for us discussing it. That seems like a broken solution so between this and the other stuff I would say -1 as it seems like even with the solution you'd be likely to complain about community consensus again.

Dec 5 2019, 4:17 PM · Websites
hein added a comment to T12322: Add additional filters to planet.kde.org.

We currently have two proposals for how to implement your filter proposal:

Dec 5 2019, 4:07 PM · Websites
hein added a comment to T12322: Add additional filters to planet.kde.org.

I'm not calling anyone bad for having differing opinions to mine, I am calling out that it's bad to go against community consensus without respecting it and acting accordingly. Restarting a debate without bringing something new to the table was bad. My own individual opinion doesn't matter - that's in fact the point. I'm not sure why this is so hard to understand.

Dec 5 2019, 3:58 PM · Websites
hein added a comment to T12322: Add additional filters to planet.kde.org.

I think goes a bit against the code of conduct.

Dec 5 2019, 3:23 PM · Websites
hein added a comment to T12322: Add additional filters to planet.kde.org.

I'm not in favor of implementing content scanning and profiling based on keywords on the Planet.

Dec 5 2019, 3:07 PM · Websites
hein added a comment to T12322: Add additional filters to planet.kde.org.

I don't know how such a filter could work in practice. There's no consensus on when a political topic is a KDE matter or not, as we e.g. saw in the climate change debate recently. As an international community that heavily relies on free traversal of borders many political issues are in our scope, too. Then there's patents, privacy which is a community goal(!), ... And Planet KDE is explicitly not a project news feed - the description of the planet says it's for personal blogs - so a filter based on whether a post is about a project or not would seem go go along its nature. Plus the e.V. and community matters are also "projects" in some sense.

Dec 5 2019, 2:55 PM · Websites
hein added a comment to T12321: Improve awareness of Planet's content policy.

This ticket is for making the existing rules more visible, not a filter mechanism, though.

Dec 5 2019, 1:23 PM · Websites

Dec 4 2019

hein claimed T12192: Tweak SimpleMenu layout and replace Kickoff.
Dec 4 2019, 10:00 AM · Plasma, VDG
hein added a comment to T12192: Tweak SimpleMenu layout and replace Kickoff.

I plan to put time into implementing the mockup this month with the above feature/change list.

Dec 4 2019, 9:53 AM · Plasma, VDG

Dec 3 2019

hein committed R134:b69636a6bfdc: Fix typo (authored by hein).
Fix typo
Dec 3 2019, 7:43 PM
hein committed R134:27e924165711: Fix display name; fix context menu action name (authored by hein).
Fix display name; fix context menu action name
Dec 3 2019, 7:41 PM

Dec 2 2019

hein committed R1035:507f9a55f86d: Update download.md (authored by hein).
Update download.md
Dec 2 2019, 1:45 AM

Nov 26 2019

hein accepted D23837: Rename action name to make it consistent with other applications.
Nov 26 2019, 8:28 PM · Documentation
hein added a comment to T12258: Change nameservers of kirogi.org.

Updated for the domain, feel free to close from your end. Thanks!

Nov 26 2019, 8:11 PM · Sysadmin