- User Since
- Apr 15 2015, 5:07 PM (127 w, 2 d)
Thu, Sep 21
Wed, Sep 20
Tue, Sep 19
Sun, Sep 17
Sat, Sep 16
I.e. this keeps the interface unchanged because the parameter-passing to the old method didn't actually work, or what is the idea here?
Fri, Sep 15
The patch makes sense, but doesn't this indicate we screwed up something conceptually because the user now needs to set font dpi in awareness they'll be scaled after instead of set directly?
Thu, Sep 14
This is not acceptable as it breaks public D-Bus API.
Wed, Sep 13
Tue, Sep 12
Yeah this one looks odd to me too as per David ...
I'm open to different approaches.
Mon, Sep 11
Sun, Sep 10
Fri, Sep 8
So I assume the bug was that I was getting too many favorites? Limit::all is now unlimited I assume? Otherwise it needs to be integrated with the maxFavorites stuff to disable the actions. (Does maxFavorites still work BTW? Because it's needed for Simple Menu on the KDE Store.)
Thu, Sep 7
Test failure using Kicker:
Wed, Sep 6
Yep, still the plan. Updating the task would be highly useful and appreciated! @jensreuterberg is working on assets currently.
Tue, Sep 5
It aaaalmost looked good, but I got this bug back:
^ What's new in the latest rev?
Both this and org.kde.klimbgrades are currently failing because they pull in Kirigami master which needs KF5 5.38. How should we proceed to fix this?
Mon, Sep 4
With the updated kactivitymanagerd the missing favorite no longer happens, although the "also add it on the second activity by checking item" step inserts it in a strange position of last-2 instead of appending it on the same applet on the other activity - considering all the other faves in the test are shared, I'd expect it to appear the end (where it also was on the first activity). Still, progress!
Should I add it to top-level then instead of todo/? Does anything else need to be done after or will it start generating packages and putting them into the repo at next run?
After the port, all launchers have the same items on the top, with the new items added to the end. Do you have any speial URL formats in your original favorites (preferred: needed special treatment, that is why I'm asking)? Can you check whether the plasma configuration file has the correct order?
And another round of testing:
Sat, Sep 2
The Kickoff thing looks more like a model bug to me - there's a duplicate delegate for "Firefox", and one of them has a broken row index (-1). Stuff like that is usually the result of confusing the view with broken model transactions ... the QML is very simple (that binding loop is a subitem of the delegate so it's not relevant to the placement) and just plain ListView really.
kactivities-stats hasn't built for me in a long time fwiw:
Add Kirigami master ala Klimbgrades' recipe.
From https://www.mankier.com/5/flatpak-manifest I'm not 100% sure
the top-level branch applies to the git module source, so specify
for good measure.
Note: I need a debugfull build because the --nui CLI arg (that bypasses the single-instance application mechanic and allows running multiple Konversation instances) is only available in debug builds.
Thu, Aug 31
Good news: There's actually nothing to do on the favorite ids, Kicker already uses KService::storageId as favorite id, which will be the menuId when it's available.
I haven't managed to make this work. The problem is that the favourites are added asynchronously, and setting the ordering for a bunch of them at once fails because the items do not exist.
Does this have any ramifications in widget mode (panel, etc)?
Looks good, go.
Wed, Aug 30
No, thatfeels even more convoluted :(. Let's keep the current patch UI and focus on merge, we'll talk to the VDG about the UI after.