hein (Eike Hein)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:07 PM (214 w, 4 d)
Availability
Available

Recent Activity

Fri, May 24

hein committed R917:8a85d0e3b7c3: Add newly-elected members (authored by hein).
Add newly-elected members
Fri, May 24, 7:48 AM

Thu, May 23

hein added a comment to D21336: Get PaginateModel class ready for frameworks.

I wouldn't call this implementation ready for frameworks, though - it just resets all the time, which is very slow as it forces views to destroy and recreate delegates instead of just updating them. A better implementation would just (re)filter source rows corresponding to the current page. This could be done as a subclass of QSortFilterProxyModel or custom; KItemModels' KRearrangeColumnsProxyModel can serve as inspiration to some degree. As it stands I wouldn't uactually use this if it was in the framework.

Thu, May 23, 6:26 AM · Plasma
hein added a comment to D21358: Prevent the Yakuake Task from Showing up in the Task Bar.

It's not that easy I'm afraid.

Thu, May 23, 6:12 AM · Yakuake

Mon, May 13

hein added a comment to D21169: Add app icon for the Kirogi Drone control app.

I'd say it's up to the Breeze maintainers. From my end I'm very interested in the app having a Breeze-compatible icon, because I'd like it to integrate well with KDE's workspaces and other apps. Review by the Breeze community is very appreciated to help with that. Application code needs to ship the icon anyway though for systems that don't have the theme and can't be reasonably expected to provide every app icon, so it's not vital to be included with the theme.

Mon, May 13, 5:02 PM · Frameworks
hein added a comment to D21169: Add app icon for the Kirogi Drone control app.

@trickyricky26 It's great! What do you think about adding the detailed SVG as 256 version?

Mon, May 13, 2:14 PM · Frameworks

Mon, May 6

hein added inline comments to D20265: Introduce libnotificationmanager.
Mon, May 6, 11:46 AM · Plasma

Sun, May 5

hein accepted D20863: Allow folder view elements to be be dropped using other Action than Copy.
Sun, May 5, 4:17 PM · Plasma
hein added inline comments to D20265: Introduce libnotificationmanager.
Sun, May 5, 9:55 AM · Plasma
hein added inline comments to D20265: Introduce libnotificationmanager.
Sun, May 5, 9:54 AM · Plasma
hein added inline comments to D20265: Introduce libnotificationmanager.
Sun, May 5, 9:51 AM · Plasma
hein added inline comments to D20265: Introduce libnotificationmanager.
Sun, May 5, 9:49 AM · Plasma
hein added inline comments to D20265: Introduce libnotificationmanager.
Sun, May 5, 9:18 AM · Plasma
hein added inline comments to D20265: Introduce libnotificationmanager.
Sun, May 5, 8:52 AM · Plasma

Tue, Apr 30

hein accepted D20851: [Pager] Improve label legibility.
Tue, Apr 30, 5:28 AM · Plasma
hein added a comment to D20908: RFC: Redesign QML applet configuration windows.

Looks great to me. Subtle visual refreshs like this are very appreciated, especially when they improve consistency, too.

Tue, Apr 30, 5:01 AM · Plasma

Apr 26 2019

hein accepted D20846: [Task Manager] Don't show redundant "Actions" header in context menu with nothing but actions in it.
Apr 26 2019, 11:29 PM · Plasma
hein accepted D20117: Remove forcing the initial dir to QDir::homePath().
Apr 26 2019, 3:19 PM

Apr 24 2019

hein accepted D20773: [Task Manager] Bring to current desktop with middle-click.
Apr 24 2019, 8:18 AM · Plasma

Apr 22 2019

hein accepted D20743: [Kicker] Modernize settings window.
Apr 22 2019, 6:39 PM · Plasma
hein accepted D20612: [Kickoff] Modernize settings window layout.

LGTM.

Apr 22 2019, 3:26 PM · Plasma

Apr 15 2019

hein added a comment to D20569: RFC: Use more compact OSD.

Personally I'm not a big fan. I think the square OSD has more character and visual flair. The change proposed here looks rather cramped and removes some identity from the system.

Apr 15 2019, 9:01 AM · Plasma
hein accepted D20469: Add DesktopEntry to notifyrc.
Apr 15 2019, 7:16 AM

Apr 14 2019

hein accepted D20494: Add DesktopEntry to notifyrc.
Apr 14 2019, 8:12 AM

Apr 10 2019

hein accepted D20428: separe mobile text selection to avoid recursive imports.

Works here now, thx!

Apr 10 2019, 11:29 AM · Frameworks

Apr 9 2019

hein committed R32:5e17ba4cd7a5: Fix build on Qt 5.13 branch (authored by hein).
Fix build on Qt 5.13 branch
Apr 9 2019, 10:43 PM
hein closed D20419: Fix build on Qt 5.13 branch.
Apr 9 2019, 10:43 PM · KDevelop
hein accepted D20420: [Folder View] use Math.floor() instead of Math.round().
Apr 9 2019, 9:56 PM · Plasma
hein committed R242:846741f851c6: Revert "use the right namespace" (authored by hein).
Revert "use the right namespace"
Apr 9 2019, 9:55 PM
hein added a reverting change for R242:067ec2eafcbe: use the right namespace: R242:846741f851c6: Revert "use the right namespace".
Apr 9 2019, 9:55 PM
hein added a reverting change for R242:c72ee78bbbc4: mov the mobile text actions in own import: R242:a280cccfde66: Revert "mov the mobile text actions in own import".
Apr 9 2019, 9:55 PM
hein committed R242:a280cccfde66: Revert "mov the mobile text actions in own import" (authored by hein).
Revert "mov the mobile text actions in own import"
Apr 9 2019, 9:55 PM
hein requested review of D20419: Fix build on Qt 5.13 branch.
Apr 9 2019, 9:38 PM · KDevelop
hein added a comment to D20407: [Folder View] Improve label crispness.

I think it would be safer to Math.floor() rather than Math.round().

Apr 9 2019, 9:15 PM · Plasma

Apr 8 2019

hein accepted D20370: [Folder View] Implement a user-configurable setting for label width.
Apr 8 2019, 3:50 PM · Plasma
hein accepted D20368: [Folder View] Use a more reasonable minimum cell width.
Apr 8 2019, 9:29 AM · Plasma

Apr 6 2019

hein committed R917:45b2366d352a: Update the member roster for the FiWG (authored by hein).
Update the member roster for the FiWG
Apr 6 2019, 2:54 AM

Apr 5 2019

hein updated the diff for D20237: Port to new KWorkspace API.

Fix refcounting

Apr 5 2019, 4:47 PM · Plasma
hein added a comment to D20237: Port to new KWorkspace API.

Personally I tend to prefer just readable, explicit code for simple cases.

Now the timing of my comment becomes awkward :/

Apr 5 2019, 4:44 PM · Plasma
hein accepted D19874: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use smallSpacing.

@hein what's your opinion on reducing the margins?

Apr 5 2019, 3:32 PM · Plasma

Apr 4 2019

hein added inline comments to D20237: Port to new KWorkspace API.
Apr 4 2019, 9:43 PM · Plasma
hein updated the diff for D20237: Port to new KWorkspace API.

Do some cleanups suggested by Kai.

Apr 4 2019, 9:41 PM · Plasma
hein added inline comments to D20237: Port to new KWorkspace API.
Apr 4 2019, 9:35 PM · Plasma
hein added inline comments to D20237: Port to new KWorkspace API.
Apr 4 2019, 9:24 PM · Plasma
hein added inline comments to D20237: Port to new KWorkspace API.
Apr 4 2019, 12:39 PM · Plasma

Apr 3 2019

hein updated the diff for D20237: Port to new KWorkspace API.

Fix up qDeleteAll usage, thanks David

Apr 3 2019, 9:51 PM · Plasma
hein added a dependent revision for D19389: [WIP] Rewrite kworkspace logout, shutdown and suspend API: D20237: Port to new KWorkspace API.
Apr 3 2019, 9:00 PM · Plasma
hein requested review of D20237: Port to new KWorkspace API.
Apr 3 2019, 9:00 PM · Plasma
hein accepted D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.
Apr 3 2019, 5:59 PM · Plasma
hein added a comment to D19926: Add Bookmark Handling.

Suuper good question that I also don't have a really good answer to :( But it's always super good when a project figures out how to answer it (e.g. Krita took off after it made a call to be a painting app).

Apr 3 2019, 5:32 PM · Dolphin
hein added a comment to D19926: Add Bookmark Handling.

I'm not sure the "Konqueror had it and people are asking
for it back" argument is strong. Because Konqueror was also unpopular enough to get replaced by Dolphin and to end up largely unmaintained (although it is still released and available). To me that indicates that becoming more like Konqueror may actually be the wrong direction.

Apr 3 2019, 8:27 AM · Dolphin
hein added a comment to D19926: Add Bookmark Handling.
Apr 3 2019, 8:23 AM · Dolphin

Apr 2 2019

hein added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

About the icon issue, IconItem by default uses the icon theme overlay from the Plasma theme, Kirigami.Icon will use the regular Plasma icons. That's kind of tricky - with Breeze we could totally make them match, but other Plasma themes would have issues.

Apr 2 2019, 9:26 PM · Plasma
hein added a comment to T10755: Unifying Applications' release versions.

Sure, why would the release team bump an individual app version if it wants to follow a random scheme?

Apr 2 2019, 8:56 PM
hein added a comment to D20205: initialize the kcolorscheme at the first app start.

Or the QPA could look at the LnF in the first place instead of kdeglobals?

Apr 2 2019, 7:50 PM · Plasma
hein added a comment to T10755: Unifying Applications' release versions.
In T10755#180963, @hein wrote:

That just seems to describe how you can make your app follow the KDE Apps YY.MM version number, not how Release Team can bump an individual app version number.

Looks like we have a subtask: Make sure all apps in "KDE Applications" store version numbers in a unified place, even if the version is not being bumped by script.

Apr 2 2019, 7:42 PM
hein added a comment to T10755: Unifying Applications' release versions.
In T10755#180958, @hein wrote:

But bumping version numbers is a technical problem that can have a technical solution.

It's not a problem. we've been doing that for years https://community.kde.org/Guidelines_and_HOWTOs/Application_Versioning

Apr 2 2019, 7:39 PM
hein added a comment to D19926: Add Bookmark Handling.

The Places panel is really for frequent and immediate access whereas bookmarks are more for long-term organization.

Apr 2 2019, 7:21 PM · Dolphin
hein added a comment to T10755: Unifying Applications' release versions.

On the other hand, having the release team take care of all of this stuff automatically and on a predictable schedule is really nice.

Apr 2 2019, 7:05 PM
hein added a comment to T10755: Unifying Applications' release versions.

But if all ‘KDE Applications’ applications used the ‘KDE Applications’ version number, KPat wouldn’t have to manage its version number …

Apr 2 2019, 7:01 PM
hein added a comment to D19926: Add Bookmark Handling.

Hang on, isn't this kind of redundant with Places? At the very least they overlap a lot. Is this feature individually strong enough to warrant that overlap?

Apr 2 2019, 6:54 PM · Dolphin
hein added a comment to T10755: Unifying Applications' release versions.

So version ‘3.6’ can mean a number of different versions, each with its own sets of bugs and features.

Apr 2 2019, 6:53 PM
hein added a comment to T10755: Unifying Applications' release versions.

I don't find being part of KDE Applications releases very compelling for many of my apps. The reasons vary - some are alternatives to other apps in the bundle, some don't act in concert with anything else in the bundle, it means sharing attention with many other things (in two ways - public attention, but also dev attention: many things have to be spun up and be ready for release simultaneously, which is inconvenient), it means no ability to set my own schedule. Not getting to set my own version would actually add to that list.

Apr 2 2019, 6:48 PM
hein added a comment to T10755: Unifying Applications' release versions.

Again you can't have a full list on the announcement with 215 names and version numbers, it's just not feasible.

Apr 2 2019, 6:10 PM
hein added a comment to T10755: Unifying Applications' release versions.

I think then we'd have to rethink the way we promote, which could also be a solution. I.e. stop having a version number for KDE Applications entirely, instead of having a YY.MM we just make a "KDE updates apps today" announcement on some day, and the announcement includes a full list with individual versions. If we don't want it to be used, why have the number?

Apr 2 2019, 5:51 PM
hein added a comment to D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.

Looks solid to me. Is your concern re vertical spacing still valid?

Apr 2 2019, 4:47 PM · Plasma
hein added a comment to T10755: Unifying Applications' release versions.

My gut reaction was to agree with @ltoscano whole-heartedly, but the more I think about it that stance does have awkward unsolved problems.

Apr 2 2019, 3:45 PM
hein added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

I'd say let's go with Kirigami.Icon for now then, and recolor the icon to the highlight color on hover. @faridb could you take a stab at that? :)

Apr 2 2019, 9:52 AM · Plasma
hein committed R119:dcb4c158b414: foldermodel: store information about screen used (authored by McPain).
foldermodel: store information about screen used
Apr 2 2019, 9:50 AM
hein closed D18979: foldermodel: store information about screen used.
Apr 2 2019, 9:50 AM · Plasma
hein added a comment to D18979: foldermodel: store information about screen used.

I checked the database and it looks like you don't have a developer account yet, so I'll land this patch for you. If you keep submitting patches, feel free to apply for a developer account via identity.kde.org at some point :)

Apr 2 2019, 9:45 AM · Plasma
hein added a comment to D20189: Change default Yakuake skin to breeze compact.

Looks pretty nice to me. I have no objections.

Apr 2 2019, 9:29 AM

Apr 1 2019

hein accepted D18979: foldermodel: store information about screen used.

Thanks! Do you need help landing this?

Apr 1 2019, 7:29 PM · Plasma

Mar 28 2019

hein added a comment to D20093: Show a context menu on pressAndHold.

I guess this brings us back to the old debate of a generic solution vs. patching all the UIs. I'm inclined to agree with this approach because it should probably be up to the specific UI what it wants to happen on the gesture.

Mar 28 2019, 2:25 PM · Plasma
hein updated subscribers of D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

rooty, your behavior in this thread has been extremely aggressive, disrespectful and uncollaborative. I'd like to ask you to stop at this point and not participate futher, as well as in any future threads related to the Task Manager applets.

Mar 28 2019, 1:43 PM · Plasma
hein added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

And that's why :D Your argument hinges on the idea that something trivial makes the UI cluttered (and also imposes a maintenance burden). I think that's too broad/dogmatic and can be true but it really doesn't have to be the case.

Mar 28 2019, 6:54 AM · Plasma

Mar 27 2019

hein requested changes to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

This is a specious argument.

Mar 27 2019, 12:18 PM · Plasma
hein added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

I'm not a fan of the checkbox, I think it's a little gratuitous. If you add a small feature and need to immediately add a checkbox to disable it, it's rather a red flag to me. It means either the feature or the checkbox should probably go. Firefox gets away without the option BTW.

Mar 27 2019, 5:27 AM · Plasma

Mar 22 2019

hein accepted D19835: [Yakuake] Improve customization.
Mar 22 2019, 10:29 PM · Yakuake

Mar 20 2019

hein accepted D19096: [Kicker] Fix "Tooltip can not be displayed".

Yeah, this looks fine, thanks!

Mar 20 2019, 2:24 PM · Plasma
hein committed R857:17d5e8085b2c: Fix Windows build tools ending up in .apks (authored by hein).
Fix Windows build tools ending up in .apks
Mar 20 2019, 9:41 AM

Mar 18 2019

hein accepted D19833: Remove double scrollbar in appearance settings.
Mar 18 2019, 8:27 PM · Yakuake
hein accepted D19800: [Application Dashboard] Improve mouse handler.
Mar 18 2019, 1:42 PM · Plasma

Mar 17 2019

hein accepted D18438: [Task Manager] When closing apps, resize only when mouse is out..

Looks good now!

Mar 17 2019, 4:29 PM · Plasma
hein added a comment to D19829: kicker: add option to make root level icons visible.

Kicker intentionally doesn't have icons on the root level to not conflict with the favorites column and reduce visual noise.

Mar 17 2019, 4:28 PM · Plasma
hein added a comment to D19744: [taskmanager] Fix desktop file mapping for some apps.

What's the name of the .desktop file though? That's the most relevant part.

Mar 17 2019, 4:26 PM · Plasma

Mar 16 2019

hein accepted D19647: [sddm-theme/lock screen] Use QQC2 for the clock labels.
Mar 16 2019, 5:55 PM · Plasma

Mar 14 2019

hein accepted D19751: [Pager] Shrink label font size dynamically.
Mar 14 2019, 9:11 AM · Plasma
hein requested changes to D19744: [taskmanager] Fix desktop file mapping for some apps.

Sorry, that's too fast and loose for me.

Mar 14 2019, 7:21 AM · Plasma

Mar 13 2019

hein accepted D19606: [Task Manager] Reorganize and improve presentation of context menu.
Mar 13 2019, 5:35 PM · Plasma
hein added a comment to D19237: [Yakuake] Use the svg icons instead of the png icons for the default theme.

Also, maybe we can just delete the .png files then and make the tarball smaller?

Mar 13 2019, 12:08 AM
hein accepted D19237: [Yakuake] Use the svg icons instead of the png icons for the default theme.

Looks great!

Mar 13 2019, 12:08 AM
hein added a comment to D19606: [Task Manager] Reorganize and improve presentation of context menu.

Idea to make the menu smaller: put the Configure and Alternatives items into the sub-menu, and rename it to just More Actions...:

Thoughts?

Mar 13 2019, 12:06 AM · Plasma

Mar 11 2019

hein committed R857:d997974fd4e8: Do shallow clones (authored by hein).
Do shallow clones
Mar 11 2019, 9:27 PM
hein committed R857:e941a2e2f0c6: Always pass PREFIX to qmake (authored by hein).
Always pass PREFIX to qmake
Mar 11 2019, 5:15 PM
hein committed R119:3fc5abe1c0aa: Merge branch 'Plasma/5.15' (authored by hein).
Merge branch 'Plasma/5.15'
Mar 11 2019, 4:48 PM
hein committed R120:169238848136: Merge branch 'Plasma/5.15' (authored by hein).
Merge branch 'Plasma/5.15'
Mar 11 2019, 4:34 PM
hein committed R120:53290043796c: [Task Manager] Fix sorting of tasks on last desktop in sort-by-desktop mode (authored by hein).
[Task Manager] Fix sorting of tasks on last desktop in sort-by-desktop mode
Mar 11 2019, 4:34 PM
hein closed D19259: [Task Manager] Fix sorting of tasks on last desktop in sort-by-desktop mode.
Mar 11 2019, 4:34 PM · Plasma
hein committed R119:4d0f1a3e6ec7: Make Ctrl+A work regardless of focus and visualize active selection in search… (authored by hein).
Make Ctrl+A work regardless of focus and visualize active selection in search…
Mar 11 2019, 4:30 PM
hein committed R119:d769b7aa8838: [Task Manager] Fix virtual desktops subtext on task tooltip (authored by hein).
[Task Manager] Fix virtual desktops subtext on task tooltip
Mar 11 2019, 4:30 PM