hein (Eike Hein)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:07 PM (179 w, 3 d)
Availability
Available

Recent Activity

Fri, Sep 21

hein added a comment to T4457: [kwayland] Virtual Desktop protocol.

Note: The "windows" KRunner plugin needs porting to libtaskmanager as well. However, we have a problem there: KRunner is a different process, and I guess it can't bind PlasmaWindowManagement too until we figure out the privileged protocol auth stuff. KWin/KWayland maintainers?

Fri, Sep 21, 10:14 AM · Plasma on Wayland
hein added a comment to T4457: [kwayland] Virtual Desktop protocol.
Fri, Sep 21, 10:13 AM · Plasma on Wayland
hein added a revision to T4457: [kwayland] Virtual Desktop protocol: D15642: Port "Switch Window" containment action to updated libtaskmanager API and away from KWindowSystem.
Fri, Sep 21, 10:11 AM · Plasma on Wayland
hein added a task to D15642: Port "Switch Window" containment action to updated libtaskmanager API and away from KWindowSystem: T4457: [kwayland] Virtual Desktop protocol.
Fri, Sep 21, 10:11 AM · Plasma
hein requested review of D15642: Port "Switch Window" containment action to updated libtaskmanager API and away from KWindowSystem.
Fri, Sep 21, 10:11 AM · Plasma
hein added a dependent revision for D13745: Implement support for virtual desktops on Wayland: D15642: Port "Switch Window" containment action to updated libtaskmanager API and away from KWindowSystem.
Fri, Sep 21, 10:11 AM · Plasma

Thu, Sep 20

hein updated the diff for D15599: Port the "Switch Desktop" containment action to libtaskmanager.

Fix wrong conditional.

Thu, Sep 20, 3:45 PM · Plasma
hein added inline comments to D15599: Port the "Switch Desktop" containment action to libtaskmanager.
Thu, Sep 20, 3:41 PM · Plasma

Wed, Sep 19

hein updated the diff for D15599: Port the "Switch Desktop" containment action to libtaskmanager.

Kill more unused stuff.

Wed, Sep 19, 10:02 AM · Plasma
hein updated the diff for D15599: Port the "Switch Desktop" containment action to libtaskmanager.

Remove another unused include.

Wed, Sep 19, 9:58 AM · Plasma
hein added a comment to T4457: [kwayland] Virtual Desktop protocol.

After D15599 the "Switch Window" containment action also needs updating to changed libtaskmanager API. That will be next.

Wed, Sep 19, 9:55 AM · Plasma on Wayland
hein added a revision to T4457: [kwayland] Virtual Desktop protocol: D15599: Port the "Switch Desktop" containment action to libtaskmanager.
Wed, Sep 19, 9:53 AM · Plasma on Wayland
hein added a task to D15599: Port the "Switch Desktop" containment action to libtaskmanager: T4457: [kwayland] Virtual Desktop protocol.
Wed, Sep 19, 9:53 AM · Plasma
hein added a dependent revision for D13745: Implement support for virtual desktops on Wayland: D15599: Port the "Switch Desktop" containment action to libtaskmanager.
Wed, Sep 19, 9:53 AM · Plasma
hein requested review of D15599: Port the "Switch Desktop" containment action to libtaskmanager.
Wed, Sep 19, 9:53 AM · Plasma
hein committed R120:fbd1e201838b: Merge branch 'Plasma/5.14' (authored by hein).
Merge branch 'Plasma/5.14'
Wed, Sep 19, 9:08 AM
hein committed R120:3f332a527c3a: Move correct indices in the manual sort map when getting a move() call for… (authored by hein).
Move correct indices in the manual sort map when getting a move() call for…
Wed, Sep 19, 9:07 AM
hein committed R120:12714f421cde: Merge branch 'Plasma/5.14' (authored by hein).
Merge branch 'Plasma/5.14'
Wed, Sep 19, 9:04 AM
hein committed R120:d81570d046e5: Move correct indices in the manual sort map when getting a move() call for… (authored by hein).
Move correct indices in the manual sort map when getting a move() call for…
Wed, Sep 19, 9:04 AM
hein committed R120:3d3a4b6c0aa6: Move correct indices in the manual sort map when getting a move() call for… (authored by hein).
Move correct indices in the manual sort map when getting a move() call for…
Wed, Sep 19, 9:04 AM
hein closed D15550: Move correct indices in the manual sort map when getting a move() call for group children.
Wed, Sep 19, 9:04 AM · Plasma

Mon, Sep 17

hein added a comment to D15535: Use KMainWindow instead of QMainWindow.

Sorry, one more lap: Can you verify that the bug addressed in https://commits.kde.org/yakuake/e2b603d16955561540b9c194c0844ec320fc2694 doesn't happen with your patch applied?

Mon, Sep 17, 6:39 AM
hein added a reviewer for D15550: Move correct indices in the manual sort map when getting a move() call for group children: Plasma.
Mon, Sep 17, 3:58 AM · Plasma

Sun, Sep 16

hein requested review of D15550: Move correct indices in the manual sort map when getting a move() call for group children.
Sun, Sep 16, 9:33 AM · Plasma
hein accepted D15535: Use KMainWindow instead of QMainWindow.

Looks good. Do you have a dev account or do we need someone to land this for you?

Sun, Sep 16, 6:48 AM

Thu, Sep 13

hein committed R120:bedf66c2a0ca: Set gtk-modules to auto-load appmenu-gtk-module (authored by broulik).
Set gtk-modules to auto-load appmenu-gtk-module
Thu, Sep 13, 9:51 PM
hein committed R120:9a0c699d6522: Revert "Set gtk-modules to auto-load appmenu-gtk-module" (authored by hein).
Revert "Set gtk-modules to auto-load appmenu-gtk-module"
Thu, Sep 13, 9:51 PM
hein added a reverting change for R120:3954e7e07c9c: Set gtk-modules to auto-load appmenu-gtk-module: R120:9a0c699d6522: Revert "Set gtk-modules to auto-load appmenu-gtk-module".
Thu, Sep 13, 9:51 PM
hein added a comment to T7116: Streamlined onboarding of new contributors.

Sorry if this was posted before, but looks interesting: https://whatcanidoformozilla.org/

Thu, Sep 13, 6:37 PM · Goal settings 2017
hein added a comment to D15315: Set gtk-modules to auto-load appmenu-gtk-module.

I'm super sorry, arc patch changed authorship somehow :( It randomly sometimes does and doesn't do this and I forgot to check

Thu, Sep 13, 5:25 PM · Plasma
hein committed R120:3954e7e07c9c: Set gtk-modules to auto-load appmenu-gtk-module (authored by hein).
Set gtk-modules to auto-load appmenu-gtk-module
Thu, Sep 13, 5:24 PM
hein closed D15315: Set gtk-modules to auto-load appmenu-gtk-module.
Thu, Sep 13, 5:24 PM · Plasma
hein added a comment to D15315: Set gtk-modules to auto-load appmenu-gtk-module.

Since we're in the middle of doing tarballs and I know @broulik was anxious to get this in I'm going to be proactive and land it.

Thu, Sep 13, 5:23 PM · Plasma
hein accepted D15315: Set gtk-modules to auto-load appmenu-gtk-module.
Thu, Sep 13, 5:21 PM · Plasma
hein committed R119:991bcf7d0d90: fix translations kcm to be usable on new users/installations (authored by sitter).
fix translations kcm to be usable on new users/installations
Thu, Sep 13, 5:08 PM
hein closed D15115: fix translations kcm to be usable on new users/installations.
Thu, Sep 13, 5:08 PM · Plasma
hein updated the diff for D15115: fix translations kcm to be usable on new users/installations.

Simplify patch to only what's actually needed.

Thu, Sep 13, 5:04 PM · Plasma
hein commandeered D15115: fix translations kcm to be usable on new users/installations.

I'll commandeer this rev to fix up the patch. Sorry @sitter, but then we can get this into beta still.

Thu, Sep 13, 5:02 PM · Plasma
hein added a comment to D15115: fix translations kcm to be usable on new users/installations.

This makes sense. In theory this is done by this code:

Thu, Sep 13, 5:01 PM · Plasma

Wed, Sep 12

hein accepted D15234: Remove breaking pointer constraints functionality.

Yeah, sounds good for now.

Wed, Sep 12, 8:20 PM · KWin
hein committed R120:2949e7c432b5: Add back comment and fix indentation. (authored by hein).
Add back comment and fix indentation.
Wed, Sep 12, 6:35 PM
hein committed R120:c81205cc458e: Do ignore-filtered-siblings properly (authored by hein).
Do ignore-filtered-siblings properly
Wed, Sep 12, 6:30 PM
hein closed D15462: Do ignore-filtered-siblings properly.
Wed, Sep 12, 6:30 PM · Plasma
hein requested review of D15462: Do ignore-filtered-siblings properly.
Wed, Sep 12, 6:23 PM · Plasma
hein committed R120:a057edc7e9fb: Re-filter launcher when a window changes identity (authored by hein).
Re-filter launcher when a window changes identity
Wed, Sep 12, 4:18 PM
hein closed D15458: Re-filter launcher when a window changes identity.
Wed, Sep 12, 4:18 PM · Plasma
hein requested review of D15458: Re-filter launcher when a window changes identity.
Wed, Sep 12, 4:02 PM · Plasma
hein committed R120:b15eaf38b6bf: Handle clients which change window metadata during early startup (authored by hein).
Handle clients which change window metadata during early startup
Wed, Sep 12, 3:46 PM
hein closed D15410: Handle clients which change window metadata during early startup.
Wed, Sep 12, 3:46 PM · Plasma
hein accepted D14426: [Folder View] Create KFilePlacesModel only when needed and listen for changes.
Wed, Sep 12, 3:24 PM · Plasma

Tue, Sep 11

hein accepted D15256: [Mouse KCM] Avoid changes to touchpads in libinput backend.
Tue, Sep 11, 1:33 PM · Plasma

Mon, Sep 10

hein added a comment to D15410: Handle clients which change window metadata during early startup.

I just want to point out that such applications are not ICCCM compliant: This property must be present when the window leaves the Withdrawn state and may be changed only while the window is in the Withdrawn state. Window managers may examine the property only when they start up and when the window leaves the Withdrawn state, but there should be no need for a client to change its state dynamically.

KWin doesn't support updates to wm_class and e.g. window rules are broken.

Mon, Sep 10, 6:25 PM · Plasma
hein updated the diff for D15410: Handle clients which change window metadata during early startup.

Add conclusion to description. Done now, promise.

Mon, Sep 10, 4:32 PM · Plasma
hein updated the diff for D15410: Handle clients which change window metadata during early startup.

Add back Nate. Now I'm committed to using arc diff --verbatim, sorry. :P

Mon, Sep 10, 4:25 PM · Plasma
hein updated the diff for D15410: Handle clients which change window metadata during early startup.

Improve description further.

Mon, Sep 10, 4:24 PM · Plasma
hein updated the diff for D15410: Handle clients which change window metadata during early startup.

Fix typo in description.

Mon, Sep 10, 4:20 PM · Plasma
hein added a reviewer for D15410: Handle clients which change window metadata during early startup: ngraham.
Mon, Sep 10, 4:18 PM · Plasma
hein requested review of D15410: Handle clients which change window metadata during early startup.
Mon, Sep 10, 4:18 PM · Plasma
hein accepted D15404: [KFileItemModelRolesUpdater] Avoid duplicate indexes to resolve.
Mon, Sep 10, 2:27 PM · Dolphin
hein committed R120:c8358c203f11: Don't consider filtered out tasks siblings when sorting in new tasks (authored by hein).
Don't consider filtered out tasks siblings when sorting in new tasks
Mon, Sep 10, 11:15 AM
hein closed D14392: Don't consider filtered out tasks siblings when sorting in new tasks.
Mon, Sep 10, 11:15 AM · Plasma
hein added inline comments to D14392: Don't consider filtered out tasks siblings when sorting in new tasks.
Mon, Sep 10, 10:40 AM · Plasma
hein added a comment to D14426: [Folder View] Create KFilePlacesModel only when needed and listen for changes.

Did you forget to update the diff?

Mon, Sep 10, 10:37 AM · Plasma
hein added a comment to D15331: [Folder View] Hide /home/foo/Desktop place in configuration.

Let's not bother with it then, thanks for looking into it.

Mon, Sep 10, 10:35 AM · Plasma
hein added a reviewer for D15234: Remove breaking pointer constraints functionality: VDG.

If I understood things right, prior work made sure that deactivating a client via any means (alt-tab, opening KRunner, etc.) will break a clients' pointer constraint (and hopefully recreate it when the client gets activated again). And this patch removes the previous dedicated means to do so, long-pressing ESC, and the notification informing the user of this possibility.

Mon, Sep 10, 10:33 AM · KWin
hein accepted D15225: Activate clients on drag enter.
Mon, Sep 10, 10:13 AM · KWin

Fri, Sep 7

hein added a comment to D15331: [Folder View] Hide /home/foo/Desktop place in configuration.

Is it worth adding QQmlParserStatus to PlacesModel at this point?

Fri, Sep 7, 6:05 PM · Plasma
hein accepted D15331: [Folder View] Hide /home/foo/Desktop place in configuration.
Fri, Sep 7, 6:04 PM · Plasma

Thu, Sep 6

hein committed R119:b69301a6d4dc: Merge branch 'Plasma/5.13' (authored by hein).
Merge branch 'Plasma/5.13'
Thu, Sep 6, 9:46 AM
hein committed R119:f2dd50a1a9aa: Merge branch 'Plasma/5.12' into Plasma/5.13 (authored by hein).
Merge branch 'Plasma/5.12' into Plasma/5.13
Thu, Sep 6, 9:45 AM
hein committed R119:1692ae244bc5: Improve arrow key navigation of Kicker search results (authored by hein).
Improve arrow key navigation of Kicker search results
Thu, Sep 6, 9:44 AM
hein closed D15286: Improve arrow key navigation of Kicker search results.
Thu, Sep 6, 9:44 AM · Plasma

Wed, Sep 5

hein accepted D15160: [Folder View] Honor editable_desktop_icons KIOSK restriction.
Wed, Sep 5, 4:42 PM · Plasma
hein accepted D15162: [Folder View] Disable the actions themselves rather than just not adding them to the menu.

Good patch!

Wed, Sep 5, 4:40 PM · Plasma
hein accepted D15291: [Folder View] Compare UDS entry times directly instead of going through KFileItem.
Wed, Sep 5, 4:40 PM · Plasma
hein accepted D15074: [server] Do not try to create data offers without source.
Wed, Sep 5, 4:39 PM · Frameworks
hein updated the diff for D15286: Improve arrow key navigation of Kicker search results.

Fix.

Wed, Sep 5, 4:20 PM · Plasma
hein added a comment to D15286: Improve arrow key navigation of Kicker search results.

Indeed. Sorry, I introduced a small bug with a fatal copy and paste mistake just before uploading.

Wed, Sep 5, 3:25 PM · Plasma
hein accepted D15269: [Folder View] Add checkbox for toggling previews.
Wed, Sep 5, 2:59 PM · Plasma
hein requested review of D15286: Improve arrow key navigation of Kicker search results.
Wed, Sep 5, 10:01 AM · Plasma
hein accepted D15268: [Folder View] Use KIO::PreviewJob::defaultPlugins() for default plugins.
Wed, Sep 5, 8:54 AM · Plasma

Tue, Sep 4

hein accepted D15263: Don't use older buggier versions of AppStream Qt.
Tue, Sep 4, 12:31 PM · Plasma
hein added a comment to D14988: Implement option to toggle page navigation wraps around for pager plasmoid.

And @phuongn, I'm guessing you set all of these options to disabling wrap-around, right?

Tue, Sep 4, 10:38 AM · Plasma
hein added a comment to D14988: Implement option to toggle page navigation wraps around for pager plasmoid.

This patch is good, but I share Kai's concern that it's perhaps suboptimal we have two-three checkboxes now to control similar behavior in different places. Does the VDG have an opinion on that @ngraham?

Tue, Sep 4, 10:37 AM · Plasma
hein added a comment to D15170: Add icon names for root level kicker, recent docs, recent apps, power and session.

This is a good patch, but I think it's actually doing too much :). I'd be OK with hardcoding the icon names in the code. I don't think they need to be configurable. Could you simplify the patch?

Tue, Sep 4, 10:34 AM · Plasma
hein added a comment to D15206: [Kickoff] Add a subtle separator line between the header and the content view.

Code looks fine.

Tue, Sep 4, 10:30 AM · Plasma

Mon, Sep 3

hein added a comment to T9592: Publish Konversation in the Microsoft Store.

It's unfortunately still pre-alpha (although I used it daily).

Mon, Sep 3, 9:36 AM · Konversation, Windows

Aug 16 2018

hein committed R917:42b9d49999e1: I blame it all on PHP (but really it was me) (authored by hein).
I blame it all on PHP (but really it was me)
Aug 16 2018, 12:08 PM
hein committed R917:589a0c5cd099: One more timeline fix (authored by hein).
One more timeline fix
Aug 16 2018, 12:08 PM
hein committed R917:b9f6c59c072e: Fix Lydia vp date (authored by hein).
Fix Lydia vp date
Aug 16 2018, 12:08 PM
hein committed R917:1b72e4054d6c: Fix timeline for Lydia (authored by hein).
Fix timeline for Lydia
Aug 16 2018, 12:08 PM
hein committed R917:a79614af81fd: Update timeline (authored by hein).
Update timeline
Aug 16 2018, 12:08 PM
hein committed R917:5fb6845679f4: Fix file extension after converting image (authored by hein).
Fix file extension after converting image
Aug 16 2018, 12:08 PM
hein committed R917:47cf3c930333: Swap Andy for Sandro on the board page (authored by hein).
Swap Andy for Sandro on the board page
Aug 16 2018, 12:08 PM
hein added a comment to D14243: Fix bad model hygiene in Positioner::move().

Oh shit, I forgot it was already commmitted, I though it was still stuck in review.

Aug 16 2018, 10:16 AM · Plasma
hein added a comment to D14860: Make middle click closes tab optional.

thanks for your patch.

Aug 16 2018, 10:14 AM
hein accepted D14836: Kicker: Reset re-used menu width to default one.
Aug 16 2018, 10:03 AM · Plasma
hein added a comment to D14243: Fix bad model hygiene in Positioner::move().

I'll take this back up in September after my vacation (unless I get bored inbetween which is unlikely).

Aug 16 2018, 9:28 AM · Plasma

Aug 11 2018

hein assigned T9347: Meeting room for board & Qt company management to derkits.
Aug 11 2018, 10:42 AM · Akademy (Akademy 2018)
hein created T9347: Meeting room for board & Qt company management.
Aug 11 2018, 10:42 AM · Akademy (Akademy 2018)