hein (Eike Hein)
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:07 PM (161 w, 6 d)
Availability
Available

Recent Activity

Yesterday

hein added a comment to D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager.

The purpose of this patch was to simply hide the standalone launcher functionality a little

Tue, May 22, 3:39 PM · Plasma
hein added a comment to D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager.

Widget-based launchers do have jump lists, fwiw

Tue, May 22, 3:30 PM · Plasma
hein added a comment to D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager.

And personally I consider pinning to be activity dependant way more complicated than having both options to pin and have a launcher

Tue, May 22, 3:08 PM · Plasma
hein added a comment to D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager.

That's disappointing to hear and a bit frustrating considering that it never came up in the Bugzilla ticket I filed months 3 ago

Tue, May 22, 12:54 PM · Plasma
hein added a comment to D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager.

I veto this patch, sorry. These are different features and they're both intended to be there. Task Manager pinning is not a replacement for permanent launchers.

Tue, May 22, 12:08 PM · Plasma

Fri, May 18

hein committed R119:11ab2b7d2684: Merge branch 'Plasma/5.13' (authored by hein).
Merge branch 'Plasma/5.13'
Fri, May 18, 6:56 PM
hein committed R119:9403d0339279: Merge branch 'Plasma/5.12' into Plasma/5.13 (authored by hein).
Merge branch 'Plasma/5.12' into Plasma/5.13
Fri, May 18, 6:56 PM
hein committed R119:3374ad0dee5c: Merge branch 'Plasma/5.13' (authored by hein).
Merge branch 'Plasma/5.13'
Fri, May 18, 6:49 PM
hein committed R119:22f83ae002e1: Fix submodel population (authored by hein).
Fix submodel population
Fri, May 18, 6:48 PM
hein committed R119:7e514201e2f1: Fix AppsModel not refreshing on syccoa changes. (authored by hein).
Fix AppsModel not refreshing on syccoa changes.
Fri, May 18, 11:23 AM
hein closed D12958: Fix AppsModel not refreshing on syccoa changes..
Fri, May 18, 11:23 AM · Plasma
hein requested review of D12958: Fix AppsModel not refreshing on syccoa changes..
Fri, May 18, 11:20 AM · Plasma
hein moved T7250: Keyboard from High priority to WIP on the Plasma: KCM Redesign board.
Fri, May 18, 10:43 AM · Plasma: KCM Redesign
hein closed T7247: Language as Resolved.
Fri, May 18, 10:43 AM · Plasma: KCM Redesign
hein closed T7284: Launch feedback as Resolved.
Fri, May 18, 10:42 AM · Plasma: KCM Redesign
hein moved T7284: Launch feedback from Low priority to WIP on the Plasma: KCM Redesign board.
Fri, May 18, 10:42 AM · Plasma: KCM Redesign

Thu, May 17

hein added a comment to D12102: Port Language KCM to Qt Quick.

I've cleaned this up/out now. About half or so got reassigned to either systemsettings:kcm_formats or frameworks-sonnet. Some got closed as FIXED and WORKSFORME. There's a bunch left. 2-3 have a point (e.g. the the language names), the rest is weird stuff.

Thu, May 17, 10:48 AM · Kirigami, Plasma

Wed, May 16

hein accepted D12927: [Service Runner] Do startsWith check case-insensitive.
Wed, May 16, 10:59 AM · Plasma
hein added a comment to T8712: Forming a welcome team to guide newcomers.

I sometimes try IRC but that does not work very well, because a developer needs to be online at the same time you are online

Wed, May 16, 9:42 AM · Goal settings 2017
hein added a comment to D12102: Port Language KCM to Qt Quick.

Sorry, accident! The code in the Keyboard KCM is ... interesting and literally breaks my system trying to build it (it needs a two-digit amount of GB of memory to build thanks to a boost-based keyboard layout preview generator it even changes the LLVM template recursion depth for), so I usually disable it so I don't have to hard reset my PC and lose data.

Wed, May 16, 9:39 AM · Kirigami, Plasma

Tue, May 15

hein added a comment to T8712: Forming a welcome team to guide newcomers.

It's worth noting we have this in a non-formalized way. The Getting Involved pages have always listed mentors you can contact for 1on1 questions (I've responsed to mails due to this for many years).

Tue, May 15, 12:04 PM · Goal settings 2017

Mon, May 14

hein committed R119:6055cfb94e1e: Port Language KCM to Qt Quick (authored by hein).
Port Language KCM to Qt Quick
Mon, May 14, 9:57 AM
hein closed D12102: Port Language KCM to Qt Quick.
Mon, May 14, 9:57 AM · Kirigami, Plasma
hein updated the diff for D12102: Port Language KCM to Qt Quick.

Move removal into the C++ model code to avoid another model reset
and speed up the UX.

Mon, May 14, 9:31 AM · Kirigami, Plasma
hein updated the diff for D12102: Port Language KCM to Qt Quick.

Add back Move up/down actions.

Mon, May 14, 9:25 AM · Kirigami, Plasma
hein committed R856:2723ef0c80a6: WIP: Show SNI to install browser-side extension (authored by davidedmundson).
WIP: Show SNI to install browser-side extension
Mon, May 14, 8:41 AM
hein closed D12698: Show SNI to install browser-side extension.
Mon, May 14, 8:41 AM · Plasma
hein updated the diff for D12698: Show SNI to install browser-side extension.

Switch icon

Mon, May 14, 8:37 AM · Plasma
hein accepted D12701: Remove D10890 workaround.
Mon, May 14, 8:03 AM · Plasma

Sun, May 13

hein updated the diff for D12102: Port Language KCM to Qt Quick.

Don't mutate source model while building list of langs to add to selection.

Sun, May 13, 8:26 AM · Kirigami, Plasma
hein updated the diff for D12102: Port Language KCM to Qt Quick.

Remove width from delegate in sheet again.

Sun, May 13, 7:42 AM · Kirigami, Plasma
hein accepted D12392: Fix the "Default" color scheme to match Breeze again.

This looks good, but I think there might be additional copies of these values in (a) the color KCM code and (b) the kdeglobals code in kdelibs4support, did you have a chance to look into those?

Sun, May 13, 7:34 AM · Frameworks
hein added a comment to D12774: Fix submenus not updating when switching between categories of the same size.

No worries, also my fault for not spotting it in review. :)

Sun, May 13, 7:15 AM · Plasma

Sat, May 12

hein added a comment to D12102: Port Language KCM to Qt Quick.
In D12102#261174, @mart wrote:

if i select more than one language, only one will be added, the others will be added as "unknown"

Sat, May 12, 1:21 PM · Kirigami, Plasma

Fri, May 11

hein committed R119:28dc6b88538e: Always set applet title, even when label is disabled (authored by hein).
Always set applet title, even when label is disabled
Fri, May 11, 8:51 AM
hein closed D12775: Always set applet title, even when label is disabled.
Fri, May 11, 8:51 AM · Plasma
hein committed R119:c0cd1f8d49e6: Fix submenus not updating when switching between categories of the same size (authored by hein).
Fix submenus not updating when switching between categories of the same size
Fri, May 11, 8:51 AM
hein closed D12774: Fix submenus not updating when switching between categories of the same size.
Fri, May 11, 8:51 AM · Plasma
hein retitled D12698: Show SNI to install browser-side extension from WIP: Show SNI to install browser-side extension to Show SNI to install browser-side extension.
Fri, May 11, 8:49 AM · Plasma
hein added a comment to D12698: Show SNI to install browser-side extension.

I currently don't have the time to make the showCount stuff per-browser to handle multi-browser usage. I think it might also not be worth it. People who use multiple browsers are probably power user enough to hear about and install the extension themselves.

Fri, May 11, 8:46 AM · Plasma
hein updated the diff for D12698: Show SNI to install browser-side extension.

Unload also on early abort.

Fri, May 11, 8:42 AM · Plasma
hein added a comment to D12698: Show SNI to install browser-side extension.
  • The SNI doesn't disappear when the browser is closed.
Fri, May 11, 8:40 AM · Plasma
hein updated the diff for D12698: Show SNI to install browser-side extension.

Always open the extension URL in the browser that was actually launched,
instead of relying on it being the same as the default browser.

Fri, May 11, 8:37 AM · Plasma

Thu, May 10

hein added a comment to D12102: Port Language KCM to Qt Quick.

@mart Do you think I should push this before we work on the DND stuff?

Thu, May 10, 6:09 AM · Kirigami, Plasma

Wed, May 9

hein added a comment to D12698: Show SNI to install browser-side extension.

There's some conceptual problems with this remaining:

Wed, May 9, 12:49 PM · Plasma
hein accepted D12780: Avoid including the generated config-X11 private header.
Wed, May 9, 11:49 AM · Plasma
hein updated the diff for D12698: Show SNI to install browser-side extension.

Clean up auto usage

Wed, May 9, 11:29 AM · Plasma
hein accepted D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
Wed, May 9, 8:56 AM · Plasma
hein updated the diff for D12775: Always set applet title, even when label is disabled.

Fix logic error.

Wed, May 9, 8:34 AM · Plasma
hein requested review of D12775: Always set applet title, even when label is disabled.
Wed, May 9, 8:27 AM · Plasma
hein added a comment to D12698: Show SNI to install browser-side extension.

The code simplification in the above changes also gets rid of the possible C++20 usage.

Wed, May 9, 8:04 AM · Plasma
hein updated the diff for D12698: Show SNI to install browser-side extension.

Add .desktop file names for Firefox Nightly and Google Chrome Beta.

Wed, May 9, 8:03 AM · Plasma
hein updated the diff for D12698: Show SNI to install browser-side extension.
  • Revise naming and make consistent
  • Fix copyrights
  • Don't use other people's branding
  • Simplify (BrowserInfo is gone)
Wed, May 9, 7:56 AM · Plasma
hein added a comment to D12698: Show SNI to install browser-side extension.

At the same time, I'm not sure using the browser icon straight in an SNI is appropriate either. Upstreams might not appreciate their branding being slapped onto something they didn't originate. I think we should use internet-web-browser here (the same icon that's used for the default browser KCM in System Settings).

Wed, May 9, 7:42 AM · Plasma
hein added a comment to D12698: Show SNI to install browser-side extension.

I'm not a fan of the combined icon idea. On face of it it's a neat "go the extra mile" kind of thing, on the other hand it creates follow-up which I'm certain will not be done in a timely manner, or even forgotten about: Updating those assets whenever the upstream branding is revised. It means initially the visual is slightly nicer, but in the future it will look outdated and crap. It's not a good idea to bring this about for such a minor thing, I think it's better to keep it simple and agree with Vlad here.

Wed, May 9, 7:38 AM · Plasma
hein requested review of D12774: Fix submenus not updating when switching between categories of the same size.
Wed, May 9, 7:27 AM · Plasma

Tue, May 8

hein updated the diff for D12102: Port Language KCM to Qt Quick.

Set explicit width for Material style

Tue, May 8, 11:52 AM · Kirigami, Plasma
hein updated the diff for D12102: Port Language KCM to Qt Quick.
  • Right-align 'Add languages ...' button
  • Clean up cruft from a pre-ListView revision, thanks Marco
Tue, May 8, 11:51 AM · Kirigami, Plasma
hein added a comment to D12698: Show SNI to install browser-side extension.

I'm left to interpret what David meant with "I don't like the module names".

Tue, May 8, 8:13 AM · Plasma
hein added reviewers for D12698: Show SNI to install browser-side extension: apol, mart, Plasma.

The code looks fine to me. I was questioning if config.writeEntry("shownCount", 100); should be MAX_SHOW_COUNT + 1 instead for a moment, but this is safer in case it gets bumped later.

Tue, May 8, 8:11 AM · Plasma
hein commandeered D12698: Show SNI to install browser-side extension.

I'll commandeer, Kai asked me to take this due to being really sick.

Tue, May 8, 8:04 AM · Plasma
hein added a comment to D12102: Port Language KCM to Qt Quick.

Right-aligned button: Can do, sure.

Tue, May 8, 5:45 AM · Kirigami, Plasma
hein accepted D12508: Make KMessageWidget match Kirigami inlineMessage's style.

Looks good to me, thanks for working on this.

Tue, May 8, 5:33 AM · Frameworks

Mon, May 7

hein updated the diff for D12102: Port Language KCM to Qt Quick.
  • Fix settings saving
  • String tweak
Mon, May 7, 6:08 AM · Kirigami, Plasma

Sat, May 5

hein committed R917:ec1539d30c7c: Update Vereinfachter Zuwendungsnachweis (authored by hein).
Update Vereinfachter Zuwendungsnachweis
Sat, May 5, 3:40 AM

Fri, Apr 27

hein accepted D12459: [Icon KCM] Port to new design.

Go go go

Fri, Apr 27, 2:28 PM · Plasma

Thu, Apr 26

hein added a comment to D12102: Port Language KCM to Qt Quick.

I also just realized we seem to have zero keyboard nav support ...

Thu, Apr 26, 3:18 PM · Kirigami, Plasma
hein added a comment to D12102: Port Language KCM to Qt Quick.

New screenshot:

Thu, Apr 26, 3:13 PM · Kirigami, Plasma
hein updated the diff for D12102: Port Language KCM to Qt Quick.
  • Port to ScrollVieWKCM
  • Add list label at the top and show conditionally
  • Actions are now 'Make default' and 'Remove' with appropriate tooltips
  • Topmost language has a "(Default)" behind it
  • Code cleanups
Thu, Apr 26, 3:12 PM · Kirigami, Plasma
hein accepted D12526: export layout paddings from qstyle, start from Control.
Thu, Apr 26, 11:06 AM · Plasma
hein added a comment to D12529: Paste dropped files and folders as text by default.

I can't quite follow the discussion so far (also because my Konsole already seems to paste URLs on drop). Are you saying the current default is to show a Dolphin/FV-like drop menu with actions? I think that's nice for consistency, no? Then again apps like Konversation don't and Konsole is often used for chats, too.

Thu, Apr 26, 10:46 AM · Konsole
hein accepted D12512: ScrollViewKCM.
Thu, Apr 26, 10:40 AM · Frameworks
hein accepted D12515: QML applets need to manage padding by themselves.

Same as before, we're just refactoring to clean some code :)

Thu, Apr 26, 10:39 AM · Plasma

Wed, Apr 25

hein added a comment to D12459: [Icon KCM] Port to new design.

Model looks good! :)

Wed, Apr 25, 4:33 PM · Plasma
hein added a comment to D12459: [Icon KCM] Port to new design.

In general: This code would be cleaner if it wasn't using QStandardItemModel but just a QAbstractListModel subclass. Then stuff like the "selected theme index" could use either a role or a QItemSelectionModel, and the role enum wouldn't need to live outside of the model. :)

Wed, Apr 25, 4:15 PM · Plasma
hein committed R169:60c9e44c2c63: Rework InlineMessages to address a number of issues (authored by hein).
Rework InlineMessages to address a number of issues
Wed, Apr 25, 2:14 PM
hein closed D12516: Rework InlineMessages to address a number of issues.
Wed, Apr 25, 2:14 PM · Kirigami
hein updated the diff for D12516: Rework InlineMessages to address a number of issues.

Expand documentation as requested by Marco.

Wed, Apr 25, 1:59 PM · Kirigami
hein added a comment to D12516: Rework InlineMessages to address a number of issues.

Seems to work well in Kirigami gallery and the KCMs

Wed, Apr 25, 1:25 PM · Kirigami
hein added a comment to D12512: ScrollViewKCM.

It looks good otherwise and I really want to accept this so I can progress on the Language KCM, but this magic value thing gives me a headache. It's going to break with other QStyles with a different value. We need some sort of fix for that ...

Wed, Apr 25, 1:25 PM · Frameworks
hein updated the diff for D12516: Rework InlineMessages to address a number of issues.

Fix the animating prop

Wed, Apr 25, 1:22 PM · Kirigami
hein requested review of D12516: Rework InlineMessages to address a number of issues.
Wed, Apr 25, 1:15 PM · Kirigami
hein added a comment to T4457: [kwayland] Virtual Desktop protocol.

Unlikely, Gnome's shell runs in-process with the compositor, they don't need any IPC for the same use case.

Wed, Apr 25, 10:08 AM · Plasma (Plasma 5.13), Plasma on Wayland
hein added a comment to D12512: ScrollViewKCM.

Does the magic pixel size number for the padding get scaled correctly on hidpi?

Wed, Apr 25, 10:06 AM · Frameworks

Tue, Apr 24

hein accepted D11955: [Folder View] Set Refresh shortcut on Refresh/Reload.
Tue, Apr 24, 4:52 PM · Plasma
hein added a comment to D4281: [Task Manager] Limit context menu width.

Does it still have the issues mentioned above? Because then not really ...

Tue, Apr 24, 3:27 PM · Plasma

Mon, Apr 23

hein accepted D12063: Add a hidden config option for showing icons on the root level of the menu.
Mon, Apr 23, 9:24 AM · Plasma

Apr 22 2018

hein committed R7:8b501c09f077: Make quit kinda work (authored by hein).
Make quit kinda work
Apr 22 2018, 5:38 PM
hein committed R7:a4cf3d141970: Fix warnings (authored by hein).
Fix warnings
Apr 22 2018, 5:38 PM
hein committed R7:320b5d716ab4: Fix typo (authored by hein).
Fix typo
Apr 22 2018, 5:16 PM
hein committed R7:287797eb3279: Fix stupid regex (authored by hein).
Fix stupid regex
Apr 22 2018, 5:16 PM
hein committed R7:00aecbf4941e: Make NotificationHandler work with the Qt Quick main window (authored by hein).
Make NotificationHandler work with the Qt Quick main window
Apr 22 2018, 5:16 PM
hein accepted D12453: Have konvi2x compile against Android.
Apr 22 2018, 5:08 PM
hein committed R7:63ad25b1d999: Add a bunch of buttons more to open legacy dialogs (authored by hein).
Add a bunch of buttons more to open legacy dialogs
Apr 22 2018, 4:57 PM
hein committed R7:834a30f0b0de: Make keyboard shortcuts work again (authored by hein).
Make keyboard shortcuts work again
Apr 22 2018, 4:57 PM
hein committed R7:b3cd362a42d3: Get rid of window nesting (authored by hein).
Get rid of window nesting
Apr 22 2018, 3:42 PM
hein committed R7:760326b2ba99: Make page handles larger on mobile (authored by hein).
Make page handles larger on mobile
Apr 22 2018, 10:48 AM

Apr 21 2018

hein added a comment to D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS.

In principle I'm inclined to side with Martin here. At this point, I no longer want the extra burden/distraction of working on newly-introduced X11-related bugs. It's frustrating to spend manhours on code you know will be obsolete, and that delays getting work done to make it obsolete. I still have many scaling problems on Wayland that I think should be higher priority.

Apr 21 2018, 8:00 PM · Plasma
hein added a comment to D12102: Port Language KCM to Qt Quick.

Adding 'Default' is pretty easy, no problem.

Apr 21 2018, 7:22 PM · Kirigami, Plasma
hein added a comment to D12102: Port Language KCM to Qt Quick.

For this list, where the items themselves don't do anything on click, I think it's sane to allow the whole list item to be a drag area. There's more of a challenge to allow re-ordering items that do something when you click on them, but we don't have that issue here.

Apr 21 2018, 3:12 PM · Kirigami, Plasma