hein (Eike Hein)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:07 PM (136 w, 1 d)
Availability
Available

Recent Activity

Today

hein added a comment to D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.

Updated screenshot:

Thu, Nov 23, 2:24 PM · Plasma
hein committed R119:e3c349358360: Port launch feedback KCM to Qt Quick and implement VDG redesign (authored by hein).
Port launch feedback KCM to Qt Quick and implement VDG redesign
Thu, Nov 23, 2:23 PM
hein updated the diff for D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.
  • Implement latest VDG mockup.
Thu, Nov 23, 2:21 PM · Plasma
hein requested changes to D8692: QML mouse cursor KCM and components.
Thu, Nov 23, 12:29 PM · Plasma
hein added a comment to D8922: Avoid jumping of items toward right/botton when dropping.

For conceptual sanity checking, could you look at c9a7741f2b8082f025b5eb2e53c3c489a95e1da8 and how these align? Note how that commit cares more about what the user considers the visual center (the icon) rather than cell or delegate centers.

Thu, Nov 23, 11:57 AM

Yesterday

hein added a comment to D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.

Thanks, will implement tomorrow!

Wed, Nov 22, 4:01 PM · Plasma
hein accepted D8915: Update the proxy to source and source to proxy mapping correctly.
Wed, Nov 22, 1:06 PM · Plasma
hein added inline comments to D8850: Support drag and drop between shared folder view containments.
Wed, Nov 22, 1:05 PM · Plasma
hein accepted D8598: FolderView: position files at drop event target position.

Small comment change request in the comments, but code-wise good to go.

Wed, Nov 22, 1:04 PM · Plasma
hein added a comment to D8493: Make Folder View screen aware.

Modulo above edge-casey comments it looks good to me.

Wed, Nov 22, 1:01 PM · Plasma
hein accepted D8864: RFC: [MouseEventListener] Allow accepting mouse event.
Wed, Nov 22, 9:48 AM · Frameworks, Plasma

Tue, Nov 21

hein added a comment to D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.

The above exchange is seriously upsetting and frustrating to me. I implemented the VDG mockup, and now there's discussion about the design in my code review. Please get your act together and make sure the mockups are ready for implementing so the review process of code work isn't this painful.

Tue, Nov 21, 3:48 PM · Plasma
hein added a comment to D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.

Can you add "Fixes T7284" so this it will close that Maniphest task once this goes in?

Tue, Nov 21, 8:50 AM · Plasma
hein added inline comments to D8916: QML port of fonts kcm.
Tue, Nov 21, 8:50 AM · Plasma
hein added a comment to D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.

Updated screenshot:

Tue, Nov 21, 8:44 AM · Plasma
hein updated the diff for D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.

Address all review comments.

Tue, Nov 21, 8:40 AM · Plasma
hein added inline comments to D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.
Tue, Nov 21, 8:38 AM · Plasma

Mon, Nov 20

hein added inline comments to D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.
Mon, Nov 20, 12:08 PM · Plasma
hein added a comment to D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.

Review comments: Some of those also apply to the fonts KCM rewrite I based this on, e.g. the broken bindings. Will fix tomorrow, thanks :)

Mon, Nov 20, 12:07 PM · Plasma
hein added a reviewer for D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign: abetts.
Mon, Nov 20, 10:51 AM · Plasma
hein added a comment to D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.

Screenshot:

Mon, Nov 20, 10:50 AM · Plasma
hein added a comment to D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.

This is on git as branch kcm-redesign/launchfeedback.

Mon, Nov 20, 10:46 AM · Plasma
hein updated the diff for D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.

Add missing package.

Mon, Nov 20, 10:45 AM · Plasma
hein committed R119:b91f75b9944a: Port launch feedback KCM to Qt Quick and implement VDG redesign (authored by hein).
Port launch feedback KCM to Qt Quick and implement VDG redesign
Mon, Nov 20, 10:44 AM
hein created D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.
Mon, Nov 20, 10:40 AM · Plasma
hein added a dependent revision for D8641: FormLayout: D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign.
Mon, Nov 20, 10:40 AM · Kirigami, Plasma
hein committed R119:22053d22777d: Port launch feedback KCM to Qt Quick and implement VDG redesign (authored by hein).
Port launch feedback KCM to Qt Quick and implement VDG redesign
Mon, Nov 20, 10:38 AM

Fri, Nov 17

hein accepted D8849: [Folder View Filter Config] Use TableView for mime types.

If the default sorting isn't on the checkbox, then I'm OK with and accept the original ver (not-so-fond of the variant).

Fri, Nov 17, 1:31 PM · Plasma
hein added a comment to D8524: Add a signal notifying a change in the names of running activities..

Such a class would imho be pretty redundant to the model class, so now it's back to whether David wants to accept this patch or not.

Fri, Nov 17, 1:26 PM · Plasma
hein added a comment to D8849: [Folder View Filter Config] Use TableView for mime types.

I like it, but should the default sort column be the name so that there's no awkward arrow in the header element for the checkboxes?

Fri, Nov 17, 4:26 AM · Plasma

Wed, Nov 15

hein committed R7:3f4e4d615bff: Adjust for dev. (authored by hein).
Adjust for dev.
Wed, Nov 15, 5:00 AM
hein committed R7:81ae9a42e3ec: Adjust for release. (authored by hein).
Adjust for release.
Wed, Nov 15, 4:46 AM
hein committed R7:c3c9ad19f2d0: Don't ignore custom font size from app configuration (authored by hein).
Don't ignore custom font size from app configuration
Wed, Nov 15, 4:43 AM

Tue, Nov 14

hein accepted D8770: Resolve the input method issue by always force focus in search field..

I think we have the same problem in Kicker and Application Dashboard, which also use append trickery.

Tue, Nov 14, 5:13 AM · Plasma
hein added a comment to D8641: FormLayout.

So if I understand correctly, the Mnemonic stuff currently doesn't seem to have the same aims as KAcceleratorManager does ...

Tue, Nov 14, 5:08 AM · Kirigami, Plasma

Mon, Nov 13

hein accepted D8771: Use heuristic weighted length algorithm to calculate the query term length..
Mon, Nov 13, 7:38 PM · Plasma
hein accepted D8800: Add a new function to measure the length by text..

I'm very happy to see this. I opened a thread about this on k-c-d (I think) last year, but I didn't follow through with actual code. We have various search fields in KDE that do something like "only search on length > 3", and they fail miserably with CJK input. KRunner is one such example.

Mon, Nov 13, 7:18 PM · Frameworks
hein closed D8723: When used by QML, only populate after component is complete.
Mon, Nov 13, 1:21 PM · Plasma
hein committed R120:b40c0de099fc: When used by QML, only populate after component is complete (authored by hein).
When used by QML, only populate after component is complete
Mon, Nov 13, 1:21 PM
hein added a comment to D8524: Add a signal notifying a change in the names of running activities..

Looking at the KActivities API more, perhaps not exposing this directly was deliberate of Ivan as otherwise Consumer would probably have all of the Cache signals. Ivan, can you opine on this?

Mon, Nov 13, 1:21 PM · Plasma
hein added a comment to D8524: Add a signal notifying a change in the names of running activities..

I inquired upstream about a signal/API a few times and wasn't told about this signal. I will look into it, unless Ivan wants to.

Mon, Nov 13, 12:56 PM · Plasma
hein added a comment to D8771: Use heuristic weighted length algorithm to calculate the query term length..

I've found this problem in many KDE UIs, and I'd like to have a generic solution. How do you feel about adding something like a logicalStringLength() to KCoreAddons or KCodecs? Then we can use it in KRunner, KMail, Amarok, ...

Mon, Nov 13, 12:48 PM · Plasma

Sun, Nov 12

hein accepted D8744: Use Qt.callLater instead of creating a Timer.
Sun, Nov 12, 8:04 AM · Plasma
hein accepted D7810: Add missing icon sizes.

Do you need someone to commit this for you or do you have access?

Sun, Nov 12, 7:59 AM · Frameworks, Breeze

Sat, Nov 11

hein added a comment to D8524: Add a signal notifying a change in the names of running activities..

Ping

Sat, Nov 11, 12:13 AM · Plasma

Fri, Nov 10

hein committed R7:39f5e4c0dc47: Adjust for next dev cycle. (authored by hein).
Adjust for next dev cycle.
Fri, Nov 10, 11:18 PM
hein committed R7:6c1ad744ac3b: Merge branch '1.7' (authored by hein).
Merge branch '1.7'
Fri, Nov 10, 11:18 PM
hein committed R7:ada9f4af2d2e: Cleanup. (authored by hein).
Cleanup.
Fri, Nov 10, 10:11 PM
hein committed R7:fdf289bdf9d3: Fix paste-from-clipboard behavior with selected text in the input field (authored by hein).
Fix paste-from-clipboard behavior with selected text in the input field
Fri, Nov 10, 10:08 PM
hein committed R7:fba85a6f6696: Merge branch '1.7' (authored by hein).
Merge branch '1.7'
Fri, Nov 10, 10:08 PM
hein committed R7:1c16992ec73b: Stricter. (authored by hein).
Stricter.
Fri, Nov 10, 10:08 PM
hein committed R7:d24d340b4324: Adjust for release. (authored by hein).
Adjust for release.
Fri, Nov 10, 10:08 PM
hein committed R7:34cc9556c1a0: Merge branch '1.6' into 1.7 (authored by hein).
Merge branch '1.6' into 1.7
Fri, Nov 10, 10:08 PM
hein committed R7:8ec44bc849fa: Flesh out changelog some more. (authored by hein).
Flesh out changelog some more.
Fri, Nov 10, 10:08 PM
hein committed R7:cebf8d7658b0: Merge branch '1.5' into 1.6 (authored by hein).
Merge branch '1.5' into 1.6
Fri, Nov 10, 10:08 PM
hein committed R7:955d6c8ef6e0: Update changelog (authored by hein).
Update changelog
Fri, Nov 10, 10:08 PM
hein committed R7:6a7f59ee1b9d: Stay within bounds (authored by argonel).
Stay within bounds
Fri, Nov 10, 10:08 PM
hein committed R7:6a1e858ac693: Merge branch '1.7' (authored by hein).
Merge branch '1.7'
Fri, Nov 10, 9:27 PM
hein committed R7:a1bdb206e213: Fix two custom text view font family reset bugs (authored by hein).
Fix two custom text view font family reset bugs
Fri, Nov 10, 9:26 PM

Thu, Nov 9

hein added a comment to D8739: Include fcitx's platform input context in runtime..

This makes sense to me conceptually. I can't comment on the flatpak recipe code though.

Thu, Nov 9, 6:15 PM
hein accepted D8608: Fix crash in KAStatsFavouritesModel.
Thu, Nov 9, 12:34 PM · Plasma

Wed, Nov 8

hein added a comment to D8524: Add a signal notifying a change in the names of running activities..

Please re-review, my above comment and diff update were submitted together.

Wed, Nov 8, 3:39 PM · Plasma
hein added inline comments to D8524: Add a signal notifying a change in the names of running activities..
Wed, Nov 8, 3:39 PM · Plasma
hein updated the diff for D8524: Add a signal notifying a change in the names of running activities..

Don't connect too rowsInserted/rowsRemoved.

Wed, Nov 8, 3:38 PM · Plasma
hein updated the diff for D8723: When used by QML, only populate after component is complete.

Fix review comments by David and Kai.

Wed, Nov 8, 3:29 PM · Plasma
hein added a comment to D8524: Add a signal notifying a change in the names of running activities..

ping?

Wed, Nov 8, 2:15 PM · Plasma
hein added a reviewer for D8525: Refresh when the names of the running activities change.: Plasma.

ping?

Wed, Nov 8, 2:15 PM · Plasma
hein created D8723: When used by QML, only populate after component is complete.
Wed, Nov 8, 2:14 PM · Plasma

Mon, Nov 6

hein abandoned D8676: bad textarea width for rename file if filename too short.
Mon, Nov 6, 3:14 PM
hein commandeered D8676: bad textarea width for rename file if filename too short.
Mon, Nov 6, 3:14 PM
hein added a comment to D8676: bad textarea width for rename file if filename too short.

And you just lost any chance of me accepting your patch, cf. https://www.kde.org/code-of-conduct/

Mon, Nov 6, 3:14 PM
hein added a comment to D8676: bad textarea width for rename file if filename too short.

Did you read the Phabricator ticket referenced in the original commit?

Mon, Nov 6, 1:41 PM
hein added a comment to D8676: bad textarea width for rename file if filename too short.

The original commit fixed broken RTL support. Did you test that this works with RTL? Because from a quick look it looks like you just reverted the code to its old, broken state.

Mon, Nov 6, 8:52 AM

Sun, Nov 5

hein added a comment to D8598: FolderView: position files at drop event target position.

This looks quite good to me now - the fact that it's much shorter than my old attempt feels pretty nice ;)

Sun, Nov 5, 7:20 AM · Plasma

Fri, Nov 3

hein accepted D8617: Folder View previews dialogue: Improve visual layout.
Fri, Nov 3, 11:12 AM · Plasma

Thu, Nov 2

hein added a comment to D8598: FolderView: position files at drop event target position.

IRC talk for posterity:

Thu, Nov 2, 9:01 AM · Plasma
hein accepted D8611: Kicker: Use QtLoggingRules.
Thu, Nov 2, 8:58 AM · Plasma
hein accepted D8520: Set CXX min version to C++11, fix of warnings.

Please put into wip/qtquick :)

Thu, Nov 2, 8:55 AM
hein added a comment to D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked.

What would you propose?

Thu, Nov 2, 8:53 AM · Plasma
hein added a comment to D8596: Fix memory leak in FolderModel::drop.

It's not necessary to delete connections. When a QObject is destroyed this is done already. Patch rejected sorry :)

Thu, Nov 2, 8:49 AM · Plasma

Wed, Nov 1

hein added a comment to D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked.

I still don't like it, sorry - the patch also feels technically and semantically wrong to me. "If widgets are locked, stop adding a certain kind of data to the drag" is a pretty bad hack.

Wed, Nov 1, 12:10 PM · Plasma
hein added a comment to D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked.

As-is I would not accept this patch, I'm sorry. Task Manager items are not widgets, it's content, and the widget mutability state should not affect content drags.

Wed, Nov 1, 11:46 AM · Plasma
hein added a comment to D8520: Set CXX min version to C++11, fix of warnings.

About those unreachable statements: Could you leave them in but comment them out? I have a feeling that was someone's poor attempt at leaving a TODO in ...

Wed, Nov 1, 11:20 AM
hein added inline comments to D8520: Set CXX min version to C++11, fix of warnings.
Wed, Nov 1, 9:47 AM
hein accepted D8563: Folder View icons properties: Improve visual layout.

Lovely, again thanks so much for tackling this, it's long overdue.

Wed, Nov 1, 9:18 AM · Plasma

Mon, Oct 30

hein accepted D8549: We use Q_DECL_OVERRIDE or override..
Mon, Oct 30, 8:46 AM · Plasma
hein accepted D8515: Don't loop twice here.
Mon, Oct 30, 8:46 AM · Plasma
hein accepted D8516: Emit signal when we change PerStripe.

One more newline after the emit line please, otherwise GTG.

Mon, Oct 30, 8:05 AM · Plasma
hein accepted D8517: Test enable status change and perStripe change.
Mon, Oct 30, 8:04 AM · Plasma
hein added inline comments to D7810: Add missing icon sizes.
Mon, Oct 30, 7:19 AM · Frameworks, Breeze
hein updated the diff for D8524: Add a signal notifying a change in the names of running activities..

Also handle empty roles.

Mon, Oct 30, 7:09 AM · Plasma
hein added a comment to D8524: Add a signal notifying a change in the names of running activities..
In D8524#161438, @ivan wrote:

Also, not sure adding a signal that has one user only to a shared library is the best approach, especially since .h says this:

37  * @NOTE: This is a placeholder, to be moved into KActivities (which it         
38  * wraps) or the Task Manager applet backend.

But this is your call.

Mon, Oct 30, 7:08 AM · Plasma

Fri, Oct 27

hein created D8525: Refresh when the names of the running activities change..
Fri, Oct 27, 2:48 PM · Plasma
hein added a dependent revision for D8524: Add a signal notifying a change in the names of running activities.: D8525: Refresh when the names of the running activities change..
Fri, Oct 27, 2:48 PM · Plasma
hein created D8524: Add a signal notifying a change in the names of running activities..
Fri, Oct 27, 2:47 PM · Plasma
hein added a comment to D8520: Set CXX min version to C++11, fix of warnings.

This is nice, but it would be great to fix the other 20% of warnings it causes, too, otherwise it's a noisy build that hides more important warnings :)

Fri, Oct 27, 2:04 PM
hein accepted D8513: Use emit as all other code use emit and not Q_EMIT.
Fri, Oct 27, 7:58 AM · Plasma
hein accepted D8447: Add unit tests for Folder View.

Please don't extend already-accepted review requests with new code without requesting more review. Otherwise the status stays "Accepted" on code that hasn't actually been reviewed, which is confusing and holds things up :)

Fri, Oct 27, 7:11 AM · Plasma

Thu, Oct 26

hein accepted D8476: qPort to new connect api + use const'ref.
Thu, Oct 26, 8:50 AM · Plasma
hein accepted D8473: Modernize code. Use nullptr where it's possible.
Thu, Oct 26, 8:49 AM · Plasma