hein (Eike Hein)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:07 PM (196 w, 5 d)
Availability
Available

Recent Activity

Wed, Jan 16

hein committed R120:f16c4616837c: Default to 1 row. (authored by hein).
Default to 1 row.
Wed, Jan 16, 12:24 PM
hein added inline comments to D18290: Use KWin's D-Bus interface to get desktop layout rows on Wayland.
Wed, Jan 16, 12:23 PM · Plasma
hein committed R120:49d9553f15c8: Use KWin's D-Bus interface to get desktop layout rows on Wayland (authored by hein).
Use KWin's D-Bus interface to get desktop layout rows on Wayland
Wed, Jan 16, 12:19 PM
hein closed D18290: Use KWin's D-Bus interface to get desktop layout rows on Wayland.
Wed, Jan 16, 12:19 PM · Plasma
hein added a comment to T4457: [kwayland] Virtual Desktop protocol.

Stop-gap Plan B for delayed D17691, please help review: https://phabricator.kde.org/D18290

Wed, Jan 16, 8:36 AM · Plasma
hein requested review of D18290: Use KWin's D-Bus interface to get desktop layout rows on Wayland.
Wed, Jan 16, 8:35 AM · Plasma

Tue, Jan 15

hein added a comment to T4457: [kwayland] Virtual Desktop protocol.

<3

Tue, Jan 15, 9:16 AM · Plasma
hein added a comment to T4457: [kwayland] Virtual Desktop protocol.

Another bugs that needs fixing: https://bugs.kde.org/show_bug.cgi?id=403226

Tue, Jan 15, 9:08 AM · Plasma
hein requested review of D18182: Fix new file creation leading to dupe items on a fresh view.

Requesting re-review due to significant behavior changes following @fvogt's comment

Tue, Jan 15, 8:59 AM · Plasma
hein updated the diff for D18182: Fix new file creation leading to dupe items on a fresh view.

Fix comments and make code reflect comment intent

Tue, Jan 15, 8:58 AM · Plasma

Sat, Jan 12

hein added a comment to T4457: [kwayland] Virtual Desktop protocol.

True enough.

Sat, Jan 12, 6:07 PM · Plasma
hein added a comment to T4457: [kwayland] Virtual Desktop protocol.

The pro-parity argument is mostly: Eventually I/we will stop testing X11, and X11-only features carry a maintenance burden. I'll think about it, nothing we need to solve for 5.15 though I guess.

Sat, Jan 12, 6:03 PM · Plasma
hein added a comment to T4457: [kwayland] Virtual Desktop protocol.

Yeah, I agree with you. The question is, should I just remove it from the X11 version so we have parity then?

Sat, Jan 12, 5:56 PM · Plasma
hein added a comment to T4457: [kwayland] Virtual Desktop protocol.

We've made progress since the last TODO comment. Here's an updated one:

Sat, Jan 12, 5:21 PM · Plasma
hein updated subscribers of T4457: [kwayland] Virtual Desktop protocol.
Sat, Jan 12, 5:19 PM · Plasma
hein added a comment to T4457: [kwayland] Virtual Desktop protocol.

Bug: https://bugs.kde.org/show_bug.cgi?id=403145

Sat, Jan 12, 5:18 PM · Plasma
hein added a revision to T4457: [kwayland] Virtual Desktop protocol: D17691: Add rows info to the plasma virtual desktop protocol.
Sat, Jan 12, 5:18 PM · Plasma
hein added a task to D17691: Add rows info to the plasma virtual desktop protocol: T4457: [kwayland] Virtual Desktop protocol.
Sat, Jan 12, 5:18 PM · Frameworks

Fri, Jan 11

hein accepted D18187: [KNewFileMenu] Don't emit fileCreated when creating a directory.
Fri, Jan 11, 4:20 PM · Frameworks
hein accepted D18186: set skipTaskbar on SurfaceEvent::SurfaceCreated.
Fri, Jan 11, 4:00 PM · Plasma
hein updated the diff for D18182: Fix new file creation leading to dupe items on a fresh view.

Forgot a hunk when moving to 5.12 branch.

Fri, Jan 11, 12:48 PM · Plasma
hein updated the diff for D18182: Fix new file creation leading to dupe items on a fresh view.

Add BUG to message.

Fri, Jan 11, 12:46 PM · Plasma
hein added a comment to D17689: [RFC] Positioner: call initMaps even if m_enabled == false.

Here's my take: https://phabricator.kde.org/D18182

Fri, Jan 11, 12:45 PM · Plasma
hein requested review of D18182: Fix new file creation leading to dupe items on a fresh view.
Fri, Jan 11, 12:45 PM · Plasma
hein added a comment to D17689: [RFC] Positioner: call initMaps even if m_enabled == false.

Thanks for the ping, it worked :)

Fri, Jan 11, 12:22 PM · Plasma
hein added a comment to D17691: Add rows info to the plasma virtual desktop protocol.

The desktop cube shows everything flat, desktop grid is configurable (and hardcoded).

Fri, Jan 11, 12:18 PM · Frameworks

Wed, Jan 9

hein added a comment to D17691: Add rows info to the plasma virtual desktop protocol.

As per this, progress on this is currently blocking wrapping up Wayland virtual desktops support for 5.15.

Wed, Jan 9, 5:42 PM · Frameworks
hein committed R120:2a1c677472ff: Question resolved: Code unnecessary (authored by hein).
Question resolved: Code unnecessary
Wed, Jan 9, 5:38 PM

Sun, Jan 6

hein added a comment to D17925: [containmentactions/switchwindow] Fix loop itteration.

Sorry about this, thx for fixing :)

Sun, Jan 6, 10:06 AM · Plasma

Sat, Jan 5

hein committed R120:bb865db2d561: Fix removing first item in languages list (authored by hein).
Fix removing first item in languages list
Sat, Jan 5, 4:10 PM
hein committed R120:d06fc5333f71: Merge branch 'Plasma/5.14' (authored by hein).
Merge branch 'Plasma/5.14'
Sat, Jan 5, 4:10 PM
hein committed R120:f1ca0ea422d2: fix translations kcm to be usable on new users/installations (authored by sitter).
fix translations kcm to be usable on new users/installations
Sat, Jan 5, 4:10 PM
hein committed R120:05621000bd10: Use the new drag handle in the Language KCM (authored by hein).
Use the new drag handle in the Language KCM
Sat, Jan 5, 4:10 PM
hein committed R120:38c66b90efcc: Fix adding langs more than once within the same session. (authored by hein).
Fix adding langs more than once within the same session.
Sat, Jan 5, 4:10 PM
hein committed R120:68b2a7556856: Port Language KCM to Qt Quick (authored by hein).
Port Language KCM to Qt Quick
Sat, Jan 5, 4:10 PM
hein committed R120:68021da4e920: Revert "Port Language KCM to Qt Quick" (authored by hein).
Revert "Port Language KCM to Qt Quick"
Sat, Jan 5, 4:10 PM
hein committed R120:6c5869affb5f: Port Language KCM to Qt Quick (authored by hein).
Port Language KCM to Qt Quick
Sat, Jan 5, 4:10 PM
hein committed R120:d0f9475b3af5: Merge branch 'Plasma/5.10' (authored by hein).
Merge branch 'Plasma/5.10'
Sat, Jan 5, 4:10 PM
hein committed R120:19b4d64107f5: Merge branch 'Plasma/5.9' (authored by hein).
Merge branch 'Plasma/5.9'
Sat, Jan 5, 4:10 PM
hein committed R120:f3d4b8ad6b9b: Merge branch 'Plasma/5.8' into Plasma/5.9 (authored by hein).
Merge branch 'Plasma/5.8' into Plasma/5.9
Sat, Jan 5, 4:10 PM
hein committed R120:3cc8a94f2ba4: Merge branch 'Plasma/5.5' (authored by hein).
Merge branch 'Plasma/5.5'
Sat, Jan 5, 4:09 PM
hein committed R120:b4cd6993fdbe: Merge branch 'Plasma/5.3' (authored by hein).
Merge branch 'Plasma/5.3'
Sat, Jan 5, 4:09 PM
hein committed R120:57752231055c: Merge branch 'Plasma/5.2' (authored by hein).
Merge branch 'Plasma/5.2'
Sat, Jan 5, 4:09 PM
hein added inline comments to D17975: [Notifications] Add padding to notifications.
Sat, Jan 5, 2:50 AM · Plasma

Wed, Jan 2

hein committed R119:70ae3a31f545: Merge branch 'Plasma/5.14' (authored by hein).
Merge branch 'Plasma/5.14'
Wed, Jan 2, 8:31 AM
hein committed R119:7fca6ede19af: Fix removing first item in languages list (authored by hein).
Fix removing first item in languages list
Wed, Jan 2, 8:30 AM
hein closed D17218: Fix removing first item in languages list.
Wed, Jan 2, 8:30 AM · Plasma
hein added inline comments to D17218: Fix removing first item in languages list.
Wed, Jan 2, 8:28 AM · Plasma
hein accepted D17809: Check icon positions after move.
Wed, Jan 2, 7:39 AM · Plasma
hein committed R954:94ce0f993f4f: Update Eike's hackergotchi. (authored by hein).
Update Eike's hackergotchi.
Wed, Jan 2, 7:31 AM

Dec 22 2018

hein accepted D17725: [RFC] Fix model updates in RunnerMatchesModel.

I don't think it's necessary to optimize the dataChanged emits at this time - in the common case the roles the delegate is visualizing (label, icon) will always change, and the other rules are lazy-evaluated by the current UI (e.g. the context menu actions are constructed on-demand). Realistically, computing the roles delta to figure out the roles will likely eat more CPU time unless the users of the module show a different usage pattern. I'm OK with this with a "// TODO: Could be optimized by ... if needed" in the code.

Dec 22 2018, 10:05 AM · Plasma
hein abandoned D17700: [kcmkwin/desktop] Add back switching animation setting.

Yes and no, the problem with temporary "workarounds" is that they often become permanent. So, I still suggest to go with the "right" approach even if it'll cause that regression.

Dec 22 2018, 9:57 AM · KWin
hein added inline comments to D17700: [kcmkwin/desktop] Add back switching animation setting.
Dec 22 2018, 9:50 AM · KWin

Dec 20 2018

hein added a comment to D17265: Fix changing the number of rows via the dbus protocol.

unrelated addition of empty line

Dec 20 2018, 6:26 PM · KWin
hein added a comment to D17700: [kcmkwin/desktop] Add back switching animation setting.

I agree with you, although I'll add that not having the setting at all in the KCM is a regression, but not having the model is not as the old KCM didn't have that ability. Sometimes we reject patches without thinking about the end-user picture.

Dec 20 2018, 1:28 PM · KWin
hein added a comment to D17700: [kcmkwin/desktop] Add back switching animation setting.

What I guess I'm asking is: Do we even have category metadata for the plugins? From the above I'm guessing the answer is yes.

Dec 20 2018, 12:47 PM · KWin
hein added a comment to D17689: [RFC] Positioner: call initMaps even if m_enabled == false.

Cool, thanks for the update. I'm a bit flooded before the Christmas holidays, but I'll try to make sense of this in early 2019.

Dec 20 2018, 10:54 AM · Plasma
hein added a comment to D17700: [kcmkwin/desktop] Add back switching animation setting.
In D17700#379803, @zzag wrote:

Would it be feasible to create a model for virtual desktop switching animations instead of hard coding them?

Dec 20 2018, 5:40 AM · KWin

Dec 19 2018

hein updated the diff for D17700: [kcmkwin/desktop] Add back switching animation setting.

++typeSafety;

Dec 19 2018, 8:19 PM · KWin
hein added reviewers for D17218: Fix removing first item in languages list: davidedmundson, broulik.

Ping?

Dec 19 2018, 8:17 PM · Plasma
hein requested review of D17700: [kcmkwin/desktop] Add back switching animation setting.
Dec 19 2018, 8:16 PM · KWin
hein accepted D17265: Fix changing the number of rows via the dbus protocol.
Dec 19 2018, 8:16 PM · KWin
hein added a comment to D17689: [RFC] Positioner: call initMaps even if m_enabled == false.

Thanks for your submission. Could you provide a description for this patch? What does it fix, why does it fix it?

Dec 19 2018, 3:14 PM · Plasma

Dec 18 2018

hein added a comment to T4457: [kwayland] Virtual Desktop protocol.

To clarify, it's possible to DND a window from desktop to desktop. "Can't move yet" refers to within a desktop by dragging the window a few pixels.

Dec 18 2018, 5:24 PM · Plasma
hein added a revision to T4457: [kwayland] Virtual Desktop protocol: D17265: Fix changing the number of rows via the dbus protocol.
Dec 18 2018, 8:15 AM · Plasma
hein added a task to D17265: Fix changing the number of rows via the dbus protocol: T4457: [kwayland] Virtual Desktop protocol.
Dec 18 2018, 8:15 AM · KWin
hein updated subscribers of T4457: [kwayland] Virtual Desktop protocol.
Dec 18 2018, 8:03 AM · Plasma
hein updated subscribers of T4457: [kwayland] Virtual Desktop protocol.

I'm now aware of the following remaining todos:

Dec 18 2018, 8:02 AM · Plasma
hein committed R120:6e41b8d98e06: Port the "Switch Desktop" containment action to libtaskmanager (authored by hein).
Port the "Switch Desktop" containment action to libtaskmanager
Dec 18 2018, 7:56 AM
hein closed D15599: Port the "Switch Desktop" containment action to libtaskmanager.
Dec 18 2018, 7:56 AM · Plasma
hein committed R120:c64fc46955f2: Port "Switch Window" containment action to updated libtaskmanager API and away… (authored by hein).
Port "Switch Window" containment action to updated libtaskmanager API and away…
Dec 18 2018, 7:54 AM
hein closed D15642: Port "Switch Window" containment action to updated libtaskmanager API and away from KWindowSystem.
Dec 18 2018, 7:54 AM · Plasma
hein committed R119:c92b97fe9390: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support (authored by hein).
Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support
Dec 18 2018, 7:52 AM
hein closed D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support.
Dec 18 2018, 7:52 AM · Plasma
hein committed R119:b0d6eab4a698: Adjust Task Manager to libtaskmanager API changes for Wayland virtual desktop… (authored by hein).
Adjust Task Manager to libtaskmanager API changes for Wayland virtual desktop…
Dec 18 2018, 7:48 AM
hein closed D13746: Adjust Task Manager to libtaskmanager API changes for Wayland virtual desktop support.
Dec 18 2018, 7:48 AM · Plasma
hein committed R120:52d760c57c24: Implement support for virtual desktops on Wayland (authored by hein).
Implement support for virtual desktops on Wayland
Dec 18 2018, 7:47 AM
hein closed D13745: Implement support for virtual desktops on Wayland.
Dec 18 2018, 7:47 AM · Plasma
hein closed T4461: [kwin] Virtual Desktops KCM needs porting, a subtask of T4457: [kwayland] Virtual Desktop protocol, as Resolved.
Dec 18 2018, 7:44 AM · Plasma
hein closed T4461: [kwin] Virtual Desktops KCM needs porting as Resolved.

Closed with https://phabricator.kde.org/D14542

Dec 18 2018, 7:44 AM · Plasma on Wayland
hein committed R108:cee5ea7819b2: [kcmkwin/desktop] KCM using new virtual desktops DBus interface (authored by hein).
[kcmkwin/desktop] KCM using new virtual desktops DBus interface
Dec 18 2018, 7:43 AM
hein closed D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.
Dec 18 2018, 7:43 AM · KWin
hein updated the diff for D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.
  • Add missing upper bound to the Rows spinbox (cf. 06a9a2a468df).
  • Change 'msec' to 'ms'.
Dec 18 2018, 7:43 AM · KWin
hein added inline comments to D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.
Dec 18 2018, 7:23 AM · KWin

Dec 15 2018

hein added a comment to D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

Apply button working for me: https://youtu.be/LvMhpCLxdWY

Dec 15 2018, 6:41 AM · KWin
hein added a comment to D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.
In D14542#376846, @zzag wrote:

Hmm, I'm no longer able to save new settings, i.e. if any option has been changed, the Apply button is still not enabled.

Dec 15 2018, 6:39 AM · KWin
hein accepted D17393: [Folder View] make file context menu consistent with Dolphin's.

Alrighty, I'll go in with the majority opinion then. Consistency is certainly an improvement by itself. Go go go!

Dec 15 2018, 4:16 AM · Plasma

Dec 14 2018

hein updated the diff for D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

Fix initial state

Dec 14 2018, 5:57 AM · KWin
hein added a comment to D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

@ngraham From a UX perspective your comments make perfect sense, but unfortunately KWin currently has a flat list of desktops divided by number of rows so I need to decline that for now. It's out of scope for 5.15 for sure.

Dec 14 2018, 5:44 AM · KWin

Dec 10 2018

hein updated subscribers of D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

It turns out we all collectively forgot about the "Switching" tab in the original KCM.

Dec 10 2018, 7:24 AM · KWin
hein updated the diff for D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

Add back nav wrap and OSD settings.

Dec 10 2018, 7:21 AM · KWin

Dec 9 2018

hein accepted D17463: Use KWindowSystem to determine which display system is in use.
Dec 9 2018, 9:52 PM

Dec 8 2018

hein added a comment to D17393: [Folder View] make file context menu consistent with Dolphin's.

Can we patch Dolphin instead? I think the order there is pretty bad, with weird random dividers etc. (From the screenshots in the original user bug.) I prefer FV's.

Dec 8 2018, 11:54 AM · Plasma

Dec 5 2018

hein added a comment to D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

I'm no longer aware of bugs in this, please re-review it.

Dec 5 2018, 8:22 PM · KWin
hein updated the diff for D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

Further fixes to sync & co

Dec 5 2018, 8:21 PM · KWin
hein updated the diff for D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

Revamp KWin restart handling

Dec 5 2018, 12:00 PM · KWin

Nov 30 2018

hein updated the diff for D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

Handle KWin restarts

Nov 30 2018, 1:19 PM · KWin
hein updated the diff for D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

Rebase on master for good measure

Nov 30 2018, 12:08 PM · KWin
hein updated the diff for D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

Fix syncing to server.

Nov 30 2018, 11:24 AM · KWin

Nov 29 2018

hein added a comment to D17203: [Task Manager] Move apps to activities from the context menu.

Well, the entire point of activities existing is that they go beyond the limitations of desktops - you can add a window to 2 out of 5 activities, not just one or all. If it's the same, we don't need both.

Nov 29 2018, 4:04 PM · Plasma