- User Since
- Apr 15 2015, 5:07 PM (214 w, 4 d)
Fri, May 24
Thu, May 23
I wouldn't call this implementation ready for frameworks, though - it just resets all the time, which is very slow as it forces views to destroy and recreate delegates instead of just updating them. A better implementation would just (re)filter source rows corresponding to the current page. This could be done as a subclass of QSortFilterProxyModel or custom; KItemModels' KRearrangeColumnsProxyModel can serve as inspiration to some degree. As it stands I wouldn't uactually use this if it was in the framework.
It's not that easy I'm afraid.
Mon, May 13
I'd say it's up to the Breeze maintainers. From my end I'm very interested in the app having a Breeze-compatible icon, because I'd like it to integrate well with KDE's workspaces and other apps. Review by the Breeze community is very appreciated to help with that. Application code needs to ship the icon anyway though for systems that don't have the theme and can't be reasonably expected to provide every app icon, so it's not vital to be included with the theme.
@trickyricky26 It's great! What do you think about adding the detailed SVG as 256 version?
Mon, May 6
Sun, May 5
Tue, Apr 30
Looks great to me. Subtle visual refreshs like this are very appreciated, especially when they improve consistency, too.
Apr 26 2019
Apr 24 2019
Apr 22 2019
Apr 15 2019
Personally I'm not a big fan. I think the square OSD has more character and visual flair. The change proposed here looks rather cramped and removes some identity from the system.
Apr 14 2019
Apr 10 2019
Works here now, thx!
Apr 9 2019
I think it would be safer to Math.floor() rather than Math.round().
Apr 8 2019
Apr 6 2019
Apr 5 2019
Apr 4 2019
Do some cleanups suggested by Kai.
Apr 3 2019
Fix up qDeleteAll usage, thanks David
Suuper good question that I also don't have a really good answer to :( But it's always super good when a project figures out how to answer it (e.g. Krita took off after it made a call to be a painting app).
I'm not sure the "Konqueror had it and people are asking
for it back" argument is strong. Because Konqueror was also unpopular enough to get replaced by Dolphin and to end up largely unmaintained (although it is still released and available). To me that indicates that becoming more like Konqueror may actually be the wrong direction.
Apr 2 2019
About the icon issue, IconItem by default uses the icon theme overlay from the Plasma theme, Kirigami.Icon will use the regular Plasma icons. That's kind of tricky - with Breeze we could totally make them match, but other Plasma themes would have issues.
Sure, why would the release team bump an individual app version if it wants to follow a random scheme?
Or the QPA could look at the LnF in the first place instead of kdeglobals?
The Places panel is really for frequent and immediate access whereas bookmarks are more for long-term organization.
On the other hand, having the release team take care of all of this stuff automatically and on a predictable schedule is really nice.
But if all ‘KDE Applications’ applications used the ‘KDE Applications’ version number, KPat wouldn’t have to manage its version number …
Hang on, isn't this kind of redundant with Places? At the very least they overlap a lot. Is this feature individually strong enough to warrant that overlap?
So version ‘3.6’ can mean a number of different versions, each with its own sets of bugs and features.
I don't find being part of KDE Applications releases very compelling for many of my apps. The reasons vary - some are alternatives to other apps in the bundle, some don't act in concert with anything else in the bundle, it means sharing attention with many other things (in two ways - public attention, but also dev attention: many things have to be spun up and be ready for release simultaneously, which is inconvenient), it means no ability to set my own schedule. Not getting to set my own version would actually add to that list.
Again you can't have a full list on the announcement with 215 names and version numbers, it's just not feasible.
I think then we'd have to rethink the way we promote, which could also be a solution. I.e. stop having a version number for KDE Applications entirely, instead of having a YY.MM we just make a "KDE updates apps today" announcement on some day, and the announcement includes a full list with individual versions. If we don't want it to be used, why have the number?
Looks solid to me. Is your concern re vertical spacing still valid?
My gut reaction was to agree with @ltoscano whole-heartedly, but the more I think about it that stance does have awkward unsolved problems.
I'd say let's go with Kirigami.Icon for now then, and recolor the icon to the highlight color on hover. @faridb could you take a stab at that? :)
I checked the database and it looks like you don't have a developer account yet, so I'll land this patch for you. If you keep submitting patches, feel free to apply for a developer account via identity.kde.org at some point :)
Looks pretty nice to me. I have no objections.
Apr 1 2019
Thanks! Do you need help landing this?
Mar 28 2019
I guess this brings us back to the old debate of a generic solution vs. patching all the UIs. I'm inclined to agree with this approach because it should probably be up to the specific UI what it wants to happen on the gesture.
rooty, your behavior in this thread has been extremely aggressive, disrespectful and uncollaborative. I'd like to ask you to stop at this point and not participate futher, as well as in any future threads related to the Task Manager applets.
Mar 27 2019
This is a specious argument.
I'm not a fan of the checkbox, I think it's a little gratuitous. If you add a small feature and need to immediately add a checkbox to disable it, it's rather a red flag to me. It means either the feature or the checkbox should probably go. Firefox gets away without the option BTW.
Mar 22 2019
Mar 20 2019
Yeah, this looks fine, thanks!
Mar 18 2019
Mar 17 2019
Looks good now!
Kicker intentionally doesn't have icons on the root level to not conflict with the favorites column and reduce visual noise.
What's the name of the .desktop file though? That's the most relevant part.
Mar 16 2019
Mar 14 2019
Sorry, that's too fast and loose for me.
Mar 13 2019
Also, maybe we can just delete the .png files then and make the tarball smaller?