hein (Eike Hein)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:07 PM (127 w, 2 d)
Availability
Available

Recent Activity

Yesterday

hein committed R7:92e16810acbd: Keyboard focus and event routing fixes (authored by hein).
Keyboard focus and event routing fixes
Fri, Sep 22, 2:06 PM
hein committed R7:43c9386c2cd0: More scroll-down work (authored by hein).
More scroll-down work
Fri, Sep 22, 2:06 PM
hein committed R7:bb4280eb6ad2: One line too many (authored by hein).
One line too many
Fri, Sep 22, 5:14 AM
hein committed R7:c8ae4f24b40a: Redo auto-scroll-down once more (authored by hein).
Redo auto-scroll-down once more
Fri, Sep 22, 5:11 AM

Thu, Sep 21

hein committed R7:e7059bbfd8d6: Input field history and make shared input field optional (authored by hein).
Input field history and make shared input field optional
Thu, Sep 21, 2:36 AM
hein committed R7:6dcb592b2e42: Cancel completion when dismissing by ESC (authored by hein).
Cancel completion when dismissing by ESC
Thu, Sep 21, 12:12 AM
hein committed R7:1d32e9e1f6cd: Cancel completion when dismissing popup by ESC (authored by hein).
Cancel completion when dismissing popup by ESC
Thu, Sep 21, 12:12 AM

Wed, Sep 20

hein committed R7:ecfd15f2e326: Slightly smarter mock (authored by hein).
Slightly smarter mock
Wed, Sep 20, 10:15 PM
hein committed R7:8cfd458865ec: More key handling for completion popup (authored by hein).
More key handling for completion popup
Wed, Sep 20, 10:07 PM
hein committed R7:d863bcb6c15f: Mock completion suffix setting so I don't go insane while dogfooding (authored by hein).
Mock completion suffix setting so I don't go insane while dogfooding
Wed, Sep 20, 10:03 PM
hein committed R7:a8f769db7742: Expanding-with-text mode for input field (authored by hein).
Expanding-with-text mode for input field
Wed, Sep 20, 9:59 PM
hein committed R7:2b5b0e3c03b5: Add user name completion popup. (authored by hein).
Add user name completion popup.
Wed, Sep 20, 9:59 PM
hein committed R7:54f141b6174d: Move input field into its own file. (authored by hein).
Move input field into its own file.
Wed, Sep 20, 9:59 PM
hein committed R7:b73479b6261a: Rest completion on text changes as well (authored by hein).
Rest completion on text changes as well
Wed, Sep 20, 9:59 PM
hein committed R7:e3368babfd32: Do less busywork on shutdown; crash less, too. (authored by hein).
Do less busywork on shutdown; crash less, too.
Wed, Sep 20, 9:59 PM

Tue, Sep 19

hein committed R7:ced2bff8ce14: Add a comment (authored by hein).
Add a comment
Tue, Sep 19, 5:05 AM
hein committed R7:57d4ad0f1d53: ++correctness; (fixes a warning) (authored by hein).
++correctness; (fixes a warning)
Tue, Sep 19, 5:03 AM
hein committed R7:8f30ae42c0e3: Speed optimization; clean away debug (authored by hein).
Speed optimization; clean away debug
Tue, Sep 19, 5:00 AM
hein committed R7:cf4bbd9a78c5: Reimplement tab completion based on the new user models and QCompleter (authored by hein).
Reimplement tab completion based on the new user models and QCompleter
Tue, Sep 19, 4:52 AM
hein committed R7:a1f37dc71310: Add basic new user models and use for the user list (authored by hein).
Add basic new user models and use for the user list
Tue, Sep 19, 4:52 AM
hein committed R7:390b0bd573b2: Hide frame the style may inject. (authored by hein).
Hide frame the style may inject.
Tue, Sep 19, 4:52 AM

Sun, Sep 17

hein committed R7:a9646f751746: Use the tight rect after all. (authored by hein).
Use the tight rect after all.
Sun, Sep 17, 2:46 AM
hein committed R7:e09b07136bb1: Don't change cursor above links while tap-selecting. (authored by hein).
Don't change cursor above links while tap-selecting.
Sun, Sep 17, 2:40 AM
hein committed R7:801e46c843d2: Don't open links while tap-selecting. (authored by hein).
Don't open links while tap-selecting.
Sun, Sep 17, 2:39 AM
hein committed R7:68b7c1c3fdeb: Only open link on press+release above it. (authored by hein).
Only open link on press+release above it.
Sun, Sep 17, 2:36 AM
hein committed R7:500a8c06e8c2: Remove accidentally committed debug stuff. (authored by hein).
Remove accidentally committed debug stuff.
Sun, Sep 17, 2:31 AM
hein committed R7:2001af4b07e7: Don't forget to forward release. (authored by hein).
Don't forget to forward release.
Sun, Sep 17, 2:23 AM
hein committed R7:af844dfb36a6: Implement full mouse- and touch-based text selection (authored by hein).
Implement full mouse- and touch-based text selection
Sun, Sep 17, 2:23 AM

Sat, Sep 16

hein added a comment to D7813: Suppress yakuake "Unregister input type" warning when using qdbus.

I.e. this keeps the interface unchanged because the parameter-passing to the old method didn't actually work, or what is the idea here?

Sat, Sep 16, 2:09 PM

Fri, Sep 15

hein committed R7:db31a6b79779: Tighter selection rect for group parents. (authored by hein).
Tighter selection rect for group parents.
Fri, Sep 15, 11:44 AM
hein committed R7:272699fab754: Start to bring back text selection (authored by hein).
Start to bring back text selection
Fri, Sep 15, 11:37 AM
hein accepted D7830: Use a separate config value for Wayland font DPI.
Fri, Sep 15, 7:12 AM · Plasma
hein accepted D7831: Use a different key for font DPI on X and Wayland.
Fri, Sep 15, 7:03 AM · Plasma
hein added a comment to D7831: Use a different key for font DPI on X and Wayland.

The patch makes sense, but doesn't this indicate we screwed up something conceptually because the user now needs to set font dpi in awareness they'll be scaled after instead of set directly?

Fri, Sep 15, 6:32 AM · Plasma

Thu, Sep 14

hein requested changes to D7813: Suppress yakuake "Unregister input type" warning when using qdbus.

This is not acceptable as it breaks public D-Bus API.

Thu, Sep 14, 8:39 PM
hein accepted D7812: Fixes a yakuake "index out of range" crash produced by QDBus exposed function TabBar::sessionAtTab(int).
Thu, Sep 14, 8:37 PM

Wed, Sep 13

hein accepted D7807: When cloning a config also clone supportedFeatures.
Wed, Sep 13, 7:38 PM · Plasma
hein accepted D7798: [Folder View] Fix supported drag actions.
Wed, Sep 13, 7:37 PM · Plasma
hein committed R7:89c7678f6950: Drop from qmldir (authored by hein).
Drop from qmldir
Wed, Sep 13, 2:03 PM
hein committed R7:76ba39913351: Drop KUIC.ScrollHelper again (authored by hein).
Drop KUIC.ScrollHelper again
Wed, Sep 13, 2:03 PM

Tue, Sep 12

hein added a comment to D7768: [Task Manager] On containsMouse change always reset toolTipDelegate data.

Yeah this one looks odd to me too as per David ...

Tue, Sep 12, 11:04 AM · Plasma
hein accepted D7769: [Task Manager] Use Grid for grouped and single tooltips.
Tue, Sep 12, 11:03 AM · Plasma
hein added a comment to T6880: Implement Settings.

I'm open to different approaches.

Tue, Sep 12, 10:51 AM · Konversation

Mon, Sep 11

hein committed R7:f967c4cdca4c: Change version (authored by hein).
Change version
Mon, Sep 11, 10:33 AM

Sun, Sep 10

hein committed R7:764ff53eca10: Rework auto-scrolldown again; fix binding loop (authored by hein).
Rework auto-scrolldown again; fix binding loop
Sun, Sep 10, 9:11 AM
hein committed R7:01b0a336954f: Try out the new Kirigami.ColorScope (authored by hein).
Try out the new Kirigami.ColorScope
Sun, Sep 10, 7:49 AM
hein accepted D7733: [Folder View Icons Config] Fix initial index of ComboBox.
Sun, Sep 10, 7:20 AM · Plasma

Fri, Sep 8

hein accepted D3805: Per-activity favorites (Final, again?).

So I assume the bug was that I was getting too many favorites? Limit::all is now unlimited I assume? Otherwise it needs to be integrated with the maxFavorites stuff to disable the actions. (Does maxFavorites still work BTW? Because it's needed for Simple Menu on the KDE Store.)

Fri, Sep 8, 1:56 PM · Plasma
hein committed R7:1824c94be2fc: Force QT_QUICK_CONTROLS_STYLE=org.kde.desktop outside Plasma (authored by hein).
Force QT_QUICK_CONTROLS_STYLE=org.kde.desktop outside Plasma
Fri, Sep 8, 9:55 AM
hein committed R256:01ab9e01de7a: qqc2-desktop-style requires an out of source build (authored by hein).
qqc2-desktop-style requires an out of source build
Fri, Sep 8, 7:49 AM
hein committed R256:fb706c89b39c: Add qqc2-desktop-style to the konvi2x recipe (authored by hein).
Add qqc2-desktop-style to the konvi2x recipe
Fri, Sep 8, 7:46 AM
hein committed R7:1b9fce314764: Hide status bar by default for now. (authored by hein).
Hide status bar by default for now.
Fri, Sep 8, 7:43 AM
hein committed R256:bf7f088ad36e: Add dri (authored by hein).
Add dri
Fri, Sep 8, 7:32 AM

Thu, Sep 7

hein added a comment to D3805: Per-activity favorites (Final, again?).

Test failure using Kicker:

Thu, Sep 7, 3:23 PM · Plasma
hein committed R7:f49ebeac27cd: Fix crash when closing query tabs. (authored by hein).
Fix crash when closing query tabs.
Thu, Sep 7, 8:23 AM
hein accepted D7709: Make Yakuake work on Wayland with Qt 5.9.

Thanks!

Thu, Sep 7, 7:47 AM

Wed, Sep 6

hein accepted D7705: [Task Manager] Strip applications: scheme from launcher URL in MPris source.
Wed, Sep 6, 12:26 PM · Plasma
hein committed R256:799abcaca8d1: Fix up the patch and recipe for org.kde.konversation-konvi2x (authored by hein).
Fix up the patch and recipe for org.kde.konversation-konvi2x
Wed, Sep 6, 12:00 PM
hein committed R7:6752c59cf32d: Call the wrapper from Exec (authored by hein).
Call the wrapper from Exec
Wed, Sep 6, 11:54 AM
hein committed R7:8a967957db0b: And now actually add it (authored by hein).
And now actually add it
Wed, Sep 6, 11:37 AM
hein committed R7:030e69e15dbb: Add a 'konvi2x' shell script wrapper for Flatpak (authored by hein).
Add a 'konvi2x' shell script wrapper for Flatpak
Wed, Sep 6, 11:36 AM
hein added a comment to T6840: Qt World Summit.

Yep, still the plan. Updating the task would be highly useful and appreciated! @jensreuterberg is working on assets currently.

Wed, Sep 6, 8:31 AM · KDE Promo

Tue, Sep 5

hein committed R7:e7fd8145721e: Tweak sizes and better auto-scroll stopgap. (authored by hein).
Tweak sizes and better auto-scroll stopgap.
Tue, Sep 5, 3:28 PM
hein committed R7:45442371c2f7: Fix timestamp matching. (authored by hein).
Fix timestamp matching.
Tue, Sep 5, 3:28 PM
hein added a comment to D3805: Per-activity favorites (Final, again?).

It aaaalmost looked good, but I got this bug back:

Tue, Sep 5, 2:36 PM · Plasma
hein committed R256:e992d869df51: Pedantic cleanup (authored by hein).
Pedantic cleanup
Tue, Sep 5, 9:30 AM
hein committed R256:e50cd5af06b4: Rename konversation-qtquick to konversation-konvi2x (authored by hein).
Rename konversation-qtquick to konversation-konvi2x
Tue, Sep 5, 9:29 AM
hein committed R256:69fe7d3e178d: Fix org.kde.klimbgrades and org.kde.konversation-qtquick builds (authored by hein).
Fix org.kde.klimbgrades and org.kde.konversation-qtquick builds
Tue, Sep 5, 9:23 AM
hein added a comment to D3805: Per-activity favorites (Final, again?).

^ What's new in the latest rev?

Tue, Sep 5, 8:08 AM · Plasma
hein added a comment to D7649: Add nightly for experimental Konversation Qt Quick branch.

Both this and org.kde.klimbgrades are currently failing because they pull in Kirigami master which needs KF5 5.38. How should we proceed to fix this?

Tue, Sep 5, 7:33 AM

Mon, Sep 4

hein committed R256:62d86ea76128: Add nightly for experimental Konversation Qt Quick branch (authored by hein).
Add nightly for experimental Konversation Qt Quick branch
Mon, Sep 4, 12:00 PM
hein closed D7649: Add nightly for experimental Konversation Qt Quick branch by committing R256:62d86ea76128: Add nightly for experimental Konversation Qt Quick branch.
Mon, Sep 4, 12:00 PM
hein added a comment to D3805: Per-activity favorites (Final, again?).

With the updated kactivitymanagerd the missing favorite no longer happens, although the "also add it on the second activity by checking item" step inserts it in a strange position of last-2 instead of appending it on the same applet on the other activity - considering all the other faves in the test are shared, I'd expect it to appear the end (where it also was on the first activity). Still, progress!

Mon, Sep 4, 11:25 AM · Plasma
hein added a comment to D7649: Add nightly for experimental Konversation Qt Quick branch.

Should I add it to top-level then instead of todo/? Does anything else need to be done after or will it start generating packages and putting them into the repo at next run?

Mon, Sep 4, 11:11 AM
hein added a comment to D3805: Per-activity favorites (Final, again?).

After the port, all launchers have the same items on the top, with the new items added to the end. Do you have any speial URL formats in your original favorites (preferred: needed special treatment, that is why I'm asking)? Can you check whether the plasma configuration file has the correct order?

Mon, Sep 4, 11:06 AM · Plasma
hein committed R7:e4afce35625a: Revert "Fix binding loop." (authored by hein).
Revert "Fix binding loop."
Mon, Sep 4, 10:28 AM
hein added a reverting commit for R7:85263786af80: Fix binding loop.: R7:e4afce35625a: Revert "Fix binding loop.".
Mon, Sep 4, 10:28 AM
hein committed R7:85263786af80: Fix binding loop. (authored by hein).
Fix binding loop.
Mon, Sep 4, 10:23 AM
hein committed R7:c50abfb09820: Cleanup the UI package loading. (authored by hein).
Cleanup the UI package loading.
Mon, Sep 4, 9:47 AM
hein added a comment to D3805: Per-activity favorites (Final, again?).

And another round of testing:

Mon, Sep 4, 9:35 AM · Plasma
hein committed R7:30fb1d260f6d: Install a .desktop into kservicetypes5 to silence warning. (authored by hein).
Install a .desktop into kservicetypes5 to silence warning.
Mon, Sep 4, 8:57 AM
hein committed R7:4db9499fee94: Make context drawer drag-resizable; factor drag handle code out to uicomponents (authored by hein).
Make context drawer drag-resizable; factor drag handle code out to uicomponents
Mon, Sep 4, 7:35 AM

Sat, Sep 2

hein added a comment to D3805: Per-activity favorites (Final, again?).

The Kickoff thing looks more like a model bug to me - there's a duplicate delegate for "Firefox", and one of them has a broken row index (-1). Stuff like that is usually the result of confusing the view with broken model transactions ... the QML is very simple (that binding loop is a subitem of the delegate so it's not relevant to the placement) and just plain ListView really.

Sat, Sep 2, 7:28 AM · Plasma
hein added a comment to D3805: Per-activity favorites (Final, again?).

kactivities-stats hasn't built for me in a long time fwiw:

Sat, Sep 2, 6:56 AM · Plasma
hein updated the diff for D7649: Add nightly for experimental Konversation Qt Quick branch.

Add Kirigami master ala Klimbgrades' recipe.

Sat, Sep 2, 5:56 AM
hein updated the diff for D7649: Add nightly for experimental Konversation Qt Quick branch.

From https://www.mankier.com/5/flatpak-manifest I'm not 100% sure
the top-level branch applies to the git module source, so specify
for good measure.

Sat, Sep 2, 5:51 AM
hein added a comment to D7649: Add nightly for experimental Konversation Qt Quick branch.

Note: I need a debugfull build because the --nui CLI arg (that bypasses the single-instance application mechanic and allows running multiple Konversation instances) is only available in debug builds.

Sat, Sep 2, 5:46 AM
hein created D7649: Add nightly for experimental Konversation Qt Quick branch.
Sat, Sep 2, 5:45 AM
hein accepted D7639: [Task Manager] Decode applications URL before dragging.
Sat, Sep 2, 4:56 AM · Plasma
hein accepted D7631: [Folder View] Accept and reject Escape event appropriately.

Nice then!

Sat, Sep 2, 4:56 AM · Plasma

Thu, Aug 31

hein added a comment to D3805: Per-activity favorites (Final, again?).

Good news: There's actually nothing to do on the favorite ids, Kicker already uses KService::storageId as favorite id, which will be the menuId when it's available.

Thu, Aug 31, 8:26 PM · Plasma
hein committed R119:ee7078864b75: Support edit and appstream actions also for application search results (authored by hein).
Support edit and appstream actions also for application search results
Thu, Aug 31, 8:14 PM
hein closed D7567: Support edit and appstream actions also for application search results by committing R119:ee7078864b75: Support edit and appstream actions also for application search results.
Thu, Aug 31, 8:14 PM · Plasma
hein added a comment to D3805: Per-activity favorites (Final, again?).

I haven't managed to make this work. The problem is that the favourites are added asynchronously, and setting the ordering for a bunch of them at once fails because the items do not exist.

Thu, Aug 31, 5:26 PM · Plasma
hein added a comment to D7631: [Folder View] Accept and reject Escape event appropriately.

Does this have any ramifications in widget mode (panel, etc)?

Thu, Aug 31, 5:04 PM · Plasma
hein accepted D7632: [Folder View] Also handle Enter key (on numpad) to run files and cd into folders.
Thu, Aug 31, 5:03 PM · Plasma
hein committed R7:a0eaffe5dce0: More performance work (authored by hein).
More performance work
Thu, Aug 31, 9:58 AM
hein added a comment to D7586: [Folder View] Delay delegate creation until plasmoid expands.

Looks good, go.

Thu, Aug 31, 8:47 AM · Plasma

Wed, Aug 30

hein added a comment to D3805: Per-activity favorites (Final, again?).

No, thatfeels even more convoluted :(. Let's keep the current patch UI and focus on merge, we'll talk to the VDG about the UI after.

Wed, Aug 30, 8:18 AM · Plasma
hein added a comment to D3805: Per-activity favorites (Final, again?).

Do you want it in this patch, or to push this one and add the kickoff one asap?

Wed, Aug 30, 6:18 AM · Plasma