hein (Eike Hein)
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:07 PM (465 w, 5 d)
Availability
Available

Recent Activity

Oct 3 2022

hein added a comment to T12533: Make kconf_update more robust.

From the KF6 BoF at Akademy 2022:

Oct 3 2022, 2:48 PM · KF6

Jul 11 2020

hein added a comment to T13158: Define a reference appearance and help users have a consistent experience of on-screen object sizes.

Overall this makes quite good sense, and I applaud the effort. Couple of thoughts and notes:

Jul 11 2020, 10:24 PM · KWin, VDG

Jun 25 2020

hein added a comment to T13332: Port Pager from Dataengines.

Looks resolved by https://invent.kde.org/plasma/plasma-desktop/-/commit/ab42f47d74288d6a824c85202ba1d1be727f811d

Jun 25 2020, 8:50 PM · Plasma 6
hein claimed T13332: Port Pager from Dataengines.
Jun 25 2020, 8:48 PM · Plasma 6
hein added a comment to T13332: Port Pager from Dataengines.

You sure we still use a data engine here? I think I already rewrote this to libtm last time around. If there's anything left I'll take it.

Jun 25 2020, 8:47 PM · Plasma 6

May 5 2020

hein committed R1034:39c3b94ff56f: VideoElement: Turn image invisible when playing video (authored by patrickelectric).
VideoElement: Turn image invisible when playing video
May 5 2020, 11:22 AM
hein committed R1034:6a2ab33e9535: FlightControls: Remove unnecessary background property (authored by patrickelectric).
FlightControls: Remove unnecessary background property
May 5 2020, 11:22 AM
hein committed R1034:037bf9b5e554: Create VideoElement to organize elements (authored by patrickelectric).
Create VideoElement to organize elements
May 5 2020, 11:22 AM

Mar 10 2020

hein committed R1034:6871b121525e: main: Use nullptr inside C++ code (authored by patrickelectric).
main: Use nullptr inside C++ code
Mar 10 2020, 1:37 AM

Mar 5 2020

hein committed R1034:b566c9f7afc1: FlightControls: Remove GstVideoItem (authored by patrickelectric).
FlightControls: Remove GstVideoItem
Mar 5 2020, 7:09 PM
hein committed R1034:36f85abd0cac: gstreamer: Add widget in VideoSurface QQuickItem (authored by patrickelectric).
gstreamer: Add widget in VideoSurface QQuickItem
Mar 5 2020, 7:09 PM
hein committed R1034:b3cd2fe3ca92: gstreamer: Include resources in CMakeLists (authored by patrickelectric).
gstreamer: Include resources in CMakeLists
Mar 5 2020, 7:09 PM
hein committed R1034:d320d4c92da3: gstreamer: Add GstVideo and resources file (authored by patrickelectric).
gstreamer: Add GstVideo and resources file
Mar 5 2020, 7:09 PM

Mar 4 2020

hein committed R1034:9977fc293c4a: CMakeLists: Add CLANG_TIDY option (authored by patrickelectric).
CMakeLists: Add CLANG_TIDY option
Mar 4 2020, 12:06 PM

Mar 3 2020

hein committed R1034:6a7515367987: FlightControls: Fix virtual joystick after gamepad is connected and removed (authored by patrickelectric).
FlightControls: Fix virtual joystick after gamepad is connected and removed
Mar 3 2020, 10:16 PM
hein committed R1034:fe714028946e: Const ref (authored by tcanabrava).
Const ref
Mar 3 2020, 6:03 PM
hein committed R1034:2984989ec1be: No Need to call save() on settings anymore (authored by tcanabrava).
No Need to call save() on settings anymore
Mar 3 2020, 6:03 PM
hein committed R1034:ce32df93aed8: Connect the settings to the "AutoHandler" (authored by tcanabrava).
Connect the settings to the "AutoHandler"
Mar 3 2020, 6:03 PM
hein committed R1034:cbda42c1cd78: Tell KConfig to generate Notify signals (authored by tcanabrava).
Tell KConfig to generate Notify signals
Mar 3 2020, 6:03 PM
hein committed R1034:b7754994494f: New Class: AutoSettingsHandler (authored by tcanabrava).
New Class: AutoSettingsHandler
Mar 3 2020, 6:03 PM
hein committed R1034:59181dcd0902: Remove the binding loop in the settings (authored by tcanabrava).
Remove the binding loop in the settings
Mar 3 2020, 6:03 PM
hein committed R1034:aaa49fc4546f: Fix English (authored by tcanabrava).
Fix English
Mar 3 2020, 6:03 PM
hein committed R1034:ad74df6c0e32: vehiclesupportpluginmodel: Use clang-format (authored by patrickelectric).
vehiclesupportpluginmodel: Use clang-format
Mar 3 2020, 5:49 PM
hein committed R1034:16cfc613b846: videosurface: Use clang-format (authored by patrickelectric).
videosurface: Use clang-format
Mar 3 2020, 5:49 PM
hein committed R1034:e3770fa00d83: videosurface: Use clang-format (authored by patrickelectric).
videosurface: Use clang-format
Mar 3 2020, 5:49 PM
hein committed R1034:c9c98434c23f: gstreamerintegration: Use clang-format (authored by patrickelectric).
gstreamerintegration: Use clang-format
Mar 3 2020, 5:49 PM
hein committed R1034:2cbf9b8df46c: gstreamerintegration: Use clang-format (authored by patrickelectric).
gstreamerintegration: Use clang-format
Mar 3 2020, 5:49 PM
hein added a member for Plasma: Workspaces: hein.
Mar 3 2020, 4:38 PM
hein removed a member for Plasma: Workspaces: hein.
Mar 3 2020, 4:37 PM
hein removed a member for KActivities: hein.
Mar 3 2020, 4:37 PM
hein removed a watcher for Goal settings 2017: hein.
Mar 3 2020, 4:36 PM
hein removed a watcher for Konversation: hein.
Mar 3 2020, 4:36 PM
hein removed a watcher for Plasma on Wayland: hein.
Mar 3 2020, 4:36 PM
hein removed a watcher for Kirigami: hein.
Mar 3 2020, 4:36 PM
hein committed R1034:dc685762245f: Coding style fixes (authored by hein).
Coding style fixes
Mar 3 2020, 12:46 PM

Feb 27 2020

hein accepted D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled.

Good stuff.

Feb 27 2020, 7:45 PM · Plasma
hein committed R1035:57cc96c7d21a: Merge branch 'master' into 'master' (authored by hein).
Merge branch 'master' into 'master'
Feb 27 2020, 7:45 PM

Feb 25 2020

hein committed R1034:fd30584e0545: gstreamerintegration: Add debug messages (authored by patrickelectric).
gstreamerintegration: Add debug messages
Feb 25 2020, 6:12 PM
hein committed R1034:4be2bd9ad983: gstreamer integration: Fix typo (authored by patrickelectric).
gstreamer integration: Fix typo
Feb 25 2020, 6:12 PM

Feb 21 2020

hein committed R1035:e5e880249fc7: Merge branch 'kirogi_png' into 'master' (authored by hein).
Merge branch 'kirogi_png' into 'master'
Feb 21 2020, 7:10 PM
hein committed R1035:149bd88665ba: Merge branch 'goose_png' into 'master' (authored by hein).
Merge branch 'goose_png' into 'master'
Feb 21 2020, 7:10 PM

Feb 7 2020

hein added a comment to D27182: [applets/taskmanager] Clean up Tooltip code.

trmdi's point is good, otherwise I like it.

Feb 7 2020, 6:03 PM · Plasma

Feb 2 2020

hein accepted D26514: Delay popup when dropping things into containments .
Feb 2 2020, 12:33 PM · Plasma

Jan 24 2020

hein accepted D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources.

Thanks :)

Jan 24 2020, 9:36 PM · Plasma
hein accepted D22005: Ensure url from KActivity resources are properly built.
Jan 24 2020, 9:00 PM · Plasma
hein accepted D24728: Ensure url from KActivity resources are properly built.
Jan 24 2020, 8:59 PM · Plasma
hein added a comment to D26564: Clean kbuildsycoca4 support.

Let's wait until branching, there's still some KDE 4 apps people use.

Jan 24 2020, 8:59 PM · Frameworks
hein added a comment to D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources.

So does this fall through to the dialog when the type hasn't been determined?

Jan 24 2020, 8:57 PM · Plasma
hein added a comment to D25428: Improved support for desktop "Folder View".

Just a quick note I will review this tomorrow or next week when I'm on vacation, sorry for the long wait.

Jan 24 2020, 12:28 AM · Plasma

Jan 21 2020

hein added a comment to D26580: Kicker/RecentDocuments display place's icon when resource matches one.

This patch is fine and in line with the existing implementation, but it occurs to me we probably should make the RecentUsageModel use FileEntry and put it centrally there at some point.

Jan 21 2020, 2:57 PM · Plasma
hein accepted D26580: Kicker/RecentDocuments display place's icon when resource matches one.
Jan 21 2020, 2:56 PM · Plasma

Jan 19 2020

hein committed R1034:8f10a4aef6df: Merge branch 'style' into 'master' (authored by hein).
Merge branch 'style' into 'master'
Jan 19 2020, 4:51 PM
hein committed R1034:bbbcb78e66e7: Update gstreamerintegration.cpp (authored by hein).
Update gstreamerintegration.cpp
Jan 19 2020, 4:50 PM
hein committed R1034:031b2a1a27e8: Merge branch 'video_tests' into 'master' (authored by hein).
Merge branch 'video_tests' into 'master'
Jan 19 2020, 4:49 PM

Jan 18 2020

hein committed R1034:3cafa675ff0a: Merge branch 'use_any_of' into 'master' (authored by hein).
Merge branch 'use_any_of' into 'master'
Jan 18 2020, 4:26 PM
hein committed R1034:51035de818ba: Merge branch 'add_unused' into 'master' (authored by hein).
Merge branch 'add_unused' into 'master'
Jan 18 2020, 4:26 PM
hein committed R1034:ecab6b426902: Merge branch 'remove_gcs' into 'master' (authored by hein).
Merge branch 'remove_gcs' into 'master'
Jan 18 2020, 4:26 PM
hein committed R1034:7991c4cc2e39: Merge branch 'fix_setController' into 'master' (authored by hein).
Merge branch 'fix_setController' into 'master'
Jan 18 2020, 4:25 PM

Jan 11 2020

hein accepted D25925: Mark applications that play audio, for all task icon sizes.
Jan 11 2020, 12:25 AM · Plasma

Jan 7 2020

hein accepted D26386: Kicker/RecentDocuments: add icons to actions.

Good stuff!

Jan 7 2020, 11:21 PM · Plasma
hein accepted D26482: [Folder view] Don't create a rubberband when dragging during a rename.
Jan 7 2020, 11:20 PM · Plasma

Jan 6 2020

hein added a comment to T12488: Use a different repo for the new version of the Breeze widget style and come up with a name for it.

The VDG channel somehow ended up liking "Yoto" a lot!

Jan 6 2020, 6:01 PM · VDG, Plasma, Breeze
hein added a comment to T12488: Use a different repo for the new version of the Breeze widget style and come up with a name for it.

"Blast"

Jan 6 2020, 5:26 PM · VDG, Plasma, Breeze
hein added a comment to D25925: Mark applications that play audio, for all task icon sizes.

That's good with me, the rest of the patch is good and much appreciated.

Jan 6 2020, 5:23 PM · Plasma
hein added a comment to D25925: Mark applications that play audio, for all task icon sizes.

Maybe there's a third option: Another precedent we already have is the circular carve-out we use for the notification number badge. Perhaps we could reuse that for the indicator.

Jan 6 2020, 3:57 PM · Plasma
hein added a comment to D25925: Mark applications that play audio, for all task icon sizes.

I'm still not a big fan of the Glow for a number of reasons:

Jan 6 2020, 3:44 PM · Plasma

Jan 5 2020

hein added a comment to T11915: Commission new official version of the KDE logo with the word "KDE" next to it or below it.

Thanks everyone!

Jan 5 2020, 8:41 PM · VDG, KDE Promo

Jan 4 2020

hein accepted D26086: Don't fetch pixmap if we have it already.
Jan 4 2020, 11:06 PM · Plasma
hein accepted D26378: [Download Plugin] Register downloaded files as recent documents.

I love it.

Jan 4 2020, 6:15 PM · Plasma
hein added a comment to T11915: Commission new official version of the KDE logo with the word "KDE" next to it or below it.

Since we have consensus, let's expand the clipart page? :)

Jan 4 2020, 1:33 PM · VDG, KDE Promo
hein accepted D26409: [kicker] Use arrow functions in signal handlers.
Jan 4 2020, 8:30 AM · Plasma
hein added a comment to T12192: Redesign application launcher.

@chwmpfling Definitely the plan! Will appreciate your review

Jan 4 2020, 8:25 AM · Plasma, VDG
hein accepted D26406: [kicker] Fix some unqualified root property access.
Jan 4 2020, 12:27 AM · Plasma

Jan 3 2020

hein added a comment to D26385: Kicker/RecentDocuments Avoid referring to hidden places.

We can revisit it after some more discussion.

Jan 3 2020, 7:30 PM · Plasma
hein requested changes to D26385: Kicker/RecentDocuments Avoid referring to hidden places.
Jan 3 2020, 7:09 PM · Plasma
hein reopened D26385: Kicker/RecentDocuments Avoid referring to hidden places.
Jan 3 2020, 7:09 PM · Plasma
hein added a comment to D26385: Kicker/RecentDocuments Avoid referring to hidden places.

I don't agree with this patch. Hiding a place or section from the Places panel doesn't mean the user didn't add it and it's not to be used. We don't hide it from Folder View's config or relative title generator either. Hidden is not removed. Please revert.

Jan 3 2020, 7:09 PM · Plasma
hein requested changes to D26386: Kicker/RecentDocuments: add icons to actions.

It should be iconName after label.

Jan 3 2020, 7:01 PM · Plasma
hein committed R1034:279b4b017ea0: Merge branch 'parameter_model' into 'master' (authored by hein).
Merge branch 'parameter_model' into 'master'
Jan 3 2020, 1:00 PM

Jan 2 2020

hein accepted D26147: Kickoff computer tab : don't display filepath for places in description.
Jan 2 2020, 6:16 PM · Plasma

Dec 28 2019

baberts awarded T12192: Redesign application launcher a Love token.
Dec 28 2019, 11:22 PM · Plasma, VDG
hein added a comment to D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default.

It's definitely a discussion I'd enjoy more :)

Dec 28 2019, 5:55 AM · Plasma
hein accepted D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default.

Ah sorry, I had a reply typed into the text field but must have botched hitting Submit.

Dec 28 2019, 3:01 AM · Plasma
hein accepted D25762: Only serialize window pixmap if we're using it.

Nice :)

Dec 28 2019, 2:57 AM · Plasma
hein added a comment to T12192: Redesign application launcher.

Should it be possible to configure the icon size for grid view?

Dec 28 2019, 1:05 AM · Plasma, VDG

Dec 26 2019

hein committed R1034:6092b67bd747: Merge branch 'position_source' into 'master' (authored by hein).
Merge branch 'position_source' into 'master'
Dec 26 2019, 10:21 PM
hein added a comment to T12192: Redesign application launcher.

This is also possible in all of the other menus based on the backend, so that's sensible, yeah.

Dec 26 2019, 9:08 PM · Plasma, VDG
hein committed R1034:8aa804e71cce: Update CMakeLists.txt (authored by hein).
Update CMakeLists.txt
Dec 26 2019, 7:25 PM

Dec 24 2019

hein committed R1034:9ff33b7fa6ca: Merge branch 'set_taw' into 'master' (authored by hein).
Merge branch 'set_taw' into 'master'
Dec 24 2019, 2:58 AM
hein committed R1034:47a4d966bd53: Merge branch 'fix_pitch' into 'master' (authored by hein).
Merge branch 'fix_pitch' into 'master'
Dec 24 2019, 2:57 AM

Dec 23 2019

alexde awarded T12192: Redesign application launcher a Love token.
Dec 23 2019, 5:31 PM · Plasma, VDG
hein committed R1034:31417b502297: Merge branch 'pragma_once' into 'master' (authored by hein).
Merge branch 'pragma_once' into 'master'
Dec 23 2019, 4:42 PM
hein committed R1034:ad8102a749f3: Merge branch 'fix_pitchbar' into 'master' (authored by hein).
Merge branch 'fix_pitchbar' into 'master'
Dec 23 2019, 4:41 PM
hein committed R1035:991ff330b230: Update faq.md (authored by hein).
Update faq.md
Dec 23 2019, 4:41 PM
hein committed R1034:fa0ef70dee98: Update README.md (authored by hein).
Update README.md
Dec 23 2019, 4:39 PM
hein committed R1035:dd9c187d6308: Update faq.md (authored by hein).
Update faq.md
Dec 23 2019, 4:39 PM
hein committed R1035:4371d96f98ae: Update index.html (authored by hein).
Update index.html
Dec 23 2019, 4:37 PM
hein committed R1035:c8fd71f4a5d1: Update faq.md (authored by hein).
Update faq.md
Dec 23 2019, 4:36 PM
hein committed R1035:d2854d582274: Update index.html (authored by hein).
Update index.html
Dec 23 2019, 4:35 PM
hein committed R1034:1f4bef254bc6: Tune the language (authored by hein).
Tune the language
Dec 23 2019, 4:33 PM