hein (Eike Hein)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:07 PM (170 w, 1 d)
Availability
Available

Recent Activity

Tue, Jul 17

hein added a comment to D12820: Add KWayland virtual desktop protocol.

I have a problem: When I restart plasmashell, I don't get any desktops again. I think the code may not be re-sending the data when the client goes away and comes a second time.

Tue, Jul 17, 1:13 PM · Frameworks
hein accepted D14174: Fix blur behind folderview context menus.

We have blurred context menus now? Wtf.

Tue, Jul 17, 5:07 AM · Plasma

Mon, Jul 16

hein accepted D14026: [Pager] Don't show a window list on hover if there is only one window.

Sorry, was traveling.

Mon, Jul 16, 3:09 AM · Plasma

Thu, Jul 12

hein accepted D14079: [Folder View] Create rename editor on demand.
Thu, Jul 12, 12:47 PM · Plasma
hein accepted D14077: [Folder View] Don't spawn multiple stat jobs for the same folder.
Thu, Jul 12, 12:35 PM · Plasma

Wed, Jul 11

hein accepted D14055: [Kickoff] Remove unused Footer.qml.
Wed, Jul 11, 5:30 PM · Plasma
hein added a comment to D14042: Support special URLs for finding files of a certain type.

Does it make sense to name the queries after XDG_USER_DIRS, so e.g. pictures instead of images?

Wed, Jul 11, 4:09 PM · Baloo, Frameworks
hein accepted D14043: [KFilePlacesModel] Support pretty baloosearch URLs.
Wed, Jul 11, 4:07 PM · Frameworks

Tue, Jul 10

hein accepted D14029: [Kicker] Use KFilePlaces::convertedUrl for ComputerModel.

In the meantime this is a necessary bugfix though.

Tue, Jul 10, 8:42 PM · Plasma
hein added a comment to D14029: [Kicker] Use KFilePlaces::convertedUrl for ComputerModel.

Yeah, I think this isn't very pretty unfortunately. Does KIO have a way to give a human-readable description of an URL or something?

Tue, Jul 10, 8:40 PM · Plasma
hein accepted D14030: [Kickoff] Use KFilePlacesModel groups.
Tue, Jul 10, 8:39 PM · Plasma
hein accepted D13999: [Kicker System Entry] Remove KDisplayManager global static.
Tue, Jul 10, 8:31 PM · Plasma
hein updated the diff for D13745: Implement support for virtual desktops on Wayland.

Drop the population loop, it's as unnecessary as it should be.

Tue, Jul 10, 7:51 PM · Plasma

Fri, Jul 6

hein added a comment to D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support.

The change would have to be in the libtm patch. But the filter model hasn't changed, all I've done in the libtm patch is that initial population loop thing in VirtualDesktopInfo.

Fri, Jul 6, 8:34 PM · Plasma

Thu, Jul 5

hein updated the diff for D13746: Adjust Task Manager to libtaskmanager API changes for Wayland virtual desktop support.

Make "New Desktop" task context menu action work on Wayland.

Thu, Jul 5, 7:57 PM · Plasma
hein updated the diff for D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support.
  • Update message.
Thu, Jul 5, 7:56 PM · Plasma
hein updated the diff for D13745: Implement support for virtual desktops on Wayland.
  • Add AbstractTasksModel::requestNewVirtualDesktop and implement for Wayland and X11.
  • Remove VirtualDesktopInfo::canManageDesktops again as there's parity now.
Thu, Jul 5, 7:55 PM · Plasma
hein updated the diff for D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support.
  • Enable Add/Remove Desktop actions on Wayland using new libtm API.
Thu, Jul 5, 7:35 PM · Plasma
hein updated the diff for D13745: Implement support for virtual desktops on Wayland.

Add API for creating/removing desktops.

Thu, Jul 5, 7:33 PM · Plasma
hein updated the diff for D13745: Implement support for virtual desktops on Wayland.
  • Revert a bit flip that wasn't intended to be in there just yet.
Thu, Jul 5, 7:05 PM · Plasma
hein updated the diff for D13745: Implement support for virtual desktops on Wayland.
  • Adjust to Marco's API changes - builds again.
  • Add initial population loop to VirtualDesktopInfo on Marco's request.
Thu, Jul 5, 7:03 PM · Plasma

Wed, Jul 4

hein committed R119:7e129489f611: Merge branch 'Plasma/5.13' (authored by hein).
Merge branch 'Plasma/5.13'
Wed, Jul 4, 7:42 PM
hein committed R119:4ad27c62b5e7: Correct Folder View sizing and representation switch behavior (authored by hein).
Correct Folder View sizing and representation switch behavior
Wed, Jul 4, 7:42 PM
hein closed D13870: Correct Folder View sizing and representation switch behavior.
Wed, Jul 4, 7:42 PM · Plasma

Tue, Jul 3

hein added inline comments to D13745: Implement support for virtual desktops on Wayland.
Tue, Jul 3, 7:21 PM · Plasma
hein updated the diff for D13870: Correct Folder View sizing and representation switch behavior.

Add back useful comment.

Tue, Jul 3, 4:32 PM · Plasma
hein updated the diff for D13870: Correct Folder View sizing and representation switch behavior.
  • Add the missing switch stuff.
  • Remove stray debug.
Tue, Jul 3, 4:30 PM · Plasma
hein planned changes to D13870: Correct Folder View sizing and representation switch behavior.

Whoops, I accidentally uploaded the wrong diff, hang on.

Tue, Jul 3, 4:19 PM · Plasma
hein requested review of D13870: Correct Folder View sizing and representation switch behavior.
Tue, Jul 3, 4:12 PM · Plasma
hein added a comment to D13745: Implement support for virtual desktops on Wayland.

Can we discuss this somewhere else, e.g. on plasma-devel or in one of the Plasma monday meetings? This is a review thread for a libtaskmanager code patch.

Tue, Jul 3, 2:44 PM · Plasma
hein committed R119:8c40fffc07ae: Merge branch 'Plasma/5.13' (authored by hein).
Merge branch 'Plasma/5.13'
Tue, Jul 3, 2:25 PM
hein committed R119:b93a3e3638e0: Merge branch 'Plasma/5.12' into Plasma/5.13 (authored by hein).
Merge branch 'Plasma/5.12' into Plasma/5.13
Tue, Jul 3, 2:24 PM
hein committed R119:e1252c6e40ac: Fix crash on post-initial refresh() (authored by hein).
Fix crash on post-initial refresh()
Tue, Jul 3, 2:24 PM
hein closed D13856: Fix crash on post-initial refresh().
Tue, Jul 3, 2:24 PM · Plasma
hein accepted D13866: Fix ResultModel item moving.

It works for me.

Tue, Jul 3, 2:22 PM · Frameworks
hein updated the diff for D13856: Fix crash on post-initial refresh().

Drop the hack.

Tue, Jul 3, 2:21 PM · Plasma
hein added a comment to D13745: Implement support for virtual desktops on Wayland.

A lot of this is still up in the air, but here's the rough plan:

Tue, Jul 3, 2:09 PM · Plasma
hein added a reviewer for D13745: Implement support for virtual desktops on Wayland: mvourlakos.

Michail: Please follow this review, as these API changes might impact Latte Dock, too. :)

Tue, Jul 3, 1:35 PM · Plasma
hein committed R7:63acdfe89198: Adjust to Kirigami API changes to hide header bar again. (authored by hein).
Adjust to Kirigami API changes to hide header bar again.
Tue, Jul 3, 1:22 PM

Mon, Jul 2

hein added a comment to D13856: Fix crash on post-initial refresh().

FWIW: I'm not going to make changes to this revision until the KActivitiesStats bug is fixed, which as mentioned I don't have time to fix. So this revision is stuck for now (unless I go for maintainer authority, which the situation must show).

Mon, Jul 2, 9:22 PM · Plasma
hein requested review of D13856: Fix crash on post-initial refresh().
Mon, Jul 2, 6:40 PM · Plasma
hein requested changes to D10342: From 100% plasma cpu usage to normal when using vivaldi.

This patch doesn't make any sense. It's setting up a cache for something computed from data that's subject to change, and it's never evicting it when that data changes.

Mon, Jul 2, 10:21 AM · Plasma

Fri, Jun 29

hein updated the diff for D13745: Implement support for virtual desktops on Wayland.

Adjust to new semantics for IsOnAllDesktops.

Fri, Jun 29, 7:47 PM · Plasma

Thu, Jun 28

hein requested review of D13788: Use Pin/Unpin also for window tasks when there's only one activity.
Thu, Jun 28, 9:13 PM · Plasma
hein updated the diff for D13745: Implement support for virtual desktops on Wayland.
  • Make WaylandTasksModel::requestVirtualDesktops treat the passed-in list as exhaustive.
  • Fix how an empty list is treated.
Thu, Jun 28, 8:05 PM · Plasma

Wed, Jun 27

hein added a comment to D13745: Implement support for virtual desktops on Wayland.

FWIW: I want to continue with this for now because under the current usage it's still better for performance and lower risk, but longer-term I might refactor VirtualDesktopInfo and ActivityInfo into {AbstractWorkspaceModel,VirtualDesktopModel,ActivityModel} and replace PagerModel directly. It would make for a more consistent lib API and simplify applet code.

Wed, Jun 27, 6:25 PM · Plasma
hein committed R936:5ef04c9b02c9: Add v1.7.5. (authored by hein).
Add v1.7.5.
Wed, Jun 27, 3:15 AM

Tue, Jun 26

hein committed R7:96f5e74f9d66: Merge branch '1.7' (authored by hein).
Merge branch '1.7'
Tue, Jun 26, 10:34 PM
hein committed R7:406dca448ad6: Adjust for dev. (authored by hein).
Adjust for dev.
Tue, Jun 26, 10:34 PM
hein committed R7:5f4c44887de7: Adjust for release. (authored by hein).
Adjust for release.
Tue, Jun 26, 10:32 PM
hein planned changes to D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support.
Tue, Jun 26, 10:11 PM · Plasma
hein planned changes to D13746: Adjust Task Manager to libtaskmanager API changes for Wayland virtual desktop support.
Tue, Jun 26, 10:11 PM · Plasma
hein planned changes to D13745: Implement support for virtual desktops on Wayland.
Tue, Jun 26, 10:11 PM · Plasma
hein requested review of D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support.
Tue, Jun 26, 10:10 PM · Plasma
hein added a dependent revision for D13745: Implement support for virtual desktops on Wayland: D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support.
Tue, Jun 26, 10:10 PM · Plasma
hein updated the diff for D13746: Adjust Task Manager to libtaskmanager API changes for Wayland virtual desktop support.

Remove accidental CMakeLists.txt change.

Tue, Jun 26, 10:09 PM · Plasma
hein updated the diff for D13746: Adjust Task Manager to libtaskmanager API changes for Wayland virtual desktop support.

Unambigous revision title.

Tue, Jun 26, 10:08 PM · Plasma
hein requested review of D13746: Adjust Task Manager to libtaskmanager API changes for Wayland virtual desktop support.
Tue, Jun 26, 9:43 PM · Plasma
hein added a dependent revision for D13745: Implement support for virtual desktops on Wayland: D13746: Adjust Task Manager to libtaskmanager API changes for Wayland virtual desktop support.
Tue, Jun 26, 9:43 PM · Plasma
hein requested review of D13745: Implement support for virtual desktops on Wayland.
Tue, Jun 26, 9:30 PM · Plasma
hein added a dependent revision for D12820: Add KWayland virtual desktop protocol: D13745: Implement support for virtual desktops on Wayland.
Tue, Jun 26, 9:30 PM · Frameworks
hein added a comment to D13481: Recommend window border size "None".

This one is definitely tricky. I don't think it's insurmountable to track whether there's movement or not prior to a release, and if not, raise the lower window and synthesise press+release events to send to it. But it would't completely eliminate the dead zone problem, for example it wouldn't fix the case I wrote about above: In that case I expected the usual raise on press to happen and then be able to immediately move the scrollbar thumb. The best we could do with the distinguishing trick is to enable click-raise, which is still inconsistent behavior.

Tue, Jun 26, 10:01 AM · Plasma

Mon, Jun 25

hein added a comment to D13481: Recommend window border size "None".

Here's a realistic scenario for the "Dead Zone Problem":

Mon, Jun 25, 9:08 PM · Plasma
hein added a comment to D13415: Reshape Kickoff avatar to a circle with Opacity Mask.

Can you have a look at the code in kdeclarative, specifically src/qmlcontrols/kcoreaddons/kuserproxy.cpp - that's where the KDirWatch monitoring the face.icon file is. I think you need to place some qDebug() there to see if the file change gets picked up on your system and the signal emitted. If this is working, then we know the problem has to be in the QML side.

Mon, Jun 25, 7:44 PM · Plasma
hein added a comment to D13415: Reshape Kickoff avatar to a circle with Opacity Mask.

Can you elaborate what you tried and what you wanted to happen and what didn't happen? I'm a bit confused now @ touch.

Mon, Jun 25, 7:08 PM · Plasma

Fri, Jun 22

hein committed R119:cead25ad8345: Merge branch 'Plasma/5.13' (authored by hein).
Merge branch 'Plasma/5.13'
Fri, Jun 22, 9:09 PM
hein committed R119:8e57b27e1ed9: Merge branch 'Plasma/5.12' into Plasma/5.13 (authored by hein).
Merge branch 'Plasma/5.12' into Plasma/5.13
Fri, Jun 22, 9:08 PM
hein committed R119:1e218b405bee: Fix tooltip woes (authored by hein).
Fix tooltip woes
Fri, Jun 22, 9:08 PM
hein closed D13602: Fix tooltip woes.
Fri, Jun 22, 9:08 PM · Plasma
hein requested review of D13602: Fix tooltip woes.
Fri, Jun 22, 7:03 PM · Plasma

Wed, Jun 20

hein added a comment to D13415: Reshape Kickoff avatar to a circle with Opacity Mask.

You can run touch $HOME/.face.icon to make the system believe the file changed, then it goes through KDirWatch etc.

Wed, Jun 20, 8:09 PM · Plasma
hein added a comment to D13415: Reshape Kickoff avatar to a circle with Opacity Mask.

I had a look at this today, and I wasn't able to reproduce the problem so far.

Wed, Jun 20, 7:58 PM · Plasma
hein updated the diff for D13602: Fix tooltip woes.

Fix crash on Qt <5.11

Wed, Jun 20, 7:30 PM · Plasma
hein reopened D13602: Fix tooltip woes.
Wed, Jun 20, 7:30 PM · Plasma
hein added a comment to D13625: Add 'Documentation' category to the Application menus.

I can see Marco's point, so I can't be the tie-breaker. Other opinions?

Wed, Jun 20, 4:16 PM · Plasma

Jun 19 2018

hein committed R119:3257c8b2da58: Merge branch 'Plasma/5.13' (authored by hein).
Merge branch 'Plasma/5.13'
Jun 19 2018, 11:25 AM
hein committed R119:99db6b33cdc0: Merge branch 'Plasma/5.12' into Plasma/5.13 (authored by hein).
Merge branch 'Plasma/5.12' into Plasma/5.13
Jun 19 2018, 11:24 AM
hein committed R119:24803dc9dc40: Fix tooltip woes (authored by hein).
Fix tooltip woes
Jun 19 2018, 11:23 AM
hein closed D13602: Fix tooltip woes.
Jun 19 2018, 11:23 AM · Plasma
hein added a comment to D13602: Fix tooltip woes.

race condition

a race between what?

Jun 19 2018, 11:11 AM · Plasma
hein requested review of D13602: Fix tooltip woes.
Jun 19 2018, 11:07 AM · Plasma

Jun 18 2018

hein committed R119:ffc6c04fe051: Merge branch 'Plasma/5.13' (authored by hein).
Merge branch 'Plasma/5.13'
Jun 18 2018, 11:06 AM
hein committed R119:cfe05561b1e5: Merge branch 'Plasma/5.12' into Plasma/5.13 (authored by hein).
Merge branch 'Plasma/5.12' into Plasma/5.13
Jun 18 2018, 11:05 AM
hein committed R119:adbc35b0d82d: Fix accident. (authored by hein).
Fix accident.
Jun 18 2018, 11:03 AM

Jun 15 2018

hein added a comment to D13529: [minimizeAll] Do not try to restore window state on model change.

Looks OK to me, but want @davidedmundson to review.

Jun 15 2018, 8:51 AM · Plasma

Jun 14 2018

hein accepted D13433: Introduce ActionToolbar.
Jun 14 2018, 10:10 AM · Kirigami

Jun 13 2018

hein committed R119:de78bcc411f3: Merge branch 'Plasma/5.13' (authored by hein).
Merge branch 'Plasma/5.13'
Jun 13 2018, 10:56 AM
hein committed R119:b8c8ba51ffc7: Merge branch 'Plasma/5.12' into Plasma/5.13 (authored by hein).
Merge branch 'Plasma/5.12' into Plasma/5.13
Jun 13 2018, 10:51 AM
hein committed R119:6f3a486330d0: Swap Trash for Delete action when only one is enabled and the Shift modifier is… (authored by hein).
Swap Trash for Delete action when only one is enabled and the Shift modifier is…
Jun 13 2018, 10:50 AM
hein closed D13508: Swap Trash for Delete action when only one is enabled and the Shift modifier is pressed.
Jun 13 2018, 10:50 AM · Plasma
hein requested review of D13508: Swap Trash for Delete action when only one is enabled and the Shift modifier is pressed.
Jun 13 2018, 7:40 AM · Plasma

Jun 12 2018

hein committed R119:59d0458bd09e: Use the new drag handle in the Language KCM (authored by hein).
Use the new drag handle in the Language KCM
Jun 12 2018, 9:53 AM
hein closed D13194: Use the new drag handle in the Language KCM.
Jun 12 2018, 9:53 AM · Plasma

Jun 11 2018

hein committed R917:cbaed1d30e2c: Better photo. (authored by hein).
Better photo.
Jun 11 2018, 7:08 AM

Jun 8 2018

hein added a comment to D13194: Use the new drag handle in the Language KCM.

The other two are currently still needed:

Jun 8 2018, 12:43 AM · Plasma
hein updated the diff for D13194: Use the new drag handle in the Language KCM.

Remove width from RowLayout.

Jun 8 2018, 12:39 AM · Plasma
hein added inline comments to D13194: Use the new drag handle in the Language KCM.
Jun 8 2018, 12:00 AM · Plasma

Jun 6 2018

hein added a comment to M112: System Settings Alpha Graphic Redesign.

Andy Betts, [07.06.18 06:20]
and yes, I was asking if you could help me track those KCMs where we introduced changes to the mockups

Andy Betts, [07.06.18 06:20]
Hopefully it is not a huge list?

Eike Hein, [07.06.18 06:21]
I'm not sure. I'd suggest going over the Phabricator KCM reviews (the ones I can think of right now: Language, Icons, Launch Feedback, Colors, Widget Styles, Cursors, etc. - maybe more). In terms of components, we have a new "Grid" style KCM and a new "List" style KCM and we figured out how we want to do draggable lists and we made FormLayout with its various abilities (reflow, clickable sections, etc.)

Eike Hein, [07.06.18 06:22]
So now it's about "If I had to do the design with these components, I would ..."

Eike Hein, [07.06.18 06:22]
So for example take the Keyboard KCM, which is now going to reuse the new "Draggable list" component/pattern we made for the Language KCM together - in the mockups, the Keyboard KCM is actually just blank, the mockup has no content

Eike Hein, [07.06.18 06:22]
There's probabl other cases where we didn't know the answer at the time, where we have a more solid idea now

Eike Hein, [07.06.18 06:24]
The process has been: Make initial mockups -> Consolidate ideas and come up with reusable components for consistency between KCMs and now it needs to continue with -> update mockups to reflect new components

Eike Hein, [07.06.18 06:25]
And this cycle will probably continue as we identify the need for new components, make them, ...

Eike Hein, [07.06.18 06:26]
Maybe @kbroulik also has an opinion here since he was one of the people who expressed frustration with aging mockups

Andy Betts, [07.06.18 06:30]
Oh this is good information

Andy Betts, [07.06.18 06:30]
Can you copy this into the ticket?

Andy Betts, [07.06.18 06:31]
Just so I can review after work?

Andy Betts, [07.06.18 06:31]
Please? :D

Jun 6 2018, 9:33 PM · KDE Developers, VDG

Jun 5 2018

hein committed R242:e108d7e90e36: Teach ContainmentInterface::processMimeData how to handle Task Manager drops (authored by hein).
Teach ContainmentInterface::processMimeData how to handle Task Manager drops
Jun 5 2018, 11:15 PM
hein closed D13275: Teach ContainmentInterface::processMimeData how to handle Task Manager drops.
Jun 5 2018, 11:15 PM · Frameworks