chinmoyr (Chinmoy Ranjan Pradhan)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jun 20 2016, 6:48 AM (83 w, 7 h)
Availability
Available

Recent Activity

Wed, Jan 17

chinmoyr added a comment to D9836: Use BatchRenameJob to rename multiple files in Dolphin.

ping. anyone from dolphin?

Wed, Jan 17, 1:36 AM

Sun, Jan 14

chinmoyr committed R241:5a1ea84476e6: Temporarily disable KAuth support in KIO (authored by chinmoyr).
Temporarily disable KAuth support in KIO
Sun, Jan 14, 3:39 AM

Sat, Jan 13

chinmoyr committed R241:3fc0dfdf33f3: Don't use privilege execution in unit test for DropJob (authored by chinmoyr).
Don't use privilege execution in unit test for DropJob
Sat, Jan 13, 3:12 AM

Fri, Jan 12

chinmoyr added inline comments to D9836: Use BatchRenameJob to rename multiple files in Dolphin.
Fri, Jan 12, 5:15 PM
chinmoyr updated the diff for D9836: Use BatchRenameJob to rename multiple files in Dolphin.
  1. Used urlList() method
  2. Set QUrl::StripTrailingSlash
  3. Used KIO::Job::result signal
Fri, Jan 12, 5:11 PM
chinmoyr committed R241:774b303c9680: [DropJob] Enable drag and drop in a read-only folder (authored by chinmoyr).
[DropJob] Enable drag and drop in a read-only folder
Fri, Jan 12, 12:31 PM
chinmoyr closed D7272: [DropJob] Enable drag and drop in a read-only folder.
Fri, Jan 12, 12:31 PM · Frameworks
chinmoyr committed R241:ac9f30b4a334: [FileUndoManager] Enable undoing changes in read-only folders (authored by chinmoyr).
[FileUndoManager] Enable undoing changes in read-only folders
Fri, Jan 12, 12:28 PM
chinmoyr closed D7270: [FileUndoManager] Enable undoing changes in read-only folders.
Fri, Jan 12, 12:28 PM · Frameworks
chinmoyr updated the diff for D7270: [FileUndoManager] Enable undoing changes in read-only folders.

Summary update

Fri, Jan 12, 12:26 PM · Frameworks
chinmoyr committed R241:ac51e5769c84: Add unit tests for privilege excution in KIO (authored by chinmoyr).
Add unit tests for privilege excution in KIO
Fri, Jan 12, 12:16 PM
chinmoyr closed D7430: Add unit tests for privilege excution in KIO.
Fri, Jan 12, 12:16 PM · Frameworks
chinmoyr committed R241:7ccf3cda121f: Add support for privilege execution in KIO jobs (authored by chinmoyr).
Add support for privilege execution in KIO jobs
Fri, Jan 12, 12:07 PM
chinmoyr closed D6833: Add support for privilege execution in KIO jobs.
Fri, Jan 12, 12:07 PM · Frameworks
chinmoyr updated the diff for D6833: Add support for privilege execution in KIO jobs.

Title and summary update

Fri, Jan 12, 12:06 PM · Frameworks
chinmoyr committed R241:596ef4ccf1d7: Integrate new file ioslave in KIO job (authored by chinmoyr).
Integrate new file ioslave in KIO job
Fri, Jan 12, 12:00 PM
chinmoyr closed D6832: Integrate new file ioslave in KIO job.
Fri, Jan 12, 12:00 PM · Frameworks
chinmoyr updated the diff for D6832: Integrate new file ioslave in KIO job.

Summary update
Fixed windows build

Fri, Jan 12, 12:00 PM · Frameworks
chinmoyr closed D6830: Make use of kauth helper in copy method of file ioslave.

commit: https://phabricator.kde.org/R241:13ab6a85bbb8502fe47935f92f466e0223baa2ac

Fri, Jan 12, 11:23 AM · Frameworks
chinmoyr committed R241:13ab6a85bbb8: Use kauth helper in member functions of FileProtocol (authored by chinmoyr).
Use kauth helper in member functions of FileProtocol
Fri, Jan 12, 11:18 AM
chinmoyr closed D6831: Make use of kauth helper in methods of file ioslave.
Fri, Jan 12, 11:18 AM · Frameworks
chinmoyr updated the diff for D6831: Make use of kauth helper in methods of file ioslave.

1.Merge code from D6830
2.Fix FreeBSD (CI) build

Fri, Jan 12, 11:17 AM · Frameworks
chinmoyr committed R241:eebc78918817: Use kauth helper in file ioslave (authored by chinmoyr).
Use kauth helper in file ioslave
Fri, Jan 12, 10:59 AM
chinmoyr closed D6829: Add ability to use the new kauth helper in file ioslave.
Fri, Jan 12, 10:59 AM · Frameworks
chinmoyr committed R241:17bf6df0d8ba: Add kauth helper to file ioslave (authored by chinmoyr).
Add kauth helper to file ioslave
Fri, Jan 12, 10:47 AM
chinmoyr closed D6197: Add kauth helper to file ioslave.
Fri, Jan 12, 10:47 AM · Frameworks
chinmoyr committed R241:bbf45d2cd550: Add support for sharing file descriptor between file KIO slave and it's KAuth… (authored by chinmoyr).
Add support for sharing file descriptor between file KIO slave and it's KAuth…
Fri, Jan 12, 10:28 AM
chinmoyr closed D6709: Add support for sharing file descriptor between KIO slave and KAuth helper.
Fri, Jan 12, 10:28 AM · Frameworks
chinmoyr updated the diff for D6709: Add support for sharing file descriptor between KIO slave and KAuth helper.

Summary update

Fri, Jan 12, 10:27 AM · Frameworks

Thu, Jan 11

chinmoyr added a comment to D6830: Make use of kauth helper in copy method of file ioslave.

Doesn't execWithElevatedPrivilege call ERR_USER_CANCELED on cancel?

Thu, Jan 11, 4:16 PM · Frameworks

Mon, Jan 8

chinmoyr added a comment to D6830: Make use of kauth helper in copy method of file ioslave.

ping

Mon, Jan 8, 11:09 AM · Frameworks
chinmoyr added a comment to D6832: Integrate new file ioslave in KIO job.

ping

Mon, Jan 8, 11:09 AM · Frameworks
chinmoyr added a comment to D7272: [DropJob] Enable drag and drop in a read-only folder.

ping

Mon, Jan 8, 11:08 AM · Frameworks

Wed, Jan 3

chinmoyr added a comment to D6831: Make use of kauth helper in methods of file ioslave.

@dhaumann The helper is called only when the error is EACCES or EPERM. So, if you are already root then this won't be the case and file ioslave will work as usual.

Wed, Jan 3, 7:25 AM · Frameworks

Tue, Jan 2

chinmoyr updated the diff for D7430: Add unit tests for privilege excution in KIO.

1.Removed all macros
2.Removed PrivilegeExecution flag.

Tue, Jan 2, 4:32 PM · Frameworks
chinmoyr updated the diff for D7272: [DropJob] Enable drag and drop in a read-only folder.

1.Replaced PrivilegeExecution flag
2.Made variable m_flags const again

Tue, Jan 2, 3:54 PM · Frameworks
chinmoyr updated the diff for D7270: [FileUndoManager] Enable undoing changes in read-only folders.

1.Removed PrivilegeExecution flag

Tue, Jan 2, 3:50 PM · Frameworks
chinmoyr updated the diff for D6833: Add support for privilege execution in KIO jobs.

1.Made privilege execution default in BatchRenameJob.
2.Removed all occurences of PrivilegeExecution as job argument.

Tue, Jan 2, 3:43 PM · Frameworks
chinmoyr updated the diff for D6832: Integrate new file ioslave in KIO job.

1.Reassigned flag values for NoPrivilegeExecution and PrivilegeExecution. I strongly feel that the latter won't be needed anymore.
2.Setting meta-data for unit test in the job itself (in tryAskPrivilegeOpConfirmation).
3.Changed some comments due to changing flags .

Tue, Jan 2, 3:36 PM · Frameworks
chinmoyr updated the diff for D6832: Integrate new file ioslave in KIO job.
Tue, Jan 2, 3:35 PM · Frameworks
chinmoyr updated the diff for D6831: Make use of kauth helper in methods of file ioslave.

1.Added check for unit test mode at beginning of put.
2.put was setting the wrong permissions because I initialized 'filemode' to 0 and did't update it. Now it is fixed.
3.Replaced file.setPermissions with Qfile::setPermissions and used tryChangeFileAttr in put.
4.Moved 'finished()' in chmod out of the else block.

Tue, Jan 2, 12:56 PM · Frameworks
chinmoyr updated the diff for D6830: Make use of kauth helper in copy method of file ioslave.

Changes:

  1. Added method tryChangeAttr. This will call chown/chmod/utime in copy with elevated privileges only during the brief period authorization is kept.

2.Added check for unit test mode at beginning of copy. "copy" calls execWihElevatedPrivileges number of times but for unit test once is enough.
3.Replaced dest_file.setPermissions(...) with the static version. This will ensure that the error code set when using file decriptor is either EACCES or EPERM.

Tue, Jan 2, 12:19 PM · Frameworks
chinmoyr updated the diff for D6829: Add ability to use the new kauth helper in file ioslave.

1.Added method privilegeOperationUnitTestMode. This replaces the previous block of code which
tested the validity of the KAuth action by looking up the action in *.policy file. I think instead of looking
for some external files its better to test if the job has the flag for privilege operation set and has a
parent job as well (in case of subjob). The method requestPrivilegeOperation is there for this exact purpose.
So for the purpose of unit test checking return value of requestPrivilegeOperation should be
sufficient.

Tue, Jan 2, 11:52 AM · Frameworks
chinmoyr updated the diff for D6709: Add support for sharing file descriptor between KIO slave and KAuth helper.

Fixed compilation issue on FreeBSD.
Apparently I was passing a pointer to array in strcpy.

Tue, Jan 2, 11:20 AM · Frameworks

Dec 3 2017

chinmoyr committed R241:befcbbd4e36b: Add undo support to BatchRenameJob (authored by chinmoyr).
Add undo support to BatchRenameJob
Dec 3 2017, 2:04 PM
chinmoyr closed D9107: Add undo support to BatchRenameJob.
Dec 3 2017, 2:04 PM · Frameworks
chinmoyr committed R241:12bf704476c6: Add BatchRenameJob to KIO (authored by chinmoyr).
Add BatchRenameJob to KIO
Dec 3 2017, 1:57 PM
chinmoyr closed D9103: Add BatchRenameJob to KIO.
Dec 3 2017, 1:57 PM · Frameworks

Dec 2 2017

chinmoyr updated the diff for D9103: Add BatchRenameJob to KIO.

removed exception for ERR_FILE_ALREADY_EXISTS.

Dec 2 2017, 6:43 PM · Frameworks
chinmoyr added inline comments to D9103: Add BatchRenameJob to KIO.
Dec 2 2017, 6:04 PM · Frameworks
chinmoyr updated the diff for D9103: Add BatchRenameJob to KIO.

changed 'first' to 'pos'.
added one more example to the doc.

Dec 2 2017, 5:54 PM · Frameworks
chinmoyr updated the diff for D9107: Add undo support to BatchRenameJob.

minor changes

Dec 2 2017, 4:43 PM · Frameworks
chinmoyr added inline comments to D9103: Add BatchRenameJob to KIO.
Dec 2 2017, 4:30 PM · Frameworks
chinmoyr updated the diff for D9103: Add BatchRenameJob to KIO.

Hopefully I haven't missed any more of your comments.

Dec 2 2017, 4:29 PM · Frameworks
chinmoyr updated the diff for D9103: Add BatchRenameJob to KIO.

Made the required changes

Dec 2 2017, 2:54 PM · Frameworks
chinmoyr created D9107: Add undo support to BatchRenameJob.
Dec 2 2017, 2:18 PM · Frameworks
chinmoyr added a dependent revision for D9103: Add BatchRenameJob to KIO: D9107: Add undo support to BatchRenameJob.
Dec 2 2017, 2:18 PM · Frameworks
chinmoyr updated the diff for D9103: Add BatchRenameJob to KIO.

Emit both old and new url in fileRenamed. It will be useful when undoing.

Dec 2 2017, 1:37 PM · Frameworks
chinmoyr added a comment to D9103: Add BatchRenameJob to KIO.
In D9103#174381, @apol wrote:

Wouldn't it be easier to have this job in Dolphin? Or it needs to be in kio to access private API?

Dec 2 2017, 1:26 PM · Frameworks
chinmoyr created D9103: Add BatchRenameJob to KIO.
Dec 2 2017, 11:06 AM · Frameworks

Oct 29 2017

chinmoyr reopened D6829: Add ability to use the new kauth helper in file ioslave.
Oct 29 2017, 4:11 PM · Frameworks
chinmoyr reopened D6709: Add support for sharing file descriptor between KIO slave and KAuth helper.
Oct 29 2017, 4:10 PM · Frameworks
chinmoyr reopened D6197: Add kauth helper to file ioslave.
Oct 29 2017, 4:10 PM · Frameworks

Oct 23 2017

chinmoyr added a comment to T6561: Polkit support in KIO.

@ngraham The breakage occured because I didn't pushed D6830 and D6831 along with those three patches.
As for the project's status, the things left are addition of unit tests in KIO and modification of context menu in Dolphin. Well, these things are taking more time than I had expected.

Oct 23 2017, 1:50 AM · Frameworks

Oct 13 2017

chinmoyr added a comment to T6561: Polkit support in KIO.

Thanks @lbeltrame and really sorry for the mess.

Oct 13 2017, 10:11 AM · Frameworks

Oct 11 2017

chinmoyr committed R241:c4726e843e42: Add ability to use the new kauth helper in file ioslave (authored by chinmoyr).
Add ability to use the new kauth helper in file ioslave
Oct 11 2017, 5:47 PM
chinmoyr closed D6829: Add ability to use the new kauth helper in file ioslave.
Oct 11 2017, 5:47 PM · Frameworks
chinmoyr committed R241:29a741982fe5: Add kauth helper to file ioslave (authored by chinmoyr).
Add kauth helper to file ioslave
Oct 11 2017, 4:45 PM
chinmoyr closed D6197: Add kauth helper to file ioslave.
Oct 11 2017, 4:45 PM · Frameworks
chinmoyr committed R241:0c2a6811dc50: Add support for sharing file descriptor between file ioslave and it's KAuth… (authored by chinmoyr).
Add support for sharing file descriptor between file ioslave and it's KAuth…
Oct 11 2017, 4:31 PM
chinmoyr closed D6709: Add support for sharing file descriptor between KIO slave and KAuth helper.
Oct 11 2017, 4:31 PM · Frameworks

Oct 8 2017

chinmoyr updated the diff for D6833: Add support for privilege execution in KIO jobs.
  • Privilege execution turned on by default
Oct 8 2017, 5:56 PM · Frameworks
chinmoyr updated the diff for D6832: Integrate new file ioslave in KIO job.

minox changes

Oct 8 2017, 4:53 PM · Frameworks

Oct 7 2017

chinmoyr updated the diff for D6832: Integrate new file ioslave in KIO job.

Added NoPrivilegeExecution flag to opt-out privilege execution.

Oct 7 2017, 4:53 PM · Frameworks
chinmoyr added a comment to D6709: Add support for sharing file descriptor between KIO slave and KAuth helper.

This is all ready to push now, right?

Please do, once the 5.39 RC tags are there (should happen today or tomorrow).

Oct 7 2017, 4:27 PM · Frameworks

Oct 5 2017

chinmoyr updated the diff for D6831: Make use of kauth helper in methods of file ioslave.

Added correct header
Removed the openMode variable. FileProtocol::tryOpen takes care of file mode.
Newline changes

Oct 5 2017, 10:38 AM · Frameworks
chinmoyr updated the diff for D6830: Make use of kauth helper in copy method of file ioslave.

used the new header and method

Oct 5 2017, 10:15 AM · Frameworks

Oct 3 2017

chinmoyr updated the diff for D6829: Add ability to use the new kauth helper in file ioslave.

copied the exact comment :)

Oct 3 2017, 5:12 PM · Frameworks
chinmoyr updated the diff for D6197: Add kauth helper to file ioslave.

replaced occurence of sharefd.{h, cpp} with fdsender.{h, cpp}

Oct 3 2017, 4:58 PM · Frameworks

Oct 2 2017

chinmoyr updated the diff for D6709: Add support for sharing file descriptor between KIO slave and KAuth helper.

Changed isValid() -> isListening() in FdReceiver

Oct 2 2017, 10:58 AM · Frameworks

Sep 21 2017

chinmoyr updated the diff for D6709: Add support for sharing file descriptor between KIO slave and KAuth helper.

Added license header

Sep 21 2017, 5:01 PM · Frameworks
chinmoyr updated the diff for D6709: Add support for sharing file descriptor between KIO slave and KAuth helper.
  • separated FdReceiver and FdSender
  • KMSgHdr -> FDMessageHeader and KSockaddrUn -> SocketAddress and moved them to private header
  • removed stopListening() method. Qt can handle m_readNotifier's deletion
Sep 21 2017, 4:57 PM · Frameworks

Sep 10 2017

chinmoyr added a comment to D7571: Enable modifying root-owned files in Dolphin.

So how do you suggest I proceed? Add an extra flag and comment out the current one or replace it altogether?

Sep 10 2017, 3:13 PM
chinmoyr added a comment to D7571: Enable modifying root-owned files in Dolphin.

I would suggest keeping it off by default and if we don't encounter any inconsistencies then we can turn it on for good. I believe this way we would have much less surprises or is it the surprises we are seeking?

Sep 10 2017, 9:10 AM

Sep 9 2017

chinmoyr added a comment to D7571: Enable modifying root-owned files in Dolphin.

I would like to add one point. With an opt-out flag we will have to patch every corner case of every application that uses KIO::Job. Whereas with PrivilegeExecution flag this transition can be slow and will be less error prone.

Sep 9 2017, 1:49 AM

Sep 4 2017

chinmoyr updated the diff for D7270: [FileUndoManager] Enable undoing changes in read-only folders.

I cannot think of any good reason as to why anyone would want to disable undo. So, removing the checks.
As of now copying from a locked folder is not supported. So your example file operation is not possible.

Sep 4 2017, 5:44 PM · Frameworks
chinmoyr updated the diff for D6833: Add support for privilege execution in KIO jobs.
  • Made method const
  • Removed unnecessary new line
Sep 4 2017, 5:12 PM · Frameworks
chinmoyr updated the diff for D6831: Make use of kauth helper in methods of file ioslave.
  • ret -> err
  • used tryOpen
Sep 4 2017, 4:08 PM · Frameworks
chinmoyr updated the diff for D6830: Make use of kauth helper in copy method of file ioslave.

removedextra semi-colon

Sep 4 2017, 3:50 PM · Frameworks
chinmoyr updated the diff for D6830: Make use of kauth helper in copy method of file ioslave.
  • Added method tryOpen
  • Ensured correct permissions are set on the newly created file.
  • auto ret -> auto err
  • There's no method like failed() in PrivOpReturnValue. We have to leave those calls as they are.
Sep 4 2017, 3:48 PM · Frameworks

Aug 27 2017

chinmoyr added a revision to T6561: Polkit support in KIO: D7571: Enable modifying root-owned files in Dolphin.
Aug 27 2017, 1:04 PM · Frameworks
chinmoyr added a task to D7571: Enable modifying root-owned files in Dolphin: T6561: Polkit support in KIO.
Aug 27 2017, 1:04 PM
chinmoyr created D7571: Enable modifying root-owned files in Dolphin.
Aug 27 2017, 1:02 PM
chinmoyr added a dependent revision for D7563: Add privilegeExecution field to file protocol description: D7571: Enable modifying root-owned files in Dolphin.
Aug 27 2017, 1:02 PM

Aug 26 2017

chinmoyr added a task to D7563: Add privilegeExecution field to file protocol description: T6561: Polkit support in KIO.
Aug 26 2017, 5:47 PM
chinmoyr added a revision to T6561: Polkit support in KIO: D7563: Add privilegeExecution field to file protocol description.
Aug 26 2017, 5:47 PM · Frameworks
chinmoyr created D7563: Add privilegeExecution field to file protocol description.
Aug 26 2017, 5:45 PM

Aug 24 2017

chinmoyr updated the diff for D6832: Integrate new file ioslave in KIO job.
  • Return an enum (PrivilegeOperationStatus) instead of bool for confirmation status.
Aug 24 2017, 5:40 PM · Frameworks
chinmoyr updated the diff for D6831: Make use of kauth helper in methods of file ioslave.
  • use the new execWithElevatedPrivilege method
Aug 24 2017, 5:10 PM · Frameworks
chinmoyr updated the diff for D6830: Make use of kauth helper in copy method of file ioslave.
  • use the new execWithElevatedPrivilege method
Aug 24 2017, 5:06 PM · Frameworks