chinmoyr (Chinmoy Ranjan Pradhan)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jun 20 2016, 6:48 AM (104 w, 5 d)
Availability
Available

Recent Activity

Fri, Jun 15

chinmoyr updated the task description for T8704: Verifying signatures of pdf files.
Fri, Jun 15, 12:58 PM · Okular

Mon, Jun 11

chinmoyr added a dependent revision for D11723: Add FormFieldSignature to Okular namespace: D13483: Add SignatureSummaryDialog and SignaturePropertiesDialog.
Mon, Jun 11, 6:18 PM · Okular
chinmoyr added a dependency for D13483: Add SignatureSummaryDialog and SignaturePropertiesDialog: D11723: Add FormFieldSignature to Okular namespace.
Mon, Jun 11, 6:18 PM · Okular
chinmoyr removed a dependent revision for D11723: Add FormFieldSignature to Okular namespace: D13366: Add SignatureEdit widget for FormFieldSignature.
Mon, Jun 11, 6:18 PM · Okular
chinmoyr edited dependencies for D13366: Add SignatureEdit widget for FormFieldSignature, added: 1; removed: 1.
Mon, Jun 11, 6:18 PM · Okular
chinmoyr added a dependent revision for D13483: Add SignatureSummaryDialog and SignaturePropertiesDialog: D13366: Add SignatureEdit widget for FormFieldSignature.
Mon, Jun 11, 6:18 PM · Okular
chinmoyr added a dependency for D13484: Show signature validation summary as popup: D13366: Add SignatureEdit widget for FormFieldSignature.
Mon, Jun 11, 6:18 PM · Okular
chinmoyr added a dependent revision for D13366: Add SignatureEdit widget for FormFieldSignature: D13484: Show signature validation summary as popup.
Mon, Jun 11, 6:18 PM · Okular
chinmoyr requested review of D13484: Show signature validation summary as popup.
Mon, Jun 11, 5:21 PM · Okular
chinmoyr updated the diff for D13366: Add SignatureEdit widget for FormFieldSignature.

Rebased on master
Made use of SignatureSummaryDialog and SignaturePropertiesDialog

Mon, Jun 11, 5:19 PM · Okular
chinmoyr requested review of D13483: Add SignatureSummaryDialog and SignaturePropertiesDialog.
Mon, Jun 11, 5:17 PM · Okular
chinmoyr updated the diff for D11723: Add FormFieldSignature to Okular namespace.

Revert to previous version. Now signatures will not be validated upfront.

Mon, Jun 11, 1:15 AM · Okular

Thu, Jun 7

chinmoyr added a comment to T8075: Fix security issues with KAuth support in KIO.

So what more is left to do here? Just improve the UI of the authorization dialog?

Thu, Jun 7, 11:55 AM · Frameworks

Tue, Jun 5

chinmoyr added a dependency for D13366: Add SignatureEdit widget for FormFieldSignature: D11723: Add FormFieldSignature to Okular namespace.
Tue, Jun 5, 5:16 PM · Okular
chinmoyr added a dependent revision for D11723: Add FormFieldSignature to Okular namespace: D13366: Add SignatureEdit widget for FormFieldSignature.
Tue, Jun 5, 5:16 PM · Okular
chinmoyr requested review of D13366: Add SignatureEdit widget for FormFieldSignature.
Tue, Jun 5, 5:09 PM · Okular

Mon, Jun 4

chinmoyr updated the diff for D11723: Add FormFieldSignature to Okular namespace.

Added validateSignatures() to validate signatures while loading a page.
Added to document info whether or not a pdf is digitally signed.

Mon, Jun 4, 11:10 AM · Okular
chinmoyr updated the task description for T8704: Verifying signatures of pdf files.
Mon, Jun 4, 9:02 AM · Okular
chinmoyr edited dependent revision(s) for D11723: Add FormFieldSignature to Okular namespace, added 1: D12901: Add unit test for SignatureFormField; removed 1: D11725: [RFC] Show signature status as a popup.
Mon, Jun 4, 8:59 AM · Okular
chinmoyr removed a dependency for D11725: [RFC] Show signature status as a popup: D11723: Add FormFieldSignature to Okular namespace.
Mon, Jun 4, 8:59 AM · Okular
chinmoyr added a dependency for D12901: Add unit test for SignatureFormField: D11723: Add FormFieldSignature to Okular namespace.
Mon, Jun 4, 8:59 AM · Okular
chinmoyr updated the diff for D11723: Add FormFieldSignature to Okular namespace.

Removed the unnecessary static_cast
Used QScopedPointer for d_ptr

Mon, Jun 4, 8:57 AM · Okular

Fri, Jun 1

chinmoyr updated the task description for T8075: Fix security issues with KAuth support in KIO.
Fri, Jun 1, 12:44 PM · Frameworks
chinmoyr updated the task description for T8075: Fix security issues with KAuth support in KIO.
Fri, Jun 1, 12:20 PM · Frameworks
chinmoyr committed R241:ba0f3e433969: Return the actual length of socket buffer (authored by chinmoyr).
Return the actual length of socket buffer
Fri, Jun 1, 12:16 PM
chinmoyr committed R241:a3328eaa5197: Unify API for file descriptor sharing (authored by chinmoyr).
Unify API for file descriptor sharing
Fri, Jun 1, 12:03 PM
chinmoyr closed D12745: Unify API for file descriptor sharing.
Fri, Jun 1, 12:03 PM · Frameworks
chinmoyr updated the diff for D12745: Unify API for file descriptor sharing.

Rebased on master

Fri, Jun 1, 12:02 PM · Frameworks
chinmoyr committed R241:bf7bfe9353c5: Add null pointer check when creating SocketAddress (authored by chinmoyr).
Add null pointer check when creating SocketAddress
Fri, Jun 1, 11:56 AM
chinmoyr closed D12744: Add null pointer check when creating SocketAddress.
Fri, Jun 1, 11:56 AM · Frameworks
chinmoyr committed R241:ae08be3a4847: Create socket file in user's runtime directory (authored by chinmoyr).
Create socket file in user's runtime directory
Fri, Jun 1, 11:50 AM
chinmoyr closed D10411: Create socket file in user's runtime directory.
Fri, Jun 1, 11:50 AM · Frameworks
chinmoyr committed R241:5b40e3322df7: Delete socket file after use (authored by chinmoyr).
Delete socket file after use
Fri, Jun 1, 11:50 AM
chinmoyr committed R241:3e7c84e877e5: Move task of cleaning up socket file to FdReceiver (authored by chinmoyr).
Move task of cleaning up socket file to FdReceiver
Fri, Jun 1, 11:35 AM
chinmoyr closed D10410: Move task of cleaning up socket file to FdReceiver.
Fri, Jun 1, 11:35 AM · Frameworks
chinmoyr retitled D10410: Move task of cleaning up socket file to FdReceiver from Move the task of cleaning up of socket file to file ioslave and FdReceiver to Move task of cleaning up socket file to FdReceiver.
Fri, Jun 1, 11:33 AM · Frameworks
chinmoyr updated the summary of D10410: Move task of cleaning up socket file to FdReceiver.
Fri, Jun 1, 11:31 AM · Frameworks
chinmoyr committed R241:89275d0d1450: In linux don't use abstract socket to share file descriptor (authored by chinmoyr).
In linux don't use abstract socket to share file descriptor
Fri, Jun 1, 11:28 AM
chinmoyr closed D10409: In linux don't use abstract socket to share file descriptor.
Fri, Jun 1, 11:27 AM · Frameworks

Mon, May 28

chinmoyr updated the diff for D11723: Add FormFieldSignature to Okular namespace.

Reused enums of Poppler::SignatureValidationInfo.
Used QDateTime in place of time_t.

Mon, May 28, 5:29 PM · Okular
chinmoyr abandoned D12291: Accept file descriptor only from root owned process.

As of now this change is not of any importance. If in future a situation arises where we need it I will reopen this revision.

Mon, May 28, 8:23 AM · Frameworks
chinmoyr updated the diff for D12291: Accept file descriptor only from root owned process.

Accept socket connection where getsockopt() is not present

Mon, May 28, 8:15 AM · Frameworks
chinmoyr added a comment to D13114: Add DocumentRevision to Okular.

Can you explain what's the use case for this?

Adobe reader allows user to view different signed revisions of a PDF. This patch intends to implement
that feature.

Mon, May 28, 6:48 AM · Okular
chinmoyr added inline comments to D12291: Accept file descriptor only from root owned process.
Mon, May 28, 6:13 AM · Frameworks
chinmoyr added a comment to D12745: Unify API for file descriptor sharing.

@dfaure can you have a look at this?

Mon, May 28, 5:25 AM · Frameworks

Sun, May 27

chinmoyr added inline comments to D12291: Accept file descriptor only from root owned process.
Sun, May 27, 1:13 PM · Frameworks
chinmoyr added a comment to D12291: Accept file descriptor only from root owned process.

@ossi would you mind reviewing this patch?

Sun, May 27, 11:34 AM · Frameworks
chinmoyr updated the diff for D12291: Accept file descriptor only from root owned process.

I only realized now that after making the previous change I forgot to rebase.
So uploading correct patch.

Sun, May 27, 11:31 AM · Frameworks
chinmoyr updated the diff for D12745: Unify API for file descriptor sharing.

Used std::string

Sun, May 27, 11:20 AM · Frameworks
chinmoyr removed a dependency for D10409: In linux don't use abstract socket to share file descriptor: D10273: Create proper SocketAddress.
Sun, May 27, 11:14 AM · Frameworks
chinmoyr removed a dependent revision for D10273: Create proper SocketAddress: D10409: In linux don't use abstract socket to share file descriptor.
Sun, May 27, 11:14 AM · Frameworks
chinmoyr removed a dependent revision for D9966: [KIO] Fix issues with sharing of file descriptor: D10410: Move task of cleaning up socket file to FdReceiver.
Sun, May 27, 11:13 AM · Frameworks
chinmoyr removed a dependency for D10410: Move task of cleaning up socket file to FdReceiver: D9966: [KIO] Fix issues with sharing of file descriptor.
Sun, May 27, 11:13 AM · Frameworks
chinmoyr updated the diff for D12744: Add null pointer check when creating SocketAddress.

fixed the issues mentioned

Sun, May 27, 10:57 AM · Frameworks
chinmoyr updated the diff for D10410: Move task of cleaning up socket file to FdReceiver.

corrected the unlink position

Sun, May 27, 10:44 AM · Frameworks
chinmoyr updated the diff for D10410: Move task of cleaning up socket file to FdReceiver.

Do the first unlink in FdReceiver constructor

Sun, May 27, 10:41 AM · Frameworks
chinmoyr added a dependent revision for D9966: [KIO] Fix issues with sharing of file descriptor: D10410: Move task of cleaning up socket file to FdReceiver.
Sun, May 27, 10:41 AM · Frameworks
chinmoyr added a comment to D10410: Move task of cleaning up socket file to FdReceiver.

SocketAddress is used only in FdSender and FdRecevier.

Sun, May 27, 10:40 AM · Frameworks
chinmoyr added a comment to D12745: Unify API for file descriptor sharing.
In D12745#268946, @ossi wrote:

why aren't you standardizing on std::string? that's cleaner than raw char pointers.
i know we discussed this before to some degree, but i don't remember the particulars.

Sun, May 27, 10:27 AM · Frameworks

Fri, May 25

chinmoyr requested review of D13114: Add DocumentRevision to Okular.
Fri, May 25, 3:35 PM · Okular

May 23 2018

chinmoyr added inline comments to D11723: Add FormFieldSignature to Okular namespace.
May 23 2018, 2:57 PM · Okular
chinmoyr updated the diff for D11723: Add FormFieldSignature to Okular namespace.

Updated API.
Removed cases with no use cases.
Removed redundant enums.

May 23 2018, 2:55 PM · Okular

May 22 2018

chinmoyr abandoned D11725: [RFC] Show signature status as a popup.
May 22 2018, 5:01 PM · Okular
chinmoyr added a comment to D12745: Unify API for file descriptor sharing.

ping

May 22 2018, 4:57 PM · Frameworks
chinmoyr added a comment to D10410: Move task of cleaning up socket file to FdReceiver.

ping

May 22 2018, 4:56 PM · Frameworks

May 19 2018

chinmoyr added a comment to D11725: [RFC] Show signature status as a popup.

Yes this was not supposed to be merged as is. Shall I abandon it?

May 19 2018, 10:06 AM · Okular
chinmoyr added a comment to D11725: [RFC] Show signature status as a popup.

Sorry you lost me here, what's revision 30645 ?

May 19 2018, 9:28 AM · Okular

May 18 2018

chinmoyr added a comment to D11725: [RFC] Show signature status as a popup.

This doesn't work anymore right? signValidationInfoList doesn't exist in D11723

May 18 2018, 3:10 PM · Okular

May 17 2018

chinmoyr updated the diff for D12901: Add unit test for SignatureFormField.

Updated test PDF.

May 17 2018, 5:50 PM · Okular

May 16 2018

chinmoyr updated the diff for D11723: Add FormFieldSignature to Okular namespace.

Removed code unrelated to this revision.

May 16 2018, 5:28 PM · Okular

May 15 2018

chinmoyr requested review of D12901: Add unit test for SignatureFormField.
May 15 2018, 5:18 PM · Okular

May 14 2018

chinmoyr added a project to T8704: Verifying signatures of pdf files: Okular.
May 14 2018, 4:28 PM · Okular
chinmoyr triaged T8704: Verifying signatures of pdf files as Normal priority.
May 14 2018, 4:24 PM · Okular
chinmoyr edited reviewers for D11723: Add FormFieldSignature to Okular namespace, added: aacid; removed: Okular.
May 14 2018, 4:16 PM · Okular

May 8 2018

chinmoyr updated the diff for D12744: Add null pointer check when creating SocketAddress.

Used qPrintable()

May 8 2018, 4:10 PM · Frameworks
chinmoyr updated the diff for D12745: Unify API for file descriptor sharing.

Rebased on updated D12744.

May 8 2018, 12:39 PM · Frameworks
chinmoyr updated the diff for D12744: Add null pointer check when creating SocketAddress.

Print the invalid socket path in case of an error.

May 8 2018, 12:30 PM · Frameworks
chinmoyr updated the diff for D12745: Unify API for file descriptor sharing.

Print the invalid socket path in case of error.

May 8 2018, 12:27 PM · Frameworks

May 7 2018

chinmoyr updated the diff for D12291: Accept file descriptor only from root owned process.

Updated the comment

May 7 2018, 4:29 PM · Frameworks
chinmoyr removed a dependency for D10410: Move task of cleaning up socket file to FdReceiver: D9966: [KIO] Fix issues with sharing of file descriptor.
May 7 2018, 4:20 PM · Frameworks
chinmoyr removed a dependent revision for D9966: [KIO] Fix issues with sharing of file descriptor: D10410: Move task of cleaning up socket file to FdReceiver.
May 7 2018, 4:20 PM · Frameworks
chinmoyr reclaimed D10411: Create socket file in user's runtime directory.

Sorry, abandoned it by mistake.

May 7 2018, 4:19 PM · Frameworks
chinmoyr abandoned D10273: Create proper SocketAddress.

Split into D12744 and D12745

May 7 2018, 4:18 PM · Frameworks
chinmoyr abandoned D10411: Create socket file in user's runtime directory.
May 7 2018, 4:17 PM · Frameworks
chinmoyr added a dependent revision for D12744: Add null pointer check when creating SocketAddress: D12745: Unify API for file descriptor sharing.
May 7 2018, 4:16 PM · Frameworks
chinmoyr requested review of D12745: Unify API for file descriptor sharing.
May 7 2018, 4:16 PM · Frameworks
chinmoyr added a dependency for D12744: Add null pointer check when creating SocketAddress: D10411: Create socket file in user's runtime directory.
May 7 2018, 3:54 PM · Frameworks
chinmoyr added a dependent revision for D10411: Create socket file in user's runtime directory: D12744: Add null pointer check when creating SocketAddress.
May 7 2018, 3:54 PM · Frameworks
chinmoyr requested review of D12744: Add null pointer check when creating SocketAddress.
May 7 2018, 3:53 PM · Frameworks
chinmoyr updated the diff for D10411: Create socket file in user's runtime directory.

Rebased on D10410

May 7 2018, 3:38 PM · Frameworks
chinmoyr updated the diff for D10410: Move task of cleaning up socket file to FdReceiver.

Used QString::toLocal8Bit() instead of QFile::encodeName(). QFile wasn't supposed to be included in this commit.

May 7 2018, 3:28 PM · Frameworks

Apr 17 2018

chinmoyr abandoned D9966: [KIO] Fix issues with sharing of file descriptor.

Changes split in D12291 and D10411

Apr 17 2018, 5:58 PM · Frameworks
chinmoyr updated the diff for D10411: Create socket file in user's runtime directory.

Rebased on D10409

Apr 17 2018, 5:56 PM · Frameworks
chinmoyr updated the diff for D10409: In linux don't use abstract socket to share file descriptor.

Fix compilation error

Apr 17 2018, 5:48 PM · Frameworks
chinmoyr updated the diff for D10409: In linux don't use abstract socket to share file descriptor.

Removed dependency on D10273
Rebased on master

Apr 17 2018, 5:29 PM · Frameworks
chinmoyr requested review of D12291: Accept file descriptor only from root owned process.
Apr 17 2018, 5:15 PM · Frameworks
chinmoyr abandoned D6199: Allow deleting from write-protected location in dolphin.

Not required due to design changes

Apr 17 2018, 5:10 PM
chinmoyr abandoned D6834: [KNewFileMenu] Enable creating new files in read-only folders.

Not required due to design changes

Apr 17 2018, 5:10 PM · Frameworks
chinmoyr added a comment to D12049: Obey umask rules when saving new file.

ping

Apr 17 2018, 4:29 PM · Okular
chinmoyr added a comment to D12098: Resize content area to correct dimensions after zooming to Auto Fit.

ping

Apr 17 2018, 4:29 PM · Okular