chinmoyr (Chinmoy Ranjan Pradhan)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 20 2016, 6:48 AM (147 w, 4 d)
Availability
Available

Recent Activity

Fri, Apr 5

chinmoyr awarded D20266: Add new notification plasmoid a Like token.
Fri, Apr 5, 3:52 PM · Plasma

Tue, Mar 26

chinmoyr added a comment to D20062: [RFC] Add support for changing volume label..

The issue here is the placement of code. There are no API for changing any volume attributes so adding the changeLabel() method here feels awkward.

Tue, Mar 26, 3:38 PM · Frameworks
chinmoyr requested review of D20062: [RFC] Add support for changing volume label..
Tue, Mar 26, 1:53 PM · Frameworks

Mar 20 2019

chinmoyr committed R373:18c3a2ee6c84: Add blender thumbnailer (authored by chinmoyr).
Add blender thumbnailer
Mar 20 2019, 2:40 PM

Mar 17 2019

chinmoyr added a comment to D18845: authority: add support for passing details to polkit.

I would like this patch to land so +1 from me. But I am not familiar with this code so I can't give any meaningful feedback. Sorry.

Mar 17 2019, 3:19 PM
chinmoyr committed R373:2da545defff9: Add blender thumbnailer (authored by chinmoyr).
Add blender thumbnailer
Mar 17 2019, 9:12 AM
chinmoyr closed D19696: Add blender thumbnailer.
Mar 17 2019, 9:11 AM · Frameworks, Dolphin

Mar 15 2019

chinmoyr updated the diff for D19696: Add blender thumbnailer.

Removed unused headers.

Mar 15 2019, 5:45 PM · Frameworks, Dolphin

Mar 14 2019

chinmoyr updated the diff for D19696: Add blender thumbnailer.

Issues fixed.

Mar 14 2019, 2:34 AM · Frameworks, Dolphin
chinmoyr added inline comments to D19696: Add blender thumbnailer.
Mar 14 2019, 2:32 AM · Frameworks, Dolphin

Mar 13 2019

chinmoyr added inline comments to D19696: Add blender thumbnailer.
Mar 13 2019, 6:50 PM · Frameworks, Dolphin
chinmoyr updated the diff for D19696: Add blender thumbnailer.

Moved to kdegraphics-thumbnailer.
Got rid of operator>>(). Now reading the entire file-block header and extracting the length from raw bytes.
Used QByteArrays instead of static char arrays.
Fixed some minor issues.

Mar 13 2019, 6:49 PM · Frameworks, Dolphin

Mar 12 2019

kamathraghavendra awarded D19696: Add blender thumbnailer a Love token.
Mar 12 2019, 10:40 AM · Frameworks, Dolphin
chinmoyr updated the summary of D19696: Add blender thumbnailer.
Mar 12 2019, 1:06 AM · Frameworks, Dolphin
chinmoyr requested review of D19696: Add blender thumbnailer.
Mar 12 2019, 1:01 AM · Frameworks, Dolphin

Mar 10 2019

chinmoyr committed R241:7a79f1531480: [FileCopyJob] Clean up after cancelation of file copy operation (authored by chinmoyr).
[FileCopyJob] Clean up after cancelation of file copy operation
Mar 10 2019, 4:47 PM
chinmoyr closed D18904: [FileCopyJob] Clean up after cancelation of file copy operation.
Mar 10 2019, 4:47 PM · Frameworks
chinmoyr updated the diff for D18904: [FileCopyJob] Clean up after cancelation of file copy operation.

Update summary

Mar 10 2019, 4:46 PM · Frameworks
chinmoyr updated the diff for D18904: [FileCopyJob] Clean up after cancelation of file copy operation.

Changed m_bFileWriteInProgress -> m_bFileCopyInProgress

Mar 10 2019, 4:43 PM · Frameworks

Mar 9 2019

chinmoyr added a comment to D7571: Enable modifying root-owned files in Dolphin.

@chinmoyr Is this patch going to be replaced by another one, or is it not needed anymore?

Mar 9 2019, 4:19 PM · Dolphin
chinmoyr committed R241:ab042f6724ee: JobTest::safeOverwrite() still fails in CI build. Use old signal syntax to see… (authored by chinmoyr).
JobTest::safeOverwrite() still fails in CI build. Use old signal syntax to see…
Mar 9 2019, 11:15 AM
chinmoyr committed R241:6e0a820eb0ce: [jobtest] Use FileCopyJob to resolve signal (authored by chinmoyr).
[jobtest] Use FileCopyJob to resolve signal
Mar 9 2019, 9:43 AM
chinmoyr committed R241:fcabd1e2c2db: Pass local file path to KFileSystemType::fileSystemType(). (authored by chinmoyr).
Pass local file path to KFileSystemType::fileSystemType().
Mar 9 2019, 8:54 AM

Mar 7 2019

chinmoyr added a comment to D18904: [FileCopyJob] Clean up after cancelation of file copy operation.

There's free space check in CopyJob. And Dolphin still gives an error in the said situation. But if some application decides to directly use FileCopyJob then IMO the free space check should be at application's side. Anyway, I tried adding it here and it felt awkward to me.

Mar 7 2019, 6:17 PM · Frameworks
chinmoyr added a comment to D19585: [CopyJob] Report results after finishing copy.

Opened Dolphin, Ctrl+C on a file, Ctrl+V it into the same folder, let it sit at the "Override?" prompt until the job view in Plasma showed up. >Chose a different filename and continued.
[...]
The URL isn't updated in case of a rename but I bet it just needs a m_bURLDirty call somewhere in the conflict handler

Mar 7 2019, 5:46 PM · Frameworks

Mar 6 2019

chinmoyr committed R241:ef5b9c6991aa: Fix upper/lower case rename on case insensitive fs (authored by hoffmannrobert).
Fix upper/lower case rename on case insensitive fs
Mar 6 2019, 5:00 PM
chinmoyr closed D19422: Fix upper/lower case rename on case insensitive fs.
Mar 6 2019, 5:00 PM · Frameworks
chinmoyr updated the diff for D18904: [FileCopyJob] Clean up after cancelation of file copy operation.

Remove unrelated changes commited by mistake.

Mar 6 2019, 4:33 PM · Frameworks
chinmoyr updated the diff for D18904: [FileCopyJob] Clean up after cancelation of file copy operation.

Delete .part file when Overwrite flag is set.

Mar 6 2019, 4:22 PM · Frameworks
chinmoyr accepted D19422: Fix upper/lower case rename on case insensitive fs.
Mar 6 2019, 3:27 PM · Frameworks
chinmoyr abandoned D7571: Enable modifying root-owned files in Dolphin.
Mar 6 2019, 3:10 PM · Dolphin

Mar 3 2019

chinmoyr committed R241:613e54a35e5e: Don't use QStringLiteral::arg() in qCWarning() (authored by chinmoyr).
Don't use QStringLiteral::arg() in qCWarning()
Mar 3 2019, 9:04 AM
chinmoyr committed R241:f34c2cf0abf1: Make file overwrite a bit safer (authored by chinmoyr).
Make file overwrite a bit safer
Mar 3 2019, 8:56 AM
chinmoyr closed D19080: Make file overwrite a bit safer.
Mar 3 2019, 8:56 AM · Frameworks
chinmoyr updated the diff for D19080: Make file overwrite a bit safer.

Print strerror.

Mar 3 2019, 8:55 AM · Frameworks

Mar 2 2019

chinmoyr abandoned D3955: [Plasma folderview] Improve keyboard navigation.
Mar 2 2019, 5:26 PM · Plasma
chinmoyr committed R241:53bba36a78c4: Port to new connect syntax (authored by chinmoyr).
Port to new connect syntax
Mar 2 2019, 5:24 PM
chinmoyr closed D18455: Port to new connect syntax.
Mar 2 2019, 5:24 PM · Frameworks
chinmoyr updated the diff for D18455: Port to new connect syntax.

Restore sourceStated in CopyJob.

Mar 2 2019, 5:13 PM · Frameworks
chinmoyr requested changes to D19422: Fix upper/lower case rename on case insensitive fs.
Mar 2 2019, 4:53 PM · Frameworks

Feb 26 2019

chinmoyr planned changes to D19339: Add option to change drive label to places panel context menu.
Feb 26 2019, 2:05 PM · Dolphin
chinmoyr requested review of D19339: Add option to change drive label to places panel context menu.
Feb 26 2019, 1:28 PM · Dolphin
chinmoyr added a comment to D19080: Make file overwrite a bit safer.

@dfaure ping

Feb 26 2019, 1:09 AM · Frameworks

Feb 24 2019

chinmoyr edited P332 [Dolphin/PlacesPanel] Add menu action to change partition label.
Feb 24 2019, 1:51 PM
chinmoyr created P332 [Dolphin/PlacesPanel] Add menu action to change partition label in the S1 KDE Community space.
Feb 24 2019, 1:49 PM

Feb 18 2019

chinmoyr updated the diff for D19080: Make file overwrite a bit safer.

Update.

Feb 18 2019, 1:50 AM · Frameworks

Feb 16 2019

chinmoyr updated the diff for D19080: Make file overwrite a bit safer.

Skip unit test on windows.

Feb 16 2019, 4:35 PM · Frameworks
chinmoyr updated the diff for D19080: Make file overwrite a bit safer.

Removed warning message.
Removed arg().
Added test cases.
Used QFile::resize().

Feb 16 2019, 4:23 PM · Frameworks
chinmoyr added a dependency for D18904: [FileCopyJob] Clean up after cancelation of file copy operation: D19080: Make file overwrite a bit safer.
Feb 16 2019, 1:35 PM · Frameworks
chinmoyr added a dependent revision for D19080: Make file overwrite a bit safer: D18904: [FileCopyJob] Clean up after cancelation of file copy operation.
Feb 16 2019, 1:35 PM · Frameworks
chinmoyr requested review of D19080: Make file overwrite a bit safer.
Feb 16 2019, 1:33 PM · Frameworks

Feb 11 2019

chinmoyr added inline comments to D18915: Fix batchrename changing extension to lower case.
Feb 11 2019, 4:19 AM · Frameworks
chinmoyr updated the diff for D18904: [FileCopyJob] Clean up after cancelation of file copy operation.

Fixed all issues.
Added test case for suspend.

Feb 11 2019, 2:17 AM · Frameworks
chinmoyr added a comment to D18915: Fix batchrename changing extension to lower case.

@cfoster Thanks for the patch :)

Feb 11 2019, 1:48 AM · Frameworks
chinmoyr added a comment to D18904: [FileCopyJob] Clean up after cancelation of file copy operation.

@ngraham The destination file is corrupted as soon as the user clicks overwrite. This patch deletes that file. Is that file supposed to be preserved (to prevent user panic)? My suggestion is to append ".part" or some similar extension when an overwrite starts, so the user knows that there data is gone.

Feb 11 2019, 1:32 AM · Frameworks

Feb 10 2019

chinmoyr requested review of D18904: [FileCopyJob] Clean up after cancelation of file copy operation.
Feb 10 2019, 5:43 PM · Frameworks

Feb 5 2019

chinmoyr accepted D18632: Port away from deprecated KIO::UDSEntry::insert().

LGTM

Feb 5 2019, 4:32 PM · Plasma
chinmoyr added inline comments to D18632: Port away from deprecated KIO::UDSEntry::insert().
Feb 5 2019, 3:53 PM · Plasma
chinmoyr added inline comments to D18632: Port away from deprecated KIO::UDSEntry::insert().
Feb 5 2019, 3:46 PM · Plasma
chinmoyr accepted D18641: [kio_applications] Fix last dir item being shown twice.
Feb 5 2019, 3:31 PM · Plasma

Feb 3 2019

chinmoyr added a reviewer for D18699: [KIO/RenameDialog] Add new apply behaviour: VDG.
Feb 3 2019, 4:16 PM · Frameworks
chinmoyr updated the diff for D18699: [KIO/RenameDialog] Add new apply behaviour.

Add bug id.
Remove old code.

Feb 3 2019, 3:59 PM · Frameworks
chinmoyr requested review of D18699: [KIO/RenameDialog] Add new apply behaviour.
Feb 3 2019, 3:53 PM · Frameworks

Jan 29 2019

chinmoyr added a comment to T8075: Fix security issues with KAuth support in KIO.

What needs to be done to push this forward? Do you need any help?

Jan 29 2019, 6:42 PM · Frameworks
chinmoyr added a comment to D17737: [CopyJob] Create clones in btrf/xfs mount.

@bruns ping

Jan 29 2019, 12:47 AM · Frameworks
chinmoyr added a comment to T8075: Fix security issues with KAuth support in KIO.

@kpiwowarski Still WIP :(

Jan 29 2019, 12:45 AM · Frameworks

Jan 22 2019

chinmoyr requested review of D18455: Port to new connect syntax.
Jan 22 2019, 1:42 PM · Frameworks

Jan 19 2019

chinmoyr added a comment to T8704: Verifying signatures of pdf files.

@aacid Add an action to "Tools" menu for accessing the signature panel. Optionally add an action to verify all signatures but I feel it's redundant due of the message widget.

Jan 19 2019, 1:05 PM · Okular
chinmoyr abandoned D13114: Add DocumentRevision to Okular.

@aacid Sorry for late reply. This got lost in my inbox.

Jan 19 2019, 12:59 PM · Okular

Jan 15 2019

chinmoyr added a comment to D18263: [CopyJob] Provide more descriptive notification header.

They emit a generic message. A descriptive message can only generated from within job.

Jan 15 2019, 2:52 PM · Frameworks
chinmoyr requested review of D18263: [CopyJob] Provide more descriptive notification header.
Jan 15 2019, 1:46 PM · Frameworks

Jan 14 2019

chinmoyr added inline comments to D17528: Refactor SlaveInterface::calcSpeed.
Jan 14 2019, 1:47 PM · Frameworks

Jan 11 2019

l10n daemon script <scripty@kde.org> committed R241:8ba03c4166c5: [KNewFileMenu] Don't emit fileCreated when creating a directory (authored by chinmoyr).
[KNewFileMenu] Don't emit fileCreated when creating a directory
Jan 11 2019, 9:07 PM
chinmoyr committed R241:28dacfe07375: [KNewFileMenu] Don't emit fileCreated when creating a directory (authored by chinmoyr).
[KNewFileMenu] Don't emit fileCreated when creating a directory
Jan 11 2019, 4:37 PM
chinmoyr closed D18187: [KNewFileMenu] Don't emit fileCreated when creating a directory.
Jan 11 2019, 4:37 PM · Frameworks
chinmoyr requested review of D18187: [KNewFileMenu] Don't emit fileCreated when creating a directory.
Jan 11 2019, 4:15 PM · Frameworks
chinmoyr accepted D18158: Fix elapsed time check.
Jan 11 2019, 3:29 PM · Frameworks

Jan 10 2019

chinmoyr added inline comments to D17528: Refactor SlaveInterface::calcSpeed.
Jan 10 2019, 3:40 PM · Frameworks

Jan 7 2019

chinmoyr updated the diff for D17737: [CopyJob] Create clones in btrf/xfs mount.

Scraped everything but the changes from file_unix.cpp

Jan 7 2019, 7:53 AM · Frameworks

Dec 23 2018

chinmoyr added a comment to D17737: [CopyJob] Create clones in btrf/xfs mount.

I think it would be much simpler if you just tried to do the the FICLONE iotctl in the job, without any prior checking:

  • no possibility for races
  • less syscals
  • less code
Dec 23 2018, 3:41 PM · Frameworks

Dec 22 2018

chinmoyr requested review of D17737: [CopyJob] Create clones in btrf/xfs mount.
Dec 22 2018, 4:16 PM · Frameworks
chinmoyr committed R241:4e2a815b9a10: Refactor SlaveInterface::calcSpeed (authored by chinmoyr).
Refactor SlaveInterface::calcSpeed
Dec 22 2018, 12:23 PM
chinmoyr closed D17528: Refactor SlaveInterface::calcSpeed.
Dec 22 2018, 12:23 PM · Frameworks

Dec 21 2018

chinmoyr updated the diff for D17528: Refactor SlaveInterface::calcSpeed.

update

Dec 21 2018, 12:31 PM · Frameworks

Dec 17 2018

chinmoyr updated the diff for D17528: Refactor SlaveInterface::calcSpeed.

Removed vector initialization.
Increased vector capacity in constructor.
Appended {0,0} at first.
Stored time and size before appending to prevent extraction.

Dec 17 2018, 5:12 PM · Frameworks
chinmoyr added inline comments to D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable.
Dec 17 2018, 4:04 PM · Frameworks
chinmoyr added inline comments to D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable.
Dec 17 2018, 3:38 PM · Frameworks

Dec 14 2018

chinmoyr updated the diff for D17528: Refactor SlaveInterface::calcSpeed.

Used a structure to group size and time.

Dec 14 2018, 2:51 PM · Frameworks

Dec 13 2018

chinmoyr updated the diff for D17528: Refactor SlaveInterface::calcSpeed.

Used QVector

Dec 13 2018, 2:28 PM · Frameworks
chinmoyr added a comment to D17528: Refactor SlaveInterface::calcSpeed.

I'm surprised, how can a QLinkedList (with nodes allocated all over the memory) be better than a static array (which fits into the same memory cache) ?

Dec 13 2018, 2:03 PM · Frameworks

Dec 12 2018

chinmoyr requested review of D17528: Refactor SlaveInterface::calcSpeed.
Dec 12 2018, 9:21 AM · Frameworks

Dec 11 2018

chinmoyr committed R241:29008f8ab520: SlaveInterface: Stop speed_timer after a job is killed. (authored by chinmoyr).
SlaveInterface: Stop speed_timer after a job is killed.
Dec 11 2018, 4:53 PM
chinmoyr closed D17502: Store timestamp as UTC.
Dec 11 2018, 1:27 PM · Frameworks
chinmoyr committed R241:1c3ecda86679: Store timestamp as UTC (authored by chinmoyr).
Store timestamp as UTC
Dec 11 2018, 1:27 PM
chinmoyr requested review of D17502: Store timestamp as UTC.
Dec 11 2018, 12:34 PM · Frameworks

Aug 14 2018

chinmoyr updated the task description for T8704: Verifying signatures of pdf files.
Aug 14 2018, 2:46 PM · Okular
chinmoyr reopened D13484: Show signature validation summary as popup.
Aug 14 2018, 2:42 PM · Okular
chinmoyr reopened D13366: Add SignatureEdit widget for FormFieldSignature.
Aug 14 2018, 2:41 PM · Okular
chinmoyr reopened D14748: Add signature properties dialog.
Aug 14 2018, 2:41 PM · Okular
chinmoyr reopened D14734: Add revision viewer.
Aug 14 2018, 2:41 PM · Okular