chinmoyr (Chinmoy Ranjan Pradhan)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jun 20 2016, 6:48 AM (165 w, 3 d)
Availability
Available

Recent Activity

Fri, Aug 16

chinmoyr added inline comments to D21795: [KAuth] Add support for action details in Polkit1 backend..
Fri, Aug 16, 6:23 PM · Frameworks
chinmoyr updated the diff for D21795: [KAuth] Add support for action details in Polkit1 backend..

Addressed comments.

Fri, Aug 16, 6:22 PM · Frameworks
chinmoyr requested changes to D23194: Making FileJob behave consistently..
Fri, Aug 16, 8:19 AM · Frameworks

Thu, Aug 15

chinmoyr added inline comments to D23159: Prevent error() being emitted when purposefully reading 0 bytes.
Thu, Aug 15, 6:13 PM · Frameworks

Tue, Aug 6

chinmoyr abandoned D22708: [WIP] Add a kded module infra for fuse mount services.
Tue, Aug 6, 9:41 AM · Frameworks

Wed, Jul 24

chinmoyr created P441 KIO-SMB in the S1 KDE Community space.
Wed, Jul 24, 12:50 PM
chinmoyr updated the diff for D22708: [WIP] Add a kded module infra for fuse mount services.

Added KRun changes

Wed, Jul 24, 12:46 PM · Frameworks
chinmoyr requested review of D22708: [WIP] Add a kded module infra for fuse mount services.
Wed, Jul 24, 6:41 AM · Frameworks

Jul 19 2019

chinmoyr requested review of D22555: [RFC] Add a kded module to manage various available fuse mount services.
Jul 19 2019, 11:20 AM · Frameworks
chinmoyr committed R236:653192440bf8: Add a warning dialog with a collapsible details section. (authored by chinmoyr).
Add a warning dialog with a collapsible details section.
Jul 19 2019, 8:52 AM
chinmoyr closed D21782: Add a warning dialog with details, continue, and cancel button.
Jul 19 2019, 8:52 AM · Frameworks
chinmoyr updated the summary of D21782: Add a warning dialog with details, continue, and cancel button.
Jul 19 2019, 8:42 AM · Frameworks

Jun 22 2019

chinmoyr added a comment to D14467: Auth Support: Drop privileges if target is not owned by root.

It would appear that the commit of this change disturbed somethng with FreeBSD builds - see https://build.kde.org/view/Failing/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/135/

Could someone take a look into that please?

Jun 22 2019, 11:49 AM · Frameworks
chinmoyr committed R241:91901a64adca: O_PATH is only available on linux. To prevent the compiler from throwing an… (authored by chinmoyr).
O_PATH is only available on linux. To prevent the compiler from throwing an…
Jun 22 2019, 11:48 AM

Jun 21 2019

chinmoyr updated the diff for D21782: Add a warning dialog with details, continue, and cancel button.

Updated the implementation.

Jun 21 2019, 5:12 PM · Frameworks
chinmoyr committed R236:89606c1ecb57: Replace "Details" button with KCollapsibleGroupBox (authored by chinmoyr).
Replace "Details" button with KCollapsibleGroupBox
Jun 21 2019, 4:49 PM
chinmoyr updated the summary of D14467: Auth Support: Drop privileges if target is not owned by root.
Jun 21 2019, 4:05 PM · Frameworks
chinmoyr committed R241:11a14afc831e: Auth Support: Drop privileges if target is not owned by root (authored by chinmoyr).
Auth Support: Drop privileges if target is not owned by root
Jun 21 2019, 4:01 PM
chinmoyr committed R241:db52929ad0de: Revert "Auth Support: Drop privileges if target is not owned by root" (authored by chinmoyr).
Revert "Auth Support: Drop privileges if target is not owned by root"
Jun 21 2019, 4:01 PM
chinmoyr added a reverting change for R241:efeede07c8eb: Auth Support: Drop privileges if target is not owned by root: R241:db52929ad0de: Revert "Auth Support: Drop privileges if target is not owned by root".
Jun 21 2019, 4:01 PM
chinmoyr committed R241:efeede07c8eb: Auth Support: Drop privileges if target is not owned by root (authored by chinmoyr).
Auth Support: Drop privileges if target is not owned by root
Jun 21 2019, 3:46 PM
chinmoyr closed D14467: Auth Support: Drop privileges if target is not owned by root.
Jun 21 2019, 3:46 PM · Frameworks
chinmoyr added a comment to D14467: Auth Support: Drop privileges if target is not owned by root.

Thanks for your help!

Jun 21 2019, 3:34 PM · Frameworks
chinmoyr closed D21953: Replace "Details" button with KCollapsibleGroupBox.

https://commits.kde.org/kwidgetsaddons/89606c1ecb571e3ae9137cab18ceadeff57666e3

Jun 21 2019, 3:30 PM · Frameworks
chinmoyr updated the diff for D21953: Replace "Details" button with KCollapsibleGroupBox.

"More Details" -> "Details"

Jun 21 2019, 3:28 PM · Frameworks
chinmoyr updated the diff for D14467: Auth Support: Drop privileges if target is not owned by root.

Separated (l)chown since it's to be done with elavated privileges.

Jun 21 2019, 3:23 PM · Frameworks
chinmoyr added inline comments to D14467: Auth Support: Drop privileges if target is not owned by root.
Jun 21 2019, 11:22 AM · Frameworks
chinmoyr updated the diff for D14467: Auth Support: Drop privileges if target is not owned by root.

Addresed the issues.

Jun 21 2019, 11:20 AM · Frameworks
chinmoyr requested review of D21953: Replace "Details" button with KCollapsibleGroupBox.
Jun 21 2019, 9:40 AM · Frameworks

Jun 20 2019

chinmoyr updated the diff for D14467: Auth Support: Drop privileges if target is not owned by root.

Thanks @maltek. I've fixed all the issues.

Jun 20 2019, 6:39 PM · Frameworks

Jun 19 2019

chinmoyr accepted D21882: RFC: [CopyJob] Batch reporting processed amount.
Jun 19 2019, 12:49 PM · Frameworks

Jun 15 2019

chinmoyr planned changes to D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation.

TODO

  • Change the UI of the warning dialog
  • We still need more details
Jun 15 2019, 8:08 AM · Frameworks

Jun 14 2019

chinmoyr updated the task description for T8075: Fix security issues with KAuth support in KIO.
Jun 14 2019, 6:14 AM · Frameworks
chinmoyr requested review of D21795: [KAuth] Add support for action details in Polkit1 backend..
Jun 14 2019, 6:12 AM · Frameworks

Jun 13 2019

chinmoyr committed R241:14b29cf64611: Cancel privilege operation for read-only target with the current user as owner (authored by chinmoyr).
Cancel privilege operation for read-only target with the current user as owner
Jun 13 2019, 7:06 PM
chinmoyr closed D14464: Cancel privilege operation for read-only target with the current user as owner.

https://commits.kde.org/kio/14b29cf64611f91f0bc1f5828e4c86392510f0e6

Jun 13 2019, 7:03 PM · Frameworks
chinmoyr updated the diff for D14464: Cancel privilege operation for read-only target with the current user as owner.

Updated frameworks version.

Jun 13 2019, 6:56 PM · Frameworks
chinmoyr added a comment to D14467: Auth Support: Drop privileges if target is not owned by root.

@mgerstner How is this looking now? Yea/nay?

Jun 13 2019, 6:45 PM · Frameworks
chinmoyr added a comment to D21782: Add a warning dialog with details, continue, and cancel button.
In D21782#479190, @GB_2 wrote:

I think a KCollapsibleGroupBox would fit here: http://blog.davidedmundson.co.uk/blog/my-new-widget-in-frameworks/

Jun 13 2019, 6:39 PM · Frameworks
chinmoyr updated the task description for T8075: Fix security issues with KAuth support in KIO.
Jun 13 2019, 6:21 PM · Frameworks
chinmoyr added a comment to D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation.

Thanks! Is this for T8075?

Jun 13 2019, 6:19 PM · Frameworks
chinmoyr updated the diff for D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation.

Fix typo

Jun 13 2019, 4:16 PM · Frameworks
chinmoyr updated the summary of D21782: Add a warning dialog with details, continue, and cancel button.
Jun 13 2019, 4:13 PM · Frameworks
chinmoyr requested review of D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation.
Jun 13 2019, 4:13 PM · Frameworks
chinmoyr requested review of D21782: Add a warning dialog with details, continue, and cancel button.
Jun 13 2019, 4:05 PM · Frameworks

Jun 7 2019

chinmoyr updated the diff for D14467: Auth Support: Drop privileges if target is not owned by root.

use seteuid to make the logic for rename work

Jun 7 2019, 9:00 AM · Frameworks

Jun 6 2019

chinmoyr updated the diff for D14467: Auth Support: Drop privileges if target is not owned by root.
  • int -> ActionType
  • separated the logic in dropPrivileges() to two parts
  • accepting mode argument in mkdir
  • used *at() functions
  • minor cosmetic changes
Jun 6 2019, 7:07 PM · Frameworks

May 27 2019

chinmoyr added inline comments to R223:a234a902dcff: Implement digital signature support for PDF.
May 27 2019, 3:36 PM
chinmoyr added inline comments to R223:a234a902dcff: Implement digital signature support for PDF.
May 27 2019, 3:33 PM
chinmoyr committed R241:8e00726eda1f: Manipulate bytes instead of characters (authored by chinmoyr).
Manipulate bytes instead of characters
May 27 2019, 2:06 PM
chinmoyr closed D21317: Manipulate bytes instead of characters.
May 27 2019, 2:06 PM · Frameworks

May 21 2019

chinmoyr requested review of D21317: Manipulate bytes instead of characters.
May 21 2019, 1:07 PM · Frameworks

May 14 2019

chinmoyr committed R241:092beaf6fbab: Truncate long filname before creating a link (authored by chinmoyr).
Truncate long filname before creating a link
May 14 2019, 12:25 PM
chinmoyr closed D21155: Truncate long filname before creating a link.
May 14 2019, 12:25 PM · Frameworks

May 13 2019

chinmoyr requested review of D21197: [KCoreDirLister] Remove assert in reinsert method.
May 13 2019, 6:47 PM · Frameworks

May 12 2019

chinmoyr requested review of D21155: Truncate long filname before creating a link.
May 12 2019, 1:51 PM · Frameworks
chinmoyr committed R318:d7555d8e1131: [Inline Rename] Move cursor to correct position on pressing Home and End (authored by chinmoyr).
[Inline Rename] Move cursor to correct position on pressing Home and End
May 12 2019, 11:12 AM
chinmoyr closed D21031: [Inline Rename] Move cursor to correct position on pressing Home and End.
May 12 2019, 11:12 AM · Dolphin

May 5 2019

chinmoyr requested review of D21031: [Inline Rename] Move cursor to correct position on pressing Home and End.
May 5 2019, 1:16 PM · Dolphin

Apr 5 2019

chinmoyr awarded D20266: Add new notification plasmoid a Like token.
Apr 5 2019, 3:52 PM · Plasma

Mar 26 2019

chinmoyr added a comment to D20062: [RFC] Add support for changing volume label..

The issue here is the placement of code. There are no API for changing any volume attributes so adding the changeLabel() method here feels awkward.

Mar 26 2019, 3:38 PM · Frameworks
chinmoyr requested review of D20062: [RFC] Add support for changing volume label..
Mar 26 2019, 1:53 PM · Frameworks

Mar 20 2019

chinmoyr committed R373:18c3a2ee6c84: Add blender thumbnailer (authored by chinmoyr).
Add blender thumbnailer
Mar 20 2019, 2:40 PM

Mar 17 2019

chinmoyr added a comment to D18845: authority: add support for passing details to polkit.

I would like this patch to land so +1 from me. But I am not familiar with this code so I can't give any meaningful feedback. Sorry.

Mar 17 2019, 3:19 PM
chinmoyr committed R373:2da545defff9: Add blender thumbnailer (authored by chinmoyr).
Add blender thumbnailer
Mar 17 2019, 9:12 AM
chinmoyr closed D19696: Add blender thumbnailer.
Mar 17 2019, 9:11 AM · Frameworks, Dolphin

Mar 15 2019

chinmoyr updated the diff for D19696: Add blender thumbnailer.

Removed unused headers.

Mar 15 2019, 5:45 PM · Frameworks, Dolphin

Mar 14 2019

chinmoyr updated the diff for D19696: Add blender thumbnailer.

Issues fixed.

Mar 14 2019, 2:34 AM · Frameworks, Dolphin
chinmoyr added inline comments to D19696: Add blender thumbnailer.
Mar 14 2019, 2:32 AM · Frameworks, Dolphin

Mar 13 2019

chinmoyr added inline comments to D19696: Add blender thumbnailer.
Mar 13 2019, 6:50 PM · Frameworks, Dolphin
chinmoyr updated the diff for D19696: Add blender thumbnailer.

Moved to kdegraphics-thumbnailer.
Got rid of operator>>(). Now reading the entire file-block header and extracting the length from raw bytes.
Used QByteArrays instead of static char arrays.
Fixed some minor issues.

Mar 13 2019, 6:49 PM · Frameworks, Dolphin

Mar 12 2019

kamathraghavendra awarded D19696: Add blender thumbnailer a Love token.
Mar 12 2019, 10:40 AM · Frameworks, Dolphin
chinmoyr updated the summary of D19696: Add blender thumbnailer.
Mar 12 2019, 1:06 AM · Frameworks, Dolphin
chinmoyr requested review of D19696: Add blender thumbnailer.
Mar 12 2019, 1:01 AM · Frameworks, Dolphin

Mar 10 2019

chinmoyr committed R241:7a79f1531480: [FileCopyJob] Clean up after cancelation of file copy operation (authored by chinmoyr).
[FileCopyJob] Clean up after cancelation of file copy operation
Mar 10 2019, 4:47 PM
chinmoyr closed D18904: [FileCopyJob] Clean up after cancelation of file copy operation.
Mar 10 2019, 4:47 PM · Frameworks
chinmoyr updated the diff for D18904: [FileCopyJob] Clean up after cancelation of file copy operation.

Update summary

Mar 10 2019, 4:46 PM · Frameworks
chinmoyr updated the diff for D18904: [FileCopyJob] Clean up after cancelation of file copy operation.

Changed m_bFileWriteInProgress -> m_bFileCopyInProgress

Mar 10 2019, 4:43 PM · Frameworks

Mar 9 2019

chinmoyr added a comment to D7571: Enable modifying root-owned files in Dolphin.

@chinmoyr Is this patch going to be replaced by another one, or is it not needed anymore?

Mar 9 2019, 4:19 PM · Dolphin
chinmoyr committed R241:ab042f6724ee: JobTest::safeOverwrite() still fails in CI build. Use old signal syntax to see… (authored by chinmoyr).
JobTest::safeOverwrite() still fails in CI build. Use old signal syntax to see…
Mar 9 2019, 11:15 AM
chinmoyr committed R241:6e0a820eb0ce: [jobtest] Use FileCopyJob to resolve signal (authored by chinmoyr).
[jobtest] Use FileCopyJob to resolve signal
Mar 9 2019, 9:43 AM
chinmoyr committed R241:fcabd1e2c2db: Pass local file path to KFileSystemType::fileSystemType(). (authored by chinmoyr).
Pass local file path to KFileSystemType::fileSystemType().
Mar 9 2019, 8:54 AM

Mar 7 2019

chinmoyr added a comment to D18904: [FileCopyJob] Clean up after cancelation of file copy operation.

There's free space check in CopyJob. And Dolphin still gives an error in the said situation. But if some application decides to directly use FileCopyJob then IMO the free space check should be at application's side. Anyway, I tried adding it here and it felt awkward to me.

Mar 7 2019, 6:17 PM · Frameworks
chinmoyr added a comment to D19585: [CopyJob] Report results after finishing copy.

Opened Dolphin, Ctrl+C on a file, Ctrl+V it into the same folder, let it sit at the "Override?" prompt until the job view in Plasma showed up. >Chose a different filename and continued.
[...]
The URL isn't updated in case of a rename but I bet it just needs a m_bURLDirty call somewhere in the conflict handler

Mar 7 2019, 5:46 PM · Frameworks

Mar 6 2019

chinmoyr committed R241:ef5b9c6991aa: Fix upper/lower case rename on case insensitive fs (authored by hoffmannrobert).
Fix upper/lower case rename on case insensitive fs
Mar 6 2019, 5:00 PM
chinmoyr closed D19422: Fix upper/lower case rename on case insensitive fs.
Mar 6 2019, 5:00 PM · Frameworks
chinmoyr updated the diff for D18904: [FileCopyJob] Clean up after cancelation of file copy operation.

Remove unrelated changes commited by mistake.

Mar 6 2019, 4:33 PM · Frameworks
chinmoyr updated the diff for D18904: [FileCopyJob] Clean up after cancelation of file copy operation.

Delete .part file when Overwrite flag is set.

Mar 6 2019, 4:22 PM · Frameworks
chinmoyr accepted D19422: Fix upper/lower case rename on case insensitive fs.
Mar 6 2019, 3:27 PM · Frameworks
chinmoyr abandoned D7571: Enable modifying root-owned files in Dolphin.
Mar 6 2019, 3:10 PM · Dolphin

Mar 3 2019

chinmoyr committed R241:613e54a35e5e: Don't use QStringLiteral::arg() in qCWarning() (authored by chinmoyr).
Don't use QStringLiteral::arg() in qCWarning()
Mar 3 2019, 9:04 AM
chinmoyr committed R241:f34c2cf0abf1: Make file overwrite a bit safer (authored by chinmoyr).
Make file overwrite a bit safer
Mar 3 2019, 8:56 AM
chinmoyr closed D19080: Make file overwrite a bit safer.
Mar 3 2019, 8:56 AM · Frameworks
chinmoyr updated the diff for D19080: Make file overwrite a bit safer.

Print strerror.

Mar 3 2019, 8:55 AM · Frameworks

Mar 2 2019

chinmoyr abandoned D3955: [Plasma folderview] Improve keyboard navigation.
Mar 2 2019, 5:26 PM · Plasma
chinmoyr committed R241:53bba36a78c4: Port to new connect syntax (authored by chinmoyr).
Port to new connect syntax
Mar 2 2019, 5:24 PM
chinmoyr closed D18455: Port to new connect syntax.
Mar 2 2019, 5:24 PM · Frameworks
chinmoyr updated the diff for D18455: Port to new connect syntax.

Restore sourceStated in CopyJob.

Mar 2 2019, 5:13 PM · Frameworks
chinmoyr requested changes to D19422: Fix upper/lower case rename on case insensitive fs.
Mar 2 2019, 4:53 PM · Frameworks

Feb 26 2019

chinmoyr planned changes to D19339: Add option to change drive label to places panel context menu.
Feb 26 2019, 2:05 PM · Dolphin