chinmoyr (Chinmoy Ranjan Pradhan)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 20 2016, 6:48 AM (95 w, 4 d)
Availability
Available

Recent Activity

Tue, Apr 17

chinmoyr abandoned D9966: [KIO] Fix issues with sharing of file descriptor.

Changes split in D12291 and D10411

Tue, Apr 17, 5:58 PM · Frameworks
chinmoyr updated the diff for D10411: Create socket file in user's runtime directory.

Rebased on D10409

Tue, Apr 17, 5:56 PM · Frameworks
chinmoyr updated the diff for D10409: In linux don't use abstract socket to share file descriptor.

Fix compilation error

Tue, Apr 17, 5:48 PM · Frameworks
chinmoyr updated the diff for D10409: In linux don't use abstract socket to share file descriptor.

Removed dependency on D10273
Rebased on master

Tue, Apr 17, 5:29 PM · Frameworks
chinmoyr requested review of D12291: Accept file descriptor only from root owned process.
Tue, Apr 17, 5:15 PM · Frameworks
chinmoyr abandoned D6199: Allow deleting from write-protected location in dolphin.

Not required due to design changes

Tue, Apr 17, 5:10 PM
chinmoyr abandoned D6834: [KNewFileMenu] Enable creating new files in read-only folders.

Not required due to design changes

Tue, Apr 17, 5:10 PM · Frameworks
chinmoyr added a comment to D12049: Obey umask rules when saving new file.

ping

Tue, Apr 17, 4:29 PM · Okular
chinmoyr added a comment to D12098: Resize content area to correct dimensions after zooming to Auto Fit.

ping

Tue, Apr 17, 4:29 PM · Okular

Tue, Apr 10

chinmoyr requested review of D12098: Resize content area to correct dimensions after zooming to Auto Fit.
Tue, Apr 10, 7:15 PM · Okular

Sun, Apr 8

chinmoyr updated the diff for D12049: Obey umask rules when saving new file.

Fix coding style

Sun, Apr 8, 6:07 PM · Okular
chinmoyr requested review of D12049: Obey umask rules when saving new file.
Sun, Apr 8, 6:04 PM · Okular
chinmoyr added a comment to D10141: Restore Persistence=session for the file ioslave kauth helper.

No objections from me - as long as the feature is disabled correctly, which it currently isn't.

See also https://phabricator.kde.org/T8075#136728.

Sun, Apr 8, 11:43 AM · Frameworks

Fri, Apr 6

chinmoyr committed R241:4de8abf55a90: Fix failing privilegejobtest (authored by chinmoyr).
Fix failing privilegejobtest
Fri, Apr 6, 3:29 PM
chinmoyr committed R241:65ab5e9a0c04: Temporarily disable installation of file ioslave's kauth helper and policy file (authored by chinmoyr).
Temporarily disable installation of file ioslave's kauth helper and policy file
Fri, Apr 6, 2:38 PM

Thu, Apr 5

chinmoyr added a comment to T8075: Fix security issues with KAuth support in KIO.

Not at all intentional. It just didn't crossed my mind. I suppose the cmake file needs to be patched to not build the helper?

Thu, Apr 5, 7:49 AM · Frameworks

Wed, Apr 4

chinmoyr accepted D10141: Restore Persistence=session for the file ioslave kauth helper.

I think it is now okay to push this diff as the issues pertaining to warning dialogs have been fixed. See T8075.

Wed, Apr 4, 4:51 AM · Frameworks
chinmoyr committed R303:bbf120b78773: Delete IdleSlave having temporary authorization (authored by chinmoyr).
Delete IdleSlave having temporary authorization
Wed, Apr 4, 4:33 AM
chinmoyr closed D10824: Delete IdleSlave having temporary authorization.
Wed, Apr 4, 4:33 AM · Frameworks
chinmoyr committed R241:d38b373c8b76: Store temporary authorization status in IdleSlave (authored by chinmoyr).
Store temporary authorization status in IdleSlave
Wed, Apr 4, 4:25 AM
chinmoyr closed D10822: Store temporary authorization status in IdleSlave.
Wed, Apr 4, 4:25 AM · Frameworks
chinmoyr committed R241:ea4329c36830: Send slave's polkit authorization status to the host (authored by chinmoyr).
Send slave's polkit authorization status to the host
Wed, Apr 4, 4:19 AM
chinmoyr closed D10820: Send slave's polkit authorization status to the host.
Wed, Apr 4, 4:19 AM · Frameworks
chinmoyr abandoned D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave.

Not required right now

Wed, Apr 4, 4:11 AM · Frameworks
chinmoyr abandoned D10636: Add support for revoking temporary authorization in KAuth.

Not required right now

Wed, Apr 4, 4:11 AM · Frameworks
chinmoyr abandoned D10638: [KAuth] Implement revokeTemporaryAuthorization in Polkit1Backend.

Not required right now or in near future.

Wed, Apr 4, 4:10 AM · Frameworks
chinmoyr committed R241:acccb63be487: Add a comment specifying not to use MSG_SLAVE_STATUS. (authored by chinmoyr).
Add a comment specifying not to use MSG_SLAVE_STATUS.
Wed, Apr 4, 4:08 AM
chinmoyr committed R241:004cb9da1913: Add MSG_SLAVE_STATUS_V2 to slave interface (authored by chinmoyr).
Add MSG_SLAVE_STATUS_V2 to slave interface
Wed, Apr 4, 3:51 AM
chinmoyr closed D11010: Add MSG_SLAVE_STATUS_V2 to slave interface.
Wed, Apr 4, 3:51 AM · Frameworks
chinmoyr committed R241:ec4df175be47: Store PolicyKit action which the slave is authorized to perform (authored by chinmoyr).
Store PolicyKit action which the slave is authorized to perform
Wed, Apr 4, 3:45 AM
chinmoyr closed D10818: Store PolicyKit action which the slave is authorized to perform.
Wed, Apr 4, 3:45 AM · Frameworks
chinmoyr updated the diff for D10818: Store PolicyKit action which the slave is authorized to perform.

Rearranged member vars

Wed, Apr 4, 3:41 AM · Frameworks

Tue, Apr 3

chinmoyr added inline comments to D10818: Store PolicyKit action which the slave is authorized to perform.
Tue, Apr 3, 6:10 PM · Frameworks
chinmoyr closed D10437: Update file ioslave's temporary authorization list.

Merged with D10818

Tue, Apr 3, 6:07 PM · Frameworks
chinmoyr updated the diff for D10818: Store PolicyKit action which the slave is authorized to perform.

Rebased on D10568
Merged D10437

Tue, Apr 3, 6:01 PM · Frameworks
chinmoyr committed R241:0e45fcffd182: Handle privilege operation confirmation prompts in SlaveBase (authored by chinmoyr).
Handle privilege operation confirmation prompts in SlaveBase
Tue, Apr 3, 5:26 PM
chinmoyr closed D10568: Handle privilege operation confirmation prompts in SlaveBase.
Tue, Apr 3, 5:26 PM · Frameworks
chinmoyr committed R241:8b34864135f8: Remove handling of privilege operation confirmation prompts from KIO::Job (authored by chinmoyr).
Remove handling of privilege operation confirmation prompts from KIO::Job
Tue, Apr 3, 5:11 PM
chinmoyr closed D10567: Remove handling of privilege operation confirmation prompts from KIO::Job.
Tue, Apr 3, 5:11 PM · Frameworks

Mon, Apr 2

chinmoyr added inline comments to D10568: Handle privilege operation confirmation prompts in SlaveBase.
Mon, Apr 2, 4:48 PM · Frameworks
chinmoyr updated the diff for D10568: Handle privilege operation confirmation prompts in SlaveBase.

Addressed David's issues.

Mon, Apr 2, 4:47 PM · Frameworks

Mon, Mar 26

chinmoyr updated the summary of D11725: [RFC] Show signature status as a popup.
Mon, Mar 26, 6:02 PM · Okular
chinmoyr added a dependency for D11725: [RFC] Show signature status as a popup: D11723: [RFC] Add FormFieldSignature to Okular's namespace.
Mon, Mar 26, 6:00 PM · Okular
chinmoyr added a dependent revision for D11723: [RFC] Add FormFieldSignature to Okular's namespace: D11725: [RFC] Show signature status as a popup.
Mon, Mar 26, 6:00 PM · Okular
chinmoyr requested review of D11725: [RFC] Show signature status as a popup.
Mon, Mar 26, 5:59 PM · Okular
chinmoyr requested review of D11723: [RFC] Add FormFieldSignature to Okular's namespace.
Mon, Mar 26, 5:44 PM · Okular

Fri, Mar 23

chinmoyr added a comment to D10824: Delete IdleSlave having temporary authorization.

David, what about this patch? It seems to me deleting the IdleSlave object is the only way to kill the ioslave from here.

Fri, Mar 23, 4:36 PM · Frameworks
chinmoyr updated the diff for D10820: Send slave's polkit authorization status to the host.

Added the missing assignment

Fri, Mar 23, 4:27 PM · Frameworks
chinmoyr updated the diff for D10820: Send slave's polkit authorization status to the host.
  1. Made method const.
  2. Increment iterator only if erasing failed.
Fri, Mar 23, 4:21 PM · Frameworks
chinmoyr added a comment to D7563: Add privilegeExecution field to file protocol description.

What's the status of this patch?

Fri, Mar 23, 4:08 PM

Mar 8 2018

chinmoyr closed D6709: Add support for sharing file descriptor between KIO slave and KAuth helper.

Bug fixed in D11011

Mar 8 2018, 3:52 PM · Frameworks

Mar 5 2018

chinmoyr added a comment to D10824: Delete IdleSlave having temporary authorization.

I haven't yet tried your patch (which btw involves the http ioslave right?) but I am quite sure that exit() is not called for file ioslave after interrupting the application. I have placed the debug statements inside exit() as well as before every exit() call and I am not seeing any output.

Mar 5 2018, 5:34 PM · Frameworks

Mar 4 2018

chinmoyr added a comment to D10824: Delete IdleSlave having temporary authorization.

Neither SlaveBase::exit nor Slave::kill is called. I also commented the line in ConnectionBackend which removes the socket file but even then the slave process terminated.
At this point I have no idea why is this working.

Mar 4 2018, 2:38 PM · Frameworks
chinmoyr added a comment to D10824: Delete IdleSlave having temporary authorization.

Actually deleteLater() does kill the slave. I placed a qDebug statement in there and immediately after the message I am getting

kdeinit5: PID $slave_pid terminated.
Mar 4 2018, 12:35 PM · Frameworks
chinmoyr updated the diff for D10822: Store temporary authorization status in IdleSlave.

added the required comment

Mar 4 2018, 12:15 PM · Frameworks
chinmoyr added a comment to D10409: In linux don't use abstract socket to share file descriptor.

Sorry, I meant D10411.

Mar 4 2018, 12:12 PM · Frameworks
chinmoyr added a comment to D10409: In linux don't use abstract socket to share file descriptor.

@ossi I think the changes in file_unix.cpp from D9966 also belong here(?)

Mar 4 2018, 12:04 PM · Frameworks
chinmoyr updated the diff for D10822: Store temporary authorization status in IdleSlave.

Added support for MSG_SLAVE_STATUS

Mar 4 2018, 12:00 PM · Frameworks
chinmoyr added inline comments to D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver.
Mar 4 2018, 11:42 AM · Frameworks
chinmoyr added inline comments to D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver.
Mar 4 2018, 11:33 AM · Frameworks
chinmoyr added inline comments to D10824: Delete IdleSlave having temporary authorization.
Mar 4 2018, 11:09 AM · Frameworks
chinmoyr committed R241:2a2a8a0fe5ab: Do not assume layout of msghdr and iovec structure (authored by chinmoyr).
Do not assume layout of msghdr and iovec structure
Mar 4 2018, 10:57 AM
chinmoyr closed D11011: Do not assume layout of msghdr and iovec structure.
Mar 4 2018, 10:57 AM · Frameworks
chinmoyr added inline comments to D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave.
Mar 4 2018, 10:53 AM · Frameworks
chinmoyr updated the diff for D11011: Do not assume layout of msghdr and iovec structure.

used &

Mar 4 2018, 10:37 AM · Frameworks
chinmoyr added a comment to D11011: Do not assume layout of msghdr and iovec structure.

I can confirm that this patch does fix the build on musl. Thank you!

Mar 4 2018, 8:21 AM · Frameworks
chinmoyr requested review of D11011: Do not assume layout of msghdr and iovec structure.
Mar 4 2018, 7:27 AM · Frameworks
chinmoyr updated the diff for D10822: Store temporary authorization status in IdleSlave.

Used MSG_SLAVE_STATUS_V2

Mar 4 2018, 6:38 AM · Frameworks
chinmoyr added a dependency for D10820: Send slave's polkit authorization status to the host: D11010: Add MSG_SLAVE_STATUS_V2 to slave interface.
Mar 4 2018, 6:23 AM · Frameworks
chinmoyr added a dependent revision for D11010: Add MSG_SLAVE_STATUS_V2 to slave interface: D10820: Send slave's polkit authorization status to the host.
Mar 4 2018, 6:23 AM · Frameworks
chinmoyr updated the diff for D10820: Send slave's polkit authorization status to the host.

Added method updateTempAuthStatus() to take care of cleaning.
Rebased on D11010

Mar 4 2018, 6:21 AM · Frameworks
chinmoyr requested review of D11010: Add MSG_SLAVE_STATUS_V2 to slave interface.
Mar 4 2018, 5:19 AM · Frameworks
chinmoyr updated the diff for D10567: Remove handling of privilege operation confirmation prompts from KIO::Job.

fix issue with variable declaration

Mar 4 2018, 4:10 AM · Frameworks
chinmoyr updated the diff for D10818: Store PolicyKit action which the slave is authorized to perform.

m_TempAuth -> m_temAuths

Mar 4 2018, 3:58 AM · Frameworks
chinmoyr updated the diff for D10824: Delete IdleSlave having temporary authorization.

Used deleteLater()

Mar 4 2018, 3:40 AM · Frameworks

Feb 25 2018

chinmoyr edited dependencies for D10437: Update file ioslave's temporary authorization list, added: 1; removed: 1.
Feb 25 2018, 12:01 PM · Frameworks
chinmoyr added a dependent revision for D10818: Store PolicyKit action which the slave is authorized to perform: D10437: Update file ioslave's temporary authorization list.
Feb 25 2018, 12:01 PM · Frameworks
chinmoyr removed a dependent revision for D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave: D10437: Update file ioslave's temporary authorization list.
Feb 25 2018, 12:01 PM · Frameworks
chinmoyr added a dependent revision for D10568: Handle privilege operation confirmation prompts in SlaveBase: D10818: Store PolicyKit action which the slave is authorized to perform.
Feb 25 2018, 11:59 AM · Frameworks
chinmoyr added a dependency for D10818: Store PolicyKit action which the slave is authorized to perform: D10568: Handle privilege operation confirmation prompts in SlaveBase.
Feb 25 2018, 11:59 AM · Frameworks
chinmoyr removed a dependency for D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave: D10568: Handle privilege operation confirmation prompts in SlaveBase.
Feb 25 2018, 11:58 AM · Frameworks
chinmoyr removed a dependent revision for D10568: Handle privilege operation confirmation prompts in SlaveBase: D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave.
Feb 25 2018, 11:58 AM · Frameworks
chinmoyr added a dependent revision for D10820: Send slave's polkit authorization status to the host: D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave.
Feb 25 2018, 11:56 AM · Frameworks
chinmoyr added a dependency for D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave: D10820: Send slave's polkit authorization status to the host.
Feb 25 2018, 11:56 AM · Frameworks
chinmoyr updated the summary of D10820: Send slave's polkit authorization status to the host.
Feb 25 2018, 11:52 AM · Frameworks
chinmoyr added a dependent revision for D10818: Store PolicyKit action which the slave is authorized to perform: D10820: Send slave's polkit authorization status to the host.
Feb 25 2018, 11:52 AM · Frameworks
chinmoyr added a dependent revision for D10820: Send slave's polkit authorization status to the host: D10822: Store temporary authorization status in IdleSlave.
Feb 25 2018, 11:49 AM · Frameworks
chinmoyr updated the summary of D10822: Store temporary authorization status in IdleSlave.
Feb 25 2018, 11:49 AM · Frameworks
chinmoyr triaged T8075: Fix security issues with KAuth support in KIO as High priority.
Feb 25 2018, 11:44 AM · Frameworks
chinmoyr updated the diff for D10437: Update file ioslave's temporary authorization list.

Updated function name.
Updated title and summary.
With this it is the third time I am completely changing the title and summary. When will it be too much? Or should I create a new patch everytime there's a change in approach?

Feb 25 2018, 11:28 AM · Frameworks
chinmoyr requested review of D10824: Delete IdleSlave having temporary authorization.
Feb 25 2018, 10:55 AM · Frameworks
chinmoyr added a dependent revision for D10822: Store temporary authorization status in IdleSlave: D10824: Delete IdleSlave having temporary authorization.
Feb 25 2018, 10:55 AM · Frameworks
chinmoyr requested review of D10822: Store temporary authorization status in IdleSlave.
Feb 25 2018, 10:49 AM · Frameworks
chinmoyr updated the diff for D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave.

Removed other files which were included in previous commit by mistake

Feb 25 2018, 10:41 AM · Frameworks
chinmoyr updated the diff for D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave.
  1. Split this diff into three parts D108{18,20} and this.
  2. Updated summary and title.
Feb 25 2018, 10:39 AM · Frameworks
chinmoyr requested review of D10820: Send slave's polkit authorization status to the host.
Feb 25 2018, 10:24 AM · Frameworks
chinmoyr requested review of D10818: Store PolicyKit action which the slave is authorized to perform.
Feb 25 2018, 9:41 AM · Frameworks

Feb 24 2018

chinmoyr added a comment to T8054: Change DocumentID.

@adridg: To be sure: using DocId = quint32; is a typo? You meant using DocId = quint64; instead?

Feb 24 2018, 12:50 AM · Baloo

Feb 18 2018

chinmoyr updated the summary of D10568: Handle privilege operation confirmation prompts in SlaveBase.
Feb 18 2018, 5:13 PM · Frameworks
chinmoyr added a dependent revision for D10567: Remove handling of privilege operation confirmation prompts from KIO::Job: D10568: Handle privilege operation confirmation prompts in SlaveBase.
Feb 18 2018, 5:13 PM · Frameworks