chinmoyr (Chinmoy Ranjan Pradhan)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jun 20 2016, 6:48 AM (139 w, 1 d)
Availability
Available

Recent Activity

Yesterday

chinmoyr updated the diff for D19080: [WIP] Make file overwrite a bit safer.

Update.

Mon, Feb 18, 1:50 AM · Frameworks

Sat, Feb 16

chinmoyr updated the diff for D19080: [WIP] Make file overwrite a bit safer.

Skip unit test on windows.

Sat, Feb 16, 4:35 PM · Frameworks
chinmoyr updated the diff for D19080: [WIP] Make file overwrite a bit safer.

Removed warning message.
Removed arg().
Added test cases.
Used QFile::resize().

Sat, Feb 16, 4:23 PM · Frameworks
chinmoyr added a dependency for D18904: [FileCopyJob] Clean up after file copy operation is cancelled: D19080: [WIP] Make file overwrite a bit safer.
Sat, Feb 16, 1:35 PM · Frameworks
chinmoyr added a dependent revision for D19080: [WIP] Make file overwrite a bit safer: D18904: [FileCopyJob] Clean up after file copy operation is cancelled.
Sat, Feb 16, 1:35 PM · Frameworks
chinmoyr requested review of D19080: [WIP] Make file overwrite a bit safer.
Sat, Feb 16, 1:33 PM · Frameworks

Mon, Feb 11

chinmoyr added inline comments to D18915: Fix batchrename changing extension to lower case.
Mon, Feb 11, 4:19 AM · Frameworks
chinmoyr updated the diff for D18904: [FileCopyJob] Clean up after file copy operation is cancelled.

Fixed all issues.
Added test case for suspend.

Mon, Feb 11, 2:17 AM · Frameworks
chinmoyr added a comment to D18915: Fix batchrename changing extension to lower case.

@cfoster Thanks for the patch :)

Mon, Feb 11, 1:48 AM · Frameworks
chinmoyr added a comment to D18904: [FileCopyJob] Clean up after file copy operation is cancelled.

@ngraham The destination file is corrupted as soon as the user clicks overwrite. This patch deletes that file. Is that file supposed to be preserved (to prevent user panic)? My suggestion is to append ".part" or some similar extension when an overwrite starts, so the user knows that there data is gone.

Mon, Feb 11, 1:32 AM · Frameworks

Sun, Feb 10

chinmoyr requested review of D18904: [FileCopyJob] Clean up after file copy operation is cancelled.
Sun, Feb 10, 5:43 PM · Frameworks

Tue, Feb 5

chinmoyr accepted D18632: Port away from deprecated KIO::UDSEntry::insert().

LGTM

Tue, Feb 5, 4:32 PM · Plasma
chinmoyr added inline comments to D18632: Port away from deprecated KIO::UDSEntry::insert().
Tue, Feb 5, 3:53 PM · Plasma
chinmoyr added inline comments to D18632: Port away from deprecated KIO::UDSEntry::insert().
Tue, Feb 5, 3:46 PM · Plasma
chinmoyr accepted D18641: [kio_applications] Fix last dir item being shown twice.
Tue, Feb 5, 3:31 PM · Plasma

Sun, Feb 3

chinmoyr added a reviewer for D18699: [KIO/RenameDialog] Add new apply behaviour: VDG.
Sun, Feb 3, 4:16 PM · Frameworks
chinmoyr updated the diff for D18699: [KIO/RenameDialog] Add new apply behaviour.

Add bug id.
Remove old code.

Sun, Feb 3, 3:59 PM · Frameworks
chinmoyr requested review of D18699: [KIO/RenameDialog] Add new apply behaviour.
Sun, Feb 3, 3:53 PM · Frameworks

Tue, Jan 29

chinmoyr added a comment to T8075: Fix security issues with KAuth support in KIO.

What needs to be done to push this forward? Do you need any help?

Tue, Jan 29, 6:42 PM · Frameworks
chinmoyr added a comment to D17737: [CopyJob] Create clones in btrf/xfs mount.

@bruns ping

Tue, Jan 29, 12:47 AM · Frameworks
chinmoyr added a comment to T8075: Fix security issues with KAuth support in KIO.

@kpiwowarski Still WIP :(

Tue, Jan 29, 12:45 AM · Frameworks

Tue, Jan 22

chinmoyr requested review of D18455: Port to new connect syntax.
Tue, Jan 22, 1:42 PM · Frameworks

Jan 19 2019

chinmoyr added a comment to T8704: Verifying signatures of pdf files.

@aacid Add an action to "Tools" menu for accessing the signature panel. Optionally add an action to verify all signatures but I feel it's redundant due of the message widget.

Jan 19 2019, 1:05 PM · Okular
chinmoyr abandoned D13114: Add DocumentRevision to Okular.

@aacid Sorry for late reply. This got lost in my inbox.

Jan 19 2019, 12:59 PM · Okular

Jan 15 2019

chinmoyr added a comment to D18263: [CopyJob] Provide more descriptive notification header.

They emit a generic message. A descriptive message can only generated from within job.

Jan 15 2019, 2:52 PM · Frameworks
chinmoyr requested review of D18263: [CopyJob] Provide more descriptive notification header.
Jan 15 2019, 1:46 PM · Frameworks

Jan 14 2019

chinmoyr added inline comments to D17528: Refactor SlaveInterface::calcSpeed.
Jan 14 2019, 1:47 PM · Frameworks

Jan 11 2019

l10n daemon script <scripty@kde.org> committed R241:8ba03c4166c5: [KNewFileMenu] Don't emit fileCreated when creating a directory (authored by chinmoyr).
[KNewFileMenu] Don't emit fileCreated when creating a directory
Jan 11 2019, 9:07 PM
chinmoyr committed R241:28dacfe07375: [KNewFileMenu] Don't emit fileCreated when creating a directory (authored by chinmoyr).
[KNewFileMenu] Don't emit fileCreated when creating a directory
Jan 11 2019, 4:37 PM
chinmoyr closed D18187: [KNewFileMenu] Don't emit fileCreated when creating a directory.
Jan 11 2019, 4:37 PM · Frameworks
chinmoyr requested review of D18187: [KNewFileMenu] Don't emit fileCreated when creating a directory.
Jan 11 2019, 4:15 PM · Frameworks
chinmoyr accepted D18158: Fix elapsed time check.
Jan 11 2019, 3:29 PM · Frameworks

Jan 10 2019

chinmoyr added inline comments to D17528: Refactor SlaveInterface::calcSpeed.
Jan 10 2019, 3:40 PM · Frameworks

Jan 7 2019

chinmoyr updated the diff for D17737: [CopyJob] Create clones in btrf/xfs mount.

Scraped everything but the changes from file_unix.cpp

Jan 7 2019, 7:53 AM · Frameworks

Dec 23 2018

chinmoyr added a comment to D17737: [CopyJob] Create clones in btrf/xfs mount.

I think it would be much simpler if you just tried to do the the FICLONE iotctl in the job, without any prior checking:

  • no possibility for races
  • less syscals
  • less code
Dec 23 2018, 3:41 PM · Frameworks

Dec 22 2018

chinmoyr requested review of D17737: [CopyJob] Create clones in btrf/xfs mount.
Dec 22 2018, 4:16 PM · Frameworks
chinmoyr committed R241:4e2a815b9a10: Refactor SlaveInterface::calcSpeed (authored by chinmoyr).
Refactor SlaveInterface::calcSpeed
Dec 22 2018, 12:23 PM
chinmoyr closed D17528: Refactor SlaveInterface::calcSpeed.
Dec 22 2018, 12:23 PM · Frameworks

Dec 21 2018

chinmoyr updated the diff for D17528: Refactor SlaveInterface::calcSpeed.

update

Dec 21 2018, 12:31 PM · Frameworks

Dec 17 2018

chinmoyr updated the diff for D17528: Refactor SlaveInterface::calcSpeed.

Removed vector initialization.
Increased vector capacity in constructor.
Appended {0,0} at first.
Stored time and size before appending to prevent extraction.

Dec 17 2018, 5:12 PM · Frameworks
chinmoyr added inline comments to D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable.
Dec 17 2018, 4:04 PM · Frameworks
chinmoyr added inline comments to D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable.
Dec 17 2018, 3:38 PM · Frameworks

Dec 14 2018

chinmoyr updated the diff for D17528: Refactor SlaveInterface::calcSpeed.

Used a structure to group size and time.

Dec 14 2018, 2:51 PM · Frameworks

Dec 13 2018

chinmoyr updated the diff for D17528: Refactor SlaveInterface::calcSpeed.

Used QVector

Dec 13 2018, 2:28 PM · Frameworks
chinmoyr added a comment to D17528: Refactor SlaveInterface::calcSpeed.

I'm surprised, how can a QLinkedList (with nodes allocated all over the memory) be better than a static array (which fits into the same memory cache) ?

Dec 13 2018, 2:03 PM · Frameworks

Dec 12 2018

chinmoyr requested review of D17528: Refactor SlaveInterface::calcSpeed.
Dec 12 2018, 9:21 AM · Frameworks

Dec 11 2018

chinmoyr committed R241:29008f8ab520: SlaveInterface: Stop speed_timer after a job is killed. (authored by chinmoyr).
SlaveInterface: Stop speed_timer after a job is killed.
Dec 11 2018, 4:53 PM
chinmoyr closed D17502: Store timestamp as UTC.
Dec 11 2018, 1:27 PM · Frameworks
chinmoyr committed R241:1c3ecda86679: Store timestamp as UTC (authored by chinmoyr).
Store timestamp as UTC
Dec 11 2018, 1:27 PM
chinmoyr requested review of D17502: Store timestamp as UTC.
Dec 11 2018, 12:34 PM · Frameworks

Aug 14 2018

chinmoyr updated the task description for T8704: Verifying signatures of pdf files.
Aug 14 2018, 2:46 PM · Okular
chinmoyr reopened D13484: Show signature validation summary as popup.
Aug 14 2018, 2:42 PM · Okular
chinmoyr reopened D13366: Add SignatureEdit widget for FormFieldSignature.
Aug 14 2018, 2:41 PM · Okular
chinmoyr reopened D14748: Add signature properties dialog.
Aug 14 2018, 2:41 PM · Okular
chinmoyr reopened D14734: Add revision viewer.
Aug 14 2018, 2:41 PM · Okular
chinmoyr reopened D14696: Add certificate viewer.
Aug 14 2018, 2:40 PM · Okular
chinmoyr reopened D14656: Add utitlity functions for use in digital signature verification.
Aug 14 2018, 2:40 PM · Okular
chinmoyr reopened D12901: Add unit test for SignatureFormField.
Aug 14 2018, 2:40 PM · Okular
chinmoyr reopened D14655: Reimplement signature form field and related utility classes in poppler generator.
Aug 14 2018, 2:40 PM · Okular
chinmoyr reopened D14654: Add API for signature form field, and other helper classes.
Aug 14 2018, 2:39 PM · Okular
chinmoyr reopened D14816: Add signature panel.
Aug 14 2018, 2:39 PM · Okular
chinmoyr committed R223:0d2a98b98de7: Fix compilation issues (authored by chinmoyr).
Fix compilation issues
Aug 14 2018, 2:37 PM
chinmoyr committed R223:aed6df314baa: Show signature validation summary as popup (authored by chinmoyr).
Show signature validation summary as popup
Aug 14 2018, 2:37 PM
chinmoyr closed D13484: Show signature validation summary as popup.
Aug 14 2018, 2:37 PM · Okular
chinmoyr committed R223:b61c57dd2864: Add signature panel (authored by chinmoyr).
Add signature panel
Aug 14 2018, 2:37 PM
chinmoyr committed R223:536095bd9700: Add SignatureEdit widget for FormFieldSignature (authored by chinmoyr).
Add SignatureEdit widget for FormFieldSignature
Aug 14 2018, 2:37 PM
chinmoyr closed D13366: Add SignatureEdit widget for FormFieldSignature.
Aug 14 2018, 2:37 PM · Okular
chinmoyr committed R223:f903370fbc55: Add signature properties dialog (authored by chinmoyr).
Add signature properties dialog
Aug 14 2018, 2:37 PM
chinmoyr committed R223:5f0d186414ee: Add revision viewer (authored by chinmoyr).
Add revision viewer
Aug 14 2018, 2:37 PM
chinmoyr committed R223:722e0348538f: Add certificate viewer (authored by chinmoyr).
Add certificate viewer
Aug 14 2018, 2:37 PM
chinmoyr committed R223:741988f99127: Add utitlity functions for use in digital signature verification (authored by chinmoyr).
Add utitlity functions for use in digital signature verification
Aug 14 2018, 2:37 PM
chinmoyr committed R223:ed93135e949f: Add unit test for SignatureFormField (authored by chinmoyr).
Add unit test for SignatureFormField
Aug 14 2018, 2:37 PM
chinmoyr committed R223:ca557c9117fe: Reimplement signature form field and related utility classes in poppler… (authored by chinmoyr).
Reimplement signature form field and related utility classes in poppler…
Aug 14 2018, 2:37 PM
chinmoyr committed R223:0696f4cb55a7: Add API for signature form field, and other helper classes (authored by chinmoyr).
Add API for signature form field, and other helper classes
Aug 14 2018, 2:37 PM
chinmoyr closed D14654: Add API for signature form field, and other helper classes.
Aug 14 2018, 2:37 PM · Okular
chinmoyr committed R223:bb1dbebb4f68: Add signature panel (authored by chinmoyr).
Add signature panel
Aug 14 2018, 2:31 PM
chinmoyr committed R223:f235e651c2aa: Show signature validation summary as popup (authored by chinmoyr).
Show signature validation summary as popup
Aug 14 2018, 2:31 PM
chinmoyr closed D14816: Add signature panel.
Aug 14 2018, 2:31 PM · Okular
chinmoyr committed R223:2c0fcaf8a22f: Add SignatureEdit widget for FormFieldSignature (authored by chinmoyr).
Add SignatureEdit widget for FormFieldSignature
Aug 14 2018, 2:31 PM
chinmoyr committed R223:bf7d548a4872: Add signature properties dialog (authored by chinmoyr).
Add signature properties dialog
Aug 14 2018, 2:31 PM
chinmoyr committed R223:b7a841e8eed1: Add revision viewer (authored by chinmoyr).
Add revision viewer
Aug 14 2018, 2:31 PM
chinmoyr closed D14748: Add signature properties dialog.
Aug 14 2018, 2:31 PM · Okular
chinmoyr closed D14734: Add revision viewer.
Aug 14 2018, 2:31 PM · Okular
chinmoyr committed R223:35965f914548: Add certificate viewer (authored by chinmoyr).
Add certificate viewer
Aug 14 2018, 2:31 PM
chinmoyr closed D14696: Add certificate viewer.
Aug 14 2018, 2:31 PM · Okular
chinmoyr committed R223:53e095439724: Add utitlity functions for use in digital signature verification (authored by chinmoyr).
Add utitlity functions for use in digital signature verification
Aug 14 2018, 2:31 PM
chinmoyr committed R223:29cea9796ca7: Add unit test for SignatureFormField (authored by chinmoyr).
Add unit test for SignatureFormField
Aug 14 2018, 2:31 PM
chinmoyr closed D14656: Add utitlity functions for use in digital signature verification.
Aug 14 2018, 2:31 PM · Okular
chinmoyr closed D12901: Add unit test for SignatureFormField.
Aug 14 2018, 2:31 PM · Okular
chinmoyr closed D14655: Reimplement signature form field and related utility classes in poppler generator.
Aug 14 2018, 2:31 PM · Okular
chinmoyr committed R223:d6e0577a0141: Reimplement signature form field and related utility classes in poppler… (authored by chinmoyr).
Reimplement signature form field and related utility classes in poppler…
Aug 14 2018, 2:31 PM
chinmoyr added a reverting change for R223:abcf0eb3ddf3: Implement SignatureInfo and CertificateInfo in poppler generator: R223:03abf14a89b2: Revert "Implement SignatureInfo and CertificateInfo in poppler generator".
Aug 14 2018, 2:31 PM
chinmoyr committed R223:03abf14a89b2: Revert "Implement SignatureInfo and CertificateInfo in poppler generator" (authored by chinmoyr).
Revert "Implement SignatureInfo and CertificateInfo in poppler generator"
Aug 14 2018, 2:31 PM
chinmoyr added a reverting change for R223:8c888675ae7b: Implement FormFieldSignature in poppler generator: R223:61dc1845bc28: Revert "Implement FormFieldSignature in poppler generator".
Aug 14 2018, 2:31 PM
chinmoyr committed R223:61dc1845bc28: Revert "Implement FormFieldSignature in poppler generator" (authored by chinmoyr).
Revert "Implement FormFieldSignature in poppler generator"
Aug 14 2018, 2:31 PM
chinmoyr committed R223:b0753c5ba826: Revert "Add SignatureSummaryDialog and SignaturePropertiesDialog to okular ui" (authored by chinmoyr).
Revert "Add SignatureSummaryDialog and SignaturePropertiesDialog to okular ui"
Aug 14 2018, 2:31 PM
chinmoyr added a reverting change for R223:02f885d3d159: Add SignatureSummaryDialog and SignaturePropertiesDialog to okular ui: R223:b0753c5ba826: Revert "Add SignatureSummaryDialog and SignaturePropertiesDialog to okular ui".
Aug 14 2018, 2:31 PM
chinmoyr added a reverting change for R223:7856035adf18: Add SignatureEdit widget to enable interaction with signature form field.: R223:e49efc74d00f: Revert "Add SignatureEdit widget to enable interaction with signature form….
Aug 14 2018, 2:31 PM
chinmoyr committed R223:e49efc74d00f: Revert "Add SignatureEdit widget to enable interaction with signature form… (authored by chinmoyr).
Revert "Add SignatureEdit widget to enable interaction with signature form…
Aug 14 2018, 2:31 PM
chinmoyr committed R223:ce50afa865f9: Revert "Show signature summary in a popup" (authored by chinmoyr).
Revert "Show signature summary in a popup"
Aug 14 2018, 2:31 PM