bshah (Bhushan Shah)
Plasma Mobile Developer

Projects (20)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:17 PM (157 w, 6 d)
Availability
Available

Recent Activity

Yesterday

bshah committed R29:8610cdcef053: optimize the dockerfile (authored by bshah).
optimize the dockerfile
Tue, Apr 24, 5:58 PM
bshah committed R29:007d06600163: Remove old stuff (authored by bshah).
Remove old stuff
Tue, Apr 24, 5:58 PM
bshah committed R29:91aeb4bf21ab: Changes for next version (authored by bshah).
Changes for next version
Tue, Apr 24, 4:56 PM
bshah committed R30:4e041b2e7ec4: create fakepkg (authored by bshah).
create fakepkg
Tue, Apr 24, 4:06 PM

Fri, Mar 30

bshah updated the task description for T8367: ksplashqml excessive CPU usage.
Fri, Mar 30, 11:32 AM · KDE Neon : bionic
bshah created KDE Neon : bionic.
Fri, Mar 30, 10:55 AM

Wed, Mar 28

bshah changed the edit policy for KDE Human Interface Guidelines.
Wed, Mar 28, 8:25 AM

Mon, Mar 26

bshah committed R290:f3619363ed63: regenerate qrc on every build (authored by bshah).
regenerate qrc on every build
Mon, Mar 26, 2:08 PM
bshah closed D11717: regenerate qrc on every build.
Mon, Mar 26, 2:08 PM · Frameworks
bshah requested review of D11717: regenerate qrc on every build.
Mon, Mar 26, 1:42 PM · Frameworks
bshah committed R290:0a26d53a0f86: Don't create dependency loop (authored by bshah).
Don't create dependency loop
Mon, Mar 26, 9:08 AM
bshah closed D11709: Don't create dependency loop.
Mon, Mar 26, 9:08 AM · Frameworks
bshah requested review of D11709: Don't create dependency loop.
Mon, Mar 26, 8:57 AM · Frameworks
bshah added a comment to D1230: GBM remote access support for KWin.

I'll take a look once I'm home

Mon, Mar 26, 7:29 AM · Plasma on Wayland, KWin
bshah committed R108:5c78fbfdcc75: Include errno.h (authored by bshah).
Include errno.h
Mon, Mar 26, 7:07 AM

Mar 25 2018

bshah added a comment to D11642: Fix the rcc binary package generation.

opened PR for KDE_INSTALL_DATADIR : https://phabricator.kde.org/D11675

Mar 25 2018, 11:14 AM · Frameworks
bshah requested review of D11675: use KDE_INSTALL_DATADIR instead of FULL_DATADIR.
Mar 25 2018, 11:13 AM · Frameworks
bshah committed R290:b69866996e7e: Fix the rcc binary package generation (authored by bshah).
Fix the rcc binary package generation
Mar 25 2018, 11:10 AM
bshah closed D11642: Fix the rcc binary package generation.
Mar 25 2018, 11:10 AM · Frameworks
bshah added inline comments to D11642: Fix the rcc binary package generation.
Mar 25 2018, 11:09 AM · Frameworks

Mar 24 2018

bshah updated the diff for D11642: Fix the rcc binary package generation.
  • regnerate rcc file on every build
  • add comment in add_custom_target for logging in build log
  • Fix the path in the qrc file which broke in previous attempt, plasma/plasmoids/<component>/ v/s plasma/plasmoids//
Mar 24 2018, 5:21 PM · Frameworks
bshah added a comment to D11642: Fix the rcc binary package generation.
In D11642#232866, @apol wrote:

See older reviews. This won't work because cmake doesn't know when one of the contained files is modified so rcc files are never regenerated properly.

Mar 24 2018, 2:05 PM · Frameworks
bshah added reviewers for D11642: Fix the rcc binary package generation: mart, davidedmundson, apol.
Mar 24 2018, 12:19 PM · Frameworks
bshah updated the diff for D11642: Fix the rcc binary package generation.

update commit message

Mar 24 2018, 12:19 PM · Frameworks
bshah requested review of D11642: Fix the rcc binary package generation.
Mar 24 2018, 12:17 PM · Frameworks

Mar 21 2018

bshah committed R120:605bd1a9ba54: Use dbus-run-session instead of dbus-launch --exit-with-session (authored by fvogt).
Use dbus-run-session instead of dbus-launch --exit-with-session
Mar 21 2018, 10:33 AM

Mar 20 2018

bshah added a comment to D11498: Install firefox's native messaging host to LIBDIR.

See : https://wiki.mozilla.org/WebExtensions/Native_Messaging#Host_Manifests

Mar 20 2018, 1:52 PM · Plasma
bshah added a comment to D11498: Install firefox's native messaging host to LIBDIR.

That's interesting... because umm, firefox specs says DATADIR should work™

Mar 20 2018, 1:51 PM · Plasma

Mar 14 2018

bshah added reviewers for D11331: add gaming_input devices and others to Battery: broulik, Plasma.
Mar 14 2018, 2:27 PM · Frameworks
bshah changed the edit policy for Websites: WKO Migration.
Mar 14 2018, 10:45 AM
bshah created Websites: general.
Mar 14 2018, 10:43 AM
bshah committed R856:0d92aba10fd9: Respect the custom install prefix (authored by bshah).
Respect the custom install prefix
Mar 14 2018, 7:32 AM

Mar 6 2018

bshah committed R108:90762ade86e2: Merge branch 'Plasma/5.12' (authored by bshah).
Merge branch 'Plasma/5.12'
Mar 6 2018, 3:58 AM
bshah committed R108:3fa287280b04: Fix the build on armhf/aarch64 (authored by bshah).
Fix the build on armhf/aarch64
Mar 6 2018, 3:58 AM
bshah closed D10762: Fix the build on armhf/aarch64.
Mar 6 2018, 3:57 AM · KWin
bshah committed R365:8611b56346b8: Add /usr/share and /etc/xdg to XDG_* variables (authored by bshah).
Add /usr/share and /etc/xdg to XDG_* variables
Mar 6 2018, 3:51 AM
bshah closed D11039: Add /usr/share and /etc/xdg to XDG_* variables.
Mar 6 2018, 3:51 AM

Mar 5 2018

bshah added a comment to D10677: add requirements.txt.

The requirement.txt I've on server which hosts hig.kde.org

Mar 5 2018, 8:09 AM · KDE Human Interface Guidelines
bshah updated the diff for D10762: Fix the build on armhf/aarch64.

updated to use single header

Mar 5 2018, 5:49 AM · KWin
bshah requested review of D11039: Add /usr/share and /etc/xdg to XDG_* variables.
Mar 5 2018, 5:31 AM

Mar 2 2018

bshah updated the diff for D10762: Fix the build on armhf/aarch64.
  • In QPA move duplicated code in the seperate header
  • Add comment on why kwinglutils_funcs.h is included
Mar 2 2018, 6:41 AM · KWin

Feb 23 2018

bshah updated the diff for D10762: Fix the build on armhf/aarch64.

cover all the cases of epoxy

Feb 23 2018, 8:07 AM · KWin
bshah planned changes to D10762: Fix the build on armhf/aarch64.

Appearantly this doesn't fix all the issues.

Feb 23 2018, 6:57 AM · KWin
bshah requested review of D10762: Fix the build on armhf/aarch64.
Feb 23 2018, 6:47 AM · KWin
bshah accepted D10294: Init the icon in ShellClient::init.
Feb 23 2018, 5:28 AM · KWin
bshah committed R296:a442b96756c0: Fix the build failure on armhf/aarch64 (authored by bshah).
Fix the build failure on armhf/aarch64
Feb 23 2018, 5:25 AM

Feb 22 2018

bshah committed R982:a83e50e7fe2a: use nmcli command (authored by bshah).
use nmcli command
Feb 22 2018, 8:32 AM

Feb 19 2018

bshah created T8008: Notification area improvements.
Feb 19 2018, 9:20 AM · Plasma: Mobile

Feb 17 2018

bshah committed R119:b8cbe13b0c79: Merge branch 'Plasma/5.12' (authored by bshah).
Merge branch 'Plasma/5.12'
Feb 17 2018, 11:45 AM
bshah added a reverting change for R119:502e8dc1080f: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version: R119:9a05da7cced3: Revert "[lookandfeel kcm] Do not declare plugin in lookandfeeltool code version".
Feb 17 2018, 11:45 AM
bshah committed R119:9a05da7cced3: Revert "[lookandfeel kcm] Do not declare plugin in lookandfeeltool code version" (authored by bshah).
Revert "[lookandfeel kcm] Do not declare plugin in lookandfeeltool code version"
Feb 17 2018, 11:45 AM
bshah added a comment to D10485: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version.

Unfortunately we will have to revert this it seems,

Feb 17 2018, 11:31 AM · Plasma
bshah created T7991: [pmiso] Strange behavior with top panel.
Feb 17 2018, 6:24 AM · Plasma: Mobile
bshah triaged T7990: [pmiso] Selection helper buttons are confusing on ISO as Normal priority.
Feb 17 2018, 6:00 AM · Plasma: Mobile
bshah triaged T7989: [pmiso] Discover can't install applications as Normal priority.
Feb 17 2018, 5:58 AM · Plasma: Mobile

Feb 15 2018

bshah created Plasma (Plasma 5.13).
Feb 15 2018, 2:26 PM
bshah accepted D10544: Avoid cmake duplication.
Feb 15 2018, 2:14 PM · Plasma
bshah created KDE Human Interface Guidelines.
Feb 15 2018, 1:06 PM
bshah committed R896:125d700f9877: Add hig.kde.org (authored by bshah).
Add hig.kde.org
Feb 15 2018, 6:29 AM
bshah committed R247:8cfd842f4d43: Create websites/hig-kde-org (authored by bshah).
Create websites/hig-kde-org
Feb 15 2018, 4:56 AM

Feb 12 2018

bshah committed R20:7af3e39cd74c: Merge branch 'master' into bshah/stuff (authored by bshah).
Merge branch 'master' into bshah/stuff
Feb 12 2018, 3:47 PM
bshah committed R216:33ca3026efd5: Add APKBUILD to be highlighted as a Bash file (authored by PureTryOut).
Add APKBUILD to be highlighted as a Bash file
Feb 12 2018, 10:52 AM
bshah committed R216:294a20847803: Revert "Add APKBUILD to be highlighted as a Bash file" (authored by bshah).
Revert "Add APKBUILD to be highlighted as a Bash file"
Feb 12 2018, 10:52 AM
bshah added a reverting change for R216:7bafdc592040: Add APKBUILD to be highlighted as a Bash file: R216:294a20847803: Revert "Add APKBUILD to be highlighted as a Bash file".
Feb 12 2018, 10:52 AM
bshah committed R216:7bafdc592040: Add APKBUILD to be highlighted as a Bash file (authored by bshah).
Add APKBUILD to be highlighted as a Bash file
Feb 12 2018, 10:28 AM
bshah accepted D10450: Generate a custom target in kcoreaddons_desktop_to_json.

+1

Feb 12 2018, 8:56 AM · Frameworks
bshah committed R20:eb6b01b558a3: Don't fullscreen windows from the showEvent (authored by bshah).
Don't fullscreen windows from the showEvent
Feb 12 2018, 8:39 AM

Feb 11 2018

bshah committed R20:0d626dc7ad67: Some changes (authored by bshah).
Some changes
Feb 11 2018, 11:15 AM

Feb 10 2018

bshah accepted D10425: Improve appearance of the logout dialog on wayland.

+1 from me, if you want wait for review from others.

Feb 10 2018, 3:11 PM · Plasma
bshah requested changes to D10425: Improve appearance of the logout dialog on wayland.
Feb 10 2018, 2:26 PM · Plasma
bshah committed R20:02fd43edb80f: use wayland to fullscreen and skip taskbar (authored by bshah).
use wayland to fullscreen and skip taskbar
Feb 10 2018, 1:43 PM

Feb 9 2018

bshah committed R19:2bb1f08507df: Add symlinks (authored by bshah).
Add symlinks
Feb 9 2018, 1:48 PM

Feb 8 2018

bshah added a comment to T4160: fix nesting in projects tooling.

Can we remove the bazzilions of warnings

Feb 8 2018, 6:38 AM · Neon

Feb 7 2018

bshah added a comment to T7906: massif_visualizer disappeared from neon.

It got moved away from kde-extras, needs forking

Feb 7 2018, 9:54 AM · Neon
bshah triaged T7906: massif_visualizer disappeared from neon as Normal priority.
Feb 7 2018, 9:35 AM · Neon
bshah moved T7651: Please provide libinput 1.9 in Neon from Backlog to Review on the Neon board.
Feb 7 2018, 9:34 AM · Neon

Feb 6 2018

bshah committed R883:1510019: release plasma 5.12.0.
release plasma 5.12.0
Feb 6 2018, 3:13 PM
bshah committed R883:1510018: release plasma 5.12.0.
release plasma 5.12.0
Feb 6 2018, 3:13 PM
bshah committed R883:1510014: Fix wording for wayland.
Fix wording for wayland
Feb 6 2018, 12:21 PM
bshah committed R883:1510010: more fancy title.
more fancy title
Feb 6 2018, 11:23 AM
bshah committed R883:1510009: properly scaled image.
properly scaled image
Feb 6 2018, 11:16 AM
bshah committed R883:1510008: Double size instead.
Double size instead
Feb 6 2018, 11:01 AM
bshah committed R883:1510007: Fix the blurry image.
Fix the blurry image
Feb 6 2018, 10:49 AM
bshah committed R883:1510006: try to give it 100% width.
try to give it 100% width
Feb 6 2018, 10:45 AM
bshah committed R883:1510001: clarify that night-light is wayland only.
clarify that night-light is wayland only
Feb 6 2018, 8:19 AM
bshah committed R883:1509999: remove duplicated entry.
remove duplicated entry
Feb 6 2018, 8:12 AM
bshah committed R883:1509998: make wayland wording proper (Plasma 5.12).
make wayland wording proper (Plasma 5.12)
Feb 6 2018, 8:11 AM

Feb 5 2018

bshah created U8 KDE Visual Design Group's Layout guideline.
Feb 5 2018, 3:29 PM
bshah created U7 KDE Human Interface Guidelines.
Feb 5 2018, 3:27 PM
bshah committed R883:1509939: update source-plasma-5.12.0.inc.
update source-plasma-5.12.0.inc
Feb 5 2018, 1:11 PM
bshah committed R572:7d63c8a2300f: Fix test data to match the bugfix (authored by bshah).
Fix test data to match the bugfix
Feb 5 2018, 11:42 AM

Feb 4 2018

bshah committed R883:1509885: update source-plasma-5.12.0.inc.
update source-plasma-5.12.0.inc
Feb 4 2018, 5:49 AM

Feb 3 2018

Restricted Application edited projects for D10236: [libinput] Ensure Event::device returns a proper Device, added: KWin; removed Plasma.

Ergh, can you commit it though?

Feb 3 2018, 2:26 PM · Plasma
Restricted Application edited projects for D10236: [libinput] Ensure Event::device returns a proper Device, added: Plasma; removed KWin.

I would not have asked for it, but I agree. @bshah can you please take care of it?

Feb 3 2018, 2:16 PM · Plasma

Feb 2 2018

bshah committed R883:1509813: fix the title for 5.12 info page.
fix the title for 5.12 info page
Feb 2 2018, 1:38 PM
bshah committed R572:3754ab0c1a06: Fix template title (authored by bshah).
Fix template title
Feb 2 2018, 1:31 PM
bshah added a comment to D10215: Make KReport use marble component, KEXI & KEXI frameworks stable is 3.1.

Uh T4946 looks unrelated?

Feb 2 2018, 7:26 AM

Feb 1 2018

bshah committed R883:1509670: add Plasma 5.12.0 announcement.
add Plasma 5.12.0 announcement
Feb 1 2018, 6:07 PM
bshah committed R883:1509669: start webpages for Plasma 5.12.0.
start webpages for Plasma 5.12.0
Feb 1 2018, 6:07 PM
bshah committed R982:c675ec966e2a: Make it clear that Arch images are deprecated (authored by bshah).
Make it clear that Arch images are deprecated
Feb 1 2018, 4:49 PM