Add Smali syntax highlighting file
ClosedPublic

Authored by davispuh on Mar 16 2019, 10:27 PM.

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davispuh created this revision.Mar 16 2019, 10:27 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptMar 16 2019, 10:27 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
davispuh requested review of this revision.Mar 16 2019, 10:27 PM
davispuh updated this revision to Diff 54046.Mar 16 2019, 10:29 PM

Use MIT license

cullmann requested changes to this revision.Mar 17 2019, 11:01 AM

I think we will need a auto-test file for this ;=)

This revision now requires changes to proceed.Mar 17 2019, 11:01 AM
davispuh updated this revision to Diff 54120.Mar 17 2019, 5:59 PM

Add a test

Hmm, if the license is ok, perhaps the smaller RealSmaliFileTest.smali you linked above would make a better test case, >> 5000 lines is a bit large for reviewing changes later ;=)

davispuh updated this revision to Diff 54631.Mar 23 2019, 5:35 PM

Reduce size of test file

Ok, thanks, think that can go in ;=)

cullmann accepted this revision.Mar 24 2019, 12:56 PM
This revision is now accepted and ready to land.Mar 24 2019, 12:56 PM
This revision was automatically updated to reflect the committed changes.