davidedmundson (David Edmundson)
User

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 17 2015, 10:32 PM (196 w, 2 d)
Availability
Available

Recent Activity

Today

davidedmundson added a comment to D18366: Fix flickering with Qt 5.12.

Also relevant is of course Fredrik's comment in the Qt bug report

Mon, Jan 21, 12:24 PM · KWin
davidedmundson added a comment to D18419: Adjust some KCMs to implement new Appearance section layout.

To clarify one thing, I didn't say "porting". The original task was to go through all of them unifying them, rethinking design and following Fabian's new HIG as well as making sure all options are in the right place, etc.. I personally don't particularly care too much which tech is used.

Mon, Jan 21, 8:43 AM · Plasma
davidedmundson added a comment to D18410: Implement PlasmaShellSurface::popupBehavior in kwin.

Fair enough. I want some name that hints it doesn't include panels.

Mon, Jan 21, 5:44 AM · KWin
davidedmundson added a comment to T7246: User Manager.

We should refrain from starting things from scratch.

Mon, Jan 21, 4:14 AM · Plasma: KCM Redesign

Yesterday

davidedmundson accepted D18413: Don't put some KCMs in a single-item top-level category.
Sun, Jan 20, 10:43 PM · Plasma
davidedmundson requested changes to D18419: Adjust some KCMs to implement new Appearance section layout.

We have all agreed before that we will not do any top-down shuffling until all the work updating KCMs bottom-up has been completed. It's documented in that linked thread. That ground-up work has not finished.

Sun, Jan 20, 10:04 PM · Plasma
davidedmundson accepted D18415: Use nullptr.
Sun, Jan 20, 9:18 PM
davidedmundson accepted D18411: [Analog Clock] Port config window to QQC2 and use Kirigami FormLayout.
Sun, Jan 20, 6:07 PM · Plasma
davidedmundson accepted D18401: [Look And Feel KCM] Use new icon.
Sun, Jan 20, 5:58 PM · Plasma
davidedmundson requested review of D18410: Implement PlasmaShellSurface::popupBehavior in kwin.
Sun, Jan 20, 5:54 PM · KWin
davidedmundson added a comment to D18406: Silence warnings in TabBoxHandler.

Regarding the latter, we could use clang-tidy,

Sun, Jan 20, 5:08 PM · KWin
davidedmundson closed D18370: Set libkworkspace minimum version.
Sun, Jan 20, 3:59 PM · Plasma
davidedmundson committed R119:270c67514052: Set libkworkspace minimum version (authored by davidedmundson).
Set libkworkspace minimum version
Sun, Jan 20, 3:59 PM
davidedmundson added a comment to D18401: [Look And Feel KCM] Use new icon.

which we can depend on for the 5.16 release.

Sun, Jan 20, 3:49 PM · Plasma
davidedmundson requested review of D18408: Set new PlasmaShellSurface::PopupBehavior flags.
Sun, Jan 20, 3:43 PM · Frameworks

Sat, Jan 19

davidedmundson added inline comments to D18376: Fix software cursors with drm backend.
Sat, Jan 19, 1:15 PM · KWin
davidedmundson added a comment to D18376: Fix software cursors with drm backend.

Can you apply for a dev account, there should be an option on identity.kde.org put my name davidedmundson@kde.org as an approver.

Sat, Jan 19, 1:07 PM · KWin

Fri, Jan 18

davidedmundson accepted D18373: Set desktop name "atomically" when using the plasma virtual desktop protocol.
Fri, Jan 18, 11:17 PM · KWin
davidedmundson accepted D18374: Fix "context objects" in VirtualDesktopManager::setVirtualDesktopManagement.
Fri, Jan 18, 11:10 PM · KWin
davidedmundson accepted D18372: Delete names of removed desktops from kwinrc.
Fri, Jan 18, 9:47 PM · KWin
davidedmundson requested review of D18370: Set libkworkspace minimum version.
Fri, Jan 18, 7:44 PM · Plasma
davidedmundson accepted D18367: [scenes/opengl] Destroy the lanczos filter when the backend is still alive.
Fri, Jan 18, 7:15 PM · KWin
davidedmundson added a comment to D17773: Copy to Clipboard in English.

How can this affect discover?

Fri, Jan 18, 6:44 PM · Plasma
davidedmundson committed R871:aa781f86780a: Use nullptr (authored by davidedmundson).
Use nullptr
Fri, Jan 18, 3:39 PM
davidedmundson updated the summary of D18365: Add a flag to keep a window on top.
Fri, Jan 18, 2:43 PM · Frameworks
davidedmundson accepted D18363: [build] Search for kirigami as a runtime dependency.
Fri, Jan 18, 2:30 PM · Plasma
davidedmundson accepted D18362: [build] Search for kirigami as a runtime dependency.
Fri, Jan 18, 2:30 PM · Plasma
davidedmundson accepted D18360: [build] Search for kirigami as a runtime dependency.
Fri, Jan 18, 2:29 PM · Plasma
davidedmundson requested review of D18365: Add a flag to keep a window on top.
Fri, Jan 18, 2:22 PM · Frameworks
davidedmundson requested review of D18357: [applets/mediaframe] Resize combobox to contents.
Fri, Jan 18, 12:29 PM · Plasma
davidedmundson accepted D18353: Compile the virtual backend with older Mesa.
Fri, Jan 18, 12:28 PM · KWin
davidedmundson accepted D18355: Generate desktop ids without curly braces.
Fri, Jan 18, 12:13 PM · KWin
davidedmundson added a comment to D18322: [Look and Feel and KSplash KCM] Set sourceSize for thumbnail.

I put debug in Qt, in qmlscene it works as you'd expect.

Fri, Jan 18, 12:13 PM · Plasma
davidedmundson accepted D18356: [Plasma Theme] Use new connect syntax.
Fri, Jan 18, 11:33 AM · Frameworks
davidedmundson accepted D18343: [wallpapers/image] Port wallpaper plugins (mostly) to QQC2.
Fri, Jan 18, 11:11 AM · Plasma
davidedmundson accepted D18348: remove superfluous code.
Fri, Jan 18, 10:18 AM · KWin
davidedmundson requested review of D18347: [wallpapers/image] Don't use PlasmaCore in desktop themed UI.
Fri, Jan 18, 12:35 AM · Plasma
davidedmundson added a comment to D18343: [wallpapers/image] Port wallpaper plugins (mostly) to QQC2.

If you want to push everything except the combobox go for it.
QQC allows us to mix, we should make use of that to do regression-free ports.

Fri, Jan 18, 12:13 AM · Plasma

Thu, Jan 17

davidedmundson requested review of D18344: Make use of doxygen markers consistent in AbstractClient.
Thu, Jan 17, 11:48 PM · KWin
davidedmundson committed R108:3e68254eff35: Merge branch 'Plasma/5.15' (authored by davidedmundson).
Merge branch 'Plasma/5.15'
Thu, Jan 17, 11:43 PM
davidedmundson committed R108:e0071910f2cc: Fix DesktopGrid drag on X11 (authored by davidedmundson).
Fix DesktopGrid drag on X11
Thu, Jan 17, 11:43 PM
davidedmundson closed D18339: Fix DesktopGrid drag on X11.
Thu, Jan 17, 11:43 PM · KWin
davidedmundson added a comment to D18339: Fix DesktopGrid drag on X11.

When can a client end up on several desktops? (on X11)

Thu, Jan 17, 11:16 PM · KWin
davidedmundson accepted D18340: [Date & Time KCM] Fix clock display with fractional scale factor.
Thu, Jan 17, 10:01 PM · Plasma
davidedmundson requested review of D18339: Fix DesktopGrid drag on X11.
Thu, Jan 17, 9:57 PM · KWin
davidedmundson committed R98:00e797aa8c5c: Merge branch 'Plasma/5.15' (authored by davidedmundson).
Merge branch 'Plasma/5.15'
Thu, Jan 17, 9:30 PM
davidedmundson committed R98:6a6a432546bb: Cosmetic fixes for build_theme.sh (authored by gepardo).
Cosmetic fixes for build_theme.sh
Thu, Jan 17, 9:29 PM
davidedmundson closed D18314: Cosmetic fixes for build_theme.sh.
Thu, Jan 17, 9:29 PM · Plasma
davidedmundson added a comment to D18307: Call frameRendered for undamaged Wayland surfaces.

This does not take into account: A server should avoid signaling the frame callbacks if the surface is not visible in any way,

Thu, Jan 17, 4:16 PM · KWin
davidedmundson added a comment to D18322: [Look and Feel and KSplash KCM] Set sourceSize for thumbnail.

Setting sourceSize +++

Thu, Jan 17, 2:21 PM · Plasma
davidedmundson added a comment to D18310: Require breeze >= 5.14.90.

Oh, I'm really sorry! I hadn't seen this.

Thu, Jan 17, 12:31 PM · Plasma
davidedmundson committed R98:843bc1cc0874: Set minimum version for Breeze import (authored by davidedmundson).
Set minimum version for Breeze import
Thu, Jan 17, 12:26 PM
davidedmundson accepted D18314: Cosmetic fixes for build_theme.sh.
Thu, Jan 17, 11:39 AM · Plasma
davidedmundson added a comment to D18307: Call frameRendered for undamaged Wayland surfaces.

I was really hoping this would turn out to be the cause of our Firefox SHM bug, but having tested it doesn't seem like it :(

Thu, Jan 17, 12:33 AM · KWin

Wed, Jan 16

davidedmundson accepted D18307: Call frameRendered for undamaged Wayland surfaces.
Wed, Jan 16, 11:43 PM · KWin
davidedmundson accepted D18306: Word-wrap long tooltips.
Wed, Jan 16, 9:49 PM · Plasma
davidedmundson added a comment to D18228: Add windowsystem plugin for KWin's qpa.

we would need to put Shadows into KWindowSystem

Wed, Jan 16, 5:28 PM · KWin
davidedmundson accepted D18299: ComboBox: fix default delegate.
Wed, Jan 16, 3:20 PM · Plasma
davidedmundson committed R108:e6b5903fffab: [kcmkwin/kwindesktop] Remove pointless layout container (authored by davidedmundson).
[kcmkwin/kwindesktop] Remove pointless layout container
Wed, Jan 16, 3:16 PM
davidedmundson closed D18297: [kcmkwin/kwindesktop] Remove pointless layout container.
Wed, Jan 16, 3:16 PM · KWin
davidedmundson committed R98:de20417d6d2e: Remove hardcoded /usr/share paths in install (authored by davidedmundson).
Remove hardcoded /usr/share paths in install
Wed, Jan 16, 2:45 PM
davidedmundson closed D18287: Remove hardcoded /usr/share paths in install.
Wed, Jan 16, 2:45 PM · Plasma
davidedmundson committed R98:fda7d4375883: Check for python-cairo (authored by davidedmundson).
Check for python-cairo
Wed, Jan 16, 2:45 PM
davidedmundson closed D18244: Check for python-cairo.
Wed, Jan 16, 2:45 PM · Plasma
davidedmundson updated the diff for D18297: [kcmkwin/kwindesktop] Remove pointless layout container.

update

Wed, Jan 16, 2:34 PM · KWin
davidedmundson requested review of D18297: [kcmkwin/kwindesktop] Remove pointless layout container.
Wed, Jan 16, 2:33 PM · KWin
davidedmundson committed R31:622db3767ea7: Export path of installed color-schemes in BreezeConfig cmake (authored by davidedmundson).
Export path of installed color-schemes in BreezeConfig cmake
Wed, Jan 16, 2:17 PM
davidedmundson closed D18286: Export path of installed color-schemes in BreezeConfig cmake.
Wed, Jan 16, 2:17 PM · Plasma
davidedmundson added inline comments to D18189: Fix ComboBox.
Wed, Jan 16, 1:42 PM · Plasma
davidedmundson updated the diff for D18286: Export path of installed color-schemes in BreezeConfig cmake.

Use PACKAGE_ var

Wed, Jan 16, 12:57 PM · Plasma
davidedmundson updated the diff for D18244: Check for python-cairo.

move set(python_exec) into relevant scope

Wed, Jan 16, 12:51 PM · Plasma
davidedmundson committed R858:a78ef64134dd: Fake mousehover whilst combobox is open (authored by davidedmundson).
Fake mousehover whilst combobox is open
Wed, Jan 16, 12:50 PM
davidedmundson committed R858:c4a35f5e36bd: Set CombooBox QStyleOptionState == On rather than Sunken to match qwidgets (authored by davidedmundson).
Set CombooBox QStyleOptionState == On rather than Sunken to match qwidgets
Wed, Jan 16, 12:50 PM
davidedmundson closed D18285: Fake mousehover whilst combobox is open.
Wed, Jan 16, 12:50 PM · Plasma
davidedmundson closed D18284: Set CombooBox QStyleOptionState == On rather than Sunken to match qwidgets.
Wed, Jan 16, 12:50 PM · Plasma
davidedmundson accepted D18291: [Greeter] Ignore unwritable configuration files.
Wed, Jan 16, 12:37 PM · Plasma
davidedmundson accepted D17751: Add shadow to Hour's hand.
Wed, Jan 16, 12:34 PM · Plasma
davidedmundson accepted D18288: Make the clock svg's shadows more logically correct and visually appropriate.
Wed, Jan 16, 12:33 PM · Frameworks
davidedmundson added a comment to D18285: Fake mousehover whilst combobox is open.

I don't fully understand why widget ComboBox turns fully blue sometimes when open

Wed, Jan 16, 12:33 PM · Plasma
davidedmundson updated the diff for D18287: Remove hardcoded /usr/share paths in install.

whitespace

Wed, Jan 16, 12:24 PM · Plasma
davidedmundson added inline comments to D18290: Use KWin's D-Bus interface to get desktop layout rows on Wayland.
Wed, Jan 16, 12:20 PM · Plasma
davidedmundson added a comment to D18284: Set CombooBox QStyleOptionState == On rather than Sunken to match qwidgets.

When we click without explicit keyboard focus:

Wed, Jan 16, 12:14 PM · Plasma
davidedmundson added a dependent revision for D18286: Export path of installed color-schemes in BreezeConfig cmake: D18287: Remove hardcoded /usr/share paths in install.
Wed, Jan 16, 1:59 AM · Plasma
davidedmundson added a dependency for D18287: Remove hardcoded /usr/share paths in install: D18286: Export path of installed color-schemes in BreezeConfig cmake.
Wed, Jan 16, 1:59 AM · Plasma
davidedmundson requested review of D18287: Remove hardcoded /usr/share paths in install.
Wed, Jan 16, 1:41 AM · Plasma
davidedmundson requested review of D18286: Export path of installed color-schemes in BreezeConfig cmake.
Wed, Jan 16, 1:38 AM · Plasma
davidedmundson accepted D18261: support decorations from lookandfeel.
Wed, Jan 16, 12:34 AM · KWin
davidedmundson requested review of D18285: Fake mousehover whilst combobox is open.
Wed, Jan 16, 12:26 AM · Plasma
davidedmundson requested review of D18284: Set CombooBox QStyleOptionState == On rather than Sunken to match qwidgets.
Wed, Jan 16, 12:22 AM · Plasma

Tue, Jan 15

davidedmundson added a comment to D18189: Fix ComboBox.

I'm finding issues with combobox and this patch.

Tue, Jan 15, 11:49 PM · Plasma
davidedmundson committed R108:7c15bc7765eb: [kcmkwin/kwindesktop] Fix error in desktop layout indicator initial state (authored by davidedmundson).
[kcmkwin/kwindesktop] Fix error in desktop layout indicator initial state
Tue, Jan 15, 9:52 PM
davidedmundson closed D18272: [kcmkwin/kwindesktop] Fix error in desktop layout indicator initial state.
Tue, Jan 15, 9:52 PM · KWin
davidedmundson added a comment to D18255: Improve up/down display for Monitor widgets.

I grabbed this code from plasma-nm, which does the same thing.

Tue, Jan 15, 9:49 PM · Plasma
davidedmundson requested review of D18272: [kcmkwin/kwindesktop] Fix error in desktop layout indicator initial state.
Tue, Jan 15, 5:01 PM · KWin
davidedmundson requested changes to D18269: Improve the Splash Screen KCM.
Tue, Jan 15, 4:28 PM · Plasma
davidedmundson added a comment to D18267: Improve the Cursor Theme KCM.

In the tooltip and header on the page

Tue, Jan 15, 3:23 PM · Plasma
davidedmundson added a comment to D18267: Improve the Cursor Theme KCM.

Try to stick to titles that aren't "improve" as that literally covers every patch (or at least, you'd hope so)

Tue, Jan 15, 3:14 PM · Plasma
davidedmundson committed R102:e556c25c888a: Fix USB view (authored by alexandref).
Fix USB view
Tue, Jan 15, 2:11 PM
davidedmundson closed D18032: Fix USB view.
Tue, Jan 15, 2:11 PM · Plasma
davidedmundson updated the diff for D18244: Check for python-cairo.

update

Tue, Jan 15, 1:28 PM · Plasma