- User Since
- Apr 17 2015, 10:32 PM (187 w, 2 d)
I remember Alex at the time had a thing that new features should be in master but in #ifdefs so it's easier for other devs to test things than having a giant patchset that no-one can even find and have to keep switching between.
Use of callLater seems like a neat solution, does it make aboutToPopulate redundant?
Observation temperature of 0 ° no longer is shown as empty string,
I don't understand.
Ship it if you like, but I think there's a nicer solution.
Sat, Nov 17
Fri, Nov 16
CI seems to be frozen again. :(
Sure, lets get this into stable till a magic fix comes along
Marking as request changes based on Kai's comment which has gone unanswered.
This was merged at some point
Closing the RR.
Marking as request changes to remove from queue pending reply to Kai's question
Generally, ship it!
Thu, Nov 15
You can do control+w with
In the previous patch @Zren said:
you can't hardcode the key combos
Wed, Nov 14
update the plasma virtual desktop test at the same time
The include changes are obviously sensible. +2 on that.
Note, that the configReady function was a public slot in an exported class, so is it safe?
Let's try to get it in. I want to have passing tests this week again.
testVirtualDesktop (which is different from testVirtualDesktops) now passes.
Tue, Nov 13
See my other patch.
I'm not loving the name, the goal of this patchset is to move all of the wayland logic out of the platform.
Mon, Nov 12
why are we moving methods about?