- User Since
- Apr 17 2015, 10:32 PM (179 w, 1 d)
The negative aspects of this patch are not related to whether Wayland exists.
I'm still not sure about tooltips. Looks like they are not popups on Wayland. Will it be changed in Qt?
Thu, Sep 20
In principle, sure.
Mon, Sep 17
It's a bit weird to use kpackage here but not in ScriptedEffect itself but we can deal with that later.
Also I've tried to keep it generic so that rendering a frame + text is just one implementation of a more generic way for effects to render arbitrary QML.
FWIW: WIP at davidedmundson/effectquickview
Now I can reproduce the bug \o/
Sun, Sep 16
Sat, Sep 15
(imho the "daemon" should quit after having fullfilled the dbus activation request but that's an unrelated issue)
Fri, Sep 14
and everything makes sense, that's a known wayland behavioural change. ++
According to https://websvn.kde.org/trunk/l10n-kf5/scripts/ update_translations it seems both Messages.sh and StaticMessages.sh will be invoked.
Thu, Sep 13
Frankly, I prefer the old approach (with tristate). Now, we have two very similar properties.
It's missing still a cleanup in case the client is broken as in not responding to any configure events or with the wrong serials and the vector would grow limitless. But we can do this in a second patch.>
Rewrite the loop in a slightly different way. Behaviour should be the same.
Swap the enum tristate for whether any effect is full screen or if we're the active full screen effect
with 2 booleans.
Force blur/constrast to stay on even though we're a full screen effect
Wed, Sep 12
Oh, I see what you're saying, I misread, sorry. That does indeed make sense.
has been for no apparent reason
18 months because the change would be that big?
Tue, Sep 11
neither QWidget::adjustSize() nor QWidget::adjustedSize() seem to use devicePixelRatio
misc review comments
As an alternative approach, we could wrap EffectsHandler and EffectWindow.
Mon, Sep 10
Add missing file
I struggle to see how
As you're doing the common fix for QRect::right/bottom fix would it be cleaner to just use a QRectF for the area and then kill all the +1s?