davidedmundson (David Edmundson)
User

Projects (16)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 17 2015, 10:32 PM (258 w, 6 d)
Availability
Available

Recent Activity

Yesterday

davidedmundson committed R120:43bb68973b4b: POC - DO NOT MERGE: Use QtWayland directly (authored by davidedmundson).
POC - DO NOT MERGE: Use QtWayland directly
Thu, Apr 2, 11:28 PM
davidedmundson updated the diff for D28355: Introduce function ecm_install_configured_file.

extra escape

Thu, Apr 2, 9:40 PM · Build System, Frameworks
davidedmundson added a comment to D28154: Add users KCM.

Drop group stubs; there will be bad UX because two different polkit actions (and thus two dialogs backtoback) would be needed for apply with groups

Thu, Apr 2, 3:17 PM · Plasma
davidedmundson added a comment to D27576: Kill Runner: Move config keys to new file.

Quick question: I just realized that I committed the second commit with a wrong username (this will get rejected when I try to land the patch).

Thu, Apr 2, 2:56 PM · Plasma
davidedmundson added a comment to T11504: Implement xdg-output v3.

That's going to be tricky as we don't have control over the wl_output done event.

Thu, Apr 2, 12:44 PM · KWin
davidedmundson accepted D28155: Make it possible to have a separate cursor for the tablet.
Thu, Apr 2, 11:28 AM · KWin
davidedmundson added a comment to T12185: KService: deprecate/slim down KToolInvocation.

Fleshing this task out a bit more.

Thu, Apr 2, 11:23 AM · KF6
davidedmundson accepted D25549: [kcms/keyboard] Port away from KToolInvokation.

Changed my mind.

Thu, Apr 2, 11:19 AM · Plasma
davidedmundson accepted D28511: Fix for older cmake versions.
Thu, Apr 2, 11:15 AM · KWin
davidedmundson added inline comments to D28498: [xdgoutput] Explicitly set version of server interface.
Thu, Apr 2, 10:33 AM · Frameworks
davidedmundson updated the diff for D28498: [xdgoutput] Explicitly set version of server interface.

update

Thu, Apr 2, 10:31 AM · Frameworks
davidedmundson added inline comments to D28498: [xdgoutput] Explicitly set version of server interface.
Thu, Apr 2, 10:29 AM · Frameworks
davidedmundson requested review of D28510: [kprocessrunner] Escape hyphen characters in scope names.
Thu, Apr 2, 10:12 AM · Frameworks
davidedmundson accepted D28438: Add per-partition total and all partitions sensors.
Thu, Apr 2, 9:40 AM · Plasma
davidedmundson updated the diff for D28355: Introduce function ecm_install_configured_file.

update

Thu, Apr 2, 9:38 AM · Build System, Frameworks
davidedmundson added inline comments to D28355: Introduce function ecm_install_configured_file.
Thu, Apr 2, 9:38 AM · Build System, Frameworks
davidedmundson updated the diff for D28305: WIP: Systemd Startup.

Add xembedsniproxy and gdbusmenuproxy

Thu, Apr 2, 8:52 AM · Plasma
davidedmundson added inline comments to D28487: Redesign of system monitor plasmoids.
Thu, Apr 2, 8:15 AM · Plasma
davidedmundson accepted D28497: Use non-const iterators.
Thu, Apr 2, 8:14 AM · Plasma
davidedmundson requested review of D28498: [xdgoutput] Explicitly set version of server interface.
Thu, Apr 2, 8:11 AM · Frameworks

Tue, Mar 31

davidedmundson added inline comments to D28466: Added Page element.
Tue, Mar 31, 3:47 PM · Frameworks
davidedmundson added a comment to D27540: KCModule: Indicate when a setting has been changed from the default or previous value.

What do we want to happen for released code that gets a bugfix update?

Tue, Mar 31, 1:55 PM · Frameworks
davidedmundson accepted D28420: [Image Wallpaper] Fix thumbnail generation when model is reloaded in-flight.
Tue, Mar 31, 11:41 AM · Plasma
davidedmundson added inline comments to D28445: Reduce the amount of objects that are compiled several times.
Tue, Mar 31, 11:09 AM · KWin
davidedmundson updated the diff for D28333: Add a new daemon for stats monitoring.

Register bus name after loading plugins

Tue, Mar 31, 10:50 AM · Plasma
davidedmundson requested changes to D28454: [libnotificationmanager] forward notifications to lockscreen greeter.

Seems pretty simple and sensible.

Tue, Mar 31, 8:54 AM · Plasma
davidedmundson added a comment to D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch.

@davidedmundson - is QIcon(QImage(...)) save?

Tue, Mar 31, 8:51 AM · Plasma
davidedmundson added a comment to D28455: add dbus interface to the greeter.

I'd say we go for the simplest solution +++

Tue, Mar 31, 8:46 AM · Plasma

Mon, Mar 30

davidedmundson updated the diff for D28305: WIP: Systemd Startup.

update

Mon, Mar 30, 5:10 PM · Plasma
davidedmundson committed R108:4d2ec7e54e1e: changes (authored by davidedmundson).
changes
Mon, Mar 30, 4:43 PM
davidedmundson committed R108:b7065584d250: changes (authored by davidedmundson).
changes
Mon, Mar 30, 4:43 PM
davidedmundson committed R108:c1c9a4501d0a: Merge branch 'master' into davidedmundson/systemd_startup (authored by davidedmundson).
Merge branch 'master' into davidedmundson/systemd_startup
Mon, Mar 30, 4:43 PM
davidedmundson accepted D28443: [kcmkwin] Remove redundant lambda.
Mon, Mar 30, 4:38 PM · KWin
davidedmundson updated the diff for D28305: WIP: Systemd Startup.

update

Mon, Mar 30, 4:35 PM · Plasma
davidedmundson committed R108:0a65681596c3: [kcmkwin] Make dialog non blocking (authored by davidedmundson).
[kcmkwin] Make dialog non blocking
Mon, Mar 30, 4:27 PM
davidedmundson closed D28293: [kcmkwin] Make dialog non blocking.
Mon, Mar 30, 4:27 PM · KWin
davidedmundson updated the diff for D28422: WIP: Use ecm_install_configured_files macro.

update

Mon, Mar 30, 3:52 PM · Plasma
davidedmundson requested changes to D28428: [screenlocker] listen to notifications from the notification server.

We've added a DBus interface to the screensaver host; ksmserver or kwin respectively.
That receives the notification and then using a different API over wayland, sends it to the greeter.
Is that right?

Mon, Mar 30, 3:20 PM · Plasma
davidedmundson added a comment to D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch.

QIcon isn't thread safe.

Mon, Mar 30, 3:10 PM · Plasma
davidedmundson requested changes to D28155: Make it possible to have a separate cursor for the tablet.

Idea seems sensible.

Mon, Mar 30, 2:46 PM · KWin
davidedmundson added a comment to D27338: Provide an initial implementation for input-method-unstable-v1.

After reading some inline comments in D28295, I think it would be better to get rid of the nested private class thing. We won't need to use Q_DECL_HIDDEN and this is what Qt folks do. :-)

Mon, Mar 30, 2:35 PM · Frameworks
davidedmundson added a comment to D17732: Respect animation settings.
+        KSharedConfig::Ptr config = KSharedConfig::openConfig(QStringLiteral("kdeglobals"));
Mon, Mar 30, 2:15 PM · Gwenview
davidedmundson committed R241:ec8cfd5ffb7f: [kprocessrunner] Add documentation with reference to cgroup standard (authored by davidedmundson).
[kprocessrunner] Add documentation with reference to cgroup standard
Mon, Mar 30, 1:50 PM
davidedmundson updated the diff for D28355: Introduce function ecm_install_configured_file.

All of the things!

Mon, Mar 30, 12:33 PM · Build System, Frameworks
davidedmundson added a comment to D28424: Add a new standalone executable to replace X-KDE-Autostart-Condition.

looks good to me, but lets delay merging till the relevant other parts are ready.

Mon, Mar 30, 9:59 AM · Plasma
davidedmundson accepted D28421: Add static method to check start condition.
Mon, Mar 30, 9:22 AM · Frameworks
davidedmundson added inline comments to D28424: Add a new standalone executable to replace X-KDE-Autostart-Condition.
Mon, Mar 30, 9:22 AM · Plasma
davidedmundson added a comment to D28355: Introduce function ecm_install_configured_file.

I agree with almost all those suggestions. Though it's a lot more complex, so I might need some help with some of that.

Mon, Mar 30, 8:32 AM · Build System, Frameworks
davidedmundson requested review of D28422: WIP: Use ecm_install_configured_files macro.
Mon, Mar 30, 8:25 AM · Plasma
davidedmundson added inline comments to D28421: Add static method to check start condition.
Mon, Mar 30, 8:23 AM · Frameworks
davidedmundson added a comment to D28421: Add static method to check start condition.

Code is fine; both the change in KAutostart and the helper.

Mon, Mar 30, 8:15 AM · Frameworks

Sun, Mar 29

davidedmundson added a comment to D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open.

As a question, rather than a researched proposal, is it better to check for the pin in?

Sun, Mar 29, 9:51 PM · Plasma
davidedmundson abandoned D25967: Emit panelTakesFocus for other plamsashell types.
Sun, Mar 29, 3:17 PM · Plasma
davidedmundson committed R119:aa2212e25c92: [kapplymousetheme] Avoid loading QPT (authored by davidedmundson).
[kapplymousetheme] Avoid loading QPT
Sun, Mar 29, 3:17 PM
davidedmundson closed D28339: [kapplymousetheme] Avoid loading QPT.
Sun, Mar 29, 3:17 PM · Plasma
davidedmundson committed R120:92a9497e8ee3: Merge branch 'Plasma/5.18' (authored by davidedmundson).
Merge branch 'Plasma/5.18'
Sun, Mar 29, 3:16 PM
davidedmundson committed R120:97bf7d777e56: [runners/recentdocuments] disable executables or .desktop files (authored by davidedmundson).
[runners/recentdocuments] disable executables or .desktop files
Sun, Mar 29, 3:13 PM
davidedmundson closed D28369: [runners/recentdocuments] disable executables or .desktop files.
Sun, Mar 29, 3:13 PM · Plasma
davidedmundson added a comment to D28133: [applets/digital-clock] Switch timezones by clicking on them in the popup.

Be careful about mixing terms here.

Sun, Mar 29, 2:25 PM · Plasma

Sat, Mar 28

davidedmundson accepted D28385: Remove unused file.
Sat, Mar 28, 7:41 PM · Plasma
davidedmundson accepted D28382: QQC2-Desktop-Style: Convert license headers to SPDX expressions.
Sat, Mar 28, 7:02 PM · Plasma
davidedmundson requested changes to D28383: Add PageRouter component.

This needs way more description and explanation of the problem it's trying to solve.

Sat, Mar 28, 5:34 PM · Kirigami
davidedmundson accepted D28378: [kcmkwin/kwindesktop] Fix inability to create more than one row on the "Virtual Desktops" settings page.
Sat, Mar 28, 4:17 PM · KWin
davidedmundson added inline comments to D28372: Added a merged look to the plasmoidheading and remove roundedborders.
Sat, Mar 28, 3:53 PM · Frameworks
davidedmundson added a comment to D28152: KWinRules KCM Redesign.

Make sure you remember to remove "WIP" from the phab request when you think we're ready for merging, otherwise no-one will do any approving.

Sat, Mar 28, 3:10 PM · VDG, KWin

Fri, Mar 27

davidedmundson requested review of D28369: [runners/recentdocuments] disable executables or .desktop files.
Fri, Mar 27, 11:16 PM · Plasma
davidedmundson added inline comments to D28355: Introduce function ecm_install_configured_file.
Fri, Mar 27, 11:10 PM · Build System, Frameworks
davidedmundson requested review of D28368: [krunner] Avoid (a third!) pointless config parse.
Fri, Mar 27, 10:56 PM · Plasma
davidedmundson updated the title for P566 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Fri, Mar 27, 10:48 PM
davidedmundson updated the diff for D28366: [krunner] Don't set the position three times in a row.

update

Fri, Mar 27, 10:24 PM · Plasma
davidedmundson requested review of D28366: [krunner] Don't set the position three times in a row.
Fri, Mar 27, 10:23 PM · Plasma
davidedmundson requested review of D28365: [krunner] Avoid (another) pointless config load on start.
Fri, Mar 27, 10:21 PM · Plasma
davidedmundson requested review of D28364: [krunner] Avoid a config pointless extra config load.
Fri, Mar 27, 10:19 PM · Plasma
davidedmundson updated the diff for D28355: Introduce function ecm_install_configured_file.

Good idea. Done

Fri, Mar 27, 6:29 PM · Build System, Frameworks
davidedmundson requested review of D28355: Introduce function ecm_install_configured_file.
Fri, Mar 27, 5:00 PM · Build System, Frameworks
davidedmundson updated the title for P565 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Fri, Mar 27, 3:53 PM
davidedmundson updated the diff for D28333: Add a new daemon for stats monitoring.

Drop object library, it was too cool for some cmake versions

Fri, Mar 27, 3:01 PM · Plasma
davidedmundson updated the title for P564 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Fri, Mar 27, 2:50 PM
davidedmundson committed R120:9be7dedb87ea: Use new simpler way to disable session management in services (authored by davidedmundson).
Use new simpler way to disable session management in services
Fri, Mar 27, 2:46 PM
davidedmundson closed D28341: Use new simpler way to disable session management in services.
Fri, Mar 27, 2:46 PM · Plasma
davidedmundson accepted D28349: Fix Warnings.
Fri, Mar 27, 2:44 PM · Frameworks
davidedmundson added inline comments to D28349: Fix Warnings.
Fri, Mar 27, 2:31 PM · Frameworks
davidedmundson requested review of D28341: Use new simpler way to disable session management in services.
Fri, Mar 27, 1:40 PM · Plasma
davidedmundson accepted D28340: Figure out nested wayland dismantle.
Fri, Mar 27, 1:33 PM · KWin
davidedmundson added inline comments to D28340: Figure out nested wayland dismantle.
Fri, Mar 27, 1:21 PM · KWin
davidedmundson accepted D28338: [PowerDevil Runner] Remove unused KRun include.
Fri, Mar 27, 1:12 PM · Plasma
davidedmundson requested review of D28339: [kapplymousetheme] Avoid loading QPT.
Fri, Mar 27, 1:11 PM · Plasma
davidedmundson created T12867: Create working restart + drkonqi.
Fri, Mar 27, 12:20 PM · Plasma
davidedmundson requested review of D28336: Drop klauncher usage from KCrash.
Fri, Mar 27, 12:04 PM · Frameworks
davidedmundson added inline comments to D28333: Add a new daemon for stats monitoring.
Fri, Mar 27, 10:57 AM · Plasma
davidedmundson requested review of D28333: Add a new daemon for stats monitoring.
Fri, Mar 27, 10:53 AM · Plasma
davidedmundson accepted D28310: Wayland: Allow to set a scroll Factor for input devices.
Fri, Mar 27, 10:00 AM · KWin
davidedmundson accepted D28332: [kwineffects] Drop KWIN_GL_DEBUG.
Fri, Mar 27, 9:59 AM · KWin
davidedmundson added inline comments to D27840: Introduce SettingState* elements to ease KCM writing.
Fri, Mar 27, 9:49 AM · Frameworks
davidedmundson added inline comments to D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting for wayland.
Fri, Mar 27, 9:40 AM · Plasma
davidedmundson added a comment to D28310: Wayland: Allow to set a scroll Factor for input devices.

Seems fine to me it's analogous to a touchpad input matrix, which are also done server side.

Fri, Mar 27, 9:36 AM · KWin
davidedmundson accepted D28326: [UnindexedFileIndexer] Only mark file for content indexing when needed.
Fri, Mar 27, 9:05 AM · Baloo, Frameworks
davidedmundson added a comment to D28310: Wayland: Allow to set a scroll Factor for input devices.

Should I add a "supportScrollFactor" bool to make it easier of the UI side ?

Fri, Mar 27, 8:44 AM · KWin

Thu, Mar 26

davidedmundson accepted D28306: [applets/taskmanager] Make the hover state clarifying, but not main.
Thu, Mar 26, 6:21 PM · Plasma
davidedmundson requested changes to D28310: Wayland: Allow to set a scroll Factor for input devices.
Thu, Mar 26, 3:55 PM · KWin