davidedmundson (David Edmundson)
User

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 17 2015, 10:32 PM (169 w, 2 d)
Availability
Available

Recent Activity

Sat, Jul 14

davidedmundson accepted D14116: Use a better icon for "Remove" on the widget handle.
Sat, Jul 14, 10:41 PM · Plasma
davidedmundson accepted D14117: [effects/magiclamp] Eliminate unnecessary reallocations.

If this is an issue, we could try looking into setting a Q_DECLARE_TYPEINFO on the WindowQuadList.
Right now QList still allocates a second set of memory for complex types separate from the internal void* list that we're pre-allocating here.

Sat, Jul 14, 10:29 PM · KWin
davidedmundson accepted D14085: [effects/slidingpopups] Reserve enough memory for filtered quads.
Sat, Jul 14, 5:32 PM · KWin
davidedmundson accepted D14105: Use a broom-style icon for clearing clipboard and notification history.
Sat, Jul 14, 2:42 PM · Plasma

Fri, Jul 13

davidedmundson added a comment to D12804: Fix window frame rounding when scaling is used.

And in that function qreal newScale = screens()->scale(m_screen); gets the value from here: https://github.com/KDE/kwin/blob/master/screens.cpp#L114
You can see that this function just returns 1

Fri, Jul 13, 11:35 PM · Plasma
davidedmundson accepted D14087: [effects/slidingpopups] Fix possible segfault.
Fri, Jul 13, 1:09 PM · KWin
davidedmundson added a comment to D13084: Avoid invalid geometry of internal clients through plasma surface interface.

One can shield

shielding means we've already gone wrong, and you'll still get broken shadows on the first tabbox.

Fri, Jul 13, 1:03 PM · KWin
davidedmundson added a comment to D14025: Move scale and unify button to the top, next to primary combo.

It (currently) depends. There are two scale UI options with the appropriate one visible.

Fri, Jul 13, 11:58 AM · Plasma
davidedmundson accepted D14088: [effects/slidingpopups] Simplify math in setupAnimData.
Fri, Jul 13, 10:51 AM · KWin
davidedmundson accepted D14086: [effects/slidingpopups] Use range-based for loops.

Would have expected some fancy std::remove_if from you

Fri, Jul 13, 10:47 AM · KWin
davidedmundson accepted D14091: [effects/slidingpopups] Delete unused prePaintScreen method.
Fri, Jul 13, 8:03 AM · KWin
davidedmundson added inline comments to D14088: [effects/slidingpopups] Simplify math in setupAnimData.
Fri, Jul 13, 7:40 AM · KWin

Thu, Jul 12

davidedmundson accepted D13734: Make GConf optional dependency.
Thu, Jul 12, 5:14 PM · Plasma
davidedmundson updated the title for P242 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Thu, Jul 12, 1:51 PM
davidedmundson added a comment to D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog.

Sorry for the delay

Thu, Jul 12, 12:27 PM · Plasma
davidedmundson updated the title for P241 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Thu, Jul 12, 10:42 AM
davidedmundson accepted D14060: Clean up string casts.

I think micro-optimizing the tests further is simply not worth anyone's time

Thu, Jul 12, 9:00 AM · Plasma

Wed, Jul 11

davidedmundson accepted D14060: Clean up string casts.

cool, thanks.

Wed, Jul 11, 9:55 PM · Plasma
davidedmundson added inline comments to D13887: use the new plasma virtual desktop protocol.
Wed, Jul 11, 9:24 PM · KWin
davidedmundson requested changes to D13084: Avoid invalid geometry of internal clients through plasma surface interface.

Done some investigation.

Wed, Jul 11, 8:49 PM · KWin
davidedmundson accepted D14051: [Lock Screen] Fix avatar not showing in software rendering.
Wed, Jul 11, 4:41 PM · Plasma
davidedmundson accepted D14049: Trim kwrited text.
Wed, Jul 11, 2:32 PM · Plasma
davidedmundson accepted D14048: Fix fake parser copy and paste error.
Wed, Jul 11, 2:00 PM · Plasma
davidedmundson accepted D14047: [KFileItemModelRolesUpdater] Fix preview scaling for frameless previews.
Wed, Jul 11, 1:37 PM · Dolphin
davidedmundson accepted D11319: [KStandardItemListWidget] Avoid needless image resizing.

Needs a comment in the code explaining why.

Wed, Jul 11, 1:28 PM · Dolphin
davidedmundson accepted D14046: [effects/desktopgrid] Don't change activities.
Wed, Jul 11, 1:24 PM · KWin
davidedmundson accepted D13979: [effects/slide] Clean up.
Wed, Jul 11, 1:10 PM · KWin
davidedmundson accepted D14024: Move KCM to UI file.
Wed, Jul 11, 1:09 PM · Plasma
davidedmundson accepted D14025: Move scale and unify button to the top, next to primary combo.
Wed, Jul 11, 1:03 PM · Plasma
davidedmundson requested changes to D10083: [Look and Feel] Reverse the button order.

Is this now redundant when this KCM was remodelled ?

Wed, Jul 11, 12:46 PM · Plasma
davidedmundson accepted D14044: Simplify getting edid in xrandr backend.
Wed, Jul 11, 10:25 AM · Plasma
davidedmundson accepted D14041: Honor ghns KIOSK restriction in new KCMs.
Wed, Jul 11, 9:36 AM · Plasma
davidedmundson added inline comments to D14041: Honor ghns KIOSK restriction in new KCMs.
Wed, Jul 11, 8:45 AM · Plasma

Tue, Jul 10

davidedmundson accepted D14011: Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM.

this has been fixed in QtQuick.Controls 2.0

Tue, Jul 10, 5:55 PM · Plasma
davidedmundson accepted D14004: [libkwineffects] Use std::copy.
Tue, Jul 10, 12:16 PM · KWin

Sat, Jul 7

davidedmundson added a comment to D13927: autotests: Compare doubles to doubles.

My fault :/
Thanks for taking care of that.

Sat, Jul 7, 8:53 AM · Plasma

Fri, Jul 6

davidedmundson committed R120:c96a9f5afec3: Remove pointless setMin/setMax size on DesktopView (authored by davidedmundson).
Remove pointless setMin/setMax size on DesktopView
Fri, Jul 6, 12:49 PM
davidedmundson closed D13850: Remove pointless setMin/setMax size on DesktopView.
Fri, Jul 6, 12:49 PM · Plasma
davidedmundson accepted D13923: [User Switcher] Swap Cancel and Switch buttons.
Fri, Jul 6, 12:46 PM · Plasma
davidedmundson committed R119:d73d047f9487: Squash me: Fix JS usage (authored by davidedmundson).
Squash me: Fix JS usage
Fri, Jul 6, 12:34 PM
davidedmundson committed R119:152881ab4290: Squash me: Spinbox/tumbler awesome morphing date input (authored by davidedmundson).
Squash me: Spinbox/tumbler awesome morphing date input
Fri, Jul 6, 12:34 PM
davidedmundson committed R119:ecf2b784a708: Squash me: Tidy up backend (authored by davidedmundson).
Squash me: Tidy up backend
Fri, Jul 6, 12:34 PM
davidedmundson committed R119:615d0327f05a: Squash me: new UI (authored by davidedmundson).
Squash me: new UI
Fri, Jul 6, 12:34 PM
davidedmundson committed R119:025e9819952d: WIP: Port clock KCM to QtQuick (authored by davidedmundson).
WIP: Port clock KCM to QtQuick
Fri, Jul 6, 12:34 PM
davidedmundson requested changes to D13758: [tabbox] Deactivate client while switching windows on Wayland.

This may not be the window you started with! You need to track which window you started with, if it got destroyed you need to ask the focuschain

Fri, Jul 6, 11:43 AM · KWin
davidedmundson accepted D13851: [kcmkwin/kwindesktop] Use PackageLoader to get effect metadata.

Meh I still don't understand why KPluginInfo(KService) is deprecated it makes no sense, given using KService for plugins is not yet deprecated.

Fri, Jul 6, 10:54 AM · KWin
davidedmundson added a comment to D13907: [SDDM Theme] Set sourceSize on background image.

Actually increases ram usage of sddm-greeter by 10 MiB here. I thought it would never load the image larger than it is? :/

Fri, Jul 6, 10:47 AM · Plasma
davidedmundson added a comment to D13920: [Font Management KCM] Only show on xcb platform.

Please open a bug report that this is missing and should be ported.

Fri, Jul 6, 10:28 AM · Plasma
davidedmundson added inline comments to D13887: use the new plasma virtual desktop protocol.
Fri, Jul 6, 10:20 AM · KWin
davidedmundson added a comment to D13887: use the new plasma virtual desktop protocol.

I think we should focus on getting the core done here, and we can do the effects themselves in a different patch.

Fri, Jul 6, 10:17 AM · KWin
davidedmundson added a comment to T4448: [kwin] Support for startup notifications.

org.freedesktop.Application (KDBusService ) supports a variant map of "platform-hints" X startup ID is currently in there and then not used.

Fri, Jul 6, 12:39 AM · Plasma on Wayland
davidedmundson claimed T4448: [kwin] Support for startup notifications.
Fri, Jul 6, 12:34 AM · Plasma on Wayland

Thu, Jul 5

davidedmundson added a comment to D13887: use the new plasma virtual desktop protocol.

Yeah, all the effects will need some tweaks for the cardinality changes.

Thu, Jul 5, 4:24 PM · KWin
davidedmundson accepted D13879: Monitor document title.
Thu, Jul 5, 1:39 PM · Plasma
davidedmundson accepted D13883: Don't keep transfer div in DOM.
Thu, Jul 5, 1:25 PM · Plasma
davidedmundson added a comment to D13084: Avoid invalid geometry of internal clients through plasma surface interface.

Unfortunately there are code areas where the way to set it is through the Plasmashell API and other areas where it is through the internal setting mechanism.

Thu, Jul 5, 12:37 PM · KWin
davidedmundson added a comment to D13456: [wayland] Make it possible to reach screen edges.

What's the status of this?

Thu, Jul 5, 11:57 AM · KWin
davidedmundson accepted D13865: [effects/kscreen] Port to TimeLine.
Thu, Jul 5, 10:44 AM · KWin
davidedmundson committed R159:3d81d0b314f5: Fix off by one error in Cache::clear (authored by davidedmundson).
Fix off by one error in Cache::clear
Thu, Jul 5, 10:36 AM
davidedmundson closed D13895: Fix off by one error in Cache::clear.
Thu, Jul 5, 10:36 AM · Frameworks

Wed, Jul 4

davidedmundson requested review of D13895: Fix off by one error in Cache::clear.
Wed, Jul 4, 11:48 PM · Frameworks
davidedmundson added a comment to T9126: Breeze scrollbar look-and-feel unification.

Good analysis, that's what I like to see at the start of any changes!

Wed, Jul 4, 9:49 PM · VDG
davidedmundson added a comment to D13887: use the new plasma virtual desktop protocol.

What's the state of an xwayland client being on N desktops?

Wed, Jul 4, 9:41 PM · KWin
davidedmundson added a comment to D13510: Add XDG WM Base support to our XDGShell API.

Or would it make sense to wait on merging until Qt 5.12 with XDG WM Base support is available to have more test candidates?

Wed, Jul 4, 9:24 PM · Frameworks
davidedmundson requested changes to D11781: Introduce generic Output class.

From IRC today.

Wed, Jul 4, 9:21 PM · KWin
davidedmundson accepted D13878: Also intercept creation of video elements.
Wed, Jul 4, 9:51 AM · Plasma

Tue, Jul 3

davidedmundson accepted D12517: Wayland: when blocking remember latest config change instead of crashing.
Tue, Jul 3, 5:45 PM · Plasma
davidedmundson added a dependency for D13530: Add XDG WmBase support: D13510: Add XDG WM Base support to our XDGShell API.
Tue, Jul 3, 5:21 PM · KWin
davidedmundson added a dependent revision for D13510: Add XDG WM Base support to our XDGShell API: D13530: Add XDG WmBase support.
Tue, Jul 3, 5:21 PM · Frameworks
davidedmundson removed a dependent revision for D13530: Add XDG WmBase support: D13510: Add XDG WM Base support to our XDGShell API.
Tue, Jul 3, 5:21 PM · KWin
davidedmundson removed a dependency for D13510: Add XDG WM Base support to our XDGShell API: D13530: Add XDG WmBase support.
Tue, Jul 3, 5:21 PM · Frameworks
davidedmundson requested changes to D13853: Fix setting primary connector if primary output changed.
Tue, Jul 3, 5:17 PM · Plasma
davidedmundson accepted D13848: Fix device label with unknown size.
Tue, Jul 3, 2:40 PM · Frameworks
davidedmundson accepted D13864: [Splash Screen KCM] Fix "no thumbnail" icon for "None".
Tue, Jul 3, 2:40 PM · Plasma
davidedmundson committed R159:75d6103df944: Fix ResultModel item moving (authored by davidedmundson).
Fix ResultModel item moving
Tue, Jul 3, 2:23 PM
davidedmundson closed D13866: Fix ResultModel item moving.
Tue, Jul 3, 2:23 PM · Frameworks
davidedmundson accepted D13856: Fix crash on post-initial refresh().
Tue, Jul 3, 2:22 PM · Plasma
davidedmundson added a comment to D13866: Fix ResultModel item moving.

In an email

Tue, Jul 3, 1:32 PM · Frameworks
davidedmundson requested review of D13866: Fix ResultModel item moving.
Tue, Jul 3, 10:30 AM · Frameworks
davidedmundson updated the diff for D13601: OutputManagement fractional scaling.

Rebase

Tue, Jul 3, 9:35 AM · Frameworks
davidedmundson accepted D13863: Don't block startplasma sending DBus call to KSplash.
Tue, Jul 3, 8:42 AM · Plasma

Mon, Jul 2

davidedmundson requested changes to D13856: Fix crash on post-initial refresh().

The parental changes totally make sense. +1 to that.

Mon, Jul 2, 9:16 PM · Plasma
davidedmundson added a comment to D13851: [kcmkwin/kwindesktop] Use PackageLoader to get effect metadata.

For scripted effects, yes, they're packages
For a 3rd party C++ plugin effects with a matching .desktop file and this will no longer have the right data.

Mon, Jul 2, 3:50 PM · KWin
davidedmundson requested review of D13850: Remove pointless setMin/setMax size on DesktopView.
Mon, Jul 2, 2:57 PM · Plasma
davidedmundson requested changes to D13846: [kcmkwin/kwindesktop] Fix KPluginInfo(KService::Ptr) deprecation warning.

This doesn't seem right. You're still using a mixture of KService and KPluginInfo just avoiding the warning by parsing everything twice, but not really the point of the warning.

Mon, Jul 2, 1:13 PM · KWin
davidedmundson requested review of D13849: WIP: Add fractional scaling to wayland scaling GUI.
Mon, Jul 2, 1:03 PM · Plasma
davidedmundson accepted D13844: [Places Runner] Add place category as subtext.
Mon, Jul 2, 12:35 PM · Plasma
davidedmundson added a comment to D10040: Add serial number and EISA ID to OutputDevice interface.

In another patch I'm doing a V2 of this interface in the next frameworks cycle.
May as well try to merge this at the same time so we only have 1 version bump?

Mon, Jul 2, 12:32 PM · Frameworks, Plasma on Wayland
davidedmundson added a reviewer for D10040: Add serial number and EISA ID to OutputDevice interface: KWin.
Mon, Jul 2, 12:31 PM · Frameworks, Plasma on Wayland
davidedmundson added a comment to D13820: Use QHash::value() in EffectWindowImpl::data().

sure

Mon, Jul 2, 11:47 AM · KWin
davidedmundson accepted D13845: Fix Enhanced Media Controls disabled state.
Mon, Jul 2, 10:29 AM · Plasma
davidedmundson accepted D13843: [effects/slide] Expose support information.

Q_PROPERTY(int foo MEMBER m_foo) saves writing getters just for moc.

Mon, Jul 2, 9:31 AM · KWin
davidedmundson accepted D13841: [Places Runner] Fix opening search and timeline URLs.
Mon, Jul 2, 9:00 AM · Plasma
davidedmundson updated the diff for D13488: Make XDGShellV5 co-compilable with XDGWMBase.

update

Mon, Jul 2, 8:50 AM · Frameworks
davidedmundson accepted D13837: Lookup loaded effects only once when building support information.

Not exactly a hotspot.

Mon, Jul 2, 8:40 AM · KWin
davidedmundson accepted D13839: [effects/cube] Change type of the rotationDuration property to int.
Mon, Jul 2, 8:37 AM · KWin

Sun, Jul 1

davidedmundson accepted D13822: Use qDeleteAll in destructor of Scene class.
Sun, Jul 1, 11:38 AM · KWin
davidedmundson accepted D13820: Use QHash::value() in EffectWindowImpl::data().

Const find/ constEnd should work here.

Sun, Jul 1, 7:46 AM · KWin

Sat, Jun 30

davidedmundson accepted D13764: [effects/slide] Port to TimeLine.
Sat, Jun 30, 9:02 PM · KWin
davidedmundson added a comment to D13810: [effects] Rewrite the Dialog Parent effect.

that can't be implemented in JavaScript.

Sat, Jun 30, 5:57 PM · KWin