- User Since
- Apr 17 2015, 10:32 PM (258 w, 6 d)
Drop group stubs; there will be bad UX because two different polkit actions (and thus two dialogs backtoback) would be needed for apply with groups
Quick question: I just realized that I committed the second commit with a wrong username (this will get rejected when I try to land the patch).
That's going to be tricky as we don't have control over the wl_output done event.
Fleshing this task out a bit more.
Changed my mind.
Add xembedsniproxy and gdbusmenuproxy
Tue, Mar 31
What do we want to happen for released code that gets a bugfix update?
Register bus name after loading plugins
Seems pretty simple and sensible.
@davidedmundson - is QIcon(QImage(...)) save?
I'd say we go for the simplest solution +++
Mon, Mar 30
We've added a DBus interface to the screensaver host; ksmserver or kwin respectively.
That receives the notification and then using a different API over wayland, sends it to the greeter.
Is that right?
QIcon isn't thread safe.
Idea seems sensible.
After reading some inline comments in D28295, I think it would be better to get rid of the nested private class thing. We won't need to use Q_DECL_HIDDEN and this is what Qt folks do. :-)
+ KSharedConfig::Ptr config = KSharedConfig::openConfig(QStringLiteral("kdeglobals"));
All of the things!
looks good to me, but lets delay merging till the relevant other parts are ready.
I agree with almost all those suggestions. Though it's a lot more complex, so I might need some help with some of that.
Code is fine; both the change in KAutostart and the helper.
Sun, Mar 29
As a question, rather than a researched proposal, is it better to check for the pin in?
Be careful about mixing terms here.
Sat, Mar 28
This needs way more description and explanation of the problem it's trying to solve.
Make sure you remember to remove "WIP" from the phab request when you think we're ready for merging, otherwise no-one will do any approving.
Fri, Mar 27
Good idea. Done
Drop object library, it was too cool for some cmake versions
Seems fine to me it's analogous to a touchpad input matrix, which are also done server side.
Should I add a "supportScrollFactor" bool to make it easier of the UI side ?