davidedmundson (David Edmundson)
User

Projects (14)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 17 2015, 10:32 PM (238 w, 2 d)
Availability
Available

Recent Activity

Today

davidedmundson committed R120:419b9708ee9e: Fix binding loop in lockscreen media controls (authored by davidedmundson).
Fix binding loop in lockscreen media controls
Mon, Nov 11, 4:41 PM
davidedmundson closed D25252: Fix binding loop in lockscreen media controls.
Mon, Nov 11, 4:41 PM · Plasma
davidedmundson requested review of D25261: [sddm-theme] Fix initial focus after SDDM QQC2 Port.
Mon, Nov 11, 3:43 PM · Plasma
davidedmundson committed R120:371dc1f1ec21: [sddm-theme] Add font size to dummydata config (authored by davidedmundson).
[sddm-theme] Add font size to dummydata config
Mon, Nov 11, 2:05 PM
davidedmundson committed R118:c400f31b2652: Avoid connecting to overloaded signal (authored by davidedmundson).
Avoid connecting to overloaded signal
Mon, Nov 11, 11:50 AM
davidedmundson added inline comments to D25146: try to enforce borders settings from KWin.
Mon, Nov 11, 10:30 AM · KWin
davidedmundson requested review of D25252: Fix binding loop in lockscreen media controls.
Mon, Nov 11, 10:06 AM · Plasma

Yesterday

davidedmundson accepted D25243: Remove some unused includes.
Sun, Nov 10, 7:19 PM · KWin
davidedmundson added inline comments to D25222: [Lock Screen] Fix album art binding loop.
Sun, Nov 10, 5:56 PM · Plasma
davidedmundson added inline comments to D25205: Remove pointless QDBusServiceWatcher.
Sun, Nov 10, 5:51 PM · Plasma
davidedmundson committed R161:35e5dc950e8f: Remove pointless QDBusServiceWatcher (authored by davidedmundson).
Remove pointless QDBusServiceWatcher
Sun, Nov 10, 5:30 PM
davidedmundson closed D25205: Remove pointless QDBusServiceWatcher.
Sun, Nov 10, 5:30 PM · Plasma
davidedmundson updated the task description for T12013: Replacement of EBN.
Sun, Nov 10, 4:47 PM · Sysadmin
davidedmundson updated the task description for T12013: Replacement of EBN.
Sun, Nov 10, 4:37 PM · Sysadmin
davidedmundson updated the task description for T12013: Replacement of EBN.
Sun, Nov 10, 4:37 PM · Sysadmin
davidedmundson created T12013: Replacement of EBN.
Sun, Nov 10, 4:36 PM · Sysadmin

Sat, Nov 9

davidedmundson added inline comments to D25222: [Lock Screen] Fix album art binding loop.
Sat, Nov 9, 2:25 PM · Plasma
davidedmundson requested changes to D25222: [Lock Screen] Fix album art binding loop.

Can you talk me through how this creates a loop?

Sat, Nov 9, 1:34 PM · Plasma

Fri, Nov 8

davidedmundson accepted D25217: don't delete and recreate wallpaperinterface if not needed.
Fri, Nov 8, 3:26 PM · Frameworks
davidedmundson added a comment to D25106: Also allow invoking session restoration logic when apps are manually launched.

This method behaves weirdly and not what I expected from reading this code.

Fri, Nov 8, 1:34 PM · Frameworks
davidedmundson added a comment to D25146: try to enforce borders settings from KWin.

I've been trying to run this patch, for me it appears the same. Plastik still has a 1px dark edge with no border set.

Fri, Nov 8, 12:22 PM · KWin
davidedmundson accepted D25208: Add missing property to KKeySequenceWidget.
Fri, Nov 8, 11:47 AM · Frameworks
davidedmundson added a comment to D25146: try to enforce borders settings from KWin.

another issue is that aurorae is going to support no borders, it has to support like

breeze resizing from the shadows

Fri, Nov 8, 11:32 AM · KWin
davidedmundson committed R120:768fa9598bdf: [applets/systemtray] Downgrade required qtquick (authored by davidedmundson).
[applets/systemtray] Downgrade required qtquick
Fri, Nov 8, 10:54 AM
davidedmundson added a comment to D24720: [applets/systemtray] Rewrite popups with layouts.

(nice patch btw, I love layouts)

Fri, Nov 8, 10:49 AM · Plasma
davidedmundson requested review of D25207: [libkwineffects] Construct correct mouse event when forwarding to QtQuickView.
Fri, Nov 8, 10:46 AM · KWin
davidedmundson requested review of D25206: [aurorae] Use shared implementation of QtQuick rendering.
Fri, Nov 8, 10:44 AM · KWin
davidedmundson requested review of D25205: Remove pointless QDBusServiceWatcher.
Fri, Nov 8, 10:19 AM · Plasma
davidedmundson added a comment to D25027: feat(kcm): zoom preview automatically.

Other that Nate's sensible comment, +1

Fri, Nov 8, 9:40 AM · Plasma
davidedmundson accepted D25062: fix(kded): read rotated output size.

I don't follow why this bug was only newly introduced, but this does seem to make sense.

Fri, Nov 8, 9:38 AM · Plasma

Thu, Nov 7

davidedmundson accepted D25201: Don't set X-Plasma-MainScript for wallpaper plugins.
Thu, Nov 7, 10:37 PM · Plasma
davidedmundson accepted D25021: fix: use output hashMd5 for control files.
Thu, Nov 7, 7:39 PM · Plasma
davidedmundson added inline comments to D25020: fix: create control files only when needed.
Thu, Nov 7, 7:37 PM · Plasma
davidedmundson accepted D25195: use modern for syntax.
Thu, Nov 7, 6:19 PM · Frameworks
davidedmundson committed R295:6f8610a1431a: Add guard for missing kirigami (authored by davidedmundson).
Add guard for missing kirigami
Thu, Nov 7, 6:11 PM
davidedmundson closed D25115: Add guard for missing kirigami.
Thu, Nov 7, 6:11 PM · Frameworks
davidedmundson added a reverting change for R295:377a27db91e8: adjust margins of KCMultiDialog: R295:c9031e8d5cd7: Revert "adjust margins of KCMultiDialog".
Thu, Nov 7, 6:11 PM
davidedmundson committed R295:c9031e8d5cd7: Revert "adjust margins of KCMultiDialog" (authored by davidedmundson).
Revert "adjust margins of KCMultiDialog"
Thu, Nov 7, 6:11 PM
davidedmundson committed R295:898e2ddc8742: Revert "fix right border" (authored by davidedmundson).
Revert "fix right border"
Thu, Nov 7, 6:11 PM
davidedmundson added a reverting change for R295:47d4e46b5252: fix right border: R295:898e2ddc8742: Revert "fix right border".
Thu, Nov 7, 6:11 PM
davidedmundson abandoned D24937: Set focus on the search bar by default.
Thu, Nov 7, 6:07 PM · Plasma
davidedmundson added a comment to D25185: Icon: solve threading issue on when the source is http.

Certainly doing all this inside updatePaintNode was wrong. So, concept wise ++

Thu, Nov 7, 6:02 PM · Kirigami
davidedmundson closed T11214: Running clang-format across all plasma (and potentially over repos) as Resolved.

Update on the plasma side.

Thu, Nov 7, 2:58 PM
davidedmundson added a comment to D25190: Translates the Search placeholder in kcm_kwin_effects.

I saw from other code in plasma this was common to do this replacement.

Thu, Nov 7, 1:53 PM · KWin
davidedmundson requested changes to D25190: Translates the Search placeholder in kcm_kwin_effects.

Kirigami has:
SearchField.qml

placeholderText: qsTr("Search...")
Thu, Nov 7, 1:00 PM · KWin
davidedmundson added a comment to D25184: Define property X-Plasma-MainScript for Plasma/Wallpaper.

From wallpaper interface:

m_qmlObject->setSource(m_pkg.fileUrl("mainscript"));
Thu, Nov 7, 12:04 PM · Frameworks

Wed, Nov 6

davidedmundson moved T11914: Merge plasma-systemd-integration from To Do to Work in Progress on the Plasma board.
Wed, Nov 6, 4:56 PM · Plasma
davidedmundson added a comment to R120:328817b582fa: update panel shadows when background hints are changed.

It is, though the preferred course of action is to commit onto 5.17 first, then merge 5.17 into master. From git's POV that means we just have one ID which is easier to track.

Wed, Nov 6, 4:23 PM
davidedmundson updated the task description for T11914: Merge plasma-systemd-integration.
Wed, Nov 6, 4:08 PM · Plasma
davidedmundson accepted D25121: update panel shadows when background hints are changed.
Wed, Nov 6, 3:52 PM · Plasma
davidedmundson committed R120:b2fcd7d4a5bf: squash me (authored by davidedmundson).
squash me
Wed, Nov 6, 3:51 PM
davidedmundson committed R120:17377fe4816a: krunner (authored by davidedmundson).
krunner
Wed, Nov 6, 3:51 PM
davidedmundson committed R120:7413160c2778: handle a dev setup (authored by davidedmundson).
handle a dev setup
Wed, Nov 6, 3:51 PM
davidedmundson updated the task description for T11914: Merge plasma-systemd-integration.
Wed, Nov 6, 3:50 PM · Plasma
davidedmundson accepted D25174: Fix binding loop on toobig.
Wed, Nov 6, 3:14 PM · Kirigami
davidedmundson committed R100:80beb01fab3f: Fix overloaded signal (authored by davidedmundson).
Fix overloaded signal
Wed, Nov 6, 1:47 PM
davidedmundson closed D25172: Fix overloaded signal.
Wed, Nov 6, 1:47 PM · Plasma
davidedmundson committed R108:18a4ded30771: [wayland] Fix sha check of filtered applications (authored by davidedmundson).
[wayland] Fix sha check of filtered applications
Wed, Nov 6, 1:41 PM
davidedmundson closed D25169: [wayland] Fix sha check of filtered applications.
Wed, Nov 6, 1:41 PM · KWin
davidedmundson requested review of D25172: Fix overloaded signal.
Wed, Nov 6, 1:17 PM · Plasma
davidedmundson added a comment to T4437: [kwayland] Security filter.

What the goal is is not really agreed upon.

Wed, Nov 6, 1:08 PM · Plasma on Wayland
davidedmundson committed R240:456582e814b5: Documentation typo correction (authored by davidedmundson).
Documentation typo correction
Wed, Nov 6, 12:51 PM
davidedmundson updated the task description for T11914: Merge plasma-systemd-integration.
Wed, Nov 6, 11:49 AM · Plasma
davidedmundson updated the task description for T11914: Merge plasma-systemd-integration.
Wed, Nov 6, 11:42 AM · Plasma
davidedmundson committed R120:19b988e78a14: changes to be squashed (authored by davidedmundson).
changes to be squashed
Wed, Nov 6, 11:40 AM
davidedmundson added a reviewer for D25169: [wayland] Fix sha check of filtered applications: fvogt.
Wed, Nov 6, 11:20 AM · KWin
davidedmundson requested review of D25169: [wayland] Fix sha check of filtered applications.
Wed, Nov 6, 11:20 AM · KWin
davidedmundson added a comment to D22571: Allow blacklisting some wayland interfaces.
> diff -s /proc/$(pidof cat)/exe /proc/$(pidof cat)/root/usr/bin/cat
Files /proc/21994/exe and /proc/21994/root/usr/bin/cat are identical
> diff -s /proc/$(pidof cat)/exe /usr/bin/cat
Binary files /proc/21994/exe and /usr/bin/cat differ
Wed, Nov 6, 10:49 AM · KWin
davidedmundson added a comment to D25149: Add a new template for KCMs.

A very sensible idea. ++

Wed, Nov 6, 12:23 AM · Plasma, Frameworks

Tue, Nov 5

davidedmundson accepted D25160: [Folder View] Use an inactive highlight effect when something else has focus.
Tue, Nov 5, 7:48 PM · Plasma
davidedmundson accepted D25158: [Touchpad applet] Close query dialog on focus loss.
Tue, Nov 5, 3:46 PM · Plasma
davidedmundson committed R108:0a7aa7587002: Update tests to include newly added session quit effect (authored by davidedmundson).
Update tests to include newly added session quit effect
Tue, Nov 5, 3:03 PM
davidedmundson added inline comments to D24865: [SystemTray] Support for AttentionIcon.
Tue, Nov 5, 1:47 PM · Plasma
davidedmundson added inline comments to D24865: [SystemTray] Support for AttentionIcon.
Tue, Nov 5, 1:46 PM · Plasma
davidedmundson accepted D24865: [SystemTray] Support for AttentionIcon.
Tue, Nov 5, 1:46 PM · Plasma
davidedmundson accepted D25157: [Slideshow] Reenable other modes.
Tue, Nov 5, 1:16 PM · Plasma
davidedmundson added a comment to D24825: Add hideOnWindowDeactivate to PlasmaComponents.Dialog.

maybe there is no point in fixing this?

Tue, Nov 5, 12:55 PM · Frameworks
davidedmundson accepted D24825: Add hideOnWindowDeactivate to PlasmaComponents.Dialog.
Tue, Nov 5, 12:53 PM · Frameworks
davidedmundson accepted D24865: [SystemTray] Support for AttentionIcon.

Alternative below. IMHO it might be cleaner.

Tue, Nov 5, 12:18 PM · Plasma
davidedmundson added inline comments to D25019: Ensure that GlobalDrawer topContent always stays on top.
Tue, Nov 5, 12:07 PM · Kirigami
davidedmundson committed R119:f2d8a2f599b8: [emojier] Load locale file correctly (authored by davidedmundson).
[emojier] Load locale file correctly
Tue, Nov 5, 11:44 AM
davidedmundson closed D25156: [emojier] Load locale file correctly.
Tue, Nov 5, 11:44 AM · Plasma
davidedmundson committed R108:34bfc49189ce: adjust cmake include order (authored by davidedmundson).
adjust cmake include order
Tue, Nov 5, 10:53 AM
davidedmundson requested review of D25156: [emojier] Load locale file correctly.
Tue, Nov 5, 10:41 AM · Plasma
davidedmundson committed R109:ea7da1c6195b: port old style connects (authored by davidedmundson).
port old style connects
Tue, Nov 5, 9:34 AM
davidedmundson committed R118:1b83265682c0: port old style connects (authored by davidedmundson).
port old style connects
Tue, Nov 5, 9:01 AM
davidedmundson committed R135:655fdfb699a9: port old style connects (authored by davidedmundson).
port old style connects
Tue, Nov 5, 8:53 AM
davidedmundson committed R100:61efc0af3c01: port old style connects (authored by davidedmundson).
port old style connects
Tue, Nov 5, 8:51 AM
davidedmundson committed R99:1ca5eb10675b: port old style connects (authored by davidedmundson).
port old style connects
Tue, Nov 5, 8:50 AM
davidedmundson committed R126:7d97e81e519b: port old style connects (authored by davidedmundson).
port old style connects
Tue, Nov 5, 8:50 AM
davidedmundson committed R134:1a906cb61820: port old style connect (authored by davidedmundson).
port old style connect
Tue, Nov 5, 8:49 AM
davidedmundson added a comment to R130:5326134f1d97: Don't commit the wl_surface from outside Qt code.

That was well spotted! It wasn't intentional to push it with the clang format stuff, which is why it misses phab markers.

Tue, Nov 5, 12:09 AM
davidedmundson committed R97:405d1294457a: Port old style connects (authored by davidedmundson).
Port old style connects
Tue, Nov 5, 12:06 AM
davidedmundson committed R838:107d0aaf0ee0: Add KDEClangFormat cmake support (authored by davidedmundson).
Add KDEClangFormat cmake support
Tue, Nov 5, 12:02 AM
davidedmundson committed R128:b5da60d99f65: Add KDEClangFormat cmake support (authored by davidedmundson).
Add KDEClangFormat cmake support
Tue, Nov 5, 12:02 AM
davidedmundson committed R124:0584eb766a19: Add KDEClangFormat cmake support (authored by davidedmundson).
Add KDEClangFormat cmake support
Tue, Nov 5, 12:02 AM
davidedmundson committed R123:161e8ccfdd76: Add KDEClangFormat cmake support (authored by davidedmundson).
Add KDEClangFormat cmake support
Tue, Nov 5, 12:01 AM
davidedmundson committed R122:1e0baeaa063e: Add KDEClangFormat cmake support (authored by davidedmundson).
Add KDEClangFormat cmake support
Tue, Nov 5, 12:00 AM
davidedmundson committed R121:b4a2202d3d50: Add KDEClangFormat cmake support (authored by davidedmundson).
Add KDEClangFormat cmake support
Tue, Nov 5, 12:00 AM
davidedmundson committed R258:2e98cd15c780: Add KDEClangFormat cmake support (authored by davidedmundson).
Add KDEClangFormat cmake support
Tue, Nov 5, 12:00 AM