davidedmundson (David Edmundson)
User

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 17 2015, 10:32 PM (205 w, 1 h)
Availability
Available

Recent Activity

Yesterday

davidedmundson requested review of D19986: Install .desktop file for kded5.
Fri, Mar 22, 11:00 PM · Frameworks
davidedmundson accepted D19979: Don't create thumbnails for encrypted Vaults.
Fri, Mar 22, 9:59 PM · Frameworks
davidedmundson added a comment to D19979: Don't create thumbnails for encrypted Vaults.

There's a findByPath method on the list https://api.kde.org/frameworks/kio/html/classKMountPoint_1_1List.html#add38a82921d203856e1d1f9ddb9adbe6

Fri, Mar 22, 9:32 PM · Frameworks
davidedmundson added inline comments to D19961: Properly fix copy constructor.
Fri, Mar 22, 7:58 PM · Baloo, Frameworks

Thu, Mar 21

davidedmundson accepted D19907: Add Theme::blurBehindEnabled().
Thu, Mar 21, 6:03 PM · Frameworks
davidedmundson added a comment to D19852: Change default Klipper behavior to accept images.

This is definitely better. The part with the history saving is neat and that part is all good to go.

Thu, Mar 21, 5:44 PM · Plasma
davidedmundson accepted D19390: adjust the size of the window after the labels sizes were changed.
Thu, Mar 21, 10:57 AM · Plasma
davidedmundson accepted D19937: don't connect to lambdas and call slots when you can just call the slots.
Thu, Mar 21, 10:56 AM · Plasma
davidedmundson added inline comments to D19920: Add High DPI support.
Thu, Mar 21, 12:24 AM

Wed, Mar 20

davidedmundson accepted D19921: RFC: Fix wayland backend initialisation.
Wed, Mar 20, 5:27 PM · KWin
davidedmundson added a comment to D19921: RFC: Fix wayland backend initialisation.

I don't get a crash and the patch itself is correct.

Wed, Mar 20, 5:24 PM · KWin
davidedmundson accepted D19922: Don't try to resize desktop or fullscreen windows.
Wed, Mar 20, 4:46 PM · KWin
davidedmundson added a comment to D19469: [sddm-theme] Update login screen preview image.

Sorry it's been taking so long, I've been having the hardest time getting virtualbox to work...

Wed, Mar 20, 1:47 PM · Plasma
davidedmundson accepted D19907: Add Theme::blurBehindEnabled().
Wed, Mar 20, 11:42 AM · Frameworks
davidedmundson accepted D19909: Enable blurbehind for panels only if theme sets it.
Wed, Mar 20, 11:41 AM · Plasma
davidedmundson closed D19888: Add runtime guard that pages are KCMs in KCMultiDialog.
Wed, Mar 20, 9:35 AM · Frameworks
davidedmundson committed R295:d9ddd3524535: Add runtime guard that pages are KCMs in KCMultiDialog (authored by davidedmundson).
Add runtime guard that pages are KCMs in KCMultiDialog
Wed, Mar 20, 9:35 AM
davidedmundson accepted D18818: virtualkeyboard: resize the focused window to make room for the keyboard.
Wed, Mar 20, 9:18 AM · KWin

Tue, Mar 19

davidedmundson accepted D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption.
Tue, Mar 19, 9:25 PM · Plasma
davidedmundson updated the title for P349 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Tue, Mar 19, 8:26 PM
davidedmundson requested review of D19888: Add runtime guard that pages are KCMs in KCMultiDialog.
Tue, Mar 19, 5:24 PM · Frameworks
davidedmundson added a comment to D19731: Have kwin understand that a transformation isn't supported.

IMHO, if we have a patch that does software rotation (which I know you're working on) we should simplify the code and just remove all the hardware rotation.

Tue, Mar 19, 3:40 PM · KWin
davidedmundson added a comment to D18570: EGLStream DRM Backend Initial Implementation.

The desktop is still essentially usable with them present, right?

Tue, Mar 19, 3:03 PM · KWin
davidedmundson added a comment to D18818: virtualkeyboard: resize the focused window to make room for the keyboard.

Cool. Seems to work nicely, even with any weird edge cases I've thrown at it.
In general ++

Tue, Mar 19, 1:56 PM · KWin
davidedmundson added a comment to D18570: EGLStream DRM Backend Initial Implementation.

Code still looks good. +1 from me

Tue, Mar 19, 9:49 AM · KWin
davidedmundson accepted D18376: Fix software cursors with drm backend.

Ah, so the connect line is just a code tidy up not trying to be an important behavioural change. I misunderstood.

Tue, Mar 19, 9:35 AM · KWin
davidedmundson updated the title for P348 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Tue, Mar 19, 9:27 AM
davidedmundson accepted D19867: [X11] Force glXSwapBuffers to block with NVIDIA driver.

The rationale all makes sense.
Thanks for investigating this.

Tue, Mar 19, 9:22 AM · KWin

Mon, Mar 18

Restricted Application added a project to D19860: Software rotation: orient the screen regardless of whether drm accepted it: KWin.
Mon, Mar 18, 10:29 PM · KWin
davidedmundson added a comment to D19852: Change default Klipper behavior to accept images.

We don't use goto.

Mon, Mar 18, 3:02 PM · Plasma
davidedmundson added a comment to D19852: Change default Klipper behavior to accept images.

It means only spectacle fills memory, not doing work in gimp.

Mon, Mar 18, 2:04 PM · Plasma
davidedmundson accepted D19604: Make it possible to autodetect the tablet mode.
Mon, Mar 18, 1:54 PM · KWin
davidedmundson accepted D19781: [platforms/drm] Add DPI connector type.
Mon, Mar 18, 1:52 PM · KWin
davidedmundson requested changes to D19852: Change default Klipper behavior to accept images.

You're just going to burn through memory like crazy. We can't do this.
It also doesn't properly fix the klipper issue as it then breaks for anyone who has changed the setting.

Mon, Mar 18, 1:33 PM · Plasma

Sun, Mar 17

davidedmundson added inline comments to D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption.
Sun, Mar 17, 10:03 PM · Plasma
davidedmundson updated the title for P346 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Sun, Mar 17, 9:54 PM
davidedmundson accepted D18703: [kcmkwin] Split out Desktop Effects KCM.

At least that transient problem is fully understood. We have to solve that somewhere else as it affects the other KCMs.
Can you file a bug report (or phab task or whatever) copying the messages above so it doesn't get lost, and then lets get this shipped.

Sun, Mar 17, 9:41 PM · KWin
davidedmundson accepted D19705: Force server-side decoration if no borders are forced by user.

Seems sensible.

Sun, Mar 17, 9:29 PM · KWin
davidedmundson accepted D19411: [wayland] Apply window rules only to xdg-shell clients.
Sun, Mar 17, 8:39 PM · KWin
davidedmundson accepted D19722: Get rid of Deleted's properties.
Sun, Mar 17, 8:01 PM · KWin
davidedmundson abandoned D18357: [applets/mediaframe] Resize combobox to contents.

Sorry, I forgot about this. AFAIK Nate rewrote media frame to QQC2 anyway.

Sun, Mar 17, 7:59 PM · Plasma

Wed, Mar 13

davidedmundson added a comment to D19613: Support NET_WM_STATE_FOCUSED.

Gtk can easily check whether the window manager supports this property and if not do the same as this patch does.

Wed, Mar 13, 7:15 PM · KWin

Tue, Mar 12

davidedmundson added a comment to D19705: Force server-side decoration if no borders are forced by user.

I just read the title guessed you were talking about any server side decos.
You are correct. Sorry

Tue, Mar 12, 7:23 PM · KWin
davidedmundson added a comment to D19705: Force server-side decoration if no borders are forced by user.

GTK doesn't support xdg-decoration. :D

Tue, Mar 12, 5:35 PM · KWin

Fri, Mar 8

davidedmundson accepted D18809: Image Wallpaper Slideshow - display the list of images that will be shown.

Good stuff! I'm hoping we see more of your commits in the future

Fri, Mar 8, 10:48 PM · Plasma
davidedmundson added inline comments to D19617: Support NET_WM_STATE_FOCUSED.
Fri, Mar 8, 5:59 PM · Frameworks
davidedmundson added a dependency for D19617: Support NET_WM_STATE_FOCUSED: D19613: Support NET_WM_STATE_FOCUSED.
Fri, Mar 8, 4:38 PM · Frameworks
davidedmundson added a dependent revision for D19613: Support NET_WM_STATE_FOCUSED: D19617: Support NET_WM_STATE_FOCUSED.
Fri, Mar 8, 4:38 PM · KWin
davidedmundson requested review of D19617: Support NET_WM_STATE_FOCUSED.
Fri, Mar 8, 4:37 PM · Frameworks
davidedmundson requested review of D19613: Support NET_WM_STATE_FOCUSED.
Fri, Mar 8, 3:36 PM · KWin
davidedmundson added a comment to D19604: Make it possible to autodetect the tablet mode.

Concept seems sensible.

Fri, Mar 8, 2:07 PM · KWin
davidedmundson accepted D19178: [platforms/x11] Properly unload effects on X11.
Fri, Mar 8, 2:04 PM · KWin
davidedmundson accepted D19199: [platforms/fbdev] Port to AbstractOutput.
Fri, Mar 8, 2:03 PM · KWin
davidedmundson added a comment to D19603: Fix colours of header bar for active and inactive windows.

Are GTK developers aware of this problem?

Fri, Mar 8, 11:58 AM · Plasma
davidedmundson added inline comments to D18818: virtualkeyboard: resize the focused window to make room for the keyboard.
Fri, Mar 8, 11:35 AM · KWin
davidedmundson added a comment to D19603: Fix colours of header bar for active and inactive windows.
Fri, Mar 8, 11:29 AM · Plasma
davidedmundson added a comment to D19603: Fix colours of header bar for active and inactive windows.

What's the reason for removing the linear gradient?

Fri, Mar 8, 10:42 AM · Plasma
davidedmundson updated the summary of D19603: Fix colours of header bar for active and inactive windows.
Fri, Mar 8, 10:24 AM · Plasma
davidedmundson added a comment to D19603: Fix colours of header bar for active and inactive windows.

two window titles of different colours matching breeze.

Fri, Mar 8, 1:18 AM · Plasma
davidedmundson requested review of D19603: Fix colours of header bar for active and inactive windows.
Fri, Mar 8, 1:17 AM · Plasma
davidedmundson added a comment to D18818: virtualkeyboard: resize the focused window to make room for the keyboard.

hmm, those windows would need a flag saying it's un-maximizable?

Fri, Mar 8, 12:27 AM · KWin
davidedmundson accepted D18465: [platforms/wayland] Multi output support.
Fri, Mar 8, 12:19 AM · KWin
davidedmundson accepted D19414: [wayland] Implement maximize rules.
Fri, Mar 8, 12:18 AM · KWin

Thu, Mar 7

davidedmundson added a comment to D19411: [wayland] Apply window rules only to xdg-shell clients.

Currently, xdg-shell protocol doesn't have any mechanism that a client could use to notify the compositor about its intent to map.

Thu, Mar 7, 11:11 PM · KWin
davidedmundson added inline comments to D19520: Properly restore current desktop from session.
Thu, Mar 7, 8:13 PM · KWin
davidedmundson accepted D19520: Properly restore current desktop from session.
Thu, Mar 7, 8:07 PM · KWin
davidedmundson added inline comments to D19214: [sddm-theme] Replace login button label with icon.
Thu, Mar 7, 2:42 PM · Plasma
davidedmundson added inline comments to D19214: [sddm-theme] Replace login button label with icon.
Thu, Mar 7, 2:19 PM · Plasma
davidedmundson added a comment to D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons.

Visual indication on mouseover is generally a good thing ++

Thu, Mar 7, 12:22 PM · Plasma
davidedmundson accepted D19580: Use high dpi pixmaps.
Thu, Mar 7, 12:13 PM · Plasma

Wed, Mar 6

davidedmundson added a comment to D19310: [WIP] Port to KGlobalAccel.

The calls to KGlobalaccel are still needed. Removing them from the updatescript caused the user specified shortcuts to be the default shortcuts.

Wed, Mar 6, 9:51 PM · Spectacle
davidedmundson committed R278:abcf323ab6f3: Send blur/background contrast in device pixels (authored by davidedmundson).
Send blur/background contrast in device pixels
Wed, Mar 6, 9:43 PM
davidedmundson closed D19544: Send blur/background contrast in device pixels.
Wed, Mar 6, 9:43 PM · Frameworks
davidedmundson accepted D19566: [OSD] Fix animation stutter.
Wed, Mar 6, 3:00 PM · Plasma

Tue, Mar 5

davidedmundson added a comment to D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption.

Would it be better to set the sourceSize? If we're downscaling during rendering we're wasting memory

Tue, Mar 5, 10:31 PM · Plasma
davidedmundson added inline comments to D19419: [KdePlasma-Addons/POTD/NOAA] Fixed RegEx string to suit latest changes on the webpage.
Tue, Mar 5, 10:19 PM · Plasma
davidedmundson accepted D19552: [effects/screenshot] Set m_windowMode in screenshotWindowUnderCursor.
Tue, Mar 5, 9:58 PM · KWin
davidedmundson added a comment to D19310: [WIP] Port to KGlobalAccel.

Maybe I should move this to a phab task, but I've done some looking:

Tue, Mar 5, 5:13 PM · Spectacle
davidedmundson added a comment to D19310: [WIP] Port to KGlobalAccel.

kconfupdate is fine for migration. That code looks somewhat sensible.

Tue, Mar 5, 4:44 PM · Spectacle
davidedmundson added inline comments to D19544: Send blur/background contrast in device pixels.
Tue, Mar 5, 4:39 PM · Frameworks
davidedmundson requested review of D19544: Send blur/background contrast in device pixels.
Tue, Mar 5, 3:30 PM · Frameworks
davidedmundson added a comment to D18818: virtualkeyboard: resize the focused window to make room for the keyboard.

[Wednesday, 27 February 2019] [16:40:39 GMT] <notmart> Android has actually 3 modes: resize the window, just tell the app of the area and shift the whole window up
[Wednesday, 27 February 2019] [16:40:49 GMT] <notmart> which is defined by the app

Tue, Mar 5, 2:58 PM · KWin
davidedmundson accepted D18912: [libinput-touchpad-kcm-click-method] Add click method Areas and Clickfinger for buttonless touchpads.
Tue, Mar 5, 2:35 PM · Plasma
davidedmundson committed R123:e2f7ead351ee: Revert "Fix autologin session loading" (authored by davidedmundson).
Revert "Fix autologin session loading"
Tue, Mar 5, 2:24 PM
davidedmundson added a reverting change for R123:634a2dd1bef5: Fix autologin session loading: R123:e2f7ead351ee: Revert "Fix autologin session loading".
Tue, Mar 5, 2:24 PM
davidedmundson added a comment to D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background.

The original rationale of the time of having the black background was to hide the flickering blank framebuffer as we switch from SDDM to the login - and we're autologigng in we're coming from a black background too. From a tech POV I like that because loading a wallpaper is quite CPU consuming.

Tue, Mar 5, 1:36 PM · Plasma
davidedmundson accepted D19540: Verify that there is no scene windows when Scene is about to be destroyed.
Tue, Mar 5, 1:16 PM · KWin
davidedmundson committed R296:715ce3c20837: Avoid fractionals in GridDelegate sizes and alignments (authored by davidedmundson).
Avoid fractionals in GridDelegate sizes and alignments
Tue, Mar 5, 1:10 PM
davidedmundson closed D19530: Avoid fractionals in GridDelegate sizes and alignments.
Tue, Mar 5, 1:10 PM · Frameworks
davidedmundson updated the diff for D7732: Force KAuth helpers to have UTF-8 support.

Add comment

Tue, Mar 5, 12:03 PM · Frameworks
davidedmundson added a comment to D7732: Force KAuth helpers to have UTF-8 support.

I'm not sure changing the codec for all kauth stuff is the best

Tue, Mar 5, 12:02 PM · Frameworks
davidedmundson committed R120:291166675703: Port SessionsModel away from KDisplayManager (authored by davidedmundson).
Port SessionsModel away from KDisplayManager
Tue, Mar 5, 11:50 AM
davidedmundson committed R120:0416f628975c: Port all to libkworkspace2 (authored by davidedmundson).
Port all to libkworkspace2
Tue, Mar 5, 11:50 AM
davidedmundson committed R120:a7528785fb92: [WIP] Rewrite kworkspace logout, shutdown and suspend API (authored by davidedmundson).
[WIP] Rewrite kworkspace logout, shutdown and suspend API
Tue, Mar 5, 11:50 AM
davidedmundson accepted D19536: [autotests] Fix KWindowInfoX11Test::testState.
Tue, Mar 5, 11:13 AM · Frameworks
davidedmundson added a comment to D19536: [autotests] Fix KWindowInfoX11Test::testState.

Autotests aren't only run on KDE CI.

Tue, Mar 5, 10:39 AM · Frameworks

Mon, Mar 4

davidedmundson requested review of D19530: Avoid fractionals in GridDelegate sizes and alignments.
Mon, Mar 4, 10:10 PM · Frameworks
davidedmundson added a comment to D19392: shannon entropy to guess monochrome icon.

so, for gtk4/qt6, the base qiconengine included in qt should support whatever coloring is used, in which case i wouldn't need to do anything on my part.. tough that's for Qt6.

Mon, Mar 4, 5:29 PM · Kirigami
davidedmundson committed R120:68a2807654c6: Only match service text strings once (authored by davidedmundson).
Only match service text strings once
Mon, Mar 4, 5:21 PM
davidedmundson closed D19475: Only match service text strings once.
Mon, Mar 4, 5:21 PM · Plasma