davidedmundson (David Edmundson)
User

Projects (14)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 17 2015, 10:32 PM (214 w, 2 d)
Availability
Available

Recent Activity

Today

davidedmundson accepted D21426: Remove unrelated code to make sure oxygen font is installed.

We need to do something to make sure startkde and startplasma/startplasmacompositor don't keep going out of sync.

Mon, May 27, 10:27 AM · Plasma
davidedmundson added inline comments to D21408: RFC: [Notifications] Better notification number alignment.
Mon, May 27, 8:33 AM · Plasma
davidedmundson accepted D21335: Don't write a anti-aliasing settings from startkde.
Mon, May 27, 7:05 AM · Plasma
davidedmundson committed R242:39d1db6e49da: Export SortFilterModel sort column to QML (authored by davidedmundson).
Export SortFilterModel sort column to QML
Mon, May 27, 7:03 AM
davidedmundson closed D21419: Export SortFilterModel sort column to QML.
Mon, May 27, 7:03 AM · Frameworks

Yesterday

davidedmundson requested review of D21419: Export SortFilterModel sort column to QML.
Sun, May 26, 6:31 PM · Frameworks

Fri, May 24

davidedmundson accepted D21181: [Notifications] Ensure "Open" and "More Options" button have the same height.
Fri, May 24, 1:40 PM · Plasma
davidedmundson updated the title for P392 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Fri, May 24, 12:58 AM

Thu, May 23

davidedmundson updated the title for P391 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Thu, May 23, 11:19 PM
davidedmundson accepted D17097: [scripting] Emit clientAdded for Wayland clients.
Thu, May 23, 1:38 PM · KWin
davidedmundson added a comment to D17097: [scripting] Emit clientAdded for Wayland clients.

The only way to make the D-Bus interface safe is to remove it.

Thu, May 23, 1:23 PM · KWin
davidedmundson added a comment to T10958: Faster Startup.

Now Qt stores its plugin information into cbor instead of the former non-standard binary json format.

Thu, May 23, 12:07 PM · Plasma

Wed, May 22

davidedmundson added a comment to D21342: [kcmkwin/touchscreen+screenedges] Call KRunner KRunner.

Code wise it's obviously fine and the goal of being consistent definitely makes sense.

Wed, May 22, 2:36 PM · KWin
davidedmundson accepted D21336: Get PaginateModel class ready for frameworks.

nice 🐿

Wed, May 22, 11:48 AM · Plasma
davidedmundson updated the diff for D21326: Make limtedrowcountproxymodel usable from QML.

update

Wed, May 22, 1:24 AM · Plasma
davidedmundson committed R120:a282bc9d612a: Don't assign a QtObject to a model (authored by davidedmundson).
Don't assign a QtObject to a model
Wed, May 22, 1:13 AM
davidedmundson closed D21274: Don't assign a QtObject to a model.
Wed, May 22, 1:13 AM · Plasma

Tue, May 21

davidedmundson updated the diff for D21328: Add qml import for KItemModels.

Sync copyright headers to existing style

Tue, May 21, 11:54 PM · Frameworks
davidedmundson updated the summary of D21328: Add qml import for KItemModels.
Tue, May 21, 11:50 PM · Frameworks
davidedmundson requested review of D21328: Add qml import for KItemModels.
Tue, May 21, 11:43 PM · Frameworks
davidedmundson committed R244:6a686c28d386: Fix compliation for python bindings (authored by davidedmundson).
Fix compliation for python bindings
Tue, May 21, 9:32 PM
davidedmundson requested review of D21326: Make limtedrowcountproxymodel usable from QML.
Tue, May 21, 9:27 PM · Plasma
davidedmundson added a comment to D21279: [sddm-theme] Add spacing between action buttons' labels.

This is an ugly hack.

Tue, May 21, 5:38 PM · Plasma
davidedmundson accepted D21319: make AcceptingInputStatus work.
Tue, May 21, 4:11 PM · Plasma
davidedmundson added a comment to D21274: Don't assign a QtObject to a model.

FWIW, the relevant Qt bug is fixed.

Tue, May 21, 12:30 PM · Plasma
davidedmundson accepted D21302: [tabbox] Properly determine depressed modifiers on X11.
Tue, May 21, 12:24 PM · KWin
davidedmundson updated the task description for T10958: Faster Startup.
Tue, May 21, 11:53 AM · Plasma
davidedmundson updated the task description for T10958: Faster Startup.
Tue, May 21, 11:31 AM · Plasma
davidedmundson updated the task description for T10958: Faster Startup.
Tue, May 21, 11:07 AM · Plasma
davidedmundson updated the diff for D20890: Close screen grabbing effect when screensaver starts.

update

Tue, May 21, 9:48 AM · KWin

Mon, May 20

davidedmundson added a comment to D21274: Don't assign a QtObject to a model.

That would still hit the Qt crash unless I declare all used properties, which is the part I wanted to avoid.

Mon, May 20, 3:33 PM · Plasma
davidedmundson accepted D21303: Set application name to org_kde_powerdevil.

Probably needs a matching
KAboutData::setProductName to "powerdevil"

Mon, May 20, 12:34 PM · Plasma

Sun, May 19

davidedmundson updated the task description for T10958: Faster Startup.
Sun, May 19, 3:00 PM · Plasma
davidedmundson renamed T10958: Faster Startup from Startup to Faster Startup.
Sun, May 19, 2:59 PM · Plasma
davidedmundson created T10958: Faster Startup.
Sun, May 19, 2:59 PM · Plasma

Sat, May 18

davidedmundson requested changes to D21278: [Touchpad KCM] Fix kded crashing at startup.

m_connection seems to be having null or 0x0 value.

Sat, May 18, 10:03 PM · Plasma
davidedmundson accepted D21268: Add missing includes.
Sat, May 18, 6:41 PM · Plasma
davidedmundson added a comment to D19745: Fix system tray UI/UX & refactor.

Please, check whether 'LayoutMirroring' works properly.

Sat, May 18, 6:35 PM · Plasma
davidedmundson accepted D19745: Fix system tray UI/UX & refactor.
Sat, May 18, 6:33 PM · Plasma
davidedmundson requested review of D21274: Don't assign a QtObject to a model.
Sat, May 18, 5:19 PM · Plasma

Fri, May 17

davidedmundson added inline comments to D21262: Fix memory leak.
Fri, May 17, 10:42 PM · KWin
davidedmundson accepted D21263: Don't call << in a temporary vector.
Fri, May 17, 10:37 PM · KWin
davidedmundson requested changes to D17704: Copy to clipboard always copy English texts.

Am I right that this can be closed as D17773 obsoletes this.

Fri, May 17, 12:11 AM · Plasma
davidedmundson requested changes to D18579: Rework Sensor Browser.

Marking as requst changes due till we get the minor comments from zzag done

Fri, May 17, 12:09 AM · Plasma
davidedmundson requested changes to D18884: Workaround to prevent recursive handling of wakeup.

Under certain circumstances, Core::onResumingFromIdle triggers an action, which causes Core::resumingFromIdle to be emitted.

Fri, May 17, 12:08 AM · Plasma
davidedmundson added a comment to D21076: ICC Color Correction Effect.

Yeah, you're right. Under their scheme the relevant app is meant to do it, not the compositor.
Thanks for the link.

Fri, May 17, 12:04 AM · KWin
davidedmundson accepted D19676: Fix out of bounds access error in SystemLoadViewer.qml.
Fri, May 17, 12:01 AM · Plasma

Thu, May 16

davidedmundson added a comment to D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI.

@broulik Do you want to commandeer this revision and do the rest?

Thu, May 16, 11:57 PM · Plasma
davidedmundson accepted D19865: Linux softraid: Define _GNU_SOURCE for pipe2.

Do you have commit access?

Thu, May 16, 11:54 PM · Plasma
davidedmundson accepted D20449: a11y: fix focus handling for clipboard plasmoid.
Thu, May 16, 11:54 PM · Plasma Accessibility
davidedmundson accepted D20222: Plasma-Workspace. The last checkbox in the widget settings.

Generally I don't like things being blocked for no discernable reason. It makes toggling between two things order dependent.

Thu, May 16, 11:42 PM · Plasma
davidedmundson committed R111:098415b77325: Merge branch 'Plasma/5.16' (authored by davidedmundson).
Merge branch 'Plasma/5.16'
Thu, May 16, 11:38 PM
davidedmundson committed R111:7904e204a12c: Hide the new NNP column by default (authored by topimiettinen).
Hide the new NNP column by default
Thu, May 16, 11:37 PM
davidedmundson closed D20901: Hide the new NNP column by default.
Thu, May 16, 11:37 PM · Plasma
davidedmundson added a comment to D21076: ICC Color Correction Effect.

They only load 1-dimensional LUTs ("VCGT" tag, Video Card Gamma Table) into the video card.

Thu, May 16, 11:36 PM · KWin
davidedmundson accepted D20584: ProcessList: add NoNewPrivileges.
Thu, May 16, 11:34 PM · Plasma
davidedmundson accepted D20786: ProcessList: add support for cgroups.
Thu, May 16, 11:31 PM · Plasma
davidedmundson accepted D21116: Keep internal clients in the unmanaged layer.
Thu, May 16, 11:11 PM · KWin
davidedmundson added a comment to D21147: Null pointer dereference at ksysguard.

I don't know the procedure though; should I do anything?

Thu, May 16, 11:09 PM · Plasma
davidedmundson accepted D21228: [Touchpad KCM] Load previous setting on reboot.
Thu, May 16, 12:04 PM · Plasma
davidedmundson added a comment to D20972: [sidebar] Make search field not glued to the separator.

When anchors.margins is removed we see that the ToolButton still has 1px of its own margin around it

Thu, May 16, 9:38 AM · Plasma

Wed, May 15

davidedmundson requested changes to D21228: [Touchpad KCM] Load previous setting on reboot.
Wed, May 15, 7:34 PM · Plasma
davidedmundson added a comment to D21226: search for a default wallpaper in lookandfeel.

Didn't we move contents/layout.js to be part of the lookandfeel and that was the previous way to set a default wallpaper?

Wed, May 15, 2:18 PM · Plasma
davidedmundson added a comment to D21083: [effects/presentwindows] Allow closing windows on middle-click.

On the other note, I don't like that the new option is off by default. It will definitely have discoverability problems!

Wed, May 15, 1:51 PM · KWin
davidedmundson added inline comments to D21221: [Notes] Port to QQC2 and use GridView KCM components for the color chooser.
Wed, May 15, 1:15 PM · Plasma
davidedmundson added a comment to D19745: Fix system tray UI/UX & refactor.

I love use of layouts for everything, so in general ++

Wed, May 15, 9:55 AM · Plasma
davidedmundson accepted D21097: Handle apps which set the desktopFileName property with filename suffix.
Wed, May 15, 9:25 AM · Plasma
davidedmundson accepted D21224: [effects/thumbnailaside] Specify screen projection matrix.
Wed, May 15, 9:22 AM · KWin

Tue, May 14

davidedmundson accepted D21220: [Touchpad KCM] Fix libinput-less build and warnings.
Tue, May 14, 10:30 PM · Plasma
davidedmundson accepted D20859: Crash in sddmthemeinstaller invalid use of errorString.
Tue, May 14, 7:58 PM · Plasma
davidedmundson accepted D21217: Port away from deprecated qFind.
Tue, May 14, 3:36 PM · KWin
davidedmundson closed D20595: Implement set_window_geometry.
Tue, May 14, 12:51 PM · Frameworks
davidedmundson committed R127:6da6c7c7e090: Implement set_window_geometry (authored by davidedmundson).
Implement set_window_geometry
Tue, May 14, 12:51 PM
davidedmundson accepted D21209: drop internal os-release class in favor of KOSRelease of kcoreaddons 5.58.
Tue, May 14, 12:17 PM · Plasma
davidedmundson accepted D20987: Compute correct boundaries in checkWorkspacePosition.
Tue, May 14, 11:41 AM · KWin
davidedmundson added a comment to D20595: Implement set_window_geometry.

marking inline comments as done

Tue, May 14, 10:11 AM · Frameworks

Mon, May 13

davidedmundson added a comment to D19867: [X11] Force glXSwapBuffers to block with NVIDIA driver.

(shall we just move this discussion there going forward?)

Mon, May 13, 9:00 PM · KWin
davidedmundson added a comment to D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end.

I don't want SDDM and the lockscreen to have subtly different behaviours.

Mon, May 13, 7:43 PM · Plasma
davidedmundson accepted D21179: FrameSvgItem: emit maskChanged always from doUpdate().
Mon, May 13, 4:41 PM · Frameworks
davidedmundson added a comment to D21076: ICC Color Correction Effect.

Lets evaluate the concept before we fuss over code details, otherwise we're doing it in the wrong order.

Mon, May 13, 11:45 AM · KWin
davidedmundson accepted D21184: Take the screen geometry into account when positioning popup notifications.
Mon, May 13, 11:32 AM · Plasma
davidedmundson requested changes to D21181: [Notifications] Ensure "Open" and "More Options" button have the same height.

See my last comment on the bug. Sorry.

Mon, May 13, 9:09 AM · Plasma
davidedmundson committed R242:0bd2ea178f01: Add test for buttons with icon height (authored by davidedmundson).
Add test for buttons with icon height
Mon, May 13, 8:56 AM
davidedmundson accepted D21172: FrameSvg: also clear mask cache on clearCache().
Mon, May 13, 8:18 AM · Frameworks
davidedmundson accepted D21180: Check if service is still registered before showing progress.
Mon, May 13, 7:55 AM · Plasma

Sun, May 12

davidedmundson accepted D21167: Add Messages.sh.
Sun, May 12, 8:49 PM · Plasma
davidedmundson added a comment to T8177: Run plasmashell with "PLASMA_USE_QT_SCALING=1" : Wait until 18.10; re-test.

Run plasmashell with "PLASMA_USE_QT_SCALING=1" : Wait until 18.10; re-test

Sun, May 12, 3:40 PM · Kubuntu

Sat, May 11

davidedmundson accepted D21137: [Notifications] Rename device name to origin name.
Sat, May 11, 8:21 AM · Plasma

Fri, May 10

davidedmundson committed R108:24cbe48656b7: Revert "Handle XdgShell window geometry in configure request sizes" (authored by davidedmundson).
Revert "Handle XdgShell window geometry in configure request sizes"
Fri, May 10, 8:45 PM
davidedmundson added a reverting change for R108:bc83065cebd7: Handle XdgShell window geometry in configure request sizes: R108:24cbe48656b7: Revert "Handle XdgShell window geometry in configure request sizes".
Fri, May 10, 8:45 PM
davidedmundson added a comment to D21083: [effects/presentwindows] Allow closing windows on middle-click.

I won that fight over your objections
You were simply wrong about that. And that's fine!

Fri, May 10, 4:02 PM · KWin
davidedmundson committed R108:bc83065cebd7: Handle XdgShell window geometry in configure request sizes (authored by davidedmundson).
Handle XdgShell window geometry in configure request sizes
Fri, May 10, 3:35 PM
davidedmundson closed D20937: Handle XdgShell window geometry in configure request sizes.
Fri, May 10, 3:35 PM · KWin
davidedmundson committed R108:ce1a5eae156a: Support NET_WM_STATE_FOCUSED (authored by davidedmundson).
Support NET_WM_STATE_FOCUSED
Fri, May 10, 3:21 PM
davidedmundson closed D19613: Support NET_WM_STATE_FOCUSED.
Fri, May 10, 3:21 PM · KWin
davidedmundson closed D19603: Fix colours of header bar for active and inactive windows.
Fri, May 10, 3:20 PM · Plasma
davidedmundson committed R98:df538d149294: Fix colours of header bar for acitve and inactive windows (authored by davidedmundson).
Fix colours of header bar for acitve and inactive windows
Fri, May 10, 3:20 PM
davidedmundson accepted D21129: Require KF5 5.58.0 like the rest of Plasma.
Fri, May 10, 2:36 PM · Plasma
davidedmundson accepted D18933: Allow compositors to send discrete axis values.
Fri, May 10, 2:05 PM · Frameworks
davidedmundson committed R111:58770026d43a: Update tests cmake to WebEngine port (authored by davidedmundson).
Update tests cmake to WebEngine port
Fri, May 10, 11:44 AM