davidedmundson (David Edmundson)
User

Projects (14)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 17 2015, 10:32 PM (230 w, 2 d)
Availability
Available

Recent Activity

Today

davidedmundson updated the title for P465 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Mon, Sep 16, 3:45 PM
davidedmundson committed R120:5ff12878e965: Avoid crash if kicker plugin is used outside plasma context (authored by davidedmundson).
Avoid crash if kicker plugin is used outside plasma context
Mon, Sep 16, 12:17 PM
davidedmundson committed R120:e4337b81f8fa: Fix QLatin1String usage (authored by davidedmundson).
Fix QLatin1String usage
Mon, Sep 16, 12:17 PM
davidedmundson committed R120:892b1b9e782c: Fix model updates in RunnerMatchesModel (authored by davidedmundson).
Fix model updates in RunnerMatchesModel
Mon, Sep 16, 12:17 PM
davidedmundson committed R120:5ae605362d6a: Merge branch 'Plasma/5.11' (authored by davidedmundson).
Merge branch 'Plasma/5.11'
Mon, Sep 16, 12:16 PM
davidedmundson committed R120:615f6ac12753: Fix crash in KAStatsFavouritesModel (authored by davidedmundson).
Fix crash in KAStatsFavouritesModel
Mon, Sep 16, 12:16 PM
davidedmundson committed R120:83ef0d4d596c: Kicker: Use QtLoggingRules (authored by davidedmundson).
Kicker: Use QtLoggingRules
Mon, Sep 16, 12:16 PM
davidedmundson committed R120:6846731f9fbf: QLatin1String-ify (authored by davidedmundson).
QLatin1String-ify
Mon, Sep 16, 12:16 PM
davidedmundson committed R120:68adea4e81c2: Remove local copy of dialog.h (authored by davidedmundson).
Remove local copy of dialog.h
Mon, Sep 16, 12:16 PM
davidedmundson committed R120:0254bb3c6fd3: Return valid string value for DescriptionRole in all models (authored by davidedmundson).
Return valid string value for DescriptionRole in all models
Mon, Sep 16, 12:16 PM
davidedmundson committed R120:f86d6b3a0d31: Make AppstreamQt optional (authored by davidedmundson).
Make AppstreamQt optional
Mon, Sep 16, 12:16 PM
davidedmundson committed R120:26077b8f2b8a: Remove outdated PackageKit include (authored by davidedmundson).
Remove outdated PackageKit include
Mon, Sep 16, 12:16 PM
davidedmundson committed R120:1c97d16fe40b: Merge branch 'Plasma/5.8' (authored by davidedmundson).
Merge branch 'Plasma/5.8'
Mon, Sep 16, 12:16 PM
davidedmundson committed R120:d108387afd2b: Let kicker display executable items instead of empty buttons. (authored by ochurlaud).
Let kicker display executable items instead of empty buttons.
Mon, Sep 16, 12:16 PM
davidedmundson committed R120:affad04d31ca: Don't load system apps model twice (authored by davidedmundson).
Don't load system apps model twice
Mon, Sep 16, 12:16 PM
davidedmundson committed R120:11bd584db638: Port derpecated authorizeKAction to authorizeAction (authored by davidedmundson).
Port derpecated authorizeKAction to authorizeAction
Mon, Sep 16, 12:16 PM
davidedmundson committed R120:69e67094a2b7: Lazy guard for KServiceGroup::root() being null. (authored by davidedmundson).
Lazy guard for KServiceGroup::root() being null.
Mon, Sep 16, 12:16 PM
davidedmundson committed R120:151c43172f6e: Fix kicker launching (authored by davidedmundson).
Fix kicker launching
Mon, Sep 16, 12:16 PM
davidedmundson committed R120:0788057414ff: Fix usage of string "shutdown" and "restart" (authored by davidedmundson).
Fix usage of string "shutdown" and "restart"
Mon, Sep 16, 12:16 PM
davidedmundson committed R120:59b7e75b2abd: Add missing countChanged (authored by davidedmundson).
Add missing countChanged
Mon, Sep 16, 12:16 PM
davidedmundson committed R120:d61da92dca8f: Merge branch 'Plasma/5.4' (authored by davidedmundson).
Merge branch 'Plasma/5.4'
Mon, Sep 16, 12:15 PM
davidedmundson committed R120:4cd7138330a6: Don't start an eventLoop from QML in menu entry editing (authored by davidedmundson).
Don't start an eventLoop from QML in menu entry editing
Mon, Sep 16, 12:15 PM
davidedmundson accepted D23987: Enable HiDPI rendering for rules dialog and killer dialog..
Mon, Sep 16, 12:01 PM · KWin
davidedmundson closed T9093: Remove QT_QPA_PLATFORM Wayland workaround as Wontfix.

SuSE still use this "feature" for making plasma run in wayland, and all clients in XCB.

Mon, Sep 16, 11:34 AM · Plasma on Wayland
davidedmundson accepted D23986: [plugins/scenes/opengl] Use linear filter on Wayland.
Mon, Sep 16, 10:58 AM · KWin
davidedmundson added inline comments to D23984: [System Settings] redesign intro page.
Mon, Sep 16, 10:33 AM · VDG, Plasma

Sat, Sep 14

davidedmundson accepted D23894: [KDeclarative] Port from deprecated QWheelEvent::delta() to angleDelta().

Kf6 ideally we drop this whole class and the new event handlers will do everything properly without these hacks...let's see.

Sat, Sep 14, 6:23 AM · Frameworks

Fri, Sep 13

davidedmundson updated the title for P464 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Fri, Sep 13, 8:53 PM
davidedmundson updated the title for P463 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Fri, Sep 13, 8:30 PM
davidedmundson committed R278:aaacf7d5c206: Set XCB to required if building the X backend (authored by davidedmundson).
Set XCB to required if building the X backend
Fri, Sep 13, 3:50 PM
davidedmundson closed D23930: Set XCB to required if building the X backend.
Fri, Sep 13, 3:50 PM · Frameworks
davidedmundson accepted D23931: Add kwayland-integration to kwin dependencies.
Fri, Sep 13, 3:47 PM
davidedmundson requested review of D23930: Set XCB to required if building the X backend.
Fri, Sep 13, 3:35 PM · Frameworks
davidedmundson committed R111:064688415a1e: Create a plugin framework for processes (authored by davidedmundson).
Create a plugin framework for processes
Fri, Sep 13, 2:43 PM
davidedmundson closed D23287: Create a plugin framework for processes.
Fri, Sep 13, 2:43 PM · Plasma
davidedmundson added a comment to D23918: RFC: Drop Outputs class.

Can you provide some arguments why we must inherit from QVector<T>? C++ templates are invariant so we have to cast manually.

Fri, Sep 13, 2:35 PM · KWin
davidedmundson updated the diff for D23287: Create a plugin framework for processes.

update

Fri, Sep 13, 2:34 PM · Plasma
davidedmundson updated the diff for D23287: Create a plugin framework for processes.

Rebase, add include

Fri, Sep 13, 2:16 PM · Plasma
davidedmundson accepted D23808: Don't create() windows that aren't native, upon receiving a palette change event..

Makes sense as we install the colour scheme when a window's surface is created.

Fri, Sep 13, 12:05 PM · Plasma
davidedmundson accepted D23910: startplasma: Respect KDEWM again.
Fri, Sep 13, 12:02 PM · Plasma
davidedmundson added a comment to D23883: libkworkspace: Install sessionmanagementbackend.h with other headers.

You split the source out? I see.

Fri, Sep 13, 11:53 AM · Plasma
davidedmundson added a comment to D23562: [wayland] Drop wl-shell support.

That change is not released yet though.

Fri, Sep 13, 10:19 AM · KWin
davidedmundson added a comment to D23918: RFC: Drop Outputs class.

Doesn't solve anything and now we have casts all over the place.

Fri, Sep 13, 10:11 AM · KWin
davidedmundson updated the diff for D22887: WIP: Load animation speed from new global animation speed controller.

Update config names

Fri, Sep 13, 9:24 AM · KWin
davidedmundson accepted D23914: [colorcorrection] Fix division by zero.
Fri, Sep 13, 7:31 AM · KWin

Thu, Sep 12

davidedmundson accepted D23913: [kcmkwin/kwineffects] Use new Kirigami ListSectionHeader component.
Thu, Sep 12, 5:28 PM · KWin
davidedmundson added a comment to T11632: Move KCoreAddons QML bindings to KCoreAddons.

I certainly would prefer if KCoreAddons would keep depending only on QtCore.

Thu, Sep 12, 11:19 AM · Frameworks, KF6
davidedmundson created T11643: Drop QWidget dependency from KAuth.
Thu, Sep 12, 11:15 AM · KF6
davidedmundson created T11642: Split plasma-framework.
Thu, Sep 12, 11:14 AM · Plasma, KF6
davidedmundson added a comment to T7331: API for creation of virtual screens.

But I heard different things about that.

Thu, Sep 12, 11:04 AM · KWin, Plasma on Wayland
davidedmundson added a comment to D23883: libkworkspace: Install sessionmanagementbackend.h with other headers.

Happy to help, but I don't understand yet.

Thu, Sep 12, 10:27 AM · Plasma
davidedmundson created T11638: Drop Plasma dependency from KRunner.
Thu, Sep 12, 9:57 AM · KF6
davidedmundson added a comment to T11635: Move KIcon* QML bindings to KIconTheme.

See also https://phabricator.kde.org/T11637

Thu, Sep 12, 9:36 AM · Frameworks, KF6
davidedmundson created T11637: Investigate if KIconThemes is needed as a framework.
Thu, Sep 12, 9:36 AM · KF6
davidedmundson added a comment to T11632: Move KCoreAddons QML bindings to KCoreAddons.

As a note, I think we don't want to "move" the wrappers exactly, but instead make use of Q_GADGET on the format and user classes.

Thu, Sep 12, 9:34 AM · Frameworks, KF6
davidedmundson committed R256:761fee38c0b5: Re-add wayland support in falkon (authored by davidedmundson).
Re-add wayland support in falkon
Thu, Sep 12, 9:28 AM

Wed, Sep 11

davidedmundson accepted D23878: Use QTEST_GUILESS_MAIN for systeminformationtest.
Wed, Sep 11, 10:42 PM · Plasma
davidedmundson updated the diff for D22885: Add global animation speed slider to workspace options KCM.

update names as per discussion

Wed, Sep 11, 10:28 PM · Plasma
davidedmundson added a comment to D23883: libkworkspace: Install sessionmanagementbackend.h with other headers.

From my header:

Wed, Sep 11, 10:11 PM · Plasma
davidedmundson added a comment to D23883: libkworkspace: Install sessionmanagementbackend.h with other headers.

what for?

Wed, Sep 11, 10:10 PM · Plasma
davidedmundson added a comment to T11585: Investigate deprecating KEmoticons in favor of Unicode Emojis.

I spoke to carewolf. We're both right.

Wed, Sep 11, 12:30 PM · KF6
davidedmundson committed R242:4ecdbe9622cc: Add manual tests for PC3 (authored by davidedmundson).
Add manual tests for PC3
Wed, Sep 11, 9:16 AM
davidedmundson closed D23827: Add manual tests for PC3.
Wed, Sep 11, 9:16 AM · Frameworks
davidedmundson created T11619: Window Activation.
Wed, Sep 11, 9:04 AM · Plasma on Wayland
davidedmundson assigned T4454: [frameworks] KModifierKeyInfo needs porting to apol.
Wed, Sep 11, 8:43 AM · Plasma on Wayland
davidedmundson moved T4454: [frameworks] KModifierKeyInfo needs porting from Peripheral to Done on the Plasma on Wayland board.
Wed, Sep 11, 8:43 AM · Plasma on Wayland
davidedmundson moved T11601: Primary Clipboard (middle click) Support from Peripheral to Work In Progress on the Plasma on Wayland board.
Wed, Sep 11, 8:30 AM · Plasma on Wayland
davidedmundson created T11601: Primary Clipboard (middle click) Support.
Wed, Sep 11, 8:00 AM · Plasma on Wayland
davidedmundson updated the task description for T4449: [kwayland] Clipboard Manager protocol.
Wed, Sep 11, 7:49 AM · Plasma on Wayland
davidedmundson reassigned T10867: XDG WindowGeometry from davidedmundson to zzag.
Wed, Sep 11, 7:48 AM · KWin, Plasma on Wayland
davidedmundson moved T4464: [kwin] Support Window Rules from Work In Progress to Done on the Plasma on Wayland board.
Wed, Sep 11, 7:48 AM · KWin, Plasma on Wayland
davidedmundson claimed T11568: Port plasma-desktop away from kdelibs4support.
Wed, Sep 11, 6:52 AM · KF6
davidedmundson claimed T11569: Port plasma-workspace away from kdelibs4support.
Wed, Sep 11, 6:52 AM · KF6
davidedmundson added a comment to T11567: Port khotkeys away from kdelibs4support.

There are plans in plasma to drop this module.

Wed, Sep 11, 6:50 AM · KF6

Tue, Sep 10

davidedmundson added a comment to D23669: Generate mipmaps for image down-scaling.

Let's do a version with with just the gl_linear patch. As that's the only part running in your testing anyway.

Tue, Sep 10, 4:57 PM · KWin
davidedmundson added a comment to T7292: Emoticons / to be rethought.

KEmoticons will probably die in a fire, but we will probably still need a glorified "font selector" to choose an emoticon font, with a similar UI.

Tue, Sep 10, 4:13 PM · Plasma: KCM Redesign
davidedmundson added a comment to T11585: Investigate deprecating KEmoticons in favor of Unicode Emojis.

Maybe changing KTextToHtml

Tue, Sep 10, 4:12 PM · KF6
davidedmundson accepted D23829: Remove unused variable.
Tue, Sep 10, 12:26 PM · KWin
davidedmundson requested review of D23827: Add manual tests for PC3.
Tue, Sep 10, 10:36 AM · Frameworks
davidedmundson added a comment to D23799: Get rid of khtml usage (kill classic mode).

+1 as the new sidebar is very similar IMHO.

Tue, Sep 10, 9:53 AM · Plasma

Sun, Sep 8

davidedmundson added inline comments to D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
Sun, Sep 8, 2:22 PM · Frameworks
davidedmundson added a comment to D23615: [kcmkwin/options] Improve the look of the KWin options KCM UIs.

Code is fine.
Needs VDG to sign off their side.

Sun, Sep 8, 1:49 PM · KWin
davidedmundson added a comment to D23766: FakeInput: add support for keyboard key press and release.

+1

Sun, Sep 8, 12:28 PM · Frameworks
davidedmundson accepted D23769: Add support for keyboard key press and release from fake input protocol.
Sun, Sep 8, 12:14 PM · KWin
davidedmundson added inline comments to D23615: [kcmkwin/options] Improve the look of the KWin options KCM UIs.
Sun, Sep 8, 8:33 AM · KWin
davidedmundson accepted D23779: Make KWin action menu consistent with task manager, use action verbs for configure items and add more icons.

Keeping them in sync makes sense. +++

Sun, Sep 8, 8:02 AM · KWin

Sat, Sep 7

davidedmundson closed D23569: Request matching version of plasma-workspace libs.
Sat, Sep 7, 9:23 PM · Plasma
davidedmundson committed R119:587cb671d4cc: Request matching version of plasma-workspace libs (authored by davidedmundson).
Request matching version of plasma-workspace libs
Sat, Sep 7, 9:23 PM
davidedmundson committed R242:5f746ce1c2c2: Fix crash on teardown with Applet's ConfigLoader (authored by davidedmundson).
Fix crash on teardown with Applet's ConfigLoader
Sat, Sep 7, 9:19 PM
davidedmundson closed D23707: Fix crash on teardown with Applet's ConfigLoader.
Sat, Sep 7, 9:19 PM · Frameworks
davidedmundson accepted D23776: Add icon to "Move to Desktop/Activity" task manager context menu item and fix capitalizations.
Sat, Sep 7, 8:39 PM · Plasma
davidedmundson updated the diff for D23770: Don't notify ksplash in our wayland session.

I don't think it's needed to move it. But done anyway.

Sat, Sep 7, 8:38 PM · KWin
davidedmundson accepted D23774: [effects/wobblywindows] Draw clients below opaque wobbly windows.
Sat, Sep 7, 8:18 PM · KWin
davidedmundson added a comment to D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS.

There's some new env vars in Qt 5.14 to set a policy of what to do with DPI. Might be useful.

Sat, Sep 7, 8:09 PM · Plasma
davidedmundson added a comment to D23745: [server] Make double-buffered properties in xdg-shell double-buffered.

pray to the God hoping that the client committed associated surface.

Sat, Sep 7, 7:59 PM · Frameworks
davidedmundson accepted D23756: Use XCB wherever possible.
Sat, Sep 7, 3:13 PM · KWin
davidedmundson accepted D23768: Set maximum volume of streams properly even if the user has configured a maximum volume <100% in the applet..
Sat, Sep 7, 3:07 PM · Plasma
davidedmundson accepted D23727: Provide a simple test tool to see what autostart will look like.

I dont like the binary name. It doesn't imply debug or listing things.

Sat, Sep 7, 2:55 PM · Plasma
davidedmundson accepted D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu..
Sat, Sep 7, 2:43 PM · Plasma
davidedmundson requested review of D23770: Don't notify ksplash in our wayland session.
Sat, Sep 7, 12:01 PM · KWin