davidedmundson (David Edmundson)
User

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 17 2015, 10:32 PM (179 w, 1 d)
Availability
Available

Recent Activity

Today

davidedmundson added a comment to D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS.

The negative aspects of this patch are not related to whether Wayland exists.

Sun, Sep 23, 7:15 AM · Plasma

Yesterday

davidedmundson added a comment to D15117: [RFC] [effects] Make Scale and Glide effects Wayland-friendly.

I'm still not sure about tooltips. Looks like they are not popups on Wayland. Will it be changed in Qt?

Sat, Sep 22, 4:49 PM · KWin

Thu, Sep 20

davidedmundson added a comment to D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog.

In principle, sure.

Thu, Sep 20, 10:31 AM · Plasma

Mon, Sep 17

davidedmundson accepted D15578: [Notifications] Store "Open..." action in history.
Mon, Sep 17, 4:03 PM · Plasma
davidedmundson added inline comments to D15020: [xwl] Move Xwayland parts into separate class.
Mon, Sep 17, 2:12 PM · KWin
davidedmundson added a comment to D15372: [effects] Make scripted effects GHNS-able.

It's a bit weird to use kpackage here but not in ScriptedEffect itself but we can deal with that later.

Mon, Sep 17, 1:56 PM · KWin
davidedmundson added a comment to T5218: Use QtQuick for EffectFrames.

Also I've tried to keep it generic so that rendering a frame + text is just one implementation of a more generic way for effects to render arbitrary QML.

Mon, Sep 17, 12:56 PM · KWin
davidedmundson added a comment to T5218: Use QtQuick for EffectFrames.

FWIW: WIP at davidedmundson/effectquickview

Mon, Sep 17, 12:55 PM · KWin
davidedmundson accepted D15519: Privatize variables in InputDeviceHandler.
Mon, Sep 17, 12:43 PM · KWin
davidedmundson added a comment to D15496: [effects/cubeslide] Fix "sticky" windows detection on Wayland.

Now I can reproduce the bug \o/

Mon, Sep 17, 12:38 PM · KWin
davidedmundson committed R120:6234aaa3680b: Sync attribution metadata for SDDM theme to LNF (authored by davidedmundson).
Sync attribution metadata for SDDM theme to LNF
Mon, Sep 17, 12:19 PM
davidedmundson closed D15571: Sync attribution metadata for SDDM theme to LNF.
Mon, Sep 17, 12:19 PM · Plasma
davidedmundson requested review of D15571: Sync attribution metadata for SDDM theme to LNF.
Mon, Sep 17, 11:25 AM · Plasma
davidedmundson added inline comments to D15443: [server] Allow multiple touch interfaces per client.
Mon, Sep 17, 10:45 AM · Frameworks
davidedmundson accepted D15561: i18n: Fix untranslatable table row "Delta".
Mon, Sep 17, 10:16 AM · KWin
davidedmundson added a dependency for D15150: [wayland] Asyncronously update maximise flags: D15135: [wayland] Syncronise pending geometry with acked configure requests.
Mon, Sep 17, 10:11 AM · KWin
davidedmundson added a dependent revision for D15135: [wayland] Syncronise pending geometry with acked configure requests: D15150: [wayland] Asyncronously update maximise flags.
Mon, Sep 17, 10:11 AM · KWin
davidedmundson committed R318:cb6c71ae1b7e: Keep org.freedesktop.FileManager1 registered across processes (authored by davidedmundson).
Keep org.freedesktop.FileManager1 registered across processes
Mon, Sep 17, 10:04 AM
davidedmundson closed D15539: Keep org.freedesktop.FileManager1 registered across processes.
Mon, Sep 17, 10:04 AM · Dolphin
davidedmundson committed R108:7cd74e7d04fd: Merge branch 'Plasma/5.14' (authored by davidedmundson).
Merge branch 'Plasma/5.14'
Mon, Sep 17, 9:40 AM
davidedmundson committed R108:8bba7009bca2: Fix untranslatable strings in debug_console.ui shortcutdialog.ui (authored by davidedmundson).
Fix untranslatable strings in debug_console.ui shortcutdialog.ui
Mon, Sep 17, 9:40 AM

Sun, Sep 16

davidedmundson accepted D15560: Define ShellClient debug output.
Sun, Sep 16, 8:53 PM · KWin

Sat, Sep 15

davidedmundson added a comment to D15516: Don't set window icon in daemon mode.

(imho the "daemon" should quit after having fullfilled the dbus activation request but that's an unrelated issue)

Sat, Sep 15, 5:15 PM · Dolphin
davidedmundson requested review of D15539: Keep org.freedesktop.FileManager1 registered across processes.
Sat, Sep 15, 5:00 PM · Dolphin

Fri, Sep 14

davidedmundson accepted D15513: Fix dangling reference with "auto" becoming "QStringBuilder".
Fri, Sep 14, 9:28 PM · Frameworks
davidedmundson accepted D15496: [effects/cubeslide] Fix "sticky" windows detection on Wayland.
Fri, Sep 14, 1:00 PM · KWin
davidedmundson committed R108:fcf9acfec505: Add XDG WmBase support (authored by davidedmundson).
Add XDG WmBase support
Fri, Sep 14, 11:18 AM
davidedmundson accepted D15498: Workaround QTBUG-47066 to fix crash on startup.
Fri, Sep 14, 9:58 AM · Plasma
davidedmundson requested changes to D15496: [effects/cubeslide] Fix "sticky" windows detection on Wayland.

and everything makes sense, that's a known wayland behavioural change. ++

Fri, Sep 14, 8:54 AM · KWin
davidedmundson committed R120:5545214d4420: Reload list of wallpaper types on install/uninstall (authored by davidedmundson).
Reload list of wallpaper types on install/uninstall
Fri, Sep 14, 8:46 AM
davidedmundson closed D15178: Reload list of wallpaper types on install/uninstall.
Fri, Sep 14, 8:46 AM · Plasma
davidedmundson committed R120:af66555b0ab0: Clarify docs in startkde about shtudown (authored by davidedmundson).
Clarify docs in startkde about shtudown
Fri, Sep 14, 8:46 AM
davidedmundson closed D15197: Clarify docs in startkde about shtudown.
Fri, Sep 14, 8:46 AM · Plasma
davidedmundson added inline comments to D7038: [server] Respect input region of sub-surfaces on pointer surface focus.
Fri, Sep 14, 8:34 AM · Plasma on Wayland, Frameworks
davidedmundson committed R108:93b3ace067ae: [effects/fadedesktop] Fade to the correct opacity (authored by davidedmundson).
[effects/fadedesktop] Fade to the correct opacity
Fri, Sep 14, 8:09 AM
davidedmundson closed D15476: [effects/fadedesktop] Fade to the correct opacity.
Fri, Sep 14, 8:09 AM · KWin
davidedmundson committed R108:4ecbacff7714: [effects/fadedesktop] Port to explicit animate API (authored by davidedmundson).
[effects/fadedesktop] Port to explicit animate API
Fri, Sep 14, 8:09 AM
davidedmundson closed D15473: [effects/fadedesktop] Port to explicit animate API.
Fri, Sep 14, 8:09 AM · KWin
davidedmundson updated the diff for D15201: Move logout-greeter into it's own subdir out of ksmserver.

Update

Fri, Sep 14, 8:07 AM · Plasma
davidedmundson added a comment to D15495: Add Messages.sh.

According to https://websvn.kde.org/trunk/l10n-kf5/scripts/ update_translations it seems both Messages.sh and StaticMessages.sh will be invoked.

Fri, Sep 14, 8:05 AM · Plasma

Thu, Sep 13

davidedmundson accepted D15488: [Bookmarks Runner] Expose list of tables from FetchSqlite.
Thu, Sep 13, 10:26 PM · Plasma
davidedmundson accepted D15468: [server] Do not return early on fail in touchDown fall back code.
Thu, Sep 13, 10:04 PM · Frameworks
davidedmundson requested changes to D15488: [Bookmarks Runner] Expose list of tables from FetchSqlite.
Thu, Sep 13, 9:44 PM · Plasma
davidedmundson accepted D15490: [Bookmarks Runner] Remove unused database parameter from query.
Thu, Sep 13, 9:29 PM · Plasma
davidedmundson accepted D15489: [Bookmarks Runner] Initialize Chrome favicon query only once per profile.
Thu, Sep 13, 9:29 PM · Plasma
davidedmundson accepted D15491: [Bookmarks Runner] Remove BuildQuery Functor class.
Thu, Sep 13, 9:21 PM · Plasma
davidedmundson added a comment to D14688: [libkwineffects] Expose getting/setting activeFullScript to scripted effects.

Frankly, I prefer the old approach (with tristate). Now, we have two very similar properties.

Thu, Sep 13, 7:56 PM · KWin
davidedmundson added a comment to D15135: [wayland] Syncronise pending geometry with acked configure requests.

It's missing still a cleanup in case the client is broken as in not responding to any configure events or with the wrong serials and the vector would grow limitless. But we can do this in a second patch.>

Thu, Sep 13, 7:31 PM · KWin
davidedmundson updated the diff for D15135: [wayland] Syncronise pending geometry with acked configure requests.

Rewrite the loop in a slightly different way. Behaviour should be the same.

Thu, Sep 13, 5:11 PM · KWin
davidedmundson accepted D15115: fix translations kcm to be usable on new users/installations.
Thu, Sep 13, 5:06 PM · Plasma
davidedmundson added inline comments to D15135: [wayland] Syncronise pending geometry with acked configure requests.
Thu, Sep 13, 3:52 PM · KWin
davidedmundson added inline comments to D15135: [wayland] Syncronise pending geometry with acked configure requests.
Thu, Sep 13, 3:23 PM · KWin
davidedmundson added inline comments to D13034: Add mechanism to notify other clients of config changes over DBus.
Thu, Sep 13, 1:23 PM · Frameworks
davidedmundson updated the diff for D13034: Add mechanism to notify other clients of config changes over DBus.

Review comments

Thu, Sep 13, 1:21 PM · Frameworks
davidedmundson updated the diff for D14688: [libkwineffects] Expose getting/setting activeFullScript to scripted effects.

Swap the enum tristate for whether any effect is full screen or if we're the active full screen effect
with 2 booleans.

Thu, Sep 13, 1:00 PM · KWin
davidedmundson updated the diff for D15474: [effects/fadedesktop] Set animation as a fullscreen effect.

Force blur/constrast to stay on even though we're a full screen effect

Thu, Sep 13, 12:58 PM · KWin
davidedmundson accepted D14806: [AppStream Runner] Reduce verbosity of log output.
Thu, Sep 13, 11:57 AM · Plasma
davidedmundson requested review of D15476: [effects/fadedesktop] Fade to the correct opacity.
Thu, Sep 13, 11:49 AM · KWin
davidedmundson accepted D15475: [shadow] Rebuild quads after creation of shadow.
Thu, Sep 13, 11:47 AM · KWin
davidedmundson added inline comments to D15473: [effects/fadedesktop] Port to explicit animate API.
Thu, Sep 13, 11:02 AM · KWin
davidedmundson added a dependency for D15474: [effects/fadedesktop] Set animation as a fullscreen effect: D14688: [libkwineffects] Expose getting/setting activeFullScript to scripted effects.
Thu, Sep 13, 10:10 AM · KWin
davidedmundson added a dependent revision for D14688: [libkwineffects] Expose getting/setting activeFullScript to scripted effects: D15474: [effects/fadedesktop] Set animation as a fullscreen effect.
Thu, Sep 13, 10:10 AM · KWin
davidedmundson requested review of D15474: [effects/fadedesktop] Set animation as a fullscreen effect.
Thu, Sep 13, 10:09 AM · KWin
davidedmundson requested review of D15473: [effects/fadedesktop] Port to explicit animate API.
Thu, Sep 13, 10:03 AM · KWin
davidedmundson abandoned D14331: Avoid pixmap format test failure with serialising QIcons.
Thu, Sep 13, 9:37 AM · Frameworks
davidedmundson abandoned D14264: Disconnect decoration button requestHover tooltip on decoration destuction.
Thu, Sep 13, 9:37 AM · Plasma
davidedmundson added a comment to D15135: [wayland] Syncronise pending geometry with acked configure requests.

ping

Thu, Sep 13, 9:37 AM · KWin
davidedmundson committed R290:b42973d964df: Emit signals when a package is installed/uninstalled (authored by davidedmundson).
Emit signals when a package is installed/uninstalled
Thu, Sep 13, 9:36 AM
davidedmundson closed D15177: Emit signals when a package is installed/uninstalled.
Thu, Sep 13, 9:36 AM · Frameworks
davidedmundson closed D13658: Remove duplicated auto backend resolution.
Thu, Sep 13, 9:21 AM · KWin
davidedmundson committed R108:0a2e51db47f4: Remove duplicated auto backend resolution (authored by davidedmundson).
Remove duplicated auto backend resolution
Thu, Sep 13, 9:21 AM
davidedmundson committed R108:d485dfe7ef19: Avoid crash with on scripted window teardown with threaded quick render loop (authored by davidedmundson).
Avoid crash with on scripted window teardown with threaded quick render loop
Thu, Sep 13, 9:19 AM
davidedmundson closed D15025: Avoid crash with on scripted window teardown with threaded quick render loop.
Thu, Sep 13, 9:19 AM · KWin

Wed, Sep 12

davidedmundson added a comment to D15443: [server] Allow multiple touch interfaces per client.

Oh, I see what you're saying, I misread, sorry. That does indeed make sense.

Wed, Sep 12, 9:14 PM · Frameworks
davidedmundson added inline comments to D15464: [server] Touch drag support.
Wed, Sep 12, 8:49 PM · Frameworks
davidedmundson added a comment to D15443: [server] Allow multiple touch interfaces per client.

has been for no apparent reason

Wed, Sep 12, 8:35 PM · Frameworks
davidedmundson added a comment to D14536: [scripting] Port ScriptedEffects to QJSEngine.

18 months because the change would be that big?

Wed, Sep 12, 8:21 PM · KWin
davidedmundson accepted D15462: Do ignore-filtered-siblings properly.
Wed, Sep 12, 6:29 PM · Plasma
davidedmundson accepted D15272: [effects/trackmouse] Allow to use both modifiers and shortcut.
Wed, Sep 12, 1:30 PM · KWin
davidedmundson added inline comments to D15272: [effects/trackmouse] Allow to use both modifiers and shortcut.
Wed, Sep 12, 12:39 PM · KWin
davidedmundson accepted D15272: [effects/trackmouse] Allow to use both modifiers and shortcut.
Wed, Sep 12, 12:24 PM · KWin
davidedmundson updated the title for P259 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Wed, Sep 12, 10:27 AM
davidedmundson accepted D15447: [libdbusmenuqt] Port to categorized logging.
Wed, Sep 12, 9:54 AM · Plasma

Tue, Sep 11

davidedmundson accepted D15435: Add translucent background attribute to desktop icon popup menu.
Tue, Sep 11, 8:42 PM · Plasma
davidedmundson added a comment to D15406: Manually resize KCMUtilDialog to sizeHint().

neither QWidget::adjustSize() nor QWidget::adjustedSize() seem to use devicePixelRatio

Tue, Sep 11, 4:59 PM · Frameworks
davidedmundson accepted D15422: [server] Fix remote access buffer handling when output not bound.
Tue, Sep 11, 1:25 PM · Frameworks
davidedmundson accepted D15424: [effects/showpaint] Modernize code.
Tue, Sep 11, 1:19 PM · KWin
davidedmundson added inline comments to D15422: [server] Fix remote access buffer handling when output not bound.
Tue, Sep 11, 12:40 PM · Frameworks
davidedmundson added inline comments to D14536: [scripting] Port ScriptedEffects to QJSEngine.
Tue, Sep 11, 11:14 AM · KWin
davidedmundson updated the diff for D14536: [scripting] Port ScriptedEffects to QJSEngine.

misc review comments

Tue, Sep 11, 10:51 AM · KWin
davidedmundson added inline comments to D14536: [scripting] Port ScriptedEffects to QJSEngine.
Tue, Sep 11, 10:51 AM · KWin
davidedmundson added a comment to D14536: [scripting] Port ScriptedEffects to QJSEngine.

As an alternative approach, we could wrap EffectsHandler and EffectWindow.

Tue, Sep 11, 9:08 AM · KWin

Mon, Sep 10

davidedmundson accepted D15413: [effects/dialogparent] Fix strict mode issues.
Mon, Sep 10, 7:46 PM · KWin
davidedmundson updated the diff for D15202: Move kcheckrunning into startkde.

Add missing file

Mon, Sep 10, 4:06 PM · Plasma
davidedmundson added inline comments to D15177: Emit signals when a package is installed/uninstalled.
Mon, Sep 10, 11:44 AM · Frameworks
davidedmundson accepted D15275: [effects/magnifier] Fix 1 px gap between magnified area and frame.
Mon, Sep 10, 10:03 AM · KWin
davidedmundson added a comment to D15275: [effects/magnifier] Fix 1 px gap between magnified area and frame.

I struggle to see how

Mon, Sep 10, 9:45 AM · KWin
davidedmundson accepted D15275: [effects/magnifier] Fix 1 px gap between magnified area and frame.

As you're doing the common fix for QRect::right/bottom fix would it be cleaner to just use a QRectF for the area and then kill all the +1s?

Mon, Sep 10, 9:02 AM · KWin

Sun, Sep 9

davidedmundson accepted D15386: Use consistent "Suspend" terminology.
Sun, Sep 9, 7:11 PM · Plasma
davidedmundson accepted D15384: [Bookmarks Runner] Remove unused define.
Sun, Sep 9, 6:38 PM · Plasma