davidedmundson (David Edmundson)
User

Projects (14)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 17 2015, 10:32 PM (248 w, 4 h)
Availability
Available

Recent Activity

Yesterday

davidedmundson added a comment to D26735: [Components 3]Make slider tickmarks optional.

We've previously avoided adding any API to PC3 so it can be used as a Qqc2-style.

Fri, Jan 17, 9:11 PM · Frameworks
davidedmundson added inline comments to D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing.
Fri, Jan 17, 2:53 PM · Baloo, Plasma
davidedmundson added a comment to D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size.

Is there a better way?

Fri, Jan 17, 2:52 PM · Plasma
davidedmundson added a comment to D25634: Add kconf update script for ksmserver.

-1 I'd prefer if the config value was kept

Fri, Jan 17, 2:43 PM · Plasma
davidedmundson committed R119:3a6795548fd7: [widgetexplorer] Animate column moves (authored by davidedmundson).
[widgetexplorer] Animate column moves
Fri, Jan 17, 2:42 PM
davidedmundson closed D26699: [widgetexplorer] Animate column moves.
Fri, Jan 17, 2:42 PM · Plasma
davidedmundson committed R119:977665254990: [widgetexplorer] Fix animate in animation (authored by davidedmundson).
[widgetexplorer] Fix animate in animation
Fri, Jan 17, 2:42 PM
davidedmundson closed D26698: [widgetexplorer] Fix animate in animation.
Fri, Jan 17, 2:42 PM · Plasma
davidedmundson accepted D26634: Correctly compute bottom margin for grid delegates with subtitles.
Fri, Jan 17, 2:37 PM · Frameworks
davidedmundson added a comment to T12040: "Resolution Dependent" cursor setting: fix it or delete it?.

Some tech notes:

Fri, Jan 17, 2:26 PM · KWin
davidedmundson added a comment to D26726: [Breeze Cursors] Add some more cursor names.

Semi relevant: https://bugs.kde.org/show_bug.cgi?id=395247

Fri, Jan 17, 2:10 PM · Plasma
davidedmundson accepted D26725: make sure Solid::Battery is not deleted from QML.
Fri, Jan 17, 12:19 PM · Plasma
davidedmundson updated the diff for D25743: Expose IndexerState enum to QML.

rebase

Fri, Jan 17, 11:37 AM · Baloo, Frameworks
davidedmundson accepted D26457: Introduce shadows API.

Good stuff!

Fri, Jan 17, 11:22 AM · Frameworks
davidedmundson added a comment to D26185: Fix font rendering when compiled against Qt >= 5.14.

Ack. Thanks for chasing up on indentifying causes.

Fri, Jan 17, 11:03 AM · Plasma
davidedmundson accepted D26722: Load user information once on startup.
Fri, Jan 17, 10:04 AM · Plasma
davidedmundson added a comment to D26715: [Widget Explorer] Show placeholder message when there are no widgets or search results.

What does enabled on a label do?

Fri, Jan 17, 7:34 AM · Plasma
davidedmundson requested changes to D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView.

The continual forwarding of keys makes sense. I'm happy to accept that.

Fri, Jan 17, 12:04 AM · Plasma

Thu, Jan 16

davidedmundson requested changes to D26691: Optimize code when dropping files into the desktop.

m_dropActions is conceptually linked to the menu we are showing
It shouldn't a direct member variable of ContainmentInterface

Thu, Jan 16, 4:28 PM · Frameworks
davidedmundson added inline comments to D26381: Port DesktopGrid QtQuickWindow to EffectQuickView.
Thu, Jan 16, 3:20 PM · KWin
davidedmundson updated the diff for D26381: Port DesktopGrid QtQuickWindow to EffectQuickView.

Remove unused destructor

Thu, Jan 16, 3:09 PM · KWin
davidedmundson accepted D26708: [x11] Apply "Block compositing" rule right away.
Thu, Jan 16, 2:10 PM · KWin
davidedmundson accepted D26543: Unbreak the KNSQuick::Engine::changedEntries functionality.

Given timeframes and where we've ended up. Accepted.

Thu, Jan 16, 1:23 PM · Frameworks
davidedmundson added a comment to D26543: Unbreak the KNSQuick::Engine::changedEntries functionality.

I've gone through this again, and I'm somewhat confused.
Entry (via EntryWrapper) doesn't seem usable by QML. It doesn't have any properties.

Thu, Jan 16, 12:56 PM · Frameworks
davidedmundson updated the diff for D26381: Port DesktopGrid QtQuickWindow to EffectQuickView.

Modernise QML

Thu, Jan 16, 12:09 AM · KWin

Wed, Jan 15

davidedmundson accepted D26700: [scenes/opengl] Merge window classes.

I like red patches.

Wed, Jan 15, 10:42 PM · KWin
davidedmundson requested review of D26699: [widgetexplorer] Animate column moves.
Wed, Jan 15, 8:52 PM · Plasma
davidedmundson added a comment to D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size.

Ok, but why minimum?
We still have a few reports of people on weird tiny netbooks.

Wed, Jan 15, 8:46 PM · Plasma
davidedmundson requested review of D26698: [widgetexplorer] Fix animate in animation.
Wed, Jan 15, 8:45 PM · Plasma
davidedmundson accepted D26631: [kstyle] Update blur region even if Breeze has no X11 support.
Wed, Jan 15, 7:32 PM · Plasma
davidedmundson added inline comments to D26543: Unbreak the KNSQuick::Engine::changedEntries functionality.
Wed, Jan 15, 6:34 PM · Frameworks
davidedmundson accepted D26570: Improve Plasma user feedback introspection.
Wed, Jan 15, 6:02 PM · Plasma
davidedmundson added a comment to D26570: Improve Plasma user feedback introspection.

Quite a clever solution. I like the general idea.

Wed, Jan 15, 5:53 PM · Plasma
davidedmundson added inline comments to D26609: [kstyle] Port to KWindowSystem shadows API.
Wed, Jan 15, 4:42 PM · Plasma
davidedmundson accepted D26642: [plugins/windowsystem] Fix compilation with no-deprecated build of KWindowSystem.
Wed, Jan 15, 4:34 PM · KWin
davidedmundson accepted D26643: [windowsystem] Fix compilation with no-deprecated build of KWindowSystem.
Wed, Jan 15, 4:34 PM · Plasma
bernieinnocenti awarded T11601: Primary Clipboard (middle click) Support a Love token.
Wed, Jan 15, 4:03 PM · Plasma on Wayland
davidedmundson added a comment to T12542: Fix circular dependency of applications.menu in KService and plasma-workspace.

Just to flesh that out more. KF5 will be presumably be co-installable with KF6 and Plasma 6 so we can't just move the file.

Wed, Jan 15, 3:55 PM · KF6
davidedmundson added inline comments to D26664: Same behavior for scrollbar as the desktop style.
Wed, Jan 15, 3:40 PM · Frameworks
kleag awarded T11601: Primary Clipboard (middle click) Support a Love token.
Wed, Jan 15, 2:09 PM · Plasma on Wayland
davidedmundson added inline comments to D26681: [TabBox] Thumbnail Grid window switcher.
Wed, Jan 15, 1:44 PM · Plasma
davidedmundson added inline comments to D26681: [TabBox] Thumbnail Grid window switcher.
Wed, Jan 15, 1:42 PM · Plasma
davidedmundson added a comment to T12542: Fix circular dependency of applications.menu in KService and plasma-workspace.

@guoyunhe can you propose a solution for KF6 that would make sure we don't have future conflicts

Wed, Jan 15, 12:12 PM · KF6
davidedmundson added inline comments to D26680: [kcms/feedback] Implement setRepresentsDefaults.
Wed, Jan 15, 11:42 AM · Plasma
davidedmundson committed R120:505ce9929b2f: [sddm-theme] Don't have a broken reveal password button (authored by davidedmundson).
[sddm-theme] Don't have a broken reveal password button
Wed, Jan 15, 10:44 AM
davidedmundson closed D26675: [sddm-theme] Don't have a broken reveal password button.
Wed, Jan 15, 10:44 AM · Plasma
davidedmundson committed R120:e1324b0f5457: [kcms/feedback] Fix default button not showing (authored by davidedmundson).
[kcms/feedback] Fix default button not showing
Wed, Jan 15, 10:44 AM
davidedmundson closed D26679: [kcms/feedback] Fix default button not showing.
Wed, Jan 15, 10:44 AM · Plasma
davidedmundson committed R120:1f75ac80b6ac: [kcms/feedback] Implement setRepresentsDefaults (authored by davidedmundson).
[kcms/feedback] Implement setRepresentsDefaults
Wed, Jan 15, 10:44 AM
davidedmundson committed R120:e5ef7ea31955: [kcms/feedback] Fix slider value (authored by davidedmundson).
[kcms/feedback] Fix slider value
Wed, Jan 15, 10:44 AM
davidedmundson closed D26680: [kcms/feedback] Implement setRepresentsDefaults.
Wed, Jan 15, 10:44 AM · Plasma
davidedmundson closed D26678: [kcms/feedback] Fix slider value.
Wed, Jan 15, 10:44 AM · Plasma
davidedmundson created T12542: Fix circular dependency of applications.menu in KService and plasma-workspace.
Wed, Jan 15, 10:35 AM · KF6
davidedmundson accepted D26162: [Notifications KCM] Force re-evaluation of position radio buttons.
Wed, Jan 15, 9:11 AM · Plasma
davidedmundson accepted D26652: Unbreak module imports for Python2.
Wed, Jan 15, 8:44 AM · Documentation, Frameworks
davidedmundson requested review of D26680: [kcms/feedback] Implement setRepresentsDefaults.
Wed, Jan 15, 1:26 AM · Plasma
davidedmundson updated the diff for D26679: [kcms/feedback] Fix default button not showing.

stupid phab

Wed, Jan 15, 1:14 AM · Plasma
davidedmundson requested review of D26679: [kcms/feedback] Fix default button not showing.
Wed, Jan 15, 1:14 AM · Plasma
davidedmundson requested review of D26678: [kcms/feedback] Fix slider value.
Wed, Jan 15, 12:56 AM · Plasma
davidedmundson committed R114:a51086867c0f: [applets/calculator] Use Qt's in-built number formatting (authored by davidedmundson).
[applets/calculator] Use Qt's in-built number formatting
Wed, Jan 15, 12:36 AM
davidedmundson closed D26676: [applets/calculator] Use Qt's in-built number formatting.
Wed, Jan 15, 12:36 AM · Plasma

Tue, Jan 14

davidedmundson requested review of D26676: [applets/calculator] Use Qt's in-built number formatting.
Tue, Jan 14, 11:03 PM · Plasma
davidedmundson requested review of D26675: [sddm-theme] Don't have a broken reveal password button.
Tue, Jan 14, 10:14 PM · Plasma
davidedmundson closed D26672: Fix crash when loading a top level entry from system settings home page.
Tue, Jan 14, 9:57 PM · Plasma
davidedmundson committed R124:27b8f182409a: Fix crash when loading a top level entry from system settings home page (authored by davidedmundson).
Fix crash when loading a top level entry from system settings home page
Tue, Jan 14, 9:57 PM
davidedmundson accepted D26483: [wallpapers/image] Add default XDG wallpaper locations for slideshow.
Tue, Jan 14, 9:50 PM · Plasma
davidedmundson requested review of D26672: Fix crash when loading a top level entry from system settings home page.
Tue, Jan 14, 9:34 PM · Plasma
davidedmundson requested changes to D26483: [wallpapers/image] Add default XDG wallpaper locations for slideshow.
Tue, Jan 14, 9:03 PM · Plasma
davidedmundson added a comment to D26371: [platforms/drm] Rewrite rotation rendering to use MapTexture.

Roman preferred to merge the less good version as-is, then merge this as top instead of my suggestion of squashing.
Renamed commit appropriately.

Tue, Jan 14, 5:53 PM · KWin
davidedmundson committed R100:26f55f10c026: Explictly state which X11 components are required (authored by davidedmundson).
Explictly state which X11 components are required
Tue, Jan 14, 5:53 PM
davidedmundson closed D26223: Explictly state which X11 components are required.
Tue, Jan 14, 5:53 PM · Plasma
davidedmundson updated the summary of D26371: [platforms/drm] Rewrite rotation rendering to use MapTexture.
Tue, Jan 14, 5:51 PM · KWin
davidedmundson accepted D25904: [libkwineffects] Set original backend framebuffer for render targets.
Tue, Jan 14, 5:48 PM · KWin
davidedmundson added a comment to D26172: Add wp_viewporter support.

Ok, then I withdraw my comment. That sounds like it's going to be good enough.

Tue, Jan 14, 5:44 PM · KWin
davidedmundson accepted D26668: [effects/flipswitch] Add a const ref.
Tue, Jan 14, 4:45 PM · KWin
davidedmundson added a comment to D26381: Port DesktopGrid QtQuickWindow to EffectQuickView.

That error is about a missing include on flipswitch.h
It doesn't seem relevant to this patch?

Tue, Jan 14, 4:32 PM · KWin
davidedmundson accepted D26666: [nightcolor] Expose transition timings to d-bus.
Tue, Jan 14, 3:42 PM · KWin
davidedmundson added inline comments to D26583: [Application Style] Add GTK Application Style Page.
Tue, Jan 14, 2:09 PM · Plasma
davidedmundson accepted D26663: Fix doc block in KProtocolInfoFactory.
Tue, Jan 14, 1:50 PM · Frameworks
davidedmundson accepted D26658: fix(kwayland): move blocking tablet init before timer start.
Tue, Jan 14, 12:42 PM · Plasma

Mon, Jan 13

davidedmundson accepted D26621: [kstyle] Drop Qt 4 style plugin.

Seems we got the go-ahead from kde-distro-packagers ML so ++

Mon, Jan 13, 4:50 PM · Plasma
davidedmundson accepted D22382: Add global shortcuts for switching to the previous/next activity.
Mon, Jan 13, 2:47 PM · Plasma
davidedmundson accepted D26625: [kcmkwin/kwincompositing] Remove "animation speed" keyword.
Mon, Jan 13, 1:34 PM · KWin
davidedmundson added a comment to T12533: Make kconf_update more robust.

Yes please!

Mon, Jan 13, 11:54 AM · KF6

Sun, Jan 12

davidedmundson added a comment to D26584: Load localization catalog for slideshow config window.

I'm still not totally clear on why some things require a domain to be added for translations, and other things don't.

Sun, Jan 12, 3:59 PM · Plasma

Sat, Jan 11

davidedmundson added a comment to D26159: Drop KWindowSystem dependency.

There's a big difference between "I want to raise my window" and I "I want to raise $random window".

Sat, Jan 11, 10:43 AM · Frameworks

Fri, Jan 10

davidedmundson committed R108:212d87a32ef1: [scenes/opengl] Remove outdated hack to reset vertex buffers (authored by davidedmundson).
[scenes/opengl] Remove outdated hack to reset vertex buffers
Fri, Jan 10, 2:51 PM
davidedmundson closed D26556: [scenes/opengl] Remove outdated hack to reset vertex buffers.
Fri, Jan 10, 2:51 PM · KWin
davidedmundson added inline comments to D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick.
Fri, Jan 10, 2:39 PM · Plasma
davidedmundson updated the diff for D26556: [scenes/opengl] Remove outdated hack to reset vertex buffers.

update

Fri, Jan 10, 2:25 PM · KWin
davidedmundson updated the diff for D26556: [scenes/opengl] Remove outdated hack to reset vertex buffers.

Just remove the whole thing

Fri, Jan 10, 2:21 PM · KWin
davidedmundson accepted D26043: Add edit mode menu item to desktop widget context menu.
Fri, Jan 10, 11:53 AM · Frameworks
davidedmundson added a comment to D25681: Get icon size from QStyle.

Sounds like 415699 which is unrelated to this change

Fri, Jan 10, 11:20 AM · KF6, Plasma
davidedmundson added a comment to D26556: [scenes/opengl] Remove outdated hack to reset vertex buffers.

As a more general comment, I think this entire debug context stuff can be deleted or at least opt-in when we want debug, rather than what seems to be a poor approach of detecting the nvidia resets.

Fri, Jan 10, 11:11 AM · KWin
davidedmundson updated the diff for D26556: [scenes/opengl] Remove outdated hack to reset vertex buffers.

Add extra guard, as there is a timer there's a hypothetical (but not real) chance that scene is destroyed

Fri, Jan 10, 10:32 AM · KWin
davidedmundson updated the diff for D26556: [scenes/opengl] Remove outdated hack to reset vertex buffers.

update

Fri, Jan 10, 1:48 AM · KWin
davidedmundson updated the summary of D26556: [scenes/opengl] Remove outdated hack to reset vertex buffers.
Fri, Jan 10, 1:24 AM · KWin
davidedmundson added a comment to D26556: [scenes/opengl] Remove outdated hack to reset vertex buffers.

Extra clue that matches my thinking:

Fri, Jan 10, 1:22 AM · KWin
davidedmundson requested review of D26556: [scenes/opengl] Remove outdated hack to reset vertex buffers.
Fri, Jan 10, 1:17 AM · KWin

Thu, Jan 9

davidedmundson committed R108:928554698b4a: [colormanager] Fix build on older glib (authored by davidedmundson).
[colormanager] Fix build on older glib
Thu, Jan 9, 8:59 PM