davidedmundson (David Edmundson)
User

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 17 2015, 10:32 PM (187 w, 2 d)
Availability
Available

Recent Activity

Today

davidedmundson added a reviewer for D17021: [ioslaves/trash] Handle broken symlinks in deleted subdirectories: dfaure.
Mon, Nov 19, 5:13 PM · Frameworks
davidedmundson requested review of D17021: [ioslaves/trash] Handle broken symlinks in deleted subdirectories.
Mon, Nov 19, 5:12 PM · Frameworks
davidedmundson requested review of D17017: Fix assert when cleaning up symlinks in PreviewJob.
Mon, Nov 19, 2:18 PM · Frameworks
davidedmundson accepted D16250: Use lambdas instead of std::bind().
Mon, Nov 19, 11:06 AM · Frameworks
davidedmundson accepted D16898: [kcm] Remove profiles code.

I remember Alex at the time had a thing that new features should be in master but in #ifdefs so it's easier for other devs to test things than having a giant patchset that no-one can even find and have to keep switching between.

Mon, Nov 19, 11:03 AM · Plasma
davidedmundson added a comment to D16990: [kded] Change configuration storage path.

Why?

Mon, Nov 19, 9:41 AM · Plasma
davidedmundson added inline comments to D17006: Compress calls to `updateSize`.
Mon, Nov 19, 9:37 AM · Plasma
davidedmundson accepted D16108: When re-using runners when reloading, reload their configuration .
Mon, Nov 19, 9:06 AM · Frameworks
davidedmundson accepted D16297: [DBusMenuImporter] Don't call removeAction() to avoid an empty QMenu.
Mon, Nov 19, 9:05 AM · Plasma
davidedmundson accepted D17006: Compress calls to `updateSize`.

Use of callLater seems like a neat solution, does it make aboutToPopulate redundant?

Mon, Nov 19, 8:59 AM · Plasma
davidedmundson accepted D16932: Delete kglobalshortcutsrc before executing a test.
Mon, Nov 19, 8:48 AM · KWin
davidedmundson accepted D16945: Fix fallback to built-in ui.
Mon, Nov 19, 8:44 AM · Plasma

Yesterday

davidedmundson accepted D16400: Prefer to set current mode in resolution combobox.

Nice solution.

Sun, Nov 18, 6:15 PM · Plasma
davidedmundson accepted D16768: mage global menu screen aware.
Sun, Nov 18, 6:13 PM · Plasma
davidedmundson added a comment to D16977: [weather] Fix broken observation display for temperature of 0 °.

Observation temperature of 0 ° no longer is shown as empty string,

Sun, Nov 18, 6:11 PM · Plasma
davidedmundson added a comment to D16890: [systemtray] Keep config entries after modifying.

I don't understand.

Sun, Nov 18, 5:11 PM · Plasma
davidedmundson added a comment to D16945: Fix fallback to built-in ui.

Ship it if you like, but I think there's a nicer solution.

Sun, Nov 18, 5:05 PM · Plasma

Sat, Nov 17

davidedmundson committed R108:6c71403281b2: [autotests] Hopefully stabilise TestShellClient (authored by davidedmundson).
[autotests] Hopefully stabilise TestShellClient
Sat, Nov 17, 12:50 PM
davidedmundson closed D16955: [autotests] Hopefully stabilise TestShellClient.
Sat, Nov 17, 12:50 PM · KWin
davidedmundson requested review of D16955: [autotests] Hopefully stabilise TestShellClient.
Sat, Nov 17, 12:07 PM · KWin
davidedmundson accepted D16939: Unset all env variables related to KDE session in integration tests.
Sat, Nov 17, 12:00 PM · KWin
davidedmundson accepted D16449: [scripting] Introduce redirect function.
Sat, Nov 17, 11:40 AM · KWin

Fri, Nov 16

davidedmundson added a comment to D16919: Re-add DBus test.

CI seems to be frozen again. :(

Fri, Nov 16, 3:07 PM · Konsole
davidedmundson accepted D16595: Fix i18n when the kcm code is embedded in the plasmoid config.

Sure, lets get this into stable till a magic fix comes along

Fri, Nov 16, 2:05 PM · Plasma
davidedmundson committed R108:37fbb49bf0af: [wayland] Fix maximised test (authored by davidedmundson).
[wayland] Fix maximised test
Fri, Nov 16, 12:29 PM
davidedmundson requested changes to D2393: Don't check current active session at all.

Marking as request changes based on Kai's comment which has gone unanswered.

Fri, Nov 16, 12:14 PM · Plasma
davidedmundson added inline comments to D16449: [scripting] Introduce redirect function.
Fri, Nov 16, 12:09 PM · KWin
davidedmundson accepted D16923: actually initialize kcrash for xclipboardsync.
Fri, Nov 16, 12:00 PM · KWin
davidedmundson committed R108:1a2c90ea1270: [wayland] Fix ShellClientTest (authored by davidedmundson).
[wayland] Fix ShellClientTest
Fri, Nov 16, 11:59 AM
davidedmundson closed D16922: [wayland] Fix ShellClientTest.
Fri, Nov 16, 11:59 AM · KWin
davidedmundson committed R108:5f2e0b729904: [wayland] WlShell cache the pre-maximised geometry before going fullscreen (authored by davidedmundson).
[wayland] WlShell cache the pre-maximised geometry before going fullscreen
Fri, Nov 16, 11:59 AM
davidedmundson closed D16921: [wayland] WlShell cache the pre-maximised geometry before going fullscreen.
Fri, Nov 16, 11:59 AM · KWin
davidedmundson committed R108:2e42f4c1a368: [wayland] Fix ShellClient removing borders to give the same window geometry (authored by davidedmundson).
[wayland] Fix ShellClient removing borders to give the same window geometry
Fri, Nov 16, 11:59 AM
davidedmundson closed D16920: [wayland] Fix ShellClient removing borders to give the same window geometry.
Fri, Nov 16, 11:59 AM · KWin
davidedmundson abandoned D2754: Touchpad KDED: fix metadata warning.
Fri, Nov 16, 11:54 AM · Plasma
davidedmundson commandeered D2754: Touchpad KDED: fix metadata warning.

This was merged at some point
Closing the RR.

Fri, Nov 16, 11:54 AM · Plasma
davidedmundson requested changes to D2975: [shell] Event compress resizePanel.

Marking as request changes to remove from queue pending reply to Kai's question

Fri, Nov 16, 11:53 AM · Plasma
davidedmundson accepted D16900: Don't use an icon that is only supposed for plasmoids.
Fri, Nov 16, 11:48 AM · Plasma
davidedmundson added a comment to D16449: [scripting] Introduce redirect function.

Generally, ship it!

Fri, Nov 16, 11:29 AM · KWin
davidedmundson accepted D16914: [Runners KCM] Focus the search field by default.
Fri, Nov 16, 11:23 AM · Plasma
davidedmundson requested review of D16922: [wayland] Fix ShellClientTest.
Fri, Nov 16, 11:10 AM · KWin
davidedmundson requested review of D16921: [wayland] WlShell cache the pre-maximised geometry before going fullscreen.
Fri, Nov 16, 11:09 AM · KWin
davidedmundson requested review of D16920: [wayland] Fix ShellClient removing borders to give the same window geometry.
Fri, Nov 16, 11:08 AM · KWin
davidedmundson requested review of D16919: Re-add DBus test.
Fri, Nov 16, 10:03 AM · Konsole

Thu, Nov 15

davidedmundson accepted D16908: [decorations] Emit DecorationSettings::fontChanged signal.
Thu, Nov 15, 7:44 PM · KWin
davidedmundson accepted D16903: Fix KeyboardLayoutTest::testNumLock.
Thu, Nov 15, 5:02 PM · KWin
davidedmundson added a comment to D16897: Allow windows to be closed from the window switchers.

You can do control+w with

Thu, Nov 15, 3:24 PM · Plasma
davidedmundson updated subscribers of D16886: [windowswitcher] Implement keyboard navigation.

In the previous patch @Zren said:

Thu, Nov 15, 3:22 PM · Plasma
davidedmundson requested changes to D16897: Allow windows to be closed from the window switchers.

you can't hardcode the key combos

Thu, Nov 15, 3:18 PM · Plasma
davidedmundson committed R127:98b0ad34b68f: Add VirtualDesktops to PlasmaWindowModel (authored by davidedmundson).
Add VirtualDesktops to PlasmaWindowModel
Thu, Nov 15, 11:56 AM
davidedmundson closed D16883: Add VirtualDesktops to PlasmaWindowModel.
Thu, Nov 15, 11:56 AM · Frameworks
davidedmundson committed R127:f1c8b16a0026: Update PlasmaWindowModel test to reflect VirtualDesktop changes (authored by davidedmundson).
Update PlasmaWindowModel test to reflect VirtualDesktop changes
Thu, Nov 15, 11:56 AM
davidedmundson committed R127:06c18f5869f3: Cleanup windowInterface in tests before windowManagement is destroyed (authored by davidedmundson).
Cleanup windowInterface in tests before windowManagement is destroyed
Thu, Nov 15, 11:56 AM
davidedmundson closed D16880: Update PlasmaWindowModel test to reflect VirtualDesktop changes.
Thu, Nov 15, 11:56 AM · Frameworks
davidedmundson closed D16877: Cleanup windowInterface in tests before windowManagement is destroyed.
Thu, Nov 15, 11:56 AM · Frameworks
davidedmundson committed R120:02541b8af06e: [logout-greeter] Use correct enum for logout hint to QML (authored by davidedmundson).
[logout-greeter] Use correct enum for logout hint to QML
Thu, Nov 15, 11:34 AM
davidedmundson closed D16891: [logout-greeter] Use correct enum for logout hint to QML.
Thu, Nov 15, 11:34 AM · Plasma
davidedmundson accepted D16859: Rename config loading function.
Thu, Nov 15, 10:30 AM · Plasma
davidedmundson updated the summary of D16891: [logout-greeter] Use correct enum for logout hint to QML.
Thu, Nov 15, 10:28 AM · Plasma
davidedmundson closed D16885: Delete the correct item in removeDesktop.
Thu, Nov 15, 10:19 AM · Frameworks
davidedmundson committed R127:f25eadc92c47: Delete the correct item in removeDesktop (authored by davidedmundson).
Delete the correct item in removeDesktop
Thu, Nov 15, 10:19 AM
davidedmundson accepted D16887: Send all active downloads on load.
Thu, Nov 15, 9:06 AM · Plasma
davidedmundson requested review of D16891: [logout-greeter] Use correct enum for logout hint to QML.
Thu, Nov 15, 8:18 AM · Plasma

Wed, Nov 14

davidedmundson requested review of D16885: Delete the correct item in removeDesktop.
Wed, Nov 14, 11:55 PM · Frameworks
davidedmundson retitled D16880: Update PlasmaWindowModel test to reflect VirtualDesktop changes from Update PlasmaWindowManagementTest for VirtualDesktop changes to Update PlasmaWindowModel test to reflect VirtualDesktop changes.
Wed, Nov 14, 11:52 PM · Frameworks
davidedmundson added inline comments to D16832: fix empty runner list after switching to new locale.
Wed, Nov 14, 9:36 PM · Frameworks, Localization
davidedmundson updated the diff for D16883: Add VirtualDesktops to PlasmaWindowModel.

update the plasma virtual desktop test at the same time

Wed, Nov 14, 8:08 PM · Frameworks
davidedmundson requested review of D16883: Add VirtualDesktops to PlasmaWindowModel.
Wed, Nov 14, 7:32 PM · Frameworks
davidedmundson accepted D16875: [kded] Cleanup KScreenDaemon class.
Wed, Nov 14, 5:53 PM · Plasma
davidedmundson added inline comments to D16875: [kded] Cleanup KScreenDaemon class.
Wed, Nov 14, 5:39 PM · Plasma
davidedmundson requested review of D16880: Update PlasmaWindowModel test to reflect VirtualDesktop changes.
Wed, Nov 14, 4:16 PM · Frameworks
davidedmundson updated subscribers of D16877: Cleanup windowInterface in tests before windowManagement is destroyed.
Wed, Nov 14, 2:50 PM · Frameworks
davidedmundson requested review of D16877: Cleanup windowInterface in tests before windowManagement is destroyed.
Wed, Nov 14, 2:50 PM · Frameworks
davidedmundson added a comment to D16792: [drm] Code cleanup in DrmOutput class.

The include changes are obviously sensible. +2 on that.

Wed, Nov 14, 12:01 PM · KWin
davidedmundson accepted D16874: [kded] Replace configReady functon with lambda.
Wed, Nov 14, 11:56 AM · Plasma
davidedmundson requested changes to D16875: [kded] Cleanup KScreenDaemon class.
Wed, Nov 14, 11:36 AM · Plasma
davidedmundson added a comment to D16874: [kded] Replace configReady functon with lambda.

Note, that the configReady function was a public slot in an exported class, so is it safe?

Wed, Nov 14, 11:29 AM · Plasma
davidedmundson added a comment to D16704: [wayland] add enter/leave virtual desktop API.

Let's try to get it in. I want to have passing tests this week again.

Wed, Nov 14, 11:24 AM · KWin
davidedmundson committed R108:f521d4bbe165: [wayland] add enter/leave virtual desktop API (authored by davidedmundson).
[wayland] add enter/leave virtual desktop API
Wed, Nov 14, 11:08 AM
davidedmundson closed D16704: [wayland] add enter/leave virtual desktop API.
Wed, Nov 14, 11:08 AM · KWin
davidedmundson updated the diff for D16704: [wayland] add enter/leave virtual desktop API.

whitespace

Wed, Nov 14, 1:37 AM · KWin
davidedmundson updated the diff for D16704: [wayland] add enter/leave virtual desktop API.

testVirtualDesktop (which is different from testVirtualDesktops) now passes.

Wed, Nov 14, 1:27 AM · KWin

Tue, Nov 13

davidedmundson requested changes to D16868: Fix VirtualDesktopTest after fixing semantics of AbstractClient::setDesktop.

See my other patch.

Tue, Nov 13, 7:04 PM · KWin
davidedmundson committed R127:a167548830fb: Cleanup Virtual Desktop Manager list entry in PlasmaVirtualDesktop destructor (authored by davidedmundson).
Cleanup Virtual Desktop Manager list entry in PlasmaVirtualDesktop destructor
Tue, Nov 13, 4:36 PM
davidedmundson closed D16686: Cleanup Virtual Desktop Manager list entry in PlasmaVirtualDesktop destructor.
Tue, Nov 13, 4:36 PM · Frameworks
davidedmundson committed R108:2fb2fb9a44af: [wayland] add explict AbstractClient::setDesktops(QList) (authored by davidedmundson).
[wayland] add explict AbstractClient::setDesktops(QList)
Tue, Nov 13, 4:08 PM
davidedmundson closed D16703: [wayland] add explict AbstractClient::setDesktops(QList).
Tue, Nov 13, 4:08 PM · KWin
davidedmundson added a comment to D16865: Unbreak AbstractClient::setDesktop.

I was waiting to sort out a minor thing in D16704 so that we can have everything working nicely without the wayland side regressing, but I can push D16703 without too much issue.

Tue, Nov 13, 4:01 PM · KWin
davidedmundson added a comment to D16865: Unbreak AbstractClient::setDesktop.

It does.

Tue, Nov 13, 3:59 PM · KWin
davidedmundson accepted D16789: Abstract OutputDevice initialization.

I'm not loving the name, the goal of this patchset is to move all of the wayland logic out of the platform.

Tue, Nov 13, 2:17 PM · KWin

Mon, Nov 12

davidedmundson accepted D16846: [wayland] Don't crash when resizing windows.
Mon, Nov 12, 11:56 PM · KWin
davidedmundson accepted D16845: Make use of libkscreen hash API.
Mon, Nov 12, 11:45 PM · Plasma
davidedmundson accepted D16843: Add output and connected outputs config API.
Mon, Nov 12, 5:49 PM · Plasma
davidedmundson accepted D16787: Abstract output dpms handling.
Mon, Nov 12, 3:02 PM · KWin
davidedmundson added inline comments to D16787: Abstract output dpms handling.
Mon, Nov 12, 2:41 PM · KWin
davidedmundson added inline comments to D16787: Abstract output dpms handling.
Mon, Nov 12, 2:10 PM · KWin
davidedmundson accepted D16793: Move output refresh rate getter into AbstractOutput.
Mon, Nov 12, 1:55 PM · KWin
davidedmundson accepted D16794: Add output orientation size helper.
Mon, Nov 12, 1:30 PM · KWin
davidedmundson added a comment to D16792: [drm] Code cleanup in DrmOutput class.

why are we moving methods about?

Mon, Nov 12, 1:29 PM · KWin
davidedmundson committed R134:d783ebd003c9: Load KDE QtQuickSettings in Discover (authored by davidedmundson).
Load KDE QtQuickSettings in Discover
Mon, Nov 12, 11:22 AM