davidedmundson (David Edmundson)
User

Projects (14)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 17 2015, 10:32 PM (221 w, 3 d)
Availability
Available

Recent Activity

Today

davidedmundson added a comment to D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami.

Ha, you're totally right. Amazing! Is this something to fix in Plasma frameworks?

Tue, Jul 16, 12:30 AM · Plasma
davidedmundson added a comment to D22475: Use metadata.json when creating the metadata from KPackage::metadata().

That was less than 5 hours from posting to give up on a review!

Tue, Jul 16, 12:14 AM · Frameworks

Yesterday

davidedmundson added a comment to D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami.

Screen size and DPI combinations are so variable that I think it makes sense to support a higher level of precision.

Mon, Jul 15, 11:44 PM · Plasma
davidedmundson added a comment to D22481: Do not show play/pause button when no media is playing.

Why?

Mon, Jul 15, 6:59 PM · Plasma
davidedmundson added a comment to D22474: Install KPackages with kpackage_install_package.

Is it possible to use kpackage_install_package inside of each effect's CMakeLists.txt file? The problem is that now "toplevel" effect directories contain only one directory - package.

Mon, Jul 15, 2:32 PM · KWin
davidedmundson added a comment to D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen.

Idea makes sense.

Mon, Jul 15, 1:53 PM · Plasma
davidedmundson added a comment to D22471: [KProcessList] Split command line and process name.

So now name() will often return an empty string?

Mon, Jul 15, 1:42 PM · Frameworks
davidedmundson committed R278:3c5f3f8ba4cd: Port KXMessages away from QWidget (authored by davidedmundson).
Port KXMessages away from QWidget
Mon, Jul 15, 1:11 PM
davidedmundson closed D22472: Port KXMessages away from QWidget.
Mon, Jul 15, 1:11 PM · Frameworks
davidedmundson added a comment to D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami.

On Wayland everything works fine. Might be a Qt bug in input handlers directly and not the code here. Other ideas?

Mon, Jul 15, 1:10 PM · Plasma
davidedmundson requested review of D22472: Port KXMessages away from QWidget.
Mon, Jul 15, 1:00 PM · Frameworks
davidedmundson updated the diff for D22471: [KProcessList] Split command line and process name.

Swap member order

Mon, Jul 15, 11:21 AM · Frameworks
davidedmundson requested review of D22471: [KProcessList] Split command line and process name.
Mon, Jul 15, 10:38 AM · Frameworks

Sun, Jul 14

davidedmundson added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

If I remove

Sun, Jul 14, 4:39 PM
davidedmundson added a comment to D22339: Make sure solid backends are reentrant.

I don't endorse things being closed whilst there are still review comments, but replying purely on the tech side:

Sun, Jul 14, 11:20 AM · Frameworks

Fri, Jul 12

davidedmundson accepted D22414: Fix build due to missing QVector include.
Fri, Jul 12, 10:18 AM · Frameworks

Thu, Jul 11

davidedmundson added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

Will formatter ruin beautiful multi-line formatting into single line?

Thu, Jul 11, 6:41 PM
davidedmundson updated the task description for T11214: Running clang-format across all plasma (and potentially over repos).
Thu, Jul 11, 2:04 PM
davidedmundson updated the task description for T11214: Running clang-format across all plasma (and potentially over repos).
Thu, Jul 11, 1:43 PM
davidedmundson created T11214: Running clang-format across all plasma (and potentially over repos).
Thu, Jul 11, 1:36 PM
davidedmundson accepted D22396: Fix typo in CREATE_GETTER_AND_SETTER.
Thu, Jul 11, 11:18 AM · Plasma
davidedmundson accepted D22339: Make sure solid backends are reentrant.
Thu, Jul 11, 10:10 AM · Frameworks
davidedmundson updated the title for P434 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Thu, Jul 11, 9:05 AM
davidedmundson updated the title for P433 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Thu, Jul 11, 1:09 AM

Wed, Jul 10

davidedmundson committed R119:4e2db5dc02a2: [kcms/ksmserver] Port to new kworkspace API (authored by davidedmundson).
[kcms/ksmserver] Port to new kworkspace API
Wed, Jul 10, 11:00 PM
davidedmundson closed D21763: [kcms/ksmserver] Port to new kworkspace API.
Wed, Jul 10, 11:00 PM · Plasma
davidedmundson committed R120:6bab1f518c50: Split ksmserver into a small application that handles startup and ksmserver (authored by bruns).
Split ksmserver into a small application that handles startup and ksmserver
Wed, Jul 10, 10:52 PM
davidedmundson closed D21995: Split ksmserver into a small application that handles startup and ksmserver.
Wed, Jul 10, 10:52 PM · Plasma
davidedmundson accepted D22387: Allow KAutostart to be constructed using an absolute path.
Wed, Jul 10, 9:36 PM · Frameworks
davidedmundson added a comment to T4437: [kwayland] Security filter.

A relevant link on future work on app identification.

Wed, Jul 10, 9:34 PM · Plasma on Wayland
davidedmundson accepted D22388: Fix case-sensitivity typo in libinput configuration function.
Wed, Jul 10, 9:04 PM · KWin
davidedmundson added a comment to D22209: [effects/screenshot] Disable screenshot to file on Wayland.

Lets not discuss that here. We get a scattering of notes randomly distributed across various review requests.

Wed, Jul 10, 6:00 PM · KWin
davidedmundson committed R108:9b04e0315c2c: [autotests] Test placement strategies (authored by davidedmundson).
[autotests] Test placement strategies
Wed, Jul 10, 5:48 PM
davidedmundson closed D21996: [autotests] Test placement strategies.
Wed, Jul 10, 5:48 PM · KWin
davidedmundson added a comment to D22362: Port keystates to use QtWayland's generator.

As some background:

Wed, Jul 10, 4:00 PM · Frameworks
davidedmundson added a comment to D22292: drm: Save scaling and position of displays at shutdown.

All this KScreen stuff is a mess to be honest. KWin/Wayland needs to be in charge, not KScreen.

Wed, Jul 10, 3:42 PM · KWin
davidedmundson accepted D22333: Move Solid::Device::listFromQuery calls to a separate thread.
Wed, Jul 10, 3:35 PM · Plasma
davidedmundson added inline comments to D22379: Don't use deprecated QDesktopWidget.
Wed, Jul 10, 2:24 PM · KWin
davidedmundson accepted D22372: Don't use deprecated QAbstractItemModel::reset().
Wed, Jul 10, 1:37 PM · KWin
davidedmundson accepted D22370: Simplify previous-/nextActivity code in kactivities-cli.
Wed, Jul 10, 10:36 AM · Frameworks
davidedmundson accepted D22296: [ksmserver] Remove obsolete KDELibs4Support dependency.
Wed, Jul 10, 12:23 AM · Plasma

Tue, Jul 9

davidedmundson accepted D22356: Port away from deprecated Qt::escape.
Tue, Jul 9, 9:35 PM · KWin
davidedmundson accepted D22357: Fix -Wredundant-move.
Tue, Jul 9, 9:30 PM · KWin
davidedmundson accepted D22351: Port away from deprecated headers.
Tue, Jul 9, 8:09 PM · KWin
davidedmundson accepted D22287: [colorcorrection] Introduce toggle Night Color shortcut.
Tue, Jul 9, 2:47 PM · KWin
davidedmundson added inline comments to D22191: Implement syncing of theme preferences between SDDM and Plasma.
Tue, Jul 9, 2:04 PM · Plasma
davidedmundson added a comment to D22287: [colorcorrection] Introduce toggle Night Color shortcut.

We can display an OSD on Wayland, but not on X11.

Tue, Jul 9, 2:03 PM · KWin
davidedmundson added a comment to D22193: [effects] Mark effect classes as final.

It's harmless, so I don't exactly object, but I don't really understand what problem you're taking time to solve.

Tue, Jul 9, 12:21 PM · KWin
davidedmundson added a comment to T9927: Reboot & Shutdown UI options.

With new plasma we have a nice infrastructure for prompts.
One can implement a DBus activatable implementing org.kde.LogoutPrompt

Tue, Jul 9, 9:13 AM · Plasma: Mobile
davidedmundson accepted D22337: Fix check for SCHED_RESET_ON_FORK feature in clean build.
Tue, Jul 9, 8:11 AM · KWin
davidedmundson accepted D22336: Hide some of kwin kcm on mobile.
Tue, Jul 9, 6:30 AM · KWin

Mon, Jul 8

davidedmundson added a comment to D22296: [ksmserver] Remove obsolete KDELibs4Support dependency.

Given it's already broken, I would say just kill it.

Mon, Jul 8, 5:47 PM · Plasma
davidedmundson updated the diff for D22327: [libnotificationmanager] Port to lighter KProcessList.

remove from cmake

Mon, Jul 8, 2:17 PM · Plasma
davidedmundson requested review of D22327: [libnotificationmanager] Port to lighter KProcessList.
Mon, Jul 8, 2:14 PM · Plasma
davidedmundson added a comment to D21606: RFC: ThreadWeaver Job Decorators not used properly and have no effect.

https://bugs.kde.org/show_bug.cgi?id=381835

Mon, Jul 8, 1:08 PM · Frameworks
davidedmundson added inline comments to D22316: Avoid garbling the sound if the volume slider is moved fast.
Mon, Jul 8, 12:02 PM · Plasma
davidedmundson added a comment to D22322: Store crash report automatically if shutting down.

What's the rationale behind this change? Isn't this use case covered by coredumpd and the like?

Mon, Jul 8, 11:05 AM · Plasma
davidedmundson added a comment to D22322: Store crash report automatically if shutting down.

One question, when do we create a DBusInterfaceLauncher instance. Is it in time here?

Mon, Jul 8, 10:28 AM · Plasma
davidedmundson accepted D22320: Hide "Dummy Output" from output list and improve user-visible labels.
Mon, Jul 8, 9:43 AM · Plasma

Sun, Jul 7

davidedmundson accepted D18153: Correct code style of Client fullscreen control.
Sun, Jul 7, 9:58 PM · KWin
davidedmundson added a comment to D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC.

The fundamental problem with this approach is you only sort through the dirs correctly, but not the total across multiple paths.

Sun, Jul 7, 6:09 PM · Plasma
davidedmundson requested changes to D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders.

Nate's crash is due to data not code.

Sun, Jul 7, 2:09 PM · Plasma
davidedmundson accepted D22302: fix kstart5 crash on wayland.
Sun, Jul 7, 7:40 AM · Plasma

Fri, Jul 5

davidedmundson added inline comments to D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders.
Fri, Jul 5, 2:03 PM · Plasma
davidedmundson added inline comments to D22287: [colorcorrection] Introduce toggle Night Color shortcut.
Fri, Jul 5, 10:45 AM · KWin
davidedmundson accepted D22286: [kcmkwin] Add a clear button to the Desktop Effects search field.
Fri, Jul 5, 9:37 AM · KWin

Thu, Jul 4

davidedmundson updated the diff for D21995: Split ksmserver into a small application that handles startup and ksmserver.

Reset state when told to resume an empty session

Thu, Jul 4, 3:53 PM · Plasma
davidedmundson updated the diff for D21995: Split ksmserver into a small application that handles startup and ksmserver.

update2

Thu, Jul 4, 3:43 PM · Plasma
davidedmundson updated the diff for D21995: Split ksmserver into a small application that handles startup and ksmserver.

update

Thu, Jul 4, 3:34 PM · Plasma
davidedmundson accepted D21963: Keep Klipper notifications out of notification history.
Thu, Jul 4, 1:18 PM · Plasma
davidedmundson accepted D22264: Always call into ksmserver DBus interface.
Thu, Jul 4, 1:12 PM · Plasma
davidedmundson accepted D22258: Improve plugin caching.

Drop the qDebug

Thu, Jul 4, 10:03 AM · Frameworks
davidedmundson accepted D22257: performance, Qt API.
Thu, Jul 4, 9:56 AM · Frameworks
davidedmundson added a comment to D22241: KModifierKeyInfo: we are sharing the internal implementation.

I don't understand the bug being fixed.

Thu, Jul 4, 9:17 AM · Frameworks
davidedmundson added a comment to D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC.

This is awkward timing.

Thu, Jul 4, 7:00 AM · Plasma

Wed, Jul 3

davidedmundson added inline comments to D22225: Partly remove Compositor restart functionality.
Wed, Jul 3, 10:31 PM · KWin
davidedmundson added a comment to D22191: Implement syncing of theme preferences between SDDM and Plasma.
I think it could be done with a systemd service
Wed, Jul 3, 8:11 PM · Plasma
davidedmundson accepted D22216: Use wayland-protocols.

It's the technically correct thing to do.

Wed, Jul 3, 12:54 PM · Frameworks
davidedmundson updated the title for P425 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Wed, Jul 3, 12:50 PM
davidedmundson updated the title for P424 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Wed, Jul 3, 5:58 AM

Tue, Jul 2

davidedmundson added a comment to D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.

Yeah, I understand the situation.

Tue, Jul 2, 8:45 PM · Plasma
davidedmundson accepted D22219: [plugins/qpa] Return fixed logicalDpi.
Tue, Jul 2, 7:19 PM · KWin
davidedmundson added a comment to D22218: Use new slot syntax in Compositor class.

TimerEvent shouldn't really be made private.
We typically don't change accessibility of superclass methods.

Tue, Jul 2, 7:03 PM · KWin
davidedmundson updated the diff for D21995: Split ksmserver into a small application that handles startup and ksmserver.

whitespace

Tue, Jul 2, 4:39 PM · Plasma
davidedmundson updated the diff for D21995: Split ksmserver into a small application that handles startup and ksmserver.

update

Tue, Jul 2, 4:35 PM · Plasma
davidedmundson committed R120:cd3e9a291a66: Rewrite kworkspace logout, shutdown and suspend API (authored by davidedmundson).
Rewrite kworkspace logout, shutdown and suspend API
Tue, Jul 2, 4:27 PM
davidedmundson closed D19389: Rewrite kworkspace logout, shutdown and suspend API.
Tue, Jul 2, 4:27 PM · Plasma
davidedmundson accepted D22211: [platforms/drm] Refactor out Edid class.
Tue, Jul 2, 3:09 PM · KWin
davidedmundson added inline comments to D22211: [platforms/drm] Refactor out Edid class.
Tue, Jul 2, 1:57 PM · KWin
davidedmundson added inline comments to D21996: [autotests] Test placement strategies.
Tue, Jul 2, 1:44 PM · KWin
davidedmundson updated the diff for D21996: [autotests] Test placement strategies.

update

Tue, Jul 2, 1:43 PM · KWin
davidedmundson requested changes to D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.

This means most our normal users in an office who don't know/care if they're running X11 or wayland have some extra tech-garbage after the name.

Tue, Jul 2, 9:46 AM · Plasma
davidedmundson added a comment to D22209: [effects/screenshot] Disable screenshot to file on Wayland.

I don't really agree, for the same reasons that I would have happily accepted David R's patch

Tue, Jul 2, 9:30 AM · KWin
davidedmundson added inline comments to D22191: Implement syncing of theme preferences between SDDM and Plasma.
Tue, Jul 2, 8:39 AM · Plasma

Mon, Jul 1

davidedmundson updated the diff for D19389: Rewrite kworkspace logout, shutdown and suspend API.

Keep canSwitchUser behaviour from KDisplayManager

Mon, Jul 1, 9:51 PM · Plasma
davidedmundson added inline comments to D22191: Implement syncing of theme preferences between SDDM and Plasma.
Mon, Jul 1, 3:21 PM · Plasma
davidedmundson accepted D16425: Added new Suspend then Hibernate option.

I'd quite like to get this in as I'll end up moving part of this - and we've got too much bikeshedding here.

Mon, Jul 1, 1:08 PM · Plasma
davidedmundson added a comment to D22102: Implement apply-on-double-click for all grid view KCM delegates.

Exposing the options through a simple command line interface would be another option.

Mon, Jul 1, 11:42 AM · Frameworks
davidedmundson added a comment to D22033: Remove confirmation overlay from screenshotFullscreen.

And IIRC this method isn't supported on Wayland where the stricter security matters.

Mon, Jul 1, 11:24 AM · KWin
davidedmundson added a comment to D21948: [colorcorrection] Add "Constant" mode.

I think I see where the difference of opinion is coming from.

Mon, Jul 1, 9:02 AM · KWin