- User Since
- Apr 17 2015, 10:32 PM (144 w, 2 d)
Sat, Jan 20
Fri, Jan 19
Thanks for the patience going through this! Some reviews do go through a lot of iterations, but it's generally worth it.
@Kanedias if you can make a small test app that acts as a client side and fetches a buffer (what you already have in krdc, but standalone) and put that somewhere, that would be awesome.
Then maybe I can hook up DBus and possibly pipewire from there. It'll split the workload.
Thu, Jan 18
Wed, Jan 17
In terms of goals, is this interface:
I handle scaling everyewhere except for Plasma which does it's own thing.
Edit: please make sure the CI has this before pushing.
Tue, Jan 16
Do you have commit access?
Mon, Jan 15
Looks sensible to me.
Thanks ever so much.
There's been a bug report open on this for ages.
Please merge after 5.12 branches.
Sat, Jan 13
Definitely not for 5.12 material with the release this close, but in general I'm in favour of it with the 4 months of testing we'd get if we went with this soon after branching.
Fri, Jan 12
That looks really good!
Thu, Jan 11
You know my rule by now. If we're working round a Qt bug, we should have a Qt bug report.
Wed, Jan 10
maybe one could still work around by connecting blindly to that by hand
The config stuff (or correct versions thereof) are already in master.
Tue, Jan 9
DBus code is all good.
Meh. If there's nothing by 5.12.0 push it, but hopefully we can get something better by then.
Because I do timer.stop() (lines 101ff) when I start dragging, I dont want it to ever go away while dragging.
Mon, Jan 8
I don't understand how this relates to the bug.
Do you have commit access.
Feel free to commit your example into the tests folder.
It's not graphics.
Sat, Jan 6
Fri, Jan 5
Remove unintended change to .ui file
maybe we need a lnf specific config module? It's not the first feature where I would say that this actually doesn't belong into kscreenlocker kcm as it's specific to the theme.
I don't think this can work (as per comment in kscreenlocker review)
Lazy create the palette manager
Thu, Jan 4
I think the change is needed and makes sense.
I'd like to see a link to an upstream Qt bug report in the comment
Could we use tabBar.layout.children.length directly in the state instead of a new property?
Wed, Jan 3
Please fill in the "testing done" field.
Why don't rely on QDBusTrayIcon?