davidedmundson (David Edmundson)
User

Projects (11)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 17 2015, 10:32 PM (144 w, 2 d)
Availability
Available

Recent Activity

Today

davidedmundson updated the diff for D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager.

Debug--

Mon, Jan 22, 12:46 PM · Plasma

Yesterday

davidedmundson committed R105:c0070395bd19: Fix QString from latin 1 error (authored by davidedmundson).
Fix QString from latin 1 error
Sun, Jan 21, 11:09 PM

Sat, Jan 20

davidedmundson committed R242:5eece6769f21: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to… (authored by rkron).
Fix one source of log spam referenced in Bug 388389 (Empty filename passed to…
Sat, Jan 20, 10:26 PM
davidedmundson closed D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function).
Sat, Jan 20, 10:26 PM · Frameworks

Fri, Jan 19

davidedmundson accepted D9967: Acknowledge the server side deco mode in WaylandServer not ShellClient.
Fri, Jan 19, 12:22 PM · Plasma
davidedmundson accepted D9979: [Notifications] Disable history check box when notifications are disabled.
Fri, Jan 19, 9:39 AM · Plasma
Restricted Application edited projects for D9848: Updated the blur method to use the more efficient dual kawase blur algorithm., added: Plasma; removed KWin.

Thanks for the patience going through this! Some reviews do go through a lot of iterations, but it's generally worth it.

Fri, Jan 19, 12:45 AM · Plasma
davidedmundson added a comment to T7785: PipeWire support in remote access to KWin.

@Kanedias if you can make a small test app that acts as a client side and fetches a buffer (what you already have in krdc, but standalone) and put that somewhere, that would be awesome.
Then maybe I can hook up DBus and possibly pipewire from there. It'll split the workload.

Fri, Jan 19, 12:16 AM · KWin, Plasma on Wayland

Thu, Jan 18

davidedmundson accepted D9963: [KCMShell] Don't assume KCModuleProxy is our child widget.
Thu, Jan 18, 3:41 PM · Plasma

Wed, Jan 17

davidedmundson accepted D9948: [AppMenu Applet] Underline mnemonics only while Alt is pressed.
Wed, Jan 17, 5:10 PM · Plasma
Restricted Application edited projects for D9944: [WIP]expose if the tablet mode switch is available, added: KWin; removed Plasma.

In terms of goals, is this interface:

Wed, Jan 17, 2:30 PM · KWin
davidedmundson accepted D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function).
Wed, Jan 17, 1:47 PM · Frameworks
davidedmundson added a comment to D9286: don't multiply svg sizes by devicepixelratio.

I handle scaling everyewhere except for Plasma which does it's own thing.

Wed, Jan 17, 10:51 AM · Frameworks, Plasma
Restricted Application edited projects for D9930: Require libinput version 1.9, added: Plasma; removed KWin.

Edit: please make sure the CI has this before pushing.

Wed, Jan 17, 12:29 AM · KWin

Tue, Jan 16

davidedmundson accepted D9930: Require libinput version 1.9.
Tue, Jan 16, 10:24 PM · KWin
davidedmundson added a comment to D8816: Show root items in kicker menu.

Do you have commit access?

Tue, Jan 16, 1:29 PM · Plasma

Mon, Jan 15

davidedmundson added a comment to D9904: Wayland: don't share the same Config between backend and clients.

Looks sensible to me.

Mon, Jan 15, 9:59 PM · Plasma
davidedmundson accepted D9905: Don't create multiple in-process backend instances.
Mon, Jan 15, 9:48 PM · Plasma
davidedmundson accepted D9902: KDED: restore output scale from config.

Thanks ever so much.
There's been a bug report open on this for ages.

Mon, Jan 15, 9:47 PM · Plasma
davidedmundson added a comment to D9792: even slimmer scrollbars.

Please merge after 5.12 branches.

Mon, Jan 15, 10:49 AM · Kirigami, Plasma
davidedmundson accepted D9812: [Icon Item] Treat sources starting with a slash as local file.
Mon, Jan 15, 9:12 AM · Frameworks, Plasma

Sat, Jan 13

Restricted Application edited projects for D9848: Updated the blur method to use the more efficient dual kawase blur algorithm., added: Plasma; removed KWin.

Definitely not for 5.12 material with the release this close, but in general I'm in favour of it with the 4 months of testing we'd get if we went with this soon after branching.

Sat, Jan 13, 9:40 AM · Plasma

Fri, Jan 12

davidedmundson accepted D9849: [keditfiletype] Enable high dpi pixmaps.
Fri, Jan 12, 11:43 PM · Plasma
davidedmundson added a comment to D9827: [Task Manager] Let badge become pill-shaped and limit to 0 through 9,999 items.

That looks really good!

Fri, Jan 12, 2:43 PM · Plasma
davidedmundson accepted D9838: [Task Manager] Reverse DBus setup order.
Fri, Jan 12, 11:48 AM · Plasma

Thu, Jan 11

davidedmundson accepted D9818: [Wallpaper Image Configuration] Set cfg_Image whenever delegate becomes current.
Thu, Jan 11, 2:34 PM · Plasma
davidedmundson edited P157 Masterwork From Distant Lands.
Thu, Jan 11, 12:38 PM
davidedmundson added a comment to D9754: [Notifications] Use custom DragHelper instead of Qt's Drag attached property.

You know my rule by now. If we're working round a Qt bug, we should have a Qt bug report.

Thu, Jan 11, 12:36 PM · Plasma

Wed, Jan 10

davidedmundson accepted D9795: Sync the startplasmacompositor with startkde.
Wed, Jan 10, 5:18 PM · Plasma
Restricted Application edited projects for D9764: A basic TabletModeManager, added: KWin; removed Plasma.

maybe one could still work around by connecting blindly to that by hand

Wed, Jan 10, 5:12 PM · KWin
davidedmundson committed R120:6202fc258e0b: Replace bc with awk (authored by Peter Eszlari <peter.eszlari@gmail.com>).
Replace bc with awk
Wed, Jan 10, 5:03 PM
davidedmundson committed R120:e0afc9ec4f8a: Add clarifying comment (authored by davidedmundson).
Add clarifying comment
Wed, Jan 10, 5:03 PM
davidedmundson requested changes to D9795: Sync the startplasmacompositor with startkde.

The config stuff (or correct versions thereof) are already in master.

Wed, Jan 10, 4:58 PM · Plasma
davidedmundson accepted D9787: [Theme Explorer] Use theme name instead of ID in theme dropdown.
Wed, Jan 10, 1:10 PM · Plasma
davidedmundson accepted D9788: [Theme Explorer] Quit with Ctrl+Q.
Wed, Jan 10, 1:09 PM · Plasma
davidedmundson committed R108:04dbafd75edd: Fix Plastik bottom and right border (authored by davidedmundson).
Fix Plastik bottom and right border
Wed, Jan 10, 12:13 PM
davidedmundson closed D9776: Fix Plastik bottom and right border.
Wed, Jan 10, 12:13 PM · Plasma
Restricted Application edited projects for D9776: Fix Plastik bottom and right border, added: Plasma; removed KWin.
Wed, Jan 10, 2:27 AM · Plasma

Tue, Jan 9

davidedmundson committed R133:c5575734b56e: Remove double margin in KCM UI (authored by davidedmundson).
Remove double margin in KCM UI
Tue, Jan 9, 9:17 PM
davidedmundson closed D9769: Remove double margin in KCM UI.
Tue, Jan 9, 9:17 PM · Plasma
Restricted Application edited projects for D9764: A basic TabletModeManager, added: KWin; removed Plasma.

DBus code is all good.

Tue, Jan 9, 2:12 PM · KWin
davidedmundson accepted D9763: [Slideshow] Don't repeatedly restart on startup.
Tue, Jan 9, 1:48 PM · Plasma
davidedmundson added a comment to D9762: [Image Wallpaper] Just use Timer to determin when we're ready.

Meh. If there's nothing by 5.12.0 push it, but hopefully we can get something better by then.

Tue, Jan 9, 1:45 PM · Plasma
davidedmundson accepted D9761: [Image Wallpaper Configuration] Fix check state for blur / solid color radios.
Tue, Jan 9, 1:30 PM · Plasma
davidedmundson accepted D9735: [Notifications] Don't restart hide timer on reposition while dragging.

Because I do timer.stop() (lines 101ff) when I start dragging, I dont want it to ever go away while dragging.

Tue, Jan 9, 1:29 PM · Plasma

Mon, Jan 8

davidedmundson added a comment to D9735: [Notifications] Don't restart hide timer on reposition while dragging.

I don't understand how this relates to the bug.

Mon, Jan 8, 4:18 PM · Plasma
davidedmundson committed R120:e2b7c395ecdb: Fix for xembedsniproxy crash due to NULL returned from xcb_image_get() (authored by maciejsitarz).
Fix for xembedsniproxy crash due to NULL returned from xcb_image_get()
Mon, Jan 8, 3:03 PM
davidedmundson closed D9732: Fix for xembedsniproxy crash due to NULL returned from xcb_image_get().
Mon, Jan 8, 3:03 PM · Plasma
davidedmundson accepted D9732: Fix for xembedsniproxy crash due to NULL returned from xcb_image_get().

Thanks.
Do you have commit access.

Mon, Jan 8, 2:27 PM · Plasma
davidedmundson accepted D9733: Display exclusive actions correctly in systray menus.

Feel free to commit your example into the tests folder.

Mon, Jan 8, 2:11 PM · Plasma
davidedmundson committed R133:e36101cd1b48: Load config specified by the LnF theme (authored by davidedmundson).
Load config specified by the LnF theme
Mon, Jan 8, 1:13 PM
davidedmundson closed D9684: Load config specified by the LnF theme.
Mon, Jan 8, 1:13 PM · Plasma
davidedmundson committed R133:d0db15779275: Remove unused class SelectImageButton (authored by davidedmundson).
Remove unused class SelectImageButton
Mon, Jan 8, 1:13 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Mon, Jan 8, 1:13 PM · Plasma
davidedmundson committed R120:7878c9988d10: Add config for the lockscreen to toggle media controls (authored by davidedmundson).
Add config for the lockscreen to toggle media controls
Mon, Jan 8, 11:47 AM
davidedmundson closed D9685: Add config for the lockscreen to toggle media controls.
Mon, Jan 8, 11:47 AM · Plasma
davidedmundson requested changes to D9678: Delay loading most used model.
Mon, Jan 8, 9:42 AM · Plasma
davidedmundson accepted D9225: Fix building autotest on platforms where syscalls are not available.
Mon, Jan 8, 9:39 AM · Plasma
davidedmundson added a comment to D9678: Delay loading most used model.

It's not graphics.

Mon, Jan 8, 9:36 AM · Plasma
davidedmundson accepted D9651: [Icons KCM] Construct QUrl from local file.
Mon, Jan 8, 9:33 AM · Plasma

Sat, Jan 6

davidedmundson accepted D9703: Allow applications using KActivities to not crash even if no dbus server is around.
Sat, Jan 6, 11:05 PM · Frameworks

Fri, Jan 5

davidedmundson updated the diff for D9684: Load config specified by the LnF theme.

Debug--

Fri, Jan 5, 6:38 PM · Plasma
davidedmundson committed R135:0490a151f95b: Use explicit palette interface (authored by davidedmundson).
Use explicit palette interface
Fri, Jan 5, 6:32 PM
davidedmundson closed D9658: Use explicit palette interface.
Fri, Jan 5, 6:32 PM · Plasma
davidedmundson updated the diff for D9684: Load config specified by the LnF theme.

Remove unintended change to .ui file

Fri, Jan 5, 6:32 PM · Plasma
davidedmundson added a comment to D9684: Load config specified by the LnF theme.

Fri, Jan 5, 6:31 PM · Plasma
davidedmundson committed R120:fd7d1ca3d705: Drop use of qtpaths in startkde (authored by davidedmundson).
Drop use of qtpaths in startkde
Fri, Jan 5, 1:59 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Fri, Jan 5, 1:59 PM · Plasma
davidedmundson added a comment to D9601: Make media controls configurable.

maybe we need a lnf specific config module? It's not the first feature where I would say that this actually doesn't belong into kscreenlocker kcm as it's specific to the theme.

Fri, Jan 5, 1:18 PM · Plasma
davidedmundson requested changes to D9600: [Look and feel package definition] Add X-Plasma-Capabilities.

I don't think this can work (as per comment in kscreenlocker review)

Fri, Jan 5, 1:05 PM · Frameworks, Plasma
davidedmundson updated the diff for D9658: Use explicit palette interface.

Lazy create the palette manager

Fri, Jan 5, 12:19 PM · Plasma
davidedmundson committed R135:ba25aa68afda: Remove now unused set window property (authored by davidedmundson).
Remove now unused set window property
Fri, Jan 5, 11:33 AM
davidedmundson closed D9659: Remove now unused set window property.
Fri, Jan 5, 11:33 AM · Plasma
davidedmundson committed R135:778ee5f541d7: Update AppMenu for an app having multiple windows (authored by davidedmundson).
Update AppMenu for an app having multiple windows
Fri, Jan 5, 11:33 AM
davidedmundson accepted D9643: Support submenus in context menu for systray icon.
Fri, Jan 5, 11:30 AM · Plasma
davidedmundson committed R127:c1fd2b4826e8: Minor doxygen change to group new bind/create methods (authored by davidedmundson).
Minor doxygen change to group new bind/create methods
Fri, Jan 5, 11:21 AM
davidedmundson committed R135:189a19f4e40d: Add manual test for win deco palettes (authored by davidedmundson).
Add manual test for win deco palettes
Fri, Jan 5, 10:51 AM
davidedmundson closed D9657: Add manual test for win deco palettes.
Fri, Jan 5, 10:51 AM · Plasma

Thu, Jan 4

davidedmundson requested changes to D9601: Make media controls configurable.

I think the change is needed and makes sense.

Thu, Jan 4, 7:05 PM · Plasma
davidedmundson accepted D9631: [DBusMenuImporter] Send "opened" signal alongside about to show.
Thu, Jan 4, 6:52 PM · Plasma
davidedmundson accepted D9635: [AppMenuModel] Monitor window properties.
Thu, Jan 4, 6:51 PM · Plasma
davidedmundson accepted D9642: [User Switcher] Workaround Connections {} not working on "plasmoid".

I'd like to see a link to an upstream Qt bug report in the comment

Thu, Jan 4, 6:44 PM · Plasma
davidedmundson accepted D9655: [Kickoff] Hide tab bar if only one tab button is configured.

Could we use tabBar.layout.children.length directly in the state instead of a new property?

Thu, Jan 4, 6:42 PM · Plasma
davidedmundson committed R108:01d6878dc2d3: Add explicit protocol for colour scheme management (authored by davidedmundson).
Add explicit protocol for colour scheme management
Thu, Jan 4, 6:32 PM
davidedmundson closed D9660: Add explicit protocol for colour scheme management.
Thu, Jan 4, 6:32 PM · Plasma
davidedmundson added inline comments to D9478: Drop use of qtpaths in startkde.
Thu, Jan 4, 6:25 PM · Plasma
Restricted Application edited projects for D9660: Add explicit protocol for colour scheme management, added: Plasma; removed KWin.
Thu, Jan 4, 5:04 PM · Plasma
davidedmundson committed R127:8826e890dd44: Fix naming inconsistency (authored by davidedmundson).
Fix naming inconsistency
Thu, Jan 4, 4:42 PM
davidedmundson closed D9656: Fix naming inconsistency.
Thu, Jan 4, 4:42 PM · Plasma, Frameworks
Restricted Application edited projects for D9656: Fix naming inconsistency, added: Plasma; removed Plasma on Wayland.
Thu, Jan 4, 3:01 PM · Plasma, Frameworks
davidedmundson updated the diff for D9478: Drop use of qtpaths in startkde.

Update

Thu, Jan 4, 1:23 PM · Plasma

Wed, Jan 3

davidedmundson added a comment to D9643: Support submenus in context menu for systray icon.

Please fill in the "testing done" field.

Wed, Jan 3, 5:50 PM · Plasma
davidedmundson added a comment to D9643: Support submenus in context menu for systray icon.

Why don't rely on QDBusTrayIcon?

Wed, Jan 3, 5:45 PM · Plasma
davidedmundson accepted D9641: [Digital Clock] Add tooltip for agenda items with too long description.
Wed, Jan 3, 3:25 PM · Plasma
davidedmundson accepted D8698: Fix KProtocoInfoTest if krusader is installed.
Wed, Jan 3, 11:49 AM · Frameworks
davidedmundson committed R127:773a4b13089a: Resolve some merge issues (authored by davidedmundson).
Resolve some merge issues
Wed, Jan 3, 11:07 AM
davidedmundson committed R127:a3e1e937ca4c: Unit test for Server Decoration Palette (authored by davidedmundson).
Unit test for Server Decoration Palette
Wed, Jan 3, 10:44 AM
davidedmundson committed R127:dec26d932914: Create interface for passing server decoration palettes (authored by davidedmundson).
Create interface for passing server decoration palettes
Wed, Jan 3, 10:39 AM
davidedmundson closed D9599: Create interface for passing server decoration palettes.
Wed, Jan 3, 10:39 AM · Plasma on Wayland, Frameworks
davidedmundson added inline comments to D9631: [DBusMenuImporter] Send "opened" signal alongside about to show.
Wed, Jan 3, 9:58 AM · Plasma