davidedmundson (David Edmundson)
User

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 17 2015, 10:32 PM (157 w, 4 d)
Availability
Available

Recent Activity

Yesterday

davidedmundson updated the summary of D9608: [KScreen Effect] Fade opacity only for transparent windows.
Tue, Apr 24, 10:00 PM · KWin
davidedmundson updated the diff for D9608: [KScreen Effect] Fade opacity only for transparent windows.

A better version

Tue, Apr 24, 9:59 PM · KWin
davidedmundson commandeered D9608: [KScreen Effect] Fade opacity only for transparent windows.
Tue, Apr 24, 9:58 PM · KWin
davidedmundson accepted D12503: [Desktop Theme KCM] Adjust to changes in other KCMs.
Tue, Apr 24, 8:53 PM · Plasma
davidedmundson added a comment to D9037: use desktop file actions instead of global shortcuts.

I have a plan for a kconf_update v2 which would resolve the problem above nicely
Probably means this would be 5.14.

Tue, Apr 24, 7:24 PM · Plasma
davidedmundson added a comment to D12466: [effects/backgroundcontrast] Calculate correct y-coord of the copy rect.

mapFrom surely

Tue, Apr 24, 3:57 PM · KWin
davidedmundson accepted D12496: Add .arcconfig.
Tue, Apr 24, 3:30 PM · Plasma
davidedmundson requested changes to D9037: use desktop file actions instead of global shortcuts.
Tue, Apr 24, 3:12 PM · Plasma
davidedmundson accepted D9653: [FStab Handling] Clean up process running by using lambdas.
Tue, Apr 24, 3:07 PM · Frameworks
davidedmundson accepted D11112: Hide KUrlNavigatorProtocolCombo if there is just one protocol supported.
Tue, Apr 24, 3:01 PM · Frameworks
davidedmundson accepted D11111: Only show supported schemes in KUrlNavigatorProtocolCombo.
Tue, Apr 24, 2:59 PM · Frameworks
davidedmundson accepted D9221: [KLineEdit] Use Qt's built-in clear button functionality.
Tue, Apr 24, 2:48 PM · Frameworks
davidedmundson accepted D6864: [System Monitor Applet] Add setting for update interval.

Please add the "." that cfeck said, then ship it

Tue, Apr 24, 2:45 PM · Plasma
davidedmundson requested changes to D3837: [Calendar] Optimize Backend.

marking as request changes based on my comments

Tue, Apr 24, 2:45 PM · Frameworks, Plasma
davidedmundson committed R102:cf6d1c6dbe1d: Merge branch 'Plasma/5.12' (authored by davidedmundson).
Merge branch 'Plasma/5.12'
Tue, Apr 24, 2:37 PM
davidedmundson committed R102:776386dc3a4f: kcm_opengl: Fix EGL info retrieval. (authored by roberts).
kcm_opengl: Fix EGL info retrieval.
Tue, Apr 24, 2:37 PM
davidedmundson committed R108:47818c097f6b: Merge branch 'Plasma/5.12' (authored by davidedmundson).
Merge branch 'Plasma/5.12'
Tue, Apr 24, 2:36 PM
davidedmundson committed R108:bec8493459d5: Don't try to filter null key combinations (authored by apol).
Don't try to filter null key combinations
Tue, Apr 24, 2:35 PM
davidedmundson accepted D12495: [Desktop Theme KCM] Workaround bug in FileDialog.
Tue, Apr 24, 2:29 PM · Plasma
davidedmundson committed R120:b9f9581f99ef: Show lockscreen controls when hitting a modifier (authored by davidedmundson).
Show lockscreen controls when hitting a modifier
Tue, Apr 24, 2:18 PM
davidedmundson closed D12494: Show lockscreen controls when hitting a modifier.
Tue, Apr 24, 2:18 PM · Plasma
davidedmundson added a comment to D10078: Add separate lib KF5::DBusRunner.

We have lots of KJob API patterns when *making* an async call to something else.
I can't think of any async-ly handling somethign else (except for maybe slavebase) , so we are in a fairly unique position here.

Tue, Apr 24, 1:38 PM · Frameworks
davidedmundson committed R119:5f2f3afcf6c2: fix (authored by davidedmundson).
fix
Tue, Apr 24, 1:14 PM
davidedmundson committed R119:88767f007d6a: start port kickoff to upcoming Qt labs handler as test (authored by davidedmundson).
start port kickoff to upcoming Qt labs handler as test
Tue, Apr 24, 1:07 PM
davidedmundson committed R108:b2ed73cdb0cd: fb_backend_qpainter_backend: Use logind to determine if the session is active. (authored by nerdopolist).
fb_backend_qpainter_backend: Use logind to determine if the session is active.
Tue, Apr 24, 12:21 PM
davidedmundson closed D9574: fb_backend_qpainter_backend: Use logind to determine if the session is active..
Tue, Apr 24, 12:21 PM · KWin
davidedmundson added a comment to D9574: fb_backend_qpainter_backend: Use logind to determine if the session is active..

Thanks for merging my other patches! What does it mean when one is accepted, but not merged though? Do I need to rebase this one?

Tue, Apr 24, 12:14 PM · KWin
davidedmundson requested review of D12494: Show lockscreen controls when hitting a modifier.
Tue, Apr 24, 10:35 AM · Plasma
davidedmundson added a comment to D12466: [effects/backgroundcontrast] Calculate correct y-coord of the copy rect.

As this is clearly more readable:
y = sg.height() - (r.y() - sg.y() + r.height())

Tue, Apr 24, 9:49 AM · KWin
davidedmundson accepted D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces.
Tue, Apr 24, 8:57 AM · Plasma
davidedmundson added a comment to D10078: Add separate lib KF5::DBusRunner.

I read your comments.

Tue, Apr 24, 8:07 AM · Frameworks

Mon, Apr 23

davidedmundson requested changes to D10078: Add separate lib KF5::DBusRunner.
Mon, Apr 23, 9:49 PM · Frameworks
davidedmundson added a comment to D12469: Fix avatar picture aliasing and stretching in kickoff.

setting sourceWidth/height so that it resizes before the texture upload

Mon, Apr 23, 3:49 PM · Plasma
davidedmundson added a comment to D12469: Fix avatar picture aliasing and stretching in kickoff.

why mipmap?

Mon, Apr 23, 3:41 PM · Plasma
davidedmundson accepted D12468: Enable anti-aliasing for user avatars.

I think so.

Mon, Apr 23, 2:28 PM · Plasma
davidedmundson added a comment to D12468: Enable anti-aliasing for user avatars.

why ignore aspect ratio?

Mon, Apr 23, 2:11 PM · Plasma
davidedmundson committed R119:101b5f749aa9: Add KCM for adjusting QtQuick Rendering in Plasma (authored by davidedmundson).
Add KCM for adjusting QtQuick Rendering in Plasma
Mon, Apr 23, 12:37 PM
davidedmundson closed D7934: Add KCM for adjusting QtQuick Rendering in Plasma.
Mon, Apr 23, 12:37 PM · Plasma
davidedmundson committed R124:2b158ac36aa6: Add hidden system setting group (authored by davidedmundson).
Add hidden system setting group
Mon, Apr 23, 12:35 PM
davidedmundson closed D12449: Add hidden system setting group.
Mon, Apr 23, 12:35 PM · Plasma

Sun, Apr 22

davidedmundson accepted D12455: kcm_opengl: Fix EGL info retrieval..
Sun, Apr 22, 6:33 PM · Plasma
davidedmundson added a comment to D12452: [libkwineffects/kwinglutils] Calculate correct srcY0 and srcY1 in GLRenderTarget::blitFromFramebuffer.

In the sense that they both involve scaling, yes. But otherwise not really. See my patch that first fixed it. But as you say this is very unrelated. Blur doesn't even use this function.

Sun, Apr 22, 6:16 PM · KWin
davidedmundson added a member for KWin: davidedmundson.
Sun, Apr 22, 5:51 PM
davidedmundson added a comment to D12452: [libkwineffects/kwinglutils] Calculate correct srcY0 and srcY1 in GLRenderTarget::blitFromFramebuffer.

On X kwin doesn't do any scaling s_virtualScreenScale will always be 1.

Sun, Apr 22, 5:46 PM · KWin
davidedmundson added a comment to D12452: [libkwineffects/kwinglutils] Calculate correct srcY0 and srcY1 in GLRenderTarget::blitFromFramebuffer.

This line was modded with 9cafbb117984f746d4b71213effc3d27e1435f36
That also claimed to be a bug fix that fixing things, and that one was tested with vertically stacked multiscreens.

Sun, Apr 22, 5:44 PM · KWin
davidedmundson accepted D12448: Fix KCompletionBox on wayland.

It's a bit cheeky, but it's the only soltuion that doesn't require an invasive patch inverting the way input is eventFiltered.

Sun, Apr 22, 4:56 PM · Frameworks
davidedmundson committed R119:1793b51ed8b9: add preview images to fonts kcm (authored by progwolff).
add preview images to fonts kcm
Sun, Apr 22, 3:36 PM
davidedmundson closed D11064: add preview images to fonts kcm.
Sun, Apr 22, 3:36 PM · Plasma
davidedmundson accepted D12351: introduce candidateContainments.
Sun, Apr 22, 3:30 PM · Plasma
davidedmundson added a comment to D7934: Add KCM for adjusting QtQuick Rendering in Plasma.

You can, but given it's intended audience and how hidden it now is, it really isn't worth putting a lot of time into.

Sun, Apr 22, 2:57 PM · Plasma
davidedmundson requested review of D12449: Add hidden system setting group.
Sun, Apr 22, 2:53 PM · Plasma
davidedmundson updated the diff for D7934: Add KCM for adjusting QtQuick Rendering in Plasma.

Hide in systemsettings whilst keeping in krunner

Sun, Apr 22, 2:50 PM · Plasma
davidedmundson committed R120:05b096135ca9: Use the default Plasma wallpaper on the login screen (authored by davidedmundson).
Use the default Plasma wallpaper on the login screen
Sun, Apr 22, 2:45 PM
davidedmundson closed D11309: Use the default Plasma wallpaper on the login screen.
Sun, Apr 22, 2:45 PM · Plasma
davidedmundson accepted D12314: expose the wallpaper config to the lockscreen.
Sun, Apr 22, 2:22 PM · Plasma
davidedmundson added a comment to D12243: Add XDG Output support.

Just to clarify somethig, even though we need this for fractional scaling (which is quite a bit in the future) it's also needed to fix an xwayland fullscreen bug at regular 2x.
So I want this for 5.13 if possible

Sun, Apr 22, 1:18 PM · KWin
davidedmundson accepted D12375: [Power Management Engine] Fix kiosk restriction for lockscreen.
Sun, Apr 22, 9:26 AM · Plasma
davidedmundson accepted D11308: Use the default Plasma wallpaper on the lock screen.
Sun, Apr 22, 9:26 AM · Plasma

Sat, Apr 21

davidedmundson accepted D12384: Fix double margins around DownloadDialog.
Sat, Apr 21, 2:41 PM · Frameworks
davidedmundson added a comment to D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS.

I can't imagine this working. It didn't when I've tried the same thing.
Docs say QT_SCREEN_SCALE_FACTORS doesn't affect the logical DPI. which means you have a 1x scale on one screen 2x on another..they both have the same font size which will just be really wrong.

Sat, Apr 21, 2:17 PM · Plasma

Fri, Apr 20

davidedmundson added a comment to D12373: Klipper: Remove first history item on clipboard clear.

We have two settings:
The first, when the X selection owner gets cleared, replaces the clipboard with the top entry
This one when the X selection owner gets cleared, deletes the top entry in the UI.

Fri, Apr 20, 11:25 AM · Plasma
davidedmundson added a comment to D12373: Klipper: Remove first history item on clipboard clear.

Right, but pressing control+v again won't paste the item after clearing which I assumed was the intended goal

Fri, Apr 20, 10:43 AM · Plasma
davidedmundson added a comment to D12373: Klipper: Remove first history item on clipboard clear.

Aren't you just duplicating the existing "prevent empty clipboard" option ?

Fri, Apr 20, 10:24 AM · Plasma
davidedmundson accepted D12359: Also read sddm.conf.d config directories.
Fri, Apr 20, 9:11 AM · Plasma
davidedmundson accepted D12186: Fix build with Qt 5.11_beta3 (dropping qt5_use_modules).
Fri, Apr 20, 8:59 AM

Thu, Apr 19

davidedmundson requested changes to D9572: framebuffer: Attempt to set the framebuffer color layout on the framebuffer device.

Kinda makes sense, though the weston code also set the resolution and bpp.

Thu, Apr 19, 10:16 PM · KWin
davidedmundson added a comment to D12066: [options] Disable prior selections of EGL on X backend.

That "fixes" it for those who accidentally have it enabled but don't want it
but breaks it for those who deliberately went and enabled it (possibly with the GUI, possibly manually)

Thu, Apr 19, 10:06 PM · KWin
davidedmundson accepted D12209: [effects/presentwindows] Fix -Wint-in-bool-context.

Surely this is now two cases of ints in booleans instead of one...but if the compiler prefers this one, sure.

Thu, Apr 19, 10:02 PM · KWin
davidedmundson accepted D12254: [effects/minimizeanimation] Don't reset timeline.
Thu, Apr 19, 9:50 PM · KWin
davidedmundson accepted D12253: [effects/magiclamp] Don't reset timeline.
Thu, Apr 19, 9:49 PM · KWin
davidedmundson accepted D12208: Fix unused param warnings.
Thu, Apr 19, 9:44 PM · KWin
davidedmundson accepted D12322: Add environment variable to force sw cursor.
Thu, Apr 19, 9:42 PM · KWin
davidedmundson accepted D12361: Use XCursorTheme on wayland as well.
Thu, Apr 19, 7:04 PM · Plasma

Wed, Apr 18

davidedmundson accepted D12330: Consistently use KQuickControls.ColorButton in the config UI.
Wed, Apr 18, 9:32 PM · Plasma
davidedmundson added a comment to D12102: Port Language KCM to Qt Quick.

It's looking a trillion times better than the early screenshots.

Wed, Apr 18, 8:27 PM · Kirigami, Plasma
davidedmundson added a comment to D12102: Port Language KCM to Qt Quick.

This revision was not accepted when it landed; it landed in state Changes Planned.Wed, Apr 18, 8:54 PM

Wed, Apr 18, 8:13 PM · Kirigami, Plasma
davidedmundson accepted D12318: Consistently use KQuickControls.ColorButton in the config UI.

So much red!

Wed, Apr 18, 7:37 PM · Plasma
davidedmundson accepted D12323: Read theme.conf of themes.

1 minor change.

Wed, Apr 18, 6:32 PM · Plasma
davidedmundson added a comment to D12318: Consistently use KQuickControls.ColorButton in the config UI.

There's ColorButton (https://api.kde.org/frameworks/kdeclarative/html/classColorButton.html) inside kquickcontrols

Wed, Apr 18, 6:24 PM · Plasma
davidedmundson accepted D12311: Align lock icon with bold message text; reduce overall size of dialog.
Wed, Apr 18, 6:18 PM · Plasma
davidedmundson added a comment to D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width.

Personally I sort of, well, hate this and it was a very conscious design decision to make the menu widths uniform, so I'd like some more VDG opinions to convince me otherwise first.

Wed, Apr 18, 2:53 PM · Plasma
davidedmundson added a comment to D12311: Align lock icon with bold message text; reduce overall size of dialog.

Probably fine, but can you attach a screenshot

Wed, Apr 18, 2:37 PM · Plasma
davidedmundson added a comment to T7325: Window Decorations.

I don't think we have the same sort of window decorations on a mobile

Wed, Apr 18, 2:25 PM · Plasma: KCM Redesign
davidedmundson committed R108:52e42df9d626: Clean up kwindecoration KCM qml code (authored by davidedmundson).
Clean up kwindecoration KCM qml code
Wed, Apr 18, 10:03 AM
davidedmundson closed D12284: Clean up kwindecoration KCM qml code.
Wed, Apr 18, 10:03 AM · KWin

Tue, Apr 17

davidedmundson accepted D12240: Save the dialog view settings when closing the dialog without hitting the cancel button.
Tue, Apr 17, 10:11 PM · Plasma
davidedmundson accepted D12227: Save the dialog view settings even when canceling.
Tue, Apr 17, 10:10 PM · Frameworks
davidedmundson requested changes to D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
Tue, Apr 17, 9:03 PM · Plasma
davidedmundson accepted D12288: [mediaframe applet] Support creation of widget on file drop on containment.
Tue, Apr 17, 4:42 PM · Plasma
davidedmundson accepted D12287: [mediaframe applet] Fix defunct adding of new files/folder per DnD.
Tue, Apr 17, 4:36 PM · Plasma
davidedmundson requested review of D12284: Clean up kwindecoration KCM qml code.
Tue, Apr 17, 3:37 PM · KWin
davidedmundson accepted D12134: [mediaframe applet] Fix broken selection of fill mode.
Tue, Apr 17, 12:51 PM · Plasma
davidedmundson added a comment to D12278: WIP: [Colors KCM] Port to new design.

Not too fond of this "Current"

Tue, Apr 17, 11:57 AM · Plasma
davidedmundson accepted D12275: FunnelModel: fix invalid model API usage..
Tue, Apr 17, 11:22 AM · Plasma
davidedmundson accepted D12277: Fix build with Qt 4.
Tue, Apr 17, 11:16 AM · Plasma

Mon, Apr 16

davidedmundson updated the language for P195 Masterwork From Distant Lands from autodetect to autodetect.
Mon, Apr 16, 4:13 PM
davidedmundson requested changes to D12148: update the wallpaper dialog to the new design.
Mon, Apr 16, 2:31 PM · Plasma
davidedmundson accepted D12090: port the look and feel kcm to new design.
Mon, Apr 16, 2:28 PM · Plasma
davidedmundson updated the diff for D12235: Add XDG Output Protocol.

Some minor fixes

Mon, Apr 16, 9:36 AM · Frameworks
davidedmundson requested review of D12243: Add XDG Output support.
Mon, Apr 16, 9:35 AM · KWin