- User Since
- Apr 19 2015, 12:29 AM (200 w, 4 d)
Tue, Feb 19
Hmmmm, it doesn't seem to totally work
Mon, Feb 18
My suggestion at https://phabricator.kde.org/D19135
This needs a test for whole word search.
Let's just get rid of it altogether, it's going to be a bit painful do an if version in cmake
Sun, Feb 17
Code looks good to me, do you want me to actually test it or are you confident enough that it works?
The code doesn't link.
Sat, Feb 16
I didn't realize you moved the text out of the i18n call.
Do not use Alt+Anything for a shortcut it's bad
Yes, imported targets are the future/present :)
Wording improvements suggested by Aleix
Fri, Feb 15
Requires a much newer KF5 so i can ping you in 6 months if you want.
also update the KF5 requirement
The code can't be much simpler than this, there's not much places it can go wrong, i guess the only other thing to mention is, poppler will crash with some bad data, so i don't know if this is on it's own process or not, but if it's not it may bring down whatever app uses it, though given the gs issues lately it's probably not worse?
KDevelope people the comment says to ask you too about it