aacid (Albert Astals Cid)
Engineering

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 19 2015, 12:29 AM (272 w, 1 d)
Availability
Available

Recent Activity

Fri, Jul 3

aacid added a comment to T4803: Consolidate {branches/stable,trunk}/l10n-{kde4,kf5}/scripts into a git repository.

I feel like it would be a good moment to pick up this again, @ltoscano what do you think?

Fri, Jul 3, 9:11 PM · Localization

Wed, Jun 24

aacid added a comment to D21277: Add "Cig Waste No. 2" theme.

Hmm, arc land says...

FETCH  Fetching origin/master...
fatal: unable to update url base from redirection:
  asked for: https://git@invent.kde.org/kmines/info/refs?service=git-upload-pack
   redirect: https://invent.kde.org/users/sign_in
Usage Exception: Fetch failed! Fix the error and run "arc land" again.

What can I do now? Except a new merge request on https://invent.kde.org/games/kmines?

Wed, Jun 24, 9:07 PM
aacid added a comment to D21277: Add "Cig Waste No. 2" theme.

Any special reason it's called "No. 2"? Is there a No 1 somewhere?

Yes :) - No. 1 is a slightly modified version of my original proposal, which I uploaded here: https://www.pling.com/p/1397003/.

Wed, Jun 24, 8:40 PM
aacid accepted D21277: Add "Cig Waste No. 2" theme.

Ok, i guess you can commit it.

Wed, Jun 24, 8:16 AM

Thu, Jun 18

aacid committed R883:1572276: New pt_BR screeshots.
New pt_BR screeshots
Thu, Jun 18, 9:14 PM
aacid committed R883:1572274: New serbian screenshots.
New serbian screenshots
Thu, Jun 18, 9:10 PM
aacid committed R883:1572273: updated slovak screenshots.
updated slovak screenshots
Thu, Jun 18, 9:08 PM

Wed, Jun 17

aacid committed R883:1572192: Update sl screenshots.
Update sl screenshots
Wed, Jun 17, 9:18 PM

Tue, Jun 16

aacid committed R883:1571915: more utf8.
more utf8
Tue, Jun 16, 10:02 PM
aacid committed R883:1571914: utf8.
utf8
Tue, Jun 16, 10:00 PM
aacid committed R883:1571913: small tweak to catalan index.php.
small tweak to catalan index.php
Tue, Jun 16, 9:59 PM
aacid committed R883:1571912: Updated screenshots in catalan.
Updated screenshots in catalan
Tue, Jun 16, 9:59 PM

Sat, Jun 13

aacid added a comment to D26342: Allow overriding to disable auto language detection.

This actually breaks language auto-detection for me in the KMail composer.

Testcase:

  • New Mail
  • I type "Bonjour," in the body

    Before: It's detected as French and not underlined as a typo

    After: The language remains English, and the word is underlined as a typo

    Workaround: Tools / Spelling / change language from English to French

    Too bad I'm realizing this is the reason for the regression only today (day of 5.71 release) by looking at the KF-5.71 changelog :(

I don't think that's a regression, in the previous behavior you could try to set any language to proofread, it would always auto-detect "Bonjour" as French, thus the "Tools / Spelling / change language" had not effect if autodetect was enabled at system level (while autodetection should be an application or even case by case decision).

It may not seem like an issue for simple cases, but actually for mixed contents (i.e. an email that is 50% French, 50% English) that would be detected as English, you would have no way at all to check the French text without disabling system-wide autodectection.

Calling setAutoDetectLanguageDisabled(false) restores the previous behavior

Sat, Jun 13, 4:07 PM · Frameworks
aacid committed R883:1571565: hardcode the php version we need in the scripts.
hardcode the php version we need in the scripts
Sat, Jun 13, 4:02 PM
aacid committed R883:1571542: anongit is gone.
anongit is gone
Sat, Jun 13, 10:27 AM
aacid added a comment to T4803: Consolidate {branches/stable,trunk}/l10n-{kde4,kf5}/scripts into a git repository.

Given the current state of instability we have due to the gitlab migration + different structure fallout, let's give us a few weeks to try to stabilize things and come back to this?

Sat, Jun 13, 9:43 AM · Localization

Thu, Jun 11

aacid committed R883:1571436: Remove po without pot.
Remove po without pot
Thu, Jun 11, 9:33 PM
aacid committed R883:1571434: remove po without pot.
remove po without pot
Thu, Jun 11, 9:33 PM
aacid added a comment to T13263: Can opt-in to make the tests failing make the CI be marked as failed instead of as success?.

Yes i understand the scripts are shared between gitlab and jenkins and that lots of projects are not "very good" in keeping their tests clean, that's why i asked this to be opt-in for those projects that try to actually have passing tests :)

Thu, Jun 11, 5:35 PM · build.kde.org

Wed, Jun 10

aacid created T13263: Can opt-in to make the tests failing make the CI be marked as failed instead of as success?.
Wed, Jun 10, 10:24 PM · build.kde.org

Tue, Jun 9

aacid committed R322:fdc0f47691ab: Make KGmap::getDivisionToCapitalQuestionPattern() a KLocalizedString (authored by pino).
Make KGmap::getDivisionToCapitalQuestionPattern() a KLocalizedString
Tue, Jun 9, 9:11 PM
aacid committed R322:33f5385d22b0: Make KGmap::getCapitalToDivisionQuestionPattern() a KLocalizedString (authored by pino).
Make KGmap::getCapitalToDivisionQuestionPattern() a KLocalizedString
Tue, Jun 9, 9:11 PM
aacid committed R322:562f5e4443cb: Store division::p_falseCapitals as translated (authored by pino).
Store division::p_falseCapitals as translated
Tue, Jun 9, 9:11 PM
aacid committed R322:811246650aab: Store division::p_name as translated (authored by pino).
Store division::p_name as translated
Tue, Jun 9, 9:11 PM
aacid committed R322:62c837f17497: Store the untranslated name in division (authored by pino).
Store the untranslated name in division
Tue, Jun 9, 9:11 PM
aacid committed R322:339060329327: Store KGmap::p_divisionsString as translated (authored by pino).
Store KGmap::p_divisionsString as translated
Tue, Jun 9, 9:11 PM
aacid committed R322:d2f3ac47bb73: Store KGmap::p_name as translated (authored by pino).
Store KGmap::p_name as translated
Tue, Jun 9, 9:11 PM
aacid committed R322:23dbb7ca4e6d: Store KGmap::p_divisionToCapitalTitle as translated (authored by pino).
Store KGmap::p_divisionToCapitalTitle as translated
Tue, Jun 9, 9:11 PM
aacid committed R322:8396abbefbf5: Store KGmap::p_capitalToDivisionTitle as translated (authored by pino).
Store KGmap::p_capitalToDivisionTitle as translated
Tue, Jun 9, 9:11 PM
aacid committed R322:1bf7e1ee3847: Store division::p_capital as translated (authored by pino).
Store division::p_capital as translated
Tue, Jun 9, 9:11 PM
aacid committed R322:c43a3d61b7fd: Get the msgctxt for the map once (authored by pino).
Get the msgctxt for the map once
Tue, Jun 9, 9:11 PM

Sun, Jun 7

aacid committed R223:7a51799484f5: Merge remote-tracking branch 'origin/release/20.04' (authored by aacid).
Merge remote-tracking branch 'origin/release/20.04'
Sun, Jun 7, 10:33 PM
aacid committed R241:2ed65ffeab8d: Port from KRandom::random to QRandomGenerator (authored by aacid).
Port from KRandom::random to QRandomGenerator
Sun, Jun 7, 10:17 AM
aacid committed R495:47a620766f9d: Use QRandomGenerator instead of KRandom::random() (authored by aacid).
Use QRandomGenerator instead of KRandom::random()
Sun, Jun 7, 10:11 AM
aacid committed R495:f462559d02b0: Use QRandomGenerator instead of KRandom::random() (authored by aacid).
Use QRandomGenerator instead of KRandom::random()
Sun, Jun 7, 10:08 AM
aacid committed R265:64544ea85820: Use QRandomGenerator::global instead of KRandom::random() (authored by aacid).
Use QRandomGenerator::global instead of KRandom::random()
Sun, Jun 7, 10:03 AM
aacid committed R410:270a964c5b76: Merge remote-tracking branch 'origin/release/20.04' (authored by aacid).
Merge remote-tracking branch 'origin/release/20.04'
Sun, Jun 7, 9:47 AM
aacid committed R332:338201de98e9: fix warning with modern gcc about having constructor but not operator= (authored by aacid).
fix warning with modern gcc about having constructor but not operator=
Sun, Jun 7, 9:37 AM
aacid committed R332:d3a828c9aa7a: remove unused variable (authored by aacid).
remove unused variable
Sun, Jun 7, 9:37 AM

Jun 4 2020

aacid added a comment to D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later).

oh i think i'm too late :D

Jun 4 2020, 10:04 PM · Frameworks
aacid added a comment to D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later).

oh i think i'm too late :D

Jun 4 2020, 10:04 PM · Frameworks
aacid committed R223:284bcc626c29: Fix/Workaround file where we can't enter values in some fields (authored by aacid).
Fix/Workaround file where we can't enter values in some fields
Jun 4 2020, 9:58 PM
aacid added a comment to D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later).

It didn't really land on Qt 5.15 yet, so we may need to update the comment to say 5.15.1 or something

Jun 4 2020, 5:36 PM · Frameworks
aacid committed R244:2d347837739e: Deprecate KRandom::random (authored by aacid).
Deprecate KRandom::random
Jun 4 2020, 3:51 PM

Jun 3 2020

aacid committed R883:1570441: new cs screenshots.
new cs screenshots
Jun 3 2020, 10:53 PM
aacid committed R883:1570440: Just use the browser to make the image smaller.
Just use the browser to make the image smaller
Jun 3 2020, 10:44 PM
aacid committed R322:feb0204c0c96: Port away from deprecated matrix() methods (authored by aacid).
Port away from deprecated matrix() methods
Jun 3 2020, 10:31 PM
aacid committed R322:d7551ceb4ddb: Increase qt, cmake and kf5 requirements a bit (authored by aacid).
Increase qt, cmake and kf5 requirements a bit
Jun 3 2020, 10:17 PM
aacid committed R322:4060384e3070: Port away from SmallIcon (authored by aacid).
Port away from SmallIcon
Jun 3 2020, 10:07 PM
aacid committed R223:daad6c9fa1f8: Silence some deprecation warnings we can't fix (authored by aacid).
Silence some deprecation warnings we can't fix
Jun 3 2020, 9:37 PM
aacid committed R223:5295d490aa95: Silence some deprecation warnings we can't fix (authored by aacid).
Silence some deprecation warnings we can't fix
Jun 3 2020, 9:36 PM
aacid committed R223:8bd51cd97d45: Merge remote-tracking branch 'origin/release/20.04' (authored by aacid).
Merge remote-tracking branch 'origin/release/20.04'
Jun 3 2020, 7:04 AM

Jun 2 2020

aacid committed R223:9d4f66538e01: Initialize m_tocEnabled (authored by aacid).
Initialize m_tocEnabled
Jun 2 2020, 9:08 PM
aacid committed R223:8460d34f3447: pdf: fix memory leak when listing fonts (authored by aacid).
pdf: fix memory leak when listing fonts
Jun 2 2020, 9:00 PM
aacid committed R883:1570131: make sure we have all the repoids in the database for stats to work.
make sure we have all the repoids in the database for stats to work
Jun 2 2020, 7:35 PM

Jun 1 2020

aacid committed R223:d7a88a170e84: Merge remote-tracking branch 'origin/release/20.04' (authored by aacid).
Merge remote-tracking branch 'origin/release/20.04'
Jun 1 2020, 10:01 AM

May 31 2020

aacid committed R883:1569909: 5.1 for kmymoney.
5.1 for kmymoney
May 31 2020, 11:06 PM

May 30 2020

aacid committed R223:1bb637574927: Merge branch 'release/20.04' (authored by aacid).
Merge branch 'release/20.04'
May 30 2020, 5:43 PM
aacid committed R223:eee401946bf6: Don't attach to another instance if we're going to exit (authored by aacid).
Don't attach to another instance if we're going to exit
May 30 2020, 5:43 PM
aacid committed R223:98570d363385: Fix indentation (authored by aacid).
Fix indentation
May 30 2020, 5:28 PM
aacid committed R410:9b1d9abdc56f: Change some verbose debugs from using ifndef NDEBUG (authored by aacid).
Change some verbose debugs from using ifndef NDEBUG
May 30 2020, 5:17 PM
aacid committed R410:2cf9243bb72b: Change some verbose debugs from using ifndef NDEBUG (authored by aacid).
Change some verbose debugs from using ifndef NDEBUG
May 30 2020, 10:24 AM

May 26 2020

aacid committed R417:332476fee507: Merge remote-tracking branch 'origin/release/20.04' (authored by aacid).
Merge remote-tracking branch 'origin/release/20.04'
May 26 2020, 10:34 PM
aacid committed R417:5a4871302cb6: Fix saving over an existing save file (authored by aacid).
Fix saving over an existing save file
May 26 2020, 10:34 PM
aacid committed R223:1a430419a482: Merge remote-tracking branch 'origin/release/20.04' (authored by aacid).
Merge remote-tracking branch 'origin/release/20.04'
May 26 2020, 9:11 PM

May 25 2020

aacid committed R223:040e11c52baa: Fix ZoomIn getting stuck when on facing pages (authored by aacid).
Fix ZoomIn getting stuck when on facing pages
May 25 2020, 10:48 PM
aacid committed R223:f39c766f78e1: Fix ZoomIn getting stuck when on facing pages (authored by aacid).
Fix ZoomIn getting stuck when on facing pages
May 25 2020, 10:25 PM
aacid committed R256:237ae44d03e5: Remove Qwt for Atelier (authored by rizzitello).
Remove Qwt for Atelier
May 25 2020, 6:00 PM
aacid committed R40:140337a6b291: Make it proper xml (authored by aacid).
Make it proper xml
May 25 2020, 6:35 AM

May 24 2020

aacid added a comment to T11539: Port Okular away from KHTML.

Potential solution, just drop CHM support https://tsdgeos.blogspot.com/2020/05/chmk-simple-chm-viewer.html

May 24 2020, 10:35 PM · Okular, KF6
aacid committed R223:0ada1973255e: Remove the "Page Sizes" action from the menu (authored by aacid).
Remove the "Page Sizes" action from the menu
May 24 2020, 5:35 PM
aacid committed R223:947d29f02963: Remove the "Page Sizes" action from the menu (authored by aacid).
Remove the "Page Sizes" action from the menu
May 24 2020, 4:57 PM
aacid added a comment to D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later).

Personally I'm happy enough with this, i guess wait a few days and if noone disagrees, land it

May 24 2020, 4:38 PM · Frameworks

May 23 2020

aacid committed R223:186e6911882b: Merge remote-tracking branch 'origin/release/20.04' (authored by aacid).
Merge remote-tracking branch 'origin/release/20.04'
May 23 2020, 8:03 PM
aacid committed R223:a0d6a377cb0c: CI: Remove python-yaml (authored by aacid).
CI: Remove python-yaml
May 23 2020, 6:08 PM
aacid added a comment to D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later).

Do you think we should mention something like

May 23 2020, 2:08 PM · Frameworks
aacid committed R278:e7ecfe56dc8a: Fix doc: Use pid() when documenting the pid() method (authored by aacid).
Fix doc: Use pid() when documenting the pid() method
May 23 2020, 10:53 AM
aacid added a comment to D22488: invoke QIcon::setFallbackThemeName a bit later.

UPD: seems like it doesn't. I've added couple qDebug lines, to QIcon::fromTheme() method and near QIcon::setFallbackThemeName() with your patch, and then ran okular and dolphin.
By the time setFallbackThemeName() is called, almost all icons are already loaded :(

May 23 2020, 10:22 AM · Frameworks
aacid added a comment to D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later).

Thanks for looking into it! :)

I don't think moving this code from KIconThemes to kmainwindow makes sense, what about all the apps that use KIconThemes but no KMainWindow?

I'm just not aware of any. I've looked at some of the most used (by me :]), noted that all of them use KMainWindow and thought it might be a good option.

May 23 2020, 10:19 AM · Frameworks
aacid committed R223:8d2fe2231dba: Merge remote-tracking branch 'origin/release/20.04' (authored by aacid).
Merge remote-tracking branch 'origin/release/20.04'
May 23 2020, 10:12 AM
aacid committed R223:793f1692db24: Fix filtering items in the contents treeview (authored by ahmadsamir).
Fix filtering items in the contents treeview
May 23 2020, 10:11 AM

May 22 2020

aacid added a comment to D22488: invoke QIcon::setFallbackThemeName a bit later.

Now i understand this is causing relatively several issues, sorry for dropping the ball, so we should probably fix for users before Qt 5.15.1

May 22 2020, 11:49 PM · Frameworks
aacid added a comment to D22488: invoke QIcon::setFallbackThemeName a bit later.

https://codereview.qt-project.org/c/qt/qtbase/+/301588

May 22 2020, 11:41 PM · Frameworks
aacid added a comment to D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later).

Not sure if you're subscribed to https://phabricator.kde.org/D22488 see my last comment there i think it's the way to go

May 22 2020, 11:19 PM · Frameworks
aacid added a comment to D22488: invoke QIcon::setFallbackThemeName a bit later.

Wouldn't it make more sense to fix in Qt?

May 22 2020, 11:19 PM · Frameworks
aacid added a comment to D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later).

I don't think moving this code from KIconThemes to kmainwindow makes sense, what about all the apps that use KIconThemes but no KMainWindow?

May 22 2020, 11:17 PM · Frameworks

May 19 2020

aacid committed R223:bb8de23468c8: CHM: Fix memory leak every time we open a file (authored by aacid).
CHM: Fix memory leak every time we open a file
May 19 2020, 10:13 PM

May 17 2020

aacid committed R223:13070218ebd3: Test whether documents that request fullscreen are handled properly (authored by sander).
Test whether documents that request fullscreen are handled properly
May 17 2020, 12:28 AM
aacid committed R223:08a76adda1b2: Do not show dialog when reloading file that requests fullscreen (authored by ictwod).
Do not show dialog when reloading file that requests fullscreen
May 17 2020, 12:28 AM

May 16 2020

aacid committed R223:4954395d0844: PDF: Only enable the signatures without page feature with poppler 0.89 (authored by aacid).
PDF: Only enable the signatures without page feature with poppler 0.89
May 16 2020, 10:16 PM
aacid committed R106:38f34d8a754f: Merge remote-tracking branch 'origin/Plasma/5.19' (authored by aacid).
Merge remote-tracking branch 'origin/Plasma/5.19'
May 16 2020, 9:10 PM
aacid committed R106:eb5e5e0538a6: Fix Messages.sh v2 (authored by aacid).
Fix Messages.sh v2
May 16 2020, 9:10 PM
aacid committed R106:f8b3c9fee723: Merge remote-tracking branch 'origin/Plasma/5.19' (authored by aacid).
Merge remote-tracking branch 'origin/Plasma/5.19'
May 16 2020, 9:05 PM
aacid committed R106:5861863dd9cf: Fix Messages.sh (authored by aacid).
Fix Messages.sh
May 16 2020, 9:05 PM
aacid committed R883:1569658: kwyaland_server is not in LTS as it wasn't part of 5.18.
kwyaland_server is not in LTS as it wasn't part of 5.18
May 16 2020, 12:35 PM
aacid committed R883:1569652: Forgot to re-add some packages now that we're tracking 5.18.
Forgot to re-add some packages now that we're tracking 5.18
May 16 2020, 10:15 AM
aacid committed R883:1569651: not in this version.
not in this version
May 16 2020, 10:01 AM

May 13 2020

aacid committed R223:4b1d85f81bf0: Show signatures that don't belong to any page in the signature panel (authored by aacid).
Show signatures that don't belong to any page in the signature panel
May 13 2020, 10:07 PM
aacid committed R223:b1c02b7e79c8: Markdown: Support internal links (authored by aacid).
Markdown: Support internal links
May 13 2020, 8:11 PM

May 12 2020

aacid committed R883:1569147: Remove gone file.
Remove gone file
May 12 2020, 5:35 PM