- User Since
- Apr 19 2015, 12:29 AM (157 w, 5 d)
Wed, Apr 25
@dfaure David, what is correct, should the part or the shell provide the print action?
Any reason you guys decided to not involve email@example.com ?
Tue, Apr 24
When double clicking an already open annotation, we bring it to front, but it doesn't get keyboard focus (the text cursos doesn't blink), which is a different behaviour from when the annocation is closed.
Mon, Apr 23
Are you sure you need s_doNotDeleteLinks ? I mean the links where deleting in resolveMediaLinks doesn't look like they can be nextActions, since it's the Opening/Closing/Activation actions we're resolving on
void PDFGenerator::resolveMediaLinkReferences( Okular::Page *page )
I'll land it
Do you have a game number we can use to compare how this is better than the existing code?
Ok, i guess, after all you're the maintainer now so i shouldn't be blocking your changes ;)
Sun, Apr 22
Sat, Apr 21
Fri, Apr 20
threre's not so many unneded stuff in there to be honest, maybe kross, kate and the emoticonthemes, but doesn't seem terrible. One would improve that by not depending on the whole kf5umbrella probably?
"Fix Page and Author tree elements are collapsed at every change of page when "Show revisions for current page only" is selected" is probably the same root cause as " Do not collapse tree elements when adding a new annotation". The proxymodels are not very well coded, basically rebuildIndexes does resetModel all the time, which is very bad.
For symmetry i will add the disconnect line in the setSourceModel, i'm not even sure we even use that if codepath but it's nice to be symmetric
yeah i think that's easier to understand
Thu, Apr 19
All the other elements of that list have an entry like
Wed, Apr 18
I'm a bit unhappy about the icon duplication, but that's life i guess :/
Tue, Apr 17
Sorry for the late answer.
Mon, Apr 16
Looks like it works, i'll commit in a minute (with a small improvement from my side).
I'll push it, i've fixed the removal of the #if 0 in scripter.cpp
I honestly don't see the need to install stuff in a non standard folder.
I'm not convinced at all parts are not in that folder.
This doesn't seem to work
HAVE_KWALLET is never defined
Fri, Apr 13
This is not ok.
This is how it looks now
Thu, Apr 12
Hmmm, not happy with things that need to be updated manually for each release :/
is appendix something people would understand? because for me is "the things that kills you if you're unlucky", "the end chapter of a book".
As discussed on IRC with Kai it seems more a bug in Ark since Konqueror seems to have it correctly work
Wed, Apr 11
Is this going to fail on my translated nm output?
Tue, Apr 10
Doesn't this mean that when you open okular you end up with two print actions?
Mon, Apr 9
Update commit author to kdab.com hat
I was thinking about that yesterday when i saw the script Riddell has that creates pages, i guess it would be possible, there's two issues i can think of that make it non-trivial (i think):
- We somehow need to update pages to cross link to all the other languages pages (if we want to keep the header like language selection we have in the announcements now, i.e. the "Also Available in" https://www.kde.org/announcements/announce-applications-18.04-rc.php)
- We need a way to segment whole pages into sensible .pot translation units. You don't want the whole page to be a single .pot entry because it would mean exposing html stuff to translators, that is easy to make mistakes with, and also because if you change one word you want to "dirty" the smallest possible unit (ideally sentence, at realistically paragraph) for retranslation not the whole page.
Sun, Apr 8
Personally i don't really have big requirements, since i do all the releases by just copy&pasting the old releases manually. I guess i could do the same thing on the webpage.
What the translators would like is something that doesn't make them change their workflow.
Sat, Apr 7
Not really an experct in phabricator use myself, so no idea :D