aacid (Albert Astals Cid)
Engineering

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 19 2015, 12:29 AM (241 w, 6 d)
Availability
Available

Recent Activity

Today

aacid committed R883:1557831: remove po without pot.
remove po without pot
Sat, Dec 7, 10:09 AM
aacid accepted D25796: Replace Q_DECL_OVERRIDE with override.

I have not looked at the whole diff, but if you exactly did replace Q_DECL_OVERRIDE with override is fine

Sat, Dec 7, 10:07 AM
aacid added a comment to D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader.

How would i load a "KPart that can open PDF files" then?

Sat, Dec 7, 10:06 AM · Frameworks

Yesterday

aacid committed R322:851a1bfbfd6d: Merge remote-tracking branch 'origin/release/19.12' (authored by aacid).
Merge remote-tracking branch 'origin/release/19.12'
Fri, Dec 6, 10:11 AM
aacid committed R322:7571c2906b2a: Russia districts: Fix Kaliningrad not being shown as part of Northwestern (authored by aacid).
Russia districts: Fix Kaliningrad not being shown as part of Northwestern
Fri, Dec 6, 10:11 AM

Thu, Dec 5

aacid committed R917:35045caf63ea: Add CNOSSOS / Adriaan de Groot (authored by aacid).
Add CNOSSOS / Adriaan de Groot
Thu, Dec 5, 11:36 PM
aacid added a comment to D25774: Disable QML pre-compilation.

So can you please close this?

Thu, Dec 5, 11:10 PM · KDE Edu
aacid added a comment to D25720: Fix shortcut conflict between Cut and Delete File.

Trying to assign anything to Shift+Delete shows the "conflicting shortcuts" error dialog.

Thu, Dec 5, 11:00 PM · Frameworks
aacid closed D21091: Try a standardised versioning scheme using KDE Apps version.

I fixed this a while ago in bovo, this patch is now obsolete

Thu, Dec 5, 10:57 PM
aacid added a comment to D25755: Replace iterators with range-based for.

is something you can use if you feel bored, i made it mandatory in poppler

Thu, Dec 5, 10:54 PM · Frameworks
aacid committed R223:f7f2b3105fbc: Increase version here too (authored by aacid).
Increase version here too
Thu, Dec 5, 10:51 PM
aacid committed R223:dcdcefc12df4: Increase version (authored by aacid).
Increase version
Thu, Dec 5, 10:47 PM
aacid added a comment to T11933: Debrand KDE Applications as Release Service.

No, because that forces you to use all the version, so you can't do stuff like okular or khelpcenter do

Thu, Dec 5, 7:55 PM · KDE Promo, KDE Applications, Goal: All About the Apps
aacid added a comment to D25769: Rename KDE Applications to the release service.

don't do reviews for this, you will die, just make sure the scripts are up to date so they update the proper variables

Thu, Dec 5, 7:55 PM
aacid added a comment to T12322: Add additional filters to planet.kde.org.

ideas called idiosyncrasies, which personally I think goes a bit against the code of conduct.

Thu, Dec 5, 7:45 PM · Websites
aacid added inline comments to D25755: Replace iterators with range-based for.
Thu, Dec 5, 1:42 PM · Frameworks
aacid added a comment to T12322: Add additional filters to planet.kde.org.

-1 the filter can't be tailored to your idiosyncrasies, if you don't like the title of a post, don't read it.

Thu, Dec 5, 1:40 PM · Websites

Wed, Dec 4

aacid added a comment to D25684: [core/*] replace foreach, deprecated, with range-for.

Please rebase your patch on current master, since it will fail to merge properly, i prefer you do the work and not me ^_^

Wed, Dec 4, 10:30 PM · Okular
aacid committed R917:b92c9f2c7dcb: Add Rohan Garg (authored by aacid).
Add Rohan Garg
Wed, Dec 4, 10:25 PM
aacid committed R917:4ef64bba043d: Prepare consultants page to support no logo and email as url (authored by aacid).
Prepare consultants page to support no logo and email as url
Wed, Dec 4, 10:25 PM
aacid added a comment to D25599: Fix plugin-metadata translations on windows.
In D25599#572013, @sars wrote:

I would agree that a UNIX/POSIX env var is not the most logical thing to use on Windows, but how do we ensure that we are in sync with ki18n? The usage of QLocale in ki18n looks like it is just adding extra languages to a list of languages, not actually using QLocale to determine what catalog to load. At least LANGUAGE overrides any QLocale settings. Should ki18n not be moved to using QLocale and setDefault()?

Do you BTW have a hint at what the "correct" place is to use QLocale::setDefault()?

Wed, Dec 4, 9:37 PM · Windows, Frameworks
aacid added a comment to D25720: Fix shortcut conflict between Cut and Delete File.

Apps that need both should be aware of it and remove the secondary Cut shortcut.

Wed, Dec 4, 9:13 PM · Frameworks
aacid added a comment to D25720: Fix shortcut conflict between Cut and Delete File.

Shift + Delete for cut is the old timer Unix cut shortcut, you're going to piss lots of people off if you remove that shortcut from every single application just because it causes a conflict in applications that do file management

Wed, Dec 4, 8:24 AM · Frameworks

Tue, Dec 3

aacid committed R223:b588989dba6a: Make AnnotationPrivate::distanceSqr const (authored by aacid).
Make AnnotationPrivate::distanceSqr const
Tue, Dec 3, 11:54 PM
aacid added a comment to D25684: [core/*] replace foreach, deprecated, with range-for.

Thanks for the patch!

Tue, Dec 3, 11:22 PM · Okular
aacid added a comment to D25599: Fix plugin-metadata translations on windows.

Sure about what?

I don't know what that link is supposed to mean :)

I don't see a call to QLocale::setDefault so I don't see how QLocale() should yield a different result.

Tue, Dec 3, 10:25 PM · Windows, Frameworks
aacid added a comment to D25708: Don't use nullptr to flags.

To be clear, that works just fine, it's just weird and deprecated on 5.15, but it's not "incorrect" code

Tue, Dec 3, 11:14 AM · Frameworks

Mon, Dec 2

aacid added inline comments to D25642: Add minimal number of moves statistics.
Mon, Dec 2, 11:21 PM
aacid added a comment to D25648: Molecular editor: Enable loading molecules in other formats than cml.

@yurchor will you do the honors and commit this to master or want me to?

Mon, Dec 2, 11:12 PM · Kalzium, KDE Edu
aacid added a comment to D25648: Molecular editor: Enable loading molecules in other formats than cml.

Sorry, I did not know that. Hope it is fixed now.

Mon, Dec 2, 11:10 PM · Kalzium, KDE Edu
aacid committed R436:9e61eafb1134: Merge remote-tracking branch 'origin/release/19.12' (authored by aacid).
Merge remote-tracking branch 'origin/release/19.12'
Mon, Dec 2, 11:07 PM
aacid closed D25640: RDP: Warn if trying to share a non existing folder.
Mon, Dec 2, 11:06 PM
aacid committed R436:e5b42510a39c: RDP: Warn if trying to share a non existing folder (authored by aacid).
RDP: Warn if trying to share a non existing folder
Mon, Dec 2, 11:06 PM
aacid added a comment to D25640: RDP: Warn if trying to share a non existing folder.

I'm going to land this *now* since i want the translatable message to be available for translators so they have a chance to translate it before thursday.

Mon, Dec 2, 11:06 PM
aacid added a comment to D25599: Fix plugin-metadata translations on windows.
Mon, Dec 2, 10:08 PM · Windows, Frameworks
aacid committed R363:c93f2f16c30d: Fix crash when cups returns jobs with duplicate id (authored by aacid).
Fix crash when cups returns jobs with duplicate id
Mon, Dec 2, 10:06 PM
aacid committed R363:24845b55618b: Merge remote-tracking branch 'origin/release/19.12' (authored by aacid).
Merge remote-tracking branch 'origin/release/19.12'
Mon, Dec 2, 10:06 PM
aacid closed D25623: Fix crash when cups returns jobs with duplicate id.
Mon, Dec 2, 10:06 PM

Sun, Dec 1

aacid added a comment to D25623: Fix crash when cups returns jobs with duplicate id.

Well I think your approach is probably the best to this, I'd only change the sanitize loop to use iterators and erase as afair they are a little faster.

Sun, Dec 1, 10:25 PM
aacid added inline comments to D25642: Add minimal number of moves statistics.
Sun, Dec 1, 9:53 PM
aacid added a comment to D25599: Fix plugin-metadata translations on windows.
In D25599#570372, @sars wrote:

ki18n does not seem to use QLocale to get the language for translation

Sun, Dec 1, 9:40 PM · Windows, Frameworks
aacid added inline comments to D25648: Molecular editor: Enable loading molecules in other formats than cml.
Sun, Dec 1, 7:03 PM · Kalzium, KDE Edu
aacid added a comment to D25599: Fix plugin-metadata translations on windows.

To be honest i don't remember why we don't use setDefault.

Sun, Dec 1, 7:01 PM · Windows, Frameworks
aacid accepted D25658: Remove superflous private.
Sun, Dec 1, 4:56 PM · Frameworks
aacid added a comment to D25599: Fix plugin-metadata translations on windows.

Right, but we set it in initializeLanguages.

Sun, Dec 1, 4:37 PM · Windows, Frameworks

Sat, Nov 30

aacid updated the diff for D25640: RDP: Warn if trying to share a non existing folder.

update strings according to Pino's comments

Sat, Nov 30, 11:37 PM
aacid updated subscribers of D25641: fix freetype git url.

I can't commit myself, not powerful enough.

Sat, Nov 30, 11:33 PM
aacid requested review of D25641: fix freetype git url.
Sat, Nov 30, 11:32 PM
aacid updated subscribers of D25640: RDP: Warn if trying to share a non existing folder.

This is a i18n break but since if you have this problem you won't be able to figure out what the problem is unless you debug the source code i'd like for this to go in to 19.12

Sat, Nov 30, 11:12 PM
aacid updated the diff for D25640: RDP: Warn if trying to share a non existing folder.

fix commit log

Sat, Nov 30, 11:10 PM
aacid requested review of D25640: RDP: Warn if trying to share a non existing folder.
Sat, Nov 30, 11:09 PM
aacid added a comment to D25623: Fix crash when cups returns jobs with duplicate id.

So i got access to another machine with broken situation and i confirm, it has duplicate ids too and my patch fixes the crash

Sat, Nov 30, 10:45 PM
aacid added a comment to D25623: Fix crash when cups returns jobs with duplicate id.

I can't play with it anymore because i fixed my jobs queue already but.

Sat, Nov 30, 10:53 AM
aacid added a comment to D10009: Improvements for Gettext entries wordwrapping.

We never got a proper explanation of what this does or how it works.

Sat, Nov 30, 10:05 AM · Localization
aacid committed R883:1557382: pot files don't belong to "translated" folders.
pot files don't belong to "translated" folders
Sat, Nov 30, 10:03 AM
aacid committed R883:1557381: Remove po without pot.
Remove po without pot
Sat, Nov 30, 10:02 AM
aacid committed R883:1557380: Remove pot without po.
Remove pot without po
Sat, Nov 30, 10:01 AM
aacid committed R883:1557379: gone.
gone
Sat, Nov 30, 10:00 AM
aacid added a comment to D25530: Sonnet: Add locales that are missing in QLocale.

I honestly would prefer if you abandon this, but maybe let it open for a few days in case someone else disagrees.

Sat, Nov 30, 9:57 AM · Frameworks
aacid committed R368:b10328480ac8: Revert "GIT_SILENT: ignore file" (authored by aacid).
Revert "GIT_SILENT: ignore file"
Sat, Nov 30, 9:51 AM
aacid added a reverting change for R368:f86c6c4baada: GIT_SILENT: ignore file: R368:b10328480ac8: Revert "GIT_SILENT: ignore file".
Sat, Nov 30, 9:51 AM
aacid committed R223:c56a924ab434: Add TeXiFy IDEA support (authored by Abby Berkers <abbyberkers@gmail.com>).
Add TeXiFy IDEA support
Sat, Nov 30, 1:20 AM
aacid updated subscribers of D25623: Fix crash when cups returns jobs with duplicate id.
Sat, Nov 30, 12:21 AM
aacid added a comment to D25623: Fix crash when cups returns jobs with duplicate id.

Now it should be good, problem is i ended up doing "cancel -a" to clear my list of pending jobs so now my queue is empty so can't be 100% sure it fixes the crash.

Sat, Nov 30, 12:20 AM
aacid updated the diff for D25623: Fix crash when cups returns jobs with duplicate id.

update code

Sat, Nov 30, 12:18 AM
aacid added a comment to D25623: Fix crash when cups returns jobs with duplicate id.

Hmmm, i think this may not be correct, need to figure out how rows are supposed to be removed

Sat, Nov 30, 12:00 AM

Fri, Nov 29

aacid requested review of D25623: Fix crash when cups returns jobs with duplicate id.
Fri, Nov 29, 11:56 PM

Thu, Nov 28

aacid accepted D25553: Port away from deprecated Bar|Desktop|SmallIcon methods.
Thu, Nov 28, 10:01 PM · Okular
aacid added a comment to D25530: Sonnet: Add locales that are missing in QLocale.

Can you give examples of places where an iso_code (cv_RU) could pop up?

Thu, Nov 28, 9:30 PM · Frameworks
aacid committed R917:4b78a4b8cefd: PIM sprint was in Toulouse (authored by aacid).
PIM sprint was in Toulouse
Thu, Nov 28, 6:28 PM
aacid added a comment to D25588: Fix color-options layout & KSaneOptCombo::setValue().

Can we get a better description?

Thu, Nov 28, 6:20 PM

Wed, Nov 27

aacid added a comment to D25348: Download kdelibs and kde-dev-scripts containing required scripts.

i can see this is a potential bugfix, but honestly, i'd just leave the kde4 branches die (unless this is blocking you heavily in some way)

Wed, Nov 27, 10:50 PM · Localization
aacid added a comment to T11933: Debrand KDE Applications as Release Service.

and removed the release team wiki page

Wed, Nov 27, 9:32 PM · KDE Promo, KDE Applications, Goal: All About the Apps
aacid committed R917:a9fbfe560689: More optipng (authored by aacid).
More optipng
Wed, Nov 27, 9:30 PM
aacid committed R917:daac2ff6436f: Link issue 35 (authored by aacid).
Link issue 35
Wed, Nov 27, 9:30 PM
aacid committed R917:289d57005c58: Run optipng (authored by aacid).
Run optipng
Wed, Nov 27, 9:30 PM
aacid committed R917:8ed4c070592b: Let's remove G+ (authored by aacid).
Let's remove G+
Wed, Nov 27, 9:30 PM
aacid accepted D25078: Replace deprecated KConfigDialogManager::changedMap with property in the class definition.
Wed, Nov 27, 9:27 PM · KDE Edu
aacid accepted D25557: Remove KCompletion dependency.

fair enough :)

Wed, Nov 27, 9:04 PM · KDE Edu
aacid added a comment to D25530: Sonnet: Add locales that are missing in QLocale.

the end user doesn't give a crap whether it was a problem in QLocale, or whether it needed to be done in many places in KDE code and that nobody did it. The end user opens the menu, sees 'American English (United States)' and below that 'cv_RU' and he is just going to think the developers didn't fix it.

Wed, Nov 27, 6:35 PM · Frameworks

Tue, Nov 26

aacid added inline comments to D25078: Replace deprecated KConfigDialogManager::changedMap with property in the class definition.
Tue, Nov 26, 11:33 PM · KDE Edu
aacid closed T12028: Create 19.12 Beta releases, a subtask of T12272: Create 19.12 releases, as Resolved.
Tue, Nov 26, 11:24 PM · Event: Release, KDE Applications
aacid closed T12028: Create 19.12 Beta releases as Resolved.
Tue, Nov 26, 11:24 PM
aacid added a comment to T12028: Create 19.12 Beta releases.

I'm going to mark this as done, I didn't get to do most of the web stuff because of reasons[*], but given that RC is in a few days I'd say we don't need those?

Tue, Nov 26, 11:20 PM
aacid updated subscribers of T12271: Create 19.12 RC releases.
Tue, Nov 26, 10:53 PM
aacid committed R255:a454b4f0ead7: GIT_SILENT Upgrade KDE Applications version to 19.11.90. (authored by aacid).
GIT_SILENT Upgrade KDE Applications version to 19.11.90.
Tue, Nov 26, 10:40 PM
aacid committed R824:4e8981e97d53: GIT_SILENT Upgrade KDE Applications version to 19.11.90. (authored by aacid).
GIT_SILENT Upgrade KDE Applications version to 19.11.90.
Tue, Nov 26, 10:36 PM
aacid committed R438:1bd14f82a167: GIT_SILENT Upgrade KDE Applications version to 19.11.90. (authored by aacid).
GIT_SILENT Upgrade KDE Applications version to 19.11.90.
Tue, Nov 26, 10:36 PM
aacid committed R156:6a26d8d30b85: GIT_SILENT Upgrade KDE Applications version to 19.11.90. (authored by aacid).
GIT_SILENT Upgrade KDE Applications version to 19.11.90.
Tue, Nov 26, 10:36 PM
aacid committed R155:6d024af4bd05: GIT_SILENT Upgrade KDE Applications version to 19.11.90. (authored by aacid).
GIT_SILENT Upgrade KDE Applications version to 19.11.90.
Tue, Nov 26, 10:36 PM
aacid committed R154:c85113f5c56a: GIT_SILENT Upgrade KDE Applications version to 19.11.90. (authored by aacid).
GIT_SILENT Upgrade KDE Applications version to 19.11.90.
Tue, Nov 26, 10:36 PM
aacid committed R152:af12f58e54c3: GIT_SILENT Upgrade KDE Applications version to 19.11.90. (authored by aacid).
GIT_SILENT Upgrade KDE Applications version to 19.11.90.
Tue, Nov 26, 10:36 PM
aacid committed R150:3fec69fceeb9: GIT_SILENT Upgrade KDE Applications version to 19.11.90. (authored by aacid).
GIT_SILENT Upgrade KDE Applications version to 19.11.90.
Tue, Nov 26, 10:36 PM
aacid committed R149:5628ca777585: GIT_SILENT Upgrade KDE Applications version to 19.11.90. (authored by aacid).
GIT_SILENT Upgrade KDE Applications version to 19.11.90.
Tue, Nov 26, 10:36 PM
aacid committed R148:949dcd99b6d8: GIT_SILENT Upgrade KDE Applications version to 19.11.90. (authored by aacid).
GIT_SILENT Upgrade KDE Applications version to 19.11.90.
Tue, Nov 26, 10:36 PM
aacid committed R147:52f786e9bf33: GIT_SILENT Upgrade KDE Applications version to 19.11.90. (authored by aacid).
GIT_SILENT Upgrade KDE Applications version to 19.11.90.
Tue, Nov 26, 10:35 PM
aacid committed R146:20f67f4ac4cc: GIT_SILENT Upgrade KDE Applications version to 19.11.90. (authored by aacid).
GIT_SILENT Upgrade KDE Applications version to 19.11.90.
Tue, Nov 26, 10:35 PM
aacid committed R145:48d74cb25a7f: GIT_SILENT Upgrade KDE Applications version to 19.11.90. (authored by aacid).
GIT_SILENT Upgrade KDE Applications version to 19.11.90.
Tue, Nov 26, 10:35 PM
aacid committed R142:ab3e48c53b86: GIT_SILENT Upgrade KDE Applications version to 19.11.90. (authored by aacid).
GIT_SILENT Upgrade KDE Applications version to 19.11.90.
Tue, Nov 26, 10:35 PM
aacid committed R143:e32889514577: GIT_SILENT Upgrade KDE Applications version to 19.11.90. (authored by aacid).
GIT_SILENT Upgrade KDE Applications version to 19.11.90.
Tue, Nov 26, 10:35 PM