aacid (Albert Astals Cid)
Engineering

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 19 2015, 12:29 AM (173 w, 3 d)
Availability
Available

Recent Activity

Today

aacid added inline comments to D14854: Switch to the new connect() API.
Wed, Aug 15, 9:39 AM · Localization
aacid committed R236:e3368be660e3: Fix two bugs in KMessageWidget (authored by aacid).
Fix two bugs in KMessageWidget
Wed, Aug 15, 9:19 AM
aacid closed D8964: Fix two bugs in KMessageWidget.
Wed, Aug 15, 9:19 AM · Frameworks

Yesterday

aacid requested review of D14836: Kicker: Reset re-used menu width to default one.
Tue, Aug 14, 2:11 PM · Plasma
aacid committed R883:1522579: Change copyright holder.
Change copyright holder
Tue, Aug 14, 1:18 PM
aacid added a comment to D14779: Fix 'kformattest fails with installed kcoreaddons language package'.

You have remembered that in this case the loader created by ecm_create_qm_loader(kcoreaddons_QM_LOADER kcoreaddons5_qt) must be adjusted to find this - not installed - fake translation by default ?

Tue, Aug 14, 12:20 PM · Frameworks
aacid added a comment to D14779: Fix 'kformattest fails with installed kcoreaddons language package'.

Personally i would include (and use) a fake translation as part of the tests and then it would just evaluate to the actual result, i.e.

QCOMPARE(format.formatSpelloutDuration(3610000), QStringLiteral("1 hour(s)"));

would end up being

QCOMPARE(format.formatSpelloutDuration(3610000), QStringLiteral("1 hour"));

because we're using the "fake" translation.

Tue, Aug 14, 11:37 AM · Frameworks
aacid added a comment to D14820: Select current format on the configure backend dialog.

Looking good! Concerning the preparatory commit 9ba8dd2cd7838c626af79a4edcd8b8437205cc02 , which copies the list of loaded generators from a QHash to a QMap: Why not use a QMap for them right away? Certainly the number of generators is low enough such that the efficiency differences between a QHash and a QMap become negligible?

Tue, Aug 14, 11:33 AM · Okular
aacid committed R883:1522575: use the proper package name instead of PACKAGE in the xgettext output.
use the proper package name instead of PACKAGE in the xgettext output
Tue, Aug 14, 10:15 AM
aacid added a comment to D14778: Disable loading of translations when using 'C' locale.

Honestly i think that test in kformattest is wrong and that it should contain it's own small minitranslation so that stuff works fine and then it should be

Tue, Aug 14, 9:24 AM · Build System, Frameworks
aacid added a comment to D14625: Add pause/resume button.

Looks good, to me, since it seems to me you're serious in being a KDE Developer, i think you should get a Developer account

Tue, Aug 14, 9:07 AM
aacid added a comment to D14809: Make 'configure generators' dialog open with current generator selected.

I made https://phabricator.kde.org/D14820 (you need latest branch since i did a change to make the sorting at least stable in the config dialog) which doesn't need changing the API, which i think it's better since it won't break plugins that may exist outside the okular repository.

Tue, Aug 14, 8:58 AM · Okular
aacid requested review of D14820: Select current format on the configure backend dialog.
Tue, Aug 14, 8:57 AM · Okular
aacid committed R223:9ba8dd2cd783: Make sure sorting in the configure backends is always the same (authored by aacid).
Make sure sorting in the configure backends is always the same
Tue, Aug 14, 8:38 AM
aacid committed R223:59b87705454b: Remove unused file (authored by sander).
Remove unused file
Tue, Aug 14, 8:21 AM
aacid accepted D14573: Add a shortcut to delete TM entries (Ctrl+Alt+Number).
Tue, Aug 14, 8:16 AM · Localization

Mon, Aug 13

aacid added a comment to D14573: Add a shortcut to delete TM entries (Ctrl+Alt+Number).

Maybe Ctrl+Shift instead of Ctrl+Alt?

Mon, Aug 13, 4:25 PM · Localization
aacid accepted D14683: Add a feature to delete all translated entries from the file in one go.

This seems very corner casey and i'm afraid we may be adding too much menu entries, but ok.

Mon, Aug 13, 4:23 PM · Localization
aacid added a comment to D14310: Fixes url whitespaces in epub documents.

Yes he can.

Mon, Aug 13, 3:56 PM · Okular
aacid added inline comments to D14752: Fix links being "lost" on save.
Mon, Aug 13, 9:51 AM · Okular
aacid updated the diff for D14752: Fix links being "lost" on save.

add small comment

Mon, Aug 13, 9:51 AM · Okular
aacid accepted D14781: Add the little close button (X) to close tabs directly.
Mon, Aug 13, 9:27 AM · Localization
aacid added a comment to D14778: Disable loading of translations when using 'C' locale.

Doesn't setting the locale to en solve the same problem without needing to change ECM?

Mon, Aug 13, 9:19 AM · Build System, Frameworks
aacid committed R223:918914dc99d7: Merge remote-tracking branch 'origin/Applications/18.08' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/18.08'
Mon, Aug 13, 9:14 AM
aacid committed R223:5e622484c874: Fix problem of saving pdf switches from thumbnail view in sidebar to contents… (authored by ahmadosama).
Fix problem of saving pdf switches from thumbnail view in sidebar to contents…
Mon, Aug 13, 9:14 AM
aacid closed D14740: Fix problem of saving pdf switches from thumbnail view in sidebar to contents view.
Mon, Aug 13, 9:14 AM · Okular

Sat, Aug 11

aacid requested review of D14752: Fix links being "lost" on save.
Sat, Aug 11, 9:18 PM · Okular
aacid added a comment to D14740: Fix problem of saving pdf switches from thumbnail view in sidebar to contents view.

Do you think you could work on an autotest for this?

Sat, Aug 11, 8:39 PM · Okular
aacid added a comment to D14625: Add pause/resume button.

i'm not very happy with m_remainingTeaTime as a variable name, because to me it doesn't say "this is only for when it's paused", maybe m_pausedRemainingTeaTime?

Sat, Aug 11, 8:38 PM
aacid accepted D14310: Fixes url whitespaces in epub documents.
Sat, Aug 11, 8:21 PM · Okular
aacid accepted D14721: Take into account summer time for the date offset in PO-Revision-Date.

looks good, if you can please add const to all those variables.

Sat, Aug 11, 7:57 PM · Localization
aacid accepted D14699: Save as saves the file to a new path even if there was no changes.
Sat, Aug 11, 4:24 PM · Localization
aacid added a comment to D14699: Save as saves the file to a new path even if there was no changes.

Looks good to me, if you want, maybe it makes sense to put

Sat, Aug 11, 4:24 PM · Localization
aacid added a comment to D14723: Add option to disable KWallet entirely in the new wallet dialog.

Isn't this actually bad for the privacy goal? AFAIK some apps will just write the password in cleartext in a config file when kwallet is not present.

Sat, Aug 11, 4:19 PM · Frameworks

Thu, Aug 9

aacid added a comment to D14703: Add a README.md with some info for Github and Phabricator.

What to link https://www.kde.org/applications/development/lokalize/ ?

Thu, Aug 9, 9:16 PM · Localization
aacid added inline comments to D14699: Save as saves the file to a new path even if there was no changes.
Thu, Aug 9, 6:48 PM · Localization

Wed, Aug 8

aacid committed R223:78e113f508e5: Merge remote-tracking branch 'origin/Applications/18.08' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/18.08'
Wed, Aug 8, 10:29 PM
aacid committed R223:4f06f742f95d: Fix properties dialog path not being correct on Save As (authored by aacid).
Fix properties dialog path not being correct on Save As
Wed, Aug 8, 10:29 PM
aacid committed R360:5dd5301b9052: Fix no tea is ready notification after second run (authored by fb).
Fix no tea is ready notification after second run
Wed, Aug 8, 9:20 PM
aacid closed D14602: Fix no tea is ready notification after second run.
Wed, Aug 8, 9:20 PM
aacid accepted D14602: Fix no tea is ready notification after second run.

Looks good :)

Wed, Aug 8, 9:20 PM
aacid added inline comments to D14625: Add pause/resume button.
Wed, Aug 8, 9:17 PM
aacid committed R436:a0b4b3a83cdb: Merge remote-tracking branch 'origin/Applications/18.08' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/18.08'
Wed, Aug 8, 6:05 PM
aacid committed R436:cd7ecfa2be9a: Fix deadlock when user cancels ssh password dialog (authored by aacid).
Fix deadlock when user cancels ssh password dialog
Wed, Aug 8, 6:05 PM
aacid closed D14681: Fix deadlock when user cancels ssh password dialog.
Wed, Aug 8, 6:05 PM

Tue, Aug 7

aacid added a reviewer for D14681: Fix deadlock when user cancels ssh password dialog: dfaure.
Tue, Aug 7, 10:04 PM
aacid requested review of D14681: Fix deadlock when user cancels ssh password dialog.
Tue, Aug 7, 10:03 PM

Mon, Aug 6

aacid committed R223:c85650a16fb8: Merge remote-tracking branch 'origin/Applications/18.08' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/18.08'
Mon, Aug 6, 11:51 PM
aacid committed R223:e0907726d63e: Increase version (authored by aacid).
Increase version
Mon, Aug 6, 11:50 PM

Sun, Aug 5

aacid added a comment to D14631: Adds a new RenameDialog to KIO with more options for batch renaming.

As far as i can see none of these headers get installed so should they all be renamed to _p.h ?

Sun, Aug 5, 6:00 PM · Frameworks
aacid committed R410:49ef224f1c8e: Freecell: Don't allow moving out of foundation (authored by Parker Coates <coates@qps.nl>).
Freecell: Don't allow moving out of foundation
Sun, Aug 5, 4:24 PM
aacid added a reviewer for D10009: Improvements for Gettext entries wordwrapping: sdepiets.

Simon what do you think about this?

Sun, Aug 5, 11:22 AM · Localization

Fri, Aug 3

aacid accepted D14502: Reuse function that already does the same.
Fri, Aug 3, 7:26 AM · Frameworks

Thu, Aug 2

aacid added a comment to D14528: Android: Make sure we're looking for .mo files in the right path.

As I am arguing in the other review, let's install the files in a nicer place? We control were we install them, no?

Thu, Aug 2, 11:04 PM · Frameworks
aacid added a comment to D14529: Android: Make sure Qm translations get loaded.

Ok, second option, we are actually installing these files ourselves, right?

Thu, Aug 2, 11:03 PM · Build System, Frameworks

Wed, Aug 1

aacid added a comment to D14493: fontinst quits after KJob is done.

you still need to merge 5.13 to master because eventually someone will, it's the trouble with cherry-picking.

Wed, Aug 1, 11:36 PM · Plasma
aacid added a comment to D14529: Android: Make sure Qm translations get loaded.

Is there a way we can get /../qt-reserved-files/share/ in a more natural way? fishing up to .. feels always like it'll break

Wed, Aug 1, 11:03 PM · Build System, Frameworks

Tue, Jul 31

aacid added a comment to D14069: Add a feature to remove deleted files entries from TM.

Do i understand it correctly that we only remove the file on

Tue, Jul 31, 9:47 PM
aacid added a comment to D14503: Android: also fall-back to using QLocale.

Aleix means https://phabricator.kde.org/D14508

Tue, Jul 31, 8:57 PM · Frameworks
aacid added a comment to D14524: Fix compiler warning -Wimplicit-fallthrough.

Maybe it makes more sense to replace it with the magic words?

Tue, Jul 31, 8:53 PM · Frameworks, Kate

Mon, Jul 30

aacid committed R249:34a22e5ee5d4: Fix KCatalog::translate when translation is same as original text (authored by aacid).
Fix KCatalog::translate when translation is same as original text
Mon, Jul 30, 11:27 PM
aacid closed D14473: Fix KCatalog::translate when translation is same as original text.
Mon, Jul 30, 11:27 PM · Frameworks

Sun, Jul 29

aacid added a comment to D14177: Fix drag'n'drop behavior within the Target area.

I would feel more safe if you initialized m_cursorSelectionStart and m_cursorSelectionEnd to 0 in the constructor

Sun, Jul 29, 9:36 PM · Localization
aacid accepted D14311: Add a project configuration menu entry for the Word Wrap feature.
Sun, Jul 29, 9:31 PM · Localization
aacid requested review of D14473: Fix KCatalog::translate when translation is same as original text.
Sun, Jul 29, 9:16 PM · Frameworks
aacid committed R883:1521212: Fix translation.
Fix translation
Sun, Jul 29, 5:48 PM
aacid committed R883:1521197: Fix translation bug.
Fix translation bug
Sun, Jul 29, 11:19 AM
aacid committed R883:1521196: Fix translation.
Fix translation
Sun, Jul 29, 11:18 AM

Sat, Jul 28

aacid committed R368:6b92eebfd606: More tests (authored by dklimkin).
More tests
Sat, Jul 28, 9:58 PM
aacid closed D8074: [PATCH 3/3] More tests for Timer.
Sat, Jul 28, 9:58 PM
aacid closed D14279: Quick fix for no end-of-break events.
Sat, Jul 28, 9:57 PM
aacid accepted D8074: [PATCH 3/3] More tests for Timer.
Sat, Jul 28, 9:57 PM
aacid committed R368:28f65ddcddb4: Quick fix for no end-of-break events (authored by dklimkin).
Quick fix for no end-of-break events
Sat, Jul 28, 9:34 PM
aacid accepted D14279: Quick fix for no end-of-break events.
Sat, Jul 28, 9:32 PM
aacid committed R223:345c21167439: Merge remote-tracking branch 'origin/Applications/18.08' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/18.08'
Sat, Jul 28, 9:14 PM
aacid committed R223:57be655c15e2: Improve picture scaling issues in epub generator (authored by gassaf).
Improve picture scaling issues in epub generator
Sat, Jul 28, 9:14 PM
aacid closed D13766: fixed picture scaling issues in epub generator.
Sat, Jul 28, 9:14 PM · Okular
aacid accepted D13766: fixed picture scaling issues in epub generator.

This makes it a bit better so i will commit it, but it is still not as good as it could/should be. See https://i.imgur.com/HDn9QIX.png

Sat, Jul 28, 9:13 PM · Okular
aacid added a comment to D14310: Fixes url whitespaces in epub documents.

Are we sure this won't break something else?

Sat, Jul 28, 8:50 PM · Okular
aacid accepted D13815: cleaned up MemoryManager code.

I'm not going to pretend that i had time to read and understand the code, but if you think it's better and you'll fix any bugs that it may introduce, just go ahead and commit it :)

Sat, Jul 28, 8:46 PM
aacid committed R223:7c87174dde4b: Merge remote-tracking branch 'origin/Applications/18.08' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/18.08'
Sat, Jul 28, 8:41 PM
aacid committed R223:aed8e5ac28a6: Fix crash on shutdown when having edited text forms (authored by aacid).
Fix crash on shutdown when having edited text forms
Sat, Jul 28, 8:41 PM

Thu, Jul 26

aacid accepted D13776: Move remaining salt file operations into unprivileged processes.
Thu, Jul 26, 10:40 PM · Plasma
aacid committed R107:3dc73747c16f: Don't create salt file if user home directory does not exist (authored by aacid).
Don't create salt file if user home directory does not exist
Thu, Jul 26, 10:28 PM
aacid added a comment to D14411: Download and use localization files for KStars Lite.
In D14411#298786, @pino wrote:

This does not look good for different reasons:

  • the KI18n framework is marked as working on Android (and looking at its git history, there were fixes for it); hence, if it still does not work, please fix it instead (so it will work for kstars any any other KI18n-based application)

It does work, i've used it.

Where? Do you have any code online? My Google search did not give any results. I asked Aleix Pol some days ago and he could not reference any KDE app which uses KI18n with gettext-style translations on Android.

Thu, Jul 26, 9:45 PM · KDE Edu
aacid added a comment to D14411: Download and use localization files for KStars Lite.
In D14411#298786, @pino wrote:

This does not look good for different reasons:

  • the KI18n framework is marked as working on Android (and looking at its git history, there were fixes for it); hence, if it still does not work, please fix it instead (so it will work for kstars any any other KI18n-based application)
Thu, Jul 26, 9:09 PM · KDE Edu
aacid accepted D14401: Don't instantiate a QStringRef into a QString only to search in a QStringList.

Does this really make a difference?

Thu, Jul 26, 5:29 PM · Frameworks
aacid accepted D14219: Add a feature to hide translated files on the Project tab.

Should the state of the action be remembered between runs?

I didn't plan that, the quick search project field isn't saved between runs.
Performance wise it would not change anything to launch the program with the filter on.

Thu, Jul 26, 5:21 PM · Localization

Tue, Jul 24

aacid added a comment to D14219: Add a feature to hide translated files on the Project tab.

Should the state of the action be remembered between runs?

Tue, Jul 24, 10:21 PM · Localization
aacid accepted D14321: Allow lokalize to build on Windows with craft.

If it works, sure let's go for it.

Tue, Jul 24, 7:24 PM · Localization

Mon, Jul 23

aacid added inline comments to D14219: Add a feature to hide translated files on the Project tab.
Mon, Jul 23, 6:29 PM · Localization
aacid updated subscribers of T9250: Revive bug triaging days.

I may be available on Sunday.

Mon, Jul 23, 6:27 PM
aacid committed R495:734561710723: test: A more "atomic" way of checking for the signal to happen (authored by aacid).
test: A more "atomic" way of checking for the signal to happen
Mon, Jul 23, 6:09 PM
aacid added inline comments to D14219: Add a feature to hide translated files on the Project tab.
Mon, Jul 23, 1:58 PM · Localization

Sat, Jul 21

aacid added a comment to D14069: Add a feature to remove deleted files entries from TM.

What is a "Deleted file"? A file that did exist and does not exist anymore?

Sat, Jul 21, 10:22 PM
aacid accepted D14151: Allow Ctrl+Wheel to zoom in/out on the target text.

I think this is fine, if we let people zoom on the top area, we should let people zoom on the zoom one, but i agree with Safa this is not the actual fix for bug 375251

Sat, Jul 21, 7:11 PM · Localization
aacid committed R348:4c475a86f0d7: Fix tests (authored by aacid).
Fix tests
Sat, Jul 21, 5:13 PM
aacid committed R348:f9fba60c54f0: Fix compile warnings (authored by aacid).
Fix compile warnings
Sat, Jul 21, 5:10 PM
aacid added inline comments to D14219: Add a feature to hide translated files on the Project tab.
Sat, Jul 21, 4:31 PM · Localization

Fri, Jul 20

aacid accepted D14244: Add libhunspell to the cmake function to build on windows.
Fri, Jul 20, 6:52 PM