aacid (Albert Astals Cid)
Engineering

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 19 2015, 12:29 AM (234 w, 6 d)
Availability
Available

Recent Activity

Thu, Oct 17

aacid accepted D24745: Add Icon to Executable and Restrict GNUCXX compiler options.

-Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -fno-exceptions are added by default by ecm so it's not that even we need to list them here.

Thu, Oct 17, 9:38 PM · Craft, KDE Games
aacid accepted D24696: don't crash on nullptr pdfOptionsPage.
Thu, Oct 17, 5:06 PM · Okular

Tue, Oct 15

aacid committed R883:1553875: ikona -> kdei.
ikona -> kdei
Tue, Oct 15, 9:44 PM

Mon, Oct 14

aacid committed R31:993c96a0ea8f: Micro optimizations (authored by aacid).
Micro optimizations
Mon, Oct 14, 6:56 PM
aacid closed D24614: Micro optimizations.
Mon, Oct 14, 6:56 PM · Plasma

Sun, Oct 13

aacid committed R883:1553744: enable ikona.
enable ikona
Sun, Oct 13, 11:21 PM
aacid committed R326:5ea6bfd431ce: adding multiple decays and updated isotope information H-Na (authored by joergbuchwald).
adding multiple decays and updated isotope information H-Na
Sun, Oct 13, 10:14 PM
aacid closed D19563: adding multiple decays and updated isotope information H-Na.

I've pushed this to git.

Sun, Oct 13, 9:28 PM · KDE Edu
aacid accepted D19563: adding multiple decays and updated isotope information H-Na.
Sun, Oct 13, 9:27 PM · KDE Edu
aacid accepted D24583: Remove Dependence on unistd.h and sys/time.h.

The code is too C++-y to me, but it works :D

Sun, Oct 13, 8:45 PM · Craft, KDE Games
aacid added inline comments to D24583: Remove Dependence on unistd.h and sys/time.h.
Sun, Oct 13, 5:06 PM · Craft, KDE Games
aacid requested review of D24614: Micro optimizations.
Sun, Oct 13, 4:34 PM · Plasma
aacid accepted D24590: Port KSslErrorUiData to QSslError.

Do we have tests for the thing you discovered breaks? Do we need them?

Sun, Oct 13, 3:32 PM · Frameworks
aacid updated subscribers of D24604: Fix compilation with clang.
Sun, Oct 13, 12:33 AM
aacid requested review of D24604: Fix compilation with clang.
Sun, Oct 13, 12:32 AM

Sat, Oct 12

aacid committed R386:c6e2a69b7ba5: Merge remote-tracking branch 'origin/Applications/19.08' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/19.08'
Sat, Oct 12, 11:02 PM
aacid committed R386:b352814a2d58: Restrict GNUGXX compiler options (authored by twighk).
Restrict GNUGXX compiler options
Sat, Oct 12, 11:02 PM
aacid closed D24581: Restrict GNUGXX compiler options.
Sat, Oct 12, 11:02 PM · KDE Games, Craft
aacid added a comment to D24570: Fix kolflib_export.

If we're going to make the kolfprivate library to be static, which kind of makes sense since we don't install the includes anyway

Sat, Oct 12, 11:00 PM · Craft, KDE Games
aacid requested changes to D24572: Remove libpala_export.

This is wrong, these classes are part of a public library, they need the symbols to be exported

Sat, Oct 12, 10:55 PM · KDE Games
aacid committed R409:3ab716faeb41: Merge remote-tracking branch 'origin/Applications/19.08' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/19.08'
Sat, Oct 12, 10:51 PM
aacid committed R409:c0ffb9b3b014: Fix struct Prototype of GameOptions (authored by twighk).
Fix struct Prototype of GameOptions
Sat, Oct 12, 10:51 PM
aacid closed D24587: Fix struct Prototype of GameOptions.
Sat, Oct 12, 10:51 PM · Craft, KDE Games
aacid committed R411:1cd81b39e7b6: Merge remote-tracking branch 'origin/Applications/19.08' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/19.08'
Sat, Oct 12, 10:48 PM
aacid committed R411:b56d13ee8f7c: Remove Include of unistd.h (authored by twighk).
Remove Include of unistd.h
Sat, Oct 12, 10:47 PM
aacid closed D24589: Remove Include of unistd.h.
Sat, Oct 12, 10:47 PM · Craft, KDE Games
aacid accepted D24589: Remove Include of unistd.h.
Sat, Oct 12, 10:47 PM · Craft, KDE Games
aacid committed R395:47fef443064c: Silence annoying gcc warning (authored by aacid).
Silence annoying gcc warning
Sat, Oct 12, 10:45 PM
aacid committed R395:566456616600: Remove Include of unistd.h (authored by twighk).
Remove Include of unistd.h
Sat, Oct 12, 10:40 PM
aacid committed R395:77ccb3d2384b: Merge remote-tracking branch 'origin/Applications/19.08' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/19.08'
Sat, Oct 12, 10:40 PM
aacid closed D24586: Remove Include of unistd.h.
Sat, Oct 12, 10:40 PM · Craft, KDE Games
aacid accepted D24586: Remove Include of unistd.h.
Sat, Oct 12, 10:38 PM · Craft, KDE Games
aacid accepted D24590: Port KSslErrorUiData to QSslError.

Looks good, maybe i can even convince you to make fatalErrors and remainingErrors const?

Sat, Oct 12, 10:34 PM · Frameworks
aacid added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

If the KDE Frameworks developers have agreed to a common style, then yes, naming it KDE Frameworks style makes sense :)

Sat, Oct 12, 10:24 PM · Build System, Frameworks
aacid committed R293:add9ec4f72cd: Add a few const & (authored by aacid).
Add a few const &
Sat, Oct 12, 10:05 PM
aacid closed D24584: Add a few const &.
Sat, Oct 12, 10:04 PM · Baloo, Frameworks
aacid added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

common KDE style file

Sat, Oct 12, 9:52 PM · Build System, Frameworks
aacid abandoned D24400: Make hours qint64.

Meh, just realized this patch is useless since we end up passing the quint variable to formatSingleDuration that passes it to QObject::tr and that one only supports int, so at some point there's a potential loss of range anyway

Sat, Oct 12, 8:49 AM · Frameworks
aacid added inline comments to D24400: Make hours qint64.
Sat, Oct 12, 8:44 AM · Frameworks
aacid requested review of D24584: Add a few const &.
Sat, Oct 12, 8:39 AM · Baloo, Frameworks

Fri, Oct 11

aacid committed R7:510745a88fa5: Fix -Wdeprecated-copy warning (authored by aacid).
Fix -Wdeprecated-copy warning
Fri, Oct 11, 5:05 PM
aacid closed D24552: Fix -Wdeprecated-copy warning.
Fri, Oct 11, 5:05 PM

Thu, Oct 10

aacid committed R411:52f2e9afbeff: Merge remote-tracking branch 'origin/Applications/19.08' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/19.08'
Thu, Oct 10, 10:31 PM
aacid committed R411:9fd839bddede: Add Icons To Executable (authored by twighk).
Add Icons To Executable
Thu, Oct 10, 10:31 PM
aacid closed D24527: Add Icons To Executable.
Thu, Oct 10, 10:31 PM · Craft, KDE Games
aacid accepted D24527: Add Icons To Executable.
Thu, Oct 10, 10:30 PM · Craft, KDE Games
aacid committed R412:bab5b853e9b6: Merge remote-tracking branch 'origin/Applications/19.08' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/19.08'
Thu, Oct 10, 10:29 PM
aacid committed R412:8c3c4e9ed0fd: Add Icons To Executable (authored by twighk).
Add Icons To Executable
Thu, Oct 10, 10:28 PM
aacid closed D24526: Add Icons To Executable.
Thu, Oct 10, 10:28 PM · Craft, KDE Games
aacid accepted D24526: Add Icons To Executable.
Thu, Oct 10, 10:28 PM · Craft, KDE Games
aacid committed R403:91b33d26c72a: Merge remote-tracking branch 'origin/Applications/19.08' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/19.08'
Thu, Oct 10, 10:26 PM
aacid committed R403:2fc9e28f636f: Add Icons To Executable (authored by twighk).
Add Icons To Executable
Thu, Oct 10, 10:25 PM
aacid closed D24525: Add Icons To Executable.
Thu, Oct 10, 10:25 PM · Craft, KDE Games
aacid accepted D24525: Add Icons To Executable.
Thu, Oct 10, 10:24 PM · Craft, KDE Games
aacid updated subscribers of D24552: Fix -Wdeprecated-copy warning.
Thu, Oct 10, 9:38 PM
aacid requested review of D24552: Fix -Wdeprecated-copy warning.
Thu, Oct 10, 9:37 PM
aacid accepted D24509: Fix $modname in update_translations if $NOUPDATE is set.

Same as in the other one, seens sensible, but not testing it is scary.

Thu, Oct 10, 8:36 PM
aacid accepted D24510: Extract module update code into a function.

This looks fine, but your totally untested makes me a bit nervous.

Thu, Oct 10, 8:32 PM
aacid added inline comments to D24511: Simplify get_po_path.
Thu, Oct 10, 8:30 PM

Wed, Oct 9

aacid accepted D24512: Remove CVS-related line.
Wed, Oct 9, 5:20 PM

Tue, Oct 8

aacid updated subscribers of D13588: Add test for field number formatting.

We did rewrite the internals quite a bit since this, @joaonetto is the one that could tell us what needs changing for this to make sense too

Tue, Oct 8, 4:42 PM · Okular

Mon, Oct 7

aacid added a comment to D24245: Add support for passing Unix file descriptors.

ok, fair enough.

Mon, Oct 7, 10:00 PM · Frameworks
aacid committed R235:1c8d9beb720f: Add some std::move in setter functions (authored by aacid).
Add some std::move in setter functions
Mon, Oct 7, 9:52 PM
aacid closed D24395: Add some std::move in setter functions.
Mon, Oct 7, 9:52 PM · Frameworks
aacid committed R877:5dfbbb878a84: Fix Blueprint description for KPat (authored by twighk).
Fix Blueprint description for KPat
Mon, Oct 7, 9:20 PM
aacid closed D24435: Fix Blueprint description for KPat.
Mon, Oct 7, 9:20 PM · KDE Games, Craft
aacid accepted D24435: Fix Blueprint description for KPat.

I've not much idea about craft, but this seems like a no brainer, so landing it :)

Mon, Oct 7, 9:19 PM · KDE Games, Craft
aacid committed R411:e6af6aa33b88: Merge remote-tracking branch 'origin/Applications/19.08' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/19.08'
Mon, Oct 7, 9:17 PM
aacid committed R411:865a87c53146: Fix compile on Windows (more) (authored by twighk).
Fix compile on Windows (more)
Mon, Oct 7, 9:17 PM
aacid closed D24444: Remove KDEGAMES_EXPORT.
Mon, Oct 7, 9:17 PM · KDE Games, Craft
aacid accepted D24444: Remove KDEGAMES_EXPORT.

Nice patch.

Mon, Oct 7, 9:16 PM · KDE Games, Craft
aacid committed R411:515740808e99: Merge remote-tracking branch 'origin/Applications/19.08' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/19.08'
Mon, Oct 7, 9:12 PM
aacid committed R411:6048355a014a: Fix compile on windows (authored by twighk).
Fix compile on windows
Mon, Oct 7, 9:12 PM
aacid closed D24441: Remove Include of pwd.h from kexthighscore_internal.cpp.
Mon, Oct 7, 9:12 PM · KDE Games, Craft
aacid accepted D24294: Port KSslCertificateManager to QSslError.
Mon, Oct 7, 8:43 PM · Frameworks
aacid accepted D24475: Join strings with +, not %.

if it compiles, ship it

Mon, Oct 7, 8:33 PM
aacid accepted D24380: Explicitly define the Journal copy ctor.
Mon, Oct 7, 8:33 PM
aacid committed R456:aa5b115d6fe3: Set label buddies (authored by aacid).
Set label buddies
Mon, Oct 7, 6:28 PM
aacid committed R456:018b2bec35c9: Open & Save various ui files with a new designer (authored by aacid).
Open & Save various ui files with a new designer
Mon, Oct 7, 6:28 PM
aacid added a comment to D24296: Fix alternative translation path building.

not really convinced about projectDir+poBaseDir thought.

Mon, Oct 7, 6:10 PM
aacid added a comment to D24102: Add Pause/Resume action for pausing and resuming speech synthesis..

Can you please close this then?

Mon, Oct 7, 6:02 PM · Okular
aacid committed R456:fd7b65c1c784: Merge remote-tracking branch 'origin/Applications/19.08' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/19.08'
Mon, Oct 7, 5:57 PM
aacid committed R456:cd05ad7feb33: Fix crash when a modified document and not saving changes (authored by aacid).
Fix crash when a modified document and not saving changes
Mon, Oct 7, 5:57 PM
aacid closed D24437: Fix crash when a modified document and not saving changes.
Mon, Oct 7, 5:56 PM

Sun, Oct 6

aacid committed R396:be77f2fe56bb: Fix compile error on Windows (authored by twighk).
Fix compile error on Windows
Sun, Oct 6, 11:22 AM
aacid committed R396:9855f6268b2e: Merge remote-tracking branch 'origin/Applications/19.08' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/19.08'
Sun, Oct 6, 11:22 AM
aacid closed D24420: Compile error on conversion of std::time_t to long int.
Sun, Oct 6, 11:22 AM · Craft, KDE Games
aacid added a reviewer for D24437: Fix crash when a modified document and not saving changes: adrianchavesfernandez.
Sun, Oct 6, 11:09 AM
aacid requested review of D24437: Fix crash when a modified document and not saving changes.
Sun, Oct 6, 11:08 AM
aacid committed R456:a8ff5103ba76: Fix -Wdeprecated-copy warning (authored by aacid).
Fix -Wdeprecated-copy warning
Sun, Oct 6, 10:44 AM

Sat, Oct 5

aacid committed R223:785a984f38ab: Remove obfuscated code from okular's source code (authored by kezik).
Remove obfuscated code from okular's source code
Sat, Oct 5, 9:18 PM
aacid committed R223:da21543a505b: Small performance improvements (authored by aacid).
Small performance improvements
Sat, Oct 5, 8:33 PM
aacid closed D24397: Make some variables qint64 instead of int.
Sat, Oct 5, 5:16 PM
aacid accepted D24419: Implement KSslCertificateRule with QSslError instead of KSslError.
Sat, Oct 5, 5:09 PM · Frameworks

Fri, Oct 4

aacid committed R39:8930c48f7e08: Small performance improvements suggested by clang-tidy (authored by aacid).
Small performance improvements suggested by clang-tidy
Fri, Oct 4, 9:58 PM
aacid closed D24403: Small performance improvements suggested by clang-tidy.
Fri, Oct 4, 9:56 PM · Frameworks, Kate
aacid requested review of D24403: Small performance improvements suggested by clang-tidy.

Ok, i'll commit it then :)

Fri, Oct 4, 9:49 PM · Frameworks, Kate
aacid accepted D24411: Simplify postprocess_pot_file.
Fri, Oct 4, 9:37 PM
aacid committed R293:1c152261b398: Small performance improvements suggested by clang-tidy (authored by aacid).
Small performance improvements suggested by clang-tidy
Fri, Oct 4, 8:27 PM
aacid committed R216:338560698005: Small performance improvements suggested by clang-tidy (authored by aacid).
Small performance improvements suggested by clang-tidy
Fri, Oct 4, 6:47 PM