aacid (Albert Astals Cid)
Engineering

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 19 2015, 12:29 AM (217 w, 22 h)
Availability
Available

Recent Activity

Thu, Jun 13

aacid added inline comments to D15580: New annotation toolbar.
Thu, Jun 13, 9:38 PM · Okular
aacid added a comment to D21786: Update kde.org front page text.

What would you think of using a different name than http://apps.kde.org.uk/ that clearly shows it's non official or a dev thing?

Thu, Jun 13, 9:10 PM
aacid accepted D21751: Fix available writing modes when formatting DVD-RW.

ok :)

Thu, Jun 13, 9:07 PM
aacid added inline comments to D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”.
Thu, Jun 13, 9:07 PM · Okular

Wed, Jun 12

aacid added a comment to D21751: Fix available writing modes when formatting DVD-RW.

Does it make sense to use MEDIA_REWRITABLE_DVD there?

Wed, Jun 12, 9:01 PM
aacid added a comment to D21756: Replace QMessageBox by KMessageBox.

Depends, KUrl? Yes Kurl is deprecated and you should use QUrl

Wed, Jun 12, 8:30 PM · KDE Games

Tue, Jun 11

aacid added inline comments to D15580: New annotation toolbar.
Tue, Jun 11, 10:40 PM · Okular
aacid committed R883:1544022: Forgot to move the appdata too.
Forgot to move the appdata too
Tue, Jun 11, 10:12 PM
aacid committed R883:1544021: gone.
gone
Tue, Jun 11, 10:09 PM
aacid added a comment to D21756: Replace QMessageBox by KMessageBox.

at this point i'd say that krazy warning is a bit old fashioned, but sure, won't hurt either

Tue, Jun 11, 10:08 PM · KDE Games
aacid added inline comments to D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”.
Tue, Jun 11, 10:06 PM · Okular
aacid added a comment to D21734: [WIP] Improve class documentation for PageView and PageViewItem.

Part calls them like this:

  • setupActions() If not in printPreview mode nor in viewerWidget mode
  • setupViewerActions() If not in printPreview mode.
  • setupBaseActions() Always.

    Thinking how to describe that...
Tue, Jun 11, 10:04 PM · Okular
aacid added a comment to D21734: [WIP] Improve class documentation for PageView and PageViewItem.

i got bored of reviewing before reaching 25%, sorry

Tue, Jun 11, 10:03 PM · Okular
aacid added a comment to D21734: [WIP] Improve class documentation for PageView and PageViewItem.

Oh, does someone know any intended purpose division between setupActions(), setupViewerActions(), and setupBaseActions()?

Tue, Jun 11, 9:50 PM · Okular
aacid added inline comments to D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”.
Tue, Jun 11, 9:44 PM · Okular
aacid committed R883:1544019: remove plasma_runner_solid.
remove plasma_runner_solid
Tue, Jun 11, 9:10 PM
aacid committed R94:7ff107454561: Merge remote-tracking branch 'origin/Applications/19.04' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/19.04'
Tue, Jun 11, 6:24 PM
aacid committed R94:d1d74a86f5bb: Fix infinite loop when mThreadingCache is 'corrupted' (authored by aacid).
Fix infinite loop when mThreadingCache is 'corrupted'
Tue, Jun 11, 6:23 PM
aacid closed D21737: Fix infinite loop when mThreadingCache is 'corrupted'.
Tue, Jun 11, 6:23 PM · KDE PIM
aacid committed R883:1544014: revert process_orphans.txt to its full size glory.
revert process_orphans.txt to its full size glory
Tue, Jun 11, 6:22 PM

Mon, Jun 10

aacid requested review of D21737: Fix infinite loop when mThreadingCache is 'corrupted'.
Mon, Jun 10, 8:39 PM · KDE PIM
aacid committed R883:1543915: pimsettingexporter.po -> pimdataexporter.po.
pimsettingexporter.po -> pimdataexporter.po
Mon, Jun 10, 4:24 PM
aacid committed R575:6907b8b70930: Add korean translation (authored by aacid).
Add korean translation
Mon, Jun 10, 4:09 PM
aacid committed R883:1543909: remove ktechlab docs they need regeneration.
remove ktechlab docs they need regeneration
Mon, Jun 10, 4:05 PM
aacid committed R916:a3705fc6f157: Add initial korean translation (authored by aacid).
Add initial korean translation
Mon, Jun 10, 4:05 PM
aacid committed R883:1543908: move ktechlab docu generation to kf5.
move ktechlab docu generation to kf5
Mon, Jun 10, 4:03 PM
aacid committed R883:1543905: forgot to copy/remove the appdata file of ktechlab.
forgot to copy/remove the appdata file of ktechlab
Mon, Jun 10, 4:03 PM
aacid added a comment to D21002: Remove kde4 migration agent completely.

I'm pretty sure there's people there still using KDE4 (real life scenario: my father) (almost real life scenario: i know the Limux people were planning a migration from kde4 to Plasma 5, not sure if it already happened or not though).

Mon, Jun 10, 10:46 AM · Frameworks

Sun, Jun 9

aacid added a comment to D20953: New Home Screen for KTouch.

Loooks good.

Sun, Jun 9, 11:05 PM · KDE Edu
aacid accepted D21190: Use elliptic curve as a default implicit curve.
Sun, Jun 9, 10:50 PM · KDE Edu
aacid accepted D17481: Use lambdas instead of QSignalMapper.
Sun, Jun 9, 10:43 PM · Okular
aacid added a comment to D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg.

Honestly i'd prefer if we wait for 5.10 and then use QMetaObject::invokeMethod instead of QTimer::singleShot.

Sun, Jun 9, 10:39 PM · Gwenview
aacid accepted D15288: Use lambda instead of QSignalMapper.
Sun, Jun 9, 10:33 PM
aacid accepted D15290: Use lambdas instead of QSignalMapper.
Sun, Jun 9, 10:31 PM
aacid added a comment to D15290: Use lambdas instead of QSignalMapper.

You're the only one that has made commits since 2016, so i'd say just commit?

Sun, Jun 9, 10:31 PM
aacid added a comment to D20790: Add highdpi support for RDP and VNC.

I don't know if it's what you where trying to fix or not, but when running with

Sun, Jun 9, 10:29 PM
aacid accepted D21096: vnc: Optimize and simplify repainting.

Please add the two suggested const and commit :)

Sun, Jun 9, 10:20 PM
aacid added a comment to D14527: Show hostname in krfb connection info.

The diff is so trivial, I say just submit a new one yourself with your own authorship information, if that's the sticking point.

Sun, Jun 9, 10:09 PM
aacid added a comment to D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes).

Yes i know you've mentioned it earlier.

Sun, Jun 9, 4:35 PM · Frameworks
aacid added a comment to D21678: audio: Support loading of files from Qt embedded resources.

Code makes sense, haven't tried it though.

Sun, Jun 9, 4:28 PM
aacid added a comment to D21679: Embed kblocksui.rc in Qt resources.

this doesn't get you anywhere though, at least you still have themes and the knsrc file that are needed from make install, no?

Sun, Jun 9, 4:21 PM
aacid committed R883:1543725: ktechlab is now kf5 based.
ktechlab is now kf5 based
Sun, Jun 9, 10:29 AM
aacid committed R495:ac3745e8ca3a: ECMPackageConfigHelpers -> CMakePackageConfigHelpers (authored by aacid).
ECMPackageConfigHelpers -> CMakePackageConfigHelpers
Sun, Jun 9, 10:07 AM
aacid closed D21681: ECMPackageConfigHelpers -> CMakePackageConfigHelpers.
Sun, Jun 9, 10:07 AM · Frameworks

Sat, Jun 8

aacid added a comment to D21679: Embed kblocksui.rc in Qt resources.

What's the problem with make install? it's literally 1 line

Sat, Jun 8, 10:48 PM
aacid added inline comments to D21678: audio: Support loading of files from Qt embedded resources.
Sat, Jun 8, 10:41 PM
aacid added a comment to D21679: Embed kblocksui.rc in Qt resources.

Personally i don't see how this helps at all, but other apps are doing it, so if you're sure it really works you can count my vote as -0

Sat, Jun 8, 10:41 PM
aacid requested review of D21681: ECMPackageConfigHelpers -> CMakePackageConfigHelpers.
Sat, Jun 8, 10:34 PM · Frameworks
aacid committed R391:99f704d3c7b5: Call sounds enabled on startup (authored by aacid).
Call sounds enabled on startup
Sat, Jun 8, 10:27 PM
aacid committed R391:24485a30c738: Delete sounds before creating them again (authored by aacid).
Delete sounds before creating them again
Sat, Jun 8, 10:06 PM
aacid committed R391:ea129f211111: No need to make KGameTheme a member variable (authored by aacid).
No need to make KGameTheme a member variable
Sat, Jun 8, 10:06 PM
aacid committed R391:35ae7d63e71d: Use the theme file defined sounds if they are declared. (authored by jjorge).
Use the theme file defined sounds if they are declared.
Sat, Jun 8, 10:06 PM
aacid closed D21477: Use the theme file defined sounds if they are declared..
Sat, Jun 8, 10:06 PM
aacid accepted D21477: Use the theme file defined sounds if they are declared..
Sat, Jun 8, 9:58 PM
aacid added a comment to D21477: Use the theme file defined sounds if they are declared..

You have a memory leak and some other things like the warnings, but i'll fix them myself and commit.

Sat, Jun 8, 9:58 PM
aacid accepted D21677: Fix cmake warning: Migrate ECMPackageConfigHelpers -> CMakePackageConfigHelpers.
Sat, Jun 8, 9:51 PM
aacid committed R247:68b9b0b06de6: ktechlab master is now kf5 based (authored by aacid).
ktechlab master is now kf5 based
Sat, Jun 8, 9:47 PM
aacid committed R883:1543684: kdev-[car]go -> unmaintained.
kdev-[car]go -> unmaintained
Sat, Jun 8, 9:33 AM
aacid committed R883:1543683: make this a bit more python3 friendly.
make this a bit more python3 friendly
Sat, Jun 8, 9:26 AM

Fri, Jun 7

aacid added a comment to D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes).

A little of both?

Fri, Jun 7, 10:29 PM · Frameworks
aacid added a comment to D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes).

@ngraham what is being requested is using existing code that does this instead of reinveinting the wheel.

Fri, Jun 7, 5:17 PM · Frameworks
aacid committed R910:b590f69be8b7: Add korean translation (authored by aacid).
Add korean translation
Fri, Jun 7, 5:02 PM
aacid committed R883:1543625: Add korean translation.
Add korean translation
Fri, Jun 7, 4:33 PM

Thu, Jun 6

aacid added a comment to D21622: Use a more conventional dropdown menu style instead of press-and-hold.

Ahhhh, yes, the everyone does it wrong except me reasoning.

Thu, Jun 6, 10:32 PM · Okular
aacid added a comment to D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement.

But we're setting the menu here no?

Thu, Jun 6, 10:30 PM · Okular
aacid added a comment to D21630: Change Browse icon back to the hand shape.

wow Not even one minute to review things

I don't particularly like this, input-mouse is an icon that exists in most icon themes
extra/adwaita-icon-theme
extra/breeze-icons
extra/efl
extra/gnome-icon-theme
extra/gnome-icon-theme-symbolic
extra/gnome-themes-extra
extra/oxygen-icons
extra/oxygen-icons-svg
extra/qt5-doc
extra/xf86-input-mouse
extra/xfce4-power-manager
community/arc-icon-theme
community/elementary-icon-theme
community/faba-icon-theme
community/faenza-icon-theme
community/lxinput
community/lxinput-gtk3
community/mate-icon-theme
community/mate-icon-theme-faenza
community/mate-themes
community/moka-icon-theme
community/papirus-icon-theme

transform-browse exists only in breeze-icons

but 🤷‍♂️ i guess

Sorry, I'll wait longer in the future, but input-mouse is still wrong. This simply doesn't mean the same thing as "grabber" or "browse": https://raw.githubusercontent.com/GNOME/adwaita-icon-theme/master/Adwaita/22x22/legacy/input-mouse.png

Thu, Jun 6, 9:59 PM · Okular
aacid added a comment to D21622: Use a more conventional dropdown menu style instead of press-and-hold.

I don't know why you say "it's a more common way", kmail does exactly what okular did, thus, being consistent.

Thu, Jun 6, 8:53 PM · Okular
aacid added a comment to D21630: Change Browse icon back to the hand shape.

wow Not even one minute to review things

Thu, Jun 6, 8:50 PM · Okular
aacid requested changes to D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement.

*Do not change the shortcuts*

Thu, Jun 6, 8:45 PM · Okular

Sun, Jun 2

aacid added inline comments to D10859: Improve layout of annotation configuration dialogs.
Sun, Jun 2, 9:39 PM · Okular
aacid added a comment to D21202: [WIP] Support animated PDF.

The diff shown here is wrong. We want the diff from your branch against master, not the last change in your branch against itself

Sun, Jun 2, 9:25 PM · Okular
aacid added inline comments to D21271: [WIP] Improve documentation of TextEntity stuff.
Sun, Jun 2, 9:13 PM · Okular
aacid added a comment to D21281: [WIP] Write Documentation for Okular::Part.

Some comments.

Sun, Jun 2, 9:08 PM · Okular
aacid added inline comments to D21271: [WIP] Improve documentation of TextEntity stuff.
Sun, Jun 2, 8:39 PM · Okular
aacid added a comment to D21266: [WIP] Improve documentation of area classes.

You really need to remove all the mentions of page you're adding, this is geometry that has nothing to do with pages.

Sun, Jun 2, 8:33 PM · Okular
aacid accepted D21543: Fix narrowing conversion in LineAnnotationWidget::endStyleIcon.

just commit and try it

Sun, Jun 2, 8:06 PM · Okular
aacid added a comment to D21542: Ignore Okteta part if there is an external application available.

Note: as side-effect of this patch, now binaries/libraries in an archive will open in Okular, because there is a okularapplication_fb desktop file registered with application/x-sharedlib.

@aacid why is okular associated with that mimetype?

Sun, Jun 2, 10:56 AM · Ark
aacid added a comment to T10159: kde.org/applications rewrite.

Do you think "Page Setup Info" should be there? Feels weird to me, we don't really have that in the rests of the web.

Yeah it's a complex site and there will be 100 people with an interest in keeping it up to date so I think an obvious link on how to do that is useful. I've moved it to float: right now so it's more out the way.

Sun, Jun 2, 9:57 AM · KDE Applications, Website Developers, KDE Promo

Sat, Jun 1

aacid committed R322:33cd0f5e2441: Follow KDE_APPLICATIONS_VERSION (authored by aacid).
Follow KDE_APPLICATIONS_VERSION
Sat, Jun 1, 7:35 PM
aacid committed R324:0d6f3564e8a1: Follow KDE_APPLICATIONS_VERSION (authored by aacid).
Follow KDE_APPLICATIONS_VERSION
Sat, Jun 1, 5:47 PM
aacid committed R399:91f8bf6fa310: Follow KDE_APPLICATIONS_VERSION (authored by aacid).
Follow KDE_APPLICATIONS_VERSION
Sat, Jun 1, 3:40 PM
aacid added a comment to D21091: Try a standardised versioning scheme using KDE Apps version.

right, see https://cgit.kde.org/ktuberling.git/commit/?id=10d753fce6718a147f0095d2274515bf96078292 for inspiration

Sat, Jun 1, 3:30 PM
aacid committed R418:10d753fce671: Follow KDE_APPLICATIONS_VERSION (authored by aacid).
Follow KDE_APPLICATIONS_VERSION
Sat, Jun 1, 3:29 PM
aacid added a comment to T10159: kde.org/applications rewrite.

Nice work in general, some little things i found.

Sat, Jun 1, 9:52 AM · KDE Applications, Website Developers, KDE Promo
aacid committed R883:1543096: remove po without pot.
remove po without pot
Sat, Jun 1, 8:30 AM

Wed, May 29

aacid requested changes to D21477: Use the theme file defined sounds if they are declared..

Actually no, this is not all good.

Wed, May 29, 10:32 PM
aacid accepted D21477: Use the theme file defined sounds if they are declared..

ther'es some small things as not compating against "" but using isEmpty, but i'll fix that myself when commititng

Wed, May 29, 10:30 PM
aacid committed R420:4cd05d9cf290: increase version a bit since there's a new function (authored by aacid).
increase version a bit since there's a new function
Wed, May 29, 10:27 PM
aacid committed R420:e8e9ea274306: Add a prefix public function to access the internatl prefix. (authored by jjorge).
Add a prefix public function to access the internatl prefix.
Wed, May 29, 10:25 PM
aacid closed D21472: Add a prefix public function to access the internatl prefix..
Wed, May 29, 10:25 PM
aacid accepted D21472: Add a prefix public function to access the internatl prefix..
Wed, May 29, 10:24 PM
aacid added inline comments to D10859: Improve layout of annotation configuration dialogs.
Wed, May 29, 6:07 PM · Okular

Tue, May 28

aacid committed R883:1542870: Bring back ktimetracker from the dead .
Bring back ktimetracker from the dead
Tue, May 28, 9:56 PM
aacid committed R883:1542869: scripts: add back ktimetracker to playground-pim.
scripts: add back ktimetracker to playground-pim
Tue, May 28, 9:52 PM

Mon, May 27

aacid committed R243:5dedab8cb9ec: KCompressionDevice::seek: Fix previous fix ^_^ (authored by aacid).
KCompressionDevice::seek: Fix previous fix ^_^
Mon, May 27, 7:19 AM
aacid closed D21418: KCompressionDevice::seek: Fix previous fix ^_^.
Mon, May 27, 7:19 AM · Frameworks

Sun, May 26

aacid added inline comments to D10859: Improve layout of annotation configuration dialogs.
Sun, May 26, 6:04 PM · Okular
aacid requested review of D21418: KCompressionDevice::seek: Fix previous fix ^_^.
Sun, May 26, 5:51 PM · Frameworks

Sat, May 25

aacid added a comment to D21248: Add line annotation ending arrows for non PDF documents.

I haven't tested it and haven't tried understanding the code farther than "this is a bunch of painting code".

Sat, May 25, 11:05 PM · Okular
aacid added a comment to D21281: [WIP] Write Documentation for Okular::Part.

Honestly i don't think documenting things at this low level makes sense, it'll break because people will never remember to update comments even if it's just on the line above the code they are changing.

Sat, May 25, 10:51 PM · Okular