aacid (Albert Astals Cid)
Engineering

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 19 2015, 12:29 AM (165 w, 5 d)
Availability
Available

Recent Activity

Today

aacid added inline comments to D13172: Add AFNumber_Format and l10n AFSimple_Calculate.
Fri, Jun 22, 8:45 AM · Okular

Yesterday

aacid added inline comments to D13171: Add support for form text formatting.
Thu, Jun 21, 3:44 PM · Okular
aacid updated the diff for D13659: Add option of connecting to the vnc server through a ssh tunnel.

Don't change height accelerator

Thu, Jun 21, 2:54 PM
aacid updated subscribers of D13659: Add option of connecting to the vnc server through a ssh tunnel.
Thu, Jun 21, 2:52 PM
aacid updated the diff for D13659: Add option of connecting to the vnc server through a ssh tunnel.

port -> Port

Thu, Jun 21, 2:52 PM
aacid requested review of D13659: Add option of connecting to the vnc server through a ssh tunnel.
Thu, Jun 21, 2:48 PM

Wed, Jun 20

aacid committed R436:98e814da7f84: Enable override warnings (on gcc) (authored by aacid).
Enable override warnings (on gcc)
Wed, Jun 20, 2:57 PM
aacid committed R436:369544a3e494: Small typo fix (authored by aacid).
Small typo fix
Wed, Jun 20, 2:34 PM

Tue, Jun 19

aacid added a comment to D10009: Improvements for Gettext entries wordwrapping.

This is a change that would greatly benefit from an auto test, sadly we don't have to have any in lokalize.

Tue, Jun 19, 9:46 PM · Localization

Thu, Jun 14

aacid committed R40:609159356c8e: Merge remote-tracking branch 'origin/Applications/18.04' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/18.04'
Thu, Jun 14, 3:56 PM
aacid committed R40:68bd86421c88: Fix if to actually have a comparison (authored by aacid).
Fix if to actually have a comparison
Thu, Jun 14, 3:56 PM
aacid closed D13522: Fix if to actually have a comparison.
Thu, Jun 14, 3:55 PM · Kate

Wed, Jun 13

aacid added a comment to D13471: Expose 'change colors' through dbus interface.

Any new feature needs to be based on master which is where it will land.

Wed, Jun 13, 10:03 PM · Okular
aacid added a comment to T8984: Enclosing placeholders by isolation characters.

I already disagreed that method is the correct solution, so no it's not "the same way"

Wed, Jun 13, 10:01 PM · Localization
aacid added a comment to T8622: sprint for privacy goal.

FWIW I may be interested in attending, i didn't add myself to the list above because I would not want to be a "voter" on the place/date but i would be interested in being notified when the place/date is chosen to see if i can join :)

Wed, Jun 13, 9:51 PM · Goal settings 2017
aacid added a comment to T8621: sprint for usability and productivity goal.

FWIW I may be interested in attending, i didn't add myself to the list above because I would not want to be a "voter" on the place/date but i would be interested in being notified when the place/date is chosen to see if i can join :)

Wed, Jun 13, 9:51 PM · Goal settings 2017
aacid added a comment to T8623: sprint for onboarding goal.

FWIW I may be interested in attending, i didn't add myself to the list above because I would not want to be a "voter" on the place/date but i would be interested in being notified when the place/date is chosen to see if i can join :)

Wed, Jun 13, 9:50 PM · Goal settings 2017
aacid requested review of D13522: Fix if to actually have a comparison.
Wed, Jun 13, 9:25 PM · Kate
aacid updated subscribers of D13489: Fix configure with Qt-5.11.0_beta3 (no more qt5_use_modules).
Wed, Jun 13, 9:13 PM · KDE Edu
aacid added a comment to T8984: Enclosing placeholders by isolation characters.

I would like to discuss if we should enclose every placeholder used in KI18n with the two isolation characters

Wed, Jun 13, 9:10 PM · Localization

Mon, Jun 11

aacid accepted D12912: Improve Hint and Solve action visibility and enabled state.
Mon, Jun 11, 9:08 PM

Fri, Jun 8

aacid committed R883:1517583: Merge elisa stuff from master.
Merge elisa stuff from master
Fri, Jun 8, 9:57 PM
aacid committed R883:1517582: merge wacomtable stuff from master.
merge wacomtable stuff from master
Fri, Jun 8, 9:57 PM
aacid committed R883:1517571: Please fix your po files to pass msgfmt --check.
Please fix your po files to pass msgfmt --check
Fri, Jun 8, 7:36 PM
aacid committed R883:1517307: forgot to update this for elisa branch.
forgot to update this for elisa branch
Fri, Jun 8, 7:30 PM
aacid committed R883:1517308: forgot to update this for wacomtablet.
forgot to update this for wacomtablet
Fri, Jun 8, 7:30 PM
aacid accepted D13411: Show number of incomplete (fuzzy + untranslated) strings in project view.

I'm not convinced "Incomplete" is the best name, but people will understand what it means quickly so i think this can go in.

Fri, Jun 8, 6:22 PM · Localization

Thu, Jun 7

aacid added a comment to D13411: Show number of incomplete (fuzzy + untranslated) strings in project view.

You can't add new features to a stable branch

Thu, Jun 7, 9:27 PM · Localization

Wed, Jun 6

aacid committed R74:b63df9f91fce: clang-standalone -> clazy-standalone (authored by aacid).
clang-standalone -> clazy-standalone
Wed, Jun 6, 3:08 PM

Tue, Jun 5

aacid committed R247:161d2008352c: new branch for elisa (authored by aacid).
new branch for elisa
Tue, Jun 5, 9:12 PM
aacid committed R883:1517240: new branch for elisa.
new branch for elisa
Tue, Jun 5, 9:09 PM
aacid committed R883:1517239: new branch for wacomtablet.
new branch for wacomtablet
Tue, Jun 5, 8:59 PM

Mon, Jun 4

aacid added a comment to D12908: Improve two messages.

For message 3 this is my suggestion, what do you think?

Mon, Jun 4, 10:35 PM
aacid added a comment to D12912: Improve Hint and Solve action visibility and enabled state.

Well, you're the de-facto mainitaner now, so i'll have to trust you, i'd say if noone complains in a week, just commit this. (with the two small things fixed if possible)

Mon, Jun 4, 9:46 PM
aacid committed R883:1517189: remove pot without pot.
remove pot without pot
Mon, Jun 4, 9:36 PM
aacid created T8956: Mails sent via Mailgun being held for moderation.
Mon, Jun 4, 9:12 PM · Sysadmin
aacid added a comment to D13328: A backend is required for kdnssd.

I'm with you that having a possibility to just compile kdnssd without any backend may be of value so i would either not commit this or improve the cmake so there's a way to say I_KNOW_WHAT_I_AM_DOING_KEEP_GOING

Mon, Jun 4, 9:09 PM · Frameworks

Sun, Jun 3

aacid committed R883:1517131: mark as fuzzy, since plurals doesn't match plurals.
mark as fuzzy, since plurals doesn't match plurals
Sun, Jun 3, 9:58 PM
aacid committed R883:1517130: remove po without pot.
remove po without pot
Sun, Jun 3, 9:49 PM
aacid added a comment to D13219: Locale-aware formatting of numbers on status bar.
Sun, Jun 3, 9:07 PM · Localization
aacid added a comment to D13219: Locale-aware formatting of numbers on status bar.

But 2018 is not a number, it's a year ;)

Sun, Jun 3, 4:59 PM · Localization

Thu, May 31

aacid committed R436:eef1768f125e: Make gcc happy (authored by aacid).
Make gcc happy
Thu, May 31, 3:10 PM
aacid added inline comments to D11723: Add FormFieldSignature to Okular namespace.
Thu, May 31, 1:21 PM · Okular
aacid added a comment to D13114: Add DocumentRevision to Okular.

Can you explain what's the use case for this?

Adobe reader allows user to view different signed revisions of a PDF. This patch intends to implement
that feature.

I thought we had agreed that using qvariantmaps for passing structures was a bad idea.
If i have to implement this for my AwesomeGenerator, how do i know what comes in revData?

My bad, I thought you were talking about returning a QVariantMap. I will correct it in next update.

Also the API is weird, you have

QString generateDocumentRevision( int revNum );

but which revNums are you going to use.

The revision number starts from 1 and goes till the total number of signature form fields. The idea here is to
include the total number of signature fields in generator's metadata

Thu, May 31, 1:12 PM · Okular
aacid committed R79:5fb8a9ee6502: Does not depend on kdelibs4support anymore (authored by aacid).
Does not depend on kdelibs4support anymore
Thu, May 31, 1:05 PM
aacid closed D13224: Does not depend on kdelibs4support anymore.
Thu, May 31, 1:05 PM · KDE PIM

Wed, May 30

aacid updated subscribers of D13219: Locale-aware formatting of numbers on status bar.

I'm not too thrilled about this to be honest, seems that this is something i18n should be doing by default, pinging @ilic to see what he would think about fixing/expanding ki18n to do "the right thing" by default

Wed, May 30, 10:30 PM · Localization
aacid requested review of D13224: Does not depend on kdelibs4support anymore.
Wed, May 30, 10:08 PM · KDE PIM
aacid committed R223:66b5f9c83c45: Merge remote-tracking branch 'origin/Applications/18.04' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/18.04'
Wed, May 30, 8:57 AM
aacid committed R223:95bc29a76fc1: Force release of free memory (authored by aacid).
Force release of free memory
Wed, May 30, 8:57 AM
aacid added inline comments to D13172: Add AFNumber_Format and l10n AFSimple_Calculate.
Wed, May 30, 8:20 AM · Okular
aacid added a comment to D13171: Add support for form text formatting.

Are you planning in adding an auto test for this?

Wed, May 30, 8:14 AM · Okular
aacid committed R223:5103e8db6f8d: Add test for additional form actions (authored by aheinecke).
Add test for additional form actions
Wed, May 30, 8:05 AM
aacid closed D13170: Add test for additional form actions.
Wed, May 30, 8:05 AM · Okular
aacid committed R223:18d404c3ee97: Support additional widget actions in PDF Forms (authored by aheinecke).
Support additional widget actions in PDF Forms
Wed, May 30, 8:05 AM
aacid closed D12665: Support additional widget actions in PDF Forms.
Wed, May 30, 8:05 AM · Okular
aacid accepted D13170: Add test for additional form actions.
Wed, May 30, 8:01 AM · Okular

Tue, May 29

aacid added a comment to D13209: Fix IPv6 connectivity.

Do you know if there's a minimum version of libvncserver we should require so that it has that listen6Sock?

Tue, May 29, 9:41 PM

Mon, May 28

aacid added a comment to D12513: CVE-2018-10361: privilege escalation.

I think it was agreed this is an improvement, so i'm going to suggest we commit it.

Mon, May 28, 9:43 PM · Frameworks, Kate
aacid updated the diff for D12937: Drop privileges when reading the salt file.

make salt be on the stack
Also use better_write instead of write

Mon, May 28, 9:33 PM · Plasma
aacid accepted D12665: Support additional widget actions in PDF Forms.

It would defenitely be nicer using a template for this instead of the big define, but if you already tried it i don't really object much, i'm fine with this and will commit it (or you can) once you fix the remaining comments for the associated test

Mon, May 28, 3:17 PM · Okular
aacid added inline comments to D13172: Add AFNumber_Format and l10n AFSimple_Calculate.
Mon, May 28, 3:15 PM · Okular
aacid requested changes to D13170: Add test for additional form actions.

QTest::qWait( 100 ); is bad as you probably already guessed since it's "machine dependant".

Mon, May 28, 3:12 PM · Okular
aacid added inline comments to D13172: Add AFNumber_Format and l10n AFSimple_Calculate.
Mon, May 28, 2:53 PM · Okular
aacid added a comment to D13171: Add support for form text formatting.

I'm not very happy of the internalText method/storage in form, ideally, the text in core/form should always be the internal text, and if there's a formatted text that needs to be different that should only be as part of the widget itself. i.e. the FormLineEdit would do something like

Mon, May 28, 2:43 PM · Okular
aacid committed R223:3ae2ae06e810: Fix recalculating forms twice (authored by aheinecke).
Fix recalculating forms twice
Mon, May 28, 2:30 PM
aacid closed D12825: Fix recalculating forms twice.
Mon, May 28, 2:30 PM · Okular
aacid added inline comments to D12665: Support additional widget actions in PDF Forms.
Mon, May 28, 2:13 PM · Okular
aacid accepted D12825: Fix recalculating forms twice.
Mon, May 28, 2:04 PM · Okular

Sun, May 27

aacid added a comment to D13114: Add DocumentRevision to Okular.

Can you explain what's the use case for this?

Sun, May 27, 7:55 PM · Okular
aacid added inline comments to D12937: Drop privileges when reading the salt file.
Sun, May 27, 7:46 PM · Plasma
aacid accepted D13098: Right-align all translation count columns in Project Overview.
Sun, May 27, 3:36 PM · Localization
aacid added inline comments to D12937: Drop privileges when reading the salt file.
Sun, May 27, 3:35 PM · Plasma
aacid added a comment to D13100: do not use buffered file IO.

have you tried this? because i have just tried it and it failed.

Sun, May 27, 10:05 AM · Plasma
aacid added inline comments to D12937: Drop privileges when reading the salt file.
Sun, May 27, 9:40 AM · Plasma
aacid added inline comments to D12937: Drop privileges when reading the salt file.
Sun, May 27, 9:38 AM · Plasma
aacid updated the diff for D12937: Drop privileges when reading the salt file.

review comments

Sun, May 27, 9:37 AM · Plasma
aacid committed R883:1516586: copy okteta to stable.
copy okteta to stable
Sun, May 27, 8:05 AM
aacid committed R883:1516585: okteta 0.25 docs.
okteta 0.25 docs
Sun, May 27, 8:01 AM
aacid committed R883:1516584: 0.25 for okteta.
0.25 for okteta
Sun, May 27, 7:55 AM
aacid committed R883:1516578: fix 2 plurals in 1 plural file.
fix 2 plurals in 1 plural file
Sun, May 27, 6:34 AM
aacid committed R395:f56cedd89a46: Merge remote-tracking branch 'origin/Applications/18.04' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/18.04'
Sun, May 27, 5:46 AM
aacid committed R395:9685f6aef21b: Fix layouting so the contents are actually not lost (authored by aacid).
Fix layouting so the contents are actually not lost
Sun, May 27, 5:46 AM
aacid committed R395:60396093e407: Fix crash when opening the network config dialog (authored by aacid).
Fix crash when opening the network config dialog
Sun, May 27, 5:46 AM

Sat, May 26

aacid added a comment to D13120: fix i18n issues in framworks/purpose/plugins.

if there's other places using the backslash it's fine, no need to change :)

Sat, May 26, 9:11 AM · Frameworks

Fri, May 25

aacid added a comment to D12912: Improve Hint and Solve action visibility and enabled state.

Are you sure about that? I remember a discussion i had long time ago with an usability person and i think he mentioned showing and hiding menu actions is usually not the best of the ideas because it confuses the user that things the action was there and when it isn't gets confused and thinks it's either somewhere else or that he misremembered, but if instead the action is disabled, usually the user thinks "ah, i need to move to a different state to enable this".

Fri, May 25, 11:07 PM
aacid accepted D12907: Implement wish 319522: Option to restart current game.
Fri, May 25, 11:03 PM
aacid committed R883:1516498: Remove docbook that doesn't compile.
Remove docbook that doesn't compile
Fri, May 25, 9:19 PM
aacid added a comment to D13120: fix i18n issues in framworks/purpose/plugins.

Are you sure you need the backslashes in add_definitions?

Fri, May 25, 9:16 PM · Frameworks
aacid added a comment to D10974: Add option to ignore print margins.

Stepping back a bit, I can identify the following two use cases:

  • The document has its own margins that will make it fit within the printer's printable area without any scaling (e.g. a scientific paper or an eBook)
  • The document will not fit within the printer's printable area without some scaling, either because it has no margins, or because its own margins are not big enough (e.g a flyer, magazine article, or advertisement)

    In the first case, you never need additional margins and always want the document printed with no scaling.

    In the second case, you always need to scale the document down to fit within the printable area, or else the edges will be clipped and you'll lose some of the content.

    If this analysis is complete, then we don't actually need a user-facing setting here at all; we should instead infer the correct setting for ourselves by seeing whether the document to be printed has its own margins that make it fit within the printer's printable area: if it does, print as-is; if it doesn't, then scale it until it fits.

    Am I on the right track, or is this an incomplete assessment?
Fri, May 25, 2:18 PM · Okular
aacid added a comment to D10974: Add option to ignore print margins.

If we use a checkbox, the string I would recommend is "Scale down to fit within printable area".

Fri, May 25, 2:15 PM · Okular

Thu, May 24

aacid added a comment to D13098: Right-align all translation count columns in Project Overview.

Looks good to me, if you want to make sure header and data alignment is the same maybe you can find a way to only have one switch instead of two (i.e. make data call headerData or viceversa or make them both call a new function) that way we enforce they're the same.

Thu, May 24, 8:04 PM · Localization
aacid updated subscribers of D12937: Drop privileges when reading the salt file.
Thu, May 24, 6:03 PM · Plasma
aacid added a comment to D10974: Add option to ignore print margins.

@aacid: What's the right way to properly indicate that an important part of this
was actually done by you (add you in the copyright, mention in the commit message,...)?

Thu, May 24, 5:42 PM · Okular
aacid requested changes to D12250: Install okularpart with the rest of kparts.
Thu, May 24, 9:48 AM · Okular
aacid requested changes to D10932: [Okular] Option to reset forms.
Thu, May 24, 9:48 AM · Okular

Wed, May 23

aacid added inline comments to D11723: Add FormFieldSignature to Okular namespace.
Wed, May 23, 10:54 PM · Okular
aacid added inline comments to D13079: use a consistent style to handle fork().
Wed, May 23, 10:00 PM · Plasma
aacid accepted D13015: use explicit_bzero() if it is present.
Wed, May 23, 8:28 PM · Plasma
aacid committed R107:68e9acb856e9: Merge remote-tracking branch 'origin/Plasma/5.13' (authored by aacid).
Merge remote-tracking branch 'origin/Plasma/5.13'
Wed, May 23, 8:16 PM