People aacid

aacid (Albert Astals Cid)
Engineering

Projects (10)
View All

Calendar

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 19 2015, 12:29 AM (253 w, 5 d)
Availability
Available

Recent Activity
View All

Today

aacid committed R486:02585a58e3c9: add a few const (authored by aacid).
add a few const
Fri, Feb 28, 1:00 PM
aacid added a comment to D27657: Adapt to new KAccounts plugin system.

It would be good if we can land this sooner than later since this is blocking a rebuild of KF5 dependencies for build.kde.org that is blocking a fixed kconfig landing there which makes Okular fail to build on CI because it still uses the unfixed kconfig

Fri, Feb 28, 10:52 AM
aacid added a comment to D27633: Port to KPluginLoader.
In D27633#619369, @aacid wrote:
In D27633#619365, @aacid wrote:

I think this broke https://build.kde.org/job/Applications/job/ktp-common-internals/job/kf5-qt5%20SUSEQt5.12/20/console guess ¿KAccountsDPlugin now requires parameters to the constructor and is thus not a valid Q_INTERFACE?

@nicolasfella can you please look at it?

On top of that that's a BIC change, you can't do BIC changes on KF5 repos, so revert?

Fri, Feb 28, 10:51 AM
aacid added a comment to D27633: Port to KPluginLoader.
In D27633#619365, @aacid wrote:

I think this broke https://build.kde.org/job/Applications/job/ktp-common-internals/job/kf5-qt5%20SUSEQt5.12/20/console guess ¿KAccountsDPlugin now requires parameters to the constructor and is thus not a valid Q_INTERFACE?

@nicolasfella can you please look at it?

Fri, Feb 28, 10:49 AM
aacid added a comment to D27633: Port to KPluginLoader.

I think this broke https://build.kde.org/job/Applications/job/ktp-common-internals/job/kf5-qt5%20SUSEQt5.12/20/console guess ¿KAccountsDPlugin now requires parameters to the constructor and is thus not a valid Q_INTERFACE?

Fri, Feb 28, 10:02 AM

Wed, Feb 26

aacid updated the diff for D27687: Trap the mouse cursor inside the playable area.

edit commit log

Wed, Feb 26, 11:35 PM
aacid updated subscribers of D27687: Trap the mouse cursor inside the playable area.
Wed, Feb 26, 11:33 PM
aacid updated the diff for D27687: Trap the mouse cursor inside the playable area.

make it a bit more robust

Wed, Feb 26, 11:31 PM
aacid planned changes to D27687: Trap the mouse cursor inside the playable area.

Need to trap vertically too

Wed, Feb 26, 10:59 PM
aacid requested review of D27687: Trap the mouse cursor inside the playable area.
Wed, Feb 26, 10:58 PM
aacid requested review of D27686: Fix connection to invalid signal.
Wed, Feb 26, 9:51 PM · Plasma

Tue, Feb 25

aacid accepted D27634: Make QIcon::pixmap() generate HighDPI pixmaps.
Tue, Feb 25, 8:58 PM

Mon, Feb 24

aacid added a comment to D27634: Make QIcon::pixmap() generate HighDPI pixmaps.

could you please change it to have both attributes (as it seems it works for you) set before QApplication?

Mon, Feb 24, 11:55 PM
aacid added a comment to D27634: Make QIcon::pixmap() generate HighDPI pixmaps.

This needs are usually set before creating the app, e.g. okular does

Mon, Feb 24, 11:07 PM
aacid updated subscribers of D27632: Implement UString operator= to make gcc happy.
Mon, Feb 24, 10:46 PM · Frameworks
aacid requested review of D27632: Implement UString operator= to make gcc happy.
Mon, Feb 24, 10:46 PM · Frameworks
aacid committed R486:4cf5d1965f88: Add more const qualifiers (authored by aacid).
Add more const qualifiers
Mon, Feb 24, 3:32 PM
aacid committed R486:06ad9c62b57e: Increase version (authored by aacid).
Increase version
Mon, Feb 24, 2:32 PM

Sun, Feb 23

aacid committed R223:af35ef4fbf4c: Merge remote-tracking branch 'origin/release/19.12' (authored by aacid).
Merge remote-tracking branch 'origin/release/19.12'
Sun, Feb 23, 9:34 PM
aacid committed R223:ff7dff1d62df: Fix rendering of stamps with non 100% opacity (authored by aacid).
Fix rendering of stamps with non 100% opacity
Sun, Feb 23, 9:33 PM
aacid committed R467:0b62c614cc73: Merge remote-tracking branch 'origin/release/19.12' (authored by aacid).
Merge remote-tracking branch 'origin/release/19.12'
Sun, Feb 23, 7:14 PM
aacid committed R467:183d20b1aa54: Fix libsoundfiledecoder with files with non whole second length (authored by aacid).
Fix libsoundfiledecoder with files with non whole second length
Sun, Feb 23, 7:13 PM
aacid committed R883:1562787: breeze-gtk and falkon for kdei.
breeze-gtk and falkon for kdei
Sun, Feb 23, 11:10 AM
aacid committed R883:1562786: falkon and breeze-gtk to kdei:.
falkon and breeze-gtk to kdei:
Sun, Feb 23, 11:05 AM

Sat, Feb 22

aacid added a comment to D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme.

Any particular reason you added me?

Sat, Feb 22, 4:11 PM · Frameworks

Fri, Feb 21

aacid requested changes to D9615: Fix calculation of TextAnnotation size so that select/move rectangle fits exactly around icons regardless of PDF page size and DPI settings.

Please move as a Merge Request in https://invent.kde.org/kde/okular

Fri, Feb 21, 6:56 PM · Okular
aacid requested changes to D10455: Add RTL support for search, copy & paste in pdf.

Please move as a Merge Request in https://invent.kde.org/kde/okular

Fri, Feb 21, 6:56 PM · Okular
aacid requested changes to D13172: Add AFNumber_Format and l10n AFSimple_Calculate.

Please move as a Merge Request in https://invent.kde.org/kde/okular

Fri, Feb 21, 6:56 PM · Okular
aacid requested changes to D13771: Okular/Mac : store the correct install location in the okularpart "install_name".

Please move as a Merge Request in https://invent.kde.org/kde/okular

Fri, Feb 21, 6:56 PM · Okular
aacid requested changes to D15711: Allow KXmlGui UI files to be found more easily.

Please move as a Merge Request in https://invent.kde.org/kde/okular

Fri, Feb 21, 6:56 PM · Okular
aacid requested changes to D16285: Remember printing option and print range in the print dialog.

Please move as a Merge Request in https://invent.kde.org/kde/okular

Fri, Feb 21, 6:56 PM · Okular
aacid requested changes to D17053: Fix link on MacOS.

Please move as a Merge Request in https://invent.kde.org/kde/okular

Fri, Feb 21, 6:55 PM · Okular
aacid requested changes to D7949: Allow to print pdf doc directly into a QPrinter.

Please move as a Merge Request in https://invent.kde.org/kde/okular

Fri, Feb 21, 6:55 PM · Okular
aacid requested changes to D19717: Search function fails to find phrases split over two lines.

Please move as a Merge Request in https://invent.kde.org/kde/okular

Fri, Feb 21, 6:55 PM · Okular
aacid requested changes to D20868: Support '#page=<pagenum>' fragment to open at page <pagenum>.

Please move as a Merge Request in https://invent.kde.org/kde/okular

Fri, Feb 21, 6:55 PM · Okular
aacid requested changes to D21364: Indicate annotation color in annotation list.

Please move as a Merge Request in https://invent.kde.org/kde/okular

Fri, Feb 21, 6:55 PM · Okular
aacid requested changes to D21281: [WIP] Write Documentation for Okular::Part.

Please move as a Merge Request in https://invent.kde.org/kde/okular

Fri, Feb 21, 6:55 PM · Okular
aacid requested changes to D21734: [WIP] Improve class documentation for PageView and PageViewItem.

Please move as a Merge Request in https://invent.kde.org/kde/okular

Fri, Feb 21, 6:55 PM · Okular
aacid requested changes to D21376: RFC: In annotations list show highlighted text.

Please move as a Merge Request in https://invent.kde.org/kde/okular

Fri, Feb 21, 6:54 PM · Okular
aacid requested changes to D22713: Use KRun::runApplication instead of KRun::runService.

Please move as a Merge Request in https://invent.kde.org/kde/okular

Fri, Feb 21, 6:54 PM · Okular
aacid requested changes to D22262: Thumbnails sidebar always open when okular starts.

Please move as a Merge Request in https://invent.kde.org/kde/okular

Fri, Feb 21, 6:54 PM · Okular
aacid requested changes to D24606: Prevent user changing the stamp opacity.

Please move as a Merge Request in https://invent.kde.org/kde/okular

Fri, Feb 21, 6:54 PM · Okular
aacid requested changes to D21195: [RFC] Create a Change Colors menu (with toolbar button).

Please move as a Merge Request in https://invent.kde.org/kde/okular

Fri, Feb 21, 6:54 PM · Okular
aacid requested changes to D21196: [RFC] Move Continuous option to View Mode submenu.

Please move as a Merge Request in https://invent.kde.org/kde/okular

Fri, Feb 21, 6:54 PM · Documentation, Okular
aacid requested changes to D25628: FEATURE: 414688 Add support for alternative scrolling method (prototype).

Please move as a Merge Request in https://invent.kde.org/kde/okular

Fri, Feb 21, 6:53 PM · Okular
aacid requested changes to D21759: Hold zoom center below center/mouse position.

Please move as a Merge Request in https://invent.kde.org/kde/okular

Fri, Feb 21, 6:53 PM · Okular
aacid requested changes to D26163: Install okularpart into plugins/kf5/parts/, embed JSON metadata.

Please move as a Merge Request in https://invent.kde.org/kde/okular

Fri, Feb 21, 6:53 PM · Okular
aacid requested changes to D19123: Added option to search for whole words only.

Please move as a Merge Request in https://invent.kde.org/kde/okular

Fri, Feb 21, 6:53 PM · Okular
aacid committed R223:3720833be4e0: Enable clazy qstring-allocations (authored by aacid).
Enable clazy qstring-allocations
Fri, Feb 21, 5:52 PM
aacid committed R223:9a32bd354d04: Enable clazy raw-environment-function (authored by aacid).
Enable clazy raw-environment-function
Fri, Feb 21, 5:13 PM
aacid committed R223:07a1f616c031: Enable clazy qproperty-type-mismatch (authored by aacid).
Enable clazy qproperty-type-mismatch
Fri, Feb 21, 5:13 PM
aacid committed R223:dcf8f794818f: Enable clazy isempty-vs-count and qhash-with-char-pointer-key (authored by aacid).
Enable clazy isempty-vs-count and qhash-with-char-pointer-key
Fri, Feb 21, 5:13 PM
aacid committed R223:46d1ba0e209d: Enable clazy missing-qobject-macro (authored by aacid).
Enable clazy missing-qobject-macro
Fri, Feb 21, 5:13 PM
aacid committed R223:6d0d61c2ada8: Enable clazy copyable-polymorphic (authored by aacid).
Enable clazy copyable-polymorphic
Fri, Feb 21, 5:13 PM
aacid committed R223:93540ac16df4: Enable most of clazy level2 (authored by aacid).
Enable most of clazy level2
Fri, Feb 21, 2:29 PM

Thu, Feb 20

aacid committed R223:968e9d607365: Enable clazy old-style-connect (authored by aacid).
Enable clazy old-style-connect
Thu, Feb 20, 5:32 PM
aacid committed R223:edb44b1fd344: Enable clazy connect-3arg-lambda (authored by aacid).
Enable clazy connect-3arg-lambda
Thu, Feb 20, 1:20 PM
aacid committed R223:c10faf0926e9: Enable clazy qproperty-without-notify (authored by aacid).
Enable clazy qproperty-without-notify
Thu, Feb 20, 1:20 PM
aacid committed R223:a9598e83e8bb: Enable all of clazy level1 (authored by aacid).
Enable all of clazy level1
Thu, Feb 20, 1:20 PM
aacid committed R223:e03943fae9df: Enable clazy qstring-lef (authored by aacid).
Enable clazy qstring-lef
Thu, Feb 20, 1:20 PM
aacid committed R223:91bce4a0a315: Enable clazy const-signal-or-slot (authored by aacid).
Enable clazy const-signal-or-slot
Thu, Feb 20, 1:20 PM
aacid committed R223:93de24779533: Enable all of clazy level0 (authored by aacid).
Enable all of clazy level0
Thu, Feb 20, 1:20 PM
aacid committed R223:3ca05fc1f8fd: Enable clazy qstring-insensitive-allocation (authored by aacid).
Enable clazy qstring-insensitive-allocation
Thu, Feb 20, 1:20 PM
aacid committed R223:f85deae68012: Enable clazy container-anti-pattern (authored by aacid).
Enable clazy container-anti-pattern
Thu, Feb 20, 1:20 PM
aacid committed R223:beb195c9e69c: Enable clazy qcolor-from-literal (authored by aacid).
Enable clazy qcolor-from-literal
Thu, Feb 20, 1:20 PM
aacid committed R223:8e35b43a3d69: Enable clazy unused-non-trivial-variable (authored by aacid).
Enable clazy unused-non-trivial-variable
Thu, Feb 20, 1:20 PM
aacid committed R223:0a60ab54c49f: Enable clazy qstring-ref (authored by aacid).
Enable clazy qstring-ref
Thu, Feb 20, 1:20 PM
aacid committed R223:95e19450c96c: Enable clazy fully-qualified-moc-types (authored by aacid).
Enable clazy fully-qualified-moc-types
Thu, Feb 20, 1:20 PM
aacid committed R223:eddbe031288e: enable clazy strict-iterators (authored by aacid).
enable clazy strict-iterators
Thu, Feb 20, 1:20 PM
aacid committed R223:3b4dd35c9fe6: Enable clazy lambda-in-connect (authored by aacid).
Enable clazy lambda-in-connect
Thu, Feb 20, 1:20 PM
aacid closed D27447: Use python3 in generate_release_data.py.

pushed

Thu, Feb 20, 12:00 AM
aacid committed R883:1562584: move generate_release_data.py to pyhon3.
move generate_release_data.py to pyhon3
Thu, Feb 20, 12:00 AM

Wed, Feb 19

aacid committed R223:e54609b596ed: CI: rename to show we're also running clazy (authored by aacid).
CI: rename to show we're also running clazy
Wed, Feb 19, 11:45 PM
aacid committed R223:468f4b64c2f1: CI: Enable clazy inefficient-qlist-soft (authored by aacid).
CI: Enable clazy inefficient-qlist-soft
Wed, Feb 19, 11:45 PM
aacid committed R223:e2a170570309: CI: Enable clazy connect-not-normalized (authored by aacid).
CI: Enable clazy connect-not-normalized
Wed, Feb 19, 11:45 PM
aacid committed R223:3af705b3d7ee: CI: Enable clazy qdeleteall (authored by aacid).
CI: Enable clazy qdeleteall
Wed, Feb 19, 11:45 PM
aacid committed R223:a23709b0970a: CI: Enable clazy range-loop (authored by aacid).
CI: Enable clazy range-loop
Wed, Feb 19, 11:45 PM
aacid committed R223:82d58104936d: CI: Enable clazy detaching-temporary (authored by aacid).
CI: Enable clazy detaching-temporary
Wed, Feb 19, 11:45 PM
aacid committed R223:1a05112be1d5: CI: enable clazy incorrect-emit (authored by aacid).
CI: enable clazy incorrect-emit
Wed, Feb 19, 11:45 PM
aacid committed R223:6ddb7e6cc96f: CI: Enable clazy qhash-namespace (authored by aacid).
CI: Enable clazy qhash-namespace
Wed, Feb 19, 11:45 PM
aacid committed R223:96f00a4d2947: CI: Enable clazy qstring-arg check (authored by aacid).
CI: Enable clazy qstring-arg check
Wed, Feb 19, 11:45 PM
aacid requested changes to D27501: Add mimetype information to mobile desktop file.
Wed, Feb 19, 10:54 PM · Okular
aacid added a comment to D27501: Add mimetype information to mobile desktop file.

Please move to https://invent.kde.org/kde/okular/

Wed, Feb 19, 10:54 PM · Okular
aacid committed R260:86775973e1cb: Merge remote-tracking branch 'origin/release/19.12' (authored by aacid).
Merge remote-tracking branch 'origin/release/19.12'
Wed, Feb 19, 10:52 PM
aacid committed R260:9973a097d30a: Fix loading of remote files (i.e https) (authored by aacid).
Fix loading of remote files (i.e https)
Wed, Feb 19, 10:52 PM
aacid closed D27489: Fix loading of remote files (i.e https).
Wed, Feb 19, 10:52 PM · Gwenview
aacid committed R223:5ecbb51f77ff: Enable modernize-use-nullptr (authored by aacid).
Enable modernize-use-nullptr
Wed, Feb 19, 6:00 PM
aacid updated the diff for D27447: Use python3 in generate_release_data.py.
Wed, Feb 19, 12:21 AM
aacid updated subscribers of D27489: Fix loading of remote files (i.e https).
Wed, Feb 19, 12:04 AM · Gwenview
aacid requested review of D27489: Fix loading of remote files (i.e https).
Wed, Feb 19, 12:04 AM · Gwenview

Tue, Feb 18

aacid committed R883:1562514: Fix markup.
Fix markup
Tue, Feb 18, 9:15 PM
aacid closed D27487: Fix et translations and build of kde.org/announcements/releases.

pushed

Tue, Feb 18, 9:15 PM
aacid accepted D27487: Fix et translations and build of kde.org/announcements/releases.
Tue, Feb 18, 9:13 PM
aacid added a comment to D10009: Improvements for Gettext entries wordwrapping.

Sure, i agree producing similar formatting to those of other tools is good.

Tue, Feb 18, 8:46 PM · Localization
aacid added a comment to D27462: Include comment for translators for Power Down.

i think it's better than nothing yes

Tue, Feb 18, 8:45 PM · Plasma
aacid committed R410:78ea459bc4ae: Fix sometimes two moves being counted as one (authored by aacid).
Fix sometimes two moves being counted as one
Tue, Feb 18, 8:39 PM
aacid closed D27336: Fix sometimes two moves being counted as one.
Tue, Feb 18, 8:39 PM
aacid committed R883:1562512: cutehmi moved back.
cutehmi moved back
Tue, Feb 18, 8:29 PM
aacid added a comment to D27459: Port QLinkedList which is deprecated in qt5.15.

Are we sure we can lose the features of QLinkedList here?

Tue, Feb 18, 12:35 AM · Frameworks

Mon, Feb 17

aacid committed R486:30a9249dd951: Mark a few byte arrays as const (authored by aacid).
Mark a few byte arrays as const
Mon, Feb 17, 5:07 PM