aacid (Albert Astals Cid)
Engineering

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 19 2015, 12:29 AM (182 w, 2 d)
Availability
Available

Recent Activity

Today

aacid added a comment to D16118: Fix crash on startup.

Unless someone disagrees i'll commit this tomorrow

Tue, Oct 16, 5:46 PM

Yesterday

aacid added inline comments to D16182: Port KWordQuiz away from deprecated API and kdelibs4support.
Mon, Oct 15, 9:29 PM · KDE Edu
aacid added a comment to D15633: Port KImageMapEditor away from deprecated KUrl, saveWindowSize and initialGeometrySet().

This looks reasonable to me, but since Luigi is the one that did most of the last work i'll let him do the actual approval for the patch :)

Mon, Oct 15, 9:21 PM
aacid added a comment to D16137: Add an option to KConfigDialog to fit page contents horizontally.

Yep, this looks more like it :)

Mon, Oct 15, 9:16 PM · Frameworks
aacid added a comment to D15355: Port KolourPaint away from deprecated KFileDialog.

Just to be sure if I'm moving in an acceptable direction (resizing does not work for some reason yet). Screenshot:

Mon, Oct 15, 9:12 PM
aacid added a comment to D15316: Port KolourPaint away from deprecated KDoubleNumInput.

I feel like having two classes of each is not the best of the ideas, since it seems the only difference in one you use 10 and in the other 100 in notifyValueChanged.

Mon, Oct 15, 9:02 PM · KDE Applications
aacid committed R467:05f4988a4719: Merge remote-tracking branch 'origin/Applications/18.08' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/18.08'
Mon, Oct 15, 8:47 PM
aacid committed R467:8709a3dcaef9: MetaItemModel: Fix Qt assertion in adding rows (authored by aacid).
MetaItemModel: Fix Qt assertion in adding rows
Mon, Oct 15, 8:46 PM
aacid closed D16213: MetaItemModel: Fix Qt assertion in adding rows.
Mon, Oct 15, 8:46 PM
aacid added a comment to D16090: Add benevity and Amazon Smile to "Other ways to Donate".

On both of the Amazon links, I only get Amazon login screens. It is not possible to review this information.

(In contrast, the Benevity link leads to information accessible to the public. The description about KDE sounds good there.)

even FSF does at https://www.fsf.org/about/ways-to-donate/

They have included a disclaimer: "As an independent small publisher, the FSF discourages people from shopping at Amazon (plus, Amazon supports DRM)". Can we add something like that as well? Because I am worried about linking to Amazon.

Mon, Oct 15, 8:44 PM
aacid added a comment to D16146: Remove KNS support.

Have you asked sysadmin if by any chance they have a backup from that old site?

Mon, Oct 15, 2:40 PM · KDE Edu

Sun, Oct 14

aacid updated subscribers of D16213: MetaItemModel: Fix Qt assertion in adding rows.
Sun, Oct 14, 10:38 PM
aacid requested review of D16213: MetaItemModel: Fix Qt assertion in adding rows.
Sun, Oct 14, 10:37 PM
aacid added a comment to D16186: Fix localization for number of seconds in spinbox.

I still maintain this is wrong, and that there is no need for the second i18ncp since we don't support anywhere else different plurals for decimal numbers so we shouldn't here either, and as far as I know we don't support differnt plurals because all languages just use the same form for decimal numbers.

Sun, Oct 14, 10:21 PM · Spectacle
aacid added a comment to D16137: Add an option to KConfigDialog to fit page contents horizontally.

That's almost good, but the flag name should be more general, think like for example you would remove the manage bool and convert it to a flag too, so that if it the future someone needs to add a new flag, they can add it to that enum and don't need a new parameter.

Sun, Oct 14, 4:56 PM · Frameworks

Sat, Oct 13

aacid added a comment to D16169: Add option to close Kate when last file closes.

*personally* I'd hate it to be the default, since clearing all the open files to get an empty one where i can write is something i do several times a day.

Sat, Oct 13, 3:38 PM · Kate
aacid committed R883:1526496: remove po without pot.
remove po without pot
Sat, Oct 13, 9:32 AM

Fri, Oct 12

aacid added inline comments to D15518: Editor - Line highlighting color fix.
Fri, Oct 12, 8:14 PM · KDE Edu
aacid added a comment to D16143: Change null pointer reference from zero to nullptr.

Oh you're doing this manually?

Fri, Oct 12, 8:02 PM · KDE Edu
aacid committed R240:1f056a36160a: Add support for the fuzzer sanitizer (authored by Adam Reichold <adam.reichold@t-online.de>).
Add support for the fuzzer sanitizer
Fri, Oct 12, 6:06 PM
aacid added a comment to D15316: Port KolourPaint away from deprecated KDoubleNumInput.

You fixed one and broke the other :D

Fri, Oct 12, 5:03 PM · KDE Applications
aacid added a comment to D16137: Add an option to KConfigDialog to fit page contents horizontally.

I have to admit, I don't know how to implement a version with flags correctly.

Fri, Oct 12, 4:39 PM · Frameworks
aacid added a comment to D15633: Port KImageMapEditor away from deprecated KUrl, saveWindowSize and initialGeometrySet().

Opening an image (Via File->Open) doesn't work (which i realize in the non ported version doesn't work either, but the error is different so you may want to have a look anyway.

Fri, Oct 12, 4:30 PM
aacid added a comment to D15316: Port KolourPaint away from deprecated KDoubleNumInput.

With the new code i get 0,10 increments in Hue instead 0,03 but still far away from the 1,08 i get with the old version

Fri, Oct 12, 4:17 PM · KDE Applications
aacid accepted D16104: Add some unit tests for the shuffle algo..
Fri, Oct 12, 3:38 PM
aacid accepted D16155: Remove color variants from methods, pass color as parameter.
Fri, Oct 12, 3:18 PM · KDE Edu
aacid committed R410:b036d67d5467: Merge remote-tracking branch 'origin/Applications/18.08' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/18.08'
Fri, Oct 12, 10:40 AM
aacid committed R410:925769b482e5: Make sure the card we're trying to automove is the top of the pile (authored by aacid).
Make sure the card we're trying to automove is the top of the pile
Fri, Oct 12, 10:40 AM
aacid closed D16121: Make sure the card we're trying to automove is the top of the pile.
Fri, Oct 12, 10:40 AM
aacid added a comment to D16121: Make sure the card we're trying to automove is the top of the pile.

Thanks! I see it here now - https://bugs.kde.org/show_bug.cgi?id=399123 - there was no link to the bug. The fix seems sane.

Fri, Oct 12, 10:34 AM

Thu, Oct 11

aacid updated subscribers of D16147: Draw non-external text annotations with word wrap.

I'm unconvinced whether this is actually better, but it's somehow similar to what poppler does, so maybe it makes sense?

Thu, Oct 11, 11:02 PM · Okular
aacid requested review of D16147: Draw non-external text annotations with word wrap.
Thu, Oct 11, 11:01 PM · Okular
aacid added a comment to D16104: Add some unit tests for the shuffle algo..

It's just that, create a folder named autotest and put the tests there :D

Thu, Oct 11, 10:17 PM
aacid added a comment to D16121: Make sure the card we're trying to automove is the top of the pile.

Can you give a deal number / screenshot / screencast where kpat moves a non-top card to the foundation automatically without this patch?

Thu, Oct 11, 10:16 PM
aacid accepted D16126: Fix opening special text files.
Thu, Oct 11, 10:10 PM
aacid added a comment to D16125: Add QCoreApplication.

@broulik so you were getting the

./kioslave/kamera.cpp:796:        error(KIO::ERR_SLAVE_DEFINED, i18n("Could not read. Reason: %1",

often? Or is it somehow an inherited i18n call?

Thu, Oct 11, 10:07 PM
aacid added a comment to D16137: Add an option to KConfigDialog to fit page contents horizontally.

Adding new parameters is unfortunately Binary Incompatible so this can't go in this way, for it to work you'd need to add a new function with all the parameters and then call one from the other.

Thu, Oct 11, 9:55 PM · Frameworks

Wed, Oct 10

aacid committed R241:ed471c701d49: kdirmodeltest: delete m_dirModelForExpand (authored by aacid).
kdirmodeltest: delete m_dirModelForExpand
Wed, Oct 10, 11:04 PM
aacid committed R241:7c4ef88f8780: Fix memory leak in KDirModelTest::testMimeData (authored by aacid).
Fix memory leak in KDirModelTest::testMimeData
Wed, Oct 10, 10:56 PM
aacid committed R241:b23c98a8363a: Fix previous commit (authored by aacid).
Fix previous commit
Wed, Oct 10, 10:53 PM
aacid updated subscribers of D16121: Make sure the card we're trying to automove is the top of the pile.
Wed, Oct 10, 10:19 PM
aacid requested review of D16121: Make sure the card we're trying to automove is the top of the pile.
Wed, Oct 10, 10:19 PM
aacid committed R241:aff9ac6d33eb: Fix test wrong usage of QModelIndex (authored by aacid).
Fix test wrong usage of QModelIndex
Wed, Oct 10, 9:40 PM
aacid committed R423:22b2209e8a24: Merge remote-tracking branch 'origin/Applications/18.08' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/18.08'
Wed, Oct 10, 9:29 PM
aacid committed R423:483d3f8b9428: Fix leak of the graphicsscene on the Puzzle preview (authored by aacid).
Fix leak of the graphicsscene on the Puzzle preview
Wed, Oct 10, 9:29 PM
aacid committed R423:c8cf3ef26f54: Only cast events to other events when we know it's them (authored by aacid).
Only cast events to other events when we know it's them
Wed, Oct 10, 9:26 PM
aacid committed R423:af5b5055fa70: Merge remote-tracking branch 'origin/Applications/18.08' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/18.08'
Wed, Oct 10, 9:21 PM
aacid committed R423:38f21198899c: Fix small memory leak (authored by aacid).
Fix small memory leak
Wed, Oct 10, 9:20 PM
aacid committed R423:e599db587d0f: Fix undefined behaviour (casting a pointer to a delete object) (authored by aacid).
Fix undefined behaviour (casting a pointer to a delete object)
Wed, Oct 10, 9:17 PM
aacid updated subscribers of D16118: Fix crash on startup.
Wed, Oct 10, 9:10 PM
aacid requested review of D16118: Fix crash on startup.
Wed, Oct 10, 9:08 PM
aacid added a comment to D16104: Add some unit tests for the shuffle algo..

Add an autotests folder?

Wed, Oct 10, 8:35 PM
aacid closed D16090: Add benevity and Amazon Smile to "Other ways to Donate".

Pushed https://websvn.kde.org/?view=revision&revision=r1526304

Wed, Oct 10, 8:25 PM
aacid committed R883:1526304: Add Benevity and Amazon Smile.
Add Benevity and Amazon Smile
Wed, Oct 10, 8:25 PM

Tue, Oct 9

aacid requested review of D16090: Add benevity and Amazon Smile to "Other ways to Donate".
Tue, Oct 9, 9:43 PM
aacid updated subscribers of D15716: Suspicious use of signed arithmetic leads to negative index crash.
Tue, Oct 9, 8:43 PM
aacid added a comment to D16048: Resize the preferences dialogue to avoid horizontal scrolling.

If you can fix this correctly once in KConfigDialog instead of adding bad magic numbers everywhere, fixing it in KConfigDialog seems to be a no brainer (maybe with an flag option to not change behaviour for people that don't want that)

Tue, Oct 9, 7:04 PM · Okular

Mon, Oct 8

aacid added a comment to D15691: Add unarchiver support for cbr files.

I'm not thrilled about all these dynamic_cast< UnarFlavour * > in the ifs.

Mon, Oct 8, 10:19 PM · Okular
aacid committed R368:7778e5f9fa92: Increase version number (authored by aacid).
Increase version number
Mon, Oct 8, 9:21 PM
aacid committed R368:006910d73a03: Split out notificator to allow for testing plus tests (authored by dklimkin).
Split out notificator to allow for testing plus tests
Mon, Oct 8, 9:12 PM
aacid closed D15593: Split out notificator to allow for testing plus tests.
Mon, Oct 8, 9:12 PM
aacid added inline comments to D15593: Split out notificator to allow for testing plus tests.
Mon, Oct 8, 9:09 PM
aacid added a comment to D15593: Split out notificator to allow for testing plus tests.

ah my fault was based on the other revision

Mon, Oct 8, 9:06 PM
aacid committed R368:fae094876050: Adjust tests to proper handle ownership (authored by dklimkin).
Adjust tests to proper handle ownership
Mon, Oct 8, 9:05 PM
aacid closed D15592: Adjust tests to proper handle ownership.
Mon, Oct 8, 9:05 PM
aacid requested changes to D13100: do not use buffered file IO.
Mon, Oct 8, 8:56 PM · Plasma
aacid committed R223:a482c56ba240: Select current format on the configure backend dialog (authored by aacid).
Select current format on the configure backend dialog
Mon, Oct 8, 8:55 PM
aacid closed D14820: Select current format on the configure backend dialog.
Mon, Oct 8, 8:55 PM · Okular
aacid added a comment to D16048: Resize the preferences dialogue to avoid horizontal scrolling.

629 is a random number, random numbers are bad.

Mon, Oct 8, 4:46 PM · Okular

Sun, Oct 7

aacid committed R883:1525993: fix issue with plurals.
fix issue with plurals
Sun, Oct 7, 4:34 PM

Fri, Oct 5

aacid added inline comments to D15518: Editor - Line highlighting color fix.
Fri, Oct 5, 9:15 PM · KDE Edu
aacid committed R353:b0ce4ff01b5e: Corrected behaviour on repeated pressing of operator buttons (authored by mschiller).
Corrected behaviour on repeated pressing of operator buttons
Fri, Oct 5, 9:10 PM
aacid closed D15463: Corrected behaviour on repeated pressing of operator buttons.
Fri, Oct 5, 9:10 PM
aacid added a comment to D15972: Port KFind away from KMimeType.

("KDE Applications" is not meant to be used as tag for reviews, it's used to collect the projects; the last one who did significant changes to kfind is @broulik )

Fri, Oct 5, 8:34 PM
aacid committed R739:293672279fba: Make the gcc fall-through detector happy (authored by aacid).
Make the gcc fall-through detector happy
Fri, Oct 5, 7:11 AM

Thu, Oct 4

aacid committed R883:1525820: Fix date.
Fix date
Thu, Oct 4, 5:26 PM
aacid accepted D15936: Remove NOKDE version.
Thu, Oct 4, 5:09 PM · Localization

Tue, Oct 2

aacid accepted D15698: Port audiocd-kio away from kdelibs4support.

I haven't tested it, but code seems sensible, so if you have tested it and are confident it works, i'd say go for it

Tue, Oct 2, 9:12 PM
aacid committed R223:3cdb348d1e0e: Merge remote-tracking branch 'origin/Applications/18.08' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/18.08'
Tue, Oct 2, 7:30 PM
aacid committed R223:ee5b830ced19: Fine tune opening of archives after last change (authored by aacid).
Fine tune opening of archives after last change
Tue, Oct 2, 7:30 PM

Mon, Oct 1

aacid committed R223:3a1a037dd306: Merge remote-tracking branch 'origin/Applications/18.08' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/18.08'
Mon, Oct 1, 11:35 PM
aacid committed R223:caf52d0ed92f: Fine tune opening files (authored by aacid).
Fine tune opening files
Mon, Oct 1, 10:36 PM
aacid requested changes to D12098: Resize content area to correct dimensions after zooming to Auto Fit.
Mon, Oct 1, 9:52 PM · Okular
aacid added a comment to D12098: Resize content area to correct dimensions after zooming to Auto Fit.

This doesn't make sense to me, this code should not be triggered in the case that is higlighted in this bug since AutoFit in that very long document should never be a case of "the scrollbar vs no scrollbar fight", so what we need to figure out is why the if is being triggered and protect against it, not fixing what is inside the if.

Mon, Oct 1, 9:52 PM · Okular
aacid added inline comments to D15698: Port audiocd-kio away from kdelibs4support.
Mon, Oct 1, 9:41 PM
aacid added inline comments to D15698: Port audiocd-kio away from kdelibs4support.
Mon, Oct 1, 9:33 PM

Thu, Sep 27

aacid added a comment to T9759: Update CiviCRM to 5.5.x.

Have you double checked with the civicrm consultant (forgot his name), that this is OK? Last i remember there was some incompatibility between the sepa stuff and the new civicrm versions.

Thu, Sep 27, 3:08 PM · KDE e.V., Fundraising Working Group

Tue, Sep 25

aacid added a comment to D14631: Adds a new RenameDialog to KIO with more options for batch renaming.

@aacid Would be great if you'd point me towards making them installable. Only the dialog itself should be exported.

Tue, Sep 25, 10:45 PM · Frameworks
aacid added inline comments to D15633: Port KImageMapEditor away from deprecated KUrl, saveWindowSize and initialGeometrySet().
Tue, Sep 25, 10:00 PM

Mon, Sep 24

aacid added inline comments to D15316: Port KolourPaint away from deprecated KDoubleNumInput.
Mon, Sep 24, 9:59 AM · KDE Applications
aacid added a comment to D15593: Split out notificator to allow for testing plus tests.

The patch doesn't seem to apply here, is this on top of master?

Mon, Sep 24, 9:41 AM
aacid added inline comments to D15633: Port KImageMapEditor away from deprecated KUrl, saveWindowSize and initialGeometrySet().
Mon, Sep 24, 9:13 AM

Sun, Sep 23

aacid added a comment to D15355: Port KolourPaint away from deprecated KFileDialog.

The ported dialog looks bad, both because the layout of the new widget is not where you would want it to be and because it has much less functionality than the native dialog.

Sun, Sep 23, 9:11 PM
aacid added inline comments to D15316: Port KolourPaint away from deprecated KDoubleNumInput.
Sun, Sep 23, 8:45 PM · KDE Applications
aacid added a comment to D15711: Allow KXmlGui UI files to be found more easily.

I don't like qrc, are you saying that the only way kxmlgui works on MacOs is by not installing files?

Sun, Sep 23, 5:38 PM · Okular

Sat, Sep 22

aacid added a comment to D15691: Add unarchiver support for cbr files.

So there's unar and lsar? What's the difference? Can you add some more text to the summary explaining it?

Sat, Sep 22, 4:33 PM · Okular

Fri, Sep 21

aacid accepted D15624: Simplify code in the paintEvent.

Cool looks defenitely easier to understand, please remove the unneded include and commit :)

Fri, Sep 21, 10:12 PM · KDE Edu

Thu, Sep 20

aacid added inline comments to D15463: Corrected behaviour on repeated pressing of operator buttons.
Thu, Sep 20, 7:56 PM
aacid updated subscribers of D15463: Corrected behaviour on repeated pressing of operator buttons.
Thu, Sep 20, 7:54 PM
aacid committed R954:6f7bf3bb16d1: Add Ashwin Samudre (ashwins) (authored by aacid).
Add Ashwin Samudre (ashwins)
Thu, Sep 20, 7:46 PM