Crash was introduced in commit decc2d76df6b6ac1515127183dae4babb6c3ace2
Author: André Agenor
Date: Tue Feb 19 14:35:31 2019 -0300

https://phabricator.kde.org/D23311

i think i have a proper fix for this, please hold on commiting for a bit

update commit log

I'll close it manually

Could i convince you to just capture what you need (game?) instead everything (=) ?

this is unreviawable, please split it in different parts

In D23016#511045, @sankethi wrote:

I see, you are suggesting a method to configure the shortcut within the app itself. I think I found an example of this in kompare - https://github.com/annulen/kompare/blob/master/kompare_shell.cpp#L438 - that seems to be the way to make this happen.

hmmm, now that i think about it LC_ALL probably needs a .UTF-8 suffix or something to be correct

if it adds something, i don't really see the usecase, but you're spending your time on this, so sure

Git it. You could have used my non expired key http://hkps.pool.sks-keyservers.net/pks/lookup?op=get&search=0xCA262C6C83DE4D2FB28A332A3A6A4DB839EAA6D7

And what are you or ben waiting for? You've both got commit access :)

Looks, good, i'll commit a slightly modified version that checks substituteName != fontname too, wanted to save us all the roundtrip

In D23037#509088, @broulik wrote:

Works well, thanks a lot! Let's wait for Okular maintainer approval.

Ok, let's see the code you have and tell us where it fails and we'll try to help :)

The "problem" with this is that you need to go to systemsettings and configure the shortcut from there.

Why do you want to move the mouse?

Having the possibility of setting a global shortcut is cool, but having one by default i think it may be a bit too much.

I don't think it makes sense to have it in the third column, personally i think it'd make more sense in the first

-1