aacid (Albert Astals Cid)
Engineering

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 19 2015, 12:29 AM (149 w, 1 h)
Availability
Available

Recent Activity

Yesterday

aacid added a comment to D10784: Convert README.md to actual markdown.

@progwolff as far as i understand it @jhoff doesn't have commit rights so you'll have to commit it for him.

Sat, Feb 24, 6:24 PM
aacid added inline comments to D10757: Reset QLocale internals when we have a custom app language.
Sat, Feb 24, 12:38 AM · Frameworks

Fri, Feb 23

aacid added a comment to D10758: Use QLocale instead of QLocale::system.

there's a new revision of D10757 that shouldn't need this at all.

Fri, Feb 23, 11:48 PM · Frameworks
aacid added a comment to D10759: Use QLocale instead of QLocale::system.

there's a new revision of D10757 that shouldn't need this at all.

Fri, Feb 23, 11:48 PM · Build System, Frameworks
aacid updated subscribers of D10757: Reset QLocale internals when we have a custom app language.

@lueck can you try this new version *without* https://phabricator.kde.org/D10758 and https://phabricator.kde.org/D10759 ? This should be enough to get QLocale to update itself.

Fri, Feb 23, 11:48 PM · Frameworks
aacid updated the diff for D10757: Reset QLocale internals when we have a custom app language.

Use QSystemLocale trick to reset QLocale

Fri, Feb 23, 11:47 PM · Frameworks
aacid requested review of D10759: Use QLocale instead of QLocale::system.
Fri, Feb 23, 12:36 AM · Build System, Frameworks
aacid requested review of D10758: Use QLocale instead of QLocale::system.
Fri, Feb 23, 12:36 AM · Frameworks
aacid requested review of D10757: Reset QLocale internals when we have a custom app language.
Fri, Feb 23, 12:35 AM · Frameworks

Thu, Feb 22

aacid added a comment to D8690: Fix use of OpenUrlArguments.

@aacid Can we agree to revert to https://phabricator.kde.org/D8690?id=22028 and land this to get the bug fixed?

Thu, Feb 22, 6:58 PM · Okular
aacid added a comment to D10249: Option to exit after printing.

You mean you don't get this?

Thu, Feb 22, 8:35 AM · Okular

Wed, Feb 21

aacid requested changes to D7962: Implement several new print scaling options.
Wed, Feb 21, 11:26 PM · Okular
aacid committed R223:f0a80a675f35: Recalculate forms after command form changes (authored by aheinecke).
Recalculate forms after command form changes
Wed, Feb 21, 11:19 PM
aacid committed R223:5f05e4a1fcce: Add autotest for AFSimple_Calculate script (authored by aheinecke).
Add autotest for AFSimple_Calculate script
Wed, Feb 21, 11:19 PM
aacid closed D10547: Recalculate forms after command form changes.
Wed, Feb 21, 11:19 PM · Okular
aacid closed D10050: [PATCH 4/4] Add autotest for AFSimple_Calculate script.
Wed, Feb 21, 11:19 PM · Okular
aacid committed R223:d50c06df2590: Add refresh widgets if underlying field changes (authored by aheinecke).
Add refresh widgets if underlying field changes
Wed, Feb 21, 11:19 PM
aacid committed R223:cead2bbef3c2: Add initial support for built-in javascript functs (authored by aheinecke).
Add initial support for built-in javascript functs
Wed, Feb 21, 11:19 PM
aacid closed D10049: [PATCH 3/4] Add initial support for built-in javascript functs.
Wed, Feb 21, 11:19 PM · Okular
aacid closed D10048: [PATCH 2/4] Add refresh widgets if underlying field changes.
Wed, Feb 21, 11:19 PM · Okular
aacid committed R223:d3a549ca258e: Add JavaScript Event Object handling (authored by aheinecke).
Add JavaScript Event Object handling
Wed, Feb 21, 11:18 PM
aacid closed D10073: [PATCH 1/4] Add JavaScript Event Object handling.
Wed, Feb 21, 11:18 PM · Okular
aacid accepted D10547: Recalculate forms after command form changes.
Wed, Feb 21, 11:18 PM · Okular
aacid accepted D10050: [PATCH 4/4] Add autotest for AFSimple_Calculate script.
Wed, Feb 21, 11:18 PM · Okular
aacid accepted D10049: [PATCH 3/4] Add initial support for built-in javascript functs.
Wed, Feb 21, 11:18 PM · Okular
aacid accepted D10048: [PATCH 2/4] Add refresh widgets if underlying field changes.
Wed, Feb 21, 11:18 PM · Okular
aacid accepted D10073: [PATCH 1/4] Add JavaScript Event Object handling.
Wed, Feb 21, 11:18 PM · Okular
aacid requested changes to D10504: Bug 288042 - Option to reset forms.

Ok, ask if you have questions :)

Wed, Feb 21, 10:48 PM · Okular
aacid committed R72:696ae6a7ae9a: Merge remote-tracking branch 'origin/Applications/17.12' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/17.12'
Wed, Feb 21, 10:41 PM
aacid committed R72:def6436d1af2: oxygen-icons.org got lost, so remove mention (authored by aacid).
oxygen-icons.org got lost, so remove mention
Wed, Feb 21, 10:41 PM
aacid requested changes to D10249: Option to exit after printing.
Wed, Feb 21, 10:25 PM · Okular
aacid added a comment to D10249: Option to exit after printing.

Have you tried running the test or did you add stuff just blindly in?

Wed, Feb 21, 10:21 PM · Okular
aacid committed R223:879f40e3a86f: Increase minimum required KF5 version (authored by aacid).
Increase minimum required KF5 version
Wed, Feb 21, 8:32 PM

Tue, Feb 20

aacid added inline comments to D10073: [PATCH 1/4] Add JavaScript Event Object handling.
Tue, Feb 20, 11:06 PM · Okular
aacid added inline comments to D10048: [PATCH 2/4] Add refresh widgets if underlying field changes.
Tue, Feb 20, 7:07 PM · Okular

Mon, Feb 19

aacid added inline comments to D10048: [PATCH 2/4] Add refresh widgets if underlying field changes.
Mon, Feb 19, 11:54 PM · Okular
aacid added inline comments to D10073: [PATCH 1/4] Add JavaScript Event Object handling.
Mon, Feb 19, 11:40 PM · Okular
aacid added a comment to D10547: Recalculate forms after command form changes.

can you add an autotest for this?

Mon, Feb 19, 11:32 PM · Okular
aacid added inline comments to D10668: Fix PowerDevil shortcuts migration.
Mon, Feb 19, 11:21 PM · Plasma
aacid committed R883:1510998: remove stale pot.
remove stale pot
Mon, Feb 19, 9:07 PM
aacid committed R883:1510997: po without pot.
po without pot
Mon, Feb 19, 9:05 PM
aacid committed R883:1510996: plasma-browser-integration has no stable branch.
plasma-browser-integration has no stable branch
Mon, Feb 19, 8:40 PM
aacid committed R883:1510995: remove po without pot.
remove po without pot
Mon, Feb 19, 8:39 PM
aacid committed R263:7bf93c32ad1e: Improve KSwitchLanguageDialogPrivate::fillApplicationLanguages (authored by aacid).
Improve KSwitchLanguageDialogPrivate::fillApplicationLanguages
Mon, Feb 19, 8:36 PM
aacid closed D10445: Improve KSwitchLanguageDialogPrivate::fillApplicationLanguages.
Mon, Feb 19, 8:36 PM · Frameworks
aacid committed R265:b1e30535eca4: Improve KLanguageButton::insertLanguage when no name is passed (authored by aacid).
Improve KLanguageButton::insertLanguage when no name is passed
Mon, Feb 19, 8:35 PM
aacid closed D10444: Improve KLanguageButton::insertLanguage when no name is passed.
Mon, Feb 19, 8:35 PM · Frameworks
aacid committed R883:1510991: remove po wihtout pot.
remove po wihtout pot
Mon, Feb 19, 7:21 PM
aacid added a comment to D10455: Add RTL support for search, copy & paste in pdf.

@aacid Thanks for the feedback.

And you have a memory leak in your function as reported by

valgrind shows that the leak happen in:

makeWordFromCharacters(QList<TinyTextEntity*> const&, int, int) (textpage.cpp:1209)

which needs to be fix but not in this patch since it is irrelevant to it.

Mon, Feb 19, 8:26 AM · Okular

Sun, Feb 18

aacid committed R223:ce7fa7b9d879: Fictionbook: Add support for code, superscript, & subscript tags (authored by abogical).
Fictionbook: Add support for code, superscript, & subscript tags
Sun, Feb 18, 10:27 PM
aacid closed D10566: Fictionbook: Add support for code, superscript, & subscript tags.
Sun, Feb 18, 10:27 PM · Okular
aacid closed D10566: Fictionbook: Add support for code, superscript, & subscript tags.
Sun, Feb 18, 10:27 PM · Okular
aacid added a comment to D10504: Bug 288042 - Option to reset forms.

Do you plan to work on the autotest?

Sun, Feb 18, 10:19 PM · Okular
aacid added a comment to D10455: Add RTL support for search, copy & paste in pdf.

@aacid any feedback?

Sun, Feb 18, 10:18 PM · Okular
aacid committed R223:7014e86f6831: tests: Use QTRY_COMPARE instead manual timer (authored by aacid).
tests: Use QTRY_COMPARE instead manual timer
Sun, Feb 18, 10:17 PM
aacid added a comment to D10566: Fictionbook: Add support for code, superscript, & subscript tags.

is your surname really "A." ?

Sun, Feb 18, 10:04 PM · Okular
aacid updated subscribers of D10186: Added a feautre to execute the next task after the previous one finishes..

@kde-doc-english Do you think we should update doc/index.docbook to include the new option and give it some more "in depth" explanation, like "if you have a loop and consecutive", the consective is not run until loop is removed?

Sun, Feb 18, 9:28 PM · KDE Applications
aacid added a comment to D10566: Fictionbook: Add support for code, superscript, & subscript tags.

We're going to need your name before being able to commit this.

Sun, Feb 18, 9:24 PM · Okular
aacid accepted D10566: Fictionbook: Add support for code, superscript, & subscript tags.

Looks reasonable.

Sun, Feb 18, 9:21 PM · Okular
aacid added a comment to D10566: Fictionbook: Add support for code, superscript, & subscript tags.

Just a question, what tools does the KDE developers use for linting the formatting of their code?

Sun, Feb 18, 9:15 PM · Okular
aacid committed R883:1510938: Another gone pot.
Another gone pot
Sun, Feb 18, 6:41 PM
aacid committed R883:1510937: more removed pots.
more removed pots
Sun, Feb 18, 6:39 PM
aacid committed R883:1510936: Remove obsolet po[t]s.
Remove obsolet po[t]s
Sun, Feb 18, 6:34 PM
aacid committed R883:1510934: po files gone.
po files gone
Sun, Feb 18, 6:29 PM
aacid committed R223:54c741844b76: Fix realDpi function for Mac (authored by sbragin).
Fix realDpi function for Mac
Sun, Feb 18, 6:23 PM
aacid closed D10415: Fix realDpi function for Mac.
Sun, Feb 18, 6:22 PM · Okular
aacid closed D10415: Fix realDpi function for Mac.
Sun, Feb 18, 6:22 PM · Okular
aacid added a comment to D10415: Fix realDpi function for Mac.

So should i commit this or is there a better patch coming? (yes, i didn't really read all those posts)

Sun, Feb 18, 6:06 PM · Okular

Thu, Feb 15

aacid committed R883:1510771: Forgot to remove this a while ago.
Forgot to remove this a while ago
Thu, Feb 15, 11:32 PM
aacid committed R883:1510770: No more kamoso stable for the moment.
No more kamoso stable for the moment
Thu, Feb 15, 11:31 PM
aacid committed R247:c494e7d23a0b: No stable kamoso branch for the moment (authored by aacid).
No stable kamoso branch for the moment
Thu, Feb 15, 11:29 PM
aacid committed R883:1510766: simpler playground-devtools_ rules.
simpler playground-devtools_ rules
Thu, Feb 15, 11:07 PM
aacid added a comment to T6858: Falkon Translations.

The problem is where to put them, create a new folder just for them? The problem i see with that is that once you've opened the can you can't just say "just for Falkon" or just for es_MX but not for es_AR, which i'm not sure we have the manpower to maintain, what happens when es_AR has a very old translation that is at 5% and "regular" es is at 100%? Sure some words may not be of common use in the _AR variant but you'd really prefer a 100% of not so common words oover a 5% of common words.

Thu, Feb 15, 11:03 PM · Falkon
aacid committed R223:739b591e25cd: Merge remote-tracking branch 'origin/Applications/17.12' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/17.12'
Thu, Feb 15, 9:16 AM

Wed, Feb 14

aacid committed R119:1948f21bf58a: Merge remote-tracking branch 'origin/Plasma/5.12' (authored by aacid).
Merge remote-tracking branch 'origin/Plasma/5.12'
Wed, Feb 14, 11:55 PM
aacid committed R119:2b098f69d354: Workaround the touchpad toggle button not working (authored by aacid).
Workaround the touchpad toggle button not working
Wed, Feb 14, 11:52 PM
aacid closed D10498: Workaround the touchpad toggle button not working.
Wed, Feb 14, 11:52 PM · Plasma
aacid committed R883:1510722: Moved to git.
Moved to git
Wed, Feb 14, 11:34 PM
aacid committed R497:a40e34b9e454: kamoso for KDE Applications 18.04 (authored by aacid).
kamoso for KDE Applications 18.04
Wed, Feb 14, 7:22 PM
aacid requested changes to D10504: Bug 288042 - Option to reset forms.
Wed, Feb 14, 7:05 PM · Okular
aacid added a comment to D10504: Bug 288042 - Option to reset forms.

Same as I asked Gilbert in reviewboard.

Wed, Feb 14, 7:05 PM · Okular
aacid committed R223:83374b97df10: PDF: Fix potential crash (authored by aacid).
PDF: Fix potential crash
Wed, Feb 14, 4:51 PM
aacid committed R223:e8d9feed70d7: Fix potential crash in document saving (authored by aacid).
Fix potential crash in document saving
Wed, Feb 14, 4:51 PM
aacid committed R223:5efba743cc4f: Merge remote-tracking branch 'origin/Applications/17.12' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/17.12'
Wed, Feb 14, 12:41 AM
aacid committed R223:42d4710198a7: XPS: Fix crash opening some files (authored by aacid).
XPS: Fix crash opening some files
Wed, Feb 14, 12:41 AM
aacid added a comment to D10498: Workaround the touchpad toggle button not working.

I updated the comment, can you have a look and approve again?

Wed, Feb 14, 12:20 AM · Plasma
aacid updated the diff for D10498: Workaround the touchpad toggle button not working.

better? explanation of why the workaround works

Wed, Feb 14, 12:19 AM · Plasma
aacid updated the diff for D10498: Workaround the touchpad toggle button not working.

correct diff against Plasma/5.12

Wed, Feb 14, 12:12 AM · Plasma
aacid updated the diff for D10498: Workaround the touchpad toggle button not working.

[try to] add BUGS:

Wed, Feb 14, 12:10 AM · Plasma
aacid added reviewers for D10498: Workaround the touchpad toggle button not working: davidedmundson, xuetianweng.
Wed, Feb 14, 12:06 AM · Plasma
aacid added a comment to D3829: [touchpad] Use a separate X11 Display to monitor the XInput event..

My proposal to fix the bug at https://phabricator.kde.org/D10498

Wed, Feb 14, 12:05 AM · Plasma
aacid requested review of D10498: Workaround the touchpad toggle button not working.
Wed, Feb 14, 12:03 AM · Plasma

Tue, Feb 13

aacid added inline comments to D10048: [PATCH 2/4] Add refresh widgets if underlying field changes.
Tue, Feb 13, 8:37 AM · Okular

Mon, Feb 12

aacid added a comment to D10048: [PATCH 2/4] Add refresh widgets if underlying field changes.

Haven't had time to try myself, but how all this works with undo/redo? Does stuff break or does it work nice?

Mon, Feb 12, 11:22 PM · Okular
aacid updated the diff for D10444: Improve KLanguageButton::insertLanguage when no name is passed.

fix suggestion by Aleix

Mon, Feb 12, 10:12 PM · Frameworks
aacid added inline comments to D10444: Improve KLanguageButton::insertLanguage when no name is passed.
Mon, Feb 12, 10:11 PM · Frameworks
aacid added a comment to D10186: Added a feautre to execute the next task after the previous one finishes..

I think i forgot about this when my hard disk crashed and burned, i'll try to have a look at it again soon if noone else beats me to it, apologies for forgetting about you.

Mon, Feb 12, 10:10 PM · KDE Applications
aacid added a comment to D10394: Replace parleys version string with KDE Applications version.

If noone disagrees i'll accept this revision in two weeks :)

Mon, Feb 12, 9:45 PM · KDE Edu
aacid committed R883:1510575: remove kdiff3 from here since we're having it again.
remove kdiff3 from here since we're having it again
Mon, Feb 12, 9:35 PM
aacid added a comment to D10455: Add RTL support for search, copy & paste in pdf.

Thanks for trying to fix this :)

Mon, Feb 12, 9:32 PM · Okular