- User Since
- Apr 19 2015, 12:29 AM (217 w, 22 h)
Thu, Jun 13
What would you think of using a different name than http://apps.kde.org.uk/ that clearly shows it's non official or a dev thing?
Wed, Jun 12
Does it make sense to use MEDIA_REWRITABLE_DVD there?
Depends, KUrl? Yes Kurl is deprecated and you should use QUrl
Tue, Jun 11
at this point i'd say that krazy warning is a bit old fashioned, but sure, won't hurt either
i got bored of reviewing before reaching 25%, sorry
Mon, Jun 10
I'm pretty sure there's people there still using KDE4 (real life scenario: my father) (almost real life scenario: i know the Limux people were planning a migration from kde4 to Plasma 5, not sure if it already happened or not though).
Sun, Jun 9
Honestly i'd prefer if we wait for 5.10 and then use QMetaObject::invokeMethod instead of QTimer::singleShot.
You're the only one that has made commits since 2016, so i'd say just commit?
I don't know if it's what you where trying to fix or not, but when running with
Please add the two suggested const and commit :)
Yes i know you've mentioned it earlier.
Code makes sense, haven't tried it though.
this doesn't get you anywhere though, at least you still have themes and the knsrc file that are needed from make install, no?
Sat, Jun 8
What's the problem with make install? it's literally 1 line
Personally i don't see how this helps at all, but other apps are doing it, so if you're sure it really works you can count my vote as -0
You have a memory leak and some other things like the warnings, but i'll fix them myself and commit.
Fri, Jun 7
A little of both?
@ngraham what is being requested is using existing code that does this instead of reinveinting the wheel.
Thu, Jun 6
Ahhhh, yes, the everyone does it wrong except me reasoning.
But we're setting the menu here no?
I don't know why you say "it's a more common way", kmail does exactly what okular did, thus, being consistent.
wow Not even one minute to review things
*Do not change the shortcuts*
Sun, Jun 2
The diff shown here is wrong. We want the diff from your branch against master, not the last change in your branch against itself
You really need to remove all the mentions of page you're adding, this is geometry that has nothing to do with pages.
just commit and try it
Sat, Jun 1
right, see https://cgit.kde.org/ktuberling.git/commit/?id=10d753fce6718a147f0095d2274515bf96078292 for inspiration
Nice work in general, some little things i found.
Wed, May 29
Actually no, this is not all good.
ther'es some small things as not compating against "" but using isEmpty, but i'll fix that myself when commititng
Tue, May 28
Mon, May 27
Sun, May 26
Sat, May 25
I haven't tested it and haven't tried understanding the code farther than "this is a bunch of painting code".
Honestly i don't think documenting things at this low level makes sense, it'll break because people will never remember to update comments even if it's just on the line above the code they are changing.