- User Since
- Apr 19 2015, 12:29 AM (234 w, 6 d)
Thu, Oct 17
-Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -fno-exceptions are added by default by ecm so it's not that even we need to list them here.
Tue, Oct 15
Mon, Oct 14
Sun, Oct 13
I've pushed this to git.
The code is too C++-y to me, but it works :D
Do we have tests for the thing you discovered breaks? Do we need them?
Sat, Oct 12
If we're going to make the kolfprivate library to be static, which kind of makes sense since we don't install the includes anyway
This is wrong, these classes are part of a public library, they need the symbols to be exported
Looks good, maybe i can even convince you to make fatalErrors and remainingErrors const?
If the KDE Frameworks developers have agreed to a common style, then yes, naming it KDE Frameworks style makes sense :)
common KDE style file
Meh, just realized this patch is useless since we end up passing the quint variable to formatSingleDuration that passes it to QObject::tr and that one only supports int, so at some point there's a potential loss of range anyway
Fri, Oct 11
Thu, Oct 10
Same as in the other one, seens sensible, but not testing it is scary.
This looks fine, but your totally untested makes me a bit nervous.
Wed, Oct 9
Tue, Oct 8
We did rewrite the internals quite a bit since this, @joaonetto is the one that could tell us what needs changing for this to make sense too
Mon, Oct 7
ok, fair enough.
I've not much idea about craft, but this seems like a no brainer, so landing it :)
not really convinced about projectDir+poBaseDir thought.
Can you please close this then?
Sun, Oct 6
Sat, Oct 5
Fri, Oct 4
Ok, i'll commit it then :)