- User Since
- Apr 19 2015, 12:29 AM (173 w, 3 d)
Personally i would include (and use) a fake translation as part of the tests and then it would just evaluate to the actual result, i.e.
QCOMPARE(format.formatSpelloutDuration(3610000), QStringLiteral("1 hour(s)"));
would end up being
QCOMPARE(format.formatSpelloutDuration(3610000), QStringLiteral("1 hour"));
because we're using the "fake" translation.
Honestly i think that test in kformattest is wrong and that it should contain it's own small minitranslation so that stuff works fine and then it should be
Looks good, to me, since it seems to me you're serious in being a KDE Developer, i think you should get a Developer account
I made https://phabricator.kde.org/D14820 (you need latest branch since i did a change to make the sorting at least stable in the config dialog) which doesn't need changing the API, which i think it's better since it won't break plugins that may exist outside the okular repository.
Mon, Aug 13
Maybe Ctrl+Shift instead of Ctrl+Alt?
This seems very corner casey and i'm afraid we may be adding too much menu entries, but ok.
Yes he can.
add small comment
Doesn't setting the locale to en solve the same problem without needing to change ECM?
Sat, Aug 11
Do you think you could work on an autotest for this?
i'm not very happy with m_remainingTeaTime as a variable name, because to me it doesn't say "this is only for when it's paused", maybe m_pausedRemainingTeaTime?
looks good, if you can please add const to all those variables.
Looks good to me, if you want, maybe it makes sense to put
Isn't this actually bad for the privacy goal? AFAIK some apps will just write the password in cleartext in a config file when kwallet is not present.
Thu, Aug 9
What to link https://www.kde.org/applications/development/lokalize/ ?
Wed, Aug 8
Looks good :)
Tue, Aug 7
Mon, Aug 6
Sun, Aug 5
As far as i can see none of these headers get installed so should they all be renamed to _p.h ?
Simon what do you think about this?
Fri, Aug 3
Thu, Aug 2
As I am arguing in the other review, let's install the files in a nicer place? We control were we install them, no?
Ok, second option, we are actually installing these files ourselves, right?
Wed, Aug 1
you still need to merge 5.13 to master because eventually someone will, it's the trouble with cherry-picking.
Is there a way we can get /../qt-reserved-files/share/ in a more natural way? fishing up to .. feels always like it'll break
Tue, Jul 31
Do i understand it correctly that we only remove the file on
Aleix means https://phabricator.kde.org/D14508
Maybe it makes more sense to replace it with the magic words?
Mon, Jul 30
Sun, Jul 29
I would feel more safe if you initialized m_cursorSelectionStart and m_cursorSelectionEnd to 0 in the constructor
Sat, Jul 28
This makes it a bit better so i will commit it, but it is still not as good as it could/should be. See https://i.imgur.com/HDn9QIX.png
Are we sure this won't break something else?
I'm not going to pretend that i had time to read and understand the code, but if you think it's better and you'll fix any bugs that it may introduce, just go ahead and commit it :)
Thu, Jul 26
Does this really make a difference?
Tue, Jul 24
Should the state of the action be remembered between runs?
If it works, sure let's go for it.
Mon, Jul 23
I may be available on Sunday.
Sat, Jul 21
What is a "Deleted file"? A file that did exist and does not exist anymore?
I think this is fine, if we let people zoom on the top area, we should let people zoom on the zoom one, but i agree with Safa this is not the actual fix for bug 375251