aacid (Albert Astals Cid)
Engineering

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 19 2015, 12:29 AM (157 w, 5 d)
Availability
Available

Recent Activity

Wed, Apr 25

aacid updated subscribers of D12067: [Okular Part] Add "Print" action.

@dfaure David, what is correct, should the part or the shell provide the print action?

Wed, Apr 25, 8:27 PM · Okular
aacid added a comment to D12513: CVE-2018-10361: privilege escalation.

Any reason you guys decided to not involve security@kde.org ?

Wed, Apr 25, 8:23 PM · Frameworks, Kate

Tue, Apr 24

aacid committed R223:9d64765c213b: Use QFile::encodeName instead of toLocal8Bit (authored by aacid).
Use QFile::encodeName instead of toLocal8Bit
Tue, Apr 24, 5:45 PM
aacid added a comment to D10792: Raise annotation window when clicking on annotation.

When double clicking an already open annotation, we bring it to front, but it doesn't get keyboard focus (the text cursos doesn't blink), which is a different behaviour from when the annocation is closed.

Tue, Apr 24, 10:08 AM · Okular
aacid committed R223:1ab8dd7c620c: Fix autotest build if poppler is not installed (authored by aacid).
Fix autotest build if poppler is not installed
Tue, Apr 24, 9:59 AM
aacid abandoned D10504: Bug 288042 - Option to reset forms.
Tue, Apr 24, 9:39 AM · Okular
aacid commandeered D10504: Bug 288042 - Option to reset forms.
Tue, Apr 24, 9:39 AM · Okular
aacid committed R119:6bc448a8ea7d: Add a hidden config option for showing icons on the root level of the menu (authored by aacid).
Add a hidden config option for showing icons on the root level of the menu
Tue, Apr 24, 7:09 AM
aacid closed D12063: Add a hidden config option for showing icons on the root level of the menu.
Tue, Apr 24, 7:09 AM · Plasma

Mon, Apr 23

aacid added a comment to D11609: Add support for chained / next actions.

Are you sure you need s_doNotDeleteLinks ? I mean the links where deleting in resolveMediaLinks doesn't look like they can be nextActions, since it's the Opening/Closing/Activation actions we're resolving on

void PDFGenerator::resolveMediaLinkReferences( Okular::Page *page )

no?

Mon, Apr 23, 10:22 PM · Okular
aacid committed R223:7eb72911f8f1: Add test for visibility changes (authored by aheinecke).
Add test for visibility changes
Mon, Apr 23, 9:58 PM
aacid closed D11597: Add test for visibility changes.
Mon, Apr 23, 9:58 PM · Okular
aacid accepted D11597: Add test for visibility changes.

ok

Mon, Apr 23, 9:58 PM · Okular
aacid committed R223:bf90867c13ed: Add support for dynamic visibility (authored by aheinecke).
Add support for dynamic visibility
Mon, Apr 23, 9:55 PM
aacid closed D11596: Add support for dynamic visibility.
Mon, Apr 23, 9:55 PM · Okular
aacid accepted D11596: Add support for dynamic visibility.

ok, i guess

Mon, Apr 23, 9:55 PM · Okular
aacid committed R223:b3f8b51b3932: Merge remote-tracking branch 'origin/Applications/18.04' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/18.04'
Mon, Apr 23, 9:09 PM
aacid committed R223:991eb0ed3125: Use toLocal8Bit instead of toUtf8 (authored by aacid).
Use toLocal8Bit instead of toUtf8
Mon, Apr 23, 9:09 PM
aacid committed R223:c5592689874f: Obey umask rules when saving new file (authored by chinmoyr).
Obey umask rules when saving new file
Mon, Apr 23, 9:09 PM
aacid closed D12049: Obey umask rules when saving new file.
Mon, Apr 23, 9:09 PM · Okular
aacid accepted D12049: Obey umask rules when saving new file.

I'll land it

Mon, Apr 23, 9:07 PM · Okular
aacid added a comment to D10932: [Okular] Option to reset forms.

+1 for keeping this open and refining the behavior rather than abandoning it.

Mon, Apr 23, 8:57 PM · Okular
aacid added a comment to D10932: [Okular] Option to reset forms.

FWIW, Foxit Reader does have a Reset Form button, which upon clicking shows a dialog asking "This option will reset all form fields to their default values. You may lose some data. Are you sure?".

Let me know if you have specific example documents I should test this applications with, to see how they solved some of the more complicated aspects.

Mon, Apr 23, 8:56 PM · Okular
aacid added a reviewer for D12415: Use Freecell Solver for FreeCell and Simple Simon: fabiank.

Do you have a game number we can use to compare how this is better than the existing code?

Mon, Apr 23, 8:45 PM · KDE Games
aacid committed R410:fee560f0582e: Refactor the Solver class (authored by fabiank).
Refactor the Solver class
Mon, Apr 23, 8:38 PM
aacid closed D11815: Refactor the Solver class.
Mon, Apr 23, 8:38 PM
aacid accepted D11815: Refactor the Solver class.

Ok, i guess, after all you're the maintainer now so i shouldn't be blocking your changes ;)

Mon, Apr 23, 8:35 PM
aacid committed R410:33dd1f273bef: Getting rid of macros and dead code: (authored by fabiank).
Getting rid of macros and dead code:
Mon, Apr 23, 8:32 PM
aacid closed D11814: Getting rid of macros and dead code:.
Mon, Apr 23, 8:32 PM
aacid accepted D11814: Getting rid of macros and dead code:.

Ok

Mon, Apr 23, 8:28 PM
aacid committed R119:b8762edefd04: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default… (authored by aacid).
Kicker: Make menus grow (to a limit) if the text doesn't fit on the default…
Mon, Apr 23, 7:19 AM
aacid closed D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width.
Mon, Apr 23, 7:19 AM · Plasma

Sun, Apr 22

aacid committed R223:33a2eaf3c4bc: Merge remote-tracking branch 'origin/Applications/18.04' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/18.04'
Sun, Apr 22, 5:46 PM
aacid committed R223:3cea7c9927f0: Fix crash on exit when having edited a text area (authored by aacid).
Fix crash on exit when having edited a text area
Sun, Apr 22, 5:46 PM
aacid added inline comments to D8074: [PATCH 3/3] More tests for Timer.
Sun, Apr 22, 4:48 PM
aacid committed R883:1514450: simplify Applications/18.04 regexps.
simplify Applications/18.04 regexps
Sun, Apr 22, 4:06 PM

Sat, Apr 21

aacid committed R244:476ab8242cd2: Fix pedantic warnings (authored by aacid).
Fix pedantic warnings
Sat, Apr 21, 12:01 AM

Fri, Apr 20

aacid added a comment to D12251: Integrate with androiddeployqt dependencies files.

threre's not so many unneded stuff in there to be honest, maybe kross, kate and the emoticonthemes, but doesn't seem terrible. One would improve that by not depending on the whole kf5umbrella probably?

Fri, Apr 20, 5:49 PM · Frameworks
aacid added a comment to T8553: Improve review side panel.

"Fix Page and Author tree elements are collapsed at every change of page when "Show revisions for current page only" is selected" is probably the same root cause as " Do not collapse tree elements when adding a new annotation". The proxymodels are not very well coded, basically rebuildIndexes does resetModel all the time, which is very bad.

Fri, Apr 20, 5:45 PM · Okular
aacid committed R223:cbc6f671e35c: Change annotation type name when an annotation is associated to non-empty popup (authored by simgunz).
Change annotation type name when an annotation is associated to non-empty popup
Fri, Apr 20, 5:45 PM
aacid closed D10797: Add asterisk when an annotation is associated to non-empty popup.
Fri, Apr 20, 5:44 PM · Okular
aacid accepted D10797: Add asterisk when an annotation is associated to non-empty popup.

For symmetry i will add the disconnect line in the setSourceModel, i'm not even sure we even use that if codepath but it's nice to be symmetric

Fri, Apr 20, 5:37 PM · Okular
aacid added a comment to D12137: Use consistent spacing and units for suffixes in spinboxes.

yeah i think that's easier to understand

Fri, Apr 20, 5:35 PM · Localization, Plasma

Thu, Apr 19

aacid added a comment to D12353: [API dox] New UI marker @item:valuesuffix.

All the other elements of that list have an entry like

Thu, Apr 19, 7:31 PM · Frameworks
aacid committed R575:975b1b764844: Okular 1.4 is out! (authored by aacid).
Okular 1.4 is out!
Thu, Apr 19, 6:15 PM
aacid committed R883:1514310: typos -= 2.
typos -= 2
Thu, Apr 19, 5:03 PM

Wed, Apr 18

aacid accepted D12299: Android: include metadata for okular kirigami.

I'm a bit unhappy about the icon duplication, but that's life i guess :/

Wed, Apr 18, 8:22 PM · Okular
aacid added inline comments to D12251: Integrate with androiddeployqt dependencies files.
Wed, Apr 18, 8:19 PM · Frameworks
aacid added a comment to D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width.
In D12171#248840, @hein wrote:

Personally I sort of, well, hate this and it was a very conscious design decision to make the menu widths uniform, so I'd like some more VDG opinions to convince me otherwise first.

Wed, Apr 18, 8:13 PM · Plasma

Tue, Apr 17

aacid added a comment to D10932: [Okular] Option to reset forms.

Sorry for the late answer.

Tue, Apr 17, 11:10 PM · Okular
aacid added inline comments to D11609: Add support for chained / next actions.
Tue, Apr 17, 7:37 AM · Okular

Mon, Apr 16

aacid committed R223:47836646d76b: Merge remote-tracking branch 'origin/Applications/18.04' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/18.04'
Mon, Apr 16, 10:39 PM
aacid committed R223:6a2ed4f3144b: [Okular] Bug 387282: Highlighting of search results lost when rotating page (authored by ahmadosama).
[Okular] Bug 387282: Highlighting of search results lost when rotating page
Mon, Apr 16, 10:39 PM
aacid closed D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page.
Mon, Apr 16, 10:39 PM · Okular
aacid accepted D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page.

Looks like it works, i'll commit in a minute (with a small improvement from my side).

Mon, Apr 16, 10:37 PM · Okular
aacid added inline comments to D11596: Add support for dynamic visibility.
Mon, Apr 16, 9:41 PM · Okular
aacid added inline comments to D10792: Raise annotation window when clicking on annotation.
Mon, Apr 16, 9:02 PM · Okular
aacid committed R223:c325b342f316: Make some frameworks optional so okular can be built on Android (authored by apol).
Make some frameworks optional so okular can be built on Android
Mon, Apr 16, 9:00 PM
aacid closed D12177: Make some frameworks optional so okular can be built on Android.
Mon, Apr 16, 9:00 PM · Okular
aacid accepted D12177: Make some frameworks optional so okular can be built on Android.

I'll push it, i've fixed the removal of the #if 0 in scripter.cpp

Mon, Apr 16, 8:41 PM · Okular
aacid added a comment to D12250: Install okularpart with the rest of kparts.

I honestly don't see the need to install stuff in a non standard folder.

Mon, Apr 16, 8:15 PM · Okular
aacid requested changes to D12251: Integrate with androiddeployqt dependencies files.
Mon, Apr 16, 4:48 PM · Frameworks
aacid added a comment to D12251: Integrate with androiddeployqt dependencies files.

I'm not convinced at all parts are not in that folder.

Mon, Apr 16, 4:48 PM · Frameworks
aacid requested changes to D12250: Install okularpart with the rest of kparts.

This doesn't seem to work

Mon, Apr 16, 4:44 PM · Okular
aacid requested changes to D12177: Make some frameworks optional so okular can be built on Android.

HAVE_KWALLET is never defined

Mon, Apr 16, 4:33 PM · Okular
aacid requested changes to D12177: Make some frameworks optional so okular can be built on Android.
Mon, Apr 16, 6:55 AM · Okular

Fri, Apr 13

aacid added a comment to D12177: Make some frameworks optional so okular can be built on Android.

This is not ok.

Fri, Apr 13, 10:50 PM · Okular
aacid added a comment to D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width.

This is how it looks now

Fri, Apr 13, 10:24 AM · Plasma
aacid requested review of D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width.
Fri, Apr 13, 10:19 AM · Plasma

Thu, Apr 12

aacid committed R497:95213d0daafc: Add kitinerary for new applications release (authored by aacid).
Add kitinerary for new applications release
Thu, Apr 12, 8:46 PM
aacid accepted D12119: Fix untranslated places panel entries.
Thu, Apr 12, 8:43 PM
aacid committed R883:1513857: remove .pot frm x-test.
remove .pot frm x-test
Thu, Apr 12, 5:26 PM
aacid added a comment to D12154: Add OARS tags to the appdata.

Hmmm, not happy with things that need to be updated manually for each release :/

Thu, Apr 12, 5:23 PM
aacid added a comment to D12137: Use consistent spacing and units for suffixes in spinboxes.

is appendix something people would understand? because for me is "the things that kills you if you're unlucky", "the end chapter of a book".

Thu, Apr 12, 5:21 PM · Localization, Plasma
aacid added a comment to T8426: Update release notes for Gwenview 18.04 release.

@mak the context is in the previous messages, but tl;dr: are the releases.release tags supposed to

I think you missed this part:

Each release tag may have a description tag as child, containing a brief description of what is new in the release. The description tag is structured as described in <description/>.

And <description> tags are translatable.

Thu, Apr 12, 5:19 PM · Gwenview
aacid added a comment to T8426: Update release notes for Gwenview 18.04 release.
In T8426#138027, @aacid wrote:

The strings in <release> tags are translatable just like all other strings in AppStream metadata files. See Krita's (for example) see how it's done: https://cgit.kde.org/krita.git/tree/krita/org.kde.krita.appdata.xml#n59

I don't understand this sentence. You mention the krita file, but it doesn't have the release tag translated? Or am i looking at the wrong thing?

The release tag is translateable in the same manner as the description tag is currently translated.

Thu, Apr 12, 5:18 PM · Gwenview
aacid added a comment to T8426: Update release notes for Gwenview 18.04 release.

To be honest

In T8426#137934, @rkflx wrote:

@ltoscano I've got a question relating to translations and AppStream metadata:

Once this is finalized, we could also add the information into Gwenview's AppStream file in a new <release> tag, which will result in all the notes showing up for users of KDE Discover and other software center apps.

Was just about to prepare patches for Gwenview, Spectacle and Dolphin, but then got doubts whether that would break the string freeze. I know that the release notes will still be translated once they are ready, but does this also apply to AppStream strings? Is <release><description> even enabled for translation?

Essentially I want to avoid showing untranslated strings in Discover… Any tips/comments?

( @aacid too ).
I have no idea. This is a first and I don't know the impact on the tooling and on the workflow (including the issues with merging from a stable branch to master).

Thu, Apr 12, 5:03 PM · Gwenview
aacid committed R883:1513856: Removed pot.
Removed pot
Thu, Apr 12, 4:55 PM
aacid committed R223:8c090da4aea0: Merge remote-tracking branch 'origin/Applications/18.04' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/18.04'
Thu, Apr 12, 4:41 PM
aacid committed R223:88faff5b3c1c: Fix crash in Kile preview mode when enabling fullscreen (authored by aacid).
Fix crash in Kile preview mode when enabling fullscreen
Thu, Apr 12, 4:41 PM
aacid added a comment to D12067: [Okular Part] Add "Print" action.

As discussed on IRC with Kai it seems more a bug in Ark since Konqueror seems to have it correctly work

Thu, Apr 12, 4:09 PM · Okular

Wed, Apr 11

aacid accepted D12038: Fix build with Qt5.11 (missing QGLFormat header w/ AvogadroLibs support).
Wed, Apr 11, 9:14 PM · KDE Edu
aacid added a comment to D12120: Check if the application androiddeployqt package has a main() symbol.

Is this going to fail on my translated nm output?

Wed, Apr 11, 9:06 PM · Build System, Frameworks
aacid committed R223:1904f7e95e68: Use KCrash (authored by aacid).
Use KCrash
Wed, Apr 11, 5:38 PM

Tue, Apr 10

aacid added a comment to D12067: [Okular Part] Add "Print" action.

Doesn't this mean that when you open okular you end up with two print actions?

Tue, Apr 10, 5:46 PM · Okular

Mon, Apr 9

aacid committed R223:b62131b7ba62: Merge remote-tracking branch 'origin/Applications/18.04' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/18.04'
Mon, Apr 9, 9:37 PM
aacid committed R223:0cb59caabbda: increase version to 1.4.x (authored by aacid).
increase version to 1.4.x
Mon, Apr 9, 9:37 PM
aacid updated the diff for D12063: Add a hidden config option for showing icons on the root level of the menu.

Update commit author to kdab.com hat

Mon, Apr 9, 9:10 AM · Plasma
aacid requested review of D12063: Add a hidden config option for showing icons on the root level of the menu.
Mon, Apr 9, 8:51 AM · Plasma
aacid added a comment to T8204: Website localisation.

I was thinking about that yesterday when i saw the script Riddell has that creates pages, i guess it would be possible, there's two issues i can think of that make it non-trivial (i think):

  • We somehow need to update pages to cross link to all the other languages pages (if we want to keep the header like language selection we have in the announcements now, i.e. the "Also Available in" https://www.kde.org/announcements/announce-applications-18.04-rc.php)
  • We need a way to segment whole pages into sensible .pot translation units. You don't want the whole page to be a single .pot entry because it would mean exposing html stuff to translators, that is easy to make mistakes with, and also because if you change one word you want to "dirty" the smallest possible unit (ideally sentence, at realistically paragraph) for retranslation not the whole page.
Mon, Apr 9, 7:49 AM · Websites: WKO Migration

Sun, Apr 8

aacid updated subscribers of T8425: Simplify announcement submission.

Personally i don't really have big requirements, since i do all the releases by just copy&pasting the old releases manually. I guess i could do the same thing on the webpage.

Sun, Apr 8, 11:43 PM · Websites: WKO Migration
aacid added a comment to T8204: Website localisation.

What the translators would like is something that doesn't make them change their workflow.

Sun, Apr 8, 11:10 PM · Websites: WKO Migration
aacid committed R223:f92b2b5f4fc9: Merge remote-tracking branch 'origin/Applications/18.04' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/18.04'
Sun, Apr 8, 11:00 AM
aacid committed R223:5ea455fe6817: xps: fix file font unloading (authored by aacid).
xps: fix file font unloading
Sun, Apr 8, 11:00 AM
aacid committed R223:5bb2a5c94766: Merge remote-tracking branch 'origin/Applications/18.04' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/18.04'
Sun, Apr 8, 10:52 AM
aacid committed R223:985e06a2f572: Fix crash in some more xps files (authored by aacid).
Fix crash in some more xps files
Sun, Apr 8, 10:52 AM
aacid committed R223:3e25263d7709: Use KCrash (authored by aacid).
Use KCrash
Sun, Apr 8, 9:54 AM

Sat, Apr 7

aacid added a comment to D10797: Add asterisk when an annotation is associated to non-empty popup.

I have created a new revision D12013 by mistake. That can be deleted.

I have removed the commit with the asterisk I have added before, because when I just tried to revert it phabricator was complaining and didn't let me update the revision. Is pushing a rebased branch to the phabricator diff a bad practice (usually it is in git)?

Not really an experct in phabricator use myself, so no idea :D

Sat, Apr 7, 10:22 AM · Okular
aacid added a comment to D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page.

I tried rotating using ( const QTransform matrix = rotationMatrix() ) but it only works when rotating a page from its original orientation, this is why I modified the RotationJob::rotationMatrix in a way similar to Okular::buildRotationMatrix to allow rotating from different orientations.

Sat, Apr 7, 9:59 AM · Okular
aacid abandoned D12013: Add suffix "with comment" to annotations containing a comment.
Sat, Apr 7, 9:42 AM · Okular