aacid (Albert Astals Cid)
Engineering

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 19 2015, 12:29 AM (208 w, 6 d)
Availability
Available

Recent Activity

Today

aacid added a comment to D20677: Fix compile on arm.
In D20677#453140, @apol wrote:

LGTM, anothher fix could have been wrapping them with parenthesis?

Sat, Apr 20, 10:09 AM
aacid committed R419:802800e36356: Merge remote-tracking branch 'origin/Applications/19.04' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/19.04'
Sat, Apr 20, 10:09 AM
aacid committed R419:6c954f348802: Fix compile on arm (authored by aacid).
Fix compile on arm
Sat, Apr 20, 10:09 AM
aacid committed R419:2ab1d007cefb: Fix compile on arm (authored by aacid).
Fix compile on arm
Sat, Apr 20, 10:08 AM
aacid closed D20677: Fix compile on arm.
Sat, Apr 20, 10:08 AM
aacid added a comment to D20678: Ensure compatibility with Qt <5.10.

Thanks :)

Sat, Apr 20, 9:56 AM · Okular
aacid committed R223:6556b5494e47: Merge remote-tracking branch 'origin/Applications/19.04' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/19.04'
Sat, Apr 20, 9:56 AM
aacid committed R223:29ac9b2302d4: Fix build with Qt <5.10 (authored by awilcox).
Fix build with Qt <5.10
Sat, Apr 20, 9:56 AM
aacid closed D20678: Ensure compatibility with Qt <5.10.
Sat, Apr 20, 9:56 AM · Okular
aacid accepted D20678: Ensure compatibility with Qt <5.10.
Sat, Apr 20, 9:56 AM · Okular
aacid committed R436:919dc0e09b87: Merge remote-tracking branch 'origin/Applications/19.04' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/19.04'
Sat, Apr 20, 9:34 AM
aacid committed R436:8491d4320a13: Do not assume framebuffer and scalines are always 32-bit aligned (authored by luc4).
Do not assume framebuffer and scalines are always 32-bit aligned
Sat, Apr 20, 9:33 AM
aacid closed D20123: Do not assume framebuffer and scalines are always 32-bit aligned.
Sat, Apr 20, 9:33 AM

Thu, Apr 18

aacid requested review of D20677: Fix compile on arm.
Thu, Apr 18, 11:06 PM
aacid added a comment to T10812: KDE Applications.

If you're suggesting that Kubuntu could change their versioning scheme, that's a tacit admission that you do think there's a problem (otherwise there would be no suggestion of a proposed change or solution). It's a problem from a user perspective for just the reason I gave: users confuse our app versions with Ubuntu's own version numbers. "Confused users" is a problem. I agree that it's not a huge issue but I think it is an issue. Maybe it's not worth fixing. But it's an issue.

Thu, Apr 18, 9:30 PM
aacid added a comment to T10812: KDE Applications.

Apps that are in the bundle have inconsistent versioning; most use the bundle's own versioning scheme, but others use their own

Thu, Apr 18, 8:21 PM
aacid committed R243:09f8083d8301: Fix invalid memory write on malformed tar files (authored by aacid).
Fix invalid memory write on malformed tar files
Thu, Apr 18, 7:08 AM
aacid closed D20643: Fix invalid memory write on malformed tar files.
Thu, Apr 18, 7:08 AM · Frameworks

Wed, Apr 17

aacid committed R243:90462cdbe3a5: Fix memory leak when reading some tar files (authored by aacid).
Fix memory leak when reading some tar files
Wed, Apr 17, 10:25 PM
aacid closed D20644: Fix memory leak when reading some tar files.
Wed, Apr 17, 10:25 PM · Frameworks
aacid added inline comments to D20643: Fix invalid memory write on malformed tar files.
Wed, Apr 17, 10:24 PM · Frameworks
aacid committed R243:8d72247daeb3: Fix uninitialized memory use when reading malformed tar files (authored by aacid).
Fix uninitialized memory use when reading malformed tar files
Wed, Apr 17, 10:21 PM
aacid closed D20641: Fix uninitialized memory use when reading malformed tar files.
Wed, Apr 17, 10:21 PM · Frameworks
aacid added a comment to D20641: Fix uninitialized memory use when reading malformed tar files.
In D20641#452130, @apol wrote:

Should maybe warn if it fails?

Wed, Apr 17, 10:21 PM · Frameworks
aacid requested review of D20644: Fix memory leak when reading some tar files.
Wed, Apr 17, 6:54 PM · Frameworks
aacid requested review of D20643: Fix invalid memory write on malformed tar files.
Wed, Apr 17, 6:52 PM · Frameworks
aacid updated subscribers of D20615: bitset: Add bit number to tooltip.

Christoph, what do you think?

Wed, Apr 17, 6:32 PM
aacid committed R287:6fea48c4eea0: xcf: Fix uninitialized memory use on broken documents (authored by aacid).
xcf: Fix uninitialized memory use on broken documents
Wed, Apr 17, 6:10 PM
aacid committed R287:aaa285a3b977: xcf: layer is const in copy and merge, mark it as such (authored by aacid).
xcf: layer is const in copy and merge, mark it as such
Wed, Apr 17, 6:07 PM
aacid committed R287:645daec1ef2e: ras: Don't overread input on malformed files (authored by aacid).
ras: Don't overread input on malformed files
Wed, Apr 17, 6:07 PM
aacid committed R287:26b796f67d0a: const & is a bit faster here (authored by aacid).
const & is a bit faster here
Wed, Apr 17, 6:07 PM
aacid committed R287:35e64c44d884: No & is a bit faster here (authored by aacid).
No & is a bit faster here
Wed, Apr 17, 6:07 PM
aacid committed R287:4692a34a1cc8: QStringLiteral is a bit faster here (authored by aacid).
QStringLiteral is a bit faster here
Wed, Apr 17, 6:07 PM
aacid requested review of D20641: Fix uninitialized memory use when reading malformed tar files.
Wed, Apr 17, 5:51 PM · Frameworks
aacid added a comment to D20615: bitset: Add bit number to tooltip.

Does this hide the existing "Click on a Bit to toggle it." tooltip?

Wed, Apr 17, 5:29 PM

Tue, Apr 16

aacid committed R296:ab7e3b607274: KeySequenceHelperPrivate::updateShortcutDisplay: Don't show english text to the… (authored by aacid).
KeySequenceHelperPrivate::updateShortcutDisplay: Don't show english text to the…
Tue, Apr 16, 10:32 PM
aacid closed D20616: KeySequenceHelperPrivate::updateShortcutDisplay: Don't show english text to the user.
Tue, Apr 16, 10:32 PM · Frameworks
aacid committed R278:05f5379c24a5: Document that modToStringUser and stringUserToMod only deal with english strings (authored by aacid).
Document that modToStringUser and stringUserToMod only deal with english strings
Tue, Apr 16, 10:20 PM
aacid requested review of D20616: KeySequenceHelperPrivate::updateShortcutDisplay: Don't show english text to the user.
Tue, Apr 16, 10:12 PM · Frameworks
aacid committed R263:1b49ea4d3154: KKeySequenceWidget: Don't show English strings to the user (authored by aacid).
KKeySequenceWidget: Don't show English strings to the user
Tue, Apr 16, 10:07 PM
aacid closed D20614: KKeySequenceWidget: Don't show English strings to the user.
Tue, Apr 16, 10:07 PM · Frameworks
aacid closed D20613: Document that modToStringUser and stringUserToMod only deal with english strings.
Tue, Apr 16, 9:59 PM · Frameworks
aacid requested review of D20614: KKeySequenceWidget: Don't show English strings to the user.
Tue, Apr 16, 9:54 PM · Frameworks
aacid requested review of D20613: Document that modToStringUser and stringUserToMod only deal with english strings.
Tue, Apr 16, 9:44 PM · Frameworks
aacid committed R243:a027f56aa89e: Fix stack-buffer-overflow read on malformed files (authored by aacid).
Fix stack-buffer-overflow read on malformed files
Tue, Apr 16, 5:59 PM
aacid closed D20604: Fix stack-buffer-overflow read on malformed files.
Tue, Apr 16, 5:59 PM · Frameworks
aacid committed R243:084dabd35bfb: Fix null-dereference on malformed tar files (authored by aacid).
Fix null-dereference on malformed tar files
Tue, Apr 16, 5:58 PM
aacid closed D20605: Fix null-dereference on malformed tar files.
Tue, Apr 16, 5:58 PM · Frameworks
aacid requested review of D20605: Fix null-dereference on malformed tar files.
Tue, Apr 16, 4:11 PM · Frameworks
aacid requested review of D20604: Fix stack-buffer-overflow read on malformed files.
Tue, Apr 16, 4:03 PM · Frameworks
aacid committed R243:e81ec04d542a: autotests: Fix leak in karchivetest (authored by aacid).
autotests: Fix leak in karchivetest
Tue, Apr 16, 4:00 PM
aacid committed R849:01f198b31101: Chart Type: -> Aggregation: (authored by aacid).
Chart Type: -> Aggregation:
Tue, Apr 16, 1:17 PM
aacid committed R849:a98372fa29ce: Fix QAssiciativeIterable typo (authored by aacid).
Fix QAssiciativeIterable typo
Tue, Apr 16, 12:58 PM
aacid closed D20601: Fix QAssiciativeIterable typo.
Tue, Apr 16, 12:58 PM
aacid requested review of D20601: Fix QAssiciativeIterable typo.
Tue, Apr 16, 12:49 PM

Mon, Apr 15

aacid added a comment to D19563: adding multiple decays and updated isotope information H-Na.

@joergbuchwald you mentioned "work will be continued/completed in next weeks", is this still true or should this be commited?

Mon, Apr 15, 9:23 PM · KDE Edu
aacid added a comment to D20559: Fix situations like "</itemizedlist>Some text".

Do you think you could include this in the tests/lauri.xml and lauri.po?

Mon, Apr 15, 8:40 PM
aacid added a comment to T9543: Project for Fundraising.

One-off donations goes inside on the section of donations types. Where the user sees how he/she can donate.

Mon, Apr 15, 8:35 PM · Fundraising Working Group
aacid added a comment to T10636: Announcement text for the Applications 19.04 release.

@cfeck : Will this be the link you will use for the announcement?:

https://kde.org/announcements/announce-applications-19.04.0.php

Mon, Apr 15, 8:09 PM · KDE Promo, KDE Applications
aacid committed R849:2ee088d140d3: Remove return from end of void function (authored by aacid).
Remove return from end of void function
Mon, Apr 15, 7:53 AM
aacid closed D20566: Remove return from end of void function.
Mon, Apr 15, 7:53 AM
aacid committed R849:a7edffeae681: Don't capture reply in lambda if we're not using it (authored by aacid).
Don't capture reply in lambda if we're not using it
Mon, Apr 15, 7:52 AM
aacid closed D20567: Don't capture reply in lambda if we're not using it.
Mon, Apr 15, 7:52 AM
aacid requested review of D20567: Don't capture reply in lambda if we're not using it.
Mon, Apr 15, 7:41 AM
aacid added a reviewer for D20566: Remove return from end of void function: vkrause.
Mon, Apr 15, 7:41 AM
aacid requested review of D20566: Remove return from end of void function.
Mon, Apr 15, 7:40 AM

Sun, Apr 14

aacid added a comment to D18179: PDF: Implement scaling options for non-rasterized printing.

i have not tested it, if you think it works, i guess it's ok from the pure code point of view.

Sun, Apr 14, 10:33 PM · Okular
aacid committed R243:4b1927e954fb: Install krcc.h header (authored by aacid).
Install krcc.h header
Sun, Apr 14, 10:13 PM
aacid closed D20557: Install krcc.h header.
Sun, Apr 14, 10:13 PM · Frameworks
aacid updated subscribers of D20557: Install krcc.h header.
Sun, Apr 14, 8:56 PM · Frameworks
aacid requested review of D20557: Install krcc.h header.
Sun, Apr 14, 8:41 PM · Frameworks
aacid committed R243:b401e24093d8: Fix double delete on broken files (authored by aacid).
Fix double delete on broken files
Sun, Apr 14, 7:17 PM
aacid closed D20519: Fix double delete on broken files.
Sun, Apr 14, 7:14 PM · Frameworks
aacid added a comment to D20519: Fix double delete on broken files.

Any input on my "cleaner solution: return a two-field structs" suggestion?

Sun, Apr 14, 6:00 PM · Frameworks
aacid committed R323:cfc08550e884: Tell cmake eigen includes are SYSTEM ones (authored by aacid).
Tell cmake eigen includes are SYSTEM ones
Sun, Apr 14, 5:50 PM
aacid closed D20520: Tell cmake eigen includes are SYSTEM ones.
Sun, Apr 14, 5:50 PM · KDE Edu
aacid accepted D20527: Check if the filename is empty when user wants to save the file.

put it on the stable branch too?

Sun, Apr 14, 5:03 PM · KDE Edu
aacid added a comment to D20437: Make selection scrolling go at 60 fps.

It's the first time after years and dozen of contributions to dozen of projects that I see such a fuss about my internet name

@aacid if I put my relicensing preferences on the kde dev script repo, will you consider the patch?

Sun, Apr 14, 4:42 PM · Okular
aacid added a comment to D20437: Make selection scrolling go at 60 fps.

Still has a fake name attached to it?

If so i'll refrain from looking at the code and getting tainted by it.

Can you clarify how reviewing this patch would taint you?

Sun, Apr 14, 4:39 PM · Okular
aacid added a comment to D20527: Check if the filename is empty when user wants to save the file.

there's 3 more checks for "Untitled" in that file. Could you check if those need updating too?

Sun, Apr 14, 4:31 PM · KDE Edu
aacid added inline comments to D20385: Shorten the freecell solutions..
Sun, Apr 14, 4:26 PM
aacid updated the diff for D20519: Fix double delete on broken files.

update with test from dfaure + local tweak

Sun, Apr 14, 4:20 PM · Frameworks
aacid added a comment to D20519: Fix double delete on broken files.

Good catch.
I'd still prefer if such changes would come with a unittest, because it will be hard otherwise to immediately detect (while developing) that changes don't introduce any regressions.
I managed to write a unittest for this one, please integrate it into your commit:

http://www.davidfaure.fr/2019/ktar_unittest.diff

Sun, Apr 14, 4:14 PM · Frameworks
aacid committed R292:bc7495095baa: Fix l/100 km to MPG conversion (authored by madcatx).
Fix l/100 km to MPG conversion
Sun, Apr 14, 3:59 PM
aacid closed D20284: Fix l/100 km to MPG conversion.
Sun, Apr 14, 3:59 PM · Frameworks
aacid accepted D20284: Fix l/100 km to MPG conversion.
Sun, Apr 14, 3:57 PM · Frameworks

Sat, Apr 13

aacid committed R378:32bb63f7b74c: use nullptr (authored by aacid).
use nullptr
Sat, Apr 13, 11:07 PM
aacid committed R378:dd763e2f8650: make gcc happy about indentation (authored by aacid).
make gcc happy about indentation
Sat, Apr 13, 11:07 PM
aacid committed R349:580fb9e4f5ae: Merge remote-tracking branch 'origin/Applications/19.04' (authored by aacid).
Merge remote-tracking branch 'origin/Applications/19.04'
Sat, Apr 13, 10:55 PM
aacid committed R349:9197a8620a31: Add override markers to functions (authored by aacid).
Add override markers to functions
Sat, Apr 13, 10:54 PM
aacid committed R458:62e1e2d44e8f: Mark functions with override (authored by aacid).
Mark functions with override
Sat, Apr 13, 10:47 PM
aacid requested review of D20520: Tell cmake eigen includes are SYSTEM ones.
Sat, Apr 13, 10:40 PM · KDE Edu
aacid updated subscribers of D20519: Fix double delete on broken files.
Sat, Apr 13, 10:22 PM · Frameworks
aacid requested review of D20519: Fix double delete on broken files.
Sat, Apr 13, 10:21 PM · Frameworks
aacid added a comment to D20489: [KIO] Make it compile without foreach (Step 1).

hmmmm, ok, i don't know why we wouldn't want things like this to now show in the autogenerated changelog, but ok, your call :)

Sat, Apr 13, 10:05 PM · Frameworks
aacid added inline comments to D20284: Fix l/100 km to MPG conversion.
Sat, Apr 13, 9:34 PM · Frameworks
aacid accepted D20515: KCharSelect: add unittest. Hits the assert in QHeaderView..
Sat, Apr 13, 9:13 PM · Frameworks
aacid added a comment to D20489: [KIO] Make it compile without foreach (Step 1).

FYI NO_CHANGELOG doesn't have to be in the first line (which would make noise in phab review titles for new requests, etc). It can be a line of its own, for example towards the end of the commit log.

Thanks!

Sat, Apr 13, 9:12 PM · Frameworks
aacid committed R243:28a43c285edf: Disallow copy of KArchiveDirectoryPrivate and KArchivePrivate (authored by aacid).
Disallow copy of KArchiveDirectoryPrivate and KArchivePrivate
Sat, Apr 13, 10:26 AM
aacid committed R243:903a523ce5c8: "Fix" KArchive::findOrCreate running out of stack on VERY LONG paths (authored by aacid).
"Fix" KArchive::findOrCreate running out of stack on VERY LONG paths
Sat, Apr 13, 10:22 AM