rempt (Boudewijn Rempt)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 7:39 AM (196 w, 5 d)
Availability
Available

Recent Activity

Yesterday

rempt updated the summary of D18407: Port krita to use Quazip instead of KArchive, to support Zip64.
Sun, Jan 20, 3:21 PM · Krita
rempt requested review of D18407: Port krita to use Quazip instead of KArchive, to support Zip64.
Sun, Jan 20, 3:20 PM · Krita

Sat, Jan 19

rempt accepted D18336: Improve decoration display for multibrush tool.
Sat, Jan 19, 1:39 PM · Krita
rempt added a comment to D18323: Add all arrange docker actions to the shape selection tool context menu..

We should indeed remove the separate arrange docker, since it is confusing people who think they can arrange paint layers with it. I think having the options in a menu won't surprise our users much, it's quite common.

Sat, Jan 19, 1:35 PM · Krita
rempt accepted D17807: Added a QComboBox to adjust preview granularity while doing transforms.

Looks like it works fine, but I would suggest putting the comboboxes underneath each other, since the tool option widget gets quite wide now.

Sat, Jan 19, 1:34 PM · Krita

Fri, Jan 18

rempt added a comment to D18305: Python unit test and code check setup.

We're trying to deprecate the wiki in favor of the official manual; the commuunity wiki is more useful for things like sprint planning, not so much for documentation.

Fri, Jan 18, 9:27 PM · Krita

Thu, Jan 17

rempt accepted D18305: Python unit test and code check setup.

Cool! We also would need to have a page for the contributors manual explaining how to use this, though. I also think it's time for you to apply for a dev account: https://community.kde.org/Infrastructure/Get_a_Developer_Account

Thu, Jan 17, 12:17 PM · Krita
rempt committed R1012:000a5e7fec9c: Remove unneeded sys-imports in Python plugin manuals (authored by rempt).
Remove unneeded sys-imports in Python plugin manuals
Thu, Jan 17, 10:22 AM
rempt closed D17701: Remove unneeded sys-imports in Python plugin manuals.
Thu, Jan 17, 10:22 AM · Krita: Manual
rempt added a comment to D17701: Remove unneeded sys-imports in Python plugin manuals.

I actually committed this yesterday when I was going through my backlog, but forgot to push it. Done now.

Thu, Jan 17, 9:20 AM · Krita: Manual

Wed, Jan 16

rempt committed R37:d7c531273736: Also save the writings systems configuration if no writing systems are selected (authored by rempt).
Also save the writings systems configuration if no writing systems are selected
Wed, Jan 16, 10:20 AM
rempt committed R37:e5ee9c48a3fd: Catch SystemExit Exception in Scripter (authored by rempt).
Catch SystemExit Exception in Scripter
Wed, Jan 16, 9:43 AM
rempt closed D17962: Catch SystemExit Exception in Scripter (Fixes #402670).
Wed, Jan 16, 9:43 AM · Krita
rempt committed R37:f41c5474b0a6: Add the Python plugin importer (authored by rempt).
Add the Python plugin importer
Wed, Jan 16, 9:43 AM
rempt closed D18074: Feature: Python Plugin Importer.
Wed, Jan 16, 9:43 AM · Krita
rempt accepted D18074: Feature: Python Plugin Importer.
Wed, Jan 16, 9:35 AM · Krita
rempt added a comment to D15584: Final Series of IMBLEND blending modes, and including modulo modes..

I also wish I can fix hard mix photoshop, but the big issue is that the bug is on photoshop end, so I can't do anything about that.

Wed, Jan 16, 9:34 AM · Krita
rempt committed R37:75f9480b9bd1: Merge branch 'master' into rempt/T379-resource-management (authored by rempt).
Merge branch 'master' into rempt/T379-resource-management
Wed, Jan 16, 9:12 AM
rempt committed R37:e0fc68d77bde: Add stub for a gridview (authored by rempt).
Add stub for a gridview
Wed, Jan 16, 9:12 AM

Tue, Jan 15

rempt committed R37:b6393ca667b1: Begin skeleton for the proxy model (authored by rempt).
Begin skeleton for the proxy model
Tue, Jan 15, 5:14 PM
rempt committed R37:0d2f1d16e187: Do not create the move tool option widget twice (authored by rempt).
Do not create the move tool option widget twice
Tue, Jan 15, 1:52 PM
rempt committed R37:eee6d7d27d10: Do not create the tool option widgets if they have already been created (authored by rempt).
Do not create the tool option widgets if they have already been created
Tue, Jan 15, 1:52 PM
rempt committed R37:c7f71140b351: Add a Copy Translate mode to the Multibrush (authored by pavelb).
Add a Copy Translate mode to the Multibrush
Tue, Jan 15, 11:41 AM
rempt closed D18257: Multibrush "copy translate" mode.
Tue, Jan 15, 11:41 AM · Krita
rempt added a comment to D18257: Multibrush "copy translate" mode.

For the next patch, we'll have to make you get a KDE identity and developer access :-)

Tue, Jan 15, 11:40 AM · Krita
rempt committed R37:dde3d267b69a: Remove unused method "boxSpecial" (authored by rempt).
Remove unused method "boxSpecial"
Tue, Jan 15, 11:39 AM
rempt added a comment to D18257: Multibrush "copy translate" mode.

Have you got commit access? If not, I can push it for you, but I need to know your name and email address.

Tue, Jan 15, 11:16 AM · Krita
rempt accepted D18257: Multibrush "copy translate" mode.

Works fine for me, and I can access the older items as well.

Tue, Jan 15, 9:48 AM · Krita
rempt committed R37:821d7d4ecd9a: Fix compilation on compilers which do not have Atomic built-in (authored by rempt).
Fix compilation on compilers which do not have Atomic built-in
Tue, Jan 15, 9:33 AM
rempt closed D16184: Fix compilation on compilers which do not have Atomic built-in.
Tue, Jan 15, 9:33 AM · Krita
rempt added a comment to D16184: Fix compilation on compilers which do not have Atomic built-in.

Yay! It works now!

Tue, Jan 15, 9:31 AM · Krita
rempt accepted D15584: Final Series of IMBLEND blending modes, and including modulo modes..

Right... From cursory testing, every seems to work. I'm pretty sure we need to expand the names with a bit of explanation, though -- nobody is going to be able to figure out what Frect is :-)

Tue, Jan 15, 9:18 AM · Krita
rempt added a comment to D18254: [WIP] Saving Mirror Tool state to KRA.

Yes, I think you're on the right track. Don't forget to add apidox for new classes along the way :-)

Tue, Jan 15, 8:57 AM · Krita
rempt added a comment to D18074: Feature: Python Plugin Importer.

I'm all for it, but the patch doesn't apply:

Tue, Jan 15, 8:54 AM · Krita
rempt added a comment to D18257: Multibrush "copy translate" mode.

Curious... I get a build error:

Tue, Jan 15, 8:53 AM · Krita

Mon, Jan 14

rempt committed R37:8afa61149949: Fix merge error (authored by rempt).
Fix merge error
Mon, Jan 14, 12:54 PM
rempt committed R37:dff00c5462ca: Merge branch 'master' into rempt/T379-resource-management (authored by rempt).
Merge branch 'master' into rempt/T379-resource-management
Mon, Jan 14, 12:21 PM

Thu, Jan 10

rempt added a task to R37:da127c2d7964: Fix saving PSD when the image has a non-transparent background: T590: Default projection color is not saved to PSD.
Thu, Jan 10, 8:42 PM
rempt added a commit to T590: Default projection color is not saved to PSD: R37:da127c2d7964: Fix saving PSD when the image has a non-transparent background.
Thu, Jan 10, 8:42 PM · Krita: Old Dmitry's Workboard (not used anymore)
rempt added a task to R37:5a6ffe8c35d5: Add caching of the random-generator device in layer styles: Unknown Object (Maniphest Task).
Thu, Jan 10, 8:42 PM

Mon, Jan 7

rempt triaged T10283: Krita 2019 Fundraiser Head Task as Normal priority.
Mon, Jan 7, 1:15 PM · Krita
rempt added a comment to D18036: encode the old appstream id as provided by the new appstream id.

Please also push to krita/1.4 -- it looks likely we'll do another 4.1 bug fix release, probably february,.

Mon, Jan 7, 12:57 PM · Krita
rempt accepted D18036: encode the old appstream id as provided by the new appstream id.
Mon, Jan 7, 12:57 PM · Krita
rempt committed R37:7225997b8e8e: BUG:402535 Make sure the assistant does not return NaN points (authored by pavelb).
BUG:402535 Make sure the assistant does not return NaN points
Mon, Jan 7, 11:11 AM
rempt closed D18024: bugfix for krita bug 402535.
Mon, Jan 7, 11:11 AM · Krita
rempt accepted D18024: bugfix for krita bug 402535.

Oh -- have you got push access, or should we push this for you?

Mon, Jan 7, 10:59 AM · Krita
rempt added a comment to D18024: bugfix for krita bug 402535.

Right... Let's push this patch first, then fix to use qIsNanPoint (which isn't, apparently a Qt function as I originally thought, but something home-grown in the KOffice era).

Mon, Jan 7, 10:59 AM · Krita
rempt added a comment to D18024: bugfix for krita bug 402535.

Thanks for the investigation and the patch! I've got one question, though...

Mon, Jan 7, 10:28 AM · Krita
rempt added a comment to D16833: [WIP] Further Color Picker Upgrades, Fixes and Refactors..

Maybe we should also have a global action or option to enable/disable picking the alpha value. People are getting confused again...

Mon, Jan 7, 10:26 AM · Krita

Sun, Jan 6

rempt committed R37:c930a16ce7dc: FIx build (authored by rempt).
FIx build
Sun, Jan 6, 11:18 AM
rempt added a comment to T863: Gradient Dithering | NotAssigned.

This is an updated diff against krita/4.1 for the dithering work:

Sun, Jan 6, 11:14 AM · Krita: Dmitry's TODO, Krita: Abyss
rempt committed R37:d6a1aae89e16: Add information about memory, cores and swap location to the buginfo (authored by rempt).
Add information about memory, cores and swap location to the buginfo
Sun, Jan 6, 10:48 AM
rempt committed R37:b1e502e5ccf3: Add a safe assert to prevent Krita from crashing when a toolbar gets… (authored by rempt).
Add a safe assert to prevent Krita from crashing when a toolbar gets…
Sun, Jan 6, 10:33 AM
rempt added a comment to T863: Gradient Dithering | NotAssigned.

So... Does anyone remember why this wasn't merged?

Sun, Jan 6, 10:16 AM · Krita: Dmitry's TODO, Krita: Abyss
rempt committed R37:6970bfcad9bf: Restore the ui after crashing in canvasonly mode (authored by rempt).
Restore the ui after crashing in canvasonly mode
Sun, Jan 6, 9:58 AM

Sat, Jan 5

rempt added a comment to D17962: Catch SystemExit Exception in Scripter (Fixes #402670).

Eliakin, will you push this patch this time? I'm about to start travelling.

Sat, Jan 5, 1:36 PM · Krita
rempt added a comment to T9477: Organizing KDE's presence at FOSDEM 2019.

I concur with Wolthera.

Sat, Jan 5, 11:21 AM · KDE Promo

Fri, Jan 4

rempt added a comment to D17962: Catch SystemExit Exception in Scripter (Fixes #402670).

Hi Rebecca,

Fri, Jan 4, 8:44 PM · Krita

Thu, Jan 3

rempt committed R37:fcc92fe9b500: Merge branch 'master' into rempt/T379-resource-management (authored by rempt).
Merge branch 'master' into rempt/T379-resource-management
Thu, Jan 3, 4:25 PM
rempt committed R37:d59b6e6c4faa: Add skeleton gridview widget (authored by rempt).
Add skeleton gridview widget
Thu, Jan 3, 4:25 PM
rempt committed R37:91c359e1977a: Remove the old Karbon gradients (.kgr) (authored by rempt).
Remove the old Karbon gradients (.kgr)
Thu, Jan 3, 4:08 PM
rempt added a comment to D17810: Fix building against exiv2-0.27.

Argh... Maybe I just shouldn't touch code today. I hope I did it right this time...

Thu, Jan 3, 10:44 AM · Krita
rempt committed R37:2b4671f64e35: Fix the exiv2 fix... (authored by rempt).
Fix the exiv2 fix...
Thu, Jan 3, 10:44 AM
rempt committed R37:f9544dd9989a: Fix the exiv2 fix... (authored by rempt).
Fix the exiv2 fix...
Thu, Jan 3, 10:44 AM
rempt committed R37:01cecbbb0f1b: Fix iterating over exiv values (authored by rempt).
Fix iterating over exiv values
Thu, Jan 3, 10:21 AM
rempt committed R37:47c1a78a0f02: Fix iterating over exiv values (authored by rempt).
Fix iterating over exiv values
Thu, Jan 3, 10:20 AM
rempt added a comment to D17810: Fix building against exiv2-0.27.

Outch, thanks for the hint. I'll fix that.

Thu, Jan 3, 10:19 AM · Krita
rempt added a comment to D15584: Final Series of IMBLEND blending modes, and including modulo modes..

Did we already commit this?

Thu, Jan 3, 9:48 AM · Krita
rempt abandoned D17115: Fix list items.

Thanks! I see that this was committed, so I'm closing the revision.

Thu, Jan 3, 9:48 AM · Krita: Manual
rempt commandeered D17115: Fix list items.
Thu, Jan 3, 9:48 AM · Krita: Manual

Wed, Jan 2

rempt committed R37:8b8073e2e108: Remove connection to anon-existent signal (authored by rempt).
Remove connection to anon-existent signal
Wed, Jan 2, 7:41 AM

Tue, Jan 1

rempt committed R37:06dfa759f4dd: Fix building against exiv2-0.27 (authored by asturmlechner).
Fix building against exiv2-0.27
Tue, Jan 1, 12:39 PM
rempt committed R37:ed9b2ef4b583: Remove splash screen options now and always close when krita finishes loading (authored by scottpetrovic).
Remove splash screen options now and always close when krita finishes loading
Tue, Jan 1, 12:39 PM
rempt accepted D17893: Advanced Color Selector: option to hide color selector.

Thanks -- this works fine.

Tue, Jan 1, 12:08 PM · Krita

Mon, Dec 31

rempt added a comment to T9477: Organizing KDE's presence at FOSDEM 2019.

Just a note: I've somehow acquired a hernia that forces me to limit my keyboard time severely. So I have completely lost track of this task. Also, last time I started doing something, making rollups, it turned out there was no need... Is there still anything I need to do?

Mon, Dec 31, 12:49 PM · KDE Promo
rempt accepted D17853: Add a CMake option for ASAN address sanitizer.

Looks good to me, but the part about installing llvm probably should be in the README.md or some place like that.

Mon, Dec 31, 12:27 PM · Krita

Sat, Dec 29

rempt added a comment to T10235: create or identify developer style guides, namespaces.

No, there isn't anything like that, it's a mess that's been twenty years in the growing. I agree it would be good to have a styleguide, and good to change the action names to be consistent and namespaced as soon as possible, before more people start relying on the current names.

Sat, Dec 29, 11:28 AM · Krita

Fri, Dec 28

rempt accepted D17810: Fix building against exiv2-0.27.
Fri, Dec 28, 3:44 PM · Krita
rempt committed R37:543760631356: BUG:402622 Add StartupWMClass=krita to the desktop file (authored by rempt).
BUG:402622 Add StartupWMClass=krita to the desktop file
Fri, Dec 28, 3:40 PM

Thu, Dec 27

rempt added a comment to D17810: Fix building against exiv2-0.27.

Ah, yes, that's my fault...

Thu, Dec 27, 10:12 AM · Krita

Mon, Dec 24

rempt accepted D17695: overview docker: preserve aspect ratio and don't stretch when some layers are hidden.
Mon, Dec 24, 11:17 AM · Krita
rempt accepted D17701: Remove unneeded sys-imports in Python plugin manuals.
Mon, Dec 24, 11:15 AM · Krita: Manual
rempt accepted D15523: Insert new layer above selected group layer.
Mon, Dec 24, 11:09 AM · Krita

Dec 19 2018

rempt committed R37:c1b8345ea18a: Fix the Node api (authored by rempt).
Fix the Node api
Dec 19 2018, 12:56 PM
rempt accepted D17665: Partial fix for bug 401656.
Dec 19 2018, 8:56 AM · Krita

Dec 18 2018

rempt committed R37:c0d1b7d764e5: BUG:402296 Resize the HUD after adding options for the first time (authored by rempt).
BUG:402296 Resize the HUD after adding options for the first time
Dec 18 2018, 12:30 PM
rempt committed R37:659bea69a12b: BUG:402296 Resize the HUD after adding options for the first time (authored by rempt).
BUG:402296 Resize the HUD after adding options for the first time
Dec 18 2018, 12:30 PM
rempt committed R37:53fb8b407228: Make the first tab the default one again (authored by rempt).
Make the first tab the default one again
Dec 18 2018, 12:07 PM
rempt committed R37:39ae2d34133e: Remove default shortcut for the text tool (authored by rempt).
Remove default shortcut for the text tool
Dec 18 2018, 7:51 AM
rempt committed R37:226a26602449: Remove default shortcut for the text tool (authored by rempt).
Remove default shortcut for the text tool
Dec 18 2018, 7:44 AM

Dec 17 2018

rempt committed R37:df1ca1576c96: Make sure all acyclic connections are unique (authored by rempt).
Make sure all acyclic connections are unique
Dec 17 2018, 11:44 AM
rempt committed R37:903fc9092a8e: Fix a bunch of multiple connections instances (authored by rempt).
Fix a bunch of multiple connections instances
Dec 17 2018, 11:44 AM
rempt committed R37:79da3a899fe5: Fix runtime warning: layouts should not be created with a parent (authored by rempt).
Fix runtime warning: layouts should not be created with a parent
Dec 17 2018, 11:12 AM
rempt committed R37:e8e78f562988: Merge branch 'master' into rempt/T379-resource-management (authored by rempt).
Merge branch 'master' into rempt/T379-resource-management
Dec 17 2018, 11:01 AM
rempt accepted D17639: add exportConfiguration InfoObject to Node.save for predictable batchmode.
Dec 17 2018, 10:53 AM · Krita

Dec 16 2018

rempt committed R37:0b7d578960f5: debug-- (authored by rempt).
debug--
Dec 16 2018, 2:18 PM
rempt committed R37:2a5de523f1ca: Bump version (authored by rempt).
Bump version
Dec 16 2018, 12:45 PM
rempt committed R37:3829dcea6d9d: Qt-5.11.3 also has bug QTBUG-72488 (authored by rempt).
Qt-5.11.3 also has bug QTBUG-72488
Dec 16 2018, 12:42 PM
rempt committed R37:6b7ab5063051: Qt-5.11.3 also has bug QTBUG-72488 (authored by rempt).
Qt-5.11.3 also has bug QTBUG-72488
Dec 16 2018, 12:42 PM

Dec 15 2018

rempt accepted D17590: Added Fill Layer Content Option for New Documents.

Yes, I agree that that should be in a separate patch.

Dec 15 2018, 10:14 PM · Krita