leinir (Dan Leinir Turthra Jensen)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jul 8 2015, 8:34 AM (455 w, 1 d)
Availability
Available

Recent Activity

Feb 10 2023

leinir added a comment to T15135: Move KMoreTools from KNewStuff to separate lib.

Yeah, whatever else we do with KNS, KMoreTools wants its own home. The reason it lives there is just that it wasn't caught during the de-monolithifying work, and then we were kind of stuck with, so... yup :)

Feb 10 2023, 1:30 PM · KF6

Jan 27 2023

leinir added a comment to T15135: Move KMoreTools from KNewStuff to separate lib.

As long as we can still "market" KNewStuffCore as a tier 2 framework, having the three of them in the same repository is fine by me, really :) And thanks for volunteering for that one! :D

Jan 27 2023, 5:17 PM · KF6

Jan 25 2023

leinir added a comment to T15135: Move KMoreTools from KNewStuff to separate lib.

Right, so this is kind of hiding a further big one - we essentially want to split KNewStuff into four: KNewStuffCore, KNewStuffWidgets (which is what's currently called KNewStuff3), KNewStuffQuick (the Qt Quick components), and KMoreTools.

Jan 25 2023, 9:28 AM · KF6

Jan 11 2022

leinir added a comment to T15180: KNewStuff: Unify KNSCore::Engine and QuickEngine.

We couldn't do it at the time, primarily because of how some things in KNSQuick is wrapping Core things, and it'd end up terribly confusing if some things were actually the literal things from Core, and some things were things that wrapped things from Core but wasn't actually those things. Still think that that logic is fairly sound, and it's perhaps also important to note that turning EntryInternal into a QObject has some pretty wide-reaching consequences. Not that it's not something we should do, but it's not at all trivial... Mostly to warn you, making it happen would be great, but don't want you trying to dig into that without having enough headache tablets in stock ;)

Jan 11 2022, 9:48 AM · KF6

Nov 30 2021

leinir added a comment to T15055: KnewStuff: Get rid of KNS3 namespace, move widgets to their own module.

i fully support this idea, and the plan as well. It will create a bit of temporary mess, but will also massively ease the transition come KF6 time, so yes, definitely let's do this :)

Nov 30 2021, 3:14 PM · KF6

Sep 13 2021

leinir added a comment to T14635: Remove KIO dependency of KNewStuff.

It feels a lot like KMoreTools becoming its own framework really needs to happen, it's always felt out of place in KNewStuff, and it really more... parallel in functionality than anything else.

Sep 13 2021, 9:00 AM · KF6

Jun 29 2021

leinir added a comment to T14635: Remove KIO dependency of KNewStuff.

Not done yet (obviously), but i've made a start and will continue tomorrow: https://invent.kde.org/frameworks/knewstuff/-/merge_requests/132

Jun 29 2021, 4:16 PM · KF6
leinir added a comment to T14635: Remove KIO dependency of KNewStuff.

It's less a care of deprecation and more a case of replacing it (and then deprecating certain functions which will not make sense any longer when it's just a dialog that gives some information to the user and does not in fact contain the upload functionality itself). I'll do that after lunch today (which basically means shortly) and get the MR pushed soon as possible - haven't looked super close, but given the nature of the effort, i don't expect it'll be overly awkward to do. In-source documentation does sound like a good idea as well, i'll add those in as i go along :)

Jun 29 2021, 10:06 AM · KF6

Jun 25 2021

leinir added a comment to T14532: Add new categories for Cantor for documentation files.

This is indeed the expected behaviour
[...]

Ok, thanks for the explanations. I adjusted the code accordingly and everything is working now.

Jun 25 2021, 9:21 AM · KDE Store

Jun 24 2021

leinir added a comment to T14635: Remove KIO dependency of KNewStuff.

It really should be, yeah - KMoreTools feels super out of place, and i guess it was put into KNewStuff back in the kdelibs days because it was kind of a way to get some new stuff, conceptually, even if it was entirely unrelated to how the rest of the get hot new stuff system worked...

Jun 24 2021, 4:26 PM · KF6

Jun 21 2021

leinir added a comment to T14532: Add new categories for Cantor for documentation files.

@leinir I'm testing with the documentation file I uploaded for Maxima. It's a zip archive with two files inside that is unpacked upon downloading it. KSN::Entry::installedFiles() is returning

"/home/alex/.local/share/cantor/documentation/Maxima_v5.44/*"

instead of a list with two file names that I would expect

"/home/alex/.local/share/cantor/documentation/Maxima_v5.44/help.qch"
"/home/alex/.local/share/cantor/documentation/Maxima_v5.44/help.qhc"

I can work around this in the code now but is it really the correct behavior or am I rather doing something wrong?

Jun 21 2021, 2:22 PM · KDE Store
leinir added a comment to T9183: Appstream data (and appstream ID).

Primarily for AppImages i guess, but also for source uploads, as well as flatpakref and snap uploads. Basically, this would tie into the whole "we need to be able to provide specific assistance for specific categories" thing, like linting of for example kpackage uploads (like plasma applets, which require a specific internal layout). Essentially helping people to correctly fill out their store listings. The first part is more work, but the second can be just sort of... done, i guess, by adding it manually (which would be something like appstream##id=org.freedesktop.ocstester as suggested in the tags proposal in T6133)

Jun 21 2021, 8:56 AM · KDE Store
leinir added a comment to T7754: Don't return an empty icon if there's no decoration.

The image should be cached on the client, so the a point should at least be heavily mitigated. But, yes, adding a mechanism to knewstuff to use the current icon theme's "no image here sorry" icon when that default image is returned would likely make sense anyway, i'll see what we can do about that :)

Jun 21 2021, 8:21 AM · KDE Store

Jun 19 2021

leinir added a comment to T14532: Add new categories for Cantor for documentation files.

Yup, looks like just the one 651 now in the /content/categories output :)

Jun 19 2021, 7:43 PM · KDE Store
leinir added a comment to T14532: Add new categories for Cantor for documentation files.

It seems to work but I'm getting the same category three times:

Jun 19 2021, 12:48 PM · KDE Store

Jun 17 2021

leinir added a comment to T14532: Add new categories for Cantor for documentation files.

Hey there - this /should/ be doable yes. We have a couple of things to care for here to fully handle this on our side (which currently does not really know how to do the parent/child relationship the server returns right now, because it's outside of the OCS specification, but also that is something we should fix). That said, this only really affects some basics of the display, and since you're wanting to show them in two different locations anyway, you'll not need to worry about that part (and i guess i'm only really saying it here to have it on record that i need to get that done ;) )

Jun 17 2021, 10:11 AM · KDE Store

May 11 2021

leinir added a comment to T12198: KXmlGui: remove Attica dependency.

Just thought i'd mention, this is now worked on on https://invent.kde.org/frameworks/kxmlgui/-/merge_requests/57

May 11 2021, 2:38 PM · KF6
leinir moved T12198: KXmlGui: remove Attica dependency from Waiting on Other Tasks to In Progress on the KF6 board.
May 11 2021, 2:37 PM · KF6

Apr 30 2021

leinir added a comment to D25506: Remove Attica from KAboutDialog.

There we go - had to do some surgery to make it work, since of course kxmlgui has moved on since this patch was first made, but i've got an MR under way on https://invent.kde.org/frameworks/kxmlgui/-/merge_requests/57 (currently WIP because i want to add in functionality to not force onlineness until people allow it) which implements the most important part of this diff, being the part about removing the hard(ish) dependency on Attica.

Apr 30 2021, 12:05 PM · Frameworks

Apr 21 2021

leinir added a comment to D25506: Remove Attica from KAboutDialog.

Right! Only a mere tiny short while later, the store has as of now got support for that avatar thing based on just the username - in a neat variety of ways, as well :) See Alexander's comment here for details: https://phabricator.kde.org/T10138#254182 (and i'll need to do some not-some-random-comment documentation for that somewhere useful)

Apr 21 2021, 9:00 AM · Frameworks
leinir added a comment to T10138: Avatar URL.

@alexanderschmidt If you will pardon my excessive use of the English language here: Awesome :D That covers pretty much every reasonable base, i feel, and gives us plenty to work with.

Apr 21 2021, 8:41 AM · KDE Store

Apr 13 2021

leinir reassigned T10138: Avatar URL from ronaldv to siyuandong.
Apr 13 2021, 8:57 AM · KDE Store

Feb 3 2021

leinir added a comment to T14091: Improve the App Update Announcements.

To me, this sounds like... pardon my Look Around You commentary here, but: An experiment was conducted, based upon the hypothesis that more frequent announcements would be advantageous. The results gathered during the experiment show that this hypothesis was not true, and a reversal to the previous approach would be advantageous. So, in short, yeah, a Quarterly App Catch-up or whatever it ends up being called seems a good idea. It also seems like this would make it perhaps a little easier for single-app highlights to show through a little easier, with an occasional big release announcement type thing. We could then call that approach a follow-up experiment ;)

Feb 3 2021, 11:42 AM · Goal: All About the Apps, KDE Applications, KDE Promo

Jan 5 2021

leinir added a comment to T14010: KNewStuff: Use d-ptr pattern and make parts internal.

Yes, i would be more comfortable with just getting rid of DownloadManager (and... i suspect we might very well be able to just mark it as deprecated, though... a quick glance through does point me to e.g. yakuake, which uses it for that simplistic convenience thing i was talking about above... not sure)

Jan 5 2021, 2:10 PM · KF6
leinir added a comment to T14010: KNewStuff: Use d-ptr pattern and make parts internal.
In T14010#247580, @alex wrote:

i have a use case in mind specifically for the cache (in short, this is the only way we can create links between content and the fact that it's a kns originated thing, without initialising an engine (that is, without phoning home first))

But there is also the DownloadManager class, it feels like to more appropriate place to put such logic.

Jan 5 2021, 12:07 PM · KF6
leinir added a comment to T14010: KNewStuff: Use d-ptr pattern and make parts internal.

i have a use case in mind specifically for the cache (in short, this is the only way we can create links between content and the fact that it's a kns originated thing, without initialising an engine (that is, without phoning home first)). The models we might need to consider, but if they're not exported, we can't easily wrap them in the qtquick components (for example).

Jan 5 2021, 11:55 AM · KF6

Dec 14 2020

leinir added a comment to T11636: rework the account and plugin management in attica/knewstuff.

The knewstuff bits are still in progress (taking way longer than i wanted, but... well, fires needed fighting and sidetracking happened, but i'm back on it shortly)

Dec 14 2020, 5:43 PM · KF6
leinir abandoned D25961: [WIP] Switch the Attica KDE plugin to use KAccounts.

@leinir it seems like this was merged so I guess this should be closed?

Dec 14 2020, 5:42 PM · Plasma

Dec 8 2020

leinir added a comment to T13924: Unify how d-pointer is created in frameworks' classes.

i've no problem either way (and also lean towards unique_ptr), but would like to see this done sweeping on a per-framework basis (that is. until a framework is moved wholesale to using that, it would be nice not to have two different styles of dptr implementation in the same framework, it's a bit jarring to come across).

Dec 8 2020, 11:22 AM · KF6

Sep 8 2020

leinir claimed T12200: KNewStuff: get rid of KNS3::standardAction.
Sep 8 2020, 9:29 AM · KF6
leinir claimed T12106: Port KNewStuff away from QDom API.
Sep 8 2020, 9:29 AM

Jun 8 2020

leinir committed R304:a1cc38205383: Don't allow content to overflow in the grid delegates (authored by leinir).
Don't allow content to overflow in the grid delegates
Jun 8 2020, 8:35 AM

May 22 2020

leinir committed R304:f02dfeecfc4f: Don't duplicate error messages in a passive notification (authored by leinir).
Don't duplicate error messages in a passive notification
May 22 2020, 7:47 PM

May 19 2020

leinir committed R169:87ba5f76d7a7: Fix the shaders resource initialisation for static builds (authored by leinir).
Fix the shaders resource initialisation for static builds
May 19 2020, 11:01 AM

May 13 2020

leinir committed R304:5ce4d1a29b96: Fix incorrect colours in the KNS Quick messagebox (authored by leinir).
Fix incorrect colours in the KNS Quick messagebox
May 13 2020, 7:49 PM
leinir closed D29678: Fix incorrect colours in the KNS Quick messagebox.
May 13 2020, 7:49 PM · Frameworks
leinir updated the diff for D29678: Fix incorrect colours in the KNS Quick messagebox.

Address comment by @ngraham

May 13 2020, 2:24 PM · Frameworks
leinir added a comment to D29678: Fix incorrect colours in the KNS Quick messagebox.

Does this even need to be a TextEdit? Or is that to get mouse-selectability for the error text? If so, +1 but please add comments indicating this reason.

May 13 2020, 2:22 PM · Frameworks
leinir accepted D29709: Give all OverlaySheets consistent headers.

Yay consistency! Good idea (and timely ;) )

May 13 2020, 1:44 PM · Plasma
leinir added a comment to D29542: Refactor canvas event handling.

Incidentally, while this was committed before i could test it, i can confirm that it works fine with Calligra Gemini

May 13 2020, 9:46 AM · Calligra: 3.0

May 12 2020

leinir added reviewers for D29678: Fix incorrect colours in the KNS Quick messagebox: Frameworks, KNewStuff, Plasma, bugseforuns.
May 12 2020, 1:50 PM · Frameworks
leinir requested review of D29678: Fix incorrect colours in the KNS Quick messagebox.
May 12 2020, 1:45 PM · Frameworks

May 7 2020

leinir accepted D29455: KNS: Deprecate isRemote method and handle parse error properly.

Sorted, nicely done :) Makes the code just a touch simpler as well, which is always good :)

May 7 2020, 9:57 AM · Frameworks
leinir accepted D29123: Do not mark entry as uninstalled if uninstallation script failed.
May 7 2020, 9:57 AM · Frameworks
leinir accepted D29451: KNS: Do not mark entry as installed if install script failed.

Thank you :D Land away :)

May 7 2020, 9:29 AM · Frameworks
leinir requested changes to D29451: KNS: Do not mark entry as installed if install script failed.

(oops, mistakenly marked as accepted, sorry...)

May 7 2020, 8:20 AM · Frameworks
leinir accepted D29451: KNS: Do not mark entry as installed if install script failed.
In D29451#665420, @alex wrote:

Fix connect

Thanks, I wasn't aware of that until now :-)

May 7 2020, 8:15 AM · Frameworks
leinir requested changes to D29451: KNS: Do not mark entry as installed if install script failed.
May 7 2020, 8:05 AM · Frameworks

May 6 2020

leinir requested changes to D29455: KNS: Deprecate isRemote method and handle parse error properly.

Apart from these couple of details, it looks pretty good :) (i'd say just fix and commit, but one of them's a tiny bit larger than just a typo fix ;) )

May 6 2020, 1:20 PM · Frameworks
leinir requested changes to D29123: Do not mark entry as uninstalled if uninstallation script failed.

Sorry about missing that bic issue before...

May 6 2020, 1:14 PM · Frameworks
leinir requested changes to D29451: KNS: Do not mark entry as installed if install script failed.

A bit nitpicky, that first one, the second's more serious (i'd like to avoid that in new code), but looks good otherwise :)

May 6 2020, 1:00 PM · Frameworks
leinir committed R304:25d391c6f36b: Fix showing updates when the option is selected (authored by leinir).
Fix showing updates when the option is selected
May 6 2020, 8:43 AM
leinir closed D29447: Fix showing updates when the option is selected.
May 6 2020, 8:43 AM · KNewStuff, Plasma, Frameworks

May 5 2020

leinir requested changes to D29455: KNS: Deprecate isRemote method and handle parse error properly.
May 5 2020, 7:59 PM · Frameworks
leinir added a comment to D29447: Fix showing updates when the option is selected.

Thanks for making me realise that it doesn't have to be quite so elaborate, @alex ;)

May 5 2020, 7:46 PM · KNewStuff, Plasma, Frameworks
leinir updated the diff for D29447: Fix showing updates when the option is selected.

As @alex suggests, just use qlist::contains, it is supposed to be
reasonably cheap, so... yup, trust the framework! ;)

May 5 2020, 7:45 PM · KNewStuff, Plasma, Frameworks
leinir added inline comments to D29447: Fix showing updates when the option is selected.
May 5 2020, 7:36 PM · KNewStuff, Plasma, Frameworks
leinir updated the diff for D29447: Fix showing updates when the option is selected.

Address comment by @alex

May 5 2020, 4:15 PM · KNewStuff, Plasma, Frameworks
leinir added projects to D29447: Fix showing updates when the option is selected: Plasma, KNewStuff.
May 5 2020, 2:44 PM · KNewStuff, Plasma, Frameworks
leinir requested review of D29447: Fix showing updates when the option is selected.
May 5 2020, 2:42 PM · KNewStuff, Plasma, Frameworks

May 4 2020

leinir committed R499:a94a2955701e: Add kpackage dependency to knewstuff (authored by leinir).
Add kpackage dependency to knewstuff
May 4 2020, 12:04 PM
leinir closed D29222: Fix update auto selection.
May 4 2020, 10:46 AM · Frameworks
leinir committed R304:12642a1c0174: Fix update auto selection (authored by leinir).
Fix update auto selection
May 4 2020, 10:46 AM
leinir committed R304:3f38da8a70d8: Add KPackage support to KNewStuffCore (authored by leinir).
Add KPackage support to KNewStuffCore
May 4 2020, 10:45 AM
leinir closed D28701: Add KPackage support to KNewStuffCore.
May 4 2020, 10:45 AM · Frameworks
leinir updated the diff for D28701: Add KPackage support to KNewStuffCore.

Since we have had a new Frameworks release while this is waiting
for the thumbs up, increase the @since to the next version.

May 4 2020, 9:57 AM · Frameworks

Apr 30 2020

leinir added a comment to D28701: Add KPackage support to KNewStuffCore.
In D28701#660186, @mart wrote:

+1 from me.

Apr 30 2020, 8:14 AM · Frameworks

Apr 28 2020

leinir added a comment to D28701: Add KPackage support to KNewStuffCore.

Ping team framework and such? (i realise we're all a tiny bit more stressy than usual...)

Apr 28 2020, 8:31 AM · Frameworks
leinir accepted D29101: KNewStuff: Fix file path and process call.

That's well spotted. Thanks for taking that one on :)

Apr 28 2020, 8:18 AM · Frameworks
leinir updated subscribers of T12787: Calligra 3.2 release.

i believe Carl's been doing some stuff already, and as we had a bit of a chat about it on the promo chat last week, i'll tag promo in as well :)

Apr 28 2020, 7:48 AM · Calligra: 3.0
leinir updated the diff for D29222: Fix update auto selection.

Thanks @ngraham, learn me to add debug information and then forget to commit it :P

Apr 28 2020, 7:33 AM · Frameworks

Apr 27 2020

leinir added reviewers for D29222: Fix update auto selection: Frameworks, Plasma, bugseforuns, ngraham.
Apr 27 2020, 9:40 AM · Frameworks
leinir requested review of D29222: Fix update auto selection.
Apr 27 2020, 9:39 AM · Frameworks

Apr 24 2020

leinir added inline comments to D28701: Add KPackage support to KNewStuffCore.
Apr 24 2020, 2:40 PM · Frameworks
leinir added a comment to T12787: Calligra 3.2 release.

It's out, so frezzes lifted.
I have posted a changelog draft on calligra-devel, please reviw!

Apr 24 2020, 10:02 AM · Calligra: 3.0
leinir requested changes to D29123: Do not mark entry as uninstalled if uninstallation script failed.

On a related note, i'm waiting on reviews on D28701 at the moment... which i'm afraid might wreck some havoc with your patch, as they touch some of the same bits of the codebase.

Apr 24 2020, 9:16 AM · Frameworks

Apr 23 2020

leinir added a comment to D29126: KNewStuff: port from KRun::runApplication to KIO::ApplicationLauncherJob.

And KRun was widgets based too. At least now you can get rid of widgets completely (for this bit about starting apps) by connecting to the result() signal yourself instead of using a dialog ui delegate. There's also a knotifications based ui delegate, but not sure it's appropriate here (that's more for plasma itself I would say).

Apr 23 2020, 10:42 AM · Frameworks
leinir accepted D29126: KNewStuff: port from KRun::runApplication to KIO::ApplicationLauncherJob.

Was /just/ about to be all "nooo, widgets in core, crying forever" but this isn't core, so go for it ;)

Apr 23 2020, 10:38 AM · Frameworks
leinir added a comment to D29123: Do not mark entry as uninstalled if uninstallation script failed.

(and now i've done it myself, terribly sorry about that, missed the WIP at the start of the title! Hope some of my comments were useful, though :) )

Apr 23 2020, 9:29 AM · Frameworks
leinir requested changes to D29123: Do not mark entry as uninstalled if uninstallation script failed.

The reporting side of this seems based on a misunderstanding of what the UI-less Core is supposed to be doing... The conceptual intention in general isn't bad, but it needs a bit of work. Thanks for spotting it, too :)

Apr 23 2020, 9:28 AM · Frameworks

Apr 22 2020

leinir updated the diff for D28701: Add KPackage support to KNewStuffCore.

Some documentation and whitespace fixes for Frameworksiness

Apr 22 2020, 10:28 AM · Frameworks
leinir added a comment to D29057: Introduce PlaceholderMessage component.

Nice! Got a few places where this could be very handy :)

Apr 22 2020, 8:25 AM · Kirigami

Apr 21 2020

leinir added a comment to D28701: Add KPackage support to KNewStuffCore.

I mean, GHNS basically *is* a userspace package manager, and things like dependency management and removal of stale files are why package managers exist. :)

If it needs to be fixed/implemented in other patches, that's okay.

Apr 21 2020, 6:51 PM · Frameworks
leinir added a comment to D28701: Add KPackage support to KNewStuffCore.

Great. There are still a few more bugs though:

When you install certain global themes, they ask for authentication so install an SDDM theme. However when you uninstall that theme, it doesn't request authentication to remove them SDDM theme. So /usr/share/sddm/themes accumulates a growing collection of unused themes:

ls /usr/share/sddm/themes/
breeze  breeze-openSUSE  elarun  Layan  maldives  maya  McMojave  plasmaX  Sweet
Apr 21 2020, 9:39 AM · Frameworks

Apr 20 2020

leinir updated the diff for D28701: Add KPackage support to KNewStuffCore.

Thank you to @ngraham for noticing this one! It only really pokes its head
out if you have multiple things installed and then try and uninstall one of
them - if you only have the one thing installed, it looks very much like
as though it's just cleaning up after itself and removing the containing
folder... Easy enough fix, though :)

Apr 20 2020, 8:11 AM · Frameworks
leinir added a comment to D28701: Add KPackage support to KNewStuffCore.

As i thought, i was indeed holding the KPackage APi incorrectly ;) The culprit is hinted at in the line

Apr 20 2020, 8:07 AM · Frameworks

Apr 17 2020

leinir added a comment to D28701: Add KPackage support to KNewStuffCore.

Thanks, the hang is gone now. However I have a new problem:

  1. Open Global Themes KCM and click new new global themes
  2. Install Sweet KDE and McMojave LAF global themes
  3. Close the GHNS dialog
  4. Open the dialog again
  5. Uninstall the McMojave LAF theme
  6. Close the dialog

    Both McMojave LAF and also Sweet KDE have disappeared from the KCM. Sweet KDE still shows up as installed in the GHNS dialog and Discover, but does not appear in the KCM.

    The same thing happens for plasma themes too. It seems that deleting one item from the GHNS dialog marks all of the installed GHNS items of that type as deleted.
Apr 17 2020, 5:46 PM · Frameworks
leinir added reviewers for D28701: Add KPackage support to KNewStuffCore: broulik, bshah.

Tagging in a couple of people who were in the original chat about doing this integration... :)

Apr 17 2020, 10:38 AM · Frameworks

Apr 16 2020

leinir updated the summary of D28701: Add KPackage support to KNewStuffCore.
Apr 16 2020, 3:25 PM · Frameworks
leinir updated the diff for D28701: Add KPackage support to KNewStuffCore.

Address @ngraham's (and my own) worry about the synchronous behaviour exhibited by KPackage... Something a bit like this probably wants to go into KPackage itself, perhaps we can consider this after we've done a bit of testing of its solidity here...

Apr 16 2020, 3:24 PM · Frameworks
leinir added a comment to D28701: Add KPackage support to KNewStuffCore.

This has fixed the issues I was seeing with installation and uninstallation, nice! However I'm not seeing a very long hang when installing certain global themes--for example Sweet KDE and Layan Look and Feel Theme. It does ultimately work, but the dialog freezes for multiple minutes before finally becoming interactive again.

Apr 16 2020, 7:51 AM · Frameworks

Apr 15 2020

leinir added reviewers for D28701: Add KPackage support to KNewStuffCore: ngraham, mart, davidedmundson.

Tagging in those active in the referenced bug, except for the reporter who doesn't have a phabricator account

Apr 15 2020, 2:01 PM · Frameworks
leinir updated the summary of D28701: Add KPackage support to KNewStuffCore.
Apr 15 2020, 1:33 PM · Frameworks
leinir updated the diff for D28701: Add KPackage support to KNewStuffCore.

Think we're at the point where testing would be good, now. This update
means we now attempt to adopt already installed kpackages if you try and
install the package from knewstuff, and removal of entries installed
using the previous implementation should now also happen during a fallback
step, intended to make life a bit simpler for those who have used this
before...

Apr 15 2020, 1:30 PM · Frameworks
leinir updated the diff for D28701: Add KPackage support to KNewStuffCore.

(the fallback handling needs some more work, but also progress)

Apr 15 2020, 10:33 AM · Frameworks

Apr 14 2020

leinir updated the test plan for D28701: Add KPackage support to KNewStuffCore.
Apr 14 2020, 1:55 PM · Frameworks
leinir updated the test plan for D28701: Add KPackage support to KNewStuffCore.
Apr 14 2020, 1:54 PM · Frameworks
leinir updated the diff for D28701: Add KPackage support to KNewStuffCore.
  • Make a touch of noise when encountering the fallback
Apr 14 2020, 1:37 PM · Frameworks
leinir updated the summary of D28701: Add KPackage support to KNewStuffCore.
Apr 14 2020, 1:34 PM · Frameworks
leinir updated the summary of D28701: Add KPackage support to KNewStuffCore.
Apr 14 2020, 1:33 PM · Frameworks