leinir (Dan Leinir Turthra Jensen)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jul 8 2015, 8:34 AM (205 w, 4 d)
Availability
Available

Recent Activity

Thu, Jun 13

leinir accepted D21778: Add some documentation for PlatformDependent.

Looks good :)

Thu, Jun 13, 10:05 AM · Frameworks
leinir added a comment to D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).

Could the new one be API compatible so we wouldn't need to wait for KF6? Also it's always nice to avoid breaking API if you don't have to.

Thu, Jun 13, 9:55 AM · Frameworks

Wed, Jun 12

leinir added a comment to D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).

Thanks! I think we should definitely aim to replace the old QWidgets-based one. Otherwise we're signing up for an increased maintenance burden with no real advantages IMO. Consider that we already have the GHNS dialog as well as Discover's UI, and each one has subtle bugs fixed in the other one. Adding a third frontend for the same data would make this even worse. Ideally over time we move to just having one desktop-based frontend (this one maybe?) with multiple ways to access it.

Wed, Jun 12, 9:16 AM · Frameworks

Tue, Jun 11

leinir added a comment to D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).

How does one test this?

Tue, Jun 11, 9:07 AM · Frameworks

Mon, Jun 10

leinir updated the summary of D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
Mon, Jun 10, 1:15 PM · Frameworks
leinir requested review of D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
Mon, Jun 10, 1:11 PM · Frameworks

Fri, May 31

leinir added a comment to D21510: Filter KNewStuff Plasma Themes by Download Tag.

Is the content actually tagged appropriately yet? When I test this out I see no effect, i.e. old Plasma 4 themes like OLED Orange (https://store.kde.org/p/998790/) are still visible.

Fri, May 31, 4:15 PM · Plasma
leinir updated the diff for D21510: Filter KNewStuff Plasma Themes by Download Tag.
  • Add TagFilter (for top level tags), and don't explicitly reject 4
Fri, May 31, 11:23 AM · Plasma
leinir added a reviewer for D21510: Filter KNewStuff Plasma Themes by Download Tag: Plasma.
Fri, May 31, 10:21 AM · Plasma
leinir updated the test plan for D21510: Filter KNewStuff Plasma Themes by Download Tag.
Fri, May 31, 10:20 AM · Plasma
leinir requested review of D21510: Filter KNewStuff Plasma Themes by Download Tag.
Fri, May 31, 10:18 AM · Plasma

Wed, May 22

leinir added a comment to T8126: Figure out what to about all the content that doesn't work.

@leinir I have changed the output for the plasma tags. Please try, if it works for you now.

Wed, May 22, 8:10 AM · KDE Store

May 17 2019

leinir added a comment to T8126: Figure out what to about all the content that doesn't work.

By example of a Plasma Theme which has 3 variants:

  • supporting Plasma 4.12...Plasma 4.last & Plasma 5.0...Plasma5.15
  • supporting Plasma5.16...5.18
  • supporting Plasma5.18... what tags should those both have set? What should be the tag filter for a Plasma system that is 5.18, and what the tag filter for a system that is 5.20?

<also snip other bits>

May 17 2019, 11:17 AM · KDE Store
leinir added a comment to D21246: Search also legacy location for knsrc files.

OK I see in https://phabricator.kde.org/D19340 this is intentional

May 17 2019, 7:00 AM · Plasma

May 13 2019

leinir accepted D21183: search in the new location for knsrc files.

In the words of the interwebs whenever someone days a certain number: nice :)

May 13 2019, 11:55 AM · Frameworks
leinir requested changes to D21183: search in the new location for knsrc files.
May 13 2019, 11:42 AM · Frameworks
leinir created T10919: Align download call with content call's IDs.
May 13 2019, 9:26 AM · KDE Store

May 10 2019

leinir updated subscribers of T8126: Figure out what to about all the content that doesn't work.

(meh, my reply got long, sorry)

May 10 2019, 10:06 AM · KDE Store

May 3 2019

leinir added a comment to D20986: Don't call click on the delegate, when we just want it to become current item.

-1

Most KCMs actually use onClicked to update the selected plugin and other bits. They don't actually set currentIndex on the ListView directly but have it updated based on whatever current scheme or theme etc is selected.

Can it be fixed such that the onClicked isn't fired when the action is invoked? From what I can see the actions don't rely on currentIndex

May 3 2019, 9:47 AM · Frameworks
leinir requested review of D20986: Don't call click on the delegate, when we just want it to become current item.
May 3 2019, 9:25 AM · Frameworks

May 2 2019

leinir added inline comments to D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons.
May 2 2019, 6:43 PM · Frameworks
leinir added inline comments to D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons.
May 2 2019, 8:53 AM · Frameworks

Apr 26 2019

leinir committed R169:168db1c41a58: Update qrc.in to match .qrc (missing ActionMenuItem) (authored by leinir).
Update qrc.in to match .qrc (missing ActionMenuItem)
Apr 26 2019, 1:00 PM

Apr 25 2019

leinir committed R304:e1f5782a8518: Remove pixelated border (authored by leinir).
Remove pixelated border
Apr 25 2019, 11:19 AM
leinir closed D20693: Remove pixelated border.
Apr 25 2019, 11:19 AM · Frameworks, KNewStuff
leinir added a comment to D20693: Remove pixelated border.

That does indeed look good, and not a huge departure from what we have already, which i'm sure will make people feel quite at home in the new version :) I do wonder if we'd want to, at some point, make it look closer to Discover, but certainly for now this seems a much more sensible direction.

Apr 25 2019, 10:45 AM · Frameworks, KNewStuff

Apr 24 2019

leinir added a comment to D20693: Remove pixelated border.

To show that a thumbnail clickable, switching to the pointing hand cursor when hovering over a thumbnail could work.

However I notice that the actual list delegates in the browse view seem to add frames and shadows to the thumbnails there, and they look okay. The frame's proportions even perfectly match the aspect ratio of the thumbnail:

Why doesn't any of that work here?

Apr 24 2019, 8:31 AM · Frameworks, KNewStuff

Apr 23 2019

leinir added a comment to D20693: Remove pixelated border.

So yes, in principle i'd certainly like there to be some kind of background or outline to suggest clickability, but the current state (and any other generic rectangular background we might come up with, higher resolution or not) would yield the same suboptimal result...

QGraphicsDropShadowEffect via QWidget::setGraphicsEffect may work for that?

Another approach would likely be to write a custom blur implementation since we fiddle with qpainter anyway, TBH I think finding a way to use the effect is likely the wise use of time though.

Apr 23 2019, 11:03 AM · Frameworks, KNewStuff
leinir added a comment to D20693: Remove pixelated border.

LGTM on a technical level. On a visual level also +1 because I hate that drop shadow with a fierce passion.

@leinir lxr says a similar thumb is also used for some of the KAboutPerson stuff in kxmlgui. it may be prudent to also remove the thumb there, I expect it looks equally dated.

Apr 23 2019, 10:56 AM · Frameworks, KNewStuff
leinir added a comment to D20693: Remove pixelated border.

+1 for the change to the large thumbnail, but I think the smaller thumbnails need something to show that they can be clicked.

Apr 23 2019, 9:52 AM · Frameworks, KNewStuff
leinir added a reviewer for D20693: Remove pixelated border: VDG.

Adding VDG because this is a visual change. To the visual commenters: This is intended as a first step, removing the old drop-shadow method (see also the related bug for a more severe version of that drop-shadow being shown very incorrectly). If we decide we do want a drop shadow, then that will want to be done separately. Note also that as we cannot guarantee the image will not have any translucent areas (which is the cause of the highly nasty look in the bug report, rather than just the basic nastiness shown in the screenshots here), we will need to do something considerably more clever than just putting a 9-slice drop image around the image (for example), which might well be a fair bit more expensive computationally than we'd probably want.

Apr 23 2019, 8:02 AM · Frameworks, KNewStuff
leinir added a reviewer for D20761: Remove pixelated border: VDG.
Apr 23 2019, 8:02 AM · Frameworks
leinir added a comment to D20693: Remove pixelated border.

Before patch:

Apr 23 2019, 7:30 AM · Frameworks, KNewStuff
leinir added a comment to D20693: Remove pixelated border.

This patch doesn't apply:

 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D20693.
Checking patch src/ui/imagepreviewwidget_p.h...
Checking patch src/ui/imagepreviewwidget.cpp...
Checking patch data/thumb_frame.png...
error: the patch applies to 'data/thumb_frame.png' (afaf432793864e1fb3f1fc27aa1d53689f2243b5), which does not match the current contents.
error: data/thumb_frame.png: patch does not apply
Checking patch data/CMakeLists.txt...
Applied patch src/ui/imagepreviewwidget_p.h cleanly.
Applied patch src/ui/imagepreviewwidget.cpp cleanly.
Applied patch data/CMakeLists.txt cleanly.

 Patch Failed! 
Usage Exception: Unable to apply patch!

Also it would be helpful if you used arc for your patches, since then you can see the context here in the web UI: https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches

Apr 23 2019, 7:28 AM · Frameworks, KNewStuff
leinir updated the diff for D20693: Remove pixelated border.

Attempt to use arcanist, hopefully with less data loss this time

Apr 23 2019, 7:22 AM · Frameworks, KNewStuff
leinir abandoned D20761: Remove pixelated border.
Apr 23 2019, 7:20 AM · Frameworks
leinir requested review of D20761: Remove pixelated border.
Apr 23 2019, 7:19 AM · Frameworks

Apr 20 2019

leinir requested review of D20693: Remove pixelated border.
Apr 20 2019, 8:42 AM · Frameworks, KNewStuff

Apr 12 2019

leinir committed R134:80bdde1ad0d7: Use correct syntax for tag filters in KNS backend (authored by leinir).
Use correct syntax for tag filters in KNS backend
Apr 12 2019, 11:27 AM

Apr 10 2019

leinir committed R134:727d8e55e46c: Make KNS applications act more like applications (authored by leinir).
Make KNS applications act more like applications
Apr 10 2019, 8:09 AM
leinir closed D20378: Make KNS applications act more like applications.
Apr 10 2019, 8:09 AM · Discover Software Store, Plasma
leinir committed R134:6589e22f08e7: Adapt an x option for app-carrying knsrc files (authored by leinir).
Adapt an x option for app-carrying knsrc files
Apr 10 2019, 8:09 AM
leinir closed D20406: Adapt an x option for app-carrying knsrc files.
Apr 10 2019, 8:09 AM · Plasma, Discover Software Store
leinir committed R134:29be60b13647: Split up subcategories for KNS categories (authored by leinir).
Split up subcategories for KNS categories
Apr 10 2019, 8:09 AM
leinir closed D19925: Split up subcategories for KNS categories.
Apr 10 2019, 8:08 AM · Plasma, Discover Software Store

Apr 9 2019

leinir added a dependency for D20406: Adapt an x option for app-carrying knsrc files: D19925: Split up subcategories for KNS categories.
Apr 9 2019, 1:04 PM · Plasma, Discover Software Store
leinir added a dependent revision for D19925: Split up subcategories for KNS categories: D20406: Adapt an x option for app-carrying knsrc files.
Apr 9 2019, 1:04 PM · Plasma, Discover Software Store
leinir requested review of D20406: Adapt an x option for app-carrying knsrc files.
Apr 9 2019, 1:04 PM · Plasma, Discover Software Store
leinir updated the diff for D19925: Split up subcategories for KNS categories.

Remove unnecessary (very noisy) debug messages

Apr 9 2019, 12:28 PM · Plasma, Discover Software Store
leinir planned changes to D19925: Split up subcategories for KNS categories.
Apr 9 2019, 12:26 PM · Plasma, Discover Software Store
leinir added a comment to D19925: Split up subcategories for KNS categories.

Ping? :)

Apr 9 2019, 12:22 PM · Plasma, Discover Software Store
leinir committed R304:fd580ca61d69: Minor documentation clearup (missing support variable) (authored by leinir).
Minor documentation clearup (missing support variable)
Apr 9 2019, 8:32 AM
leinir updated the diff for D20378: Make KNS applications act more like applications.

We now assume that an AdoptionCommand is set. This reduces the code overhead, which is always nice.

Apr 9 2019, 7:50 AM · Discover Software Store, Plasma
leinir planned changes to D20378: Make KNS applications act more like applications.
Apr 9 2019, 7:42 AM · Discover Software Store, Plasma

Apr 8 2019

leinir requested review of D20378: Make KNS applications act more like applications.
Apr 8 2019, 12:40 PM · Discover Software Store, Plasma

Apr 5 2019

leinir added a comment to D20198: Don't lose list position after installing KNS cursor themes.

FYI the patch gets closed automatically only if the commit message has Differential Revision: https://phabricator.kde.org/D20198 somewhere in it. If you use arc land or cherry-pick the commit hash of the arc-created patch, that happens automatically.

Apr 5 2019, 1:01 PM · Plasma
leinir closed D20198: Don't lose list position after installing KNS cursor themes.

Forgot to close the revision in R119:4545601adec0

Apr 5 2019, 12:20 PM · Plasma
leinir committed R119:4545601adec0: Don't lose list position after installing KNS cursor themes (authored by leinir).
Don't lose list position after installing KNS cursor themes
Apr 5 2019, 12:11 PM
leinir updated the diff for D20198: Don't lose list position after installing KNS cursor themes.

Address @apol's comment (can't use splitref in the second bit, as we're joining the list again at the end)

Apr 5 2019, 7:29 AM · Plasma
leinir added inline comments to D20198: Don't lose list position after installing KNS cursor themes.
Apr 5 2019, 7:29 AM · Plasma

Apr 4 2019

leinir added inline comments to D20198: Don't lose list position after installing KNS cursor themes.
Apr 4 2019, 9:44 AM · Plasma
leinir updated the diff for D20198: Don't lose list position after installing KNS cursor themes.

Less invasive change, but with more (what seem like fairly reasonable) assumptions. We now operate explicitly on installed and uninstalled files as presented by KNS, rather than simply rechecking the theme locations (which it turns out is surprisingly intensive, but then again, it /is/ a disk IO operation, so perhaps not really that surprising).

Apr 4 2019, 9:43 AM · Plasma

Apr 3 2019

leinir added a comment to D20198: Don't lose list position after installing KNS cursor themes.
In D20198#442785, @apol wrote:

So fixing refreshList to not reset isn't feasible?

Apr 3 2019, 11:54 AM · Plasma
leinir updated the diff for D20198: Don't lose list position after installing KNS cursor themes.

Address comments by @ngraham and @apol

Apr 3 2019, 7:55 AM · Plasma
leinir added a comment to D20198: Don't lose list position after installing KNS cursor themes.

Why do we need this do-it-once helper function?

Apr 3 2019, 7:51 AM · Plasma

Apr 2 2019

leinir requested review of D20198: Don't lose list position after installing KNS cursor themes.
Apr 2 2019, 9:54 AM · Plasma

Mar 28 2019

leinir committed R235:7e988d655db2: Accept any HTTP status between 100 and 199 as benign (authored by leinir).
Accept any HTTP status between 100 and 199 as benign
Mar 28 2019, 10:58 AM
leinir closed D20077: Accept any HTTP status between 100 and 199 as benign.
Mar 28 2019, 10:58 AM · KNewStuff, Frameworks

Mar 27 2019

leinir accepted D19943: Small cleanups for qml components.
Mar 27 2019, 1:28 PM · Calligra: 3.0
leinir accepted D19990: Switch URLs to https.

LGTM, as long as all the various sites being pointed at there actually resolve on https, which i'm guessing (going by your summary) you've checked? :)

Mar 27 2019, 12:48 PM · Frameworks
leinir accepted D19944: Migrate away from deprecated interfaces in gemini dropbox parts.

If memory serves, we'll need to do a fair bit of work to get the DropBox code to work properly again. DropBox has turned off the V1 API support, and we'll need to work against the V2 stuff now, which... Well, it might be trivial, but i have no time to look at it, i'm afraid. Be really good to get it back, though.

Mar 27 2019, 12:45 PM · Calligra: 3.0
leinir added inline comments to D19943: Small cleanups for qml components.
Mar 27 2019, 12:40 PM · Calligra: 3.0
leinir updated the diff for D20077: Accept any HTTP status between 100 and 199 as benign.

Just accept any informational status as benign, rather than the specifically picked ones.

Mar 27 2019, 12:12 PM · KNewStuff, Frameworks
leinir added a comment to D20077: Accept any HTTP status between 100 and 199 as benign.
In D20077#439290, @apol wrote:

And why are 101 and 102 bad?
Should we just accept between 100 and 200?

Mar 27 2019, 12:07 PM · KNewStuff, Frameworks
leinir requested review of D20077: Accept any HTTP status between 100 and 199 as benign.
Mar 27 2019, 11:11 AM · KNewStuff, Frameworks

Mar 20 2019

leinir requested review of D19925: Split up subcategories for KNS categories.
Mar 20 2019, 6:06 PM · Plasma, Discover Software Store
leinir closed D19917: Additions for ProviderManager documentation.
Mar 20 2019, 4:27 PM · Frameworks, KNewStuff
leinir committed R235:533b31b5d6f9: Additions for ProviderManager documentation (authored by leinir).
Additions for ProviderManager documentation
Mar 20 2019, 4:27 PM
leinir added inline comments to D19917: Additions for ProviderManager documentation.
Mar 20 2019, 4:04 PM · Frameworks, KNewStuff
leinir requested review of D19917: Additions for ProviderManager documentation.
Mar 20 2019, 3:59 PM · Frameworks, KNewStuff

Mar 19 2019

leinir closed D19899: Adapt leaf Category names for kns backend, and ensure correct filters.
Mar 19 2019, 9:59 PM · Plasma, Discover Software Store
leinir committed R134:c4e8f04a2489: Adapt leaf Category names for kns backend, and ensure correct filters (authored by leinir).
Adapt leaf Category names for kns backend, and ensure correct filters
Mar 19 2019, 9:59 PM
leinir committed R134:356fe5019436: Fix crash in category comparison caused by incorrect filters (authored by leinir).
Fix crash in category comparison caused by incorrect filters
Mar 19 2019, 9:59 PM
leinir closed D19880: Fix crash in category comparison caused by incorrect filters.
Mar 19 2019, 9:59 PM · Plasma, Discover Software Store
leinir committed R304:88ffd3cce725: Set category on Attica entries (authored by leinir).
Set category on Attica entries
Mar 19 2019, 9:54 PM
leinir closed D19900: Set category on Attica entries.
Mar 19 2019, 9:54 PM · Frameworks, KNewStuff
leinir updated the diff for D19880: Fix crash in category comparison caused by incorrect filters.

Remove some future-leftovers

Mar 19 2019, 9:38 PM · Plasma, Discover Software Store
leinir requested review of D19900: Set category on Attica entries.
Mar 19 2019, 9:02 PM · Frameworks, KNewStuff
leinir requested review of D19899: Adapt leaf Category names for kns backend, and ensure correct filters.
Mar 19 2019, 9:00 PM · Plasma, Discover Software Store
leinir closed T10635: Export category name or ID with all content items as Resolved.

This turns out to already exist, just under a different name. typeid and typename are exactly the category id and human readable category name. Everything is great, thank you very much :)

Mar 19 2019, 5:27 PM · KDE Store
leinir committed R134:eccaa65c9672: Ignore source packages when adding them to the PK list (authored by leinir).
Ignore source packages when adding them to the PK list
Mar 19 2019, 4:48 PM
leinir renamed T10635: Export category name or ID with all content items from Export category name with all content items to Export category name or ID with all content items.
Mar 19 2019, 11:28 AM · KDE Store
leinir requested review of D19880: Fix crash in category comparison caused by incorrect filters.
Mar 19 2019, 11:13 AM · Plasma, Discover Software Store

Mar 18 2019

leinir added a watcher for KDE Store: leinir.
Mar 18 2019, 9:10 PM
leinir created T10635: Export category name or ID with all content items.
Mar 18 2019, 8:53 PM · KDE Store
leinir committed R304:2a40085fc3d2: Handle unsupported OCS commands, and don't over-vote (authored by leinir).
Handle unsupported OCS commands, and don't over-vote
Mar 18 2019, 3:44 PM
leinir closed D19858: Handle unsupported OCS commands, and don't over-vote.
Mar 18 2019, 3:44 PM · KNewStuff, Frameworks
leinir added a comment to D19858: Handle unsupported OCS commands, and don't over-vote.

Thanks! Makes sense, and fixes the bug. :)

Of course the underlying issue is still present. If you can't vote from the GHNS dialogs, there shouldn't be a UI for let you try; it should be strictly read-only. I suppose that's a separate matter though.

Mar 18 2019, 3:40 PM · KNewStuff, Frameworks
leinir updated the diff for D19858: Handle unsupported OCS commands, and don't over-vote.

Copypasta error... thanks Nate :)

Mar 18 2019, 3:31 PM · KNewStuff, Frameworks
leinir added inline comments to D19858: Handle unsupported OCS commands, and don't over-vote.
Mar 18 2019, 3:30 PM · KNewStuff, Frameworks