leinir (Dan Leinir Turthra Jensen)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 8 2015, 8:34 AM (197 w, 3 d)
Availability
Available

Recent Activity

Today

leinir requested review of D20693: Remove pixelated border.
Sat, Apr 20, 8:42 AM · Frameworks, KNewStuff

Fri, Apr 12

leinir committed R134:80bdde1ad0d7: Use correct syntax for tag filters in KNS backend (authored by leinir).
Use correct syntax for tag filters in KNS backend
Fri, Apr 12, 11:27 AM

Wed, Apr 10

leinir committed R134:727d8e55e46c: Make KNS applications act more like applications (authored by leinir).
Make KNS applications act more like applications
Wed, Apr 10, 8:09 AM
leinir closed D20378: Make KNS applications act more like applications.
Wed, Apr 10, 8:09 AM · Plasma, Discover Software Store
leinir committed R134:6589e22f08e7: Adapt an x option for app-carrying knsrc files (authored by leinir).
Adapt an x option for app-carrying knsrc files
Wed, Apr 10, 8:09 AM
leinir closed D20406: Adapt an x option for app-carrying knsrc files.
Wed, Apr 10, 8:09 AM · Plasma, Discover Software Store
leinir committed R134:29be60b13647: Split up subcategories for KNS categories (authored by leinir).
Split up subcategories for KNS categories
Wed, Apr 10, 8:09 AM
leinir closed D19925: Split up subcategories for KNS categories.
Wed, Apr 10, 8:08 AM · Plasma, Discover Software Store

Tue, Apr 9

leinir added a dependency for D20406: Adapt an x option for app-carrying knsrc files: D19925: Split up subcategories for KNS categories.
Tue, Apr 9, 1:04 PM · Plasma, Discover Software Store
leinir added a dependent revision for D19925: Split up subcategories for KNS categories: D20406: Adapt an x option for app-carrying knsrc files.
Tue, Apr 9, 1:04 PM · Plasma, Discover Software Store
leinir requested review of D20406: Adapt an x option for app-carrying knsrc files.
Tue, Apr 9, 1:04 PM · Plasma, Discover Software Store
leinir updated the diff for D19925: Split up subcategories for KNS categories.

Remove unnecessary (very noisy) debug messages

Tue, Apr 9, 12:28 PM · Plasma, Discover Software Store
leinir planned changes to D19925: Split up subcategories for KNS categories.
Tue, Apr 9, 12:26 PM · Plasma, Discover Software Store
leinir added a comment to D19925: Split up subcategories for KNS categories.

Ping? :)

Tue, Apr 9, 12:22 PM · Plasma, Discover Software Store
leinir committed R304:fd580ca61d69: Minor documentation clearup (missing support variable) (authored by leinir).
Minor documentation clearup (missing support variable)
Tue, Apr 9, 8:32 AM
leinir updated the diff for D20378: Make KNS applications act more like applications.

We now assume that an AdoptionCommand is set. This reduces the code overhead, which is always nice.

Tue, Apr 9, 7:50 AM · Plasma, Discover Software Store
leinir planned changes to D20378: Make KNS applications act more like applications.
Tue, Apr 9, 7:42 AM · Plasma, Discover Software Store

Mon, Apr 8

leinir requested review of D20378: Make KNS applications act more like applications.
Mon, Apr 8, 12:40 PM · Plasma, Discover Software Store

Fri, Apr 5

leinir added a comment to D20198: Don't lose list position after installing KNS cursor themes.

FYI the patch gets closed automatically only if the commit message has Differential Revision: https://phabricator.kde.org/D20198 somewhere in it. If you use arc land or cherry-pick the commit hash of the arc-created patch, that happens automatically.

Fri, Apr 5, 1:01 PM · Plasma
leinir closed D20198: Don't lose list position after installing KNS cursor themes.

Forgot to close the revision in R119:4545601adec0

Fri, Apr 5, 12:20 PM · Plasma
leinir committed R119:4545601adec0: Don't lose list position after installing KNS cursor themes (authored by leinir).
Don't lose list position after installing KNS cursor themes
Fri, Apr 5, 12:11 PM
leinir updated the diff for D20198: Don't lose list position after installing KNS cursor themes.

Address @apol's comment

Fri, Apr 5, 7:29 AM · Plasma
leinir added inline comments to D20198: Don't lose list position after installing KNS cursor themes.
Fri, Apr 5, 7:29 AM · Plasma

Thu, Apr 4

leinir added inline comments to D20198: Don't lose list position after installing KNS cursor themes.
Thu, Apr 4, 9:44 AM · Plasma
leinir updated the diff for D20198: Don't lose list position after installing KNS cursor themes.

Less invasive change, but with more (what seem like fairly reasonable) assumptions. We now operate explicitly on installed and uninstalled files as presented by KNS, rather than simply rechecking the theme locations (which it turns out is surprisingly intensive, but then again, it /is/ a disk IO operation, so perhaps not really that surprising).

Thu, Apr 4, 9:43 AM · Plasma

Wed, Apr 3

leinir added a comment to D20198: Don't lose list position after installing KNS cursor themes.
In D20198#442785, @apol wrote:

So fixing refreshList to not reset isn't feasible?

Wed, Apr 3, 11:54 AM · Plasma
leinir updated the diff for D20198: Don't lose list position after installing KNS cursor themes.

Address comments by @ngraham and @apol

Wed, Apr 3, 7:55 AM · Plasma
leinir added a comment to D20198: Don't lose list position after installing KNS cursor themes.

Why do we need this do-it-once helper function?

Wed, Apr 3, 7:51 AM · Plasma

Tue, Apr 2

leinir requested review of D20198: Don't lose list position after installing KNS cursor themes.
Tue, Apr 2, 9:54 AM · Plasma

Thu, Mar 28

leinir committed R235:7e988d655db2: Accept any HTTP status between 100 and 199 as benign (authored by leinir).
Accept any HTTP status between 100 and 199 as benign
Thu, Mar 28, 10:58 AM
leinir closed D20077: Accept any HTTP status between 100 and 199 as benign.
Thu, Mar 28, 10:58 AM · KNewStuff, Frameworks

Wed, Mar 27

leinir accepted D19943: Small cleanups for qml components.
Wed, Mar 27, 1:28 PM · Calligra: 3.0
leinir accepted D19990: Switch URLs to https.

LGTM, as long as all the various sites being pointed at there actually resolve on https, which i'm guessing (going by your summary) you've checked? :)

Wed, Mar 27, 12:48 PM · Frameworks
leinir accepted D19944: Migrate away from deprecated interfaces in gemini dropbox parts.

If memory serves, we'll need to do a fair bit of work to get the DropBox code to work properly again. DropBox has turned off the V1 API support, and we'll need to work against the V2 stuff now, which... Well, it might be trivial, but i have no time to look at it, i'm afraid. Be really good to get it back, though.

Wed, Mar 27, 12:45 PM · Calligra: 3.0
leinir added inline comments to D19943: Small cleanups for qml components.
Wed, Mar 27, 12:40 PM · Calligra: 3.0
leinir updated the diff for D20077: Accept any HTTP status between 100 and 199 as benign.

Just accept any informational status as benign, rather than the specifically picked ones.

Wed, Mar 27, 12:12 PM · KNewStuff, Frameworks
leinir added a comment to D20077: Accept any HTTP status between 100 and 199 as benign.
In D20077#439290, @apol wrote:

And why are 101 and 102 bad?
Should we just accept between 100 and 200?

Wed, Mar 27, 12:07 PM · KNewStuff, Frameworks
leinir requested review of D20077: Accept any HTTP status between 100 and 199 as benign.
Wed, Mar 27, 11:11 AM · KNewStuff, Frameworks

Mar 20 2019

leinir requested review of D19925: Split up subcategories for KNS categories.
Mar 20 2019, 6:06 PM · Plasma, Discover Software Store
leinir closed D19917: Additions for ProviderManager documentation.
Mar 20 2019, 4:27 PM · KNewStuff, Frameworks
leinir committed R235:533b31b5d6f9: Additions for ProviderManager documentation (authored by leinir).
Additions for ProviderManager documentation
Mar 20 2019, 4:27 PM
leinir added inline comments to D19917: Additions for ProviderManager documentation.
Mar 20 2019, 4:04 PM · KNewStuff, Frameworks
leinir requested review of D19917: Additions for ProviderManager documentation.
Mar 20 2019, 3:59 PM · KNewStuff, Frameworks

Mar 19 2019

leinir closed D19899: Adapt leaf Category names for kns backend, and ensure correct filters.
Mar 19 2019, 9:59 PM · Discover Software Store, Plasma
leinir committed R134:c4e8f04a2489: Adapt leaf Category names for kns backend, and ensure correct filters (authored by leinir).
Adapt leaf Category names for kns backend, and ensure correct filters
Mar 19 2019, 9:59 PM
leinir committed R134:356fe5019436: Fix crash in category comparison caused by incorrect filters (authored by leinir).
Fix crash in category comparison caused by incorrect filters
Mar 19 2019, 9:59 PM
leinir closed D19880: Fix crash in category comparison caused by incorrect filters.
Mar 19 2019, 9:59 PM · Plasma, Discover Software Store
leinir committed R304:88ffd3cce725: Set category on Attica entries (authored by leinir).
Set category on Attica entries
Mar 19 2019, 9:54 PM
leinir closed D19900: Set category on Attica entries.
Mar 19 2019, 9:54 PM · Frameworks, KNewStuff
leinir updated the diff for D19880: Fix crash in category comparison caused by incorrect filters.

Remove some future-leftovers

Mar 19 2019, 9:38 PM · Plasma, Discover Software Store
leinir requested review of D19900: Set category on Attica entries.
Mar 19 2019, 9:02 PM · Frameworks, KNewStuff
leinir requested review of D19899: Adapt leaf Category names for kns backend, and ensure correct filters.
Mar 19 2019, 9:00 PM · Discover Software Store, Plasma
leinir closed T10635: Export category name or ID with all content items as Resolved.

This turns out to already exist, just under a different name. typeid and typename are exactly the category id and human readable category name. Everything is great, thank you very much :)

Mar 19 2019, 5:27 PM · KDE Store
leinir committed R134:eccaa65c9672: Ignore source packages when adding them to the PK list (authored by leinir).
Ignore source packages when adding them to the PK list
Mar 19 2019, 4:48 PM
leinir renamed T10635: Export category name or ID with all content items from Export category name with all content items to Export category name or ID with all content items.
Mar 19 2019, 11:28 AM · KDE Store
leinir requested review of D19880: Fix crash in category comparison caused by incorrect filters.
Mar 19 2019, 11:13 AM · Plasma, Discover Software Store

Mar 18 2019

leinir added a watcher for KDE Store: leinir.
Mar 18 2019, 9:10 PM
leinir created T10635: Export category name or ID with all content items.
Mar 18 2019, 8:53 PM · KDE Store
leinir committed R304:2a40085fc3d2: Handle unsupported OCS commands, and don't over-vote (authored by leinir).
Handle unsupported OCS commands, and don't over-vote
Mar 18 2019, 3:44 PM
leinir closed D19858: Handle unsupported OCS commands, and don't over-vote.
Mar 18 2019, 3:44 PM · Frameworks, KNewStuff
leinir added a comment to D19858: Handle unsupported OCS commands, and don't over-vote.

Thanks! Makes sense, and fixes the bug. :)

Of course the underlying issue is still present. If you can't vote from the GHNS dialogs, there shouldn't be a UI for let you try; it should be strictly read-only. I suppose that's a separate matter though.

Mar 18 2019, 3:40 PM · Frameworks, KNewStuff
leinir updated the diff for D19858: Handle unsupported OCS commands, and don't over-vote.

Copypasta error... thanks Nate :)

Mar 18 2019, 3:31 PM · Frameworks, KNewStuff
leinir added inline comments to D19858: Handle unsupported OCS commands, and don't over-vote.
Mar 18 2019, 3:30 PM · Frameworks, KNewStuff
leinir requested review of D19858: Handle unsupported OCS commands, and don't over-vote.
Mar 18 2019, 3:25 PM · Frameworks, KNewStuff
leinir accepted D19826: kns: Show subcategories for things that have one.

Nifty :)

Mar 18 2019, 2:07 PM · Plasma
leinir committed R134:ffc6023c5412: Add support for applications in KNSBackend (authored by leinir).
Add support for applications in KNSBackend
Mar 18 2019, 1:17 PM
leinir closed D19837: Add support for applications in KNSBackend.
Mar 18 2019, 1:17 PM · Plasma, Discover Software Store
leinir updated the diff for D19837: Add support for applications in KNSBackend.

Address various comments, and also fix one issue discovered while addressing those

Mar 18 2019, 11:43 AM · Plasma, Discover Software Store
leinir added inline comments to D19837: Add support for applications in KNSBackend.
Mar 18 2019, 11:42 AM · Plasma, Discover Software Store
leinir added a comment to D19837: Add support for applications in KNSBackend.

Can you edit the test plan to indicate the name of an app from the store that now appears in Discover's Applications section? A quick test of this patch didn't reveal ExeQt or Treeline in Discover, which are visible on http://opendesktop.org.

Mar 18 2019, 9:19 AM · Plasma, Discover Software Store

Mar 17 2019

leinir accepted D19842: Port to the new install directory for knsrc files.

Ought to do the trick! :)

Mar 17 2019, 8:08 PM · Plasma
leinir requested review of D19837: Add support for applications in KNSBackend.
Mar 17 2019, 5:11 PM · Plasma, Discover Software Store
leinir requested changes to D19826: kns: Show subcategories for things that have one.

The rest looks nice and solid :)

Mar 17 2019, 1:49 PM · Plasma
leinir committed R304:d95afd3ea3af: Remove some erroneously left-in debug, and leave one warning (authored by leinir).
Remove some erroneously left-in debug, and leave one warning
Mar 17 2019, 1:17 PM
leinir committed R134:d617dd8e6a1e: Search new knsrc locations (authored by leinir).
Search new knsrc locations
Mar 17 2019, 9:33 AM
leinir closed D19340: Search new knsrc locations.
Mar 17 2019, 9:33 AM · Plasma, Discover Software Store

Mar 14 2019

leinir added a comment to D19340: Search new knsrc locations.

Nice. So do we need to change KNS providers/apps to install their files in the new location now?

Mar 14 2019, 2:13 PM · Plasma, Discover Software Store
leinir updated the diff for D19340: Search new knsrc locations.

Update to require 5.57, and also actually inspect the minor version rather than two instances of the major version.

Mar 14 2019, 11:49 AM · Plasma, Discover Software Store
leinir committed R304:be0412024a46: New location for KNSRC files (authored by leinir).
New location for KNSRC files
Mar 14 2019, 10:14 AM
leinir closed D19338: New location for KNSRC files.
Mar 14 2019, 10:14 AM · KNewStuff, Frameworks

Mar 13 2019

leinir added inline comments to D19340: Search new knsrc locations.
Mar 13 2019, 7:28 PM · Plasma, Discover Software Store
leinir added a comment to D19338: New location for KNSRC files.

Quick ping, be good to get this in sometime before it becomes late again... :)

Mar 13 2019, 11:58 AM · KNewStuff, Frameworks

Mar 11 2019

leinir accepted D19683: autotests: use new signal failedToLoad in ProviderTest.

This does seem very much sensible, yes, well thought :)

Mar 11 2019, 2:50 PM · Frameworks
leinir accepted D19672: [knewstuff] make it compile without foreach.

Looks good to me... None of the scary ones that'll trigger various nasty side effects as far as i can tell.

Mar 11 2019, 12:07 PM · Frameworks

Mar 7 2019

leinir committed R134:65d7fa3bbe07: Don't crash if the fwupd error is null (authored by leinir).
Don't crash if the fwupd error is null
Mar 7 2019, 9:40 AM
leinir closed D19561: Don't crash if the fwupd error is null.
Mar 7 2019, 9:40 AM · Discover Software Store, Plasma
leinir committed R134:1d8ab1561d0b: Don't crash if the fwupd error is null (authored by leinir).
Don't crash if the fwupd error is null
Mar 7 2019, 9:40 AM

Mar 6 2019

leinir added a comment to D19561: Don't crash if the fwupd error is null.
In D19561#425879, @apol wrote:

Cool, thanks! remember to land in 5.15.

Mar 6 2019, 3:01 PM · Discover Software Store, Plasma
leinir requested review of D19561: Don't crash if the fwupd error is null.
Mar 6 2019, 10:49 AM · Discover Software Store, Plasma

Mar 4 2019

leinir updated the diff for D19338: New location for KNSRC files.

Since 5.57, not 5.56

Mar 4 2019, 12:45 PM · KNewStuff, Frameworks

Feb 27 2019

leinir accepted D19387: Remove deprecated QSignalMapper.

Much simpler code run, there, lgtm :)

Feb 27 2019, 3:17 PM · Frameworks
leinir updated the diff for D19340: Search new knsrc locations.

Don't search fallback locations - we're trying to avoid crashes, so unless people update their installation locations, they don't get Discovered:tm: ;)

Feb 27 2019, 11:01 AM · Plasma, Discover Software Store
leinir added a comment to D19338: New location for KNSRC files.
In D19338#420303, @apol wrote:

+1 cool stuff!

this opens the possibility for files being both in /usr and /etc, can you make sure hell doesn't break loose when that happens?

Was these files look up was delegated entirely to KConfig?

Feb 27 2019, 9:46 AM · KNewStuff, Frameworks
leinir added inline comments to D19340: Search new knsrc locations.
Feb 27 2019, 9:41 AM · Plasma, Discover Software Store

Feb 26 2019

leinir added a dependency for D19340: Search new knsrc locations: D19338: New location for KNSRC files.
Feb 26 2019, 1:29 PM · Plasma, Discover Software Store
leinir added a dependent revision for D19338: New location for KNSRC files: D19340: Search new knsrc locations.
Feb 26 2019, 1:29 PM · KNewStuff, Frameworks
leinir requested review of D19340: Search new knsrc locations.
Feb 26 2019, 1:29 PM · Plasma, Discover Software Store
leinir requested review of D19338: New location for KNSRC files.
Feb 26 2019, 1:25 PM · KNewStuff, Frameworks

Feb 21 2019

leinir committed R858:632c9cce4a3b: Use PointingHand when hovering links in Label (authored by leinir).
Use PointingHand when hovering links in Label
Feb 21 2019, 11:54 AM
leinir closed D19179: Use PointingHand when hovering links in Label.
Feb 21 2019, 11:54 AM · Plasma, Kirigami