leinir (Dan Leinir Turthra Jensen)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 8 2015, 8:34 AM (223 w, 3 d)
Availability
Available

Recent Activity

Today

leinir updated the diff for D24754: Fix KNSCore::Cache fetching when initialising Engine.
  • Ensure that the config filename only has the base name
Sat, Oct 19, 9:19 AM · Frameworks

Yesterday

leinir added reviewers for D24754: Fix KNSCore::Cache fetching when initialising Engine: rikmills, Frameworks, KNewStuff.
Fri, Oct 18, 11:07 AM · Frameworks
leinir updated the diff for D24754: Fix KNSCore::Cache fetching when initialising Engine.
  • Revert unrelated change
Fri, Oct 18, 11:06 AM · Frameworks
leinir requested review of D24754: Fix KNSCore::Cache fetching when initialising Engine.
Fri, Oct 18, 11:04 AM · Frameworks
leinir accepted D24650: Use ECMGenerateExportHeader to manage deprecated API better.

Very nicely, go for it :)

Fri, Oct 18, 8:06 AM · Frameworks
leinir accepted D24681: Use ECMGenerateExportHeader to manage deprecated API better.

No support for EXCLUDE_DEPRECATED_BEFORE_AND_AT, as some deprecated API is still used internally, so this needs more clean-up by someone(tm) first.

Fri, Oct 18, 8:05 AM · Frameworks

Tue, Oct 15

leinir created T11879: Implement vote call for OCS controller.
Tue, Oct 15, 8:52 AM · KDE Store

Thu, Oct 10

leinir committed R157:7b0d811efdf3: Simplify the holyrects a touch (by having more of them...) (authored by leinir).
Simplify the holyrects a touch (by having more of them...)
Thu, Oct 10, 2:38 PM
leinir committed R157:6ac3df677ef4: Add property to HolyRect to allow disabling hole-position animation (authored by leinir).
Add property to HolyRect to allow disabling hole-position animation
Thu, Oct 10, 2:38 PM
leinir committed R169:3f29408665a7: Mark an unused variable as unused (yay less warnings!) (authored by leinir).
Mark an unused variable as unused (yay less warnings!)
Thu, Oct 10, 8:49 AM

Thu, Oct 3

leinir accepted D24395: Add some std::move in setter functions.

Looks good :) If you could pop in a TODO KF6 comment, so it's not forgotten when we can, in fact, fix it properly, that'd be great :)

Thu, Oct 3, 5:14 PM · Frameworks

Tue, Oct 1

leinir committed R157:05fe847ba30d: Equalise the various import statements throught the qml code (authored by leinir).
Equalise the various import statements throught the qml code
Tue, Oct 1, 1:20 PM
leinir committed R157:c4f3c7a631e4: Actually require Qt 5.12 (and don't use bogus import versions) (authored by leinir).
Actually require Qt 5.12 (and don't use bogus import versions)
Tue, Oct 1, 11:19 AM
leinir closed D24156: Don't require QtGui for the PaginateModel test.
Tue, Oct 1, 10:45 AM · Plasma
leinir committed R134:120ee5cbb571: Don't require QtGui for the PaginateModel test (authored by leinir).
Don't require QtGui for the PaginateModel test
Tue, Oct 1, 10:45 AM
leinir added a comment to D24156: Don't require QtGui for the PaginateModel test.
In D24156#540238, @apol wrote:

I'm not sure what we're winning, but sure.

Tue, Oct 1, 10:23 AM · Plasma

Mon, Sep 30

leinir committed R157:5aaec35aae3a: Remove the magic globalUiScaleFactor cli thing, use devicePixelRatio (authored by leinir).
Remove the magic globalUiScaleFactor cli thing, use devicePixelRatio
Mon, Sep 30, 1:28 PM
leinir committed R157:fce7322a433e: Move some attr sets to before app creation (and add devicePixelRatio) (authored by leinir).
Move some attr sets to before app creation (and add devicePixelRatio)
Mon, Sep 30, 1:28 PM
leinir added a comment to D24141: Add page removal functionality to Peruse Creator.

I double checked, and if I remove pages from a file the filesize goes down, so it must be deleting properly :)

Mon, Sep 30, 8:16 AM · Peruse

Fri, Sep 27

leinir committed R304:140c0d0b7be8: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets) (authored by leinir).
Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)
Fri, Sep 27, 12:40 PM
leinir closed D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
Fri, Sep 27, 12:40 PM · Frameworks
leinir added a comment to D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).

Right, unless i hear otherwise, i'm going to push this 13:00 CEST (that is, in three hours). I realise this is short notice, but the patch has also been sitting here since before Akademy.

Fri, Sep 27, 8:12 AM · Frameworks

Thu, Sep 26

leinir added a comment to D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).

I would suggest to commit it either sooner, or after 5.63 is tagged. If you commit on 3rd, there are only two days to test and decide how to improve or revert before tars are made.

Thu, Sep 26, 7:24 PM · Frameworks
leinir added a comment to D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).

Alrighty, quick chat somewhere else, and i'm going to have to call silent agreement on this one - unless i hear things to the contrary, i'm going to merge this next week (that is, 2nd or 3rd of October 2019) so we can get a bit more wide-spread testing done on it before the next release rolls around. Thanks to those who reviewed already :)

Thu, Sep 26, 1:12 PM · Frameworks
leinir updated the diff for D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).

Ping @Frameworks - new cycle, chunky thing, be good to get it in early :)

Thu, Sep 26, 9:20 AM · Frameworks

Mon, Sep 23

leinir accepted D24141: Add page removal functionality to Peruse Creator.

Looks pretty good, but i'm not entirely certain... we might need to do some housekeeping in the zip file when removing pages, to ensure we don't leave graphics files behind that aren't referenced somewhere (cbzs are already large enough without stray files sitting around inside the archive)... but that seems perhaps like something that'd want to be in the save part of the process, maybe

I thought we were already completely rewriting the zip file in question? If not I'll take a look at ensuring only files that the bookmodel knows about are in the zip file.

Mon, Sep 23, 12:47 PM · Peruse
leinir added reviewers for D24156: Don't require QtGui for the PaginateModel test: Discover Software Store, bshah, apol.
Mon, Sep 23, 12:37 PM · Plasma
leinir requested review of D24156: Don't require QtGui for the PaginateModel test.
Mon, Sep 23, 12:36 PM · Plasma

Sun, Sep 22

leinir added a comment to D24141: Add page removal functionality to Peruse Creator.

Looks pretty good, but i'm not entirely certain... we might need to do some housekeeping in the zip file when removing pages, to ensure we don't leave graphics files behind that aren't referenced somewhere (cbzs are already large enough without stray files sitting around inside the archive)... but that seems perhaps like something that'd want to be in the save part of the process, maybe

Sun, Sep 22, 8:13 PM · Peruse

Fri, Sep 20

leinir requested review of D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).

Ping for some of the frameworks peeps... would be great to get this in sooner rather than later :)

Fri, Sep 20, 9:47 AM · Frameworks
leinir updated the diff for D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Fix some whitespace issues
Fri, Sep 20, 9:46 AM · Frameworks

Sep 19 2019

leinir committed R8:99c56bedcd36: Add enabled property to DocumentTile component (authored by leinir).
Add enabled property to DocumentTile component
Sep 19 2019, 3:51 PM
leinir committed R8:a0da8029e833: Rework the dialogues in Gemini's Cloud pages to Kirigami (authored by leinir).
Rework the dialogues in Gemini's Cloud pages to Kirigami
Sep 19 2019, 3:51 PM

Sep 18 2019

leinir updated the diff for D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).

Address comments by @ahiemstra

Sep 18 2019, 10:50 AM · Frameworks

Sep 17 2019

leinir committed R8:bad25e9c5d58: Also sort the QVector<QPoint> instances (just the two) (authored by leinir).
Also sort the QVector<QPoint> instances (just the two)
Sep 17 2019, 1:27 PM
leinir committed R8:5bdeb53ae255: Catch a few more of those QVector<QPointF> things... hopefully it (authored by leinir).
Catch a few more of those QVector<QPointF> things... hopefully it
Sep 17 2019, 12:50 PM
leinir committed R8:dfb4a9be2d6c: Also don't just use .begin with this... it'll still break (authored by leinir).
Also don't just use .begin with this... it'll still break
Sep 17 2019, 12:24 PM
leinir committed R8:73de6546cc65: More Windows iterator fixing... (authored by leinir).
More Windows iterator fixing...
Sep 17 2019, 11:47 AM
leinir committed R8:2d50f2e6b562: Rework iterators to work on windows again (authored by leinir).
Rework iterators to work on windows again
Sep 17 2019, 10:33 AM

Sep 16 2019

leinir committed R8:65a1941899a4: Switch to more Kirigami units (authored by leinir).
Switch to more Kirigami units
Sep 16 2019, 2:26 PM
leinir committed R8:5e7ebd496d93: Add option for debugging libemf (authored by leinir).
Add option for debugging libemf
Sep 16 2019, 2:26 PM
leinir committed R8:45ca655e7f1c: Make the document tile more reasonable when resized (authored by leinir).
Make the document tile more reasonable when resized
Sep 16 2019, 12:25 PM
leinir committed R8:112fe8b8abf0: Remove the no longer used CloudAccounts page (authored by leinir).
Remove the no longer used CloudAccounts page
Sep 16 2019, 12:25 PM
leinir committed R8:191bcd296f6c: Make the cloud welcome page more welcoming (authored by leinir).
Make the cloud welcome page more welcoming
Sep 16 2019, 12:25 PM
leinir committed R8:bbdb18a972c8: A touch of visibility juggling for Kirigami controls (authored by leinir).
A touch of visibility juggling for Kirigami controls
Sep 16 2019, 12:25 PM
leinir committed R8:e38bf7c16036: Kirigami page for MainPage (and make navigating back work) (authored by leinir).
Kirigami page for MainPage (and make navigating back work)
Sep 16 2019, 12:25 PM
leinir committed R8:68aaeed62182: Make RecentFileManager less potentially crashy (authored by leinir).
Make RecentFileManager less potentially crashy
Sep 16 2019, 12:25 PM
leinir committed R8:54c7db0e174c: Further work on Kirigamifying Calligra Gemini (authored by leinir).
Further work on Kirigamifying Calligra Gemini
Sep 16 2019, 12:25 PM
leinir committed R8:ddc4d7bd48b2: Add text to CloudModel entries' account details (authored by leinir).
Add text to CloudModel entries' account details
Sep 16 2019, 12:25 PM
leinir committed R8:befe8ce04119: Some cleanup and refactoring of the load process (authored by leinir).
Some cleanup and refactoring of the load process
Sep 16 2019, 12:24 PM
leinir committed R8:d66807d505b3: Actually sort the two Words subpages (authored by leinir).
Actually sort the two Words subpages
Sep 16 2019, 12:24 PM
leinir committed R8:36e841bf2852: Kirigamify the Stage welcomepage (authored by leinir).
Kirigamify the Stage welcomepage
Sep 16 2019, 12:24 PM
leinir committed R8:5f225d32e8af: Ensure the pages are given full width (authored by leinir).
Ensure the pages are given full width
Sep 16 2019, 12:24 PM
leinir committed R8:7529de8fd073: Rework the Words page as more Kirigami-esque (authored by leinir).
Rework the Words page as more Kirigami-esque
Sep 16 2019, 12:24 PM
leinir committed R8:6d460eff9d9d: Clean up recent and library pages a touch (authored by leinir).
Clean up recent and library pages a touch
Sep 16 2019, 12:24 PM
leinir committed R8:930772c24369: Add a context drawer, and set the app bar style (authored by leinir).
Add a context drawer, and set the app bar style
Sep 16 2019, 12:24 PM
leinir committed R8:dab25ceb0e08: Make the Calligra Gemini flow more Kirigami based (much more work to do) (authored by leinir).
Make the Calligra Gemini flow more Kirigami based (much more work to do)
Sep 16 2019, 12:24 PM
leinir committed R8:91842233eea4: Pull out the Document Tile as a component (authored by leinir).
Pull out the Document Tile as a component
Sep 16 2019, 12:24 PM

Sep 12 2019

leinir committed R8:bf90c0cd3357: Postpone the loading, remove crash in cloud support (authored by leinir).
Postpone the loading, remove crash in cloud support
Sep 12 2019, 3:03 PM
leinir committed R8:6480c5469e6c: Request delete through deleteLater (authored by leinir).
Request delete through deleteLater
Sep 12 2019, 3:03 PM
leinir committed R8:fc3401f3f9f4: Trust QPointer, and just clear the pointer (authored by leinir).
Trust QPointer, and just clear the pointer
Sep 12 2019, 3:03 PM
leinir accepted D23903: Remove dead icon loading code.

The code is referred to in src/ui/itemsviewdelegate.cpp:322 in a commented-out section, which will likely want to be reimplemented in some other way. However, the code is entirely unused, and i'm fine with this disappearing, that was more a comment for context :)

Sep 12 2019, 1:47 PM · Frameworks

Sep 9 2019

leinir updated the diff for D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Add a simple cache for CommentsModel instances
Sep 9 2019, 6:24 PM · Frameworks
leinir added inline comments to D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
Sep 9 2019, 4:19 PM · Frameworks
leinir updated the diff for D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).

Address comments by Kai Uwe and David

Sep 9 2019, 4:17 PM · Frameworks

Sep 8 2019

ognarb awarded D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets) a Love token.
Sep 8 2019, 2:24 PM · Frameworks

Sep 7 2019

leinir committed R157:8c27d0130c39: Sort out the action separators (authored by leinir).
Sort out the action separators
Sep 7 2019, 4:09 PM
leinir committed R157:7bc45c9df7b8: Some work on ensuring the view is restored when switching fullscreening (authored by leinir).
Some work on ensuring the view is restored when switching fullscreening
Sep 7 2019, 4:02 PM
leinir committed R157:1a1b254f9321: Minor bit of code clarity (authored by leinir).
Minor bit of code clarity
Sep 7 2019, 4:02 PM
leinir updated the diff for D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Add a getter for the first provider (usually the default)
  • Get the default provider, if one is not yet set
  • Handle the multi-provider scenario
Sep 7 2019, 1:13 PM · Frameworks
leinir accepted D23617: [gemini] Remove "template://" scheme from file name.

Long as that works on linux, that ought to do the trick, yes :) (probably ought to have been there to start with anyway)

Sep 7 2019, 8:11 AM · Calligra: 3.0

Sep 6 2019

leinir committed R157:8a8a6323d999: A touch of busy indication for the Store page (authored by leinir).
A touch of busy indication for the Store page
Sep 6 2019, 1:55 PM
leinir committed R157:91739f3a518f: Be slightly more helpful when interwebs are down (authored by leinir).
Be slightly more helpful when interwebs are down
Sep 6 2019, 1:55 PM
leinir committed R157:e39a5441556f: Use Kirigami.Action instead of QtObjects (authored by leinir).
Use Kirigami.Action instead of QtObjects
Sep 6 2019, 1:55 PM
leinir committed R157:83b126d32951: We're really working with pixmaps, so use requestPixmap (authored by leinir).
We're really working with pixmaps, so use requestPixmap
Sep 6 2019, 1:55 PM
leinir updated the diff for D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Also catch the error messages from the non-deprecated error function
  • Equalize border colour with Breeze
Sep 6 2019, 1:26 PM · Frameworks

Sep 2 2019

leinir requested changes to D23617: [gemini] Remove "template://" scheme from file name.

Something tells me there's going to be problems on windows if this gets done... since that is the precise reason that code exists in the first place: https://phabricator.kde.org/R8:c1866b590bd6103fdf118558834104be2737cca4

Sep 2 2019, 5:27 PM · Calligra: 3.0
leinir updated the diff for D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Make sure to import the right version of newstuff
Sep 2 2019, 1:19 PM · Frameworks
leinir updated the diff for D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Whole lot of @since-ing
  • Adopt Qt-style KF5-version-aligned import versioning
Sep 2 2019, 10:04 AM · Frameworks
leinir added a comment to D23617: [gemini] Remove "template://" scheme from file name.

That makes sense but none handle that schemes or should be responsible for that?

Sep 2 2019, 8:02 AM · Calligra: 3.0

Sep 1 2019

leinir added a comment to D23617: [gemini] Remove "template://" scheme from file name.

The idea is that the template protocol gets caught by the components, which marks the file as new, resets the filename and so on (the way you would expect a template to work). Doing it this way just opens the template as a file, and requires the user to manually do the save-as thing... Unless you are trying to actually edit the template, this isn't the solution... Create file will be something similar.

Sep 1 2019, 9:40 AM · Calligra: 3.0

Aug 30 2019

leinir updated the summary of D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
Aug 30 2019, 12:16 PM · Frameworks
leinir updated the diff for D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Fiddle with the downloaditems sheet layout a touch
Aug 30 2019, 12:15 PM · Frameworks
leinir accepted D23492: Correct anchor detection in QML components..

Oh dear, yes, took a moment. Well spotted indeed!

Aug 30 2019, 11:33 AM · Calligra: 3.0
leinir updated the diff for D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Switch to using a FileDialog-like property for changedEntries
Aug 30 2019, 9:54 AM · Frameworks
leinir added inline comments to D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
Aug 30 2019, 9:54 AM · Frameworks
leinir updated the summary of D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
Aug 30 2019, 9:40 AM · Frameworks
leinir updated the diff for D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Add a kf6 todo item (our api's QListey and should become QVectory)
  • Adopt a more pleasant comments layout
Aug 30 2019, 9:39 AM · Frameworks

Aug 29 2019

leinir updated the summary of D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
Aug 29 2019, 12:25 PM · Frameworks
leinir updated the diff for D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Debug--
  • Ensure data is actually loaded properly, also from cache
  • Include the right header
  • Adapt the Discover comments delegate (and add a nesting indicator)
Aug 29 2019, 12:23 PM · Frameworks

Aug 28 2019

leinir updated the diff for D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).

Address comments by @ahiemstra

Aug 28 2019, 3:02 PM · Frameworks
leinir added inline comments to D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
Aug 28 2019, 3:01 PM · Frameworks

Aug 27 2019

leinir updated the summary of D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
Aug 27 2019, 2:59 PM · Frameworks
leinir updated the summary of D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
Aug 27 2019, 12:38 PM · Frameworks
leinir updated the summary of D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
Aug 27 2019, 11:54 AM · Frameworks
leinir added reviewers for D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets): KNewStuff, VDG, Frameworks.
Aug 27 2019, 11:50 AM · Frameworks

Aug 24 2019

leinir updated the diff for D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Use the image's Ready status, rather than just the url availability
Aug 24 2019, 9:22 AM · Frameworks

Aug 23 2019

leinir added a comment to T11173: Expose (partial) person data for unauthorised users.

And there we go, ain't it a lovely thing ;)

Aug 23 2019, 3:00 PM · KDE Store
leinir updated the diff for D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Switch to a slightly different avatar display method
  • Rejig the lamdba slightly, with less indirection (and more working)
Aug 23 2019, 2:59 PM · Frameworks
leinir added a comment to T11173: Expose (partial) person data for unauthorised users.

Thank you very much :) i shall follow up with a screenshot when i've got it all happy :)

Aug 23 2019, 1:53 PM · KDE Store