leinir (Dan Leinir Turthra Jensen)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jul 8 2015, 8:34 AM (188 w, 5 d)
Availability
Available

Recent Activity

Thu, Feb 14

leinir added a comment to D18994: Update screenshots for Calligra sheets 3.1.

A quick note that you kind of got the name of the suite wrong in a few places, it's called Calligra, not Callibra :)

Thu, Feb 14, 1:26 PM · Documentation, Calligra: 3.0

Tue, Feb 12

leinir committed R304:1f4e1a6db756: Filter out invalid content in lists (authored by leinir).
Filter out invalid content in lists
Tue, Feb 12, 2:08 PM
leinir closed D18813: Filter out invalid content in lists.
Tue, Feb 12, 2:08 PM · Frameworks, KNewStuff
leinir accepted D18935: [kcmkwin/kwindecoration] Fix Get Hot New Stuff.

LGTM, yup! :) Sort of two things in one, there, but both good changes, so let's roll with it :)

Tue, Feb 12, 1:17 PM · KWin
leinir committed R134:8c673e79ab45: Set parent on newly created fwupd resource (authored by leinir).
Set parent on newly created fwupd resource
Tue, Feb 12, 10:54 AM
leinir closed D18946: Set parent on newly created fwupd resource.
Tue, Feb 12, 10:54 AM · Plasma, Discover Software Store
leinir updated the diff for D18946: Set parent on newly created fwupd resource.

Slightly different (and more central) approach. This ensures that resources are parented on creation rather than later (such as when being added to the updates list)

Tue, Feb 12, 10:43 AM · Plasma, Discover Software Store
leinir updated the summary of D18946: Set parent on newly created fwupd resource.
Tue, Feb 12, 10:34 AM · Plasma, Discover Software Store
leinir requested review of D18946: Set parent on newly created fwupd resource.
Tue, Feb 12, 10:33 AM · Plasma, Discover Software Store

Fri, Feb 8

leinir updated the diff for D18813: Filter out invalid content in lists.

Swap the logic around a bit, makes for an easier to read patch and whatnot.

Fri, Feb 8, 11:46 AM · Frameworks, KNewStuff
leinir added inline comments to D18813: Filter out invalid content in lists.
Fri, Feb 8, 11:45 AM · Frameworks, KNewStuff

Thu, Feb 7

leinir requested review of D18813: Filter out invalid content in lists.
Thu, Feb 7, 1:54 PM · Frameworks, KNewStuff

Tue, Feb 5

leinir committed R134:b11cdd776c93: Don't accept invalid KNS EntryInternal results (authored by leinir).
Don't accept invalid KNS EntryInternal results
Tue, Feb 5, 4:43 PM
leinir closed D18760: Don't accept invalid KNS EntryInternal results.
Tue, Feb 5, 4:43 PM · Plasma, Discover Software Store
leinir added a comment to D18760: Don't accept invalid KNS EntryInternal results.
In D18760#405894, @apol wrote:

Good, now I just wonder why KNS would give us poised entries...

Tue, Feb 5, 4:41 PM · Plasma, Discover Software Store
leinir updated the diff for D18760: Don't accept invalid KNS EntryInternal results.

Actually use the filtered list of entries

Tue, Feb 5, 4:37 PM · Plasma, Discover Software Store
leinir added inline comments to D18760: Don't accept invalid KNS EntryInternal results.
Tue, Feb 5, 4:36 PM · Plasma, Discover Software Store
leinir requested review of D18760: Don't accept invalid KNS EntryInternal results.
Tue, Feb 5, 1:54 PM · Plasma, Discover Software Store
leinir committed R134:003fc9fc9800: Add a timeout for KNS backends (authored by leinir).
Add a timeout for KNS backends
Tue, Feb 5, 1:21 PM
leinir closed D18724: Add a timeout for KNS backends.
Tue, Feb 5, 1:21 PM · Plasma, Discover Software Store
leinir added inline comments to D18724: Add a timeout for KNS backends.
Tue, Feb 5, 11:14 AM · Plasma, Discover Software Store

Mon, Feb 4

leinir added a reviewer for D18724: Add a timeout for KNS backends: davidedmundson.
Mon, Feb 4, 2:19 PM · Plasma, Discover Software Store
leinir requested review of D18724: Add a timeout for KNS backends.
Mon, Feb 4, 2:04 PM · Plasma, Discover Software Store

Fri, Jan 25

leinir committed R134:9144f96baa5c: Prettify and search enable the error page (authored by leinir).
Prettify and search enable the error page
Fri, Jan 25, 9:28 AM
leinir closed D18318: Prettify and search enable the error page.
Fri, Jan 25, 9:28 AM · Plasma, Discover Software Store

Thu, Jan 24

leinir updated the diff for D18318: Prettify and search enable the error page.

Hmm... yes, it does seem just perhaps a little more, hmm, pleasing i guess, for lack of a more technical way to say "it looks nice" ;) and most of the time that string will be a little bit shorter than it is, so... yup, updated patch, swapped enormous for huge :)

Thu, Jan 24, 9:37 AM · Plasma, Discover Software Store

Wed, Jan 23

leinir updated the diff for D18318: Prettify and search enable the error page.

In fact, don't need that outer item, so removing that

Wed, Jan 23, 3:06 PM · Plasma, Discover Software Store
leinir updated the diff for D18318: Prettify and search enable the error page.

Try and pop the the icon above the text, and just use iconsize enormous rather than a hardcoded one, and also raise the whole thing just a bit. And since the plan is to not use a similar layout on the updates page in short order, let's just not componentise this just yet, so now it just looks kind of nice all 'round :)

Wed, Jan 23, 2:57 PM · Plasma, Discover Software Store

Mon, Jan 21

leinir updated the diff for D18318: Prettify and search enable the error page.

Changes as discussed: The component is now all nice and centered, and the icon is fully opaque. Yup, much prettier all 'round, and would be nice and easy to turn into a full-on component :)

Mon, Jan 21, 11:33 AM · Plasma, Discover Software Store
leinir added a comment to D18318: Prettify and search enable the error page.

+1 for always showing the search field. But that icon looks a bit big. I might make it smaller and lose the opacity.

Also, while we're prettifying the error page, how about vertically centering everything too?

Mon, Jan 21, 10:25 AM · Plasma, Discover Software Store

Jan 18 2019

leinir committed R134:9aa0a7df1395: Search-enable the application page (authored by leinir).
Search-enable the application page
Jan 18 2019, 9:06 AM
leinir closed D18320: Search-enable the application page.
Jan 18 2019, 9:06 AM · Plasma, Discover Software Store
leinir added a comment to D18320: Search-enable the application page.

Thanks for the copious code comments. Definitely makes things easier to understand in the future.

Jan 18 2019, 9:03 AM · Plasma, Discover Software Store
leinir added a comment to D18318: Prettify and search enable the error page.

Yes, quite, of course :D Was going to post one and got sidetracked ;)

Jan 18 2019, 9:01 AM · Plasma, Discover Software Store

Jan 17 2019

leinir requested review of D18320: Search-enable the application page.
Jan 17 2019, 1:59 PM · Plasma, Discover Software Store
leinir requested review of D18318: Prettify and search enable the error page.
Jan 17 2019, 1:56 PM · Plasma, Discover Software Store

Jan 16 2019

leinir created T10359: Architecture based filtering for KNS backend.
Jan 16 2019, 11:28 AM · Discover Software Store

Jan 15 2019

leinir committed R134:88e315953fc0: Ensure only one allInitialised emission (authored by leinir).
Ensure only one allInitialised emission
Jan 15 2019, 1:27 PM
leinir closed D18262: Ensure only one allInitialised emission.
Jan 15 2019, 1:27 PM · Discover Software Store, Plasma
leinir requested review of D18262: Ensure only one allInitialised emission.
Jan 15 2019, 1:05 PM · Discover Software Store, Plasma
leinir committed R134:798514c11668: Fix premature firing of allInitialized signal (authored by leinir).
Fix premature firing of allInitialized signal
Jan 15 2019, 9:19 AM
leinir closed D18246: Fix premature firing of allInitialized signal.
Jan 15 2019, 9:19 AM · Plasma, Discover Software Store
leinir added a comment to D18246: Fix premature firing of allInitialized signal.

Nice catch. Looks like this might fix 401334?

Jan 15 2019, 8:55 AM · Plasma, Discover Software Store

Jan 14 2019

leinir requested review of D18246: Fix premature firing of allInitialized signal.
Jan 14 2019, 3:34 PM · Plasma, Discover Software Store

Jan 12 2019

leinir committed R304:301fe73569ba: Fix semantics for ghns_exclude (authored by leinir).
Fix semantics for ghns_exclude
Jan 12 2019, 4:29 PM
leinir closed D18038: Fix semantics for ghns_exclude.
Jan 12 2019, 4:29 PM · KDE Store, Frameworks, KNewStuff
leinir updated the summary of D18038: Fix semantics for ghns_exclude.
Jan 12 2019, 3:48 PM · KDE Store, Frameworks, KNewStuff
leinir added a comment to D18038: Fix semantics for ghns_exclude.

Thanks, in addition to the testing tool working, this patch seems to actually fix the issue in production (e.g. "Tree on Island" is no longer visible in the wallpaper downloader), and as far as I can tell the code is sane. Thanks for the additional documentation and commenting too.

Should this be marked as actually fixing 402888? If so, it should be BUG: 402888

Jan 12 2019, 3:48 PM · KDE Store, Frameworks, KNewStuff

Jan 11 2019

leinir updated the summary of D18180: Fix layout issues in the AboutPage personDelegate component.
Jan 11 2019, 11:18 AM · Kirigami
leinir added a comment to D18180: Fix layout issues in the AboutPage personDelegate component.

Before (after resizing):

Jan 11 2019, 11:17 AM · Kirigami
leinir requested review of D18180: Fix layout issues in the AboutPage personDelegate component.
Jan 11 2019, 11:15 AM · Kirigami
leinir added a comment to D18038: Fix semantics for ghns_exclude.

What is the test tool? Can you help a total n00b like me learn how to test KNewStuff patches like these?

Jan 11 2019, 8:42 AM · KDE Store, Frameworks, KNewStuff

Jan 10 2019

leinir closed D18150: Unbreak the AboutPage layout on smaller devices.
Jan 10 2019, 2:38 PM · Kirigami
leinir committed R169:de624a35bd52: Unbreak the AboutPage layout on smaller devices (authored by leinir).
Unbreak the AboutPage layout on smaller devices
Jan 10 2019, 2:38 PM
leinir added a comment to D18150: Unbreak the AboutPage layout on smaller devices.
In D18150#390493, @apol wrote:

Can you show a screenshot of before/after so I understand? So far it looks a bit random.

Jan 10 2019, 1:35 PM · Kirigami
leinir requested review of D18150: Unbreak the AboutPage layout on smaller devices.
Jan 10 2019, 10:29 AM · Kirigami

Jan 9 2019

leinir added a reviewer for D18038: Fix semantics for ghns_exclude: ngraham.
Jan 9 2019, 9:15 AM · KDE Store, Frameworks, KNewStuff

Jan 7 2019

leinir requested review of D18038: Fix semantics for ghns_exclude.
Jan 7 2019, 1:30 PM · KDE Store, Frameworks, KNewStuff

Jan 4 2019

leinir committed R169:99e9679b44af: Fix static Kirigami (about page etc) (authored by leinir).
Fix static Kirigami (about page etc)
Jan 4 2019, 1:31 PM
leinir closed D17961: Fix static Kirigami (about page etc).
Jan 4 2019, 1:31 PM · Kirigami
leinir requested review of D17961: Fix static Kirigami (about page etc).
Jan 4 2019, 1:06 PM · Kirigami

Dec 19 2018

leinir accepted D17593: Notify if a default provider failed to download.

Hm, definitely yes. Frankly i thought this already happened, goes to show what assumptions make of us, eh? ;)

Dec 19 2018, 5:10 PM · Frameworks
leinir accepted D17594: Notify about the provider not being loaded.

Oh wow, ouch, yes that should definitely be happening. Well caught, thank you! :)

Dec 19 2018, 5:06 PM · Frameworks

Dec 5 2018

leinir added inline comments to D17334: Export enum into qobject for easier debugging.
Dec 5 2018, 12:23 PM · Frameworks
leinir accepted D17334: Export enum into qobject for easier debugging.

Good call there, yup :)

Dec 5 2018, 11:23 AM · Frameworks

Nov 30 2018

leinir added a comment to T10138: Avatar URL.

That's indeed good inspiration - don't really see a reason not to follow their examples, so for the options, instead of the magic stuff above, we could do...

Nov 30 2018, 10:13 AM · KDE Store

Nov 29 2018

leinir created T10138: Avatar URL.
Nov 29 2018, 2:59 PM · KDE Store
leinir added inline comments to D17216: Move the about page from Discover to Kirigami.
Nov 29 2018, 12:10 PM · Kirigami

Nov 28 2018

leinir accepted D17177: Drop tab-based UI for the about page.

Lovin' it - i also like how sort of... well, how little code there really is here, QML done absolutely the right way, only the presentation and that's it, nifty :)

Nov 28 2018, 9:55 AM · Plasma

Nov 27 2018

leinir added a comment to D17177: Drop tab-based UI for the about page.

Ah yes, somehow i managed to miss the button @colomar mentions, which does the bug reporting linkage already. Removing the link in favour of just keeping that button seems a sensible option :)

Nov 27 2018, 2:26 PM · Plasma
leinir requested changes to D17177: Drop tab-based UI for the about page.

It does seem that the bugAddress being an email address is a bit odd... The address given by KAboutData::bugAddress can be either an email address, or a URL, though, so it might make sense to try and handle either case (something as simple as checking for :// in the string would probably work), to make the functionality here functionally equivalent to the qwidget dialogue.

Nov 27 2018, 2:22 PM · Plasma

Nov 22 2018

leinir added a comment to D17079: Provide a qqc2/kirigami-based about page.

Basically what Nate said, this is a great idea :) Thinking that having this is already an improvement, but also perhaps that having it as a scrollable page would indeed feel more natural here rather than tabs... Thinking this seems like a good place to use the fact that Cards are good for not-quite-similar data, or am i off there?

Nov 22 2018, 12:56 PM · Plasma

Nov 21 2018

leinir accepted D17058: Fix android build.

Thanks! :)

Nov 21 2018, 10:38 AM

Nov 20 2018

leinir committed R134:8bea95730eab: Allow clicking of links in app descriptions (authored by leinir).
Allow clicking of links in app descriptions
Nov 20 2018, 2:32 PM
leinir closed D17050: Allow clicking of links in app descriptions.
Nov 20 2018, 2:32 PM · Discover Software Store, Plasma
leinir requested review of D17050: Allow clicking of links in app descriptions.
Nov 20 2018, 1:52 PM · Discover Software Store, Plasma

Nov 19 2018

leinir committed R134:49229f398abd: We now have a hard dependency on KNewStuff 5.53 (authored by leinir).
We now have a hard dependency on KNewStuff 5.53
Nov 19 2018, 9:54 AM

Nov 14 2018

leinir created T10032: Allow creators to add ghns_exclude to their own content items.
Nov 14 2018, 9:47 AM · KDE Store

Nov 13 2018

leinir updated subscribers of R134:7f6caf385809: Better error handling in KNewStuff backend.

Through pushing this patch, i have discovered there is no easily discoverable documentation regarding when Frameworks are updated for unstable builds. According to https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.11/68/console KF 5.53 is found, but the version being found does not include the patch pushed to KNewStuff yesterday (D16665). I did think there was some reasonable timing for updating Frameworks for other CI builds, and so left it overnight. However, this turns out not to be long enough. Am i simply unable to find this documentation (and wrong in thinking that https://community.kde.org/Policies would be the right place), or is such documentation simply not available? It would be terribly handy to know. I did ask on #kde-devel on freenode, but nobody there seemed to know either.

Nov 13 2018, 1:24 PM
leinir committed R304:3b270a216664: Mark new public bits as since 5.53 (authored by leinir).
Mark new public bits as since 5.53
Nov 13 2018, 9:16 AM
leinir committed R134:7f6caf385809: Better error handling in KNewStuff backend (authored by leinir).
Better error handling in KNewStuff backend
Nov 13 2018, 9:09 AM
leinir closed D16776: Better error handling in KNewStuff backend.
Nov 13 2018, 9:09 AM · Discover Software Store, Plasma

Nov 12 2018

leinir committed R304:e8e3160cd20c: Add programmaticaly useful error signalling (authored by leinir).
Add programmaticaly useful error signalling
Nov 12 2018, 12:41 PM
leinir closed D16665: Add programmaticaly useful error signalling.
Nov 12 2018, 12:41 PM · KNewStuff, Frameworks
leinir updated the diff for D16776: Better error handling in KNewStuff backend.

Address @apol's comments

Nov 12 2018, 11:39 AM · Discover Software Store, Plasma
leinir added a comment to D16776: Better error handling in KNewStuff backend.
In D16776#356741, @apol wrote:

Where will the All categories are missing error fall right now?

Nov 12 2018, 11:37 AM · Discover Software Store, Plasma

Nov 9 2018

leinir added a dependent revision for D16665: Add programmaticaly useful error signalling: D16776: Better error handling in KNewStuff backend.
Nov 9 2018, 12:05 PM · KNewStuff, Frameworks
leinir added a dependency for D16776: Better error handling in KNewStuff backend: D16665: Add programmaticaly useful error signalling.
Nov 9 2018, 12:05 PM · Discover Software Store, Plasma
leinir requested review of D16776: Better error handling in KNewStuff backend.
Nov 9 2018, 11:57 AM · Discover Software Store, Plasma

Nov 7 2018

leinir added a comment to D16665: Add programmaticaly useful error signalling.
In D16665#355578, @apol wrote:

Maybe it would be good to produce the Discover patch before committing this to make sure the API is the one we want.

Nov 7 2018, 2:03 PM · KNewStuff, Frameworks
leinir updated the diff for D16665: Add programmaticaly useful error signalling.

Adjust the patch to address @apol's comment about deprecating the old error signal

Nov 7 2018, 1:31 PM · KNewStuff, Frameworks
leinir added inline comments to D16665: Add programmaticaly useful error signalling.
Nov 7 2018, 1:14 PM · KNewStuff, Frameworks

Nov 4 2018

leinir requested review of D16665: Add programmaticaly useful error signalling.
Nov 4 2018, 4:38 PM · KNewStuff, Frameworks

Oct 9 2018

leinir added a comment to D15053: Consistently use qreal in libs/pigment.

@dcaliste @anthonyfieroni Any updates here, pro/con? Would be a terrible shame to let this fall through :)

Oct 9 2018, 9:12 AM · Calligra: 3.0

Oct 8 2018

leinir accepted D15951: Add opening a file via the command line..

Looks good from here - unless @pino has further to add, go for it :)

Oct 8 2018, 10:57 AM · Peruse

Oct 5 2018

leinir added inline comments to D15951: Add opening a file via the command line..
Oct 5 2018, 12:45 PM · Peruse
leinir added inline comments to D15951: Add opening a file via the command line..
Oct 5 2018, 11:30 AM · Peruse

Oct 1 2018

leinir accepted D15820: Update database when booklist is updated..

bindValue is a good choice, yes, thank you ;) Go for it :)

Oct 1 2018, 12:23 PM · Peruse
leinir committed R304:158ba4e2420b: Add support for Attica tags support (authored by leinir).
Add support for Attica tags support
Oct 1 2018, 11:49 AM
leinir closed D6513: Add support for Attica tags support.
Oct 1 2018, 11:49 AM · Frameworks, KNewStuff