leinir (Dan Leinir Turthra Jensen)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jul 8 2015, 8:34 AM (98 w, 5 d)
Availability
Available

Recent Activity

Thu, May 18

leinir updated the diff for D5902: Expand KNewStuff documentation.
Thu, May 18, 9:17 AM · Frameworks
leinir added inline comments to D5902: Expand KNewStuff documentation.
Thu, May 18, 8:50 AM · Frameworks

Wed, May 17

leinir added a reviewer for D5902: Expand KNewStuff documentation: KNewStuff.
Wed, May 17, 12:56 PM · Frameworks
leinir created D5902: Expand KNewStuff documentation.
Wed, May 17, 12:56 PM · Frameworks

Mon, May 15

leinir edited the description of T6133: Tags support in Ocsv1Controller.
Mon, May 15, 2:26 PM · KDE Store
leinir created T6133: Tags support in Ocsv1Controller.
Mon, May 15, 2:18 PM · KDE Store

Thu, May 11

leinir added a comment to D5769: Use Kirigami.Icon instead of QIconItem.

if we can trust that Kirigami 2.2 is released sometime in the not too distant future.

Will it be released publicly by Monday?

Thu, May 11, 2:04 PM · Plasma
leinir committed R304:b8d0bc8818ff: Use a single QNAM (and a disk cache) for HTTP jobs (authored by leinir).
Use a single QNAM (and a disk cache) for HTTP jobs
Thu, May 11, 1:14 PM
leinir closed D5638: Use a single QNAM (and a disk cache) for HTTP jobs by committing R304:b8d0bc8818ff: Use a single QNAM (and a disk cache) for HTTP jobs.
Thu, May 11, 1:14 PM · Frameworks
leinir committed R304:6207a87b71d7: Internal cache for provider data on initialisation (authored by leinir).
Internal cache for provider data on initialisation
Thu, May 11, 1:13 PM
leinir closed D5639: Internal cache for provider data on initialisation by committing R304:6207a87b71d7: Internal cache for provider data on initialisation.
Thu, May 11, 1:13 PM · Frameworks
leinir accepted D5811: Improve error notification.

lgtm :)

Thu, May 11, 1:04 PM · Frameworks
leinir committed R134:361f408eb00c: Use Kirigami.Icon instead of QIconItem (authored by leinir).
Use Kirigami.Icon instead of QIconItem
Thu, May 11, 1:00 PM
leinir closed D5769: Use Kirigami.Icon instead of QIconItem by committing R134:361f408eb00c: Use Kirigami.Icon instead of QIconItem.
Thu, May 11, 1:00 PM · Plasma

Mon, May 8

leinir added a comment to D5767: Postpone searches for half a human moment.
In D5767#108234, @apol wrote:

It could make sense to move this to the KNSBackend, any appstream-based backends don't have such a problem.

Mon, May 8, 9:30 PM · Plasma
leinir committed R169:e3293e9c05b5: Add support for remote image sources to DesktopIcon (authored by leinir).
Add support for remote image sources to DesktopIcon
Mon, May 8, 7:16 PM
leinir closed D5764: Add support for remote image sources to DesktopIcon by committing R169:e3293e9c05b5: Add support for remote image sources to DesktopIcon.
Mon, May 8, 7:16 PM · Kirigami
leinir added a comment to D5767: Postpone searches for half a human moment.
In D5767#108088, @markg wrote:

I don't think adding a (rather massive) delay is the real fix here. It only masks the actual issue.

What really happens (just opened the discover store for the first time ever) is that entries can flow in at any point, that might be an issue.
Every batch can contain items for any position in the in the store.

The query used to fetch the data should fetch it in order of appearance. That would fix the visual clutter issue you described.

Secondly (but this is outside the scope of this report) it should probably implement a incremental loading logic. Right now it seems to fetch everything.

Mon, May 8, 4:53 PM · Plasma
leinir added a comment to D5769: Use Kirigami.Icon instead of QIconItem.
In D5769#108014, @apol wrote:

This will add a dependency to Kirigami 2.2, is it something we can have?

Mon, May 8, 3:11 PM · Plasma
leinir added a comment to D5764: Add support for remote image sources to DesktopIcon.
In D5764#108019, @apol wrote:

Don't we also have to add support for when DesktopIcon::m_source is a QIcon?

Mon, May 8, 3:04 PM · Kirigami
leinir updated the diff for D5768: Use the first thumbnail as icon for KNS resources.

Have a slightly more useful fallback icon than just nothing (that is, if there is no first thumbnail, use the one it used previously)

Mon, May 8, 2:56 PM · Plasma
leinir created D5769: Use Kirigami.Icon instead of QIconItem.
Mon, May 8, 2:51 PM · Plasma
leinir created D5768: Use the first thumbnail as icon for KNS resources.
Mon, May 8, 2:48 PM · Plasma
leinir created D5767: Postpone searches for half a human moment.
Mon, May 8, 2:44 PM · Plasma
leinir created D5764: Add support for remote image sources to DesktopIcon.
Mon, May 8, 1:17 PM · Kirigami

Sun, May 7

leinir updated the diff for D5638: Use a single QNAM (and a disk cache) for HTTP jobs.

Work some numbers a bit

Sun, May 7, 5:30 PM · Frameworks
leinir added a comment to D5638: Use a single QNAM (and a disk cache) for HTTP jobs.

50000 is 50kB.
You wrote 50 megs which would be 50000000 or 50*1024*1024.

Sun, May 7, 5:28 PM · Frameworks
leinir updated the diff for D5639: Internal cache for provider data on initialisation.

Static var naming change, for consistency and whatnot

Sun, May 7, 5:18 PM · Frameworks
leinir added inline comments to D5639: Internal cache for provider data on initialisation.
Sun, May 7, 5:17 PM · Frameworks
leinir updated the diff for D5638: Use a single QNAM (and a disk cache) for HTTP jobs.

static var naming fix, for consistency with elsewhere

Sun, May 7, 5:16 PM · Frameworks
leinir updated the diff for D5638: Use a single QNAM (and a disk cache) for HTTP jobs.

A bit of naming cleanup, and a very silly miscalculation because things count in bytes rather than some arbitrary random multiple of them

Sun, May 7, 5:12 PM · Frameworks
leinir added inline comments to D5638: Use a single QNAM (and a disk cache) for HTTP jobs.
Sun, May 7, 5:10 PM · Frameworks
leinir updated the diff for D5639: Internal cache for provider data on initialisation.

Simplify the xmlloader cache logic a touch

Sun, May 7, 4:16 PM · Frameworks
leinir added inline comments to D5639: Internal cache for provider data on initialisation.
Sun, May 7, 4:15 PM · Frameworks
leinir updated the diff for D5638: Use a single QNAM (and a disk cache) for HTTP jobs.

Some style fixes, and set a reasonable maximum size for the cache

Sun, May 7, 4:13 PM · Frameworks
leinir added inline comments to D5638: Use a single QNAM (and a disk cache) for HTTP jobs.
Sun, May 7, 4:11 PM · Frameworks
leinir accepted D5739: Improve some error messages.
Sun, May 7, 2:02 PM · Frameworks

Fri, May 5

leinir updated the diff for D5638: Use a single QNAM (and a disk cache) for HTTP jobs.

Unpointerify the internals, as agreed

Fri, May 5, 8:44 AM · Frameworks

Tue, May 2

leinir updated the diff for D5639: Internal cache for provider data on initialisation.

Simplify the logic, and only do the xmlloader caching, not the documents themselves which (as apol points out) should be cached already anyway. Not only that, but that codepath was never triggered when i rechecked it after implementing the xmlloader cache, and so, simpler logic is a good thing. Adjusted summary to match.

Tue, May 2, 1:24 PM · Frameworks
leinir updated the diff for D5638: Use a single QNAM (and a disk cache) for HTTP jobs.

Simpler logic, with the global qnam (etc) stored in a locally defined class, so we only have the one global static, and also allowing the qnam access to be more pleasantly locked.

Tue, May 2, 1:20 PM · Frameworks
leinir added inline comments to D5638: Use a single QNAM (and a disk cache) for HTTP jobs.
Tue, May 2, 1:18 PM · Frameworks
leinir added a comment to D5639: Internal cache for provider data on initialisation.
In D5639#105620, @apol wrote:

Won't caching already fix the problem of traffic there? This change adds quite some complexity (all these QMutex make me cringe, these methods should always be called from the same thread anyway...)

Tue, May 2, 8:53 AM · Frameworks

Apr 28 2017

leinir created D5639: Internal cache for provider data on initialisation.
Apr 28 2017, 1:26 PM · Frameworks
leinir created D5638: Use a single QNAM (and a disk cache) for HTTP jobs.
Apr 28 2017, 1:20 PM · Frameworks
leinir accepted D5616: Set up a cache for attica.

Looks good to me! :) i am employing a similar method in an upcoming KNS patch, so i will equalise the paths and whatnot in that one, so things are nice and clear :)

Apr 28 2017, 12:56 PM · Plasma

Apr 26 2017

leinir accepted D5587: Improvements.

Looks good to me :)

Apr 26 2017, 8:30 AM · Frameworks

Apr 23 2017

leinir committed R8:0fe4f0e4bb98: Don't have checkable menu actions (authored by leinir).
Don't have checkable menu actions
Apr 23 2017, 3:58 PM

Apr 18 2017

leinir committed R134:639bf33c0192: Queue some connections which cannot be autodetected (authored by leinir).
Queue some connections which cannot be autodetected
Apr 18 2017, 12:28 PM
leinir closed D5409: Queue some connections which cannot be autodetected by committing R134:639bf33c0192: Queue some connections which cannot be autodetected.
Apr 18 2017, 12:28 PM · Plasma
leinir committed R169:c06013e88e4f: Don't forward keys until the recipient is ready (authored by leinir).
Don't forward keys until the recipient is ready
Apr 18 2017, 10:49 AM
leinir closed D5408: Don't forward keys until the recipient is ready by committing R169:c06013e88e4f: Don't forward keys until the recipient is ready.
Apr 18 2017, 10:48 AM · Kirigami

Apr 16 2017

leinir committed R8:05151b681bca: Fix the date part of the git log (authored by leinir).
Fix the date part of the git log
Apr 16 2017, 9:24 PM
leinir committed R8:e933e3d4b20d: Export things for the Gemini library (authored by leinir).
Export things for the Gemini library
Apr 16 2017, 9:23 PM

Apr 15 2017

leinir committed R8:c8374d00f5a5: Switch to Kirigami 2.1 (authored by leinir).
Switch to Kirigami 2.1
Apr 15 2017, 7:55 AM
leinir committed R8:0088b4b5a57f: Install components to KDE's qml install dir (authored by leinir).
Install components to KDE's qml install dir
Apr 15 2017, 7:55 AM
leinir committed R8:701d435f75c9: Merge remote-tracking branch 'origin/master' into calligra-gemini-leinir (authored by leinir).
Merge remote-tracking branch 'origin/master' into calligra-gemini-leinir
Apr 15 2017, 7:55 AM

Apr 13 2017

leinir updated the diff for D5409: Queue some connections which cannot be autodetected.

Changed the KNS backend's main queued connection to somewhere a tiny bit more central. This causes us to require KNewStuff master, but we already require a bunch of master stuff elsewhere, so, you know, not so big an issue anyway :)

Apr 13 2017, 1:08 PM · Plasma
leinir added inline comments to D5409: Queue some connections which cannot be autodetected.
Apr 13 2017, 1:03 PM · Plasma
leinir committed R304:7a8c2db4526a: Register and declare KNSCore::EntryInternal::List as a metatype (authored by leinir).
Register and declare KNSCore::EntryInternal::List as a metatype
Apr 13 2017, 1:02 PM
leinir committed R304:3941d4dd7039: Don't fall through the switch. Double entries? No please. (authored by leinir).
Don't fall through the switch. Double entries? No please.
Apr 13 2017, 1:02 PM
leinir added a comment to D5408: Don't forward keys until the recipient is ready.
In D5408#101657, @apol wrote:

Add BUG: 378339

Apr 13 2017, 8:22 AM · Kirigami
leinir updated the diff for D5408: Don't forward keys until the recipient is ready.

Add the missing check identified by Aleix. Thanks :)

Apr 13 2017, 8:20 AM · Kirigami

Apr 12 2017

leinir added a comment to D5409: Queue some connections which cannot be autodetected.
In D5409#101510, @apol wrote:

Are you sure? Which other threads? From the rendering?

Apr 12 2017, 12:11 PM · Plasma
leinir created D5409: Queue some connections which cannot be autodetected.
Apr 12 2017, 11:38 AM · Plasma
leinir created D5408: Don't forward keys until the recipient is ready.
Apr 12 2017, 11:33 AM · Kirigami
leinir accepted D5402: always close the downloaded file after downloading.

Yes, good catch. I am unsure of why that happened, but i quite agree, that certainly needs to happen whether or not a redirection has been involved.

Apr 12 2017, 8:13 AM · Frameworks, Plasma

Apr 5 2017

leinir committed R134:a8031fead6a6: Stop perpetual search state for StaticXml KNS stuff (authored by leinir).
Stop perpetual search state for StaticXml KNS stuff
Apr 5 2017, 11:24 AM
leinir closed D5240: Stop perpetual search state for StaticXml KNS stuff by committing R134:a8031fead6a6: Stop perpetual search state for StaticXml KNS stuff.
Apr 5 2017, 11:24 AM · Plasma

Apr 4 2017

leinir accepted D5166: introduce ApplicationItem.

i am inclined to ship this - there are the following couple of things which do show up, but the item works as expected anyway, and i now have a version of Calligra Gemini using Kirigami for a large part of its UI (there are details to be sorted as yet, including a not inconsiderable amount of UX reworking because of the old non-Kirigami-esque workflow design created by Cohere back in the day, but that is not caused by Kirigami, of course, and in particular not this item - so for the parts which are Kirigami-based now, it works :) )

Apr 4 2017, 9:41 AM · Kirigami

Mar 29 2017

leinir created D5240: Stop perpetual search state for StaticXml KNS stuff.
Mar 29 2017, 2:03 PM · Plasma

Mar 28 2017

leinir added inline comments to D5194: Make various bits of the Apper tool chain optional.
Mar 28 2017, 9:44 AM
leinir committed R549:b44657762de1: Reinsert the documentation build (authored by leinir).
Reinsert the documentation build
Mar 28 2017, 9:43 AM
leinir committed R549:ec6b72c544c1: Make various bits of the Apper tool chain optional (authored by leinir).
Make various bits of the Apper tool chain optional
Mar 28 2017, 9:09 AM
leinir closed D5194: Make various bits of the Apper tool chain optional by committing R549:ec6b72c544c1: Make various bits of the Apper tool chain optional.
Mar 28 2017, 9:09 AM
leinir committed R134:bdccef045c12: Mark "all categories missing" kns sources as invalid (authored by leinir).
Mark "all categories missing" kns sources as invalid
Mar 28 2017, 9:08 AM
leinir committed R134:73b61fcdf140: Implement UI feedback for long-running searches, and no-results (authored by leinir).
Implement UI feedback for long-running searches, and no-results
Mar 28 2017, 9:08 AM
leinir committed R134:8bb5178bd65e: Use the back function, rather than pop, when pressing Escape (authored by leinir).
Use the back function, rather than pop, when pressing Escape
Mar 28 2017, 9:08 AM
leinir closed D5146: Implement UI feedback for long-running searches, and no-results.

Closed by commit 73b61fcdf1408871de85d60c7341e283194b92c6

Mar 28 2017, 9:05 AM · Discover Software Store, Plasma

Mar 27 2017

leinir committed R549:2341630cfbd4: Port away from KUniqueApplication to QApplication with KDBusService (authored by leinir).
Port away from KUniqueApplication to QApplication with KDBusService
Mar 27 2017, 2:56 PM
leinir closed D5193: Port away from KUniqueApplication to QApplication with KDBusService.
Mar 27 2017, 1:34 PM
leinir added a comment to D5193: Port away from KUniqueApplication to QApplication with KDBusService.

Closed by commit https://commits.kde.org/apper/2341630cfbd40e3eaa98a4eceea0f64fbd9c58e3

Mar 27 2017, 1:34 PM
leinir added a comment to D5194: Make various bits of the Apper tool chain optional.
In D5194#97936, @apol wrote:

Can we split the parts we want into different repositories? This looks rather unpractical...

Mar 27 2017, 1:20 PM
leinir created D5194: Make various bits of the Apper tool chain optional.
Mar 27 2017, 12:25 PM
leinir created D5193: Port away from KUniqueApplication to QApplication with KDBusService.
Mar 27 2017, 12:11 PM

Mar 23 2017

leinir closed D5148: Use the back function, rather than pop, when pressing Escape.

Closed by commit efe7d505eb294b11cc6d513ed8448cd5b8eab668

Mar 23 2017, 12:44 PM · Plasma, Discover Software Store
leinir updated the summary of D5146: Implement UI feedback for long-running searches, and no-results.
Mar 23 2017, 12:44 PM · Discover Software Store, Plasma
leinir added a comment to D5146: Implement UI feedback for long-running searches, and no-results.
In D5146#97069, @mart wrote:

just an heads up: ui reviews with VDG as reviewers should have a screenshot attached

Mar 23 2017, 12:42 PM · Discover Software Store, Plasma
leinir closed D5147: Mark "all categories missing" kns sources as invalid.

Closed by commit 1db3b40cc4f979cc8c50dcfc1a41cddcce973ae7

Mar 23 2017, 12:38 PM · Discover Software Store, Plasma
leinir created D5148: Use the back function, rather than pop, when pressing Escape.
Mar 23 2017, 10:37 AM · Plasma, Discover Software Store
leinir created D5147: Mark "all categories missing" kns sources as invalid.
Mar 23 2017, 10:35 AM · Discover Software Store, Plasma
leinir created D5146: Implement UI feedback for long-running searches, and no-results.
Mar 23 2017, 10:34 AM · Discover Software Store, Plasma
leinir abandoned D5145: Mark "all categories missing" kns sources as invalid.

That, apparently, is not how arc works. Very sorry.

Mar 23 2017, 9:43 AM · Plasma
leinir created D5145: Mark "all categories missing" kns sources as invalid.
Mar 23 2017, 9:42 AM · Plasma

Mar 17 2017

leinir committed R134:eb8f4ae2b46a: UI feedback when checking for updates (authored by leinir).
UI feedback when checking for updates
Mar 17 2017, 9:46 AM
leinir closed D5046: UI feedback when checking for updates.

Closed by commit https://commits.kde.org/discover/eb8f4ae2b46a0516a99d26b25f120a5be28e910c

Mar 17 2017, 9:44 AM · Plasma, Discover Software Store

Mar 16 2017

leinir added a comment to D5046: UI feedback when checking for updates.
In D5046#95122, @apol wrote:

Have you tested what happens during the update? Does it change to "checking for updates"?

Mar 16 2017, 12:30 PM · Plasma, Discover Software Store

Mar 14 2017

leinir committed R134:02e9cd6399d3: Check the correct enabled property for updateButton background (authored by leinir).
Check the correct enabled property for updateButton background
Mar 14 2017, 1:10 PM
leinir created D5046: UI feedback when checking for updates.
Mar 14 2017, 1:05 PM · Plasma, Discover Software Store

Mar 13 2017

leinir committed R283:39621f485f43: Add support for killing a KAuth::ExecuteJob (authored by leinir).
Add support for killing a KAuth::ExecuteJob
Mar 13 2017, 8:49 AM
leinir closed D5001: Add support for killing a KAuth::ExecuteJob.

Closed by commit https://commits.kde.org/kauth/39621f485f434fb4453a1fd6af2796cde23eec53

Mar 13 2017, 8:47 AM · Frameworks