leinir (Dan Leinir Turthra Jensen)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jul 8 2015, 8:34 AM (124 w, 1 d)
Availability
Available

Recent Activity

Today

leinir committed R8:564772b9ed14: Use correct exports for the kinit mains (authored by leinir).
Use correct exports for the kinit mains
Thu, Nov 23, 12:01 PM
leinir committed R8:02358285a3bb: Build with not-gcc (authored by leinir).
Build with not-gcc
Thu, Nov 23, 12:01 PM
leinir committed R8:faad036201aa: Avoid duplicated symbols (authored by leinir).
Avoid duplicated symbols
Thu, Nov 23, 12:01 PM
leinir committed R8:2d5fd7646b32: Use QQC2.Label instead of Kirigami's (deprecated) one (authored by leinir).
Use QQC2.Label instead of Kirigami's (deprecated) one
Thu, Nov 23, 12:01 PM

Thu, Nov 16

leinir accepted D8811: [knewstuff] Do not leak ImageLoader on error.

Looks good to me :)

Thu, Nov 16, 1:52 PM · Frameworks, KNewStuff

Wed, Nov 15

leinir added inline comments to D8811: [knewstuff] Do not leak ImageLoader on error.
Wed, Nov 15, 1:05 PM · Frameworks, KNewStuff
leinir added inline comments to D8811: [knewstuff] Do not leak ImageLoader on error.
Wed, Nov 15, 12:46 PM · Frameworks, KNewStuff
leinir added inline comments to D8811: [knewstuff] Do not leak ImageLoader on error.
Wed, Nov 15, 11:49 AM · Frameworks, KNewStuff

Mon, Nov 13

leinir added a comment to R8:1bbb6e00022b: Port Calligra Gemini for 3.x.

The commit breaks compilation om CI, see:
https://build.kde.org/job/Extragear%20calligra%20kf5-qt5%20SUSEQt5.9/
Could you have a look?

Mon, Nov 13, 1:24 PM
leinir committed R8:c39f329dbdbd: Mark the QtQuick1 components as unported (authored by leinir).
Mark the QtQuick1 components as unported
Mon, Nov 13, 1:21 PM
leinir added a comment to R8:1bbb6e00022b: Port Calligra Gemini for 3.x.

The commit breaks compilation om CI, see:
https://build.kde.org/job/Extragear%20calligra%20kf5-qt5%20SUSEQt5.9/
Could you have a look?

Mon, Nov 13, 10:30 AM

Wed, Nov 8

leinir committed R8:1bbb6e00022b: Port Calligra Gemini for 3.x (authored by leinir).
Port Calligra Gemini for 3.x
Wed, Nov 8, 2:17 PM
leinir closed D8310: Port Calligra Gemini for 3.x.
Wed, Nov 8, 2:17 PM · Calligra: 3.0
leinir committed R8:4e8829be02b0: Fix the broken merge bits, again (authored by leinir).
Fix the broken merge bits, again
Wed, Nov 8, 1:57 PM
leinir committed R8:8c40c5cc2a2a: Add the GeminiMainWindow library (authored by leinir).
Add the GeminiMainWindow library
Wed, Nov 8, 1:57 PM
leinir committed R8:76a0a0938abf: Merge branch 'master' into calligra-gemini-leinir (authored by leinir).
Merge branch 'master' into calligra-gemini-leinir
Wed, Nov 8, 1:57 PM
leinir committed R8:ff8ecadad90a: Fix the include's case (or clang will complain) (authored by leinir).
Fix the include's case (or clang will complain)
Wed, Nov 8, 1:57 PM
leinir committed R8:5e430a7a5e9d: Syntax policy (authored by leinir).
Syntax policy
Wed, Nov 8, 1:57 PM
leinir committed R8:9952b763b23e: Merge branch 'master' into calligra-gemini-leinir (authored by leinir).
Merge branch 'master' into calligra-gemini-leinir
Wed, Nov 8, 1:57 PM
leinir committed R8:3e6df97bdb29: Add the GeminiMainWindow library (authored by leinir).
Add the GeminiMainWindow library
Wed, Nov 8, 1:57 PM

Mon, Oct 30

leinir added a comment to D8310: Port Calligra Gemini for 3.x.

Pinged on IRC on Friday and i'll just archive the chat here:

Mon, Oct 30, 11:01 AM · Calligra: 3.0

Fri, Oct 27

leinir added an inline comment to M112: System Settings Alpha Graphic Redesign.
Fri, Oct 27, 4:51 PM · KDE Developers, VDG
leinir accepted D8188: Remove PreferCache from network requests.

Right, yes, i think that was a bit of left over from working on it all. Go for it.

Fri, Oct 27, 11:21 AM · Frameworks
leinir added a comment to D7194: Detach before setting the d pointer.

This already went into one release, and it would be quite useful to get it sorted before the next one rolls around, and the consensus seems to be reverting, as leaving kns with this patch in has some fairly unfortunate side effects. Could we get it reverted before the next release is done?

Fri, Oct 27, 10:53 AM · Frameworks

Wed, Oct 25

leinir updated subscribers of D7194: Detach before setting the d pointer.

Damn... Well spotted, @kossebau. Right, so immediate (at least temporary solution) to make things not broken would annoyingly enough be to revert the patch, yes... I am now thinking that another oddity noticed by @sitter last week was caused by this as well (going by the installedFiles data being out of sync, it would seem likely it would cause what they were seeing). So... while it feels a bit odd, i would have to vote to revert immediately, and create a new patch documenting why we can't detach in certain classes... Possibly adding in a TODO for Frameworks 6 (there's already a couple of those in kns).

Wed, Oct 25, 8:27 AM · Frameworks

Oct 15 2017

leinir created D8311: Require the same internal version as you're building.
Oct 15 2017, 2:01 PM · Frameworks, KNewStuff
leinir committed R157:41ce3757d3ee: Port to QCC2 from 1.4 (Button in particular) (authored by leinir).
Port to QCC2 from 1.4 (Button in particular)
Oct 15 2017, 1:52 PM
leinir created D8310: Port Calligra Gemini for 3.x.
Oct 15 2017, 1:18 PM · Calligra: 3.0
leinir committed R8:7acd5f0760eb: Merge branch 'master' into calligra-gemini-leinir (authored by leinir).
Merge branch 'master' into calligra-gemini-leinir
Oct 15 2017, 12:36 PM
leinir committed R8:5c0a448e5f8e: Remove some errors from merging (authored by leinir).
Remove some errors from merging
Oct 15 2017, 12:36 PM
leinir committed R8:2ed1aef99547: Add the GeminiMainWindow library (authored by leinir).
Add the GeminiMainWindow library
Oct 15 2017, 12:36 PM
leinir committed R8:247826f3f9ba: Merge remote-tracking branch 'origin/master' into calligra-gemini-leinir (authored by leinir).
Merge remote-tracking branch 'origin/master' into calligra-gemini-leinir
Oct 15 2017, 12:36 PM
leinir committed R8:c1e2eef8c3b9: A bit of windowsism reduction... (authored by leinir).
A bit of windowsism reduction...
Oct 15 2017, 12:36 PM
leinir committed R8:81e595dda4fe: Merge remote-tracking branch 'origin/master' into calligra-gemini-leinir (authored by leinir).
Merge remote-tracking branch 'origin/master' into calligra-gemini-leinir
Oct 15 2017, 12:36 PM

Oct 2 2017

leinir committed R304:aad1ca02f183: Require Kirigami 2.1 instead of 1.0 for KNewStuffQuick (authored by leinir).
Require Kirigami 2.1 instead of 1.0 for KNewStuffQuick
Oct 2 2017, 2:47 PM
leinir closed D8111: Require Kirigami 2.1 instead of 1.0 for KNewStuffQuick.
Oct 2 2017, 2:47 PM · KNewStuff, Frameworks
leinir created D8111: Require Kirigami 2.1 instead of 1.0 for KNewStuffQuick.
Oct 2 2017, 1:56 PM · KNewStuff, Frameworks

Sep 21 2017

leinir committed R157:26fc03476045: Trust that shortcuts are disabled for disabled Actions (authored by leinir).
Trust that shortcuts are disabled for disabled Actions
Sep 21 2017, 1:47 PM
leinir committed R169:69e074a874a2: Disable shortcuts when an action is disabled (authored by leinir).
Disable shortcuts when an action is disabled
Sep 21 2017, 1:04 PM
leinir closed D7814: Disable shortcuts when an action is disabled.
Sep 21 2017, 1:04 PM · Kirigami
leinir updated the diff for D7814: Disable shortcuts when an action is disabled.

Change the approach from performing all the magic inside Kirigami (which resulted in not entirely consistent behaviours, depending on which actions you used), pushing some of the requirements for disabling things onto the app developer.

Sep 21 2017, 10:55 AM · Kirigami
leinir retitled D7814: Disable shortcuts when an action is disabled from Disable shortcuts for actions not on the current page to Disable shortcuts when an action is disabled.
Sep 21 2017, 10:54 AM · Kirigami

Sep 14 2017

leinir committed R157:d057db785817: Make sure we use the right knsrc file (authored by leinir).
Make sure we use the right knsrc file
Sep 14 2017, 2:52 PM
leinir created D7814: Disable shortcuts when an action is disabled.
Sep 14 2017, 12:22 PM · Kirigami

Sep 4 2017

leinir committed R157:2dffa45e9b49: Add sequence/series data from acbf into model (just one for now) (authored by leinir).
Add sequence/series data from acbf into model (just one for now)
Sep 4 2017, 2:07 PM
leinir committed R157:0af71a46b801: Use displayname when getting the author in archivebookmodel (authored by leinir).
Use displayname when getting the author in archivebookmodel
Sep 4 2017, 2:07 PM
leinir committed R157:b4a117607369: More pleasant clear-db option help text (authored by leinir).
More pleasant clear-db option help text
Sep 4 2017, 2:07 PM
leinir committed R157:c2b102279e20: Limit searches as they should be (authored by leinir).
Limit searches as they should be
Sep 4 2017, 2:07 PM

Sep 1 2017

leinir committed R157:04fcb56e275d: Ensure fiels are filled out in the author editor (authored by leinir).
Ensure fiels are filled out in the author editor
Sep 1 2017, 3:17 PM
leinir committed R157:ee9ab5600d55: Actually wire up the add new author functionality (authored by leinir).
Actually wire up the add new author functionality
Sep 1 2017, 3:17 PM
leinir committed R157:be3d51d27b06: Add an application header to Creator (authored by leinir).
Add an application header to Creator
Sep 1 2017, 3:17 PM
leinir committed R157:5b3c3541047b: Initial filling out of the book list with ACBF info (authored by leinir).
Initial filling out of the book list with ACBF info
Sep 1 2017, 3:17 PM
leinir committed R157:af23260c0d92: Add an initial author editor (authored by leinir).
Add an initial author editor
Sep 1 2017, 3:17 PM
leinir committed R157:cc4c63521b96: Switch Creator's Book page to ScrollablePage (authored by leinir).
Switch Creator's Book page to ScrollablePage
Sep 1 2017, 3:17 PM
leinir committed R157:58c1c12a3921: Expose some author things to QML (authored by leinir).
Expose some author things to QML
Sep 1 2017, 3:17 PM
leinir committed R157:1bca664846cd: Expose a bunch of Author things to QML (and add displayName) (authored by leinir).
Expose a bunch of Author things to QML (and add displayName)
Sep 1 2017, 3:17 PM
leinir committed R157:54e49c8b5df6: Add option to clear the database cache (authored by leinir).
Add option to clear the database cache
Sep 1 2017, 3:17 PM
leinir committed R157:df2dcf35b83c: Make it possible to use ArchiveModel without a qml engine set (authored by leinir).
Make it possible to use ArchiveModel without a qml engine set
Sep 1 2017, 3:17 PM

Aug 24 2017

leinir committed R157:76f472108c54: Fix license issue (authored by leinir).
Fix license issue
Aug 24 2017, 11:38 AM
leinir committed R169:2cdd0402bf9c: Get rid of warnings about setting both pixel and point sizes (authored by leinir).
Get rid of warnings about setting both pixel and point sizes
Aug 24 2017, 8:29 AM
leinir closed D7483: Get rid of warnings about setting both pixel and point sizes by committing R169:2cdd0402bf9c: Get rid of warnings about setting both pixel and point sizes.
Aug 24 2017, 8:29 AM · Kirigami

Aug 23 2017

leinir created D7483: Get rid of warnings about setting both pixel and point sizes.
Aug 23 2017, 11:34 AM · Kirigami
leinir accepted D7190: Don't complain the knsregistry file is not present before it's useful.

Good call, yes - gets rid of a lump of irrelevant and technically correct but subjectively incorrect information.

Aug 23 2017, 8:06 AM · Frameworks
leinir accepted D7194: Detach before setting the d pointer.

Ah, yes, good catch :)

Aug 23 2017, 8:03 AM · Frameworks

Aug 22 2017

leinir committed R157:f9224e911fe8: Fix keyboard navigation (authored by leinir).
Fix keyboard navigation
Aug 22 2017, 4:49 PM
leinir committed R157:f5436f12d2e7: Hide things sitting behind the search results pane (authored by leinir).
Hide things sitting behind the search results pane
Aug 22 2017, 4:49 PM
leinir committed R157:2aad2171fa80: Intersection points are fun sometimes. Fix crash. (authored by leinir).
Intersection points are fun sometimes. Fix crash.
Aug 22 2017, 4:49 PM
leinir committed R169:e0f56dac7959: Check item validity before using it (authored by leinir).
Check item validity before using it
Aug 22 2017, 4:42 PM
leinir closed D7467: Check item validity before using it by committing R169:e0f56dac7959: Check item validity before using it.
Aug 22 2017, 4:42 PM · Kirigami
leinir closed D7466: Honour layer position for isCurrentPage.

Closed by: https://commits.kde.org/kirigami/6dffeef3c09ef62f7ea2775bf9ec72585755e3d2

Aug 22 2017, 4:21 PM · Kirigami
leinir reclaimed D7467: Check item validity before using it.

Also, i am a silly person and closed the wrong revision.

Aug 22 2017, 4:21 PM · Kirigami
leinir abandoned D7467: Check item validity before using it.

Closed by: https://commits.kde.org/kirigami/6dffeef3c09ef62f7ea2775bf9ec72585755e3d2

Aug 22 2017, 4:20 PM · Kirigami
leinir committed R169:6dffeef3c09e: Honour layer position for isCurrentPage (authored by leinir).
Honour layer position for isCurrentPage
Aug 22 2017, 4:12 PM
leinir created D7467: Check item validity before using it.
Aug 22 2017, 4:10 PM · Kirigami
leinir created D7466: Honour layer position for isCurrentPage.
Aug 22 2017, 2:37 PM · Kirigami
leinir added a comment to T6840: Qt World Summit.

I think we should consider the entire presence as a whole - just get all communication goals in place so that we this year have one solid communication and our presence is aimed at one specific thing

Aug 22 2017, 8:20 AM · KDE Promo

Aug 21 2017

leinir accepted D7343: auto generate desktop file for url handling.

Hmm... LGTM - mind that i am not the maintainer here, but it does look like it's likely the needed approach.

Aug 21 2017, 1:40 PM · Plasma

Aug 16 2017

leinir committed R157:aed2256a1e5c: Up Kirigami requirement to 5.37 for PageRow layers (authored by leinir).
Up Kirigami requirement to 5.37 for PageRow layers
Aug 16 2017, 3:14 PM
leinir accepted D7306: concept of Layers.
Aug 16 2017, 10:46 AM · Kirigami
leinir added a comment to D7306: concept of Layers.

The StackView is complaining about some erroneous anchoring (and i don't see the visual effects it's complaining about, as far as i can tell), but apart from that, it looks to work really quite nicely :)

Aug 16 2017, 10:46 AM · Kirigami

Aug 8 2017

leinir committed R32:1dd87ec852c5: Add Provider URLs to the two knsrc files (authored by leinir).
Add Provider URLs to the two knsrc files
Aug 8 2017, 5:04 PM

Jul 23 2017

leinir committed R8:2b89f0e7508e: Clean the view mode sync object up a bit (authored by leinir).
Clean the view mode sync object up a bit
Jul 23 2017, 8:29 PM
leinir committed R8:214a1cea5df6: A bit of documentation (authored by leinir).
A bit of documentation
Jul 23 2017, 8:29 PM
leinir committed R8:ce5330777205: Initialise the document offset (authored by leinir).
Initialise the document offset
Jul 23 2017, 3:29 PM
leinir committed R8:0d7e1a3cc757: Handle being given a null documentOffset (and react appropriately) (authored by leinir).
Handle being given a null documentOffset (and react appropriately)
Jul 23 2017, 3:29 PM
leinir committed R8:2e4523ac18ad: Left over merge crud (authored by leinir).
Left over merge crud
Jul 23 2017, 2:43 PM
leinir committed R8:d256bc2cd5ab: Initialise some more members on the viewmodesyncobject (authored by leinir).
Initialise some more members on the viewmodesyncobject
Jul 23 2017, 2:43 PM
leinir committed R8:f652d13de296: Merge branch 'master' into calligra-gemini-leinir (authored by leinir).
Merge branch 'master' into calligra-gemini-leinir
Jul 23 2017, 2:43 PM
leinir committed R8:b31621174fd1: Add the GeminiMainWindow library (authored by leinir).
Add the GeminiMainWindow library
Jul 23 2017, 2:43 PM
leinir committed R8:a5a14f883e44: Fix Stage document page in Gemini (authored by leinir).
Fix Stage document page in Gemini
Jul 23 2017, 1:44 PM

Jul 22 2017

leinir committed R8:8ef9322f3823: QPointer for the text doc implementation (authored by leinir).
QPointer for the text doc implementation
Jul 22 2017, 7:02 PM
leinir committed R8:e72d5b0b1dc1: Add some QPointer to the statistics widget (authored by leinir).
Add some QPointer to the statistics widget
Jul 22 2017, 7:02 PM

Jul 21 2017

leinir committed R157:cc1b7204ac15: Require Qt5::Sql and Kirigami 2.1 (authored by leinir).
Require Qt5::Sql and Kirigami 2.1
Jul 21 2017, 5:16 PM
leinir committed R157:5cc08593bb39: Port Peruse to Kirigami 2.1 (authored by leinir).
Port Peruse to Kirigami 2.1
Jul 21 2017, 5:16 PM
leinir committed R157:d214fd606068: Make the category get function return count as well (authored by leinir).
Make the category get function return count as well
Jul 21 2017, 5:16 PM
leinir committed R157:a224574ea44d: Don't give the rowcount for categories, just the book count (authored by leinir).
Don't give the rowcount for categories, just the book count
Jul 21 2017, 4:56 PM
leinir committed R157:13a9b616e4ad: Add the database code itself (authored by leinir).
Add the database code itself
Jul 21 2017, 4:56 PM
leinir committed R157:6825117b44d1: Make the cache loading gentler, instant UI (authored by leinir).
Make the cache loading gentler, instant UI
Jul 21 2017, 4:56 PM
leinir committed R157:ba158c885c17: Add an sqlite database cache to Peruse (authored by leinir).
Add an sqlite database cache to Peruse
Jul 21 2017, 4:56 PM

Jul 7 2017

leinir accepted D6532: When requesting from the cache, report all entries at bulk.

Hmm... i was thinking this could cause issues, i don't see anywhere assumptions are made about page size on the consumption side (damn we're lucky this whole split thing's so new ;) ). Nothing in the API suggests you might get more than the requested number when you ask for entries, but conversely nothing says you will potentially get less, and that happens on a regular basis, so... sure, why not :)

Jul 7 2017, 8:06 AM · Frameworks