leinir (Dan Leinir Turthra Jensen)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jul 8 2015, 8:34 AM (242 w, 2 d)
Availability
Available

Recent Activity

Today

leinir updated the summary of D27681: [WIP] Prettify the Accounts KCM and expand KAccounts integration library.
Fri, Feb 28, 12:54 PM
leinir updated the diff for D27681: [WIP] Prettify the Accounts KCM and expand KAccounts integration library.
  • Lamdafy some data signal handling, for less publics and easier code
  • Add a bit of documentation (and remove an unneeded include)
Fri, Feb 28, 12:49 PM
leinir updated the diff for D27681: [WIP] Prettify the Accounts KCM and expand KAccounts integration library.

(yeah, this took a bit of work...)

Fri, Feb 28, 11:44 AM
leinir updated the diff for D27681: [WIP] Prettify the Accounts KCM and expand KAccounts integration library.

A pre-merging diff, just in case something goes horribly wrong my end

Fri, Feb 28, 11:18 AM
leinir accepted D27709: Move job classes to kaccounts lib and rename to *Job.

As i was going to do this as part of something else, i obviously think this is a good idea ;) And yes, the thought process behind it was indeed that this is something that'd just make sense in general, not just from QML.

Fri, Feb 28, 8:54 AM
leinir added a comment to D27681: [WIP] Prettify the Accounts KCM and expand KAccounts integration library.

I see we had similar thoughts about moving the jobs to the kaccounts lib (D27709) :D. IMHO this should be done in a separate patch than the UI changes, so I will update my patch with the name change of yours

Fri, Feb 28, 8:53 AM

Yesterday

leinir closed D27696: Fix scrolling on the EntryDetails page.
Thu, Feb 27, 11:41 AM · Frameworks
leinir committed R304:94015abda31b: Fix scrolling on the EntryDetails page (authored by leinir).
Fix scrolling on the EntryDetails page
Thu, Feb 27, 11:41 AM
leinir added reviewers for D27696: Fix scrolling on the EntryDetails page: ngraham, Frameworks, Plasma, hexchain.
Thu, Feb 27, 10:55 AM · Frameworks
leinir requested review of D27696: Fix scrolling on the EntryDetails page.
Thu, Feb 27, 10:55 AM · Frameworks
leinir accepted D27694: Don't recreate ImageDataItem texture unless needed.

That's a very good idea, yes, go for it! :)

Thu, Feb 27, 9:08 AM · Calligra: 3.0

Wed, Feb 26

leinir requested review of D27681: [WIP] Prettify the Accounts KCM and expand KAccounts integration library.
Wed, Feb 26, 3:24 PM
leinir added inline comments to D25961: [WIP] Switch the Attica KDE plugin to use KAccounts.
Wed, Feb 26, 8:28 AM · Plasma

Tue, Feb 25

leinir added inline comments to D27633: Port to KPluginLoader.
Tue, Feb 25, 1:24 PM
leinir committed R155:74e770cc9398: Compiler warnings-- (authored by leinir).
Compiler warnings--
Tue, Feb 25, 1:23 PM

Mon, Feb 24

leinir added a comment to D25961: [WIP] Switch the Attica KDE plugin to use KAccounts.
In D25961#617057, @apol wrote:

+1 cool stuff, much better than using kwallet for it.

Mon, Feb 24, 4:38 PM · Plasma
leinir updated the diff for D25961: [WIP] Switch the Attica KDE plugin to use KAccounts.
  • Switch to using the kaccounts cmake commands
Mon, Feb 24, 3:54 PM · Plasma
leinir committed R155:748b8519e56a: Polish up the KAccounts KCM (authored by leinir).
Polish up the KAccounts KCM
Mon, Feb 24, 11:05 AM
leinir closed D27479: Polish up the KAccounts KCM.
Mon, Feb 24, 11:05 AM
leinir updated the summary of D27479: Polish up the KAccounts KCM.
Mon, Feb 24, 11:03 AM

Fri, Feb 21

leinir added reviewers for D27544: Fix update scenarios with no explicit downloadlink selected: KNewStuff, Frameworks, Plasma.
Fri, Feb 21, 11:52 AM · Frameworks
leinir requested review of D27544: Fix update scenarios with no explicit downloadlink selected.
Fri, Feb 21, 11:52 AM · Frameworks

Thu, Feb 20

leinir updated the diff for D25961: [WIP] Switch the Attica KDE plugin to use KAccounts.

Fair bit of work gone on here, but in short, given a patch which handles the
OpenID ID token in the OAuth2 requests in signon-plugin-oauth2, we are now
able to construct a bearer-authenticated request and whatnot. There is more
work to be done, but it seems like things are happening now! Progress.

Thu, Feb 20, 1:48 PM · Plasma
leinir added a comment to D27479: Polish up the KAccounts KCM.

Thanks for taking this up, I have to admit I neglected this after doing the initial QML "port"/transfer

Thu, Feb 20, 10:51 AM
leinir updated the diff for D27479: Polish up the KAccounts KCM.
  • Add a text (and thus tooltip) to the account delegate's remove action
Thu, Feb 20, 10:50 AM

Wed, Feb 19

leinir updated the diff for D27479: Polish up the KAccounts KCM.
  • Add a helpful label when there are no accounts in the list
Wed, Feb 19, 1:24 PM
leinir updated the diff for D27479: Polish up the KAccounts KCM.
  • Switch to using a Binding
Wed, Feb 19, 1:01 PM
leinir added inline comments to D27479: Polish up the KAccounts KCM.
Wed, Feb 19, 1:01 PM
leinir updated the summary of D27479: Polish up the KAccounts KCM.
Wed, Feb 19, 12:30 PM
leinir updated the diff for D27479: Polish up the KAccounts KCM.
  • These are not bookmarks, they're things that should be removed...
Wed, Feb 19, 12:29 PM
leinir updated the diff for D27479: Polish up the KAccounts KCM.

Address some of the issues highlighted by @ahiemstra

Wed, Feb 19, 12:02 PM
leinir added inline comments to D27479: Polish up the KAccounts KCM.
Wed, Feb 19, 12:01 PM
leinir accepted D27474: [CreateAccount job] Never set an empty name when creating an account.

i think that i'm with @wbauer here - but also Bhushan. This is most definitely a good fallback that i think we'll want in (also, good commenting), but a second patch to pull up more friendly names for accounts where that's possible/make sense/whatnot would also be pretty great. So... accept this one, and suggest further work i think (wow, it's almost like being at uni ;) )

Wed, Feb 19, 10:01 AM
leinir added reviewers for D27479: Polish up the KAccounts KCM: Plasma, bshah.
Wed, Feb 19, 9:57 AM
leinir updated the summary of D27479: Polish up the KAccounts KCM.
Wed, Feb 19, 9:47 AM
leinir updated the diff for D27479: Polish up the KAccounts KCM.

Thanks for the swift decision on that, and i look forward to the visual fix!

Wed, Feb 19, 9:46 AM
leinir added a comment to D27479: Polish up the KAccounts KCM.
In D27479#613974, @mart wrote:

this look


is fine. is already used by other kcms.

I'll disable the graying out for overlaysheets when running in a kcm as with qml there is no way whatsoever to gray out the entire systemsettings area.

Wed, Feb 19, 9:32 AM
leinir updated subscribers of D27479: Polish up the KAccounts KCM.

Could we add a property to the OverlaySheet to disable dimming the background?
For KCMs I don't really see a different way to fix this.
Whether this is possible depends on which KF5 version we can depend on here.

Wed, Feb 19, 8:32 AM

Tue, Feb 18

leinir added a comment to D27479: Polish up the KAccounts KCM.

QtQuick.Dialogs seems to be part of QtQuickControls 1, which is deprecated since Qt 5.12.
Also the point of replacing the old KCM with the QML based one was to share it between desktop and mobile devices, where this kind of dialogs don't work well. From my point of view, please use a dialog that does not open a new window.

Tue, Feb 18, 3:32 PM
leinir updated the summary of D27479: Polish up the KAccounts KCM.
Tue, Feb 18, 3:17 PM
leinir updated the diff for D27479: Polish up the KAccounts KCM.
  • Remove some test data
Tue, Feb 18, 2:48 PM
leinir requested review of D27479: Polish up the KAccounts KCM.
Tue, Feb 18, 2:36 PM
leinir accepted D27468: Don't double delete CommentsModel.

Quite right. Looks like some leftovers from before that caching was added, shippit :)

Tue, Feb 18, 8:39 AM · Frameworks

Mon, Feb 17

leinir committed R155:2420b04e3d01: Unbreak the Accounts KCM (authored by leinir).
Unbreak the Accounts KCM
Mon, Feb 17, 1:43 PM
leinir closed D27454: Unbreak the Accounts KCM.
Mon, Feb 17, 1:42 PM · Plasma
leinir added a project to D27454: Unbreak the Accounts KCM: Plasma.
Mon, Feb 17, 12:14 PM · Plasma
leinir requested review of D27454: Unbreak the Accounts KCM.
Mon, Feb 17, 12:12 PM · Plasma

Fri, Feb 7

leinir committed R157:4a1b3f954d2f: Convert the archive image provider to async as well (authored by leinir).
Convert the archive image provider to async as well
Fri, Feb 7, 9:36 PM
l10n daemon script <scripty@kde.org> committed R304:5adb54f284eb: Fix the KNSQuick Dialog's close title and basic layout (authored by leinir).
Fix the KNSQuick Dialog's close title and basic layout
Fri, Feb 7, 2:10 PM
leinir committed R304:fd5b37818e6a: Fix the KNSQuick Dialog's close title and basic layout (authored by leinir).
Fix the KNSQuick Dialog's close title and basic layout
Fri, Feb 7, 1:53 PM
leinir closed D27204: Fix the KNSQuick Dialog's close title and basic layout.
Fri, Feb 7, 1:53 PM · Frameworks
leinir added a comment to D27204: Fix the KNSQuick Dialog's close title and basic layout.

LGTM and fixes all the bugs! Thanks.

Fri, Feb 7, 1:52 PM · Frameworks
leinir committed R157:152f9b281c1c: Use smooth transform for comic cover previews (and fix doc) (authored by leinir).
Use smooth transform for comic cover previews (and fix doc)
Fri, Feb 7, 11:58 AM
leinir committed R157:490d28bfc7bf: Convert the PDF cover generator to the async method as well (authored by leinir).
Convert the PDF cover generator to the async method as well
Fri, Feb 7, 11:58 AM
leinir committed R157:2aa52b102dc2: Don't try and abort a null job, we might do a splode... (authored by leinir).
Don't try and abort a null job, we might do a splode...
Fri, Feb 7, 11:58 AM
leinir committed R157:7c87932156ea: Convert the ComicCover provider to using the async method as well (authored by leinir).
Convert the ComicCover provider to using the async method as well
Fri, Feb 7, 11:58 AM
leinir committed R157:1273f3e80649: Use a smooth transformation for the preview generator (authored by leinir).
Use a smooth transformation for the preview generator
Fri, Feb 7, 11:58 AM
leinir added reviewers for D27204: Fix the KNSQuick Dialog's close title and basic layout: Frameworks, ngraham.
Fri, Feb 7, 10:31 AM · Frameworks
leinir requested review of D27204: Fix the KNSQuick Dialog's close title and basic layout.
Fri, Feb 7, 10:29 AM · Frameworks

Thu, Feb 6

leinir added a comment to D27194: Remove human avatars.

Wouldn't it be better to get better ones? We already removed a ton last year. If we keep on removing stuff, we'll eventually end up with nothing but Konqis.

Thu, Feb 6, 2:55 PM · Plasma
leinir committed R157:592f61271749: Don't allow switching to the category you're already on (authored by leinir).
Don't allow switching to the category you're already on
Thu, Feb 6, 2:34 PM
leinir committed R157:39d4888f7a9c: Simplify the layout logic a touch for BookTile (authored by leinir).
Simplify the layout logic a touch for BookTile
Thu, Feb 6, 2:34 PM
leinir committed R157:6d122613741b: Implement cancellation for previews (authored by leinir).
Implement cancellation for previews
Thu, Feb 6, 12:13 PM
leinir committed R157:ec35287e9f3e: Fix some sporadic crashes in the previewing code (authored by leinir).
Fix some sporadic crashes in the previewing code
Thu, Feb 6, 12:13 PM

Wed, Feb 5

leinir added a reviewer for D27028: Switch from download.k.o to autoconfig: KNewStuff.
Wed, Feb 5, 2:01 PM · Frameworks
leinir updated the diff for D27028: Switch from download.k.o to autoconfig.

During some cleanup and addition, i realised it was silly to have
the documentation for knsrc files in the widgets bits, and in two
places. In addition, those places were both at least a bit wrong,
or outdated, and needed fixing anyway, so... consolidate all that
into the README.md file, as it's fairly central anyway. More could
reasonably be done with that section, but this is already better.

Wed, Feb 5, 12:21 PM · Frameworks

Tue, Feb 4

leinir closed D27123: Add a default provider (as per documentation).
Tue, Feb 4, 10:40 AM · Frameworks
leinir committed R235:5f799b92559f: Add a default provider (as per documentation) (authored by leinir).
Add a default provider (as per documentation)
Tue, Feb 4, 10:40 AM

Mon, Feb 3

leinir updated the diff for D27123: Add a default provider (as per documentation).
  • Use more modern style for the list initialisation
Mon, Feb 3, 12:14 PM · Frameworks
leinir added reviewers for D27123: Add a default provider (as per documentation): kossebau, Frameworks, KNewStuff.
Mon, Feb 3, 11:46 AM · Frameworks
leinir requested review of D27123: Add a default provider (as per documentation).
Mon, Feb 3, 11:43 AM · Frameworks
leinir added inline comments to D27028: Switch from download.k.o to autoconfig.
Mon, Feb 3, 9:17 AM · Frameworks
leinir updated the diff for D27028: Switch from download.k.o to autoconfig.

Address comments by meven and bcooksley

Mon, Feb 3, 9:17 AM · Frameworks

Thu, Jan 30

leinir added inline comments to D27028: Switch from download.k.o to autoconfig.
Thu, Jan 30, 1:04 PM · Frameworks
leinir updated the diff for D27028: Switch from download.k.o to autoconfig.

Thanks to broulik for noticing (or making me notice) this

Thu, Jan 30, 1:04 PM · Frameworks
leinir added inline comments to D27028: Switch from download.k.o to autoconfig.
Thu, Jan 30, 12:52 PM · Frameworks
leinir updated the diff for D27028: Switch from download.k.o to autoconfig.

As suggested by frinring, do not suggest setting a ProvidersUrl unless
it is actually needed.

Thu, Jan 30, 12:12 PM · Frameworks
leinir added reviewers for D27028: Switch from download.k.o to autoconfig: bcooksley, Frameworks.
Thu, Jan 30, 12:02 PM · Frameworks
leinir requested review of D27028: Switch from download.k.o to autoconfig.
Thu, Jan 30, 12:01 PM · Frameworks
leinir accepted D27021: Port plasma-workspace to autoconfig.kde.org.

As D27020, might want to backport this to any branches still being released.

Thu, Jan 30, 9:39 AM · Plasma
leinir accepted D27020: Port plasma-desktop to autoconfig.kde.org.

Goodness me, yes please. Land in 5.18 for sure (also perhaps backport to anywhere that's still being released)

Thu, Jan 30, 9:38 AM · Plasma

Jan 29 2020

leinir added a comment to D26976: Fix DownloadPage use of KNS.ItemsModel.

Also incidentally, i've just posted D26990 which should hopefully alleviate the issue for people with an up-to-date Frameworks but an out-of-date Artikulate ;)

Jan 29 2020, 1:57 PM · KDE Edu
leinir added reviewers for D26990: Allow setting ItemsModel engine to either KNSCore or KNSQuick engine: KNewStuff, aacid, Frameworks.
Jan 29 2020, 1:54 PM · Frameworks
leinir updated the diff for D26990: Allow setting ItemsModel engine to either KNSCore or KNSQuick engine.
  • Remove some unrelated changes
Jan 29 2020, 1:53 PM · Frameworks
leinir requested review of D26990: Allow setting ItemsModel engine to either KNSCore or KNSQuick engine.
Jan 29 2020, 1:52 PM · Frameworks
leinir accepted D26976: Fix DownloadPage use of KNS.ItemsModel.

About half a year ago, yeah - it is a regression, but to ensure people can use it with already-released versions of Frameworks, this'll probably want to go in. Also, since the old code would take either, if people insist on running it against an old version of Frameworks, it should then still work :)

Jan 29 2020, 8:47 AM · KDE Edu
leinir added a comment to D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).

FWIW this broke artikulate since you changed the expected entry for engine: in KNS.ItemsModel

Jan 29 2020, 8:43 AM · Frameworks

Jan 28 2020

leinir committed R119:6fb116e7d63a: Merge branch 'Plasma/5.18' (authored by leinir).
Merge branch 'Plasma/5.18'
Jan 28 2020, 10:22 AM
leinir committed R119:ec387280ad9d: Switch to the old-style button text for the KNSQuick buttons (authored by leinir).
Switch to the old-style button text for the KNSQuick buttons
Jan 28 2020, 9:59 AM
leinir closed D26892: Switch to the old-style button text for the KNSQuick buttons.
Jan 28 2020, 9:59 AM · Plasma
leinir added a comment to D26665: Switch to KNSQuick for getting new wallpapers.

What about the "Get New Plugins" button in the same dialog? It still uses the old style.
Probably unrelated, but for me, both of these buttons fail to actually load anything, stuck connecting forever. I would blame all of my internet connections that I tried it with, but it does not happen in System Settings, so maybe there's some bug here.

Jan 28 2020, 9:58 AM · Plasma
leinir added a comment to D26892: Switch to the old-style button text for the KNSQuick buttons.

stable branch please :)

Jan 28 2020, 9:20 AM · Plasma

Jan 24 2020

leinir added a reviewer for D26892: Switch to the old-style button text for the KNSQuick buttons: Plasma.
Jan 24 2020, 10:44 AM · Plasma
leinir requested review of D26892: Switch to the old-style button text for the KNSQuick buttons.
Jan 24 2020, 10:43 AM · Plasma

Jan 23 2020

leinir added a comment to D26794: [WIP] Implement comment posting (and reenable voting).

Right, so because it is being brought up by people, i thought i should perhaps just do a touch of an explanation for the thought process that made me arrive at the current design for the NewCommentSheet component and its ability to chose whether or not you are writing a comment or a review. The options that i found can be enumerated as follows:

Jan 23 2020, 2:04 PM · Frameworks
leinir updated the diff for D26794: [WIP] Implement comment posting (and reenable voting).
  • A better text for the "be the first" link (i'll try not dither too much)
Jan 23 2020, 1:28 PM · Frameworks
leinir updated the diff for D26794: [WIP] Implement comment posting (and reenable voting).
  • Clarify the "be the first" text a touch...
Jan 23 2020, 1:26 PM · Frameworks
leinir updated the summary of D26794: [WIP] Implement comment posting (and reenable voting).
Jan 23 2020, 1:17 PM · Frameworks
leinir updated the summary of D26794: [WIP] Implement comment posting (and reenable voting).
Jan 23 2020, 1:17 PM · Frameworks
leinir updated the diff for D26794: [WIP] Implement comment posting (and reenable voting).
  • Don't suggest making reviews if you're writing a reply comment
  • Don't pull up a comments model until we actually need it
Jan 23 2020, 1:12 PM · Frameworks