leinir (Dan Leinir Turthra Jensen)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jul 8 2015, 8:34 AM (215 w, 1 d)
Availability
Available

Recent Activity

Today

leinir committed R157:417f086e5531: Don't try and go past the end of the list, silly (authored by leinir).
Don't try and go past the end of the list, silly
Thu, Aug 22, 2:15 PM
leinir committed R157:9e1aed6b6c38: Navigator's swipe detection is now actually working right (authored by leinir).
Navigator's swipe detection is now actually working right
Thu, Aug 22, 11:16 AM

Yesterday

leinir accepted D23327: [Gemini] Clarify deletion of document.

Well spotted. Yes, this is frankly from before i quite understood how smart pointer types worked, so... yeah, my bad, and thanks for sorting this :) As you say, there's plenty of more stuff to do, including some semi-basic interaction issues...

Wed, Aug 21, 7:15 PM · Calligra: 3.0
leinir committed R157:268d785ed987: Change the frame changing logic a touch (authored by leinir).
Change the frame changing logic a touch
Wed, Aug 21, 11:42 AM
leinir committed R157:9322075df21d: Handle the hole rect being NaN (by just setting it full width) (authored by leinir).
Handle the hole rect being NaN (by just setting it full width)
Wed, Aug 21, 11:42 AM

Fri, Aug 16

leinir committed R157:8bfb63412ac1: Reduce QtQuick requirement to 2.12 (from 2.12) (authored by leinir).
Reduce QtQuick requirement to 2.12 (from 2.12)
Fri, Aug 16, 10:18 AM

Thu, Aug 15

leinir committed R157:25b0f97de4f1: Some cleanup, and double-click-to-zoom is back, and safer (authored by leinir).
Some cleanup, and double-click-to-zoom is back, and safer
Thu, Aug 15, 9:15 PM
leinir committed R157:e32eb0420145: Sort the Book viewer title with some more reasonable bindings (authored by leinir).
Sort the Book viewer title with some more reasonable bindings
Thu, Aug 15, 7:11 PM
leinir committed R157:3fb467523638: Make the okular viewer work again (this time with more URLness) (authored by leinir).
Make the okular viewer work again (this time with more URLness)
Thu, Aug 15, 6:40 PM
leinir committed R157:a32467ae4eb5: onLoaded doesn't do that... onStatusChanged does. (authored by leinir).
onLoaded doesn't do that... onStatusChanged does.
Thu, Aug 15, 6:40 PM
leinir committed R157:8c64db408599: Require Qt 5.10 explicitly (later would also be nice) (authored by leinir).
Require Qt 5.10 explicitly (later would also be nice)
Thu, Aug 15, 6:40 PM
leinir committed R157:1e426540b04c: Fix copyright (authored by leinir).
Fix copyright
Thu, Aug 15, 5:37 PM
leinir committed R157:202ec4d8bd3b: Add a Navigator component (for in-book navigation) (authored by leinir).
Add a Navigator component (for in-book navigation)
Thu, Aug 15, 5:37 PM
leinir committed R157:a573ace44375: Add Navigator to both ImageBrowser and okular fallback components (authored by leinir).
Add Navigator to both ImageBrowser and okular fallback components
Thu, Aug 15, 5:37 PM

Wed, Aug 14

leinir added a member for Discover Software Store: leinir.
Wed, Aug 14, 4:49 PM
leinir accepted D17598: Improve "No internet connection!" error message.
Wed, Aug 14, 3:26 PM · Plasma
leinir committed R169:56d3ccd95753: Rework the visibleActions logic in SwipeListItem (authored by leinir).
Rework the visibleActions logic in SwipeListItem
Wed, Aug 14, 2:49 PM
leinir closed D23109: Rework the visibleActions logic in SwipeListItem.
Wed, Aug 14, 2:49 PM · Kirigami

Tue, Aug 13

leinir updated the diff for D23109: Rework the visibleActions logic in SwipeListItem.
  • Only check for other visible actions if this one is not visible
Tue, Aug 13, 1:47 PM · Kirigami
leinir added a comment to T10973: Add command line apps to kde.org/applications.

It seems to me that the question here is perhaps less about command line tools and more "does this executable perform a useful function, if launched without any pre-launch input". For command line tools, that question would become "does this tool require any parameters to perform any useful function"... As a specific example, KDialog does require that, and so it seems like we'd want to not be showing that in Discover.

Tue, Aug 13, 10:51 AM · KDE Applications

Mon, Aug 12

leinir added a comment to T11142: OCS comment rating machine readability.

Just a quick poke, because i kind of need this to happen... how's it coming along? Thanks in advance! I realise you've been ooo for a little bit :)

Mon, Aug 12, 12:38 PM · KDE Store
leinir added a comment to T11173: Expose (partial) person data for unauthorised users.

Just a quick poke, because i kind of need this to happen... how's it coming along? Thanks in advance! :)

Mon, Aug 12, 12:37 PM · KDE Store
leinir added reviewers for D23109: Rework the visibleActions logic in SwipeListItem: Kirigami, mart.
Mon, Aug 12, 11:10 AM · Kirigami
leinir requested review of D23109: Rework the visibleActions logic in SwipeListItem.
Mon, Aug 12, 11:09 AM · Kirigami
leinir added a comment to D23029: Fix the attica pkgconfig file..

Unless someone has objections, I'll push this tomorrow.

Mon, Aug 12, 10:20 AM · Frameworks

Fri, Aug 9

leinir committed R157:ee3b7dfc8555: Hopefully unbork NewStuff things just a tiny touch... (authored by leinir).
Hopefully unbork NewStuff things just a tiny touch...
Fri, Aug 9, 12:40 PM
leinir committed R157:2ba65e3a6cf5: Respect the scaling when doing frame-by-frame (authored by leinir).
Respect the scaling when doing frame-by-frame
Fri, Aug 9, 11:09 AM
leinir committed R157:4acb7f8680ba: Warning-- (authored by leinir).
Warning--
Fri, Aug 9, 11:09 AM
leinir committed R157:786eeb5b8975: Render hidpi, and expose the global scale factor... (authored by leinir).
Render hidpi, and expose the global scale factor...
Fri, Aug 9, 11:09 AM

Thu, Aug 8

leinir committed R157:50495c53c1c8: Hide controls automatically (and show again) when fullscreening (authored by leinir).
Hide controls automatically (and show again) when fullscreening
Thu, Aug 8, 8:58 AM

Wed, Aug 7

leinir committed R157:e112a91dd429: Build the qml files into the apps as resources (authored by leinir).
Build the qml files into the apps as resources
Wed, Aug 7, 11:46 AM
leinir committed R157:7cc2be5e60a5: Actually load the resource qml files as well (authored by leinir).
Actually load the resource qml files as well
Wed, Aug 7, 11:46 AM
leinir committed R157:644cd7797bc4: Move some of the holyrect logic into the component (where it belongs) (authored by leinir).
Move some of the holyrect logic into the component (where it belongs)
Wed, Aug 7, 11:20 AM

Tue, Aug 6

leinir committed R157:fa3445eaedb3: Clean up the initial hole state (authored by leinir).
Clean up the initial hole state
Tue, Aug 6, 1:04 PM
leinir committed R157:93ad972674e4: When doing frame-based reading, stay in that mode while reading (authored by leinir).
When doing frame-based reading, stay in that mode while reading
Tue, Aug 6, 10:11 AM

Mon, Aug 5

leinir committed R157:c7a5b853a6fa: Ensure we hide more of the background in HolyRect (authored by leinir).
Ensure we hide more of the background in HolyRect
Mon, Aug 5, 12:38 PM
leinir committed R157:8ce52ab9cdb5: Initial opacity should be 0 on the holyborder (authored by leinir).
Initial opacity should be 0 on the holyborder
Mon, Aug 5, 12:38 PM
leinir updated the diff for D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Use typed animations instead of the inefficient PropertyAnimation
Mon, Aug 5, 11:24 AM · Frameworks
leinir committed R157:f6160afc079e: Switch to explicit type animations instead of PropertyAnimation (authored by leinir).
Switch to explicit type animations instead of PropertyAnimation
Mon, Aug 5, 11:22 AM
leinir committed R157:2086eb66b29c: Visible/opacity semantics are fun... (authored by leinir).
Visible/opacity semantics are fun...
Mon, Aug 5, 10:22 AM
leinir committed R157:ef0f8f8785ff: Add a component for drawing a rectangle with a hole in it (authored by leinir).
Add a component for drawing a rectangle with a hole in it
Mon, Aug 5, 10:12 AM
leinir committed R157:dfaa74a1e230: Add a HolyRect to the ImageBrowser's frame navigation (authored by leinir).
Add a HolyRect to the ImageBrowser's frame navigation
Mon, Aug 5, 10:12 AM
leinir committed R157:6b252248f2b5: Add missing about page components (authored by leinir).
Add missing about page components
Mon, Aug 5, 10:12 AM

Fri, Aug 2

leinir committed R157:9d02155d4853: Remove white background on the large Creator icon (authored by leinir).
Remove white background on the large Creator icon
Fri, Aug 2, 10:05 AM
leinir committed R157:6fc0794b9d21: Add AboutData and About page to Reader (authored by leinir).
Add AboutData and About page to Reader
Fri, Aug 2, 10:05 AM
leinir committed R157:c61931c1f762: Add AboutData and About page to Creator (and fix up the menu a bit) (authored by leinir).
Add AboutData and About page to Creator (and fix up the menu a bit)
Fri, Aug 2, 10:05 AM
leinir committed R157:a8cd714d9069: Expose KAboutData as a context property (authored by leinir).
Expose KAboutData as a context property
Fri, Aug 2, 10:05 AM
leinir abandoned D18180: Fix layout issues in the AboutPage personDelegate component.

Irrelevantisified by D22868 :)

Fri, Aug 2, 8:04 AM · Kirigami

Thu, Aug 1

leinir committed R157:1d46f0905229: A bit of header cleanup (authored by leinir).
A bit of header cleanup
Thu, Aug 1, 12:39 PM
leinir committed R157:e56e0f751361: Add a touch of pretty to frame moves (authored by leinir).
Add a touch of pretty to frame moves
Thu, Aug 1, 11:15 AM
leinir committed R157:7923d6a1855d: Unbreak okular fallback viewer (due to api change) (authored by leinir).
Unbreak okular fallback viewer (due to api change)
Thu, Aug 1, 9:43 AM
leinir committed R157:bbda59f5b1b7: A touch more padding at the bottom of Book, so we can see entire pages (authored by leinir).
A touch more padding at the bottom of Book, so we can see entire pages
Thu, Aug 1, 9:43 AM
leinir accepted D22868: Revamp Kirigami.AboutPage.

While swapping out the card for straight up a rowlayout might[1] effectively look like a workaround for the weirdness in that bit... this really just looks better anyway ;) Go for it :D

Thu, Aug 1, 8:54 AM · Kirigami

Wed, Jul 31

leinir updated the diff for D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Parent the QuickQuestionAsker to qApp
  • Add in a QuestionAsker on NewStuffList
Wed, Jul 31, 1:23 PM · Frameworks
leinir updated the diff for D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Fix up the NewStuffItem installer busy indicator a bit
Wed, Jul 31, 1:02 PM · Frameworks
leinir updated the diff for D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Add in a getter for category displaynames
  • Add category/filter/sort dropdowns to NewStuffList
  • A bit of minor prettification for NewStuffItem
Wed, Jul 31, 11:39 AM · Frameworks
leinir committed R157:c1fe5d2a148e: Add the two new book categories, and accept pure zip (for now) (authored by leinir).
Add the two new book categories, and accept pure zip (for now)
Wed, Jul 31, 10:41 AM
leinir committed R157:314f1ef7af51: Guard accessing the length of a var property (authored by leinir).
Guard accessing the length of a var property
Wed, Jul 31, 10:41 AM
leinir committed R157:68a8a8896d68: Sanity check for thumbnail url (probably wants to not be Unknown role) (authored by leinir).
Sanity check for thumbnail url (probably wants to not be Unknown role)
Wed, Jul 31, 10:41 AM
leinir committed R157:8f164b6e9550: Remove some of the throttling for previews, and rejig the job removal (authored by leinir).
Remove some of the throttling for previews, and rejig the job removal
Wed, Jul 31, 10:41 AM
leinir committed R157:906d52117f5d: Use the new KNSCore config location bits (authored by leinir).
Use the new KNSCore config location bits
Wed, Jul 31, 10:41 AM
leinir committed R157:a40a5d60f10d: Sanitise the thumbnail data from the database (authored by leinir).
Sanitise the thumbnail data from the database
Wed, Jul 31, 10:41 AM
leinir committed R157:ab37ce790822: Move pdf generator option, and make it an actual cmake option (authored by leinir).
Move pdf generator option, and make it an actual cmake option
Wed, Jul 31, 10:41 AM
leinir added a comment to T11303: Expose book categories through OCS.

Thanks! :)
Yeah, i did have a quick look around and couldn't find them anywhere but in the fileserver (when i uploaded a story of my own there), that makes good sense - some testing before that bit goes live would be a sensible sort of thing :)

Wed, Jul 31, 9:18 AM · KDE Store
leinir created T11303: Expose book categories through OCS.
Wed, Jul 31, 8:59 AM · KDE Store

Tue, Jul 30

leinir updated the diff for D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Actually request a downloaditem in NewStuffItem when install/updating
Tue, Jul 30, 10:30 AM · Frameworks
leinir committed R157:6c602fcb34b8: If the initial page is -1, things will break. Assume 0 (authored by leinir).
If the initial page is -1, things will break. Assume 0
Tue, Jul 30, 10:30 AM

Thu, Jul 25

leinir committed R134:29fb6ce9e369: Add icons to Categories, Installed, and Sources globaldrawer entries (authored by leinir).
Add icons to Categories, Installed, and Sources globaldrawer entries
Thu, Jul 25, 7:40 AM
leinir closed D22716: Add icons to Categories, Installed, and Sources globaldrawer entries.
Thu, Jul 25, 7:40 AM · Plasma

Wed, Jul 24

leinir added reviewers for D22716: Add icons to Categories, Installed, and Sources globaldrawer entries: Discover Software Store, VDG.
Wed, Jul 24, 1:40 PM · Plasma
leinir requested review of D22716: Add icons to Categories, Installed, and Sources globaldrawer entries.
Wed, Jul 24, 1:38 PM · Plasma

Jul 22 2019

leinir added a comment to T11142: OCS comment rating machine readability.

How's this coming along? :) (i can't finish up the work i'm doing in D21721 without this and T11173 being done)

Jul 22 2019, 8:38 AM · KDE Store
leinir added a comment to T11173: Expose (partial) person data for unauthorised users.

How's this coming along? :) (i can't finish up the work i'm doing in D21721 without this and T11142 being done)

Jul 22 2019, 8:37 AM · KDE Store

Jul 19 2019

leinir updated the diff for D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Refactor the naming of components etc a touch (and hide private bits)
  • Fix a few bits of stray naming in the docs
Jul 19 2019, 10:55 AM · Frameworks

Jul 17 2019

leinir committed R157:943253b6c982: Remove unneeded size setting from the loaded component (authored by leinir).
Remove unneeded size setting from the loaded component
Jul 17 2019, 11:50 AM
leinir committed R157:f8bf9658ea4f: Make the Store page use a ScrollablePage (authored by leinir).
Make the Store page use a ScrollablePage
Jul 17 2019, 11:50 AM
leinir committed R157:b26f350d72e8: Update the Frameworks requirement to something more reasonable (authored by leinir).
Update the Frameworks requirement to something more reasonable
Jul 17 2019, 11:50 AM
leinir committed R157:f2171db7241d: Less warnings from kdeclarative, thx (authored by leinir).
Less warnings from kdeclarative, thx
Jul 17 2019, 11:50 AM
leinir updated the diff for D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Don't use outdated code (e.g. the Kirigami Label component)
  • Update NewStuffList to the new model API
  • Explicit operator= implementations (for less warnings)
Jul 17 2019, 11:39 AM · Frameworks

Jul 16 2019

leinir committed R157:9c137d5790ed: Filter out unsupported ghns download types (authored by leinir).
Filter out unsupported ghns download types
Jul 16 2019, 12:26 PM
leinir committed R157:3e237afe0c3f: Warning-- (authored by leinir).
Warning--
Jul 16 2019, 12:26 PM
leinir committed R157:81c6d2c1d62a: Give a touch of useful info when loading an image fails (authored by leinir).
Give a touch of useful info when loading an image fails
Jul 16 2019, 12:26 PM
leinir committed R157:910c78737e15: The app header is automatic now (authored by leinir).
The app header is automatic now
Jul 16 2019, 11:01 AM
leinir committed R157:88718bae3dd0: A touch of fixing of the welcome page loading view layout (authored by leinir).
A touch of fixing of the welcome page loading view layout
Jul 16 2019, 11:01 AM
leinir committed R157:b131ec00e14f: Ensure the page turn controls are in the right place (authored by leinir).
Ensure the page turn controls are in the right place
Jul 16 2019, 11:01 AM

Jul 12 2019

leinir updated the diff for D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • A small spacer item for the entry details page
  • Documentation++
  • Show a passive notification in the dialog when messages are posted
Jul 12 2019, 11:02 AM · Frameworks

Jul 10 2019

leinir updated the diff for D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Add a downloaditemssheet to the entry details page
Jul 10 2019, 10:48 AM · Frameworks

Jul 8 2019

leinir updated the diff for D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Put the NewStuff.Author component to use on the details page as well
Jul 8 2019, 1:51 PM · Frameworks
leinir updated the diff for D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Add the user ID to the author class
  • Expose the entry author id through the qtquick item model
  • Rename the entryAuthor property to entryAuthorId, as that's what it is
  • Add a bit more info to the author
  • Add a copy ctor to Author
  • Make sure we check the right things, and format the author correctly
Jul 8 2019, 1:33 PM · Frameworks
leinir updated the diff for D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).

Thanks kbroulik!

Jul 8 2019, 11:24 AM · Frameworks

Jul 5 2019

leinir committed R119:7a12a95faf99: Merge branch 'Plasma/5.16' (authored by leinir).
Merge branch 'Plasma/5.16'
Jul 5 2019, 8:50 AM
leinir committed R119:5d35dd7066bd: Also filter on the ghns_excluded tag, otherwise they'll be shown... (authored by leinir).
Also filter on the ghns_excluded tag, otherwise they'll be shown...
Jul 5 2019, 8:47 AM
leinir committed R119:e02c253dd840: Add TagFilter (for top level tags), and don't explicitly reject 4 (authored by leinir).
Add TagFilter (for top level tags), and don't explicitly reject 4
Jul 5 2019, 8:47 AM
leinir committed R119:e93b567ecb7f: Filter KNewStuff Plasma Themes by Download Tag (authored by leinir).
Filter KNewStuff Plasma Themes by Download Tag
Jul 5 2019, 8:47 AM
leinir closed D21510: Filter KNewStuff Plasma Themes by Download Tag.
Jul 5 2019, 8:47 AM · Plasma

Jul 4 2019

leinir added a comment to D21510: Filter KNewStuff Plasma Themes by Download Tag.

Yep, seems to work and makes sense. Let's get this in so we can start tagging things.

Aaaawesomesauce :) Land on master, or 5.16, or?

If the requisite support is entirely server-side, I'd even say the Plasma/5.12 branch and merge forward. Otherwise Plasma/5.16 and merge forward.

Jul 4 2019, 2:47 PM · Plasma
leinir added a comment to D21510: Filter KNewStuff Plasma Themes by Download Tag.
  • Also filter on the ghns_excluded tag, otherwise they'll be shown...

I thought that was taken care of on the server side?

Jul 4 2019, 2:46 PM · Plasma
leinir updated the diff for D21510: Filter KNewStuff Plasma Themes by Download Tag.
  • Also filter on the ghns_excluded tag, otherwise they'll be shown...
Jul 4 2019, 10:07 AM · Plasma

Jul 3 2019

leinir added a comment to T11173: Expose (partial) person data for unauthorised users.

I also think that the second option sounds better. I think we do it that way.
However, we have to agree exactly what should be publicly available. Following your suggestion and considering our website we would make the following attributes public:

  • username
  • avatar
  • website

    We discuss the topic in our team and clarify when and how quickly we can implement it.
Jul 3 2019, 1:12 PM · KDE Store
leinir updated the diff for D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Add profile page to the author classes
  • Add a spacer item to the CommentsPage listview
  • A touch of visual cleaning in the comment delegate
  • Type-safe comparisons are good
  • Throttle the fetch calls just a touch, no reason to be spammy
Jul 3 2019, 12:58 PM · Frameworks