leinir (Dan Leinir Turthra Jensen)
User

User Details

User Since
Jul 8 2015, 8:34 AM (89 w, 3 d)

Recent Activity

Thu, Mar 23

leinir closed D5148: Use the back function, rather than pop, when pressing Escape.

Closed by commit efe7d505eb294b11cc6d513ed8448cd5b8eab668

Thu, Mar 23, 12:44 PM · Plasma, Discover Software Store
leinir updated the summary of D5146: Implement UI feedback for long-running searches, and no-results.
Thu, Mar 23, 12:44 PM · Plasma, Discover Software Store
leinir added a comment to D5146: Implement UI feedback for long-running searches, and no-results.
In D5146#97069, @mart wrote:

just an heads up: ui reviews with VDG as reviewers should have a screenshot attached

Thu, Mar 23, 12:42 PM · Plasma, Discover Software Store
leinir closed D5147: Mark "all categories missing" kns sources as invalid.

Closed by commit 1db3b40cc4f979cc8c50dcfc1a41cddcce973ae7

Thu, Mar 23, 12:38 PM · Plasma, Discover Software Store
leinir created D5148: Use the back function, rather than pop, when pressing Escape.
Thu, Mar 23, 10:37 AM · Plasma, Discover Software Store
leinir created D5147: Mark "all categories missing" kns sources as invalid.
Thu, Mar 23, 10:35 AM · Plasma, Discover Software Store
leinir created D5146: Implement UI feedback for long-running searches, and no-results.
Thu, Mar 23, 10:34 AM · Plasma, Discover Software Store
leinir abandoned D5145: Mark "all categories missing" kns sources as invalid.

That, apparently, is not how arc works. Very sorry.

Thu, Mar 23, 9:43 AM · Plasma
leinir created D5145: Mark "all categories missing" kns sources as invalid.
Thu, Mar 23, 9:42 AM · Plasma

Fri, Mar 17

leinir committed R134:eb8f4ae2b46a: UI feedback when checking for updates (authored by leinir).
UI feedback when checking for updates
Fri, Mar 17, 9:46 AM
leinir closed D5046: UI feedback when checking for updates.

Closed by commit https://commits.kde.org/discover/eb8f4ae2b46a0516a99d26b25f120a5be28e910c

Fri, Mar 17, 9:44 AM · Discover Software Store, Plasma

Thu, Mar 16

leinir added a comment to D5046: UI feedback when checking for updates.
In D5046#95122, @apol wrote:

Have you tested what happens during the update? Does it change to "checking for updates"?

Thu, Mar 16, 12:30 PM · Discover Software Store, Plasma

Tue, Mar 14

leinir committed R134:02e9cd6399d3: Check the correct enabled property for updateButton background (authored by leinir).
Check the correct enabled property for updateButton background
Tue, Mar 14, 1:10 PM
leinir created D5046: UI feedback when checking for updates.
Tue, Mar 14, 1:05 PM · Discover Software Store, Plasma

Mon, Mar 13

leinir committed R283:39621f485f43: Add support for killing a KAuth::ExecuteJob (authored by leinir).
Add support for killing a KAuth::ExecuteJob
Mon, Mar 13, 8:49 AM
leinir closed D5001: Add support for killing a KAuth::ExecuteJob.

Closed by commit https://commits.kde.org/kauth/39621f485f434fb4453a1fd6af2796cde23eec53

Mon, Mar 13, 8:47 AM · Frameworks
leinir accepted D5003: Update docs to Frameworks API.

That looks about right to me! :)

Mon, Mar 13, 8:42 AM · Frameworks

Fri, Mar 10

leinir requested changes to D5003: Update docs to Frameworks API.

Thinking this is... well under way, with a couple of details :)

Fri, Mar 10, 2:13 PM · Frameworks
leinir created D5001: Add support for killing a KAuth::ExecuteJob.
Fri, Mar 10, 11:54 AM · Frameworks

Feb 17 2017

leinir committed R8:6b0d658effa1: Actually give that page an ID (authored by leinir).
Actually give that page an ID
Feb 17 2017, 4:38 PM
leinir committed R8:aa7e143dd070: Show the cloud account page when the list entry is clicked (authored by leinir).
Show the cloud account page when the list entry is clicked
Feb 17 2017, 4:38 PM
leinir committed R8:b2494bdf051b: Fix the count check for account removal (authored by leinir).
Fix the count check for account removal
Feb 17 2017, 4:38 PM
leinir committed R8:da839fa4691e: Make it possible to create new git clones again (authored by leinir).
Make it possible to create new git clones again
Feb 17 2017, 4:38 PM
leinir committed R8:46dcc2c08003: More useful debug outputs on git errors (authored by leinir).
More useful debug outputs on git errors
Feb 17 2017, 4:38 PM

Feb 16 2017

leinir committed R8:39199df9da56: Crash-- (authored by leinir).
Crash--
Feb 16 2017, 5:02 PM

Feb 13 2017

leinir committed R8:eebe9cf0b8dc: Assing our new QIcon icon to the sidebar header icon (authored by leinir).
Assing our new QIcon icon to the sidebar header icon
Feb 13 2017, 8:03 PM
leinir committed R8:2a3f720f2caa: Make it possible to get a QIcon from Theme (authored by leinir).
Make it possible to get a QIcon from Theme
Feb 13 2017, 8:03 PM
leinir committed R8:d056621fa306: The KIconLoader stuff is in main, not mainwindow (authored by leinir).
The KIconLoader stuff is in main, not mainwindow
Feb 13 2017, 8:03 PM
leinir committed R8:a3161e83411f: Clean up main a touch (authored by leinir).
Clean up main a touch
Feb 13 2017, 8:03 PM
leinir committed R8:cfd5143fba29: Use a QQuickWidget instead of the QQuickView... (authored by leinir).
Use a QQuickWidget instead of the QQuickView...
Feb 13 2017, 4:28 PM
leinir committed R8:e6e85fcfa3f5: A few different Gemini requirements and whatnot (authored by leinir).
A few different Gemini requirements and whatnot
Feb 13 2017, 4:28 PM
leinir committed R8:6f2cba29d12d: Make Gemini actually load files properly on Windows (authored by leinir).
Make Gemini actually load files properly on Windows
Feb 13 2017, 4:28 PM
leinir committed R8:d08fbf2e6e1c: Craft installs data into bin (authored by leinir).
Craft installs data into bin
Feb 13 2017, 4:28 PM
leinir committed R8:e42c9d24f7ff: The document is this one... (authored by leinir).
The document is this one...
Feb 13 2017, 4:28 PM
leinir committed R8:f90c61ee53fa: Pass along the part calls from Document (authored by leinir).
Pass along the part calls from Document
Feb 13 2017, 4:28 PM
leinir committed R8:d54e2a96e349: Make gemini's main.cpp work on windows again (authored by leinir).
Make gemini's main.cpp work on windows again
Feb 13 2017, 3:58 PM
leinir committed R8:5065308892d0: Fix linking order for the odf2odt filter (authored by leinir).
Fix linking order for the odf2odt filter
Feb 13 2017, 3:58 PM
leinir committed R8:a85cf5c3f9e4: Let wv2 compile with mingw (authored by leinir).
Let wv2 compile with mingw
Feb 13 2017, 3:58 PM
leinir committed R8:300ff5711b95: Such fun with qt quick plugins on windows vs elsewhere... (authored by leinir).
Such fun with qt quick plugins on windows vs elsewhere...
Feb 13 2017, 3:58 PM

Feb 11 2017

leinir committed R8:620f5df65581: Suggestions are this will fix the finite issue with mingw (authored by leinir).
Suggestions are this will fix the finite issue with mingw
Feb 11 2017, 11:16 AM
leinir committed R8:2a71b29b6e49: Don't add code that's already in a library that's linked to (authored by leinir).
Don't add code that's already in a library that's linked to
Feb 11 2017, 10:24 AM
leinir committed R8:847ba6aa35d1: Add QtQml include... i think? (authored by leinir).
Add QtQml include... i think?
Feb 11 2017, 9:31 AM

Feb 10 2017

leinir committed R8:c110f1f71c29: Need these on windows, obviously... (authored by leinir).
Need these on windows, obviously...
Feb 10 2017, 9:39 PM
leinir committed R8:8206f3b90012: Not pretty. But this module no longer exists in Qt and needs sorting (authored by leinir).
Not pretty. But this module no longer exists in Qt and needs sorting
Feb 10 2017, 9:28 PM
leinir committed R8:acbae2473325: Mark the gemini git and gemini applications as ported (authored by leinir).
Mark the gemini git and gemini applications as ported
Feb 10 2017, 8:37 PM
leinir committed R8:0bc3778dac2e: Make open other work again (authored by leinir).
Make open other work again
Feb 10 2017, 4:21 PM
leinir committed R8:d909fc978f8a: Make the welcome pages a bit prettier again (authored by leinir).
Make the welcome pages a bit prettier again
Feb 10 2017, 4:21 PM
leinir committed R8:7c2a05690c20: Rejig the repository content a bit... (authored by leinir).
Rejig the repository content a bit...
Feb 10 2017, 4:21 PM
leinir committed R8:e055860d331a: BusyIndicator is now in QtQuick.Controls (authored by leinir).
BusyIndicator is now in QtQuick.Controls
Feb 10 2017, 4:21 PM
leinir committed R8:03bcf8078022: Make the RangeInput work again (authored by leinir).
Make the RangeInput work again
Feb 10 2017, 4:21 PM
leinir committed R8:b3c7b2c47b90: Fix the custom word document page (again) (authored by leinir).
Fix the custom word document page (again)
Feb 10 2017, 4:21 PM
leinir committed R8:4dda04942655: Couple of minor details on the custom word doc page (authored by leinir).
Couple of minor details on the custom word doc page
Feb 10 2017, 4:21 PM
leinir committed R8:20847c10aade: More Kirigami and QtQuick.Controls stuff in the cloud pages (authored by leinir).
More Kirigami and QtQuick.Controls stuff in the cloud pages
Feb 10 2017, 4:21 PM
leinir committed R8:f67051efaf25: Rework the RangeInput a touch (rebased on QtQuick.Controls) (authored by leinir).
Rework the RangeInput a touch (rebased on QtQuick.Controls)
Feb 10 2017, 4:20 PM
leinir committed R8:3556cd729591: Use the scroll indicator for the git history as well (authored by leinir).
Use the scroll indicator for the git history as well
Feb 10 2017, 4:20 PM
leinir committed R8:7e5a151a11e7: Use more QtQuick controls (it crashed before?!) (authored by leinir).
Use more QtQuick controls (it crashed before?!)
Feb 10 2017, 4:20 PM

Feb 9 2017

leinir committed R8:cfe7fb09f29a: Margin-fiddling... (authored by leinir).
Margin-fiddling...
Feb 9 2017, 6:35 PM
leinir committed R8:70f7a9c1d100: Don't switch again if you're already current page (authored by leinir).
Don't switch again if you're already current page
Feb 9 2017, 6:35 PM
leinir committed R8:fb01c2b9753b: Swap some controls out for QtQuick.Controls ones (authored by leinir).
Swap some controls out for QtQuick.Controls ones
Feb 9 2017, 6:35 PM
leinir committed R8:aa8c34b6fe96: Actually make the git functionality work (commit, push, pull, merge, log) (authored by leinir).
Actually make the git functionality work (commit, push, pull, merge, log)
Feb 9 2017, 6:35 PM
leinir committed R8:fca5e7cbe64f: Switch WelcomePage's logic to something more Kirigami-esque (authored by leinir).
Switch WelcomePage's logic to something more Kirigami-esque
Feb 9 2017, 6:35 PM
leinir committed R8:89f7bfd28a94: Set a pleasant default window size (authored by leinir).
Set a pleasant default window size
Feb 9 2017, 6:35 PM
leinir committed R8:08b91d494c63: Remove the libqgit2 check (authored by leinir).
Remove the libqgit2 check
Feb 9 2017, 6:35 PM
leinir committed R8:aca1503f9929: Port the git support away from libqgit2, use libgit2 directly (authored by leinir).
Port the git support away from libqgit2, use libgit2 directly
Feb 9 2017, 6:35 PM
leinir committed R8:69d7fd3a430e: Register QAction as a type, so we can pass it through Qt Quick (authored by leinir).
Register QAction as a type, so we can pass it through Qt Quick
Feb 9 2017, 6:35 PM
leinir committed R8:3f044cd72aa2: Actually install the gemini library (authored by leinir).
Actually install the gemini library
Feb 9 2017, 6:35 PM
leinir committed R8:d84a065a1198: Add the GeminiMainWindow library (authored by leinir).
Add the GeminiMainWindow library
Feb 9 2017, 6:35 PM

Jan 27 2017

leinir accepted D4295: Add support for images embedded in the .acbf file.

With that minor caveat in the archive image provider, this looks good to me! :)

Jan 27 2017, 10:43 AM · Peruse

Jan 23 2017

leinir accepted D4226: [KNS] Take into account the distribution type.

Yup, this is fairly clearly what this is really supposed to be doing...

Jan 23 2017, 10:48 AM · Frameworks
leinir added a comment to D3984: Fixes to ACBF reading.

Given the quality here, sure - the process is described here, and when it comes to the whole reference thing, point to me :) https://community.kde.org/Infrastructure/Get_a_Developer_Account

Jan 23 2017, 10:41 AM

Jan 19 2017

leinir accepted D4065: Don't ask if we're getting the file in /tmp.

Go for it

Jan 19 2017, 11:26 AM · Frameworks

Jan 18 2017

leinir added a comment to D3984: Fixes to ACBF reading.

If you would like to get access, we can set you up with that - would make life easier in the future :)

Jan 18 2017, 11:33 AM
leinir accepted D4118: if is not an archive, always copy.

Right. I think we can sensibly pick this. I would like a comment added, though, that future "don't simply install things" logic should go into the section above this one, rather than into the if statement there... but, other than that, yes, the logic itself is good, let's go for it :)

Jan 18 2017, 11:31 AM · Frameworks, Plasma
leinir accepted D4156: sort alphabetically category list.

LGTM :)

Jan 18 2017, 11:11 AM · Frameworks, Plasma

Jan 13 2017

leinir accepted D4121: add support for display_name in categories.

This being an extension of ocs, we will need to prepare a proposal of this at some point in the not too far distant future. However, as other things (tags etc) are also going to be required, perhaps that could all be done at the same time. OCS being implementation-driven, and attica/ocs-server being the reference implementations, i did think that we might be venturing into embrace/extend territory here, however it is more akin to how OCS has always been developed (just more in the public eye now, rather than behind closed doors). So, yup, let's do this.

Jan 13 2017, 3:21 PM · Frameworks, Plasma
leinir accepted D4120: add support for display_name in categories.

We will need to consider the implications of adding functionality into ocs, but technically this would be fine.

Jan 13 2017, 3:15 PM · Frameworks, Plasma

Jan 10 2017

leinir accepted D4048: Support some of the KNSCore questions using notifications.

That works, yup :)

Jan 10 2017, 11:52 AM · Frameworks
leinir accepted D4063: Only continue if it's what was said.

Ah, yes, quite, push away :)

Jan 10 2017, 11:49 AM · Frameworks

Jan 5 2017

leinir accepted D3984: Fixes to ACBF reading.

This does change the logic somewhat... But as the result is simpler, that's fine with me :)

Jan 5 2017, 6:59 PM
leinir accepted D3985: Create arcanist config file.

Ship it :)

Jan 5 2017, 6:57 PM

Jan 4 2017

leinir committed R157:cb9f49dcf570: ACBF parser was far, far too greedy, and failed on many documents (authored by leinir).
ACBF parser was far, far too greedy, and failed on many documents
Jan 4 2017, 1:13 PM
leinir committed R157:638593522898: Use the book titles we're given (much nicer) (authored by leinir).
Use the book titles we're given (much nicer)
Jan 4 2017, 1:13 PM

Dec 22 2016

leinir committed R157:874812c7c26c: Make it explicit that we want a QLatin1String... (authored by leinir).
Make it explicit that we want a QLatin1String...
Dec 22 2016, 3:54 PM
leinir committed R157:1cf136f55868: Attempt to restore the view properly (PageRow behaves better now) (authored by leinir).
Attempt to restore the view properly (PageRow behaves better now)
Dec 22 2016, 10:43 AM
leinir committed R157:08d9b1e083c8: When updating the recently read view, update the current item as well (authored by leinir).
When updating the recently read view, update the current item as well
Dec 22 2016, 10:43 AM

Dec 21 2016

leinir committed R157:da62386dc3c4: Okular pages should now be the correct size (authored by leinir).
Okular pages should now be the correct size
Dec 21 2016, 1:26 PM

Dec 19 2016

leinir committed R157:49a1807c75ad: Add creator icon (needed a 128x128 version) (authored by leinir).
Add creator icon (needed a 128x128 version)
Dec 19 2016, 3:08 PM
leinir committed R157:0e9acc20f4d2: Remove the sidebar-expansion hack (no longer needed, yay!) (authored by leinir).
Remove the sidebar-expansion hack (no longer needed, yay!)
Dec 19 2016, 3:08 PM
leinir committed R157:d27573569e88: Don't require the plasma components (use the qtquick ones) (authored by leinir).
Don't require the plasma components (use the qtquick ones)
Dec 19 2016, 3:08 PM
leinir committed R157:c2bba18536d1: Don't use the msvc ghostscript exec names with mingw (authored by leinir).
Don't use the msvc ghostscript exec names with mingw
Dec 19 2016, 3:08 PM
leinir committed R157:8da581226e04: Make sure we find the main qml file (authored by leinir).
Make sure we find the main qml file
Dec 19 2016, 3:08 PM
leinir committed R138:0160985a290c: Switch to Kirigami's 1.1.0 release by default (authored by leinir).
Switch to Kirigami's 1.1.0 release by default
Dec 19 2016, 1:42 PM

Dec 14 2016

leinir added a reverting commit for R138:4dbc417ec7d1: Upgrade libtiff to 4.0.7: R138:f0e0c8ef090d: Revert "Upgrade libtiff to 4.0.7".
Dec 14 2016, 11:10 AM
leinir committed R138:f0e0c8ef090d: Revert "Upgrade libtiff to 4.0.7" (authored by leinir).
Revert "Upgrade libtiff to 4.0.7"
Dec 14 2016, 11:10 AM
leinir added a reverting commit for R138:fd6777f0b5dd: Update freetype (and use autothings for mingw): R138:dbf9b4388158: Revert "Update freetype (and use autothings for mingw)".
Dec 14 2016, 11:10 AM
leinir added a reverting commit for R138:53cc0acd76be: Poppler wants iconv: R138:012054737543: Revert "Poppler wants iconv".
Dec 14 2016, 11:10 AM
leinir committed R138:012054737543: Revert "Poppler wants iconv" (authored by leinir).
Revert "Poppler wants iconv"
Dec 14 2016, 11:10 AM
leinir committed R138:dbf9b4388158: Revert "Update freetype (and use autothings for mingw)" (authored by leinir).
Revert "Update freetype (and use autothings for mingw)"
Dec 14 2016, 11:10 AM
leinir added a reverting commit for R138:45441e8d33ab: Update libcurl, and build with autotools when using mingw: R138:8b766c247831: Revert "Update libcurl, and build with autotools when using mingw".
Dec 14 2016, 11:10 AM
leinir added a reverting commit for R138:4bd892f4527d: Change compile/install logic for zlib with mingw: R138:ad99744c22a3: Revert "Change compile/install logic for zlib with mingw".
Dec 14 2016, 11:10 AM