leinir (Dan Leinir Turthra Jensen)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jul 8 2015, 8:34 AM (157 w, 5 d)
Availability
Available

Recent Activity

Today

leinir accepted D14097: Change default sort order in the download dialog to Rating.

As an aside, I'd probably like this to end up being remembered between sessions, but this no different to the current state, and so outside the scope of this patch. As a default setting, yup, sorting by Rating definitely makes better sense than Newest :) (Newest would make better sense for people who look regularly, but Rating is definitely the best first-run thing, and that's the experience we're trying to improve - we can get to remembering the state later on, if everybody else agrees that that's something we want to do)

Mon, Jul 16, 8:06 AM · Frameworks
leinir accepted D14095: Fix DownloadDialog window margins to meet general theme margins.

In principle, this would really want to go via the designers, but at the same time it does seem that this was what was originally intended anyway. Shippit :)

Mon, Jul 16, 7:57 AM · Frameworks

Thu, Jul 12

leinir added a comment to D6513: Add support for Attica tags support.

Pingaling, it would be super handy if we could get this merged soon :) It's needed to support the moderation happening on the KDE Store, and also needed for better handling of specific types of content like e.g. comic books in Peruse. Thanks! :D

Thu, Jul 12, 1:47 PM · Frameworks, KNewStuff
leinir added a comment to D6512: Add support for proposed tags addition in OCS 1.7.

Ping, if we could get this merged soon, it would be terribly handy :) (it's the basis for moderating the ghns content, and needed for the knewstuff patch in D6513)

Thu, Jul 12, 1:44 PM · Frameworks, KDE Store

Wed, Jul 11

leinir created T9184: Per-category content linting .
Wed, Jul 11, 10:52 AM · KDE Store
leinir updated the task description for T9183: Appstream data (and appstream ID).
Wed, Jul 11, 10:48 AM · KDE Store
leinir created T9183: Appstream data (and appstream ID).
Wed, Jul 11, 10:47 AM · KDE Store

Mon, Jul 2

leinir added a comment to D6513: Add support for Attica tags support.

Test tool using the default settings, and with QT__LOGGING_RULES="org.kde.knewstuff.*=true"

Mon, Jul 2, 10:11 AM · Frameworks, KNewStuff
leinir updated the diff for D6513: Add support for Attica tags support.
  • add test tool
  • add support for filtering by tags on both base entry and download items contained within that entry
Mon, Jul 2, 10:09 AM · Frameworks, KNewStuff

Thu, Jun 28

leinir accepted D13732: Add debug output for all network requests.

Sorted! Good digging, nice work :)

Thu, Jun 28, 6:12 PM · Frameworks
leinir committed R8:e660876d7413: The QQuickView isn't top level, parent must accept touch events too (authored by leinir).
The QQuickView isn't top level, parent must accept touch events too
Thu, Jun 28, 11:38 AM

Wed, Jun 27

leinir committed R8:1f60109e521a: Fix a few validation errors for Calligra Gemini's Appstream data (authored by leinir).
Fix a few validation errors for Calligra Gemini's Appstream data
Wed, Jun 27, 11:53 AM
leinir committed R8:836e392c8ed0: Make touch view accept touch events on recent Qt versions (authored by leinir).
Make touch view accept touch events on recent Qt versions
Wed, Jun 27, 11:27 AM
leinir committed R8:2fe7799b45ec: Ensure Gemini drawer's open and non-modal (for static sidebarness) (authored by leinir).
Ensure Gemini drawer's open and non-modal (for static sidebarness)
Wed, Jun 27, 10:49 AM
leinir added a comment to D13744: Let ki18n macro file name follow style of other find_package related files.

Aah, yes that does happen at times :) Perhaps something to bring up on the mailing lists, something like adding the maintainers to the .arcconfigs as a hint or somesuch?

Wed, Jun 27, 10:26 AM
leinir added a comment to D13744: Let ki18n macro file name follow style of other find_package related files.

Similarly to D13743, i am unsure why you think i, specifically, should pay attention to this... Again, cleanups are lovely, and i support the effort, but i haven't really been involved with the Frameworks CMake system to a degree where i can tell whether a change such as this might cause issues in various places. To my understanding, the filename handling in cmake is caseless, and so it should be fine, but still... Again, looks fine, but this is fairly core stuff and that needs a bit of extra care and domain knowledge :)

Wed, Jun 27, 9:56 AM
leinir added a comment to D13743: Migrate build system to use find_package in autotests/ki18n_install.

This seems quite sensible to me, a cleanup and simplification of the test build system is not bad...

Wed, Jun 27, 9:51 AM · Frameworks
leinir committed R235:b173d478076e: Unbreak building tests on Windows (authored by leinir).
Unbreak building tests on Windows
Wed, Jun 27, 8:48 AM
leinir requested changes to D13732: Add debug output for all network requests.

Straight-up qDebug would cause quite a lot of spam... I'd be much happier if this was done using qCDebug (which is already used in other parts of the code, so just need to include attica_debug.h and swap for qDebug for qCDebug(ATTICA))

Wed, Jun 27, 8:32 AM · Frameworks
leinir accepted D13733: Add provider auto test.
Wed, Jun 27, 8:27 AM · Frameworks

Tue, Jun 26

leinir requested changes to D13733: Add provider auto test.

Autotests are good, but so is documentation - in principle this is good, but new public functions without documentation isn't really acceptable :)
Apart from that, though, looks good! :) (was just about to add a comment about your invalid data string being less than descriptive... but hey, it's invalid data, why not ;) )

Tue, Jun 26, 1:00 PM · Frameworks

Mon, Jun 25

leinir accepted D13714: Fix broken url to API specification.
Mon, Jun 25, 8:23 AM · Frameworks

Thu, Jun 21

leinir committed R157:8dbb984b3857: Build on Windows (authored by leinir).
Build on Windows
Thu, Jun 21, 8:16 AM

Tue, Jun 19

leinir committed R8:70be8c437406: Missing include for QFrame (authored by leinir).
Missing include for QFrame
Tue, Jun 19, 9:28 AM

Jun 13 2018

leinir added a comment to D13515: Remove KNS::Engine d-pointer hack.

Hmmmm... this is tricky, but... yes, it seems reasonable to me that replacing one pointer with another would cause no BIC issues... and i certainly am happy to get rid of the d-pointer hack, so... if we're absolutely super-sure that this is BC, i'm all for it... would kind of like someone with better linker-fu to give word on this, but in principle, i like :)

Jun 13 2018, 1:45 PM · Frameworks
firef awarded D11173: Actually vote when clicking stars in the list view a Party Time token.
Jun 13 2018, 9:02 AM · KNewStuff, Frameworks

Jun 8 2018

leinir added a comment to D13306: Simplify and Modernize some aspects of Peruse.

Silly arc... Long as the message has all the comments and such, it's ok :) Thank you :D

Jun 8 2018, 11:00 AM

Jun 7 2018

leinir accepted D13306: Simplify and Modernize some aspects of Peruse.

Awesomesauce, go for it! :)

Jun 7 2018, 10:36 AM

Jun 6 2018

This is a test notification, sent at Wed, Jun 6, 1:12 PM.
Jun 6 2018, 12:12 PM

Jun 5 2018

leinir added inline comments to D13306: Simplify and Modernize some aspects of Peruse.
Jun 5 2018, 7:14 AM

Jun 4 2018

leinir requested changes to D13306: Simplify and Modernize some aspects of Peruse.

A bunch of very good stuff in there :) Just a couple of comments, and one thing that i really would like to see changed, but all in all, very solid work :D

Jun 4 2018, 12:56 PM

Apr 20 2018

leinir committed R8:0a9ea5748906: Resolve ambiguous access reported by msvc (authored by leinir).
Resolve ambiguous access reported by msvc
Apr 20 2018, 9:08 AM

Apr 17 2018

leinir committed R8:2890f2a92903: Build on Windows again (authored by leinir).
Build on Windows again
Apr 17 2018, 9:45 AM

Apr 13 2018

leinir accepted D12169: Chart: Remove unused frame/background stuff from legend.

That's a good catch. The charts always did feel a little sort of... external, which i guess this goes some way to explain :)

Apr 13 2018, 12:29 PM · Calligra: 3.0

Apr 11 2018

leinir committed R8:e27a26744469: Build++ (authored by leinir).
Build++
Apr 11 2018, 12:51 PM
leinir committed R8:c1451bab05ff: Fix commit creation and pushing for the git plugin (authored by leinir).
Fix commit creation and pushing for the git plugin
Apr 11 2018, 12:49 PM
leinir accepted D12084: Reactivate flow apps.

Congratulations to our new Flow maintainer! ;)

Apr 11 2018, 11:09 AM · Calligra: 3.0
leinir committed R304:469db5c6934b: Don't offer qml plugin as a link target (authored by leinir).
Don't offer qml plugin as a link target
Apr 11 2018, 9:05 AM
leinir closed D12082: Don't offer qml plugin as a link target.
Apr 11 2018, 9:05 AM · KNewStuff, Frameworks

Apr 10 2018

leinir committed R8:c1866b590bd6: Unbreak loading in Gemini on Windows (authored by leinir).
Unbreak loading in Gemini on Windows
Apr 10 2018, 2:05 PM
leinir requested review of D12082: Don't offer qml plugin as a link target.
Apr 10 2018, 9:57 AM · KNewStuff, Frameworks

Mar 20 2018

leinir committed R877:bf513cb832b5: Fix libSSH2 patch for updated openssl (authored by leinir).
Fix libSSH2 patch for updated openssl
Mar 20 2018, 3:29 PM

Mar 16 2018

leinir committed R134:a69ec23a7e51: Ensure the KNS resource returns most recently updated for releaseDate (authored by leinir).
Ensure the KNS resource returns most recently updated for releaseDate
Mar 16 2018, 12:00 PM
leinir closed D11387: Ensure the KNS resource returns most recently updated for releaseDate.
Mar 16 2018, 12:00 PM · Plasma, Discover Software Store
leinir requested review of D11387: Ensure the KNS resource returns most recently updated for releaseDate.
Mar 16 2018, 11:51 AM · Plasma, Discover Software Store

Mar 12 2018

leinir committed R8:58326d57db0f: Update appdata screenshot location for Calligra Gemini (authored by leinir).
Update appdata screenshot location for Calligra Gemini
Mar 12 2018, 11:15 AM
leinir committed R234:093b5e797542: Add screenshots for Calligra Gemini (authored by leinir).
Add screenshots for Calligra Gemini
Mar 12 2018, 11:14 AM

Mar 9 2018

leinir committed R304:77e5c43a881c: Actually vote when clicking stars in the list view (authored by leinir).
Actually vote when clicking stars in the list view
Mar 9 2018, 11:43 AM
leinir closed D11173: Actually vote when clicking stars in the list view.
Mar 9 2018, 11:42 AM · KNewStuff, Frameworks
leinir committed R235:dfdbf55a4cda: Explicitly set content type to form data (authored by leinir).
Explicitly set content type to form data
Mar 9 2018, 11:39 AM
leinir closed D11172: Explicitly set content type to form data.
Mar 9 2018, 11:39 AM · Frameworks
leinir added a comment to D11172: Explicitly set content type to form data.
In D11172#221854, @apol wrote:

Which warning? How does changing to "application/x-www-form-urlencoded" help?

Mar 9 2018, 11:20 AM · Frameworks
leinir updated the summary of D11173: Actually vote when clicking stars in the list view.
Mar 9 2018, 9:51 AM · KNewStuff, Frameworks
leinir requested review of D11173: Actually vote when clicking stars in the list view.
Mar 9 2018, 9:34 AM · KNewStuff, Frameworks
leinir added a reviewer for D11172: Explicitly set content type to form data: Frameworks.
Mar 9 2018, 9:29 AM · Frameworks
leinir requested review of D11172: Explicitly set content type to form data.
Mar 9 2018, 9:28 AM · Frameworks

Feb 19 2018

leinir committed R157:4125d3149c45: Fix appdata files (authored by leinir).
Fix appdata files
Feb 19 2018, 1:38 PM
leinir committed R157:5544b050b2db: Install the pre-rendered icons (authored by leinir).
Install the pre-rendered icons
Feb 19 2018, 1:38 PM

Feb 15 2018

leinir committed R8:45866bf30bcf: Guard the canvas a bit, it can potentially be null (authored by leinir).
Guard the canvas a bit, it can potentially be null
Feb 15 2018, 5:27 PM

Jan 22 2018

leinir committed R246:9038a8effc41: Find Aspell dictionaries on Windows (authored by leinir).
Find Aspell dictionaries on Windows
Jan 22 2018, 8:38 PM
leinir closed D10017: Find Aspell dictionaries on Windows.
Jan 22 2018, 8:38 PM · Frameworks
leinir committed R877:ae3d738e342a: Install Aspell data in a more Crafty location (authored by leinir).
Install Aspell data in a more Crafty location
Jan 22 2018, 1:21 PM
leinir closed D10018: Install Aspell data in a more Crafty location.
Jan 22 2018, 1:21 PM · Craft

Jan 18 2018

leinir accepted D9907: Update the ContentList QML plugin to make it more general.

Right! It looks like this does the trick! Push away :D

Jan 18 2018, 10:21 AM
leinir accepted D9954: Ensure the database path exists before trying to create a file there.

Ah. Well spotted - and silly QStandardPaths ;)

Jan 18 2018, 9:14 AM

Jan 16 2018

leinir requested changes to D9907: Update the ContentList QML plugin to make it more general.

Nice work on the new API, very much better than the sort of slap-dash version in the original. Unfortunately, as the inline comments suggest, needs a bit of work ;)

Jan 16 2018, 11:28 AM

Jan 12 2018

leinir committed R169:811d023b5198: Ensure DesktopIcon paints with the correct aspect ratio (authored by leinir).
Ensure DesktopIcon paints with the correct aspect ratio
Jan 12 2018, 3:18 PM
leinir closed D9816: Ensure DesktopIcon paints with the correct aspect ratio.
Jan 12 2018, 3:18 PM · Kirigami

Jan 11 2018

leinir added a comment to R8:0dfb05ddf9f3: Plan: Use namespaces from report template in generated reports.

Looks like this breaks compilation on Windows... Please use the same method for iterating over the xml attributes as used in the rest of the codebase. See commit 0daa695cfde5d518d9422f3519c8900f536fdf6c for an example of somewhere else that had to be done.

Jan 11 2018, 3:21 PM
leinir added a comment to D9816: Ensure DesktopIcon paints with the correct aspect ratio.

Shows the updated output:

Jan 11 2018, 12:26 PM · Kirigami

Jan 9 2018

leinir committed R8:cd9748a49028: Don't always re-open when filename changes (authored by leinir).
Don't always re-open when filename changes
Jan 9 2018, 2:25 PM
leinir committed R8:8ae1090d609b: Fix the presentation implementation's template functionality (authored by leinir).
Fix the presentation implementation's template functionality
Jan 9 2018, 2:25 PM
leinir committed R8:3976cfbee9fb: Update the window title to something a bit better (authored by leinir).
Update the window title to something a bit better
Jan 9 2018, 2:25 PM
leinir committed R8:2115c35f0e2b: Ensure isTemporaryFile returns something useful (authored by leinir).
Ensure isTemporaryFile returns something useful
Jan 9 2018, 2:25 PM

Dec 21 2017

leinir committed R8:be26b8ff8596: Support templates and new file functionality in Components (authored by leinir).
Support templates and new file functionality in Components
Dec 21 2017, 7:44 PM
leinir committed R8:61801f8fc9e9: A better/longer description of Gemini for AppStream (authored by leinir).
A better/longer description of Gemini for AppStream
Dec 21 2017, 7:44 PM
leinir committed R8:5ca31ad3d698: Simplify the tempate logic a touch (authored by leinir).
Simplify the tempate logic a touch
Dec 21 2017, 7:44 PM
leinir requested changes to D8813: Gemini fails to open templates.

This fixes the wrong problem, i'm afraid - if you do this, then the file is not opened as a template, but rather just as a file (which results in unexpected behaviour, when you are not attempting to edit the template itself). It also doesn't fix a related issue for new file creation. Basically, this is caused by switching to the QtQuick 2 components (the old components had an implementation for this functionality, which i am currently porting over). Thank you for spotting it, though :)

Dec 21 2017, 11:26 AM · Calligra: 3.0

Dec 20 2017

leinir accepted D9421: Remove anchient and broken workaround.

Ha, yes, i concur with Aleix there, workaround-be-gone! ;) (i have a suspicion the reason i thought this worked before is because i was testing on my local machine... which also explains nicely why the packages from BF don't have functioning spell checking for me ;) )

Dec 20 2017, 12:19 PM · Frameworks
leinir committed R246:bdc6562faf73: Don't cause circular linking on Windows (authored by leinir).
Don't cause circular linking on Windows
Dec 20 2017, 10:08 AM
leinir closed D9018: Don't cause circular linking on Windows.
Dec 20 2017, 10:08 AM · Frameworks

Dec 19 2017

leinir added a comment to D9018: Don't cause circular linking on Windows.

Would it be possible to get an accept here, or is there something people fundamentally disagree with about it?

Dec 19 2017, 4:54 PM · Frameworks
leinir committed R8:6c4806a73e15: Link solver against blas as well (authored by leinir).
Link solver against blas as well
Dec 19 2017, 12:14 PM
leinir committed R8:bcab5a19f958: Disable Plan on missing KHTML condition (authored by leinir).
Disable Plan on missing KHTML condition
Dec 19 2017, 11:56 AM
leinir committed R877:583c9f938e9b: KHTML is required for Calligra Plan, so add that to the requirements (authored by leinir).
KHTML is required for Calligra Plan, so add that to the requirements
Dec 19 2017, 10:46 AM
leinir committed R157:d1e69a05800f: Import the unarr code (authored by leinir).
Import the unarr code
Dec 19 2017, 10:24 AM
leinir committed R157:d53549d4ffc8: Remove the external module for unarr (authored by leinir).
Remove the external module for unarr
Dec 19 2017, 10:24 AM

Dec 18 2017

leinir committed R8:5a2229ee7d5f: Make sure to add TextWidgets (for KRichTextWidget) (authored by leinir).
Make sure to add TextWidgets (for KRichTextWidget)
Dec 18 2017, 7:29 PM
leinir committed R877:06bb49439587: Add (temporary) patch for TagLib detection issue (authored by leinir).
Add (temporary) patch for TagLib detection issue
Dec 18 2017, 4:13 PM
leinir committed R877:43f129bfb38f: Fix up Peruse blueprint a touch for clarity (authored by leinir).
Fix up Peruse blueprint a touch for clarity
Dec 18 2017, 4:13 PM
leinir committed R304:e33d06f9857a: Require the same internal version as you're building (authored by leinir).
Require the same internal version as you're building
Dec 18 2017, 2:53 PM
leinir closed D8311: Require the same internal version as you're building.
Dec 18 2017, 2:53 PM · Frameworks, KNewStuff
leinir added a reviewer for D9398: Fix TagLib detection and build on Windows: Frameworks.
Dec 18 2017, 2:45 PM
leinir created D9398: Fix TagLib detection and build on Windows.
Dec 18 2017, 2:44 PM
leinir committed R877:c1fc2fba7a7b: Don't require all of boost, when we only need boost-system (authored by leinir).
Don't require all of boost, when we only need boost-system
Dec 18 2017, 9:14 AM
leinir committed R8:0daa695cfde5: Use same qxst iteration as elsewhere in the codebase (authored by leinir).
Use same qxst iteration as elsewhere in the codebase
Dec 18 2017, 9:02 AM

Dec 15 2017

leinir committed R8:8e55f29b8228: Only do this magic on Windows (fails elsewhere) (authored by leinir).
Only do this magic on Windows (fails elsewhere)
Dec 15 2017, 12:01 PM
leinir committed R877:f2e81bb632ad: Add Calligra blueprint (authored by leinir).
Add Calligra blueprint
Dec 15 2017, 10:37 AM
leinir committed R8:4cf27fe08f78: Ensure we have app icons on Windows (authored by leinir).
Ensure we have app icons on Windows
Dec 15 2017, 9:39 AM
leinir committed R8:23e6060411e4: Switch to using QtWebEngine for dropbox support (authored by leinir).
Switch to using QtWebEngine for dropbox support
Dec 15 2017, 9:39 AM