leinir (Dan Leinir Turthra Jensen)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 8 2015, 8:34 AM (264 w, 5 d)
Availability
Available

Recent Activity

Jun 8 2020

leinir committed R304:a1cc38205383: Don't allow content to overflow in the grid delegates (authored by leinir).
Don't allow content to overflow in the grid delegates
Jun 8 2020, 8:35 AM

May 22 2020

leinir committed R304:f02dfeecfc4f: Don't duplicate error messages in a passive notification (authored by leinir).
Don't duplicate error messages in a passive notification
May 22 2020, 7:47 PM

May 19 2020

leinir committed R169:87ba5f76d7a7: Fix the shaders resource initialisation for static builds (authored by leinir).
Fix the shaders resource initialisation for static builds
May 19 2020, 11:01 AM

May 13 2020

leinir committed R304:5ce4d1a29b96: Fix incorrect colours in the KNS Quick messagebox (authored by leinir).
Fix incorrect colours in the KNS Quick messagebox
May 13 2020, 7:49 PM
leinir closed D29678: Fix incorrect colours in the KNS Quick messagebox.
May 13 2020, 7:49 PM · Frameworks
leinir updated the diff for D29678: Fix incorrect colours in the KNS Quick messagebox.

Address comment by @ngraham

May 13 2020, 2:24 PM · Frameworks
leinir added a comment to D29678: Fix incorrect colours in the KNS Quick messagebox.

Does this even need to be a TextEdit? Or is that to get mouse-selectability for the error text? If so, +1 but please add comments indicating this reason.

May 13 2020, 2:22 PM · Frameworks
leinir accepted D29709: Give all OverlaySheets consistent headers.

Yay consistency! Good idea (and timely ;) )

May 13 2020, 1:44 PM · Plasma
leinir added a comment to D29542: Refactor canvas event handling.

Incidentally, while this was committed before i could test it, i can confirm that it works fine with Calligra Gemini

May 13 2020, 9:46 AM · Calligra: 3.0

May 12 2020

leinir added reviewers for D29678: Fix incorrect colours in the KNS Quick messagebox: Frameworks, KNewStuff, Plasma, bugseforuns.
May 12 2020, 1:50 PM · Frameworks
leinir requested review of D29678: Fix incorrect colours in the KNS Quick messagebox.
May 12 2020, 1:45 PM · Frameworks

May 7 2020

leinir accepted D29455: KNS: Deprecate isRemote method and handle parse error properly.

Sorted, nicely done :) Makes the code just a touch simpler as well, which is always good :)

May 7 2020, 9:57 AM · Frameworks
leinir accepted D29123: Do not mark entry as uninstalled if uninstallation script failed.
May 7 2020, 9:57 AM · Frameworks
leinir accepted D29451: KNS: Do not mark entry as installed if install script failed.

Thank you :D Land away :)

May 7 2020, 9:29 AM · Frameworks
leinir requested changes to D29451: KNS: Do not mark entry as installed if install script failed.

(oops, mistakenly marked as accepted, sorry...)

May 7 2020, 8:20 AM · Frameworks
leinir accepted D29451: KNS: Do not mark entry as installed if install script failed.
In D29451#665420, @alex wrote:

Fix connect

Thanks, I wasn't aware of that until now :-)

May 7 2020, 8:15 AM · Frameworks
leinir requested changes to D29451: KNS: Do not mark entry as installed if install script failed.
May 7 2020, 8:05 AM · Frameworks

May 6 2020

leinir requested changes to D29455: KNS: Deprecate isRemote method and handle parse error properly.

Apart from these couple of details, it looks pretty good :) (i'd say just fix and commit, but one of them's a tiny bit larger than just a typo fix ;) )

May 6 2020, 1:20 PM · Frameworks
leinir requested changes to D29123: Do not mark entry as uninstalled if uninstallation script failed.

Sorry about missing that bic issue before...

May 6 2020, 1:14 PM · Frameworks
leinir requested changes to D29451: KNS: Do not mark entry as installed if install script failed.

A bit nitpicky, that first one, the second's more serious (i'd like to avoid that in new code), but looks good otherwise :)

May 6 2020, 1:00 PM · Frameworks
leinir committed R304:25d391c6f36b: Fix showing updates when the option is selected (authored by leinir).
Fix showing updates when the option is selected
May 6 2020, 8:43 AM
leinir closed D29447: Fix showing updates when the option is selected.
May 6 2020, 8:43 AM · KNewStuff, Plasma, Frameworks

May 5 2020

leinir requested changes to D29455: KNS: Deprecate isRemote method and handle parse error properly.
May 5 2020, 7:59 PM · Frameworks
leinir added a comment to D29447: Fix showing updates when the option is selected.

Thanks for making me realise that it doesn't have to be quite so elaborate, @alex ;)

May 5 2020, 7:46 PM · KNewStuff, Plasma, Frameworks
leinir updated the diff for D29447: Fix showing updates when the option is selected.

As @alex suggests, just use qlist::contains, it is supposed to be
reasonably cheap, so... yup, trust the framework! ;)

May 5 2020, 7:45 PM · KNewStuff, Plasma, Frameworks
leinir added inline comments to D29447: Fix showing updates when the option is selected.
May 5 2020, 7:36 PM · KNewStuff, Plasma, Frameworks
leinir updated the diff for D29447: Fix showing updates when the option is selected.

Address comment by @alex

May 5 2020, 4:15 PM · KNewStuff, Plasma, Frameworks
leinir added projects to D29447: Fix showing updates when the option is selected: Plasma, KNewStuff.
May 5 2020, 2:44 PM · KNewStuff, Plasma, Frameworks
leinir requested review of D29447: Fix showing updates when the option is selected.
May 5 2020, 2:42 PM · KNewStuff, Plasma, Frameworks

May 4 2020

leinir committed R499:a94a2955701e: Add kpackage dependency to knewstuff (authored by leinir).
Add kpackage dependency to knewstuff
May 4 2020, 12:04 PM
leinir closed D29222: Fix update auto selection.
May 4 2020, 10:46 AM · Frameworks
leinir committed R304:12642a1c0174: Fix update auto selection (authored by leinir).
Fix update auto selection
May 4 2020, 10:46 AM
leinir committed R304:3f38da8a70d8: Add KPackage support to KNewStuffCore (authored by leinir).
Add KPackage support to KNewStuffCore
May 4 2020, 10:45 AM
leinir closed D28701: Add KPackage support to KNewStuffCore.
May 4 2020, 10:45 AM · Frameworks
leinir updated the diff for D28701: Add KPackage support to KNewStuffCore.

Since we have had a new Frameworks release while this is waiting
for the thumbs up, increase the @since to the next version.

May 4 2020, 9:57 AM · Frameworks

Apr 30 2020

leinir added a comment to D28701: Add KPackage support to KNewStuffCore.
In D28701#660186, @mart wrote:

+1 from me.

Apr 30 2020, 8:14 AM · Frameworks

Apr 28 2020

leinir added a comment to D28701: Add KPackage support to KNewStuffCore.

Ping team framework and such? (i realise we're all a tiny bit more stressy than usual...)

Apr 28 2020, 8:31 AM · Frameworks
leinir accepted D29101: KNewStuff: Fix file path and process call.

That's well spotted. Thanks for taking that one on :)

Apr 28 2020, 8:18 AM · Frameworks
leinir updated subscribers of T12787: Calligra 3.2 release.

i believe Carl's been doing some stuff already, and as we had a bit of a chat about it on the promo chat last week, i'll tag promo in as well :)

Apr 28 2020, 7:48 AM · Calligra: 3.0
leinir updated the diff for D29222: Fix update auto selection.

Thanks @ngraham, learn me to add debug information and then forget to commit it :P

Apr 28 2020, 7:33 AM · Frameworks

Apr 27 2020

leinir added reviewers for D29222: Fix update auto selection: Frameworks, Plasma, bugseforuns, ngraham.
Apr 27 2020, 9:40 AM · Frameworks
leinir requested review of D29222: Fix update auto selection.
Apr 27 2020, 9:39 AM · Frameworks

Apr 24 2020

leinir added inline comments to D28701: Add KPackage support to KNewStuffCore.
Apr 24 2020, 2:40 PM · Frameworks
leinir added a comment to T12787: Calligra 3.2 release.

It's out, so frezzes lifted.
I have posted a changelog draft on calligra-devel, please reviw!

Apr 24 2020, 10:02 AM · Calligra: 3.0
leinir requested changes to D29123: Do not mark entry as uninstalled if uninstallation script failed.

On a related note, i'm waiting on reviews on D28701 at the moment... which i'm afraid might wreck some havoc with your patch, as they touch some of the same bits of the codebase.

Apr 24 2020, 9:16 AM · Frameworks

Apr 23 2020

leinir added a comment to D29126: KNewStuff: port from KRun::runApplication to KIO::ApplicationLauncherJob.

And KRun was widgets based too. At least now you can get rid of widgets completely (for this bit about starting apps) by connecting to the result() signal yourself instead of using a dialog ui delegate. There's also a knotifications based ui delegate, but not sure it's appropriate here (that's more for plasma itself I would say).

Apr 23 2020, 10:42 AM · Frameworks
leinir accepted D29126: KNewStuff: port from KRun::runApplication to KIO::ApplicationLauncherJob.

Was /just/ about to be all "nooo, widgets in core, crying forever" but this isn't core, so go for it ;)

Apr 23 2020, 10:38 AM · Frameworks
leinir added a comment to D29123: Do not mark entry as uninstalled if uninstallation script failed.

(and now i've done it myself, terribly sorry about that, missed the WIP at the start of the title! Hope some of my comments were useful, though :) )

Apr 23 2020, 9:29 AM · Frameworks
leinir requested changes to D29123: Do not mark entry as uninstalled if uninstallation script failed.

The reporting side of this seems based on a misunderstanding of what the UI-less Core is supposed to be doing... The conceptual intention in general isn't bad, but it needs a bit of work. Thanks for spotting it, too :)

Apr 23 2020, 9:28 AM · Frameworks

Apr 22 2020

leinir updated the diff for D28701: Add KPackage support to KNewStuffCore.

Some documentation and whitespace fixes for Frameworksiness

Apr 22 2020, 10:28 AM · Frameworks
leinir added a comment to D29057: Introduce PlaceholderMessage component.

Nice! Got a few places where this could be very handy :)

Apr 22 2020, 8:25 AM · Kirigami

Apr 21 2020

leinir added a comment to D28701: Add KPackage support to KNewStuffCore.

I mean, GHNS basically *is* a userspace package manager, and things like dependency management and removal of stale files are why package managers exist. :)

If it needs to be fixed/implemented in other patches, that's okay.

Apr 21 2020, 6:51 PM · Frameworks
leinir added a comment to D28701: Add KPackage support to KNewStuffCore.

Great. There are still a few more bugs though:

When you install certain global themes, they ask for authentication so install an SDDM theme. However when you uninstall that theme, it doesn't request authentication to remove them SDDM theme. So /usr/share/sddm/themes accumulates a growing collection of unused themes:

ls /usr/share/sddm/themes/
breeze  breeze-openSUSE  elarun  Layan  maldives  maya  McMojave  plasmaX  Sweet
Apr 21 2020, 9:39 AM · Frameworks

Apr 20 2020

leinir updated the diff for D28701: Add KPackage support to KNewStuffCore.

Thank you to @ngraham for noticing this one! It only really pokes its head
out if you have multiple things installed and then try and uninstall one of
them - if you only have the one thing installed, it looks very much like
as though it's just cleaning up after itself and removing the containing
folder... Easy enough fix, though :)

Apr 20 2020, 8:11 AM · Frameworks
leinir added a comment to D28701: Add KPackage support to KNewStuffCore.

As i thought, i was indeed holding the KPackage APi incorrectly ;) The culprit is hinted at in the line

Apr 20 2020, 8:07 AM · Frameworks

Apr 17 2020

leinir added a comment to D28701: Add KPackage support to KNewStuffCore.

Thanks, the hang is gone now. However I have a new problem:

  1. Open Global Themes KCM and click new new global themes
  2. Install Sweet KDE and McMojave LAF global themes
  3. Close the GHNS dialog
  4. Open the dialog again
  5. Uninstall the McMojave LAF theme
  6. Close the dialog

    Both McMojave LAF and also Sweet KDE have disappeared from the KCM. Sweet KDE still shows up as installed in the GHNS dialog and Discover, but does not appear in the KCM.

    The same thing happens for plasma themes too. It seems that deleting one item from the GHNS dialog marks all of the installed GHNS items of that type as deleted.
Apr 17 2020, 5:46 PM · Frameworks
leinir added reviewers for D28701: Add KPackage support to KNewStuffCore: broulik, bshah.

Tagging in a couple of people who were in the original chat about doing this integration... :)

Apr 17 2020, 10:38 AM · Frameworks

Apr 16 2020

leinir updated the summary of D28701: Add KPackage support to KNewStuffCore.
Apr 16 2020, 3:25 PM · Frameworks
leinir updated the diff for D28701: Add KPackage support to KNewStuffCore.

Address @ngraham's (and my own) worry about the synchronous behaviour exhibited by KPackage... Something a bit like this probably wants to go into KPackage itself, perhaps we can consider this after we've done a bit of testing of its solidity here...

Apr 16 2020, 3:24 PM · Frameworks
leinir added a comment to D28701: Add KPackage support to KNewStuffCore.

This has fixed the issues I was seeing with installation and uninstallation, nice! However I'm not seeing a very long hang when installing certain global themes--for example Sweet KDE and Layan Look and Feel Theme. It does ultimately work, but the dialog freezes for multiple minutes before finally becoming interactive again.

Apr 16 2020, 7:51 AM · Frameworks

Apr 15 2020

leinir added reviewers for D28701: Add KPackage support to KNewStuffCore: ngraham, mart, davidedmundson.

Tagging in those active in the referenced bug, except for the reporter who doesn't have a phabricator account

Apr 15 2020, 2:01 PM · Frameworks
leinir updated the summary of D28701: Add KPackage support to KNewStuffCore.
Apr 15 2020, 1:33 PM · Frameworks
leinir updated the diff for D28701: Add KPackage support to KNewStuffCore.

Think we're at the point where testing would be good, now. This update
means we now attempt to adopt already installed kpackages if you try and
install the package from knewstuff, and removal of entries installed
using the previous implementation should now also happen during a fallback
step, intended to make life a bit simpler for those who have used this
before...

Apr 15 2020, 1:30 PM · Frameworks
leinir updated the diff for D28701: Add KPackage support to KNewStuffCore.

(the fallback handling needs some more work, but also progress)

Apr 15 2020, 10:33 AM · Frameworks

Apr 14 2020

leinir updated the test plan for D28701: Add KPackage support to KNewStuffCore.
Apr 14 2020, 1:55 PM · Frameworks
leinir updated the test plan for D28701: Add KPackage support to KNewStuffCore.
Apr 14 2020, 1:54 PM · Frameworks
leinir updated the diff for D28701: Add KPackage support to KNewStuffCore.
  • Make a touch of noise when encountering the fallback
Apr 14 2020, 1:37 PM · Frameworks
leinir updated the summary of D28701: Add KPackage support to KNewStuffCore.
Apr 14 2020, 1:34 PM · Frameworks
leinir updated the summary of D28701: Add KPackage support to KNewStuffCore.
Apr 14 2020, 1:33 PM · Frameworks
leinir updated the diff for D28701: Add KPackage support to KNewStuffCore.

Bunch of new functionality, with a fallback which ought to allow it to work
without requiring any kind of changes to the existing knsrc files based on
kpackage, as long as they follow the pattern they seem to mostly follow.

Apr 14 2020, 1:29 PM · Frameworks
leinir added a comment to D28701: Add KPackage support to KNewStuffCore.

Okay thanks, can you update the test plan then? Also I think the diff currently does not actually fix 418466.

Apr 14 2020, 8:30 AM · Frameworks

Apr 9 2020

leinir added a comment to D28701: Add KPackage support to KNewStuffCore.

Am I not testing properly?

Apr 9 2020, 4:41 PM · Frameworks
leinir updated the diff for D28701: Add KPackage support to KNewStuffCore.
  • Remove a stray newline
Apr 9 2020, 12:46 PM · Frameworks
leinir requested review of D28701: Add KPackage support to KNewStuffCore.
Apr 9 2020, 12:41 PM · Frameworks
leinir created P580 Output of KPackage support in KNewStuff's Installer in the S1 KDE Community space.
Apr 9 2020, 12:27 PM

Apr 7 2020

leinir created P574 Sample of a larger (more elaborate) kns registry in the S1 KDE Community space.
Apr 7 2020, 10:43 AM
leinir created P573 An example of a kns registry file in the S1 KDE Community space.
Apr 7 2020, 10:26 AM
leinir committed R304:37452d022c6e: Fix minor typo (stray word from the wrong bit of the sentence) (authored by leinir).
Fix minor typo (stray word from the wrong bit of the sentence)
Apr 7 2020, 9:05 AM
leinir added a comment to T12787: Calligra 3.2 release.

No objections from this side :)

Apr 7 2020, 7:51 AM · Calligra: 3.0

Apr 6 2020

leinir committed R304:eb23f549ea9b: Introduce more user-visible error reporting for installations (authored by leinir).
Introduce more user-visible error reporting for installations
Apr 6 2020, 2:43 PM
leinir closed D28532: Introduce more user-visible error reporting for installations.
Apr 6 2020, 2:43 PM · Frameworks
leinir updated the test plan for D28532: Introduce more user-visible error reporting for installations.
Apr 6 2020, 11:51 AM · Frameworks
leinir updated the diff for D28532: Introduce more user-visible error reporting for installations.
  • Merge branch 'master' into more-installation-error-handling
  • Actually read the error (not just all)
Apr 6 2020, 11:50 AM · Frameworks
leinir updated the test plan for D28532: Introduce more user-visible error reporting for installations.
Apr 6 2020, 9:09 AM · Frameworks

Apr 4 2020

leinir committed R304:449d056a2d77: Fix layout in DownloadItemsSheet (authored by leinir).
Fix layout in DownloadItemsSheet
Apr 4 2020, 1:35 PM
leinir closed D28540: Fix layout in DownloadItemsSheet.
Apr 4 2020, 1:35 PM · Frameworks

Apr 3 2020

leinir added reviewers for D28540: Fix layout in DownloadItemsSheet: Frameworks, bugseforuns, mart, Plasma, KNewStuff.
Apr 3 2020, 2:47 PM · Frameworks
leinir requested review of D28540: Fix layout in DownloadItemsSheet.
Apr 3 2020, 2:46 PM · Frameworks
leinir updated the diff for D28532: Introduce more user-visible error reporting for installations.
  • Address @pino's comment re i18n overload usage
Apr 3 2020, 10:44 AM · Frameworks
leinir updated the test plan for D28532: Introduce more user-visible error reporting for installations.
Apr 3 2020, 10:21 AM · Frameworks
leinir added reviewers for D28532: Introduce more user-visible error reporting for installations: KNewStuff, Plasma, ngraham, Frameworks.
Apr 3 2020, 9:19 AM · Frameworks
leinir requested review of D28532: Introduce more user-visible error reporting for installations.
Apr 3 2020, 9:17 AM · Frameworks

Apr 2 2020

leinir committed R304:aa29f344928e: Switch to using Kirigami's ShadowedRectangle (authored by leinir).
Switch to using Kirigami's ShadowedRectangle
Apr 2 2020, 8:54 AM
leinir closed D28220: Switch to using Kirigami's ShadowedRectangle.
Apr 2 2020, 8:54 AM · Frameworks

Mar 31 2020

leinir added a comment to D28220: Switch to using Kirigami's ShadowedRectangle.

Ping? Not super critical, i guess, but it just feels sad to have things pending for weeks...

Mar 31 2020, 10:43 AM · Frameworks

Mar 30 2020

leinir added inline comments to D28298: Reduce superfluous changedEntriesChanged emissions.
Mar 30 2020, 12:48 PM · Frameworks

Mar 25 2020

leinir added inline comments to D28220: Switch to using Kirigami's ShadowedRectangle.
Mar 25 2020, 9:04 AM · Frameworks
leinir updated the diff for D28220: Switch to using Kirigami's ShadowedRectangle.

Address comment by @ahiemstra

Mar 25 2020, 8:29 AM · Frameworks

Mar 24 2020

leinir updated subscribers of D28220: Switch to using Kirigami's ShadowedRectangle.

Just an observation, we should maybe consider making a shared component for this screenshots list so that Discover can use it too.

Mar 24 2020, 3:19 PM · Frameworks
leinir updated the diff for D28220: Switch to using Kirigami's ShadowedRectangle.
  • Less magic numbers
  • Remove some unneeded bits
Mar 24 2020, 10:06 AM · Frameworks