leinir (Dan Leinir Turthra Jensen)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jul 8 2015, 8:34 AM (178 w, 4 d)
Availability
Available

Recent Activity

Wed, Dec 5

leinir added inline comments to D17334: Export enum into qobject for easier debugging.
Wed, Dec 5, 12:23 PM · Frameworks
leinir accepted D17334: Export enum into qobject for easier debugging.

Good call there, yup :)

Wed, Dec 5, 11:23 AM · Frameworks

Fri, Nov 30

leinir added a comment to T10138: Avatar URL.

That's indeed good inspiration - don't really see a reason not to follow their examples, so for the options, instead of the magic stuff above, we could do...

Fri, Nov 30, 10:13 AM · KDE Store

Thu, Nov 29

leinir created T10138: Avatar URL.
Thu, Nov 29, 2:59 PM · KDE Store
leinir added inline comments to D17216: Move the about page from Discover to Kirigami.
Thu, Nov 29, 12:10 PM · Kirigami

Wed, Nov 28

leinir accepted D17177: Drop tab-based UI for the about page.

Lovin' it - i also like how sort of... well, how little code there really is here, QML done absolutely the right way, only the presentation and that's it, nifty :)

Wed, Nov 28, 9:55 AM · Plasma

Tue, Nov 27

leinir added a comment to D17177: Drop tab-based UI for the about page.

Ah yes, somehow i managed to miss the button @colomar mentions, which does the bug reporting linkage already. Removing the link in favour of just keeping that button seems a sensible option :)

Tue, Nov 27, 2:26 PM · Plasma
leinir requested changes to D17177: Drop tab-based UI for the about page.

It does seem that the bugAddress being an email address is a bit odd... The address given by KAboutData::bugAddress can be either an email address, or a URL, though, so it might make sense to try and handle either case (something as simple as checking for :// in the string would probably work), to make the functionality here functionally equivalent to the qwidget dialogue.

Tue, Nov 27, 2:22 PM · Plasma

Thu, Nov 22

leinir added a comment to D17079: Provide a qqc2/kirigami-based about page.

Basically what Nate said, this is a great idea :) Thinking that having this is already an improvement, but also perhaps that having it as a scrollable page would indeed feel more natural here rather than tabs... Thinking this seems like a good place to use the fact that Cards are good for not-quite-similar data, or am i off there?

Thu, Nov 22, 12:56 PM · Plasma

Wed, Nov 21

leinir accepted D17058: Fix android build.

Thanks! :)

Wed, Nov 21, 10:38 AM

Tue, Nov 20

leinir committed R134:8bea95730eab: Allow clicking of links in app descriptions (authored by leinir).
Allow clicking of links in app descriptions
Tue, Nov 20, 2:32 PM
leinir closed D17050: Allow clicking of links in app descriptions.
Tue, Nov 20, 2:32 PM · Discover Software Store, Plasma
leinir requested review of D17050: Allow clicking of links in app descriptions.
Tue, Nov 20, 1:52 PM · Discover Software Store, Plasma

Mon, Nov 19

leinir committed R134:49229f398abd: We now have a hard dependency on KNewStuff 5.53 (authored by leinir).
We now have a hard dependency on KNewStuff 5.53
Mon, Nov 19, 9:54 AM

Wed, Nov 14

leinir created T10032: Allow creators to add ghns_exclude to their own content items.
Wed, Nov 14, 9:47 AM · KDE Store

Tue, Nov 13

leinir updated subscribers of R134:7f6caf385809: Better error handling in KNewStuff backend.

Through pushing this patch, i have discovered there is no easily discoverable documentation regarding when Frameworks are updated for unstable builds. According to https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.11/68/console KF 5.53 is found, but the version being found does not include the patch pushed to KNewStuff yesterday (D16665). I did think there was some reasonable timing for updating Frameworks for other CI builds, and so left it overnight. However, this turns out not to be long enough. Am i simply unable to find this documentation (and wrong in thinking that https://community.kde.org/Policies would be the right place), or is such documentation simply not available? It would be terribly handy to know. I did ask on #kde-devel on freenode, but nobody there seemed to know either.

Tue, Nov 13, 1:24 PM
leinir committed R304:3b270a216664: Mark new public bits as since 5.53 (authored by leinir).
Mark new public bits as since 5.53
Tue, Nov 13, 9:16 AM
leinir committed R134:7f6caf385809: Better error handling in KNewStuff backend (authored by leinir).
Better error handling in KNewStuff backend
Tue, Nov 13, 9:09 AM
leinir closed D16776: Better error handling in KNewStuff backend.
Tue, Nov 13, 9:09 AM · Discover Software Store, Plasma

Mon, Nov 12

leinir committed R304:e8e3160cd20c: Add programmaticaly useful error signalling (authored by leinir).
Add programmaticaly useful error signalling
Mon, Nov 12, 12:41 PM
leinir closed D16665: Add programmaticaly useful error signalling.
Mon, Nov 12, 12:41 PM · Frameworks, KNewStuff
leinir updated the diff for D16776: Better error handling in KNewStuff backend.

Address @apol's comments

Mon, Nov 12, 11:39 AM · Discover Software Store, Plasma
leinir added a comment to D16776: Better error handling in KNewStuff backend.
In D16776#356741, @apol wrote:

Where will the All categories are missing error fall right now?

Mon, Nov 12, 11:37 AM · Discover Software Store, Plasma

Nov 9 2018

leinir added a dependent revision for D16665: Add programmaticaly useful error signalling: D16776: Better error handling in KNewStuff backend.
Nov 9 2018, 12:05 PM · Frameworks, KNewStuff
leinir added a dependency for D16776: Better error handling in KNewStuff backend: D16665: Add programmaticaly useful error signalling.
Nov 9 2018, 12:05 PM · Discover Software Store, Plasma
leinir requested review of D16776: Better error handling in KNewStuff backend.
Nov 9 2018, 11:57 AM · Discover Software Store, Plasma

Nov 7 2018

leinir added a comment to D16665: Add programmaticaly useful error signalling.
In D16665#355578, @apol wrote:

Maybe it would be good to produce the Discover patch before committing this to make sure the API is the one we want.

Nov 7 2018, 2:03 PM · Frameworks, KNewStuff
leinir updated the diff for D16665: Add programmaticaly useful error signalling.

Adjust the patch to address @apol's comment about deprecating the old error signal

Nov 7 2018, 1:31 PM · Frameworks, KNewStuff
leinir added inline comments to D16665: Add programmaticaly useful error signalling.
Nov 7 2018, 1:14 PM · Frameworks, KNewStuff

Nov 4 2018

leinir requested review of D16665: Add programmaticaly useful error signalling.
Nov 4 2018, 4:38 PM · Frameworks, KNewStuff

Oct 9 2018

leinir added a comment to D15053: Consistently use qreal in libs/pigment.

@dcaliste @anthonyfieroni Any updates here, pro/con? Would be a terrible shame to let this fall through :)

Oct 9 2018, 9:12 AM · Calligra: 3.0

Oct 8 2018

leinir accepted D15951: Add opening a file via the command line..

Looks good from here - unless @pino has further to add, go for it :)

Oct 8 2018, 10:57 AM · Peruse

Oct 5 2018

leinir added inline comments to D15951: Add opening a file via the command line..
Oct 5 2018, 12:45 PM · Peruse
leinir added inline comments to D15951: Add opening a file via the command line..
Oct 5 2018, 11:30 AM · Peruse

Oct 1 2018

leinir accepted D15820: Update database when booklist is updated..

bindValue is a good choice, yes, thank you ;) Go for it :)

Oct 1 2018, 12:23 PM · Peruse
leinir committed R304:158ba4e2420b: Add support for Attica tags support (authored by leinir).
Add support for Attica tags support
Oct 1 2018, 11:49 AM
leinir closed D6513: Add support for Attica tags support.
Oct 1 2018, 11:49 AM · Frameworks, KNewStuff

Sep 30 2018

leinir added a comment to D6513: Add support for Attica tags support.

Sorry for pinging again, but i'd really quite like to not have to wait (yet) another cycle for this to get out...

Sep 30 2018, 10:41 AM · Frameworks, KNewStuff

Sep 28 2018

leinir added a comment to D15766: Add keywords, characters and genres to the bookentry/database and use it for a category filter..

I was thniking in terms of 'putting seriesNumbers and Volumes next to the series entry', and such. But I'll push this after my daily walk :)

Sep 28 2018, 11:35 AM · Peruse
leinir requested changes to D15775: Make the item background color and page cache properties available from View component.

Looks pretty good to me. It'd be nice if we could avoid exposing DocumentImpl (it's supposed to be sort of hidden), if you could have a think on a way to avoid that, i'd appreciate it :)

Sep 28 2018, 10:54 AM · Calligra: 3.0
leinir accepted D15766: Add keywords, characters and genres to the bookentry/database and use it for a category filter..

Not entirely sure how we would really make the database any nicer.. don't particularly want to add more tables, though i guess that might be what we'd end up doing (in essence, a new table for everything that's currently a csv list). If you feel like doing it, though, do go ahead :)

Sep 28 2018, 9:08 AM · Peruse
leinir updated subscribers of T9768: URL store.kde.org not reachable: Error 503.

@leinir: Who is responsible for the name server? Who can help me?

Sep 28 2018, 9:00 AM · KDE Store

Sep 26 2018

leinir committed R157:0f264cb49185: Add keyboard navigation for frames (authored by leinir).
Add keyboard navigation for frames
Sep 26 2018, 12:34 PM
leinir updated the diff for D6513: Add support for Attica tags support.

Address @cfeck's comments

Sep 26 2018, 11:54 AM · Frameworks, KNewStuff
leinir added a comment to D6513: Add support for Attica tags support.
In D6513#332106, @cfeck wrote:

Using a hash to map public to private class is a good idea. The only thing I'm not sure about is if there is a memory leak. I would think that having only pointers in the hash will never free the referenced values.

Sep 26 2018, 11:53 AM · Frameworks, KNewStuff
leinir added a comment to D6513: Add support for Attica tags support.

Sorry for pinging again, but i'd quite like this to get in, bic fixed and all that, before the next release...

Sep 26 2018, 10:11 AM · Frameworks, KNewStuff

Sep 25 2018

leinir accepted D15748: Remove entries from cache if their filename does not exist..

Good stuff, let's roll with this one :)

Sep 25 2018, 2:09 PM · Peruse
leinir added a comment to D15748: Remove entries from cache if their filename does not exist..

Well, the thing is, I have a large collection(sqlitebrowser counts about 586 entries right now), yes, but I also have a fairly beefy computer. Starting peruse with clear-db takes way longer than this(which is near instantaneous), but because I have a beefy computer I suspect it might be the debug messages that is the major cause of the slowdown with clear-db. Either someone with a slow harddrive should check this, or I'll drop the patch and wait for one that is theoretically speedier.

Sep 25 2018, 1:51 PM · Peruse
leinir added a comment to D15748: Remove entries from cache if their filename does not exist..

The reason i didn't do this before is that it does file system access, which is precisely what the cache is supposed to try to avoid... You've got a large collection, right? What sort of impact does this have on load time? (baloo shouldn't matter in this case, but it's good to test with that turned off anyway...)

Sep 25 2018, 1:42 PM · Peruse
leinir added inline comments to D15734: Order books in their series number if available..
Sep 25 2018, 10:05 AM · Peruse
leinir accepted D15734: Order books in their series number if available..

Similarly unsure whether we can reasonably make it appreciably cleaner... let's roll with it :)

Sep 25 2018, 8:46 AM · Peruse

Sep 24 2018

leinir added a comment to D15713: Extend the categories model with some extra items..

Great stuff, push away! :)

No showstopper or anything, just for a bit of background: The reason behind caching everything is that file system access is super expensive, so causing file system access for cached entries seems perhaps less than good. To test whether this is sufficiently fast for you, turn off your file indexer (balooctl stop should do that nicely). If it is, indeed, fast enough, then go for it, otherwise caching will want to happen for those parts as well... We need some way to update the cache when the filesystem has changed, but i'm as yet unsure of how to properly deal with that... However, that doesn't have to stop the patch going in, just something to check :)

Weirdly enough, on my system, if a file has not been indexed by baloo, Peruse just doesn't see it.

Sep 24 2018, 11:55 AM · Peruse
leinir accepted D15617: Move away from kdebug and kdelibs4 in filter/sheets.

Yes please, categorification and less dependency on the support library is definitely a good thing :)

Sep 24 2018, 11:20 AM · Calligra: 3.0
leinir accepted D15679: Add missing dependencies for PART_STAGE.

Maybe it would be nice to replace the Q_ASSERT with an if (factory) {} and put a warning in the else part in case of a wrong installation and plugins are missing. What do you think ?

Sep 24 2018, 11:16 AM · Calligra: 3.0
leinir accepted D15713: Extend the categories model with some extra items..
Sep 24 2018, 9:58 AM · Peruse
leinir added a comment to D15713: Extend the categories model with some extra items..

Great stuff, push away! :)

Sep 24 2018, 9:58 AM · Peruse

Sep 21 2018

leinir accepted D15661: Frame zoom in the image browser..

Niiiiice... Really neat stuff, thank you! Sure, i'll do a bit of hooking up with keys and whatnot :)

Sep 21 2018, 2:38 PM · Peruse
leinir added a comment to D6513: Add support for Attica tags support.

For ease of re-reviewing, the relevant bits of the patch (the bits that didn't already get the tickmark) can be seen on their own like so: https://phabricator.kde.org/D6513?vs=41133&id=41886&whitespace=ignore-most#toc

Sep 21 2018, 11:58 AM · Frameworks, KNewStuff
leinir added a comment to D15053: Consistently use qreal in libs/pigment.

This is looking pretty good to me, really... i know there was talk about deprecating qreal at some point, but turns out that never happened?

Sep 21 2018, 8:13 AM · Calligra: 3.0

Sep 20 2018

leinir accepted D15601: Add parsing of comicinfo.xml and CoMet..

Hmm... i have no comments to make, this is good stuff! Fire away :)

Sep 20 2018, 9:19 AM · Peruse

Sep 18 2018

leinir added a comment to D15591: Add Open Document thumbnailer.

[...]actually uses KOffice classes

Sep 18 2018, 6:41 PM · Frameworks, Dolphin
leinir added a comment to D15542: Make ACBF library data accesible from QML and update Peruse Creator to edit them..

I actually did manage to get the swap working just now, I replaced the counts with stringlists with the points of the frames(which should be useful for debug as well :) )

Sep 18 2018, 10:53 AM · Peruse
leinir accepted D15542: Make ACBF library data accesible from QML and update Peruse Creator to edit them..

Okay, updated with the changed you suggested. (And all my own changes I thought were really necessary.)

Sep 18 2018, 10:28 AM · Peruse
leinir updated the diff for D6513: Add support for Attica tags support.

Forgot @since 5.51 in the new api in Provider.h

Sep 18 2018, 9:20 AM · Frameworks, KNewStuff

Sep 17 2018

leinir added a comment to D15542: Make ACBF library data accesible from QML and update Peruse Creator to edit them..

It also needs a property registery? But I can't for the life of me figure out how to set that up, when I copy qmlplugin to the acbf folder it complains it cannot find the qmlengine type despite including QtQml/QQmlEngine. I am giving up on this now.

Sep 17 2018, 12:01 PM · Peruse
leinir requested review of D6513: Add support for Attica tags support.

Previous patch had BIC issues - new patch attempts to address this, but as a result (of course) requires another round of review.

Sep 17 2018, 11:01 AM · Frameworks, KNewStuff
leinir updated the diff for D6513: Add support for Attica tags support.

After discovering that the previous version of this patch had introduced a binary incompatibility, and panicking momentarily that this had been done in a release, Jonathan reverted it (as i was away for a bit and unable to do so myself). The patch here attempts to fix the BIC issue, while also readjusting the logic for how the tag filters reach the provider. It is now done directly by the provider itself, rather than through each search request. While this does introduce that nasty d-pointer hack, it also makes more logical sense that the Provider itself holds the information (as that's where those filters are directly relevant). So, nasty surprise to find out i'd caused things to break, but the end result is, i think, kind of better anyway (even though it introduces that todo for kf-next).

Sep 17 2018, 11:00 AM · Frameworks, KNewStuff
leinir accepted D15567: Words: Do not popup contextmenu twice.

Yes please, thank you! That has frankly been bugging me for a while... We're sure there's no side effects here? But, yeah, having two menus pop up underneath each other is sort of annoying ;)

Sep 17 2018, 7:54 AM · Calligra: 3.0

Sep 15 2018

leinir reopened D6513: Add support for Attica tags support.

FYI, this included an ABI change to SearchRequest that broke Discover: https://bugs.kde.org/show_bug.cgi?id=398412

I see this revision has been reverted in master in 293ae2448f54fd1b1f7cacc86cd40b30a3fb087d

Sep 15 2018, 5:14 PM · Frameworks, KNewStuff

Sep 14 2018

leinir added a comment to T1350: Viewport-based comic book view support.

Hmm... this is const because the getter is const... going by what the example suggest, implementing a QQmlListProperty requires the getter not to be const, which of course seems weird for a READ function, but that is what it expects, so... yeah, try that?

Sep 14 2018, 8:54 AM · Peruse

Sep 13 2018

leinir added a comment to D6513: Add support for Attica tags support.

So I see ghns_exclude over at store.kde.org, but it doesn't feel quite right to check that box next to everything KDE4. Is that what I should be doing?

That is precisely what you should be doing, yes :) You are right, it doesn't quite feel right to just outright exclude everything KDE4 from GHNS, but the reason it works is that the filtering happens clientside, and it will still show up for anybody who doesn't have this patch (or, in other words, anybody who has a less than version 5.51 Frameworks).

OK, got it! Will commence that work and then document it with some instructions in https://community.kde.org/Get_Involved. :)

Sep 13 2018, 9:59 AM · Frameworks, KNewStuff

Sep 12 2018

leinir accepted D15407: Fix OCS provider URL in about dialog.
Sep 12 2018, 8:58 AM · Frameworks
leinir added a comment to D6513: Add support for Attica tags support.

So is this enough for people to start tagging KDE4 content as such? Or is anything else still required before that capability lands?

In short, this is basically enough :) When people run KNewStuff with this patch, any content which has been marked as ghns_exclude (that tick box you and the other moderators have on the store) will be hidden from the user :) For doing more "proper" filtering, changes will want to be done to either just the knsrc files, or to the clients themselves (which would be for things like "don't show wallpapers with incorrect resolutions" or "only show things with x86 binaries" or that sort of stuff).

So I see ghns_exclude over at store.kde.org, but it doesn't feel quite right to check that box next to everything KDE4. Is that what I should be doing?

Sep 12 2018, 6:53 AM · Frameworks, KNewStuff

Sep 11 2018

leinir accepted D15351: Make switching to new books in series easier..

Hmm! Yes, that's a good idea, hadn't really thought of that :)

Sep 11 2018, 9:56 AM · Peruse
leinir accepted D15354: Add an indicator that press does something to BookTileTall..

Hmm... Yeah, that sounds like a pretty good idea, really... let's do it :)

Sep 11 2018, 9:55 AM · Peruse

Sep 8 2018

leinir added a comment to D6513: Add support for Attica tags support.

So is this enough for people to start tagging KDE4 content as such? Or is anything else still required before that capability lands?

Sep 8 2018, 9:54 AM · Frameworks, KNewStuff

Sep 7 2018

leinir committed R304:c4b2e5353551: Remove an unneeded include (and fix a warning while we're at it) (authored by leinir).
Remove an unneeded include (and fix a warning while we're at it)
Sep 7 2018, 8:40 AM
leinir committed R304:66fc21df8c1f: Make test tools link on Windows (authored by leinir).
Make test tools link on Windows
Sep 7 2018, 8:35 AM
leinir committed R304:c3053442d104: Unbreak build with Qt 5.9 (authored by leinir).
Unbreak build with Qt 5.9
Sep 7 2018, 8:20 AM
leinir committed R304:b98acc38484e: Missing file, unbreak compilation (authored by leinir).
Missing file, unbreak compilation
Sep 7 2018, 8:00 AM
leinir added inline comments to D6513: Add support for Attica tags support.
Sep 7 2018, 7:52 AM · Frameworks, KNewStuff
leinir committed R304:2ad3e66d81b6: Add support for Attica tags support (authored by leinir).
Add support for Attica tags support
Sep 7 2018, 7:51 AM
leinir closed D6513: Add support for Attica tags support.
Sep 7 2018, 7:51 AM · Frameworks, KNewStuff
leinir requested changes to D15319: Add file descriptions to (almost) all the qml files..

(sorry, forgot to mark as request changes)

Sep 7 2018, 7:41 AM · Peruse
leinir added a comment to D15319: Add file descriptions to (almost) all the qml files..

Good initiative, and a great way to get to both get to grips with things and wrap your head around it at the same time! I must adopt this method ;)

Sep 7 2018, 7:40 AM · Peruse
leinir updated the diff for D6513: Add support for Attica tags support.

Address @dfaure's comments

Sep 7 2018, 7:10 AM · Frameworks, KNewStuff
leinir added inline comments to D6513: Add support for Attica tags support.
Sep 7 2018, 7:08 AM · Frameworks, KNewStuff

Sep 6 2018

leinir accepted D15313: Update the ACBF library..

Great stuff, fire away! :)

Sep 6 2018, 1:39 PM · Peruse
leinir requested changes to D15313: Update the ACBF library..

Looking really good! Mostly some nitpicking going on, and primarily documentation inconsistencies, to be fair, but still, good to get them fixed :)

Sep 6 2018, 12:43 PM · Peruse
leinir added a comment to T9628: Updating the ACBF library with missing items and to read/write ACBF 1.1.

Huh, yes, that is indeed interesting... At any rate, yay! :)

Sep 6 2018, 11:44 AM · Peruse
leinir added a comment to T9628: Updating the ACBF library with missing items and to read/write ACBF 1.1.

It's looking good so far :) That smells very much of c++1x magic breaking... If you haven't worked it out, push what you've got and i'll second-pair-of-eyes you?

Sep 6 2018, 10:36 AM · Peruse

Sep 5 2018

leinir updated the diff for D6513: Add support for Attica tags support.

More codestyle fixes. I also notice some which were there before this work, but fixing that seems distinctly out of scope for this patch...

Sep 5 2018, 9:57 AM · Frameworks, KNewStuff
leinir added a comment to D6513: Add support for Attica tags support.

i guess uncrustify isn't a magic bullet either, eh? ;) Thanks for the findings!

Sep 5 2018, 9:51 AM · Frameworks, KNewStuff
leinir accepted D15273: Fix loading ACBF image urls when they use backslashes..

Hmmmmm... well, backslashes in URLs isn't proper XML, so it would /seem/ to make sense, even for roundtripping, that we just refuse to output improper data into ACBF... though, at the same time, making the imageprovider more robust is perhaps not a silly idea either... It does all seem a little strange, though, like you say. If you could add a comment here describing why we're doing that string replacement (something like "While URLs should always use forward slashes, books exists in the wild which do not, and we have to be able to consume those files as well" would be handy for future reference, but whatever you feel is good, i'll accept it as is :) )

Sep 5 2018, 8:03 AM · Peruse

Sep 4 2018

leinir accepted D15264: Add documentation to the QtQuick and ContentList plugins..

Great stuff, thank you! :)

Sep 4 2018, 1:31 PM · Peruse
leinir updated the diff for D6513: Add support for Attica tags support.

Uncrustify-kf5 things as requested, hope this is better!

Sep 4 2018, 12:47 PM · Frameworks, KNewStuff
leinir requested changes to D15264: Add documentation to the QtQuick and ContentList plugins..

That's a whole lot of documentation for some, granted, not always particularly pretty bits of logic! Some bits are misinterpreted or misunderstood, so if you wouldn't mind terribly fixing those, i'd appreciate it :)

Sep 4 2018, 12:35 PM · Peruse
leinir accepted D15253: Fix "I18N_ARGUMENT_MISSING" in peruse creator.

Ah, i did wonder what happened with that (and was busy doing something else at the time). Good catch, thank you :)

Sep 4 2018, 7:06 AM · Peruse
leinir accepted D15250: Remove a warning..

That is indeed correct, well done on your first bit of QML! :D

Sep 4 2018, 7:04 AM · Peruse
leinir accepted D15246: Allow checking against the new ACBF namespaces as well..

LGTM! (and yes, that NB does sound rather like another patch - i'll have a look at that, likely make sense to ask Qt what image formats it supports and then use that, which also needs to happen elsewhere (specifically in the folderofimages type) :) )

Sep 4 2018, 7:03 AM · Peruse