leinir (Dan Leinir Turthra Jensen)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 8 2015, 8:34 AM (230 w, 3 d)
Availability
Available

Recent Activity

Wed, Dec 4

leinir added a comment to D25714: [WIP]: Port away from deprecated KHtml.

Just a quick tip, when posting things that are a work in progress as a diff (which, incidentally, is a great idea, both in general, and this!), adding "[WIP]" to the beginning of the diff's title is very handy, both for your own tracking, and for those going through the review lists :)

Wed, Dec 4, 1:57 PM · Calligra: 3.0

Tue, Dec 3

leinir committed R304:834e52ee4bd9: Add some friendly "report bugs here" links (authored by leinir).
Add some friendly "report bugs here" links
Tue, Dec 3, 11:46 AM
leinir closed D25562: Add some friendly "report bugs here" links.
Tue, Dec 3, 11:46 AM · Frameworks

Mon, Dec 2

leinir updated the diff for D25562: Add some friendly "report bugs here" links.
  • Merge branch 'master' into helpful-linking-for-bugs
  • Don't use .arg, just embed the URLs directly in the translatable text
Mon, Dec 2, 11:30 AM · Frameworks

Thu, Nov 28

leinir accepted D25585: Fix i18n syntax to avoid runtime errors.

...wow, ok, right, that's a fun bit of api difference right there ;) Thanks for those!

Thu, Nov 28, 10:33 AM · Frameworks

Wed, Nov 27

leinir updated the diff for D25441: Send along the config name with requests.

(just a little merge, for my own sanity... but also ping?)

Wed, Nov 27, 1:28 PM · Frameworks
leinir added reviewers for D25562: Add some friendly "report bugs here" links: Frameworks, KNewStuff, ngraham.
Wed, Nov 27, 10:57 AM · Frameworks
leinir requested review of D25562: Add some friendly "report bugs here" links.
Wed, Nov 27, 10:56 AM · Frameworks

Tue, Nov 26

leinir committed R304:9d1ae1544808: Turn KNewStuffQuick::CommentsModel into a SortFilterProxy for reviews (authored by leinir).
Turn KNewStuffQuick::CommentsModel into a SortFilterProxy for reviews
Tue, Nov 26, 1:02 PM
leinir closed D25272: Turn KNewStuffQuick::CommentsModel into a SortFilterProxy for reviews.
Tue, Nov 26, 1:02 PM · Frameworks
leinir added inline comments to D25440: Set a proper agent string for Attica requests.
Tue, Nov 26, 1:00 PM · Frameworks
leinir updated the diff for D25440: Set a proper agent string for Attica requests.
Tue, Nov 26, 12:59 PM · Frameworks
leinir added a comment to D25440: Set a proper agent string for Attica requests.

Ping? If this (and the partner over at D25441) could get under way sooner rather than later, it would help a bunch with some bottleneck analysis...

Tue, Nov 26, 12:37 PM · Frameworks
leinir added a comment to D25272: Turn KNewStuffQuick::CommentsModel into a SortFilterProxy for reviews.

Ping?

Tue, Nov 26, 12:36 PM · Frameworks

Mon, Nov 25

leinir added a comment to D25506: Remove Attica from KAboutDialog.

Given the amount of work being put into the KDE Store recently, i am dismayed that it is considered undesirable that we should use the information the store provides us. I understand the surprise phone-home-ness it suggests, but i also am not at all happy with this. It is, however, not my decision, and while i know that we talked about this last autumn and you agreed to hold off on doing this patch, i guess others have weighed in during a sprint i didn't attend (which is my own fault). It seems to me, however, that the fix to this code not being used is to add the usernames of people to about dialogues, rather than removing the functionality.

Mon, Nov 25, 11:22 AM · Frameworks

Fri, Nov 22

leinir committed R252:06bd561dceb1: Set application name and version on the knshandler tool (authored by leinir).
Set application name and version on the knshandler tool
Fri, Nov 22, 11:11 AM
leinir closed D25442: Set application name and version on the knshandler tool.
Fri, Nov 22, 11:11 AM · Frameworks
leinir added a comment to D25442: Set application name and version on the knshandler tool.
In D25442#566050, @apol wrote:

Is the store having a big impact from this handler?

Fri, Nov 22, 11:11 AM · Frameworks

Thu, Nov 21

leinir added reviewers for D25442: Set application name and version on the knshandler tool: Frameworks, Plasma, starbuck.
Thu, Nov 21, 4:19 PM · Frameworks
leinir requested review of D25442: Set application name and version on the knshandler tool.
Thu, Nov 21, 4:19 PM · Frameworks
leinir added reviewers for D25441: Send along the config name with requests: KNewStuff, Frameworks, Plasma, starbuck, ronaldv.
Thu, Nov 21, 3:46 PM · Frameworks
leinir added a reviewer for D25440: Set a proper agent string for Attica requests: ronaldv.
Thu, Nov 21, 3:46 PM · Frameworks
leinir added reviewers for D25440: Set a proper agent string for Attica requests: Frameworks, KNewStuff, Plasma, starbuck.
Thu, Nov 21, 3:45 PM · Frameworks
leinir added a dependent revision for D25440: Set a proper agent string for Attica requests: D25441: Send along the config name with requests.
Thu, Nov 21, 3:44 PM · Frameworks
leinir added a dependency for D25441: Send along the config name with requests: D25440: Set a proper agent string for Attica requests.
Thu, Nov 21, 3:44 PM · Frameworks
leinir requested review of D25441: Send along the config name with requests.
Thu, Nov 21, 3:44 PM · Frameworks
leinir requested review of D25440: Set a proper agent string for Attica requests.
Thu, Nov 21, 3:36 PM · Frameworks

Wed, Nov 13

leinir committed R134:11bfabfcbee9: Ensure comments fetch for KNS starts on the right page (authored by leinir).
Ensure comments fetch for KNS starts on the right page
Wed, Nov 13, 4:36 PM
leinir closed D25282: Ensure comments fetch for KNS starts on the right page.
Wed, Nov 13, 4:36 PM · Plasma
leinir added reviewers for D25282: Ensure comments fetch for KNS starts on the right page: Discover Software Store, Plasma, ngraham, apol, starbuck.
Wed, Nov 13, 10:26 AM · Plasma
leinir requested review of D25282: Ensure comments fetch for KNS starts on the right page.
Wed, Nov 13, 10:25 AM · Plasma

Tue, Nov 12

leinir updated the test plan for D25272: Turn KNewStuffQuick::CommentsModel into a SortFilterProxy for reviews.
Tue, Nov 12, 1:35 PM · Frameworks
leinir added reviewers for D25272: Turn KNewStuffQuick::CommentsModel into a SortFilterProxy for reviews: Plasma, KNewStuff, Frameworks.
Tue, Nov 12, 1:34 PM · Frameworks
leinir requested review of D25272: Turn KNewStuffQuick::CommentsModel into a SortFilterProxy for reviews.
Tue, Nov 12, 1:32 PM · Frameworks
leinir committed R304:99144e8b823b: These functions are @since 5.65, not 5.64 (authored by leinir).
These functions are @since 5.65, not 5.64
Tue, Nov 12, 10:51 AM

Fri, Nov 8

leinir accepted D25215: Fix a couple of broken links, update links to https://kde.org/applications/.

Good catch :)

Fri, Nov 8, 2:40 PM · Frameworks
leinir committed R304:080f5276ae2f: Show a "Loading more..." busy indicator when loading view data (authored by leinir).
Show a "Loading more..." busy indicator when loading view data
Fri, Nov 8, 2:35 PM
leinir closed D25197: Show a "Loading more..." busy indicator when loading view data.
Fri, Nov 8, 2:35 PM · Frameworks
leinir closed D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading.
Fri, Nov 8, 2:32 PM · Frameworks
leinir committed R304:f1f439cbef94: Give some more pretty feedback in NewStuff::Page while the Engine is loading (authored by leinir).
Give some more pretty feedback in NewStuff::Page while the Engine is loading
Fri, Nov 8, 2:32 PM
leinir updated the diff for D25197: Show a "Loading more..." busy indicator when loading view data.
  • Ensure that the indicator is the full height of the view when it's empty
Fri, Nov 8, 10:47 AM · Frameworks
leinir added a comment to D25197: Show a "Loading more..." busy indicator when loading view data.

Cool, I'm okay with that.

The "Loading more" indicator is aligned to the top, not centered like the other loading indicator is.

Fri, Nov 8, 10:17 AM · Frameworks

Nov 7 2019

leinir updated the diff for D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading.
  • Merge branch 'master' into be-more-friendly-during-initial-load
  • Add a bit of @since
Nov 7 2019, 3:38 PM · Frameworks
leinir updated the diff for D25197: Show a "Loading more..." busy indicator when loading view data.
  • Add some @since
Nov 7 2019, 3:36 PM · Frameworks
leinir added a dependent revision for D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading: D25197: Show a "Loading more..." busy indicator when loading view data.
Nov 7 2019, 3:32 PM · Frameworks
leinir added a dependency for D25197: Show a "Loading more..." busy indicator when loading view data: D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading.
Nov 7 2019, 3:32 PM · Frameworks
leinir added reviewers for D25197: Show a "Loading more..." busy indicator when loading view data: KNewStuff, Frameworks, Plasma, ngraham.
Nov 7 2019, 3:32 PM · Frameworks
leinir requested review of D25197: Show a "Loading more..." busy indicator when loading view data.
Nov 7 2019, 3:31 PM · Frameworks
leinir added a comment to D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading.

I still see "Loading Data" in a passiveNotification as well as in text under the loading indicator.

Nov 7 2019, 2:27 PM · Frameworks
leinir added inline comments to D25189: Add an overlay component for item activity feedback.
Nov 7 2019, 2:09 PM · Frameworks
leinir committed R304:24ffb9cb9c11: Add an overlay component for item activity feedback (authored by leinir).
Add an overlay component for item activity feedback
Nov 7 2019, 2:05 PM
leinir closed D25189: Add an overlay component for item activity feedback.
Nov 7 2019, 2:05 PM · Frameworks
leinir added reviewers for D25189: Add an overlay component for item activity feedback: KNewStuff, Frameworks, Plasma, ngraham.
Nov 7 2019, 12:08 PM · Frameworks
leinir requested review of D25189: Add an overlay component for item activity feedback.
Nov 7 2019, 12:07 PM · Frameworks
leinir updated the diff for D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading.
  • Merge branch 'master' into be-more-friendly-during-initial-load
  • Don't show the passive notification for already shown messages
Nov 7 2019, 11:08 AM · Frameworks
leinir added inline comments to D25176: Add a displayHint property to Action.
Nov 7 2019, 11:00 AM · Kirigami
leinir added inline comments to D25176: Add a displayHint property to Action.
Nov 7 2019, 9:40 AM · Kirigami
leinir committed R304:7de5ad66fd89: Only show DownloadItemsSheet if there's more than one download item (authored by leinir).
Only show DownloadItemsSheet if there's more than one download item
Nov 7 2019, 9:24 AM
leinir closed D25165: Only show DownloadItemsSheet if there's more than one download item.
Nov 7 2019, 9:24 AM · Frameworks
leinir committed R304:728f01f064ab: Use the pointing hand cursor for the single-clickable delegates (authored by leinir).
Use the pointing hand cursor for the single-clickable delegates
Nov 7 2019, 9:23 AM
leinir closed D25168: Use the pointing hand cursor for the single-clickable delegates.
Nov 7 2019, 9:23 AM · Frameworks

Nov 6 2019

leinir added reviewers for D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading: KNewStuff, Frameworks, ngraham, VDG.
Nov 6 2019, 2:01 PM · Frameworks
leinir requested review of D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading.
Nov 6 2019, 1:58 PM · Frameworks
leinir added a comment to T11142: OCS comment rating machine readability.

Confirmed, thank you :) Need to do a bit of jiggery-pokery to the various consumers of the data, but it's already much more consistent now - always had a kind of "...what in the world?" feel when the numbers didn't match, and having this works well i think :) Thanks! Think we can call this one all done (if it turns out to need further work, we'd probably want to open a different ticket to track what and why for that, rather than this one)

Nov 6 2019, 11:46 AM · KDE Store
leinir added reviewers for D25165: Only show DownloadItemsSheet if there's more than one download item: KNewStuff, Frameworks, ngraham.
Nov 6 2019, 11:12 AM · Frameworks
leinir added reviewers for D25168: Use the pointing hand cursor for the single-clickable delegates: KNewStuff, Frameworks, ngraham.
Nov 6 2019, 11:11 AM · Frameworks
leinir requested review of D25168: Use the pointing hand cursor for the single-clickable delegates.
Nov 6 2019, 11:09 AM · Frameworks
leinir added a comment to T11142: OCS comment rating machine readability.

Great, i can work with that! :)

Nov 6 2019, 10:42 AM · KDE Store
leinir requested review of D25165: Only show DownloadItemsSheet if there's more than one download item.
Nov 6 2019, 10:25 AM · Frameworks
leinir added a comment to T11142: OCS comment rating machine readability.

Hmm... In that case, if it's more like a filter, it might actually make sense to send all the comments out - how much trouble would it be to make it do so? (if it's a huge amount of work, then it's probably not really worth it, but i think it might well be good; it'd allow us to perhaps add some more interesting filtering and sorting options on the client side)

Nov 6 2019, 10:11 AM · KDE Store
leinir added a comment to T11142: OCS comment rating machine readability.

I think we have a discrepancy between the comments being sent out via this call, and the number of comments reported in the content call. As an example, see below:

Nov 6 2019, 9:52 AM · KDE Store

Nov 5 2019

leinir closed D25067: Fix the header layouts for EntryDetails and Page components.
Nov 5 2019, 8:43 PM · Frameworks
leinir committed R304:4d56727cc7d7: Fix the header layouts for EntryDetails and Page components (authored by leinir).
Fix the header layouts for EntryDetails and Page components
Nov 5 2019, 8:43 PM
leinir updated the diff for D25067: Fix the header layouts for EntryDetails and Page components.
  • Remove the custom title delegate on EntryDetails
Nov 5 2019, 12:40 PM · Frameworks
leinir added inline comments to D25067: Fix the header layouts for EntryDetails and Page components.
Nov 5 2019, 12:31 PM · Frameworks
leinir added a comment to D25067: Fix the header layouts for EntryDetails and Page components.

With that Kirigami patch, this *almost* works. There's still an empty area on the right:

Nov 5 2019, 10:42 AM · Frameworks

Nov 4 2019

leinir accepted D25141: Use a RowLayout for laying out ToolBarPageHeader.

These changes make the KNSQuick components all happy :)

Nov 4 2019, 4:30 PM · Kirigami
leinir added a comment to D25067: Fix the header layouts for EntryDetails and Page components.

With that Kirigami patch, this *almost* works. There's still an empty area on the right:

Nov 4 2019, 4:23 PM · Frameworks
leinir updated the diff for D25067: Fix the header layouts for EntryDetails and Page components.

Thanks to @ahiemstra for helping out with the Kirigami side :)

Nov 4 2019, 4:09 PM · Frameworks
leinir added a dependency for D25067: Fix the header layouts for EntryDetails and Page components: D25141: Use a RowLayout for laying out ToolBarPageHeader.
Nov 4 2019, 4:08 PM · Frameworks
leinir added a dependent revision for D25141: Use a RowLayout for laying out ToolBarPageHeader: D25067: Fix the header layouts for EntryDetails and Page components.
Nov 4 2019, 4:08 PM · Kirigami
leinir added a comment to D25067: Fix the header layouts for EntryDetails and Page components.

Now that's fixed on the main page but it's missing margins on the right side:

Nov 4 2019, 11:15 AM · Frameworks

Oct 30 2019

leinir added inline comments to D25067: Fix the header layouts for EntryDetails and Page components.
Oct 30 2019, 4:32 PM · Frameworks
leinir updated the diff for D25067: Fix the header layouts for EntryDetails and Page components.

Based on @ahiemstra's comments on the sizing logic, this seems to work...

Oct 30 2019, 4:30 PM · Frameworks
leinir added reviewers for D25067: Fix the header layouts for EntryDetails and Page components: Frameworks, Plasma.
Oct 30 2019, 1:54 PM · Frameworks
leinir added reviewers for D25067: Fix the header layouts for EntryDetails and Page components: ngraham, KNewStuff.
Oct 30 2019, 10:30 AM · Frameworks
leinir requested review of D25067: Fix the header layouts for EntryDetails and Page components.
Oct 30 2019, 10:29 AM · Frameworks
leinir committed R119:c21a8bd82ec2: Require and use the new NewStuffQuick Button component (authored by leinir).
Require and use the new NewStuffQuick Button component
Oct 30 2019, 9:55 AM
leinir closed D24942: Require and use the new NewStuffQuick Button component.
Oct 30 2019, 9:55 AM · Plasma
leinir committed R304:344e9b7c07ad: Ensure that the changedEntries property is correctly propagated (authored by leinir).
Ensure that the changedEntries property is correctly propagated
Oct 30 2019, 9:28 AM
leinir closed D25041: Ensure that the changedEntries property is correctly propagated.
Oct 30 2019, 9:28 AM · Frameworks
leinir added a comment to D24942: Require and use the new NewStuffQuick Button component.

Thanks, that fixes the issue. This works quite well now.

Would be nice to address the bugs I filed before 5.18 is released so it really gets polished up all nice and shiny. :)

Oct 30 2019, 8:45 AM · Plasma

Oct 29 2019

leinir added reviewers for D25041: Ensure that the changedEntries property is correctly propagated: Frameworks, KNewStuff, apol, ngraham.
Oct 29 2019, 10:04 AM · Frameworks
leinir updated the diff for D24942: Require and use the new NewStuffQuick Button component.

Together with the change in D25041 this makes the model reloading work
(without that patch, it simply fails quietly as the signal forwarding
fails). If wanted, we could also use the count property in the same
diff to reintroduce the previous logic (which of course would then
require that patch having been merged first)

Oct 29 2019, 10:03 AM · Plasma
leinir requested review of D25041: Ensure that the changedEntries property is correctly propagated.
Oct 29 2019, 9:59 AM · Frameworks

Oct 25 2019

leinir added reviewers for D24942: Require and use the new NewStuffQuick Button component: Plasma, KNewStuff, VDG, broulik.
Oct 25 2019, 12:47 PM · Plasma
leinir requested review of D24942: Require and use the new NewStuffQuick Button component.
Oct 25 2019, 12:43 PM · Plasma

Oct 21 2019

leinir committed R304:8977627cab85: Fix KNSCore::Cache fetching when initialising Engine (authored by leinir).
Fix KNSCore::Cache fetching when initialising Engine
Oct 21 2019, 8:08 AM
leinir closed D24754: Fix KNSCore::Cache fetching when initialising Engine.
Oct 21 2019, 8:08 AM · Frameworks

Oct 19 2019

leinir updated the diff for D24754: Fix KNSCore::Cache fetching when initialising Engine.
  • Ensure that the config filename only has the base name
Oct 19 2019, 9:19 AM · Frameworks