leinir (Dan Leinir Turthra Jensen)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jul 8 2015, 8:34 AM (115 w, 3 d)
Availability
Available

Recent Activity

Thu, Sep 21

leinir committed R157:26fc03476045: Trust that shortcuts are disabled for disabled Actions (authored by leinir).
Trust that shortcuts are disabled for disabled Actions
Thu, Sep 21, 1:47 PM
leinir committed R169:69e074a874a2: Disable shortcuts when an action is disabled (authored by leinir).
Disable shortcuts when an action is disabled
Thu, Sep 21, 1:04 PM
leinir closed D7814: Disable shortcuts when an action is disabled.
Thu, Sep 21, 1:04 PM · Kirigami
leinir updated the diff for D7814: Disable shortcuts when an action is disabled.

Change the approach from performing all the magic inside Kirigami (which resulted in not entirely consistent behaviours, depending on which actions you used), pushing some of the requirements for disabling things onto the app developer.

Thu, Sep 21, 10:55 AM · Kirigami
leinir retitled D7814: Disable shortcuts when an action is disabled from Disable shortcuts for actions not on the current page to Disable shortcuts when an action is disabled.
Thu, Sep 21, 10:54 AM · Kirigami

Thu, Sep 14

leinir committed R157:d057db785817: Make sure we use the right knsrc file (authored by leinir).
Make sure we use the right knsrc file
Thu, Sep 14, 2:52 PM
leinir created D7814: Disable shortcuts when an action is disabled.
Thu, Sep 14, 12:22 PM · Kirigami

Mon, Sep 4

leinir committed R157:2dffa45e9b49: Add sequence/series data from acbf into model (just one for now) (authored by leinir).
Add sequence/series data from acbf into model (just one for now)
Mon, Sep 4, 2:07 PM
leinir committed R157:0af71a46b801: Use displayname when getting the author in archivebookmodel (authored by leinir).
Use displayname when getting the author in archivebookmodel
Mon, Sep 4, 2:07 PM
leinir committed R157:b4a117607369: More pleasant clear-db option help text (authored by leinir).
More pleasant clear-db option help text
Mon, Sep 4, 2:07 PM
leinir committed R157:c2b102279e20: Limit searches as they should be (authored by leinir).
Limit searches as they should be
Mon, Sep 4, 2:07 PM

Fri, Sep 1

leinir committed R157:04fcb56e275d: Ensure fiels are filled out in the author editor (authored by leinir).
Ensure fiels are filled out in the author editor
Fri, Sep 1, 3:17 PM
leinir committed R157:ee9ab5600d55: Actually wire up the add new author functionality (authored by leinir).
Actually wire up the add new author functionality
Fri, Sep 1, 3:17 PM
leinir committed R157:be3d51d27b06: Add an application header to Creator (authored by leinir).
Add an application header to Creator
Fri, Sep 1, 3:17 PM
leinir committed R157:5b3c3541047b: Initial filling out of the book list with ACBF info (authored by leinir).
Initial filling out of the book list with ACBF info
Fri, Sep 1, 3:17 PM
leinir committed R157:af23260c0d92: Add an initial author editor (authored by leinir).
Add an initial author editor
Fri, Sep 1, 3:17 PM
leinir committed R157:cc4c63521b96: Switch Creator's Book page to ScrollablePage (authored by leinir).
Switch Creator's Book page to ScrollablePage
Fri, Sep 1, 3:17 PM
leinir committed R157:58c1c12a3921: Expose some author things to QML (authored by leinir).
Expose some author things to QML
Fri, Sep 1, 3:17 PM
leinir committed R157:1bca664846cd: Expose a bunch of Author things to QML (and add displayName) (authored by leinir).
Expose a bunch of Author things to QML (and add displayName)
Fri, Sep 1, 3:17 PM
leinir committed R157:54e49c8b5df6: Add option to clear the database cache (authored by leinir).
Add option to clear the database cache
Fri, Sep 1, 3:17 PM
leinir committed R157:df2dcf35b83c: Make it possible to use ArchiveModel without a qml engine set (authored by leinir).
Make it possible to use ArchiveModel without a qml engine set
Fri, Sep 1, 3:17 PM

Aug 24 2017

leinir committed R157:76f472108c54: Fix license issue (authored by leinir).
Fix license issue
Aug 24 2017, 11:38 AM
leinir committed R169:2cdd0402bf9c: Get rid of warnings about setting both pixel and point sizes (authored by leinir).
Get rid of warnings about setting both pixel and point sizes
Aug 24 2017, 8:29 AM
leinir closed D7483: Get rid of warnings about setting both pixel and point sizes by committing R169:2cdd0402bf9c: Get rid of warnings about setting both pixel and point sizes.
Aug 24 2017, 8:29 AM · Kirigami

Aug 23 2017

leinir created D7483: Get rid of warnings about setting both pixel and point sizes.
Aug 23 2017, 11:34 AM · Kirigami
leinir accepted D7190: Don't complain the knsregistry file is not present before it's useful.

Good call, yes - gets rid of a lump of irrelevant and technically correct but subjectively incorrect information.

Aug 23 2017, 8:06 AM · Frameworks
leinir accepted D7194: Detach before setting the d pointer.

Ah, yes, good catch :)

Aug 23 2017, 8:03 AM · Frameworks

Aug 22 2017

leinir committed R157:f9224e911fe8: Fix keyboard navigation (authored by leinir).
Fix keyboard navigation
Aug 22 2017, 4:49 PM
leinir committed R157:f5436f12d2e7: Hide things sitting behind the search results pane (authored by leinir).
Hide things sitting behind the search results pane
Aug 22 2017, 4:49 PM
leinir committed R157:2aad2171fa80: Intersection points are fun sometimes. Fix crash. (authored by leinir).
Intersection points are fun sometimes. Fix crash.
Aug 22 2017, 4:49 PM
leinir committed R169:e0f56dac7959: Check item validity before using it (authored by leinir).
Check item validity before using it
Aug 22 2017, 4:42 PM
leinir closed D7467: Check item validity before using it by committing R169:e0f56dac7959: Check item validity before using it.
Aug 22 2017, 4:42 PM · Kirigami
leinir closed D7466: Honour layer position for isCurrentPage.

Closed by: https://commits.kde.org/kirigami/6dffeef3c09ef62f7ea2775bf9ec72585755e3d2

Aug 22 2017, 4:21 PM · Kirigami
leinir reclaimed D7467: Check item validity before using it.

Also, i am a silly person and closed the wrong revision.

Aug 22 2017, 4:21 PM · Kirigami
leinir abandoned D7467: Check item validity before using it.

Closed by: https://commits.kde.org/kirigami/6dffeef3c09ef62f7ea2775bf9ec72585755e3d2

Aug 22 2017, 4:20 PM · Kirigami
leinir committed R169:6dffeef3c09e: Honour layer position for isCurrentPage (authored by leinir).
Honour layer position for isCurrentPage
Aug 22 2017, 4:12 PM
leinir created D7467: Check item validity before using it.
Aug 22 2017, 4:10 PM · Kirigami
leinir created D7466: Honour layer position for isCurrentPage.
Aug 22 2017, 2:37 PM · Kirigami
leinir added a comment to T6840: Qt World Summit.

I think we should consider the entire presence as a whole - just get all communication goals in place so that we this year have one solid communication and our presence is aimed at one specific thing

Aug 22 2017, 8:20 AM · KDE Promo

Aug 21 2017

leinir accepted D7343: auto generate desktop file for url handling.

Hmm... LGTM - mind that i am not the maintainer here, but it does look like it's likely the needed approach.

Aug 21 2017, 1:40 PM · Plasma

Aug 16 2017

leinir committed R157:aed2256a1e5c: Up Kirigami requirement to 5.37 for PageRow layers (authored by leinir).
Up Kirigami requirement to 5.37 for PageRow layers
Aug 16 2017, 3:14 PM
leinir accepted D7306: concept of Layers.
Aug 16 2017, 10:46 AM · Kirigami
leinir added a comment to D7306: concept of Layers.

The StackView is complaining about some erroneous anchoring (and i don't see the visual effects it's complaining about, as far as i can tell), but apart from that, it looks to work really quite nicely :)

Aug 16 2017, 10:46 AM · Kirigami

Aug 8 2017

leinir committed R32:1dd87ec852c5: Add Provider URLs to the two knsrc files (authored by leinir).
Add Provider URLs to the two knsrc files
Aug 8 2017, 5:04 PM

Jul 23 2017

leinir committed R8:2b89f0e7508e: Clean the view mode sync object up a bit (authored by leinir).
Clean the view mode sync object up a bit
Jul 23 2017, 8:29 PM
leinir committed R8:214a1cea5df6: A bit of documentation (authored by leinir).
A bit of documentation
Jul 23 2017, 8:29 PM
leinir committed R8:ce5330777205: Initialise the document offset (authored by leinir).
Initialise the document offset
Jul 23 2017, 3:29 PM
leinir committed R8:0d7e1a3cc757: Handle being given a null documentOffset (and react appropriately) (authored by leinir).
Handle being given a null documentOffset (and react appropriately)
Jul 23 2017, 3:29 PM
leinir committed R8:2e4523ac18ad: Left over merge crud (authored by leinir).
Left over merge crud
Jul 23 2017, 2:43 PM
leinir committed R8:d256bc2cd5ab: Initialise some more members on the viewmodesyncobject (authored by leinir).
Initialise some more members on the viewmodesyncobject
Jul 23 2017, 2:43 PM
leinir committed R8:f652d13de296: Merge branch 'master' into calligra-gemini-leinir (authored by leinir).
Merge branch 'master' into calligra-gemini-leinir
Jul 23 2017, 2:43 PM
leinir committed R8:b31621174fd1: Add the GeminiMainWindow library (authored by leinir).
Add the GeminiMainWindow library
Jul 23 2017, 2:43 PM
leinir committed R8:a5a14f883e44: Fix Stage document page in Gemini (authored by leinir).
Fix Stage document page in Gemini
Jul 23 2017, 1:44 PM

Jul 22 2017

leinir committed R8:8ef9322f3823: QPointer for the text doc implementation (authored by leinir).
QPointer for the text doc implementation
Jul 22 2017, 7:02 PM
leinir committed R8:e72d5b0b1dc1: Add some QPointer to the statistics widget (authored by leinir).
Add some QPointer to the statistics widget
Jul 22 2017, 7:02 PM

Jul 21 2017

leinir committed R157:cc1b7204ac15: Require Qt5::Sql and Kirigami 2.1 (authored by leinir).
Require Qt5::Sql and Kirigami 2.1
Jul 21 2017, 5:16 PM
leinir committed R157:5cc08593bb39: Port Peruse to Kirigami 2.1 (authored by leinir).
Port Peruse to Kirigami 2.1
Jul 21 2017, 5:16 PM
leinir committed R157:d214fd606068: Make the category get function return count as well (authored by leinir).
Make the category get function return count as well
Jul 21 2017, 5:16 PM
leinir committed R157:a224574ea44d: Don't give the rowcount for categories, just the book count (authored by leinir).
Don't give the rowcount for categories, just the book count
Jul 21 2017, 4:56 PM
leinir committed R157:13a9b616e4ad: Add the database code itself (authored by leinir).
Add the database code itself
Jul 21 2017, 4:56 PM
leinir committed R157:6825117b44d1: Make the cache loading gentler, instant UI (authored by leinir).
Make the cache loading gentler, instant UI
Jul 21 2017, 4:56 PM
leinir committed R157:ba158c885c17: Add an sqlite database cache to Peruse (authored by leinir).
Add an sqlite database cache to Peruse
Jul 21 2017, 4:56 PM

Jul 7 2017

leinir accepted D6532: When requesting from the cache, report all entries at bulk.

Hmm... i was thinking this could cause issues, i don't see anywhere assumptions are made about page size on the consumption side (damn we're lucky this whole split thing's so new ;) ). Nothing in the API suggests you might get more than the requested number when you ask for entries, but conversely nothing says you will potentially get less, and that happens on a regular basis, so... sure, why not :)

Jul 7 2017, 8:06 AM · Frameworks

Jul 5 2017

leinir added a comment to D6512: Add support for proposed tags addition in OCS 1.7.
In D6512#121834, @apol wrote:

+1 looks sensible to me.

Jul 5 2017, 12:33 PM · KDE Store, Frameworks
leinir created D6513: Add support for Attica tags support.
Jul 5 2017, 12:31 PM · Frameworks, KNewStuff
leinir added a dependent revision for D6512: Add support for proposed tags addition in OCS 1.7: D6513: Add support for Attica tags support.
Jul 5 2017, 12:31 PM · KDE Store, Frameworks
leinir created D6512: Add support for proposed tags addition in OCS 1.7.
Jul 5 2017, 12:26 PM · KDE Store, Frameworks

Jul 4 2017

leinir accepted D6492: Also use m_currentRequest when checking for installed and updates.

Different approach, but yeah, telling people what'll actually happen works :)

Jul 4 2017, 1:59 PM · Frameworks
leinir requested changes to D6492: Also use m_currentRequest when checking for installed and updates.

derp, not accepted, my bad...

Jul 4 2017, 8:30 AM · Frameworks
leinir accepted D6492: Also use m_currentRequest when checking for installed and updates.

That is indeed a very good point. I think we might possibly have an issue here, though, in that since these two searches are no longer stand-alone, if the filter is not explicitly reset before attempting to perform a search we will only search installed and updateable items. I don't think it is necessarily an enormous or insurmountable issue here, as far as i can tell the only code which currently uses these two functions is in KNS' own DownloadManagers (at least, lxr suggests as much), and if we ensure those two are fixed to reset the filter before launching a search, i think we're probably ok.

Jul 4 2017, 8:29 AM · Frameworks

Jun 27 2017

leinir committed R304:4b37ece102dd: Expand KNewStuff documentation (authored by leinir).
Expand KNewStuff documentation
Jun 27 2017, 4:00 PM
leinir closed D5902: Expand KNewStuff documentation by committing R304:4b37ece102dd: Expand KNewStuff documentation.
Jun 27 2017, 4:00 PM · Frameworks
leinir added inline comments to D5902: Expand KNewStuff documentation.
Jun 27 2017, 1:43 PM · Frameworks
leinir updated the diff for D5902: Expand KNewStuff documentation.

Add/fix a whole bunch of more documentation, identified as missing (or incorrect) by Aniketh

Jun 27 2017, 10:59 AM · Frameworks

Jun 23 2017

leinir committed R304:eb2e65a882f0: Fix incorrect error detection for missing knsrc files (authored by leinir).
Fix incorrect error detection for missing knsrc files
Jun 23 2017, 10:50 AM
leinir closed D6340: Fix incorrect error detection for missing knsrc files by committing R304:eb2e65a882f0: Fix incorrect error detection for missing knsrc files.
Jun 23 2017, 10:50 AM · Frameworks, KNewStuff
leinir added inline comments to D6340: Fix incorrect error detection for missing knsrc files.
Jun 23 2017, 10:48 AM · Frameworks, KNewStuff

Jun 22 2017

leinir created D6340: Fix incorrect error detection for missing knsrc files.
Jun 22 2017, 12:48 PM · Frameworks, KNewStuff
leinir accepted D6324: Make sure we won't modify the aspect ratio of the icons.

Looks good for the initial case of getting rid of the obviously broken looking aspect ratio at the very least, though i think exposing the property might still be good... But, at the very least, it matches the HIG so that's cool :) (i don't personally like the whole scale-and-crop thing, but i'm also not the designer and i know entirely sensible reasons exist for this choice)

Jun 22 2017, 10:33 AM · Kirigami
leinir committed R134:3bb34859dcb6: Simplify KNSBackend fetch logic (authored by leinir).
Simplify KNSBackend fetch logic
Jun 22 2017, 10:29 AM

Jun 15 2017

leinir added a comment to D6191: Simplify KNSBackend fetch logic.
In D6191#116635, @apol wrote:
In D6191#116480, @apol wrote:

This will go to Plasma/5.10, right?

As in, merge this patch into Plasma/5.10 as well as master? I don't see why it would fail to merge, yeah, i'll do that :)

It went to master, right? Also for some reason it didn't close the bug...

Jun 15 2017, 6:30 PM · Plasma, Discover Software Store
leinir abandoned D5767: Postpone searches for half a human moment.

Incidentally, because KNS itself will already postpone non-cached searches by one second, the new proposed solution above (to only to this for KNS sources) is already implemented by way of using D6191

Jun 15 2017, 9:50 AM · Plasma
leinir committed R134:efaa09a20543: Simplify KNSBackend fetch logic (authored by leinir).
Simplify KNSBackend fetch logic
Jun 15 2017, 9:47 AM
leinir closed D6191: Simplify KNSBackend fetch logic by committing R134:efaa09a20543: Simplify KNSBackend fetch logic.
Jun 15 2017, 9:47 AM · Plasma, Discover Software Store
leinir added a comment to D6191: Simplify KNSBackend fetch logic.
In D6191#116480, @apol wrote:

This will go to Plasma/5.10, right?

Jun 15 2017, 8:52 AM · Plasma, Discover Software Store

Jun 14 2017

leinir added a comment to D6191: Simplify KNSBackend fetch logic.

Related bug: https://bugs.kde.org/show_bug.cgi?id=380138

Jun 14 2017, 5:34 PM · Plasma, Discover Software Store
leinir committed R169:f3f2622e79b9: Don't crash when deleted during network operations (authored by leinir).
Don't crash when deleted during network operations
Jun 14 2017, 11:02 AM
leinir closed D6212: Don't crash when deleted during network operations by committing R169:f3f2622e79b9: Don't crash when deleted during network operations.
Jun 14 2017, 11:02 AM · Kirigami
leinir updated the diff for D6191: Simplify KNSBackend fetch logic.

Upon reviewing prior to merging, i realised that a file was missing from the most recent diff (StandardBackendUpdater did, as suggested, not listen to the resourceRemoved signal, and now does).

Jun 14 2017, 10:51 AM · Plasma, Discover Software Store
leinir committed R304:2f8580b9e604: Expose and use Engine's page size variable (authored by leinir).
Expose and use Engine's page size variable
Jun 14 2017, 10:46 AM
leinir closed D6190: Expose and use Engine's page size variable by committing R304:2f8580b9e604: Expose and use Engine's page size variable.
Jun 14 2017, 10:46 AM · Frameworks, KNewStuff

Jun 13 2017

leinir updated the diff for D6212: Don't crash when deleted during network operations.

Fix glaringly obvious over-complication spotted by David :)

Jun 13 2017, 1:20 PM · Kirigami
leinir created D6212: Don't crash when deleted during network operations.
Jun 13 2017, 12:52 PM · Kirigami
leinir updated the diff for D6191: Simplify KNSBackend fetch logic.

Adapted code as suggested. Note that this now depends on D6190 getting merged (as that contains the code that's iffed out).

Jun 13 2017, 12:10 PM · Plasma, Discover Software Store
leinir added inline comments to D6191: Simplify KNSBackend fetch logic.
Jun 13 2017, 12:09 PM · Plasma, Discover Software Store

Jun 12 2017

leinir updated the diff for D6190: Expose and use Engine's page size variable.

Don't const & an int, that's just silly.

Jun 12 2017, 1:25 PM · Frameworks, KNewStuff
leinir added a comment to D6190: Expose and use Engine's page size variable.

As far as i can gather, it was simply never added because, well, it was never used in a lot of places... This really is more a case of equalising some features between requestData and other parts of the engine (so they can all be paginated by the size they really want to be).

Jun 12 2017, 1:24 PM · Frameworks, KNewStuff
leinir created D6191: Simplify KNSBackend fetch logic.
Jun 12 2017, 12:46 PM · Plasma, Discover Software Store
leinir created D6190: Expose and use Engine's page size variable.
Jun 12 2017, 12:40 PM · Frameworks, KNewStuff

Jun 8 2017

leinir created T6288: Support for granular install of DownloadItems.
Jun 8 2017, 12:04 PM · KNewStuff