leinir (Dan Leinir Turthra Jensen)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 8 2015, 8:34 AM (137 w, 3 d)
Availability
Available

Recent Activity

Mon, Feb 19

leinir committed R157:4125d3149c45: Fix appdata files (authored by leinir).
Fix appdata files
Mon, Feb 19, 1:38 PM
leinir committed R157:5544b050b2db: Install the pre-rendered icons (authored by leinir).
Install the pre-rendered icons
Mon, Feb 19, 1:38 PM

Thu, Feb 15

leinir committed R8:45866bf30bcf: Guard the canvas a bit, it can potentially be null (authored by leinir).
Guard the canvas a bit, it can potentially be null
Thu, Feb 15, 5:27 PM

Jan 22 2018

leinir committed R246:9038a8effc41: Find Aspell dictionaries on Windows (authored by leinir).
Find Aspell dictionaries on Windows
Jan 22 2018, 8:38 PM
leinir closed D10017: Find Aspell dictionaries on Windows.
Jan 22 2018, 8:38 PM · Frameworks
leinir committed R877:ae3d738e342a: Install Aspell data in a more Crafty location (authored by leinir).
Install Aspell data in a more Crafty location
Jan 22 2018, 1:21 PM
leinir closed D10018: Install Aspell data in a more Crafty location.
Jan 22 2018, 1:21 PM · Craft

Jan 18 2018

leinir accepted D9907: Update the ContentList QML plugin to make it more general.

Right! It looks like this does the trick! Push away :D

Jan 18 2018, 10:21 AM
leinir accepted D9954: Ensure the database path exists before trying to create a file there.

Ah. Well spotted - and silly QStandardPaths ;)

Jan 18 2018, 9:14 AM

Jan 16 2018

leinir requested changes to D9907: Update the ContentList QML plugin to make it more general.

Nice work on the new API, very much better than the sort of slap-dash version in the original. Unfortunately, as the inline comments suggest, needs a bit of work ;)

Jan 16 2018, 11:28 AM

Jan 12 2018

leinir committed R169:811d023b5198: Ensure DesktopIcon paints with the correct aspect ratio (authored by leinir).
Ensure DesktopIcon paints with the correct aspect ratio
Jan 12 2018, 3:18 PM
leinir closed D9816: Ensure DesktopIcon paints with the correct aspect ratio.
Jan 12 2018, 3:18 PM · Kirigami

Jan 11 2018

leinir added a comment to R8:0dfb05ddf9f3: Plan: Use namespaces from report template in generated reports.

Looks like this breaks compilation on Windows... Please use the same method for iterating over the xml attributes as used in the rest of the codebase. See commit 0daa695cfde5d518d9422f3519c8900f536fdf6c for an example of somewhere else that had to be done.

Jan 11 2018, 3:21 PM
leinir added a comment to D9816: Ensure DesktopIcon paints with the correct aspect ratio.

Shows the updated output:

Jan 11 2018, 12:26 PM · Kirigami

Jan 9 2018

leinir committed R8:cd9748a49028: Don't always re-open when filename changes (authored by leinir).
Don't always re-open when filename changes
Jan 9 2018, 2:25 PM
leinir committed R8:8ae1090d609b: Fix the presentation implementation's template functionality (authored by leinir).
Fix the presentation implementation's template functionality
Jan 9 2018, 2:25 PM
leinir committed R8:3976cfbee9fb: Update the window title to something a bit better (authored by leinir).
Update the window title to something a bit better
Jan 9 2018, 2:25 PM
leinir committed R8:2115c35f0e2b: Ensure isTemporaryFile returns something useful (authored by leinir).
Ensure isTemporaryFile returns something useful
Jan 9 2018, 2:25 PM

Dec 21 2017

leinir committed R8:be26b8ff8596: Support templates and new file functionality in Components (authored by leinir).
Support templates and new file functionality in Components
Dec 21 2017, 7:44 PM
leinir committed R8:61801f8fc9e9: A better/longer description of Gemini for AppStream (authored by leinir).
A better/longer description of Gemini for AppStream
Dec 21 2017, 7:44 PM
leinir committed R8:5ca31ad3d698: Simplify the tempate logic a touch (authored by leinir).
Simplify the tempate logic a touch
Dec 21 2017, 7:44 PM
leinir requested changes to D8813: Gemini fails to open templates.

This fixes the wrong problem, i'm afraid - if you do this, then the file is not opened as a template, but rather just as a file (which results in unexpected behaviour, when you are not attempting to edit the template itself). It also doesn't fix a related issue for new file creation. Basically, this is caused by switching to the QtQuick 2 components (the old components had an implementation for this functionality, which i am currently porting over). Thank you for spotting it, though :)

Dec 21 2017, 11:26 AM · Calligra: 3.0

Dec 20 2017

leinir accepted D9421: Remove anchient and broken workaround.

Ha, yes, i concur with Aleix there, workaround-be-gone! ;) (i have a suspicion the reason i thought this worked before is because i was testing on my local machine... which also explains nicely why the packages from BF don't have functioning spell checking for me ;) )

Dec 20 2017, 12:19 PM · Frameworks
leinir committed R246:bdc6562faf73: Don't cause circular linking on Windows (authored by leinir).
Don't cause circular linking on Windows
Dec 20 2017, 10:08 AM
leinir closed D9018: Don't cause circular linking on Windows.
Dec 20 2017, 10:08 AM · Frameworks

Dec 19 2017

leinir added a comment to D9018: Don't cause circular linking on Windows.

Would it be possible to get an accept here, or is there something people fundamentally disagree with about it?

Dec 19 2017, 4:54 PM · Frameworks
leinir committed R8:6c4806a73e15: Link solver against blas as well (authored by leinir).
Link solver against blas as well
Dec 19 2017, 12:14 PM
leinir committed R8:bcab5a19f958: Disable Plan on missing KHTML condition (authored by leinir).
Disable Plan on missing KHTML condition
Dec 19 2017, 11:56 AM
leinir committed R877:583c9f938e9b: KHTML is required for Calligra Plan, so add that to the requirements (authored by leinir).
KHTML is required for Calligra Plan, so add that to the requirements
Dec 19 2017, 10:46 AM
leinir committed R157:d1e69a05800f: Import the unarr code (authored by leinir).
Import the unarr code
Dec 19 2017, 10:24 AM
leinir committed R157:d53549d4ffc8: Remove the external module for unarr (authored by leinir).
Remove the external module for unarr
Dec 19 2017, 10:24 AM

Dec 18 2017

leinir committed R8:5a2229ee7d5f: Make sure to add TextWidgets (for KRichTextWidget) (authored by leinir).
Make sure to add TextWidgets (for KRichTextWidget)
Dec 18 2017, 7:29 PM
leinir committed R877:06bb49439587: Add (temporary) patch for TagLib detection issue (authored by leinir).
Add (temporary) patch for TagLib detection issue
Dec 18 2017, 4:13 PM
leinir committed R877:43f129bfb38f: Fix up Peruse blueprint a touch for clarity (authored by leinir).
Fix up Peruse blueprint a touch for clarity
Dec 18 2017, 4:13 PM
leinir committed R304:e33d06f9857a: Require the same internal version as you're building (authored by leinir).
Require the same internal version as you're building
Dec 18 2017, 2:53 PM
leinir closed D8311: Require the same internal version as you're building.
Dec 18 2017, 2:53 PM · KNewStuff, Frameworks
leinir added a reviewer for D9398: Fix TagLib detection and build on Windows: Frameworks.
Dec 18 2017, 2:45 PM
leinir created D9398: Fix TagLib detection and build on Windows.
Dec 18 2017, 2:44 PM
leinir committed R877:c1fc2fba7a7b: Don't require all of boost, when we only need boost-system (authored by leinir).
Don't require all of boost, when we only need boost-system
Dec 18 2017, 9:14 AM
leinir committed R8:0daa695cfde5: Use same qxst iteration as elsewhere in the codebase (authored by leinir).
Use same qxst iteration as elsewhere in the codebase
Dec 18 2017, 9:02 AM

Dec 15 2017

leinir committed R8:8e55f29b8228: Only do this magic on Windows (fails elsewhere) (authored by leinir).
Only do this magic on Windows (fails elsewhere)
Dec 15 2017, 12:01 PM
leinir committed R877:f2e81bb632ad: Add Calligra blueprint (authored by leinir).
Add Calligra blueprint
Dec 15 2017, 10:37 AM
leinir committed R8:4cf27fe08f78: Ensure we have app icons on Windows (authored by leinir).
Ensure we have app icons on Windows
Dec 15 2017, 9:39 AM
leinir committed R8:23e6060411e4: Switch to using QtWebEngine for dropbox support (authored by leinir).
Switch to using QtWebEngine for dropbox support
Dec 15 2017, 9:39 AM

Dec 12 2017

leinir committed R877:6778b010d315: Remove non-existent URL, point default to one that does exist (authored by leinir).
Remove non-existent URL, point default to one that does exist
Dec 12 2017, 1:15 PM
leinir committed R877:7fe561b404ab: Require lcms2 for poppler (authored by leinir).
Require lcms2 for poppler
Dec 12 2017, 1:08 PM
leinir committed R877:7196b2cf993a: Port to the new blacklisting API (authored by leinir).
Port to the new blacklisting API
Dec 12 2017, 1:08 PM

Dec 11 2017

leinir committed R8:ad5f70e27c5f: Make Plan build on Windows (authored by leinir).
Make Plan build on Windows
Dec 11 2017, 10:51 AM
leinir closed D9253: Make Plan build on Windows.
Dec 11 2017, 10:51 AM · Calligra: 3.0

Dec 8 2017

leinir updated subscribers of D9253: Make Plan build on Windows.
Dec 8 2017, 1:36 PM · Calligra: 3.0
leinir created D9253: Make Plan build on Windows.
Dec 8 2017, 1:29 PM · Calligra: 3.0

Dec 7 2017

leinir committed R877:61c02a13fbd3: Add ssl login support for libgit2 (by adding libssh2 blueprint and using it) (authored by leinir).
Add ssl login support for libgit2 (by adding libssh2 blueprint and using it)
Dec 7 2017, 11:36 AM
leinir closed D9069: Add ssl login support for libgit2 (by adding libssh2 blueprint and using it).
Dec 7 2017, 11:36 AM · Craft

Dec 6 2017

leinir updated the diff for D9069: Add ssl login support for libgit2 (by adding libssh2 blueprint and using it).

Create a proper git formatted patch, and don't try to both switch to a branch and check out a tag (because that's just silly)

Dec 6 2017, 2:03 PM · Craft

Dec 5 2017

leinir updated the diff for D9069: Add ssl login support for libgit2 (by adding libssh2 blueprint and using it).

Add the patch required to get linking working properly for libssh2 with msvc

Dec 5 2017, 2:40 PM · Craft

Nov 30 2017

leinir added a comment to D9069: Add ssl login support for libgit2 (by adding libssh2 blueprint and using it).

msvc:
FAILED: git2.dll git2.lib
cmd.exe /C "cd . && C:\ProgramData\chocolatey\lib\cmake.portable\tools\cmake-3.9.4-win32-x86\bin\cmake.exe -E vs_link_dll --intdir=src\CMakeFiles\git2.dir --manifests -- C:\PROGRA~2\MICROS~1\2017\PROFES~1\VC\Tools\MSVC\1411~1.255\bin\HostX64\x64\link.exe /nologo @CMakeFiles/git2.rsp /out:git2.dll /implib:git2.lib /pdb:git2.pdb /dll /version:0.26 /DYNAMICBASE /NXCOMPAT /LARGEADDRESSAWARE /VERSION:0.26 /DEBUG /RELEASE /LTCG /OPT:REF /OPT:ICF /INCREMENTAL:NO /DEBUGTYPE:cv,fixup && cd ."
LINK : fatal error LNK1181: cannot open input file 'ssh2.lib'
LINK failed. with 1181

Nov 30 2017, 1:50 PM · Craft
leinir added inline comments to D9067: Detect x64 for icu with msvc, and duplicate data file functionality from mingw.
Nov 30 2017, 1:46 PM · Craft
leinir created D9069: Add ssl login support for libgit2 (by adding libssh2 blueprint and using it).
Nov 30 2017, 1:17 PM · Craft
leinir created D9067: Detect x64 for icu with msvc, and duplicate data file functionality from mingw.
Nov 30 2017, 1:11 PM · Craft

Nov 28 2017

leinir added a comment to D9018: Don't cause circular linking on Windows.

So it resulted in something like aspell.dll requiring aspell.dll?

Nov 28 2017, 9:19 AM · Frameworks

Nov 27 2017

leinir accepted D9012: Revert "Detach before setting the d pointer".
Nov 27 2017, 7:05 PM · Frameworks
leinir added a reviewer for D9018: Don't cause circular linking on Windows: Frameworks.
Nov 27 2017, 2:40 PM · Frameworks
leinir created D9018: Don't cause circular linking on Windows.
Nov 27 2017, 2:38 PM · Frameworks
leinir added a comment to D9012: Revert "Detach before setting the d pointer".

Quicker is better here, i think... Perhaps it is worth adding the documentation we discussed as well in this review? Thinking about making it easier to track the history and whatnot of what happened and why...

Nov 27 2017, 11:19 AM · Frameworks

Nov 23 2017

leinir committed R8:564772b9ed14: Use correct exports for the kinit mains (authored by leinir).
Use correct exports for the kinit mains
Nov 23 2017, 12:01 PM
leinir committed R8:02358285a3bb: Build with not-gcc (authored by leinir).
Build with not-gcc
Nov 23 2017, 12:01 PM
leinir committed R8:faad036201aa: Avoid duplicated symbols (authored by leinir).
Avoid duplicated symbols
Nov 23 2017, 12:01 PM
leinir committed R8:2d5fd7646b32: Use QQC2.Label instead of Kirigami's (deprecated) one (authored by leinir).
Use QQC2.Label instead of Kirigami's (deprecated) one
Nov 23 2017, 12:01 PM

Nov 16 2017

leinir accepted D8811: [knewstuff] Do not leak ImageLoader on error.

Looks good to me :)

Nov 16 2017, 1:52 PM · Frameworks, KNewStuff

Nov 15 2017

leinir added inline comments to D8811: [knewstuff] Do not leak ImageLoader on error.
Nov 15 2017, 1:05 PM · Frameworks, KNewStuff
leinir added inline comments to D8811: [knewstuff] Do not leak ImageLoader on error.
Nov 15 2017, 12:46 PM · Frameworks, KNewStuff
leinir added inline comments to D8811: [knewstuff] Do not leak ImageLoader on error.
Nov 15 2017, 11:49 AM · Frameworks, KNewStuff

Nov 13 2017

leinir added a comment to R8:1bbb6e00022b: Port Calligra Gemini for 3.x.

The commit breaks compilation om CI, see:
https://build.kde.org/job/Extragear%20calligra%20kf5-qt5%20SUSEQt5.9/
Could you have a look?

Nov 13 2017, 1:24 PM
leinir committed R8:c39f329dbdbd: Mark the QtQuick1 components as unported (authored by leinir).
Mark the QtQuick1 components as unported
Nov 13 2017, 1:21 PM
leinir added a comment to R8:1bbb6e00022b: Port Calligra Gemini for 3.x.

The commit breaks compilation om CI, see:
https://build.kde.org/job/Extragear%20calligra%20kf5-qt5%20SUSEQt5.9/
Could you have a look?

Nov 13 2017, 10:30 AM

Nov 8 2017

leinir committed R8:1bbb6e00022b: Port Calligra Gemini for 3.x (authored by leinir).
Port Calligra Gemini for 3.x
Nov 8 2017, 2:17 PM
leinir closed D8310: Port Calligra Gemini for 3.x.
Nov 8 2017, 2:17 PM · Calligra: 3.0
leinir committed R8:4e8829be02b0: Fix the broken merge bits, again (authored by leinir).
Fix the broken merge bits, again
Nov 8 2017, 1:57 PM
leinir committed R8:8c40c5cc2a2a: Add the GeminiMainWindow library (authored by leinir).
Add the GeminiMainWindow library
Nov 8 2017, 1:57 PM
leinir committed R8:76a0a0938abf: Merge branch 'master' into calligra-gemini-leinir (authored by leinir).
Merge branch 'master' into calligra-gemini-leinir
Nov 8 2017, 1:57 PM
leinir committed R8:ff8ecadad90a: Fix the include's case (or clang will complain) (authored by leinir).
Fix the include's case (or clang will complain)
Nov 8 2017, 1:57 PM
leinir committed R8:5e430a7a5e9d: Syntax policy (authored by leinir).
Syntax policy
Nov 8 2017, 1:57 PM
leinir committed R8:9952b763b23e: Merge branch 'master' into calligra-gemini-leinir (authored by leinir).
Merge branch 'master' into calligra-gemini-leinir
Nov 8 2017, 1:57 PM
leinir committed R8:3e6df97bdb29: Add the GeminiMainWindow library (authored by leinir).
Add the GeminiMainWindow library
Nov 8 2017, 1:57 PM

Oct 30 2017

leinir added a comment to D8310: Port Calligra Gemini for 3.x.

Pinged on IRC on Friday and i'll just archive the chat here:

Oct 30 2017, 11:01 AM · Calligra: 3.0

Oct 27 2017

leinir added an inline comment to M112: System Settings Alpha Graphic Redesign.
Oct 27 2017, 4:51 PM · KDE Developers, VDG
leinir accepted D8188: Remove PreferCache from network requests.

Right, yes, i think that was a bit of left over from working on it all. Go for it.

Oct 27 2017, 11:21 AM · Frameworks
leinir added a comment to D7194: Detach before setting the d pointer.

This already went into one release, and it would be quite useful to get it sorted before the next one rolls around, and the consensus seems to be reverting, as leaving kns with this patch in has some fairly unfortunate side effects. Could we get it reverted before the next release is done?

Oct 27 2017, 10:53 AM · Frameworks

Oct 25 2017

leinir updated subscribers of D7194: Detach before setting the d pointer.

Damn... Well spotted, @kossebau. Right, so immediate (at least temporary solution) to make things not broken would annoyingly enough be to revert the patch, yes... I am now thinking that another oddity noticed by @sitter last week was caused by this as well (going by the installedFiles data being out of sync, it would seem likely it would cause what they were seeing). So... while it feels a bit odd, i would have to vote to revert immediately, and create a new patch documenting why we can't detach in certain classes... Possibly adding in a TODO for Frameworks 6 (there's already a couple of those in kns).

Oct 25 2017, 8:27 AM · Frameworks

Oct 15 2017

leinir created D8311: Require the same internal version as you're building.
Oct 15 2017, 2:01 PM · KNewStuff, Frameworks
leinir committed R157:41ce3757d3ee: Port to QCC2 from 1.4 (Button in particular) (authored by leinir).
Port to QCC2 from 1.4 (Button in particular)
Oct 15 2017, 1:52 PM
leinir created D8310: Port Calligra Gemini for 3.x.
Oct 15 2017, 1:18 PM · Calligra: 3.0
leinir committed R8:7acd5f0760eb: Merge branch 'master' into calligra-gemini-leinir (authored by leinir).
Merge branch 'master' into calligra-gemini-leinir
Oct 15 2017, 12:36 PM
leinir committed R8:5c0a448e5f8e: Remove some errors from merging (authored by leinir).
Remove some errors from merging
Oct 15 2017, 12:36 PM
leinir committed R8:2ed1aef99547: Add the GeminiMainWindow library (authored by leinir).
Add the GeminiMainWindow library
Oct 15 2017, 12:36 PM
leinir committed R8:247826f3f9ba: Merge remote-tracking branch 'origin/master' into calligra-gemini-leinir (authored by leinir).
Merge remote-tracking branch 'origin/master' into calligra-gemini-leinir
Oct 15 2017, 12:36 PM
leinir committed R8:c1e2eef8c3b9: A bit of windowsism reduction... (authored by leinir).
A bit of windowsism reduction...
Oct 15 2017, 12:36 PM
leinir committed R8:81e595dda4fe: Merge remote-tracking branch 'origin/master' into calligra-gemini-leinir (authored by leinir).
Merge remote-tracking branch 'origin/master' into calligra-gemini-leinir
Oct 15 2017, 12:36 PM

Oct 2 2017

leinir committed R304:aad1ca02f183: Require Kirigami 2.1 instead of 1.0 for KNewStuffQuick (authored by leinir).
Require Kirigami 2.1 instead of 1.0 for KNewStuffQuick
Oct 2 2017, 2:47 PM
leinir closed D8111: Require Kirigami 2.1 instead of 1.0 for KNewStuffQuick.
Oct 2 2017, 2:47 PM · KNewStuff, Frameworks