leinir (Dan Leinir Turthra Jensen)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jul 8 2015, 8:34 AM (106 w, 4 d)
Availability
Available

Recent Activity

Yesterday

leinir committed R8:2b89f0e7508e: Clean the view mode sync object up a bit (authored by leinir).
Clean the view mode sync object up a bit
Sun, Jul 23, 8:29 PM
leinir committed R8:214a1cea5df6: A bit of documentation (authored by leinir).
A bit of documentation
Sun, Jul 23, 8:29 PM
leinir committed R8:ce5330777205: Initialise the document offset (authored by leinir).
Initialise the document offset
Sun, Jul 23, 3:29 PM
leinir committed R8:0d7e1a3cc757: Handle being given a null documentOffset (and react appropriately) (authored by leinir).
Handle being given a null documentOffset (and react appropriately)
Sun, Jul 23, 3:29 PM
leinir committed R8:2e4523ac18ad: Left over merge crud (authored by leinir).
Left over merge crud
Sun, Jul 23, 2:43 PM
leinir committed R8:d256bc2cd5ab: Initialise some more members on the viewmodesyncobject (authored by leinir).
Initialise some more members on the viewmodesyncobject
Sun, Jul 23, 2:43 PM
leinir committed R8:f652d13de296: Merge branch 'master' into calligra-gemini-leinir (authored by leinir).
Merge branch 'master' into calligra-gemini-leinir
Sun, Jul 23, 2:43 PM
leinir committed R8:b31621174fd1: Add the GeminiMainWindow library (authored by leinir).
Add the GeminiMainWindow library
Sun, Jul 23, 2:43 PM
leinir committed R8:a5a14f883e44: Fix Stage document page in Gemini (authored by leinir).
Fix Stage document page in Gemini
Sun, Jul 23, 1:44 PM

Sat, Jul 22

leinir committed R8:8ef9322f3823: QPointer for the text doc implementation (authored by leinir).
QPointer for the text doc implementation
Sat, Jul 22, 7:02 PM
leinir committed R8:e72d5b0b1dc1: Add some QPointer to the statistics widget (authored by leinir).
Add some QPointer to the statistics widget
Sat, Jul 22, 7:02 PM

Fri, Jul 21

leinir committed R157:cc1b7204ac15: Require Qt5::Sql and Kirigami 2.1 (authored by leinir).
Require Qt5::Sql and Kirigami 2.1
Fri, Jul 21, 5:16 PM
leinir committed R157:5cc08593bb39: Port Peruse to Kirigami 2.1 (authored by leinir).
Port Peruse to Kirigami 2.1
Fri, Jul 21, 5:16 PM
leinir committed R157:d214fd606068: Make the category get function return count as well (authored by leinir).
Make the category get function return count as well
Fri, Jul 21, 5:16 PM
leinir committed R157:a224574ea44d: Don't give the rowcount for categories, just the book count (authored by leinir).
Don't give the rowcount for categories, just the book count
Fri, Jul 21, 4:56 PM
leinir committed R157:13a9b616e4ad: Add the database code itself (authored by leinir).
Add the database code itself
Fri, Jul 21, 4:56 PM
leinir committed R157:6825117b44d1: Make the cache loading gentler, instant UI (authored by leinir).
Make the cache loading gentler, instant UI
Fri, Jul 21, 4:56 PM
leinir committed R157:ba158c885c17: Add an sqlite database cache to Peruse (authored by leinir).
Add an sqlite database cache to Peruse
Fri, Jul 21, 4:56 PM

Fri, Jul 7

leinir accepted D6532: When requesting from the cache, report all entries at bulk.

Hmm... i was thinking this could cause issues, i don't see anywhere assumptions are made about page size on the consumption side (damn we're lucky this whole split thing's so new ;) ). Nothing in the API suggests you might get more than the requested number when you ask for entries, but conversely nothing says you will potentially get less, and that happens on a regular basis, so... sure, why not :)

Fri, Jul 7, 8:06 AM · Frameworks

Wed, Jul 5

leinir added a comment to D6512: Add support for proposed tags addition in OCS 1.7.
In D6512#121834, @apol wrote:

+1 looks sensible to me.

Wed, Jul 5, 12:33 PM · KDE Store, Frameworks
leinir created D6513: Add support for Attica tags support.
Wed, Jul 5, 12:31 PM · Frameworks, KNewStuff
leinir added a dependent revision for D6512: Add support for proposed tags addition in OCS 1.7: D6513: Add support for Attica tags support.
Wed, Jul 5, 12:31 PM · KDE Store, Frameworks
leinir created D6512: Add support for proposed tags addition in OCS 1.7.
Wed, Jul 5, 12:26 PM · KDE Store, Frameworks

Tue, Jul 4

leinir accepted D6492: Also use m_currentRequest when checking for installed and updates.

Different approach, but yeah, telling people what'll actually happen works :)

Tue, Jul 4, 1:59 PM · Frameworks
leinir requested changes to D6492: Also use m_currentRequest when checking for installed and updates.

derp, not accepted, my bad...

Tue, Jul 4, 8:30 AM · Frameworks
leinir accepted D6492: Also use m_currentRequest when checking for installed and updates.

That is indeed a very good point. I think we might possibly have an issue here, though, in that since these two searches are no longer stand-alone, if the filter is not explicitly reset before attempting to perform a search we will only search installed and updateable items. I don't think it is necessarily an enormous or insurmountable issue here, as far as i can tell the only code which currently uses these two functions is in KNS' own DownloadManagers (at least, lxr suggests as much), and if we ensure those two are fixed to reset the filter before launching a search, i think we're probably ok.

Tue, Jul 4, 8:29 AM · Frameworks

Tue, Jun 27

leinir committed R304:4b37ece102dd: Expand KNewStuff documentation (authored by leinir).
Expand KNewStuff documentation
Tue, Jun 27, 4:00 PM
leinir closed D5902: Expand KNewStuff documentation by committing R304:4b37ece102dd: Expand KNewStuff documentation.
Tue, Jun 27, 4:00 PM · Frameworks
leinir added inline comments to D5902: Expand KNewStuff documentation.
Tue, Jun 27, 1:43 PM · Frameworks
leinir updated the diff for D5902: Expand KNewStuff documentation.

Add/fix a whole bunch of more documentation, identified as missing (or incorrect) by Aniketh

Tue, Jun 27, 10:59 AM · Frameworks

Jun 23 2017

leinir committed R304:eb2e65a882f0: Fix incorrect error detection for missing knsrc files (authored by leinir).
Fix incorrect error detection for missing knsrc files
Jun 23 2017, 10:50 AM
leinir closed D6340: Fix incorrect error detection for missing knsrc files by committing R304:eb2e65a882f0: Fix incorrect error detection for missing knsrc files.
Jun 23 2017, 10:50 AM · Frameworks, KNewStuff
leinir added inline comments to D6340: Fix incorrect error detection for missing knsrc files.
Jun 23 2017, 10:48 AM · Frameworks, KNewStuff

Jun 22 2017

leinir created D6340: Fix incorrect error detection for missing knsrc files.
Jun 22 2017, 12:48 PM · Frameworks, KNewStuff
leinir accepted D6324: Make sure we won't modify the aspect ratio of the icons.

Looks good for the initial case of getting rid of the obviously broken looking aspect ratio at the very least, though i think exposing the property might still be good... But, at the very least, it matches the HIG so that's cool :) (i don't personally like the whole scale-and-crop thing, but i'm also not the designer and i know entirely sensible reasons exist for this choice)

Jun 22 2017, 10:33 AM · Kirigami
leinir committed R134:3bb34859dcb6: Simplify KNSBackend fetch logic (authored by leinir).
Simplify KNSBackend fetch logic
Jun 22 2017, 10:29 AM

Jun 15 2017

leinir added a comment to D6191: Simplify KNSBackend fetch logic.
In D6191#116635, @apol wrote:
In D6191#116480, @apol wrote:

This will go to Plasma/5.10, right?

As in, merge this patch into Plasma/5.10 as well as master? I don't see why it would fail to merge, yeah, i'll do that :)

It went to master, right? Also for some reason it didn't close the bug...

Jun 15 2017, 6:30 PM · Discover Software Store, Plasma
leinir abandoned D5767: Postpone searches for half a human moment.

Incidentally, because KNS itself will already postpone non-cached searches by one second, the new proposed solution above (to only to this for KNS sources) is already implemented by way of using D6191

Jun 15 2017, 9:50 AM · Plasma
leinir committed R134:efaa09a20543: Simplify KNSBackend fetch logic (authored by leinir).
Simplify KNSBackend fetch logic
Jun 15 2017, 9:47 AM
leinir closed D6191: Simplify KNSBackend fetch logic by committing R134:efaa09a20543: Simplify KNSBackend fetch logic.
Jun 15 2017, 9:47 AM · Discover Software Store, Plasma
leinir added a comment to D6191: Simplify KNSBackend fetch logic.
In D6191#116480, @apol wrote:

This will go to Plasma/5.10, right?

Jun 15 2017, 8:52 AM · Discover Software Store, Plasma

Jun 14 2017

leinir added a comment to D6191: Simplify KNSBackend fetch logic.

Related bug: https://bugs.kde.org/show_bug.cgi?id=380138

Jun 14 2017, 5:34 PM · Discover Software Store, Plasma
leinir committed R169:f3f2622e79b9: Don't crash when deleted during network operations (authored by leinir).
Don't crash when deleted during network operations
Jun 14 2017, 11:02 AM
leinir closed D6212: Don't crash when deleted during network operations by committing R169:f3f2622e79b9: Don't crash when deleted during network operations.
Jun 14 2017, 11:02 AM · Kirigami
leinir updated the diff for D6191: Simplify KNSBackend fetch logic.

Upon reviewing prior to merging, i realised that a file was missing from the most recent diff (StandardBackendUpdater did, as suggested, not listen to the resourceRemoved signal, and now does).

Jun 14 2017, 10:51 AM · Discover Software Store, Plasma
leinir committed R304:2f8580b9e604: Expose and use Engine's page size variable (authored by leinir).
Expose and use Engine's page size variable
Jun 14 2017, 10:46 AM
leinir closed D6190: Expose and use Engine's page size variable by committing R304:2f8580b9e604: Expose and use Engine's page size variable.
Jun 14 2017, 10:46 AM · Frameworks, KNewStuff

Jun 13 2017

leinir updated the diff for D6212: Don't crash when deleted during network operations.

Fix glaringly obvious over-complication spotted by David :)

Jun 13 2017, 1:20 PM · Kirigami
leinir created D6212: Don't crash when deleted during network operations.
Jun 13 2017, 12:52 PM · Kirigami
leinir updated the diff for D6191: Simplify KNSBackend fetch logic.

Adapted code as suggested. Note that this now depends on D6190 getting merged (as that contains the code that's iffed out).

Jun 13 2017, 12:10 PM · Discover Software Store, Plasma
leinir added inline comments to D6191: Simplify KNSBackend fetch logic.
Jun 13 2017, 12:09 PM · Discover Software Store, Plasma

Jun 12 2017

leinir updated the diff for D6190: Expose and use Engine's page size variable.

Don't const & an int, that's just silly.

Jun 12 2017, 1:25 PM · Frameworks, KNewStuff
leinir added a comment to D6190: Expose and use Engine's page size variable.

As far as i can gather, it was simply never added because, well, it was never used in a lot of places... This really is more a case of equalising some features between requestData and other parts of the engine (so they can all be paginated by the size they really want to be).

Jun 12 2017, 1:24 PM · Frameworks, KNewStuff
leinir created D6191: Simplify KNSBackend fetch logic.
Jun 12 2017, 12:46 PM · Discover Software Store, Plasma
leinir created D6190: Expose and use Engine's page size variable.
Jun 12 2017, 12:40 PM · Frameworks, KNewStuff

Jun 8 2017

leinir created T6288: Support for granular install of DownloadItems.
Jun 8 2017, 12:04 PM · KNewStuff

Jun 6 2017

leinir accepted D6067: Make it possible to use QXmlStreamReader to read a KNS registry file.
In D6067#114528, @apol wrote:

On a similar note to handling comments, how does it now handle unknown/garbage tags? While it won't affect the cache code, it would potentially affect other things (ocs is not guaranteed to be perfectly formed, and it's one of the ways the framework's retained backwards compatibility). From what i can tell, this would assert when an unknown tag is encountered, right?

This is for .knsregistry files, not OCS. These files are generated by the very same class here.

Jun 6 2017, 12:05 PM · Frameworks
leinir added a comment to D6067: Make it possible to use QXmlStreamReader to read a KNS registry file.

On a similar note to handling comments, how does it now handle unknown/garbage tags? While it won't affect the cache code, it would potentially affect other things (ocs is not guaranteed to be perfectly formed, and it's one of the ways the framework's retained backwards compatibility). From what i can tell, this would assert when an unknown tag is encountered, right?

Jun 6 2017, 10:31 AM · Frameworks
leinir accepted D6104: Use the right scope for the installpath variable.

Personally less fond of auto than you are... But, that is just me, and this is a framework, and it's fine :) A massive reduction in allocations is a very good thing, go for it :)

Jun 6 2017, 9:15 AM · Frameworks

Jun 5 2017

leinir accepted D6049: Extend unittests to test stable sort..

Sorting correctness (and more thorough testing) is good, yes. LGTM! :)

Jun 5 2017, 11:01 AM · Frameworks
leinir committed R134:05e780a32f21: Use the first thumbnail as icon for KNS resources (authored by leinir).
Use the first thumbnail as icon for KNS resources
Jun 5 2017, 10:58 AM
leinir closed D5768: Use the first thumbnail as icon for KNS resources by committing R134:05e780a32f21: Use the first thumbnail as icon for KNS resources.
Jun 5 2017, 10:58 AM · Plasma

May 18 2017

leinir updated the diff for D5902: Expand KNewStuff documentation.
May 18 2017, 9:17 AM · Frameworks
leinir added inline comments to D5902: Expand KNewStuff documentation.
May 18 2017, 8:50 AM · Frameworks

May 17 2017

leinir added a reviewer for D5902: Expand KNewStuff documentation: KNewStuff.
May 17 2017, 12:56 PM · Frameworks
leinir created D5902: Expand KNewStuff documentation.
May 17 2017, 12:56 PM · Frameworks

May 15 2017

leinir updated the task description for T6133: Tags support in Ocsv1Controller.
May 15 2017, 2:26 PM · KDE Store
leinir created T6133: Tags support in Ocsv1Controller.
May 15 2017, 2:18 PM · KDE Store

May 11 2017

leinir added a comment to D5769: Use Kirigami.Icon instead of QIconItem.

if we can trust that Kirigami 2.2 is released sometime in the not too distant future.

Will it be released publicly by Monday?

May 11 2017, 2:04 PM · Plasma
leinir committed R304:b8d0bc8818ff: Use a single QNAM (and a disk cache) for HTTP jobs (authored by leinir).
Use a single QNAM (and a disk cache) for HTTP jobs
May 11 2017, 1:14 PM
leinir closed D5638: Use a single QNAM (and a disk cache) for HTTP jobs by committing R304:b8d0bc8818ff: Use a single QNAM (and a disk cache) for HTTP jobs.
May 11 2017, 1:14 PM · Frameworks
leinir committed R304:6207a87b71d7: Internal cache for provider data on initialisation (authored by leinir).
Internal cache for provider data on initialisation
May 11 2017, 1:13 PM
leinir closed D5639: Internal cache for provider data on initialisation by committing R304:6207a87b71d7: Internal cache for provider data on initialisation.
May 11 2017, 1:13 PM · Frameworks
leinir accepted D5811: Improve error notification.

lgtm :)

May 11 2017, 1:04 PM · Frameworks
leinir committed R134:361f408eb00c: Use Kirigami.Icon instead of QIconItem (authored by leinir).
Use Kirigami.Icon instead of QIconItem
May 11 2017, 1:00 PM
leinir closed D5769: Use Kirigami.Icon instead of QIconItem by committing R134:361f408eb00c: Use Kirigami.Icon instead of QIconItem.
May 11 2017, 1:00 PM · Plasma

May 8 2017

leinir added a comment to D5767: Postpone searches for half a human moment.
In D5767#108234, @apol wrote:

It could make sense to move this to the KNSBackend, any appstream-based backends don't have such a problem.

May 8 2017, 9:30 PM · Plasma
leinir committed R169:e3293e9c05b5: Add support for remote image sources to DesktopIcon (authored by leinir).
Add support for remote image sources to DesktopIcon
May 8 2017, 7:16 PM
leinir closed D5764: Add support for remote image sources to DesktopIcon by committing R169:e3293e9c05b5: Add support for remote image sources to DesktopIcon.
May 8 2017, 7:16 PM · Kirigami
leinir added a comment to D5767: Postpone searches for half a human moment.
In D5767#108088, @markg wrote:

I don't think adding a (rather massive) delay is the real fix here. It only masks the actual issue.

What really happens (just opened the discover store for the first time ever) is that entries can flow in at any point, that might be an issue.
Every batch can contain items for any position in the in the store.

The query used to fetch the data should fetch it in order of appearance. That would fix the visual clutter issue you described.

Secondly (but this is outside the scope of this report) it should probably implement a incremental loading logic. Right now it seems to fetch everything.

May 8 2017, 4:53 PM · Plasma
leinir added a comment to D5769: Use Kirigami.Icon instead of QIconItem.
In D5769#108014, @apol wrote:

This will add a dependency to Kirigami 2.2, is it something we can have?

May 8 2017, 3:11 PM · Plasma
leinir added a comment to D5764: Add support for remote image sources to DesktopIcon.
In D5764#108019, @apol wrote:

Don't we also have to add support for when DesktopIcon::m_source is a QIcon?

May 8 2017, 3:04 PM · Kirigami
leinir updated the diff for D5768: Use the first thumbnail as icon for KNS resources.

Have a slightly more useful fallback icon than just nothing (that is, if there is no first thumbnail, use the one it used previously)

May 8 2017, 2:56 PM · Plasma
leinir created D5769: Use Kirigami.Icon instead of QIconItem.
May 8 2017, 2:51 PM · Plasma
leinir created D5768: Use the first thumbnail as icon for KNS resources.
May 8 2017, 2:48 PM · Plasma
leinir created D5767: Postpone searches for half a human moment.
May 8 2017, 2:44 PM · Plasma
leinir created D5764: Add support for remote image sources to DesktopIcon.
May 8 2017, 1:17 PM · Kirigami

May 7 2017

leinir updated the diff for D5638: Use a single QNAM (and a disk cache) for HTTP jobs.

Work some numbers a bit

May 7 2017, 5:30 PM · Frameworks
leinir added a comment to D5638: Use a single QNAM (and a disk cache) for HTTP jobs.

50000 is 50kB.
You wrote 50 megs which would be 50000000 or 50*1024*1024.

May 7 2017, 5:28 PM · Frameworks
leinir updated the diff for D5639: Internal cache for provider data on initialisation.

Static var naming change, for consistency and whatnot

May 7 2017, 5:18 PM · Frameworks
leinir added inline comments to D5639: Internal cache for provider data on initialisation.
May 7 2017, 5:17 PM · Frameworks
leinir updated the diff for D5638: Use a single QNAM (and a disk cache) for HTTP jobs.

static var naming fix, for consistency with elsewhere

May 7 2017, 5:16 PM · Frameworks
leinir updated the diff for D5638: Use a single QNAM (and a disk cache) for HTTP jobs.

A bit of naming cleanup, and a very silly miscalculation because things count in bytes rather than some arbitrary random multiple of them

May 7 2017, 5:12 PM · Frameworks
leinir added inline comments to D5638: Use a single QNAM (and a disk cache) for HTTP jobs.
May 7 2017, 5:10 PM · Frameworks
leinir updated the diff for D5639: Internal cache for provider data on initialisation.

Simplify the xmlloader cache logic a touch

May 7 2017, 4:16 PM · Frameworks
leinir added inline comments to D5639: Internal cache for provider data on initialisation.
May 7 2017, 4:15 PM · Frameworks
leinir updated the diff for D5638: Use a single QNAM (and a disk cache) for HTTP jobs.

Some style fixes, and set a reasonable maximum size for the cache

May 7 2017, 4:13 PM · Frameworks
leinir added inline comments to D5638: Use a single QNAM (and a disk cache) for HTTP jobs.
May 7 2017, 4:11 PM · Frameworks
leinir accepted D5739: Improve some error messages.
May 7 2017, 2:02 PM · Frameworks

May 5 2017

leinir updated the diff for D5638: Use a single QNAM (and a disk cache) for HTTP jobs.

Unpointerify the internals, as agreed

May 5 2017, 8:44 AM · Frameworks