antlarr (Antonio Larrosa Jimenez)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Sep 22 2016, 10:42 AM (160 w, 6 d)
Availability
Available

Recent Activity

Apr 3 2019

antlarr requested review of D20231: Don't force a check for updates when the applet runs.
Apr 3 2019, 3:42 PM

Mar 18 2019

antlarr requested review of D19862: Several fixes related to the network state and applet messages/notifications..
Mar 18 2019, 5:30 PM

May 13 2018

antlarr requested review of D12845: Remove duplicated entry.
May 13 2018, 9:18 AM · Dolphin

Feb 22 2018

antlarr requested review of D10755: Add a MsmApp::skillsPath method so the skills folder is not hardcoded.
Feb 22 2018, 8:06 PM · Plasma
antlarr requested review of D10752: Fix focus being removed from the text input widget.
Feb 22 2018, 7:37 PM · Plasma

Feb 13 2018

antlarr committed R954:d865eec08733: Add Antonio Larrosa's blog (authored by antlarr).
Add Antonio Larrosa's blog
Feb 13 2018, 8:31 PM

Feb 12 2018

antlarr requested review of D10454: Translated all texts from the en directory so the extension works in es.
Feb 12 2018, 9:07 AM · Plasma

Feb 6 2018

antlarr requested review of D10345: Fix build with Qt dev branch, where QCUPSSupport::cupsOptionsList was removed.
Feb 6 2018, 3:59 PM

Oct 2 2017

antlarr updated the diff for D8054: Show headset icons for devices identifying as "Headset" in Description.
  • Remove check for currentPort which is no longer needed
Oct 2 2017, 11:54 AM · Plasma

Sep 29 2017

antlarr added a comment to D8054: Show headset icons for devices identifying as "Headset" in Description.

Thanks for the hint! I didn't know I could use FormFactor directly to reference the Device's formFactor property. Indeed now it looks much better.

Sep 29 2017, 2:31 PM · Plasma
antlarr updated the diff for D8054: Show headset icons for devices identifying as "Headset" in Description.
  • Use the formFactor attribute of the Device directly
Sep 29 2017, 2:30 PM · Plasma
antlarr updated the diff for D8054: Show headset icons for devices identifying as "Headset" in Description.
  • Use form_factor from device to select the icon for a profile
Sep 29 2017, 12:44 PM · Plasma
antlarr added a comment to D8054: Show headset icons for devices identifying as "Headset" in Description.

I wrote in the summary above the contents of the string variables we could work with so that it's clear I couldn't find any other way to extract that information. If you have any other idea (any other variable to use for the match?) I'm happy to test it.

Sep 29 2017, 10:01 AM · Plasma
antlarr added a comment to D8054: Show headset icons for devices identifying as "Headset" in Description.

Perfect, thanks, I'll do that

Sep 29 2017, 9:57 AM · Plasma
antlarr added a comment to D8054: Show headset icons for devices identifying as "Headset" in Description.

If I move it to the end, then the player device will show a headset correctly anyway since no other condition matches but for the capture device, a microphone icon will be shown instead of the headset.

Sep 29 2017, 9:50 AM · Plasma
antlarr added a comment to D8054: Show headset icons for devices identifying as "Headset" in Description.

Hmm, you're right, there's no audio-headset icon in breeze, it's inherited from oxygen. Should we use it while we request an audio-headset icon for breeze? or should I revert that change and use headphones in the meantime?

Sep 29 2017, 9:46 AM · Plasma
antlarr retitled D8054: Show headset icons for devices identifying as "Headset" in Description from Show headphone icons for devices identifying as "Headset" in Description to Show headset icons for devices identifying as "Headset" in Description.
Sep 29 2017, 9:40 AM · Plasma
antlarr updated the diff for D8054: Show headset icons for devices identifying as "Headset" in Description.
  • We have a headset icon, so use it for headsets
Sep 29 2017, 9:39 AM · Plasma
antlarr added a comment to D8054: Show headset icons for devices identifying as "Headset" in Description.
Sep 29 2017, 9:20 AM · Plasma
antlarr created D8054: Show headset icons for devices identifying as "Headset" in Description.
Sep 29 2017, 9:19 AM · Plasma

Mar 23 2017

antlarr committed R495:f35cc5e9ae91: Add explicit cast to fix build with gcc-4.8 (authored by antlarr).
Add explicit cast to fix build with gcc-4.8
Mar 23 2017, 3:28 PM
antlarr closed D5081: Add explicit cast to fix build with gcc-4.8 by committing R495:f35cc5e9ae91: Add explicit cast to fix build with gcc-4.8.
Mar 23 2017, 3:28 PM
antlarr added inline comments to D5081: Add explicit cast to fix build with gcc-4.8.
Mar 23 2017, 12:12 PM

Mar 17 2017

antlarr created D5081: Add explicit cast to fix build with gcc-4.8.
Mar 17 2017, 12:24 PM

Feb 8 2017

antlarr committed R446:f635d3b2347b: Fix build for GCC 7 (authored by antlarr).
Fix build for GCC 7
Feb 8 2017, 4:50 PM

Dec 13 2016

antlarr abandoned D3662: Downgrade required ECM version to 5.26.0.

It seems other parts of kdepim already really require KF5 5.28, so there's no point in requiring less here

Dec 13 2016, 2:45 PM · KDE PIM
antlarr updated the diff for D3662: Downgrade required ECM version to 5.26.0.
  • Change back REQUIRED_KF5_VERSION to KF5_VERSION
Dec 13 2016, 2:28 PM · KDE PIM
antlarr updated the diff for D3662: Downgrade required ECM version to 5.26.0.
  • Set the required KF5 version (5.26.0) with a variable
Dec 13 2016, 10:07 AM · KDE PIM
antlarr updated the diff for D3661: Downgrade required ECM version to 5.26.
  • Set the ECM dependency with a variable
Dec 13 2016, 9:59 AM · Frameworks
antlarr added a comment to D3661: Downgrade required ECM version to 5.26.

The change is fine with me (and 5.26 indeed still works), the problem I see is that the version bumps here happen automatically by the KF5 release scripts AFAIK, ie. this will be a very short-lived change.

Dec 13 2016, 9:26 AM · Frameworks
antlarr updated D3661: Downgrade required ECM version to 5.26.
Dec 13 2016, 9:23 AM · Frameworks
antlarr updated the test plan for D3662: Downgrade required ECM version to 5.26.0.
Dec 13 2016, 9:22 AM · KDE PIM
antlarr added a reviewer for D3662: Downgrade required ECM version to 5.26.0: KDE PIM.
Dec 13 2016, 9:19 AM · KDE PIM
antlarr retitled D3662: Downgrade required ECM version to 5.26.0 from to Downgrade required ECM version to 5.26.0.
Dec 13 2016, 9:18 AM · KDE PIM
antlarr updated the test plan for D3661: Downgrade required ECM version to 5.26.
Dec 13 2016, 9:07 AM · Frameworks
antlarr added a reviewer for D3661: Downgrade required ECM version to 5.26: vkrause.
Dec 13 2016, 9:02 AM · Frameworks
antlarr retitled D3661: Downgrade required ECM version to 5.26 from to Downgrade required ECM version to 5.26.
Dec 13 2016, 9:00 AM · Frameworks

Nov 11 2016

antlarr closed D3331: Unsets XDG_RUNTIME_DIR in processes run with kdesu.
Nov 11 2016, 9:53 AM

Nov 10 2016

antlarr retitled D3331: Unsets XDG_RUNTIME_DIR in processes run with kdesu from to Unsets XDG_RUNTIME_DIR in processes run with kdesu.
Nov 10 2016, 2:49 PM
antlarr added a comment to D3317: Create the xauth-<uid>-<display> under /run instead of /tmp.
In D3317#61947, @dfaure wrote:

Did you test this with kdesu? According to the comment, the whole point here is to save a file that will be used by kdesu, i.e. as another user. Since RuntimeLocation is normally per-user, that other user might not have access to the file
(well ok, root would, but I suppose kdesu also allows logging in as another user?)

Nov 10 2016, 12:43 PM
antlarr updated subscribers of D3317: Create the xauth-<uid>-<display> under /run instead of /tmp.
In D3317#61881, @aacid wrote:

I really know nothing about this, my only involvement with this change was settiing it's umask "properly-ish".

Nov 10 2016, 8:06 AM
antlarr edited reviewers for D3317: Create the xauth-<uid>-<display> under /run instead of /tmp, added: dfaure; removed: aacid.
Nov 10 2016, 7:50 AM

Nov 9 2016

antlarr retitled D3317: Create the xauth-<uid>-<display> under /run instead of /tmp from to Create the xauth-<uid>-<display> under /run instead of /tmp.
Nov 9 2016, 2:40 PM

Nov 4 2016

antlarr committed R120:c309f1eaeb69: Modified distance function to keep aspect ratio as close as possible (authored by antlarr).
Modified distance function to keep aspect ratio as close as possible
Nov 4 2016, 8:58 AM

Nov 2 2016

antlarr committed R120:18858d16d6b1: Modified distance function to keep aspect ratio as close as possible (authored by antlarr).
Modified distance function to keep aspect ratio as close as possible
Nov 2 2016, 12:07 PM
antlarr closed D3188: Modified distance function to keep aspect ratio as close as possible by committing R120:18858d16d6b1: Modified distance function to keep aspect ratio as close as possible.
Nov 2 2016, 12:07 PM · Plasma
antlarr updated the diff for D3188: Modified distance function to keep aspect ratio as close as possible.
  • Moved testfindpreferredimage to an autotests directory
Nov 2 2016, 12:04 PM · Plasma
antlarr committed R134:3297fe6026ed: Make screenshots visible when there's only one screenshot too (authored by antlarr).
Make screenshots visible when there's only one screenshot too
Nov 2 2016, 11:41 AM
antlarr closed D3223: Make screenshots visible when there's only one screenshot too.
Nov 2 2016, 11:40 AM
antlarr retitled D3223: Make screenshots visible when there's only one screenshot too from to Make screenshots visible when there's only one screenshot too.
Nov 2 2016, 10:57 AM

Oct 31 2016

antlarr added a comment to D3192: The combobox needs to be 2 pixels wider for contents to fit.

@hpereiradacosta thanks for reviewing this. Can you cherry-pick the commit for Plasma/5.8?

Oct 31 2016, 5:17 PM · Plasma: Design, Plasma
antlarr committed R31:2007a6b7ad4a: The combobox needs to be 2 pixels wider for contents to fit (authored by antlarr).
The combobox needs to be 2 pixels wider for contents to fit
Oct 31 2016, 5:11 PM
antlarr closed D3192: The combobox needs to be 2 pixels wider for contents to fit.
Oct 31 2016, 5:11 PM · Plasma: Design, Plasma
antlarr updated the diff for D3192: The combobox needs to be 2 pixels wider for contents to fit.
  • Increase width by MenuButton_IndicatorWidth+2 instead of adding a new enum entry
Oct 31 2016, 5:00 PM · Plasma: Design, Plasma
antlarr added inline comments to D3192: The combobox needs to be 2 pixels wider for contents to fit.
Oct 31 2016, 4:24 PM · Plasma: Design, Plasma
antlarr updated the diff for D3188: Modified distance function to keep aspect ratio as close as possible.
  • Adjust the distance method to work with QUAD HD resolutions
Oct 31 2016, 8:53 AM · Plasma

Oct 28 2016

antlarr added a comment to D3188: Modified distance function to keep aspect ratio as close as possible.

Converted the test to use QTest

Oct 28 2016, 4:12 PM · Plasma
antlarr updated the diff for D3188: Modified distance function to keep aspect ratio as close as possible.
  • Converted the test to use QTest
Oct 28 2016, 4:10 PM · Plasma
antlarr added a reviewer for D3192: The combobox needs to be 2 pixels wider for contents to fit: Plasma: Design.
Oct 28 2016, 3:23 PM · Plasma: Design, Plasma
antlarr retitled D3192: The combobox needs to be 2 pixels wider for contents to fit from to The combobox needs to be 2 pixels wider for contents to fit.
Oct 28 2016, 3:18 PM · Plasma: Design, Plasma
antlarr added inline comments to D3188: Modified distance function to keep aspect ratio as close as possible.
Oct 28 2016, 2:54 PM · Plasma
antlarr added inline comments to D3188: Modified distance function to keep aspect ratio as close as possible.
Oct 28 2016, 11:43 AM · Plasma
antlarr retitled D3188: Modified distance function to keep aspect ratio as close as possible from to Modified distance function to keep aspect ratio as close as possible.
Oct 28 2016, 11:36 AM · Plasma

Oct 25 2016

antlarr committed R108:19147f5f85bd: [platformx/x11] Add a freeze protection against OpenGL (authored by antlarr).
[platformx/x11] Add a freeze protection against OpenGL
Oct 25 2016, 7:53 AM
antlarr closed D3132: [platformx/x11] Add a freeze protection against OpenGL.
Oct 25 2016, 7:51 AM · Plasma
antlarr added a comment to D3132: [platformx/x11] Add a freeze protection against OpenGL.

I don't know why, but it seems arc diff doesn't work anymore and I have to use arc diff HEAD~7 to include all 7 commits

Oct 25 2016, 6:58 AM · Plasma
antlarr updated the diff for D3132: [platformx/x11] Add a freeze protection against OpenGL.

Include all 7 commits

Oct 25 2016, 6:55 AM · Plasma

Oct 24 2016

antlarr added a comment to D3132: [platformx/x11] Add a freeze protection against OpenGL.

All issues done

Oct 24 2016, 4:04 PM · Plasma
antlarr updated the diff for D3132: [platformx/x11] Add a freeze protection against OpenGL.
  • Only call PostLastGuardedFrame when OpenGLCompositing is set
Oct 24 2016, 3:16 PM · Plasma
antlarr added inline comments to D3132: [platformx/x11] Add a freeze protection against OpenGL.
Oct 24 2016, 3:10 PM · Plasma
antlarr updated the diff for D3132: [platformx/x11] Add a freeze protection against OpenGL.

Include all 6 commits

Oct 24 2016, 2:56 PM · Plasma
antlarr updated the diff for D3132: [platformx/x11] Add a freeze protection against OpenGL.
  • Use only one timer to detect freezes and other optimizations
  • Test 3 frames for freezes by default
Oct 24 2016, 2:52 PM · Plasma
antlarr committed R128:a666712102be: Do not ask for root permissions when it's unnecessary (authored by antlarr).
Do not ask for root permissions when it's unnecessary
Oct 24 2016, 11:01 AM
antlarr closed D3102: Do not ask for root permissions when it's unnecessary.
Oct 24 2016, 10:57 AM · Plasma
antlarr added inline comments to D3132: [platformx/x11] Add a freeze protection against OpenGL.
Oct 24 2016, 7:24 AM · Plasma

Oct 23 2016

antlarr added inline comments to D3132: [platformx/x11] Add a freeze protection against OpenGL.
Oct 23 2016, 7:20 PM · Plasma
antlarr added inline comments to D3132: [platformx/x11] Add a freeze protection against OpenGL.
Oct 23 2016, 6:31 PM · Plasma
antlarr added a comment to D3132: [platformx/x11] Add a freeze protection against OpenGL.

Btw, I tested the last commit on a virtual machine simulating the freeze with a sleep. I'll check tomorrow what's the minimum value for m_maxFramesTestedForSafety that works to detect the real freeze and update its default value.

Oct 23 2016, 10:35 AM · Plasma
antlarr updated the diff for D3132: [platformx/x11] Add a freeze protection against OpenGL.
  • Remove most overhead caused by the freeze-detection thread
Oct 23 2016, 10:29 AM · Plasma

Oct 22 2016

antlarr added a comment to D3132: [platformx/x11] Add a freeze protection against OpenGL.

How many frames do we need to detect the freeze? I think 30 frames is too much by default. It's adding quite some stress on startup (lots of write to config, lots of additional threads started). Assuming we freeze with tripple buffer when trying to get the next buffer 4 frames should be sufficient to trigger the freeze?

Oct 22 2016, 8:49 AM · Plasma

Oct 21 2016

antlarr added a comment to D3127: [platformx/x11] Add a freeze protection against OpenGL.

I tested this patch but it didn't work at detecting the freeze. Fortunately, after debugging kwin for a bit I worked on this and made a version that detects the freezes correctly.

Oct 21 2016, 7:23 PM · Plasma
antlarr added reviewers for D3132: [platformx/x11] Add a freeze protection against OpenGL: KWin, Plasma, davidedmundson.
Oct 21 2016, 7:20 PM · Plasma
antlarr committed R120:70fc5cc70281: Directly show the username/password textboxes when user list is empty (authored by antlarr).
Directly show the username/password textboxes when user list is empty
Oct 21 2016, 2:04 PM
antlarr closed D3128: Directly show the username/password textboxes when user list is empty.
Oct 21 2016, 2:04 PM · Plasma
antlarr retitled D3128: Directly show the username/password textboxes when user list is empty from to Directly show the username/password textboxes when user list is empty.
Oct 21 2016, 12:36 PM · Plasma

Oct 20 2016

antlarr committed R120:1948839b82b5: Removes preferred definition so a new wallpaper is selected. (authored by antlarr).
Removes preferred definition so a new wallpaper is selected.
Oct 20 2016, 11:54 AM
antlarr closed D2981: Removes preferred definition so a new wallpaper is selected..
Oct 20 2016, 11:52 AM · Plasma
antlarr added a comment to D3102: Do not ask for root permissions when it's unnecessary.

Oops, sorry, I wrote a reply yesterday but forgot to submit it :/

Oct 20 2016, 9:13 AM · Plasma

Oct 18 2016

antlarr retitled D3102: Do not ask for root permissions when it's unnecessary from to Do not ask for root permissions when it's unnecessary.
Oct 18 2016, 5:06 PM · Plasma

Oct 11 2016

antlarr added inline comments to D2981: Removes preferred definition so a new wallpaper is selected..
Oct 11 2016, 6:48 AM · Plasma

Oct 7 2016

antlarr retitled D2981: Removes preferred definition so a new wallpaper is selected. from to Removes preferred definition so a new wallpaper is selected..
Oct 7 2016, 4:37 PM · Plasma

Sep 28 2016

antlarr closed D2880: Fix handling of multiple arguments in command line.
Sep 28 2016, 3:05 PM
antlarr updated the diff for D2880: Fix handling of multiple arguments in command line.
  • Add QUrl::AssumeLocalFile and assume Qt > 5.4.0
Sep 28 2016, 2:59 PM
antlarr retitled D2880: Fix handling of multiple arguments in command line from to Fix handling of multiple arguments in command line.
Sep 28 2016, 1:47 PM
antlarr committed R120:189546c2696a: Renamed userPrompt to userPromptComponent and add userListComponent id (authored by antlarr).
Renamed userPrompt to userPromptComponent and add userListComponent id
Sep 28 2016, 10:12 AM
antlarr closed D2874: Renamed userPrompt to userPromptComponent and add userListComponent id by committing R120:189546c2696a: Renamed userPrompt to userPromptComponent and add userListComponent id.
Sep 28 2016, 10:12 AM · Plasma
antlarr updated the diff for D2874: Renamed userPrompt to userPromptComponent and add userListComponent id.
  • Move logic to show/hide avatars from components/SessionManagementScreen.qml to Main.qml
Sep 28 2016, 7:57 AM · Plasma

Sep 27 2016

antlarr added a comment to D2874: Renamed userPrompt to userPromptComponent and add userListComponent id.

Thanks for your comments. I should warn you that this is the second time I touch qml code, so apologies in advance :).

Sep 27 2016, 5:04 PM · Plasma
antlarr retitled D2874: Renamed userPrompt to userPromptComponent and add userListComponent id from to Renamed userPrompt to userPromptComponent and add userListComponent id.
Sep 27 2016, 3:58 PM · Plasma
antlarr committed R120:76f4d8d71a09: Prefer wallpapers with same aspect ratio as screen (authored by antlarr).
Prefer wallpapers with same aspect ratio as screen
Sep 27 2016, 8:09 AM