cfeck (Christoph Feck)
Developer

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Nov 2 2015, 10:13 PM (154 w, 2 d)
Availability
Available

Recent Activity

Yesterday

cfeck accepted D15857: Port Kalzium away from KDialog KFileDialog and deprecated KRun::runUrl.

Such big changes are hard to review. We used to do KF5 porting step by step, i.e. replace one include or one class in a single commit.

Wed, Oct 17, 10:58 PM · KDE Edu
cfeck accepted D16133: Port KmPlot away from deprecated KStatusBar and kdelibs4support at all.
Wed, Oct 17, 10:49 PM · KDE Edu
cfeck added a reviewer for D15223: Port KolourPaint away from deprecated KIntNumInput: mkoller.
Wed, Oct 17, 10:35 PM
cfeck added a reviewer for D15355: Port KolourPaint away from deprecated KFileDialog: mkoller.
Wed, Oct 17, 10:34 PM
cfeck added a reviewer for D15316: Port KolourPaint away from deprecated KDoubleNumInput: mkoller.

Adding maintainer, because I have seen him reverting previous (unreviewed) attempts.

Wed, Oct 17, 10:32 PM · KDE Applications
cfeck added a comment to D16281: update epub test data and test for comment property.

Phabricator says the MIME Type was changed from application/epub+zip to application/zip. Is this is problem in Phabricator or in your file?

Wed, Oct 17, 10:07 PM · Baloo, Frameworks
cfeck added a comment to T6582: Investigate if qApp->globalStrut is useful.

Qt developers apparently think it is not useful. It wasn't moved to QtGuiApplication, but is only available in QApplication (for QWidget-based apps).

Wed, Oct 17, 1:48 PM · Plasma: Convergence

Sat, Oct 13

cfeck added a comment to D6056: [Run Command] Auto-close on focus loss only if query field is empty.

Please commit or abandon this.

Sat, Oct 13, 10:33 PM · Plasma

Thu, Oct 11

cfeck added a comment to D16133: Port KmPlot away from deprecated KStatusBar and kdelibs4support at all.

Checking the previous statusbar code, the id's have a range of 1 ... 4, so there should be 4 sections at list index 0 ... 3, accessed by at(id - 1). The current patch adds 5 sections, and label at index 0 is never used.

Thu, Oct 11, 6:11 PM · KDE Edu
cfeck added inline comments to D16133: Port KmPlot away from deprecated KStatusBar and kdelibs4support at all.
Thu, Oct 11, 5:37 PM · KDE Edu
cfeck added inline comments to D16133: Port KmPlot away from deprecated KStatusBar and kdelibs4support at all.
Thu, Oct 11, 5:10 PM · KDE Edu
cfeck added inline comments to D16133: Port KmPlot away from deprecated KStatusBar and kdelibs4support at all.
Thu, Oct 11, 5:09 PM · KDE Edu
cfeck committed R883:1526396: Release KDE Applications 18.08.2.
Release KDE Applications 18.08.2
Thu, Oct 11, 9:59 AM
cfeck committed R883:1526395: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:57 AM
cfeck committed R883:1526394: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:57 AM
cfeck committed R883:1526393: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:57 AM
cfeck committed R883:1526392: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:57 AM
cfeck committed R883:1526391: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:57 AM
cfeck committed R883:1526389: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:57 AM
cfeck committed R883:1526390: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:57 AM
cfeck committed R883:1526388: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:57 AM
cfeck committed R883:1526387: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:57 AM
cfeck committed R883:1526386: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:56 AM
cfeck committed R883:1526385: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:56 AM
cfeck committed R883:1526382: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:56 AM
cfeck committed R883:1526383: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:56 AM
cfeck committed R883:1526384: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:56 AM
cfeck committed R883:1526380: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:56 AM
cfeck committed R883:1526381: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:56 AM
cfeck committed R883:1526379: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:56 AM
cfeck committed R883:1526378: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:56 AM
cfeck committed R883:1526377: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:56 AM
cfeck committed R883:1526376: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:56 AM
cfeck committed R883:1526375: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:56 AM
cfeck committed R883:1526373: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:56 AM
cfeck committed R883:1526374: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:56 AM
cfeck committed R883:1526372: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:56 AM
cfeck committed R883:1526371: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:56 AM
cfeck committed R883:1526370: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:56 AM
cfeck committed R883:1526369: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:56 AM
cfeck committed R883:1526368: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:56 AM
cfeck committed R883:1526366: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:56 AM
cfeck committed R883:1526367: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:56 AM
cfeck committed R883:1526365: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:55 AM
cfeck committed R883:1526364: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:55 AM
cfeck committed R883:1526361: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:55 AM
cfeck committed R883:1526363: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:55 AM
cfeck committed R883:1526362: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:55 AM
cfeck committed R883:1526360: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:55 AM
cfeck committed R883:1526357: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:55 AM
cfeck committed R883:1526359: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:55 AM
cfeck committed R883:1526358: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:55 AM
cfeck committed R883:1526356: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:55 AM
cfeck committed R883:1526355: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:55 AM
cfeck committed R883:1526354: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:55 AM
cfeck committed R883:1526350: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:55 AM
cfeck committed R883:1526351: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:55 AM
cfeck committed R883:1526352: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:55 AM
cfeck committed R883:1526353: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:55 AM
cfeck committed R883:1526348: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:55 AM
cfeck committed R883:1526346: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:55 AM
cfeck committed R883:1526349: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:55 AM
cfeck committed R883:1526347: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:55 AM
cfeck committed R883:1526345: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:55 AM
cfeck committed R883:1526342: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:54 AM
cfeck committed R883:1526344: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:54 AM
cfeck committed R883:1526343: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:54 AM
cfeck committed R883:1526341: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:54 AM
cfeck committed R883:1526340: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:54 AM
cfeck committed R883:1526339: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:54 AM
cfeck committed R883:1526338: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:54 AM
cfeck committed R883:1526337: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:54 AM
cfeck committed R883:1526335: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:54 AM
cfeck committed R883:1526336: Create tag for 18.08.2.
Create tag for 18.08.2
Thu, Oct 11, 9:54 AM
cfeck accepted D16117: Port KmPlot away from deprecated KIO::NetAccess and KImageIO.
Thu, Oct 11, 8:20 AM · KDE Edu

Wed, Oct 10

cfeck added a comment to D16117: Port KmPlot away from deprecated KIO::NetAccess and KImageIO.

Awesome. So it does (also) fix bug 360685?

Wed, Oct 10, 10:05 PM · KDE Edu

Tue, Oct 9

cfeck updated subscribers of D15638: force-finish canberra notifications on close().

@dfaure, worth a respin?

Tue, Oct 9, 12:27 PM · Frameworks
cfeck committed R883:1526096: Add KDE Applications 18.08.2.
Add KDE Applications 18.08.2
Tue, Oct 9, 1:49 AM
cfeck committed R883:1526095: Add KDE Applications 18.08.2 announcement.
Add KDE Applications 18.08.2 announcement
Tue, Oct 9, 1:47 AM
cfeck committed R883:1526093: Add (preliminary) changelog for KDE Applications 18.08.2.
Add (preliminary) changelog for KDE Applications 18.08.2
Tue, Oct 9, 1:11 AM

Mon, Oct 8

cfeck added a comment to D15915: Antialias line drawing characters.

Converting int to float does not make lines appear at pixel centers. They need to be shifted by 0.5 pixels in each direction.

Mon, Oct 8, 1:26 PM · Konsole

Sun, Oct 7

cfeck added a comment to D15915: Antialias line drawing characters.

Kurt, please use 'git commit --author=...' to give proper attribution to patches from contributors.

Sun, Oct 7, 12:24 AM · Konsole

Fri, Oct 5

cfeck accepted D15463: Corrected behaviour on repeated pressing of operator buttons.
Fri, Oct 5, 5:41 PM
cfeck added a comment to D15929: Add a 'Properties' entry in the Places panel context menu.

There already is a separator (original line 202), but it is (for whatever reason) not always added. You can remove the if for the separator either in this commit, or in a separate patch, because it is unrelated to the addition of the Properties item.

Fri, Oct 5, 12:22 AM · Dolphin

Thu, Oct 4

cfeck added a comment to D15929: Add a 'Properties' entry in the Places panel context menu.

No, the see the first 'screenshot' I added.

Thu, Oct 4, 8:29 PM · Dolphin
cfeck added a comment to D15929: Add a 'Properties' entry in the Places panel context menu.

Maybe I should actually read the code ... I guess what I want is that you move the 'Properties' above the seperator, not after the 'Edit ...' entry.

Thu, Oct 4, 7:49 PM · Dolphin
cfeck added a comment to D15929: Add a 'Properties' entry in the Places panel context menu.

Yes, I would prefer if the 'Hide' and 'Edit' entries are always preceeded by the separator, separating the items that act on the actual device and the items that act on the places entry.

Thu, Oct 4, 7:46 PM · Dolphin
cfeck accepted D15928: Port Step away from kdelibs4support.
Thu, Oct 4, 7:38 PM · KDE Edu

Wed, Oct 3

cfeck added a comment to D15929: Add a 'Properties' entry in the Places panel context menu.

Actually, I retract previous comment, it should be the last entry in the first section ('Open in ...'), and the separator that is shown above the 'Edit...' entry should also be visible when the 'Edit...' is hidden.

Wed, Oct 3, 10:34 PM · Dolphin
cfeck added inline comments to D15928: Port Step away from kdelibs4support.
Wed, Oct 3, 10:13 PM · KDE Edu
cfeck added a comment to D15929: Add a 'Properties' entry in the Places panel context menu.

Should 'Properties' be last item in the menu?

Wed, Oct 3, 10:09 PM · Dolphin
cfeck committed R374:f167d74ee7eb: GIT_SILENT Upgrade KDE Applications version to 18.08.2. (authored by cfeck).
GIT_SILENT Upgrade KDE Applications version to 18.08.2.
Wed, Oct 3, 8:07 PM
cfeck added inline comments to D15928: Port Step away from kdelibs4support.
Wed, Oct 3, 7:42 PM · KDE Edu
cfeck committed R356:390ebe3746f1: GIT_SILENT Upgrade KDE Applications version to 18.08.2. (authored by cfeck).
GIT_SILENT Upgrade KDE Applications version to 18.08.2.
Wed, Oct 3, 6:32 PM
cfeck committed R358:2717f0625d95: GIT_SILENT Upgrade KDE Applications version to 18.08.2. (authored by cfeck).
GIT_SILENT Upgrade KDE Applications version to 18.08.2.
Wed, Oct 3, 5:58 PM
cfeck committed R344:923871e16155: GIT_SILENT Upgrade KDE Applications version to 18.08.2. (authored by cfeck).
GIT_SILENT Upgrade KDE Applications version to 18.08.2.
Wed, Oct 3, 5:45 PM
cfeck committed R139:767b71e3fa3b: GIT_SILENT Upgrade KDE Applications version to 18.08.2. (authored by cfeck).
GIT_SILENT Upgrade KDE Applications version to 18.08.2.
Wed, Oct 3, 5:37 PM
cfeck committed R318:3f682ad3a7f9: GIT_SILENT Upgrade KDE Applications version to 18.08.2. (authored by cfeck).
GIT_SILENT Upgrade KDE Applications version to 18.08.2.
Wed, Oct 3, 5:37 PM
cfeck committed R166:9fefac3fc265: GIT_SILENT Upgrade KDE Applications version to 18.08.2. (authored by cfeck).
GIT_SILENT Upgrade KDE Applications version to 18.08.2.
Wed, Oct 3, 5:34 PM
cfeck committed R320:6146b7d33efe: GIT_SILENT Upgrade KDE Applications version to 18.08.2. (authored by cfeck).
GIT_SILENT Upgrade KDE Applications version to 18.08.2.
Wed, Oct 3, 5:10 PM