- User Since
- Nov 2 2015, 10:13 PM (154 w, 2 d)
Such big changes are hard to review. We used to do KF5 porting step by step, i.e. replace one include or one class in a single commit.
Adding maintainer, because I have seen him reverting previous (unreviewed) attempts.
Phabricator says the MIME Type was changed from application/epub+zip to application/zip. Is this is problem in Phabricator or in your file?
Qt developers apparently think it is not useful. It wasn't moved to QtGuiApplication, but is only available in QApplication (for QWidget-based apps).
Sat, Oct 13
Please commit or abandon this.
Thu, Oct 11
Checking the previous statusbar code, the id's have a range of 1 ... 4, so there should be 4 sections at list index 0 ... 3, accessed by at(id - 1). The current patch adds 5 sections, and label at index 0 is never used.
Wed, Oct 10
Awesome. So it does (also) fix bug 360685?
Tue, Oct 9
@dfaure, worth a respin?
Mon, Oct 8
Converting int to float does not make lines appear at pixel centers. They need to be shifted by 0.5 pixels in each direction.
Sun, Oct 7
Kurt, please use 'git commit --author=...' to give proper attribution to patches from contributors.
Fri, Oct 5
There already is a separator (original line 202), but it is (for whatever reason) not always added. You can remove the if for the separator either in this commit, or in a separate patch, because it is unrelated to the addition of the Properties item.
Thu, Oct 4
No, the see the first 'screenshot' I added.
Maybe I should actually read the code ... I guess what I want is that you move the 'Properties' above the seperator, not after the 'Edit ...' entry.
Yes, I would prefer if the 'Hide' and 'Edit' entries are always preceeded by the separator, separating the items that act on the actual device and the items that act on the places entry.
Wed, Oct 3
Actually, I retract previous comment, it should be the last entry in the first section ('Open in ...'), and the separator that is shown above the 'Edit...' entry should also be visible when the 'Edit...' is hidden.
Should 'Properties' be last item in the menu?