vkrause (Volker Krause)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jul 29 2015, 8:38 AM (142 w, 6 d)
Availability
Available

Recent Activity

Yesterday

vkrause accepted D12484: Add TouristAttractionVisit.
Tue, Apr 24, 7:34 AM · KDE PIM

Sun, Apr 22

vkrause committed R81:ce24244bb8db: Display current data merged with already existing data in the calendar (authored by vkrause).
Display current data merged with already existing data in the calendar
Sun, Apr 22, 9:20 PM
vkrause committed R81:721bf0b170ba: Properly merge existing reservation data in the calendar (authored by vkrause).
Properly merge existing reservation data in the calendar
Sun, Apr 22, 1:41 PM
vkrause committed R81:3729748d642a: Rework data extraction (authored by vkrause).
Rework data extraction
Sun, Apr 22, 1:41 PM
vkrause committed R1003:0b164b5fc5e7: Attach the reservation object to the ical event (authored by vkrause).
Attach the reservation object to the ical event
Sun, Apr 22, 1:03 PM

Sat, Apr 21

vkrause committed R1003:80c16aa877c2: Deal with time-only values in the departureTime field (authored by vkrause).
Deal with time-only values in the departureTime field
Sat, Apr 21, 8:13 PM
vkrause committed R1003:394fca5b8a87: Gradually increase the desperation level when looking for structured data (authored by vkrause).
Gradually increase the desperation level when looking for structured data
Sat, Apr 21, 5:46 PM
vkrause committed R1003:f7c5b7e97402: Handle missing unique conditional section in IATA BCBP data (authored by vkrause).
Handle missing unique conditional section in IATA BCBP data
Sat, Apr 21, 4:11 PM
vkrause committed R1003:54c94ee72bf6: Break up person names into family and given name when possible (authored by vkrause).
Break up person names into family and given name when possible
Sat, Apr 21, 3:30 PM
vkrause committed R1003:34c40eb01ed1: Handle merging of codeshare flights (authored by vkrause).
Handle merging of codeshare flights
Sat, Apr 21, 12:22 PM
vkrause requested review of D12394: Distinguish between settings and explicit overrides for external content.
Sat, Apr 21, 9:51 AM · KDE PIM
vkrause requested review of D12393: Distinguish between settings and explicit override for external content.
Sat, Apr 21, 9:49 AM · KDE PIM
vkrause committed R1003:f6870cc79e5f: Merge duplicate entries during post-processing (authored by vkrause).
Merge duplicate entries during post-processing
Sat, Apr 21, 6:47 AM
vkrause committed R1003:e4f47b450ace: Prepare post-processor to accumulate and merge multiple data elements (authored by vkrause).
Prepare post-processor to accumulate and merge multiple data elements
Sat, Apr 21, 6:47 AM

Fri, Apr 20

vkrause requested review of D12391: Load external references in encrypted emails only on explicit request.
Fri, Apr 20, 9:38 PM · KDE PIM
vkrause committed R1003:29ff1a7d18f1: Explicitly take care of meta type registration (authored by vkrause).
Explicitly take care of meta type registration
Fri, Apr 20, 4:45 PM
vkrause committed R1003:f74823ce3a55: Remove some more old string-based property access (authored by vkrause).
Remove some more old string-based property access
Fri, Apr 20, 4:45 PM
vkrause committed R1003:762af1e73dbd: Try harder to find the boarding time in a pkpass file (authored by vkrause).
Try harder to find the boarding time in a pkpass file
Fri, Apr 20, 3:05 PM
vkrause committed R1003:a0ca2d5835b1: Support by-name property writes on concrete types (authored by vkrause).
Support by-name property writes on concrete types
Fri, Apr 20, 3:05 PM
vkrause committed R1003:3b6d1be5a355: Port flight processing to type-safe API (authored by vkrause).
Port flight processing to type-safe API
Fri, Apr 20, 3:05 PM

Tue, Apr 17

vkrause accepted D12269: Don't install plugins within lib on android.
Tue, Apr 17, 7:17 AM · Build System, Frameworks

Mon, Apr 16

vkrause accepted D12251: Integrate with androiddeployqt dependencies files.
Mon, Apr 16, 4:48 PM · Frameworks

Sun, Apr 15

vkrause committed R1003:d399b79cc0a2: Fix deserialization of integer values (authored by vkrause).
Fix deserialization of integer values
Sun, Apr 15, 9:48 AM
vkrause committed R1003:968df899b531: Document our deviations from schema.org (authored by vkrause).
Document our deviations from schema.org
Sun, Apr 15, 8:14 AM
vkrause committed R1003:9339340bce46: Silence runtime warnings to better see the actual test failures (authored by vkrause).
Silence runtime warnings to better see the actual test failures
Sun, Apr 15, 7:58 AM
vkrause committed R1003:9fe9a70e70e6: Fix unit tests after changing LodingBusiness to be an Organization (authored by vkrause).
Fix unit tests after changing LodingBusiness to be an Organization
Sun, Apr 15, 7:58 AM

Sat, Apr 14

vkrause committed R1003:4551a5518a3a: Make isValid/isEmpty for location types accessible to QML (authored by vkrause).
Make isValid/isEmpty for location types accessible to QML
Sat, Apr 14, 6:59 PM
vkrause committed R1003:f3cb0c1cdfb4: Silence unused parameter warning on Android (authored by vkrause).
Silence unused parameter warning on Android
Sat, Apr 14, 5:49 PM
vkrause committed R174:fc512cee665f: Remove unused D-Bus dependency (authored by vkrause).
Remove unused D-Bus dependency
Sat, Apr 14, 4:13 PM
vkrause closed D12198: Remove unused D-Bus dependency.
Sat, Apr 14, 4:13 PM · KDE PIM
vkrause requested review of D12198: Remove unused D-Bus dependency.
Sat, Apr 14, 4:09 PM · KDE PIM
vkrause committed R1003:063abf0effb2: Implement merging of restaurant reservations (authored by vkrause).
Implement merging of restaurant reservations
Sat, Apr 14, 3:43 PM
vkrause committed R1003:339d420f0cb1: Disambiguate Brussels airport (authored by vkrause).
Disambiguate Brussels airport
Sat, Apr 14, 3:12 PM
vkrause committed R1003:6e842332ad3e: Fix extraction of multi-leg trips (authored by vkrause).
Fix extraction of multi-leg trips
Sat, Apr 14, 3:12 PM
vkrause committed R1003:58fc445cfa5d: Fix entity replacement when encountering raw ampersands (authored by vkrause).
Fix entity replacement when encountering raw ampersands
Sat, Apr 14, 2:15 PM
vkrause committed R81:9dba3046bf58: Fix show on map action if both address and geo coordinates are present (authored by vkrause).
Fix show on map action if both address and geo coordinates are present
Sat, Apr 14, 11:57 AM
vkrause committed R1003:48b2773b489f: Add extractor for A&O hostel bookings (authored by vkrause).
Add extractor for A&O hostel bookings
Sat, Apr 14, 11:45 AM
vkrause committed R1003:8e4a0035948f: Also accept numeric properties encoded as strings (authored by vkrause).
Also accept numeric properties encoded as strings
Sat, Apr 14, 11:45 AM
vkrause committed R1003:5bd3998b9196: Fix double-free when re-using the extractor engine (authored by vkrause).
Fix double-free when re-using the extractor engine
Sat, Apr 14, 11:45 AM
vkrause committed R1003:73d52bcffd29: Don't stop after the first successful microdata extraction (authored by vkrause).
Don't stop after the first successful microdata extraction
Sat, Apr 14, 10:33 AM
vkrause committed R1003:448199bf355b: Fix wrongly encoded entities in URLs (authored by vkrause).
Fix wrongly encoded entities in URLs
Sat, Apr 14, 10:33 AM
vkrause committed R1003:a23c09bae4fc: Fix off-by-one error in leading garbage removal (authored by vkrause).
Fix off-by-one error in leading garbage removal
Sat, Apr 14, 10:33 AM
vkrause added a comment to D12172: Android: Also install plugins, otherwise they are just not available.
In D12172#245790, @apol wrote:

Yes, it's something I'd like to look into. I haven't found documentation for it yet.

Sat, Apr 14, 10:26 AM · Build System, Frameworks
vkrause accepted D12179: Make LodgingBusiness and FoodEstablishment inherit from Organization instead of Place.
Sat, Apr 14, 9:37 AM · KDE PIM

Fri, Apr 13

vkrause committed R1003:fe8e9200bc42: Add restaurant reservation data type (authored by vkrause).
Add restaurant reservation data type
Fri, Apr 13, 7:02 PM
vkrause committed R1003:2392ab56a705: Fix bogus airport name extraction for Swiss pkpass files (authored by vkrause).
Fix bogus airport name extraction for Swiss pkpass files
Fri, Apr 13, 7:02 PM
vkrause committed R81:3c7d6e69d964: Improve map actions (authored by vkrause).
Improve map actions
Fri, Apr 13, 6:20 PM
vkrause committed R81:7613bea1d2e4: Also consider pkpass attachments for extraction (authored by vkrause).
Also consider pkpass attachments for extraction
Fri, Apr 13, 5:35 PM
vkrause committed R1003:907594e49687: Correctly handle UTC times when converting to airport timezones (authored by vkrause).
Correctly handle UTC times when converting to airport timezones
Fri, Apr 13, 5:32 PM
vkrause added a comment to D12172: Android: Also install plugins, otherwise they are just not available.

For Qt < 5.12 this is ok as a temporary solution I think, but with the new androiddeployqt I'd rather add -android-dependencies.xml files for the libraries needing plugins (simple example: https://github.com/KDAB/GammaRay/blob/master/probe/gammaray_probe-android-dependencies.xml, more complex ones are part of Qt itself). Then you'll only get the plugins included that a library you (indirectly) use actually needs. That's much cleaner IMHO.

Fri, Apr 13, 2:12 PM · Build System, Frameworks
vkrause accepted D12150: Make it possible to build several apk out of a project.

I very much like that direction. I always found the need to specify platform-independent build properties explicitly on the command line weird, so anything moving towards being able to just write that into CMakeLists.txt is good :)
A module with cmake functions you call instead will then also make it easier to control apk generation in more detail by specifying additional parameters, so we can eventually disable the full copying of share and lib/qml.

Fri, Apr 13, 8:52 AM · Build System, Frameworks

Thu, Apr 12

vkrause committed R81:ac0468e54207: Switch to the KItinerary library (authored by vkrause).
Switch to the KItinerary library
Thu, Apr 12, 6:25 PM
vkrause closed D11932: Switch to the KItinerary library.
Thu, Apr 12, 6:25 PM · KDE PIM
vkrause committed R1003:1f7515577c41: Attempt microdata extraction even if it's behind unreadable garbage (authored by vkrause).
Attempt microdata extraction even if it's behind unreadable garbage
Thu, Apr 12, 5:09 PM
vkrause accepted D12120: Check if the application androiddeployqt package has a main() symbol.

Just tested that my 64bit host nm can also consume 32bit ARM binaries, seems to work, so not using the corresponding toolchain nm is probably fine here.

Thu, Apr 12, 7:36 AM · Build System, Frameworks

Wed, Apr 11

vkrause committed R1003:583ba0fba524: Reduce template bloat (authored by vkrause).
Reduce template bloat
Wed, Apr 11, 4:44 PM
vkrause committed R1003:4f3ba0171ca8: Fix de-serialization of Person objects (authored by vkrause).
Fix de-serialization of Person objects
Wed, Apr 11, 4:44 PM
vkrause accepted D11984: Android: Explicitly point at upstream documentation and deprecate duplicated concepts.

Builds fine here, and moving closer to the Android cmake files makes sense IMHO.

Wed, Apr 11, 7:34 AM · Build System, Frameworks

Tue, Apr 10

vkrause committed R1003:3b3b901f05ab: Fix non-closed <link> tags too (authored by vkrause).
Fix non-closed <link> tags too
Tue, Apr 10, 6:45 PM
vkrause committed R1003:8cc50ee9524f: Move the export macro to the right spot (authored by vkrause).
Move the export macro to the right spot
Tue, Apr 10, 11:20 AM

Mon, Apr 9

vkrause committed R1003:ab7ed44266ce: Install IATA BCBP parser (authored by vkrause).
Install IATA BCBP parser
Mon, Apr 9, 8:08 PM

Sun, Apr 8

vkrause committed R1003:c285f5766c24: Port most of CalendarHandler to use the type-safe property access (authored by vkrause).
Port most of CalendarHandler to use the type-safe property access
Sun, Apr 8, 3:30 PM
vkrause committed R1003:fb83a27a1238: Hide implementation details (authored by vkrause).
Hide implementation details
Sun, Apr 8, 3:30 PM
vkrause committed R1003:e248ee311b5c: Parse boarding pass issue date in IATA BCBP data (authored by vkrause).
Parse boarding pass issue date in IATA BCBP data
Sun, Apr 8, 10:16 AM
vkrause committed R1003:f9545bf3e4bc: Add variant to base class conversion helper functions (authored by vkrause).
Add variant to base class conversion helper functions
Sun, Apr 8, 9:33 AM
vkrause committed R1003:27824b145cc7: Make data types implicitly convertible to QVariant (authored by vkrause).
Make data types implicitly convertible to QVariant
Sun, Apr 8, 9:33 AM
vkrause committed R1003:a079cf304ccc: Rename LodingReservation::check[in|out]Date (authored by vkrause).
Rename LodingReservation::check[in|out]Date
Sun, Apr 8, 9:33 AM

Sat, Apr 7

vkrause committed R1003:ce9a8675c567: Fix IATA BCBP parsing when eticket indicator is missing (authored by vkrause).
Fix IATA BCBP parsing when eticket indicator is missing
Sat, Apr 7, 9:35 PM
vkrause committed R1003:e2b5f887bb40: Implement merging of bus reservations (authored by vkrause).
Implement merging of bus reservations
Sat, Apr 7, 8:16 PM
vkrause committed R1003:29d5b45c2e7c: Implement hotel reservation merging (authored by vkrause).
Implement hotel reservation merging
Sat, Apr 7, 7:21 PM
vkrause committed R1003:80bf4f180e82: Fully qualify namespaced property types (authored by vkrause).
Fully qualify namespaced property types
Sat, Apr 7, 4:35 PM
vkrause committed R1003:d85feacfac21: Implement merging of train trips (authored by vkrause).
Implement merging of train trips
Sat, Apr 7, 4:35 PM
vkrause committed R1003:442a3d50cd6b: Add departure terminal property (authored by vkrause).
Add departure terminal property
Sat, Apr 7, 1:34 PM
vkrause committed R499:9b26821a80e4: Add dependencies for KItinerary (authored by vkrause).
Add dependencies for KItinerary
Sat, Apr 7, 8:12 AM

Fri, Apr 6

vkrause committed R1003:72afaa339a84: Translate TrainTrip::trainCompany to TrainTrip::provider (authored by vkrause).
Translate TrainTrip::trainCompany to TrainTrip::provider
Fri, Apr 6, 8:07 PM
vkrause committed R1003:c3afac740141: Add an import filter for JsonLdDocument::fromJson (authored by vkrause).
Add an import filter for JsonLdDocument::fromJson
Fri, Apr 6, 7:46 PM
vkrause committed R1003:6a29c86f99a1: Inherit Airline from Organization (authored by vkrause).
Inherit Airline from Organization
Fri, Apr 6, 6:14 PM
vkrause committed R1003:2625b83a13bb: Fix bus reservation inheritance (authored by vkrause).
Fix bus reservation inheritance
Fri, Apr 6, 4:18 PM
vkrause committed R1003:b3748b39196e: Hide d pointers from API docs (authored by vkrause).
Hide d pointers from API docs
Fri, Apr 6, 4:18 PM
vkrause committed R1003:6ed666613b2d: Provide i18n context for a pure placeholder string (authored by vkrause).
Provide i18n context for a pure placeholder string
Fri, Apr 6, 9:10 AM
vkrause accepted D11974: Add more datatypes.

Simplifying the inheritance is perfectly fine, we do that in a number of other places too (e.g. we don't use "Thing"), let's just make this as complex as absolutely necessary.

Fri, Apr 6, 8:07 AM · KDE PIM

Thu, Apr 5

vkrause committed R1003:94acd77659f9: Fix inheritance for hotels and bus stations (authored by vkrause).
Fix inheritance for hotels and bus stations
Thu, Apr 5, 5:40 PM
vkrause committed R1003:9c63cce19da6: Try to further improve API docs for basic data types (authored by vkrause).
Try to further improve API docs for basic data types
Thu, Apr 5, 5:40 PM
vkrause added a comment to D11932: Switch to the KItinerary library.

mmh this is not very easy to see what are the changes. Because of the many files disappearing.
I found 8 files that are touched and not deleted. Looks fine so far.

But please next time split the review request into one, that is worth looking and only mention that you will delete files.

Thu, Apr 5, 7:26 AM · KDE PIM
vkrause accepted D11935: Wire up Organization in other data types.
Thu, Apr 5, 7:21 AM · KDE PIM

Wed, Apr 4

vkrause requested review of D11932: Switch to the KItinerary library.
Wed, Apr 4, 7:41 PM · KDE PIM
vkrause committed R1003:f67370620d61: Hide airport db internals and properly expand the value type properties (authored by vkrause).
Hide airport db internals and properly expand the value type properties
Wed, Apr 4, 6:30 PM
vkrause committed R1003:330aa7eec148: Namespace the airport database code too (authored by vkrause).
Namespace the airport database code too
Wed, Apr 4, 6:30 PM
vkrause committed R1003:9ecd7c7583ac: Use KDE PIM versioning (authored by vkrause).
Use KDE PIM versioning
Wed, Apr 4, 4:56 PM
vkrause committed R81:7026f9ecbce2: Switch the pkpass formatter plugin to use KPkPass (authored by vkrause).
Switch the pkpass formatter plugin to use KPkPass
Wed, Apr 4, 11:01 AM
vkrause closed D11830: Switch the pkpass formatter plugin to use KPkPass.
Wed, Apr 4, 11:01 AM · KDE PIM
vkrause accepted D11910: Add support for Organization.
Wed, Apr 4, 7:45 AM · KDE PIM
vkrause added a comment to D11910: Add support for Organization.

Thanks! This can go in as-is.

Wed, Apr 4, 6:58 AM · KDE PIM

Tue, Apr 3

vkrause updated the diff for D11830: Switch the pkpass formatter plugin to use KPkPass.

Remove no longer needed sharedmimeinfo dependency.

Tue, Apr 3, 6:51 AM · KDE PIM
vkrause added inline comments to D11830: Switch the pkpass formatter plugin to use KPkPass.
Tue, Apr 3, 6:49 AM · KDE PIM

Mon, Apr 2

vkrause accepted D11887: No need to enable CMAKE_AUTOMOC manually.
Mon, Apr 2, 8:32 PM · KDE PIM
vkrause accepted D11886: pkpassextractortest: Use QTEST_GUILESS_MAIN.
Mon, Apr 2, 8:32 PM · KDE PIM
vkrause accepted D11885: No need to enable CMAKE_AUTOMOC manually.
Mon, Apr 2, 8:32 PM · KDE PIM
vkrause committed R1003:e90333caf3e3: Provide context date to the post-processor too (authored by vkrause).
Provide context date to the post-processor too
Mon, Apr 2, 4:55 PM
vkrause committed R1003:f92ff3d99c43: Introduce Flight::departureDay (authored by vkrause).
Introduce Flight::departureDay
Mon, Apr 2, 4:38 PM