vkrause (Volker Krause)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 29 2015, 8:38 AM (120 w, 2 d)
Availability
Available

Recent Activity

Mon, Nov 13

vkrause accepted D8570: Move attachment handling to renderer..
Mon, Nov 13, 6:10 PM · KDE PIM
vkrause accepted D8573: get rid of objectTreeParser()->showOnlyOneMimePart().
Mon, Nov 13, 6:09 PM · KDE PIM
vkrause accepted D8620: drawFrame is a property of the renderer and not of the parser.
Mon, Nov 13, 6:09 PM · KDE PIM
vkrause accepted D8621: embed hidden parts, if they have a cid link..
Mon, Nov 13, 6:07 PM · KDE PIM
vkrause accepted D8790: Add FindSasl2.cmake to ECM.
Mon, Nov 13, 5:00 PM · KDE PIM, Build System, Frameworks
vkrause moved T6716: Fix native kauth-policy-gen build for KAuth from In Progress to Done on the KDE Yocto board.
Mon, Nov 13, 4:52 PM · KDE Yocto
vkrause committed R283:af4f0052f1ef: Allow to only build the kauth-policy-gen code generator (authored by vkrause).
Allow to only build the kauth-policy-gen code generator
Mon, Nov 13, 4:52 PM
vkrause closed D7274: Allow to only build the kauth-policy-gen code generator.
Mon, Nov 13, 4:52 PM · Frameworks
vkrause accepted D8782: add *.email to the extensions.

Not an extension I have ever encountered, but it's conflict-free with everything else we have, so that should be fine.

Mon, Nov 13, 1:06 PM · Frameworks

Sun, Nov 12

vkrause committed R868:33adeb86c6ea: Update to KF5 5.40.0 (authored by vkrause).
Update to KF5 5.40.0
Sun, Nov 12, 12:19 PM
vkrause updated the diff for D7274: Allow to only build the kauth-policy-gen code generator.

Integrate review feedback.

Sun, Nov 12, 12:17 PM · Frameworks

Sat, Nov 11

vkrause updated the diff for D8546: Add Aztec code generator.

Fix off-by-one inconsistency in layerCount

Sat, Nov 11, 9:57 PM · Frameworks
vkrause committed R81:c7b61377d6fe: Add show calendar action (authored by vkrause).
Add show calendar action
Sat, Nov 11, 6:01 PM
vkrause committed R81:2d06a92e2dbb: Allow to add reservations to the calendar (authored by vkrause).
Allow to add reservations to the calendar
Sat, Nov 11, 6:01 PM
vkrause committed R81:6dc80098e7fc: Store parsed result, not the raw JSON-LD (authored by vkrause).
Store parsed result, not the raw JSON-LD
Sat, Nov 11, 6:01 PM
vkrause updated the diff for D8546: Add Aztec code generator.

Adapt to review comments.

Sat, Nov 11, 1:27 PM · Frameworks
vkrause committed R81:4a9f8d856f47: Add semantic data extraction plugin (authored by vkrause).
Add semantic data extraction plugin
Sat, Nov 11, 11:58 AM
vkrause closed D8583: Add semantic data extraction plugin.
Sat, Nov 11, 11:58 AM · KDE PIM
vkrause added a comment to D7274: Allow to only build the kauth-policy-gen code generator.

ping?

Sat, Nov 11, 11:03 AM · Frameworks

Fri, Nov 10

vkrause accepted D8662: Validate that for all attributes an itemData exists.
Fri, Nov 10, 10:25 AM · Frameworks
vkrause added inline comments to D8546: Add Aztec code generator.
Fri, Nov 10, 10:17 AM · Frameworks

Sat, Nov 4

vkrause updated the diff for D8583: Add semantic data extraction plugin.

Localize/format flight and checkin/checkout times.

Sat, Nov 4, 2:32 PM · KDE PIM
vkrause committed R81:e966ff79c14a: Handle boarding passes using a barcode array (authored by vkrause).
Handle boarding passes using a barcode array
Sat, Nov 4, 2:08 PM
vkrause added a comment to D8583: Add semantic data extraction plugin.

No commited ?:)

Sat, Nov 4, 2:06 PM · KDE PIM

Thu, Nov 2

vkrause committed R94:e9826c36f77b: Probe attachment mimetypes ourselves when there's doubt (authored by vkrause).
Probe attachment mimetypes ourselves when there's doubt
Thu, Nov 2, 6:27 PM
vkrause closed D8551: Probe attachment mimetypes ourselves when there's doubt.
Thu, Nov 2, 6:27 PM · KDE PIM

Wed, Nov 1

vkrause added inline comments to D8583: Add semantic data extraction plugin.
Wed, Nov 1, 8:52 PM · KDE PIM
vkrause updated the diff for D8583: Add semantic data extraction plugin.

addressed review comments, added basic support for hotel booking confirmations

Wed, Nov 1, 8:51 PM · KDE PIM
vkrause committed R180:9d0159b4dddb: Do not clear parameters when changing the mimetype of a Content-Type header (authored by vkrause).
Do not clear parameters when changing the mimetype of a Content-Type header
Wed, Nov 1, 4:44 PM
vkrause closed D8568: Do not clear parameters when changing the mimetype of a Content-Type header.
Wed, Nov 1, 4:44 PM · KDE PIM
vkrause accepted D8591: Make Composer page in KMail->Settings fully translated.
Wed, Nov 1, 2:02 PM · KDE PIM
vkrause accepted D8584: move DefaultRendererPrivate into MessageViewer namespace.
Wed, Nov 1, 8:14 AM · KDE PIM

Tue, Oct 31

vkrause added inline comments to D8570: Move attachment handling to renderer..
Tue, Oct 31, 5:56 PM · KDE PIM
vkrause added inline comments to D8573: get rid of objectTreeParser()->showOnlyOneMimePart().
Tue, Oct 31, 5:55 PM · KDE PIM
vkrause accepted D8575: move HtmlWriter from MimeTreeParser->MessageViewer.
Tue, Oct 31, 5:55 PM · KDE PIM
vkrause accepted D8574: move AttachmentStrategy from MimeTreeParser -> MessageViewer.
Tue, Oct 31, 5:51 PM · KDE PIM
vkrause accepted D8572: Remove ObjectTreeParser::attachmentStrategy.
Tue, Oct 31, 5:42 PM · KDE PIM
vkrause accepted D8571: delete BodyPart::defaultDisplay, that is not used from any plugin..
Tue, Oct 31, 5:42 PM · KDE PIM
vkrause added a comment to D8568: Do not clear parameters when changing the mimetype of a Content-Type header.

that is a behaviour change - did you check what parts use this code and may rely on the cleaning? The other solution would fix magicSetType to store all paramenters before and reset afterwards.

Tue, Oct 31, 5:38 PM · KDE PIM
vkrause created D8583: Add semantic data extraction plugin.
Tue, Oct 31, 5:34 PM · KDE PIM
vkrause updated the diff for D8551: Probe attachment mimetypes ourselves when there's doubt.

Persist the probed mimetype, which simplifies things considerably.
Needs D8568 to work correctly in all cases.

Tue, Oct 31, 11:35 AM · KDE PIM
vkrause created D8568: Do not clear parameters when changing the mimetype of a Content-Type header.
Tue, Oct 31, 11:33 AM · KDE PIM
vkrause added inline comments to D8551: Probe attachment mimetypes ourselves when there's doubt.
Tue, Oct 31, 11:11 AM · KDE PIM
vkrause committed R94:473ae7fe48ed: Remove unused parameter (authored by vkrause).
Remove unused parameter
Tue, Oct 31, 10:41 AM

Mon, Oct 30

vkrause created D8551: Probe attachment mimetypes ourselves when there's doubt.
Mon, Oct 30, 10:35 AM · KDE PIM

Sun, Oct 29

vkrause committed R868:03f127aa53b5: Add package group for all of KF5 (authored by vkrause).
Add package group for all of KF5
Sun, Oct 29, 7:05 PM
vkrause committed R868:26733d6bfe07: Move more common file patterns to the KF5 class (authored by vkrause).
Move more common file patterns to the KF5 class
Sun, Oct 29, 6:31 PM
vkrause committed R868:aa85f0a19182: Move handling of D-Bus files to the KF5 class (authored by vkrause).
Move handling of D-Bus files to the KF5 class
Sun, Oct 29, 6:16 PM
vkrause committed R868:9b6eddf5fa93: Add QQC2 Desktop Style recipe (authored by vkrause).
Add QQC2 Desktop Style recipe
Sun, Oct 29, 5:13 PM
vkrause added a revision to T6715: Add cross compilation support for breeze-icons QRC generator: D8427: Allow cross compiling resource file.
Sun, Oct 29, 5:12 PM · KDE Yocto
vkrause added a task to D8427: Allow cross compiling resource file: T6715: Add cross compilation support for breeze-icons QRC generator.
Sun, Oct 29, 5:12 PM · Kdenlive, Frameworks
vkrause moved T6612: Script KF5 updating from In Progress to Done on the KDE Yocto board.
Sun, Oct 29, 5:10 PM · KDE Yocto
vkrause committed R868:47aef2fa5fc8: Update to KF 5.39.0 (authored by vkrause).
Update to KF 5.39.0
Sun, Oct 29, 5:00 PM
vkrause committed R868:6d65f41ac7d7: Also add changes to Git in the update script (authored by vkrause).
Also add changes to Git in the update script
Sun, Oct 29, 4:59 PM
vkrause committed R81:c138c8918e50: Register the Apple Wallet pass mimetype (authored by vkrause).
Register the Apple Wallet pass mimetype
Sun, Oct 29, 4:17 PM
vkrause committed R81:5caed13fdac4: Escape line breaks in back field values (authored by vkrause).
Escape line breaks in back field values
Sun, Oct 29, 4:17 PM
vkrause committed R81:ab79317caa16: Add padding around barcodes (authored by vkrause).
Add padding around barcodes
Sun, Oct 29, 4:17 PM
vkrause committed R81:f4e03e92bd84: Fix barcode size computation (authored by vkrause).
Fix barcode size computation
Sun, Oct 29, 4:17 PM
vkrause committed R81:471baccc5c26: Fix parsing UTF-8 encoded message catalogs (authored by vkrause).
Fix parsing UTF-8 encoded message catalogs
Sun, Oct 29, 4:17 PM
vkrause created D8546: Add Aztec code generator.
Sun, Oct 29, 3:26 PM · Frameworks
vkrause committed R81:57edf8f487e8: Add support for rendering Apple Wallet boarding passes (authored by vkrause).
Add support for rendering Apple Wallet boarding passes
Sun, Oct 29, 1:14 PM
vkrause closed D8395: Add support for rendering Apple Wallet boarding passes.
Sun, Oct 29, 1:14 PM · KDE PIM

Thu, Oct 26

vkrause added a comment to D8395: Add support for rendering Apple Wallet boarding passes.

Just one thing, does the fileformat knows in what language is the text? I'm thinking about languages that are right-to-left...

Thu, Oct 26, 9:17 AM · KDE PIM
vkrause accepted D8451: JavaScript: include standard mime types.

please also bump the version number

Thu, Oct 26, 9:10 AM · Frameworks

Sun, Oct 22

vkrause added a comment to D8395: Add support for rendering Apple Wallet boarding passes.

The colors are entirely provided by the pkpass file, so the host color scheme doesn't matter. The only exception is the barcode area, which is defined to be black on white for obvious reasons.

Sun, Oct 22, 8:14 AM · KDE PIM

Sat, Oct 21

vkrause created D8395: Add support for rendering Apple Wallet boarding passes.
Sat, Oct 21, 10:47 AM · KDE PIM

Oct 18 2017

vkrause added a comment to D8353: Resolve body part URL handlers based on part mimetype.

This makes sense and looks good to me. I still fail to understand why this worked before though, I just moved this code to a different location :)
Mapping this to the render plugin that was used is tricky, as we do not persist that information, nor will it always be a single plugin responsible for drawing one part, so I think the mimetype approach works well for this.

Wait we know excatly, that a plugin was used for one email, when DefaultRendererPrivate::renderWithFactory retruns true. So adding afterwarts the loading for URLHandler here would result in the correct URLHandlers loaded. This was done before too.

Oct 18 2017, 5:01 PM · KDE PIM
vkrause accepted D8353: Resolve body part URL handlers based on part mimetype.

This makes sense and looks good to me. I still fail to understand why this worked before though, I just moved this code to a different location :)

Oct 18 2017, 3:26 PM · KDE PIM

Oct 15 2017

vkrause committed R81:1ac1a5a7eafe: Turn the diff plugin into a generic syntax highlighting plugin (authored by vkrause).
Turn the diff plugin into a generic syntax highlighting plugin
Oct 15 2017, 12:10 PM
vkrause closed D8192: Turn the diff plugin into a generic syntax highlighting plugin.
Oct 15 2017, 12:10 PM · KDE PIM
vkrause committed R94:5776a48bcbb4: Allow more control over render plugin loading (authored by vkrause).
Allow more control over render plugin loading
Oct 15 2017, 12:09 PM
vkrause committed R94:1bfd5b8c6a9a: Remove no longer valid warnings (authored by vkrause).
Remove no longer valid warnings
Oct 15 2017, 12:09 PM
vkrause committed R94:2384b7a0c212: Remove unused methods in BodyPart (authored by vkrause).
Remove unused methods in BodyPart
Oct 15 2017, 12:09 PM
vkrause committed R94:5d6066121c80: Improve render plugin selection (authored by vkrause).
Improve render plugin selection
Oct 15 2017, 12:06 PM
vkrause closed D8195: Improve render plugin selection.
Oct 15 2017, 12:06 PM · KDE PIM
vkrause committed R94:c12692c95d4e: Remove the now no longer used legacy rendering infrastructure (authored by vkrause).
Remove the now no longer used legacy rendering infrastructure
Oct 15 2017, 12:05 PM
vkrause closed D8190: Remove the now no longer used legacy rendering infrastructure.
Oct 15 2017, 12:05 PM · KDE PIM
vkrause committed R81:b50a08170d4b: Port the WKS formatter to the new rendering API (authored by vkrause).
Port the WKS formatter to the new rendering API
Oct 15 2017, 9:57 AM
vkrause closed D8189: Port the WKS formatter to the new rendering API.
Oct 15 2017, 9:57 AM · KDE PIM
vkrause committed R81:c79e2f04320a: Port the GPG key formatter to the new render plugin API (authored by vkrause).
Port the GPG key formatter to the new render plugin API
Oct 15 2017, 9:57 AM
vkrause closed D8183: Port the GPG key formatter to the new render plugin API.
Oct 15 2017, 9:57 AM · KDE PIM
vkrause committed R81:ca579a8aa0fb: Port iCal plugin to new render plugin API (authored by vkrause).
Port iCal plugin to new render plugin API
Oct 15 2017, 9:56 AM
vkrause closed D8181: Port iCal plugin to new render plugin API.
Oct 15 2017, 9:56 AM · KDE PIM
vkrause committed R81:9205588f811b: Port vcard plugin to the new render plugin API (authored by vkrause).
Port vcard plugin to the new render plugin API
Oct 15 2017, 9:56 AM
vkrause closed D8180: Port vcard plugin to the new render plugin API.
Oct 15 2017, 9:56 AM · KDE PIM
vkrause committed R81:75442b236796: Move URL handlers to the new plugin interface (authored by vkrause).
Move URL handlers to the new plugin interface
Oct 15 2017, 9:50 AM
vkrause closed D8176: Move URL handlers to the new plugin interface.
Oct 15 2017, 9:50 AM · KDE PIM
vkrause committed R94:74904c4c593e: Extend MessagePart API as needed for porting the vcard plugin (authored by vkrause).
Extend MessagePart API as needed for porting the vcard plugin
Oct 15 2017, 9:49 AM
vkrause closed D8179: Extend MessagePart API as needed for porting the vcard plugin.
Oct 15 2017, 9:49 AM · KDE PIM
vkrause committed R94:1fb129aa73c2: Move URL handling from the processing to the rendering plugin (authored by vkrause).
Move URL handling from the processing to the rendering plugin
Oct 15 2017, 9:36 AM
vkrause closed D8175: Move URL handling from the processing to the rendering plugin.
Oct 15 2017, 9:36 AM · KDE PIM
vkrause committed R81:35d1d8615ad0: Port TNEF plugin to new rendering plugin API (authored by vkrause).
Port TNEF plugin to new rendering plugin API
Oct 15 2017, 9:34 AM
vkrause closed D8171: Port TNEF plugin to new rendering plugin API.
Oct 15 2017, 9:34 AM · KDE PIM

Oct 14 2017

vkrause committed R94:b02241748845: Extend MessagePart API as needed for the TNEF plugin (authored by vkrause).
Extend MessagePart API as needed for the TNEF plugin
Oct 14 2017, 10:09 AM
vkrause closed D8170: Extend MessagePart API as needed for the TNEF plugin.
Oct 14 2017, 10:09 AM · KDE PIM
vkrause accepted D8290: Remove more memory allocations during header parsing.
Oct 14 2017, 10:07 AM · KDE PIM
vkrause committed R78:b4f2311f85d9: Fix another CI breakage due to QStringLiteral lambdas inside Q_FOREACH (authored by vkrause).
Fix another CI breakage due to QStringLiteral lambdas inside Q_FOREACH
Oct 14 2017, 10:00 AM
vkrause committed R81:b00588ed5f55: Adapt diff plugin to the new renderer plugin interface (authored by vkrause).
Adapt diff plugin to the new renderer plugin interface
Oct 14 2017, 9:54 AM
vkrause closed D8122: Adapt diff plugin to the new renderer plugin interface.
Oct 14 2017, 9:53 AM · KDE PIM
vkrause added a comment to D8245: Optimize parsing headers.

Yep, exactly. QByteArrayView would address this too, but that's still a long way out.

Oct 14 2017, 9:26 AM · KDE PIM