vkrause (Volker Krause)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jul 29 2015, 8:38 AM (219 w, 5 d)
Availability
Available

Recent Activity

Today

vkrause added a comment to D24590: Port KSslErrorUiData to QSslError.

Do we have tests for the thing you discovered breaks? Do we need them?

Mon, Oct 14, 7:34 AM · Frameworks

Yesterday

vkrause moved T11590: Remove kdesignerplugin from Backlog to Waiting on the KF6 board.
Sun, Oct 13, 1:22 PM · KF6
vkrause added a comment to T11590: Remove kdesignerplugin.

The only one remaining I can find (locally and with lxr) is kdelibs4support, which of course makes no sense to port. So I think this is done apart from the actual deletion.

Sun, Oct 13, 1:20 PM · KF6
vkrause updated the task description for T11864: Integrate KQuickSyntaxHighlighter into KSyntaxHighlighting.
Sun, Oct 13, 1:14 PM · KF6
vkrause committed R1003:4a3054fd586b: Add ÖBB extractor script to show access to UIC 918.3 vendor blocks in JS (authored by vkrause).
Add ÖBB extractor script to show access to UIC 918.3 vendor blocks in JS
Sun, Oct 13, 11:13 AM
vkrause committed R1003:a0750e3deca2: Make UIC 918.3 blocks accessible for JavaScript (authored by vkrause).
Make UIC 918.3 blocks accessible for JavaScript
Sun, Oct 13, 11:13 AM
vkrause committed R1003:074f0442c2f1: Merge branch 'Applications/19.08' (authored by vkrause).
Merge branch 'Applications/19.08'
Sun, Oct 13, 10:51 AM
vkrause committed R1003:0f8b2babcc69: Fix compatibility with Poppler 0.82 (authored by vkrause).
Fix compatibility with Poppler 0.82
Sun, Oct 13, 10:51 AM
vkrause committed R1003:7e0e66911e64: Better end time default for restaurant reservations without an end time (authored by vkrause).
Better end time default for restaurant reservations without an end time
Sun, Oct 13, 10:51 AM
vkrause committed R1003:69aafbe11aec: Simplify VGN extractor by using the new Context properties (authored by vkrause).
Simplify VGN extractor by using the new Context properties
Sun, Oct 13, 10:51 AM
vkrause added a comment to T11848: Devices.

My RPI3 with the Yocto-based Plasma Mobile isn't in the best state as you saw at Akademy, and updating it is somewhat blocked by support for the DSI display being broken upstream currently, ie. the best I can offer is the old version from around FOSDEM 2019. HDMI output works fine still, but I don't have a HDMI touch screen.

Sun, Oct 13, 9:14 AM · KDE Promo
vkrause accepted D24603: Port away from deprecated KDELibs4Support.

Thanks!

Sun, Oct 13, 9:11 AM · Plasma
vkrause added a comment to D24588: [SslUi] Add api docs for askIgnoreSslErrors().

Hmm, why not just do KSslErrorUiData uiData(socket); in the caller, or even just askIgnoreSslErrors(KSslErrorUiData(socket), storedRules).
Don't know, just wondering (not objecting). @vkrause, any opinion?

Sun, Oct 13, 9:09 AM · Frameworks
vkrause updated the diff for D24590: Port KSslErrorUiData to QSslError.

Deal with errors with full QSslError level of detail until kssld is ported, make variables const.

Sun, Oct 13, 9:06 AM · Frameworks
vkrause planned changes to D24590: Port KSslErrorUiData to QSslError.

This actually breaks things when the error comes from a Qt source rather than a KIO one, as we now carry the QSslError level of detail forward far enough and compare it to the stored KSslError. This is a temporary problem until the kssld side is ported too, but it nevertheless needs a workaround until that is done.

Sun, Oct 13, 8:57 AM · Frameworks

Sat, Oct 12

vkrause added a comment to T11865: Deprecate KIconTheme::assignIconsToContextMenu.

Upstream fix: https://codereview.qt-project.org/c/qt/qtbase/+/277245

Sat, Oct 12, 3:02 PM · KF6
vkrause created T11865: Deprecate KIconTheme::assignIconsToContextMenu.
Sat, Oct 12, 2:45 PM · KF6
vkrause committed R247:1ba97bfd4037: Move KPublicTransport to kdereview (authored by vkrause).
Move KPublicTransport to kdereview
Sat, Oct 12, 11:27 AM
vkrause added a revision to T11620: Port from KSslError to QSslError: D24590: Port KSslErrorUiData to QSslError.
Sat, Oct 12, 10:35 AM · KF6
vkrause added a task to D24590: Port KSslErrorUiData to QSslError: T11620: Port from KSslError to QSslError.
Sat, Oct 12, 10:35 AM · Frameworks
vkrause requested review of D24590: Port KSslErrorUiData to QSslError.
Sat, Oct 12, 10:35 AM · Frameworks
vkrause committed R241:41a209b2b6ce: Implement KSslCertificateRule with QSslError instead of KSslError (authored by vkrause).
Implement KSslCertificateRule with QSslError instead of KSslError
Sat, Oct 12, 10:26 AM
vkrause closed D24419: Implement KSslCertificateRule with QSslError instead of KSslError.
Sat, Oct 12, 10:26 AM · Frameworks
vkrause accepted D24574: packagegroup-kde-frameworks5: Rename to be a packagegroup.
Sat, Oct 12, 10:25 AM
vkrause committed R241:524023533886: Port (most of) the interface of KSslCertificateRule to QSslError (authored by vkrause).
Port (most of) the interface of KSslCertificateRule to QSslError
Sat, Oct 12, 10:23 AM
vkrause closed D24382: Port (most of) the interface of KSslCertificateRule to QSslError.
Sat, Oct 12, 10:23 AM · Frameworks
vkrause updated the diff for D24382: Port (most of) the interface of KSslCertificateRule to QSslError.

bump version number to 5.64

Sat, Oct 12, 10:22 AM · Frameworks
vkrause created T11864: Integrate KQuickSyntaxHighlighter into KSyntaxHighlighting.
Sat, Oct 12, 10:19 AM · KF6
vkrause committed R241:4bfbdad31fdc: Port KSslCertificateManager to QSslError (authored by vkrause).
Port KSslCertificateManager to QSslError
Sat, Oct 12, 10:10 AM
vkrause closed D24294: Port KSslCertificateManager to QSslError.
Sat, Oct 12, 10:10 AM · Frameworks
vkrause updated the diff for D24294: Port KSslCertificateManager to QSslError.

bump version to 5.64

Sat, Oct 12, 10:10 AM · Frameworks

Fri, Oct 11

vkrause accepted D24569: packagegroup-plasma-mobile: Rename to be a packagegroup.
Fri, Oct 11, 8:25 PM
vkrause accepted D24566: layer.conf: Mark zeus as supported.
Fri, Oct 11, 6:50 PM
vkrause accepted D24565: layer.conf: Mark zeus as supported.
Fri, Oct 11, 6:50 PM
vkrause added a comment to D24537: Icons for windy weather.

Nice! We use the Breeze weather icons in KDE Itinerary too, based on api.met.no data, but so far didn't make use of the wind information in there yet.

Fri, Oct 11, 3:24 PM · Frameworks
vkrause added a comment to D24382: Port (most of) the interface of KSslCertificateRule to QSslError.

ping?

Fri, Oct 11, 2:58 PM · Frameworks
vkrause committed R490:9629a5eff5b8: Unbreak Qt 5.11 build (authored by vkrause).
Unbreak Qt 5.11 build
Fri, Oct 11, 10:43 AM
vkrause accepted D24553: Fix finding trams in Würzburg.

Seems to work, and conceptually this makes sense, we don't want to have any product filter active. I suspect it's a leftover I didn't catch when bisecting which of the settings are actually mandatory to get useful a response.

Fri, Oct 11, 7:43 AM

Thu, Oct 10

vkrause committed R1003:412cd98357af: Deduplicate generic PDF extraction results by barcode (authored by vkrause).
Deduplicate generic PDF extraction results by barcode
Thu, Oct 10, 4:24 PM
vkrause committed R1003:1393b2567df8: Add flag to convert PDF images to grayscale during loading already (authored by vkrause).
Add flag to convert PDF images to grayscale during loading already
Thu, Oct 10, 4:24 PM

Wed, Oct 9

vkrause committed R1003:ec24147a7761: Add Indigo boarding pass extractor script (authored by vkrause).
Add Indigo boarding pass extractor script
Wed, Oct 9, 4:43 PM
vkrause committed R1003:2d9e1de6121e: Add a flag to abort loading PDF images when encountering colored pixels (authored by vkrause).
Add a flag to abort loading PDF images when encountering colored pixels
Wed, Oct 9, 4:43 PM
vkrause closed D24380: Explicitly define the Journal copy ctor.
Wed, Oct 9, 4:13 PM

Tue, Oct 8

vkrause accepted D24482: telepathy-qt: Use Python3 native.
Tue, Oct 8, 7:21 AM
vkrause added a reviewer for D24443: Add a plugin system: KDE PIM.
Tue, Oct 8, 7:18 AM
vkrause added a comment to D24443: Add a plugin system.
  • Is KDeclarative is the right place for this? It's a module on the way out in KF6, it is hard to build for Android due to its dependency chain (which isn't even needed for this), while at the same time forcing ABI stability on this basically immediately without much chance for battle testing this.
Tue, Oct 8, 7:18 AM

Mon, Oct 7

vkrause committed R490:a7400a8e70a0: Remove the PROTOCOL_COUNT enum value (authored by vkrause).
Remove the PROTOCOL_COUNT enum value
Mon, Oct 7, 7:29 PM
vkrause committed R1003:90c33ad7c7f6: Use PDF creation/modification dates as context date when available too (authored by vkrause).
Use PDF creation/modification dates as context date when available too
Mon, Oct 7, 6:59 PM
vkrause committed R1032:29fb4c50cdc6: Fix Location type registering (authored by vkrause).
Fix Location type registering
Mon, Oct 7, 5:30 PM
vkrause added a comment to D24294: Port KSslCertificateManager to QSslError.
In D24294#543158, @apol wrote:

I may be missing some context but this doesn't seem to be porting anything only adding a nonIgnorableErrors function that ignores whatever it gets.

Mon, Oct 7, 4:54 PM · Frameworks
vkrause added a task to D24419: Implement KSslCertificateRule with QSslError instead of KSslError: T11620: Port from KSslError to QSslError.
Mon, Oct 7, 4:52 PM · Frameworks
vkrause added a revision to T11620: Port from KSslError to QSslError: D24419: Implement KSslCertificateRule with QSslError instead of KSslError.
Mon, Oct 7, 4:52 PM · KF6
vkrause added a comment to T11833: Overhaul Solid.

Solid certainly needs attention for KF6 :)

  • Do you see powersave/screen saver inhibition and display brightness control in scope for Solid? If not, where would we put that in KF6? T11532 suggests Solid, this task would suggest something else IIUC.
  • How widespread is the usage of the things you suggest to drop? CPU enumeration sounds like something that's only there "because we can", but we should verify nevertheless to avoid repeating the same problem as with the Solid parts still in KDELibs4Support.
Mon, Oct 7, 4:32 PM · KF6
vkrause added a comment to D24294: Port KSslCertificateManager to QSslError.

Ping?

Mon, Oct 7, 4:26 PM · Frameworks
vkrause updated the diff for D24380: Explicitly define the Journal copy ctor.

Explicitly delete the assignment operator (which has no implementation).

Mon, Oct 7, 4:25 PM
vkrause added a comment to D24380: Explicitly define the Journal copy ctor.

hmmmm, the explicitely defined assignment operator is private (old way to delete it). So it seems what we should do is delete it and then delete the copy constructor too?

Mon, Oct 7, 4:25 PM
vkrause added a comment to T11535: Organize 2019 KF6 sprint.

Obviously I'm also interested :)

Mon, Oct 7, 4:21 PM · KF6
vkrause updated subscribers of D24443: Add a plugin system.

Thanks for working on this! Some general thoughts:

  • Is KDeclarative is the right place for this? It's a module on the way out in KF6, it is hard to build for Android due to its dependency chain (which isn't even needed for this), while at the same time forcing ABI stability on this basically immediately without much chance for battle testing this.
  • This currently represents a flat list of calendars, which matches Android IIRC, but not Akonadi (which treats calendars as folders and thus hierarchical). That might not be a problem as long as we treat Akonadi as a single calendar and don't expose the different backends on this level at all, but IIUC @dvratil was argueing to move away from that approach.
Mon, Oct 7, 4:11 PM
vkrause moved T11490: Control for visibility of symbols of deprecated API and compiler warnings from Backlog to In Progress on the KF6 board.
Mon, Oct 7, 4:07 PM · KF6, Frameworks
vkrause added a project to T11490: Control for visibility of symbols of deprecated API and compiler warnings: KF6.
Mon, Oct 7, 4:06 PM · KF6, Frameworks

Sun, Oct 6

vkrause committed R1003:9f6b04aaff7c: Attempt to fix the FreeBSD CI build (authored by vkrause).
Attempt to fix the FreeBSD CI build
Sun, Oct 6, 2:18 PM
vkrause accepted D24438: Port away from KTcpSocket to QSslSocket.

Awesome, thanks!

Sun, Oct 6, 11:33 AM · KDE PIM
vkrause committed R1003:48e78469361f: Add access to PDF document creation/modification times (authored by vkrause).
Add access to PDF document creation/modification times
Sun, Oct 6, 10:32 AM
vkrause committed R1003:071c6b558813: Check if unstable Poppler headers are available (authored by vkrause).
Check if unstable Poppler headers are available
Sun, Oct 6, 9:37 AM
vkrause moved T9359: Improve Poppler CMake check from Actionable to Done on the KDE Itinerary board.
Sun, Oct 6, 9:36 AM · KDE Itinerary
vkrause accepted D24434: Fix include path to kjob.h.
Sun, Oct 6, 9:02 AM · Frameworks

Sat, Oct 5

vkrause accepted D24397: Make some variables qint64 instead of int.
Sat, Oct 5, 5:11 PM
vkrause accepted D24416: Declare Calendar::Ptr as metatype.
Sat, Oct 5, 2:57 PM
vkrause committed R1003:f9f0f7348944: Add converter for Flixbus ticket download links to ticket QR codes (authored by vkrause).
Add converter for Flixbus ticket download links to ticket QR codes
Sat, Oct 5, 11:03 AM
vkrause committed R1003:ed6e718ec1e3: Make JSON-LD matching more flexible for custom extractors (authored by vkrause).
Make JSON-LD matching more flexible for custom extractors
Sat, Oct 5, 11:03 AM
vkrause added a comment to D24416: Declare Calendar::Ptr as metatype.

Ok as such, but there seem to be unrelated changes to test scripts in this commit.

Sat, Oct 5, 9:09 AM
vkrause requested review of D24419: Implement KSslCertificateRule with QSslError instead of KSslError.
Sat, Oct 5, 9:00 AM · Frameworks

Fri, Oct 4

vkrause committed R1003:885d1fc589f4: Don't treat pkpass special anymore (authored by vkrause).
Don't treat pkpass special anymore
Fri, Oct 4, 1:25 PM
vkrause committed R1003:e04eff4665ca: Work towards unifying the generic extraction process (authored by vkrause).
Work towards unifying the generic extraction process
Fri, Oct 4, 1:25 PM
vkrause committed R1003:4bfedd547682: Don't trigger text-based extractors if we have a PDF alternative (authored by vkrause).
Don't trigger text-based extractors if we have a PDF alternative
Fri, Oct 4, 1:25 PM
vkrause committed R1003:1ca3f50a0fe7: Refactor how ExtractorRepository provides extractors (authored by vkrause).
Refactor how ExtractorRepository provides extractors
Fri, Oct 4, 1:25 PM

Thu, Oct 3

vkrause committed R1003:931f2bbb4904: Improve the generic PkPass extractor (authored by vkrause).
Improve the generic PkPass extractor
Thu, Oct 3, 4:12 PM
vkrause committed R1003:c091b08096b0: Factor out result type from PDF extractor (authored by vkrause).
Factor out result type from PDF extractor
Thu, Oct 3, 11:44 AM
vkrause committed R1003:aa213cb4c1ac: Move generic extractor code to its own subdir (authored by vkrause).
Move generic extractor code to its own subdir
Thu, Oct 3, 11:44 AM
vkrause added a task to D24294: Port KSslCertificateManager to QSslError: T11620: Port from KSslError to QSslError.
Thu, Oct 3, 9:20 AM · Frameworks
vkrause added revisions to T11620: Port from KSslError to QSslError: D24382: Port (most of) the interface of KSslCertificateRule to QSslError, D24294: Port KSslCertificateManager to QSslError.
Thu, Oct 3, 9:20 AM · KF6
vkrause added a task to D24382: Port (most of) the interface of KSslCertificateRule to QSslError: T11620: Port from KSslError to QSslError.
Thu, Oct 3, 9:20 AM · Frameworks
vkrause requested review of D24382: Port (most of) the interface of KSslCertificateRule to QSslError.
Thu, Oct 3, 9:17 AM · Frameworks
vkrause requested review of D24380: Explicitly define the Journal copy ctor.
Thu, Oct 3, 8:43 AM
vkrause closed D24322: Document known issue in Recurrence::operator=.
Thu, Oct 3, 8:28 AM
vkrause closed D24365: Make copying and assigning of Event::Private behave the same.
Thu, Oct 3, 8:26 AM

Wed, Oct 2

vkrause accepted D24111: Allow getting telemetry descriptions from the enum.
Wed, Oct 2, 3:45 PM
vkrause committed R1003:40c474f1aa16: Fix extraction of nested objects in schema.org microdata annotations (authored by vkrause).
Fix extraction of nested objects in schema.org microdata annotations
Wed, Oct 2, 3:04 PM
vkrause requested review of D24365: Make copying and assigning of Event::Private behave the same.
Wed, Oct 2, 2:55 PM
vkrause committed R490:62cdf27e89db: Fix KIO WebDAV usage and remove obsolete workarounds (authored by vkrause).
Fix KIO WebDAV usage and remove obsolete workarounds
Wed, Oct 2, 2:52 PM
vkrause closed D24343: Fix KIO WebDAV usage and remove obsolete workarounds.
Wed, Oct 2, 2:52 PM · KDE PIM

Tue, Oct 1

vkrause accepted D24348: Use range for loop instead of ugly sizeof arithmetic.
Tue, Oct 1, 6:37 PM · Frameworks
vkrause committed R739:ecbac9b321a1: Fix license information, treemap is GPLv2+, making all of this GPLv2+ too (authored by vkrause).
Fix license information, treemap is GPLv2+, making all of this GPLv2+ too
Tue, Oct 1, 5:32 PM
vkrause accepted D24347: Use range for loop instead of sizeof(x) / sizeof(x[0]).
Tue, Oct 1, 5:28 PM · Frameworks, Dolphin
vkrause accepted D24346: Use range for instead of sizeof(aztec_code_double_symbols) / sizeof(aztec_code_double_symbols[0]).
Tue, Oct 1, 5:26 PM · Frameworks
vkrause accepted D24344: Use range for instead of sizeof(buttons) / sizeof(buttons[0]).
Tue, Oct 1, 5:26 PM · Frameworks
vkrause accepted D24345: Use range for loop instead of sizeof(magic_detector) / sizeof(magic_detector[0]).
Tue, Oct 1, 5:22 PM · KDE PIM
vkrause committed R739:3d9aa1a3b211: Normalize Capstone include dirs towards adding the capstone subdir (authored by vkrause).
Normalize Capstone include dirs towards adding the capstone subdir
Tue, Oct 1, 5:20 PM
vkrause requested review of D24343: Fix KIO WebDAV usage and remove obsolete workarounds.
Tue, Oct 1, 4:57 PM · KDE PIM
vkrause closed D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV.
Tue, Oct 1, 4:47 PM · Frameworks