trmdi (Tranter Madi)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Mar 2 2018, 3:40 PM (117 w, 2 d)
Availability
Available

Recent Activity

Yesterday

trmdi added a comment to D29466: [applets/appmenu] Add search to global application menu.

Can this be moved to krunner? In that case it can be used even when the user doesn't use global menu?

Sat, May 30, 3:47 PM · Plasma

Fri, May 29

trmdi committed R878:2aa010b5f38a: Set Combobox's icon size more properly (authored by trmdi).
Set Combobox's icon size more properly
Fri, May 29, 6:28 PM

Sat, May 9

trmdi added a comment to D28623: [WIP] Sync titlebar button appearance with GTK CSD apps.

Just a question, SierraBreezeEnhanced has a feature called "Unison hovering". Does this support it?

Sat, May 9, 12:53 PM · Plasma

Mon, May 4

trmdi added a comment to D29395: Refactor MediaController.

Now the inner image has a greater top margin than bottom margin. Also, could the artist and album be allowed to become two-line strings before eliding, maybe?

Mon, May 4, 3:32 AM · Plasma

Apr 28 2020

trmdi added a comment to D29260: Set better default and minimum sizes for the desktop config window.

GridUnit * 40 works out to be 720 px high with the default 10pt Noto Sans font, which is enough space to not interfere with the default 36px bottom panel.

But there's no way around the fact that this window greatly benefits from more space. On such a small screen resolution, I would expect people to want to just maximize the window.

Apr 28 2020, 5:08 PM · Plasma
trmdi added a comment to D29260: Set better default and minimum sizes for the desktop config window.

Please keep in mind that not everyone uses a high res screen. 1366x768 is a very popular one, please don't make it too big on those screens. :(

Apr 28 2020, 5:02 PM · Plasma

Apr 20 2020

trmdi added a comment to D28985: [Kickoff] Disable tabBar's mouseArea when searching.

Excellent!

Please land on the Plasma/5.18 branch and then merge to master. Let me know if you need a hand with that.

Apr 20 2020, 2:10 PM · Plasma

Apr 19 2020

GB_2 awarded D28985: [Kickoff] Disable tabBar's mouseArea when searching a Love token.
Apr 19 2020, 4:40 PM · Plasma
trmdi updated the summary of D28985: [Kickoff] Disable tabBar's mouseArea when searching.
Apr 19 2020, 4:18 PM · Plasma
trmdi requested review of D28985: [Kickoff] Disable tabBar's mouseArea when searching.
Apr 19 2020, 4:12 PM · Plasma

Apr 17 2020

trmdi committed R878:a8957925837b: Typo in README (authored by trmdi).
Typo in README
Apr 17 2020, 3:51 AM

Apr 10 2020

trmdi added a comment to D27951: Allow users to change dropAction to MoveAction through kdeglobals.

I might take over to finish it eventually.

Apr 10 2020, 8:50 AM · Frameworks

Apr 5 2020

trmdi abandoned D27733: Set a better position on wayland.
Apr 5 2020, 3:28 AM
trmdi abandoned D27998: [KCMs/Workspace] Add option for dndToMove.
Apr 5 2020, 3:27 AM · Plasma

Apr 4 2020

trmdi abandoned D27951: Allow users to change dropAction to MoveAction through kdeglobals.

Anything that concerns a kdeconnet:/ url is handled by the kdeconnect ioslave, including the stat call made in KIO::StatJob.
It is in the kdeconnect code base, the issue you point to is there.

Thanks, got it. Then could we simply use KMountPoint instead of UDS_Device_ID ? KMountPoint seems more reliable.

But KMountPoint induces more cost (it makes a syscall and a bunch of parsing).
So instead I would recommend fixing the issue in kdeconnect (and potentially other ioslave) as it will fix things here and elsewhere potentially too.

Also local = url.isLocalFile should return false for kdeconnect in the first place.
So I belive you can avoid using KMountPoint at all and use only stat.

Apr 4 2020, 11:36 AM · Frameworks

Apr 1 2020

trmdi added a comment to D27951: Allow users to change dropAction to MoveAction through kdeglobals.

Anything that concerns a kdeconnet:/ url is handled by the kdeconnect ioslave, including the stat call made in KIO::StatJob.
It is in the kdeconnect code base, the issue you point to is there.

Apr 1 2020, 2:14 PM · Frameworks

Mar 30 2020

trmdi added a comment to D27951: Allow users to change dropAction to MoveAction through kdeglobals.

Look into kde connect kioslave.
That does not concern this diff much though.

Mar 30 2020, 8:40 AM · Frameworks
trmdi committed R318:4440e961a07a: Set a better defaultDropAction for dragging (authored by trmdi).
Set a better defaultDropAction for dragging
Mar 30 2020, 2:54 AM
trmdi closed D28370: Set a better defaultDropAction for dragging.
Mar 30 2020, 2:54 AM · Dolphin

Mar 29 2020

trmdi added a comment to D27951: Allow users to change dropAction to MoveAction through kdeglobals.

Indeed. Bug in kio_file, fixed in D28388.

Mar 29 2020, 1:32 AM · Frameworks

Mar 28 2020

trmdi added a comment to D27951: Allow users to change dropAction to MoveAction through kdeglobals.

Seems to work for symlinks here. We *don't* want it to follow symlinks, right?

I have /opt a symlink to /d/opt, where /d is on another partition

$ kioclient5 openProperties /opt
DEVICE 65025

$ kioclient5 openProperties /d/opt
DEVICE 65028

Different, as expected.

Mar 28 2020, 9:53 PM · Frameworks
trmdi added a comment to D27951: Allow users to change dropAction to MoveAction through kdeglobals.

Note sure how you're testing UDS_* but you need to pass KIO::StatInode to KIO::statDetails for inode and device ID to be filled in.

Testcase: apply http://www.davidfaure.fr/2020/uds_device_test.diff then kioclient5 openProperties ~/.bashrc

Mar 28 2020, 5:07 PM · Frameworks
trmdi requested review of D28370: Set a better defaultDropAction for dragging.
Mar 28 2020, 3:36 AM · Dolphin

Mar 27 2020

trmdi updated the diff for D27951: Allow users to change dropAction to MoveAction through kdeglobals.

Improve the logic a bit.

Mar 27 2020, 6:22 PM · Frameworks
trmdi added a comment to D27951: Allow users to change dropAction to MoveAction through kdeglobals.

Symlinks are a bit special, we could add a way to ask kio_file not to follow them.

But at least it should work for regular files and directories, right?

Anyhow, we don't have a kio_file result here so I guess my point is moot.

Mar 27 2020, 9:30 AM · Frameworks

Mar 26 2020

trmdi added a comment to D27951: Allow users to change dropAction to MoveAction through kdeglobals.

Implementation note: the fastest way to know if two items are on the same partition is to compare KIO::UDSEntry::UDS_DEVICE_ID values. But unfortunately it looks like this code takes URLs, not proper KFileItems created from a kio_file job... I guess that means statbuf.st_dev directly, on Unix?

Mar 26 2020, 9:55 AM · Frameworks

Mar 25 2020

trmdi added a comment to D28017: Update dragCursor while dragging.

@ngraham
It seems that everyone accepted this, could you help me to land this to whatever branch you want ?

Mar 25 2020, 2:48 PM · Dolphin
trmdi updated the diff for D27951: Allow users to change dropAction to MoveAction through kdeglobals.

Improve the symlink case, any symlink is considered as on the same device with any destination.

Mar 25 2020, 6:03 AM · Frameworks
trmdi added inline comments to D27951: Allow users to change dropAction to MoveAction through kdeglobals.
Mar 25 2020, 5:33 AM · Frameworks
trmdi updated the diff for D27951: Allow users to change dropAction to MoveAction through kdeglobals.
  • Always move files if all of them are symlinks
  • Use KMountPoint
Mar 25 2020, 5:28 AM · Frameworks

Mar 20 2020

trmdi added inline comments to D28017: Update dragCursor while dragging.
Mar 20 2020, 1:42 AM · Dolphin

Mar 19 2020

trmdi added inline comments to D28017: Update dragCursor while dragging.
Mar 19 2020, 4:13 AM · Dolphin
trmdi added a comment to D27951: Allow users to change dropAction to MoveAction through kdeglobals.

Friendly ping.

Mar 19 2020, 3:51 AM · Frameworks
trmdi updated the test plan for D28017: Update dragCursor while dragging.
Mar 19 2020, 3:48 AM · Dolphin
trmdi updated the test plan for D28017: Update dragCursor while dragging.
Mar 19 2020, 3:48 AM · Dolphin
trmdi updated the diff for D28017: Update dragCursor while dragging.

The patch now only updates the cursor while dragging.

Mar 19 2020, 3:47 AM · Dolphin

Mar 17 2020

trmdi added a comment to D28017: Update dragCursor while dragging.

With Qt 5.15 I get this debug output when i click that "drag" button:

Qt::CopyAction QFlags<Qt::DropAction>(CopyAction|MoveAction)

Mar 17 2020, 4:28 AM · Dolphin

Mar 15 2020

trmdi added a comment to D27951: Allow users to change dropAction to MoveAction through kdeglobals.

With dndToMove=true in kdeglobals, drag&drop files will move them without showing the menu. (holding Shift shows it)

Are we going to expose this setting in Plasma?

Mar 15 2020, 6:50 PM · Frameworks
trmdi added a comment to D28017: Update dragCursor while dragging.

As far as I can see, bug #388259 has been fixed upstream (either in Qt or in the platform integration plugin).

Mar 15 2020, 6:32 PM · Dolphin
trmdi added inline comments to D28017: Update dragCursor while dragging.
Mar 15 2020, 6:13 PM · Dolphin
trmdi updated the diff for D28017: Update dragCursor while dragging.

Set accepted state and dropAction of event more correctly.

Mar 15 2020, 5:58 PM · Dolphin
trmdi added inline comments to D28017: Update dragCursor while dragging.
Mar 15 2020, 4:24 PM · Dolphin
trmdi added a comment to D28017: Update dragCursor while dragging.

Is this a Qt bug or an intention

which bit specifically?

Mar 15 2020, 4:06 PM · Dolphin
trmdi added a reviewer for D28017: Update dragCursor while dragging: davidedmundson.

Is this a Qt bug or an intention? Because QDrag is used in many places.

Mar 15 2020, 12:28 PM · Dolphin
trmdi updated the diff for D27998: [KCMs/Workspace] Add option for dndToMove.

Nate's comment

Mar 15 2020, 3:10 AM · Plasma
trmdi added inline comments to D27998: [KCMs/Workspace] Add option for dndToMove.
Mar 15 2020, 2:58 AM · Plasma
trmdi added a comment to D27998: [KCMs/Workspace] Add option for dndToMove.

Where? Being wrong in multiple places doesn't make it right. ;)

Mar 15 2020, 2:55 AM · Plasma
trmdi updated the diff for D27998: [KCMs/Workspace] Add option for dndToMove.

Nate's comment

Mar 15 2020, 2:54 AM · Plasma
trmdi added a comment to D27998: [KCMs/Workspace] Add option for dndToMove.

Right.

@bugseforuns's objection is that you used the word "device" to mean "partition" in the UI.

Mar 15 2020, 2:52 AM · Plasma
trmdi updated the diff for D28017: Update dragCursor while dragging.

clean

Mar 15 2020, 2:30 AM · Dolphin
trmdi added a comment to D27998: [KCMs/Workspace] Add option for dndToMove.

What does?

Mar 15 2020, 12:54 AM · Plasma
trmdi added a comment to D27998: [KCMs/Workspace] Add option for dndToMove.

Yes, it means "partition".

Mar 15 2020, 12:51 AM · Plasma
trmdi updated the diff for D28017: Update dragCursor while dragging.

Address @meven and @ngraham's comments.
Now you can change the modifier key without having to move the mouse.

Mar 15 2020, 12:47 AM · Dolphin

Mar 14 2020

trmdi added a comment to D27951: Allow users to change dropAction to MoveAction through kdeglobals.

My interpretation of the use case is that a user who chooses dndToMove prefers Move over Copy and Link, but not necessarily Extract or Set as Wallpaper, since those are context-specific options that exist because they are potentially more useful than move, copy, or link.

If he wants to see the menu, he could hold the Shift modifier key.

If he doesn't know that there are other options, then he has no way of knowing that he should hold down the shift key to see them.

Mar 14 2020, 1:51 AM · Frameworks

Mar 13 2020

trmdi added a comment to D27951: Allow users to change dropAction to MoveAction through kdeglobals.

When drop an image to the desktop in the FolderView layout, there would be no menu, so users can not change the wallpaper by drag&drop in this case. How do you think about this?

In fact there are other options that I didn't think about. For example when dragging-and-dropping an archive, there's an "extract here" item that would be hidden with this patch.

Could we maybe generalize the logic so that it always shows the full drop menu if there are any custom items in it like "Expand here" or "Set as Wallpaper"? That way it will only move if you have the setting turned on and there really are no other ambiguous options.

Mar 13 2020, 4:37 PM · Frameworks
trmdi added a comment to D28017: Update dragCursor while dragging.

This works only once the mouse starts moving after the key modifier has been pressed.

Mar 13 2020, 8:30 AM · Dolphin
trmdi requested review of D28017: Update dragCursor while dragging.
Mar 13 2020, 8:07 AM · Dolphin

Mar 12 2020

trmdi updated the diff for D27951: Allow users to change dropAction to MoveAction through kdeglobals.

Minor improvement

Mar 12 2020, 5:00 PM · Frameworks
trmdi updated the test plan for D27951: Allow users to change dropAction to MoveAction through kdeglobals.
Mar 12 2020, 3:30 PM · Frameworks
trmdi added inline comments to D27998: [KCMs/Workspace] Add option for dndToMove.
Mar 12 2020, 3:27 PM · Plasma
trmdi updated the test plan for D27998: [KCMs/Workspace] Add option for dndToMove.
Mar 12 2020, 3:26 PM · Plasma
trmdi updated the diff for D27998: [KCMs/Workspace] Add option for dndToMove.

Move to bottom, add hint

Mar 12 2020, 3:23 PM · Plasma
trmdi updated the diff for D27951: Allow users to change dropAction to MoveAction through kdeglobals.

Allow to explicitly show the menu when holding Shift

Mar 12 2020, 3:02 PM · Frameworks
trmdi added a comment to D27951: Allow users to change dropAction to MoveAction through kdeglobals.

it needs more discussion first...

Mar 12 2020, 9:33 AM · Frameworks
trmdi updated the test plan for D27998: [KCMs/Workspace] Add option for dndToMove.
Mar 12 2020, 4:47 AM · Plasma
trmdi requested review of D27998: [KCMs/Workspace] Add option for dndToMove.
Mar 12 2020, 4:44 AM · Plasma

Mar 11 2020

trmdi added a comment to D27951: Allow users to change dropAction to MoveAction through kdeglobals.

Excellent. The behavior seems correct to me now. There are a few more issues I've like to bring up:

  • While dragging, the cursor always shows a "copying" icon, even though with the patch local drags result in a move. Anytime the file will be moved without showing the drop menu, it should show the move cursor, which looks like a grabbing hand
Mar 11 2020, 4:51 PM · Frameworks
trmdi updated the diff for D27951: Allow users to change dropAction to MoveAction through kdeglobals.

Apply only when all the sources and the dest are on a same device.

Mar 11 2020, 4:49 PM · Frameworks
trmdi updated the diff for D27951: Allow users to change dropAction to MoveAction through kdeglobals.

Code style

Mar 11 2020, 8:33 AM · Frameworks
trmdi updated the diff for D27951: Allow users to change dropAction to MoveAction through kdeglobals.

Code style

Mar 11 2020, 8:29 AM · Frameworks
trmdi updated the diff for D27951: Allow users to change dropAction to MoveAction through kdeglobals.

Apply only when all items are local.

Mar 11 2020, 8:22 AM · Frameworks
trmdi added a comment to D27951: Allow users to change dropAction to MoveAction through kdeglobals.

However dragging a URL still doesn't show the menu; it just downloads the entire page. We need the drop menu in this case because it's probably more common to want to create a link to the page than it is to download the entire thing.

If introspecting the mimetype of every URL is too costly, could we maybe short-circuit the logic if the URL scheme is HTTP or HTTPS?

Mar 11 2020, 2:40 AM · Frameworks

Mar 10 2020

trmdi updated the diff for D27951: Allow users to change dropAction to MoveAction through kdeglobals.

Move comment

Mar 10 2020, 1:29 PM · Frameworks
trmdi retitled D27951: Allow users to change dropAction to MoveAction through kdeglobals from Allow users to change dropAction to MoveAction through workspace kcm to Allow users to change dropAction to MoveAction through kdeglobals.
Mar 10 2020, 1:21 PM · Frameworks
trmdi updated the diff for D27951: Allow users to change dropAction to MoveAction through kdeglobals.

Address meven's comment

Mar 10 2020, 1:19 PM · Frameworks
trmdi retitled D27951: Allow users to change dropAction to MoveAction through kdeglobals from Allow users to change dropAction to MoveAction through workspace-option kcm to Allow users to change dropAction to MoveAction through workspace kcm.
Mar 10 2020, 1:10 PM · Frameworks
trmdi updated the diff for D27951: Allow users to change dropAction to MoveAction through kdeglobals.

Move fileItem back to the local scope

Mar 10 2020, 1:05 PM · Frameworks
trmdi updated the diff for D27951: Allow users to change dropAction to MoveAction through kdeglobals.
  • Check possible actions in determineDropAction
Mar 10 2020, 2:21 AM · Frameworks
trmdi abandoned D27961: GIT_SILENT Upgrade ECM and KF5 version requirements for 5.68.0 release..
Mar 10 2020, 2:18 AM · Frameworks
trmdi requested review of D27961: GIT_SILENT Upgrade ECM and KF5 version requirements for 5.68.0 release..
Mar 10 2020, 2:17 AM · Frameworks

Mar 9 2020

trmdi planned changes to D27951: Allow users to change dropAction to MoveAction through kdeglobals.
Mar 9 2020, 10:36 PM · Frameworks
trmdi updated the test plan for D27951: Allow users to change dropAction to MoveAction through kdeglobals.
Mar 9 2020, 5:13 PM · Frameworks
trmdi added reviewers for D27951: Allow users to change dropAction to MoveAction through kdeglobals: ngraham, dfaure.
Mar 9 2020, 5:12 PM · Frameworks
trmdi requested review of D27951: Allow users to change dropAction to MoveAction through kdeglobals.
Mar 9 2020, 5:11 PM · Frameworks

Mar 8 2020

trmdi added a comment to D27925: Reformatted all if statements.

Look weird. Don't you misunderstand it?

Apparently my titlebar resize patch shouldn't have a space between "if" and "(" so I changed the rest of Yakuake to match.

Mar 8 2020, 10:24 AM
trmdi requested changes to D27925: Reformatted all if statements.
Mar 8 2020, 4:39 AM
trmdi added a comment to D27925: Reformatted all if statements.

Look weird. Don't you misunderstand it?

Mar 8 2020, 4:36 AM

Mar 5 2020

trmdi added a comment to T12316: Make Plasma Desktop aware about Latte Docks/Panels geometries.

Could we close this now?

Mar 5 2020, 9:18 AM · Latte Dock

Feb 29 2020

trmdi updated the summary of D27733: Set a better position on wayland.
Feb 29 2020, 7:37 AM
trmdi requested review of D27733: Set a better position on wayland.
Feb 29 2020, 7:34 AM

Feb 28 2020

trmdi committed R120:731a19081044: Set a better position for Krunner in wayland (authored by trmdi).
Set a better position for Krunner in wayland
Feb 28 2020, 1:08 PM
trmdi closed D27458: Set a better position for Krunner in wayland.
Feb 28 2020, 1:05 PM · Plasma
trmdi updated the diff for D27458: Set a better position for Krunner in wayland.

Rename m_realVisible to m_requestedVisible

Feb 28 2020, 1:02 PM · Plasma
trmdi updated the diff for D27458: Set a better position for Krunner in wayland.

Small fix.

Feb 28 2020, 5:19 AM · Plasma
trmdi updated the diff for D27458: Set a better position for Krunner in wayland.

Never show before position is set

Feb 28 2020, 4:41 AM · Plasma

Feb 26 2020

trmdi added a comment to D27458: Set a better position for Krunner in wayland.
Feb 26 2020, 5:24 PM · Plasma

Feb 25 2020

trmdi added a comment to D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground.

Hmm, I think you need to rebase to remove unrelated files in this patch e.g. dropjob.cpp ... ?

Feb 25 2020, 3:22 PM · VDG, Plasma, Frameworks

Feb 19 2020

trmdi abandoned D27016: Update from Plasma's ToolTip.
Feb 19 2020, 3:26 AM · Plasma
trmdi abandoned D27329: Make Taskmanager's tooltip a fixed ratio rectangle.
Feb 19 2020, 3:19 AM · Plasma
trmdi added a comment to D27329: Make Taskmanager's tooltip a fixed ratio rectangle.

How about this?

You can also try the GoldNumber/Ratio that is found in all real nature patterns and also at Ancient Greeks in their architectural buildings. That is 1.618, there is a big chance that it feels right without being able to explain why.

Feb 19 2020, 3:05 AM · Plasma