trmdi (Tranter Madi)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Mar 2 2018, 3:40 PM (99 w, 2 d)
Availability
Available

Recent Activity

Fri, Jan 24

trmdi committed R878:77c170c8f7cb: Update from Plasma for ToolTipInstance.qml (authored by trmdi).
Update from Plasma for ToolTipInstance.qml
Fri, Jan 24, 8:34 AM
trmdi closed D26760: Update from Plasma for ToolTipInstance.qml.
Fri, Jan 24, 8:34 AM · Plasma
trmdi added a comment to D26760: Update from Plasma for ToolTipInstance.qml.

Thanks, but I want to wait for this patch: https://phabricator.kde.org/D26739 to be committed, then I will add it to this patch. It looks pretty nice. :)

Fri, Jan 24, 6:50 AM · Plasma
trmdi added inline comments to D26720: Cache single image wallpapers locally.
Fri, Jan 24, 2:16 AM · Plasma

Thu, Jan 23

trmdi added a comment to D26739: [applets/Task Manager] Refine tooltip highlight effect.

Pretty nice.
But clicking on playerControlsRow (exclude buttons) does not behave the same way like clicking on the cover art, while the effect would make users think that they can click on the control row to open the window.

Thu, Jan 23, 6:14 PM · Plasma
trmdi retitled D26514: Delay popup when dropping things into containments from Delay popup for containments to Delay popup when dropping things into containments .
Thu, Jan 23, 5:39 PM · Plasma
trmdi edited reviewers for D26514: Delay popup when dropping things into containments , added: davidedmundson, broulik; removed: dfaure.
Thu, Jan 23, 5:34 PM · Plasma
trmdi updated the diff for D26514: Delay popup when dropping things into containments .
  • Show drop menu manually when dropping things into the desktop
Thu, Jan 23, 5:31 PM · Plasma
trmdi added a dependent revision for D26484: Add KIO::DropJobFlag to allow manually showing the menu: D26514: Delay popup when dropping things into containments .
Thu, Jan 23, 5:31 PM · Frameworks
trmdi added a comment to D26760: Update from Plasma for ToolTipInstance.qml.

@trmdi have you checked the previews still work OK after the patch?

Thu, Jan 23, 4:52 PM · Plasma
trmdi updated the diff for D26760: Update from Plasma for ToolTipInstance.qml.
  • Address comment
Thu, Jan 23, 4:48 PM · Plasma

Tue, Jan 21

trmdi updated the summary of D26691: Optimize code when dropping files into the desktop.
Tue, Jan 21, 6:06 PM · Frameworks
trmdi updated the diff for D26691: Optimize code when dropping files into the desktop.
  • Address comment
Tue, Jan 21, 6:03 PM · Frameworks
trmdi added inline comments to D26691: Optimize code when dropping files into the desktop.
Tue, Jan 21, 5:17 PM · Frameworks
trmdi updated the diff for D26691: Optimize code when dropping files into the desktop.
  • Code style
Tue, Jan 21, 5:07 PM · Frameworks
trmdi updated the diff for D26691: Optimize code when dropping files into the desktop.
  • Handle the case in which the menu is not shown
Tue, Jan 21, 4:28 PM · Frameworks

Mon, Jan 20

trmdi added a comment to D26739: [applets/Task Manager] Refine tooltip highlight effect.

How about this?

Mon, Jan 20, 4:13 PM · Plasma
trmdi added a comment to D26739: [applets/Task Manager] Refine tooltip highlight effect.

Could you clarify before/after screenshots?

Mon, Jan 20, 2:09 PM · Plasma
trmdi added inline comments to D26720: Cache single image wallpapers locally.
Mon, Jan 20, 2:03 PM · Plasma
trmdi added inline comments to D26691: Optimize code when dropping files into the desktop.
Mon, Jan 20, 1:16 PM · Frameworks
trmdi added inline comments to D26760: Update from Plasma for ToolTipInstance.qml.
Mon, Jan 20, 1:03 PM · Plasma
trmdi updated the diff for D26760: Update from Plasma for ToolTipInstance.qml.
  • hasPlayer-tooltips shouldn't disappear when the mouse is inside the bottom margin of the tooltip
Mon, Jan 20, 1:00 PM · Plasma

Sun, Jan 19

trmdi updated the diff for D26760: Update from Plasma for ToolTipInstance.qml.
Sun, Jan 19, 1:48 PM · Plasma
trmdi added a comment to D26760: Update from Plasma for ToolTipInstance.qml.

Is there any improvement, or it is just a code update?

Sun, Jan 19, 10:55 AM · Plasma
trmdi retitled D26760: Update from Plasma for ToolTipInstance.qml from Update from Plasma to Update from Plasma for ToolTipInstance.qml.
Sun, Jan 19, 10:46 AM · Plasma
trmdi requested review of D26760: Update from Plasma for ToolTipInstance.qml.
Sun, Jan 19, 10:45 AM · Plasma

Sat, Jan 18

trmdi updated the diff for D26691: Optimize code when dropping files into the desktop.
  • Add DropMenu class to combine choices/dropjobMenu
  • Only 1 menu can be created
  • Fix some possible memory leaks
Sat, Jan 18, 7:02 AM · Frameworks

Thu, Jan 16

trmdi updated the diff for D26691: Optimize code when dropping files into the desktop.
  • Change the cursor to the busy state when the first file is not local
Thu, Jan 16, 4:04 PM · Frameworks
trmdi updated the diff for D26691: Optimize code when dropping files into the desktop.
  • Remove unneeded code
Thu, Jan 16, 11:12 AM · Frameworks
trmdi updated the diff for D26691: Optimize code when dropping files into the desktop.
  • Remove unneeded code
Thu, Jan 16, 11:11 AM · Frameworks
trmdi added reviewers for D26691: Optimize code when dropping files into the desktop: broulik, VDG.
Thu, Jan 16, 11:08 AM · Frameworks
trmdi updated the summary of D26691: Optimize code when dropping files into the desktop.
Thu, Jan 16, 2:36 AM · Frameworks

Wed, Jan 15

trmdi committed R120:2212a9af156b: Fix wallpaper destination path (authored by trmdi).
Fix wallpaper destination path
Wed, Jan 15, 5:24 PM
trmdi closed D26525: Fix wallpaper destination path.
Wed, Jan 15, 5:24 PM · Plasma
trmdi updated the summary of D26691: Optimize code when dropping files into the desktop.
Wed, Jan 15, 4:40 PM · Frameworks
trmdi added a comment to D26525: Fix wallpaper destination path.

Ping. Could I land this now?

Wed, Jan 15, 4:36 PM · Plasma
trmdi updated the summary of D26691: Optimize code when dropping files into the desktop.
Wed, Jan 15, 4:36 PM · Frameworks
trmdi retitled D26691: Optimize code when dropping files into the desktop from [WIP] Optimize code when dropping files into the desktop to Optimize code when dropping files into the desktop.
Wed, Jan 15, 4:31 PM · Frameworks
trmdi updated the summary of D26691: Optimize code when dropping files into the desktop.
Wed, Jan 15, 4:30 PM · Frameworks
trmdi added reviewers for D26691: Optimize code when dropping files into the desktop: Plasma, mart.
Wed, Jan 15, 4:29 PM · Frameworks
trmdi updated the summary of D26691: Optimize code when dropping files into the desktop.
Wed, Jan 15, 4:28 PM · Frameworks
trmdi requested review of D26691: Optimize code when dropping files into the desktop.
Wed, Jan 15, 4:20 PM · Frameworks

Mon, Jan 13

trmdi committed R241:fbb2be9aad19: Add KIO::DropJobFlag to allow manually showing the menu (authored by trmdi).
Add KIO::DropJobFlag to allow manually showing the menu
Mon, Jan 13, 12:35 PM
trmdi closed D26484: Add KIO::DropJobFlag to allow manually showing the menu.
Mon, Jan 13, 12:35 PM · Frameworks
trmdi updated the diff for D26484: Add KIO::DropJobFlag to allow manually showing the menu.
  • Comment
Mon, Jan 13, 12:34 PM · Frameworks
trmdi added a reviewer for D26525: Fix wallpaper destination path: ngraham.
Mon, Jan 13, 7:36 AM · Plasma
trmdi updated the diff for D26484: Add KIO::DropJobFlag to allow manually showing the menu.
  • Typo
Mon, Jan 13, 4:47 AM · Frameworks
trmdi updated the diff for D26484: Add KIO::DropJobFlag to allow manually showing the menu.
  • Improve comment/doc
Mon, Jan 13, 4:40 AM · Frameworks

Sun, Jan 12

trmdi updated the summary of D26484: Add KIO::DropJobFlag to allow manually showing the menu.
Sun, Jan 12, 3:03 PM · Frameworks
trmdi retitled D26484: Add KIO::DropJobFlag to allow manually showing the menu from Add KIO::DropJobFlag flag and DropJob::menuPopup() to Add KIO::DropJobFlag to allow manually showing the menu.
Sun, Jan 12, 2:58 PM · Frameworks
trmdi retitled D26484: Add KIO::DropJobFlag to allow manually showing the menu from Add KIO::DelayPopup flag and DropJob::menuPopup() to Add KIO::DropJobFlag flag and DropJob::menuPopup().
Sun, Jan 12, 2:57 PM · Frameworks
trmdi updated the diff for D26484: Add KIO::DropJobFlag to allow manually showing the menu.
  • Move the flag to DropJob header, rename
Sun, Jan 12, 2:56 PM · Frameworks

Sat, Jan 11

trmdi updated the summary of D26484: Add KIO::DropJobFlag to allow manually showing the menu.
Sat, Jan 11, 2:04 PM · Frameworks
trmdi updated the diff for D26484: Add KIO::DropJobFlag to allow manually showing the menu.
  • use the flag approach and add DropJob::menuPopup()
Sat, Jan 11, 2:00 PM · Frameworks
trmdi added inline comments to D26484: Add KIO::DropJobFlag to allow manually showing the menu.
Sat, Jan 11, 12:51 PM · Frameworks
trmdi added inline comments to D26484: Add KIO::DropJobFlag to allow manually showing the menu.
Sat, Jan 11, 12:45 PM · Frameworks
trmdi added a comment to D26484: Add KIO::DropJobFlag to allow manually showing the menu.

Sorry I have no idea about the calling side in plasma. It sounds buggy indeed, if those are all calls on the same DropJob instance.

Sat, Jan 11, 10:56 AM · Frameworks

Fri, Jan 10

trmdi added a comment to D26484: Add KIO::DropJobFlag to allow manually showing the menu.

I have some question.
1, Should DropJob::setApplicationActions() be called only one time?
2, I see this when I drop multiple file types at once to the desktop (e.g. 2 jpg and 1 zip), the DropJob::setApplicationActions() is called 3 times as follow:

Fri, Jan 10, 5:34 PM · Frameworks
trmdi added a comment to D26525: Fix wallpaper destination path.

@mart
Are you ok with this now ?

Fri, Jan 10, 5:21 PM · Plasma
trmdi updated the summary of D26525: Fix wallpaper destination path.
Fri, Jan 10, 5:18 PM · Plasma
trmdi updated the summary of D26525: Fix wallpaper destination path.
Fri, Jan 10, 5:18 PM · Plasma
trmdi updated the diff for D26525: Fix wallpaper destination path.
  • Switch from FileCopyJob to CopyJob to allow showing file overwrite dialog
Fri, Jan 10, 5:16 PM · Plasma
trmdi added inline comments to D26525: Fix wallpaper destination path.
Fri, Jan 10, 1:57 PM · Plasma
trmdi added inline comments to D26525: Fix wallpaper destination path.
Fri, Jan 10, 12:40 PM · Plasma
trmdi retitled D26484: Add KIO::DropJobFlag to allow manually showing the menu from Add a new parameter for delaying showing menu to Popup menu again to reposition it.
Fri, Jan 10, 3:38 AM · Frameworks
trmdi abandoned D26514: Delay popup when dropping things into containments .
Fri, Jan 10, 3:36 AM · Plasma
trmdi removed a dependent revision for D26484: Add KIO::DropJobFlag to allow manually showing the menu: D26514: Delay popup when dropping things into containments .
Fri, Jan 10, 3:36 AM · Frameworks
trmdi removed a dependency for D26514: Delay popup when dropping things into containments : D26484: Add KIO::DropJobFlag to allow manually showing the menu.
Fri, Jan 10, 3:36 AM · Plasma
trmdi updated the summary of D26484: Add KIO::DropJobFlag to allow manually showing the menu.
Fri, Jan 10, 3:35 AM · Frameworks
trmdi updated the diff for D26484: Add KIO::DropJobFlag to allow manually showing the menu.
  • Simplify the approach
Fri, Jan 10, 3:33 AM · Frameworks

Thu, Jan 9

trmdi planned changes to D26514: Delay popup when dropping things into containments .
Thu, Jan 9, 5:44 PM · Plasma
trmdi planned changes to D26484: Add KIO::DropJobFlag to allow manually showing the menu.
Thu, Jan 9, 5:44 PM · Frameworks
trmdi updated the diff for D26525: Fix wallpaper destination path.
  • Improve code
Thu, Jan 9, 6:11 AM · Plasma
trmdi updated the diff for D26484: Add KIO::DropJobFlag to allow manually showing the menu.
  • Improve code
  • Improve code
Thu, Jan 9, 4:45 AM · Frameworks
trmdi updated the diff for D26484: Add KIO::DropJobFlag to allow manually showing the menu.
  • Improve code
Thu, Jan 9, 4:38 AM · Frameworks
trmdi updated the diff for D26484: Add KIO::DropJobFlag to allow manually showing the menu.
  • Remove the new signal and show a "Fetching data" menu while delaying
Thu, Jan 9, 4:03 AM · Frameworks
trmdi planned changes to D26484: Add KIO::DropJobFlag to allow manually showing the menu.
Thu, Jan 9, 2:52 AM · Frameworks

Wed, Jan 8

trmdi updated the summary of D26484: Add KIO::DropJobFlag to allow manually showing the menu.
Wed, Jan 8, 5:17 PM · Frameworks
trmdi updated the diff for D26514: Delay popup when dropping things into containments .
  • Sync with the dependency
Wed, Jan 8, 5:15 PM · Plasma
trmdi updated the diff for D26514: Delay popup when dropping things into containments .
  • Sync with the dependency
Wed, Jan 8, 5:09 PM · Plasma
trmdi updated the diff for D26484: Add KIO::DropJobFlag to allow manually showing the menu.
  • Move delayPopup to JobFlag
Wed, Jan 8, 5:00 PM · Frameworks
trmdi requested review of D26525: Fix wallpaper destination path.
Wed, Jan 8, 3:46 PM · Plasma
trmdi updated the diff for D26484: Add KIO::DropJobFlag to allow manually showing the menu.
  • Add a new function instead of changing the old exported one
Wed, Jan 8, 7:26 AM · Frameworks
trmdi updated the summary of D26514: Delay popup when dropping things into containments .
Wed, Jan 8, 3:52 AM · Plasma
trmdi added a reviewer for D26514: Delay popup when dropping things into containments : dfaure.
Wed, Jan 8, 3:33 AM · Plasma
trmdi added a reviewer for D26514: Delay popup when dropping things into containments : Plasma.
Wed, Jan 8, 3:29 AM · Plasma
trmdi added a dependent revision for D26484: Add KIO::DropJobFlag to allow manually showing the menu: D26514: Delay popup when dropping things into containments .
Wed, Jan 8, 3:26 AM · Frameworks
trmdi added a dependency for D26514: Delay popup when dropping things into containments : D26484: Add KIO::DropJobFlag to allow manually showing the menu.
Wed, Jan 8, 3:26 AM · Plasma
trmdi requested review of D26514: Delay popup when dropping things into containments .
Wed, Jan 8, 3:21 AM · Plasma

Tue, Jan 7

trmdi updated the summary of D26484: Add KIO::DropJobFlag to allow manually showing the menu.
Tue, Jan 7, 3:36 PM · Frameworks
trmdi updated the summary of D26484: Add KIO::DropJobFlag to allow manually showing the menu.
Tue, Jan 7, 3:13 PM · Frameworks
trmdi updated the summary of D26484: Add KIO::DropJobFlag to allow manually showing the menu.
Tue, Jan 7, 1:38 PM · Frameworks
trmdi updated the diff for D26484: Add KIO::DropJobFlag to allow manually showing the menu.
  • Use signal instead of timer
Tue, Jan 7, 1:33 PM · Frameworks
trmdi planned changes to D26484: Add KIO::DropJobFlag to allow manually showing the menu.
Tue, Jan 7, 9:11 AM · Frameworks
trmdi added a comment to D26484: Add KIO::DropJobFlag to allow manually showing the menu.

I don't understand the reasoning, what is this waiting for?

Tue, Jan 7, 8:10 AM · Frameworks
trmdi added a comment to D26484: Add KIO::DropJobFlag to allow manually showing the menu.

Sometimes 100ms is not enough, maybe there is a better way...

Tue, Jan 7, 7:52 AM · Frameworks
trmdi updated the summary of D26484: Add KIO::DropJobFlag to allow manually showing the menu.
Tue, Jan 7, 7:47 AM · Frameworks
trmdi updated the summary of D26484: Add KIO::DropJobFlag to allow manually showing the menu.
Tue, Jan 7, 7:43 AM · Frameworks
trmdi requested review of D26484: Add KIO::DropJobFlag to allow manually showing the menu.
Tue, Jan 7, 7:42 AM · Frameworks

Mon, Jan 6

trmdi added a comment to D4574: [WIP]: unify file drop menu and containment.

This patch seems to cause this bug: https://bugs.kde.org/show_bug.cgi?id=415917

Mon, Jan 6, 6:34 AM · Plasma