sitter (Harald Sitter)
Engineering

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Sep 15 2015, 12:04 PM (183 w, 5 h)
Availability
Available

Recent Activity

Today

sitter moved T10618: review our use of khelpcenter (and its deps) from Ready To Do to Blocked on the Neon board.
Tue, Mar 19, 2:47 PM · Neon
sitter updated the task description for T10618: review our use of khelpcenter (and its deps).
Tue, Mar 19, 2:44 PM · Neon
sitter updated the task description for T10618: review our use of khelpcenter (and its deps).
Tue, Mar 19, 2:36 PM · Neon
sitter added a comment to T10513: HWE again!.

livecd-rootfs changes now also in all branches pending ISO rebuilds and validation

Tue, Mar 19, 11:47 AM · Neon
sitter updated the task description for T10513: HWE again!.
Tue, Mar 19, 11:45 AM · Neon
sitter added a comment to D17913: Require CMake 3.4 and use the OpenSSL imported libs.

Looks like that broke something... note the output at the bottom

Tue, Mar 19, 11:16 AM
sitter added inline comments to D19856: find ruby gems & make coverage conditional on BUILD_COVERAGE.
Tue, Mar 19, 10:48 AM · Dolphin
sitter added a comment to T4969: fix qml module lookup.

Oh and since qml dependencies are spreading throughout the stack now it may actually be a good idea to reinvent the system and implement it as substvars ${qml:Depends}. To that end inspecting all modules installed by a package would be useful, alas, doing that technically has Qt tech but it's not available for external use! Namely qtcreator has a thing called (IIRC) qmljs which is meant to import models of all datatypes in modules, kdevelop has a fork of it as well. Unfortunately since it is not available from the outside it's probably still easier to have custom "finding" logic.

Tue, Mar 19, 9:50 AM · Neon

Yesterday

sitter added a comment to D19855: Fix bugzilla login page widgets tab order.

While that fixes the drkonqi bug just fine I am not sure that is the best fix for the problem. As I understand it KPasswordLineEdit doesn't set itself to StrongFocus, seeing as it is a replacement for QLineEdit that seems inconsistent and should be rectified though. IOW: I think KPasswordLineEdit should be changed to set a StrongFocus by default, same as QLineEdit.

Mon, Mar 18, 4:30 PM · Plasma
sitter added a reviewer for D19856: find ruby gems & make coverage conditional on BUILD_COVERAGE: Dolphin.
Mon, Mar 18, 2:39 PM · Dolphin
sitter requested review of D19856: find ruby gems & make coverage conditional on BUILD_COVERAGE.
Mon, Mar 18, 2:39 PM · Dolphin
sitter committed R318:81ff2a73f9d0: fix coverage generation when run through ctest (authored by sitter).
fix coverage generation when run through ctest
Mon, Mar 18, 2:24 PM
sitter committed R318:644d6f85223d: redo service menu ruby helpers from ground up more or less (authored by sitter).
redo service menu ruby helpers from ground up more or less
Mon, Mar 18, 1:04 PM
sitter closed D19334: redo service menu ruby helpers from ground up more or less.
Mon, Mar 18, 1:04 PM · Dolphin
sitter added a comment to D19786: Fix WebDAV directory renaming if KeepAlive is off.

setting server to keepalive=false? what is this? the 90's? :O

Mon, Mar 18, 11:49 AM · Frameworks
sitter committed R120:1467145971e5: Merge branch 'Plasma/5.15' (authored by sitter).
Merge branch 'Plasma/5.15'
Mon, Mar 18, 11:07 AM
sitter committed R120:1f3ab6f7dddb: [service runner] throw out kde3 "compat" code (authored by sitter).
[service runner] throw out kde3 "compat" code
Mon, Mar 18, 11:06 AM
sitter closed D19788: [service runner] throw out kde3 "compat" code.
Mon, Mar 18, 11:06 AM · Plasma
sitter updated the summary of D19788: [service runner] throw out kde3 "compat" code.
Mon, Mar 18, 10:57 AM · Plasma

Fri, Mar 15

sitter retitled D19788: [service runner] throw out kde3 "compat" code from [service runner] throw out kde3 "compat" code for KCMs to [service runner] throw out kde3 "compat" code.
Fri, Mar 15, 2:47 PM · Plasma
sitter added a reviewer for D19788: [service runner] throw out kde3 "compat" code: broulik.
Fri, Mar 15, 2:47 PM · Plasma
sitter requested review of D19788: [service runner] throw out kde3 "compat" code.
Fri, Mar 15, 2:47 PM · Plasma
sitter closed T9383: queue.rb to warn on excessive queing of jobs as Resolved.

https://github.com/pangea-project/pangea-tooling/commit/68eede405590fe1de2910945368d16f6e49f2602

Fri, Mar 15, 1:58 PM · Neon
sitter added a comment to T5069: package systemdgenie.

Heh, meanwhile I am not sure what to make of the current activity. It looks basically inactive for like a year or two now. The commits last year were more minor adjustments than anything. Plus it continues to be in playground with no apparent moves to change that. So... I am not sure this needs packaging at this time. If anything ... one should probably ask the author first if he has any plans to push it forwards towards production quality and extragear.

Fri, Mar 15, 1:25 PM · Neon
sitter updated the diff for D19612: RFC port to bugzilla REST API.

competing api design on commentsclient::getfrombug2

Fri, Mar 15, 1:22 PM · Plasma
sitter added a comment to T5069: package systemdgenie.

Is this blocked on something?

Fri, Mar 15, 11:17 AM · Neon
sitter requested review of D19779: point readme to the wiki page.
Fri, Mar 15, 10:40 AM · Frameworks
sitter added inline comments to D19767: Fix malloc/delete mismatch.
Fri, Mar 15, 10:09 AM · Frameworks, Dolphin
sitter added a comment to T10618: review our use of khelpcenter (and its deps).

Huh, that is actually a bug in all KCM-related tech I'd imagine. They all handle help independently of kxmlgui and thus do not transparently fall back to resolve help via the web when khelpcenter isn't avialable.

Fri, Mar 15, 9:48 AM · Neon

Thu, Mar 14

sitter updated the diff for D19612: RFC port to bugzilla REST API.

redo diff so it maybe doesn't include nonesense

Thu, Mar 14, 3:02 PM · Plasma
sitter updated the diff for D19612: RFC port to bugzilla REST API.

search now searches long description so only get somewhat pertinent bugs come back as results. also implement pagniation of results (ie. only 25 results at a time are queried, this is both much faster to query and to parse). boths somewhat reliant on undocumented features of the webservice api (they are however intentional features since they have explicit code in the webservice code)

Thu, Mar 14, 2:59 PM · Plasma
sitter closed T5302: Review ISO contents for Cruft as Resolved.

I did a review. there honestly isn't much that sticks out

Thu, Mar 14, 1:18 PM · Neon
sitter updated the task description for T10618: review our use of khelpcenter (and its deps).
Thu, Mar 14, 12:48 PM · Neon
sitter triaged T10618: review our use of khelpcenter (and its deps) as Low priority.
Thu, Mar 14, 12:44 PM · Neon
sitter created T10616: drop qt4.
Thu, Mar 14, 11:58 AM · Neon

Wed, Mar 13

sitter committed R843:1a73c1eade1f: start socket (authored by sitter).
start socket
Wed, Mar 13, 3:00 PM
sitter committed R843:a1def5560a8a: implement zero downtime restarts & let systemd manage the socket (authored by sitter).
implement zero downtime restarts & let systemd manage the socket
Wed, Mar 13, 3:00 PM
sitter committed R843:e217f1caaede: use master instead of milonia name (authored by sitter).
use master instead of milonia name
Wed, Mar 13, 3:00 PM
sitter closed T5513: neon-sftp-bridge should systemd socket activate as Resolved.

seems to be working. should there be problems in the next couple of days this change is probably why ;)

Wed, Mar 13, 2:27 PM · Neon
sitter added a comment to T4969: fix qml module lookup.

To add: the helper is called qmlimportscanner and generates a json blob of all modules inside a dir e.g. qmlimportscanner -rootPath . it may be compiled with qmlplugindump which introspects modules (which is more than we need unfortunately) e.g. qmlplugindump Qt.labs.folderlistmodexl 2.0.

Wed, Mar 13, 1:36 PM · Neon
sitter closed T5244: newer new appstream as Resolved.
Wed, Mar 13, 1:27 PM · Neon
sitter committed R840:ad3c6c30a694: port to ruby 2.5.1 (authored by sitter).
port to ruby 2.5.1
Wed, Mar 13, 12:31 PM
sitter committed R840:7db15c85312f: port from file config to builtin config (authored by sitter).
port from file config to builtin config
Wed, Mar 13, 12:31 PM
sitter added a comment to T10285: assert release coverage.

Has overlap with T9388 see comment @ https://phabricator.kde.org/T9388#178663

Wed, Mar 13, 12:21 PM · Neon
sitter added a comment to T9388: version status page.

You know, I feel like appstream can help us here. Certainly with the individual extragear apps. We could simply crawl all application appstream components we have packaged, then exclude all which aren't clearly KDE, then exclude all which are from a package that is in a release bundle and presto we have nice metadata to render into a website.

Wed, Mar 13, 12:20 PM · Neon
sitter committed R841:d9094681d131: port to ruby 2.5.1 (authored by sitter).
port to ruby 2.5.1
Wed, Mar 13, 12:09 PM
sitter committed R841:dd5ab36a9137: port from file config to builtin config (authored by sitter).
port from file config to builtin config
Wed, Mar 13, 12:09 PM

Tue, Mar 12

sitter committed R237:516f558742df: [kconf_update] move from custom logging tech to qCDebug (authored by sitter).
[kconf_update] move from custom logging tech to qCDebug
Tue, Mar 12, 1:48 PM
sitter closed D19508: [kconf_update] move from custom logging tech to qCDebug.
Tue, Mar 12, 1:48 PM · Frameworks
sitter triaged T10604: backport poppler as Low priority.
Tue, Mar 12, 1:46 PM · Neon
sitter accepted D19596: color monochrome icons to tooltip colors.

It's gorgeous!

Tue, Mar 12, 12:07 PM · Plasma
sitter added a comment to T10091: migrate server.

ping

Tue, Mar 12, 11:32 AM · Neon
sitter committed R102:e1f29e14e2df: Merge branch 'Plasma/5.15' (authored by sitter).
Merge branch 'Plasma/5.15'
Tue, Mar 12, 11:16 AM
sitter committed R102:515575b9495b: style++ (authored by sitter).
style++
Tue, Mar 12, 11:16 AM
sitter closed D19704: style++.
Tue, Mar 12, 11:16 AM · Plasma
sitter committed R102:2e07d3648557: Merge branch 'Plasma/5.15' (authored by sitter).
Merge branch 'Plasma/5.15'
Tue, Mar 12, 11:11 AM
sitter committed R102:dbaf5ba7e833: connect clicked signal of view (again) (authored by sitter).
connect clicked signal of view (again)
Tue, Mar 12, 11:11 AM
sitter closed D19703: connect clicked signal of view (again).
Tue, Mar 12, 11:11 AM · Plasma
sitter requested review of D19704: style++.
Tue, Mar 12, 10:21 AM · Plasma
sitter requested review of D19703: connect clicked signal of view (again).
Tue, Mar 12, 10:19 AM · Plasma

Mon, Mar 11

sitter accepted D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox.

I'll put it on the record that I still think the "yo you wanna restart now" message should be at the top of the KCM and not inside the groupbox.

Mon, Mar 11, 3:46 PM · Plasma
sitter updated the diff for D19612: RFC port to bugzilla REST API.
  • repair dupe detection - was running on empty list
  • refactor bug fetching to not include comment fetching and port all users of it
  • stop holding all comments of all bugs in memory. we have no use for like 99% of them after parsing
  • rebase on master
Mon, Mar 11, 3:40 PM · Plasma
sitter committed R871:f7fbcff86ac4: drop explicit disconnect in dtor (authored by sitter).
drop explicit disconnect in dtor
Mon, Mar 11, 3:14 PM
sitter closed D19684: drop explicit disconnect in dtor.
Mon, Mar 11, 3:14 PM · Plasma
sitter requested review of D19684: drop explicit disconnect in dtor.
Mon, Mar 11, 3:07 PM · Plasma
sitter added a comment to D19562: [Logout Screen] Show info that rebooting will enter firmware setup.

I think you lost the QML part of the diff.

Mon, Mar 11, 2:21 PM · Plasma
sitter requested changes to D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox.

XML broken.

Mon, Mar 11, 2:00 PM · Plasma
sitter added a comment to D19562: [Logout Screen] Show info that rebooting will enter firmware setup.

I think it's bad practice to do blocking dbus calls.

Mon, Mar 11, 1:43 PM · Plasma
sitter added a comment to D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox.

I feel like this would be nicer a dbus interface class thingy.

Mon, Mar 11, 11:13 AM · Plasma
sitter added a comment to D19334: redo service menu ruby helpers from ground up more or less.

Could this be a packaging problem in your distro?

Mon, Mar 11, 10:20 AM · Dolphin

Fri, Mar 8

sitter triaged T9791: What to do with projects with KDE4 translations? as Normal priority.
Fri, Mar 8, 2:50 PM · Neon
sitter requested review of D19612: RFC port to bugzilla REST API.
Fri, Mar 8, 2:43 PM · Plasma
sitter added a comment to T9791: What to do with projects with KDE4 translations?.

I see code for this in tooling. Has this been resolved?

Fri, Mar 8, 1:16 PM · Neon
sitter moved T10478: document snap tech from Ready To Do to Doing on the Neon board.
Fri, Mar 8, 1:13 PM · Neon
sitter added a comment to D19599: textfield height based only on clear text.

LGTM, but do we need the MMM there? Wouldn't one M do? Or if control.text is always a string we don't need the ""+ at all?

Fri, Mar 8, 10:43 AM · Frameworks
sitter added a comment to D19596: color monochrome icons to tooltip colors.

Following Kai's question... wouldn't KIconLoader::global make the entire static obsolete?

Fri, Mar 8, 10:33 AM · Plasma
sitter committed R410:2486cfa6c6e7: fix parallel building by forcing correct dependency order (authored by sitter).
fix parallel building by forcing correct dependency order
Fri, Mar 8, 10:25 AM
sitter closed D19590: fix parallel building by forcing correct dependency order.
Fri, Mar 8, 10:25 AM

Thu, Mar 7

sitter added a comment to D19596: color monochrome icons to tooltip colors.

The sidepanel (which I guess is the mainview) gets the icon from InfoKcmModel::data from what I can tell. ::data and ::generateToolTipLine are the only places where I see ::icon get called. So what I am thinking is these changes:

Thu, Mar 7, 5:16 PM · Plasma
sitter added a comment to D19595: use a TextMetrics for height.

I think this is the wrong TextField for SDDM/kscreenlocker actually. They use PlasmaComponents 2, which judging by my printf debugging isn't loading that particular TextField.qml.

Thu, Mar 7, 4:44 PM · Plasma
sitter edited P340 ~/.config/fontconfig/fonts.conf.
Thu, Mar 7, 4:42 PM
sitter updated the title for P340 ~/.config/fontconfig/fonts.conf from untitled to Masterwork From Distant Lands.
Thu, Mar 7, 4:41 PM
sitter requested changes to D19596: color monochrome icons to tooltip colors.

That seems to break the category icons because KDE::icon(menuItem->kcm().icon() is only working on Kcm entries, while KcmCategory entries overload ::icon with divergent behavior.

Thu, Mar 7, 4:16 PM · Plasma
sitter added a reviewer for D19590: fix parallel building by forcing correct dependency order: aacid.
Thu, Mar 7, 11:01 AM
sitter requested review of D19590: fix parallel building by forcing correct dependency order.
Thu, Mar 7, 11:00 AM
sitter accepted D19578: tagme: Do not use git push --tags.

lgtm

Thu, Mar 7, 10:17 AM

Wed, Mar 6

sitter closed D19558: disable motd polling from ubuntu.com.
Wed, Mar 6, 10:31 AM
sitter added reviewers for D19558: disable motd polling from ubuntu.com: jriddell, bshah.
Wed, Mar 6, 9:40 AM
sitter requested review of D19558: disable motd polling from ubuntu.com.
Wed, Mar 6, 9:40 AM

Tue, Mar 5

sitter committed R871:082d0f1bb10e: move version definition into generated header instead of passing it on CLI (authored by sitter).
move version definition into generated header instead of passing it on CLI
Tue, Mar 5, 3:25 PM
sitter closed D19543: move version definition into generated header instead of passing it on CLI.
Tue, Mar 5, 3:25 PM · Plasma
sitter added a reviewer for D19543: move version definition into generated header instead of passing it on CLI: jriddell.
Tue, Mar 5, 3:23 PM · Plasma
sitter requested review of D19543: move version definition into generated header instead of passing it on CLI.
Tue, Mar 5, 3:22 PM · Plasma

Mon, Mar 4

sitter updated the task description for T10513: HWE again!.
Mon, Mar 4, 4:32 PM · Neon
sitter added a comment to T10513: HWE again!.

livecd changes simmering in unstable... going to wait for a week before proceeding.

Mon, Mar 4, 4:31 PM · Neon
sitter moved T10513: HWE again! from Ready To Do to Doing on the Neon board.
Mon, Mar 4, 4:30 PM · Neon
sitter moved T10513: HWE again! from Discussing to Ready To Do on the Neon board.
Mon, Mar 4, 4:30 PM · Neon
sitter committed R352:25ae3e8fadc4: Merge branch 'Applications/18.12' (authored by sitter).
Merge branch 'Applications/18.12'
Mon, Mar 4, 4:12 PM
sitter committed R352:4cc7c44589f0: Fix use after free in RadialMap::Widget::invalidate() (authored by janus).
Fix use after free in RadialMap::Widget::invalidate()
Mon, Mar 4, 4:12 PM
sitter closed D11188: Fix use after free in RadialMap::Widget::invalidate().
Mon, Mar 4, 4:12 PM