sitter (Harald Sitter)
Engineering

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Sep 15 2015, 12:04 PM (217 w, 1 d)
Availability
Available

Recent Activity

Yesterday

sitter committed R871:c6cfdb243c3e: Merge branch 'Plasma/5.17' (authored by sitter).
Merge branch 'Plasma/5.17'
Wed, Nov 13, 5:09 PM
sitter committed R871:4f161fa0b57f: disable systeminfo test on systems without uname (authored by sitter).
disable systeminfo test on systems without uname
Wed, Nov 13, 5:09 PM
sitter committed R871:fb50d436d178: fix msvc compatibility (authored by sitter).
fix msvc compatibility
Wed, Nov 13, 5:09 PM
sitter added a comment to T11933: Debrand KDE Applications as Release Service.

^ Plays into https://github.com/ximion/appstream/issues/240

Wed, Nov 13, 1:01 PM · KDE Promo, KDE Applications, Goal: All About the Apps

Mon, Nov 11

sitter committed R871:883769ab88c1: Merge branch 'Plasma/5.17' (authored by sitter).
Merge branch 'Plasma/5.17'
Mon, Nov 11, 1:21 PM
sitter committed R871:8a03e199c204: move plus character in query test to connection (authored by sitter).
move plus character in query test to connection
Mon, Nov 11, 1:21 PM
sitter committed R871:8eedb5a0eaae: Merge branch 'Plasma/5.17' (authored by sitter).
Merge branch 'Plasma/5.17'
Mon, Nov 11, 1:12 PM
sitter committed R871:885a58205ba0: force encoding on all queries (authored by sitter).
force encoding on all queries
Mon, Nov 11, 1:12 PM
sitter added a comment to T11979: KDE neon's Welcome Screen.

OEM configuration is driven by installers already e.g. calamares https://people.ubuntu.com/~apachelogger/screencasts/vokoscreen-2019-05-03_11-43-36.mkv or ubiquity https://userbase.kde.org/Neon/Installation/OEM#First_Boot
Both aforementioned use cases are addressed by the same software using the same code. The "steps" can be different though (e.g. OEM config mostly needs no partitioning so this step is not part of it).

Mon, Nov 11, 10:46 AM · VDG

Sat, Nov 9

GB_2 awarded D25191: replace bespoke xkb geometry parser with xkb a Like token.
Sat, Nov 9, 12:30 PM · Plasma

Fri, Nov 8

sitter updated the diff for D25191: replace bespoke xkb geometry parser with xkb.

fix tooltip scaling to show keys at 2.5 times their original size

Fri, Nov 8, 1:30 PM · Plasma
sitter updated the diff for D25191: replace bespoke xkb geometry parser with xkb.

install bin, drop ki18n as link target (not used at this time)

Fri, Nov 8, 1:05 PM · Plasma
sitter committed R871:ec4a4cb89df7: Merge branch 'Plasma/5.17' (authored by sitter).
Merge branch 'Plasma/5.17'
Fri, Nov 8, 12:18 PM
sitter committed R871:4e29b8a75635: force-encode passwords on login (authored by sitter).
force-encode passwords on login
Fri, Nov 8, 12:18 PM
sitter added a comment to T11979: KDE neon's Welcome Screen.

We have distro-independent ways to refer to software (appstream ids) so software stores understand what we mean. So, there is no technical problem here. Heck, even without it there wouldn't be. Calamares manages to be a distro-independent installer that can be used by all distros and made their own. There is no reason we couldn't have the same for a first start experience.

Fri, Nov 8, 11:05 AM · VDG
sitter added a comment to D25148: Add binary-version dependency of hwcomposer on glutils.

Oh oh oh, I forgot to actually read this.

Fri, Nov 8, 10:21 AM

Thu, Nov 7

sitter committed R871:0f343ffbeb0f: unbreak crash reports involving QML (authored by sitter).
unbreak crash reports involving QML
Thu, Nov 7, 3:40 PM
sitter requested review of D25191: replace bespoke xkb geometry parser with xkb.
Thu, Nov 7, 1:17 PM · Plasma
sitter added a comment to T11933: Debrand KDE Applications as Release Service.

I figure we want maximum exposure for this. So, much like we do with Plasma already I would suggest that we post the announcement on kde.org AND copy it to the dot.

Thu, Nov 7, 12:52 PM · KDE Promo, KDE Applications, Goal: All About the Apps

Wed, Nov 6

sitter added inline comments to D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO.
Wed, Nov 6, 2:04 PM · Frameworks
sitter added a comment to D25159: Fix linking to libssh 0.9.1.

D25170 for when that lands

Wed, Nov 6, 1:00 PM · Frameworks, Dolphin
sitter added a comment to D25170: make the libssh finder ensure the new ssh target is set.

NB: depends on https://gitlab.com/libssh/libssh-mirror/merge_requests/71 getting landed.

Wed, Nov 6, 12:59 PM · Frameworks, Dolphin
sitter requested review of D25170: make the libssh finder ensure the new ssh target is set.
Wed, Nov 6, 12:59 PM · Frameworks, Dolphin

Tue, Nov 5

sitter added a comment to D25159: Fix linking to libssh 0.9.1.
In D25159#559016, @asn wrote:

We moved from a manually generated libssh-config.cmake to install(EXPORTS libssh-config) and it does things completely different.

I'm currently trying to fix it. However better don't apply this as ssh_shared will vanish as a target.

I wonder how I can define LIBSSH_LIBRARIES again with EXPORTS.

Tue, Nov 5, 4:49 PM · Frameworks, Dolphin
sitter accepted D25159: Fix linking to libssh 0.9.1.

I think there's a smarter way of dealing with this somewhere in our finder, not blocking though. I'll take a look when I find a minute.

Tue, Nov 5, 4:26 PM · Frameworks, Dolphin
sitter committed R871:210c9d88fb81: disable bug report when there are signs of an update (authored by sitter).
disable bug report when there are signs of an update
Tue, Nov 5, 1:01 PM
sitter closed D25002: disable bug report when there are signs of an update.
Tue, Nov 5, 1:01 PM · Plasma
sitter committed R285:cc0d3c8b7977: actually set a dependency between kcrashtest and test_crasher (authored by sitter).
actually set a dependency between kcrashtest and test_crasher
Tue, Nov 5, 11:39 AM
sitter closed D25154: actually set a dependency between kcrashtest and test_crasher.
Tue, Nov 5, 11:39 AM · Frameworks
sitter closed D25153: disable kcrashtest and its helper executable test_crasher on windows.
Tue, Nov 5, 11:39 AM · Frameworks
sitter committed R285:d3b83d931176: disable kcrashtest and its helper executable test_crasher on windows (authored by sitter).
disable kcrashtest and its helper executable test_crasher on windows
Tue, Nov 5, 11:39 AM
sitter added a reverting change for R285:a105c4520880: Disable execution of test_crasher, which enters an infinite loop on Windows…: R285:cc5f139a614a: Revert "Disable execution of test_crasher, which enters an infinite loop on….
Tue, Nov 5, 11:39 AM
sitter committed R285:cc5f139a614a: Revert "Disable execution of test_crasher, which enters an infinite loop on… (authored by sitter).
Revert "Disable execution of test_crasher, which enters an infinite loop on…
Tue, Nov 5, 11:39 AM
sitter added a comment to D25152: Reenable the tests and only disable krcrashtest on windows.

D25153 for reference.

Tue, Nov 5, 10:54 AM · Frameworks
sitter requested review of D25154: actually set a dependency between kcrashtest and test_crasher.
Tue, Nov 5, 10:25 AM · Frameworks
sitter requested review of D25153: disable kcrashtest and its helper executable test_crasher on windows.
Tue, Nov 5, 10:23 AM · Frameworks

Wed, Oct 30

sitter added a comment to D25079: [CopyJob] Increase the amount of data sendfile can copy at once.

TBH, I would move away from the hardcoding in general.... try to sendfile size_of_file and if n < size use n as new count for the next cycle. The second cycle will use the maximum regardless of what the specific kernel version has as maximum.
The maximum is an implementation detail of the kernel that may change every release, so hardcoding anything seems wrong here.

Wed, Oct 30, 4:13 PM · Frameworks

Tue, Oct 29

sitter updated the diff for D25002: disable bug report when there are signs of an update.

typo--

Tue, Oct 29, 11:21 AM · Plasma
sitter updated the diff for D25002: disable bug report when there are signs of an update.

switch from list to bool since we don't actually use the list anyway

Tue, Oct 29, 11:19 AM · Plasma

Mon, Oct 28

sitter added inline comments to D25002: disable bug report when there are signs of an update.
Mon, Oct 28, 3:57 PM · Plasma
sitter planned changes to D25002: disable bug report when there are signs of an update.
Mon, Oct 28, 3:57 PM · Plasma
sitter requested review of D25002: disable bug report when there are signs of an update.
Mon, Oct 28, 12:26 PM · Plasma

Fri, Oct 25

sitter committed R241:de3ca85f058e: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds (authored by sitter).
auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds
Fri, Oct 25, 11:14 AM
sitter closed D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds.
Fri, Oct 25, 11:14 AM · Frameworks
sitter committed R263:e9387f561fa2: fix default shortcut detection (authored by sitter).
fix default shortcut detection
Fri, Oct 25, 10:44 AM
sitter closed D24908: fix default shortcut detection.
Fri, Oct 25, 10:44 AM · Frameworks
sitter added a comment to D24887: WIP slave command behavior assertion system.

About the list of unexpected signals in forCommand():

Fri, Oct 25, 9:48 AM · Frameworks

Thu, Oct 24

sitter added inline comments to D24908: fix default shortcut detection.
Thu, Oct 24, 10:21 PM · Frameworks
sitter added a comment to D24908: fix default shortcut detection.

Supposedly, I was being lazy though since there is no pre existing test and I don't exactly know if there's anything to watch out for when testing widgets (as in: I've never written a widget test before).

Thu, Oct 24, 8:35 PM · Frameworks
sitter added a comment to D24641: Collect more information from version control systems.

Hm, how about separate functions though? With a single stat any given build still needs N process forks even when they only want 1 value.

Thu, Oct 24, 10:22 AM · Build System, Frameworks
sitter added a reviewer for D24908: fix default shortcut detection: dfaure.
Thu, Oct 24, 9:40 AM · Frameworks
sitter updated the test plan for D24908: fix default shortcut detection.
Thu, Oct 24, 9:40 AM · Frameworks
sitter requested review of D24908: fix default shortcut detection.
Thu, Oct 24, 9:39 AM · Frameworks

Wed, Oct 23

sitter committed R871:fff04078f84f: Merge branch 'Plasma/5.17' (authored by sitter).
Merge branch 'Plasma/5.17'
Wed, Oct 23, 2:59 PM
sitter committed R871:45ea4d554c54: typo-- (authored by sitter).
typo--
Wed, Oct 23, 2:59 PM
sitter accepted D24890: Report windowing system.

Oh it's gorgeous!

Wed, Oct 23, 2:44 PM · Plasma
sitter requested changes to D24890: Report windowing system.
Wed, Oct 23, 2:17 PM · Plasma
sitter added a comment to T10217: Package Kolorfill.

Not sure if that sort of application really needs to have regular commits ;)

Wed, Oct 23, 12:49 PM · Neon
sitter abandoned D23537: extend state verification to open connection commands.

Replaced by D24887 which instead creates a more generic system to verify slave behavior.

Wed, Oct 23, 12:45 PM · Frameworks
sitter requested review of D24887: WIP slave command behavior assertion system.
Wed, Oct 23, 12:44 PM · Frameworks

Tue, Oct 22

sitter updated the summary of D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds.
Tue, Oct 22, 10:34 AM · Frameworks
sitter updated the diff for D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds.

remove warning

Tue, Oct 22, 10:33 AM · Frameworks
sitter added inline comments to D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds.
Tue, Oct 22, 9:54 AM · Frameworks

Mon, Oct 21

sitter committed R971:65ebfb01567e: point filelight to new windows store version (authored by sitter).
point filelight to new windows store version
Mon, Oct 21, 3:21 PM
sitter planned changes to D23537: extend state verification to open connection commands.
Mon, Oct 21, 2:56 PM · Frameworks
sitter added a comment to D23537: extend state verification to open connection commands.

I've actually started work on a more general system for this. Will update soon.

Mon, Oct 21, 2:56 PM · Frameworks
sitter committed R241:ecb39f191560: typo-- (authored by sitter).
typo--
Mon, Oct 21, 1:23 PM
sitter requested review of D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds.
Mon, Oct 21, 11:38 AM · Frameworks
sitter committed R223:568f11b0678e: don't crash on nullptr pdfOptionsPage (authored by sitter).
don't crash on nullptr pdfOptionsPage
Mon, Oct 21, 9:39 AM
sitter committed R223:596b2d3019e3: Merge branch 'Applications/19.08' (authored by sitter).
Merge branch 'Applications/19.08'
Mon, Oct 21, 9:39 AM
sitter closed D24696: don't crash on nullptr pdfOptionsPage.
Mon, Oct 21, 9:39 AM · Okular
sitter committed R223:235164b264f7: don't crahs on nullptr pdfOptionsPage (authored by sitter).
don't crahs on nullptr pdfOptionsPage
Mon, Oct 21, 9:39 AM

Fri, Oct 18

sitter accepted D24727: Fix NOAA picture of the day provider.

works well enough it seems

Fri, Oct 18, 2:08 PM · Plasma
sitter added a comment to D24727: Fix NOAA picture of the day provider.

When I put the code in a minimal standalone program I can confirm that the code works just fine. Are you sure your testing methodology is sound @ngraham ?

Fri, Oct 18, 10:24 AM · Plasma

Thu, Oct 17

sitter added inline comments to D24568: Provide clang-format target with a KDE Frameworks style file.
Thu, Oct 17, 9:33 AM · Build System, Frameworks
sitter committed R320:4197683e7e33: Merge branch 'Applications/19.08' (authored by sitter).
Merge branch 'Applications/19.08'
Thu, Oct 17, 9:05 AM
sitter committed R320:45b1327a6dac: fix password error condition handling of smb mount (authored by sitter).
fix password error condition handling of smb mount
Thu, Oct 17, 9:05 AM
sitter closed D24487: fix password error condition handling of smb mount.
Thu, Oct 17, 9:05 AM · Frameworks, Dolphin
sitter committed R106:726e7b6d1815: fix nvidia line part count (authored by sitter).
fix nvidia line part count
Thu, Oct 17, 9:04 AM
sitter closed D24694: fix part count.
Thu, Oct 17, 9:04 AM · Plasma

Wed, Oct 16

sitter added a reviewer for D24696: don't crash on nullptr pdfOptionsPage: aacid.
Wed, Oct 16, 12:50 PM · Okular
sitter requested review of D24696: don't crash on nullptr pdfOptionsPage.
Wed, Oct 16, 12:50 PM · Okular
sitter added reviewers for D24694: fix part count: davidedmundson, ahiemstra.
Wed, Oct 16, 11:40 AM · Plasma
sitter requested review of D24694: fix part count.
Wed, Oct 16, 11:39 AM · Plasma
sitter committed R883:1553901: remove mention of nvidia stats support.
remove mention of nvidia stats support
Wed, Oct 16, 10:20 AM

Tue, Oct 15

sitter committed R241:c2bd18f17e61: give all pointers in slavebase a default init to nullptr (authored by sitter).
give all pointers in slavebase a default init to nullptr
Tue, Oct 15, 9:14 AM
sitter closed D24655: give all pointers in slavebase a default init to nullptr.
Tue, Oct 15, 9:14 AM · Frameworks
sitter requested review of D24655: give all pointers in slavebase a default init to nullptr.
Tue, Oct 15, 8:52 AM · Frameworks

Oct 15 2019

sitter accepted D24639: Update link to the impressum. It was broken since at least 9 years.

Thanks!

Oct 15 2019, 8:42 AM
sitter added a comment to D24641: Collect more information from version control systems.

Do we have a request for this outside kbibtex? My attitude towards adding things to ECM is always "is there more than one user".

Oct 15 2019, 8:24 AM · Build System, Frameworks
sitter committed R241:5f66badc6e7a: ftptest: replace logger-colors with logger (authored by sitter).
ftptest: replace logger-colors with logger
Oct 15 2019, 7:44 AM

Oct 14 2019

sitter closed D24631: exclude ioslaves directory from api docs.
Oct 14 2019, 1:58 PM · Frameworks
sitter committed R241:d05d03f2f13e: exclude ioslaves directory from api docs (authored by sitter).
exclude ioslaves directory from api docs
Oct 14 2019, 1:58 PM
sitter committed R241:c847c2c79b0e: ftptest: refactor the daemon startup into its own helper function (authored by sitter).
ftptest: refactor the daemon startup into its own helper function
Oct 14 2019, 12:09 PM
sitter committed R241:3ac354ea8e6c: ftptest: mark overwrite without overwrite flag no longer failing (authored by sitter).
ftptest: mark overwrite without overwrite flag no longer failing
Oct 14 2019, 12:09 PM
sitter requested review of D24631: exclude ioslaves directory from api docs.
Oct 14 2019, 11:48 AM · Frameworks
sitter added a comment to D24626: install ftpd gem for KIO ftp tests.

Thanks for this - i'll get this integrated soon.

Please note that Ruby is totally unavailable on our Windows builders - will you be making the presence of this gem optional (just disabling the unit tests when it is unavailable) in KIO?

Oct 14 2019, 11:36 AM
sitter added a reviewer for D24626: install ftpd gem for KIO ftp tests: Sysadmin.
Oct 14 2019, 10:15 AM
sitter requested review of D24626: install ftpd gem for KIO ftp tests.
Oct 14 2019, 10:15 AM
sitter committed R241:a92123d8b0dd: consider ftpd not required for the time being (authored by sitter).
consider ftpd not required for the time being
Oct 14 2019, 10:11 AM