sitter (Harald Sitter)
Engineering

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Sep 15 2015, 12:04 PM (226 w, 6 d)
Availability
Available

Recent Activity

Today

sitter requested review of D26785: cleanup devinfo header includes.
Mon, Jan 20, 11:41 AM · Plasma

Fri, Jan 17

sitter retitled D26730: parse xorg version for nicer display from pare xorg version for nicer display to parse xorg version for nicer display.
Fri, Jan 17, 5:56 PM · Plasma
sitter added a comment to D26733: sync tooltip delay with systemsettings.

Thanks for context though.

Fri, Jan 17, 5:56 PM · Plasma
sitter requested review of D26733: sync tooltip delay with systemsettings.
Fri, Jan 17, 5:51 PM · Plasma
sitter triaged T12558: lintqml install without recommends as High priority.
Fri, Jan 17, 5:28 PM · Neon
sitter requested review of D26730: parse xorg version for nicer display.
Fri, Jan 17, 3:55 PM · Plasma
sitter updated the diff for D26729: do not disable getifaddrs use because of sa_len availablility.

committing the latest working tree helps a lot -.-

Fri, Jan 17, 3:25 PM · Plasma
sitter requested review of D26729: do not disable getifaddrs use because of sa_len availablility.
Fri, Jan 17, 3:24 PM · Plasma
sitter committed R102:8a4f8c4a2d1c: Merge branch 'Plasma/5.18' (authored by sitter).
Merge branch 'Plasma/5.18'
Fri, Jan 17, 1:34 PM
sitter committed R102:764fce4aefbe: make sure Solid::Battery is not deleted from QML (authored by sitter).
make sure Solid::Battery is not deleted from QML
Fri, Jan 17, 1:33 PM
sitter closed D26725: make sure Solid::Battery is not deleted from QML.
Fri, Jan 17, 1:33 PM · Plasma
sitter updated the summary of D26725: make sure Solid::Battery is not deleted from QML.
Fri, Jan 17, 1:29 PM · Plasma
sitter requested review of D26725: make sure Solid::Battery is not deleted from QML.
Fri, Jan 17, 12:17 PM · Plasma

Thu, Jan 16

sitter added inline comments to D26709: add gpu entry to about system.
Thu, Jan 16, 3:46 PM · Plasma
sitter added a dependent revision for D26667: refactor about-distro to more generically support textual dumps: D26709: add gpu entry to about system.
Thu, Jan 16, 3:06 PM · Plasma
sitter requested review of D26709: add gpu entry to about system.
Thu, Jan 16, 3:06 PM · Plasma
sitter updated the diff for D26667: refactor about-distro to more generically support textual dumps.

remove extra file

Thu, Jan 16, 2:48 PM · Plasma
sitter updated the diff for D26667: refactor about-distro to more generically support textual dumps.

split into one class per file

Thu, Jan 16, 2:42 PM · Plasma
sitter updated the diff for D25682: add initial wsdiscovery support.

redesign finish system

Thu, Jan 16, 2:06 PM · Frameworks, Dolphin

Wed, Jan 15

sitter updated subscribers of D26405: Add mime type for backtraces saved from DrKonqi.

+1 form me. not sure if @mpyne wants to have a look as well.

Wed, Jan 15, 4:36 PM · Frameworks
sitter triaged T12545: revise lintqml as Low priority.
Wed, Jan 15, 4:23 PM · Neon
sitter closed T10513: HWE again! as Resolved.

Revisit for 20.04 I guess. Not much worth putting effort into this now.

Wed, Jan 15, 1:49 PM · Neon
sitter added inline comments to D26650: Use KService to look for Filelight.
Wed, Jan 15, 1:22 PM · Frameworks
sitter updated the diff for D26667: refactor about-distro to more generically support textual dumps.

forgot to actually write cleanup after having wanted to twice :'D

Wed, Jan 15, 9:27 AM · Plasma

Tue, Jan 14

sitter added a comment to D26667: refactor about-distro to more generically support textual dumps.

not sure if it's worth splitting into multiple files. personally I prefer many tiny files over one long one though *shrug*.

Tue, Jan 14, 3:37 PM · Plasma
sitter requested review of D26667: refactor about-distro to more generically support textual dumps.
Tue, Jan 14, 3:35 PM · Plasma
sitter committed R106:a01b1f75f18d: typo-- (authored by sitter).
typo--
Tue, Jan 14, 10:28 AM
sitter committed R263:59954316cc95: remove ability to report bugs against arbitrary stuff from a static list (authored by sitter).
remove ability to report bugs against arbitrary stuff from a static list
Tue, Jan 14, 10:06 AM
sitter closed D26019: remove ability to report bugs against arbitrary stuff from a static list.
Tue, Jan 14, 10:06 AM · Frameworks
sitter committed R263:3014b0278c50: remove compiler information from bug report dialog (authored by sitter).
remove compiler information from bug report dialog
Tue, Jan 14, 10:06 AM
sitter closed D26014: remove compiler information from bug report dialog.
Tue, Jan 14, 10:06 AM · Frameworks
sitter added a comment to D26019: remove ability to report bugs against arbitrary stuff from a static list.

Mh, I actually was lying it's documented on the setter https://api.kde.org/frameworks/kcoreaddons/html/classKAboutData.html#a0167de5a0565e61e57e8f6ee7dcce71b :)

Tue, Jan 14, 10:05 AM · Frameworks

Mon, Jan 13

sitter added inline comments to D25682: add initial wsdiscovery support.
Mon, Jan 13, 1:12 PM · Frameworks, Dolphin
sitter updated the summary of D25682: add initial wsdiscovery support.
Mon, Jan 13, 1:12 PM · Frameworks, Dolphin
sitter updated the diff for D25682: add initial wsdiscovery support.

since there's not been much design input let's move to actual review

Mon, Jan 13, 1:11 PM · Frameworks, Dolphin
sitter added a comment to D26575: Add command line options --bugzilla-project and --release-path.

This should be added to the scm metadata and then picked up from there

Sure, will be a good addition, but will need some time for analysis, design and implementation and therefore cannot be a quick fix, which is covered by this request.

Mon, Jan 13, 10:48 AM
sitter added inline comments to D26019: remove ability to report bugs against arbitrary stuff from a static list.
Mon, Jan 13, 10:13 AM · Frameworks

Sat, Jan 11

sitter added a comment to D26575: Add command line options --bugzilla-project and --release-path.

This should be added to the scm metadata and then picked up from there, not as an option on releaseme specifically as this isn't releaseme specific information.
That said I suppose it'd be best to actually extract this out of the source, but I am not sure there's an easy way to get that going without moving kaboutdata to cmake so metadata is likely the most reasonable thing to do :/

Sat, Jan 11, 1:13 AM

Tue, Jan 7

sitter added a comment to D26180: phonon : build against "older" Qt5 versions.

KF5's Qt support strategy is sound and so phonon should follow that. We've moved away from keeping phonon backwards compatible to the big bang, it's not sustainable.

Tue, Jan 7, 2:04 PM
sitter added a comment to D26019: remove ability to report bugs against arbitrary stuff from a static list.

I think the application should have a way to provide a list of components to choose from, to avoid losing the feature of selecting a component here, and therefore to make life easier for people triaging bugs.

Tue, Jan 7, 1:57 PM · Frameworks
sitter requested changes to D26180: phonon : build against "older" Qt5 versions.

I'd rather just bump the required version to 5.12.

Tue, Jan 7, 12:20 PM
sitter accepted D26191: Add support for FileJob->truncate() in smb/sftp slaves.

I do wonder if maybe more granular return value handling of the smb truncate would be in order, but then I suppose the most relevant error is EACCES and that'd be handled at opening ¯\_(ツ)_/¯

Tue, Jan 7, 12:11 PM · Frameworks, Dolphin

Sat, Dec 21

sitter added a comment to T12400: Consider what position KDE Neon should take regarding Flatpak, Snaps, and packages future.

I think it would be nice if we shipped Neon with Flathub out of the box rather than the Snap Store

Sat, Dec 21, 12:19 PM · Neon

Dec 15 2019

sitter requested review of D26019: remove ability to report bugs against arbitrary stuff from a static list.
Dec 15 2019, 4:44 PM · Frameworks
sitter requested review of D26014: remove compiler information from bug report dialog.
Dec 15 2019, 11:26 AM · Frameworks

Dec 14 2019

sitter committed R296:f5ca7a470ac6: document colorbutton with an example (authored by sitter).
document colorbutton with an example
Dec 14 2019, 1:42 PM
sitter closed D25988: document colorbutton with an example.
Dec 14 2019, 1:41 PM · Frameworks
sitter requested review of D25988: document colorbutton with an example.
Dec 14 2019, 1:38 PM · Frameworks
sitter added a comment to D25984: Load translations.

Seems a bit meh to have a verbatim copy of the auto generated functions. Perhaps it'd be better to add an option to the ECM generator to export a loader function for use in plugins?
Then we could just call that from the plugin init instead of having to copy it.

Dec 14 2019, 11:30 AM · Kirigami

Dec 11 2019

sitter updated the task description for T9376: calamares by default.
Dec 11 2019, 8:28 PM · Neon

Dec 9 2019

sitter updated the diff for D25682: add initial wsdiscovery support.

various fixes suggested by dfaure

Dec 9 2019, 3:35 PM · Frameworks, Dolphin
sitter added a comment to D25682: add initial wsdiscovery support.

Yep, still looking for primarily design input.

Dec 9 2019, 3:34 PM · Frameworks, Dolphin

Dec 7 2019

sitter accepted D25802: Don't use obsolete qVariantFromValue.
Dec 7 2019, 10:25 PM

Dec 3 2019

sitter added a comment to D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

I haven't read everything in great detail... but...

Dec 3 2019, 12:21 PM · Frameworks
sitter committed R365:b8f39bd08f84: make phonon use the basename without dir (authored by sitter).
make phonon use the basename without dir
Dec 3 2019, 11:44 AM
sitter committed R499:608410c3ebf8: update phonon paths (authored by sitter).
update phonon paths
Dec 3 2019, 11:27 AM
sitter committed R247:add1a39c297c: flatten phonon directory (authored by sitter).
flatten phonon directory
Dec 3 2019, 11:08 AM
sitter updated subscribers of T12257: Webpage advertising Linux distributions with KDE Software.

Jonathan said our writer isn't ready for this sort of spotlight IIRC. @jriddell input?

Dec 3 2019, 10:36 AM · Neon, Kubuntu, KDE Promo

Dec 2 2019

sitter updated subscribers of D25682: add initial wsdiscovery support.

Why do we need to mirror this dsoap-ws-discovery-client lib that seems to be copied from somewhere?

Dec 2 2019, 2:42 PM · Frameworks, Dolphin
sitter requested review of D25682: add initial wsdiscovery support.
Dec 2 2019, 1:50 PM · Frameworks, Dolphin
sitter committed R860:fadd8803e08a: add a (temporary) workaround to ensure phonon i18n is inferred correctly (authored by sitter).
add a (temporary) workaround to ensure phonon i18n is inferred correctly
Dec 2 2019, 10:24 AM
sitter committed R860:7e00c762eb3f: typo-- (authored by sitter).
typo--
Dec 2 2019, 10:24 AM

Nov 29 2019

sitter committed R119:c7a1f606ca96: replace bespoke xkb geometry parser with xkb (authored by sitter).
replace bespoke xkb geometry parser with xkb
Nov 29 2019, 7:53 AM
sitter closed D25191: replace bespoke xkb geometry parser with xkb.
Nov 29 2019, 7:53 AM · Plasma
sitter awarded T12257: Webpage advertising Linux distributions with KDE Software a Love token.
Nov 29 2019, 7:32 AM · Neon, Kubuntu, KDE Promo

Nov 26 2019

sitter committed R860:f3739372febe: document 404 potential of find endpoint (authored by sitter).
document 404 potential of find endpoint
Nov 26 2019, 1:25 PM
sitter committed R860:c6ee26b72392: refactor find arg handling and add ability to find only active/inactive (authored by sitter).
refactor find arg handling and add ability to find only active/inactive
Nov 26 2019, 1:25 PM
sitter committed R860:0a45c83cacbe: refine makefile a bit (authored by sitter).
refine makefile a bit
Nov 26 2019, 1:25 PM
sitter committed R860:030ff5437e6e: switch on release mode for good measure (authored by sitter).
switch on release mode for good measure
Nov 26 2019, 1:25 PM
sitter committed R860:741f406bb784: implement proper zero-downtime restarts (authored by sitter).
implement proper zero-downtime restarts
Nov 26 2019, 1:25 PM

Nov 25 2019

sitter added a comment to D23579: port ftp slave to new error reporting system.

I'll see about adding some debug output for the daemon state. Hard to say why it's flakey with the info at hand.

Nov 25 2019, 11:13 AM · Frameworks

Nov 19 2019

sitter closed D25308: when kioslave5 couldn't be found in libexec-ish locations try $PATH.
Nov 19 2019, 2:14 PM · Frameworks
sitter committed R241:eab483fa2eab: when kioslave5 couldn't be found in libexec-ish locations try $PATH (authored by sitter).
when kioslave5 couldn't be found in libexec-ish locations try $PATH
Nov 19 2019, 2:14 PM
sitter closed T5621: ccache as Wontfix.

The arm setup actually disappeared since (possibly wasn't carried into new server) so there are no up to date metrics. It does not really matter though since we do not have a way to pull this off for amd64. We'd require a persistent storage for the cache as nodes are largely ephemeral so result need "offsite" storage. This would be tricky to do since we currently have no space for this and the actual transfer overhead would like destroy any gains made by the cache. Plus there is of course the risk of false positives anyway. All in all no longer viable to implement.

Nov 19 2019, 2:04 PM · Neon
sitter triaged T12072: move snaps to binary factory as Normal priority.
Nov 19 2019, 9:49 AM · Neon

Nov 18 2019

sitter committed R116:cb8b854c80e9: Merge branch 'Plasma/5.17' (authored by sitter).
Merge branch 'Plasma/5.17'
Nov 18 2019, 4:54 PM
sitter committed R116:c8775cb198f3: connect groupbox toggles to change signal (authored by sitter).
connect groupbox toggles to change signal
Nov 18 2019, 4:54 PM
sitter closed D25368: connect groupbox toggles to change signal.
Nov 18 2019, 4:54 PM · Plasma
sitter added a comment to D25368: connect groupbox toggles to change signal.

@broulik the children are handled by the other connections already (linedit, push button etc.)

Nov 18 2019, 4:13 PM · Plasma
sitter requested review of D25368: connect groupbox toggles to change signal.
Nov 18 2019, 2:31 PM · Plasma
sitter added inline comments to D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.
Nov 18 2019, 10:35 AM · Frameworks

Nov 15 2019

sitter added inline comments to D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.
Nov 15 2019, 1:18 PM · Frameworks
sitter added a comment to D24641: Collect more information from version control systems.

This is starting to look really good. All functions will need documenting in the header of that file so they show up on api.kde.org, see other modules for examples.

Nov 15 2019, 12:26 PM · Build System, Frameworks
sitter added a comment to D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

some style complaints. Looks great other than that 👍

Nov 15 2019, 11:50 AM · Frameworks
sitter updated the diff for D25191: replace bespoke xkb geometry parser with xkb.
  • remove all color mapping tech, it's pointless since the code now uses the system palette
  • remove garbage foobar class
  • remove unnecessary main.moc include
  • create two global SystemPalettes instead of in individual items
Nov 15 2019, 11:36 AM · Plasma

Nov 14 2019

sitter requested review of D25308: when kioslave5 couldn't be found in libexec-ish locations try $PATH.
Nov 14 2019, 5:37 PM · Frameworks
sitter updated the diff for D25191: replace bespoke xkb geometry parser with xkb.
  • bump preview size a bit
  • update documentation
  • resolve outstanding todos
Nov 14 2019, 3:41 PM · Plasma
sitter updated the diff for D25191: replace bespoke xkb geometry parser with xkb.
  • document why section overlays aren't modelled
  • doodad qml item creation is now type based rather than duck typed
  • logo doodads are now supported as a compositie of shape doodads and labels
  • outline doodads now behave correctly in that they only render an outline without fill (at least I think that's how they are meant to work)
  • todo--
Nov 14 2019, 2:09 PM · Plasma
sitter committed R320:903eb5d5031d: Merge branch 'release/19.12' (authored by sitter).
Merge branch 'release/19.12'
Nov 14 2019, 11:51 AM
sitter committed R320:24506c2af8d1: make the libssh finder ensure the new ssh target is set (authored by sitter).
make the libssh finder ensure the new ssh target is set
Nov 14 2019, 11:51 AM
sitter closed D25170: make the libssh finder ensure the new ssh target is set.
Nov 14 2019, 11:51 AM · Frameworks, Dolphin

Nov 13 2019

sitter committed R871:c6cfdb243c3e: Merge branch 'Plasma/5.17' (authored by sitter).
Merge branch 'Plasma/5.17'
Nov 13 2019, 5:09 PM
sitter committed R871:4f161fa0b57f: disable systeminfo test on systems without uname (authored by sitter).
disable systeminfo test on systems without uname
Nov 13 2019, 5:09 PM
sitter committed R871:fb50d436d178: fix msvc compatibility (authored by sitter).
fix msvc compatibility
Nov 13 2019, 5:09 PM
sitter added a comment to T11933: Debrand KDE Applications as Release Service.

^ Plays into https://github.com/ximion/appstream/issues/240

Nov 13 2019, 1:01 PM · KDE Promo, KDE Applications, Goal: All About the Apps

Nov 11 2019

sitter committed R871:883769ab88c1: Merge branch 'Plasma/5.17' (authored by sitter).
Merge branch 'Plasma/5.17'
Nov 11 2019, 1:21 PM
sitter committed R871:8a03e199c204: move plus character in query test to connection (authored by sitter).
move plus character in query test to connection
Nov 11 2019, 1:21 PM
sitter committed R871:8eedb5a0eaae: Merge branch 'Plasma/5.17' (authored by sitter).
Merge branch 'Plasma/5.17'
Nov 11 2019, 1:12 PM
sitter committed R871:885a58205ba0: force encoding on all queries (authored by sitter).
force encoding on all queries
Nov 11 2019, 1:12 PM
sitter added a comment to T11979: KDE Welcome Screen.

OEM configuration is driven by installers already e.g. calamares https://people.ubuntu.com/~apachelogger/screencasts/vokoscreen-2019-05-03_11-43-36.mkv or ubiquity https://userbase.kde.org/Neon/Installation/OEM#First_Boot
Both aforementioned use cases are addressed by the same software using the same code. The "steps" can be different though (e.g. OEM config mostly needs no partitioning so this step is not part of it).

Nov 11 2019, 10:46 AM · VDG