sitter (Harald Sitter)
Engineering

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Sep 15 2015, 12:04 PM (143 w, 5 d)
Availability
Available

Recent Activity

Fri, Jun 15

sitter added a reverting change for R948:71c6e9cba014: link to shirts: R948:461bc2fde6ef: Revert "link to shirts".
Fri, Jun 15, 7:30 PM
sitter committed R948:461bc2fde6ef: Revert "link to shirts" (authored by sitter).
Revert "link to shirts"
Fri, Jun 15, 7:30 PM
sitter committed R1005:92b00346ae40: add a fallback to make sure the lockscrene is unidled (authored by sitter).
add a fallback to make sure the lockscrene is unidled
Fri, Jun 15, 2:34 PM
sitter committed R1005:ad3154f7c246: change alternatives test to detect corrupted popups and try again (authored by sitter).
change alternatives test to detect corrupted popups and try again
Fri, Jun 15, 1:19 PM
sitter committed R1005:09effa0f0407: introduce a temporary hack to wait for a corruption to go away (authored by sitter).
introduce a temporary hack to wait for a corruption to go away
Fri, Jun 15, 12:16 PM
sitter committed R1005:5e45f91db5ac: move lockscreen test to end of plasma suite (authored by sitter).
move lockscreen test to end of plasma suite
Fri, Jun 15, 11:08 AM
sitter committed R1005:732e48f05886: attempt to detect the idle screen more reliably (authored by sitter).
attempt to detect the idle screen more reliably
Fri, Jun 15, 9:00 AM
sitter committed R1005:ad300464a36b: make result.rb pass the arc lint spelling check (authored by sitter).
make result.rb pass the arc lint spelling check
Fri, Jun 15, 9:00 AM
sitter committed R1005:5e2026c5d31e: add basic needle for falkon (authored by sitter).
add basic needle for falkon
Fri, Jun 15, 9:00 AM

Thu, Jun 14

sitter committed R1005:e6a3c3249885: update kicker needle with fixed background (authored by sitter).
update kicker needle with fixed background
Thu, Jun 14, 3:09 PM
sitter accepted D13531: Add arclint file.

Man. I really hate the format of arclint. why it needs to be godawful json is beyond me.

Thu, Jun 14, 1:57 PM
sitter committed R1005:b143abcdf4d6: update oem desktop needle to match 5.13 (authored by sitter).
update oem desktop needle to match 5.13
Thu, Jun 14, 11:03 AM
sitter committed R1005:59b3904e3148: shrink needle to prevent it from matching a possibly highlighted entry (authored by sitter).
shrink needle to prevent it from matching a possibly highlighted entry
Thu, Jun 14, 9:40 AM
sitter committed R1005:982a57a58bd5: retag useredition and devedition-gitstable from plasma 5.12 to master (authored by sitter).
retag useredition and devedition-gitstable from plasma 5.12 to master
Thu, Jun 14, 9:09 AM
sitter committed R1005:58e795a31df3: fix bad copy paste name (authored by sitter).
fix bad copy paste name
Thu, Jun 14, 9:09 AM
sitter committed R1005:744a7da136db: change locking to happen before claiming the node (authored by sitter).
change locking to happen before claiming the node
Thu, Jun 14, 9:09 AM

Wed, Jun 13

sitter added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.

Random complaints I stumbled upon:

Wed, Jun 13, 10:45 AM · Plasma, KDE Connect, Frameworks
sitter committed R1005:aa8a1969b6f8: limit concurrent installation tests via jenkins resources (authored by sitter).
limit concurrent installation tests via jenkins resources
Wed, Jun 13, 9:44 AM

Mon, Jun 11

sitter committed R1005:1b70a3b99db6: add needle for kblackbox (authored by sitter).
add needle for kblackbox
Mon, Jun 11, 2:39 PM
sitter added a comment to D13410: Add test to verify the Alternative Menu.

As @bshah pointed on IRC this may or may not need updating of the needles.

Mon, Jun 11, 2:34 PM
sitter committed R1005:7fd038f6e571: drop the snap_channel fallback it serves no real purpose (authored by sitter).
drop the snap_channel fallback it serves no real purpose
Mon, Jun 11, 2:21 PM
sitter committed R1005:7f45a8f935b5: correctly split channels between runtime and snap (authored by sitter).
correctly split channels between runtime and snap
Mon, Jun 11, 2:13 PM
sitter committed R1005:f54871c507d0: refresh kickoff-popup against fixed color background (authored by sitter).
refresh kickoff-popup against fixed color background
Mon, Jun 11, 2:09 PM
sitter committed R1005:738103bac14a: untangle needle mess and drop unused needle (authored by sitter).
untangle needle mess and drop unused needle
Mon, Jun 11, 1:38 PM
sitter committed R1005:0b9454cf3d8f: prevent saving without a master tag and offer adding it automatically (authored by sitter).
prevent saving without a master tag and offer adding it automatically
Mon, Jun 11, 1:28 PM
sitter committed R1005:dcac09dee3ef: fix tags & make names less awkward (authored by sitter).
fix tags & make names less awkward
Mon, Jun 11, 1:28 PM
sitter committed R1005:edabbcaff546: let tags hover tooltip their full name (authored by sitter).
let tags hover tooltip their full name
Mon, Jun 11, 1:28 PM
sitter committed R1005:8a86286c07a8: fix tag layout to only use the available width and elide the text properly (authored by sitter).
fix tag layout to only use the available width and elide the text properly
Mon, Jun 11, 1:28 PM
sitter committed R1005:8846066bb56a: deal with plasma translucency by forcing static color wallpapers (authored by sitter).
deal with plasma translucency by forcing static color wallpapers
Mon, Jun 11, 12:35 PM
sitter committed R1005:7439e7475479: switch to x11_start_program (authored by sitter).
switch to x11_start_program
Mon, Jun 11, 11:39 AM
sitter committed R1005:f4d789b51e23: add a temporary workaround to disable compositing for the favorite test (authored by sitter).
add a temporary workaround to disable compositing for the favorite test
Mon, Jun 11, 11:39 AM
sitter committed R1005:6689406da085: style (authored by sitter).
style
Mon, Jun 11, 11:39 AM

Fri, Jun 8

sitter accepted D13419: show installed size for all packages.
Fri, Jun 8, 11:19 AM
sitter added a comment to D13419: show installed size for all packages.

The duplicated if (package->isInstalled()) { is a bit meh.

Fri, Jun 8, 11:18 AM
sitter accepted D13412: enable sorting by version and installed size.

Agh. The ints instead of enum values everywhere :((

Fri, Jun 8, 11:15 AM
sitter accepted D13417: fix sort by status or requested change.
Fri, Jun 8, 11:13 AM
sitter committed R1005:b7754f5d7c55: drop the regex assertion of bcmwl (authored by sitter).
drop the regex assertion of bcmwl
Fri, Jun 8, 8:51 AM
sitter committed R1005:2c232c072bb8: make oem test a real proper livetest (authored by sitter).
make oem test a real proper livetest
Fri, Jun 8, 8:51 AM
sitter committed R1005:3063f8c7c99b: document all new snap variables (authored by sitter).
document all new snap variables
Fri, Jun 8, 8:51 AM
sitter committed R1005:f65c5ac5249e: add new environment variable to control the runtime channel (authored by sitter).
add new environment variable to control the runtime channel
Fri, Jun 8, 8:51 AM
sitter accepted D13410: Add test to verify the Alternative Menu.

I'd undo the launcher switch before ending the test. Besides that, awesome work.

Fri, Jun 8, 8:41 AM

Thu, Jun 7

sitter committed R1005:a0af9fc3ede5: get json blobs out of the daemon and archive them (authored by sitter).
get json blobs out of the daemon and archive them
Thu, Jun 7, 9:25 AM

Mon, Jun 4

sitter added a comment to D13327: Fix conversion error when compiled against MDNSRESPONDER option.

-DQT_NO_CAST_FROM_BYTEARRAY is a default define from KDEFrameworkCompilerSettings.cmake, so kdnssd should be working. The reason it wasn't is likely because most/all distributions build with avahi. Additionally, build.kde.org seems to build without avahi and dnssd, so it doesn't validate half the code at all 😒

Mon, Jun 4, 10:34 AM · Frameworks

Fri, Jun 1

sitter accepted D13239: Extended test for verifying the Remove from Favorite option..

Looks like a really good addition.

Fri, Jun 1, 11:22 AM

Wed, May 30

sitter committed R1005:c09da62887cf: correctly tag bovo (authored by sitter).
correctly tag bovo
Wed, May 30, 11:31 AM
sitter committed R1005:c711570c0c43: add needles for primitive test of bovo and konversation (authored by sitter).
add needles for primitive test of bovo and konversation
Wed, May 30, 11:27 AM
sitter committed R1005:0eb0b7b92878: syntax++ (authored by sitter).
syntax++
Wed, May 30, 10:26 AM
sitter committed R1005:2ab898a08182: add a whole bunch of needles for primitive app validation (authored by sitter).
add a whole bunch of needles for primitive app validation
Wed, May 30, 10:12 AM
sitter committed R1005:bc2bb0e18363: fix sizing of the properties dialog (authored by sitter).
fix sizing of the properties dialog
Wed, May 30, 10:12 AM
sitter committed R1005:401f5cab27df: dump the info of installed snaps into the openqa artifacts (authored by sitter).
dump the info of installed snaps into the openqa artifacts
Wed, May 30, 10:12 AM
sitter committed R1005:7056232a6cb8: fix needle (authored by sitter).
fix needle
Wed, May 30, 10:12 AM
sitter committed R1005:6a8c93bf789b: squash enabling and install (authored by sitter).
squash enabling and install
Wed, May 30, 9:28 AM
sitter committed R1005:5a54ea22c54a: add crazy sudo caching system (authored by sitter).
add crazy sudo caching system
Wed, May 30, 8:45 AM
sitter committed R1005:e7c26b8f8c15: add a simple okular needle (authored by sitter).
add a simple okular needle
Wed, May 30, 7:38 AM
sitter committed R1005:ec0a37fa007e: do not hardcode the channel but get it from env (authored by sitter).
do not hardcode the channel but get it from env
Wed, May 30, 7:38 AM
sitter committed R1005:606c1ac784cf: let snap enablement only return once all changes are done (authored by sitter).
let snap enablement only return once all changes are done
Wed, May 30, 7:34 AM
sitter committed R1005:5730880628cd: auto-refresh block switch, try refresh instead (authored by sitter).
auto-refresh block switch, try refresh instead
Wed, May 30, 6:24 AM
sitter updated subscribers of D13132: Add test to verify the Add to Favorite option..

It's been broken since @jriddell landed new stuff but then didn't update the needles.

Wed, May 30, 6:19 AM

Tue, May 29

sitter committed R1005:92cd9a59a232: add snap_name to list of test defining vars (authored by sitter).
add snap_name to list of test defining vars
Tue, May 29, 3:31 PM
sitter committed R1005:1b7ef554bda6: add a new snap testing feature (authored by sitter).
add a new snap testing feature
Tue, May 29, 2:28 PM
sitter accepted D13132: Add test to verify the Add to Favorite option..

LGTM now

Tue, May 29, 9:48 AM

Mon, May 28

sitter requested changes to D13132: Add test to verify the Add to Favorite option..

Looks good, I'd like to get rid of the fractional pixel values though.

Mon, May 28, 7:01 AM

Fri, May 25

sitter reopened T8776: shell broken as "Open".

Ergh. xenial actually failed to build but still somehow managed to pass QA -.-

Fri, May 25, 11:01 AM · KDE Neon : bionic

Thu, May 24

sitter closed T8776: shell broken as Resolved.

All is good in the world again. All ISOs respun. Meanwhile upstream made a fix as well and I undid my patch and that also still seems to pass QA.

Thu, May 24, 3:19 PM · KDE Neon : bionic

Wed, May 23

sitter committed R1005:1cb9c98bda73: make ubiquity comply with strict (authored by sitter).
make ubiquity comply with strict
Wed, May 23, 11:47 AM
sitter committed R1005:10e2c3305438: do not sleep when looking for grub (authored by sitter).
do not sleep when looking for grub
Wed, May 23, 11:46 AM
sitter committed R1005:7134fcbf2272: set up journald to log to new ttyS1 device (authored by sitter).
set up journald to log to new ttyS1 device
Wed, May 23, 11:46 AM
sitter committed R1005:3a95546391f3: kvm_hugepages is now kvm_arg_injector and sets up another chardev (authored by sitter).
kvm_hugepages is now kvm_arg_injector and sets up another chardev
Wed, May 23, 11:46 AM
sitter closed T8731: No click enter to restart on completion of the installation as Invalid.

HA! Now that you mention it, both I and our openqa setup use a newer OVMF as the old one actually was bugging out with qxl and uefi :)
Although I think the bug we had was it shutting down, but then failing to reinitialize the display on reboot (which ought to be clearly a firmware problem). Anyway, newer OVMF is the way to go indeed.

Wed, May 23, 9:38 AM · KDE Neon : bionic
sitter closed T8746: Issue: Unable to install the bcmwl-kernel-sources as Resolved.

Cool. Thanks!

Wed, May 23, 9:25 AM · KDE Neon : bionic

Tue, May 22

sitter triaged T8776: shell broken as Unbreak Now! priority.
Tue, May 22, 2:22 PM · KDE Neon : bionic
sitter added a comment to T8746: Issue: Unable to install the bcmwl-kernel-sources.

New ISO in the usual place. I can't say if it actually fixes the issue as there's been other regressions in the meantime preventing auto QA from passing, but the build log certainly looks more correct than before.

Tue, May 22, 2:19 PM · KDE Neon : bionic
sitter raised the priority of T8746: Issue: Unable to install the bcmwl-kernel-sources from Normal to Unbreak Now!.

Ah! oh! This is actually a regression because the tooling used to build the bionic iso is out of date 🙄

Tue, May 22, 12:54 PM · KDE Neon : bionic
sitter triaged T8746: Issue: Unable to install the bcmwl-kernel-sources as Normal priority.

Ok, I've managed to construct a test for this.

Tue, May 22, 12:47 PM · KDE Neon : bionic
sitter committed R1005:14187cbc1639: completely refactor the way install testing works (authored by sitter).
completely refactor the way install testing works
Tue, May 22, 12:23 PM
sitter committed R1005:65189ddc0537: use correct command for policy (authored by sitter).
use correct command for policy
Tue, May 22, 10:31 AM
sitter added a comment to T8731: No click enter to restart on completion of the installation.

Does it work with the ubuntu 18.04 ISO? Do you have the VM on a HDD or SSD? What's your host system?

Tue, May 22, 10:29 AM · KDE Neon : bionic
sitter committed R1005:3532efb2bc46: make needler round x,y,width,height (authored by sitter).
make needler round x,y,width,height
Tue, May 22, 9:58 AM
sitter committed R1005:b7b32e93b976: make installer icon a bit smaller (authored by sitter).
make installer icon a bit smaller
Tue, May 22, 9:58 AM
sitter committed R1005:2ca9c9c89359: make sure offline doesn't get combined with upgrade (authored by sitter).
make sure offline doesn't get combined with upgrade
Tue, May 22, 9:49 AM
sitter committed R1005:1322516cc9ce: assert that bcmwl is provided by the preinstalled-pool (authored by sitter).
assert that bcmwl is provided by the preinstalled-pool
Tue, May 22, 9:49 AM
sitter committed R1005:0ecbb4ebd046: share offline assertion in install test core (authored by sitter).
share offline assertion in install test core
Tue, May 22, 9:49 AM

Mon, May 21

sitter added a comment to T8746: Issue: Unable to install the bcmwl-kernel-sources.

May be T8638 as I now realize offline install works unless versions go out of sync -.-

Mon, May 21, 9:19 AM · KDE Neon : bionic

May 18 2018

sitter accepted D12958: Fix AppsModel not refreshing on syccoa changes..

💃 💃 💃

May 18 2018, 11:22 AM · Plasma
sitter committed R1005:de0bcbc48fe2: assert correct repo path (authored by sitter).
assert correct repo path
May 18 2018, 10:40 AM
sitter added a comment to T8731: No click enter to restart on completion of the installation.

That is most curious. openqa also uses kvm with uefi and qxl, so it should be seeing the problem as well oO. And so am I for the record.
Can you make a video of the entire installation maybe (from start up to shutdown)? The recording tool vokoscreen works well for me.

May 18 2018, 9:55 AM · KDE Neon : bionic

May 17 2018

sitter committed R1005:28f4c2141a96: make matching rule account for extra lines etc. (authored by sitter).
make matching rule account for extra lines etc.
May 17 2018, 2:52 PM
sitter committed R1005:58275f6b8866: make code simpler by compounding assertions (authored by sitter).
make code simpler by compounding assertions
May 17 2018, 1:37 PM
sitter committed R1005:8d71f57efe20: syntax++ (authored by sitter).
syntax++
May 17 2018, 11:02 AM
sitter committed R1005:2d44ab05f790: assert neon.list exists and contains the expected content (authored by sitter).
assert neon.list exists and contains the expected content
May 17 2018, 9:33 AM
sitter added a comment to T8731: No click enter to restart on completion of the installation.

openqa disagrees.
https://build.neon.kde.org/view/openqa%20%E2%9B%91/job/openqa_bionic_devedition-gitunstable_installation/lastCompletedBuild/testReport/(root)/002_install_calamares/044_live_remove_medium/

May 17 2018, 9:02 AM · KDE Neon : bionic

May 16 2018

sitter triaged T8727: openqa ALL => ALL upgrade as Normal priority.
May 16 2018, 12:31 PM · KDE Neon : bionic
sitter triaged T8726: all software needs to be > ubuntu as Normal priority.
May 16 2018, 12:23 PM · KDE Neon : bionic
sitter closed T8717: Issue with software updating application Launcher as Invalid.

Not a bionic issue.

May 16 2018, 12:17 PM · KDE Neon : bionic
sitter closed T8718: Issue with updates permanently shows as 3 updates available as Invalid.

Closing in favor of bug reports. Probably doesn't have anything to do with bionic as people are also having this issue with xenial discover.

May 16 2018, 11:39 AM · KDE Neon : bionic

May 15 2018

sitter triaged T8715: metadata seeds as Low priority.
May 15 2018, 11:52 AM · KDE Neon : bionic
sitter triaged T8369: not all software built as Low priority.
May 15 2018, 11:32 AM · KDE Neon : bionic
sitter created T8714: unstable appdata.
May 15 2018, 11:32 AM · KDE Neon : bionic
sitter closed T8364: appdata missing as Resolved.

I've rolled out 1.3 with https://github.com/aptly-dev/aptly/pull/473 merged in (i.e. a local fork) and added static data in. So we have appdata sent, they aren't updated or anything but for testing purposes this should be good enough.

May 15 2018, 7:27 AM · KDE Neon : bionic

May 14 2018

sitter closed T8420: Suspend to disk offered as Resolved.

https://bugs.kde.org/show_bug.cgi?id=394252

May 14 2018, 1:58 PM · KDE Neon : bionic