sitter (Harald Sitter)
Engineering

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Sep 15 2015, 12:04 PM (200 w, 4 h)
Availability
Available

Recent Activity

Today

sitter committed R871:246239f60a48: refactor jobdouble duplication away (authored by sitter).
refactor jobdouble duplication away
Tue, Jul 16, 3:28 PM
sitter committed R871:1a4d726209cb: move coverage to src scope (authored by sitter).
move coverage to src scope
Tue, Jul 16, 3:28 PM
sitter added a dependent revision for D22491: implement parts of the bug field api endpoint: D22492: pull platforms/distributions dynamically out of the bugzilla api.
Tue, Jul 16, 3:18 PM · Plasma
sitter added a dependency for D22492: pull platforms/distributions dynamically out of the bugzilla api: D22491: implement parts of the bug field api endpoint.
Tue, Jul 16, 3:18 PM · Plasma
sitter updated the summary of D22492: pull platforms/distributions dynamically out of the bugzilla api.
Tue, Jul 16, 3:18 PM · Plasma
sitter requested review of D22492: pull platforms/distributions dynamically out of the bugzilla api.
Tue, Jul 16, 3:17 PM · Plasma
sitter requested review of D22491: implement parts of the bug field api endpoint.
Tue, Jul 16, 3:16 PM · Plasma
sitter updated the title for P435 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Tue, Jul 16, 2:05 PM
sitter updated the task description for T9376: calamares by default.
Tue, Jul 16, 12:01 PM · Neon
sitter committed R259:f9ae086f19a0: Add ability to copy the URL of played media (authored by gshah).
Add ability to copy the URL of played media
Tue, Jul 16, 11:16 AM
sitter closed D22423: Add ability to copy the URL of played media.
Tue, Jul 16, 11:16 AM
sitter accepted D22423: Add ability to copy the URL of played media.

It's a work of perfection. Thanks! :)

Tue, Jul 16, 11:14 AM
sitter added a reviewer for D22485: wrap the details example label+spacer in a container widget: Plasma.
Tue, Jul 16, 11:09 AM · Plasma
sitter requested review of D22485: wrap the details example label+spacer in a container widget.
Tue, Jul 16, 11:08 AM · Plasma
sitter closed T6780: look into disk space implications of one home per snap as Resolved.

kicon cache is a huge drag (10MiB per kde snap). in point of fact I suspect all of .cache is being fairly awkward but I also do not think this is all too solvable. there is no way to ensure that the cache format of snap X is the same as Y, so they couldn't share the cache.

Tue, Jul 16, 9:36 AM · Neon
sitter accepted D22466: servicemenuinstaller: Run installation scripts with cwd in their parent directories.

fix it then shipit

Tue, Jul 16, 9:20 AM · Dolphin
sitter closed T3528: Wayland by default in neon dev/unstable after Plasma 5.8 as Resolved.

Closing this task for now. We've missed the mark by a bit, and from the neon side things should be more or less in place right now. So, this is mostly blocked on actually having the plasma wayland UX ready for primetime. Or perhaps more importantly, should the requirements change we need to reshuffle the stack anyway, so having a perpetually stuck task serves no purpose.

Tue, Jul 16, 9:18 AM · Neon

Yesterday

sitter committed R236:2631be903f94: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator (authored by sitter).
new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator
Mon, Jul 15, 2:41 PM
sitter closed D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator.
Mon, Jul 15, 2:41 PM · Frameworks
sitter added a comment to D22466: servicemenuinstaller: Run installation scripts with cwd in their parent directories.

Did this case not have a test? Shouldn't it be getting one if it didn't have one?

Mon, Jul 15, 1:56 PM · Dolphin
sitter added inline comments to D22423: Add ability to copy the URL of played media.
Mon, Jul 15, 1:55 PM
sitter updated the diff for D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator.

typos--

Mon, Jul 15, 1:53 PM · Frameworks
sitter added a comment to D22445: WIP: Open from cache / Open Normally.

I would break the problem apart: pretend you only have one cached report. By wanting to deal with multiple reports at once I imagine you are making this more complicated than it is.

Mon, Jul 15, 1:40 PM · Plasma
sitter closed T10786: remove ircbot from job templates as Resolved.
Mon, Jul 15, 9:51 AM · Neon
sitter moved T10786: remove ircbot from job templates from Ready To Do to Doing on the Neon board.
Mon, Jul 15, 9:14 AM · Neon
sitter closed D22421: generate list of data files on the fly.
Mon, Jul 15, 8:50 AM · Documentation, Frameworks
sitter committed R264:a46504bdfcb3: generate list of data files on the fly (authored by sitter).
generate list of data files on the fly
Mon, Jul 15, 8:50 AM

Fri, Jul 12

sitter updated the diff for D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator.
  • add simple example code + image
  • add @since tag
  • override event
Fri, Jul 12, 2:07 PM · Frameworks
sitter added a reviewer for D22421: generate list of data files on the fly: ochurlaud.
Fri, Jul 12, 2:05 PM · Documentation, Frameworks
sitter requested review of D22421: generate list of data files on the fly.
Fri, Jul 12, 2:05 PM · Documentation, Frameworks
sitter committed R871:d8cf681eb060: change debug dir order to prefer appDir and do not duplicate Debuggers (authored by sitter).
change debug dir order to prefer appDir and do not duplicate Debuggers
Fri, Jul 12, 1:17 PM
sitter closed D22401: change debug dir order to prefer appDir and do not duplicate Debuggers.
Fri, Jul 12, 1:17 PM · Plasma
sitter committed R871:c07434bf8e2e: prevent exhausting the maximum size of bug reports (authored by sitter).
prevent exhausting the maximum size of bug reports
Fri, Jul 12, 12:51 PM
sitter closed D22399: prevent exhausting the maximum size of bug reports.
Fri, Jul 12, 12:51 PM · Plasma
sitter committed R871:854c95323993: only benchmark once (authored by sitter).
only benchmark once
Fri, Jul 12, 12:51 PM
sitter closed D22402: only benchmark once.
Fri, Jul 12, 12:51 PM · Plasma
sitter committed R871:68ccdf540ee3: always log raw exception data (authored by sitter).
always log raw exception data
Fri, Jul 12, 12:51 PM
sitter committed R871:76f5df262eb4: disambiguate the names of Debugger (authored by sitter).
disambiguate the names of Debugger
Fri, Jul 12, 12:51 PM
sitter closed D22398: always log raw exception data.
Fri, Jul 12, 12:51 PM · Plasma
sitter closed D22400: disambiguate the names of Debugger.
Fri, Jul 12, 12:51 PM · Plasma
sitter committed R871:88918ab8a59d: do not dereference `current` outside guard condition (authored by sitter).
do not dereference `current` outside guard condition
Fri, Jul 12, 12:51 PM
sitter closed D22404: do not dereference `current` outside guard condition.
Fri, Jul 12, 12:51 PM · Plasma
sitter committed R871:ec63673c3695: qobject_cast rather than dynamic_cast (authored by sitter).
qobject_cast rather than dynamic_cast
Fri, Jul 12, 12:51 PM
sitter closed D22403: qobject_cast rather than dynamic_cast.
Fri, Jul 12, 12:51 PM · Plasma
sitter updated the diff for D22401: change debug dir order to prefer appDir and do not duplicate Debuggers.
  • constify
  • use qasconst on both loops
  • don't make string concatations unecessarily complicate
Fri, Jul 12, 11:20 AM · Plasma

Thu, Jul 11

sitter committed R488:d3ed76d5f67b: Merge branch '4.9' (authored by sitter).
Merge branch '4.9'
Thu, Jul 11, 4:42 PM
sitter committed R488:f1ac69f79a41: don't use nullptr to stay compatible with !c++11 & qt4 (authored by sitter).
don't use nullptr to stay compatible with !c++11 & qt4
Thu, Jul 11, 4:42 PM
sitter closed D22378: don't use nullptr to stay compatible with !c++11 & qt4.
Thu, Jul 11, 4:42 PM
sitter updated the diff for D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator.

get rid of need for decl_hidden and extend the test to play with visiblity

Thu, Jul 11, 3:32 PM · Frameworks
sitter added inline comments to D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator.
Thu, Jul 11, 3:30 PM · Frameworks
sitter added inline comments to D22403: qobject_cast rather than dynamic_cast.
Thu, Jul 11, 2:59 PM · Plasma
sitter requested review of D22404: do not dereference `current` outside guard condition.
Thu, Jul 11, 2:57 PM · Plasma
sitter requested review of D22403: qobject_cast rather than dynamic_cast.
Thu, Jul 11, 2:48 PM · Plasma
sitter requested review of D22402: only benchmark once.
Thu, Jul 11, 2:34 PM · Plasma
sitter requested review of D22401: change debug dir order to prefer appDir and do not duplicate Debuggers.
Thu, Jul 11, 1:24 PM · Plasma
sitter requested review of D22400: disambiguate the names of Debugger.
Thu, Jul 11, 1:23 PM · Plasma
sitter requested review of D22399: prevent exhausting the maximum size of bug reports.
Thu, Jul 11, 1:23 PM · Plasma
sitter requested review of D22398: always log raw exception data.
Thu, Jul 11, 1:20 PM · Plasma
sitter committed R871:a23fe3a38a30: remove UnhandledErrorDialog (authored by sitter).
remove UnhandledErrorDialog
Thu, Jul 11, 12:07 PM
sitter closed D22393: remove UnhandledErrorDialog.
Thu, Jul 11, 12:07 PM · Plasma
sitter added a comment to T9091: Merge PulseAudio and Phonon KCM.

@nicolasfella what were the questions you had?

Thu, Jul 11, 12:04 PM · Plasma
sitter requested review of D22393: remove UnhandledErrorDialog.
Thu, Jul 11, 10:05 AM · Plasma
sitter accepted D22322: Store crash report automatically if shutting down.

some style fixes then ship it plz 👍

Thu, Jul 11, 9:08 AM · Plasma

Wed, Jul 10

sitter added a reviewer for D22378: don't use nullptr to stay compatible with !c++11 & qt4: jriddell.
Wed, Jul 10, 4:01 PM
sitter added a comment to D22378: don't use nullptr to stay compatible with !c++11 & qt4.

good point

Wed, Jul 10, 4:01 PM
sitter updated the diff for D22378: don't use nullptr to stay compatible with !c++11 & qt4.

also throw out the overrides

Wed, Jul 10, 4:01 PM
sitter updated the diff for D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator.
  • running property gone since we have no use case + simplified code since we no longer account for it
  • dropped superfluous virtual keywords
  • bumped duration to 1.5s
  • moved to qvariantanimation + alloc animation on stack
  • now has minimumsizehint based on PM_SmallIconSize
Wed, Jul 10, 3:57 PM · Frameworks
sitter committed R871:e6a81b2d466b: fix API availability/version detection to not be terribly racey (authored by sitter).
fix API availability/version detection to not be terribly racey
Wed, Jul 10, 3:17 PM
sitter closed D22326: fix API availability/version detection to not be terribly racey.
Wed, Jul 10, 3:17 PM · Plasma
sitter updated the diff for D22326: fix API availability/version detection to not be terribly racey.

build fix

Wed, Jul 10, 2:17 PM · Plasma
sitter updated the diff for D22326: fix API availability/version detection to not be terribly racey.

use qprogressbar until a proper busyindicator becomes available

Wed, Jul 10, 2:15 PM · Plasma
sitter added inline comments to D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator.
Wed, Jul 10, 2:05 PM · Frameworks
sitter requested review of D22378: don't use nullptr to stay compatible with !c++11 & qt4.
Wed, Jul 10, 2:04 PM
sitter added a comment to D22376: new env var DRKONQI_HTTP_DELAY_MS to force a connection delay.

Fair point but I don't want to throttle my music stream, I want to throttle the drkonqi api requests ;)
Also, an IO throttle isn't always useful. e.g. for the stuff in D22326 I want control exactly how long the reply should take so I reach the page in question when the reply hasn't yet returned, but then returns "soon enough".

Wed, Jul 10, 1:53 PM · Plasma
sitter committed R487:6c70fd20c341: Merge branch '4.10' (authored by sitter).
Merge branch '4.10'
Wed, Jul 10, 1:45 PM
sitter committed R487:25c4fb0a471b: dirty hack to get qt4 building for the time being (authored by sitter).
dirty hack to get qt4 building for the time being
Wed, Jul 10, 1:45 PM
sitter closed D22377: dirty hack to get qt4 building for the time being.
Wed, Jul 10, 1:45 PM
sitter added inline comments to D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator.
Wed, Jul 10, 1:44 PM · Frameworks
sitter requested review of D22377: dirty hack to get qt4 building for the time being.
Wed, Jul 10, 1:36 PM
sitter requested review of D22376: new env var DRKONQI_HTTP_DELAY_MS to force a connection delay.
Wed, Jul 10, 1:22 PM · Plasma
sitter requested review of D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator.
Wed, Jul 10, 1:08 PM · Frameworks
sitter committed R1005:935ecf602a70: also unrestrict all of sddm (authored by sitter).
also unrestrict all of sddm
Wed, Jul 10, 12:16 PM
sitter committed R1005:84943b77a9c1: unrestrict all unversioned lockscreen needles so they apply to user ed (authored by sitter).
unrestrict all unversioned lockscreen needles so they apply to user ed
Wed, Jul 10, 12:14 PM
sitter committed R1005:83cf68e61ebb: make lock idle needle apply to all types (authored by sitter).
make lock idle needle apply to all types
Wed, Jul 10, 11:50 AM
sitter committed R1005:e4f712cb0684: force a timeout on x11 start program (authored by sitter).
force a timeout on x11 start program
Wed, Jul 10, 11:38 AM
sitter updated the title for P431 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Wed, Jul 10, 10:23 AM
sitter added a comment to T10938: switch to libinput with plasma 5.16+.

Yup.

Wed, Jul 10, 9:23 AM · Neon
sitter committed R1005:08fc7c7f2cc6: update wayland selector (authored by sitter).
update wayland selector
Wed, Jul 10, 9:19 AM
sitter committed R1005:6185733aeb19: fix close needle (authored by sitter).
fix close needle
Wed, Jul 10, 9:18 AM
sitter added a comment to T11034: snap binary factorization.

In terms of compatibility for uploading, I don't suppose whether we know if the version shipped with Ubuntu 18.04 will be able to continue to do that on a continuing basis?

Wed, Jul 10, 9:10 AM · Sysadmin

Tue, Jul 9

sitter closed T10938: switch to libinput with plasma 5.16+ as Resolved.

All ISOs respun and openqa updated as well. Transition complete.

Tue, Jul 9, 4:03 PM · Neon
sitter updated the title for P430 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Tue, Jul 9, 1:57 PM
sitter added a comment to D22122: use pwquality_strerror to get error strings.

Concept makes sense.
+1

@ltoscano can you confirm you're ok from an i18n side.

Tue, Jul 9, 10:53 AM · Plasma
sitter accepted D22322: Store crash report automatically if shutting down.

some style annoyances. fix it then ship it 👍

Tue, Jul 9, 10:52 AM · Plasma
sitter committed R1005:1d1ca73c4fab: update spanish sddm for new wallpaper (authored by sitter).
update spanish sddm for new wallpaper
Tue, Jul 9, 10:13 AM
sitter accepted D11234: [DrKonqi] Show debug button when KDevelop session is running.

Heh. Fair enough, I too ran down the wrong rabbit hole with the size issue until I noticed the policy was wrong.

Tue, Jul 9, 10:08 AM · Plasma
sitter committed R871:598d1560b6e2: Merge branch 'Plasma/5.16' (authored by sitter).
Merge branch 'Plasma/5.16'
Tue, Jul 9, 10:05 AM
sitter committed R871:1d7464b58f59: update integration test (authored by sitter).
update integration test
Tue, Jul 9, 10:05 AM
sitter committed R871:01c7604fd925: typo-- (authored by sitter).
typo--
Tue, Jul 9, 9:13 AM
sitter committed R871:3768d0e6cbe3: fix integration test (authored by sitter).
fix integration test
Tue, Jul 9, 9:13 AM