- User Since
- Sep 15 2015, 12:04 PM (130 w, 6 d)
Tue, Mar 13
some suggestions, lgtm though
@elvisangelaccio ah, sorry I missed your comment. It certainly would make sense.
Mon, Mar 12
Fri, Mar 9
(new screenshot not synced to cdn as of right now, so it still 404s until that happens)
Thu, Mar 8
Wed, Mar 7
Tue, Mar 6
Since categories is now the same as in the desktop file you can simply drop it. appstream-generator will merge the desktop file's data in. Otherwise looks good now
The custom roles in data() ignoring the column isn't necessarily a problem, but combined with the callers not knowing what is in a column it gets problematic. e.g. if you look at the Delegate's paintText, it wants to do different rendering based on the "meaning" of the column but ultimately needs to hardcode the columns because there is no way to determine it programmatically.
Mon, Mar 5
Many moons ago I actually rewrote dragon in QML and didn't like it https://cgit.kde.org/scratch/sitter/dragon.git/ (mostly because Qt4 qml was fairly meh and I didn't know what I was doing).
When working phonon for Qt5 I again wrote some reimplementations in QML https://cgit.kde.org/scratch/sitter/phonon5-examples.git/tree/ for testing.
As discussed on telegram: the proposed change makes it a different problem. Now instead of running serial all the time, it'd fork bomb all the time (peaks at 3671 forks for plasma-desktop 5.12 when run on a fairly fast system with SSD).
Fair enough but even screensaver inhibition isn't the same as power management inhibition?
Why does the battery applet show the notification inhibition for notifications?
Are you sure this is used in the battery applet? I really don't see how notifications relate to that applet. Surely it'd be using PM inhibitions which are an entirely different thing?
Wed, Feb 28
I suggest you also get an appdata file started https://community.kde.org/Guidelines_and_HOWTOs/AppStream
Mon, Feb 26
Are you sure wherever you install konsole has the XDG_* vars set up properly?
Meh. The entire codebase seems to often be guessing if it needs to append a slash or not. It's fairly dishearting.
Fri, Feb 23
Please push to 0.9 branch. Pvlc should be on phab btw.
Wed, Feb 21
As mentioned on IRC I think this would benefit greatly from some unit testing as that line check is dangerously close to requiring mental gymnastics to read. AT a glance, all that's needed is writing stub sudo/su helpers and a test asserting outcome of SuProcess('us0r', 'PATH/fakesudo').converseSU('passwd') in the given scenarios (password good su&sudo, password bad su&sudo).
I suggest you also increase the timeout to 20 or 30s so it becomes less likely the timeout gets hit at all. Otherwise, it still times out and causes a useless progressbar show/hide dance. 10s is fairly short given the timeout is only there to prevent the bar from being up indefinitely if xapian hangs or something.
I don't know enough about xapian to say if that makes sense. But the way I read the original commit is that if you were to install a package through dpkg directly, xapian would not know about it until you force a cache refresh (which in turn would refresh the cache from apt and apt in that case is simply a frontend for dpkg).
Tue, Feb 20
Well it does, but it does so through hinting not hardcoding *and* in fact even has a fallback list. It basically tells Qt "plz use breeze, or oxygen, or fusion, or windows" and then Qt picks whichever is available.
you might want to make the string cost. other than that good to land. 👍
Mon, Feb 19
Looks good. I am not sure this is entirely correct though.
Sun, Feb 18
Name should be pulseaudio-qt with library libKF5PulseAudioQt (following the same naming scheme as bluez-qt, networkmanager-qt and modemmanager-qt). It's specific binding API for PA really.
Feb 16 2018
Yeah, it costs us nothing to use a 5 suffix though and it is more consistent with the other bins. If someone says bin/kdesu as a name is more useful to them I am not opposed to dropping the suffix though.
Feb 15 2018
Currently targeting 5.12 but I am not too sure that is an entirely suitable change. Input welcome.
Feb 8 2018
We cannot. The way it is worked around is by skipping too deep directories so if this ever becomes a necessary use case it would not work and no one would remember why that is.