- User Since
- Sep 15 2015, 12:04 PM (174 w, 6 d)
Thu, Jan 17
compat down to 10 is almost certainly a hack done for xenial. bionic has dh11
Wed, Jan 16
Tue, Jan 15
Mon, Jan 14
please provide some backtraces. This looks like a hack, the qa decidedly shouldn't get stuck on destruction just because cleanup already ran.
BUILD_TESTING easy fix: https://phabricator.kde.org/source/knotifyconfig/browse/master/CMakeLists.txt$60
Fri, Jan 11
rename the package to freerdp but explicitly mention that the xfreerdp binary is needed
Oh actually. I have a theory. My environment vars were wrong. Try with s/LANG/LANGUAGE and s/LOCALE/LANG please.
You'll have to debug this for us. It passes on build.kde.org 😒
Thu, Jan 10
somewhat unrelated ... @whiting do you recall why line 83 still says "Needs porting"? according to the git history you ported this a couple months after but the comment was not removed.
Wed, Jan 9
Is there a reason you didn't push that into the stable branch?
Tue, Jan 8
Mon, Jan 7
if the diff doesn't get landed, another cheap approach is to add a button 'install addition wallpapers' in the wallpaper kcm which opens discover with an appstream component for the wallpapers. it'd be similar to a patch I maintained at kubuntu except with appstream ids we can now solve this properly in plasma itself without patching
I am not sure if this needs to go anywhere but master. Please advise.
add an empty es directory to see in the source that es is meant to be empty. serves no purpose other than making things more obvious
configure_file the fixtures lest they get mangled by scripty on account of being desktop files
I am somewhat indifferent. It certainly has caused some grief for various reasons in various places, so it stands to reason that it should go. Also since auto-init of kcrash is essentially not a thing for application code (what with link-as-needed being a common distro flag) it's possibly more consistent to move it's enabling to the individual slaves.
I agree but then it's so large!!! oof
Dec 18 2018
move env setup to qcorestartup to prevent the env from not getting set up in time and the tests failing as a result
Dec 15 2018
iterating the diff a bit as mentioned in a comment.
Dec 14 2018
Stacking the functions seems to work fine
Dec 13 2018
Fair enough. If you tell me what needs doing I can poke it. I don't want to invest too much time, but at a glance what you have done seems pretty much done really.
@aacid what were the changes you had planned here?
This has no UI-backing (i.e. dragon has no playlist), and dragon won't get UI-backing because it is intentionally designed not to have a playlist. Opening multiple files would go against one of the core designs of dragon.
Dec 12 2018
The amount of if conditions in the MainWindow is rising at an alarming rate :|
Dec 11 2018
Dec 10 2018
4.10 as well please
Oh la la, I didn't even realize phonon was optional. New code is much better.
For the record, other random stuff the people I was talking with just now were whining about, but I am not addressing because I really only want this branding issue gone:
actually change from KDE project to KDE community, makes most sense I feel
Well, dvratil is maintainer you don't need me to accept really, I'll just defer to him anyway :P
Well, I can't make a release if you don't land the commit?
Dec 7 2018
Dec 5 2018
This is not the place to talk about this. kde-community is the better place I should think.