sitter (Harald Sitter)
Engineering

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Sep 15 2015, 12:04 PM (209 w, 5 d)
Availability
Available

Recent Activity

Thu, Sep 19

sitter added a comment to T11720: mask appstream components of debs using qt private abi .

Excitingly enough apt rdepends doesn't actually manage to generate a list for the virtual package qtbase-abi-5-9-5 so we need custom tooling to even get a list of offending packages -.-

Thu, Sep 19, 1:12 PM · Neon
sitter requested review of D24076: add a simple smoke test for slaves by using kioclient5.
Thu, Sep 19, 1:04 PM · Frameworks, Dolphin
sitter triaged T11722: fix appstream for unstable/stable as High priority.
Thu, Sep 19, 11:31 AM · Neon
sitter triaged T11720: mask appstream components of debs using qt private abi as Low priority.
Thu, Sep 19, 11:28 AM · Neon
sitter created T11720: mask appstream components of debs using qt private abi .
Thu, Sep 19, 11:28 AM · Neon

Wed, Sep 18

sitter committed R489:b5c4d67a9f2a: preliminary vlc4 port (authored by sitter).
preliminary vlc4 port
Wed, Sep 18, 2:33 PM
sitter added a comment to T11716: Sort out kdeedu-data.

In point of fact, that's literally what the last build failure says

Wed, Sep 18, 12:51 PM · Neon
sitter added a comment to T11716: Sort out kdeedu-data.

I think the only thing blocking this is the not set branch. what you describe are l10n data assets, those have literally no requirements other than knowing where to get them from (i.e. a branch)

Wed, Sep 18, 12:50 PM · Neon
sitter added a comment to T11675: Create Discourse Setup.

(in lieu of a new oauth-enabled identity, if someone shows me code how to use current identity ldap shebang and/or give me some info needed for that I can try to throw together an auth plugin ... not quite sure how to test that reliably without access to anything though?)

Wed, Sep 18, 12:41 PM · Goal: All About the Apps, Sysadmin
sitter committed R247:67d487fe1262: move rekonq to unmaintained (authored by sitter).
move rekonq to unmaintained
Wed, Sep 18, 11:17 AM
sitter added a comment to T11034: snap binary factorization.

KBlocks should generally work https://packaging.neon.kde.org/kde/kblocks.git/tree/?h=Neon/release

Wed, Sep 18, 9:55 AM · Sysadmin
sitter committed R489:0ddf289d7e2a: only set xwindow when the qt platform actually is xcb (on unix) (authored by sitter).
only set xwindow when the qt platform actually is xcb (on unix)
Wed, Sep 18, 9:22 AM
sitter committed R489:37ceea8f65c2: typo-- (authored by sitter).
typo--
Wed, Sep 18, 9:03 AM

Tue, Sep 17

sitter closed T11304: Having a dedicated KDE server/service/location for public gpg keys of tarballers & Co. as Resolved.

Fine by me.

Tue, Sep 17, 2:14 PM · Sysadmin
sitter added a comment to T11034: snap binary factorization.

FWIW for signing we actually need snapcraft login which shouldn't require snapd or apparmor or anything. snap login would be for the user to login to see private store items and I guess make purchases or something, should be entirely irrelevant to us from a build perspective.

Tue, Sep 17, 1:56 PM · Sysadmin
sitter added a comment to T11304: Having a dedicated KDE server/service/location for public gpg keys of tarballers & Co..

I'll write a mail to release team list later this week as I am still catching up with my inbox. What we came up with is still pending further discussion anyway. The short description is that we want a keyring of "trusted" release keys, which would be curated by sysadmins in a git repo. (Source) releases would have to be signed by a key in the keyring and the keyring would act as validation source for all concerned parties. This would also solve the task at hand in that the keyring can also be used by distros. It would also allow a future move to more tightly controlled signing procedures (i.e. no source releases without signature) which would in turn allow for greater automation possibilities for sysadmins as well, as instead of manual checksum checks an automated signature verification could be employed.

Tue, Sep 17, 1:28 PM · Sysadmin
sitter closed T10616: drop qt4 as Resolved.
Tue, Sep 17, 8:55 AM · Neon
sitter accepted D23821: Clean up a few deprecated headers, and make dependencies more explicit.
Tue, Sep 17, 8:53 AM · Plasma

Mon, Sep 16

sitter committed R120:867410b1b367: ensure results are sorted by relevance (authored by sitter).
ensure results are sorted by relevance
Mon, Sep 16, 12:16 PM
sitter committed R120:f8e6e084b77b: Merge branch 'Plasma/5.8' (authored by sitter).
Merge branch 'Plasma/5.8'
Mon, Sep 16, 12:16 PM

Thu, Sep 12

sitter added a comment to D23911: Port SearchLineWidget to use KBusyIndicatorWidget.

It's marvelous!

Thu, Sep 12, 4:27 PM · Okular
sitter added a comment to T10648: package AppImage support.

This in fact only became active recently.

Thu, Sep 12, 9:55 AM · Neon
sitter edited projects for T10815: Package Kipi Plugins, added: Neon2Debian; removed Neon.
Thu, Sep 12, 9:53 AM · Neon2Debian
sitter edited projects for T10407: merge ( applications ), added: Neon2Debian; removed Neon.
Thu, Sep 12, 9:53 AM · Neon2Debian
sitter edited projects for T10354: merge ( Extras ), added: Neon2Debian; removed Neon.
Thu, Sep 12, 9:53 AM · Neon2Debian
sitter edited projects for T10160: merge ( Plasma ), added: Neon2Debian; removed Neon.
Thu, Sep 12, 9:53 AM · Neon2Debian
sitter edited projects for T8586: merge ( Frameworks ), added: Neon2Debian; removed Neon.
Thu, Sep 12, 9:52 AM · Neon2Debian
sitter edited projects for T10850: Update qca2, added: Neon2Debian; removed Neon.
Thu, Sep 12, 9:52 AM · Neon2Debian
sitter set the color for Neon2Debian to Yellow.
Thu, Sep 12, 9:50 AM
sitter added a comment to T10513: HWE again!.

Also apply to 18.04. Needs investigation on how to actually pull in the upgrade. Possibly -desktop should recommend the HWE packages, but this may not be enough. So, check what is the least invasive but reliably upgrading approach here.

Thu, Sep 12, 9:43 AM · Neon

Wed, Sep 11

sitter accepted D23873: Remove 'phonon' from the include directory.
Wed, Sep 11, 9:54 PM
sitter accepted D23878: Use QTEST_GUILESS_MAIN for systeminformationtest.
Wed, Sep 11, 9:51 PM · Plasma

Tue, Sep 10

sitter added a comment to T10475: update snaps for better appstream integration.

Look at all bugs see if they have impact on production and if not close this task

Tue, Sep 10, 3:24 PM · Neon
sitter added a comment to T11283: gcompris misses box2d.

snap building apparently has troubles with it. needs investigation

Tue, Sep 10, 3:22 PM · Neon
sitter added a comment to T10616: drop qt4.

also needs removal of phonon-backend-vlc (that is the qt4 thingy)

Tue, Sep 10, 3:21 PM · Neon

Mon, Sep 9

sitter added a comment to D23799: Get rid of khtml usage (kill classic mode).

+1

Mon, Sep 9, 2:14 PM · Plasma

Sat, Sep 7

sitter committed R486:2895ca34ddf1: Fix QCA android build (authored by ppetrik).
Fix QCA android build
Sat, Sep 7, 3:29 PM
sitter committed R486:4b11437f7a43: change the android condition to a getuid check (authored by sitter).
change the android condition to a getuid check
Sat, Sep 7, 3:29 PM
sitter closed D23289: Fix QCA android build.
Sat, Sep 7, 3:29 PM

Mon, Sep 2

sitter added a comment to T11388: torrent generator.

Yep. It should be out this week, so we likely are good to promote torrents next week or the week after so distros had a chance to adopt it.

Mon, Sep 2, 1:56 PM · Neon

Fri, Aug 30

sitter committed R487:e26724d4dec9: throw out the qml demo (authored by sitter).
throw out the qml demo
Fri, Aug 30, 2:49 PM
sitter committed R487:ed0bff57ab7e: import gpl2 for new settings source code (authored by sitter).
import gpl2 for new settings source code
Fri, Aug 30, 2:39 PM
sitter added a comment to T11388: torrent generator.

@kives spam.

Fri, Aug 30, 1:22 PM · Neon
sitter requested review of D23579: WIP: port ftp slave to new error reporting system.
Fri, Aug 30, 1:11 PM · Frameworks

Thu, Aug 29

sitter committed R241:830c56744f2b: assert slave command finality (authored by sitter).
assert slave command finality
Thu, Aug 29, 10:51 AM
sitter closed D23344: assert slave command finality.
Thu, Aug 29, 10:51 AM · Frameworks
sitter added a comment to D23344: assert slave command finality.

Shoes! I meant shoes! 😿

Thu, Aug 29, 10:48 AM · Frameworks
sitter accepted D23558: Use KBusyIndicatorWidget.

Designer widget is in kdesingerplugin FTR.

Thu, Aug 29, 10:43 AM · Plasma
sitter added a comment to T11304: Having a dedicated KDE server/service/location for public gpg keys of tarballers & Co..

This is all getting a bit long :/

Thu, Aug 29, 10:39 AM · Sysadmin

Wed, Aug 28

sitter added a comment to D23552: ECM: remove set_package_properties from FindCanberra.

No objections from me. This was explicitly suggested during review though, so I'd like @cgiboudeaux to approve this.

Wed, Aug 28, 11:49 PM · Build System, Frameworks
sitter added a comment to T11304: Having a dedicated KDE server/service/location for public gpg keys of tarballers & Co..

No, you.

Wed, Aug 28, 4:14 PM · Sysadmin
sitter added a comment to T11304: Having a dedicated KDE server/service/location for public gpg keys of tarballers & Co..

@lavender I'm very sorry if I insulted you.

Wed, Aug 28, 4:11 PM · Sysadmin
sitter added a comment to T11304: Having a dedicated KDE server/service/location for public gpg keys of tarballers & Co..

So when it comes to my needs, I conform with the current level of activity now by having put my public key to share.kde.org and adding a note to kdevelop.org/download. But I have to tell, I do not feel like this actually is made us of by anyone, nor could I tell if this really improves protection against assumable attacks.

Wed, Aug 28, 4:09 PM · Sysadmin
sitter added a comment to T11304: Having a dedicated KDE server/service/location for public gpg keys of tarballers & Co..

Stop disrupting the ticket. Your uninformed babbling is entirely irrelevant.

Wed, Aug 28, 3:26 PM · Sysadmin
sitter added a comment to D23537: extend state verification to open connection commands.

I do wonder if maybe it would make sense to revise the verification system to be based off of a list of allowed/forbidden functions that may be called during a command.

Wed, Aug 28, 3:21 PM · Frameworks
sitter requested review of D23537: extend state verification to open connection commands.
Wed, Aug 28, 3:12 PM · Frameworks
sitter added a comment to D23207: Fixing implementation of FileJob interface in smb/sftp slaves.

@dfaure this is actually a different beast altogether, the current state validation is only run on the API for all slaves, seek/read/write are run in a completely different loop which I see isn't being verified at all. I'll add it in a separate diff once the assertion is in. Should be fairly trivial. As I understand it open/read/write/seek must only ever call error() or their specific "send" function (opened()/data()/written()/position()) but never finished. Close meanwhile must reach finality (finished or error).

Wed, Aug 28, 11:26 AM · Frameworks, Dolphin
sitter updated the diff for D23344: assert slave command finality.

some days one has to wonder how I manage to put on shows. fix warning branch as per David's comments to actually do nothing when the cond was matched

Wed, Aug 28, 11:19 AM · Frameworks
sitter accepted D22616: Remove phonon KCM.

Good to land. Phonon 4.11 replaces this KCM with a new phononsettings application, which is a simple port of the KCM to a standalone application.

Wed, Aug 28, 10:03 AM · Documentation, Plasma
sitter requested changes to D22616: Remove phonon KCM.

Also needs removal of doc/kcontrol/phonon/ and also the qdebugcategory plasma-desktop.categories:org.kde.kcm.phonon kcm module phonon IDENTIFIER [KCM_PHONON_LOG]

Wed, Aug 28, 9:54 AM · Documentation, Plasma
sitter committed R247:ece8a6f9169c: bump stable branches of phonon for new series (authored by sitter).
bump stable branches of phonon for new series
Wed, Aug 28, 9:09 AM

Tue, Aug 27

sitter accepted D23503: Reorder cmake macro includes.
Tue, Aug 27, 11:30 PM
sitter added a comment to D23207: Fixing implementation of FileJob interface in smb/sftp slaves.

SlaveBase (which the slaves derive from) runs a command loop, out of this command loop come the actual calls to the API functions. So, in said command loop we can verify which state the slave is in before and more importantly after any API call. Specifically about the defects you are repairing here I'd guess that none of the commands running on an open connection must result in the finished state. We already do this for (some) of the other commands.

Tue, Aug 27, 3:56 PM · Frameworks, Dolphin
sitter added a comment to D23207: Fixing implementation of FileJob interface in smb/sftp slaves.

Not knowing the background here at a glance I would argue that SlaveBase in KIO should be getting state verification on all of this,.

Tue, Aug 27, 3:06 PM · Frameworks, Dolphin
sitter updated the diff for D23344: assert slave command finality.
  • wrap in custom assert defines that either assert or qwarn based on a cmake option
  • new cmake option KIO_ASSERT_SLAVE_STATES enables the asserts. the option is only on by default when run on jenkins
  • fix a bunch of typos
Tue, Aug 27, 2:25 PM · Frameworks
sitter committed R488:900ebb5abed0: bump to 4.10.0 for release (authored by sitter).
bump to 4.10.0 for release
Tue, Aug 27, 1:17 PM
sitter committed R489:5c72e819a536: bump to 0.11.0 for release (authored by sitter).
bump to 0.11.0 for release
Tue, Aug 27, 1:17 PM
sitter committed R487:840d18e17975: bump to 4.11.0 for release (authored by sitter).
bump to 4.11.0 for release
Tue, Aug 27, 1:17 PM
sitter accepted D23488: Explicitly initialize KCrash.
Tue, Aug 27, 12:38 PM · Plasma

Mon, Aug 26

sitter added a comment to D23381: Allow splitting lists using ;.

Shouldn't you be using KConfigGroup::readXdgListEntry? KConfig is strangely conflicted with it's default assumption being that you want the legacy comma lists so if you want xdg-style lists you need to call different functions altogether. That said I think Kai and I also stumbled across this same sillyness a while ago, so I am rather thinking this needs dealing with to avoid more people looking at the same issue :/

Mon, Aug 26, 3:30 PM · Frameworks
sitter requested changes to D21795: [KAuth] Add support for action details in Polkit1 backend..

Unfortunately I've noticed a huge blocker...
polkit-qt-1 with the checkAuthorizationWithDetails change is not actually released. That needs fixing :| https://community.kde.org/ReleasingSoftware

Mon, Aug 26, 10:39 AM · Frameworks
sitter accepted D23261: Add option to discourage reporting bugs.

Thanks

Mon, Aug 26, 9:26 AM · Dolphin, Plasma
sitter added inline comments to D23261: Add option to discourage reporting bugs.
Mon, Aug 26, 9:21 AM · Dolphin, Plasma
sitter added inline comments to D23241: Show application window icon on AboutPage.
Mon, Aug 26, 9:19 AM · Kirigami
sitter added inline comments to D23261: Add option to discourage reporting bugs.
Mon, Aug 26, 9:08 AM · Dolphin, Plasma

Sat, Aug 24

sitter added a comment to D23344: assert slave command finality.

Yeah, it's certainly a very aggressive change. I also think we need this to be outside kdeinit5, otherwise unit tests won't crash since they generally should fork directly. That being said, as a first step maybe we can have this enabled on the CI and see if existing unit tests start failing.

Sat, Aug 24, 11:28 AM · Frameworks

Aug 23 2019

sitter committed R488:d6cb593eabee: bump to 4.9.60 for release prep (authored by sitter).
bump to 4.9.60 for release prep
Aug 23 2019, 1:16 PM
sitter committed R489:b4e5f0d5f1e3: bump to 0.10.90 for release prep (authored by sitter).
bump to 0.10.90 for release prep
Aug 23 2019, 1:16 PM
sitter committed R487:237a4ce0f368: bump to 4.10.90 for release prep (authored by sitter).
bump to 4.10.90 for release prep
Aug 23 2019, 1:16 PM
sitter added a comment to D23289: Fix QCA android build.

We will need your email address for commit authorship.

Aug 23 2019, 12:00 PM

Aug 22 2019

sitter committed R116:9fccc9a8d599: fix bridge master:slave mapping by-name (authored by sitter).
fix bridge master:slave mapping by-name
Aug 22 2019, 4:12 PM
sitter closed D23125: fix bridge master:slave mapping by-name.
Aug 22 2019, 4:12 PM · Plasma
sitter added a comment to D23348: force applicationDirPath into first position when finding plugins.

That is a solvable problem, there's a property to control where things end up in the build tree:
set_target_properties(kio_ftp PROPERTIES LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin/kf5/kio")

Aug 22 2019, 2:47 PM · Frameworks
sitter added a comment to D23348: force applicationDirPath into first position when finding plugins.

Perhaps the answer actually is that QT_PLUGIN_PATH should not be necessary ;)

Aug 22 2019, 2:25 PM · Frameworks
sitter abandoned D23348: force applicationDirPath into first position when finding plugins.

Agh, you are very right of course. Things are never easy :/

Aug 22 2019, 2:01 PM · Frameworks
sitter requested review of D23348: force applicationDirPath into first position when finding plugins.
Aug 22 2019, 1:22 PM · Frameworks
sitter committed R241:ccae728a5494: KIO FTP: Fix file copy hanging when copying to existing file (authored by ZaWertun).
KIO FTP: Fix file copy hanging when copying to existing file
Aug 22 2019, 1:09 PM
sitter requested review of D23344: assert slave command finality.
Aug 22 2019, 11:19 AM · Frameworks
sitter updated the title for P457 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Aug 22 2019, 9:23 AM
sitter committed R487:2a940bd20bd8: fix designer target directory (authored by sitter).
fix designer target directory
Aug 22 2019, 9:21 AM
sitter committed R487:008a3a7a5f54: fix backend dir suffix getting passed around (authored by sitter).
fix backend dir suffix getting passed around
Aug 22 2019, 8:47 AM

Aug 20 2019

sitter accepted D23289: Fix QCA android build.

What if one is root on android?

Aug 20 2019, 3:16 PM
sitter committed R487:39e60f69af80: silence a whole bunch of warnings (authored by sitter).
silence a whole bunch of warnings
Aug 20 2019, 11:21 AM
sitter committed R487:56e50e4faf28: drop use of removed header (authored by sitter).
drop use of removed header
Aug 20 2019, 10:51 AM
sitter committed R487:41073dbb7681: remove dbus support from audiooutput (authored by sitter).
remove dbus support from audiooutput
Aug 20 2019, 10:51 AM
sitter committed R487:ece20131b1ef: remove state assertion option (authored by sitter).
remove state assertion option
Aug 20 2019, 10:51 AM
sitter committed R487:0ba0c1eae03a: add a todo about removing dbus support (authored by sitter).
add a todo about removing dbus support
Aug 20 2019, 10:51 AM
sitter committed R487:531ea2df1119: remove the opt-in qt compat headers (authored by sitter).
remove the opt-in qt compat headers
Aug 20 2019, 10:51 AM
sitter committed R487:80991f330860: remove graphicsview and declarative plugin (authored by sitter).
remove graphicsview and declarative plugin
Aug 20 2019, 10:51 AM
sitter committed R487:8813af63ea39: enable settings by default (authored by sitter).
enable settings by default
Aug 20 2019, 10:51 AM