sitter (Harald Sitter)
Engineering

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Sep 15 2015, 12:04 PM (174 w, 6 d)
Availability
Available

Recent Activity

Thu, Jan 17

sitter closed D18309: don't set python exe to undefined.
Thu, Jan 17, 10:20 AM · Plasma
sitter committed R98:51e27ecf4057: don't set python exe to undefined (authored by sitter).
don't set python exe to undefined
Thu, Jan 17, 10:20 AM
sitter updated the test plan for D18309: don't set python exe to undefined.
Thu, Jan 17, 7:57 AM · Plasma
sitter updated the title for P289 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Thu, Jan 17, 7:51 AM
sitter added a reviewer for D18309: don't set python exe to undefined: davidedmundson.
Thu, Jan 17, 7:44 AM · Plasma
sitter requested review of D18309: don't set python exe to undefined.
Thu, Jan 17, 7:44 AM · Plasma
sitter added a comment to T10365: Neon Qt delta.

compat down to 10 is almost certainly a hack done for xenial. bionic has dh11

Thu, Jan 17, 7:13 AM · Neon

Wed, Jan 16

sitter committed R255:2e326d7b2eec: do not install an so-symlink for elisaLib (authored by sitter).
do not install an so-symlink for elisaLib
Wed, Jan 16, 11:35 AM
sitter closed D18266: do not install an so-symlink for elisaLib.
Wed, Jan 16, 11:35 AM

Tue, Jan 15

sitter added a reviewer for D18266: do not install an so-symlink for elisaLib: mgallien.
Tue, Jan 15, 2:55 PM
sitter requested review of D18266: do not install an so-symlink for elisaLib.
Tue, Jan 15, 2:53 PM
sitter updated the title for P288 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Tue, Jan 15, 12:02 PM

Mon, Jan 14

sitter accepted D10716: handle wrong password when using sudo which asks for another password.

lgtm

Mon, Jan 14, 4:10 PM · Frameworks
sitter added a comment to D18245: [DrKonqi] Create QApplication in a scope to fix possible deadlock.

please provide some backtraces. This looks like a hack, the qa decidedly shouldn't get stuck on destruction just because cleanup already ran.

Mon, Jan 14, 3:52 PM · Plasma
sitter committed R265:5ba6283e4ec1: fix environment setup of klanguagename test (authored by sitter).
fix environment setup of klanguagename test
Mon, Jan 14, 11:14 AM
sitter closed D18178: fix environment setup of klanguagename test.
Mon, Jan 14, 11:14 AM · Frameworks
sitter updated the summary of D18178: fix environment setup of klanguagename test.
Mon, Jan 14, 11:13 AM · Frameworks
sitter committed R436:119d08830e51: Merge branch 'Applications/18.12' (authored by sitter).
Merge branch 'Applications/18.12'
Mon, Jan 14, 11:11 AM
sitter closed D18151: properly show xfreerdp runtime dependency in cmake summary.
Mon, Jan 14, 11:11 AM
sitter committed R436:f013a85b5a2c: properly show xfreerdp runtime dependency in cmake summary (authored by sitter).
properly show xfreerdp runtime dependency in cmake summary
Mon, Jan 14, 11:11 AM
sitter added a comment to D10716: handle wrong password when using sudo which asks for another password.

BUILD_TESTING easy fix: https://phabricator.kde.org/source/knotifyconfig/browse/master/CMakeLists.txt$60

Mon, Jan 14, 11:09 AM · Frameworks

Fri, Jan 11

sitter updated the diff for D18151: properly show xfreerdp runtime dependency in cmake summary.

rename the package to freerdp but explicitly mention that the xfreerdp binary is needed

Fri, Jan 11, 11:32 AM
sitter requested review of D18178: fix environment setup of klanguagename test.
Fri, Jan 11, 10:27 AM · Frameworks
sitter added inline comments to D18151: properly show xfreerdp runtime dependency in cmake summary.
Fri, Jan 11, 9:18 AM
sitter added a comment to D10446: Add KLanguageName.

Oh actually. I have a theory. My environment vars were wrong. Try with s/LANG/LANGUAGE and s/LOCALE/LANG please.

Fri, Jan 11, 9:16 AM · Frameworks
sitter added a comment to D10446: Add KLanguageName.

You'll have to debug this for us. It passes on build.kde.org 😒

Fri, Jan 11, 9:13 AM · Frameworks

Thu, Jan 10

sitter committed R1025:23901ced369b: update deps (authored by sitter).
update deps
Thu, Jan 10, 12:45 PM
sitter updated subscribers of D18151: properly show xfreerdp runtime dependency in cmake summary.

somewhat unrelated ... @whiting do you recall why line 83 still says "Needs porting"? according to the git history you ported this a couple months after but the comment was not removed.

Thu, Jan 10, 11:41 AM
sitter added a reviewer for D18151: properly show xfreerdp runtime dependency in cmake summary: KDE Applications.
Thu, Jan 10, 11:40 AM
sitter requested review of D18151: properly show xfreerdp runtime dependency in cmake summary.
Thu, Jan 10, 11:39 AM
sitter committed R436:f7467114ff4b: Merge branch 'Applications/18.12' (authored by sitter).
Merge branch 'Applications/18.12'
Thu, Jan 10, 11:30 AM
sitter committed R436:c3ba7c0e3eb9: style++ (authored by sitter).
style++
Thu, Jan 10, 11:30 AM

Wed, Jan 9

sitter committed R265:91077def022a: Add KLanguageName (authored by aacid).
Add KLanguageName
Wed, Jan 9, 3:16 PM
sitter closed D10446: Add KLanguageName.
Wed, Jan 9, 3:16 PM · Frameworks
sitter added inline comments to D10446: Add KLanguageName.
Wed, Jan 9, 3:15 PM · Frameworks
sitter added a comment to D14241: [phonon-gstreamer] Do not trigger paused state on 0 percentage.

Is there a reason you didn't push that into the stable branch?

Wed, Jan 9, 12:30 PM
sitter committed R487:1d1681db561a: bump version from 4.10.1 to 4.10.2 (authored by sitter).
bump version from 4.10.1 to 4.10.2
Wed, Jan 9, 12:26 PM

Tue, Jan 8

sitter committed R572:d21b768b7c0f: drop version lock on bundler (authored by sitter).
drop version lock on bundler
Tue, Jan 8, 1:56 PM
sitter committed R572:30b81ff28e75: remove ruby 2.2 support (authored by sitter).
remove ruby 2.2 support
Tue, Jan 8, 1:56 PM
sitter committed R572:7db18d67127e: support ruby 2.6 (authored by sitter).
support ruby 2.6
Tue, Jan 8, 1:56 PM
sitter committed R572:ec11313a92b5: don't leave dangling .svn directories (authored by sitter).
don't leave dangling .svn directories
Tue, Jan 8, 1:26 PM
sitter committed R572:5d0e45a9686a: add convenience variant to get and clean from a vcs in one step (authored by sitter).
add convenience variant to get and clean from a vcs in one step
Tue, Jan 8, 1:26 PM
sitter committed R572:de72bd870fe2: make git.get a bit more compact (authored by sitter).
make git.get a bit more compact
Tue, Jan 8, 1:26 PM
sitter committed R572:0840cb62c3a3: use git from module correctly (authored by sitter).
use git from module correctly
Tue, Jan 8, 1:26 PM
sitter added inline comments to D10446: Add KLanguageName.
Tue, Jan 8, 10:30 AM · Frameworks

Mon, Jan 7

sitter triaged T10285: assert release coverage as Low priority.
Mon, Jan 7, 2:26 PM · Neon
sitter added a comment to T10219: Ship the plasma-workspace-wallpapers package by default in Neon.

if the diff doesn't get landed, another cheap approach is to add a button 'install addition wallpapers' in the wallpaper kcm which opens discover with an appstream component for the wallpapers. it'd be similar to a patch I maintained at kubuntu except with appstream ids we can now solve this properly in plasma itself without patching

Mon, Jan 7, 1:55 PM · Neon
sitter added a task to D18005: Include only the largest size for each wallpaper: T10219: Ship the plasma-workspace-wallpapers package by default in Neon.
Mon, Jan 7, 1:44 PM · Plasma
sitter added a revision to T10219: Ship the plasma-workspace-wallpapers package by default in Neon: D18005: Include only the largest size for each wallpaper.
Mon, Jan 7, 1:44 PM · Neon
sitter committed R37:0c1da950700a: encode the old appstream id as provided by the new appstream id (authored by sitter).
encode the old appstream id as provided by the new appstream id
Mon, Jan 7, 1:32 PM
sitter committed R37:28fed10f4a84: encode the old appstream id as provided by the new appstream id (authored by sitter).
encode the old appstream id as provided by the new appstream id
Mon, Jan 7, 1:32 PM
sitter closed D18036: encode the old appstream id as provided by the new appstream id.
Mon, Jan 7, 1:32 PM · Krita
sitter added a comment to D18036: encode the old appstream id as provided by the new appstream id.

I am not sure if this needs to go anywhere but master. Please advise.

Mon, Jan 7, 11:23 AM · Krita
sitter requested review of D18036: encode the old appstream id as provided by the new appstream id.
Mon, Jan 7, 11:23 AM · Krita
sitter updated the diff for D10446: Add KLanguageName.

add an empty es directory to see in the source that es is meant to be empty. serves no purpose other than making things more obvious

Mon, Jan 7, 11:15 AM · Frameworks
sitter updated the diff for D10446: Add KLanguageName.

configure_file the fixtures lest they get mangled by scripty on account of being desktop files

Mon, Jan 7, 11:13 AM · Frameworks
sitter triaged T10282: appstream override tech as Low priority.
Mon, Jan 7, 10:37 AM · Neon
sitter added a comment to D15573: replace custom backtracing in SlaveBase with KCrash.

I am somewhat indifferent. It certainly has caused some grief for various reasons in various places, so it stands to reason that it should go. Also since auto-init of kcrash is essentially not a thing for application code (what with link-as-needed being a common distro flag) it's possibly more consistent to move it's enabling to the individual slaves.

Mon, Jan 7, 10:25 AM · Frameworks
sitter added a comment to T10219: Ship the plasma-workspace-wallpapers package by default in Neon.

I agree but then it's so large!!! oof

Mon, Jan 7, 12:52 AM · Neon
sitter added inline comments to D10446: Add KLanguageName.
Mon, Jan 7, 12:36 AM · Frameworks

Dec 18 2018

sitter added inline comments to D10446: Add KLanguageName.
Dec 18 2018, 10:36 AM · Frameworks
sitter updated the diff for D10446: Add KLanguageName.

move env setup to qcorestartup to prevent the env from not getting set up in time and the tests failing as a result

Dec 18 2018, 10:35 AM · Frameworks

Dec 15 2018

sitter added a comment to D10446: Add KLanguageName.

But you end up repeating that in lots of places (which we should there's lots of places that suffer from trying to guess a language name at this point, and all of them went the bad way one way or another). If you want to give some random potential user more flexibility i'm fine with that, add some flags, but i want the "give me the best you can do" possibility to still work. Maybe we should even never return an empty string and worst case scenario return code back.

Dec 15 2018, 3:59 PM · Frameworks
sitter updated the diff for D10446: Add KLanguageName.

iterating the diff a bit as mentioned in a comment.

Dec 15 2018, 3:53 PM · Frameworks

Dec 14 2018

sitter added a comment to D10446: Add KLanguageName.

Stacking the functions seems to work fine

Dec 14 2018, 10:15 AM · Frameworks

Dec 13 2018

sitter added a comment to D17560: fully port away from kdelibs4support.

Fair enough. If you tell me what needs doing I can poke it. I don't want to invest too much time, but at a glance what you have done seems pretty much done really.

Dec 13 2018, 3:29 PM
sitter added a comment to D10446: Add KLanguageName.

@aacid what were the changes you had planned here?

Dec 13 2018, 3:27 PM · Frameworks
sitter requested review of D17560: fully port away from kdelibs4support.
Dec 13 2018, 1:51 PM
sitter requested changes to D17539: [dragon] Add ability to play multiple files.

This has no UI-backing (i.e. dragon has no playlist), and dragon won't get UI-backing because it is intentionally designed not to have a playlist. Opening multiple files would go against one of the core designs of dragon.

Dec 13 2018, 9:43 AM

Dec 12 2018

sitter accepted D17524: [dragon] Do not allow changing volume on scroll event in load view.

The amount of if conditions in the MainWindow is rising at an alarming rate :|

Dec 12 2018, 9:19 AM

Dec 11 2018

sitter committed R328:00609ad6dc74: use nullptr instead of NULL (authored by sitter).
use nullptr instead of NULL
Dec 11 2018, 8:18 AM
sitter closed D17478: use nullptr instead of NULL.
Dec 11 2018, 8:18 AM · KDE Edu
sitter committed R923:506ae97fd397: rebrand index (authored by sitter).
rebrand index
Dec 11 2018, 8:18 AM
sitter closed D17475: rebrand index.
Dec 11 2018, 8:18 AM

Dec 10 2018

sitter added a comment to D17486: Fix PulseAudio support with Qt 5.12.

4.10 as well please

Dec 10 2018, 6:11 PM
sitter accepted D17486: Fix PulseAudio support with Qt 5.12.
Dec 10 2018, 6:06 PM
sitter accepted D17479: Fix build without phonon.

Oh la la, I didn't even realize phonon was optional. New code is much better.

Dec 10 2018, 3:32 PM · Frameworks
sitter requested review of D17478: use nullptr instead of NULL.
Dec 10 2018, 2:53 PM · KDE Edu
sitter added a comment to D17475: rebrand index.

For the record, other random stuff the people I was talking with just now were whining about, but I am not addressing because I really only want this branding issue gone:

Dec 10 2018, 1:55 PM
sitter updated the diff for D17475: rebrand index.

actually change from KDE project to KDE community, makes most sense I feel

Dec 10 2018, 1:47 PM
sitter requested review of D17475: rebrand index.
Dec 10 2018, 1:42 PM
sitter accepted D14241: [phonon-gstreamer] Do not trigger paused state on 0 percentage.

Well, dvratil is maintainer you don't need me to accept really, I'll just defer to him anyway :P

Dec 10 2018, 1:36 PM
sitter committed R424:0448ba56231c: set project license (authored by sitter).
set project license
Dec 10 2018, 1:24 PM
sitter committed R424:fca3f21e71a8: update picmi screenshot to a variant using breeze styling and the cdn host (authored by sitter).
update picmi screenshot to a variant using breeze styling and the cdn host
Dec 10 2018, 1:24 PM
sitter added inline comments to D14241: [phonon-gstreamer] Do not trigger paused state on 0 percentage.
Dec 10 2018, 1:18 PM
sitter added a comment to D14241: [phonon-gstreamer] Do not trigger paused state on 0 percentage.

Well, I can't make a release if you don't land the commit?

Dec 10 2018, 1:17 PM
sitter committed R489:179fac0d37bf: Merge branch '0.10' (authored by sitter).
Merge branch '0.10'
Dec 10 2018, 11:30 AM
sitter committed R489:e441972892fe: always print status info on vlc finding (even when not found) (authored by sitter).
always print status info on vlc finding (even when not found)
Dec 10 2018, 11:30 AM
sitter closed D17473: always print status info on vlc finding (even when not found).
Dec 10 2018, 11:30 AM
sitter requested review of D17473: always print status info on vlc finding (even when not found).
Dec 10 2018, 11:28 AM

Dec 7 2018

sitter committed R320:55eb68ff6364: fallback to dnssd service discovery if smb listDir failed on root (authored by sitter).
fallback to dnssd service discovery if smb listDir failed on root
Dec 7 2018, 12:59 PM
sitter closed D16299: fallback to dnssd service discovery if smb listDir failed on root.
Dec 7 2018, 12:59 PM · Frameworks, Dolphin
sitter updated the title for P280 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Dec 7 2018, 11:37 AM

Dec 5 2018

sitter committed R234:a6365ce24c89: add "new" picmi screenshot (authored by sitter).
add "new" picmi screenshot
Dec 5 2018, 4:03 PM
sitter added a comment to T10152: Update www.kde.org to this decade.

This is not the place to talk about this. kde-community is the better place I should think.

kde-www is the better place, but since Jon already posted an email there saying "let's track it in phabricator", now suddenly this is the place to discuss it.

Just as a side note i find it EXTREMELY charming, that you, the very same person that bulldozed the new design without any kind of community involvement, are now is saying "but we should ask the community about the design!!!!!!1"

Dec 5 2018, 1:52 PM · KDE Promo
sitter added a comment to T10152: Update www.kde.org to this decade.

This is not the place to talk about this. kde-community is the better place I should think.

Dec 5 2018, 11:16 AM · KDE Promo
sitter added a comment to T10152: Update www.kde.org to this decade.

Please no. The idea is to generate the content of /applications/ from the appdata files and other resources. The wiki is not good for consistency.
Please check the past discussions on kde-www.

If I recall, @sitter pushed some code to do this last year, and it was mostly really great, but unfortunately got reverted because it wasn't quite perfect. It might be a good idea to revisit that effort with an eye towards keeping it in production and fixing whatever issues present themselves.

Dec 5 2018, 10:17 AM · KDE Promo

Nov 29 2018

sitter committed R305:f6d55baf5aa8: do not attempt to link phononexperimental :O (authored by sitter).
do not attempt to link phononexperimental :O
Nov 29 2018, 12:26 PM
sitter closed D17234: do not attempt to link phononexperimental :O.
Nov 29 2018, 12:26 PM · Frameworks
sitter updated the test plan for D17234: do not attempt to link phononexperimental :O.
Nov 29 2018, 12:22 PM · Frameworks