- User Since
- Apr 19 2015, 9:33 AM (241 w, 6 d)
Sun, Dec 1
Release published and announced :)
Fri, Nov 29
I checked your diff, though unlike the other fixes you did this one was a little more complicated to handle;
and so I did a proper fix to be sure it's fixed in time for the release this week-end.
Thanks for looking at it,
though I fixed it in master a bit more properly.
You can check the commit for reference here: d3972d63d49000b76d2b1fb5011701ade6dd12cb
Thanks, commited in 6d3be37985f9b8e13fd9095c260903fa01ac0f33 .
Wed, Nov 27
OK now I think I see what you mean.
Indeed the domain is managed by me, which is the simplest solution as we need to keep it on my server and I need to manage emails on this domain.
Tue, Nov 26
Mon, Nov 25
Fixed in commit 7a5188e9ef0846aad1ff7bec8ae6a66d7147029e .
Looks good, thanks.
I'll commit it.
Yes it is still open, you can work on it.
Sun, Nov 24
Commited in master.
Thanks, I'll commit it.
However I need your full name and email address to credit you as author of the commit (you can tell here or on irc).
This task got a bit lost in the backlog, as I was waiting for more comments before proceeding.
But I guess it's ok to proceed now.
It will not be changed for the coming release as it's in string freeze, but it can be changed in master branch for the next one.
Better rename it just as I suggested in the task: "count intervals". Shorter and simpler.
Thu, Nov 21
Wed, Nov 20
Tue, Nov 19
Thu, Nov 14
Nov 6 2019
Nov 5 2019
Oct 31 2019
Actually now I see digital electricity was in the list of the task description, but as the user's answer is always in place after pressing ok, I do think "check answer" makes sense.
I tested and found more activities where the voice "Check answer" made sense, so I changed those too :
find the day
letter in which word
woops indeed I forgot that; now done :)
Oct 30 2019
Voices recorded for en_GB, fr and ml.
Commited on gcompris-data repository, and rcc files updated on the server.
Tested on master, all works good :)
Oct 29 2019
Here are my little changes (adapted the overlay color and size, the captured pieces size, and add hide-on-click-overlay).
Good plan then :)
Actually we'll record those voices tomorrow, will be easier.
I'll update the voices rcc on the server after that.
Since aman managed to fix the remaining bug, I'd say it's good to merge now.
Ok, the "missing track" issue is fixed, at the cost of bringing back the "restart needed to re-enable music if started without" bug.
As I noted in the commit comment, ideally fixing both would be best, but if not possible it's less bad to keep the restart-needed issue than the missing track one.
Do you plan to do the changes to add the pop-up as I described, or should I do it?
Good idea; Here we can record voice for English, French and Malayalam, will be done today.
Ouch, actually I found a last remaining bug: when the music reaches the end of last track in the list, it restarts on track 2 instead of track 1... (it doesn't happen when using the "Next" button, only when playing normally).
I'll look at it.
All features completed, bugs fixed, and thoroughly tested.
@jjazeix can you please merge it to master ?
Oct 28 2019
Oct 27 2019
I added a note about this in gcompris-data repository ( https://cgit.kde.org/gcompris-data.git/commit/?id=e0537083aebc8136c123cfe4094d43ccdb43bd30 ).
Let's keep those images a little longer for retro-compatibility with pre-0.95 versions of GCompris.
task resolved long time ago, closing it.