- User Since
- Apr 19 2015, 9:33 AM (226 w, 3 d)
Thanks. To me it looks good.
Though waiting for others comments too.
Tested, all works as expected.
There is still the star level associated with the datasets which need to be properly set, as on most of the datasets you added...
Beside this, the rest looks ok.
Tested, for me it's good to merge.
I wait for other mentors advices on the code before pushing the "Accept Revision" button.
I tested the patch on multiple_dataset branch, and noticed several issues.
Thu, Aug 15
Sun, Aug 11
Thu, Aug 8
Actually I agree with Johnny's comment about alphabet-sequence activity; better not add dataset to it and instead see how we can improve its pedagogical side.
Mon, Aug 5
Fri, Aug 2
Thu, Aug 1
Tue, Jul 30
Thu, Jul 25
Why did you duplicate the svg images from planegame in the alphabet-sequence activity (cloud, cloud_storm and tuxhelico) ?
It is not needed and only increase the size of the package.
Jul 17 2019
Jul 11 2019
Jul 9 2019
Jul 2 2019
Thanks for the patch, it has a few different things than what I tried so it might work.
I'll make the test apk when I'm back, check with them and forward the result.
Jun 28 2019
Jun 27 2019
All the comments have been addressed, looks good for me.
Jun 21 2019
Jun 20 2019
Jun 19 2019
Jun 18 2019
I didn't comment before as I saw others did and I didn't see anything more to say on that diff.
But yes, good work!
Jun 17 2019
Jun 16 2019
Jun 15 2019
@amankumargupta : those errors probably just mean some parts of those svg images are not read properly.
Those errors will go when I draw new images anyway, no need to worry about it for now if the images still look ok as placeholder.
Jun 13 2019
Jun 12 2019
sorry @AkshayCHD for taking time to answer your question "So should I start with that part after money activity or start working on them while working on planned activities only or take them up at the end."
I would say as you planned to look at those issues from 9th to 20th of August, better follow your plan and focus on the current task.
Jun 11 2019
Jun 10 2019
May 13 2019
May 4 2019
May 3 2019
Apr 20 2019
Apr 19 2019
This is how it looks after applying his patch
Yes I did read that comment, but still it's a bad design idea to mix half transparent text with the area to interact with, it doesn't look really good. Also we can easily have space in the bar with items to drag for that new button.
Actually this is not a good plan in my opinion, as in some levels we need to place several boys and girls, and it will not fit anymore in the area.
I propose a better plan: keep current behavior (hide the instructions when dragging items), but also add an explicit button to display again the instructions on top of placed items in the area. (for this button, you can use any temporary icon, I'll make a good one when the patch is accepted).