- User Since
- May 2 2015, 5:25 PM (193 w, 4 d)
Speed issue fixed, thanks
Here is the current state after the first changes to the code.
Tue, Jan 15
This is now committed, thanks (our KDE repository is currently read-only because we are testing a new infrastructure)
So I started implementing colors in the timeline. I agree that we should ideally use variations of the theme's original colors, in our case mostly breeze dark: https://community.kde.org/KDE_Visual_Design_Group/HIG/BreezeDark
Mon, Jan 14
committed now in git, thanks
Sat, Jan 12
Thanks for this contribution!
We could add a "record button" to audio tracks.
When triggered, it would remember the timeline position, start playing timeline and start recording audio using ffmpeg (using something similat to what we do in src/monitor/recmanager.cpp, line 240 and following with screen grab.
Fri, Jan 11
I don't really understand the what you are looking for. Your current patch does take into account the screen size at line 354:
I just committed your change.
Thu, Jan 10
Wed, Jan 9
2 comments there:
A hardcoded size is never good. For example on my laptop, this results in unnecessarily wide dialog. I don't see a perfect solution but would recommend this:
- Restore default can normally be done with middle mouse click - although I understand it's not the best since unavailable to Mac/Windows/Laptop users. We should add another default
Tue, Jan 8
Mon, Jan 7
Yes, thanks for pointing this. I just backported the fix to the stable 18.12 branch
Sun, Jan 6
... or do you have commit rights ? If not, please give me your full name so that I can acknowledge you as the commit author.
Perfect, thanks! Will commit right now.
Thanks for this contribution. To convert an url to a string, it is recommended to use toLocalFile() instead of toString() .
Also, the m_projectTitlePath variable is local to the titleWidget, so it is lost as soon as you close the title widget. To work around that, I used a KDE class that was designed to store paths for file dialogs: KRecentDirs::dir(QStringLiteral(":KdenliveProjectsTitles"));
Well, I had a look and we use FFmpeg but not the showwave effect. Currently we retrieve the audio data directly from FFmpeg using the "data" effect which does not seem to allow logarithmic output. We might have to perform the transformation on our side... so it's a bit more work...
Sat, Jan 5
Thanks, I have pushed the change.