GB_2 (Björn Feber)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2018, 6:27 PM (9 w, 4 d)
Availability
Available

Recent Activity

Yesterday

GB_2 updated the description for M144: New panel right click context menu.
Mon, Dec 10, 8:03 PM · VDG, Plasma
GB_2 updated the description for M144: New panel right click context menu.
Mon, Dec 10, 7:58 PM · VDG, Plasma
GB_2 updated the description for M144: New panel right click context menu.
Mon, Dec 10, 7:57 PM · VDG, Plasma
GB_2 created M144: New panel right click context menu.
Mon, Dec 10, 7:53 PM · VDG, Plasma
GB_2 updated the diff for D17416: [kcmkwin/compositing] Remove effect list item selection, fix list item size after hiding the effect video, use a real button as the play button and use the right busy indicator.

Remove unused code.

Mon, Dec 10, 6:37 PM · VDG, KWin

Sun, Dec 9

GB_2 added a comment to D17288: Fix hardcoded private browsing icon.

https://phabricator.kde.org/R266:b849a63cefb3 got added.

Sun, Dec 9, 7:25 PM · Falkon
GB_2 added a comment to D17416: [kcmkwin/compositing] Remove effect list item selection, fix list item size after hiding the effect video, use a real button as the play button and use the right busy indicator.

Should these list items even become selected when clicked? Typically items are only selectable when there are some actions you can apply to selected items, which isn't the case here.

Sun, Dec 9, 5:55 PM · VDG, KWin
GB_2 added a comment to T10152: Update www.kde.org to this decade.

The newest KDE Frameworks announcement (https://www.kde.org/announcements/kde-frameworks-5.53.0.php) still has the old KDE Logo and the old Qt logo.
I made an updated image:

Sun, Dec 9, 1:25 PM · KDE Promo

Sat, Dec 8

GB_2 added a comment to D17410: Add alternatives button to applet configuration in panel edit mode.

I'm trying to emit the signal contextualActionsAboutToShow in the (QML) onVisualParentChanged function, but it doesn't work...

Sat, Dec 8, 11:46 PM · VDG, Plasma
GB_2 added a revision to T10047: Guerilla UX testing: a GNOME switcher: D17321: Change panel edit mode icon from from a hamburger icon to a configure icon.
Sat, Dec 8, 10:13 PM · VDG, Plasma
GB_2 added a task to D17321: Change panel edit mode icon from from a hamburger icon to a configure icon: T10047: Guerilla UX testing: a GNOME switcher.
Sat, Dec 8, 10:13 PM · VDG, Plasma
GB_2 added a comment to T10047: Guerilla UX testing: a GNOME switcher.

Would it help if "Alternatives" got renamed to "Alternative Widgets"?
It already says that in the title of the alternatives popup.

Sat, Dec 8, 10:11 PM · VDG, Plasma
GB_2 added a comment to T10047: Guerilla UX testing: a GNOME switcher.
Sat, Dec 8, 10:03 PM · VDG, Plasma
GB_2 added a task to D17410: Add alternatives button to applet configuration in panel edit mode: T10047: Guerilla UX testing: a GNOME switcher.
Sat, Dec 8, 10:03 PM · VDG, Plasma
GB_2 added a revision to T10047: Guerilla UX testing: a GNOME switcher: D17410: Add alternatives button to applet configuration in panel edit mode.
Sat, Dec 8, 10:03 PM · VDG, Plasma
GB_2 added a revision to T10047: Guerilla UX testing: a GNOME switcher: D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.
Sat, Dec 8, 10:02 PM · VDG, Plasma
GB_2 added a task to D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips: T10047: Guerilla UX testing: a GNOME switcher.
Sat, Dec 8, 10:02 PM · VDG, Plasma
GB_2 updated the diff for D17288: Fix hardcoded private browsing icon.

Prepare for https://phabricator.kde.org/D17419.

Sat, Dec 8, 9:19 PM · Falkon
GB_2 added a comment to D17419: Add view-private icon.

If view-private-symbolic is just a symlink to the regular icon, do we really need it?

Sat, Dec 8, 9:16 PM · VDG, Breeze, Frameworks
GB_2 updated the diff for D17419: Add view-private icon.

Improve icons (wider hat brim).
It's perfect now :-)

Sat, Dec 8, 9:02 PM · VDG, Breeze, Frameworks
GB_2 added a comment to D17419: Add view-private icon.
Sat, Dec 8, 8:26 PM · VDG, Breeze, Frameworks
GB_2 added a comment to D17419: Add view-private icon.
Sat, Dec 8, 8:20 PM · VDG, Breeze, Frameworks
GB_2 updated the summary of D17419: Add view-private icon.
Sat, Dec 8, 7:59 PM · VDG, Breeze, Frameworks
GB_2 updated the diff for D17419: Add view-private icon.

Change name to the more common "view-private" and add a symlink for the symbolic icon.

Sat, Dec 8, 7:51 PM · VDG, Breeze, Frameworks
GB_2 requested review of D17440: Rotate busy indicator clockwise.
Sat, Dec 8, 7:33 PM · VDG, Breeze, Plasma
GB_2 updated the diff for D17419: Add view-private icon.

Only provide correct 16px icons.

Sat, Dec 8, 6:53 PM · VDG, Breeze, Frameworks
GB_2 retitled D17416: [kcmkwin/compositing] Remove effect list item selection, fix list item size after hiding the effect video, use a real button as the play button and use the right busy indicator from [Effects KCM] Use a better selection color, fix list item size after hiding the effect video, use a real button as the play button and use the right busy indicator to [Effects KCM] Remove effect list item selection, fix list item size after hiding the effect video, use a real button as the play button and use the right busy indicator.
Sat, Dec 8, 5:40 PM · VDG, KWin
GB_2 added a comment to D17410: Add alternatives button to applet configuration in panel edit mode.

Neat, it seems to generally work well. I notice that when I click the new menu item, it somewhat unexpectedly exits from panel edit mode. I wonder if we could make it not do that, so it would stay in panel edit mode if invoked while in panel edit mode.

Sat, Dec 8, 5:39 PM · VDG, Plasma
GB_2 updated the diff for D17416: [kcmkwin/compositing] Remove effect list item selection, fix list item size after hiding the effect video, use a real button as the play button and use the right busy indicator.

Use the right busy indicator.

Sat, Dec 8, 5:33 PM · VDG, KWin
GB_2 added a comment to D17416: [kcmkwin/compositing] Remove effect list item selection, fix list item size after hiding the effect video, use a real button as the play button and use the right busy indicator.

Hmm, why did you change the busy indicator? I think the current one is fine. The new one is something I haven't seen used anywhere else.

Sat, Dec 8, 3:49 PM · VDG, KWin
GB_2 updated the diff for D17416: [kcmkwin/compositing] Remove effect list item selection, fix list item size after hiding the effect video, use a real button as the play button and use the right busy indicator.

Remove effect list item selection and use a Breeze BusyIndicator.
Opening a new dialog for the video would need some more work, so it's not included here.

Sat, Dec 8, 3:00 PM · VDG, KWin
GB_2 updated the test plan for D17419: Add view-private icon.
Sat, Dec 8, 2:49 PM · VDG, Breeze, Frameworks
GB_2 added a comment to D17419: Add view-private icon.

Oh, thanks for reminding me about Cuttlefish...
I forgot about it, but now I don't need a QML for testing icons anymore :P

Sat, Dec 8, 2:48 PM · VDG, Breeze, Frameworks
GB_2 added a comment to D17419: Add view-private icon.

How is that even possible? There is no 48 px size icon and the one you showed was and older version of the icon...

Sat, Dec 8, 2:40 PM · VDG, Breeze, Frameworks
GB_2 updated the diff for D17419: Add view-private icon.

Improve icons.

Sat, Dec 8, 1:21 PM · VDG, Breeze, Frameworks
GB_2 retitled D17416: [kcmkwin/compositing] Remove effect list item selection, fix list item size after hiding the effect video, use a real button as the play button and use the right busy indicator from [Effects KCM] Use a better selection color, fix list item size after hiding the effect video and use a real button the play button to [Effects KCM] Use a better selection color, fix list item size after hiding the effect video and use a real button as the play button.
Sat, Dec 8, 12:39 PM · VDG, KWin
GB_2 updated the diff for D17419: Add view-private icon.

Improve icons.

Sat, Dec 8, 10:18 AM · VDG, Breeze, Frameworks
GB_2 added a comment to D17419: Add view-private icon.
Sat, Dec 8, 10:12 AM · VDG, Breeze, Frameworks
GB_2 added a comment to D17419: Add view-private icon.

Very Chrome/-ium like :)

Maybe expanding the bottom line just a tad more would make it more obvious it's a private eye's hat? Right now it still looks a bit more like eyebrows to me.

Firefox's mask also maybe isn't a bad idea:

Sure, I'll improve it!

Sat, Dec 8, 12:22 AM · VDG, Breeze, Frameworks

Fri, Dec 7

GB_2 updated the diff for D17419: Add view-private icon.

Improve icons.

Fri, Dec 7, 11:05 PM · VDG, Breeze, Frameworks
GB_2 requested review of D17419: Add view-private icon.
Fri, Dec 7, 10:09 PM · VDG, Breeze, Frameworks
GB_2 requested review of D17416: [kcmkwin/compositing] Remove effect list item selection, fix list item size after hiding the effect video, use a real button as the play button and use the right busy indicator.
Fri, Dec 7, 8:13 PM · VDG, KWin
GB_2 updated the diff for D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.

Hide the tooltip if you click on it.

Fri, Dec 7, 6:21 PM · VDG, Plasma
GB_2 added a comment to D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.

It's okay :-)

Fri, Dec 7, 6:07 PM · VDG, Plasma
GB_2 added a comment to D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.

when resizing the panel can we show the width of it
48px ,36px etc
because now when I resize the panel I guess what better visually
but if I know the size exactly It will much better
like all other panels latte dock for example

Fri, Dec 7, 6:04 PM · VDG, Plasma
GB_2 updated the diff for D17410: Add alternatives button to applet configuration in panel edit mode.

Update TODO text.

Fri, Dec 7, 6:00 PM · VDG, Plasma
GB_2 updated the summary of D17410: Add alternatives button to applet configuration in panel edit mode.
Fri, Dec 7, 5:58 PM · VDG, Plasma
GB_2 requested review of D17410: Add alternatives button to applet configuration in panel edit mode.
Fri, Dec 7, 5:56 PM · VDG, Plasma
GB_2 updated the diff for D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.

Fix tooltip text color (for real this time).

Fri, Dec 7, 4:05 PM · VDG, Plasma
GB_2 updated the diff for D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.
Fri, Dec 7, 3:18 PM · VDG, Plasma
GB_2 updated the diff for D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.

Improve wording.

Fri, Dec 7, 2:48 PM · VDG, Plasma
GB_2 updated the summary of D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.
Fri, Dec 7, 2:06 PM · VDG, Plasma
GB_2 updated the diff for D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.

Add tooltip for the resize button, change tooltip text and increase tooltip timeout.

Fri, Dec 7, 1:59 PM · VDG, Plasma
GB_2 updated the diff for D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.

Increase tooltip timeout.

Fri, Dec 7, 6:57 AM · VDG, Plasma
GB_2 updated the diff for D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.

Improve code and add tooltip timeout.

Fri, Dec 7, 6:55 AM · VDG, Plasma

Thu, Dec 6

GB_2 updated the diff for D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.

Add import.

Thu, Dec 6, 4:59 PM · VDG, Plasma
GB_2 added a comment to D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.

Oops, forgot the import...

Thu, Dec 6, 4:58 PM · VDG, Plasma
GB_2 updated the diff for D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.

Use QQC2 tooltip.

Thu, Dec 6, 4:56 PM · VDG, Plasma
GB_2 updated the diff for D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.

Added the tooltip.


It is ready now!

Thu, Dec 6, 4:31 PM · VDG, Plasma

Wed, Dec 5

GB_2 added a comment to D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.

Ok, number two then.

Wed, Dec 5, 9:38 PM · VDG, Plasma
GB_2 added a comment to D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.

Because https://phabricator.kde.org/D17355 is currently not working properly, we have two options:

Wed, Dec 5, 9:26 PM · VDG, Plasma
GB_2 updated the diff for D17355: Align Plasma QML button content in center if it has an icon.

Improve menu button.

Wed, Dec 5, 9:16 PM · VDG, Plasma, Frameworks
GB_2 added a comment to D17355: Align Plasma QML button content in center if it has an icon.

Hmm... then I give up.

Wed, Dec 5, 9:09 PM · VDG, Plasma, Frameworks
GB_2 updated the diff for D17355: Align Plasma QML button content in center if it has an icon.

I can't figure out how to make "elide" work without using Layout.fillWidth.

Wed, Dec 5, 8:44 PM · VDG, Plasma, Frameworks
GB_2 updated the diff for D17355: Align Plasma QML button content in center if it has an icon.

Improved code.
How qmlscene tests/components/button.qml looks like:


For some reason "elide" doesn't work...

Wed, Dec 5, 4:48 PM · VDG, Plasma, Frameworks

Tue, Dec 4

GB_2 added a comment to D17355: Align Plasma QML button content in center if it has an icon.

It works properly, no matter how big the button is or if have an icon or not.
In my opinion we should leave it how it is now.

Tue, Dec 4, 7:29 PM · VDG, Plasma, Frameworks
GB_2 updated the diff for D17355: Align Plasma QML button content in center if it has an icon.
Tue, Dec 4, 7:27 PM · VDG, Plasma, Frameworks
GB_2 added a comment to T10152: Update www.kde.org to this decade.

I also really like the new theme, but this page still needs work: https://www.kde.org/community/donations/index.php

Tue, Dec 4, 7:05 PM · KDE Promo
GB_2 added a comment to D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.
Tue, Dec 4, 6:59 PM · VDG, Plasma
GB_2 updated the summary of D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.
Tue, Dec 4, 6:58 PM · VDG, Plasma
GB_2 requested review of D17355: Align Plasma QML button content in center if it has an icon.
Tue, Dec 4, 6:47 PM · VDG, Plasma, Frameworks
GB_2 added a comment to T10152: Update www.kde.org to this decade.

Ok...
Can we contribute to the applications page to help update it?

Tue, Dec 4, 2:13 PM · KDE Promo
GB_2 added a comment to T10152: Update www.kde.org to this decade.

https://www.kde.org/appliactions/ got ported to the new theme, but it still has many outdated apps, images and icons. Would it be better to use https://userbase.kde.org/Applications instead?

Tue, Dec 4, 2:04 PM · KDE Promo

Mon, Dec 3

GB_2 added a comment to T10152: Update www.kde.org to this decade.

The UserBase wiki links to it.

Mon, Dec 3, 11:00 PM · KDE Promo
GB_2 added a comment to T10152: Update www.kde.org to this decade.

This page needs to be updated too: https://www.kde.org/screenshots/

Mon, Dec 3, 10:53 PM · KDE Promo
GB_2 added a comment to D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.

I managed to fix it, but it the Plasma QML Button code needs to be changed. Should I create a new Phabricator revision or add it here?

Mon, Dec 3, 6:11 PM · VDG, Plasma
GB_2 added a comment to D17281: Add icon to KBuildSycocaProgressDialog cancel button.

Ok.
Email: feber70@gmail.com

Mon, Dec 3, 9:30 AM · VDG, Frameworks

Sun, Dec 2

GB_2 added a comment to D17281: Add icon to KBuildSycocaProgressDialog cancel button.

@GB_2, can you provide an email address so we can land this for you? Thanks!

How can I provide an email address in the Phabriactor webinterface?
I already provided an email in my email settings on here...

Sun, Dec 2, 10:12 PM · VDG, Frameworks
GB_2 added a comment to D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.

Hmm... when a button has an icon the content gets aligned on the left and I can't find a way to change it...

Sun, Dec 2, 9:47 PM · VDG, Plasma
GB_2 added a comment to D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.

Oh, you mean the button content...
I will try to fix that!

Sun, Dec 2, 9:02 PM · VDG, Plasma
GB_2 updated the diff for D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.

Update panel size button icons.

Sun, Dec 2, 8:34 PM · VDG, Plasma
GB_2 added a comment to D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.

+1, but why aren't the buttons content centered?

They are, do you think that because of the screenshot?

Sun, Dec 2, 8:13 PM · VDG, Plasma
GB_2 added a comment to D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.

Feel free to come up with a better wording; mine is probably crap since I just randomly thought of it. :p

Yeah :P

Sun, Dec 2, 8:04 PM · VDG, Plasma
GB_2 added a comment to D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.

This is awesome, thank you!

If this is not clear enough, would it be technically possible to display a tooltip explaining you have to drag the button and make that tooltip appear when the user clicks on the button without dragging it?

! In D17323#370398, @ngraham wrote:

Nice!

While we're at it, what do you think about adding a tooltip saying "Drag to the screen edge where you would like this panel to love" or something?

Ok, I will add that!

Sun, Dec 2, 8:03 PM · VDG, Plasma
GB_2 requested review of D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips.
Sun, Dec 2, 7:54 PM · VDG, Plasma
GB_2 updated the summary of D17321: Change panel edit mode icon from from a hamburger icon to a configure icon.
Sun, Dec 2, 7:00 PM · VDG, Plasma
GB_2 updated the diff for D17321: Change panel edit mode icon from from a hamburger icon to a configure icon.

Only change panel toolbox icon.

Sun, Dec 2, 6:57 PM · VDG, Plasma
GB_2 added a comment to D17321: Change panel edit mode icon from from a hamburger icon to a configure icon.

For the panel edit mode button, I think this is 100% appropriate since it opens a configuration UI. For the toolbox, I'm not as convinced yet, since clicking on it opens a menu with a number of non-configuration-related menu items. It's not the biggest deal, but it does feel a bit odd.

Thoughts?

Sun, Dec 2, 6:55 PM · VDG, Plasma
GB_2 requested review of D17321: Change panel edit mode icon from from a hamburger icon to a configure icon.
Sun, Dec 2, 6:42 PM · VDG, Plasma
GB_2 added a comment to D17307: Fix unreadable Falkon logo text when using a dark theme.

That looks good, but this image is also used in falkon:about page, please test that it is fine there too.

Sun, Dec 2, 1:26 PM · Falkon
GB_2 updated the diff for D17307: Fix unreadable Falkon logo text when using a dark theme.

Remove unneeded lines.

Sun, Dec 2, 1:23 PM · Falkon
GB_2 updated the test plan for D17307: Fix unreadable Falkon logo text when using a dark theme.
Sun, Dec 2, 1:19 PM · Falkon
GB_2 updated the test plan for D17307: Fix unreadable Falkon logo text when using a dark theme.
Sun, Dec 2, 1:19 PM · Falkon
GB_2 requested review of D17307: Fix unreadable Falkon logo text when using a dark theme.
Sun, Dec 2, 1:13 PM · Falkon
GB_2 added a comment to D17288: Fix hardcoded private browsing icon.

Good idea!
But which of the 3 icons now?

  • im-user
  • visibilty
  • hint
Sun, Dec 2, 10:26 AM · Falkon
GB_2 added a comment to D17288: Fix hardcoded private browsing icon.

Ok, but what should it look like, because the existing Breeze icons I told you about already look like a "private browsing/private mode" icon.

Sun, Dec 2, 10:16 AM · Falkon
GB_2 updated the diff for D17281: Add icon to KBuildSycocaProgressDialog cancel button.

Improve code (pass this as parent).

Sun, Dec 2, 10:12 AM · VDG, Frameworks

Sat, Dec 1

GB_2 added a comment to D17288: Fix hardcoded private browsing icon.

Maybe in your icon theme.
There is no "standard" icon for this action, so that's why it uses hardcoded icon.

It looks like the original one in Breeze too...
Is the icon "visibility" or "hint" better?
The hardcoded icon is a problem, when you use a bug report (as described in the bug report).

Sat, Dec 1, 8:22 PM · Falkon
GB_2 added a comment to D17288: Fix hardcoded private browsing icon.

im-user has completely different meaning than "private browsing".

Sat, Dec 1, 8:12 PM · Falkon
GB_2 requested review of D17288: Fix hardcoded private browsing icon.
Sat, Dec 1, 7:50 PM · Falkon