GB_2 (Björn Feber)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2018, 6:27 PM (45 w, 6 d)
Availability
Available

Recent Activity

Today

GB_2 updated the summary of D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses.
Thu, Aug 22, 10:26 AM · VDG, Plasma
GB_2 accepted D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses.
Thu, Aug 22, 9:33 AM · VDG, Plasma
GB_2 added inline comments to D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses.
Thu, Aug 22, 9:30 AM · VDG, Plasma
GB_2 added a project to D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses: VDG.
Thu, Aug 22, 9:29 AM · VDG, Plasma
GB_2 added a comment to D23174: Improve the look of the Activities KCM UI.

Ping.

Thu, Aug 22, 9:17 AM · KActivities, Plasma

Yesterday

GB_2 updated the test plan for D23049: Add Kirigami ListSectionHeader component.
Wed, Aug 21, 2:44 PM · Kirigami
GB_2 updated the diff for D23049: Add Kirigami ListSectionHeader component.

Improve look

Wed, Aug 21, 2:43 PM · Kirigami

Tue, Aug 20

GB_2 added a comment to D23117: kcmlookandfeel - Correctly set the Splash Screen to what the Look & Feel intends for it to be set to.

Ping.

Tue, Aug 20, 8:53 PM · Plasma
GB_2 abandoned D23286: Prevent dragging SimpleKCM contents outside view.
Tue, Aug 20, 7:52 PM · Frameworks
GB_2 added a comment to D23286: Prevent dragging SimpleKCM contents outside view.

This would disable it when using a touch swipe or a touchpad on the desktop too though, right? That doesn;t seem desirable. I think we on;y want scroll overshoot disabled when using a scroll wheel; for all other cases, IMO it should be on.

Tue, Aug 20, 5:48 PM · Frameworks
GB_2 added a comment to D23286: Prevent dragging SimpleKCM contents outside view.

+1, but maybe this doesn't go far enough. How about doing it for ScrollablePage instead? That would fix https://bugs.kde.org/show_bug.cgi?id=403837 as well as this.

Tue, Aug 20, 4:38 PM · Frameworks
GB_2 committed R858:ec1b5c60c19f: Prevent dragging QQC2 ComboBox contents outside menu (authored by GB_2).
Prevent dragging QQC2 ComboBox contents outside menu
Tue, Aug 20, 10:52 AM
GB_2 closed D23285: Prevent dragging QQC2 ComboBox contents outside menu.
Tue, Aug 20, 10:52 AM · Plasma
GB_2 updated the diff for D23286: Prevent dragging SimpleKCM contents outside view.

Only affect desktop

Tue, Aug 20, 9:29 AM · Frameworks
GB_2 updated the test plan for D23286: Prevent dragging SimpleKCM contents outside view.
Tue, Aug 20, 8:31 AM · Frameworks
GB_2 requested review of D23286: Prevent dragging SimpleKCM contents outside view.
Tue, Aug 20, 8:31 AM · Frameworks
GB_2 updated the test plan for D23285: Prevent dragging QQC2 ComboBox contents outside menu.
Tue, Aug 20, 8:30 AM · Plasma
GB_2 requested review of D23285: Prevent dragging QQC2 ComboBox contents outside menu.
Tue, Aug 20, 8:05 AM · Plasma
GB_2 added a watcher for Kirigami: GB_2.
Tue, Aug 20, 8:00 AM
GB_2 added a watcher for Breeze: GB_2.
Tue, Aug 20, 7:59 AM
GB_2 added a watcher for Junior Jobs: GB_2.
Tue, Aug 20, 7:59 AM
GB_2 added a watcher for Frameworks: GB_2.
Tue, Aug 20, 7:58 AM
GB_2 added a watcher for Bugsquad: GB_2.
Tue, Aug 20, 7:58 AM
GB_2 added a member for Bugsquad: GB_2.
Tue, Aug 20, 7:58 AM
GB_2 updated the task description for T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible.
Tue, Aug 20, 7:34 AM · Plasma, VDG

Mon, Aug 19

GB_2 added a comment to D21524: Keep existing configurations' strings               .

Ping.

Mon, Aug 19, 9:04 PM · Plasma
GB_2 updated subscribers of D23274: [WIP] Add "Show intro page" button to System Settings sidebar.

@mart can you help here?

Mon, Aug 19, 8:30 PM · Plasma
GB_2 requested review of D23274: [WIP] Add "Show intro page" button to System Settings sidebar.
Mon, Aug 19, 8:18 PM · Plasma
GB_2 closed D22896: Port System Settings sidebar to QQC2.
Mon, Aug 19, 6:15 PM · Plasma
GB_2 committed R124:b42479962795: Port System Settings sidebar to QQC2 (authored by GB_2).
Port System Settings sidebar to QQC2
Mon, Aug 19, 6:15 PM
GB_2 updated the diff for D22896: Port System Settings sidebar to QQC2.

Move setActionMenuVisible to the Private class

Mon, Aug 19, 5:06 PM · Plasma
GB_2 added a comment to D23242: Add grouping and "Show Only Minimized" options to icons-only task manager.
In D23242#514239, @hein wrote:

Code's fine, but let's discuss the change briefly - disabling grouping in ITM gets you a bunch of identical-looking icons you can't tell apart. I think that's a pretty ugly user experience, does it make sense to have an option to configure the applet into an invariably sort of unpleasant to use state? That's why I resisted it in the past.

Mon, Aug 19, 6:56 AM · Plasma

Sun, Aug 18

GB_2 updated the summary of D23242: Add grouping and "Show Only Minimized" options to icons-only task manager.
Sun, Aug 18, 6:57 PM · Plasma
GB_2 requested review of D23242: Add grouping and "Show Only Minimized" options to icons-only task manager.
Sun, Aug 18, 6:56 PM · Plasma
GB_2 added a comment to T10997: Improve check box design.

Yeah, let's go with 3 horizontal dots then.

Sun, Aug 18, 9:03 AM · VDG, Breeze
GB_2 updated the diff for D22896: Port System Settings sidebar to QQC2.

Add tooltip to menu button

Sun, Aug 18, 8:07 AM · Plasma

Sat, Aug 17

GB_2 added a comment to D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar.

I just tried it on Wayland and it looks like for some reason instead of a number it shows some kind of UUID.

Sat, Aug 17, 7:59 PM · Plasma
GB_2 added a project to D23174: Improve the look of the Activities KCM UI: KActivities.
Sat, Aug 17, 5:20 PM · KActivities, Plasma
GB_2 awarded D23112: Add a event Spy for GtkFileChooser recent files a Like token.
Sat, Aug 17, 11:41 AM · Plasma
GB_2 added a comment to D23049: Add Kirigami ListSectionHeader component.

@mart is this good now?

Sat, Aug 17, 9:27 AM · Kirigami
GB_2 added a comment to D19620: Use a searchbar similar to the one in okular.

See https://phabricator.kde.org/D19774#inline-110882

Sat, Aug 17, 8:50 AM · Frameworks

Fri, Aug 16

GB_2 updated the diff for D22896: Port System Settings sidebar to QQC2.

Address comments

Fri, Aug 16, 4:26 PM · Plasma
GB_2 added a comment to D12445: Add shortcut for application menu.

Ping.

Fri, Aug 16, 8:26 AM · KWin
GB_2 added a comment to D19620: Use a searchbar similar to the one in okular.

Don't use the unicode ellipsis. We use three dots everywhere.

Fri, Aug 16, 8:18 AM · Frameworks
GB_2 accepted D19471: Middle-elide file/folder labels so the extension is always visible.

Now we need the file dialog patch.

Fri, Aug 16, 8:15 AM · Dolphin
GB_2 updated the summary of D19471: Middle-elide file/folder labels so the extension is always visible.
Fri, Aug 16, 8:14 AM · Dolphin
GB_2 added a comment to D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.

Ping.

Fri, Aug 16, 8:08 AM · Plasma
GB_2 accepted D23158: [Kickoff] Improve appearance of draggable button grid in settings window.

Visually +1

Fri, Aug 16, 7:57 AM · Plasma

Thu, Aug 15

GB_2 updated the test plan for D22896: Port System Settings sidebar to QQC2.
Thu, Aug 15, 5:10 PM · Plasma
GB_2 updated the diff for D22896: Port System Settings sidebar to QQC2.

Use standard shortcut for "Configure System Settings..." action

Thu, Aug 15, 5:08 PM · Plasma
GB_2 updated the diff for D23174: Improve the look of the Activities KCM UI.

Fix "blocked" emblem icon

Thu, Aug 15, 4:08 PM · KActivities, Plasma
GB_2 updated the diff for D23174: Improve the look of the Activities KCM UI.

Address comments

Thu, Aug 15, 4:00 PM · KActivities, Plasma
GB_2 added a reviewer for D23174: Improve the look of the Activities KCM UI: ivan.
Thu, Aug 15, 2:29 PM · KActivities, Plasma
GB_2 updated the diff for D23174: Improve the look of the Activities KCM UI.

"Only for specific applications" -> "Only for specific applications:"

Thu, Aug 15, 2:20 PM · KActivities, Plasma
GB_2 updated the diff for D22896: Port System Settings sidebar to QQC2.

Bind checked property directly

Thu, Aug 15, 2:14 PM · Plasma
GB_2 updated the diff for D23174: Improve the look of the Activities KCM UI.

Remove unneeded import

Thu, Aug 15, 11:16 AM · KActivities, Plasma
GB_2 requested review of D23174: Improve the look of the Activities KCM UI.
Thu, Aug 15, 11:14 AM · KActivities, Plasma

Wed, Aug 14

GB_2 added a comment to D23161: Make media control icons outline style instead of solid style.


This would fix the unbalanced icon style in file operation notifications.

Wed, Aug 14, 8:49 PM · Frameworks
GB_2 added inline comments to D17598: Improve "No internet connection!" error message.
Wed, Aug 14, 1:29 PM · Plasma
GB_2 added a comment to D22885: Add global animation speed slider to workspace options KCM.

Why is it confusing? I find it more confusing if AnimationSpeed=0.5 means *faster* instead of "half the speed" as reading that line would suggest.
However, KWin seems to do it the same way round...

Wed, Aug 14, 1:15 PM · Plasma

Tue, Aug 13

GB_2 added a comment to D21815: [sddm-theme] Start moving from QQC1 to QQC2.

If keeping the new menu style we have to wait until all those patches get merged in Plasma.

Might be better to just follow current style; updating it to the new one would be a quick review.

Tue, Aug 13, 8:06 PM · Plasma
GB_2 added a comment to D23116: Fix missing digit and pixel-perfect alignment of depth action icons.

Maybe instead of hardcoding the blue and red colors you can use the stylesheet colors ButtonFocus and NegativeText: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets

Tue, Aug 13, 8:03 PM · Frameworks
GB_2 added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

Just throwing out another possible solution: the PlasmaComponents Highlight thingy:

Might be considered too obtrusive though.

EDIT: not a good idea "2.0 to be used only as the "highlight" property of the ListView and GridView primitive QML components (or their derivates)"

Tue, Aug 13, 7:53 PM · Plasma
GB_2 updated the summary of D14830: Add "Configure Displays" context menu entry on the desktop.
Tue, Aug 13, 3:24 PM · Plasma
GB_2 added inline comments to D14830: Add "Configure Displays" context menu entry on the desktop.
Tue, Aug 13, 3:17 PM · Plasma
GB_2 added inline comments to D14830: Add "Configure Displays" context menu entry on the desktop.
Tue, Aug 13, 3:16 PM · Plasma
GB_2 added a comment to D14830: Add "Configure Displays" context menu entry on the desktop.

I think we should definitely add this shortcut, because it is very useful for the people mentioned and for other situations. I agree that it should be on by default, then it's already there when you need it.

Tue, Aug 13, 3:14 PM · Plasma
GB_2 abandoned D23128: [plasma-workspace] Add desktop context menu entry for Displays KCM.
Tue, Aug 13, 3:04 PM · Plasma
GB_2 abandoned D23127: [plasma-desktop] Add desktop context menu entry for Displays KCM.

Oh, didn't know that existed, it wasn't mentioned anywhere in the bug report.

Tue, Aug 13, 3:04 PM · Plasma
GB_2 added a dependency for D23128: [plasma-workspace] Add desktop context menu entry for Displays KCM: D23127: [plasma-desktop] Add desktop context menu entry for Displays KCM.
Tue, Aug 13, 2:58 PM · Plasma
GB_2 added a dependent revision for D23127: [plasma-desktop] Add desktop context menu entry for Displays KCM: D23128: [plasma-workspace] Add desktop context menu entry for Displays KCM.
Tue, Aug 13, 2:58 PM · Plasma
GB_2 removed a dependency for D23127: [plasma-desktop] Add desktop context menu entry for Displays KCM: D23128: [plasma-workspace] Add desktop context menu entry for Displays KCM.
Tue, Aug 13, 2:58 PM · Plasma
GB_2 removed a dependent revision for D23128: [plasma-workspace] Add desktop context menu entry for Displays KCM: D23127: [plasma-desktop] Add desktop context menu entry for Displays KCM.
Tue, Aug 13, 2:58 PM · Plasma
GB_2 added a dependent revision for D23128: [plasma-workspace] Add desktop context menu entry for Displays KCM: D23127: [plasma-desktop] Add desktop context menu entry for Displays KCM.
Tue, Aug 13, 2:57 PM · Plasma
GB_2 added a dependency for D23127: [plasma-desktop] Add desktop context menu entry for Displays KCM: D23128: [plasma-workspace] Add desktop context menu entry for Displays KCM.
Tue, Aug 13, 2:57 PM · Plasma
GB_2 requested review of D23128: [plasma-workspace] Add desktop context menu entry for Displays KCM.
Tue, Aug 13, 2:57 PM · Plasma
GB_2 requested review of D23127: [plasma-desktop] Add desktop context menu entry for Displays KCM.
Tue, Aug 13, 2:57 PM · Plasma
GB_2 accepted D23080: [GTK3 -> Chrome/ium] Tweak tab stylings.
Tue, Aug 13, 2:27 PM · Plasma
GB_2 updated the test plan for D23049: Add Kirigami ListSectionHeader component.
Tue, Aug 13, 2:10 PM · Kirigami
GB_2 updated the diff for D23049: Add Kirigami ListSectionHeader component.

Improve example

Tue, Aug 13, 2:09 PM · Kirigami
GB_2 added a comment to D23049: Add Kirigami ListSectionHeader component.

Hmm, if software making use of this needs to manually add a label, that seems to defeat part of the point of using a standard component.

Tue, Aug 13, 1:47 PM · Kirigami
GB_2 updated the test plan for D23049: Add Kirigami ListSectionHeader component.
Tue, Aug 13, 10:32 AM · Kirigami
GB_2 updated the diff for D23049: Add Kirigami ListSectionHeader component.

Ditch the extra property

Tue, Aug 13, 10:31 AM · Kirigami

Mon, Aug 12

GB_2 added a reviewer for D23117: kcmlookandfeel - Correctly set the Splash Screen to what the Look & Feel intends for it to be set to: Plasma.
Mon, Aug 12, 9:58 PM · Plasma
GB_2 added a comment to D23075: Change default Dolphin toolbar layout.

So now we wait for @elvisangelaccio :-)

Mon, Aug 12, 7:45 PM · VDG, Dolphin
GB_2 updated the diff for D22896: Port System Settings sidebar to QQC2.

Address comments

Mon, Aug 12, 7:42 PM · Plasma
GB_2 retitled D22896: Port System Settings sidebar to QQC2 from Port System Settings sidebar to QQC2 and add "Show Most Used Page" button to Port System Settings sidebar to QQC2.
Mon, Aug 12, 3:34 PM · Plasma
GB_2 updated the summary of D22896: Port System Settings sidebar to QQC2.
Mon, Aug 12, 3:33 PM · Plasma
GB_2 updated the diff for D22896: Port System Settings sidebar to QQC2.

Use a QMenu

Mon, Aug 12, 3:31 PM · Plasma
GB_2 updated the summary of D23075: Change default Dolphin toolbar layout.
Mon, Aug 12, 1:07 PM · VDG, Dolphin
GB_2 accepted D23075: Change default Dolphin toolbar layout.
Mon, Aug 12, 1:02 PM · VDG, Dolphin
GB_2 updated the summary of D23075: Change default Dolphin toolbar layout.
Mon, Aug 12, 1:00 PM · VDG, Dolphin
GB_2 accepted D23057: Use new Kirigami ListSectionHeader component on Updates and Sources pages.
Mon, Aug 12, 12:01 PM · Plasma
GB_2 added a comment to D23075: Change default Dolphin toolbar layout.
In D23075#510697, @GB_2 wrote:


This is my final proposal with a category structure.

I could be persuaded to have the Split button on the left, but either way this looks good.

Mon, Aug 12, 11:35 AM · VDG, Dolphin
GB_2 added a comment to D23075: Change default Dolphin toolbar layout.


This is my final proposal with a category structure.

Mon, Aug 12, 9:31 AM · VDG, Dolphin
GB_2 added a comment to D23075: Change default Dolphin toolbar layout.

Mon, Aug 12, 8:09 AM · VDG, Dolphin
GB_2 added a comment to D23075: Change default Dolphin toolbar layout.
In D23075#510674, @GB_2 wrote:


Is this better?

I think the view mode buttons should be replaced by the single View Mode menu button. Unlabelled icons are a bad idea unless the symbol is very common and very distinct. I don't think it's reasonable to expect people to understand the compact mode and icon mode icons without looking at the tooltip.

I think the Sort By button should also be on the left.

If a Create New button is also added after more discussion, I think it should also be on the left.

Mon, Aug 12, 8:03 AM · VDG, Dolphin
GB_2 added a comment to D23075: Change default Dolphin toolbar layout.

Is this better?

Mon, Aug 12, 7:02 AM · VDG, Dolphin
GB_2 added a comment to D23075: Change default Dolphin toolbar layout.
Mon, Aug 12, 6:57 AM · VDG, Dolphin

Sun, Aug 11

GB_2 committed R119:6bf630cce15a: [Task Manager] Add icon to the grouping menu entry (authored by simonkr).
[Task Manager] Add icon to the grouping menu entry
Sun, Aug 11, 9:16 PM