GB_2 (Björn Feber)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2018, 6:27 PM (19 w, 1 d)
Availability
Available

Recent Activity

Today

GB_2 committed R242:bb643e99c3ca: Make Breeze theme tooltip texts consistent (authored by GB_2).
Make Breeze theme tooltip texts consistent
Fri, Feb 15, 6:53 PM
GB_2 committed R120:f6f08e97ce8d: Make Breeze theme tooltip texts consistent (authored by GB_2).
Make Breeze theme tooltip texts consistent
Fri, Feb 15, 6:48 PM
GB_2 committed R266:2dc5b2ab65d0: Make Breeze theme tooltip texts consistent (authored by GB_2).
Make Breeze theme tooltip texts consistent
Fri, Feb 15, 6:41 PM
GB_2 committed R31:1befbfed8bbe: Make Breeze theme tooltip texts consistent and rename Breeze Snow cursors to… (authored by GB_2).
Make Breeze theme tooltip texts consistent and rename Breeze Snow cursors to…
Fri, Feb 15, 6:35 PM
GB_2 closed D19046: Make Breeze theme tooltip texts consistent and rename Breeze Snow cursors to Breeze Light.
Fri, Feb 15, 6:35 PM · Plasma
GB_2 updated the diff for D19046: Make Breeze theme tooltip texts consistent and rename Breeze Snow cursors to Breeze Light.

Fix comment

Fri, Feb 15, 5:53 PM · Plasma
GB_2 added inline comments to D19046: Make Breeze theme tooltip texts consistent and rename Breeze Snow cursors to Breeze Light.
Fri, Feb 15, 5:51 PM · Plasma
GB_2 requested review of D19046: Make Breeze theme tooltip texts consistent and rename Breeze Snow cursors to Breeze Light.
Fri, Feb 15, 5:38 PM · Plasma
GB_2 committed R119:6eb8333334d7: Make Appearance KCM tooltip texts consistent (authored by GB_2).
Make Appearance KCM tooltip texts consistent
Fri, Feb 15, 5:33 PM
GB_2 closed D19038: Make Appearance KCM tooltip texts consistent.
Fri, Feb 15, 5:33 PM · Plasma
GB_2 requested review of D19038: Make Appearance KCM tooltip texts consistent.
Fri, Feb 15, 3:23 PM · Plasma

Yesterday

GB_2 accepted D19018: [kcmkwin/decorations] Use correct header text.
Thu, Feb 14, 5:45 PM · KWin
GB_2 committed R99:bceb50cb8ec3: Use better KDE GTK Config KCM desktop file comment (authored by GB_2).
Use better KDE GTK Config KCM desktop file comment
Thu, Feb 14, 4:56 PM
GB_2 closed D19009: Use better KDE GTK Config KCM desktop file comment.
Thu, Feb 14, 4:56 PM · Plasma
GB_2 closed D19006: Use KCM name in KCM header.
Thu, Feb 14, 4:55 PM · Plasma
GB_2 committed R124:b6ad57fc5fa2: Use KCM name in KCM header (authored by GB_2).
Use KCM name in KCM header
Thu, Feb 14, 4:55 PM
GB_2 requested review of D19009: Use better KDE GTK Config KCM desktop file comment.
Thu, Feb 14, 4:40 PM · Plasma
GB_2 requested review of D19006: Use KCM name in KCM header.
Thu, Feb 14, 4:19 PM · Plasma
GB_2 committed R119:0af980f5cab8: Move Look and Feel KCM to top level (authored by GB_2).
Move Look and Feel KCM to top level
Thu, Feb 14, 6:30 AM
GB_2 closed D18892: Move Look and Feel KCM to top level.
Thu, Feb 14, 6:30 AM · Plasma

Wed, Feb 13

GB_2 updated the task description for T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible.
Wed, Feb 13, 9:53 PM · VDG
D18892: Move Look and Feel KCM to top level is now accepted and ready to land.
Wed, Feb 13, 8:14 PM · Plasma
GB_2 added a comment to D18892: Move Look and Feel KCM to top level.

Ping?

Wed, Feb 13, 7:28 PM · Plasma
GB_2 accepted D18903: Make Appearance KCMs' labels consistent.
Wed, Feb 13, 7:26 PM · Plasma
GB_2 updated the summary of D18903: Make Appearance KCMs' labels consistent.
Wed, Feb 13, 7:25 PM · Plasma
GB_2 added a comment to D18903: Make Appearance KCMs' labels consistent.

Oops

Wed, Feb 13, 5:28 PM · Plasma
GB_2 requested changes to D18903: Make Appearance KCMs' labels consistent.
Wed, Feb 13, 5:28 PM · Plasma
GB_2 accepted D18903: Make Appearance KCMs' labels consistent.

For this patch (and moving forward) we still have 2 dilemmas left then:

  • remove the article -> "Configure system fonts" instead of "Configure the system fonts"?

My recommendation:

  • For the UI-related font KCM: "Choose user interface fonts" or something like that
  • For the font installer KCM, we could expose some more of its power via the tooltip and make the comment something more like "Install, manage, and organize system fonts"
  • capitalize Look and Feel? Or just do "Choose (the) look and feel theme"?

For the title, "Look And Feel" is good. For the tooltip, my recommendation is "Choose the Look and Feel theme".

Wed, Feb 13, 5:25 PM · Plasma

Tue, Feb 12

GB_2 added a comment to D18903: Make Appearance KCMs' labels consistent.

We currently use the KAboutData name in headers, we can easily change them to real titles and leave the desktop files how they are currently (explanation sentences). Should we just use the KCM name in the header or something more explaining like "Look and Feel Theme Selection"?

Tue, Feb 12, 4:19 PM · Plasma

Mon, Feb 11

GB_2 committed R119:190bea82b06f: Fix Font Management KCM search bar placeholder text (authored by GB_2).
Fix Font Management KCM search bar placeholder text
Mon, Feb 11, 4:40 PM

Sun, Feb 10

GB_2 accepted D18903: Make Appearance KCMs' labels consistent.

Perfect!

Sun, Feb 10, 5:15 PM · Plasma
GB_2 added a revision to T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible: D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.
Sun, Feb 10, 12:57 PM · VDG
GB_2 added a task to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule: T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible.
Sun, Feb 10, 12:57 PM · KWin
GB_2 updated the task description for T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible.
Sun, Feb 10, 12:57 PM · VDG
GB_2 updated the task description for T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible.
Sun, Feb 10, 7:15 AM · VDG
GB_2 requested review of D18892: Move Look and Feel KCM to top level.
Sun, Feb 10, 7:07 AM · Plasma
GB_2 committed R119:9dac09af4a02: Improve the look of the Fonts KCM UI (authored by GB_2).
Improve the look of the Fonts KCM UI
Sun, Feb 10, 6:44 AM
GB_2 closed D18861: Improve the look of the Fonts KCM UI.
Sun, Feb 10, 6:44 AM · Plasma

Sat, Feb 9

GB_2 added a revision to T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible: D18247: Improve Desktop/Plasma Theme KCM.
Sat, Feb 9, 5:15 PM · VDG
GB_2 added a task to D18247: Improve Desktop/Plasma Theme KCM: T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible.
Sat, Feb 9, 5:15 PM · Plasma
GB_2 added revisions to T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible: D18861: Improve the look of the Fonts KCM UI, D18269: Improve the Splash Screen KCM, D18267: Improve the Cursor Theme KCM, D12278: [Colors KCM] Port to new design.
Sat, Feb 9, 5:14 PM · VDG
GB_2 added a task to D18861: Improve the look of the Fonts KCM UI: T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible.
Sat, Feb 9, 5:14 PM · Plasma
GB_2 added a task to D18269: Improve the Splash Screen KCM: T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible.
Sat, Feb 9, 5:14 PM · Plasma
GB_2 added a task to D12278: [Colors KCM] Port to new design: T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible.
Sat, Feb 9, 5:14 PM · Plasma
GB_2 added a task to D18267: Improve the Cursor Theme KCM: T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible.
Sat, Feb 9, 5:14 PM · Plasma
GB_2 updated the summary of D18861: Improve the look of the Fonts KCM UI.
Sat, Feb 9, 5:07 PM · Plasma
GB_2 updated the diff for D18861: Improve the look of the Fonts KCM UI.

Show pt after font size and remove seperator in the font preview. Also apply the KDE HIG even more.

Sat, Feb 9, 5:06 PM · Plasma
GB_2 retitled D18861: Improve the look of the Fonts KCM UI from Improve the Fonts KCM UI to Improve the look of the Fonts KCM UI.
Sat, Feb 9, 2:28 PM · Plasma
GB_2 added a comment to D18861: Improve the look of the Fonts KCM UI.

Please use more descriptive messages than "Improve the blahblah".
Practically every single commit aims to improve the product.

Sat, Feb 9, 11:33 AM · Plasma

Fri, Feb 8

GB_2 added a comment to D18861: Improve the look of the Fonts KCM UI.

What about Noto Sans 10pt?

Fri, Feb 8, 10:41 PM · Plasma
GB_2 updated the summary of D18861: Improve the look of the Fonts KCM UI.
Fri, Feb 8, 7:35 PM · Plasma
GB_2 updated the diff for D18861: Improve the look of the Fonts KCM UI.

Change "Force fonts DPI" checkbox text to "Force font DPI"

Fri, Feb 8, 7:29 PM · Plasma
GB_2 requested review of D18861: Improve the look of the Fonts KCM UI.
Fri, Feb 8, 7:22 PM · Plasma
GB_2 committed R266:b5c94b245d1a: Remove monochrome font preferences icon (authored by GB_2).
Remove monochrome font preferences icon
Fri, Feb 8, 5:02 PM
GB_2 closed D18702: Remove monochrome font preferences icon.
Fri, Feb 8, 5:02 PM · Frameworks
GB_2 committed R266:11e51771626b: Improve font selection icon (authored by GB_2).
Improve font selection icon
Fri, Feb 8, 4:37 PM
GB_2 closed D18855: Improve font selection icon.
Fri, Feb 8, 4:37 PM · Frameworks
GB_2 requested review of D18855: Improve font selection icon.
Fri, Feb 8, 4:30 PM · Frameworks
GB_2 updated the summary of D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it.
Fri, Feb 8, 12:47 PM · Plasma
GB_2 retitled D18702: Remove monochrome font preferences icon from Remove monochrome font preferences icon and improve font selection icon to Remove monochrome font preferences icon.
Fri, Feb 8, 11:34 AM · Frameworks
GB_2 updated the test plan for D18702: Remove monochrome font preferences icon.
Fri, Feb 8, 11:34 AM · Frameworks
GB_2 updated the diff for D18702: Remove monochrome font preferences icon.

Revert font selection icon change

Fri, Feb 8, 11:33 AM · Frameworks
GB_2 committed R119:e5ef9c97e75e: Use different Font Management KCM "All Fonts" icon (authored by GB_2).
Use different Font Management KCM "All Fonts" icon
Fri, Feb 8, 11:08 AM
GB_2 closed D18785: Use different Font Management KCM "All Fonts" icon.
Fri, Feb 8, 11:08 AM · Plasma

Thu, Feb 7

GB_2 added a comment to D18702: Remove monochrome font preferences icon.

Can you improve the font selection icon in a separate patch please?

Thu, Feb 7, 5:44 PM · Frameworks
GB_2 updated the diff for D18785: Use different Font Management KCM "All Fonts" icon.

Use new icon "font"

Thu, Feb 7, 5:36 PM · Plasma
GB_2 accepted D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg.

Great!

Thu, Feb 7, 3:26 PM · Frameworks
GB_2 added a comment to D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter.

So if this isn't an acceptable solution, then what we need to do is remove all the 22px monochrome versions of icons that have colorful 32px-and-larger versions.

Thu, Feb 7, 3:01 PM · Plasma
GB_2 added a comment to D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg.

@rooty just copy a different 16px font icon like format-font-size-more and remove the other things than the A and align it in the horizontal center.

Thu, Feb 7, 12:14 PM · Frameworks

Wed, Feb 6

GB_2 added a dependent revision for D18785: Use different Font Management KCM "All Fonts" icon: D18702: Remove monochrome font preferences icon.
Wed, Feb 6, 5:28 PM · Plasma
GB_2 added a dependency for D18702: Remove monochrome font preferences icon: D18785: Use different Font Management KCM "All Fonts" icon.
Wed, Feb 6, 5:28 PM · Frameworks
GB_2 updated the task description for T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible.
Wed, Feb 6, 4:37 PM · VDG
GB_2 updated the task description for T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible.
Wed, Feb 6, 4:31 PM · VDG
Pixel_Lime awarded T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible a Like token.
Wed, Feb 6, 3:37 PM · VDG
GB_2 removed a dependency for D18785: Use different Font Management KCM "All Fonts" icon: D18702: Remove monochrome font preferences icon.
Wed, Feb 6, 1:18 PM · Plasma
GB_2 removed a dependent revision for D18702: Remove monochrome font preferences icon: D18785: Use different Font Management KCM "All Fonts" icon.
Wed, Feb 6, 1:18 PM · Frameworks
GB_2 added a dependent revision for D18702: Remove monochrome font preferences icon: D18785: Use different Font Management KCM "All Fonts" icon.
Wed, Feb 6, 12:46 PM · Frameworks
GB_2 added a dependency for D18785: Use different Font Management KCM "All Fonts" icon: D18702: Remove monochrome font preferences icon.
Wed, Feb 6, 12:46 PM · Plasma
GB_2 requested review of D18785: Use different Font Management KCM "All Fonts" icon.
Wed, Feb 6, 12:45 PM · Plasma

Tue, Feb 5

GB_2 accepted D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons.

Very nice!

Tue, Feb 5, 8:24 PM · Frameworks
GB_2 added a comment to D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons.

Or we could just use frikkin' light buttons. :)

Tue, Feb 5, 6:39 PM · Frameworks
GB_2 added a comment to D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons.

Well, I really don't like that this is the only thing that has dark buttons. It is inconsistent and just looks out of place. We should probably do some more discussion elsewhere if we want do this in other places too.

Tue, Feb 5, 6:34 PM · Frameworks
GB_2 added a comment to T10413: Specify how to use and classify monochrome vs color icons.

If we would do it like described in the task description then application developers would need to figure it out too if they wanted to prevent it too.

Tue, Feb 5, 5:28 PM · Plasma, VDG, Breeze
GB_2 added a comment to D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons.

One thing I will not do in this patch is synthesize a fake button that has different behaviors from the standard button. If there's a problem with our buttons we need to fix it everywhere, not work around it here (and elsewhere).

Here are our two options:

Maybe we should just take a vote.

Tue, Feb 5, 2:45 PM · Frameworks

Mon, Feb 4

GB_2 added a comment to D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons.
In D18649#405209, @GB_2 wrote:

Here's how the buttons look when placed fully inline and with the color scheme inverted:

I have to admit, it ain't half bad.

I still think it looks better if it follows the color scheme.

Why do you think that? Context?

Mon, Feb 4, 8:15 PM · Frameworks
GB_2 added a comment to D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons.

Here's how the buttons look when placed fully inline and with the color scheme inverted:

I have to admit, it ain't half bad.

Mon, Feb 4, 8:11 PM · Frameworks
GB_2 added a comment to D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons.

I think it looks good.

Mon, Feb 4, 7:34 PM · Frameworks
GB_2 added a comment to D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons.

Nah, it's actually fine:

Mon, Feb 4, 7:26 PM · Frameworks
GB_2 added a comment to D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons.

Now that I think about it though, the buttons overlap the label of the label text is long...

Mon, Feb 4, 7:23 PM · Frameworks
GB_2 added a comment to D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons.

Like this? Or fully contained within the thumbnail?

Mon, Feb 4, 7:21 PM · Frameworks
GB_2 added a comment to D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons.

Not sure I catch your meaning, sorry. How big should the square buttons be? I kinda like them at that size TBH. Gwenview also has inline square hover buttons like this and it's fine.

Mon, Feb 4, 7:15 PM · Frameworks
GB_2 added a comment to D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons.
In D18649#405091, @GB_2 wrote:

What if the buttons just looked normal and not so big and not as circles?

With regular-sized square buttons:

Mon, Feb 4, 6:43 PM · Frameworks
GB_2 added a comment to D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons.

What if the buttons just looked normal and not so big and not as circles?

Mon, Feb 4, 6:17 PM · Frameworks
GB_2 added a comment to D18702: Remove monochrome font preferences icon.

Is this icon used by any other KDE software or 3rd party applications?

Yes, quite a few: https://lxr.kde.org/search?_filestring=&_string=preferences-desktop-font

Those apps won't experience any breakage, but they will suddenly display the scaled-down color version.

Mon, Feb 4, 6:33 AM · Frameworks
GB_2 added a comment to T10413: Specify how to use and classify monochrome vs color icons.

I'm still for doing it like GNOME, I think it's the easiest and best solution:

  • Provide -symbolic icons only for application/category icons that must have a monochrome version (will just be a few)
  • Normal application/category icons are always colorful, even at small sizes
  • Action/status icons are always monochrome
  • If an app wants to use a monochrome icon it should either use an action/status icon or a -symbolic application/category icon
Mon, Feb 4, 4:04 AM · Plasma, VDG, Breeze
GB_2 added a comment to T10413: Specify how to use and classify monochrome vs color icons.
In T10413#175176, @GB_2 wrote:

BTW, most applications use colorful icons as their app icons anyways, so it would be inconsistent that some have monochrome icons and almost all not.

Then perhaps we need a way to make sure that a color icon is used in some places. Maybe find icon from scalable directory (defined in index.theme), then shrink to fit. I don't know how to make that happen or if it's feasible. It would eliminate our problem and allow us to avoid doing anything drastic. I should update the main task, because I realize that the whole symbolic thing was designed for a theme that normally has a color version of everything. We would also have to make a color version of everything. That's why I no longer think the -symbolic thing would work for Breeze.

Mon, Feb 4, 3:53 AM · Plasma, VDG, Breeze
GB_2 added a comment to T10413: Specify how to use and classify monochrome vs color icons.
In T10413#175171, @GB_2 wrote:

We're trying to avoid this:


I know, but I don't want to only move the problem over to 3rd party applications. We'll have to find another way to fix that.The simplest way to fix these might be to fix the issues in the software that uses the icons. That means not using 22px or 16px at all if you want color icons. For titlebars, we would need a way to apply titlebar text color from colorschemes to the icons via embedded style sheets. We already do that, but only for regular text color, not titlebar text color.

In T10413#175172, @GB_2 wrote:

What if we make -symbolic versions of category and application icons that are monochrome and the normal application and category icons are always corful. The action icons, status icons, etc are always monochrome.

But what do we do when a 3rd party application doesn't ask for a -symbolic version of a standard icon, but still requires a smaller version of the icon than the color version and needs a monochrome version to look consistent (back to the Inkscape screenshot)?

Mon, Feb 4, 2:31 AM · Plasma, VDG, Breeze

Sun, Feb 3

GB_2 added a comment to T10413: Specify how to use and classify monochrome vs color icons.

What if we make -symbolic versions of category and application icons that are monochrome and the normal application and category icons are always corful. The action icons, status icons, etc are always monochrome.

Sun, Feb 3, 11:42 PM · Plasma, VDG, Breeze
GB_2 added a comment to T10413: Specify how to use and classify monochrome vs color icons.

It seems like it might be simpler to choose monochrome or color based on size rather than category and usage. If we want to avoid using monochrome icons in a specific instance, we'll just have to avoid using icons at a monochrome size.

Sun, Feb 3, 11:35 PM · Plasma, VDG, Breeze
GB_2 added a comment to T10413: Specify how to use and classify monochrome vs color icons.
In T10413#175165, @GB_2 wrote:
In T10413#175163, @GB_2 wrote:

If you use a colorful only icon at a small size then fine, but if you don't want it then you'll have to use an action icon or other monochrome icons.

I'm talking about issues like this:

I'm afraid we won't be able to 100% ensure that everything looks right. The apps will need to be changed if they inappropriately use a colorful icon or a wrong size.

While is isn't our responsibility to include icons for every app in the universe, it is still our responsibility to make sure standard icons look right whenever they are used. BTW, this app is Inkscape 1.0.

Sun, Feb 3, 9:04 PM · Plasma, VDG, Breeze