GB_2 (Björn Feber)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2018, 6:27 PM (29 w, 3 h)
Availability
Available

Recent Activity

Today

GB_2 accepted D20827: Reword some text, a couple clean ups, add a separator.
Thu, Apr 25, 7:22 PM · VDG, Frameworks
GB_2 added a project to D20827: Reword some text, a couple clean ups, add a separator: VDG.
Thu, Apr 25, 7:21 PM · VDG, Frameworks
GB_2 added a comment to D17936: Rewrite the front-end of docs.kde.org.

And also make it blue like the other search button.

Thu, Apr 25, 7:08 PM · VDG, Documentation
GB_2 accepted D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI.

Perfect.

Thu, Apr 25, 7:05 PM · Plasma
GB_2 added a comment to D19812: Add a web page to view and compare icons of different sizes.

I personally think this could be quite useful.

Thu, Apr 25, 7:04 PM · Frameworks
GB_2 added a comment to D17936: Rewrite the front-end of docs.kde.org.

Just one tip, I'd replace the "Search" button with a search icon, since it looks better and the search placeholder already says "Search...".

Thu, Apr 25, 6:58 PM · VDG, Documentation
GB_2 added a comment to D19829: kicker: add option to make root level icons visible.

Can you please update this patch? It doesn't apply anymore. It would also be nice if you used Arcanist/arc in the future: https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches

Thu, Apr 25, 6:46 PM · Plasma
GB_2 added a dependent revision for D20818: Add the Show Desktop applet (moved from kdeplasma-addons): D20820: Add Show Desktop applet to default panel.
Thu, Apr 25, 3:00 PM · Plasma
GB_2 added a dependency for D20820: Add Show Desktop applet to default panel: D20818: Add the Show Desktop applet (moved from kdeplasma-addons).
Thu, Apr 25, 3:00 PM · Plasma
GB_2 removed a dependency for D20818: Add the Show Desktop applet (moved from kdeplasma-addons): D20820: Add Show Desktop applet to default panel.
Thu, Apr 25, 3:00 PM · Plasma
GB_2 removed a dependent revision for D20820: Add Show Desktop applet to default panel: D20818: Add the Show Desktop applet (moved from kdeplasma-addons).
Thu, Apr 25, 3:00 PM · Plasma
GB_2 added a dependency for D20818: Add the Show Desktop applet (moved from kdeplasma-addons): D20820: Add Show Desktop applet to default panel.
Thu, Apr 25, 2:59 PM · Plasma
GB_2 added a dependent revision for D20820: Add Show Desktop applet to default panel: D20818: Add the Show Desktop applet (moved from kdeplasma-addons).
Thu, Apr 25, 2:59 PM · Plasma
GB_2 requested review of D20820: Add Show Desktop applet to default panel.
Thu, Apr 25, 2:58 PM · Plasma
GB_2 added a dependency for D20817: Remove the Show Desktop applet (it's in plasma-desktop now): D20818: Add the Show Desktop applet (moved from kdeplasma-addons).
Thu, Apr 25, 2:48 PM · Plasma
GB_2 added a dependent revision for D20818: Add the Show Desktop applet (moved from kdeplasma-addons): D20817: Remove the Show Desktop applet (it's in plasma-desktop now).
Thu, Apr 25, 2:48 PM · Plasma
GB_2 requested review of D20818: Add the Show Desktop applet (moved from kdeplasma-addons).
Thu, Apr 25, 2:48 PM · Plasma
GB_2 requested review of D20817: Remove the Show Desktop applet (it's in plasma-desktop now).
Thu, Apr 25, 2:48 PM · Plasma

Yesterday

GB_2 updated the task description for T10827: Website redesign.
Wed, Apr 24, 10:53 PM · Websites
GB_2 added a comment to D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI.

Looks good UI-wise.

Wed, Apr 24, 10:24 PM · Plasma
GB_2 accepted D20747: [FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout and improve UI.
Wed, Apr 24, 8:42 PM · Plasma
GB_2 closed D20791: Rename "edit-remove" icon to "edit-delete-remove" to support Oxygen and other icon themes.
Wed, Apr 24, 4:38 PM · Frameworks
GB_2 committed R266:2cbbfe2351a6: Rename "edit-remove" icon to "edit-delete-remove" to support Oxygen and other… (authored by GB_2).
Rename "edit-remove" icon to "edit-delete-remove" to support Oxygen and other…
Wed, Apr 24, 4:38 PM
GB_2 added a comment to D18419: Adjust some KCMs to implement new Appearance section layout.

Should we really wait until those are merged and not have the new layout in Plasma 5.16? Merging these will take quite some time and I don't see how it would make a difference layout-wise.

Wed, Apr 24, 4:30 PM · Plasma
GB_2 added a comment to D19011: Thunderbolt KCM and KDED module.

Ping

Wed, Apr 24, 4:27 PM · Plasma
GB_2 requested review of D20791: Rename "edit-remove" icon to "edit-delete-remove" to support Oxygen and other icon themes.
Wed, Apr 24, 4:05 PM · Frameworks
GB_2 renamed T10384: Unify styles for lists and their buttons from Unify styles for Add & Remove buttons on lists to Unify styles for lists and their buttons.
Wed, Apr 24, 3:50 PM · Kirigami, KDE Human Interface Guidelines, VDG

Tue, Apr 23

GB_2 added inline comments to D20747: [FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout and improve UI.
Tue, Apr 23, 8:09 PM · Plasma
GB_2 added a comment to D20576: Add new notifications KCM.

You can now use edit-remove, which got added in D20700.

Tue, Apr 23, 8:01 PM · Plasma
GB_2 closed D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".
Tue, Apr 23, 7:50 PM · Frameworks
GB_2 committed R266:7c6559bdb86f: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit… (authored by GB_2).
Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit…
Tue, Apr 23, 7:50 PM
GB_2 updated the diff for D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".

Fix one 16px path point

Tue, Apr 23, 4:38 PM · Frameworks
GB_2 retitled D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none" from Add "edit-remove" icon symlink and add 22px version of "paint-none" to Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".
Tue, Apr 23, 4:31 PM · Frameworks
GB_2 updated the diff for D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".

(Hopefully) fix icons and add 22px version of edit-none

Tue, Apr 23, 4:30 PM · Frameworks

Mon, Apr 22

GB_2 accepted D20743: [Kicker] Modernize settings window.

Looks good

Mon, Apr 22, 6:42 PM · Plasma
GB_2 updated the diff for D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".

Fix icons

Mon, Apr 22, 2:22 PM · Frameworks
GB_2 updated the summary of D20730: Change default window actions modifier key to Meta.
Mon, Apr 22, 11:05 AM · KWin
GB_2 abandoned D20730: Change default window actions modifier key to Meta.
Mon, Apr 22, 11:04 AM · KWin
GB_2 added a comment to D20730: Change default window actions modifier key to Meta.

You can't break the behaviour for every KDE user.

Existing users come first.

Mon, Apr 22, 10:43 AM · KWin
GB_2 requested review of D20730: Change default window actions modifier key to Meta.
Mon, Apr 22, 10:37 AM · KWin
GB_2 retitled D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none" from Add "edit-remove" icon symlink to Add "edit-remove" icon symlink and add 22px version of "paint-none".
Mon, Apr 22, 8:51 AM · Frameworks
GB_2 updated the diff for D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".

Add 22px version of paint-none and add symlink for it

Mon, Apr 22, 8:51 AM · Frameworks

Sun, Apr 21

GB_2 committed R266:1c6e30d312c7: Use consistent default Kickoff user icon (authored by GB_2).
Use consistent default Kickoff user icon
Sun, Apr 21, 7:28 PM
GB_2 closed D20536: Use consistent default Kickoff user icon.
Sun, Apr 21, 7:28 PM · Frameworks
GB_2 updated the diff for D20536: Use consistent default Kickoff user icon.

Fix diff

Sun, Apr 21, 7:26 PM · Frameworks
GB_2 closed D20564: Rename colorful user gallery avatar.
Sun, Apr 21, 7:21 PM · Plasma
GB_2 committed R128:774c4c628d72: Rename colorful user gallery avatar (authored by GB_2).
Rename colorful user gallery avatar
Sun, Apr 21, 7:21 PM
GB_2 added a comment to D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".

We have a problem where we don't use consistent iconography for "remove". Sometimes it's a normal minus, sometimes it's a red minus, sometimes it's a red X and sometimes it's a red trash can (the line between "delete" and "remove" can be blurry). I think adding an edit-remove icon would likely cause more confusion, first for developers and then for users. I don't think using a minus without a plus is a problem, but perhaps the minus should be made red?

Sun, Apr 21, 5:30 PM · Frameworks
GB_2 abandoned D20709: [kcmkwin/kwindecoration] Use correct defaults and reset button icons in window decorations configuration window.
Sun, Apr 21, 3:47 PM · KWin
GB_2 updated the task description for T10047: Guerilla UX testing: a GNOME switcher.
Sun, Apr 21, 2:41 PM · VDG, Plasma
GB_2 requested review of D20709: [kcmkwin/kwindecoration] Use correct defaults and reset button icons in window decorations configuration window.
Sun, Apr 21, 1:22 PM · KWin
GB_2 added a comment to D18419: Adjust some KCMs to implement new Appearance section layout.

Ping

Sun, Apr 21, 12:35 PM · Plasma
GB_2 added a comment to D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".

Why does list-remove need an alternative?

Sun, Apr 21, 12:35 PM · Frameworks
GB_2 added a comment to D20564: Rename colorful user gallery avatar.

Ping

For future, the commit message is important.

The person reviewing doesn't have the same context you have when you're making the change, if you can save the reviewer having to dig around user-manager to understand what we're doing it makes everything easier. You won't have me asking potentially stupid questions :D

So from what I can tell:

  • UserManager by default uses an icon from breeze `QIcon::fromTheme(QStringLiteral("user-identity"))`

    It completely ignores anything from the gallery we ship with user-manager /o\
  • The "User.png" gallery icon matches the large version of the "user-identity" icon in the breeze theme

    The part I don't understand, how does renaming this file change anything?
Sun, Apr 21, 11:13 AM · Plasma
GB_2 retitled D20564: Rename colorful user gallery avatar from Rename default user gallery avatar to Rename colorful user gallery avatar.
Sun, Apr 21, 11:05 AM · Plasma
GB_2 updated the summary of D20564: Rename colorful user gallery avatar.
Sun, Apr 21, 11:03 AM · Plasma
GB_2 updated the summary of D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".
Sun, Apr 21, 10:59 AM · Frameworks
GB_2 retitled D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none" from Add "edit-remove" icon to Add "edit-remove" icon symlink.
Sun, Apr 21, 10:56 AM · Frameworks
GB_2 updated the diff for D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".

Use symlinks: edit-remove -> paint-none

Sun, Apr 21, 10:56 AM · Frameworks

Sat, Apr 20

GB_2 added a comment to D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".

Oops, forgot that paint-none already exists, which looks like this. I will just make a symlink then.

Sat, Apr 20, 9:37 PM · Frameworks
GB_2 added a comment to D20576: Add new notifications KCM.

Here you go: https://phabricator.kde.org/D20700

Sat, Apr 20, 6:40 PM · Plasma
GB_2 updated the summary of D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".
Sat, Apr 20, 6:40 PM · Frameworks
GB_2 requested review of D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".
Sat, Apr 20, 6:39 PM · Frameworks
GB_2 added a comment to D20564: Rename colorful user gallery avatar.

Ping

Sat, Apr 20, 7:14 AM · Plasma

Thu, Apr 18

GB_2 committed R596:f9015ff1bad2: Don't set Breeze as icon theme (authored by GB_2).
Don't set Breeze as icon theme
Thu, Apr 18, 3:41 PM
GB_2 closed D20650: Don't set Breeze as icon theme.
Thu, Apr 18, 3:40 PM
GB_2 added a comment to D20650: Don't set Breeze as icon theme.

Does this app always have to run as root? If so, that would be why that code is in there. If not, then yeah, it's superfluous now.

Thu, Apr 18, 3:28 PM
GB_2 added reviewers for D20564: Rename colorful user gallery avatar: afiestas, broulik.
Thu, Apr 18, 8:31 AM · Plasma
GB_2 requested review of D20650: Don't set Breeze as icon theme.
Thu, Apr 18, 8:19 AM

Wed, Apr 17

GB_2 updated the task description for T10047: Guerilla UX testing: a GNOME switcher.
Wed, Apr 17, 7:30 PM · VDG, Plasma
GB_2 added a comment to D20612: [Kickoff] Modernize settings window layout.

Use onPressed And Layout.preferredHeight (still doesn't fix the button height though)

Wed, Apr 17, 6:21 PM · Plasma
GB_2 retitled D20638: [Widget Explorer] Continue using a trash can icon for deleting delegates from [WIdget Explorer] Continue using a trash can icon for deleting delegates to [Widget Explorer] Continue using a trash can icon for deleting delegates.
Wed, Apr 17, 5:20 PM · Plasma
GB_2 accepted D20638: [Widget Explorer] Continue using a trash can icon for deleting delegates.
Wed, Apr 17, 5:19 PM · Plasma
GB_2 added a comment to D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI.

@broulik Do you want to commandeer this revision and do the rest?

Wed, Apr 17, 4:26 PM · Plasma
GB_2 updated the diff for D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI.

Address some comments

Wed, Apr 17, 4:25 PM · Plasma
GB_2 added inline comments to D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI.
Wed, Apr 17, 3:44 PM · Plasma
GB_2 committed R119:c308122688ee: Add alternatives button to applet configuration in panel edit mode (authored by GB_2).
Add alternatives button to applet configuration in panel edit mode
Wed, Apr 17, 1:58 PM
GB_2 closed D17410: Add alternatives button to applet configuration in panel edit mode.
Wed, Apr 17, 1:58 PM · VDG, Plasma
GB_2 updated the diff for D17410: Add alternatives button to applet configuration in panel edit mode.

Move currentApplet.applet.prepareContextualActions(); to onVisualParentChanged

Wed, Apr 17, 1:56 PM · VDG, Plasma
GB_2 added a comment to D20576: Add new notifications KCM.

Yeah, I was thinking of the Breeze icon theme one, which IMO looks better:

I agree that they should match each other. I think @ndavis is working on that in D20623, as a matter of fact!

Wed, Apr 17, 1:46 PM · Plasma
GB_2 added a comment to T10384: Unify styles for lists and their buttons.

BTW, we should also unify the styles for the lists itself. The list headers and items currently don't all look consistent.

Wed, Apr 17, 1:24 PM · Kirigami, KDE Human Interface Guidelines, VDG
GB_2 added a comment to D17410: Add alternatives button to applet configuration in panel edit mode.

Ping

Wed, Apr 17, 1:21 PM · VDG, Plasma
GB_2 added a comment to D20576: Add new notifications KCM.

Hmm, it seems like the Plasma theme list-remove is different from the normal Breeze icon theme list-remove. I think we should have the icon from the Plasma theme in the Breeze icon theme too, but with a different name, so we don't overwrite the existing one.

Wed, Apr 17, 1:20 PM · Plasma

Mon, Apr 15

GB_2 added a member for Plasma: KCM Redesign: GB_2.
Mon, Apr 15, 8:46 PM
GB_2 claimed T3040: update KCM usability.
Mon, Apr 15, 8:44 PM · VDG, Plasma, Breeze
GB_2 added a comment to D20283: [RFC] [SimpleKCM] Fix height calculation.

Ping

Mon, Apr 15, 7:35 PM · Frameworks
GB_2 accepted D19077: Redesign the theme preview window.

Now it's great.

Mon, Apr 15, 5:20 PM · Plasma
GB_2 updated the diff for D19077: Redesign the theme preview window.

Fix "No Preview" icon

Mon, Apr 15, 5:20 PM · Plasma
GB_2 updated the summary of D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI.
Mon, Apr 15, 5:01 PM · Plasma
GB_2 updated the diff for D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI.

Fix initial selection bug and add load indication

Mon, Apr 15, 4:56 PM · Plasma
GB_2 renamed T10799: Update outdated artwork, branding, logos, colors and screenshots from Update outdated artwork, branding, logos and screenshots to Update outdated artwork, branding, logos, colors and screenshots.
Mon, Apr 15, 10:53 AM · Websites: general, KDE Promo
GB_2 created T10799: Update outdated artwork, branding, logos, colors and screenshots.
Mon, Apr 15, 10:52 AM · Websites: general, KDE Promo
GB_2 added a comment to D19770: Use placeholder for search action.

Ping @elvisangelaccio

Mon, Apr 15, 7:38 AM · Documentation, Dolphin
GB_2 added a comment to D19011: Thunderbolt KCM and KDED module.

Looks ok to me.

Mon, Apr 15, 7:37 AM · Plasma
GB_2 added a comment to D15423: System settings: make date/time format preview consistent.

Ping

Mon, Apr 15, 7:35 AM · Plasma
GB_2 added a comment to D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight.

Ping

Mon, Apr 15, 5:45 AM · Frameworks
GB_2 updated the diff for D19077: Redesign the theme preview window.

Try to fix diff

Mon, Apr 15, 5:18 AM · Plasma
GB_2 accepted D19077: Redesign the theme preview window.
Mon, Apr 15, 4:44 AM · Plasma
GB_2 added a comment to D19077: Redesign the theme preview window.
In D19077#442323, @mart wrote:

@mart could you help us out a bit please? I used code with "Kirigami.Theme.viewBackgroundColor.r", which throws out a warning that the value is deprecated. The one suggested for replacement (Theme.View) isn't the same as the deprecated one though. How bad would it be to leave the code with the deprecated value?

that rectangle should havethe attached property:
Rectangle {

Kirigami.Theme.inherit: false
Kirigami.Theme.colorSet: Kirigami.Theme.View

}

then, anywhere under this item you access Kirigami.Theme.backgroundColor and will be the background color of the view, because you defined it to use the color set for views.

Mon, Apr 15, 4:40 AM · Plasma
GB_2 updated the diff for D19077: Redesign the theme preview window.

Prevent deprecation warning

Mon, Apr 15, 4:39 AM · Plasma