Fix bugzilla login page widgets tab order
Needs ReviewPublic

Authored by marcelomariano on Mar 18 2019, 2:28 PM.


Group Reviewers

BUG: 398275

Diff Detail

R871 DrKonqi
Lint Skipped
Unit Tests Skipped
marcelomariano created this revision.Mar 18 2019, 2:28 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 18 2019, 2:28 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
marcelomariano requested review of this revision.Mar 18 2019, 2:28 PM

While that fixes the drkonqi bug just fine I am not sure that is the best fix for the problem. As I understand it KPasswordLineEdit doesn't set itself to StrongFocus, seeing as it is a replacement for QLineEdit that seems inconsistent and should be rectified though. IOW: I think KPasswordLineEdit should be changed to set a StrongFocus by default, same as QLineEdit.

cfeck added a comment.Mar 18 2019, 9:38 PM

QLineEdit has Qt::StrongFocus policy and it is the focus proxy of KPasswordLineEdit. My impression was that KPasswordLineEdit then automatically also had Qt::StrongFocus.

Appearantly, the policy is propagated in the other direction, so a correct fix would be to change the focus policy in kwidgetsaddons, see

Testing would need to confirm that this doesn't open password dialogs with the password line focussed by default.

This comment was removed by marcelomariano.

That is true.
I will consider taking a look at KPasswordLineEdit implementation.
Thanks a lot!