apol (Aleix Pol Gonzalez)
User

Projects (14)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 27 2015, 12:34 PM (225 w, 3 d)
Availability
Available

Recent Activity

Today

apol updated the diff for D22969: Make it possible to modify vcards.

Make it possible to create new contacts

Thu, Aug 22, 3:40 PM
apol updated the diff for D22968: Make it possible to modify contacts.

Make it possible to create new contacts

Thu, Aug 22, 3:39 PM · Frameworks
apol committed R32:12bf83b0abd0: Indicate appsteam the ps desktop file isn't a separate application (authored by apol).
Indicate appsteam the ps desktop file isn't a separate application
Thu, Aug 22, 3:05 PM
apol closed D23321: Indicate appsteam the ps desktop file isn't a separate application.

Landed as https://invent.kde.org/kde/kdevelop/commit/12bf83b0abd064f22c0a137b0ec7123f155c3097

Thu, Aug 22, 3:01 PM · KDevelop
apol committed R134:27550f8a6d7f: Show progress for PackageKit update fetching (authored by apol).
Show progress for PackageKit update fetching
Thu, Aug 22, 2:22 PM
apol closed D23324: Show progress for PackageKit update fetching.
Thu, Aug 22, 2:22 PM · Plasma
apol added inline comments to D22514: Show if KRunner is still searching for more things.
Thu, Aug 22, 2:18 PM · Plasma
apol updated the diff for D23324: Show progress for PackageKit update fetching.

Center in the updates page

Thu, Aug 22, 10:57 AM · Plasma
apol updated the diff for D22514: Show if KRunner is still searching for more things.

positioning

Thu, Aug 22, 1:26 AM · Plasma
apol added inline comments to D22513: Expose if we're still searching for more results.
Thu, Aug 22, 1:24 AM · Plasma
apol updated the diff for D22514: Show if KRunner is still searching for more things.

Use the new querying property

Thu, Aug 22, 1:23 AM · Plasma
apol added a comment to D23323: Add support for handling QNAM SSL errors to KSslErrorUiData.

Makes sense, but I feel some explanation is missing ^^'

Thu, Aug 22, 12:40 AM · Frameworks
apol committed R308:ae5a477b9d41: Make sure we're checking whether tearing down is due after finishing a job (authored by apol).
Make sure we're checking whether tearing down is due after finishing a job
Thu, Aug 22, 12:39 AM
apol abandoned D22723: Fix RunnerManager::queryFinished().

https://commits.kde.org/krunner/ae5a477b9d41e33137c4c8447e3fbe6e4b72cf32

Thu, Aug 22, 12:38 AM · Frameworks
apol committed R323:f39578b63d47: plotter2d: remove duplicated code with the views (authored by apol).
plotter2d: remove duplicated code with the views
Thu, Aug 22, 12:09 AM

Yesterday

apol committed R323:b0a4a090d1fd: Fix warning (authored by apol).
Fix warning
Wed, Aug 21, 11:42 PM
apol committed R323:0e5f941cde22: fix setting populated models to plot views (authored by apol).
fix setting populated models to plot views
Wed, Aug 21, 11:41 PM
apol committed R323:b740eec5e09c: graph2dmobile: add a notify field in the property (authored by apol).
graph2dmobile: add a notify field in the property
Wed, Aug 21, 11:41 PM
apol updated the diff for D23324: Show progress for PackageKit update fetching.

Lose the BusyIndicator

Wed, Aug 21, 5:32 PM · Plasma
apol requested review of D23324: Show progress for PackageKit update fetching.
Wed, Aug 21, 5:28 PM · Plasma
apol added a comment to D23321: Indicate appsteam the ps desktop file isn't a separate application.
In D23321#516020, @apol wrote:

Don't mention the ps desktop file as the executable

It was mentioned on purpose though, cmp. commit message of ab22ca659cf337fc1de01d69b0ced949156f01e5 (result of discussion on KDevelop with @flherne )

Wed, Aug 21, 3:25 PM · KDevelop
apol updated the diff for D23321: Indicate appsteam the ps desktop file isn't a separate application.

BUG: 410687

Wed, Aug 21, 3:23 PM · KDevelop
apol updated the diff for D23321: Indicate appsteam the ps desktop file isn't a separate application.

Don't mention the ps desktop file as the executable

Wed, Aug 21, 3:09 PM · KDevelop
apol requested review of D23321: Indicate appsteam the ps desktop file isn't a separate application.
Wed, Aug 21, 3:01 PM · KDevelop
apol accepted D23306: Add AppStream metadata file.
Wed, Aug 21, 2:57 PM · Plasma
apol accepted D23320: Tell AppStream generators not to index Klipper .desktop files.
Wed, Aug 21, 2:57 PM · Plasma
apol added inline comments to D22723: Fix RunnerManager::queryFinished().
Wed, Aug 21, 1:52 PM · Frameworks
apol committed R302:ee1d424f1cb9: Properly turn real into integer (authored by apol).
Properly turn real into integer
Wed, Aug 21, 1:42 PM
apol closed D23047: Properly turn real into integer.
Wed, Aug 21, 1:42 PM · Frameworks
apol accepted D23315: Port runnertest to QGuiApplication.
Wed, Aug 21, 12:46 PM · Frameworks
apol accepted D23305: Add plugin showing nvidia GPU load stats.

LGTM

Wed, Aug 21, 11:19 AM · Plasma

Tue, Aug 20

apol added a comment to D23305: Add plugin showing nvidia GPU load stats.

Otherwise LGTM

Tue, Aug 20, 10:31 PM · Plasma
apol accepted D23301: [Cuttlefish] Use only a single AppStream ID.
Tue, Aug 20, 6:37 PM · Plasma
apol added a comment to D23298: Unify busy spinner appearance on update page.

As is, it looks unfinished to me. I prefer to give some kind of hint of what's happening, especially since this could take a while, yesterday I opened one laptop after a month (neon git unstable) or so and it took easily a minute to show anything there.
In fact, we could look into showing progress here, which is what I wanted looking at the thing spin to no end.

Tue, Aug 20, 6:27 PM · Plasma
apol added a comment to D23298: Unify busy spinner appearance on update page.

We don't want any text?

Tue, Aug 20, 5:38 PM · Plasma
apol committed R134:fc40759e4df3: Fix qml warnings, remove old code (authored by apol).
Fix qml warnings, remove old code
Tue, Aug 20, 4:31 PM
apol committed R134:bb1af171c0b8: Fix qml warnings, remove old code (authored by apol).
Fix qml warnings, remove old code
Tue, Aug 20, 4:27 PM
apol added inline comments to D23288: Move XResources out of the central model into a plugin.
Tue, Aug 20, 3:46 PM · Plasma
apol added a comment to D23292: Make update page labels consistent with topUpdateComp.

Thanks. The problem with the knsbackendtest is most likely unrelated. You can ignore it here.

Tue, Aug 20, 3:43 PM · Plasma
apol committed R257:f61b2372f4e7: Merge branch 'frameworks-5.61.0' into 'qt5.12lts' (authored by apol).
Merge branch 'frameworks-5.61.0' into 'qt5.12lts'
Tue, Aug 20, 3:41 PM
apol committed R857:0a7b984761ef: android: use proper bash syntax to compare strings (authored by apol).
android: use proper bash syntax to compare strings
Tue, Aug 20, 2:37 PM
apol committed R857:226d00dce8e9: android: also don't install libintl.h with gstreamer (authored by apol).
android: also don't install libintl.h with gstreamer
Tue, Aug 20, 2:37 PM
apol committed R857:9b5ae35f07c1: android: remove confusing ssl script (authored by apol).
android: remove confusing ssl script
Tue, Aug 20, 2:36 PM
apol accepted D23149: Only build tests when DBus is available.
Tue, Aug 20, 11:21 AM · Frameworks
apol committed R857:e713bffcf0f0: android: fix gstreamer on binary-factory (authored by apol).
android: fix gstreamer on binary-factory
Tue, Aug 20, 11:17 AM
apol added a comment to D22946: Include API to generically implement --replace arguments.

ping

Tue, Aug 20, 10:58 AM · Frameworks
apol added a comment to D23047: Properly turn real into integer.

ping

Tue, Aug 20, 10:58 AM · Frameworks
apol accepted D23285: Prevent dragging QQC2 ComboBox contents outside menu.
Tue, Aug 20, 10:19 AM · Plasma
apol accepted D23284: Add keyboard control for ProceedDialog buttons.

Thanks!

Tue, Aug 20, 10:16 AM · Plasma
apol committed R857:4cbbeca417e9: android: Don't let gstreamer overwrite our libintl.a (authored by apol).
android: Don't let gstreamer overwrite our libintl.a
Tue, Aug 20, 2:46 AM
apol committed R857:3791056d9365: android: properly replace weird paths on gstreamer build (authored by apol).
android: properly replace weird paths on gstreamer build
Tue, Aug 20, 2:46 AM

Mon, Aug 19

apol accepted D23250: Only display old and new versions when both are available.
Mon, Aug 19, 10:29 PM · Plasma
apol committed R857:9f58cead9702: android: update docker images to ubuntu:18.04 (authored by apol).
android: update docker images to ubuntu:18.04
Mon, Aug 19, 10:19 PM
apol committed R993:ced729b56289: android: don't hardcode arch names on kirogi recipe (authored by apol).
android: don't hardcode arch names on kirogi recipe
Mon, Aug 19, 5:58 PM
apol accepted D23269: Fix creating archives on Android content: URLs.

Makes sense

Mon, Aug 19, 5:07 PM · Frameworks
apol added a comment to D23266: Export Plasma core lib log category, add a category to a qWarning.

How about porting it to use ecm_qt_declare_logging_category?

Mon, Aug 19, 5:01 PM · Frameworks
apol accepted D23262: disable autouic again - it breaks builds.

Thanks!

Mon, Aug 19, 2:29 PM · Build System, Frameworks
apol committed R857:5818ee62ac45: android: improve gstreamer extraction (authored by apol).
android: improve gstreamer extraction
Mon, Aug 19, 2:26 PM
apol accepted D22805: set autorcc and autouic by default.

LGTM

Mon, Aug 19, 12:35 PM · Build System, Frameworks
apol committed R256:2ef55ab7b6c8: kirogi: include gstqtsink (authored by apol).
kirogi: include gstqtsink
Mon, Aug 19, 12:09 PM
apol added a comment to D23250: Only display old and new versions when both are available.

Doesn't the visible addition solve it already? We can keep the i18n() call, it will fail in this case but since it's not visible it isn't a big problem anyway.

Mon, Aug 19, 9:46 AM · Plasma

Sun, Aug 18

apol added a comment to D23237: Do not display vendor, Product and capacity in network plasmoid.

LGTM but the title looks wrong, this isn't the network plasmoid.

Sun, Aug 18, 10:52 PM · Plasma
apol added a comment to D23241: Show application window icon on AboutPage.

+1 LGTM, please address the @since bit

Sun, Aug 18, 10:51 PM · Kirigami
apol accepted D23188: Fix supported OS attributes for api.kde.org.
Sun, Aug 18, 10:48 PM · Kirigami
apol added a comment to D23224: Fix capitalization of Nextcloud.

Do you have commit rights or you need us to land it for you?

Sun, Aug 18, 12:34 AM · Frameworks
apol accepted D23224: Fix capitalization of Nextcloud.
Sun, Aug 18, 12:34 AM · Frameworks
apol accepted D23218: Fix compile warning.
Sun, Aug 18, 12:32 AM · Plasma
apol added inline comments to D23188: Fix supported OS attributes for api.kde.org.
Sun, Aug 18, 12:30 AM · Kirigami
apol added a comment to D23205: [KProcessList] Optimize KProcessList::processInfo.

patch looks good overall.

Sun, Aug 18, 12:27 AM · Frameworks
apol accepted D23185: [libtaskmanager] Port to lighter KProcessList.

LGTM

Sun, Aug 18, 12:18 AM · Plasma
apol added a comment to D23172: Do not crash immediately when deleting SoftBody attached to a stick.

Sometimes saves? ^^'

Sun, Aug 18, 12:13 AM · KDE Edu

Wed, Aug 14

apol accepted D23163: Remove double check for DBus.

it was just in case.. ;)

Wed, Aug 14, 11:50 PM · Frameworks
apol accepted D23160: Use contextually-appropriate icon for GlobalDrawer handle button.
Wed, Aug 14, 11:21 PM
apol added inline comments to D23159: Prevent error() being emitted when purposefully reading 0 bytes.
Wed, Aug 14, 11:20 PM · Frameworks
apol accepted D23058: Reduce visual strength of version numbers on Updates page.
Wed, Aug 14, 11:16 PM · Plasma
apol accepted D23155: Show busy indicator while loading apps list.
Wed, Aug 14, 11:15 PM · Plasma
apol added inline comments to D23151: Implement Web Share API through Purpose.
Wed, Aug 14, 11:10 PM · Plasma
apol added a comment to D23145: [Exe Thumbnailer] Match 16 bit executables and don't request icon types wrestool cannot handle.

There's several unrealated changes I'd discourage but the patch looks good overall. +1

Wed, Aug 14, 11:00 PM · Frameworks, Dolphin
apol accepted D23131: Define install location for JAR/AAR files for Android.

Thanks!

Wed, Aug 14, 10:54 PM · Build System, Frameworks
apol added a comment to D23119: Fix dates being on the wrong locale when setting an application language individually.

LGTM +1

Wed, Aug 14, 10:49 PM · Frameworks
apol added a comment to D23114: [perf] Introduce ftrace marker.

It would be really cool to have a blog post on how to use this once it's in. 👍

Wed, Aug 14, 10:42 PM · KWin

Mon, Aug 12

apol accepted D23057: Use new Kirigami ListSectionHeader component on Updates and Sources pages.
Mon, Aug 12, 11:34 AM · Plasma
apol accepted D23040: Add extension point for Qt wayland decorations.
Mon, Aug 12, 11:32 AM
apol accepted D23020: Use QQuickWidget instead of a QQuickView placed into QWidget.
Mon, Aug 12, 11:27 AM · Plasma
apol added a comment to D22978: Toggle filtering of remote branches in DVCS Branch Manager.

Maybe it would make sense to move the whole dialog into git plugin's code.

Mon, Aug 12, 11:24 AM · KDevelop

Fri, Aug 9

apol requested review of D23047: Properly turn real into integer.
Fri, Aug 9, 2:42 PM · Frameworks
apol committed R256:a19071c51b35: ark: Specify ID (authored by apol).
ark: Specify ID
Fri, Aug 9, 1:16 AM
apol committed R256:e5aaab466808: add kirogi (authored by apol).
add kirogi
Fri, Aug 9, 1:08 AM
apol committed R256:9f98d8519072: update frameworks (authored by apol).
update frameworks
Fri, Aug 9, 1:05 AM
apol committed R993:81687a765afd: android: add kirogi (authored by apol).
android: add kirogi
Fri, Aug 9, 1:05 AM
apol committed R857:a104b9514399: android: properly identify application-frameworks as application products (authored by apol).
android: properly identify application-frameworks as application products
Fri, Aug 9, 12:06 AM

Thu, Aug 8

apol accepted D23031: more control on what shell is loaded.

I like it much better

Thu, Aug 8, 2:17 PM · Plasma
apol added a comment to D23023: more control on what shell is loaded.

This will always have this environment variable set up, which could become a bit weird if we end up supporting changing shells, because we'd have a value in the environment variable but the shell in another.
How about passing it through a file?

Thu, Aug 8, 10:19 AM · Plasma
apol committed R857:af13883a066e: android: Make sure we use the same version for arm 32 and 64 bits (authored by apol).
android: Make sure we use the same version for arm 32 and 64 bits
Thu, Aug 8, 2:35 AM
apol committed R857:bc9b477ae8ff: android: a special ecm branch isn't necessary anymore (authored by apol).
android: a special ecm branch isn't necessary anymore
Thu, Aug 8, 2:29 AM
apol committed R857:f31a260dd2ba: android: clean build directories for arm 32-bits (authored by apol).
android: clean build directories for arm 32-bits
Thu, Aug 8, 2:29 AM
apol committed R857:e0a1c11ae728: android: also log when cleaning (authored by apol).
android: also log when cleaning
Thu, Aug 8, 2:29 AM
apol committed R857:af8b1e816222: android: stop disabling kcalcore (authored by apol).
android: stop disabling kcalcore
Thu, Aug 8, 2:29 AM

Tue, Aug 6

apol committed R857:25e39dff5071: android: Include cp-with-prefix to the docker images (authored by apol).
android: Include cp-with-prefix to the docker images
Tue, Aug 6, 11:35 PM
apol committed R857:ef9f6394d486: android: provide a prefix for the generated apks (authored by apol).
android: provide a prefix for the generated apks
Tue, Aug 6, 11:33 PM