apol (Aleix Pol Gonzalez)
User

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 27 2015, 12:34 PM (142 w, 6 d)
Availability
Available

Recent Activity

Today

apol accepted D10002: Improve header and screenshots.
Sun, Jan 21, 2:11 PM · Plasma

Yesterday

apol accepted D9595: Don't export kded5 as a CMake target.
Sat, Jan 20, 12:26 PM · Frameworks
apol accepted D9990: Fix compilation of just the UI-less host tools.
Sat, Jan 20, 12:26 PM · Frameworks
apol accepted D9974: Improve header and metadata display.
Sat, Jan 20, 2:01 AM · Plasma

Fri, Jan 19

apol added a comment to T7771: Growing Plasma Mobile: Collect data.

Also any application that now is targetting Android should be there too: kstars, minuet, kalgebra, KDE Connect...

Fri, Jan 19, 9:37 PM · Plasma: Mobile, KDE Promo
apol requested changes to D9974: Improve header and metadata display.
Fri, Jan 19, 7:54 PM · Plasma
apol added a comment to D9974: Improve header and metadata display.

I like it, some nitpicking:

Fri, Jan 19, 7:54 PM · Plasma
apol committed R474:04aebd3df9ce: David doesn't like the banana (authored by apol).
David doesn't like the banana
Fri, Jan 19, 7:00 PM
apol committed R474:ae336a8f7169: Specify action text, now it will be visible from kirigami (authored by apol).
Specify action text, now it will be visible from kirigami
Fri, Jan 19, 7:00 PM
apol committed R474:f44428de05a8: Set a camera upon discovery if none was selected (authored by apol).
Set a camera upon discovery if none was selected
Fri, Jan 19, 7:00 PM
apol updated the diff for D9965: Provide a tooltip for the main action.

No tooltip on mobile

Fri, Jan 19, 6:46 PM · Kirigami
apol updated the diff for D9965: Provide a tooltip for the main action.

Make it work for the other actions as well

Fri, Jan 19, 6:41 PM · Kirigami
apol committed R134:9cbe6c4800ff: Slows down start, just uncomment if needed (authored by apol).
Slows down start, just uncomment if needed
Fri, Jan 19, 5:01 PM
apol committed R134:714d918e1384: Force the invalidation of the currentItem (authored by apol).
Force the invalidation of the currentItem
Fri, Jan 19, 5:01 PM
apol added inline comments to D9965: Provide a tooltip for the main action.
Fri, Jan 19, 12:39 AM · Kirigami

Thu, Jan 18

apol added a comment to D9965: Provide a tooltip for the main action.

With tooltip

Thu, Jan 18, 4:29 PM · Kirigami
apol committed R134:fc0334278a47: Rework keyboard focus strategy (authored by apol).
Rework keyboard focus strategy
Thu, Jan 18, 3:39 PM
apol committed R134:7ec48a5b9af7: Only request focus for the screenshots when it's shown (authored by apol).
Only request focus for the screenshots when it's shown
Thu, Jan 18, 3:39 PM
apol committed R134:15295b5e607b: Show a tooltip with the keyboard short on hover (authored by apol).
Show a tooltip with the keyboard short on hover
Thu, Jan 18, 3:39 PM
apol added a comment to D9960: Query os-release for distro name.

Then leave it as is.

Thu, Jan 18, 1:50 PM · Plasma
apol accepted D9960: Query os-release for distro name.

Please Plasma/5.12

Thu, Jan 18, 12:20 PM · Plasma
apol added a comment to D9960: Query os-release for distro name.

Works for me.
Maybe use PRETTY_NAME? It's supposed to be prettier and it's used to display after all.

Thu, Jan 18, 12:19 PM · Plasma
apol committed R134:7a4f1c1c1983: Merge branch 'Plasma/5.12' (authored by apol).
Merge branch 'Plasma/5.12'
Thu, Jan 18, 12:12 PM
apol committed R134:dc87d64ec2d3: Properly detect the right pkqt version for offline updates (authored by apol).
Properly detect the right pkqt version for offline updates
Thu, Jan 18, 12:12 PM
apol accepted D9950: [KUser] Check whether .face.icon is actually readable before returning it.
Thu, Jan 18, 3:29 AM · Frameworks
apol added a comment to D9951: [KUserProxy] Adjust to accounts service.

LGTM

Thu, Jan 18, 3:27 AM · Frameworks, Plasma
apol committed R474:5f6efc957c64: Don't point at a destroyed pointer (authored by apol).
Don't point at a destroyed pointer
Thu, Jan 18, 12:19 AM

Wed, Jan 17

apol added a comment to T7680: Promo Sprint: Sign up.

Please open a reimbursement in reimbursements.kde.org if you want me to manage the hotel reservation for you. If you don't want sponsoring just request 0€. :P

Wed, Jan 17, 4:03 PM · KDE Promo
apol committed R134:3d37d257a40a: Only notify about updates when there's actually more updates (authored by apol).
Only notify about updates when there's actually more updates
Wed, Jan 17, 2:18 PM
apol added a comment to T7629: Clean up bugtracker.

Do I need special permissions in Bugzilla for that?

Wed, Jan 17, 11:48 AM · KDE Connect
apol closed T7629: Clean up bugtracker as Resolved.

Looks good, now we can focus on the real bugs.

Hurray!

Wed, Jan 17, 12:18 AM · KDE Connect
apol added a comment to T7629: Clean up bugtracker.

Went through the bug reports, closed a bunch. I'll let you consider if you want to leave this task up for now. 😛

Wed, Jan 17, 12:06 AM · KDE Connect

Tue, Jan 16

apol updated the summary of D7993: WIP: System volume plugin Android.
Tue, Jan 16, 10:21 PM · KDE Connect
apol added a comment to D9691: Add contacts-reading plugin.

The DBus API seems too convoluted, I suggest using vcard for now, which will be understood by every PIM suite in existance.

Tue, Jan 16, 8:21 PM
apol updated the summary of D9691: Add contacts-reading plugin.
Tue, Jan 16, 8:19 PM
apol accepted D9882: Add flatpak build manifest.
Tue, Jan 16, 8:08 PM · Krita, Flatpak
apol accepted D9919: Fix and improve CMake test finding and running.

LGTM, thanks!

Tue, Jan 16, 7:44 PM
apol committed R224:895a9206ffaf: Was getting a double-delete, now it won't crash (authored by apol).
Was getting a double-delete, now it won't crash
Tue, Jan 16, 7:36 PM
apol accepted D9882: Add flatpak build manifest.

I'll do the change of krita if nobody beats me to it.

Tue, Jan 16, 7:19 PM · Krita, Flatpak
apol committed R225:5c3fcb14236e: Prevent Android 8.1 crash (authored by philipc).
Prevent Android 8.1 crash
Tue, Jan 16, 7:12 PM
apol closed D9739: Prevent Android 8.1 crash.
Tue, Jan 16, 7:12 PM
apol committed R134:2b6507f27c54: Fix removing cancelled transactions (authored by apol).
Fix removing cancelled transactions
Tue, Jan 16, 4:56 PM
apol committed R134:8ee02d0d1e45: Remove sync call to snap to get icons (authored by apol).
Remove sync call to snap to get icons
Tue, Jan 16, 4:20 PM
apol committed R134:c510c7c79e5b: Always show the downloadSize (authored by apol).
Always show the downloadSize
Tue, Jan 16, 3:59 PM
apol committed R134:a3a835e7090c: Revert "Use the right API to fetch 1 package" (authored by apol).
Revert "Use the right API to fetch 1 package"
Tue, Jan 16, 3:59 PM
apol added a reverting commit for R134:8520cc4054ca: Use the right API to fetch 1 package: R134:a3a835e7090c: Revert "Use the right API to fetch 1 package".
Tue, Jan 16, 3:59 PM
apol committed R134:ecffc981a64a: Store the new Snap tuple when refreshing after installing (authored by apol).
Store the new Snap tuple when refreshing after installing
Tue, Jan 16, 3:59 PM
apol committed R134:0717dcec5b3e: Have DiscoverPage refresh if F5 is pressed (authored by apol).
Have DiscoverPage refresh if F5 is pressed
Tue, Jan 16, 3:59 PM
apol committed R134:6330ac30dd04: Expose method (authored by apol).
Expose method
Tue, Jan 16, 3:59 PM
apol committed R134:b0cdc22942b0: Make it possible to pull to refresh application lists (authored by apol).
Make it possible to pull to refresh application lists
Tue, Jan 16, 3:59 PM
apol committed R134:d5356147fea8: Polish the ApplicationDelegate (authored by apol).
Polish the ApplicationDelegate
Tue, Jan 16, 3:59 PM
apol committed R256:e99802e1db53: Update KF5 version (authored by apol).
Update KF5 version
Tue, Jan 16, 2:30 PM
apol committed R257:219053324af0: Update KF5 to the new release (authored by apol).
Update KF5 to the new release
Tue, Jan 16, 2:29 PM
apol committed R257:53f9f8499845: Inherit new useful extension points (authored by alexanderlarsson).
Inherit new useful extension points
Tue, Jan 16, 2:27 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Tue, Jan 16, 2:27 PM
apol committed R257:85beac85cb2c: Use the new freedesktop-post.sh script (authored by alexanderlarsson).
Use the new freedesktop-post.sh script
Tue, Jan 16, 2:26 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Tue, Jan 16, 2:26 PM
apol accepted D9920: KF5NewStuff is only used in moleculeview, conditional on Eigen3 and AvogadroLibs.
Tue, Jan 16, 2:06 PM · KDE Edu
apol accepted D9921: Link against KF5::Purpose if it's available.
Tue, Jan 16, 1:46 PM
apol added a comment to D9892: cmake: Use the official CMake variable for building as a static plugin..
In D9892#191707, @mart wrote:
In D9892#191590, @apol wrote:

I wonder if it would make sense to always ship the qml files as qrc in the plugin. Have you considered it?

may make sense...
i would save it for another poatch tough this is big enough already :)

Tue, Jan 16, 9:58 AM · Kirigami
apol accepted D9899: Android: Add more includes.

Never seen this issue, but I'm happy to have it in. If it has regressions we can revert it.

Tue, Jan 16, 12:39 AM · Build System, Frameworks
apol added a comment to D9892: cmake: Use the official CMake variable for building as a static plugin..

I did consider it and went ahead in ring-kde and put every QML in QRC even in non static builds. I think it makes sense, but makes debugging a bit harder and I didn't want to change too much things to fix the static plugin. Shipping assets in QRC doesn't seem to be common outside of some KDE projects that take cross platform more seriously.

Tue, Jan 16, 12:35 AM · Kirigami
apol added a comment to D9892: cmake: Use the official CMake variable for building as a static plugin..

I wonder if it would make sense to always ship the qml files as qrc in the plugin. Have you considered it?

Tue, Jan 16, 12:19 AM · Kirigami

Mon, Jan 15

apol committed R134:c947d6f9571b: snap: Set the downloading status to the transaction (authored by apol).
snap: Set the downloading status to the transaction
Mon, Jan 15, 6:33 PM
apol committed R134:832a9a8f33a9: Hardcode the state the snap is going to get (authored by apol).
Hardcode the state the snap is going to get
Mon, Jan 15, 6:33 PM
apol committed R134:e324fd7f079f: First weird logic upon initialization of resources' state (authored by apol).
First weird logic upon initialization of resources' state
Mon, Jan 15, 6:33 PM
apol committed R134:1d845be14c95: Finish streams when the stream ends with an error (authored by apol).
Finish streams when the stream ends with an error
Mon, Jan 15, 6:13 PM
apol committed R134:fa4f70e9de95: Flatpak: Notify about removed resources before deleting them (authored by apol).
Flatpak: Notify about removed resources before deleting them
Mon, Jan 15, 6:13 PM
apol committed R134:fe9895aa6cac: Use upper_bound instead of find_if (authored by apol).
Use upper_bound instead of find_if
Mon, Jan 15, 6:13 PM
apol committed R134:fee58bff985d: Fix test (authored by apol).
Fix test
Mon, Jan 15, 6:13 PM
apol committed R134:d76d9c212d34: Don't add the same resource twice in the resources proxy model (authored by apol).
Don't add the same resource twice in the resources proxy model
Mon, Jan 15, 6:13 PM
apol committed R134:db01c0d4fb5b: Expose the handbook, it's already there, better show it (authored by apol).
Expose the handbook, it's already there, better show it
Mon, Jan 15, 6:13 PM
apol committed R134:c2decd101667: Remove unreachable code (authored by apol).
Remove unreachable code
Mon, Jan 15, 6:13 PM
apol committed R134:c09cf89bb75c: Remove unused code and dependencies (authored by apol).
Remove unused code and dependencies
Mon, Jan 15, 6:13 PM
apol committed R134:762f55a71042: Source models are simpler now (authored by apol).
Source models are simpler now
Mon, Jan 15, 6:12 PM
apol added inline comments to D9894: [UDisks Device] Show loop device with their backing file name and icon.
Mon, Jan 15, 6:02 PM · Frameworks
apol accepted D9891: [Style KCM] Sync KConfig before announcing change.
Mon, Jan 15, 4:39 PM · Plasma
apol added inline comments to D9882: Add flatpak build manifest.
Mon, Jan 15, 2:01 PM · Krita, Flatpak
apol committed R883:1508739: Change duped link id.
Change duped link id
Mon, Jan 15, 12:02 PM
apol added inline comments to D9882: Add flatpak build manifest.
Mon, Jan 15, 3:06 AM · Krita, Flatpak
apol committed R495:3075c50e4209: Add missing files (authored by apol).
Add missing files
Mon, Jan 15, 2:58 AM
apol committed R495:9ee5a188421b: Make it possible to search the framework as KF5Purpose (authored by apol).
Make it possible to search the framework as KF5Purpose
Mon, Jan 15, 2:55 AM
apol committed R883:1508714: Add bitpay link as a donation method.
Add bitpay link as a donation method
Mon, Jan 15, 2:50 AM
apol created T7754: Don't return an empty icon if there's no decoration.
Mon, Jan 15, 2:30 AM · KDE Store
apol committed R134:79ff30795bd3: Use ordering according to https://github.com/ximion/appstream/issues/164 (authored by apol).
Use ordering according to https://github.com/ximion/appstream/issues/164
Mon, Jan 15, 2:18 AM
apol committed R134:3193c6f19b96: Report progress on snaps (authored by apol).
Report progress on snaps
Mon, Jan 15, 2:18 AM
apol committed R134:6279f62d6da6: Give some url to snaps until they have an appsteam id (authored by apol).
Give some url to snaps until they have an appsteam id
Mon, Jan 15, 2:06 AM
apol committed R134:61f520f9cf1d: Extract the version number from the AppStream information (authored by apol).
Extract the version number from the AppStream information
Mon, Jan 15, 1:57 AM
apol committed R134:718483ce5b18: typo (authored by apol).
typo
Mon, Jan 15, 1:42 AM
apol committed R134:da8e125a0ede: Report errors in snap backend (authored by apol).
Report errors in snap backend
Mon, Jan 15, 1:41 AM
apol committed R134:8520cc4054ca: Use the right API to fetch 1 package (authored by apol).
Use the right API to fetch 1 package
Mon, Jan 15, 1:41 AM
apol committed R474:63b4f37a6802: Remove packaging file (authored by apol).
Remove packaging file
Mon, Jan 15, 1:31 AM
apol committed R134:15c1240f2cfc: Add a button on the notification to open the updates (authored by apol).
Add a button on the notification to open the updates
Mon, Jan 15, 1:25 AM
apol added a comment to D9881: Replace deprecated QSignalMapper by lambda expressions.

All in all, LGTM. +1

Mon, Jan 15, 1:06 AM
apol accepted D9868: Rename Discover's "Home" page to "Featured".
Mon, Jan 15, 1:00 AM · Plasma

Sun, Jan 14

apol added a comment to D9868: Rename Discover's "Home" page to "Featured".

Okay, makes sense. Can you leave it at just "Featured"?

Sun, Jan 14, 8:24 PM · Plasma
apol accepted D9874: Fix executable name in README.
Sun, Jan 14, 8:22 PM · Plasma
apol accepted D9850: Remove redundant changeLog field.

On ArchLinux the changelog field is empty/unused.

Sun, Jan 14, 8:22 PM · Plasma
apol added a reviewer for D9871: Add partial busy-widget support: andreask.
Sun, Jan 14, 8:14 PM · Frameworks
apol requested changes to D9871: Add partial busy-widget support.

Please remove the changes in the *.sh files.

Sun, Jan 14, 8:13 PM · Frameworks