apol (Aleix Pol Gonzalez)
User

Projects (14)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 27 2015, 12:34 PM (189 w, 6 d)
Availability
Available

Recent Activity

Today

apol added inline comments to D17616: [SMS App] Improve "No devices available" warning.
Mon, Dec 17, 2:32 AM · KDE Connect
apol accepted D17614: [SMS App] Improve filter.
Mon, Dec 17, 2:29 AM · KDE Connect
apol added a comment to D17612: [SMS App] Add highlighting to ConversationList view.

instead use:
highlighted: ListView.isCurrentIndex

Mon, Dec 17, 2:25 AM · KDE Connect
apol committed R241:16c98669aa7c: Fix build warning (authored by apol).
Fix build warning
Mon, Dec 17, 1:34 AM
apol updated the diff for D17550: Make the open url in tab feature a bit more discoverable.

Remove unrelated change

Mon, Dec 17, 1:33 AM · Frameworks
apol updated the diff for D17550: Make the open url in tab feature a bit more discoverable.

add space

Mon, Dec 17, 1:32 AM · Frameworks
apol added inline comments to D17550: Make the open url in tab feature a bit more discoverable.
Mon, Dec 17, 1:32 AM · Frameworks

Sat, Dec 15

apol committed R134:db37fb5d1a82: sources: Tell the source delegate to not have mouse events (authored by apol).
sources: Tell the source delegate to not have mouse events
Sat, Dec 15, 1:31 PM
apol added a comment to D17598: Improve "No internet connection!" error message.

I wonder if "app" is the right term. How about "could not load the featured applications"?

Sat, Dec 15, 12:37 PM · Plasma
apol committed R134:2b061966daa0: kns: Don't delete categories when the backend is marked as invalid (authored by apol).
kns: Don't delete categories when the backend is marked as invalid
Sat, Dec 15, 2:13 AM
apol requested review of D17594: Notify about the provider not being loaded.
Sat, Dec 15, 2:06 AM · Frameworks
apol requested review of D17593: Notify if a default provider failed to download.
Sat, Dec 15, 2:05 AM · Frameworks
apol committed R134:4eddf4d824f3: Initialize category actions with the subcategories already inside (authored by apol).
Initialize category actions with the subcategories already inside
Sat, Dec 15, 1:27 AM
apol committed R134:84137f97fe91: Include a cancel button on the application page (authored by apol).
Include a cancel button on the application page
Sat, Dec 15, 1:05 AM
apol committed R134:e3b49c448279: Fix opening flatpakref of already-existing repositories (authored by apol).
Fix opening flatpakref of already-existing repositories
Sat, Dec 15, 12:46 AM
apol committed R134:6ea64d5e7808: Drop virtual AbstractResourcesBackend::resourceForFile (authored by apol).
Drop virtual AbstractResourcesBackend::resourceForFile
Sat, Dec 15, 12:46 AM
apol committed R134:d23440ffca96: Move the filter feature into a delegate action instead of the main action (authored by apol).
Move the filter feature into a delegate action instead of the main action
Sat, Dec 15, 12:42 AM

Fri, Dec 14

apol committed R169:287ca4a8bd30: SwipeListItem: always show the icons if !supportsMouseEvents (authored by apol).
SwipeListItem: always show the icons if !supportsMouseEvents
Fri, Dec 14, 11:27 PM
apol closed D17584: SwipeListItem: always show the icons if !supportsMouseEvents.
Fri, Dec 14, 11:27 PM · Kirigami
apol requested review of D17592: Introduce a DelegateRecycler attached object.
Fri, Dec 14, 11:27 PM · Kirigami
apol requested review of D17591: Make AbstractCard.background react to AbstractCard.highlighted.
Fri, Dec 14, 11:21 PM · Kirigami
apol requested review of D17584: SwipeListItem: always show the icons if !supportsMouseEvents.
Fri, Dec 14, 7:18 PM · Kirigami
apol committed R134:83fd7740e139: If inherit is not disabled, the colorSet isn't followed (authored by apol).
If inherit is not disabled, the colorSet isn't followed
Fri, Dec 14, 7:01 PM
apol updated the diff for D17583: Simplify code in MnemonicAttached.

Tune in

Fri, Dec 14, 6:52 PM · Kirigami
apol updated the diff for D17583: Simplify code in MnemonicAttached.

Polish

Fri, Dec 14, 6:42 PM · Kirigami
apol requested review of D17583: Simplify code in MnemonicAttached.
Fri, Dec 14, 6:34 PM · Kirigami
apol committed R134:42ed98ba2cc1: Don't inspect sources if the backend isn't confident about offering good results (authored by apol).
Don't inspect sources if the backend isn't confident about offering good results
Fri, Dec 14, 6:17 PM
apol committed R257:f7250edc2557: Remove unneeded options (authored by apol).
Remove unneeded options
Fri, Dec 14, 6:04 PM

Thu, Dec 13

apol accepted D17465: KDevelop/Shell : add 2 missing KTextEditorPluginIntegration::MainWindow slots.

LGTM

Thu, Dec 13, 7:24 PM · KDevelop
apol committed R134:19130e67b897: flatpak: Update flatpak dependency version (authored by apol).
flatpak: Update flatpak dependency version
Thu, Dec 13, 7:03 PM
apol committed R134:ede4a7c75cb8: Show an error if we couldn't find any resources from the featured apps (authored by apol).
Show an error if we couldn't find any resources from the featured apps
Thu, Dec 13, 6:59 PM
apol committed R134:9136b27a8d47: Remove unused code (authored by apol).
Remove unused code
Thu, Dec 13, 6:45 PM
apol committed R134:8c059ef7dc69: flatpak: prefer starting applications using the desktop file (authored by apol).
flatpak: prefer starting applications using the desktop file
Thu, Dec 13, 6:45 PM
apol committed R256:a5551dcb6bf0: discover: fix build (authored by apol).
discover: fix build
Thu, Dec 13, 6:10 PM
apol committed R256:e13ee2e0f2ec: discover: fix build in binary-factory (authored by apol).
discover: fix build in binary-factory
Thu, Dec 13, 6:10 PM
apol added a comment to D17549: We are not linking against dbus when building kstars lite.

Looks promising, just triggered a build.
https://binary-factory.kde.org/view/Android/job/KStars_android/

Thu, Dec 13, 5:10 PM · KDE Edu
apol committed R169:acad63a3c4ea: Consider whether needToUpdateWidth according to widthFromItem, not height (authored by apol).
Consider whether needToUpdateWidth according to widthFromItem, not height
Thu, Dec 13, 3:41 PM
apol committed R169:a9dbeaf21936: Don't try to reposition the ScrollView when we get a faulty height (authored by apol).
Don't try to reposition the ScrollView when we get a faulty height
Thu, Dec 13, 3:36 PM
apol committed R169:582721206a03: Take the scrollbar into account for the ScrollablePage margin (authored by apol).
Take the scrollbar into account for the ScrollablePage margin
Thu, Dec 13, 3:36 PM
apol closed D17551: Take the scrollbar into account for the ScrollablePage margin.
Thu, Dec 13, 3:36 PM · Kirigami
apol closed D17562: Don't try to reposition the ScrollView when we get a faulty height.
Thu, Dec 13, 3:36 PM · Kirigami
apol committed R134:4c5db5cdd604: ux: Make sure we can reach the view from the appdelegate (authored by apol).
ux: Make sure we can reach the view from the appdelegate
Thu, Dec 13, 3:12 PM
apol requested review of D17562: Don't try to reposition the ScrollView when we get a faulty height.
Thu, Dec 13, 3:08 PM · Kirigami
apol added a comment to D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space.

Hey, this change makes the file dialog crawl on big directories.
For me, going into /usr/include makes the whole application freeze.

Thu, Dec 13, 2:06 PM · Frameworks
apol added a comment to D17549: We are not linking against dbus when building kstars lite.

Then why does it build? Maybe fov.cpp isn't built on Android?

Thu, Dec 13, 1:51 PM · KDE Edu
apol committed R134:e935726e8340: Fix warning (authored by apol).
Fix warning
Thu, Dec 13, 4:23 AM
apol committed R134:0731c75b396e: Remove unused role (authored by apol).
Remove unused role
Thu, Dec 13, 4:23 AM
apol committed R134:1fb9be36a386: pk: Don't the dependencies button if there aren't dependencies (authored by apol).
pk: Don't the dependencies button if there aren't dependencies
Thu, Dec 13, 4:11 AM
apol requested review of D17551: Take the scrollbar into account for the ScrollablePage margin.
Thu, Dec 13, 3:43 AM · Kirigami
apol committed R169:819aee467d93: --warnings (authored by apol).
--warnings
Thu, Dec 13, 3:40 AM
apol committed R134:c980ddf6e368: pk: Fix state update logic on aptcc (authored by apol).
pk: Fix state update logic on aptcc
Thu, Dec 13, 3:05 AM
apol committed R134:012bd024d631: pk: change strategy for updating the installed package state (authored by apol).
pk: change strategy for updating the installed package state
Thu, Dec 13, 2:41 AM
apol committed R134:11b741429fed: pk: only emit PackageKitResource::stateChanged if it actually changed (authored by apol).
pk: only emit PackageKitResource::stateChanged if it actually changed
Thu, Dec 13, 2:41 AM
apol added a reviewer for D17550: Make the open url in tab feature a bit more discoverable: Frameworks.
Thu, Dec 13, 1:28 AM · Frameworks
apol requested review of D17550: Make the open url in tab feature a bit more discoverable.
Thu, Dec 13, 1:28 AM · Frameworks

Wed, Dec 12

apol requested review of D17549: We are not linking against dbus when building kstars lite.
Wed, Dec 12, 11:41 PM · KDE Edu
apol committed R321:2c2a6c5dc860: Add missing file to integrate with arcanist (authored by apol).
Add missing file to integrate with arcanist
Wed, Dec 12, 11:37 PM
apol committed R257:739028731bfc: Fix build against fdo sdk 18.08 (authored by apol).
Fix build against fdo sdk 18.08
Wed, Dec 12, 6:53 PM
apol committed R257:5f51307cc156: Rename extension: ffmpeg -> html5-codecs (authored by jjardon).
Rename extension: ffmpeg -> html5-codecs
Wed, Dec 12, 6:53 PM
apol committed R257:c382a0d36c49: Update to Qt 5.12.0 (authored by apol).
Update to Qt 5.12.0
Wed, Dec 12, 6:53 PM
apol committed R257:cf897200a8b9: Build against freedesktop-sdk 18.08 (authored by jjardon).
Build against freedesktop-sdk 18.08
Wed, Dec 12, 6:53 PM
apol committed R257:c31b1208ebc9: Use the same version for plasma-framework and kactivities as the restUse the… (authored by apol).
Use the same version for plasma-framework and kactivities as the restUse the…
Wed, Dec 12, 6:29 PM
apol committed R256:a6199a6d2fde: Update KF5 release (authored by apol).
Update KF5 release
Wed, Dec 12, 2:49 PM
apol committed R237:e4b002e7ae07: Fix documentation, QValueList isn't a thing anymore (authored by apol).
Fix documentation, QValueList isn't a thing anymore
Wed, Dec 12, 2:18 PM
apol closed D17491: Fix documentation, QValueList isn't a thing anymore.
Wed, Dec 12, 2:00 PM · Frameworks

Tue, Dec 11

apol committed R257:8d3a31d1e252: Merge branch 'qt5.9lts' (authored by apol).
Merge branch 'qt5.9lts'
Tue, Dec 11, 3:51 PM
apol committed R32:4ff8f6c4e4f3: polish flatpak integration (authored by apol).
polish flatpak integration
Tue, Dec 11, 3:23 PM
apol committed R32:b3f45c441135: Introduce checkExitCode on the OutputExecuteJob (authored by apol).
Introduce checkExitCode on the OutputExecuteJob
Tue, Dec 11, 3:23 PM
apol accepted D17501: Install Platform theme plugin into bin/platformthemes for unit tests.
Tue, Dec 11, 2:56 PM · Plasma
apol accepted D17367: Update Void Linux URL in README.md.

Looks good, do you need us to push the change?

Tue, Dec 11, 2:55 PM · Plasma
apol committed R256:352e9f49cc59: discover: fix listing user's flatpak apps (authored by apol).
discover: fix listing user's flatpak apps
Tue, Dec 11, 1:04 AM
apol committed R256:e44b630fa997: discover: newer versions of flatpak don't build (authored by apol).
discover: newer versions of flatpak don't build
Tue, Dec 11, 1:04 AM
apol accepted D17466: Fix doxygen markdown rendering.

As discussed or IRC

Tue, Dec 11, 12:55 AM · Documentation, Frameworks
apol added a comment to D17466: Fix doxygen markdown rendering.

But then it doesn't work here. Is it maybe possible to force the usage of github markdown on it?

Tue, Dec 11, 12:49 AM · Documentation, Frameworks
apol committed R134:4b9bdde405a7: Save last used sort order (authored by apol).
Save last used sort order
Tue, Dec 11, 12:43 AM

Mon, Dec 10

apol accepted D17475: rebrand index.
Mon, Dec 10, 10:57 PM
apol requested review of D17491: Fix documentation, QValueList isn't a thing anymore.
Mon, Dec 10, 5:09 PM · Frameworks
apol committed R169:b133bdc9998a: --warning (authored by apol).
--warning
Mon, Dec 10, 4:46 PM
apol added a comment to D17466: Fix doxygen markdown rendering.

If we are doing markdown, it could make sense why such common markdown isn't working too, otherwise this is bound to happen anyway. I've actually never seen this ~~~ thing.

Mon, Dec 10, 4:39 PM · Documentation, Frameworks
apol committed R858:c3ed33b9b5ea: Fix warning (authored by apol).
Fix warning
Mon, Dec 10, 4:25 PM
apol committed R134:1c40f2f6d542: snap: show more useful information for each channel (authored by apol).
snap: show more useful information for each channel
Mon, Dec 10, 4:02 PM
apol committed R134:de81341e8afa: Don't show a hover event if there's nothing to open (authored by apol).
Don't show a hover event if there's nothing to open
Mon, Dec 10, 4:02 PM
apol committed R858:afebad2e398d: Fix menu item width when the delegate is overriden (authored by apol).
Fix menu item width when the delegate is overriden
Mon, Dec 10, 3:51 PM
apol closed D17484: Fix menu item width when the delegate is overriden.
Mon, Dec 10, 3:51 PM · Plasma
apol committed R169:caf10fb3aeae: Fix warning (authored by apol).
Fix warning
Mon, Dec 10, 3:47 PM
apol closed D17268: Fix warning.
Mon, Dec 10, 3:47 PM · Kirigami
apol requested review of D17484: Fix menu item width when the delegate is overriden.
Mon, Dec 10, 3:46 PM · Plasma
apol committed R858:a8ea15ff5298: Fix warnings (authored by apol).
Fix warnings
Mon, Dec 10, 3:26 PM
apol closed D17480: Fix warnings.
Mon, Dec 10, 3:26 PM · Plasma
apol requested review of D17480: Fix warnings.
Mon, Dec 10, 3:21 PM · Plasma
apol closed D16965: Update platform theme extension point to new download-if conditional.
Mon, Dec 10, 2:19 PM
apol committed R257:9e5c5ebe1b22: Update platform theme extension point to new download-if conditional (authored by tingping).
Update platform theme extension point to new download-if conditional
Mon, Dec 10, 2:19 PM
apol committed R257:5d092b0dbe1c: Use kcoreaddons 5.53.1 that actually builds (authored by apol).
Use kcoreaddons 5.53.1 that actually builds
Mon, Dec 10, 12:53 PM
apol committed R256:f263a543f832: discover: supposedly make sure some backends are found (authored by apol).
discover: supposedly make sure some backends are found
Mon, Dec 10, 12:35 PM
apol committed R257:546d01ca25d1: Merge branch 'qt5.9lts' (authored by apol).
Merge branch 'qt5.9lts'
Mon, Dec 10, 1:42 AM
apol committed R257:ff32a5d4a9e6: Update to latest release of KF5 (authored by apol).
Update to latest release of KF5
Mon, Dec 10, 1:37 AM
apol committed R134:30de60f05d18: Don't automatically refresh if the user already asked apt to do so (authored by apol).
Don't automatically refresh if the user already asked apt to do so
Mon, Dec 10, 1:01 AM
apol added a comment to D17268: Fix warning.

ping

Mon, Dec 10, 12:58 AM · Kirigami
apol added a comment to D17438: [folder] Initialise LabelGenerator::m_labelMode.

That patch needs backporting to stable.

I'll do that now.

Mon, Dec 10, 12:40 AM · Plasma
apol abandoned D17375: Don't automatically refresh if the user already asked apt to do so.

It's landed, phabricator doesn't let me just close it.
https://commits.kde.org/discover/30de60f05d183e185724e614aad67b06aec987f3

Mon, Dec 10, 12:38 AM · Plasma