apol (Aleix Pol Gonzalez)
User

Projects (14)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 27 2015, 12:34 PM (238 w, 4 d)
Availability
Available

Recent Activity

Today

apol accepted D25460: Add a descriptive warning when inotify_add_watch returned ENOSPC.
Fri, Nov 22, 5:28 PM · Frameworks
apol accepted D25457: [kcmkwin/tabbox] Use an enum for role names.
Fri, Nov 22, 5:27 PM · KWin
apol accepted D25448: EBN cleanup of autests transfer protocol.

Do you have a commit account?

Fri, Nov 22, 11:06 AM · Frameworks
apol accepted D25442: Set application name and version on the knshandler tool.

Is the store having a big impact from this handler?

Fri, Nov 22, 11:05 AM · Frameworks

Yesterday

apol added inline comments to D25426: use the new GlobalDrawer header property.
Thu, Nov 21, 3:20 PM · Plasma
apol added a comment to D25226: [KPropertiesDialog] provide a way of showing the target of a symlink.

+1 LGTM

Thu, Nov 21, 3:17 PM · Frameworks
apol accepted D25430: fix layout of overlaysheet.

Change looks good to me. Please resolve the comments before landing.

Thu, Nov 21, 3:14 PM · Plasma

Wed, Nov 20

apol updated the title for P492 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Wed, Nov 20, 10:23 PM
apol closed D22946: Include API to generically implement --replace arguments.
Wed, Nov 20, 10:14 AM · Frameworks
apol committed R271:75cf9e495edd: Include API to generically implement --replace arguments (authored by apol).
Include API to generically implement --replace arguments
Wed, Nov 20, 10:14 AM
apol updated the diff for D22946: Include API to generically implement --replace arguments.

Remove wrong comment

Wed, Nov 20, 10:13 AM · Frameworks

Tue, Nov 19

apol updated the diff for D22946: Include API to generically implement --replace arguments.

Made the code less "racey"

Tue, Nov 19, 3:14 PM · Frameworks
apol committed R20:f0f01e82e6ad: Centralise startup code in this repository (authored by apol).
Centralise startup code in this repository
Tue, Nov 19, 2:23 PM
apol committed R20:538eae4aef6c: Workarounds (authored by apol).
Workarounds
Tue, Nov 19, 2:23 PM
apol committed R257:c390df12b10d: Merge branch 'qt5.12lts' into qt5.13 (authored by apol).
Merge branch 'qt5.12lts' into qt5.13
Tue, Nov 19, 12:54 PM
apol added a comment to D25398: Check values have changed before setting the model.

The commit message looks wrong, maybe you meant PolicyKit? PackageKit should be irrelevant.

Tue, Nov 19, 12:42 PM · Plasma
apol accepted D25396: Make the docs reflect that setIconName should be preferred over setPixmap when possible.
Tue, Nov 19, 12:40 PM · Frameworks
apol accepted D25384: Remove some unused includes.
Tue, Nov 19, 10:05 AM · Plasma

Mon, Nov 18

apol committed R134:f0b581e9e985: Fix build with Qt < 5.14 (authored by apol).
Fix build with Qt < 5.14
Mon, Nov 18, 9:58 PM
apol committed R257:ad045b53fc60: undate to kf 5.64 (authored by apol).
undate to kf 5.64
Mon, Nov 18, 9:42 PM
apol committed R257:0c2498fbd805: update to phonon 4.11.1 (authored by apol).
update to phonon 4.11.1
Mon, Nov 18, 9:42 PM
apol committed R257:530b8b1b3a67: update to qt 5.12.6 (authored by apol).
update to qt 5.12.6
Mon, Nov 18, 9:42 PM
apol committed R169:5cc8be3cd1fd: Icon: solve threading issue on when the source is http (authored by apol).
Icon: solve threading issue on when the source is http
Mon, Nov 18, 9:33 PM
apol closed D25185: Icon: solve threading issue on when the source is http.
Mon, Nov 18, 9:33 PM · Kirigami
apol committed R134:c98f34887bcf: Improve startup time when not opening the main page (authored by apol).
Improve startup time when not opening the main page
Mon, Nov 18, 5:17 PM
apol accepted D25331: Duplicate QML installation for unit tests.
Mon, Nov 18, 12:48 AM · Frameworks

Sun, Nov 17

apol accepted D25342: Mention all fetch project sources in the documentation.
Sun, Nov 17, 6:59 PM · Documentation, KDevelop
apol accepted D25331: Duplicate QML installation for unit tests.

Maybe wrap in if(BUILD_TESTING)

Sun, Nov 17, 6:54 PM · Frameworks

Fri, Nov 15

apol accepted D25327: Fix cmake project command position.
Fri, Nov 15, 3:35 PM · Kirigami
apol accepted D25270: Correctly set i18n arguments in one pass.
Fri, Nov 15, 3:31 PM · Frameworks
apol accepted D25308: when kioslave5 couldn't be found in libexec-ish locations try $PATH.
Fri, Nov 15, 3:30 PM · Frameworks
apol added inline comments to D25265: Support adding a contact to a specific backend.
Fri, Nov 15, 3:19 PM · Frameworks

Mon, Nov 11

apol added a comment to D24642: Rework Android APK generation.

+1
I'd like to see marble devs accepting it.

Mon, Nov 11, 9:25 PM · KDE Edu, Marble
apol added a comment to D25228: Bump version of KPeople.

Okay, makes sense to me

Mon, Nov 11, 9:09 PM
apol accepted D25227: Document Kirigami.Theme Better.

Looks like an improvement.

Mon, Nov 11, 3:31 AM · Kirigami, Documentation

Sat, Nov 9

apol accepted D25228: Bump version of KPeople.

.

Sat, Nov 9, 11:22 AM

Fri, Nov 8

apol accepted D25205: Remove pointless QDBusServiceWatcher.
Fri, Nov 8, 7:32 PM · Plasma
apol accepted D25196: Perform KNS searches from the Featured page again.
Fri, Nov 8, 5:49 PM · Plasma
apol updated the diff for D25185: Icon: solve threading issue on when the source is http.

simplify connect

Fri, Nov 8, 2:46 AM · Kirigami
apol updated the summary of D25185: Icon: solve threading issue on when the source is http.
Fri, Nov 8, 2:44 AM · Kirigami
apol updated the diff for D25185: Icon: solve threading issue on when the source is http.

Update commit text

Fri, Nov 8, 2:43 AM · Kirigami
apol updated the diff for D25185: Icon: solve threading issue on when the source is http.

Simplify the multithread situation with updatePolish

Fri, Nov 8, 2:42 AM · Kirigami

Thu, Nov 7

apol added a comment to D25196: Perform KNS searches from the Featured page again.

How about we target master for this?

Thu, Nov 7, 7:00 PM · Plasma
apol committed R257:fb5bbe40a1fc: Remove QtWebEngine for now (authored by apol).
Remove QtWebEngine for now
Thu, Nov 7, 5:36 PM
apol committed R257:5abf2b01e9f3: use a phonon version that exists (authored by apol).
use a phonon version that exists
Thu, Nov 7, 5:33 PM
apol committed R134:17c3bced4649: flatpak: --verbosity (authored by apol).
flatpak: --verbosity
Thu, Nov 7, 5:28 PM
apol committed R134:a6dac5a6045b: flatpak: show an error message when remotes are faulty (authored by apol).
flatpak: show an error message when remotes are faulty
Thu, Nov 7, 5:17 PM
apol committed R134:93e9f4bda9e9: ui: fix updates page (authored by apol).
ui: fix updates page
Thu, Nov 7, 5:17 PM
apol committed R134:6e752399db71: pk+suse: include a hack to allow apps to be executed (authored by apol).
pk+suse: include a hack to allow apps to be executed
Thu, Nov 7, 4:08 PM
apol committed R134:949b2aa718cf: pk: fix fallback invocation plan (authored by apol).
pk: fix fallback invocation plan
Thu, Nov 7, 4:08 PM
apol accepted D25193: use more modern for construct.
Thu, Nov 7, 2:25 PM · Frameworks
apol accepted D25192: Replace for with maths with range for.
Thu, Nov 7, 2:24 PM · Frameworks
apol accepted D25188: Bump fcitx-qt5 version to support new flatpak..
Thu, Nov 7, 12:29 PM
apol added a comment to D25185: Icon: solve threading issue on when the source is http.

Can we just use queued connection, it'll avoid mutex weirdness.

Thu, Nov 7, 12:28 PM · Kirigami
apol committed R134:9c5836affddd: Merge branch 'Plasma/5.17' (authored by apol).
Merge branch 'Plasma/5.17'
Thu, Nov 7, 2:38 AM
apol committed R134:219e5a255920: kns: don't read globals when loading KNS files (authored by apol).
kns: don't read globals when loading KNS files
Thu, Nov 7, 2:38 AM
apol committed R134:836b5595516c: ui: improve busy indicator handling (authored by apol).
ui: improve busy indicator handling
Thu, Nov 7, 2:38 AM
apol updated the diff for D25185: Icon: solve threading issue on when the source is http.

deadlock

Thu, Nov 7, 2:33 AM · Kirigami
apol requested review of D25185: Icon: solve threading issue on when the source is http.
Thu, Nov 7, 2:26 AM · Kirigami

Wed, Nov 6

apol committed R134:cbf1241d57eb: flatpak: save quite some unnecessary QString allocations at startup (authored by apol).
flatpak: save quite some unnecessary QString allocations at startup
Wed, Nov 6, 8:20 PM
apol requested review of D25179: Don't move the drawer collapse button if there's no icon or image.
Wed, Nov 6, 8:18 PM · Kirigami
apol committed R169:1f7d5ff90879: Fix binding loop on toobig (authored by apol).
Fix binding loop on toobig
Wed, Nov 6, 8:17 PM
apol closed D25174: Fix binding loop on toobig.
Wed, Nov 6, 8:17 PM · Kirigami
apol added a comment to T10952: Drop EmojiOne and adopt Twemoji for emoticon substitution.

I'm not sure what you're talking about. Drop EmojiOne from where?

Wed, Nov 6, 5:51 PM · Plasma
apol committed R134:d7579e8dedbe: app page: fix display of faulty screenshots (authored by apol).
app page: fix display of faulty screenshots
Wed, Nov 6, 3:28 PM
apol committed R134:1206c9db940d: Merge branch 'Plasma/5.17' (authored by apol).
Merge branch 'Plasma/5.17'
Wed, Nov 6, 3:04 PM
apol committed R134:a539db7d4d50: --qml warnings (authored by apol).
--qml warnings
Wed, Nov 6, 3:02 PM
apol requested review of D25174: Fix binding loop on toobig.
Wed, Nov 6, 3:02 PM · Kirigami
apol committed R134:2e3994c435a8: Merge branch 'Plasma/5.17' (authored by apol).
Merge branch 'Plasma/5.17'
Wed, Nov 6, 1:54 PM
apol committed R134:9e081fb2d175: --warnings (authored by apol).
--warnings
Wed, Nov 6, 1:54 PM
apol committed R134:a3ac05401e4f: ui: uncomment tooltip text (authored by apol).
ui: uncomment tooltip text
Wed, Nov 6, 1:54 PM
apol accepted D25172: Fix overloaded signal.
Wed, Nov 6, 1:46 PM · Plasma
apol accepted D25167: Un-break portal support.
Wed, Nov 6, 1:44 PM
apol accepted D25164: MobileTextActionsToolBar check if controlRoot is undefined before using it.
Wed, Nov 6, 1:44 PM · Frameworks

Tue, Nov 5

apol accepted D25159: Fix linking to libssh 0.9.1.

Fixes the build for me too, patch looks good.

Tue, Nov 5, 3:48 PM · Frameworks, Dolphin
apol committed R134:909dac1e69b7: kns: fetching details might increase the description we have (authored by apol).
kns: fetching details might increase the description we have
Tue, Nov 5, 3:00 PM
apol committed R134:2609ab269b65: --qclp runtime warnings (authored by apol).
--qclp runtime warnings
Tue, Nov 5, 2:23 PM
apol committed R134:db7364d451da: ui: remove LinkLabel (authored by apol).
ui: remove LinkLabel
Tue, Nov 5, 2:23 PM
apol committed R134:77d64f93e1a3: Fix qml warnings (authored by apol).
Fix qml warnings
Tue, Nov 5, 2:09 PM
apol committed R134:c76730efd1a4: Merge branch 'Plasma/5.17' (authored by apol).
Merge branch 'Plasma/5.17'
Tue, Nov 5, 1:55 PM
apol accepted D25156: [emojier] Load locale file correctly.
Tue, Nov 5, 11:44 AM · Plasma
apol accepted D25143: Basic cross-compiling support for parsetrigrams.

LGTM, thanks for looking into this!

Tue, Nov 5, 11:35 AM · Frameworks
apol accepted D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu.
Tue, Nov 5, 11:32 AM · Plasma
apol accepted D25002: disable bug report when there are signs of an update.
Tue, Nov 5, 11:30 AM · Plasma
apol accepted D25154: actually set a dependency between kcrashtest and test_crasher.
Tue, Nov 5, 11:29 AM · Frameworks
apol accepted D25153: disable kcrashtest and its helper executable test_crasher on windows.
Tue, Nov 5, 11:27 AM · Frameworks
apol committed R857:d89209f9915a: android: fix one of the paths we were replacing in the pc files (authored by apol).
android: fix one of the paths we were replacing in the pc files
Tue, Nov 5, 2:10 AM

Mon, Nov 4

apol committed R857:e56e081e448e: gstreamer: fix pkg-config files (authored by apol).
gstreamer: fix pkg-config files
Mon, Nov 4, 7:04 PM
apol committed R256:5ecf6e009e28: kirogi: forgot patch (authored by apol).
kirogi: forgot patch
Mon, Nov 4, 4:30 PM
apol committed R256:d71bb94e4634: kirogi: address several issues (authored by apol).
kirogi: address several issues
Mon, Nov 4, 4:23 PM
apol added a comment to D25127: [platforms/wayland] Do an initial xdg-surface commit.

Awesome, thanks! :)

Mon, Nov 4, 3:45 PM · KWin
apol committed R257:3fb306e6e048: Update to newer qt and kf (authored by apol).
Update to newer qt and kf
Mon, Nov 4, 2:56 PM
apol committed R256:41afc7f603b0: kirogi: Update to platform 5.13 (authored by apol).
kirogi: Update to platform 5.13
Mon, Nov 4, 1:29 PM

Sun, Nov 3

apol added a comment to D25124: Make env in plasma-sourceenv.sh call portable.

Can you add a comment about this?

Sun, Nov 3, 2:38 AM · Plasma
apol accepted D25124: Make env in plasma-sourceenv.sh call portable.
Sun, Nov 3, 2:38 AM · Plasma
apol added a comment to D25117: file ioslave: stop copying as soon as the ioslave is killed.

+1 makes a lot of sense overall.

Sun, Nov 3, 2:34 AM · Frameworks
apol accepted D25115: Add guard for missing kirigami.
Sun, Nov 3, 2:29 AM · Frameworks
apol accepted D25113: ftp ioslave: remove redundant variable.
Sun, Nov 3, 2:29 AM · Frameworks
apol accepted D25109: Make it impossible to open the progress view sheet multiple times.
Sun, Nov 3, 2:27 AM · Plasma
apol accepted D25107: Add install dir for systemd units.
Sun, Nov 3, 2:26 AM · Build System, Frameworks