- User Since
- Apr 27 2015, 12:34 PM (116 w, 6 d)
Sat, Jul 22
Fri, Jul 21
Maybe you could add a unit test?
+1 from the board, we'll make the transfer later today (when petra is in Civitas).
Thu, Jul 20
Wed, Jul 19
What's the background for the change?
In general, this looks like an overkill to me.
Maybe it would make sense to allow the DeviceLink to tell which IP it's connected to?
Tue, Jul 18
Mon, Jul 17
I guess this task can be closed now.
I'd gladly give you a +1 but I have no idea about ocaml, maybe you can point us to the documentation?
Apparently this is something that changed in ocaml eventually...
Sun, Jul 16
I agree it's better that we don't use KF5:: if it's not actually in KDE Frameworks. Also the patch looks good.
This was implemented at some point in the past, it was decided against merging it because it wasn't working very well. Maybe you'd like to pick it up:
Sat, Jul 15
Looks good to me.
Fri, Jul 14
Thu, Jul 13
Looks good to me
Check if there's a flickableItem like others
Wed, Jul 12
Note: This should probably be turned into a data-driven test in future. Too many branches checking for individual test rows in the body now.
I know that so far TDF, Slimbook, Blue Systems requested a booth.
Also we will need some for the t-shirts.
Seems like this API is extremely brittle, would it be possible to make sure this is dealt with on the library side?
Why are you doing this? What are you trying to fix?
Tue, Jul 11
Mon, Jul 10
Other than that, LGTM. I'm not sure why you need to go through the job list again, but it's not a big penalty so if that's what makes it stable, let's go for it.
Fri, Jul 7
+1, this has annoyed me in the past.