apol (Aleix Pol Gonzalez)
User

Projects (14)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 27 2015, 12:34 PM (208 w, 3 d)
Availability
Available

Recent Activity

Today

apol added a comment to D20826: Allow building without a CMAKE_BUILD_TYPE.

We were not explicitly setting it in the flatpak nightly builds and it was failing because of that. We are now so it's not an issue anymore there.

Thu, Apr 25, 7:17 PM · KDE Edu
apol edited reviewers for D20826: Allow building without a CMAKE_BUILD_TYPE, added: Cantor; removed: Kdenlive.
Thu, Apr 25, 6:51 PM · KDE Edu
apol requested review of D20826: Allow building without a CMAKE_BUILD_TYPE.
Thu, Apr 25, 6:51 PM · KDE Edu
apol committed R256:97bad436c02a: kdenlive: Set a build type (authored by apol).
kdenlive: Set a build type
Thu, Apr 25, 6:49 PM
apol committed R256:86fe899044b9: kdenlive: build rttr from flatpak (authored by apol).
kdenlive: build rttr from flatpak
Thu, Apr 25, 5:50 PM
apol committed R256:5d28e2bdc335: kcolorscheme: Fix finding the icon (authored by apol).
kcolorscheme: Fix finding the icon
Thu, Apr 25, 5:19 PM
apol committed R323:d1b091911a6b: Still find header after installing (authored by apol).
Still find header after installing
Thu, Apr 25, 5:12 PM
apol committed R256:3ba7ab22eaab: atelier: remove cmake build, update to stable qwt (authored by apol).
atelier: remove cmake build, update to stable qwt
Thu, Apr 25, 5:05 PM
apol accepted D20818: Add the Show Desktop applet (moved from kdeplasma-addons).

Looks good to me. Will have to move the (few) translations with it. @ltoscano

Thu, Apr 25, 4:16 PM · Plasma
apol accepted D20810: Fix launcher URL comparison.
Thu, Apr 25, 4:07 PM · Plasma
apol accepted D20807: add support for extra cmake finders.
Thu, Apr 25, 3:53 PM · KDE Edu
apol accepted D20814: find netcdf via its own cmake config.

LGTM

Thu, Apr 25, 3:53 PM · KDE Edu
apol accepted D20813: replace manual lz4 lookup with pkg-config-assisted finder.

LGTM

Thu, Apr 25, 3:53 PM · KDE Edu
apol accepted D20812: import cfitsio finder from gwenview and use it instead of manual find_*.

LGTM

Thu, Apr 25, 3:53 PM · KDE Edu
apol accepted D20811: replace manual fftw3 lookup with pkg-config-assisted finder.

LGTM

Thu, Apr 25, 3:46 PM · KDE Edu
apol accepted D20809: replace manual cerf lookup with pkg-config-assisted finder.
Thu, Apr 25, 3:44 PM · KDE Edu
apol added a comment to D20808: find cantor via config (and fall back to finder when not available).

Then let's leave it as +1 :)

Thu, Apr 25, 3:44 PM · KDE Edu
apol committed R857:c7fbf3901992: android: git.openssl.org seems to be down, use the github mirror (authored by apol).
android: git.openssl.org seems to be down, use the github mirror
Thu, Apr 25, 3:41 PM
apol added a comment to D20808: find cantor via config (and fall back to finder when not available).

Other than that, +1 for the patch.

Thu, Apr 25, 3:30 PM · KDE Edu
apol committed R857:c8e40a945526: Update to Qt 5.12.3 (authored by apol).
Update to Qt 5.12.3
Thu, Apr 25, 3:16 PM
apol updated the summary of D20255: Improve behavior of rotated displays.
Thu, Apr 25, 12:19 AM · KWin

Yesterday

apol accepted D20521: Don't rescale every output every time outputs change.
Wed, Apr 24, 11:43 PM · KWin
apol accepted D20800: Initialise XdgOutput properties on creation.
Wed, Apr 24, 11:43 PM · KWin
apol updated the diff for D19860: Software rotation: orient the screen regardless of whether drm accepted it.

Disable blur and bg contrast when rotated

Wed, Apr 24, 4:37 PM · KWin
apol accepted D20785: expand bsd license in cmake modules.
Wed, Apr 24, 1:59 PM · KDE Edu
apol added inline comments to D20787: process: add support for cgroups.
Wed, Apr 24, 1:53 PM · Plasma
apol added a comment to T10837: Plasma Accessibility Sprint.

We are having a regular Plasma sprint, maybe you'd want to join us and work on a11y?
https://community.kde.org/Sprints/Plasma/2019

Wed, Apr 24, 1:21 PM · Plasma Accessibility

Tue, Apr 23

apol committed R134:96fa705d15f7: Fix warning (authored by apol).
Fix warning
Tue, Apr 23, 4:10 PM
apol committed R169:94b8482946db: Make sure we don't squeeze out the ActionButton (authored by apol).
Make sure we don't squeeze out the ActionButton
Tue, Apr 23, 4:08 PM
apol closed D20771: Make sure we don't squeeze out the ActionButton.
Tue, Apr 23, 4:08 PM · Kirigami
apol requested review of D20771: Make sure we don't squeeze out the ActionButton.
Tue, Apr 23, 4:03 PM · Kirigami
apol committed R134:817101c32a9a: Improve dealing with updates (authored by apol).
Improve dealing with updates
Tue, Apr 23, 2:49 PM
apol committed R108:bf6f05bf3cd6: Initialise the orientation sensor at start (authored by apol).
Initialise the orientation sensor at start
Tue, Apr 23, 12:48 PM
apol closed D20622: Initialise the orientation sensor at start.
Tue, Apr 23, 12:48 PM · KWin
apol committed R257:3e8d5066faef: Update to Qt 5.9.8 (authored by apol).
Update to Qt 5.9.8
Tue, Apr 23, 1:06 AM
apol committed R257:d059eb794faf: Fetch sha256sum files before getting the full package and calculating it (authored by apol).
Fetch sha256sum files before getting the full package and calculating it
Tue, Apr 23, 1:06 AM
apol accepted D20758: kpackagetool: read kpackage-generic.desktop from qrc.
Tue, Apr 23, 12:02 AM
apol accepted D20749: autotests: don't fail appstream test because of anything on stderr.

Thanks!

Tue, Apr 23, 12:00 AM · Frameworks

Sun, Apr 21

apol accepted D20702: KTar: Protect against negative longlink sizes.
Sun, Apr 21, 12:02 PM · Frameworks

Sat, Apr 20

apol committed R32:8f77f44b67c7: DVCS Branch Manager with filtering and sorting proposal (authored by christiant).
DVCS Branch Manager with filtering and sorting proposal
Sat, Apr 20, 12:13 AM

Fri, Apr 19

apol committed R134:1f8acd37773d: Add flatpak mime types (authored by eszlari).
Add flatpak mime types
Fri, Apr 19, 11:47 PM
apol closed D20242: Add flatpak mime types.
Fri, Apr 19, 11:47 PM · Plasma
apol added a comment to D20242: Add flatpak mime types.

Don't you have a commit account yet?
https://community.kde.org/Infrastructure/Get_a_Developer_Account

Fri, Apr 19, 11:46 PM · Plasma
apol accepted D20677: Fix compile on arm.

LGTM, anothher fix could have been wrapping them with parenthesis?

Fri, Apr 19, 11:44 PM
apol added a comment to D20142: DVCS Branch Manager with filtering and sorting proposal.

Probably not - this is my first commit. Where do I need to apply :-D

Fri, Apr 19, 11:42 PM · KDevelop, VDG
apol closed D20142: DVCS Branch Manager with filtering and sorting proposal.
Fri, Apr 19, 11:41 PM · KDevelop, VDG
apol accepted D20663: Use more accurate name for Workspace::getMovingClient method.

Reads better!

Fri, Apr 19, 11:36 PM · KWin

Wed, Apr 17

apol committed R257:02adbdb11109: Update to Qt 5.12.3 (authored by apol).
Update to Qt 5.12.3
Wed, Apr 17, 11:00 PM
apol updated the diff for D20622: Initialise the orientation sensor at start.

address zzag's comment

Wed, Apr 17, 10:47 PM · KWin
apol added inline comments to D20622: Initialise the orientation sensor at start.
Wed, Apr 17, 10:47 PM · KWin
apol accepted D20643: Fix invalid memory write on malformed tar files.
Wed, Apr 17, 10:46 PM · Frameworks
apol added a comment to D17105: Add a new lookandfeel runner.

That's all true, yeah. I see more and more people asking for an automatic color scheme switching system these days. So we might want to consider adding this feature in some manner.

Technically, I feel like for this purpose ("it's dark, I want my UI to be dark too"), changing just the color scheme is much less invasive than changing the whole LnF theme, which for example resets your window switcher effect. That would be very unwelcome.

Wed, Apr 17, 10:24 PM · Plasma
apol accepted D20644: Fix memory leak when reading some tar files.
Wed, Apr 17, 10:19 PM · Frameworks
apol accepted D20641: Fix uninitialized memory use when reading malformed tar files.

Should maybe warn if it fails?

Wed, Apr 17, 10:18 PM · Frameworks
apol added a comment to D20643: Fix invalid memory write on malformed tar files.

+1 in general

Wed, Apr 17, 10:16 PM · Frameworks
apol requested changes to D20639: Remove TODO.

I don't think you understood the TODO. Also this change breaks ABI, since const it's part of it.
The TODO talks about adding a startTimer method and deprecating timer (which it already is).

Wed, Apr 17, 10:12 PM · Frameworks
apol added a comment to D17105: Add a new lookandfeel runner.

Hmm, I'm not sure how I feel about this. Seems like this could make it easy to accidentally change your LNF by accident. Changing LNF packages is in some sense a destructive since there's no easy way to undo it and go back to your previous panel-and-widget setup.

I feel like there's probably a better solution to the "I'm staying up too late with my computer" use case. I typically just turn down the brightness when I'm doing this. There's also the KWin "Invert" effect which lets you instantly invert the colors with a single keyboard shortcut.

Wed, Apr 17, 6:22 PM · Plasma
apol committed R134:3aadd3aa4c02: Allow to close Discover when there's ongoing jobs (authored by apol).
Allow to close Discover when there's ongoing jobs
Wed, Apr 17, 6:15 PM
apol updated the title for P375 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Wed, Apr 17, 6:12 PM
apol committed R134:246ea7263182: Improve startup sequence (authored by apol).
Improve startup sequence
Wed, Apr 17, 6:06 PM
apol added a comment to D20558: Bug fix: find c++ stl using regex.

In my case if I do this: include (Android.cmake), then it won't be able to find the ECMAndroidDeployQt.cmake because I am using android-ndk's toolchain.

Wed, Apr 17, 4:08 PM · Build System, Frameworks
apol committed R257:2a93af37c18d: Explicitly disable UDev (authored by apol).
Explicitly disable UDev
Wed, Apr 17, 3:28 PM
apol accepted D20558: Bug fix: find c++ stl using regex.
Wed, Apr 17, 3:16 PM · Build System, Frameworks
apol added a comment to D20558: Bug fix: find c++ stl using regex.

Why are you using it without Android.cmake?

I am building Krita and to add create-apk target I am using include (ECMAndroidDeployQt.cmake), I can't use Android.cmake because of some variables as it expects to run as a toolchain.

Wed, Apr 17, 2:36 PM · Build System, Frameworks
apol requested review of D20622: Initialise the orientation sensor at start.
Wed, Apr 17, 12:34 AM · KWin

Tue, Apr 16

apol committed R257:77f3c4145b3e: Forgot to add to README (authored by apol).
Forgot to add to README
Tue, Apr 16, 10:51 PM
apol committed R257:4d951eb34566: Improve README.md (authored by apol).
Improve README.md
Tue, Apr 16, 10:50 PM
apol accepted D20616: KeySequenceHelperPrivate::updateShortcutDisplay: Don't show english text to the user.

We shouldn't indeed. Maybe it's a candidate to get in KGuiAddons

Tue, Apr 16, 10:28 PM · Frameworks
apol accepted D20614: KKeySequenceWidget: Don't show English strings to the user.
Tue, Apr 16, 9:57 PM · Frameworks
apol accepted D20613: Document that modToStringUser and stringUserToMod only deal with english strings.
Tue, Apr 16, 9:45 PM · Frameworks
apol accepted D20604: Fix stack-buffer-overflow read on malformed files.
Tue, Apr 16, 5:57 PM · Frameworks
apol accepted D20605: Fix null-dereference on malformed tar files.
Tue, Apr 16, 5:57 PM · Frameworks
apol committed R474:5cf9934b697e: Merge branch 'Applications/19.04' (authored by apol).
Merge branch 'Applications/19.04'
Tue, Apr 16, 12:40 PM
apol committed R474:8dc8fffee2c6: Easier to read GstPointer (authored by apol).
Easier to read GstPointer
Tue, Apr 16, 12:40 PM
apol committed R474:f3753e2b12d5: Don't leak gst structures (authored by apol).
Don't leak gst structures
Tue, Apr 16, 12:40 PM
apol updated the diff for D19860: Software rotation: orient the screen regardless of whether drm accepted it.

Detect when the display reports portrait by default

Tue, Apr 16, 2:07 AM · KWin
apol updated the title for P373 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Tue, Apr 16, 2:06 AM
apol committed R134:9d49c268cf22: packagekit: Don't display packages that extend themselves (authored by apol).
packagekit: Don't display packages that extend themselves
Tue, Apr 16, 1:31 AM
apol accepted D20092: New class KOSRelease - a parser for os-release files.
Tue, Apr 16, 12:52 AM · Frameworks
apol committed R134:b7ebd04e8945: Improve the updates page (authored by apol).
Improve the updates page
Tue, Apr 16, 12:18 AM

Mon, Apr 15

apol added inline comments to D20588: Refactor getters in OutputScreens.
Mon, Apr 15, 11:50 PM · KWin
apol added inline comments to D20588: Refactor getters in OutputScreens.
Mon, Apr 15, 11:37 PM · KWin
apol committed R134:0ef1323345b9: Don't offer system updates while offline (authored by apol).
Don't offer system updates while offline
Mon, Apr 15, 4:57 PM
apol committed R134:fc903987492c: Fix warning (authored by apol).
Fix warning
Mon, Apr 15, 4:57 PM
apol committed R134:24f71827a88d: Add debug information when a backend is being slow (authored by apol).
Add debug information when a backend is being slow
Mon, Apr 15, 4:57 PM
apol committed R474:a7947d0e1125: Properly un-mirror images (authored by apol).
Properly un-mirror images
Mon, Apr 15, 3:18 PM
apol added inline comments to D20521: Don't rescale every output every time outputs change.
Mon, Apr 15, 2:16 PM · KWin
apol added a comment to D20572: RFC: Add .clang-format.

Reviewing such changes gets a bit tedious for both code reviewer and patch author.

I think this is bigger than kwin and something worth taking to kde-devel, plasma-devel.

Applying to all files in the project is something that IMHO makes sense, and something I would readily approve in plasma-desktop/plasma-workspace.

Mon, Apr 15, 2:15 PM · KWin
apol updated the title for P372 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Mon, Apr 15, 1:52 PM
apol added a comment to D20572: RFC: Add .clang-format.

We could give it a go, how do you test it?
Do you suggest having it in git hooks? Can we use it only on the places that change?

Mon, Apr 15, 12:57 PM · KWin
apol added a comment to D20558: Bug fix: find c++ stl using regex.

Can we add a cmake_minimum_required to 3.7? Regex fails to compile on older versions, when run outside of Android.cmake.

Mon, Apr 15, 12:08 AM · Build System, Frameworks
apol added inline comments to D20521: Don't rescale every output every time outputs change.
Mon, Apr 15, 12:02 AM · KWin

Sun, Apr 14

apol accepted D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix.

Looks good to me, can you land it?

Sun, Apr 14, 11:59 PM · Build System, Frameworks
apol added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

Oh, really? Hmm! I wouldn't be opposed to enable compilation with exceptions myself, what do the others say? We don't need to use them excessively, but for error handling in async promise chains, that would be quite useful I think?

Sun, Apr 14, 6:14 PM · KDevelop
apol committed R257:3a5b6770dcf0: Solid patch is now unnecessary (authored by apol).
Solid patch is now unnecessary
Sun, Apr 14, 5:56 PM
apol committed R257:85722e73b65d: Dependencies are installed by flatpak-builder now (authored by apol).
Dependencies are installed by flatpak-builder now
Sun, Apr 14, 5:56 PM
apol committed R257:e912bb7404d5: Don't need to include cmake files in the Platform (authored by apol).
Don't need to include cmake files in the Platform
Sun, Apr 14, 5:56 PM
apol committed R257:77595a162bca: Remove unused files (authored by apol).
Remove unused files
Sun, Apr 14, 5:56 PM
apol committed R116:4408af0c1111: Don't load the KSharedConfig instance on every read (authored by apol).
Don't load the KSharedConfig instance on every read
Sun, Apr 14, 5:53 PM
apol closed D20522: Don't load the KSharedConfig instance on every read.
Sun, Apr 14, 5:53 PM · Plasma