apol (Aleix Pol Gonzalez)
User

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 27 2015, 12:34 PM (116 w, 6 d)
Availability
Available

Recent Activity

Yesterday

apol accepted D6793: adopt new KAboutLicense::spdx.
Sun, Jul 23, 3:42 PM · Frameworks

Sat, Jul 22

apol added a comment to D6827: Remove unused khtml dependency.

+1

Sat, Jul 22, 2:06 PM

Fri, Jul 21

apol added a comment to D6807: Fix segmentation fault caused by certain files.

Maybe you could add a unit test?

Fri, Jul 21, 1:46 PM
apol added a comment to T6035: Visit to the Cabo de Gata-Níjar Natural park.

+1 from the board, we'll make the transfer later today (when petra is in Civitas).

Fri, Jul 21, 11:20 AM · Akademy (Akademy 2017)

Thu, Jul 20

apol accepted D6794: assert the testpackage appstream data validates.
Thu, Jul 20, 2:34 PM · Frameworks

Wed, Jul 19

apol added a comment to D6772: Fix usage of query_qmake: differ between calls expecting qmake or not.

What's the background for the change?

Wed, Jul 19, 1:13 PM · Build System, Frameworks
apol committed R32:47f9ffe02413: Support not having an artifact (authored by apol).
Support not having an artifact
Wed, Jul 19, 1:13 AM
apol committed R257:57fd2d3a235d: Revert "Remove unneeded settings" (authored by apol).
Revert "Remove unneeded settings"
Wed, Jul 19, 12:56 AM
apol added a reverting commit for R257:5924e060df36: Remove unneeded settings: R257:57fd2d3a235d: Revert "Remove unneeded settings".
Wed, Jul 19, 12:56 AM
apol added a comment to D6730: Determine which IP address to use for sshfs.

In general, this looks like an overkill to me.
Maybe it would make sense to allow the DeviceLink to tell which IP it's connected to?

Wed, Jul 19, 12:52 AM · KDE Connect

Tue, Jul 18

apol accepted D6773: Add API dox for KDEInstallDirs' KDE_INSTALL_USE_QT_SYS_PATHS.
Tue, Jul 18, 4:49 PM · Build System, Frameworks
apol committed R720:008f6642cb1d: Embed the component icon (authored by apol).
Embed the component icon
Tue, Jul 18, 11:38 AM

Mon, Jul 17

apol added a comment to T5740: promo plan for Akademy.

I guess this task can be closed now.

Mon, Jul 17, 11:31 PM · Akademy (Akademy 2017), KDE Promo
apol committed R257:5924e060df36: Remove unneeded settings (authored by apol).
Remove unneeded settings
Mon, Jul 17, 11:11 PM
apol added a reviewer for D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin: Windows.
Mon, Jul 17, 11:06 PM · Build System, Frameworks
apol added a comment to D6752: Fix build with ocaml 4.04.

I'd gladly give you a +1 but I have no idea about ocaml, maybe you can point us to the documentation?
Apparently this is something that changed in ocaml eventually...

Mon, Jul 17, 2:29 PM
apol committed R256:b3a5c906f216: Kube needs network access (authored by apol).
Kube needs network access
Mon, Jul 17, 2:00 AM

Sun, Jul 16

apol added a comment to D6736: Remove KF5 prefix.

I agree it's better that we don't use KF5:: if it's not actually in KDE Frameworks. Also the patch looks good.
+1

Sun, Jul 16, 11:07 PM
apol added a comment to T6512: Add Media Player Controls.

This was implemented at some point in the past, it was decided against merging it because it wasn't working very well. Maybe you'd like to pick it up:
https://git.reviewboard.kde.org/r/116972/
https://git.reviewboard.kde.org/r/126129/

Sun, Jul 16, 11:04 PM · KDE Connect
apol added a comment to D6740: Fixed exception while handling notifications.

Looks good to me.

Sun, Jul 16, 10:55 PM · KDE Connect

Sat, Jul 15

apol accepted D6724: Replace Q_FOREACH with C++11 range-for.

Looks good to me.

Sat, Jul 15, 11:32 PM · KDE Connect

Fri, Jul 14

apol committed R224:d7ec24725f93: Make sure we keep track of changes when the device link changes (authored by apol).
Make sure we keep track of changes when the device link changes
Fri, Jul 14, 1:31 AM

Thu, Jul 13

apol committed R224:209e3e284227: Reflect property change when unpairing (authored by apol).
Reflect property change when unpairing
Thu, Jul 13, 11:01 PM
apol committed R224:bfaec966384a: Unpair whenever there's a QSSLError (authored by apol).
Unpair whenever there's a QSSLError
Thu, Jul 13, 10:24 PM
apol committed R240:1e3d961c0091: Properly point at ECM (authored by apol).
Properly point at ECM
Thu, Jul 13, 4:46 PM
apol accepted D6677: Automatically install/remove/update related refs.
Thu, Jul 13, 1:15 PM · Plasma
apol added a comment to D6677: Automatically install/remove/update related refs.

Looks good to me

Thu, Jul 13, 1:13 PM · Plasma
apol committed R169:868d61272b2a: Allow having a header in a ListView that is in an OverlaySheet (authored by apol).
Allow having a header in a ListView that is in an OverlaySheet
Thu, Jul 13, 10:59 AM
apol closed D6666: Allow having a header in a ListView that is in an OverlaySheet by committing R169:868d61272b2a: Allow having a header in a ListView that is in an OverlaySheet.
Thu, Jul 13, 10:59 AM · Kirigami
apol updated the diff for D6666: Allow having a header in a ListView that is in an OverlaySheet.

Check if there's a flickableItem like others

Thu, Jul 13, 12:51 AM · Kirigami
apol added a comment to D6666: Allow having a header in a ListView that is in an OverlaySheet.

Before

Thu, Jul 13, 12:50 AM · Kirigami
apol created D6666: Allow having a header in a ListView that is in an OverlaySheet.
Thu, Jul 13, 12:46 AM · Kirigami
apol committed R325:0d7f00c6287d: Include equivalent completion to the QtWidgets UI (authored by apol).
Include equivalent completion to the QtWidgets UI
Thu, Jul 13, 12:17 AM
apol committed R323:0b22699ffcbf: Extend OperatorsModel means (authored by apol).
Extend OperatorsModel means
Thu, Jul 13, 12:16 AM

Wed, Jul 12

apol committed R32:d19352b83d41: Improve ctest system (authored by apol).
Improve ctest system
Wed, Jul 12, 10:56 PM
apol added a comment to D6656: honor WORKING_DIRECTORY set on CTest tests.

Note: This should probably be turned into a data-driven test in future. Too many branches checking for individual test rows in the body now.

Wed, Jul 12, 10:25 PM
apol added a comment to T5959: Set furniture list for hall space.

I know that so far TDF, Slimbook, Blue Systems requested a booth.
Also we will need some for the t-shirts.

Wed, Jul 12, 10:20 PM · Akademy (Akademy 2017)
apol accepted D6656: honor WORKING_DIRECTORY set on CTest tests.

Cool, thanks!

Wed, Jul 12, 10:02 PM
apol added a comment to D6657: [krunner] First set panel behavior than as panel.

Seems like this API is extremely brittle, would it be possible to make sure this is dealt with on the library side?

Wed, Jul 12, 10:00 PM · Plasma
apol added a comment to D6656: honor WORKING_DIRECTORY set on CTest tests.

Why are you doing this? What are you trying to fix?

Wed, Jul 12, 5:55 PM
apol accepted D6642: Use version of the Applications product.
Wed, Jul 12, 5:51 PM · Plasma
apol committed R257:57fac2e0aab6: Include Intel.VAAPI extensions (authored by apol).
Include Intel.VAAPI extensions
Wed, Jul 12, 5:39 PM
apol committed R32:a2d8ad440a02: Fix test, remove commented code (authored by apol).
Fix test, remove commented code
Wed, Jul 12, 3:53 PM
apol committed R32:3c1fd1f09e60: Properly initialize a test's executable (authored by apol).
Properly initialize a test's executable
Wed, Jul 12, 3:38 PM
apol committed R32:a2df30205c0a: Properly detect subdirectories (authored by apol).
Properly detect subdirectories
Wed, Jul 12, 3:38 PM
apol committed R32:83d654c6c7a3: Use the old cmake parser for CTestTestfile (authored by apol).
Use the old cmake parser for CTestTestfile
Wed, Jul 12, 3:38 PM
apol committed R32:c80143aa35b5: Don't allocate strings unnecessarily (authored by apol).
Don't allocate strings unnecessarily
Wed, Jul 12, 3:38 PM
apol committed R32:b0d98306e30c: Fix the parser test run (authored by apol).
Fix the parser test run
Wed, Jul 12, 3:38 PM
apol committed R32:0552ff770efa: Use the executable path offered by the cmake server (authored by apol).
Use the executable path offered by the cmake server
Wed, Jul 12, 12:57 PM
apol committed R134:f440cf983b1a: Last merge was broken (authored by apol).
Last merge was broken
Wed, Jul 12, 12:08 AM
apol committed R134:5fc06043c226: Merge branch 'Plasma/5.10' (authored by apol).
Merge branch 'Plasma/5.10'
Wed, Jul 12, 12:02 AM

Tue, Jul 11

apol committed R134:33805b2deda1: Fix launching of resources for PackageKit and Flatpak (authored by apol).
Fix launching of resources for PackageKit and Flatpak
Tue, Jul 11, 11:54 PM
apol committed R256:ac229f785622: Fix KReversi (authored by apol).
Fix KReversi
Tue, Jul 11, 10:55 PM
apol committed R256:166fd73a1f4c: Disable Discover SnapBackend build, the new library doesn't work (authored by apol).
Disable Discover SnapBackend build, the new library doesn't work
Tue, Jul 11, 10:55 PM
apol committed R256:575ae6f6ab50: Fix kgoldrunner (authored by apol).
Fix kgoldrunner
Tue, Jul 11, 10:55 PM
apol committed R256:c09bdb57174c: Build krita from master (authored by apol).
Build krita from master
Tue, Jul 11, 6:33 PM
apol committed R256:28a669997023: Fix Kube dependencies (authored by apol).
Fix Kube dependencies
Tue, Jul 11, 6:33 PM
apol committed R256:64cf5d91c6ca: Use dependencies from the platform (authored by apol).
Use dependencies from the platform
Tue, Jul 11, 5:51 PM
apol committed R134:ce54589cc393: Don't change the title of the Installed section (authored by apol).
Don't change the title of the Installed section
Tue, Jul 11, 4:03 PM
apol committed R134:33000d5409e5: Make sure the UpdateModel is initialized after switching the view (authored by apol).
Make sure the UpdateModel is initialized after switching the view
Tue, Jul 11, 3:52 PM
apol committed R134:65cbbbe6c9ec: Remove unused code (authored by apol).
Remove unused code
Tue, Jul 11, 3:27 PM
apol accepted D6593: Remove messages of already running CTests for UnitTests.
Tue, Jul 11, 12:46 AM

Mon, Jul 10

apol added inline comments to D6089: Show no notification icon if there is no.
Mon, Jul 10, 10:09 PM · KDE Connect
apol committed R134:53651467b98a: Don't show the drawer immediately when on compact mode (authored by apol).
Don't show the drawer immediately when on compact mode
Mon, Jul 10, 5:59 PM
apol committed R134:218aff459791: Don't reset the menu unless there's something to change (authored by apol).
Don't reset the menu unless there's something to change
Mon, Jul 10, 5:59 PM
apol committed R134:dd49191c6f0b: Remove unused file (authored by apol).
Remove unused file
Mon, Jul 10, 5:59 PM
apol committed R134:e3eb4dd77df2: Use "reviews" rather than "comments" for consistency (authored by apol).
Use "reviews" rather than "comments" for consistency
Mon, Jul 10, 3:46 PM
apol committed R257:ec3c0fc5e906: Ugh json array comas... (authored by apol).
Ugh json array comas...
Mon, Jul 10, 2:30 PM
apol committed R257:83b1e24cc19f: Don't expect others to define our extensions (authored by apol).
Don't expect others to define our extensions
Mon, Jul 10, 2:25 PM
apol accepted D6610: don't override paddings.

Thanks!

Mon, Jul 10, 2:18 PM · Plasma
apol committed R134:ed6f66ec001a: Fix qml module versioning (authored by apol).
Fix qml module versioning
Mon, Jul 10, 2:07 PM
apol committed R134:cc28a65b6335: Don't show the progress view if there's nothing to show (authored by apol).
Don't show the progress view if there's nothing to show
Mon, Jul 10, 11:08 AM
apol committed R134:c9c3b71245d3: Use the right API (authored by apol).
Use the right API
Mon, Jul 10, 10:50 AM
apol committed R134:43573ccded06: Forgot to commit AppStreamUtils.h (authored by apol).
Forgot to commit AppStreamUtils.h
Mon, Jul 10, 10:48 AM
apol committed R134:a1ddd8aa2428: Make sure we never use the local plugin instead (authored by apol).
Make sure we never use the local plugin instead
Mon, Jul 10, 10:45 AM
apol committed R134:bc937a1868d0: Set icon's size so the proper size is chosen (authored by apol).
Set icon's size so the proper size is chosen
Mon, Jul 10, 10:25 AM
apol committed R134:5cbcb4ca31d6: flatpak: Reduce path puzzles and duplicated code (authored by apol).
flatpak: Reduce path puzzles and duplicated code
Mon, Jul 10, 10:25 AM
apol committed R134:47d6d14364ec: Share appstream screenshots code (authored by apol).
Share appstream screenshots code
Mon, Jul 10, 10:25 AM
apol committed R134:b53ad168a589: Properly convert from QString to char* (authored by apol).
Properly convert from QString to char*
Mon, Jul 10, 10:25 AM
apol accepted D6599: elisa needs pulseaudio socket and access to opengl.
Mon, Jul 10, 10:10 AM
apol added a comment to D6593: Remove messages of already running CTests for UnitTests.

Other than that, LGTM. I'm not sure why you need to go through the job list again, but it's not a big penalty so if that's what makes it stable, let's go for it.

Mon, Jul 10, 10:07 AM
apol committed R256:58ef2b03ddf1: Update KF5 version (authored by apol).
Update KF5 version
Mon, Jul 10, 1:09 AM
apol committed R257:1268c890e194: Update KF5 version (authored by apol).
Update KF5 version
Mon, Jul 10, 1:09 AM
apol committed R257:891281a1b95b: Improve extension declaration (authored by apol).
Improve extension declaration
Mon, Jul 10, 1:09 AM

Fri, Jul 7

apol committed R852:89e87a179f40: Install icons so it can be used by AppStream (authored by apol).
Install icons so it can be used by AppStream
Fri, Jul 7, 5:27 PM
apol committed R255:0910d0713802: Install elisa icon with the application (authored by apol).
Install elisa icon with the application
Fri, Jul 7, 4:40 PM
apol committed R256:141cf36210fb: Actually include babe (authored by apol).
Actually include babe
Fri, Jul 7, 4:32 PM
apol committed R256:2849ba6a04f5: Enable elisa nightlies (authored by apol).
Enable elisa nightlies
Fri, Jul 7, 4:30 PM
apol committed R256:d525bad9a98d: Babe builds now (authored by apol).
Babe builds now
Fri, Jul 7, 4:30 PM
apol added a comment to D6553: Standard shortcuts: use Ctrl+PageUp/PageDown for prev/next tab..

Just to be sure, does it touch all applications which uses tabs (like Okular)?

Fri, Jul 7, 3:43 PM · Frameworks
apol committed R304:2e8756d2d50b: When requesting from the cache, report all entries at bulk (authored by apol).
When requesting from the cache, report all entries at bulk
Fri, Jul 7, 3:35 PM
apol closed D6532: When requesting from the cache, report all entries at bulk.
Fri, Jul 7, 3:33 PM · Frameworks
apol added a comment to D6553: Standard shortcuts: use Ctrl+PageUp/PageDown for prev/next tab..

+1, this has annoyed me in the past.

Fri, Jul 7, 3:32 PM · Frameworks
apol committed R224:29888cb78be5: Improve debug information (authored by apol).
Improve debug information
Fri, Jul 7, 3:27 PM
apol accepted D6466: Android: scan for qml files in the source dir, not in the install dir..
In D6466#121152, @apol wrote:

This will be problematic as soon as your application depends on any libraries.

You mean, libraries which themselves have installed QML files, right? Depending on e.g. ki18n is no problem.

But yeah I can see how this would be a problem for something that depends on kirigami for instance.

If we can't find a better solution, then at least it should be documented in the ECM android stuff to NOT put qml files into a .qrc...

Fri, Jul 7, 1:11 PM · Build System, Frameworks
apol added a comment to D6549: Look for QtGraphicalEffects, so packagers don't forget it.

Probably should go to ECM instead of being copy pasted.

Fri, Jul 7, 11:20 AM · Kirigami
apol created D6549: Look for QtGraphicalEffects, so packagers don't forget it.
Fri, Jul 7, 11:07 AM · Kirigami
apol committed R32:2f051f80afb1: Remove a bunch of unused cmake code, bring back a couple of tests (authored by apol).
Remove a bunch of unused cmake code, bring back a couple of tests
Fri, Jul 7, 1:36 AM

Thu, Jul 6

apol accepted D6538: CMake: Use 'subdirs' function in importTestSuites.
Thu, Jul 6, 9:01 PM
l10n daemon script <scripty@kde.org> committed R249:cbac122b11ec: Make sure that the tsfiles target is generated (authored by apol).
Make sure that the tsfiles target is generated
Thu, Jul 6, 7:18 PM