apol (Aleix Pol Gonzalez)
User

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 27 2015, 12:34 PM (156 w, 1 d)
Availability
Available

Recent Activity

Yesterday

apol committed R857:831803d2f38f: Android: Properly pass arguments to the application git clone (authored by apol).
Android: Properly pass arguments to the application git clone
Tue, Apr 24, 8:39 PM
apol committed R659:88e8d88ce8f4: Include AppStream information (authored by apol).
Include AppStream information
Tue, Apr 24, 7:19 PM
apol committed R857:33fc9240565a: Android: Include missing script (authored by apol).
Android: Include missing script
Tue, Apr 24, 4:40 PM
apol committed R7:9a40c27e28c8: Include AndroidManifest.xml (authored by apol).
Include AndroidManifest.xml
Tue, Apr 24, 4:35 PM
apol committed R7:93051ec03a75: Make it possible to use qrc when building locally (authored by apol).
Make it possible to use qrc when building locally
Tue, Apr 24, 4:35 PM
apol committed R108:6e84645e355a: Reparse the input configuration when we are notified that it changed (authored by apol).
Reparse the input configuration when we are notified that it changed
Tue, Apr 24, 2:41 PM
apol committed R108:4403e86acc8c: Don't try to filter null key combinations (authored by apol).
Don't try to filter null key combinations
Tue, Apr 24, 2:24 PM
apol closed D12416: Don't try to filter null key combinations.
Tue, Apr 24, 2:24 PM · KWin
apol committed R993:225200e8e9fd: Add quotes around env var (authored by apol).
Add quotes around env var
Tue, Apr 24, 9:14 AM
apol committed R993:b535a92b0e4a: Android: Try setting environment variables in a different way (authored by apol).
Android: Try setting environment variables in a different way
Tue, Apr 24, 9:06 AM
apol committed R993:1859cfd774b2: Revert "Android: Fix konvi2x build" (authored by apol).
Revert "Android: Fix konvi2x build"
Tue, Apr 24, 9:06 AM
apol added a reverting change for R993:c2308f6b6252: Android: Fix konvi2x build: R993:1859cfd774b2: Revert "Android: Fix konvi2x build".
Tue, Apr 24, 9:06 AM

Mon, Apr 23

apol updated the diff for D5961: PoC: Generic adoption of KUserFeedback for Discover.

adapt

Mon, Apr 23, 5:22 PM · Plasma
apol committed R993:c2308f6b6252: Android: Fix konvi2x build (authored by apol).
Android: Fix konvi2x build
Mon, Apr 23, 3:19 PM
apol updated the diff for D5961: PoC: Generic adoption of KUserFeedback for Discover.

Rebase to master

Mon, Apr 23, 2:20 PM · Plasma
apol updated the diff for D12416: Don't try to filter null key combinations.

Add test

Mon, Apr 23, 2:08 PM · KWin
apol added a comment to T8281: Make runcommand great again.

What do you think about introducing hooks that commands could be connected to? E.g. run foo on device connected/disconnected. Or connect commands to DBus signals.

Mon, Apr 23, 12:44 PM · KDE Connect
apol added a comment to T8281: Make runcommand great again.
  • Make it more discoverable
  • Integrate with KNS/Discover

decided against this one.

Mon, Apr 23, 12:14 PM · KDE Connect
apol committed R134:ff6f7b86a94c: Improve display of Progress element (authored by apol).
Improve display of Progress element
Mon, Apr 23, 11:09 AM

Sun, Apr 22

apol committed R223:2648ad7b7389: Correctly list the supported file suffixes (authored by apol).
Correctly list the supported file suffixes
Sun, Apr 22, 9:01 PM
apol committed R223:077d0219fe79: Did not meant to commit that (authored by apol).
Did not meant to commit that
Sun, Apr 22, 9:01 PM
apol committed R223:1fb77446a737: Make it possible to disable the build of okularkirigami (authored by apol).
Make it possible to disable the build of okularkirigami
Sun, Apr 22, 8:23 PM
apol closed D12352: Make it possible to disable the build of okularkirigami.
Sun, Apr 22, 8:23 PM · Okular
apol updated the summary of D12416: Don't try to filter null key combinations.
Sun, Apr 22, 5:36 PM · KWin
apol committed R284:fbb5609001ab: Fix KCompletionBox on wayland (authored by apol).
Fix KCompletionBox on wayland
Sun, Apr 22, 5:35 PM
apol closed D12448: Fix KCompletionBox on wayland.
Sun, Apr 22, 5:35 PM · Frameworks
apol added a comment to D12448: Fix KCompletionBox on wayland.

Why not

static const auto flags = qGuiApp->platformName() == QLatin1String("wayland") ? Qt::WindowFlags(Qt::ToolTip | Qt::FramelessWindowHint | Qt::BypassWindowManagerHint) :
                                                                                Qt::WindowFlags(Qt::Window | Qt::FramelessWindowHint | Qt::BypassWindowManagerHint);
q->setWindowFlags(flags);

It's not need to check in every completion construction.

Sun, Apr 22, 5:35 PM · Frameworks
apol committed R993:d64e449152f0: Android. Have konversation wip/qtquick branch built into an apk (authored by apol).
Android. Have konversation wip/qtquick branch built into an apk
Sun, Apr 22, 5:31 PM
apol committed R857:f54554c737ac: Android: build-standalone error handling (authored by apol).
Android: build-standalone error handling
Sun, Apr 22, 5:26 PM
apol committed R857:775e99806dbc: Android: allow to request a special branch when building an app (authored by apol).
Android: allow to request a special branch when building an app
Sun, Apr 22, 5:26 PM
apol committed R7:9dc539dd3d3b: Have konvi2x compile against Android (authored by apol).
Have konvi2x compile against Android
Sun, Apr 22, 5:18 PM
apol closed D12453: Have konvi2x compile against Android.
Sun, Apr 22, 5:18 PM
apol requested review of D12453: Have konvi2x compile against Android.
Sun, Apr 22, 5:05 PM
apol committed R7:6bdba46a4389: Android: fix build (authored by apol).
Android: fix build
Sun, Apr 22, 4:59 PM
apol requested review of D12448: Fix KCompletionBox on wayland.
Sun, Apr 22, 2:20 PM · Frameworks
apol committed R993:3ca82d8a3cb6: Android: Force okular to link against poppler (authored by apol).
Android: Force okular to link against poppler
Sun, Apr 22, 2:03 PM
apol accepted D12331: Always use the clang builtin headers for the libclang version we use.

Fair enough.
It's working for me anyway, I'd say land this, we land my other patch, then we see how we proceed. Makes sense?

Sun, Apr 22, 9:53 AM

Sat, Apr 21

apol added a reviewer for D12416: Don't try to filter null key combinations: KWin.
Sat, Apr 21, 4:37 PM · KWin
apol updated the summary of D12416: Don't try to filter null key combinations.
Sat, Apr 21, 4:37 PM · KWin
apol updated the diff for D12416: Don't try to filter null key combinations.

Don't try to filter null key combinations

Sat, Apr 21, 4:36 PM · KWin
apol requested review of D12416: Don't try to filter null key combinations.
Sat, Apr 21, 4:36 PM · KWin
apol committed R857:46c3b1427296: Android: Backport verbosity patch (authored by apol).
Android: Backport verbosity patch
Sat, Apr 21, 2:59 PM
apol committed R857:8e7895320781: Android: Make /opt writable (authored by apol).
Android: Make /opt writable
Sat, Apr 21, 2:59 PM
apol committed R162:082c0f506987: I updated gpgme.json on flatpak-kde-applications, probably applies here too (authored by apol).
I updated gpgme.json on flatpak-kde-applications, probably applies here too
Sat, Apr 21, 2:14 PM
apol committed R162:6d671661e47f: I updated gpgme.json on flatpak-kde-applications, probably applies here too (authored by apol).
I updated gpgme.json on flatpak-kde-applications, probably applies here too
Sat, Apr 21, 2:14 PM
apol closed D12367: I updated gpgme.json on flatpak-kde-applications, probably applies here too.
Sat, Apr 21, 2:14 PM
apol committed R256:d8f5560c4884: Fix weird typo (authored by apol).
Fix weird typo
Sat, Apr 21, 2:14 PM
apol updated the diff for D12367: I updated gpgme.json on flatpak-kde-applications, probably applies here too.

oops

Sat, Apr 21, 2:14 PM
apol abandoned D12411: I updated gpgme.json on flatpak-kde-applications, probably applies here too.
Sat, Apr 21, 2:13 PM
apol requested review of D12411: I updated gpgme.json on flatpak-kde-applications, probably applies here too.
Sat, Apr 21, 2:11 PM
apol added a comment to D12367: I updated gpgme.json on flatpak-kde-applications, probably applies here too.

Assuming setting the sha256 to a name is a thing now?

Thanks for the patch!

Sat, Apr 21, 2:10 PM

Fri, Apr 20

apol added a reverting change for R857:2baa5c2b6e71: Android: Backport verbosity patch to androiddeployqt: R857:d0beb8dd4d83: Revert "Android: Backport verbosity patch to androiddeployqt".
Fri, Apr 20, 4:02 PM
apol committed R857:d0beb8dd4d83: Revert "Android: Backport verbosity patch to androiddeployqt" (authored by apol).
Revert "Android: Backport verbosity patch to androiddeployqt"
Fri, Apr 20, 4:02 PM
apol committed R899:753b88e4f5ac: Only link against kirigami if we are using the local kirigami clone (authored by apol).
Only link against kirigami if we are using the local kirigami clone
Fri, Apr 20, 3:05 PM
apol closed D12382: Only link against kirigami if we are using the local kirigami clone.
Fri, Apr 20, 3:04 PM
apol requested review of D12382: Only link against kirigami if we are using the local kirigami clone.
Fri, Apr 20, 2:42 PM
apol committed R857:2940359c7f3c: Android: Include build-poppler script in the image (authored by apol).
Android: Include build-poppler script in the image
Fri, Apr 20, 2:41 PM
apol committed R857:2baa5c2b6e71: Android: Backport verbosity patch to androiddeployqt (authored by apol).
Android: Backport verbosity patch to androiddeployqt
Fri, Apr 20, 2:41 PM
apol requested changes to D12371: fix always reproducible crash.

^^' this won't work though. If the object gets deleted you will get a null pointer in the list.

Fri, Apr 20, 12:35 PM · Frameworks
apol accepted D12370: Move gnome integration plugins back to runtime repo.
Fri, Apr 20, 9:29 AM
apol added inline comments to D12371: fix always reproducible crash.
Fri, Apr 20, 9:27 AM · Frameworks
apol committed R256:3077451f7cc5: Update eigen, boost and openal (authored by apol).
Update eigen, boost and openal
Fri, Apr 20, 12:37 AM
apol committed R256:c3ecb20439d7: Update GPG components versions (authored by apol).
Update GPG components versions
Fri, Apr 20, 12:37 AM
apol requested review of D12367: I updated gpgme.json on flatpak-kde-applications, probably applies here too.
Fri, Apr 20, 12:29 AM

Thu, Apr 19

apol committed R993:a337ef36734a: Android: Specify empty dependency fields so they don't translate to "null" (authored by apol).
Android: Specify empty dependency fields so they don't translate to "null"
Thu, Apr 19, 11:56 PM
apol closed D12366: Android: Specify empty dependency fields so they don't translate to "null".
Thu, Apr 19, 11:56 PM
apol added a comment to D12331: Always use the clang builtin headers for the libclang version we use.
  • what compiler is used?

I'm using clang for all my projects.

Thu, Apr 19, 11:37 PM
apol requested review of D12366: Android: Specify empty dependency fields so they don't translate to "null".
Thu, Apr 19, 11:23 PM
apol updated the diff for D12352: Make it possible to disable the build of okularkirigami.

Improve description

Thu, Apr 19, 11:00 PM · Okular
apol added a comment to T7205: create call for locations for Akademy 2019.

Here's an etherpad with @valorie's text and @derkits corrections: https://notes.kde.org/p/akademy-2019-callforlocations

Thu, Apr 19, 10:47 PM · KDE e.V., Akademy
apol committed R495:8ff96619cab8: Make sure we give some vertical space to configuration plugins (authored by apol).
Make sure we give some vertical space to configuration plugins
Thu, Apr 19, 4:46 PM
apol committed R495:f2c776a68813: Readability (authored by apol).
Readability
Thu, Apr 19, 4:46 PM
apol committed R495:fd4f5dc800a4: Port KDEConnect plugin config to QQC2 (authored by apol).
Port KDEConnect plugin config to QQC2
Thu, Apr 19, 4:46 PM
apol committed R495:87eaf5cc1c54: Port AlternativesView to QQC2 (authored by apol).
Port AlternativesView to QQC2
Thu, Apr 19, 4:46 PM
apol committed R114:1d6d94de66b7: Merge branch 'Plasma/5.12' (authored by apol).
Merge branch 'Plasma/5.12'
Thu, Apr 19, 3:00 PM
apol committed R114:45a25f05ad3e: Fix run-time warnings on quick-share (authored by apol).
Fix run-time warnings on quick-share
Thu, Apr 19, 3:00 PM
apol requested review of D12352: Make it possible to disable the build of okularkirigami.
Thu, Apr 19, 2:38 PM · Okular
apol committed R307:e7f6a6c547a4: Fix PersonSortFilterProxyModel filtering (authored by apol).
Fix PersonSortFilterProxyModel filtering
Thu, Apr 19, 2:35 PM
apol committed R307:c277548fb9d7: Use QVector for internal data types (authored by apol).
Use QVector for internal data types
Thu, Apr 19, 2:35 PM
apol added a comment to D12331: Always use the clang builtin headers for the libclang version we use.

It broke my system... It's looking for all classes in my projects into std::, failing and complaining about it. :'(

Thu, Apr 19, 2:13 PM
apol committed R899:3bbe95d31e31: Fix fresh android build (authored by apol).
Fix fresh android build
Thu, Apr 19, 12:53 PM
apol committed R899:c74eeceb54bf: Add .arcconfig for easier phabricator integration (authored by apol).
Add .arcconfig for easier phabricator integration
Thu, Apr 19, 11:29 AM
apol committed R993:81bebfc12107: Add .arcconfig file to integrate to phabricator (authored by apol).
Add .arcconfig file to integrate to phabricator
Thu, Apr 19, 11:09 AM
apol committed R993:1a8500d62836: Make it possible for pipelines to include a dependency (authored by apol).
Make it possible for pipelines to include a dependency
Thu, Apr 19, 11:09 AM
apol closed D12304: Make it possible for pipelines to include a dependency.
Thu, Apr 19, 11:09 AM
apol added a comment to D12331: Always use the clang builtin headers for the libclang version we use.

+1 from my side, I'm running it locally, didn't really have problems earlier don't seem to have them now. Will get back on the Android work and see how it works there soonish, but it's no reason to stop this patch, especially if it fixes bugs.

Thu, Apr 19, 11:03 AM
apol committed R224:dd031d3debaf: Show the KCM with the run commands open when a setup packet is received (authored by apol).
Show the KCM with the run commands open when a setup packet is received
Thu, Apr 19, 1:04 AM
apol closed D11684: Show the KCM with the run commands open when a setup packet is received.
Thu, Apr 19, 1:04 AM · KDE Connect
apol updated the diff for D11684: Show the KCM with the run commands open when a setup packet is received.

Included Nico's patch

Thu, Apr 19, 12:31 AM · KDE Connect
apol added a comment to D12251: Integrate with androiddeployqt dependencies files.

I don't really see why we need a special path for parts.

Thu, Apr 19, 12:27 AM · Frameworks

Wed, Apr 18

apol requested changes to D11854: (WIP) Upgrade Telephony plugin to read SMS history (KDE side).
Wed, Apr 18, 11:20 PM · KDE Connect
apol committed R223:77049d3b80c2: Android: include metadata for okular kirigami (authored by apol).
Android: include metadata for okular kirigami
Wed, Apr 18, 11:06 PM
apol closed D12299: Android: include metadata for okular kirigami.
Wed, Apr 18, 11:06 PM · Okular
apol accepted D9691: Add contacts-reading plugin (KDE side).
Wed, Apr 18, 10:44 PM · KDE Connect
apol added a comment to D9691: Add contacts-reading plugin (KDE side).

Patch looks good to me, I'd say let's merge it so we can start testing.

Wed, Apr 18, 10:44 PM · KDE Connect
apol added a comment to D11136: Make sure we use the same compiler settings as the project is by default.

see also: https://bugs.kde.org/show_bug.cgi?id=387005

In that bug report we (presumably) get bitten by clang-5.0 (which is used for parsing) failing to understand clang-3.8 system headers (autodetected compiler).
I second @aaronpuchert - it would be better to remove support for other compilers than the one that is actually used for parsing.

Wed, Apr 18, 12:35 PM
apol added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.

Hey, looking into it, context.h doesn't include pulse/volume.h.

Wed, Apr 18, 12:31 PM · Plasma, KDE Connect, Frameworks
apol updated the diff for D12304: Make it possible for pipelines to include a dependency.

Address Ben's comment

Wed, Apr 18, 12:18 PM
apol committed R857:38d40dac49a8: Android: Include helper scripts to build common dependencies (authored by apol).
Android: Include helper scripts to build common dependencies
Wed, Apr 18, 11:57 AM
apol updated the diff for D12251: Integrate with androiddeployqt dependencies files.

Don't generate the xml file in the sources dir

Wed, Apr 18, 11:56 AM · Frameworks