apol (Aleix Pol Gonzalez)
User

Projects (8)

User Details

User Since
Apr 27 2015, 12:34 PM (99 w, 5 d)

Recent Activity

Today

apol committed R256:780cc3973d9c: Rename unnecessary (authored by apol).
Rename unnecessary
Sat, Mar 25, 1:53 AM

Yesterday

apol added a comment to D5143: Introduce fetch-translations build command.

See https://phabricator.kde.org/D5167, with this all mentioned issues should be fixed.

Fri, Mar 24, 8:28 PM · Build System, Frameworks
apol updated the diff for D5143: Introduce fetch-translations build command.

prefer trunk translations branch

Fri, Mar 24, 8:25 PM · Build System, Frameworks
apol committed R256:7c25af04514a: Include labplot2 (authored by apol).
Include labplot2
Fri, Mar 24, 6:45 PM
apol added a comment to D5166: introduce ApplicationItem.

Shouldn't we make the ApplicationWindow use the ApplicationItem instead of fully forking the code?

Fri, Mar 24, 6:36 PM · Kirigami
apol added a comment to D5129: QtWebKit documentation regression fixes.

Thanks!

Fri, Mar 24, 6:22 PM
apol added a reviewer for D5167: Move .po and .ts files look-up to build-time: ilic.
Fri, Mar 24, 6:10 PM · Frameworks
apol created D5167: Move .po and .ts files look-up to build-time.
Fri, Mar 24, 6:08 PM · Frameworks
apol accepted D5163: Include kqtquickcharts in KTouch manifiest.
Fri, Mar 24, 12:48 PM

Thu, Mar 23

apol added a comment to D5159: Remove unused Qt::WindowFlags parameters from internal API.
In D5159#97239, @kfunk wrote:

I know why you did that! ;)

Thu, Mar 23, 11:23 PM
apol added inline comments to D5162: Port custom image mode to IconItem..
Thu, Mar 23, 11:21 PM · Plasma
apol updated the diff for D5143: Introduce fetch-translations build command.

Add documentation

Thu, Mar 23, 1:58 PM · Build System, Frameworks
apol added a comment to D5143: Introduce fetch-translations build command.

will send another review with the documentation

Thu, Mar 23, 1:55 PM · Build System, Frameworks
apol committed R32:321498c96478: Use proper naming, this was refactored at some point (authored by apol).
Use proper naming, this was refactored at some point
Thu, Mar 23, 1:06 PM
apol committed R32:4997f8a38577: Adapt to changes in the codemodel (authored by apol).
Adapt to changes in the codemodel
Thu, Mar 23, 1:06 PM
apol accepted D5146: Implement UI feedback for long-running searches, and no-results.

LGTM.

Thu, Mar 23, 12:34 PM · Plasma, Discover Software Store
apol accepted D5081: Add explicit cast to fix build with gcc-4.8.
Thu, Mar 23, 12:33 PM
apol accepted D5148: Use the back function, rather than pop, when pressing Escape.
Thu, Mar 23, 12:32 PM · Plasma, Discover Software Store
apol accepted D5147: Mark "all categories missing" kns sources as invalid.
Thu, Mar 23, 12:32 PM · Plasma, Discover Software Store
apol added inline comments to D5147: Mark "all categories missing" kns sources as invalid.
Thu, Mar 23, 12:32 PM · Plasma, Discover Software Store
apol requested changes to D5149: Cache screenshots to avoid downloading them over and over.
Thu, Mar 23, 12:08 PM · Plasma
apol added a comment to D5149: Cache screenshots to avoid downloading them over and over.

Please try using QNetworkDiskCache.

Thu, Mar 23, 12:08 PM · Plasma
apol added inline comments to D5081: Add explicit cast to fix build with gcc-4.8.
Thu, Mar 23, 11:39 AM
apol closed T3290: Implementation of Jens design as "Resolved".
Thu, Mar 23, 1:40 AM · Discover Software Store
apol closed T2178: make default property of Page contentData nd be a list as "Resolved".
Thu, Mar 23, 1:39 AM · Kirigami
apol closed T2057: Discover: integrate store.kde.org as "Resolved".
Thu, Mar 23, 1:39 AM · Plasma
apol closed T2058: Discover: move mobile to Kirigami as "Resolved".
Thu, Mar 23, 1:39 AM · Plasma
apol closed T537: Keyboard Sharing as "Resolved".
Thu, Mar 23, 1:38 AM · Plasma: Mobile

Wed, Mar 22

apol abandoned D5136: Introduce fetch-translations build command.

On ECM https://phabricator.kde.org/D5143

Wed, Mar 22, 11:25 PM · Frameworks
apol created D5143: Introduce fetch-translations build command.
Wed, Mar 22, 11:25 PM · Build System, Frameworks
apol added a comment to D5136: Introduce fetch-translations build command.
In D5136#96878, @aacid wrote:

I'm not sure addign a dependency for releaseme in ki18n is a good idea to be honest.

This very "only works for KDE-based applications", a third-party using k18n has no interest in this at all.

Maybe it would make more sense in some of the *KDE* files ECM has?

Wed, Mar 22, 10:57 PM · Frameworks
apol updated the diff for D5136: Introduce fetch-translations build command.

Address some issues

Wed, Mar 22, 9:35 PM · Frameworks
apol committed R572:474c8704ce76: Introduce fetchpo.rb (authored by apol).
Introduce fetchpo.rb
Wed, Mar 22, 6:55 PM
apol closed D5133: Introduce fetchpo.rb by committing R572:474c8704ce76: Introduce fetchpo.rb.
Wed, Mar 22, 6:55 PM
apol added a dependency for D5136: Introduce fetch-translations build command: D5133: Introduce fetchpo.rb.

FWIW, depends on D5133

Wed, Mar 22, 6:54 PM · Frameworks
apol added a dependent revision for D5133: Introduce fetchpo.rb: D5136: Introduce fetch-translations build command.
Wed, Mar 22, 6:54 PM
apol created D5136: Introduce fetch-translations build command.
Wed, Mar 22, 6:53 PM · Frameworks
apol updated the diff for D5133: Introduce fetchpo.rb.

Address issue, use git.kde.org repo name as identifier

Wed, Mar 22, 6:26 PM
apol updated the diff for D5133: Introduce fetchpo.rb.

Address sitter concerns

Wed, Mar 22, 5:38 PM
apol created D5133: Introduce fetchpo.rb.
Wed, Mar 22, 4:13 PM
apol committed R257:257d5c9a47a9: Test settings from ArchLinux ARM (authored by apol).
Test settings from ArchLinux ARM
Wed, Mar 22, 1:34 AM
apol added a comment to D5088: Generate plugins.qmltypes files for the plugins we install.

Ping

Wed, Mar 22, 12:52 AM · Frameworks, Plasma
apol added a comment to D5087: Introduce ecm_generate_qmltypes.

Ping

Wed, Mar 22, 12:52 AM · Build System, Frameworks

Tue, Mar 21

apol added a comment to D5125: Fix compile warnings with clang.

First time I see the code, but the changes look sound.
+1

Tue, Mar 21, 11:47 PM
apol added a comment to D5123: Try to fix call to KXMLGuiWindow::setupGUI.

I get this with your patch:

Tue, Mar 21, 11:43 PM
apol committed R32:ae72650d213e: This dependency isn't needed (authored by apol).
This dependency isn't needed
Tue, Mar 21, 11:23 PM
apol committed R33:cae0ae82d1af: Merge remote-tracking branch 'origin/5.1' (authored by apol).
Merge remote-tracking branch 'origin/5.1'
Tue, Mar 21, 10:45 PM
apol committed R32:f976448f66ec: Merge remote-tracking branch 'origin/5.1' (authored by apol).
Merge remote-tracking branch 'origin/5.1'
Tue, Mar 21, 10:44 PM
apol committed R33:e94438f3a773: Fix debug message (authored by apol).
Fix debug message
Tue, Mar 21, 10:36 PM
apol added a comment to D5123: Try to fix call to KXMLGuiWindow::setupGUI.

Have you tried removing the cached rc files you might have in .local? It's working properly here, I doubt it's a problem in the code...

Tue, Mar 21, 10:32 PM
apol committed R33:2486228ccee2: Port away from QtWebKit to QtWebEngine (authored by apol).
Port away from QtWebKit to QtWebEngine
Tue, Mar 21, 10:27 PM
apol closed D5041: Port away from QtWebKit to QtWebEngine by committing R33:2486228ccee2: Port away from QtWebKit to QtWebEngine.
Tue, Mar 21, 10:27 PM
apol committed R32:8a1536caf85f: Port away from QtWebKit into QtWebEngine (authored by apol).
Port away from QtWebKit into QtWebEngine
Tue, Mar 21, 10:27 PM
apol closed D5042: Port away from QtWebKit into QtWebEngine by committing R32:8a1536caf85f: Port away from QtWebKit into QtWebEngine.
Tue, Mar 21, 10:27 PM
apol committed R257:3ee6e7382749: The option reduce-relocations is not supported on ARM (authored by apol).
The option reduce-relocations is not supported on ARM
Tue, Mar 21, 10:10 PM
apol updated the diff for D5041: Port away from QtWebKit to QtWebEngine.

Fallback to qtwebkit if there's no qtwebengine

Tue, Mar 21, 2:26 PM
apol committed R257:bb850aec8353: freedesktop 1.6 isn't available yet for arm (authored by apol).
freedesktop 1.6 isn't available yet for arm
Tue, Mar 21, 1:18 PM

Mon, Mar 20

apol added a comment to D5041: Port away from QtWebKit to QtWebEngine.

@mwolff I think it's fine like this, I wouldn't want people compiling against qtwebkit because they forgot to pull a dependency, it should be a conscious decision.

Mon, Mar 20, 11:26 PM
apol committed R256:9b351d1e7224: discover is not yet ready (authored by apol).
discover is not yet ready
Mon, Mar 20, 6:34 PM
apol committed R256:45e1e03e0e0d: Add missing kde edu applications (authored by apol).
Add missing kde edu applications
Mon, Mar 20, 5:51 PM
apol committed R256:c496ff202d01: Desist on getting in pkqt (authored by apol).
Desist on getting in pkqt
Mon, Mar 20, 5:51 PM
apol committed R256:2d759a0d6019: Include the flatpakrepo file (authored by apol).
Include the flatpakrepo file
Mon, Mar 20, 4:02 PM
apol added a comment to D5088: Generate plugins.qmltypes files for the plugins we install.

I'm confused.

If you're generating the qmltypes with the ecm command, why are they in the diff?

Mon, Mar 20, 11:53 AM · Frameworks, Plasma
apol updated the diff for D5041: Port away from QtWebKit to QtWebEngine.

Leave the code that workarounds integration issues in QtWebKit

Mon, Mar 20, 11:43 AM
apol updated the diff for D5042: Port away from QtWebKit into QtWebEngine.

adapt to changes in kdevplatform, abstracted webkit

Mon, Mar 20, 2:07 AM
apol updated the diff for D5041: Port away from QtWebKit to QtWebEngine.

abstract out the webkit view

Mon, Mar 20, 2:06 AM

Sun, Mar 19

apol committed R256:0f9da8c0d4d0: Added a bunch of applications from kde edu (authored by apol).
Added a bunch of applications from kde edu
Sun, Mar 19, 2:32 AM

Sat, Mar 18

apol added a comment to D5042: Port away from QtWebKit into QtWebEngine.

Then please, let me submit this change and as soon as there's something we can share with Kontact I'll do the port myself.

Sat, Mar 18, 8:35 PM
apol added a comment to M94: Kamoso + Kirigami.

I'm not convinced, I don't think the main page for the application should be the gallery. One opens Kamoso to take pictures, not to browse himself.

Sat, Mar 18, 8:18 PM · VDG, Kirigami
apol added a comment to D4095: Refactor to embrace a cmake server import backend.
In D4095#95855, @kfunk wrote:

Please close this.

Sat, Mar 18, 8:04 PM · KDevelop

Fri, Mar 17

apol committed R134:15d373ca4714: Mark local file resources as installed once the transaction finishes (authored by apol).
Mark local file resources as installed once the transaction finishes
Fri, Mar 17, 6:25 PM
apol added a comment to D5089: KDE compiler settings fail to consider AppleClang.

Maybe it would make sense to use MATCHES? are there any other *Clang*?

Fri, Mar 17, 5:48 PM · Frameworks, Build System
apol updated the diff for D5087: Introduce ecm_generate_qmltypes.

Some adaptions so it works for Plasma Framework too

Fri, Mar 17, 4:52 PM · Build System, Frameworks
apol created D5088: Generate plugins.qmltypes files for the plugins we install.
Fri, Mar 17, 4:51 PM · Frameworks, Plasma
apol created D5087: Introduce ecm_generate_qmltypes.
Fri, Mar 17, 4:22 PM · Build System, Frameworks
apol committed R240:d3feb0a9821c: Improve error messages (authored by apol).
Improve error messages
Fri, Mar 17, 4:20 PM
apol accepted D5084: fix a crash caused by bad disconnects during debug install cancellation.
Fri, Mar 17, 3:02 PM · Plasma
apol accepted D5080: do not add debugger button unless it is meant to be visible.
Fri, Mar 17, 12:20 PM · Plasma

Thu, Mar 16

apol accepted D5071: Remove unused/unneeded includes & forward declarations.

One day we won't have to include each and every class separately... :P

Thu, Mar 16, 6:23 PM
apol committed R495:17e456805c60: Include a plugins.qmltypes file (authored by apol).
Include a plugins.qmltypes file
Thu, Mar 16, 5:33 PM
apol committed R240:c5d92deff245: Specify qml-root-path as the share directory in the prefix (authored by apol).
Specify qml-root-path as the share directory in the prefix
Thu, Mar 16, 2:12 PM
apol closed D5067: Specify qml-root-path as the share directory in the prefix by committing R240:c5d92deff245: Specify qml-root-path as the share directory in the prefix.
Thu, Mar 16, 2:12 PM · Build System, Frameworks
apol committed R134:d99c6e00aac1: Add a review button when there's no page, for now (authored by apol).
Add a review button when there's no page, for now
Thu, Mar 16, 1:49 PM
apol committed R134:c059b7955a43: fix warning (authored by apol).
fix warning
Thu, Mar 16, 1:16 PM
apol committed R134:5093b6df5374: Elide text review title (authored by apol).
Elide text review title
Thu, Mar 16, 1:15 PM
apol committed R134:43d7a8656d99: case-insensitive comparison of appstream ids (authored by apol).
case-insensitive comparison of appstream ids
Thu, Mar 16, 1:03 PM
apol committed R134:38b084e1dd5d: Fix build (authored by apol).
Fix build
Thu, Mar 16, 1:03 PM
apol committed R134:4acd29a52da4: Use units-aware spacing values whenever possible (authored by apol).
Use units-aware spacing values whenever possible
Thu, Mar 16, 1:03 PM
apol committed R134:ca7a7cc0aaad: Fix weird flicker on some ReviewPage instances (authored by apol).
Fix weird flicker on some ReviewPage instances
Thu, Mar 16, 1:03 PM
apol committed R134:16a806029ca8: Let resources announce that they got ratings (authored by apol).
Let resources announce that they got ratings
Thu, Mar 16, 1:03 PM
apol committed R134:e109cd4f0c4b: Fix build (authored by apol).
Fix build
Thu, Mar 16, 1:03 PM
apol committed R134:10958d5e7c44: Don't use split if we can use splitRef (authored by apol).
Don't use split if we can use splitRef
Thu, Mar 16, 1:03 PM
apol committed R169:dbd0e833e801: Increase the margins in ActionButtons (authored by apol).
Increase the margins in ActionButtons
Thu, Mar 16, 12:44 PM
apol closed D5050: Increase the margins in ActionButtons by committing R169:dbd0e833e801: Increase the margins in ActionButtons.
Thu, Mar 16, 12:44 PM · Kirigami
apol updated the diff for D5050: Increase the margins in ActionButtons.

addressed

Thu, Mar 16, 12:41 PM · Kirigami
apol accepted D5046: UI feedback when checking for updates.
Thu, Mar 16, 12:34 PM · Plasma, Discover Software Store
apol added a comment to T1007: Figure out how to set the color of the system bar (i.e. where the notifications and the clock are).

https://bugreports.qt.io/browse/QTBUG-51196
https://github.com/jpnurmi/statusbar

Thu, Mar 16, 3:16 AM · Android
apol committed R323:7576ea7a76c9: Remove unneeded import (authored by apol).
Remove unneeded import
Thu, Mar 16, 3:02 AM
apol committed R323:7e9e8376031f: Make Plotter3DRenderer::renderGL thread-safe (authored by apol).
Make Plotter3DRenderer::renderGL thread-safe
Thu, Mar 16, 3:02 AM
apol committed R325:a91c55f7d347: Make it look proper on my device again (authored by apol).
Make it look proper on my device again
Thu, Mar 16, 3:00 AM