apol (Aleix Pol Gonzalez)
User

Projects (14)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 27 2015, 12:34 PM (172 w, 3 d)
Availability
Available

Recent Activity

Wed, Aug 15

apol committed R256:7edb0e27e7a9: Add missing changes to new KF5 (authored by apol).
Add missing changes to new KF5
Wed, Aug 15, 10:25 AM
apol requested changes to D14807: [AppStream Runner] Also search when there were errors during Pool::load.

Please squash all changes

Wed, Aug 15, 10:08 AM · Plasma
apol requested changes to D14806: [AppStream Runner] Reduce verbosity of log output.

Please squash all changes

Wed, Aug 15, 10:07 AM · Plasma
apol requested changes to D14805: [AppStream Runner] Use categorized logging.

Please squash all changes

Wed, Aug 15, 10:07 AM · Plasma
apol requested changes to D14804: [AppStream Runner] Pass on error message from the library.

Please squash all changes

Wed, Aug 15, 10:07 AM · Plasma
apol added a comment to D14807: [AppStream Runner] Also search when there were errors during Pool::load.

This is outright weird, please send just one patch with the feature and the logging and without the wrong lines.

Wed, Aug 15, 10:07 AM · Plasma
apol accepted D14806: [AppStream Runner] Reduce verbosity of log output.

LGTM, maybe commit once only? xD

Wed, Aug 15, 10:06 AM · Plasma
apol accepted D14805: [AppStream Runner] Use categorized logging.
Wed, Aug 15, 10:06 AM · Plasma
apol accepted D14804: [AppStream Runner] Pass on error message from the library.
Wed, Aug 15, 10:05 AM · Plasma
apol committed R256:a2682d2fb553: Update to latest KF5 release (authored by apol).
Update to latest KF5 release
Wed, Aug 15, 9:54 AM
apol committed R257:3f514192d878: Update to latest stable Plasma release (authored by apol).
Update to latest stable Plasma release
Wed, Aug 15, 9:54 AM
apol committed R257:bc65f484a074: Merge branch 'qt5.9lts' (authored by apol).
Merge branch 'qt5.9lts'
Wed, Aug 15, 9:54 AM
apol committed R257:b3ac70cd80bb: Update to latest KF5 stable release (authored by apol).
Update to latest KF5 stable release
Wed, Aug 15, 9:53 AM

Sun, Aug 12

apol added inline comments to D14568: Fixup the sfos mpris control.
Sun, Aug 12, 9:20 AM · KDE Connect
apol added a comment to D14568: Fixup the sfos mpris control.

LGTM

Sun, Aug 12, 8:40 AM · KDE Connect

Thu, Aug 9

apol added a reviewer for D14710: Inject default environment group variables into debug process environment.: KDevelop.
Thu, Aug 9, 4:47 PM · KDevelop
apol added inline comments to D14710: Inject default environment group variables into debug process environment..
Thu, Aug 9, 4:47 PM · KDevelop
apol committed R499:0e7b1c3ebf9f: Include build metadata for kirigami-gallery (authored by apol).
Include build metadata for kirigami-gallery
Thu, Aug 9, 10:11 AM

Wed, Aug 8

apol committed R257:a49243173e2f: -DCMAKE_INSTALL_LIBDIR=lib shouldn't be needed anymore (authored by apol).
-DCMAKE_INSTALL_LIBDIR=lib shouldn't be needed anymore
Wed, Aug 8, 11:03 PM
apol committed R257:6109ef16781b: Merge branch 'qt5.9lts' (authored by apol).
Merge branch 'qt5.9lts'
Wed, Aug 8, 11:03 PM
apol committed R256:b60629d60703: -DCMAKE_INSTALL_LIBDIR=lib is no longer necessary (authored by apol).
-DCMAKE_INSTALL_LIBDIR=lib is no longer necessary
Wed, Aug 8, 11:01 PM
apol committed R256:7db7aad8df65: kamoso: Give access to the cameras (authored by apol).
kamoso: Give access to the cameras
Wed, Aug 8, 10:49 PM
apol committed R474:232fb3df9979: Merge branch 'Applications/18.08' (authored by apol).
Merge branch 'Applications/18.08'
Wed, Aug 8, 9:31 PM
apol committed R474:a68e65734c78: Fix crash when destroying a surface (authored by apol).
Fix crash when destroying a surface
Wed, Aug 8, 3:42 PM
apol committed R883:1522201: Add Breeze slides template for presentations.
Add Breeze slides template for presentations
Wed, Aug 8, 10:26 AM
apol added a comment to D14162: Figure out the escaped path list on kconfig.

Correct, I wanted to fix all the allocations as the commit message says, then I realised it wasn't even working well when I added the unit test, so I fixed that too.

Wed, Aug 8, 10:11 AM · Frameworks

Tue, Aug 7

apol accepted D14675: cppcheck: pass "-i" & path as separate argument items, not as single string.
Tue, Aug 7, 5:15 PM · KDevelop
apol committed R134:f69eb23d627f: Merge branch 'Plasma/5.12' into Plasma/5.13 (authored by apol).
Merge branch 'Plasma/5.12' into Plasma/5.13
Tue, Aug 7, 4:06 PM
apol committed R134:2155003d054e: PK: wait until we have fetched the packages that dont' come from appstream (authored by apol).
PK: wait until we have fetched the packages that dont' come from appstream
Tue, Aug 7, 4:05 PM
apol committed R134:1ef4447b9e82: Share appstream screenshots code extraction between flatpak and packagekit (authored by apol).
Share appstream screenshots code extraction between flatpak and packagekit
Tue, Aug 7, 3:40 PM
apol committed R134:aeb9e71f4e20: Fwupd: fix compiler warning (authored by apol).
Fwupd: fix compiler warning
Tue, Aug 7, 2:50 PM
apol committed R134:aeacfe2b1182: Fwupd: better variable scope (authored by apol).
Fwupd: better variable scope
Tue, Aug 7, 2:50 PM
apol committed R134:3efdec4a551b: Fwupd: don't return every resource if we don't know about the URL we're given (authored by apol).
Fwupd: don't return every resource if we don't know about the URL we're given
Tue, Aug 7, 2:47 PM
apol added a comment to D14162: Figure out the escaped path list on kconfig.

I don't really understand why we can't just skip the escapes as we go along, as most parsers do, for the sake of efficiency. This is already a state-machine based parser so it should be easy to integrate that in, no?

Tue, Aug 7, 1:02 PM · Frameworks
apol committed R857:c8ea403b0231: Android: make internal build-* variables more verbose (authored by apol).
Android: make internal build-* variables more verbose
Tue, Aug 7, 12:25 PM
apol committed R857:08feb52e8ec9: Android: Forward the androiddeployqt args when we have keys as well (authored by apol).
Android: Forward the androiddeployqt args when we have keys as well
Tue, Aug 7, 12:25 PM

Mon, Aug 6

apol committed R134:4b1c55098170: PK: Improve changelog for appstream applications (authored by apol).
PK: Improve changelog for appstream applications
Mon, Aug 6, 11:38 PM
apol accepted D14657: Fix perforce unittest on Windows CI.
Mon, Aug 6, 10:46 PM · KDevelop
apol committed R249:64796250e69d: Check the build directory for po/ as well (authored by apol).
Check the build directory for po/ as well
Mon, Aug 6, 10:39 PM
apol closed D14572: Check the build directory for po/ as well.
Mon, Aug 6, 10:39 PM · Frameworks
apol accepted D14649: Fwupd-Backend (Fixes).
Mon, Aug 6, 4:04 PM · Plasma, Discover Software Store
apol committed R993:f4353516ae2e: Make sure poppler is included (authored by apol).
Make sure poppler is included
Mon, Aug 6, 3:55 PM
apol committed R240:02881711cfce: Make it possible for ECM to detect po files at configure time (authored by apol).
Make it possible for ECM to detect po files at configure time
Mon, Aug 6, 2:23 PM
apol closed D14569: Make it possible for ECM to detect po files at configure time.
Mon, Aug 6, 2:23 PM · Build System, Frameworks
apol updated the diff for D14569: Make it possible for ECM to detect po files at configure time.

Correct version

Mon, Aug 6, 2:20 PM · Build System, Frameworks
apol updated the diff for D14572: Check the build directory for po/ as well.

Added David's recommended comment

Mon, Aug 6, 2:17 PM · Frameworks
apol committed R304:480f1665b3d5: Cache providerId (authored by apol).
Cache providerId
Mon, Aug 6, 2:06 PM
apol committed R169:0d29657961fa: Fix warning (authored by apol).
Fix warning
Mon, Aug 6, 2:00 PM
apol added inline comments to D14649: Fwupd-Backend (Fixes).
Mon, Aug 6, 1:43 PM · Plasma, Discover Software Store
apol added a comment to D14649: Fwupd-Backend (Fixes).

Reviewing the patch with such menial styling changes becomes to hard, please clean up first.

Mon, Aug 6, 1:34 PM · Plasma, Discover Software Store
apol updated the diff for D14162: Figure out the escaped path list on kconfig.

Addressed issues by David and Anthony

Mon, Aug 6, 12:10 PM · Frameworks
apol added inline comments to D14162: Figure out the escaped path list on kconfig.
Mon, Aug 6, 12:10 PM · Frameworks
apol accepted D14626: Remove qt5_use_modules .
Mon, Aug 6, 11:09 AM · KDE Edu, GCompris
apol accepted D14642: [SMS app] Mask regex special characters in search box.
Mon, Aug 6, 10:54 AM · KDE Connect

Sun, Aug 5

apol committed R857:ab59d2f969eb: ECM should be smart enough to figure out the SDK tools version (authored by apol).
ECM should be smart enough to figure out the SDK tools version
Sun, Aug 5, 11:43 PM

Sat, Aug 4

apol requested changes to D14604: Runner for executing commands on remote device.
Sat, Aug 4, 5:55 PM · KDE Connect

Fri, Aug 3

apol committed R134:2078bb73d9d5: Merge branch 'Plasma/5.13' (authored by apol).
Merge branch 'Plasma/5.13'
Fri, Aug 3, 3:39 PM
apol committed R134:d3d94ed6b1c5: Merge branch 'Plasma/5.12' into Plasma/5.13 (authored by apol).
Merge branch 'Plasma/5.12' into Plasma/5.13
Fri, Aug 3, 3:38 PM
apol committed R134:e41df0e3b0b8: Fix navigation after search (authored by apol).
Fix navigation after search
Fri, Aug 3, 3:37 PM
apol added a comment to T7862: `sudo` command takes forever.

echo "127.0.0.1 localhost.localdomain" | sudo tee /etc/hosts

Fri, Aug 3, 12:08 PM · Plasma: Mobile
apol added inline comments to D14568: Fixup the sfos mpris control.
Fri, Aug 3, 11:21 AM · KDE Connect
apol committed R134:5dbb15a3007b: Add missing endif(), remove deprecated args in closing conditionals (authored by apol).
Add missing endif(), remove deprecated args in closing conditionals
Fri, Aug 3, 11:18 AM
apol committed R249:3e66e1496235: Reuse function that already does the same (authored by apol).
Reuse function that already does the same
Fri, Aug 3, 10:53 AM
apol closed D14502: Reuse function that already does the same.
Fri, Aug 3, 10:53 AM · Frameworks
apol committed R134:f74ee5fbc1c7: Remove some hardcoded sizes (authored by apol).
Remove some hardcoded sizes
Fri, Aug 3, 2:24 AM
apol accepted D14571: Show icons in plugin list.
Fri, Aug 3, 12:22 AM · KDE Connect
apol accepted D14567: Move declarativeplugin to top-level dir.
Fri, Aug 3, 12:19 AM · KDE Connect
apol requested review of D14572: Check the build directory for po/ as well.
Fri, Aug 3, 12:12 AM · Frameworks
apol updated the diff for D14528: Android: Make sure we're looking for .mo files in the right path.

Merged another patch, sorry

Fri, Aug 3, 12:10 AM · Frameworks
apol added inline comments to D14570: Use localization for KStars Lite.
Fri, Aug 3, 12:07 AM · KDE Edu

Thu, Aug 2

apol updated the diff for D14528: Android: Make sure we're looking for .mo files in the right path.

Check the build directory for po/ as well

Thu, Aug 2, 10:48 PM · Frameworks
apol requested review of D14569: Make it possible for ECM to detect po files at configure time.
Thu, Aug 2, 10:47 PM · Build System, Frameworks
apol added a comment to D14568: Fixup the sfos mpris control.

In any case, feel free to push directly to the sfos parts of kdeconnect, I don't think we have the know-how in the team to review properly.
Also feel free to find someone who knows sailfish to review, that would work as well.

Thu, Aug 2, 10:09 PM · KDE Connect
apol accepted D14566: Fix Build Fails Due to variable Not set in FINDLIBFWUPD.cmake.
Thu, Aug 2, 9:36 PM · Plasma, Discover Software Store
apol committed R134:57e58f7cfd3d: Merge branch 'Plasma/5.13' (authored by apol).
Merge branch 'Plasma/5.13'
Thu, Aug 2, 5:58 PM
apol committed R134:529a7023764f: Merge branch 'Plasma/5.12' into Plasma/5.13 (authored by apol).
Merge branch 'Plasma/5.12' into Plasma/5.13
Thu, Aug 2, 5:58 PM
apol committed R134:310685b3db21: Remove wrong assert (authored by apol).
Remove wrong assert
Thu, Aug 2, 5:58 PM
apol accepted D14050: Fwupd-Backend Integration.
Thu, Aug 2, 5:13 PM · Discover Software Store, Plasma
apol committed R134:05d10118d361: Don't load categories for invalid backends (authored by apol).
Don't load categories for invalid backends
Thu, Aug 2, 1:42 PM
apol committed R134:8b8cbe301f91: Fix indentation (authored by apol).
Fix indentation
Thu, Aug 2, 1:38 PM
apol committed R134:af0c90831d81: Unify header and toolbar background color (authored by apol).
Unify header and toolbar background color
Thu, Aug 2, 1:38 PM
apol accepted D14557: Use a consistent visual style on the Settings page.
Thu, Aug 2, 1:17 PM · Plasma
apol committed R169:3327997346c1: Fix documentation typo (authored by apol).
Fix documentation typo
Thu, Aug 2, 1:05 PM
apol committed R134:0a468792d655: Remove unused class (authored by apol).
Remove unused class
Thu, Aug 2, 11:09 AM
apol accepted D14545: Support both QString and QIcon for dragHelper pixmap.

Meh, then go for it.
Remove the unneeded exports? (In a separate patch, if you want)

Thu, Aug 2, 10:50 AM · Plasma
apol accepted D14548: testedid: make sure to use uint consistently.
Thu, Aug 2, 10:36 AM · Plasma
apol added inline comments to D14545: Support both QString and QIcon for dragHelper pixmap.
Thu, Aug 2, 10:35 AM · Plasma
apol committed R240:2f9bf6673179: Android: Don't hardcode a random version of the Android SDK (authored by apol).
Android: Don't hardcode a random version of the Android SDK
Thu, Aug 2, 10:34 AM
apol closed D14544: Android: Don't hardcode a random version of the Android SDK.
Thu, Aug 2, 10:33 AM · Build System, Frameworks
apol added a comment to D14544: Android: Don't hardcode a random version of the Android SDK.

From all of my installed build tools: 19.1.0, 20.0.0, 21.1.2, 22.0.1, 23.0.1, 23.0.2, 23.0.3, 24.0.0, 26.0.1 it selects _default_sdk as 19.1.0, is it fine? 😄
I mean, which one should be used ideally?

Thu, Aug 2, 10:31 AM · Build System, Frameworks
apol added a comment to D14529: Android: Make sure Qm translations get loaded.

I don't really see how, with the information we have provided today.

Thu, Aug 2, 1:22 AM · Build System, Frameworks
apol requested review of D14544: Android: Don't hardcode a random version of the Android SDK.
Thu, Aug 2, 12:10 AM · Build System, Frameworks

Wed, Aug 1

apol committed R857:bea80a78472a: Android: only create one apk (authored by apol).
Android: only create one apk
Wed, Aug 1, 11:52 PM
apol committed R857:3fe5eea42a71: Android: make it possible to the docker image to install translations (authored by apol).
Android: make it possible to the docker image to install translations
Wed, Aug 1, 11:52 PM
apol committed R321:c4dd86424dac: Add the file to integrate with phabricator (authored by apol).
Add the file to integrate with phabricator
Wed, Aug 1, 11:05 PM
apol committed R883:1521458: Introduced fixes as suggested by Josep Ma..
Introduced fixes as suggested by Josep Ma.
Wed, Aug 1, 10:31 PM
apol abandoned D14504: Save few string allocations.

Probably not worth it if it needs to become public.

Wed, Aug 1, 10:17 PM · Frameworks
apol accepted D14541: ECMOptionalAddSubdirectory: Provide a bit more detail.
Wed, Aug 1, 6:02 PM · Build System, Frameworks
apol added a comment to T8288: Drag n Drop Filetransfer on the plasmoid.

Sure, go for it! :)

Wed, Aug 1, 5:15 PM · KDE Connect
apol added a comment to D14528: Android: Make sure we're looking for .mo files in the right path.

Is this a possible Qt bug where the output of QStandardPaths should be tuned on Android?

Wed, Aug 1, 2:33 PM · Frameworks