- User Since
- Apr 27 2015, 12:34 PM (125 w, 5 d)
I don't really see how this needs review. :)
This is not necessary: see here.
Thu, Sep 21
Which part of the system doesn't work if there are symlinks?
This is the wrong fix, let me look into fixing it in Kirigami.
Thanks! this bothered me in the past :)
It's very similar to the patch I pushed: 667891df61d4f90e20692d59b9bfc7c1ba8bd6b1
Where's the attempt? Maybe I can look into it.
Wed, Sep 20
Tue, Sep 19
Mon, Sep 18
Looks good to me.
Sun, Sep 17
Makes sense to me, maybe we will use it someday and it doesn't hurt to implement the API.
One point that I think is fundamental to make is that we don't want to be as excluding as Ubuntu and Sailfish did (note that we have several apps ported to Android but none to either of those, because they're far more restrictive!!!!). In principle any Linux application should work on the Plasma Phone so rather than trying to push down a very specific technology we can leverage the whole Linux platform as whole.
Fri, Sep 15
Thu, Sep 14
Wed, Sep 13
Use the configured settings if nothing was provided
Good point. I wouldn't go into merging, the whole point of this is to have the file parser use the same settings that the build system will use.
Use flatpak_installed_ref_load_metadata to read the metadata
Here's an issue related to the next version of the patch: https://github.com/flatpak/flatpak/issues/1014
Can we have a unit test too? It shouldn't be hard to adapt one of the current ones.
Also you maybe can move this code into the tests subdirectory, so it only needs to be run in BUILD_TESTING.
Tue, Sep 12
Addressed Milian's comments
Sun, Sep 10
Rene, you submitted it to the wrong repository.
Sat, Sep 9
I like the feature. Thanks!
Fri, Sep 8
Thu, Sep 7