apol (Aleix Pol Gonzalez)
User

Projects (14)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 27 2015, 12:34 PM (229 w, 3 d)
Availability
Available

Recent Activity

Yesterday

apol accepted D24098: Remove unnecessary KF5People dependency.
Thu, Sep 19, 10:22 PM · Plasma
apol added inline comments to D24086: Don't initialize QFlags<T> with nullptr.
Thu, Sep 19, 3:33 PM · KWin
apol updated the diff for D24011: Provide a telemetrics kcm module for Plasma.

Polish

Thu, Sep 19, 3:32 PM · Plasma
apol updated the diff for D24011: Provide a telemetrics kcm module for Plasma.

Iterated with Nate's feedback

Thu, Sep 19, 2:11 PM · Plasma
apol committed R134:b2f4d53563c5: Remove unused method (authored by apol).
Remove unused method
Thu, Sep 19, 1:51 PM
apol requested review of D24080: Fix copying urls to the clipboard.
Thu, Sep 19, 1:25 PM · Kirigami
apol accepted D24072: properly install whole plasmacomponent3.
Thu, Sep 19, 12:13 PM · Frameworks
apol committed R857:3a9fc88d98ed: android: update to newer Qt and CMake (authored by apol).
android: update to newer Qt and CMake
Thu, Sep 19, 1:20 AM
apol committed R857:4e2f0e68fce4: android: allow using gstreamer's libintl (authored by apol).
android: allow using gstreamer's libintl
Thu, Sep 19, 1:20 AM
apol accepted D24067: CMake: Remove own FindLibXml2.
Thu, Sep 19, 12:54 AM · KDE Telepathy
apol added a comment to D24065: Tools: Sync with TelepathyQt (make compatible with Python 3).

+1 lgtm

Thu, Sep 19, 12:53 AM · KDE Telepathy
apol accepted D24066: CMake: Remove own FindPython modules, use standard FindPython3 instead.
Thu, Sep 19, 12:53 AM · KDE Telepathy

Wed, Sep 18

apol committed R134:c6fd9a4257a6: Fix placement of extra backend buttons (authored by apol).
Fix placement of extra backend buttons
Wed, Sep 18, 11:32 PM
apol committed R307:eff51d5c825b: Claim Android as a supported platform (authored by apol).
Claim Android as a supported platform
Wed, Sep 18, 1:35 PM
apol committed R857:cb560fa43e7c: android: Include KPeople into the CI (authored by apol).
android: Include KPeople into the CI
Wed, Sep 18, 1:30 PM
apol accepted D24050: Deploy default avatar via qrc.
Wed, Sep 18, 1:26 PM · Frameworks
apol accepted D24045: Port away from deprecated QString::sprintf.
Wed, Sep 18, 11:04 AM · KWin
apol added a comment to D23766: FakeInput: add support for keyboard key press and release.

The patch looks good to me, is there a reason why it wasn't accepted?

Wed, Sep 18, 12:04 AM · Frameworks

Tue, Sep 17

apol accepted D24039: Process directory when dirty.
Tue, Sep 17, 11:57 PM
apol updated the diff for D24011: Provide a telemetrics kcm module for Plasma.

Include a provider for plasmashell

Tue, Sep 17, 11:50 PM · Plasma
apol updated the diff for D24011: Provide a telemetrics kcm module for Plasma.

Don't use "telemetry"

Tue, Sep 17, 9:55 PM · Plasma
apol added inline comments to D24011: Provide a telemetrics kcm module for Plasma.
Tue, Sep 17, 9:55 PM · Plasma
apol updated the diff for D5961: PoC: Generic adoption of KUserFeedback for Discover.

Use KDE's server

Tue, Sep 17, 6:12 PM · Plasma
apol added a comment to D24025: Don't use KCrash on Android.

I think the line between dummy and #ifdef is in the commit message: if we don't want something on Android #ifdef is IMHO the way to go, if we merely don't have something yet, let's go for the dummy. A crash handler/bug reporter is something we certainly want I'd say, but something that currently isn't working yet.

Tue, Sep 17, 5:56 PM · Frameworks
apol accepted D24005: Show a new version string description for updates where the old and new versions are identical.
Tue, Sep 17, 4:10 PM · Plasma
apol added a comment to D24025: Don't use KCrash on Android.

Why not? it could be useful. The alternative is darkness over what happened there.

Tue, Sep 17, 2:51 PM · Frameworks
apol added a comment to D24011: Provide a telemetrics kcm module for Plasma.

Hey @ngraham, I introduced many of your points to the proposal. Here's some thoughts on the rest:

Tue, Sep 17, 2:48 PM · Plasma
apol added a comment to D5961: PoC: Generic adoption of KUserFeedback for Discover.

Shouldn't these be in Kirigami, then?

Tue, Sep 17, 2:37 PM · Plasma
apol updated the test plan for D24011: Provide a telemetrics kcm module for Plasma.
Tue, Sep 17, 2:37 PM · Plasma
apol updated the diff for D24011: Provide a telemetrics kcm module for Plasma.

Improve how we display plasma settings

Tue, Sep 17, 2:36 PM · Plasma
apol accepted D24024: Bundle plugin files on Android.
Tue, Sep 17, 2:35 PM · Frameworks, Android
apol updated the diff for D24011: Provide a telemetrics kcm module for Plasma.

Copyrights

Tue, Sep 17, 12:38 PM · Plasma
apol updated the diff for D24011: Provide a telemetrics kcm module for Plasma.

Include the policy, KUserfeedback decides the setting default, polishing.

Tue, Sep 17, 12:36 PM · Plasma
apol added a comment to D24011: Provide a telemetrics kcm module for Plasma.

Screenshot, I thought I'd uploaded it already.

Tue, Sep 17, 12:28 PM · Plasma
apol added inline comments to D24011: Provide a telemetrics kcm module for Plasma.
Tue, Sep 17, 12:16 PM · Plasma
apol added a comment to D24011: Provide a telemetrics kcm module for Plasma.

Should we make it already a "Privacy" KCM just in case?

Tue, Sep 17, 10:20 AM · Plasma

Mon, Sep 16

apol added a dependent revision for D24011: Provide a telemetrics kcm module for Plasma: D5961: PoC: Generic adoption of KUserFeedback for Discover.
Mon, Sep 16, 10:42 PM · Plasma
apol added a dependency for D5961: PoC: Generic adoption of KUserFeedback for Discover: D24011: Provide a telemetrics kcm module for Plasma.
Mon, Sep 16, 10:42 PM · Plasma
apol updated the diff for D5961: PoC: Generic adoption of KUserFeedback for Discover.

Remove the dialog and read the settings globally for Plasma.
Moved the feedback settings to the About page.

Mon, Sep 16, 10:42 PM · Plasma
apol requested review of D24011: Provide a telemetrics kcm module for Plasma.
Mon, Sep 16, 10:40 PM · Plasma
apol updated the diff for D24010: Fix generating properties that start with an uppercase letter.

Also make the property lowercase

Mon, Sep 16, 10:20 PM · Frameworks
apol requested review of D24010: Fix generating properties that start with an uppercase letter.
Mon, Sep 16, 10:05 PM · Frameworks
apol added a comment to D24005: Show a new version string description for updates where the old and new versions are identical.

Having 3 identical labels with slightly different conditions feels odd, maybe we should just take it into account if when assigning the property?

Mon, Sep 16, 9:19 PM · Plasma
apol accepted D23996: Port away from deprecated KIO::suggestName.
Mon, Sep 16, 3:37 PM · Plasma
apol committed R257:45f75cc7f91a: Fix build (authored by apol).
Fix build
Mon, Sep 16, 2:57 PM
apol accepted D23994: [KPeople] Port away from deprecated methods in Qt 5.14.

Thank you!

Mon, Sep 16, 2:41 PM · Frameworks
apol closed T11645: Update address in FLA as Resolved by committing R917:17e017857af6: Update the e.V. office address.
Mon, Sep 16, 2:35 PM · KDE e.V.
apol committed R917:17e017857af6: Update the e.V. office address (authored by gladhorn).
Update the e.V. office address
Mon, Sep 16, 2:35 PM
apol closed D23992: Update the e.V. office address.
Mon, Sep 16, 2:35 PM
apol accepted D23992: Update the e.V. office address.

Thank you very much, Frederik!

Mon, Sep 16, 2:34 PM
apol accepted D23990: [kcmutils] Port away from deprecated methods in Qt 5.14.

Looks good :)

Mon, Sep 16, 1:58 PM · Frameworks
apol committed R120:e7cc46fad0c2: Provide a simple test tool to see what autostart will look like (authored by apol).
Provide a simple test tool to see what autostart will look like
Mon, Sep 16, 1:48 PM
apol closed D23727: Provide a simple test tool to see what autostart will look like.
Mon, Sep 16, 1:48 PM · Plasma
apol committed R120:17a706a917c3: Make sure we only initialize the appstream pool once (authored by apol).
Make sure we only initialize the appstream pool once
Mon, Sep 16, 12:16 PM
apol committed R120:4e9cf6695ad8: Fix issues pointed out by Kai (authored by apol).
Fix issues pointed out by Kai
Mon, Sep 16, 12:16 PM
apol committed R120:19f2cada1745: Figure out software center integration on the menus (authored by apol).
Figure out software center integration on the menus
Mon, Sep 16, 12:16 PM
apol committed R120:45118bf219ba: Port away from deprecated API (authored by apol).
Port away from deprecated API
Mon, Sep 16, 12:16 PM
apol committed R120:5f45f75cd5c8: Drop usage of Qt4Support (authored by apol).
Drop usage of Qt4Support
Mon, Sep 16, 12:16 PM
apol accepted D23983: [Notifications] Create KFilePlacesModel when needed.
Mon, Sep 16, 10:04 AM · Plasma
apol accepted D23980: [Folder View] Don't explicitly initialize fontMetrics.
Mon, Sep 16, 10:02 AM · Plasma
apol added a comment to D23968: Use app specific location for DB on Android.

I thought the same thing, but I'm not sure if changing that could break some apps

Mon, Sep 16, 10:01 AM · Frameworks

Sun, Sep 15

apol accepted D23971: Build KXmlGui without globalaccel support on Android.

I'd write ON, uppercase, it's how it's usually represented.

Sun, Sep 15, 11:20 PM
apol accepted D23970: Port away from deprecated methods in Qt 5.14.
Sun, Sep 15, 11:19 PM · Frameworks
apol added a comment to D23968: Use app specific location for DB on Android.

Then maybe Qt shouldn't offer it? It's supposed to be writtable after all...

Sun, Sep 15, 11:15 PM · Frameworks
apol committed R257:df95e0a5f2ff: update to kf 5.62 (authored by apol).
update to kf 5.62
Sun, Sep 15, 10:52 PM
apol committed R257:20c81316895c: Remove backported patches that are now available (authored by apol).
Remove backported patches that are now available
Sun, Sep 15, 10:52 PM
apol added a comment to T11535: Organize 2019 KF6 sprint.

I'm interested in participating, could help organising but don't really have an easy venue.

Sun, Sep 15, 3:46 PM · KF6
apol committed R134:4a5cdd4bb2d7: Port to new QAbstractItemModelTester (authored by apol).
Port to new QAbstractItemModelTester
Sun, Sep 15, 3:18 PM
apol accepted D23933: Add more checks to deleteContact.

Good thinking

Sun, Sep 15, 3:03 PM
apol accepted D23910: startplasma: Respect KDEWM again.
Sun, Sep 15, 3:01 PM · Plasma

Fri, Sep 13

apol updated the diff for D5961: PoC: Generic adoption of KUserFeedback for Discover.

Rename property

Fri, Sep 13, 9:58 AM · Plasma
apol updated the diff for D5961: PoC: Generic adoption of KUserFeedback for Discover.

Rebase

Fri, Sep 13, 9:56 AM · Plasma

Thu, Sep 12

apol committed R257:f4373394b5b6: Update to Qt 5.12.5 (authored by apol).
Update to Qt 5.12.5
Thu, Sep 12, 11:59 AM
apol committed R257:2d86093a92a7: fix udev (authored by apol).
fix udev
Thu, Sep 12, 11:59 AM

Wed, Sep 11

apol accepted D23854: Fix wrong title of the Drawers page.
Wed, Sep 11, 8:41 AM · Kirigami, Plasma
apol accepted D23828: Disable DBus pieces on Android.
Wed, Sep 11, 8:31 AM · Frameworks
apol accepted D23827: Add manual tests for PC3.

cool!

Wed, Sep 11, 8:30 AM · Frameworks

Sun, Sep 8

apol committed R307:3292b028d702: Fix crash when monitoring a contact that gets removed on PersonData (authored by apol).
Fix crash when monitoring a contact that gets removed on PersonData
Sun, Sep 8, 4:47 PM
apol committed R307:561ff775ad22: Use fully qualified types on signals (authored by apol).
Use fully qualified types on signals
Sun, Sep 8, 4:47 PM
apol committed R732:f29a760485cd: Improve test coverage (authored by apol).
Improve test coverage
Sun, Sep 8, 2:32 PM
apol committed R732:8207754733da: Implement deleting a contact (authored by jbbgameich).
Implement deleting a contact
Sun, Sep 8, 2:11 PM
apol closed D23765: Implement deleting a contact.
Sun, Sep 8, 2:10 PM
apol committed R732:b3ed6ad25dcc: Fix refreshing after the addition of the first contact in a subdirectory (authored by apol).
Fix refreshing after the addition of the first contact in a subdirectory
Sun, Sep 8, 2:10 PM
apol added a comment to D23765: Implement deleting a contact.

Landing it because I need it for something I'm working on.

Sun, Sep 8, 2:08 PM
apol added a comment to D23784: Remove custom content item from ActionMenu separator.

Other than that, LGTM +1

Sun, Sep 8, 9:46 AM · Kirigami
apol accepted D23765: Implement deleting a contact.
Sun, Sep 8, 7:56 AM
apol added a comment to D23765: Implement deleting a contact.
Sun, Sep 8, 7:55 AM

Sat, Sep 7

apol added a comment to D23777: Fix diff.

Please fix commit message.

Sat, Sep 7, 9:44 PM
apol added a comment to D23727: Provide a simple test tool to see what autostart will look like.

plasma-checkautostart? plasma-autostart-list?

Sat, Sep 7, 3:59 PM · Plasma
apol added inline comments to D23765: Implement deleting a contact.
Sat, Sep 7, 3:59 PM
apol added inline comments to D23411: Fix crash in writer collection and cleanup.
Sat, Sep 7, 1:53 PM · Baloo, Frameworks
apol added a comment to D23765: Implement deleting a contact.

LGTM otherwise.

Sat, Sep 7, 1:43 PM
apol accepted D23764: Make it possible to delete contacts from backends.
Sat, Sep 7, 10:05 AM · Frameworks
apol accepted D23752: [tabbox] Delete unused X11 includes.
Sat, Sep 7, 9:30 AM · KWin
apol accepted D23751: [kcmkwin/options] Delete unused X11 includes.
Sat, Sep 7, 9:29 AM · KWin

Thu, Sep 5

apol updated the diff for D23727: Provide a simple test tool to see what autostart will look like.

add missing files

Thu, Sep 5, 3:25 PM · Plasma
apol committed R224:8d6136f9530c: wayland: we need the input interface to be able to use the remote capabilities (authored by apol).
wayland: we need the input interface to be able to use the remote capabilities
Thu, Sep 5, 2:58 PM
apol committed R108:5ed98f79e8c2: Fix warning text message (authored by apol).
Fix warning text message
Thu, Sep 5, 2:48 PM
apol updated the title for P462 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Thu, Sep 5, 2:15 PM
apol accepted D23722: Warn if KPackage is invalid.

Let's consider it an iteration though.

Thu, Sep 5, 1:00 PM · Frameworks