apol (Aleix Pol Gonzalez)
User

Projects (14)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 27 2015, 12:34 PM (258 w, 3 d)
Availability
Available

Recent Activity

Yesterday

apol updated the diff for D28708: egl: encapsulate and share duplicated code.

Remove unrelated changes

Thu, Apr 9, 5:57 PM · KWin
apol requested review of D28708: egl: encapsulate and share duplicated code.
Thu, Apr 9, 5:56 PM · KWin
apol updated the task description for T12906: Mini Plasma Mobile sprint.
Thu, Apr 9, 1:49 PM · Plasma: Mobile
apol accepted D28699: Add startCapture method.
Thu, Apr 9, 10:28 AM · Frameworks

Wed, Apr 8

apol committed R108:85b322ad9c8f: drm: Fix hotplugging docking stations (authored by apol).
drm: Fix hotplugging docking stations
Wed, Apr 8, 10:45 PM
apol closed D28642: drm: Fix hotplugging docking stations.
Wed, Apr 8, 10:45 PM · KWin
apol updated the diff for D28642: drm: Fix hotplugging docking stations.

rebase + debugging

Wed, Apr 8, 4:40 PM · KWin
apol committed R108:6a33533816d9: drm: properly access a scoped pointer (authored by apol).
drm: properly access a scoped pointer
Wed, Apr 8, 2:26 PM
apol committed R108:fa654bda59d1: drm: Improve QDebug of DrmOutput (authored by apol).
drm: Improve QDebug of DrmOutput
Wed, Apr 8, 2:26 PM
apol committed R108:16fe8dbd88d8: drm: Don't leak planes (authored by apol).
drm: Don't leak planes
Wed, Apr 8, 2:26 PM
apol closed D28680: drm: Improve QDebug of DrmOutput.
Wed, Apr 8, 2:26 PM · KWin
apol requested review of D28680: drm: Improve QDebug of DrmOutput.
Wed, Apr 8, 2:13 PM · KWin
apol accepted D28676: Drop kdeinit from ksmserver.
Wed, Apr 8, 10:31 AM · Plasma
apol accepted D28668: [wayland] Fix teardown order.

Saw this warning yesterday too.

Wed, Apr 8, 10:28 AM · KWin
apol accepted D28667: [platforms/x11] Fix valigrind warning copying window icon for windowed mode.
Wed, Apr 8, 10:27 AM · KWin

Tue, Apr 7

apol committed R108:f6029c3dbdfb: debugging: Simplify printing DrmObjects through QDebug (authored by apol).
debugging: Simplify printing DrmObjects through QDebug
Tue, Apr 7, 11:23 AM
apol closed D28641: debugging: Simplify printing DrmObjects through QDebug.
Tue, Apr 7, 11:23 AM · KWin
apol accepted D28214: Add background portal.
Tue, Apr 7, 12:40 AM · Plasma
apol accepted D28637: Use ecm_setup_qtplugin_macro_names.
Tue, Apr 7, 12:37 AM · Frameworks
apol requested review of D28642: drm: Fix hotplugging docking stations.
Tue, Apr 7, 12:34 AM · KWin
apol requested review of D28641: debugging: Simplify printing DrmObjects through QDebug.
Tue, Apr 7, 12:28 AM · KWin

Mon, Apr 6

apol committed R917:79f5de118dcb: Add post "Changes in Qt and the KDE Free Qt Foundation" (authored by apol).
Add post "Changes in Qt and the KDE Free Qt Foundation"
Mon, Apr 6, 1:24 PM
apol added inline comments to D28214: Add background portal.
Mon, Apr 6, 1:12 PM · Plasma
apol accepted D28620: Add readmes clarifying state of plasma component versions.

LGTM

Mon, Apr 6, 12:51 PM · Frameworks
apol added a comment to D28617: Remove QSessionManager usage.

+1 LGTM

Mon, Apr 6, 12:35 PM · KWin
apol committed R39:b70654b6bddd: Revert premature port to unreleased Qt 5.15 (authored by apol).
Revert premature port to unreleased Qt 5.15
Mon, Apr 6, 11:21 AM
apol accepted D28618: ScreenSharing: close dialogs when session is closed.
Mon, Apr 6, 10:59 AM · Plasma
apol committed R169:989cd3098ced: Remove the STATIC_LIBRARY option to fix static builds (authored by bartoc).
Remove the STATIC_LIBRARY option to fix static builds
Mon, Apr 6, 12:08 AM
apol closed D28066: Remove the STATIC_LIBRARY option to fix static builds.
Mon, Apr 6, 12:08 AM · Kirigami
apol accepted D28066: Remove the STATIC_LIBRARY option to fix static builds.
Mon, Apr 6, 12:02 AM · Kirigami

Sun, Apr 5

apol accepted D28599: [configview] Simplify code / workaround Qt5.15 crash.

LGTM

Sun, Apr 5, 6:15 PM · Frameworks
apol accepted D28409: ECM: attempt to fix KDEInstallDirsTest.relative_or_absolute on Windows.
Sun, Apr 5, 3:04 PM · Build System, Frameworks
apol added a comment to D28409: ECM: attempt to fix KDEInstallDirsTest.relative_or_absolute on Windows.

Will /tmp then still work on Windows?

Sun, Apr 5, 2:40 PM · Build System, Frameworks
apol added a comment to D28579: Improve the look of kcachegrind.

+1 much better!

Sun, Apr 5, 2:31 AM · Frameworks
apol accepted D28578: kwin: fix compilation error with strict iterators.

Makes sense, yes.

Sun, Apr 5, 2:29 AM · KWin
apol accepted D28565: [QueryParser] Replace single-use helper with std::none_of.
Sun, Apr 5, 2:24 AM · Baloo, Frameworks
apol added a reverting change for R116:beff45c61c81: Port some deprecated signal (qt5.15): R116:285b559393b9: Revert "Port some deprecated signal (qt5.15)".
Sun, Apr 5, 12:34 AM
apol committed R116:285b559393b9: Revert "Port some deprecated signal (qt5.15)" (authored by apol).
Revert "Port some deprecated signal (qt5.15)"
Sun, Apr 5, 12:34 AM
apol committed R40:eb144cb9faaf: Revert premature porting (authored by apol).
Revert premature porting
Sun, Apr 5, 12:33 AM
apol committed R260:1dda9f489284: Revert "Port deprecated signal" (authored by apol).
Revert "Port deprecated signal"
Sun, Apr 5, 12:31 AM
apol added a reverting change for R260:b1ae993cac2d: Port deprecated signal: R260:1dda9f489284: Revert "Port deprecated signal".
Sun, Apr 5, 12:31 AM

Sat, Apr 4

apol committed R318:c01d1b4c0e90: Revert "Port deprecated signal (qt5.15)" (authored by apol).
Revert "Port deprecated signal (qt5.15)"
Sat, Apr 4, 2:10 PM
apol added a reverting change for R318:e545efee73a8: Port deprecated signal (qt5.15): R318:c01d1b4c0e90: Revert "Port deprecated signal (qt5.15)".
Sat, Apr 4, 2:10 PM
apol committed R94:94df4238047e: Revert premature port of QComboBox::currentIndexChanged (authored by apol).
Revert premature port of QComboBox::currentIndexChanged
Sat, Apr 4, 2:08 PM

Fri, Apr 3

apol accepted D28539: [Emoji panel] search when the user begins typing.

Fonts are slow...

Fri, Apr 3, 6:35 PM · Plasma
apol committed R108:77782efc1fa4: x11: register the cursor as well (authored by apol).
x11: register the cursor as well
Fri, Apr 3, 6:04 PM
apol committed R134:498e6d6ec51d: flatpak: Don't issue commands when cancelled (authored by apol).
flatpak: Don't issue commands when cancelled
Fri, Apr 3, 2:02 PM
apol accepted D27980: make opengl module support multiple dri devices.

LGTM

Fri, Apr 3, 1:07 PM · Plasma
apol accepted D28520: Fix lifetime of slot in KIO-MTP.
Fri, Apr 3, 1:06 PM · Frameworks, Dolphin
apol added a comment to D28521: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts.

@apol So okay if I land this one for now?
The initlist approach does not cover all cases anyway, and until that one is reviewed by enough experienced developers (e.g. who can tell if alignment of data works as hoped), this here should save resources across the globe already :) (even more as std::vector does not know about Q_DECLARE_TYPEINFO(KIO::UDSEntry, Q_MOVABLE_TYPE); and on each resize does a full copy of all items.

Fri, Apr 3, 1:05 PM · Frameworks
apol accepted D28531: [KNotificationJobUiDelegate] Append "Failed" for error messages.
Fri, Apr 3, 10:24 AM · Frameworks
apol added a comment to D28528: UDSEntry: add constructor variant with std::initializer_list.

+1 Makes sense, the code looks a bit fiddly but should allow cleaner code.

Fri, Apr 3, 1:39 AM · Frameworks
apol added inline comments to D28528: UDSEntry: add constructor variant with std::initializer_list.
Fri, Apr 3, 1:15 AM · Frameworks
apol committed R108:9f183642ca8a: Fix build (authored by apol).
Fix build
Fri, Apr 3, 12:35 AM

Thu, Apr 2

apol added a comment to D23114: [perf] Introduce ftrace marker.

Don't we want this anymore? :/ it looked promising

Thu, Apr 2, 11:22 PM · KWin
apol committed R108:6abd23ed0220: Make it possible to have a separate cursor for the tablet (authored by apol).
Make it possible to have a separate cursor for the tablet
Thu, Apr 2, 11:16 PM
apol closed D28155: Make it possible to have a separate cursor for the tablet.
Thu, Apr 2, 11:16 PM · KWin
apol accepted D28522: [QtQuick dialog] Port to UrlBUtton and hide when there's no URL.
Thu, Apr 2, 5:29 PM · Frameworks
apol added a comment to D28521: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts.

+1 Makes sense.

Thu, Apr 2, 5:27 PM · Frameworks
apol accepted D28520: Fix lifetime of slot in KIO-MTP.

Makes sense

Thu, Apr 2, 5:25 PM · Frameworks, Dolphin
apol accepted D28519: [KMenuEdit] Port QRegExp to QRegularExpression.

It could make sense for you to test that the names are properly parsed besides just making sure it starts.

Thu, Apr 2, 5:24 PM · Plasma
apol accepted D28517: Send notification when screencasting fails.
Thu, Apr 2, 3:51 PM · Plasma
apol added inline comments to D28517: Send notification when screencasting fails.
Thu, Apr 2, 3:32 PM · Plasma
apol added inline comments to D27980: make opengl module support multiple dri devices.
Thu, Apr 2, 2:47 PM · Plasma
apol added inline comments to D28498: [xdgoutput] Explicitly set version of server interface.
Thu, Apr 2, 2:44 PM · Frameworks
apol accepted D28510: [kprocessrunner] Escape hyphen characters in scope names.
Thu, Apr 2, 2:41 PM · Frameworks
apol committed R838:d2aef53e0611: Revert "Make it compile against qt5.15 without deprecated method" (authored by apol).
Revert "Make it compile against qt5.15 without deprecated method"
Thu, Apr 2, 2:33 PM
apol added a reverting change for R838:44a35b8763bd: Make it compile against qt5.15 without deprecated method: R838:d2aef53e0611: Revert "Make it compile against qt5.15 without deprecated method".
Thu, Apr 2, 2:33 PM
apol added a reverting change for R36:9c901d16ae43: Make it compile against last qt5.15 without deprecated method: R36:7a3a689b173a: Revert "Make it compile against last qt5.15 without deprecated method".
Thu, Apr 2, 2:32 PM
apol committed R36:7a3a689b173a: Revert "Make it compile against last qt5.15 without deprecated method" (authored by apol).
Revert "Make it compile against last qt5.15 without deprecated method"
Thu, Apr 2, 2:32 PM
apol committed R121:76a4c2e58a03: Revert "Make it compile against qt5.15" (authored by apol).
Revert "Make it compile against qt5.15"
Thu, Apr 2, 2:30 PM
apol added a reverting change for R121:dcb24c27c722: Make it compile against qt5.15: R121:76a4c2e58a03: Revert "Make it compile against qt5.15".
Thu, Apr 2, 2:30 PM
apol added a comment to T12863: Use PipeWire for screen casting.

Obviously, this would mean higher CPU usage, but it's better than nothing.

Thu, Apr 2, 2:10 PM · Plasma on Wayland, KWin
apol added inline comments to D27980: make opengl module support multiple dri devices.
Thu, Apr 2, 1:22 PM · Plasma
apol committed R108:da2d896257f6: Fix for older cmake versions (authored by apol).
Fix for older cmake versions
Thu, Apr 2, 11:20 AM
apol closed D28511: Fix for older cmake versions.
Thu, Apr 2, 11:20 AM · KWin
apol requested review of D28511: Fix for older cmake versions.
Thu, Apr 2, 11:14 AM · KWin
apol committed R108:f4e41430e5bd: Improve PowerOff/PowerDown behaviour (authored by apol).
Improve PowerOff/PowerDown behaviour
Thu, Apr 2, 10:10 AM
apol closed D28490: Improve PowerOff/PowerDown behaviour.
Thu, Apr 2, 10:10 AM · KWin
apol accepted D28502: [baloosearch] Bail out early if specified folder is not valid.
Thu, Apr 2, 9:59 AM · Baloo, Frameworks
apol added inline comments to D28501: [SearchStore] Use categorized logging.
Thu, Apr 2, 9:57 AM · Baloo, Frameworks
apol added a comment to D28498: [xdgoutput] Explicitly set version of server interface.

Some concerns at the documentation level. Looks good overall.

Thu, Apr 2, 9:54 AM · Frameworks
apol committed R122:a9abb0cb7924: Properly store the powerdown action (authored by apol).
Properly store the powerdown action
Thu, Apr 2, 9:50 AM
apol closed D28491: Properly store the powerdown action.
Thu, Apr 2, 9:50 AM · Plasma

Wed, Apr 1

apol committed R108:dbac4bce7e62: Reduce the amount of objects that are compiled several times (authored by apol).
Reduce the amount of objects that are compiled several times
Wed, Apr 1, 10:42 PM
apol closed D28445: Reduce the amount of objects that are compiled several times.
Wed, Apr 1, 10:42 PM · KWin
apol accepted D28494: [KItemModels/KLinkItemSelectionModelTest] Port QRegExp to QRegularExpression.
Wed, Apr 1, 10:39 PM · Frameworks
apol closed D28492: Improve powerdevil's main.
Wed, Apr 1, 6:49 PM · Plasma
apol committed R122:41ef07d6d3c1: Improve powerdevil's main (authored by apol).
Improve powerdevil's main
Wed, Apr 1, 6:49 PM
apol accepted D28485: Move QMimeData registration back to where it belongs.
Wed, Apr 1, 6:48 PM · Plasma
apol requested review of D28492: Improve powerdevil's main.
Wed, Apr 1, 6:45 PM · Plasma
apol added a comment to T9927: Reboot & Shutdown UI options.

https://phabricator.kde.org/D28490
https://phabricator.kde.org/D28491

Wed, Apr 1, 6:43 PM · Plasma: Mobile
apol requested review of D28491: Properly store the powerdown action.
Wed, Apr 1, 6:41 PM · Plasma
apol requested review of D28490: Improve PowerOff/PowerDown behaviour.
Wed, Apr 1, 6:37 PM · KWin
apol added a reverting change for R122:3a5aca82527e: Fix build with Qt 5.15: R122:9dbae3f1c3d6: Revert "Fix build with Qt 5.15".
Wed, Apr 1, 2:43 PM
apol closed D28481: Revert "Fix build with Qt 5.15".
Wed, Apr 1, 2:43 PM · Plasma
apol committed R122:9dbae3f1c3d6: Revert "Fix build with Qt 5.15" (authored by apol).
Revert "Fix build with Qt 5.15"
Wed, Apr 1, 2:43 PM
apol abandoned D28482: Revert "Fix build with Qt 5.15".

Once is enough

Wed, Apr 1, 1:13 PM · Plasma
apol added a comment to D28481: Revert "Fix build with Qt 5.15".

commit 46ebd11e66f6f3180043a7258b46a1aff79a69f8
Author: Lars Knoll <lars.knoll@qt.io>
Date: Wed Mar 25 11:20:28 2020 +0100

Wed, Apr 1, 1:00 PM · Plasma
apol updated the diff for D28481: Revert "Fix build with Qt 5.15".

remove unrelated changes

Wed, Apr 1, 12:59 PM · Plasma