- User Since
- Apr 27 2015, 12:34 PM (208 w, 3 d)
We were not explicitly setting it in the flatpak nightly builds and it was failing because of that. We are now so it's not an issue anymore there.
Looks good to me. Will have to move the (few) translations with it. @ltoscano
Then let's leave it as +1 :)
Other than that, +1 for the patch.
Disable blur and bg contrast when rotated
We are having a regular Plasma sprint, maybe you'd want to join us and work on a11y?
Tue, Apr 23
Sun, Apr 21
Sat, Apr 20
Fri, Apr 19
Don't you have a commit account yet?
LGTM, anothher fix could have been wrapping them with parenthesis?
Wed, Apr 17
address zzag's comment
Should maybe warn if it fails?
+1 in general
I don't think you understood the TODO. Also this change breaks ABI, since const it's part of it.
The TODO talks about adding a startTimer method and deprecating timer (which it already is).
Tue, Apr 16
We shouldn't indeed. Maybe it's a candidate to get in KGuiAddons
Detect when the display reports portrait by default
Mon, Apr 15
We could give it a go, how do you test it?
Do you suggest having it in git hooks? Can we use it only on the places that change?
Sun, Apr 14
Looks good to me, can you land it?