apol (Aleix Pol Gonzalez)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 27 2015, 12:34 PM (104 w, 23 h)
Availability
Available

Recent Activity

Today

apol committed R849:33ae0a262302: Fix build with Qt5.9 (authored by apol).
Fix build with Qt5.9
Tue, Apr 25, 12:13 PM
apol closed D5578: Fix build with Qt5.9 by committing R849:33ae0a262302: Fix build with Qt5.9.
Tue, Apr 25, 12:13 PM
apol added a comment to R268:3670b49d5721: build: Remove KService dependency.

I was under the impression arcanist would take care of it...

Tue, Apr 25, 12:12 PM
apol created D5578: Fix build with Qt5.9.
Tue, Apr 25, 11:00 AM
apol committed R268:3670b49d5721: build: Remove KService dependency (authored by apol).
build: Remove KService dependency
Tue, Apr 25, 10:25 AM
apol closed D5556: build: Remove KService dependency by committing R268:3670b49d5721: build: Remove KService dependency.
Tue, Apr 25, 10:25 AM · Frameworks

Yesterday

apol added a comment to D5556: build: Remove KService dependency.

Yes, do you have commit/push access? Otherwise we'll push it ourselves.

Mon, Apr 24, 6:12 PM · Frameworks
apol accepted D5557: fix basename handling of po files.

Lgtm, thanks for the test!

Mon, Apr 24, 4:19 PM · Frameworks

Fri, Apr 21

apol committed R32:7e2af7d8a7f7: Small cmakeutils refactoring (authored by apol).
Small cmakeutils refactoring
Fri, Apr 21, 8:25 PM
apol committed R235:138e7355c83d: Fix warning (authored by apol).
Fix warning
Fri, Apr 21, 2:55 PM
apol committed R249:c187a59514e8: Fix ki18n bootstrapping (authored by apol).
Fix ki18n bootstrapping
Fri, Apr 21, 12:25 PM
apol closed D5534: Fix ki18n bootstrapping by committing R249:c187a59514e8: Fix ki18n bootstrapping.
Fri, Apr 21, 12:25 PM · Frameworks
apol updated the diff for D5534: Fix ki18n bootstrapping.

add comment

Fri, Apr 21, 12:07 PM · Frameworks
apol created D5534: Fix ki18n bootstrapping.
Fri, Apr 21, 12:06 PM · Frameworks

Thu, Apr 20

apol committed R249:a54ae95b520e: Move .po and .ts files look-up to build-time (authored by apol).
Move .po and .ts files look-up to build-time
Thu, Apr 20, 6:31 PM
apol closed D5167: Move .po and .ts files look-up to build-time by committing R249:a54ae95b520e: Move .po and .ts files look-up to build-time.
Thu, Apr 20, 6:31 PM · Frameworks
apol accepted D5526: make fetchpo poqm aware and change argument handling to scale better.
Thu, Apr 20, 2:37 PM
apol added inline comments to D5526: make fetchpo poqm aware and change argument handling to scale better.
Thu, Apr 20, 1:59 PM
apol accepted D5525: adapt to fetchpo changes and use vars for target directories to dry code.

Okay, note that we should stabilize fetchpo.rb though as when it's released we won't get to do these changes anymore.

Thu, Apr 20, 1:57 PM · Build System, Frameworks
apol accepted D5523: use correct variable for fetch-translations injection.
Thu, Apr 20, 12:01 PM · Build System, Frameworks
apol committed R134:32cbc50cb819: Improve how we set up the flatpak backend (authored by apol).
Improve how we set up the flatpak backend
Thu, Apr 20, 10:31 AM
apol closed D5510: Improve how we set up the flatpak backend by committing R134:32cbc50cb819: Improve how we set up the flatpak backend.
Thu, Apr 20, 10:31 AM · Plasma
apol added a comment to D5510: Improve how we set up the flatpak backend.

Overall looks good to me, I also now understand why you don't use appScope as part of the unique id, hovewer I've been suggested by Alex to use flatpak_installation_get_display_name() or flatpak_installation_get_id(), which would result into a more readable unique id.

Thu, Apr 20, 10:18 AM · Plasma
apol added a comment to D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed.

Make them optional dependencies.

What do you mean by this?

Thu, Apr 20, 10:16 AM · Frameworks
apol committed R256:1c43be85a49d: ksudoku doesn't build currently (authored by apol).
ksudoku doesn't build currently
Thu, Apr 20, 10:03 AM
apol added a comment to D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed.

Make them optional dependencies.

Thu, Apr 20, 10:00 AM · Frameworks
apol committed R256:39b398c1916f: Add a bunch of applications (authored by apol).
Add a bunch of applications
Thu, Apr 20, 3:03 AM

Wed, Apr 19

apol added a comment to D5503: No "KDE Daemon" in password dialogs.

Maybe we want to have something else? Sometimes it's good to see where a dialog is coming from...

Wed, Apr 19, 3:08 PM · Frameworks
apol created D5510: Improve how we set up the flatpak backend.
Wed, Apr 19, 2:50 PM · Plasma
apol committed R134:6d1c4f6a2d2f: Remove the concept of scope (authored by apol).
Remove the concept of scope
Wed, Apr 19, 2:47 PM
apol committed R134:21e4312f5257: Use flatpak_get_system_installations to set up the system installations (authored by apol).
Use flatpak_get_system_installations to set up the system installations
Wed, Apr 19, 2:47 PM
apol committed R134:d873c0b8a995: Reduce semantics between user and system installations (authored by apol).
Reduce semantics between user and system installations
Wed, Apr 19, 2:47 PM
apol committed R134:b464b2ef5ae7: Simplify (authored by apol).
Simplify
Wed, Apr 19, 2:47 PM
apol accepted D5464: Nextcloud Upload Purpose Plugin.

Okay, let's integrate it and then we see how it works.

Wed, Apr 19, 2:31 PM · Plasma
apol committed R302:683bb49d4949: Don't even try to create icons with empty sizes (authored by apol).
Don't even try to create icons with empty sizes
Wed, Apr 19, 12:51 PM
apol closed D5506: Don't even try to create icons with empty sizes by committing R302:683bb49d4949: Don't even try to create icons with empty sizes.
Wed, Apr 19, 12:51 PM · Frameworks
apol updated the diff for D5506: Don't even try to create icons with empty sizes.

Readability

Wed, Apr 19, 12:33 PM · Frameworks
apol committed R325:1e0b3dc4cf86: This title doesn't really belong (authored by apol).
This title doesn't really belong
Wed, Apr 19, 11:28 AM
apol committed R325:cea61636d5fd: Use the component name as the the page title (authored by apol).
Use the component name as the the page title
Wed, Apr 19, 11:28 AM
apol committed R325:ce8ed9303ae1: Offer the same default window size as the legacy UI (authored by apol).
Offer the same default window size as the legacy UI
Wed, Apr 19, 11:28 AM
apol created D5507: Don't even try to scale images that we created ad-hoc.
Wed, Apr 19, 11:19 AM · Kirigami
apol created D5506: Don't even try to create icons with empty sizes.
Wed, Apr 19, 11:17 AM · Frameworks
apol added a comment to D5497: Improved Suggestions Model.

Okay, well, you know your code, but it all looks fishy.
Maybe it would be interesting for you to have upstream mycroft people involved.

Wed, Apr 19, 11:14 AM · Plasma
apol requested changes to D5464: Nextcloud Upload Purpose Plugin.

+1
Please look at David's comments and we'll integrate it.

Wed, Apr 19, 11:13 AM · Plasma

Tue, Apr 18

apol added a comment to D5497: Improved Suggestions Model.

Isn't mycroft supposed to do the language parts? is it mandatory to have this huge list?

Tue, Apr 18, 10:47 PM · Plasma
apol committed R134:f3d4cbdbe7d5: Improve interaction with --list* arguments (authored by apol).
Improve interaction with --list* arguments
Tue, Apr 18, 10:21 PM
apol committed R134:982f1e17e562: Properly construct strings (authored by apol).
Properly construct strings
Tue, Apr 18, 9:50 PM
apol committed R134:ffd101f129a9: Make sure the backend has been set up properly (authored by apol).
Make sure the backend has been set up properly
Tue, Apr 18, 9:44 PM
apol closed D5495: Make sure the backend has been set up properly by committing R134:ffd101f129a9: Make sure the backend has been set up properly.
Tue, Apr 18, 9:44 PM · Plasma
apol abandoned D5492: We don't have this dependency anymore.
Tue, Apr 18, 6:36 PM · Plasma
apol created D5495: Make sure the backend has been set up properly.
Tue, Apr 18, 5:16 PM · Plasma
apol updated the diff for D5492: We don't have this dependency anymore.
  • Better assert on flatpak successfully set up
Tue, Apr 18, 5:15 PM · Plasma
apol committed R499:8b71aedcafb7: Fix typo (authored by apol).
Fix typo
Tue, Apr 18, 1:49 PM
apol committed R499:050cacd6eb42: Include xdg-desktop-portal-kde (authored by apol).
Include xdg-desktop-portal-kde
Tue, Apr 18, 1:49 PM
apol abandoned D5492: We don't have this dependency anymore.
Tue, Apr 18, 1:15 PM · Plasma
apol created D5492: We don't have this dependency anymore.
Tue, Apr 18, 12:31 PM · Plasma
apol accepted D5409: Queue some connections which cannot be autodetected.

Go for it, let's see how it goes.

Tue, Apr 18, 12:18 PM · Plasma
apol committed R134:85ffb0cf458f: Don't open every file with the packagekit backend (authored by apol).
Don't open every file with the packagekit backend
Tue, Apr 18, 11:13 AM
apol added a comment to T5886: test campaign with Google Adwords.

Maybe it would make most sense with stuff on Google Play?

Tue, Apr 18, 10:44 AM · KDE Promo
apol accepted D5408: Don't forward keys until the recipient is ready.
Tue, Apr 18, 10:43 AM · Kirigami

Fri, Apr 14

apol added a comment to D5447: Only add auto-detected compilers to model if they actually exist.

Please, explain the reason for your changes. A commit without explanation is confusion-prone...

Fri, Apr 14, 12:24 PM
apol added a reviewer for D5443: fix duplicated symbols compilation error with mingw on Windows: Windows.
Fri, Apr 14, 12:20 PM · Frameworks

Thu, Apr 13

apol added a comment to T5851: Version scheme for the runtimes.

Alternatives:

  • version different releases per KF5 release (i.e. 5.33, 5.34) always with the latest stable Qt.
  • stable/lts (with Qt LTS) + master (latest KF5+latest Qt)
Thu, Apr 13, 6:55 PM · Flatpak
apol updated the diff for D5167: Move .po and .ts files look-up to build-time.

AUTHOR_WARNING

Thu, Apr 13, 6:50 PM · Frameworks
apol committed R256:92c6abc02a93: Build the stable branch as master doesn't build (authored by apol).
Build the stable branch as master doesn't build
Thu, Apr 13, 4:39 PM
apol updated the diff for D5167: Move .po and .ts files look-up to build-time.

Address some issues pointed at by sitter

Thu, Apr 13, 2:57 PM · Frameworks
apol added a comment to D5425: Allow disabling the git plugin with a kdevgit.disabled git config option.

+1

Thu, Apr 13, 2:02 PM
apol added a comment to T5874: Runtimes: support for gnome integration.

So it's a fork from the functionality in Qt? Any pro/con?

Thu, Apr 13, 1:42 PM · Flatpak
apol committed R256:f552c92ff180: Move because it needs QtWebKit which we don't have ATM (authored by apol).
Move because it needs QtWebKit which we don't have ATM
Thu, Apr 13, 1:18 PM
apol abandoned D5426: QtWebKit doesn't seem to be needed.

Never mind, I didn't saw the use of QWebPage...

Thu, Apr 13, 1:17 PM
apol committed R256:1adac7dd192b: Easily allow bundle.flatpak creation (authored by apol).
Easily allow bundle.flatpak creation
Thu, Apr 13, 1:09 PM
apol added a reviewer for D5426: QtWebKit doesn't seem to be needed: knauss.
Thu, Apr 13, 1:07 PM
apol created D5426: QtWebKit doesn't seem to be needed.
Thu, Apr 13, 1:06 PM
apol committed R256:4ead31115ce6: Fix Discover build (authored by apol).
Fix Discover build
Thu, Apr 13, 12:38 PM
apol committed R134:43051eef19e5: Fix warning (authored by apol).
Fix warning
Thu, Apr 13, 10:43 AM
apol committed R134:8e9a3aa84a27: Improve the FeaturedModel (authored by apol).
Improve the FeaturedModel
Thu, Apr 13, 10:43 AM
apol committed R169:8a5efae3d165: Polish ItemViewHeader, solve binding loops (authored by apol).
Polish ItemViewHeader, solve binding loops
Thu, Apr 13, 10:31 AM
apol closed D5416: Polish ItemViewHeader, solve binding loops by committing R169:8a5efae3d165: Polish ItemViewHeader, solve binding loops.
Thu, Apr 13, 10:31 AM · Kirigami
apol committed R134:092cedcc7463: Merge branch 'Plasma/5.9' (authored by apol).
Merge branch 'Plasma/5.9'
Thu, Apr 13, 10:01 AM
apol committed R134:c057f37b6d4d: Don't make the size of the icon match the size of the text (authored by apol).
Don't make the size of the icon match the size of the text
Thu, Apr 13, 10:01 AM
apol committed R134:55b624c15c06: Don't show anything with the PageHeader extra (authored by apol).
Don't show anything with the PageHeader extra
Thu, Apr 13, 9:58 AM
apol added a comment to T5345: [Portals] Make applications to use flatpak platform plugin by default for portals support.

We need to figure it out with Wayland too.
Note that it's not about desktop files, it's about including it in the finish-args.

Thu, Apr 13, 9:18 AM · Flatpak
apol added a comment to T5874: Runtimes: support for gnome integration.

Where's qgnomeplatform? How is it different from upstream Qt?

Thu, Apr 13, 9:15 AM · Flatpak
apol added a comment to T5849: Figure out QtWebEngine ARM32 build.

https://bugreports.qt.io/browse/QTBUG-60108

Thu, Apr 13, 9:03 AM · Flatpak
apol added a comment to D5408: Don't forward keys until the recipient is ready.

Add BUG: 378339

Thu, Apr 13, 1:19 AM · Kirigami
apol committed R313:2d9c893adef9: Fix build with Qt 5.9 (authored by apol).
Fix build with Qt 5.9
Thu, Apr 13, 1:03 AM
apol closed D5392: Fix build with Qt 5.9 by committing R313:2d9c893adef9: Fix build with Qt 5.9.
Thu, Apr 13, 1:03 AM · Frameworks
apol committed R134:0735be3a3012: Include a background behind the extra part of the controls in PageHeader (authored by apol).
Include a background behind the extra part of the controls in PageHeader
Thu, Apr 13, 12:56 AM
apol committed R134:a640cf42a434: Improve the behavior when closing (authored by apol).
Improve the behavior when closing
Thu, Apr 13, 12:16 AM

Wed, Apr 12

apol committed R134:2309a527f888: Introduce the Launch button back (authored by apol).
Introduce the Launch button back
Wed, Apr 12, 11:54 PM
apol committed R134:3b3f51d406c8: Let install button be flat in the toolbar, full elsewhere (authored by apol).
Let install button be flat in the toolbar, full elsewhere
Wed, Apr 12, 11:54 PM
apol committed R134:6d923fae5fc8: Fix few warnings (authored by apol).
Fix few warnings
Wed, Apr 12, 11:26 PM
apol committed R134:449862d95afd: Fix test when plasma-themes.knsrc is not installed (authored by apol).
Fix test when plasma-themes.knsrc is not installed
Wed, Apr 12, 10:47 PM
apol committed R134:f122409447eb: Make sure categories are populated (authored by apol).
Make sure categories are populated
Wed, Apr 12, 10:47 PM
apol committed R134:60092b28c827: Merge branch 'Plasma/5.9' (authored by apol).
Merge branch 'Plasma/5.9'
Wed, Apr 12, 10:47 PM
apol committed R134:2de134b28768: Merge branch 'Plasma/5.9' (authored by apol).
Merge branch 'Plasma/5.9'
Wed, Apr 12, 6:45 PM
apol committed R134:53702ce2d964: Make sure QSharedPointer is included (authored by apol).
Make sure QSharedPointer is included
Wed, Apr 12, 6:45 PM
apol committed R134:050713a46113: Prefer override (authored by apol).
Prefer override
Wed, Apr 12, 6:45 PM
apol committed R134:c28481108ffb: Remove unneeded include (authored by apol).
Remove unneeded include
Wed, Apr 12, 6:29 PM
apol committed R134:43dee4ec0935: Report the updatesCount after asserting progress (authored by apol).
Report the updatesCount after asserting progress
Wed, Apr 12, 5:28 PM