- User Since
- Apr 27 2015, 12:34 PM (215 w, 5 d)
Let's discuss at the sprint?
Have you considered what it would look like using libssl.so directly?
Fri, Jun 14
static const to be sure that QRegularExpression is only initialised once
No, @mlaurent sent a similar patch and since he doesn't ask for review it went unnoticed.
It would be useful if you provide a screenshot of the result so people can assess the change properly.
Thu, Jun 13
Prefer a QRegularExpression to QRegExp
Address xrdb call as suggested by David
You didn't specify any repository or people to review the patch.
Thought about it a bit more, it should be okay.
Wed, Jun 12
Been running it since and no replies, I'll land it.
Tue, Jun 11
addressed suggested changes
Having a performance goal can make sense. Stepping ahead and saying all performance problems are QML is odd and not something I'd say we can get behind as is.
Mon, Jun 10
Make sure plasma-localerc is created
I'd say you're not simplifying it, you're changing the logic. This needs to be reflected in the commit message.
I wonder if that's the right API to use from QML, I guess it's fine but marking something as successful by assigning null could feel odd?