- User Since
- Apr 27 2015, 12:34 PM (109 w, 4 h)
Looks good. I'd say it can be committed together with the Android side.
If this is making sure some output match that didn't use to, I suggest adding a test case so that we don't regress in changes like this in the future.
Sat, May 27
Please abandon the patch or fix it.
Or we apply it for master and hope Kirigami 2.2 is released before next Plasma release.
Is there a way where we can include a test to make sure this works properly?
Fri, May 26
Removed unrelated changes
Thu, May 25
Wed, May 24
Tue, May 23
Keep the old reverse.domain-pid notation when not sandboxed
Other than that, LGTM.
I'm not all that into telepathy connection managers though.
Mon, May 22
Can somebody point out a problem with this approach? Or approve instead?
If nobody does I'll just push the patch.