elvisangelaccio (Elvis Angelaccio)
Developer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 16 2015, 4:08 PM (182 w, 6 d)
Availability
Available

Recent Activity

Yesterday

elvisangelaccio added a comment to D19083: Fix crash during shutdown.

Fixes the crash for me, thanks!

Sat, Feb 16, 4:25 PM · Dolphin
elvisangelaccio accepted D18945: New tab should be placed after the current tab.

Please use FEATURE: instead of BUG: in the commit message.

Sat, Feb 16, 3:22 PM · Dolphin
elvisangelaccio committed R318:92368c1e4df9: Add option to choose which view to close (authored by angeloevertonjr).
Add option to choose which view to close
Sat, Feb 16, 3:15 PM
elvisangelaccio closed D18040: Add option to choose which view to close.
Sat, Feb 16, 3:15 PM · Dolphin
elvisangelaccio accepted D18040: Add option to choose which view to close.

Looks good to me now, landing it.

Sat, Feb 16, 3:15 PM · Dolphin
elvisangelaccio added a comment to D18968: Word-wrap KMessageWidget text.

@cfeck What if we use a KSqueezedTextLabel in KMessageWidget instead? That would mostly fix also the 'aaaaaaaaaaaa' case without requiring new API in QLabel.

Sat, Feb 16, 2:37 PM · Dolphin
elvisangelaccio committed R36:0c5243242dce: libzip: rename callback function (authored by elvisangelaccio).
libzip: rename callback function
Sat, Feb 16, 2:22 PM
elvisangelaccio updated the diff for D18769: Fix context for QDateTime::toString() translations.
  • Added warnings
Sat, Feb 16, 2:13 PM · Dolphin
elvisangelaccio requested changes to D18945: New tab should be placed after the current tab.
Sat, Feb 16, 11:26 AM · Dolphin
elvisangelaccio added inline comments to D18915: Fix batchrename changing extension to lower case.
Sat, Feb 16, 11:13 AM · Frameworks

Sun, Feb 10

elvisangelaccio updated the summary of D18769: Fix context for QDateTime::toString() translations.
Sun, Feb 10, 9:42 PM · Dolphin
elvisangelaccio updated the diff for D18769: Fix context for QDateTime::toString() translations.
  • Use untraslated string as fallback
Sun, Feb 10, 9:41 PM · Dolphin
elvisangelaccio added a comment to D18562: Determine isDirectory by "Folder = " field in 7z plugin.

You're welcome :)

Sun, Feb 10, 8:54 PM · Ark
elvisangelaccio committed R36:ca4667adf1cd: Determine isDirectory by "Folder = " field in 7z plugin (authored by gepardo).
Determine isDirectory by "Folder = " field in 7z plugin
Sun, Feb 10, 8:53 PM
elvisangelaccio closed D18562: Determine isDirectory by "Folder = " field in 7z plugin.
Sun, Feb 10, 8:53 PM · Ark
elvisangelaccio accepted D18562: Determine isDirectory by "Folder = " field in 7z plugin.

Thanks. Do you have commit access?

Sun, Feb 10, 8:46 PM · Ark
elvisangelaccio added a comment to D18562: Determine isDirectory by "Folder = " field in 7z plugin.

Please remove the QEXPECT_FAIL at line 498 of cli7ztest.cpp, then this is good to go.

I don't have such line. Should I merge my branch with master?

Sun, Feb 10, 8:43 PM · Ark
elvisangelaccio requested changes to D18562: Determine isDirectory by "Folder = " field in 7z plugin.

Thanks, looks good to me now.

Sun, Feb 10, 8:35 PM · Ark
elvisangelaccio committed R36:6b72fca27326: Merge branch 'Applications/18.12' (authored by elvisangelaccio).
Merge branch 'Applications/18.12'
Sun, Feb 10, 8:15 PM
elvisangelaccio requested changes to D18562: Determine isDirectory by "Folder = " field in 7z plugin.

Thanks, that fixed the tests.

Sun, Feb 10, 7:28 PM · Ark
elvisangelaccio committed R36:95bf2244e5b4: cli7ztest: add failing test case for zip folders with RDA attributes (authored by elvisangelaccio).
cli7ztest: add failing test case for zip folders with RDA attributes
Sun, Feb 10, 6:59 PM
elvisangelaccio requested changes to D18562: Determine isDirectory by "Folder = " field in 7z plugin.
Sun, Feb 10, 6:15 PM · Ark
elvisangelaccio added a comment to D18562: Determine isDirectory by "Folder = " field in 7z plugin.

Failing test case added with 95bf2244e5b4c9fe7901fd50dd662dd514439407 (thanks for the test archive!)

Sun, Feb 10, 6:14 PM · Ark
elvisangelaccio added inline comments to D18562: Determine isDirectory by "Folder = " field in 7z plugin.
Sun, Feb 10, 6:08 PM · Ark
elvisangelaccio added a comment to D18562: Determine isDirectory by "Folder = " field in 7z plugin.

Sorry but this patch breaks the following tests:

Sun, Feb 10, 6:05 PM · Ark
elvisangelaccio added a comment to D18838: Fix opening http links in browser.

+1 otherwise.
Would be nice if we manage to not keep the http link in the URL navigator, but that's probably an unrelated issue.

Sun, Feb 10, 4:57 PM · Dolphin
elvisangelaccio accepted D18152: Preset file name of archive in CreateDialog.
Sun, Feb 10, 4:12 PM · Ark

Thu, Feb 7

elvisangelaccio accepted D18811: [DolphinView] Use correct color group.
Thu, Feb 7, 9:27 PM · Dolphin
elvisangelaccio added a comment to D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency.

Wait, do we need to add this workaround to every popup menu around? What about 3d-party apps?

Thu, Feb 7, 9:14 PM · Frameworks

Wed, Feb 6

elvisangelaccio accepted D18738: Add ebook thumbnailer.
Wed, Feb 6, 9:17 PM · Frameworks, Dolphin

Tue, Feb 5

elvisangelaccio added a comment to D18738: Add ebook thumbnailer.

LGTM

Tue, Feb 5, 9:28 PM · Frameworks, Dolphin
elvisangelaccio added reviewers for D18769: Fix context for QDateTime::toString() translations: lueck, aacid, cfeck.
Tue, Feb 5, 9:10 PM · Dolphin
elvisangelaccio requested review of D18769: Fix context for QDateTime::toString() translations.
Tue, Feb 5, 9:10 PM · Dolphin
elvisangelaccio committed R240:ba3341c83b18: Fix ENABLE_CLAZY option with clazy >= 1.5 (authored by elvisangelaccio).
Fix ENABLE_CLAZY option with clazy >= 1.5
Tue, Feb 5, 8:35 PM
elvisangelaccio closed D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.
Tue, Feb 5, 8:35 PM · Build System, Frameworks

Sun, Feb 3

elvisangelaccio added a comment to D18562: Determine isDirectory by "Folder = " field in 7z plugin.

I'll review it soon. I want to add a test case with your test archive first; feel free to beat me to it :)

Sun, Feb 3, 8:32 PM · Ark
elvisangelaccio accepted D18697: Use more suitable default view mode for recent documents and Downloads folder.
Sun, Feb 3, 5:37 PM · Dolphin
elvisangelaccio updated the summary of D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.
Sun, Feb 3, 5:19 PM · Build System, Frameworks
elvisangelaccio updated the diff for D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.

Addressed comments

Sun, Feb 3, 5:18 PM · Build System, Frameworks

Sat, Feb 2

elvisangelaccio added a comment to D16648: Open externally called files/directories in new tabs.

Also, can you please update the Summary and the Test Plan? We should remove mentions of the option (which we dropped) and we should use FEATURE: instead of BUG:.

Sat, Feb 2, 8:55 PM · Dolphin
elvisangelaccio added a comment to D16648: Open externally called files/directories in new tabs.

I'm not sure if I'm testing this patch the wrong way, but it doesn't seem to work here. What I did:

Sat, Feb 2, 8:52 PM · Dolphin
elvisangelaccio added a comment to D16648: Open externally called files/directories in new tabs.

Can you please rebase the patch? There is new code in dolphinmainwindowtest which needs to be adapted.

Sat, Feb 2, 8:45 PM · Dolphin
elvisangelaccio committed R318:fb4b4465f915: Merge branch 'Applications/18.12' (authored by elvisangelaccio).
Merge branch 'Applications/18.12'
Sat, Feb 2, 8:38 PM
elvisangelaccio added a comment to D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.

Note: this will break with older clazy versions. I'm not sure how to prevent that.
One could argue that a developer interested in clazy should probably run the latest version anyway...

Sat, Feb 2, 5:51 PM · Build System, Frameworks
elvisangelaccio requested review of D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.
Sat, Feb 2, 5:50 PM · Build System, Frameworks
elvisangelaccio committed R241:04082f3c2ce1: Improve keyboard controls of the checksum widget (authored by cfarrell).
Improve keyboard controls of the checksum widget
Sat, Feb 2, 5:24 PM
elvisangelaccio closed D18676: Improve keyboard controls of the checksum widget.
Sat, Feb 2, 5:24 PM · Frameworks
elvisangelaccio accepted D18676: Improve keyboard controls of the checksum widget.

Thanks!

Sat, Feb 2, 5:23 PM · Frameworks
elvisangelaccio accepted D18605: [versioncontrolobserver] Update working directory on tab activation.
Sat, Feb 2, 4:58 PM · Dolphin
elvisangelaccio added a comment to D18273: Bring back KActivities support.

I'll push in a week unless there are objections.

Sat, Feb 2, 4:48 PM · Dolphin

Tue, Jan 29

elvisangelaccio added a comment to D18563: Don't create directory tree when a new folder has a '/' in the name.

I'm also a bit puzzled: are we removing a feature in order to show an error message instead?

Tue, Jan 29, 9:07 PM · Frameworks
elvisangelaccio added a comment to D18605: [versioncontrolobserver] Update working directory on tab activation.

I prefer your previous approach: an "observer" class is not supposed to have public slots, it should react on its own when stuff happens.

Tue, Jan 29, 8:59 PM · Dolphin
elvisangelaccio added a comment to D17640: [versioncontrolobserver] Do not use static plugin objects.

@anthonyfieroni Next time please add the summary of the revision to the actual commit message. You may want to setup arc to do that.

Tue, Jan 29, 8:51 PM · Dolphin
elvisangelaccio added inline comments to D17640: [versioncontrolobserver] Do not use static plugin objects.
Tue, Jan 29, 10:46 AM · Dolphin
elvisangelaccio accepted D17635: After opening and switching to a new tab, always focus the view.
Tue, Jan 29, 10:32 AM · Dolphin

Mon, Jan 28

elvisangelaccio updated the diff for D18273: Bring back KActivities support.
  • Rebased
Mon, Jan 28, 9:46 PM · Dolphin
elvisangelaccio committed R318:8bc93b564c28: Introduce HAVE_TERMINAL (authored by elvisangelaccio).
Introduce HAVE_TERMINAL
Mon, Jan 28, 9:43 PM
elvisangelaccio added a comment to D18273: Bring back KActivities support.

Ping

Mon, Jan 28, 9:19 PM · Dolphin
elvisangelaccio added inline comments to D17640: [versioncontrolobserver] Do not use static plugin objects.
Mon, Jan 28, 9:18 PM · Dolphin
elvisangelaccio added a comment to D17635: After opening and switching to a new tab, always focus the view.

@elvisangelaccio would you be okay with changing the behavior to always focus the view upon opening a new tab as @emateli requests? I'm pretty much fine with anything, but I'd rather we decide on something so this poor patch can come to the end of its end its identity crisis. :-)

Mon, Jan 28, 4:35 PM · Dolphin
elvisangelaccio added a comment to D18562: Determine isDirectory by "Folder = " field in 7z plugin.

Thanks. Can you share a test archive that works with this patch but doesn't without?

Mon, Jan 28, 4:27 PM · Ark

Sat, Jan 19

elvisangelaccio added inline comments to D17635: After opening and switching to a new tab, always focus the view.
Sat, Jan 19, 11:43 AM · Dolphin
elvisangelaccio accepted D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program.

LGTM now.

Sat, Jan 19, 11:35 AM · Dolphin
elvisangelaccio edited reviewers for D18296: Add support for passing cursor information via URL parameters when running kioclient exec., added: Plasma, KTextEditor; removed: KDE Applications.
Sat, Jan 19, 11:25 AM · Plasma
elvisangelaccio accepted D13316: manually set format in jpeg thumbnail creator.
Sat, Jan 19, 11:19 AM · Frameworks, Dolphin
elvisangelaccio updated the diff for D18273: Bring back KActivities support.
  • Added set_package_properties to explain the optional feature
Sat, Jan 19, 11:12 AM · Dolphin

Jan 16 2019

elvisangelaccio accepted D17882: Abort updateWindowTitle and activeViewChanged if not changed..
Jan 16 2019, 6:17 PM · Dolphin

Jan 15 2019

elvisangelaccio committed R318:d23b842a1441: Fix required version for baloo and kfilemetadata (authored by elvisangelaccio).
Fix required version for baloo and kfilemetadata
Jan 15 2019, 6:26 PM
elvisangelaccio committed R318:0634e6833622: Use stable version as required version for baloo-widgets (authored by elvisangelaccio).
Use stable version as required version for baloo-widgets
Jan 15 2019, 6:26 PM
elvisangelaccio committed R318:ae906710bab5: Drop unused config-X11.h.cmake (authored by elvisangelaccio).
Drop unused config-X11.h.cmake
Jan 15 2019, 6:26 PM
elvisangelaccio committed R318:f8196b8cf35c: Drop unused includes (authored by elvisangelaccio).
Drop unused includes
Jan 15 2019, 6:26 PM
elvisangelaccio committed R318:67e7f8132fe3: Fix include style (authored by elvisangelaccio).
Fix include style
Jan 15 2019, 6:26 PM
elvisangelaccio added a comment to D18273: Bring back KActivities support.

Note: I have no clue what KActivities::ResourceInstance actually does, but it doesn't seem to break anything either.

Jan 15 2019, 6:04 PM · Dolphin
elvisangelaccio requested review of D18273: Bring back KActivities support.
Jan 15 2019, 6:02 PM · Dolphin
elvisangelaccio requested changes to D17640: [versioncontrolobserver] Do not use static plugin objects.

Sorry but I can't reproduce the bug you put in the commit message.

Jan 15 2019, 4:22 PM · Dolphin
elvisangelaccio accepted D18256: Remember part URL to delete the tempfile even if the user used save as..

Thanks!

Jan 15 2019, 4:06 PM · Ark
elvisangelaccio added a comment to D17938: Add support for passing cursor information to KRun..

@arrowd I see you landed D18099, so this can be discarded, right?

Jan 15 2019, 4:04 PM · Frameworks
elvisangelaccio accepted D17882: Abort updateWindowTitle and activeViewChanged if not changed..
Jan 15 2019, 3:56 PM · Dolphin

Jan 13 2019

elvisangelaccio committed R36:185678c756e8: Stop defining empty DEPENDENCY_TOOL_ARGS (authored by elvisangelaccio).
Stop defining empty DEPENDENCY_TOOL_ARGS
Jan 13 2019, 4:05 PM
elvisangelaccio added a comment to D17882: Abort updateWindowTitle and activeViewChanged if not changed..

What should I be using as a base for this code? Its currently based upon the Applications/18.12 branch

Jan 13 2019, 3:02 PM · Dolphin
elvisangelaccio committed R36:80a059d44697: Fix clazy-skipped-base-method warnings (authored by elvisangelaccio).
Fix clazy-skipped-base-method warnings
Jan 13 2019, 1:05 PM
elvisangelaccio committed R36:b5d0bcbb485f: Stop using empty QStringLiterals (authored by elvisangelaccio).
Stop using empty QStringLiterals
Jan 13 2019, 1:05 PM
elvisangelaccio committed R36:53ff91a1c56c: Fix clazy-fully-qualified-moc-types warnings (authored by elvisangelaccio).
Fix clazy-fully-qualified-moc-types warnings
Jan 13 2019, 1:05 PM
elvisangelaccio committed R36:96dd78e08304: Port to K_PLUGIN_CLASS_WITH_JSON (authored by elvisangelaccio).
Port to K_PLUGIN_CLASS_WITH_JSON
Jan 13 2019, 1:05 PM
elvisangelaccio committed R36:bf7554f0ae6c: Bump copyright year (authored by elvisangelaccio).
Bump copyright year
Jan 13 2019, 1:05 PM
elvisangelaccio added inline comments to D18152: Preset file name of archive in CreateDialog.
Jan 13 2019, 12:15 PM · Ark
elvisangelaccio accepted D17882: Abort updateWindowTitle and activeViewChanged if not changed..
Jan 13 2019, 9:28 AM · Dolphin

Jan 12 2019

elvisangelaccio requested changes to D18040: Add option to choose which view to close.

For the record I still think that we should add another button rather than a new option. But anyway I think we discussed this enough, let's go with the option.

Jan 12 2019, 3:47 PM · Dolphin
elvisangelaccio added a comment to D18158: Fix elapsed time check.

What else is missing to fix #402665?

Jan 12 2019, 11:57 AM · Frameworks
elvisangelaccio added a comment to D17966: Add missing Comment in .desktop file.

+1

Jan 12 2019, 11:44 AM

Jan 5 2019

elvisangelaccio accepted D17640: [versioncontrolobserver] Do not use static plugin objects.

Well ok, you seem confident enough :)

Jan 5 2019, 6:52 PM · Dolphin
elvisangelaccio added a comment to D17938: Add support for passing cursor information to KRun..

I don't know, "cursorRow" and "cursorColumn" are pretty editor-specific. I'm not sure they make sense in the KRun API.

I'd say they are both filetype-specific and service-specific. But I haven't found any other approach.

Jan 5 2019, 5:33 PM · Frameworks
elvisangelaccio added a reviewer for D17966: Add missing Comment in .desktop file: cfeck.
Jan 5 2019, 5:06 PM
elvisangelaccio added inline comments to D17966: Add missing Comment in .desktop file.
Jan 5 2019, 5:06 PM
elvisangelaccio added a comment to D17938: Add support for passing cursor information to KRun..

I don't know, "cursorRow" and "cursorColumn" are pretty editor-specific. I'm not sure they make sense in the KRun API.

Jan 5 2019, 4:53 PM · Frameworks
elvisangelaccio committed R318:504db3f70262: Fix title update when changing active split view (authored by elvisangelaccio).
Fix title update when changing active split view
Jan 5 2019, 4:36 PM
elvisangelaccio closed D17881: Fix title update when changing active split view.
Jan 5 2019, 4:36 PM · Dolphin

Jan 1 2019

elvisangelaccio accepted D17617: Display error instead of silently failing when asked to create folder that already exists.

I don't have access to a webdav server to test with. Do you know of a public one?

Jan 1 2019, 10:32 PM · Frameworks

Dec 30 2018

elvisangelaccio added a comment to D17617: Display error instead of silently failing when asked to create folder that already exists.

Much better now, but I noticed that with webdavs:// the errore message does not show the name of the new folder:

Dec 30 2018, 11:45 PM · Frameworks
elvisangelaccio added a comment to D17840: Update window title on split toggle..

Alternative fix: D17881

Dec 30 2018, 11:38 PM · Dolphin