- User Since
- Aug 16 2015, 4:08 PM (236 w, 5 d)
Sun, Feb 23
Sorry for the delay, I moved to a new house. I'll resume all pending reviews soon.
Sat, Feb 1
Still does not apply for me.
Jan 26 2020
Patch doesn't seem to apply, can you rebase it on master please?
I don't get why we want to start a rename operation at all, tbf.
I'm still not a big fan of the huge "normal" icon, but at least now they don't look bad as in D11022.
Jan 25 2020
How about "Context Menu Plugins" ?
Jan 19 2020
I noticed the following warning if I close dolphin while kompare is still running:
Haven't tried the dolphin branch yet, just a comment on the API for now.
From a quick look the patch looks good though.
Sorry for the delay, patch looks good but needs some polish.
Looks safe enough to me.
Very nice, much simpler than D18838 ;)
Jan 12 2020
Jan 11 2020
Thanks! Going to push to 19.12.
Sorry, we can't make this an option. Moving the navigator to the toolbar would require lots of changes to the code. We can't possibly maintain both implementations, it would be a nightmare.
Do you have commit access?
Jan 6 2020
Fixed, it was a problem on my end. I'm going to push it, thanks!
Just minor nitpicks, looks good otherwise.
It seems to me that moving the url navigator to the toolbar creates more problems than it solves, because of split views.
Can you please rebase this patch? It doesn't apply currently.
Yes, the fix is correct. Feel free to submit patches for all affected apps :)
Update: Google still hasn't verified my app after months, but I noticed that the libkgapi's embedded web browser fails to meet Google's security standards anyway (too old webengine?):
Is it possible to add a test case in dolphinquerytest.cpp?
@nicolasfella I don't like the hardcoding of 48. If there is no clean way to port IconSize(KIconLoader::Desktop), I'd prefer to port to a different non-hardcoded size.
Jan 2 2020
Please update the commit message before pushing.
Dec 29 2019
@heikobecker are you still interested in this patch? I can take over otherwise.
Dec 28 2019
So the threshold is now 50%? Isn't that a bit too low?
Dec 26 2019
Dec 24 2019
Dec 21 2019
Not in the current version, I'm afraid.
Go for it
Do you mind splitting this into a renaming-only patch and another patch for the changes to the logic?
Dec 15 2019