elvisangelaccio (Elvis Angelaccio)
Developer

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 16 2015, 4:08 PM (132 w, 5 h)
Availability
Available

Recent Activity

Today

elvisangelaccio moved T8081: Job::doKill should not trigger the result signal from In progress to Done on the Ark board.
Sun, Feb 25, 5:17 PM · Ark
elvisangelaccio added inline comments to D10149: baloo-widgets: Add autotest for asychronously extracted data.
Sun, Feb 25, 5:16 PM · Baloo
elvisangelaccio accepted D10149: baloo-widgets: Add autotest for asychronously extracted data.
Sun, Feb 25, 5:15 PM · Baloo
elvisangelaccio added a comment to D10149: baloo-widgets: Add autotest for asychronously extracted data.

Almost there!

Sun, Feb 25, 5:01 PM · Baloo
elvisangelaccio triaged T8084: Interface functions should return an enum rather than a bool as High priority.
Sun, Feb 25, 4:45 PM · Ark
elvisangelaccio triaged T8083: LibzipPlugin::testArchive() is memory hungry as High priority.
Sun, Feb 25, 4:28 PM · Ark
elvisangelaccio added inline comments to D10149: baloo-widgets: Add autotest for asychronously extracted data.
Sun, Feb 25, 3:46 PM · Baloo
elvisangelaccio added a comment to D10149: baloo-widgets: Add autotest for asychronously extracted data.

Should work now. Is there an easy way to recognize these problems beforehand?

Sun, Feb 25, 3:27 PM · Baloo
elvisangelaccio triaged T8081: Job::doKill should not trigger the result signal as High priority.
Sun, Feb 25, 3:26 PM · Ark
elvisangelaccio added a comment to D10149: baloo-widgets: Add autotest for asychronously extracted data.

Hmm, needs more rebase?

Sun, Feb 25, 3:08 PM · Baloo
elvisangelaccio added a comment to D10804: Show "Empty trash" button inside trash directory.

There is 3 places that is responsible for emptying trash. 2 of them use code from trash/dolphintrash.cpp. Third place is https://github.com/KDE/dolphin/blob/master/src/panels/places/placespanel.cpp#L458

The code differs a little bit and I don't understand why. What should we do with that?

Sun, Feb 25, 3:04 PM · Dolphin
elvisangelaccio added a comment to D10804: Show "Empty trash" button inside trash directory.

I'd be ok with a KMessageWidget, not the perfect solution but surely the easiest.
If you can manage to dinamically show the button in the toolbar as @rkflx suggested, that would be better for sure.

Sun, Feb 25, 3:02 PM · Dolphin
elvisangelaccio accepted D10834: filemetadatawidget: Use object names.
Sun, Feb 25, 2:11 PM · Baloo
elvisangelaccio updated subscribers of D10832: Replace all enum to enum class.

Thanks for the patch.

Sun, Feb 25, 2:10 PM · Dolphin
elvisangelaccio accepted D10833: Remove dataavailable signal.
Sun, Feb 25, 1:57 PM · Baloo
elvisangelaccio added inline comments to D10834: filemetadatawidget: Use object names.
Sun, Feb 25, 1:57 PM · Baloo
elvisangelaccio committed R36:0f02f13ea370: Add apidox to cancelled() signal (authored by elvisangelaccio).
Add apidox to cancelled() signal
Sun, Feb 25, 12:39 PM
elvisangelaccio committed R36:92c2684c1e58: Merge branch 'Applications/17.12' (authored by elvisangelaccio).
Merge branch 'Applications/17.12'
Sun, Feb 25, 12:39 PM
elvisangelaccio committed R36:5e2f31633a7b: Fix apidox copy-paste bug (authored by elvisangelaccio).
Fix apidox copy-paste bug
Sun, Feb 25, 12:39 PM
elvisangelaccio committed R36:d36f3880564f: Fix valgrind uninitialised warnings (authored by elvisangelaccio).
Fix valgrind uninitialised warnings
Sun, Feb 25, 12:39 PM
elvisangelaccio committed R36:910d28721756: Fix mismatched new[] / delete[] valgrind warning (authored by elvisangelaccio).
Fix mismatched new[] / delete[] valgrind warning
Sun, Feb 25, 12:39 PM
elvisangelaccio moved T7824: [libzip] Check kill operation for each type of job from Backlog to In progress on the Ark board.
Sun, Feb 25, 12:37 PM · Ark
elvisangelaccio moved T6707: Jobs should properly set an error if they fail from Backlog to In progress on the Ark board.
Sun, Feb 25, 12:31 PM · Ark
elvisangelaccio committed R36:92fe1c13bf50: Mark canceled extractions as killed jobs (authored by elvisangelaccio).
Mark canceled extractions as killed jobs
Sun, Feb 25, 12:31 PM
elvisangelaccio added a comment to D10149: baloo-widgets: Add autotest for asychronously extracted data.

Tests now pass for me! But I agree that splitting this diff would be good.

Sun, Feb 25, 8:46 AM · Baloo

Yesterday

elvisangelaccio committed R36:b36f24ed69d1: Drop dead code (authored by elvisangelaccio).
Drop dead code
Sat, Feb 24, 11:53 PM
elvisangelaccio committed R36:3c30ef508f71: Add apidox for waitForFinishedSignal() (authored by elvisangelaccio).
Add apidox for waitForFinishedSignal()
Sat, Feb 24, 11:53 PM
elvisangelaccio triaged T8072: [libzip] Always call zip_close() as Normal priority.
Sat, Feb 24, 11:20 PM · Ark
elvisangelaccio added a comment to T7824: [libzip] Check kill operation for each type of job.

The test does can react to QThread::requestInterruption(), instead. It just doesn't currently do it.

Sat, Feb 24, 11:08 PM · Ark
elvisangelaccio added a comment to T7824: [libzip] Check kill operation for each type of job.

Possible solution: call zip_discard(m_archive) in LibzipPlugin::doKill() (where m_archive stores the zip_t* returned by zip_open()).
Howewer this needs a mutex, since we are freeing m_archive from the main thread (while it was created in the secondary thread).

Sat, Feb 24, 7:16 PM · Ark
elvisangelaccio updated the diff for D10312: FileUndoManager: don't delete non-existing local files.
  • Improved unit test
  • Replaced slotUnlock() with slotPop()
Sat, Feb 24, 6:28 PM · Frameworks
elvisangelaccio added reviewers for D10801: LocalLister: always append trailing slash if it's a folder: sandsmark, sitter.
Sat, Feb 24, 5:37 PM
elvisangelaccio requested review of D10801: LocalLister: always append trailing slash if it's a folder.
Sat, Feb 24, 5:37 PM

Sun, Feb 18

elvisangelaccio committed R36:2610eebcd0e1: Merge branch 'Applications/17.12' (authored by elvisangelaccio).
Merge branch 'Applications/17.12'
Sun, Feb 18, 10:39 PM
elvisangelaccio committed R36:2af8d35e362b: Stop crashing when all read-write plugins are disabled (authored by elvisangelaccio).
Stop crashing when all read-write plugins are disabled
Sun, Feb 18, 10:34 PM
elvisangelaccio added a reviewer for D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full: dfaure.
Sun, Feb 18, 5:54 PM · Frameworks
elvisangelaccio added a comment to D10532: [Information Panel] Adjust painting icons for high dpi scaling.

So, what's wrong with KIconLoader? Shouldn't we fix it?

Sun, Feb 18, 5:53 PM
elvisangelaccio added a comment to D10149: baloo-widgets: Add autotest for asychronously extracted data.

Crash is gone, but now I get two failures:

Sun, Feb 18, 5:42 PM · Baloo
elvisangelaccio added inline comments to D10149: baloo-widgets: Add autotest for asychronously extracted data.
Sun, Feb 18, 5:32 PM · Baloo
elvisangelaccio added inline comments to D10312: FileUndoManager: don't delete non-existing local files.
Sun, Feb 18, 11:57 AM · Frameworks
elvisangelaccio added inline comments to D10149: baloo-widgets: Add autotest for asychronously extracted data.
Sun, Feb 18, 11:15 AM · Baloo
elvisangelaccio requested changes to D10149: baloo-widgets: Add autotest for asychronously extracted data.

FileMetadataWidgetTest::shouldShowProperties() is crashing for me.

Sun, Feb 18, 11:12 AM · Baloo
elvisangelaccio added a comment to D10617: Fix "ambiguous shortcut" issue introduced with D10314.

The shortcut won't affect other apps since the file dialog its its own context. Even if the host app uses F12 for something, the file dialog will grab the key first, so there's no "ambiguous shortcut" issue.

Sun, Feb 18, 10:45 AM · Frameworks

Sat, Feb 17

elvisangelaccio added a comment to D10617: Fix "ambiguous shortcut" issue introduced with D10314.

Would be nice to get more feedback before choosing a shortcut that affects many applications.

Sat, Feb 17, 10:53 PM · Frameworks
elvisangelaccio updated the summary of D9806: KIOGDrive::copy - resolve the destGDriveUrl's new parent into a destDirId before passing it to FileCopyJob in src/kio_gdrive.cpp.
Sat, Feb 17, 6:55 PM · KIO GDrive
elvisangelaccio added a comment to D9806: KIOGDrive::copy - resolve the destGDriveUrl's new parent into a destDirId before passing it to FileCopyJob in src/kio_gdrive.cpp.

The patch seems to fix the problem, great!
Code looks good beside the inline comment.

Sat, Feb 17, 6:54 PM · KIO GDrive
elvisangelaccio triaged T7996: Fix permissions on shared folders as High priority.
Sat, Feb 17, 6:49 PM · KIO GDrive
elvisangelaccio triaged T7995: Fix "finished() called after error()" warnings as Normal priority.
Sat, Feb 17, 6:20 PM · KIO GDrive
elvisangelaccio added a comment to D9675: Don't show context menu menu if right-clicking outside.

+1 works for me.

Sat, Feb 17, 5:44 PM · Frameworks
elvisangelaccio added a reviewer for D9675: Don't show context menu menu if right-clicking outside: dfaure.
Sat, Feb 17, 5:43 PM · Frameworks
elvisangelaccio added a comment to D10340: Clean up old, unreachable code.

+1

Sat, Feb 17, 5:34 PM · Frameworks
elvisangelaccio added a reviewer for D10340: Clean up old, unreachable code: dfaure.
Sat, Feb 17, 5:34 PM · Frameworks
elvisangelaccio accepted D10558: Also use standard keyboard shortcut for "show/hide hidden files".

Please ask release-team@kde.org whether we can ship this on 17.12

Sat, Feb 17, 5:32 PM
elvisangelaccio added a comment to D10609: Make "Split" checkable.

How come, out of curiosity? I would argue that making Split checkable matches the user expectation (not the developer expectation) better than the current approach.

Sat, Feb 17, 5:12 PM
elvisangelaccio added a comment to D10609: Make "Split" checkable.

Sorry but #208023 should be closed as wontfix.

Sat, Feb 17, 4:47 PM
elvisangelaccio added a comment to D10558: Also use standard keyboard shortcut for "show/hide hidden files".

Thanks! I was thinking of putting Ctrl+H first because that's what people will see when they first go looking for the feature in the menus.

Sat, Feb 17, 4:36 PM

Fri, Feb 16

elvisangelaccio added a comment to D10558: Also use standard keyboard shortcut for "show/hide hidden files".

This is a new feature so it should not got in the stable branch (unless we ask for an exception to the release team).

Fri, Feb 16, 7:51 PM

Tue, Feb 13

elvisangelaccio added a comment to D9806: KIOGDrive::copy - resolve the destGDriveUrl's new parent into a destDirId before passing it to FileCopyJob in src/kio_gdrive.cpp.

Ah right, so this is https://bugs.kde.org/show_bug.cgi?id=376735

Tue, Feb 13, 10:30 PM · KIO GDrive
elvisangelaccio committed R318:5f57256a2f29: Merge branch 'Applications/17.12' (authored by elvisangelaccio).
Merge branch 'Applications/17.12'
Tue, Feb 13, 10:21 PM
elvisangelaccio committed R318:a618383df384: Fix resetting "View Modes" preferences to defaults (authored by hoffmannrobert).
Fix resetting "View Modes" preferences to defaults
Tue, Feb 13, 10:21 PM
elvisangelaccio closed D10190: Fix resetting "View Modes" preferences to defaults.
Tue, Feb 13, 10:21 PM · Dolphin
elvisangelaccio accepted D10190: Fix resetting "View Modes" preferences to defaults.
Tue, Feb 13, 10:17 PM · Dolphin

Sun, Feb 11

elvisangelaccio added a comment to D10006: Build TerminalPanel also on Windows.
Sun, Feb 11, 10:47 PM
elvisangelaccio committed R318:e136d8cfeb1d: Fix Windows build (authored by elvisangelaccio).
Fix Windows build
Sun, Feb 11, 10:04 PM
elvisangelaccio committed R318:3dcfb753624c: Fix typo (authored by elvisangelaccio).
Fix typo
Sun, Feb 11, 10:03 PM
elvisangelaccio added a comment to D10006: Build TerminalPanel also on Windows.

Crap. I'll have a look later today.

Sun, Feb 11, 9:35 AM

Sat, Feb 10

elvisangelaccio committed R318:87e8d0ba5f80: Build TerminalPanel also on Windows (authored by elvisangelaccio).
Build TerminalPanel also on Windows
Sat, Feb 10, 9:35 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Sat, Feb 10, 9:35 PM
elvisangelaccio added inline comments to D10312: FileUndoManager: don't delete non-existing local files.
Sat, Feb 10, 9:18 PM · Frameworks
elvisangelaccio requested changes to D10149: baloo-widgets: Add autotest for asychronously extracted data.
Sat, Feb 10, 8:43 PM · Baloo
elvisangelaccio added a comment to D10149: baloo-widgets: Add autotest for asychronously extracted data.

Can you look at the files autotests/testtagged.* and check if they have rating = 5?

Sat, Feb 10, 6:37 PM · Baloo
elvisangelaccio added a comment to D10149: baloo-widgets: Add autotest for asychronously extracted data.

Same here:

Sat, Feb 10, 6:32 PM · Baloo
elvisangelaccio added inline comments to D10190: Fix resetting "View Modes" preferences to defaults.
Sat, Feb 10, 6:21 PM · Dolphin
elvisangelaccio accepted D10119: baloo-widgets: Create test to assert metaDataRequestFinished is emitted once only.

Thanks!

Sat, Feb 10, 5:26 PM
elvisangelaccio committed R219:69bc358d195c: MIME type correction for .ods files in src/gdrivehelper.cpp (authored by martijnschmidt).
MIME type correction for .ods files in src/gdrivehelper.cpp
Sat, Feb 10, 4:57 PM
elvisangelaccio closed D9706: MIME type correction for .ods files in src/gdrivehelper.cpp.
Sat, Feb 10, 4:57 PM · KIO GDrive
elvisangelaccio added reviewers for D9806: KIOGDrive::copy - resolve the destGDriveUrl's new parent into a destDirId before passing it to FileCopyJob in src/kio_gdrive.cpp: elvisangelaccio, dvratil.
Sat, Feb 10, 4:44 PM · KIO GDrive
elvisangelaccio added a comment to D9806: KIOGDrive::copy - resolve the destGDriveUrl's new parent into a destDirId before passing it to FileCopyJob in src/kio_gdrive.cpp.

I'm not sure I'm following: all the 3 steps in the test plan work for me, without this patch.
Is there something else needed to trigger the bug?

Sat, Feb 10, 4:44 PM · KIO GDrive
elvisangelaccio added inline comments to D9775: Trash behaviour improvements: check for the amount of parentReference items on a fileId before processing the delete command in src/kio_gdrive.cpp.
Sat, Feb 10, 4:40 PM · KIO GDrive
elvisangelaccio accepted D9706: MIME type correction for .ods files in src/gdrivehelper.cpp.
Sat, Feb 10, 4:31 PM · KIO GDrive
elvisangelaccio added inline comments to D10119: baloo-widgets: Create test to assert metaDataRequestFinished is emitted once only.
Sat, Feb 10, 4:28 PM
elvisangelaccio triaged T7938: Inline comments at wrong places after diff updates as Normal priority.
Sat, Feb 10, 4:21 PM · Phabricator

Fri, Feb 9

elvisangelaccio added a comment to D10119: baloo-widgets: Create test to assert metaDataRequestFinished is emitted once only.

My inline comments do not appear where they should.

  • Deleting cleanupTestCase() gave a linker error.
Fri, Feb 9, 11:19 PM
elvisangelaccio added a comment to D10119: baloo-widgets: Create test to assert metaDataRequestFinished is emitted once only.

Almost there, just coding style issues now :)

Fri, Feb 9, 10:20 PM
elvisangelaccio requested changes to D10119: baloo-widgets: Create test to assert metaDataRequestFinished is emitted once only.

Treated all test equally: QVERIFY(spy.wait(xxx)); -> spy.wait(xxx)
shouldSignalOnceWithoutFile() and shouldSignalOnceWithEmptyFile() still fail, the others pass.

Just to see what would happen I changed filemetadataprovider.cpp:465 to

KFileItemList FileMetaDataProvider::items() const
{
    return m_fileItems.isEmpty() 
        ? KFileItemList() << QUrl(QStringLiteral("file:///"))
        : m_fileItems;
}

Now all tests pass.

The crux must be in build/kde/applications/baloo-widgets/src/KF5BalooWidgets_autogen/include/moc_filemetadatawidget.cpp:

// SIGNAL 1
void Baloo::FileMetaDataWidget::metaDataRequestFinished(const KFileItemList & _t1)
{
    void *_a[] = { nullptr, const_cast<void*>(reinterpret_cast<const void*>(&_t1)) };
    QMetaObject::activate(this, &staticMetaObject, 1, _a);
}

I can't read this, but hopefully you can tell why there is no signal when _t1 is an empty list.

Fri, Feb 9, 8:50 PM
elvisangelaccio accepted D10267: [fileviewgitplugin] Add log action.
Fri, Feb 9, 8:23 PM

Thu, Feb 8

elvisangelaccio requested changes to D10119: baloo-widgets: Create test to assert metaDataRequestFinished is emitted once only.

@elvisangelaccio: D10113 currently fails shouldSignalOnceWithoutFile() and shouldSignalOnceWithEmptyFile() for reasons I don't understand. The correct code path is taken, but no signal is emitted in src/filemetadatawidget.cpp:119
I hadn't pushed D10113 because I was waiting for your comment on this.

Thu, Feb 8, 9:20 PM
elvisangelaccio added a comment to D10267: [fileviewgitplugin] Add log action.

Is it normal that the dolphin process does not quit if I close the dolphin window but not the Git Log window?

Thu, Feb 8, 8:56 PM
elvisangelaccio added a comment to D10267: [fileviewgitplugin] Add log action.

Can you please rebase the patch? It doesn't apply currently

Thu, Feb 8, 8:47 PM
elvisangelaccio added a comment to D10267: [fileviewgitplugin] Add log action.

Can you please rebase the patch? It doesn't apply currently

Thu, Feb 8, 8:43 PM

Wed, Feb 7

elvisangelaccio added a comment to D10119: baloo-widgets: Create test to assert metaDataRequestFinished is emitted once only.

@michaelh Why is D10113 not pushed yet? You need to rebase this patch on top of master *after* you push D10113.

Wed, Feb 7, 8:46 PM
elvisangelaccio added a reviewer for D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu: dfaure.
Wed, Feb 7, 8:27 PM · Frameworks
elvisangelaccio added a comment to D10362: Swap reveal password button logic.

Hmm I don't know, that's a button and a button should tell me what happens when I click it (Dolphin is also wrong imho).

Wed, Feb 7, 8:26 PM · Frameworks, Plasma

Sun, Feb 4

elvisangelaccio updated the summary of D10312: FileUndoManager: don't delete non-existing local files.
Sun, Feb 4, 10:22 PM · Frameworks
elvisangelaccio accepted D10085: Faster drag&drop in directories with thousands of files.

Thanks :)

Sun, Feb 4, 8:26 PM
elvisangelaccio added a comment to D10119: baloo-widgets: Create test to assert metaDataRequestFinished is emitted once only.

error: could not apply 88a775b... baloo-widgets: Apply coding style to filemetadataprovider

Sun, Feb 4, 5:22 PM
elvisangelaccio added a comment to D10085: Faster drag&drop in directories with thousands of files.

Almost there, I could not find regressions this time :)

Sun, Feb 4, 4:36 PM
elvisangelaccio added inline comments to D9775: Trash behaviour improvements: check for the amount of parentReference items on a fileId before processing the delete command in src/kio_gdrive.cpp.
Sun, Feb 4, 4:01 PM · KIO GDrive
elvisangelaccio committed R36:ef02eaaee5f6: Merge branch 'Applications/17.12' (authored by elvisangelaccio).
Merge branch 'Applications/17.12'
Sun, Feb 4, 3:24 PM
elvisangelaccio committed R36:cec095d69f1d: CreateDialog: remove trailing whitespace after last separator (authored by elvisangelaccio).
CreateDialog: remove trailing whitespace after last separator
Sun, Feb 4, 3:24 PM