elvisangelaccio (Elvis Angelaccio)
Developer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Aug 16 2015, 4:08 PM (140 w, 2 d)
Availability
Available

Recent Activity

Today

elvisangelaccio requested changes to D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility.
Wed, Apr 25, 11:58 AM · Frameworks
elvisangelaccio committed R318:362244ccbe69: DolphinTabPage: deactivate secondary view after closing split view (authored by elvisangelaccio).
DolphinTabPage: deactivate secondary view after closing split view
Wed, Apr 25, 11:43 AM
elvisangelaccio committed R318:9ec813597430: Merge branch 'Applications/18.04' (authored by elvisangelaccio).
Merge branch 'Applications/18.04'
Wed, Apr 25, 11:25 AM
elvisangelaccio committed R318:78c8b36dd84a: Update window title after closing split view (authored by rjennings).
Update window title after closing split view
Wed, Apr 25, 10:50 AM
elvisangelaccio closed D12446: Update window title after closing split view.
Wed, Apr 25, 10:50 AM
elvisangelaccio committed R318:74c2d4ea2d25: Add failing test case for bug #385111 (authored by elvisangelaccio).
Add failing test case for bug #385111
Wed, Apr 25, 10:50 AM
elvisangelaccio accepted D12446: Update window title after closing split view.

This is indeed the proper fix, since m_primaryViewActive will be set to true again in slotViewActivated(). I also added a test case for this bug.

Wed, Apr 25, 10:43 AM
elvisangelaccio requested changes to D12508: Make KMessageWidget match Kirigami inlineMessage's style.
Wed, Apr 25, 8:20 AM · Frameworks

Yesterday

elvisangelaccio added a comment to D12464: Fix the test that broke after recent changes to the default Places items.

This will only fix the test if you have a recent enough version of KIO. I wonder if we can find a more robust solution (which we'd also need in the 18.04 branch).

Tue, Apr 24, 9:43 PM

Mon, Apr 23

elvisangelaccio added a comment to D12446: Update window title after closing split view.

From a quick look it seems there is something strange going on here. I'll investigate in the next days, please don't push it yet.

Mon, Apr 23, 9:46 PM

Sun, Apr 22

elvisangelaccio added a comment to D12389: Filepicker reads thumbs preview from Dolphin settings.

One more reason to move this stuff from the Dolphin settings into a KCM...

Sun, Apr 22, 3:21 PM · Frameworks
elvisangelaccio added inline comments to D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility.
Sun, Apr 22, 3:06 PM · Frameworks
elvisangelaccio committed R36:a5fc055dae51: flatpak: enable graphics acceleration (authored by elvisangelaccio).
flatpak: enable graphics acceleration
Sun, Apr 22, 2:45 PM
elvisangelaccio committed R36:dc3581c3dab2: flatpak: drop QT_QPA_PLATFORM=flatpak (authored by elvisangelaccio).
flatpak: drop QT_QPA_PLATFORM=flatpak
Sun, Apr 22, 2:45 PM
elvisangelaccio committed R136:5bb4911c0038: flatpak: enable graphics acceleration (authored by elvisangelaccio).
flatpak: enable graphics acceleration
Sun, Apr 22, 2:42 PM
elvisangelaccio committed R136:12f2dd89cfb2: flatpak: enable dbus (authored by elvisangelaccio).
flatpak: enable dbus
Sun, Apr 22, 2:42 PM
elvisangelaccio committed R136:44e4c242fdea: flatpak: drop QT_QPA_PLATFORM=flatpak (authored by elvisangelaccio).
flatpak: drop QT_QPA_PLATFORM=flatpak
Sun, Apr 22, 2:42 PM
elvisangelaccio accepted D11884: Move "Open" actions to the top of the context menu for files.
Sun, Apr 22, 10:57 AM

Sat, Apr 21

elvisangelaccio requested changes to D11884: Move "Open" actions to the top of the context menu for files.

UI looks good now, but I think there is still room for improvements in the code. See inline comment.

Sat, Apr 21, 3:38 PM
elvisangelaccio added a comment to D12327: Show Detailed Tree View by default.

I'm not sure I agree with this change

At least it's not a -1 yet, so maybe we can convince you once everything is in place…!?

afaik Windows does not show the tree view by default in its file dialogs (unless you are referring to FolderBrowserDialog from .Net)

Testing Internet Explorer, Paint and Notepad, all show this detailed view (Explorer too!). Only when switching to the Pictures folder the view is changed to "text under icons". For a non-Microsoft app I tested Firefox, which also has detailed view. If you asked me, I'd say that's the default experience people get on Windows.

Sat, Apr 21, 11:00 AM · Frameworks
elvisangelaccio committed R219:dca0b5306e0e: Merge branch '1.2' (authored by elvisangelaccio).
Merge branch '1.2'
Sat, Apr 21, 10:36 AM
elvisangelaccio committed R219:1cf643905379: Bump version (authored by elvisangelaccio).
Bump version
Sat, Apr 21, 10:35 AM
elvisangelaccio committed R219:d7e9258267b1: Add a copy of the GPL3 license. (authored by elvisangelaccio).
Add a copy of the GPL3 license.
Sat, Apr 21, 10:35 AM
elvisangelaccio removed a reviewer for D12342: Update CMakeLists.txt: Frameworks.
Sat, Apr 21, 10:23 AM · Baloo
elvisangelaccio removed a member for Frameworks: elvisangelaccio.
Sat, Apr 21, 10:22 AM
elvisangelaccio requested changes to D12342: Update CMakeLists.txt.
Sat, Apr 21, 10:22 AM · Baloo
elvisangelaccio accepted D12374: libzipplugin: Add missing <memory> header.
Sat, Apr 21, 10:03 AM · Ark
elvisangelaccio added a comment to D12327: Show Detailed Tree View by default.

I'm not sure I agree with this change, and afaik Windows does not show the tree view by default in its file dialogs (unless you are referring to FolderBrowserDialog from .Net)

Sat, Apr 21, 9:34 AM · Frameworks

Mon, Apr 16

elvisangelaccio added inline comments to D12240: Save the dialog view settings when closing the dialog without hitting the cancel button.
Mon, Apr 16, 9:07 PM · Plasma
elvisangelaccio added a comment to D11245: infopanel: Add choice of date display formats.

This patch should have bumped the minimum required version of baloo-widgets.

The current baloo-widgets version 5.0.0 (build/baloowidgets_version.h) has not been changed since April 2014 (https://cgit.kde.org/baloo-widgets.git/diff/CMakeLists.txt?id=a62a6a223b7927bcc18c625f436e454b6601255e). Shouldn't that be bumped first?
Contrary to baloo it seems not to be bumped automatically.

Mon, Apr 16, 9:03 PM · KDE Applications, Dolphin

Sun, Apr 15

elvisangelaccio added a comment to D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views.

I don't believe there's any getting around having two entries in the available actions for toolbar/menu editing. Perhaps one could be given a different label and/or icon? It's awkward because they're both "find"-related actions, but have to be implemented separately.

Sun, Apr 15, 9:26 PM
elvisangelaccio added a comment to D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views.

I get a crash when I try to open the control menu:

Sun, Apr 15, 9:24 PM
elvisangelaccio requested changes to D11245: infopanel: Add choice of date display formats.
Sun, Apr 15, 9:06 PM · KDE Applications, Dolphin
elvisangelaccio reopened D11245: infopanel: Add choice of date display formats.

This patch should have bumped the minimum required version of baloo-widgets.

Sun, Apr 15, 9:06 PM · KDE Applications, Dolphin
elvisangelaccio added a comment to D12234: Update unit tests after removing "this month" and "last month" items .

+1

Sun, Apr 15, 8:51 PM · Frameworks
elvisangelaccio accepted D12206: Don't show top "Open With" app for folders; only for files.

As for D11569, make sure we don't break the konqueror test before pushing.

Sun, Apr 15, 4:46 PM · Frameworks
elvisangelaccio added a comment to D12206: Don't show top "Open With" app for folders; only for files.

Henrik suggested it:

+1 for only showing the Open With menu, without an additional top app. (But make sure to consolidate the number of separators…)

But I can do that in another patch.

Sun, Apr 15, 4:42 PM · Frameworks
elvisangelaccio added inline comments to D12206: Don't show top "Open With" app for folders; only for files.
Sun, Apr 15, 4:37 PM · Frameworks
elvisangelaccio added a comment to D12206: Don't show top "Open With" app for folders; only for files.

Yes, what I meant was to show only the "Open with" entry for folders.

Sun, Apr 15, 4:31 PM · Frameworks

Mon, Apr 9

elvisangelaccio accepted D12039: Add more tab access functions.
Mon, Apr 9, 8:24 PM
elvisangelaccio accepted D11703: Select and scroll to the file for "Open path" and "Open Path in New Window" operations.
Mon, Apr 9, 8:23 PM
elvisangelaccio added a comment to T8473: Dolphin 'Find' button behavior.

For the record, see also D10246 and https://git.reviewboard.kde.org/r/127054/

Mon, Apr 9, 8:23 PM · Dolphin

Sun, Apr 8

elvisangelaccio requested changes to D11304: Fix bug where dolphin fails to select any item where a path is created using "Create New | Folder".
Sun, Apr 8, 3:14 PM
elvisangelaccio accepted D11048: Convert hard coded shortcuts to standard keys.
Sun, Apr 8, 3:05 PM
elvisangelaccio added a comment to D11324: Select files instead of opening them when trying to open a QUrl as a directory when in fact it is a file..

The feature is that you can open a file by typing its name in the url navigator, see e9463ffe2ac11019.

That does sound like a feature we'd be breaking which I was unaware of.

@emateli Sounds like plasma should pass the --select paramater then?

I'm not sure why the shell should be aware on how to launch Dolphin with special parameters when the parameter is a file or a directory. The way it is now is consistent with all DE that i've used so far.

With that in mind however I'd like to propose the following:

  • We keep and fix the navigation from the KUrlNavigator. If a directory is typed in then the view will change, otherwise if it's a file, the application will launch it while remaining in the same directory. This IMO should work only for local files (and it's also much easier to implement, at that). If you type some ftp url it should not execute it (but with the current patch it will select it)
  • We change the behaviour of the parameter to what the patch proposes. No file execition when launched from the shell but rather selection.
  • When requesting to browse a file which is an archive it will be opened inside Dolphin only when the appropriate configuration is active, otherwise it will fallback to the default behaviour(run if via kurlnavigator) otherwise select. (This one I'm less convinced overall, but seems like a more consistent behaviour given that the BrowseThroughArchives setting exists)

    Thoughts?
Sun, Apr 8, 3:00 PM
elvisangelaccio added a comment to D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files.

Go for it!

Sun, Apr 8, 1:21 PM · Plasma
elvisangelaccio added a comment to D10141: Restore Persistence=session for the file ioslave kauth helper.

@fvogt @lbeltrame @davidedmundson Any remaining objections?

Sun, Apr 8, 11:05 AM · Frameworks
elvisangelaccio requested changes to D11884: Move "Open" actions to the top of the context menu for files.
Sun, Apr 8, 11:04 AM
elvisangelaccio added a comment to D11569: Improve consistency of "Open With" UI by always showing top app inline.

I didn't notice that this change also affects the context menu of folders. That doesn't make much sense and just clutters the menu, imho.

Sun, Apr 8, 10:52 AM · Frameworks
elvisangelaccio added a comment to D11979: Automatically show and hide selection markers based on single click/double click setting.

I also don't see the problem of double click + selection markers and I don't understand why Folder View doesn't show them.

Sun, Apr 8, 10:06 AM
elvisangelaccio requested changes to D12039: Add more tab access functions.
Sun, Apr 8, 9:55 AM
elvisangelaccio added a comment to D11990: use the same bound check as setCurrentItem when setting m_currentItem manually.

Yes. Thanks!

Sun, Apr 8, 9:43 AM
elvisangelaccio accepted D11990: use the same bound check as setCurrentItem when setting m_currentItem manually.

I don't think there is a logic bug, this is just a missing check for an off-by-one error caused by the places panel (if you hide it, the warning is gone).

Sun, Apr 8, 9:38 AM
elvisangelaccio added a comment to D11703: Select and scroll to the file for "Open path" and "Open Path in New Window" operations.

Commit message also needs to be updated (it should not mention 'open in new tab' or it should say why we are ignoring it).

Sun, Apr 8, 8:55 AM

Sat, Apr 7

elvisangelaccio added inline comments to D12027: Fix obscured 'Comment' bug.
Sat, Apr 7, 7:27 PM · Baloo
elvisangelaccio added a comment to D11871: [DolphinTabWidget] Rewrite tab widget close.

I cannot reproduce with Qt 5.11, let's see if someone else can.

Sat, Apr 7, 3:44 PM
elvisangelaccio requested changes to D11703: Select and scroll to the file for "Open path" and "Open Path in New Window" operations.
Sat, Apr 7, 3:41 PM
elvisangelaccio added a comment to D11703: Select and scroll to the file for "Open path" and "Open Path in New Window" operations.

Ok, I was finally able to reproduce the issue. I'll investigate in the next days...

Sat, Apr 7, 3:36 PM
elvisangelaccio added a comment to D11871: [DolphinTabWidget] Rewrite tab widget close.

I cannot reproduce the loop of FocusIn events. At step 4. there is only one searchbox (the one in the first tab), the new tab doesn't have a searchbox when I open it.

Sat, Apr 7, 2:01 PM
elvisangelaccio accepted D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files.
Sat, Apr 7, 11:35 AM · Plasma

Thu, Apr 5

elvisangelaccio committed R318:5413025f0b26: Merge branch 'Applications/18.04' (authored by elvisangelaccio).
Merge branch 'Applications/18.04'
Thu, Apr 5, 9:31 PM
elvisangelaccio committed R318:e9192259f6fd: Improve QDialogButtonBox::Yes override text (authored by elvisangelaccio).
Improve QDialogButtonBox::Yes override text
Thu, Apr 5, 9:31 PM
elvisangelaccio closed D11892: Improve QDialogButtonBox::Yes override text.
Thu, Apr 5, 9:30 PM
elvisangelaccio committed R318:30349ef1bdca: [RenameDialog] Fix crash when renaming single items (authored by elvisangelaccio).
[RenameDialog] Fix crash when renaming single items
Thu, Apr 5, 9:28 PM
elvisangelaccio closed D11972: [RenameDialog] Fix crash when renaming single items.
Thu, Apr 5, 9:28 PM
elvisangelaccio added a comment to D11972: [RenameDialog] Fix crash when renaming single items.

and is m_renamedItems cleared anywhere before or after renaming?

Thu, Apr 5, 9:20 PM
elvisangelaccio updated the diff for D11972: [RenameDialog] Fix crash when renaming single items.
  • Set m_renamedItems also in single-rename case
Thu, Apr 5, 9:16 PM
elvisangelaccio added a comment to D11972: [RenameDialog] Fix crash when renaming single items.

m_renamedItems is emitted in renamingFinished(). I haven't checked carefully, but is m_renamedItems correct for the single file rename?

Thu, Apr 5, 9:14 PM
elvisangelaccio updated the summary of D11972: [RenameDialog] Fix crash when renaming single items.
Thu, Apr 5, 8:40 PM
elvisangelaccio updated the test plan for D11972: [RenameDialog] Fix crash when renaming single items.
Thu, Apr 5, 8:39 PM
elvisangelaccio added reviewers for D11972: [RenameDialog] Fix crash when renaming single items: cfeck, chinmoyr, Dolphin.
Thu, Apr 5, 8:38 PM
elvisangelaccio requested review of D11972: [RenameDialog] Fix crash when renaming single items.
Thu, Apr 5, 8:38 PM
elvisangelaccio added a comment to D11948: [KFileWidget] Hardcode example user name.

+1

Thu, Apr 5, 7:51 PM · Frameworks

Wed, Apr 4

elvisangelaccio added a comment to D11871: [DolphinTabWidget] Rewrite tab widget close.

I'll have a look this weekend.

Wed, Apr 4, 8:43 PM

Tue, Apr 3

elvisangelaccio retitled D11892: Improve QDialogButtonBox::Yes override text from Improve QDialogButtonBox::Yes override to Improve QDialogButtonBox::Yes override text.
Tue, Apr 3, 9:23 PM
elvisangelaccio added a comment to D11892: Improve QDialogButtonBox::Yes override text.

New "After" screenshot:

Tue, Apr 3, 9:23 PM
elvisangelaccio updated the summary of D11892: Improve QDialogButtonBox::Yes override text.
Tue, Apr 3, 9:23 PM
elvisangelaccio updated the diff for D11892: Improve QDialogButtonBox::Yes override text.
  • Yes -> Quit Dolphin
Tue, Apr 3, 9:22 PM
elvisangelaccio accepted D11894: Show folder previews for items that have a Places Panel entry.
Tue, Apr 3, 8:41 PM

Mon, Apr 2

elvisangelaccio planned changes to D11892: Improve QDialogButtonBox::Yes override text.
Mon, Apr 2, 9:48 PM
elvisangelaccio added a comment to D11892: Improve QDialogButtonBox::Yes override text.

Right. How about "Close All Tabs"? But I'd also be ok with "Quit Dolphin".

Mon, Apr 2, 9:47 PM
elvisangelaccio updated the summary of D11892: Improve QDialogButtonBox::Yes override text.
Mon, Apr 2, 9:15 PM
elvisangelaccio added a comment to D11892: Improve QDialogButtonBox::Yes override text.

Before:

Mon, Apr 2, 9:14 PM
elvisangelaccio requested review of D11892: Improve QDialogButtonBox::Yes override text.
Mon, Apr 2, 9:12 PM
elvisangelaccio added a comment to D11703: Select and scroll to the file for "Open path" and "Open Path in New Window" operations.

Ok, I was finally able to reproduce the issue. I'll investigate in the next days...

Mon, Apr 2, 8:54 PM
elvisangelaccio added a comment to D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default.

+1

Mon, Apr 2, 8:51 PM · Frameworks

Sun, Apr 1

elvisangelaccio added a comment to D11022: Resize the "normal" folder icons.

Does it even make sense to have the information panel this wide in the first place? Neither the status quo nor the proposed patch really make sense when it's super wide. Maybe we shouldn't optimize for this extreme corner case.

Sun, Apr 1, 10:09 PM
elvisangelaccio added a comment to D11022: Resize the "normal" folder icons.

If we make all icons of the same size (which I'm not sure I'd like), that code would become useless and should then be removed.

  1. I am totally fine with abandoning this patch, but it was brought up on a few occasions on Bugzilla so I simply went ahead & made a patch

The thing is, for one user that complains on bugzilla there are probably 10x people who are happy about the current implementation. Some of them *will* complain after this patch goes in.

What do we suspect that they will complain about?

Sun, Apr 1, 9:18 PM
elvisangelaccio added a comment to D11022: Resize the "normal" folder icons.

Still, as I mentioned in bugzilla, the only inconsistency that I'd fix is that the information panel does not check whether the preview setting is enabled.

And what do you think about the size when the information panel is resized? Right now, folders without previews look pretty bad if you expand the panel:

Sun, Apr 1, 9:14 PM
elvisangelaccio committed R318:763933977b87: Use QHash rather than QMap (authored by elvisangelaccio).
Use QHash rather than QMap
Sun, Apr 1, 10:31 AM
elvisangelaccio committed R318:6f3b0e3d00e1: Fix detaching (authored by elvisangelaccio).
Fix detaching
Sun, Apr 1, 10:31 AM
elvisangelaccio committed R318:d0503ae8e05a: Use rightRef() instead of right() (authored by elvisangelaccio).
Use rightRef() instead of right()
Sun, Apr 1, 10:31 AM
elvisangelaccio added a comment to D10698: Adds a new RenameDialog to Dolphin with more options for batch renaming.

I have another comment on the UI: I don't understand how #name, #bname, and #ext are supposed to work.

Sun, Apr 1, 9:58 AM · Dolphin
elvisangelaccio added a comment to D11022: Resize the "normal" folder icons.

If we make all icons of the same size (which I'm not sure I'd like), that code would become useless and should then be removed.

  1. I am totally fine with abandoning this patch, but it was brought up on a few occasions on Bugzilla so I simply went ahead & made a patch
Sun, Apr 1, 9:22 AM
elvisangelaccio accepted D11816: Split Image Size into Width/Height.
Sun, Apr 1, 8:58 AM

Sat, Mar 31

elvisangelaccio requested changes to D11816: Split Image Size into Width/Height.

There are still a few bits of code to be ported:

Sat, Mar 31, 12:57 PM
elvisangelaccio added a comment to D11703: Select and scroll to the file for "Open path" and "Open Path in New Window" operations.

Can you explain how to reproduce the "scrolls to an incorrect location" issue?

Sat, Mar 31, 9:52 AM
elvisangelaccio requested changes to D11816: Split Image Size into Width/Height.
Sat, Mar 31, 9:48 AM
elvisangelaccio added a comment to D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files.

I'd just remove the code and explain why in the commit message.

Sat, Mar 31, 9:40 AM · Plasma

Fri, Mar 30

elvisangelaccio requested changes to D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files.

Qt minimum version for plasma-integration is 5.9 these days, so this patch should be updated.

Fri, Mar 30, 5:48 PM · Plasma