elvisangelaccio (Elvis Angelaccio)
Developer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Aug 16 2015, 4:08 PM (191 w, 5 d)
Availability
Available

Recent Activity

Sun, Apr 14

elvisangelaccio added a comment to D20427: When renaming files, move to next file using tab key..

what does it means? is it done already?

@msciubidlo See https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages

Sun, Apr 14, 9:07 PM · Dolphin
elvisangelaccio added inline comments to D20524: [FileMetaDataWidget] Allow inline configuration of visible properties.
Sun, Apr 14, 8:54 PM · Baloo
elvisangelaccio added a comment to D20525: [InformationPanel] Use the new inline configuration mode.

About the UI, I noticed that when the panel is in "configure" mode, it's still possible to right-click it and click the "Configure" entry, which will do nothing.
We could fix this by disabling the entry once clicked. Another idea: make the entry checkable instead of using the buttonbox.

Sun, Apr 14, 8:45 PM · Dolphin
elvisangelaccio requested changes to D20525: [InformationPanel] Use the new inline configuration mode.

Please bump the minimum required version for KF5BalooWidgets to 19.07.70.

Sun, Apr 14, 8:45 PM · Dolphin
elvisangelaccio committed R824:7eaa04b2804b: Fix version on master (authored by elvisangelaccio).
Fix version on master
Sun, Apr 14, 8:36 PM
elvisangelaccio added a comment to D16648: Open externally called files/directories in new tabs.

Another thing: can you have a look about these warnings?

Sun, Apr 14, 1:03 PM · Dolphin
elvisangelaccio accepted D20513: Remove last traces of KFileMetaDataWidget from information panel.

Thanks

Sun, Apr 14, 12:57 PM · Dolphin
elvisangelaccio added a comment to D16648: Open externally called files/directories in new tabs.

This made me think: what about non-plasma systems?
e.g. GNOME doesn't even have a taskbar, what's gonna happen there?

Sun, Apr 14, 12:45 PM · Dolphin
elvisangelaccio added inline comments to D16648: Open externally called files/directories in new tabs.
Sun, Apr 14, 12:18 PM · Dolphin
elvisangelaccio added a comment to D20524: [FileMetaDataWidget] Allow inline configuration of visible properties.

Hmm, it seems you need to rebase this patch:

Sun, Apr 14, 12:04 PM · Baloo
elvisangelaccio added inline comments to D20524: [FileMetaDataWidget] Allow inline configuration of visible properties.
Sun, Apr 14, 12:01 PM · Baloo
elvisangelaccio accepted D20514: [Information Panel] Remove nullptr checks for MetaDataWidget member.
Sun, Apr 14, 11:55 AM · Dolphin
elvisangelaccio added inline comments to D20513: Remove last traces of KFileMetaDataWidget from information panel.
Sun, Apr 14, 11:52 AM · Dolphin
elvisangelaccio accepted D20523: Remove a dead declaration.
Sun, Apr 14, 10:29 AM · Baloo

Sat, Apr 13

elvisangelaccio added a comment to D20452: Clear terminal display when closing and opening it.

This patch looks more like a workaround to me. I'd suggest to identify the root cause of "^C" and "cd <path>" whenever the terminal is hidden and reopened again by hitting F4 and to find a another solution as I guess and especially hope that this behaviour is actually not necessary to happen.

Sat, Apr 13, 9:11 AM · Dolphin

Thu, Apr 11

elvisangelaccio requested changes to D20452: Clear terminal display when closing and opening it.

Hmm, I don't I like it sorry. Running clear without the user permission could be annoying or even dangerous.

Thu, Apr 11, 9:45 PM · Dolphin
elvisangelaccio requested changes to D16648: Open externally called files/directories in new tabs.

@elvisangelaccio is this the patch we're going with?

Thu, Apr 11, 8:48 PM · Dolphin
elvisangelaccio added a comment to D19883: Add unique-window mode which opens uris in a new tab instead of a window.

Sorry for the delay. Let's focus on D16648 please, which has already started its review process.

Thu, Apr 11, 8:03 PM · Dolphin
elvisangelaccio accepted D20152: Scroll to item if it's not visible on keyPress.

Please push to master only, just to make sure we don't introduce regressions.

Thu, Apr 11, 5:32 PM · Dolphin

Tue, Apr 9

elvisangelaccio accepted D20404: Allow the baloo widgets to display creation date and access date..
Tue, Apr 9, 8:59 PM · Baloo
elvisangelaccio accepted D20357: Make buttons in seach bar nicer (icon, tooltip, autoselect).
Tue, Apr 9, 8:56 PM · Dolphin
elvisangelaccio accepted D20396: Don't show "Open With" menu items for empty directories.
Tue, Apr 9, 8:55 PM · Dolphin
elvisangelaccio added a comment to D20152: Scroll to item if it's not visible on keyPress.

We always call KItemListSelectionManager::setCurrentItem() before calling scrollToItem(), so we should probably do it also here.

I don't think it is needed because it was set in the above code block.

Only if m_selectionManager->currentItem() != index, but this won't be true when the item is not visible. Which is why you want to move the scrollToItem() call outside this if() block in the first place, isn't it?

When m_selectionManager->currentItem() == index, the setCurrentItem(index) will do nothing.

Tue, Apr 9, 8:48 PM · Dolphin

Mon, Apr 8

elvisangelaccio committed R219:44d7e49d8897: Port away from deprecated insert() (authored by elvisangelaccio).
Port away from deprecated insert()
Mon, Apr 8, 8:34 PM
elvisangelaccio added a comment to D20152: Scroll to item if it's not visible on keyPress.

We always call KItemListSelectionManager::setCurrentItem() before calling scrollToItem(), so we should probably do it also here.

I don't think it is needed because it was set in the above code block.

Mon, Apr 8, 8:16 PM · Dolphin
elvisangelaccio added inline comments to D20357: Make buttons in seach bar nicer (icon, tooltip, autoselect).
Mon, Apr 8, 8:10 PM · Dolphin

Sun, Apr 7

elvisangelaccio committed R318:93f26f799fe7: Merge branch 'Applications/19.04' (authored by elvisangelaccio).
Merge branch 'Applications/19.04'
Sun, Apr 7, 8:55 PM
elvisangelaccio committed R318:30a335cbcf12: [DolphinMainWindowTest] Fix testNewFileMenuEnabled (authored by elvisangelaccio).
[DolphinMainWindowTest] Fix testNewFileMenuEnabled
Sun, Apr 7, 8:48 PM
elvisangelaccio requested changes to D20049: Fix unexpected behaviour when calling dolphin with a file as an argument.
Sun, Apr 7, 7:55 PM · Dolphin
elvisangelaccio added a comment to D19782: Allow dolphin to auto-play previewed media file, click on preview to play/pause videos or audio.

I didn't notice that this patch is also adding click-on-preview to toggle play/pause. To me that is an unrelated feature that should go in another commit (and will probably help you to debug it).

Sun, Apr 7, 5:15 PM · Dolphin
elvisangelaccio accepted D20361: [tagsaction] Don't crash on multiple files.

Thanks. Please push to Applications/19.04

Sun, Apr 7, 5:07 PM · Baloo
elvisangelaccio requested changes to D20152: Scroll to item if it's not visible on keyPress.

We always call KItemListSelectionManager::setCurrentItem() before calling scrollToItem(), so we should probably do it also here.

Sun, Apr 7, 4:58 PM · Dolphin
elvisangelaccio removed a reviewer for D20357: Make buttons in seach bar nicer (icon, tooltip, autoselect): KDE Applications.
Sun, Apr 7, 4:54 PM · Dolphin
elvisangelaccio requested changes to D20357: Make buttons in seach bar nicer (icon, tooltip, autoselect).
Sun, Apr 7, 4:54 PM · Dolphin
elvisangelaccio added a reviewer for D20333: libzip: Fix CRC checksum display: rthomsen.
Sun, Apr 7, 4:18 PM · Ark
elvisangelaccio added a comment to D19926: Add Bookmark Handling.

Let's see what the dolphin philosophy says: https://github.com/KDE/dolphin/blob/master/HACKING.md

Sun, Apr 7, 4:17 PM · Dolphin
elvisangelaccio committed R318:11955532d4d3: Add HACKING file with 'Philosophy' paragraph from the Userbase page (authored by elvisangelaccio).
Add HACKING file with 'Philosophy' paragraph from the Userbase page
Sun, Apr 7, 3:34 PM
elvisangelaccio committed R318:d47090eb1306: [KFileItemModelTest] Port to fastInsert() (authored by elvisangelaccio).
[KFileItemModelTest] Port to fastInsert()
Sun, Apr 7, 3:34 PM
elvisangelaccio accepted D20122: Properly handle locked RAR archives.
Sun, Apr 7, 11:04 AM · Ark

Sat, Apr 6

elvisangelaccio added a comment to D19311: Add navigation history to forward/back buttons.

About the UI: I'd also be in favor of not showing the arrows. It's not just Falkon that doesn't show them, but also Firefox and Chrome.

Sat, Apr 6, 6:03 PM · Dolphin
elvisangelaccio added a comment to D10959: Add action for focusing Terminal Panel.

Too late for 19.04 anyway, sorry for the delay :(

Sat, Apr 6, 5:44 PM · Dolphin
elvisangelaccio accepted D20229: Re-implement Meta-E global launch shortcut using KGlobalAccel.

Too late for 19.04, please push to master (after replacing BUG: with FEATURE: in the commit message :D)

Sat, Apr 6, 5:33 PM · Dolphin
elvisangelaccio added a comment to D18296: Add support for passing cursor information via URL parameters when running kioclient exec..

Is it really necessary to copy urlinfo.h here? Wouldn't be enough to just create a static function and put the URL parsing logic there?

Sat, Apr 6, 5:21 PM · Plasma
elvisangelaccio added inline comments to D20122: Properly handle locked RAR archives.
Sat, Apr 6, 5:06 PM · Ark
elvisangelaccio added a reviewer for D20197: Fix desktop link to file or directory: dfaure.
Sat, Apr 6, 4:38 PM · Frameworks
elvisangelaccio added inline comments to D20024: Fixes crash when hiding devices.
Sat, Apr 6, 4:29 PM · Dolphin

Sun, Mar 31

elvisangelaccio added inline comments to D20122: Properly handle locked RAR archives.
Sun, Mar 31, 10:33 AM · Ark
elvisangelaccio added a comment to D20122: Properly handle locked RAR archives.

I cannot open the test file...

Sun, Mar 31, 10:32 AM · Ark
elvisangelaccio added a comment to D20024: Fixes crash when hiding devices.

Could you try and move the testHideItem to be the first test? Also make sure to run placesitemmodeltest using valgrind, i.e. valgrind placesitemmodeltest

Sun, Mar 31, 10:29 AM · Dolphin

Sat, Mar 30

elvisangelaccio updated subscribers of D20024: Fixes crash when hiding devices.

Hi @elvisangelaccio , I have been looking into writing a unit test for the crash, but it turns out we already have one: PlacesModelItemTest::testHideItem. But, the test only triggers the crash if it is run before the testPlaceItem test case. I have been digging in the code to figure out why the test cases are coupled in this way, but I haven't figured it out, so could you take a look? Here is a diff that triggers the crash:

diff --git a/src/tests/placesitemmodeltest.cpp b/src/tests/placesitemmodeltest.cpp
index fac0931a6..05aa02064 100644
--- a/src/tests/placesitemmodeltest.cpp
+++ b/src/tests/placesitemmodeltest.cpp
@@ -63,13 +63,13 @@ private slots:
     void testModelSort();
     void testGroups();
     void testDeletePlace();
+    void testHideItem();
     void testPlaceItem_data();
     void testPlaceItem();
     void testTearDownDevice();
     void testDefaultViewProperties_data();
     void testDefaultViewProperties();
     void testClear();
-    void testHideItem();
     void testSystemItems();
     void testEditBookmark();
     void testEditAfterCreation();
Sat, Mar 30, 5:56 PM · Dolphin
elvisangelaccio committed R318:f4549a196b21: [KFileItemModel] Fix alignment of rolesInfoMap (authored by elvisangelaccio).
[KFileItemModel] Fix alignment of rolesInfoMap
Sat, Mar 30, 5:42 PM
elvisangelaccio added a comment to D20122: Properly handle locked RAR archives.

@rthomsen Is it possible to add a small test archive so that we can write an unit test?

Sat, Mar 30, 3:07 PM · Ark
elvisangelaccio added inline comments to D18845: authority: add support for passing details to polkit.
Sat, Mar 30, 3:06 PM

Tue, Mar 26

elvisangelaccio requested changes to D20052: Make tabs rename-able.
Tue, Mar 26, 9:28 PM · Dolphin
elvisangelaccio added a comment to D20064: Add trash related to GDriveUrl.

Bonus point if you add a test case in urltest.cpp ;)

Tue, Mar 26, 9:07 PM · KIO GDrive
elvisangelaccio added a comment to D19953: Fix progress info for CreateJob.

Please update the commit message before pushing, it's still referring to PercentFromNestedJob

Tue, Mar 26, 8:42 PM · Ark
elvisangelaccio accepted D19953: Fix progress info for CreateJob.
Tue, Mar 26, 8:42 PM · Ark
elvisangelaccio added a comment to D20007: Add GetProcessList for retrieving the list of currently active processes.

Don't forget to update the commit message (it still mentions "Add GetProcessList") ;)

Tue, Mar 26, 8:40 PM · Frameworks

Mon, Mar 25

elvisangelaccio requested changes to D20049: Fix unexpected behaviour when calling dolphin with a file as an argument.

I get a crash if I run dolphin /etc/fstab:

Mon, Mar 25, 9:05 PM · Dolphin
elvisangelaccio accepted D19904: Prompt user to save/discard changes upon closing config dialog.

Please push to master only.

Mon, Mar 25, 8:55 PM · Dolphin
elvisangelaccio added inline comments to D19953: Fix progress info for CreateJob.
Mon, Mar 25, 8:50 PM · Ark

Sun, Mar 24

elvisangelaccio closed D20016: Don't set a null completer on a non-editable combobox.
Sun, Mar 24, 8:42 PM · Frameworks
elvisangelaccio committed R284:c955994053a7: Don't set a null completer on a non-editable combobox (authored by elvisangelaccio).
Don't set a null completer on a non-editable combobox
Sun, Mar 24, 8:42 PM
elvisangelaccio added a comment to D20024: Fixes crash when hiding devices.

That said, the fix looks correct. An unit test for this crash would be awesome, you have spare time.

Sun, Mar 24, 8:39 PM · Dolphin
elvisangelaccio added a comment to D20024: Fixes crash when hiding devices.

Hmm, I can't reproduce the crash following the test plan.

Sun, Mar 24, 8:34 PM · Dolphin
elvisangelaccio requested changes to D19782: Allow dolphin to auto-play previewed media file, click on preview to play/pause videos or audio.
Sun, Mar 24, 6:58 PM · Dolphin
elvisangelaccio added a comment to D20004: Add "Up" action to editable mode, accessible via Key_Up press while focus is on lineEdit.

Yes please, this feature really belongs to KUrlNavigator.

Sun, Mar 24, 5:55 PM · Dolphin
elvisangelaccio requested changes to D19904: Prompt user to save/discard changes upon closing config dialog.
Sun, Mar 24, 5:36 PM · Dolphin
elvisangelaccio updated the diff for D20016: Don't set a null completer on a non-editable combobox.
  • David's suggestion
Sun, Mar 24, 3:52 PM · Frameworks
elvisangelaccio accepted D19950: Move Safely Remove down in places context menu.

Generally UI changes shouldn't go to the stable branch, but this can be considered a bugfix, so let's go with 19.04 ;)

Sun, Mar 24, 3:46 PM · Dolphin
elvisangelaccio added inline comments to D20016: Don't set a null completer on a non-editable combobox.
Sun, Mar 24, 3:41 PM · Frameworks
elvisangelaccio added a comment to D19926: Add Bookmark Handling.

Hmm, when I apply this patch I don't actually see the new menu item.

Sun, Mar 24, 3:32 PM · Dolphin
elvisangelaccio added a comment to D19953: Fix progress info for CreateJob.

If it is possible to somehow force Qt to connect to the signal, then the PercentFromNestedJob is not necessary.

Sun, Mar 24, 3:31 PM · Ark
elvisangelaccio added a comment to D19926: Add Bookmark Handling.

What about the Control menu? Remember that the menubar is hidden by default in dolphin, so the average user probably won't be able to discover this feature.

Sun, Mar 24, 3:11 PM · Dolphin
elvisangelaccio added a comment to D19988: Fix lengthy URLs in tooltips.

Also please write a descriptive commit message and use the BUG: keyword. See https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages

Sun, Mar 24, 12:21 PM · Baloo
elvisangelaccio added inline comments to D19988: Fix lengthy URLs in tooltips.
Sun, Mar 24, 12:19 PM · Baloo
elvisangelaccio added a reviewer for D20016: Don't set a null completer on a non-editable combobox: dfaure.
Sun, Mar 24, 12:16 PM · Frameworks
elvisangelaccio requested review of D20016: Don't set a null completer on a non-editable combobox.
Sun, Mar 24, 12:16 PM · Frameworks
elvisangelaccio added a comment to D19987: Bug 405620 - Move 'Safely Remove' down in Places popup menu.

Oh. Alright. How do I close this MR?

Sun, Mar 24, 11:47 AM · Dolphin
elvisangelaccio committed R318:3fe65471973c: Revert "Create a global launch shortcut (Meta+E)" (authored by elvisangelaccio).
Revert "Create a global launch shortcut (Meta+E)"
Sun, Mar 24, 11:14 AM
elvisangelaccio added a reverting change for R318:58084cf7da36: Create a global launch shortcut (Meta+E): R318:3fe65471973c: Revert "Create a global launch shortcut (Meta+E)".
Sun, Mar 24, 11:14 AM
elvisangelaccio committed R318:0b9cb0f7d9b6: [PhononWidget] Fix layout warning (authored by elvisangelaccio).
[PhononWidget] Fix layout warning
Sun, Mar 24, 11:14 AM
elvisangelaccio added a comment to D19831: Create a global launch shortcut (Meta+E).

Makes sense, thanks for the explanation. Reverted with 3fe6547197.

Sun, Mar 24, 11:12 AM · Dolphin
elvisangelaccio added a comment to D19831: Create a global launch shortcut (Meta+E).

We don't want more stuff using khotkeys, you've seen the spectacle discussion and the move to the new kglobalaccel code.

Sun, Mar 24, 9:58 AM · Dolphin
elvisangelaccio accepted D19844: [InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled.

Please push to the 19.04 branch. Thanks!

Sun, Mar 24, 9:43 AM · Dolphin
elvisangelaccio added inline comments to D19988: Fix lengthy URLs in tooltips.
Sun, Mar 24, 9:33 AM · Baloo

Sat, Mar 23

elvisangelaccio added inline comments to D20007: Add GetProcessList for retrieving the list of currently active processes.
Sat, Mar 23, 9:39 PM · Frameworks
elvisangelaccio requested changes to D19844: [InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled.
Sat, Mar 23, 6:43 PM · Dolphin
elvisangelaccio added a comment to T10630: Show Team Drives.

I see. Then I'd exclude #3 for the reason you mentioned. I'd be ok with either #1 or #2, with a slight preference for #2.

Sat, Mar 23, 11:27 AM · KIO GDrive
elvisangelaccio added a comment to D19987: Bug 405620 - Move 'Safely Remove' down in Places popup menu.

Thanks, but there is already a patch for this in D19950. We may want to focus on that one.

Sat, Mar 23, 11:21 AM · Dolphin
elvisangelaccio added a comment to D19950: Move Safely Remove down in places context menu.

I undid changes to Trash. The only difference now is Mount/Unmount is lower in the list.

Sat, Mar 23, 9:55 AM · Dolphin
elvisangelaccio committed R318:aee1b07e26ca: Merge branch 'Applications/19.04' (authored by elvisangelaccio).
Merge branch 'Applications/19.04'
Sat, Mar 23, 9:53 AM
elvisangelaccio added a comment to D19989: Unmounting busy device doesn't tell who is blocking.

I'd also try to avoid copying the code here, is possible.

Sat, Mar 23, 9:41 AM · Dolphin
elvisangelaccio updated subscribers of D19856: find ruby gems & make coverage conditional on BUILD_COVERAGE.

@sitter @bcooksley It seems the freebsd CI node doesn't have the test-unit gem, can we install it?

Sat, Mar 23, 9:15 AM · Dolphin

Mar 20 2019

elvisangelaccio accepted D19911: Convert foreach to for loops.
Mar 20 2019, 10:05 PM · Dolphin
elvisangelaccio added a comment to D10959: Add action for focusing Terminal Panel.

We are still in time for 19.04 ;)

Mar 20 2019, 10:03 PM · Dolphin
elvisangelaccio accepted D19910: Hide the phonon widget when preview gets disabled.

Haven't tried D19844 yet, but this patch can only make sense.

Mar 20 2019, 9:15 PM · Dolphin
elvisangelaccio added a comment to D19904: Prompt user to save/discard changes upon closing config dialog.

What if the user press Cancel instead of closing the window?

Mar 20 2019, 8:48 PM · Dolphin
elvisangelaccio added a comment to D19661: Make global view properties the default setting.

BTW, I'm not sure how it could possibly be related, but the placesitemmodel test has started consistently failing after this commit went in: https://build.kde.org/job/Applications/job/dolphin/job/stable-kf5-qt5%20SUSEQt5.10/30/testReport/junit/projectroot.src/tests/placesitemmodeltest/

Mar 20 2019, 8:38 PM · Dolphin
elvisangelaccio committed R318:bff373d598c0: Fix PlacesItemModelTest::testDefaultViewProperties() (authored by elvisangelaccio).
Fix PlacesItemModelTest::testDefaultViewProperties()
Mar 20 2019, 8:37 PM