elvisangelaccio (Elvis Angelaccio)
Developer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 16 2015, 4:08 PM (148 w, 6 d)
Availability
Available

Recent Activity

Yesterday

elvisangelaccio added a comment to D13570: Add workaround for labels with word-wrapping.

Ping?

Sat, Jun 23, 2:39 PM · Frameworks
elvisangelaccio accepted D13680: don't use temporaries when uneeded.

Thanks

Sat, Jun 23, 11:00 AM · Dolphin
elvisangelaccio requested review of D13691: Use percent encoding when creating urls for UDS entries.
Sat, Jun 23, 9:05 AM

Thu, Jun 21

elvisangelaccio committed R241:de5ab5e74b4c: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu (authored by mmustac).
[KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu
Thu, Jun 21, 9:05 PM
elvisangelaccio closed D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu.
Thu, Jun 21, 9:05 PM · Frameworks

Tue, Jun 19

elvisangelaccio accepted D13554: [Properties dialog] Make all field values on general tab selectable.
Tue, Jun 19, 9:01 PM · Frameworks
elvisangelaccio committed R36:479bb7a58668: Merge branch 'Applications/18.04' (authored by elvisangelaccio).
Merge branch 'Applications/18.04'
Tue, Jun 19, 9:01 PM
elvisangelaccio added a comment to D13595: Move General settings to the top.

@ltoscano Yes, seems the docboock lists the page in their actual order within the dialog.

Tue, Jun 19, 8:54 PM · Documentation, Dolphin
elvisangelaccio accepted D13595: Move General settings to the top.

Indeed, it probably makes sense to be consistent here.

Tue, Jun 19, 8:49 PM · Documentation, Dolphin

Mon, Jun 18

elvisangelaccio added inline comments to D13124: [RFC] Add Share action to Dolphin context menu.
Mon, Jun 18, 8:55 PM · Frameworks, Dolphin

Sun, Jun 17

elvisangelaccio committed R36:9a349f680b1b: libzip: fix extraction of folders without zip entry (authored by elvisangelaccio).
libzip: fix extraction of folders without zip entry
Sun, Jun 17, 2:01 PM

Sat, Jun 16

elvisangelaccio added a comment to D12571: Modernize Settings window.

Don't they control how the view appears on startup?

Only "Split view mode" does. The other ones control things that are outside the view. How about using "On startup:" and rewording the sentences on the checkboxes where necessary?

I was using the term "View" from a user perspective. I think to people who aren't Dolphin developers, these are view settings. The technical distinction between the view, its container, and the main window are not relevant to users, or important to understand.

Sat, Jun 16, 5:01 PM · Dolphin
elvisangelaccio requested review of D13570: Add workaround for labels with word-wrapping.
Sat, Jun 16, 4:26 PM · Frameworks
elvisangelaccio added a comment to D13569: Use collapsible box to configure visible roles.

Some screens:

Sat, Jun 16, 3:43 PM · Dolphin
elvisangelaccio requested review of D13569: Use collapsible box to configure visible roles.
Sat, Jun 16, 3:40 PM · Dolphin

Thu, Jun 14

elvisangelaccio committed R318:32b8b19ba556: ViewPropertiesDialog: disable Apply button on startup (authored by elvisangelaccio).
ViewPropertiesDialog: disable Apply button on startup
Thu, Jun 14, 8:23 PM

Wed, Jun 13

elvisangelaccio committed R318:615838083dfe: Merge branch 'Applications/18.04' (authored by elvisangelaccio).
Merge branch 'Applications/18.04'
Wed, Jun 13, 8:39 PM
elvisangelaccio requested changes to D12571: Modernize Settings window.

Don't they control how the view appears on startup?

Wed, Jun 13, 8:36 PM · Dolphin
elvisangelaccio added a comment to D13475: fix sftp links with new uds implementation.

Should we backport this on the stable branch? Otherwise affected people will have to either downgrade kio or compile kio-extras from master...

Wed, Jun 13, 7:58 PM
elvisangelaccio committed R318:9616edbb66a8: Fix loop of FocusIn events (authored by elvisangelaccio).
Fix loop of FocusIn events
Wed, Jun 13, 7:42 PM
elvisangelaccio closed D13152: Fix loop of FocusIn events.
Wed, Jun 13, 7:42 PM · Dolphin
elvisangelaccio added a comment to D13474: Remove "Use Default Location" button in settings window.

I'm not 100% convinced. The Defaults button resets all dolphin settings, while this one resets only this particular option.
The problem is we don't know if someone relies on this "feature", and in theory we could break someone else's workflow (unlikely, but still).

Wed, Jun 13, 7:36 PM · Dolphin

Sun, Jun 10

elvisangelaccio added inline comments to D12961: Updated alignment, keylines, messures to new radio button layout and the new qml formlayout.
Sun, Jun 10, 6:47 PM · KDE Human Interface Guidelines
elvisangelaccio added inline comments to D12961: Updated alignment, keylines, messures to new radio button layout and the new qml formlayout.
Sun, Jun 10, 9:59 AM · KDE Human Interface Guidelines

Tue, Jun 5

l10n daemon script <scripty@kde.org> committed R241:943c062f0e0b: Fix regression when pasting binary data from clipboard (authored by elvisangelaccio).
Fix regression when pasting binary data from clipboard
Tue, Jun 5, 10:09 PM
elvisangelaccio added a comment to D12571: Modernize Settings window.

I updated the title to reflect what this patch actually does now: it modernizes the look and feel of the whole settings window to be in line with the current HIG and our latest design focus for settings windows throughout KDE.

Tue, Jun 5, 9:42 PM · Dolphin
elvisangelaccio added a comment to D13342: Fix regression when pasting binary data from clipboard.

@dfaure Can you respin the kio tarball with this commit?

Tue, Jun 5, 8:42 PM · Frameworks
elvisangelaccio committed R241:95865915945d: Fix regression when pasting binary data from clipboard (authored by elvisangelaccio).
Fix regression when pasting binary data from clipboard
Tue, Jun 5, 8:41 PM
elvisangelaccio closed D13342: Fix regression when pasting binary data from clipboard.
Tue, Jun 5, 8:41 PM · Frameworks
elvisangelaccio committed R495:2c582ad02cdb: Properly reset plugins (authored by elvisangelaccio).
Properly reset plugins
Tue, Jun 5, 8:39 PM
elvisangelaccio closed D13343: Properly reset plugins.
Tue, Jun 5, 8:39 PM · Frameworks
elvisangelaccio accepted D13349: [KBalooRolesProvider] Support properties of type QStringList.

Though we should probably fix the non-localized ", " usage, eventually :D

Tue, Jun 5, 8:29 PM · Dolphin
elvisangelaccio committed R318:e308985de4b3: Fix scrolling to renamed file when using the rename dialog (authored by elvisangelaccio).
Fix scrolling to renamed file when using the rename dialog
Tue, Jun 5, 8:08 PM
elvisangelaccio closed D13304: Fix scrolling to renamed file when using the rename dialog.
Tue, Jun 5, 8:08 PM · Dolphin

Mon, Jun 4

elvisangelaccio updated the diff for D13304: Fix scrolling to renamed file when using the rename dialog.
  • Also delete when the dialog is rejected
Mon, Jun 4, 8:47 PM · Dolphin
elvisangelaccio added a comment to D13304: Fix scrolling to renamed file when using the rename dialog.

Works for me as well. One potential issue is that the object is not deleted if the rename operation is cancelled as the flag is not there anymore.

Mon, Jun 4, 8:46 PM · Dolphin
elvisangelaccio requested review of D13343: Properly reset plugins.
Mon, Jun 4, 8:38 PM · Frameworks
elvisangelaccio committed R495:727ce79c815d: Filter out duplicate plugins (authored by elvisangelaccio).
Filter out duplicate plugins
Mon, Jun 4, 8:12 PM
elvisangelaccio closed D13308: Filter out duplicate plugins.
Mon, Jun 4, 8:12 PM · Frameworks
elvisangelaccio requested review of D13342: Fix regression when pasting binary data from clipboard.
Mon, Jun 4, 7:49 PM · Frameworks

Sun, Jun 3

elvisangelaccio accepted D13314: Use file contents when selecting extractor plugin.
Sun, Jun 3, 8:54 PM · Baloo
elvisangelaccio added a reviewer for D13315: Detect mime type of local files based on their contents: dfaure.
Sun, Jun 3, 8:52 PM · Frameworks
elvisangelaccio updated the summary of D13308: Filter out duplicate plugins.
Sun, Jun 3, 6:07 PM · Frameworks
elvisangelaccio removed a reviewer for D13124: [RFC] Add Share action to Dolphin context menu: elvisangelaccio.
Sun, Jun 3, 6:06 PM · Frameworks, Dolphin
elvisangelaccio removed a reviewer for D13124: [RFC] Add Share action to Dolphin context menu: Dolphin.
Sun, Jun 3, 6:06 PM · Frameworks, Dolphin
elvisangelaccio added inline comments to D13124: [RFC] Add Share action to Dolphin context menu.
Sun, Jun 3, 6:06 PM · Frameworks, Dolphin
elvisangelaccio updated the diff for D13308: Filter out duplicate plugins.
  • Use auto
Sun, Jun 3, 6:03 PM · Frameworks
elvisangelaccio requested review of D13308: Filter out duplicate plugins.
Sun, Jun 3, 5:59 PM · Frameworks
elvisangelaccio committed R241:860ea6f924c4: KFileOperator: fix apidox of fileHighlighted() (authored by elvisangelaccio).
KFileOperator: fix apidox of fileHighlighted()
Sun, Jun 3, 4:36 PM
elvisangelaccio closed D12599: KFileOperator: fix apidox of fileHighlighted().
Sun, Jun 3, 4:36 PM · Frameworks
elvisangelaccio requested review of D13304: Fix scrolling to renamed file when using the rename dialog.
Sun, Jun 3, 4:34 PM · Dolphin
elvisangelaccio added a comment to D13152: Fix loop of FocusIn events.

When you have more than one tab with search box in click repeatedly between.

Sun, Jun 3, 1:01 PM · Dolphin
elvisangelaccio committed R318:3c6ecfa246c1: Merge branch 'Applications/18.04' (authored by elvisangelaccio).
Merge branch 'Applications/18.04'
Sun, Jun 3, 11:22 AM
elvisangelaccio committed R318:588abbf1b699: Fix crash in PlacesItem::setUrl() (authored by elvisangelaccio).
Fix crash in PlacesItem::setUrl()
Sun, Jun 3, 11:19 AM
elvisangelaccio committed R318:c1a594a88684: Drop obsolete version checks (authored by elvisangelaccio).
Drop obsolete version checks
Sun, Jun 3, 11:00 AM
elvisangelaccio committed R318:2e6798088b1a: Enable test mode in dolphinmainwindowtest (authored by elvisangelaccio).
Enable test mode in dolphinmainwindowtest
Sun, Jun 3, 9:25 AM

Sat, Jun 2

elvisangelaccio committed R318:97801e2cdb22: Add 'Sort By' and 'View Mode' into Dolphin file context menus (authored by nerdopolist).
Add 'Sort By' and 'View Mode' into Dolphin file context menus
Sat, Jun 2, 2:41 PM
elvisangelaccio closed D12911: Add 'Sort By' and 'View Mode' into Dolphin file context menus.
Sat, Jun 2, 2:41 PM · Dolphin
elvisangelaccio added a comment to D12911: Add 'Sort By' and 'View Mode' into Dolphin file context menus.

No need to resubmit, I'll amend the commit locally for this time.

Sat, Jun 2, 2:39 PM · Dolphin
elvisangelaccio added a comment to D13152: Fix loop of FocusIn events.

I try this too, but loop still present

Sat, Jun 2, 2:07 PM · Dolphin
elvisangelaccio requested changes to D12571: Modernize Settings window.

Sorry but now there are even more visual regressions than the original revision had.

Sat, Jun 2, 1:52 PM · Dolphin
elvisangelaccio added a comment to D12599: KFileOperator: fix apidox of fileHighlighted().

Ping?

Sat, Jun 2, 1:34 PM · Frameworks
D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar. is now accepted and ready to land.
Sat, Jun 2, 1:32 PM
elvisangelaccio abandoned D11334: Disable Create New menu and button when Trash dir is active.

Superseded by D12731.

Sat, Jun 2, 1:31 PM · Dolphin
elvisangelaccio commandeered D11334: Disable Create New menu and button when Trash dir is active.
Sat, Jun 2, 1:31 PM · Dolphin
elvisangelaccio added a comment to D12911: Add 'Sort By' and 'View Mode' into Dolphin file context menus.

@nerdopolist: why does arc create a commit with author "nerdopolis <rbos@rbos>" ?

Sat, Jun 2, 1:28 PM · Dolphin
elvisangelaccio accepted D12911: Add 'Sort By' and 'View Mode' into Dolphin file context menus.
Sat, Jun 2, 1:25 PM · Dolphin
elvisangelaccio updated the diff for D13152: Fix loop of FocusIn events.
  • Bring back setFocus() call
Sat, Jun 2, 11:44 AM · Dolphin
elvisangelaccio updated the summary of D13152: Fix loop of FocusIn events.
Sat, Jun 2, 11:43 AM · Dolphin
elvisangelaccio updated the test plan for D13152: Fix loop of FocusIn events.
Sat, Jun 2, 11:43 AM · Dolphin
elvisangelaccio updated the diff for D13152: Fix loop of FocusIn events.
  • Don't schedule the activation if we are already active
Sat, Jun 2, 11:41 AM · Dolphin
elvisangelaccio planned changes to D13152: Fix loop of FocusIn events.

I try this, but it does not work in all cases. I can't test right now, but i'll provide more info soon.
Edit: I remember, now when change tabs focus is not in search box, which is annoying.

Sat, Jun 2, 10:58 AM · Dolphin

Fri, Jun 1

elvisangelaccio committed R268:706730f9d7a3: Make sure ungrab keyboard request is processed before emitting shortcut (authored by sontolbonggol).
Make sure ungrab keyboard request is processed before emitting shortcut
Fri, Jun 1, 9:45 PM
elvisangelaccio closed D13128: Make sure ungrab keyboard request is processed before emitting shortcut.
Fri, Jun 1, 9:45 PM · Frameworks
elvisangelaccio committed R241:b73355da3f5b: Check if destination exists also when pasting binary data (authored by elvisangelaccio).
Check if destination exists also when pasting binary data
Fri, Jun 1, 9:39 PM
elvisangelaccio closed D13145: Check if destination exists also when pasting binary data.
Fri, Jun 1, 9:39 PM · Frameworks
elvisangelaccio committed R241:9d4ccb9836b3: Drop old QString::null usage (authored by elvisangelaccio).
Drop old QString::null usage
Fri, Jun 1, 9:39 PM
elvisangelaccio closed D13146: Drop old QString::null usage.
Fri, Jun 1, 9:39 PM · Frameworks
elvisangelaccio accepted D12732: Show a warning when running as the root user.
Fri, Jun 1, 9:31 PM · Dolphin
elvisangelaccio added inline comments to D12520: [PasteJob] Emit KDirNotify on paste.
Fri, Jun 1, 9:09 PM · Frameworks
elvisangelaccio added a comment to D13128: Make sure ungrab keyboard request is processed before emitting shortcut.

@sontolbonggol What's the email address we should use for the git commit?

Fri, Jun 1, 8:51 PM · Frameworks

Sun, May 27

elvisangelaccio added a comment to D11871: [DolphinTabWidget] Rewrite tab widget close.

@anthonyfieroni I propose another fix in D13152 :)

Sun, May 27, 3:40 PM · Dolphin
elvisangelaccio requested review of D13152: Fix loop of FocusIn events.
Sun, May 27, 3:40 PM · Dolphin
elvisangelaccio added a comment to D11871: [DolphinTabWidget] Rewrite tab widget close.

Patch doesn't apply, can you rebase it?

Sun, May 27, 2:35 PM · Dolphin
elvisangelaccio added a comment to D11871: [DolphinTabWidget] Rewrite tab widget close.

@anthonyfieroni Thanks, that was helpful and I was finally able to reproduce the problem.

Sun, May 27, 2:01 PM · Dolphin
elvisangelaccio requested review of D13146: Drop old QString::null usage.
Sun, May 27, 11:08 AM · Frameworks
elvisangelaccio requested review of D13145: Check if destination exists also when pasting binary data.
Sun, May 27, 11:01 AM · Frameworks
elvisangelaccio added a comment to D11871: [DolphinTabWidget] Rewrite tab widget close.

@anthonyfieroni Can you make a video? I still don't understand how to reproduce

Sun, May 27, 8:55 AM · Dolphin
elvisangelaccio accepted D11121: Add simple appdata file for KWalletManager.

LGTM

Sun, May 27, 8:51 AM

Sat, May 26

elvisangelaccio committed R241:aeab2bbcd5f4: KFileItemActions: remove unused variables (authored by elvisangelaccio).
KFileItemActions: remove unused variables
Sat, May 26, 4:46 PM
elvisangelaccio committed R241:233a00b7e162: KFileItemActions: fallback to default mimetype when selecting only files (authored by elvisangelaccio).
KFileItemActions: fallback to default mimetype when selecting only files
Sat, May 26, 4:46 PM
elvisangelaccio closed D12728: KFileItemActions: fallback to default mimetype when selecting only files.
Sat, May 26, 4:46 PM · Frameworks
elvisangelaccio committed R241:c84c8afd7f55: Introduce KFileItemListProperties::isFile() (authored by elvisangelaccio).
Introduce KFileItemListProperties::isFile()
Sat, May 26, 4:45 PM
elvisangelaccio closed D12727: Introduce KFileItemListProperties::isFile().
Sat, May 26, 4:45 PM · Frameworks
elvisangelaccio committed R343:d357d0e48b2c: Add filmstrip embed configuration (authored by tcarmichael).
Add filmstrip embed configuration
Sat, May 26, 4:32 PM
elvisangelaccio closed D12918: Add filmstrip embed configuration.
Sat, May 26, 4:32 PM
elvisangelaccio committed R343:95d7d2b22d4c: Add arcconfig (authored by elvisangelaccio).
Add arcconfig
Sat, May 26, 4:32 PM
Restricted Application added a project to D11324: Select files instead of opening them when trying to open a QUrl as a directory when in fact it is a file.: Dolphin.

@emateli Can you please click on "Plan Changes" if this review needs to be updated?

Sat, May 26, 4:23 PM · Dolphin
elvisangelaccio added a comment to D12918: Add filmstrip embed configuration.

Please tell us which email address we should use to land this patch on your behalf. Thanks!

Sat, May 26, 4:15 PM
elvisangelaccio accepted D12918: Add filmstrip embed configuration.
Sat, May 26, 4:14 PM