elvisangelaccio (Elvis Angelaccio)
Developer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Aug 16 2015, 4:08 PM (174 w, 10 h)
Availability
Available

Recent Activity

Yesterday

elvisangelaccio moved T6707: Jobs should properly set an error if they fail from In progress to Done on the Ark board.
Sun, Dec 16, 3:51 PM · Ark
elvisangelaccio committed R36:5c989b9cb214: Stop emitting error() when user cancels a DnD extraction (authored by elvisangelaccio).
Stop emitting error() when user cancels a DnD extraction
Sun, Dec 16, 3:47 PM
elvisangelaccio committed R318:2050fe17811c: Drop old krazy comments (authored by elvisangelaccio).
Drop old krazy comments
Sun, Dec 16, 1:24 PM
elvisangelaccio accepted D16980: Return editable URL navigator to breadcrumb mode if it has focus and everything is selected and when Ctrl+L is pressed.

I'd be ok with the proposed behavior.

Sun, Dec 16, 1:02 PM · Dolphin
elvisangelaccio added inline comments to D17620: Make setHelp() public.
Sun, Dec 16, 12:35 PM · Frameworks
elvisangelaccio requested review of D17621: Make RenameDialog modal again..
Sun, Dec 16, 12:30 PM · Dolphin
elvisangelaccio added inline comments to D17270: [KUrlNavigator] List subdirs of a parent folder of an archive.
Sun, Dec 16, 11:58 AM · Frameworks
elvisangelaccio added inline comments to D17550: Make the open url in tab feature a bit more discoverable.
Sun, Dec 16, 11:26 AM · Frameworks
elvisangelaccio added inline comments to D17619: Unit test and fix for bug 401552.
Sun, Dec 16, 10:49 AM · Frameworks
elvisangelaccio added a comment to D17619: Unit test and fix for bug 401552.

Unfortunately it's still crashing for me, even with this patch.

Sun, Dec 16, 10:46 AM · Frameworks
elvisangelaccio committed R241:ac1ea383a489: Fix <filename> tags (authored by elvisangelaccio).
Fix <filename> tags
Sun, Dec 16, 10:43 AM
elvisangelaccio added a comment to D17617: Display error instead of silently failing when asked to create folder that already exists.

Note that mkdir also doesn't warn if the folder already exists. I guess KNewFileMenu was designed to behave accordingly.

Sun, Dec 16, 10:29 AM · Frameworks
elvisangelaccio requested changes to D17617: Display error instead of silently failing when asked to create folder that already exists.
Sun, Dec 16, 10:22 AM · Frameworks

Sat, Dec 15

elvisangelaccio added inline comments to D17596: [KDirOperator] Allow renaming files from the context menu.
Sat, Dec 15, 5:22 PM · Frameworks
elvisangelaccio added inline comments to D17596: [KDirOperator] Allow renaming files from the context menu.
Sat, Dec 15, 4:17 PM · Frameworks
elvisangelaccio added a comment to D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache.

Let's see if this assert/crash can be avoided without reverting all the patch. Any help is welcome.

Sat, Dec 15, 3:52 PM · Frameworks

Fri, Dec 14

elvisangelaccio reopened D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache.
Fri, Dec 14, 10:17 PM · Frameworks

Mon, Dec 10

elvisangelaccio accepted D17470: [fileviewgitplugin] Ability to add conflicting file as well, Git expects that.
Mon, Dec 10, 8:58 PM
elvisangelaccio accepted D17468: [fileviewgitplugin] Apply Git log to selected files as well as directory.
Mon, Dec 10, 8:57 PM

Sun, Dec 9

elvisangelaccio accepted D17446: cmake macros: Port away from deprecated ECM var in kcoreaddons_add_plugin.
Sun, Dec 9, 10:35 AM · Frameworks

Sat, Dec 8

elvisangelaccio added a comment to D17392: Fix checkDesktopFile function.

Already fixed by c08ee4577168070896a4a46220cd39df4e4e32cf

Sat, Dec 8, 3:28 PM · Frameworks

Wed, Dec 5

elvisangelaccio committed R320:39da278f0d3b: Merge branch 'Applications/18.12' (authored by elvisangelaccio).
Merge branch 'Applications/18.12'
Wed, Dec 5, 9:12 PM
elvisangelaccio committed R320:35d737456c90: [Comic Thumbnailer] fix CBR thumbnail generation (authored by fleger).
[Comic Thumbnailer] fix CBR thumbnail generation
Wed, Dec 5, 9:12 PM
elvisangelaccio closed D15367: [Comic Thumbnailer] fix CBR thumbnail generation.
Wed, Dec 5, 9:12 PM · Frameworks, Dolphin

Tue, Dec 4

elvisangelaccio abandoned D17363: Fix crash in TagsFileItemAction.

There is already a fix in D17348

Tue, Dec 4, 9:24 PM · Baloo
elvisangelaccio added a comment to D17348: Initialize m_metaData.

And yes, this happens only in master, not 18.12

Tue, Dec 4, 9:23 PM · Baloo
elvisangelaccio accepted D17348: Initialize m_metaData.

Ops, I just submitted D17363, but this fix is indeed better.

Tue, Dec 4, 9:22 PM · Baloo
elvisangelaccio requested review of D17363: Fix crash in TagsFileItemAction.
Tue, Dec 4, 9:20 PM · Baloo
elvisangelaccio committed R318:f7a824b70d38: Merge branch 'Applications/18.12' (authored by elvisangelaccio).
Merge branch 'Applications/18.12'
Tue, Dec 4, 9:06 PM

Mon, Dec 3

elvisangelaccio accepted D17330: KItemListWidget: Use QGraphicsWidget::initStyleOption instead of QStyleOption::initFrom.

Can you please push it to the stable branch? (Applications/18.12)

Mon, Dec 3, 9:03 PM · Dolphin
elvisangelaccio added inline comments to D12162: Add support for touch scrolling in Dolphin.
Mon, Dec 3, 8:49 PM · Dolphin

Sun, Dec 2

elvisangelaccio committed R318:ca5581944b00: [PlacesPanel] Fix unused variable warning (authored by elvisangelaccio).
[PlacesPanel] Fix unused variable warning
Sun, Dec 2, 1:50 PM
elvisangelaccio committed R318:6938a73fe5e0: [KItemListController] Drop virtual keywords (authored by elvisangelaccio).
[KItemListController] Drop virtual keywords
Sun, Dec 2, 1:50 PM
elvisangelaccio committed R318:3ee24ac28742: [KItemListController] Make event-handling functions private (authored by elvisangelaccio).
[KItemListController] Make event-handling functions private
Sun, Dec 2, 1:50 PM
elvisangelaccio committed R318:7af0e2318667: [KItemListController] Drop unused functions (authored by elvisangelaccio).
[KItemListController] Drop unused functions
Sun, Dec 2, 1:50 PM
elvisangelaccio requested changes to D12162: Add support for touch scrolling in Dolphin.

Finally had the time to look at this diff.

Sun, Dec 2, 11:20 AM · Dolphin
elvisangelaccio added a comment to D16980: Return editable URL navigator to breadcrumb mode if it has focus and everything is selected and when Ctrl+L is pressed.

Ctrl+L already does multiple things depending on the context:

  1. URL navigator is a breadcrumb bar: Ctrl+L makes it editable, focuses it, and selects everything
  2. URL Navigator is editable but unfocused: Ctrl+L makes it focused and selects everything
  3. URL Navigator is editable and focused, but not everything is selected: Ctrl+L selects everything
  4. URL Navigator is editable and focused and everything is already selected: Ctrl+L does nothing

    This patch currently changes 3 and 4 to be "Ctrl+L turns it back into a breadcrumb bar and returns focus to the main view". Perhaps I could tweak the patch so that this only happens for case #4, for which hitting Ctrl+L currently has no effect. Thoughts?
Sun, Dec 2, 10:17 AM · Dolphin
elvisangelaccio accepted D17281: Add icon to KBuildSycocaProgressDialog cancel button.
Sun, Dec 2, 10:12 AM · VDG, Frameworks
elvisangelaccio requested changes to D7446: [Places panel] Revamp the Recently Saved section.

We need to update kfileplacesmodeltest (as well as placesitemmodeltest in dolphin).

Sun, Dec 2, 10:08 AM · Frameworks, Dolphin
elvisangelaccio added inline comments to D17281: Add icon to KBuildSycocaProgressDialog cancel button.
Sun, Dec 2, 9:48 AM · VDG, Frameworks

Sat, Dec 1

elvisangelaccio accepted D17111: Do not sort twice when changing role and order at the same time.
Sat, Dec 1, 4:14 PM · Dolphin
elvisangelaccio accepted D17042: Fix selection when navigating back, with size sorting..

I think we can land this on the stable branch too (Applications/18.12).

Sat, Dec 1, 4:13 PM · Dolphin
elvisangelaccio added inline comments to D17270: [KUrlNavigator] List subdirs of a parent folder of an archive.
Sat, Dec 1, 3:59 PM · Frameworks
elvisangelaccio accepted D17256: [KUrlNavigator] Fix firstChildUrl when going back from archive.
Sat, Dec 1, 3:41 PM · Frameworks
elvisangelaccio added inline comments to D17281: Add icon to KBuildSycocaProgressDialog cancel button.
Sat, Dec 1, 3:28 PM · VDG, Frameworks

Thu, Nov 29

elvisangelaccio closed T10070: Announcement text for the Applications 18.12 release as Resolved.

Superseded by T10131.

Thu, Nov 29, 9:56 PM · KDE Promo

Sun, Nov 25

elvisangelaccio committed R36:6a7b7c797509: Cleanup function names from debugging output (authored by elvisangelaccio).
Cleanup function names from debugging output
Sun, Nov 25, 11:53 AM
elvisangelaccio added a reviewer for D17017: Fix assert when cleaning up symlinks in PreviewJob: dfaure.
Sun, Nov 25, 10:29 AM · Frameworks
elvisangelaccio accepted D16413: Add a keyboard shortcut to create file.

I don't have an opinion about the new shortcut, I'll leave that to the VDG team.

Sun, Nov 25, 10:27 AM · Dolphin
elvisangelaccio accepted D16412: Add the possibility to have a keyboard shortcut to create a file.
Sun, Nov 25, 10:25 AM · Frameworks
elvisangelaccio added a comment to D17063: Fix middle click on breadcrumbs, in split view.

@thsurrel Don't forget to abandond this diff :)

Sun, Nov 25, 10:19 AM · Dolphin
elvisangelaccio requested changes to D17111: Do not sort twice when changing role and order at the same time.
Sun, Nov 25, 10:18 AM · Dolphin

Sat, Nov 24

elvisangelaccio accepted D17114: [KUrlNavigator] Re-activate on mouse middle button click.

We could have used KUrlNavigator::mouseReleaseEvent() where we already have the same check, but this is also fine.

Sat, Nov 24, 4:43 PM · Frameworks
elvisangelaccio committed R318:b5df5f4d9581: [PlacesPanel] Port to KFilePlaceEditDialog (authored by elvisangelaccio).
[PlacesPanel] Port to KFilePlaceEditDialog
Sat, Nov 24, 12:26 PM
elvisangelaccio closed D16824: [PlacesPanel] Port to KFilePlaceEditDialog.
Sat, Nov 24, 12:26 PM · Dolphin
elvisangelaccio closed D16825: Export again KFilePlaceEditDialog.
Sat, Nov 24, 11:00 AM · Frameworks
elvisangelaccio committed R241:7ad161b1a2bb: Export again KFilePlaceEditDialog (authored by elvisangelaccio).
Export again KFilePlaceEditDialog
Sat, Nov 24, 11:00 AM
elvisangelaccio requested changes to D15368: [Comic Thumbnailer] support more image formats.
Sat, Nov 24, 10:58 AM · Frameworks, Dolphin
elvisangelaccio added inline comments to D15368: [Comic Thumbnailer] support more image formats.
Sat, Nov 24, 10:58 AM · Frameworks, Dolphin
elvisangelaccio accepted D15367: [Comic Thumbnailer] fix CBR thumbnail generation.

Sorry for taking so long.

Sat, Nov 24, 10:51 AM · Frameworks, Dolphin

Wed, Nov 21

elvisangelaccio added inline comments to D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB).
Wed, Nov 21, 8:10 PM · Frameworks

Tue, Nov 20

elvisangelaccio requested changes to D17063: Fix middle click on breadcrumbs, in split view.

Looks good beside the inline issue (hence why my Request Changes).

Tue, Nov 20, 10:21 PM · Dolphin
elvisangelaccio added a comment to D17042: Fix selection when navigating back, with size sorting..

Thanks, patch looks good and kitemlistselectionmanagertest still passes.

Tue, Nov 20, 10:02 PM · Dolphin

Mon, Nov 19

elvisangelaccio added a comment to D16872: Add FileItemActionPlugin for tag manipulation.

Shouldn't the plugin check whether the file is writable? I don't think we can add tags to root-owned files, do we?

Mon, Nov 19, 9:44 PM · Baloo
elvisangelaccio committed R241:bb00649dc6e0: [RenameDialog] Fix layout when using the NoRename flag (authored by elvisangelaccio).
[RenameDialog] Fix layout when using the NoRename flag
Mon, Nov 19, 9:40 PM
elvisangelaccio closed D16984: [RenameDialog] Fix layout when using the NoRename flag.
Mon, Nov 19, 9:40 PM · Frameworks
elvisangelaccio committed R241:d9e33ad398b0: Fix apidox of RenameDialog_Option (authored by elvisangelaccio).
Fix apidox of RenameDialog_Option
Mon, Nov 19, 9:34 PM
elvisangelaccio closed D16985: Fix apidox of RenameDialog_Option.
Mon, Nov 19, 9:34 PM · Frameworks

Sun, Nov 18

elvisangelaccio requested review of D16985: Fix apidox of RenameDialog_Option.
Sun, Nov 18, 6:56 PM · Frameworks
elvisangelaccio added a comment to D16984: [RenameDialog] Fix layout when using the NoRename flag.

Before:

Sun, Nov 18, 6:46 PM · Frameworks
elvisangelaccio requested review of D16984: [RenameDialog] Fix layout when using the NoRename flag.
Sun, Nov 18, 6:46 PM · Frameworks
elvisangelaccio added a comment to D16980: Return editable URL navigator to breadcrumb mode if it has focus and everything is selected and when Ctrl+L is pressed.

This provides a slightly easier way to make the location bar return to breadcrumbs mode

Sun, Nov 18, 5:48 PM · Dolphin
elvisangelaccio added a comment to D16648: Open externally called files/directories in new tabs.

I vote to not make it an option. There is always time to reconsider if enough people complain about the new behavior :)

Sun, Nov 18, 10:21 AM · Dolphin
elvisangelaccio added a comment to D16967: Add Documents shortcut detection.

The patch looks fine and works for me: the upatched test fails, the patched one passes.

Sun, Nov 18, 10:04 AM · Dolphin

Sat, Nov 17

elvisangelaccio added a comment to D16824: [PlacesPanel] Port to KFilePlaceEditDialog.

FIXED-IN: 19.03.80

Shouldn't that be 19.04.0? It doesn't matter that it will be in a future beta release; that's implied.

Sat, Nov 17, 3:47 PM · Dolphin
elvisangelaccio updated the diff for D16824: [PlacesPanel] Port to KFilePlaceEditDialog.
  • Properly pass places' labels to the dialog
Sat, Nov 17, 3:44 PM · Dolphin
elvisangelaccio added a comment to D16767: Improve Ux for the places panel's hidden items.

This should have been pushed on master, Applications/18.12 is feature frozen since 15th November.
Given that we are only two days late, I think we can ask for an exception, but next time please be careful.

Sat, Nov 17, 3:32 PM · Dolphin
elvisangelaccio added a comment to D16852: Add Documents to the default list of Places.

@acrouthamel Please open another diff with your patch thats updates the dolphin test, so I can try easily try it out

Sat, Nov 17, 12:14 PM · Frameworks
elvisangelaccio added inline comments to D7700: Show list of tags in PlacesView.
Sat, Nov 17, 12:07 PM · Frameworks, Dolphin
elvisangelaccio triaged T10070: Announcement text for the Applications 18.12 release as High priority.
Sat, Nov 17, 11:34 AM · KDE Promo
elvisangelaccio accepted D16857: Do not disconnect all StorageAccess signals when unmounting.

Thanks, this fixes the bug for me.

Sat, Nov 17, 11:15 AM · Dolphin
elvisangelaccio accepted D16767: Improve Ux for the places panel's hidden items.
Sat, Nov 17, 10:49 AM · Dolphin
elvisangelaccio accepted D16896: move kcrash link to dolphin app (which is the effective user).

Thanks

Sat, Nov 17, 10:30 AM · Dolphin

Nov 11 2018

elvisangelaccio added a comment to D16767: Improve Ux for the places panel's hidden items.

ONE PROBLEM HERE: Can not get a count of hidden Items on start up. the count for hidden items is always 0. So the Menu entry always starts enabled. Any help here would be great.

Nov 11 2018, 7:39 PM · Dolphin
elvisangelaccio added a reviewer for D16412: Add the possibility to have a keyboard shortcut to create a file: dfaure.
Nov 11 2018, 6:43 PM · Frameworks
elvisangelaccio added a comment to D16412: Add the possibility to have a keyboard shortcut to create a file.

+1, looks good to me now.

Nov 11 2018, 6:43 PM · Frameworks
elvisangelaccio added inline comments to D16767: Improve Ux for the places panel's hidden items.
Nov 11 2018, 6:38 PM · Dolphin
elvisangelaccio added a task to D16824: [PlacesPanel] Port to KFilePlaceEditDialog: T9795: Use Places Panel code from KIO instead of private implementation.
Nov 11 2018, 6:18 PM · Dolphin
elvisangelaccio added a revision to T9795: Use Places Panel code from KIO instead of private implementation: D16824: [PlacesPanel] Port to KFilePlaceEditDialog.
Nov 11 2018, 6:18 PM · Frameworks, Dolphin
elvisangelaccio added a revision to T8349: Improve Places panel usability and presentation: D16824: [PlacesPanel] Port to KFilePlaceEditDialog.
Nov 11 2018, 6:17 PM · VDG, Dolphin
elvisangelaccio added a task to D16824: [PlacesPanel] Port to KFilePlaceEditDialog: T8349: Improve Places panel usability and presentation.
Nov 11 2018, 6:17 PM · Dolphin
elvisangelaccio added a dependent revision for D16825: Export again KFilePlaceEditDialog: D16824: [PlacesPanel] Port to KFilePlaceEditDialog.
Nov 11 2018, 6:16 PM · Frameworks
elvisangelaccio added a dependency for D16824: [PlacesPanel] Port to KFilePlaceEditDialog: D16825: Export again KFilePlaceEditDialog.
Nov 11 2018, 6:16 PM · Dolphin
elvisangelaccio requested review of D16825: Export again KFilePlaceEditDialog.
Nov 11 2018, 6:16 PM · Frameworks
elvisangelaccio requested review of D16824: [PlacesPanel] Port to KFilePlaceEditDialog.
Nov 11 2018, 6:14 PM · Dolphin
elvisangelaccio committed R318:20e11282b547: [PlacesItem] Add support for OnlyInApp metadata for bookmarks (authored by elvisangelaccio).
[PlacesItem] Add support for OnlyInApp metadata for bookmarks
Nov 11 2018, 6:05 PM
elvisangelaccio committed R318:140ccf1df8ae: [PlacesItemModel] Match KFilePlacesModel addPlaces() API (authored by elvisangelaccio).
[PlacesItemModel] Match KFilePlacesModel addPlaces() API
Nov 11 2018, 6:05 PM
elvisangelaccio committed R318:e3eba9ea66e2: Merge branch 'Applications/18.12' (authored by elvisangelaccio).
Merge branch 'Applications/18.12'
Nov 11 2018, 6:05 PM
elvisangelaccio committed R318:23350914f67b: Update copyright year in KAboutData (authored by elvisangelaccio).
Update copyright year in KAboutData
Nov 11 2018, 6:05 PM
elvisangelaccio added inline comments to D16767: Improve Ux for the places panel's hidden items.
Nov 11 2018, 4:39 PM · Dolphin