- User Since
- Aug 16 2015, 4:08 PM (121 w, 1 d)
Sun, Dec 10
- Dropped TODO, there is not enough evidence that this method should become protected.
Fri, Dec 8
I can't apply this patch, can you please rebase it?
LGTM as well.
Mon, Dec 4
Sun, Dec 3
LGTM now, thanks!
Fri, Dec 1
What about non-unix systems? e.g. on Windows we don't have dbus but the stash ioslave could still be functional (or maybe not, @shortstheory what do you say?)
Ping? Is anyone working on this?
Thu, Nov 30
Patch doesn't apply for me (running arc patch D8855). Do you need to rebase it?
Tue, Nov 28
- Addressed comments
Mon, Nov 27
I'm getting this failure when running the test:
Sun, Nov 26
If this doesn't fix bug #332948, please remove it from the BUG: keyword, otherwise it will be automatically closed when pushing this commit.
Sat, Nov 25
Oh, you're totally right. Everything looks good then, thanks for the patch!
Fri, Nov 24
We probably need a manpage anyway, since this is a cli app. If we go with manpage only, would it show up in khelpcenter?
Thu, Nov 23
Wed, Nov 22
What about using ecm_setup_version ?
Tue, Nov 21
Please bump the minimum KIO version in CMakeLists.txt
By the way, this code can probably be simplified by making m_label a KSqueezedTextLabel. Feel like doing a follow up patch? :)
Mon, Nov 20
Sun, Nov 19
Cherry-picked on the stable branch.
@ngraham Next time please push bugfixes to the Applications/xx.yy branch, then merge on master.
Sat, Nov 18
@rkflx Good catch :(
Fri, Nov 17
Thu, Nov 16
Thanks for working on this.
Can you try to use the event filter in KItemListRoleEditor instead? It should be enough to also check for the QEvent::Wheel event.
It seems to work for me and the patch becomes much simpler.
- Use local variables
- Fix also mkpathjobtest and fileundomanagertest
Wed, Nov 15
Tue, Nov 14
Mon, Nov 13
The Applications/17.12 branch has been created, so on master we could already depend on KIO >= 5.40. How about doing that?
Sun, Nov 12
- Implement a global 'edit mode' that enables both kind of drags (whole toolbar + actions within the toolbar).