elvisangelaccio (Elvis Angelaccio)
Developer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Aug 16 2015, 4:08 PM (209 w, 3 d)
Availability
Available

Recent Activity

Wed, Aug 14

elvisangelaccio added a comment to D22594: [Dolphin] Open Preferred Search Tool action.

I'll be AFK for a week for vacation. Will do a proper review once I'm back ;)

Wed, Aug 14, 10:50 PM · Documentation, Dolphin
elvisangelaccio added a comment to D23075: Change default Dolphin toolbar layout.

Wow, this is quite a radical change :)

Wed, Aug 14, 10:49 PM · VDG, Dolphin

Tue, Aug 13

elvisangelaccio committed R318:0ab277905885: Remove redundant code (authored by aprcela).
Remove redundant code
Tue, Aug 13, 9:22 PM
elvisangelaccio closed D23129: Remove redundant code.
Tue, Aug 13, 9:22 PM · Dolphin
elvisangelaccio added a comment to D22802: [dolphin] make link with LLVM.

Can you try to build another kdeinit app (i.e. khelpcenter) to check if you get the same error?

Tue, Aug 13, 8:49 PM · Dolphin
elvisangelaccio added a comment to D22183: Add click to play/pause feature on previews for audio/video.

Btw I think I spotted a regression:

Tue, Aug 13, 8:34 PM · Dolphin
elvisangelaccio added a comment to D23129: Remove redundant code.

Got the following errore while pushing:

Tue, Aug 13, 8:18 PM · Dolphin
elvisangelaccio accepted D23129: Remove redundant code.

Thanks

Tue, Aug 13, 8:15 PM · Dolphin

Sun, Aug 11

elvisangelaccio requested changes to D22183: Add click to play/pause feature on previews for audio/video.
Sun, Aug 11, 3:05 PM · Dolphin
elvisangelaccio added inline comments to D23087: Do not match daemonized dolphin instances: part 2.
Sun, Aug 11, 2:08 PM · Dolphin
elvisangelaccio committed R318:c18f5fde4b9b: Match style of if() condition used above (authored by elvisangelaccio).
Match style of if() condition used above
Sun, Aug 11, 2:08 PM
elvisangelaccio committed R318:87f30d3fc817: Merge branch 'Applications/19.08' (authored by elvisangelaccio).
Merge branch 'Applications/19.08'
Sun, Aug 11, 2:03 PM
elvisangelaccio committed R318:aeba47648d8b: Do not match daemonized dolphin instances: part 2 (authored by elvisangelaccio).
Do not match daemonized dolphin instances: part 2
Sun, Aug 11, 1:57 PM
elvisangelaccio closed D23087: Do not match daemonized dolphin instances: part 2.
Sun, Aug 11, 1:57 PM · Dolphin
elvisangelaccio committed R318:ec1a0c2543a5: Fix an issue with focus lost after closing terminal panel (authored by AndreyYashkin).
Fix an issue with focus lost after closing terminal panel
Sun, Aug 11, 11:24 AM
elvisangelaccio closed D22420: Fix an issue with focus lost after closing terminal panel.
Sun, Aug 11, 11:24 AM · Dolphin
elvisangelaccio accepted D22420: Fix an issue with focus lost after closing terminal panel.

I'd still like to understand what happend at the change in 4e40fe810d324.

@ngraham Any idea?

@elvisangelaccio, I read the description of change in 4e40fe810d324 and bug 298467, which was fixed in it more carefull and understood that the change was supposed to introduce the feature of setting the focus back to the active view. However, it seems that Ctrl-D or exit command cases were not tested good enough.

Sun, Aug 11, 11:22 AM · Dolphin
elvisangelaccio committed R318:2de943fbe452: Coding style fixes (authored by elvisangelaccio).
Coding style fixes
Sun, Aug 11, 10:40 AM
elvisangelaccio committed R318:4a25f01b7c13: Move variables closer to their usage (authored by elvisangelaccio).
Move variables closer to their usage
Sun, Aug 11, 10:40 AM
elvisangelaccio added reviewers for D23087: Do not match daemonized dolphin instances: part 2: ngraham, feverfew.
Sun, Aug 11, 10:19 AM · Dolphin
elvisangelaccio requested review of D23087: Do not match daemonized dolphin instances: part 2.
Sun, Aug 11, 10:18 AM · Dolphin
elvisangelaccio accepted D22907: fall back to nummerical owner and group if no text representation exists.

Please push to master or wait after August 15th (Applications 19.08 Release day) if you need this in the stable branch too.

Sun, Aug 11, 9:28 AM · Ark

Wed, Aug 7

elvisangelaccio accepted D22983: Fix build with cmake < 3.7.
Wed, Aug 7, 8:22 PM · Ark

Sat, Aug 3

elvisangelaccio committed R318:ba92917ac2f3: [Dolphin] Hide tooltip instantly on key press (authored by pdabrowski).
[Dolphin] Hide tooltip instantly on key press
Sat, Aug 3, 1:32 PM
elvisangelaccio closed D22512: [Dolphin] Hide tooltip instantly on key press.
Sat, Aug 3, 1:32 PM · Dolphin
elvisangelaccio accepted D22512: [Dolphin] Hide tooltip instantly on key press.

Thanks, LGTM now.

Sat, Aug 3, 12:01 PM · Dolphin
elvisangelaccio added a comment to D22444: Add Reset Zoom Level action inside View menu.
Sat, Aug 3, 11:55 AM · Documentation, Dolphin
elvisangelaccio requested changes to D22444: Add Reset Zoom Level action inside View menu.
Sat, Aug 3, 11:50 AM · Documentation, Dolphin
elvisangelaccio accepted D22628: Fix mimeType loss during file creation or update..
Sat, Aug 3, 10:40 AM · KIO GDrive
elvisangelaccio requested changes to D22149: Add "Add to Places" action to file menu.

There seems to be another issue: if I run dolphin <some folder> from cmd line I always get Add 'file' to place, no matter what the folder is.

Sat, Aug 3, 10:33 AM · Dolphin
elvisangelaccio added inline comments to D22512: [Dolphin] Hide tooltip instantly on key press.
Sat, Aug 3, 10:23 AM · Dolphin

Sun, Jul 28

elvisangelaccio added a comment to R318:dc586ada63d1: Fix name grouping feature for cyrillic names.

Reverted this commit and then pushed diff 61904.

Sun, Jul 28, 8:16 PM
elvisangelaccio committed R318:e9d8bab20bdc: Fix name grouping feature for cyrillic names (authored by AndreyYashkin).
Fix name grouping feature for cyrillic names
Sun, Jul 28, 8:15 PM
elvisangelaccio added a reverting change for R318:dc586ada63d1: Fix name grouping feature for cyrillic names: R318:b8849f74aab2: Revert "Fix name grouping feature for cyrillic names".
Sun, Jul 28, 8:15 PM
elvisangelaccio committed R318:b8849f74aab2: Revert "Fix name grouping feature for cyrillic names" (authored by elvisangelaccio).
Revert "Fix name grouping feature for cyrillic names"
Sun, Jul 28, 8:15 PM
elvisangelaccio added a comment to D22628: Fix mimeType loss during file creation or update..

Note that the commit message will need BUG: (with the colons) in order to automagically close the bug report.

Sun, Jul 28, 8:03 PM · KIO GDrive
elvisangelaccio added a comment to R318:dc586ada63d1: Fix name grouping feature for cyrillic names.

@elvisangelaccio, you have forgotten or I did not say clear enough that it is the previous cosmetic cosmetic version(Diff 61904) that was correct! Read my remark again in the revision conversation, please. @hein did not respond and I cannot say even if this one is fully correct for Korean. The one line solution does groupping of some Cyrillic symbols, which cannot be grouped toggether(aleast in Russian dictionary)
This was my fall. Sorry again for it.

Sun, Jul 28, 5:18 PM
elvisangelaccio updated subscribers of D22420: Fix an issue with focus lost after closing terminal panel.

I'd still like to understand what happend at the change in 4e40fe810d324.

Sun, Jul 28, 5:09 PM · Dolphin
elvisangelaccio requested changes to D22512: [Dolphin] Hide tooltip instantly on key press.
Sun, Jul 28, 5:08 PM · Dolphin
elvisangelaccio committed R318:572d4e54bbe6: Merge branch 'Applications/19.08' (authored by elvisangelaccio).
Merge branch 'Applications/19.08'
Sun, Jul 28, 4:32 PM
elvisangelaccio committed R318:8bed4c25ee42: Fix dir change when show hidden terminal panel with running program in it (authored by AndreyYashkin).
Fix dir change when show hidden terminal panel with running program in it
Sun, Jul 28, 4:31 PM
elvisangelaccio closed D22422: Fix dir change when show hidden terminal panel with running program in it.
Sun, Jul 28, 4:31 PM · Dolphin
elvisangelaccio accepted D22422: Fix dir change when show hidden terminal panel with running program in it.

Thanks, going to push to 19.08 :)

Sun, Jul 28, 4:31 PM · Dolphin
elvisangelaccio committed R318:dc586ada63d1: Fix name grouping feature for cyrillic names (authored by AndreyYashkin).
Fix name grouping feature for cyrillic names
Sun, Jul 28, 3:12 PM
elvisangelaccio closed D22303: Fix name grouping feature for cyrillic names.
Sun, Jul 28, 3:12 PM · Dolphin
elvisangelaccio accepted D22303: Fix name grouping feature for cyrillic names.

Well, I like that we are replacing 20+ lines of code with only one ;)

Sun, Jul 28, 3:12 PM · Dolphin
elvisangelaccio committed R36:afdf8f2638c7: Display BLAKE2 file checksums for RAR files (authored by Natsumi Higa <r0106.nhiga.kde@protonmail.com>).
Display BLAKE2 file checksums for RAR files
Sun, Jul 28, 3:09 PM
elvisangelaccio closed D21637: Display BLAKE2 file checksums for RAR files.
Sun, Jul 28, 3:09 PM · Ark
elvisangelaccio added a comment to D22594: [Dolphin] Open Preferred Search Tool action.

As for the feature itself, for the past few years I'd been opposed to this, on the basis that people should just use the built-in Baloo-based search instead. But unfortunately the requests keep coming in

Sun, Jul 28, 3:00 PM · Documentation, Dolphin
elvisangelaccio requested changes to D22149: Add "Add to Places" action to file menu.

Code looks good, but I spotted a regression: 'Add to Places' is now disabled if you don't select any folder. Currently it is possible to add the current folder as place without the need for any selection.

Sun, Jul 28, 2:48 PM · Dolphin
elvisangelaccio accepted D22529: Do not display a buggy filesize for non local files.

LGTM. Feel free to push on 19.08.

Sun, Jul 28, 2:35 PM · Baloo
elvisangelaccio committed R318:9d4c75d2f7a9: Fix an issue with a new tab focus (authored by AndreyYashkin).
Fix an issue with a new tab focus
Sun, Jul 28, 2:20 PM
elvisangelaccio closed D22386: Fix an issue with a new tab focus.
Sun, Jul 28, 2:20 PM · Dolphin
elvisangelaccio accepted D22386: Fix an issue with a new tab focus.

I like this solution better. I'll push on master only for now, and we'll see if we break something ;)

Sun, Jul 28, 2:19 PM · Dolphin
elvisangelaccio accepted D21637: Display BLAKE2 file checksums for RAR files.
Sun, Jul 28, 2:04 PM · Ark
elvisangelaccio committed R136:f6da3c15ec90: Bump version and update changelog (authored by elvisangelaccio).
Bump version and update changelog
Sun, Jul 28, 10:50 AM
elvisangelaccio committed R136:796668c08f5d: Update stopwatch granularity on change in settings (authored by gshah).
Update stopwatch granularity on change in settings
Sun, Jul 28, 10:50 AM

Jul 21 2019

elvisangelaccio added inline comments to D22628: Fix mimeType loss during file creation or update..
Jul 21 2019, 8:48 PM · KIO GDrive
elvisangelaccio added a comment to D22628: Fix mimeType loss during file creation or update..

Can you expland a bit the commit message explaining how does libkgapi use the filename?

Jul 21 2019, 8:14 PM · KIO GDrive
elvisangelaccio accepted D22462: Avoid calling finished() after error()".

Please push to master. Thanks!

Jul 21 2019, 8:03 PM · KIO GDrive
elvisangelaccio added inline comments to D22462: Avoid calling finished() after error()".
Jul 21 2019, 7:15 PM · KIO GDrive
elvisangelaccio added a comment to D21637: Display BLAKE2 file checksums for RAR files.

I'd go with option 1 ;)

Jul 21 2019, 7:11 PM · Ark
elvisangelaccio added a comment to D22303: Fix name grouping feature for cyrillic names.

Previous Diff 61904 was correct.

Jul 21 2019, 7:10 PM · Dolphin

Jul 17 2019

elvisangelaccio added a comment to D21637: Display BLAKE2 file checksums for RAR files.

Sorry for the delay. See the inline comment.

Jul 17 2019, 8:32 PM · Ark
elvisangelaccio added a comment to D22265: KPluginMetaData: use Q_DECLARE_METATYPE.

This runs the chance to break some 3rd-party software which also calls the Q_DECLARE_METATYPE(KPluginMetaData) macro.
Any chance this could be moved to the place that needs this for now, and perhaps add a KF6 TODO instead?

See e.g. R36:3aacbbaab50ac6e0557c5d69c430459eb3d71ad7 which was needed to unbreak ark builds.

Jul 17 2019, 8:25 PM · Frameworks
elvisangelaccio requested changes to D22512: [Dolphin] Hide tooltip instantly on key press.

Thanks for the patch! The fix looks correct, but I have suggestions for the coding style.

Jul 17 2019, 8:17 PM · Dolphin
elvisangelaccio added a comment to D21937: Use destinationDir to save viewproperties when not in global viewproperties setting.

Sorry, I missed this one. I'd say let's postpone to 19.12...

Jul 17 2019, 7:44 PM · Dolphin
elvisangelaccio requested changes to D22183: Add click to play/pause feature on previews for audio/video.
Jul 17 2019, 7:43 PM · Dolphin
elvisangelaccio committed R318:aabfce16797a: Fix rubber band not going away after right-click (authored by jacksonmcneill).
Fix rubber band not going away after right-click
Jul 17 2019, 7:42 PM
elvisangelaccio closed D21590: Fix rubber band not going away after right-click.
Jul 17 2019, 7:42 PM · Dolphin
elvisangelaccio accepted D21590: Fix rubber band not going away after right-click.
Jul 17 2019, 7:39 PM · Dolphin
elvisangelaccio accepted D22303: Fix name grouping feature for cyrillic names.

Thanks for the patch!

Given that the correctness of this code depends on the locale, I'm not confident we won't break some corner cases.
Ideally we'd need more unit tests in KFileItemModelTest::testNameRoleGroups(), but I understand that's a lot to ask.

@cfeck in the bug report suggested to add more letters ranges. @AndreyYashkin Did you try that?

As I understand the puprose of vector "lettersAtoZ" is to put words like "Ottava" and german "Österreich" in one latin "O" group. It seems to be some feature of german language that was taken into account by the author of code. I cannot speak for all who use cyrillic script, but in russian we do not expect anything like this. Thatwhy I discarded the idea of one more range. In addition, it may be wrong to apply such behavior for all languages that use extended latin alphabets.

QCollator thinks that cyrillic symbols are less than latin characters, while chinese and others are bigger. For this reason, it is necessary to put them in a new group without searching them in the vector or they will be putted in latin "A" group.

Jul 17 2019, 7:32 PM · Dolphin

Jul 15 2019

elvisangelaccio requested changes to D22462: Avoid calling finished() after error()".
Jul 15 2019, 8:29 PM · KIO GDrive
elvisangelaccio requested changes to D22444: Add Reset Zoom Level action inside View menu.

Please use a descriptive commit message: https://community.kde.org/Policies/Commit_Policy#Always_add_descriptive_log_messages

Jul 15 2019, 8:25 PM · Documentation, Dolphin
elvisangelaccio added inline comments to D21878: Rewrite servicemenu helper utility in C++.
Jul 15 2019, 8:12 PM · Dolphin
elvisangelaccio accepted D22465: servicemenuinstaller: Use QMimeDatabase instead of running xdg-mime.

Thanks :)

Jul 15 2019, 8:10 PM · Dolphin
elvisangelaccio accepted D22461: Add missing QVector include.
Jul 15 2019, 8:06 PM · Ark

Jul 14 2019

elvisangelaccio accepted D21878: Rewrite servicemenu helper utility in C++.
Jul 14 2019, 9:12 PM · Dolphin
elvisangelaccio added a comment to D22420: Fix an issue with focus lost after closing terminal panel.

This issue was supposed to be fixed by commit 4e40fe810d324 but it seems it got reintroduced in the past months.

Jul 14 2019, 9:08 PM · Dolphin
elvisangelaccio requested changes to D22386: Fix an issue with a new tab focus.

Hmm, this feels like a work-around because we initialize m_active(true) everywhere else (DolphinView, DolphinSearchBox).

Jul 14 2019, 8:58 PM · Dolphin
elvisangelaccio requested changes to D21878: Rewrite servicemenu helper utility in C++.
Jul 14 2019, 8:32 PM · Dolphin
elvisangelaccio added inline comments to D21782: Add a warning dialog with details, continue, and cancel button.
Jul 14 2019, 8:21 PM · Frameworks

Jul 7 2019

elvisangelaccio accepted D22290: Update stopwatch granularity on change in settings.

Thanks for the patch!

Jul 7 2019, 8:02 PM · Kronometer
elvisangelaccio accepted D22009: Re get Google credentials from KAccounts when a refresh is needed..
Jul 7 2019, 7:51 PM
elvisangelaccio added a comment to D21878: Rewrite servicemenu helper utility in C++.

src/settings/services/servicemenuinstaller/servicemenuinstaller.cpp
35–42
Since we are in a Qt program now, we could just open a KMessageBox rather than spawn another process just to show an error dialog (and kdialog might not even be installed).

71–77
Same here. We should use QMimeDatabase rather than run xdg-mime.

This patch is about rewrite to C++. What you suggest are good ideas, but can be done as separate patches, from my POV they are of lower priority.

Besides the two issues you mentioned, the current implementation also has a huge bug that stops many services menus from being installed: the installation scripts are run from a wrong current working dir. I already have a patch to fix it, however I will post it when this one lands because otherwise it's hard to publish the second patch with Phabricator.

To be exact, KMessageBox is not equivalent to kdialog --passivepopup.

Jul 7 2019, 7:50 PM · Dolphin
elvisangelaccio added a reviewer for D22303: Fix name grouping feature for cyrillic names: cfeck.
Jul 7 2019, 7:46 PM · Dolphin
elvisangelaccio updated subscribers of D22303: Fix name grouping feature for cyrillic names.

Thanks for the patch!

Jul 7 2019, 7:45 PM · Dolphin
elvisangelaccio added a comment to T10630: Show Team Drives.

Sure!

Jul 7 2019, 7:06 PM · KIO GDrive

Jul 3 2019

elvisangelaccio added inline comments to D21878: Rewrite servicemenu helper utility in C++.
Jul 3 2019, 7:56 PM · Dolphin

Jul 1 2019

elvisangelaccio added a comment to D21838: Add Drive resource and example..

@barchiesi This commit broke the kio-gdrive build (CanCreateTeamDrives no longer existing).

Jul 1 2019, 9:16 PM · LibKGAPI, KDE PIM
elvisangelaccio added a comment to D22144: Add kio recentlyused:/ to access KActivityStats data.

+1

Jul 1 2019, 8:05 PM · Frameworks, Dolphin

Jun 30 2019

elvisangelaccio updated subscribers of D22009: Re get Google credentials from KAccounts when a refresh is needed..

@elvisangelaccio We have a refresh token available that could be used but I couldn't find any information regarding refreshing an account through KAccounts. Do you know if such functionality is available? If not, would you perhaps know who I can reach out to?

Jun 30 2019, 8:38 PM
elvisangelaccio accepted D19471: Middle-elide file/folder labels so the extension is always visible.

I guess go for it.

Jun 30 2019, 8:29 PM · Dolphin
elvisangelaccio added inline comments to D22144: Add kio recentlyused:/ to access KActivityStats data.
Jun 30 2019, 8:19 PM · Frameworks, Dolphin
elvisangelaccio committed R226:ce61f5132a6d: fix crash in webenginepart on konqueror shutdown (authored by jhirte).
fix crash in webenginepart on konqueror shutdown
Jun 30 2019, 8:11 PM
elvisangelaccio closed D21562: fix crash in webenginepart on konqueror shutdown.
Jun 30 2019, 8:11 PM

Jun 23 2019

elvisangelaccio committed R318:bd788a3ff425: Add "What's This?" to nearly everything in the main window (authored by felixernst).
Add "What's This?" to nearly everything in the main window
Jun 23 2019, 7:25 PM
elvisangelaccio closed D20471: Add "What's This?" to nearly everything in the main window.
Jun 23 2019, 7:25 PM · Dolphin
elvisangelaccio accepted D20471: Add "What's This?" to nearly everything in the main window.
Jun 23 2019, 7:24 PM · Dolphin
elvisangelaccio requested changes to D20471: Add "What's This?" to nearly everything in the main window.

Sorry but there are a lot of trailing whitespace changes (which unfortunately phabricator ignores).

Jun 23 2019, 5:09 PM · Dolphin