elvisangelaccio (Elvis Angelaccio)
Developer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 16 2015, 4:08 PM (448 w, 1 d)
Availability
Available

Recent Activity

Dec 3 2022

elvisangelaccio added a comment to T14154: Adapt to QTextCodec changes.

We might need to use QTextCodec in ark to fix this bug: https://bugs.kde.org/show_bug.cgi?id=393901#c12

Dec 3 2022, 11:59 AM · KF6

Nov 24 2022

elvisangelaccio closed T11560: Create new set of keys to replace the PIM ones as Resolved.

Closing, see https://invent.kde.org/network/kio-gdrive/-/commit/6d7456fde9762bf76007388d17b7367b20160ac4

Nov 24 2022, 10:03 PM · KIO GDrive

Jun 9 2022

elvisangelaccio closed T1876: Check for available space before starting jobs as Resolved.

Fixed with https://invent.kde.org/utilities/ark/-/commit/75ee205a779a13f536186720295cae71f130c4a6

Jun 9 2022, 5:47 PM · Ark

Jul 4 2021

elvisangelaccio added a comment to T14538: Move KOverlayIconPlugin to KIOCore.

What do we gain by removing it from KIO?

Jul 4 2021, 11:58 AM · KF6

Dec 29 2020

elvisangelaccio added inline comments to D27790: update KParts' ReadOnlyPart::localFilePath in DolphinPart::openUrl().
Dec 29 2020, 10:29 PM · Dolphin

Dec 28 2020

elvisangelaccio requested changes to D24907: Fix error handling when renaming a single file.

Sorry for the delay.
Patch looks good beside the inline comment. @alexmi Can you fix it?

Dec 28 2020, 10:03 PM · Dolphin
elvisangelaccio closed D9094: Use a faster way to determine kio-stash isn't installed.

Merged with b339ac1b5f22efb57619c738eb39268c3e00948d

Dec 28 2020, 9:47 PM · Dolphin
elvisangelaccio added a comment to D29525: Make Previews devicePixelRatio aware.

Superseded by https://invent.kde.org/system/dolphin/-/merge_requests/147

Dec 28 2020, 5:11 PM · Dolphin
elvisangelaccio accepted D9094: Use a faster way to determine kio-stash isn't installed.

Given that nothing happened in 3 years and that kio-stash (sadly) is still not very popular, I'm going to merge this patch.

Dec 28 2020, 5:06 PM · Dolphin
elvisangelaccio abandoned D19288: Respect default web browser system settings in address bar.
Dec 28 2020, 4:50 PM · Dolphin
elvisangelaccio commandeered D19288: Respect default web browser system settings in address bar.

Closing since this is superseded now.

Dec 28 2020, 4:50 PM · Dolphin
elvisangelaccio abandoned D18838: Fix opening http links in browser.
Dec 28 2020, 4:49 PM · Dolphin
elvisangelaccio commandeered D18838: Fix opening http links in browser.

Closing.

Dec 28 2020, 4:49 PM · Dolphin
elvisangelaccio added a comment to D21937: Use destinationDir to save viewproperties when not in global viewproperties setting.

Sorry, I missed this one. I'd say let's postpone to 19.12...

No worries

Also we might want to discuss it a bit more, folder moving :

A limitation of the current patch is when a folder is moved, the settings are lost.
I can imagine two potential solution :

  • a "bazooka" solution : use inotify and consort to have the settings follow the files.
  • a simple solution : use inode id as path in destinationDir for local files. That way if a folder is moved its settings follow. Although it won't survive network moves.

A third solution would be to store the view settings in an extended attribute on the folder itself. That wouldn't survive copying to or from filesystems that don't support xattrs though.

Dec 28 2020, 4:40 PM · Dolphin
elvisangelaccio added a comment to D25651: Allow to forget recentlyused resources.

This doesn't seem to work for me. When I click on the new menu item, the view refreshes but the item I told it to forget it still visible in the ioslave.

Unfortunately the

This doesn't seem to work for me. When I click on the new menu item, the view refreshes but the item I told it to forget it still visible in the ioslave.

I may be due to the asynchronous nature of KActivities::Stats calling dbus and sqlite.
I will see what I can do to improve on the situation.

Dec 28 2020, 4:25 PM · Dolphin
elvisangelaccio added inline comments to D27790: update KParts' ReadOnlyPart::localFilePath in DolphinPart::openUrl().
Dec 28 2020, 4:23 PM · Dolphin
elvisangelaccio added a comment to D29115: Add option to show hidden files and folders last.

You said it yourself: every setting needs a good amount of clutter code, which makes the overall codebase harder to test and harder to maintain. That's why we try to avoid adding a new setting every time we add a new feature.

We can reconsider if enough people complain about this new behavior not being optional.

So is that a let's go with it? I'm sorry I'm kinda lost as per what you want to do exactly (if anything at all), I don't have much of a say here. My opinion I already gave.

Dec 28 2020, 4:21 PM · Dolphin

Nov 11 2020

elvisangelaccio added a project to T13752: Cleanup Dolphin Context Menu and make components reusable: Dolphin.
Nov 11 2020, 6:36 PM · Dolphin, KF6

Nov 6 2020

elvisangelaccio abandoned D12983: (icon view) Text width relative to icon size.
Nov 6 2020, 12:34 AM · Dolphin
elvisangelaccio commandeered D12983: (icon view) Text width relative to icon size.
Nov 6 2020, 12:34 AM · Dolphin

Oct 23 2020

elvisangelaccio added a comment to D23694: Add support for sshfs to the fstab backend.

@elvisangelaccio Thanks, first of all. If that's the case, do you think it's better to touch KIO first before landing this?

Yeah this should probably wait for the KIO patch, which I just submitted: https://invent.kde.org/frameworks/kio/-/merge_requests/175

Oct 23 2020, 4:32 PM · Frameworks

Oct 18 2020

elvisangelaccio added a comment to D23694: Add support for sshfs to the fstab backend.

@elvisangelaccio Thanks, first of all. If that's the case, do you think it's better to touch KIO first before landing this?

Oct 18 2020, 10:42 PM · Frameworks

Oct 17 2020

elvisangelaccio added a comment to T8187: Single click vs double-click.

Just my 2 cents: we have telemetry now, so we can actually check whether people prefer single or double click.

Oct 17 2020, 2:43 PM · Plasma, VDG

Oct 15 2020

elvisangelaccio added a comment to D23694: Add support for sshfs to the fstab backend.

Would this change be needed on this side or kdeconnect side? I don't mind landing this, but I need formal approval by someone. (I won't have any time to do additional changes elsewhere).

Oct 15 2020, 5:47 PM · Frameworks

Oct 14 2020

elvisangelaccio added a comment to D23694: Add support for sshfs to the fstab backend.

Ping? Can we get this in?

Oct 14 2020, 10:52 PM · Frameworks

Oct 11 2020

elvisangelaccio closed T13738: Change listing key from stringlist to bool as Wontfix.

I see, so I guess it doesn't hurt to keep KProtocolManager::listing() around and the gain wouldn't be worth the effort.

Oct 11 2020, 4:28 PM · KF6

Oct 8 2020

elvisangelaccio added a comment to T13738: Change listing key from stringlist to bool.

Yeah I could not find any usage of KProtocolManager::listing(), not even in KIO...

Oct 8 2020, 8:55 PM · KF6

Oct 7 2020

elvisangelaccio created T13738: Change listing key from stringlist to bool.
Oct 7 2020, 10:22 PM · KF6

Sep 13 2020

elvisangelaccio added a comment to T13595: Improve Dolphin homepage.

https://dolphin.kde.org/ would be nice but very low-priority. I know there is already plenty of work on the table for the websites people ;)

Sep 13 2020, 6:48 PM · Dolphin, KDE Promo

Sep 9 2020

elvisangelaccio closed T12061: Nicer URLs for kde.org/applications as Resolved.

Fixed by @ognarb after discussing it at today's Website BoF :)

Sep 9 2020, 9:39 PM · Goal: All About the Apps, Websites
elvisangelaccio created T13595: Improve Dolphin homepage.
Sep 9 2020, 9:07 PM · Dolphin, KDE Promo

Sep 7 2020

elvisangelaccio closed T5408: Integrate KBookmarks (incl. bookmarks editor) into Dolphin as Resolved.

This has been done!

Sep 7 2020, 11:54 PM · Dolphin

Sep 5 2020

elvisangelaccio abandoned D7696: Add "Width" and "Height" separately to Additional Information -> Images.
Sep 5 2020, 11:44 PM · Dolphin
elvisangelaccio added a comment to D7696: Add "Width" and "Height" separately to Additional Information -> Images.

Superseded by D11816

Sep 5 2020, 11:44 PM · Dolphin
elvisangelaccio commandeered D7696: Add "Width" and "Height" separately to Additional Information -> Images.
Sep 5 2020, 11:44 PM · Dolphin
elvisangelaccio added a comment to D28370: Set a better defaultDropAction for dragging.

This caused issues so I reverted it for now.

Sep 5 2020, 8:58 PM · Dolphin

Aug 25 2020

elvisangelaccio closed T8144: Fix failing timestamp tests as Resolved.

Fixed with https://invent.kde.org/utilities/ark/-/commit/c7764f469021122d487c3c74cf364b751b2d3ae8

Aug 25 2020, 4:51 PM · Ark
elvisangelaccio closed T8083: LibzipPlugin::testArchive() is memory hungry as Resolved.

Fixed with https://invent.kde.org/utilities/ark/-/merge_requests/4

Aug 25 2020, 4:42 PM · Ark

Aug 23 2020

elvisangelaccio added a comment to T8144: Fix failing timestamp tests.

Hi, can you please submit the patch on gitlab? https://invent.kde.org/utilities/ark

Aug 23 2020, 9:01 PM · Ark

Aug 19 2020

elvisangelaccio added a comment to T13518: Revisit KUserFeedback collected data and UX.

As a starter, I'd add a global kill switch in the plasma KCM. KUserFeedback already supports the concept of kill switch AFAICS, we are just missing the UI for it.

Aug 19 2020, 3:11 PM · Frameworks, VDG

Jul 26 2020

elvisangelaccio added a comment to D23168: Use embedded cover in MP4 video files.

@hschaefer Please abandon this review. Thanks :)

Jul 26 2020, 10:36 PM

Jul 18 2020

elvisangelaccio added a comment to D20532: Proof of Concept: Add double click actions to empty space in the folder view.

Here's a recap. I might accept the patch if:

Jul 18 2020, 3:47 PM · Dolphin
elvisangelaccio added a comment to T12061: Nicer URLs for kde.org/applications.

I'm looking at the code. If I'm not wrong, the URLs are generated by parsing https://kde.org/applications/index.json

Jul 18 2020, 2:15 PM · Goal: All About the Apps, Websites

Jul 12 2020

elvisangelaccio accepted D29178: [dolphin] : Mac integration.

Feel free to ship it.

Jul 12 2020, 10:48 PM · Dolphin
elvisangelaccio added a comment to D23168: Use embedded cover in MP4 video files.

You uploaded a wrong version of the patch. Please do a git rebase master and make sure you only have one commit on top of origin/master.

Jul 12 2020, 10:07 PM

Jul 5 2020

elvisangelaccio added a comment to D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.
In D21312#675714, @Zren wrote:

I have created a Merge Request on GitLab with a a couple new commits.

https://invent.kde.org/system/dolphin/-/merge_requests/31

  • It will only show on devices. It no longer show under mounted folders like Root in the user's favorite places.
  • Adurol on Freenode pointed out that the KIO FilePicker now uses KIO::FileSystemFreeSpaceJob, so I've refactored the patch to use that API.
Jul 5 2020, 5:05 PM · Dolphin
elvisangelaccio requested changes to D27710: Remove unused FindIntlTool.

What about 1a98206873d77310a161e2ff7f39afe1060484a0 ? Is it not needed anymore?

Jul 5 2020, 4:36 PM
elvisangelaccio added a comment to D29178: [dolphin] : Mac integration.

@feverfew Does it look good now for you?

Jul 5 2020, 4:32 PM · Dolphin
elvisangelaccio abandoned D29419: Improved Touch support.

Superseded by https://invent.kde.org/system/dolphin/-/merge_requests/7

Jul 5 2020, 4:28 PM · Dolphin
elvisangelaccio commandeered D29419: Improved Touch support.
Jul 5 2020, 4:28 PM · Dolphin
elvisangelaccio abandoned D12162: Add support for touch scrolling in Dolphin.

Superseded by https://invent.kde.org/system/dolphin/-/merge_requests/7

Jul 5 2020, 4:28 PM · Dolphin
elvisangelaccio commandeered D12162: Add support for touch scrolling in Dolphin.
Jul 5 2020, 4:27 PM · Dolphin
elvisangelaccio requested changes to D23168: Use embedded cover in MP4 video files.
Jul 5 2020, 4:26 PM

Jun 21 2020

elvisangelaccio requested changes to D23168: Use embedded cover in MP4 video files.

Please either copy the FindTaglib.cmake from ECM master or require KF5 >= 5.72 and don't copy FindTaglib.cmake here.

Jun 21 2020, 9:27 PM
elvisangelaccio abandoned D21695: Add FindTaglib.cmake.
Jun 21 2020, 9:17 PM · Build System, Frameworks
elvisangelaccio commandeered D21695: Add FindTaglib.cmake.
Jun 21 2020, 9:17 PM · Build System, Frameworks

Jun 15 2020

elvisangelaccio added inline comments to D23168: Use embedded cover in MP4 video files.
Jun 15 2020, 5:53 PM

Jun 11 2020

elvisangelaccio added a comment to D21695: Add FindTaglib.cmake.

New attempt at https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/6

Jun 11 2020, 10:34 PM · Build System, Frameworks

Jun 7 2020

elvisangelaccio accepted D28402: Provide ability to configure size cut-off for local file previews.

@ngraham Does the UI look good? Can we ship this?

Jun 7 2020, 10:59 PM · Dolphin
elvisangelaccio abandoned D27976: WIP: UI for maximumFileSize showing correctly, but not working as expected.

Closing as discussed.

Jun 7 2020, 10:49 PM · Dolphin
elvisangelaccio commandeered D27976: WIP: UI for maximumFileSize showing correctly, but not working as expected.
Jun 7 2020, 10:48 PM · Dolphin
elvisangelaccio added a comment to D27523: [Moved to invent.kde.org]Add an option to use a KUrlNavigator on the toolbar instead.

Sorry for the delay :(

Jun 7 2020, 10:23 PM · Dolphin
elvisangelaccio accepted D29525: Make Previews devicePixelRatio aware.
Jun 7 2020, 10:02 PM · Dolphin
elvisangelaccio accepted D29213: Status bar: Hide the space free bar when size is unknown.
Jun 7 2020, 10:01 PM · Dolphin

May 31 2020

elvisangelaccio committed R318:acad57dc7b10: Port away from QLinkedList (authored by elvisangelaccio).
Port away from QLinkedList
May 31 2020, 9:51 PM
elvisangelaccio committed R318:c16f777b289f: Fix FIFO usage (authored by elvisangelaccio).
Fix FIFO usage
May 31 2020, 9:48 PM
elvisangelaccio committed R318:664f97ff0d1c: [DolphinStatusBar] Fix free space info height with bigger fonts (authored by ahmadsamir).
[DolphinStatusBar] Fix free space info height with bigger fonts
May 31 2020, 9:30 PM
elvisangelaccio committed R449:20f1a4c1ce43: [svn] SVN Log dialog after update to revision action now selects that revision. (authored by nikolaik).
[svn] SVN Log dialog after update to revision action now selects that revision.
May 31 2020, 9:28 PM
elvisangelaccio committed R318:770d083182fd: Prevents warnings (authored by meven).
Prevents warnings
May 31 2020, 9:19 PM
elvisangelaccio added inline comments to D29213: Status bar: Hide the space free bar when size is unknown.
May 31 2020, 9:15 PM · Dolphin
elvisangelaccio committed R449:de4e5c31370b: [svn] Added SVN clean up dialog. (authored by nikolaik).
[svn] Added SVN clean up dialog.
May 31 2020, 9:03 PM

May 29 2020

elvisangelaccio committed R318:b65576a131eb: Port away from deprecated QFontMetrics::width() (authored by elvisangelaccio).
Port away from deprecated QFontMetrics::width()
May 29 2020, 11:24 PM

May 28 2020

elvisangelaccio committed R318:d5563b4b5101: Port away from QLinkedList (authored by elvisangelaccio).
Port away from QLinkedList
May 28 2020, 11:14 PM
elvisangelaccio committed R318:89dfdb5399e6: Port away from deprecated QFontMetrics::width() (authored by elvisangelaccio).
Port away from deprecated QFontMetrics::width()
May 28 2020, 9:12 PM
elvisangelaccio committed R318:380e3e9b5477: Port away from QWheelEvent::orientation() (authored by elvisangelaccio).
Port away from QWheelEvent::orientation()
May 28 2020, 9:11 PM
elvisangelaccio committed R318:0d679da0a378: Port to non-deprecated variant of QPixmapCache::find() (authored by elvisangelaccio).
Port to non-deprecated variant of QPixmapCache::find()
May 28 2020, 9:11 PM
elvisangelaccio committed R318:46c4b902c1cf: Drop incorrect emit keywork (authored by elvisangelaccio).
Drop incorrect emit keywork
May 28 2020, 9:11 PM
elvisangelaccio committed R318:cbb35681f51b: Add some missing const qualifiers (authored by elvisangelaccio).
Add some missing const qualifiers
May 28 2020, 9:11 PM
elvisangelaccio committed R318:c886d3736d35: Fix clazy-range-loop warning (authored by elvisangelaccio).
Fix clazy-range-loop warning
May 28 2020, 9:11 PM
elvisangelaccio committed R318:51441cd3c2f2: Port away from deprecated qrand() (authored by elvisangelaccio).
Port away from deprecated qrand()
May 28 2020, 9:11 PM

May 24 2020

elvisangelaccio added a comment to D29788: [svn] Added basic svn commands logging output..

@elvisangelaccio Can I rename to buttonCancel/buttonOk instead of cancelButton/okButton? If variable name starts with UI element it's easier to use code completion.

May 24 2020, 1:38 PM

May 23 2020

elvisangelaccio committed R318:0d6b900a8433: Revert "GIT_SILENT: we don't use phabricator now" (authored by elvisangelaccio).
Revert "GIT_SILENT: we don't use phabricator now"
May 23 2020, 9:45 PM
elvisangelaccio added a reverting change for R318:eee6b15865c7: GIT_SILENT: we don't use phabricator now: R318:0d6b900a8433: Revert "GIT_SILENT: we don't use phabricator now".
May 23 2020, 9:45 PM
elvisangelaccio accepted D29788: [svn] Added basic svn commands logging output..
May 23 2020, 9:45 PM
elvisangelaccio accepted D29568: use KSycoca for updating OpenPreferredSearchTool action.

Not sure if this should go to release/20.04, but I guess it shouldn't hurt.

May 23 2020, 9:41 PM · Dolphin
elvisangelaccio added inline comments to D29397: KPreviewJob : Support for DeviceRatioPixel.
May 23 2020, 9:30 PM · Frameworks

May 18 2020

elvisangelaccio committed R318:a3052c3942fc: DolphinView: rename new methods to copy/move urls (authored by elvisangelaccio).
DolphinView: rename new methods to copy/move urls
May 18 2020, 10:33 PM

May 17 2020

elvisangelaccio added a comment to D27181: Rename dialog displays also source file information.

Ah right, sorry :P

May 17 2020, 11:16 PM · Ark
elvisangelaccio added a comment to D29562: KDirectoryContentsCounter: Avoid scanning twice the same dir, prioritise path not in cache.

@meven Yes please. The patch may be small, but it's not trivial. Smaller atomic changes are always easier to review.

May 17 2020, 11:14 PM · Dolphin
elvisangelaccio added a comment to D27181: Rename dialog displays also source file information.

That's because the source is still compressed and we can't get a preview out of it.

May 17 2020, 10:39 PM · Ark
elvisangelaccio accepted D29693: Move search and filter bar close buttons to the right.
May 17 2020, 10:03 PM · Dolphin
elvisangelaccio added a comment to D29397: KPreviewJob : Support for DeviceRatioPixel.

Would it make sense to initialize devicePixelRatio to QGuiApplication::devicePixelRatio() and add an API to change it (if desired) ?

May 17 2020, 9:25 PM · Frameworks
elvisangelaccio accepted D29794: Left-elide file/folders while keeping their extension visible.

Very nice. Please push to release/20.04. Thanks!

May 17 2020, 9:10 PM · Dolphin

May 12 2020

elvisangelaccio accepted D29006: Allow to copy or move selection to the other split view.
May 12 2020, 8:05 PM · Documentation, Dolphin

May 11 2020

elvisangelaccio added inline comments to D29006: Allow to copy or move selection to the other split view.
May 11 2020, 11:02 PM · Documentation, Dolphin
elvisangelaccio added a comment to D29213: Status bar: Hide the space free bar when size is unknown.

Sounds to me like we should just hide the widget entirely when there's no size available, or a size calculation doesn't make sense given the context.

May 11 2020, 10:59 PM · Dolphin
elvisangelaccio added a comment to D29562: KDirectoryContentsCounter: Avoid scanning twice the same dir, prioritise path not in cache.

Use QVector instead of QQueue to avoid adding to the queue twice the same dir for subsequent scanning.

Add a priority queue for path that were not already present in cache.

May 11 2020, 9:04 PM · Dolphin
elvisangelaccio committed R318:42148dd3560c: DolphinView: rename cutSelectedItems to cutSelectedItemsToClipboard (authored by elvisangelaccio).
DolphinView: rename cutSelectedItems to cutSelectedItemsToClipboard
May 11 2020, 8:55 PM
elvisangelaccio requested changes to D29488: Added VCS plugins signals connections for outOfVersionControl() actions..
May 11 2020, 8:52 PM · Dolphin
elvisangelaccio accepted D29489: [svn] Added SVN Checkout dialog..
May 11 2020, 8:48 PM