- User Since
- Aug 16 2015, 4:08 PM (191 w, 5 d)
Sun, Apr 14
what does it means? is it done already?
About the UI, I noticed that when the panel is in "configure" mode, it's still possible to right-click it and click the "Configure" entry, which will do nothing.
We could fix this by disabling the entry once clicked. Another idea: make the entry checkable instead of using the buttonbox.
Please bump the minimum required version for KF5BalooWidgets to 19.07.70.
Another thing: can you have a look about these warnings?
This made me think: what about non-plasma systems?
e.g. GNOME doesn't even have a taskbar, what's gonna happen there?
Hmm, it seems you need to rebase this patch:
Sat, Apr 13
Thu, Apr 11
Hmm, I don't I like it sorry. Running clear without the user permission could be annoying or even dangerous.
Sorry for the delay. Let's focus on D16648 please, which has already started its review process.
Please push to master only, just to make sure we don't introduce regressions.
Tue, Apr 9
Mon, Apr 8
Sun, Apr 7
I didn't notice that this patch is also adding click-on-preview to toggle play/pause. To me that is an unrelated feature that should go in another commit (and will probably help you to debug it).
Thanks. Please push to Applications/19.04
We always call KItemListSelectionManager::setCurrentItem() before calling scrollToItem(), so we should probably do it also here.
Let's see what the dolphin philosophy says: https://github.com/KDE/dolphin/blob/master/HACKING.md
Sat, Apr 6
About the UI: I'd also be in favor of not showing the arrows. It's not just Falkon that doesn't show them, but also Firefox and Chrome.
Too late for 19.04 anyway, sorry for the delay :(
Too late for 19.04, please push to master (after replacing BUG: with FEATURE: in the commit message :D)
Is it really necessary to copy urlinfo.h here? Wouldn't be enough to just create a static function and put the URL parsing logic there?
Sun, Mar 31
I cannot open the test file...
Sat, Mar 30
@rthomsen Is it possible to add a small test archive so that we can write an unit test?
Tue, Mar 26
Bonus point if you add a test case in urltest.cpp ;)
Please update the commit message before pushing, it's still referring to PercentFromNestedJob
Don't forget to update the commit message (it still mentions "Add GetProcessList") ;)
Mon, Mar 25
I get a crash if I run dolphin /etc/fstab:
Please push to master only.
Sun, Mar 24
That said, the fix looks correct. An unit test for this crash would be awesome, you have spare time.
Hmm, I can't reproduce the crash following the test plan.
Yes please, this feature really belongs to KUrlNavigator.
- David's suggestion
Generally UI changes shouldn't go to the stable branch, but this can be considered a bugfix, so let's go with 19.04 ;)
If it is possible to somehow force Qt to connect to the signal, then the PercentFromNestedJob is not necessary.
What about the Control menu? Remember that the menubar is hidden by default in dolphin, so the average user probably won't be able to discover this feature.
Also please write a descriptive commit message and use the BUG: keyword. See https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages
Makes sense, thanks for the explanation. Reverted with 3fe6547197.
Please push to the 19.04 branch. Thanks!
Sat, Mar 23
I see. Then I'd exclude #3 for the reason you mentioned. I'd be ok with either #1 or #2, with a slight preference for #2.
Thanks, but there is already a patch for this in D19950. We may want to focus on that one.
I'd also try to avoid copying the code here, is possible.
Mar 20 2019
We are still in time for 19.04 ;)
Haven't tried D19844 yet, but this patch can only make sense.
What if the user press Cancel instead of closing the window?