LGTM now.

I don't know if there should be a word wrap, text stretches the layout (and provider buttons) considerably. It can be scrolled as is, but still…

In D3977#155762, @kossebau wrote:

On a quick look the automatic unregistering based on the finished signal seems to make sense for any KJob subclass. Perhaps the change in this commit conflicts with some older code in Ark to work around the old behaviour and which does some additional manual unregistration? Or perhaps some slot in accidentally invoked 2x so the unregistration happens more than once, with the second try than failing? Wild guesses is all I have to offer, sorry. I cannot remember anything questionable about this patch, so no pointers into it, instead my initial reaction would be to look at the consumer side.

If the main/classic method of copying doesn't work well with many files, imho we should find a way to fix that. So that the use case would be ok for everyone, not just those who have the menubar visible or know the CTRL+D shortcut.

@ngraham This patch is for knewstuff :)

m_twoClicksRenamingTimer(new QTimer(this))

@kossebau
After this change we get the

In D7647#155581, @rkflx wrote:

I likely wanted to just give focus back to Dolphin, rather than start a renaming operation.

On the other hand, executing actions when giving focus is already happening today, e.g. activating Dolphin by clicking on a folder will enter this folder. Shouldn't we rather be consistent here?

Thanks for this patch, but I don't think we should add another action for something that can be already accomplished in two different ways (copy/paste, CTRL+drop).

I do have another comment: if Dolphin loses focus the two clicks renaming should be aborted:

I guess +1 from me. Infopanel and tooltips are disabled by default anyway, so it's not a big deal if we also show the mtime there.

Ping? I'll push in a week unless there are objections.

I wonder how it would look with KMessageWidgets rather than QLabels. Could you try this change and attach another screenshot?

+1 for the one with the clipboard, I like it.

• Switched from user-trash to trash-empty (discussed with @andreaska in person).

There is a patch for the grouping in D8243

I had tested the patch and it was fixing the bug.
I'm fine with this as long as @gregormi volunteers to maintain this code updated (and eventually to switch to a better design, if possible).

Can you attach one or more screenshots that show the changes in the UI? Thanks!

In D8142#152539, @dhaumann wrote:

Does the file template plugin still exist? If so, did you test this?

In D8119#151982, @ngraham wrote:

Well as long as one of them gets in, I'm happy! :) I slightly prefer my patch since I think the more natural place for Folders is closer to the beginning than the end, but I won't block anything on that.

There is already: https://git.reviewboard.kde.org/r/130159/

Thanks for the updated diff, please fix the inline issues.

@ngraham needs some more work, marking it as such.

Ping?

In D7996#149307, @elvisangelaccio wrote:

The weird thing is that I can't find the change with git blame. Shouldn't we just restore the old implementation?

In D7996#149273, @aacid wrote:

Whoever decided to change from iconName to fullpath deserves some punishment for having a class constructor that has exactly signature but behaves totally different.

every single instance is broken
https://lxr.kde.org/source/frameworks/kpeople/src/widgets/mergedialog.cpp#0082
https://lxr.kde.org/source/frameworks/knewstuff/src/uploaddialog.cpp#0147
https://lxr.kde.org/source/calligra/krita/libs/ui/widgets/kis_cie_tongue_widget.cpp#0162
https://lxr.kde.org/source/extragear/base/nepomuk-webminer/src/lib/ui/fetcherdialog.cpp#0140

meh, i'll forget this to make my life better.

Ping?

In D7944#148134, @ngraham wrote:

You're right that this improves one workflow and impairs another, but the way I see it, the patch simply brings consistency with the behavior you get if you hit ctrl-L/Replace Location.

The linked bug looks wrong.

Yeah I also find weird to see weblinks in there. Maybe if we call it "History" would be a bit better (and it would also match the History tab in Kickoff).

I'm not sure if it's a good idea to fork QColumnView in KIO. Is it not possible to contribute the changes upstream?

In D7914#147512, @emmanuelp wrote:

A better fix is https://git.reviewboard.kde.org/r/123253/

In D6312#146807, @emateli wrote:

@elvisangelaccio: So I was thinking of using KIO::FileUndoManager::undoJobFinished but it unfortunately provides no details as to what job was undone.
A possible option would be to keep the last job recorded so we have the name that the undo-ed item will have after reverting, but this is just hacky and doesn't support more than 1 action. I think best would be if job information was passed from KIO::FileUndoManager and then Dolphin could leverage it. I also tried to use selectionManager but to no avail.

I'm not sure I agree with this patch.
A standard behavior in other filemanagers when umounting a device is to redirect to the view from the device URL to the home URL.
So imho this patch is using the wrong approach: instead of the mainwindow telling the terminal panel to go to the home, it should be the mainwindow the one that changes its URL to the home.

@alexeymin Yep, definitely. Thanks for the reminder!