I'd be ok with the proposed behavior.

Unfortunately it's still crashing for me, even with this patch.

Note that mkdir also doesn't warn if the folder already exists. I guess KNewFileMenu was designed to behave accordingly.

In D10742#377356, @jtamate wrote:

Let's see if this assert/crash can be avoided without reverting all the patch. Any help is welcome.

Already fixed by c08ee4577168070896a4a46220cd39df4e4e32cf

There is already a fix in D17348

And yes, this happens only in master, not 18.12

Ops, I just submitted D17363, but this fix is indeed better.

Can you please push it to the stable branch? (Applications/18.12)

Finally had the time to look at this diff.

In D16980#361984, @ngraham wrote:

Ctrl+L already does multiple things depending on the context:

1. URL navigator is a breadcrumb bar: Ctrl+L makes it editable, focuses it, and selects everything
2. URL Navigator is editable but unfocused: Ctrl+L makes it focused and selects everything
3. URL Navigator is editable and focused, but not everything is selected: Ctrl+L selects everything
4. URL Navigator is editable and focused and everything is already selected: Ctrl+L does nothing
   
   This patch currently changes 3 and 4 to be "Ctrl+L turns it back into a breadcrumb bar and returns focus to the main view". Perhaps I could tweak the patch so that this only happens for case #4, for which hitting Ctrl+L currently has no effect. Thoughts?

We need to update kfileplacesmodeltest (as well as placesitemmodeltest in dolphin).

I think we can land this on the stable branch too (Applications/18.12).

Superseded by T10131.

I don't have an opinion about the new shortcut, I'll leave that to the VDG team.

@thsurrel Don't forget to abandond this diff :)

We could have used KUrlNavigator::mouseReleaseEvent() where we already have the same check, but this is also fine.

Sorry for taking so long.

Looks good beside the inline issue (hence why my Request Changes).

Thanks, patch looks good and kitemlistselectionmanagertest still passes.

Shouldn't the plugin check whether the file is writable? I don't think we can add tags to root-owned files, do we?

Before:

This provides a slightly easier way to make the location bar return to breadcrumbs mode

I vote to not make it an option. There is always time to reconsider if enough people complain about the new behavior :)

The patch looks fine and works for me: the upatched test fails, the patched one passes.

In D16824#359159, @ngraham wrote:

FIXED-IN: 19.03.80

Shouldn't that be 19.04.0? It doesn't matter that it will be in a future beta release; that's implied.

• Properly pass places' labels to the dialog

This should have been pushed on master, Applications/18.12 is feature frozen since 15th November.
Given that we are only two days late, I think we can ask for an exception, but next time please be careful.

@acrouthamel Please open another diff with your patch thats updates the dolphin test, so I can try easily try it out

Thanks, this fixes the bug for me.

Thanks

ONE PROBLEM HERE: Can not get a count of hidden Items on start up. the count for hidden items is always 0. So the Menu entry always starts enabled. Any help here would be great.

+1, looks good to me now.