elvisangelaccio (Elvis Angelaccio)
Developer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Aug 16 2015, 4:08 PM (256 w, 2 d)
Availability
Available

Recent Activity

Sun, Jul 12

elvisangelaccio accepted D29178: [dolphin] : Mac integration.

Feel free to ship it.

Sun, Jul 12, 10:48 PM · Dolphin
elvisangelaccio added a comment to D23168: Use embedded cover in MP4 video files.

You uploaded a wrong version of the patch. Please do a git rebase master and make sure you only have one commit on top of origin/master.

Sun, Jul 12, 10:07 PM

Sun, Jul 5

elvisangelaccio added a comment to D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.
In D21312#675714, @Zren wrote:

I have created a Merge Request on GitLab with a a couple new commits.

https://invent.kde.org/system/dolphin/-/merge_requests/31

  • It will only show on devices. It no longer show under mounted folders like Root in the user's favorite places.
  • Adurol on Freenode pointed out that the KIO FilePicker now uses KIO::FileSystemFreeSpaceJob, so I've refactored the patch to use that API.
Sun, Jul 5, 5:05 PM · Dolphin
elvisangelaccio requested changes to D27710: Remove unused FindIntlTool.

What about 1a98206873d77310a161e2ff7f39afe1060484a0 ? Is it not needed anymore?

Sun, Jul 5, 4:36 PM
elvisangelaccio added a comment to D29178: [dolphin] : Mac integration.

@feverfew Does it look good now for you?

Sun, Jul 5, 4:32 PM · Dolphin
elvisangelaccio abandoned D29419: Improved Touch support.

Superseded by https://invent.kde.org/system/dolphin/-/merge_requests/7

Sun, Jul 5, 4:28 PM · Dolphin
elvisangelaccio commandeered D29419: Improved Touch support.
Sun, Jul 5, 4:28 PM · Dolphin
elvisangelaccio abandoned D12162: Add support for touch scrolling in Dolphin.

Superseded by https://invent.kde.org/system/dolphin/-/merge_requests/7

Sun, Jul 5, 4:28 PM · Dolphin
elvisangelaccio commandeered D12162: Add support for touch scrolling in Dolphin.
Sun, Jul 5, 4:27 PM · Dolphin
elvisangelaccio requested changes to D23168: Use embedded cover in MP4 video files.
Sun, Jul 5, 4:26 PM

Sun, Jun 21

elvisangelaccio requested changes to D23168: Use embedded cover in MP4 video files.

Please either copy the FindTaglib.cmake from ECM master or require KF5 >= 5.72 and don't copy FindTaglib.cmake here.

Sun, Jun 21, 9:27 PM
elvisangelaccio abandoned D21695: Add FindTaglib.cmake.
Sun, Jun 21, 9:17 PM · Build System, Frameworks
elvisangelaccio commandeered D21695: Add FindTaglib.cmake.
Sun, Jun 21, 9:17 PM · Build System, Frameworks

Mon, Jun 15

elvisangelaccio added inline comments to D23168: Use embedded cover in MP4 video files.
Mon, Jun 15, 5:53 PM

Jun 11 2020

elvisangelaccio added a comment to D21695: Add FindTaglib.cmake.

New attempt at https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/6

Jun 11 2020, 10:34 PM · Build System, Frameworks

Jun 7 2020

elvisangelaccio accepted D28402: Provide ability to configure size cut-off for local file previews.

@ngraham Does the UI look good? Can we ship this?

Jun 7 2020, 10:59 PM · Dolphin
elvisangelaccio abandoned D27976: WIP: UI for maximumFileSize showing correctly, but not working as expected.

Closing as discussed.

Jun 7 2020, 10:49 PM · Dolphin
elvisangelaccio commandeered D27976: WIP: UI for maximumFileSize showing correctly, but not working as expected.
Jun 7 2020, 10:48 PM · Dolphin
elvisangelaccio added a comment to D27523: [Moved to invent.kde.org]Add an option to use a KUrlNavigator on the toolbar instead.

Sorry for the delay :(

Jun 7 2020, 10:23 PM · Dolphin
elvisangelaccio accepted D29525: Make Previews devicePixelRatio aware.
Jun 7 2020, 10:02 PM · Dolphin
elvisangelaccio accepted D29213: Status bar: Hide the space free bar when size is unknown.
Jun 7 2020, 10:01 PM · Dolphin

May 31 2020

elvisangelaccio committed R318:acad57dc7b10: Port away from QLinkedList (authored by elvisangelaccio).
Port away from QLinkedList
May 31 2020, 9:51 PM
elvisangelaccio committed R318:c16f777b289f: Fix FIFO usage (authored by elvisangelaccio).
Fix FIFO usage
May 31 2020, 9:48 PM
elvisangelaccio committed R318:664f97ff0d1c: [DolphinStatusBar] Fix free space info height with bigger fonts (authored by ahmadsamir).
[DolphinStatusBar] Fix free space info height with bigger fonts
May 31 2020, 9:30 PM
elvisangelaccio committed R449:20f1a4c1ce43: [svn] SVN Log dialog after update to revision action now selects that revision. (authored by nikolaik).
[svn] SVN Log dialog after update to revision action now selects that revision.
May 31 2020, 9:28 PM
elvisangelaccio committed R318:770d083182fd: Prevents warnings (authored by meven).
Prevents warnings
May 31 2020, 9:19 PM
elvisangelaccio added inline comments to D29213: Status bar: Hide the space free bar when size is unknown.
May 31 2020, 9:15 PM · Dolphin
elvisangelaccio committed R449:de4e5c31370b: [svn] Added SVN clean up dialog. (authored by nikolaik).
[svn] Added SVN clean up dialog.
May 31 2020, 9:03 PM

May 29 2020

elvisangelaccio committed R318:b65576a131eb: Port away from deprecated QFontMetrics::width() (authored by elvisangelaccio).
Port away from deprecated QFontMetrics::width()
May 29 2020, 11:24 PM

May 28 2020

elvisangelaccio committed R318:d5563b4b5101: Port away from QLinkedList (authored by elvisangelaccio).
Port away from QLinkedList
May 28 2020, 11:14 PM
elvisangelaccio committed R318:89dfdb5399e6: Port away from deprecated QFontMetrics::width() (authored by elvisangelaccio).
Port away from deprecated QFontMetrics::width()
May 28 2020, 9:12 PM
elvisangelaccio committed R318:380e3e9b5477: Port away from QWheelEvent::orientation() (authored by elvisangelaccio).
Port away from QWheelEvent::orientation()
May 28 2020, 9:11 PM
elvisangelaccio committed R318:0d679da0a378: Port to non-deprecated variant of QPixmapCache::find() (authored by elvisangelaccio).
Port to non-deprecated variant of QPixmapCache::find()
May 28 2020, 9:11 PM
elvisangelaccio committed R318:46c4b902c1cf: Drop incorrect emit keywork (authored by elvisangelaccio).
Drop incorrect emit keywork
May 28 2020, 9:11 PM
elvisangelaccio committed R318:cbb35681f51b: Add some missing const qualifiers (authored by elvisangelaccio).
Add some missing const qualifiers
May 28 2020, 9:11 PM
elvisangelaccio committed R318:c886d3736d35: Fix clazy-range-loop warning (authored by elvisangelaccio).
Fix clazy-range-loop warning
May 28 2020, 9:11 PM
elvisangelaccio committed R318:51441cd3c2f2: Port away from deprecated qrand() (authored by elvisangelaccio).
Port away from deprecated qrand()
May 28 2020, 9:11 PM

May 24 2020

elvisangelaccio added a comment to D29788: [svn] Added basic svn commands logging output..

@elvisangelaccio Can I rename to buttonCancel/buttonOk instead of cancelButton/okButton? If variable name starts with UI element it's easier to use code completion.

May 24 2020, 1:38 PM

May 23 2020

elvisangelaccio committed R318:0d6b900a8433: Revert "GIT_SILENT: we don't use phabricator now" (authored by elvisangelaccio).
Revert "GIT_SILENT: we don't use phabricator now"
May 23 2020, 9:45 PM
elvisangelaccio added a reverting change for R318:eee6b15865c7: GIT_SILENT: we don't use phabricator now: R318:0d6b900a8433: Revert "GIT_SILENT: we don't use phabricator now".
May 23 2020, 9:45 PM
elvisangelaccio accepted D29788: [svn] Added basic svn commands logging output..
May 23 2020, 9:45 PM
elvisangelaccio accepted D29568: use KSycoca for updating OpenPreferredSearchTool action.

Not sure if this should go to release/20.04, but I guess it shouldn't hurt.

May 23 2020, 9:41 PM · Dolphin
elvisangelaccio added inline comments to D29397: KPreviewJob : Support for DeviceRatioPixel.
May 23 2020, 9:30 PM · Frameworks

May 18 2020

elvisangelaccio committed R318:a3052c3942fc: DolphinView: rename new methods to copy/move urls (authored by elvisangelaccio).
DolphinView: rename new methods to copy/move urls
May 18 2020, 10:33 PM

May 17 2020

elvisangelaccio added a comment to D27181: Rename dialog displays also source file information.

Ah right, sorry :P

May 17 2020, 11:16 PM · Ark
elvisangelaccio added a comment to D29562: KDirectoryContentsCounter: Avoid scanning twice the same dir, prioritise path not in cache.

@meven Yes please. The patch may be small, but it's not trivial. Smaller atomic changes are always easier to review.

May 17 2020, 11:14 PM · Dolphin
elvisangelaccio added a comment to D27181: Rename dialog displays also source file information.

That's because the source is still compressed and we can't get a preview out of it.

May 17 2020, 10:39 PM · Ark
elvisangelaccio accepted D29693: Move search and filter bar close buttons to the right.
May 17 2020, 10:03 PM · Dolphin
elvisangelaccio added a comment to D29397: KPreviewJob : Support for DeviceRatioPixel.

Would it make sense to initialize devicePixelRatio to QGuiApplication::devicePixelRatio() and add an API to change it (if desired) ?

May 17 2020, 9:25 PM · Frameworks
elvisangelaccio accepted D29794: Left-elide file/folders while keeping their extension visible.

Very nice. Please push to release/20.04. Thanks!

May 17 2020, 9:10 PM · Dolphin

May 12 2020

elvisangelaccio accepted D29006: Allow to copy or move selection to the other split view.
May 12 2020, 8:05 PM · Documentation, Dolphin

May 11 2020

elvisangelaccio added inline comments to D29006: Allow to copy or move selection to the other split view.
May 11 2020, 11:02 PM · Documentation, Dolphin
elvisangelaccio added a comment to D29213: Status bar: Hide the space free bar when size is unknown.

Sounds to me like we should just hide the widget entirely when there's no size available, or a size calculation doesn't make sense given the context.

May 11 2020, 10:59 PM · Dolphin
elvisangelaccio added a comment to D29562: KDirectoryContentsCounter: Avoid scanning twice the same dir, prioritise path not in cache.

Use QVector instead of QQueue to avoid adding to the queue twice the same dir for subsequent scanning.

Add a priority queue for path that were not already present in cache.

May 11 2020, 9:04 PM · Dolphin
elvisangelaccio committed R318:42148dd3560c: DolphinView: rename cutSelectedItems to cutSelectedItemsToClipboard (authored by elvisangelaccio).
DolphinView: rename cutSelectedItems to cutSelectedItemsToClipboard
May 11 2020, 8:55 PM
elvisangelaccio requested changes to D29488: Added VCS plugins signals connections for outOfVersionControl() actions..
May 11 2020, 8:52 PM · Dolphin
elvisangelaccio accepted D29489: [svn] Added SVN Checkout dialog..
May 11 2020, 8:48 PM
elvisangelaccio added inline comments to R318:d1a70c0b629b: DolphinView: rename copySelectedItems to copySelectedItemsToClipboard.
May 11 2020, 8:42 PM
elvisangelaccio accepted D29560: Dolphin: Cleanup service settings page.
May 11 2020, 5:57 PM · Dolphin
elvisangelaccio accepted D27181: Rename dialog displays also source file information.
May 11 2020, 5:57 PM · Ark
elvisangelaccio requested changes to D29560: Dolphin: Cleanup service settings page.
May 11 2020, 5:46 PM · Dolphin
elvisangelaccio accepted D29489: [svn] Added SVN Checkout dialog..
May 11 2020, 5:40 PM
elvisangelaccio added inline comments to D29006: Allow to copy or move selection to the other split view.
May 11 2020, 5:35 PM · Documentation, Dolphin
elvisangelaccio committed R318:d1a70c0b629b: DolphinView: rename copySelectedItems to copySelectedItemsToClipboard (authored by elvisangelaccio).
DolphinView: rename copySelectedItems to copySelectedItemsToClipboard
May 11 2020, 5:33 PM

May 7 2020

elvisangelaccio accepted D29470: Prevent crash in Windows.
May 7 2020, 9:37 PM · Dolphin

May 5 2020

elvisangelaccio accepted D26215: Port QRegExp to QRegularExpression.

Actually *\* currently works and with this patch won't work anymore, but IMHO this should be fixed in Qt.
QRegExp is deprecated anyway and will probably be removed in Qt 6. Let's get rid of it.

May 5 2020, 10:22 PM · Dolphin
elvisangelaccio added inline comments to D22594: [Dolphin] Open Preferred Search Tool action.
May 5 2020, 10:08 PM · Documentation, Dolphin
elvisangelaccio accepted D29441: Don't update preferred search action on window activation.

Yes, please push to 20.04.

May 5 2020, 10:07 PM · Dolphin
elvisangelaccio accepted D29378: Keep name readable on drag to matching background.
May 5 2020, 10:02 PM · Dolphin
elvisangelaccio added a comment to D25335: [Details mode] Allow to fill the column size of directories with actual size.

@meven Can you please also fix these issues?

May 5 2020, 9:47 PM · Dolphin

May 4 2020

elvisangelaccio added a comment to D29425: Fix Windows Build.

Wait, so the new feature does not work on Windows?

May 4 2020, 8:11 PM · Dolphin
elvisangelaccio added a comment to D25335: [Details mode] Allow to fill the column size of directories with actual size.

This also broke the Windows build on the CI:

May 4 2020, 5:17 PM · Dolphin

May 3 2020

elvisangelaccio accepted D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages.

Please fix the last two inline comments and then feel free to ship it.

May 3 2020, 7:33 PM · Dolphin
elvisangelaccio requested changes to D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages.
May 3 2020, 6:20 PM · Dolphin
elvisangelaccio accepted D29089: Dolphin Service Menu Installer: Launch certain scripts in Konsole.
May 3 2020, 5:51 PM · Dolphin
elvisangelaccio accepted D25335: [Details mode] Allow to fill the column size of directories with actual size.

LGTM now. Please improve the commit message and then feel free to ship it.

May 3 2020, 5:49 PM · Dolphin
elvisangelaccio added inline comments to D25335: [Details mode] Allow to fill the column size of directories with actual size.
May 3 2020, 5:44 PM · Dolphin
elvisangelaccio requested changes to D29006: Allow to copy or move selection to the other split view.

The feature looks reasonable to me.

May 3 2020, 5:41 PM · Documentation, Dolphin
elvisangelaccio accepted D29383: libarchive: Improve error-handling when loading archive.
May 3 2020, 5:14 PM · Ark
elvisangelaccio added a comment to D29115: Add option to show hidden files and folders last.

About testing, you need to install the tool ctest then go to build dir and run the whole tests with ctest (it has many options to be more clever for instance ctest -R kfileitemmodeltest

Thank you for the info. I will try to add a test then.

Well for me it is pretty clear that this should be at least an option, if not the default. If you don't work with hidden files visible then this does nothing. But if you do, like myself, which view do you think is more useful/productive

Right, so let's make it the default without adding an option to get a worse behavior ;)

So do you all want me to remove all the clutter code regarding the new setting and just keep the logic as to make it the default and only behavior?
I would rather very much keep the extra option. But it is up to you I guess.

May 3 2020, 5:07 PM · Dolphin
elvisangelaccio committed R318:32308843f96f: ServicesSettingsPage: add missing connection receiver (authored by elvisangelaccio).
ServicesSettingsPage: add missing connection receiver
May 3 2020, 5:06 PM
elvisangelaccio requested changes to D29378: Keep name readable on drag to matching background.

LGTM besides the inline comment.

May 3 2020, 5:00 PM · Dolphin
elvisangelaccio accepted D29345: Fixes Dolphin crash on "Defocus Terminal Panel" menu click if no Konsole is installed..
May 3 2020, 4:01 PM · Dolphin
elvisangelaccio accepted D29197: filenamesearch: Implement stat to display metainfo.
May 3 2020, 3:26 PM · Frameworks, Dolphin
elvisangelaccio added a comment to D26215: Port QRegExp to QRegularExpression.

What about QRegularExpression::wildcardToRegularExpression() ? Could we use that? Note that the filter string comes from user input (i.e. from the filter bar).

I've just tested; it can be used, with the same caveat as the QRegExp docs have about WildcardUnix, a wildcard can't be escaped with a \:
*.txt would show all files with a .txt extension

  • would show all files \* _won't_ show files with a literal "*" in their names

    Looks good enough to me, if you agree I'll update the diff.
May 3 2020, 3:22 PM · Dolphin

Apr 26 2020

elvisangelaccio added a comment to D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages.

Does PackageKit work on Windows/MacOS? I don't think so. We should probably run this code only on Unix, no?

Apr 26 2020, 11:31 PM · Dolphin
elvisangelaccio added a comment to D29115: Add option to show hidden files and folders last.

Well for me it is pretty clear that this should be at least an option, if not the default. If you don't work with hidden files visible then this does nothing. But if you do, like myself, which view do you think is more useful/productive

Right, so let's make it the default without adding an option to get a worse behavior ;)

Apr 26 2020, 11:22 PM · Dolphin
elvisangelaccio added inline comments to D29089: Dolphin Service Menu Installer: Launch certain scripts in Konsole.
Apr 26 2020, 11:15 PM · Dolphin
elvisangelaccio requested changes to D25335: [Details mode] Allow to fill the column size of directories with actual size.

I think we should default to "number of items", because we can't know whether the user runs an SSD or an old HDD. Better safe than sorry.

Apr 26 2020, 11:00 PM · Dolphin
elvisangelaccio added a comment to D29213: Status bar: Hide the space free bar when size is unknown.

What about "Size not available" ? I'm not sure I like the empty space there...

Apr 26 2020, 10:20 PM · Dolphin
elvisangelaccio accepted D29198: filenamesearch:/ define a title for the query.

LGTM but I'd like input from @iasensio too.

Apr 26 2020, 9:58 PM · Dolphin
elvisangelaccio accepted D29194: [dolphin] : prevent QFileInfo warning.
Apr 26 2020, 9:52 PM · Dolphin
elvisangelaccio accepted D29043: Fix 'SVN Log...' crash while watching history in the unversioned directory. Added checks m_log variable contains anything..
Apr 26 2020, 9:44 PM
elvisangelaccio added a comment to D27976: WIP: UI for maximumFileSize showing correctly, but not working as expected.

Hmm, looks like someone else submitted a patch to do this: D28402. Perhaps we should proceed there instead?

Apr 26 2020, 9:41 PM · Dolphin
elvisangelaccio requested changes to D28402: Provide ability to configure size cut-off for local file previews.

Please add a #include <QCheckBox> in previewssettingspage.cpp, otherwise it doesn't build with Qt 5.15.

Apr 26 2020, 9:41 PM · Dolphin
elvisangelaccio added inline comments to D29178: [dolphin] : Mac integration.
Apr 26 2020, 9:14 PM · Dolphin
elvisangelaccio added inline comments to D29178: [dolphin] : Mac integration.
Apr 26 2020, 9:13 PM · Dolphin
elvisangelaccio accepted D29042: Updates in response to KVersionControlPlugin interface changes..
Apr 26 2020, 5:19 PM
elvisangelaccio accepted D29041: For VCS-plugin interface added pure virtual function outOfVersionControlActions().
Apr 26 2020, 5:18 PM · Dolphin
elvisangelaccio accepted D11382: Add an option to show tabs from last time when Dolphin starts.

LGTM now. Ship it! :)

Apr 26 2020, 5:10 PM · Dolphin