- User Since
- Aug 16 2015, 4:08 PM (209 w, 3 d)
Wed, Aug 14
I'll be AFK for a week for vacation. Will do a proper review once I'm back ;)
Wow, this is quite a radical change :)
Tue, Aug 13
Can you try to build another kdeinit app (i.e. khelpcenter) to check if you get the same error?
Btw I think I spotted a regression:
Got the following errore while pushing:
Sun, Aug 11
Please push to master or wait after August 15th (Applications 19.08 Release day) if you need this in the stable branch too.
Wed, Aug 7
Sat, Aug 3
Thanks, LGTM now.
There seems to be another issue: if I run dolphin <some folder> from cmd line I always get Add 'file' to place, no matter what the folder is.
Sun, Jul 28
Reverted this commit and then pushed diff 61904.
Note that the commit message will need BUG: (with the colons) in order to automagically close the bug report.
I'd still like to understand what happend at the change in 4e40fe810d324.
Thanks, going to push to 19.08 :)
Well, I like that we are replacing 20+ lines of code with only one ;)
Code looks good, but I spotted a regression: 'Add to Places' is now disabled if you don't select any folder. Currently it is possible to add the current folder as place without the need for any selection.
LGTM. Feel free to push on 19.08.
I like this solution better. I'll push on master only for now, and we'll see if we break something ;)
Jul 21 2019
Can you expland a bit the commit message explaining how does libkgapi use the filename?
Please push to master. Thanks!
I'd go with option 1 ;)
Jul 17 2019
Sorry for the delay. See the inline comment.
Thanks for the patch! The fix looks correct, but I have suggestions for the coding style.
Sorry, I missed this one. I'd say let's postpone to 19.12...
Jul 15 2019
Please use a descriptive commit message: https://community.kde.org/Policies/Commit_Policy#Always_add_descriptive_log_messages
Jul 14 2019
This issue was supposed to be fixed by commit 4e40fe810d324 but it seems it got reintroduced in the past months.
Hmm, this feels like a work-around because we initialize m_active(true) everywhere else (DolphinView, DolphinSearchBox).
Jul 7 2019
Thanks for the patch!
Thanks for the patch!
Jul 3 2019
Jul 1 2019
@barchiesi This commit broke the kio-gdrive build (CanCreateTeamDrives no longer existing).
Jun 30 2019
I guess go for it.
Jun 23 2019
Sorry but there are a lot of trailing whitespace changes (which unfortunately phabricator ignores).