I don't have a touch screen for actual testing, but I'll have a look asap anyway.

What if some day someone changes the Dolphin's ID from <id>org.kde.dolphin.desktop</id> to <id>org.kde.dolphin</id> ?
Will it break this appstream file? (since I'm hardcoding .desktop in the IDs)

• Make it an addon instead

Thanks!

This is a bugfix, it should be pushed to the stable branch (Applications/18.08).

Thanks

In D15278#321028, @elvisangelaccio wrote:

Hmm, I don't know. If the tabbar is not visible, there is no "last tab". Why should the "close tab" action be enabled then?

Browsers are different because they always have the tabbar visible (even if there is only one tab).

Thanks

Awesome job, Andreas <3

Please don't use goto.
Also this will need some i18n fixes to avoid word puzzles, see https://api.kde.org/frameworks/ki18n/html/prg_guide.html#good_text

I don't get it. Ctrl+T works with dolphin from my arch distro package. It doesn't work with my self-compiled dolphin though. What's going on?

Btw we broke the "Create New" button on read-only folders. Time to write an unit test for that...

I'm pretty sure this can be implemented in KFilePlacesModel without the need to duplicate the feature here in dolphin.

In T9795#162803, @nicolasfella wrote:

One thing that strikes me is that a lot of the PlacesItemModel code is just proxying KFilePlacesModel. Another large part of the code seems entirely duplicated. It would make sense to check if we can just use KFilePlacesModel directly in the Places Panel.

Thanks!

@madcatx Time to request commit access? :D

In D15221#321062, @mak wrote:

That is not entirely correct, and I really hope the notion of ".desktop file" will finally die at some point soon... AppStream requires you to set one or multiple component-IDs that the component extends. So, if KIO had a metainfo file, you could extend it by specifying your addon to extend org.kde.kio (or whatever ID it would have).
Apps looking for extensions that know they use KIO can then also look for KIO extensions.
Since very few apps (none?) do that currently and users will want to find your module in software centers easily, I would also make your addon extend org.kde.dolphin (or whatever Dolphin's ID is) as well as Konqueror. That will likely cover 90% of all usecases.

I also think we should use monochrome icons there.

Apparently this also caused https://bugs.kde.org/show_bug.cgi?id=398817

In D7647#328392, @wbauer wrote:

This apparently caused regressions as I noticed:

1.) Long-clicking on a selected file now triggers inline renaming in single-click mode too.
Or was that intentional? The summary states this though:

Please push to the stable branch (1.2). Thanks!

From a quick look, the architecture is sound and respects what was discussed in T9390. And indeed it works pretty well, awesome job @akrutzler!

Looks good otherwise

For the record, I submitted the following two patches:

Looks good except the version bump.

Thanks

Thanks a lot for working on this.

Let's not make this an option, please :/

@broulik Can you please "plan changes" or abandon it then?

+1 for D15507 and D15508

Stable branch, please. Thanks!

Note that kioexecd is slave-agnostic, we shouldn't test only with the samba slave.

Hmm, I don't know. If the tabbar is not visible, there is no "last tab". Why should the "close tab" action be enabled then?

Thanks

In D15221#320487, @ltoscano wrote:

In D15221#320391, @elvisangelaccio wrote:

Yes I was condering that, but the problem is this is an ioslave that almost anyone can use (not just dolphin or plasma).

If anyone (KIO-based) can use it, doesn't it make it an addon?