elvisangelaccio (Elvis Angelaccio)
Developer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Aug 16 2015, 4:08 PM (156 w, 4 d)
Availability
Available

Recent Activity

Yesterday

elvisangelaccio added a comment to D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app.

No need to apologize, that's what code reviews are for :)

Thu, Aug 16, 10:12 PM · Frameworks
elvisangelaccio accepted D14878: Pretty-print "creationtime" role.
Thu, Aug 16, 2:19 PM · Dolphin
elvisangelaccio closed T8160: Enable uninstalled ark build as Invalid.

Not an ark issue. See https://mail.kde.org/pipermail/kde-buildsystem/2018-March/012418.html

Thu, Aug 16, 12:48 PM · Ark
elvisangelaccio added a comment to D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app.

Same, there is only one entry there.

Thu, Aug 16, 12:02 PM · Frameworks
elvisangelaccio added a comment to T9390: Next Gen MTP.

Apparently, I'm working on exactly this approach for the last week. :) I moved all the MTP handling to a KDED module. The KIO slaves then connects to this KDED module via dbus. It will still take some time to be finished but I get pretty promising results so far.
I will be at the Akademy today (16.08.18) at around 5pm, so if you are around we can discuss more on this topic. Sadly am not able to take my laptop with me to show you how it works so far...

Thu, Aug 16, 11:57 AM · Frameworks
elvisangelaccio added a comment to D13813: Make this test work again with new uds implementation.

Authored by a Bot?

Somehow my name and email address in .gitconfig got changed. How? No idea.
Should revert and push again with the right name?

Thu, Aug 16, 11:44 AM · Dolphin
elvisangelaccio updated subscribers of D13813: Make this test work again with new uds implementation.

Authored by a Bot?

Thu, Aug 16, 11:42 AM · Dolphin
vandenoever awarded T9390: Next Gen MTP a Like token.
Thu, Aug 16, 10:56 AM · Frameworks
elvisangelaccio accepted D13813: Make this test work again with new uds implementation.

Right. Then let's ship it as is for now, thanks!

Thu, Aug 16, 10:33 AM · Dolphin
elvisangelaccio added a comment to D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app.

I cannot reproduce the linked bug. If open the same file in both kate and kwrite I get only one entry in krunner (despite the file having two different X-KDE-LastOpenedWith values in .local/share/RecentDocuments/).

Thu, Aug 16, 10:25 AM · Frameworks
elvisangelaccio committed R320:6010d09233e5: Avoid a kio-mtp crash when trying to add a blocked device to the device cache (authored by jtamate).
Avoid a kio-mtp crash when trying to add a blocked device to the device cache
Thu, Aug 16, 9:02 AM

Wed, Aug 15

elvisangelaccio added a comment to D13813: Make this test work again with new uds implementation.

@jtamate Any updates on this? Can you use the new fastInsert() calls here?

Wed, Aug 15, 8:59 AM · Dolphin
elvisangelaccio triaged T9390: Next Gen MTP as High priority.
Wed, Aug 15, 8:49 AM · Frameworks

Tue, Aug 14

elvisangelaccio accepted D14844: [CompressFileItemAction] Don't offer for non-local URLs.

Actually, the list is already const, so this is fine as is.

Tue, Aug 14, 9:16 PM · Ark
elvisangelaccio requested changes to D14844: [CompressFileItemAction] Don't offer for non-local URLs.

Looks good otherwise.

Tue, Aug 14, 9:11 PM · Ark
elvisangelaccio committed R449:466234d17ac4: Fix clazy-connect-not-normalized warnings (authored by elvisangelaccio).
Fix clazy-connect-not-normalized warnings
Tue, Aug 14, 1:37 PM
elvisangelaccio committed R449:0d5ba4ef7911: Fix syntax error (authored by elvisangelaccio).
Fix syntax error
Tue, Aug 14, 1:37 PM
elvisangelaccio committed R449:295678bab771: Port away from deprecated QProcess:error signal (authored by elvisangelaccio).
Port away from deprecated QProcess:error signal
Tue, Aug 14, 1:37 PM
elvisangelaccio committed R449:70c2f816e6a9: Use same minimum Qt version as dolphin (authored by elvisangelaccio).
Use same minimum Qt version as dolphin
Tue, Aug 14, 1:37 PM
elvisangelaccio committed R449:aa7543eadeb1: Use minimum KF5 version also for ECM (authored by elvisangelaccio).
Use minimum KF5 version also for ECM
Tue, Aug 14, 1:37 PM
elvisangelaccio committed R449:e9baa21ec55b: Fix const-signal-or-slot warnings in bazaar plugin (authored by elvisangelaccio).
Fix const-signal-or-slot warnings in bazaar plugin
Tue, Aug 14, 1:37 PM

Mon, Aug 13

elvisangelaccio requested review of D14814: Port away from kdelibs4support.
Mon, Aug 13, 10:21 PM · Dolphin
elvisangelaccio added a revision to T8720: Get rid of kdelibs4support in dolphin: D14814: Port away from kdelibs4support.
Mon, Aug 13, 10:21 PM · Dolphin
elvisangelaccio committed R449:7ce880096a96: Drop deprecated toAscii() method (authored by elvisangelaccio).
Drop deprecated toAscii() method
Mon, Aug 13, 8:43 PM
elvisangelaccio committed R449:7409605149bd: Fix mistakes from commit dd7c13a490 (authored by elvisangelaccio).
Fix mistakes from commit dd7c13a490
Mon, Aug 13, 8:43 PM
elvisangelaccio committed R449:6c8cfb363006: Add dependency on KTextWidgets (authored by elvisangelaccio).
Add dependency on KTextWidgets
Mon, Aug 13, 8:43 PM
elvisangelaccio committed R449:4dc1f6004b86: Port away remaining KLocale includes (authored by elvisangelaccio).
Port away remaining KLocale includes
Mon, Aug 13, 8:43 PM
elvisangelaccio committed R449:5b97d038862c: Link to KF5::KIOFileWidgets (authored by elvisangelaccio).
Link to KF5::KIOFileWidgets
Mon, Aug 13, 8:43 PM
elvisangelaccio committed R449:b694592d5f5f: Port away from KLineEdit (authored by elvisangelaccio).
Port away from KLineEdit
Mon, Aug 13, 8:43 PM
elvisangelaccio committed R449:739e4323049a: Drop last remaining KUrl include (authored by elvisangelaccio).
Drop last remaining KUrl include
Mon, Aug 13, 8:43 PM
elvisangelaccio committed R449:ec89488c59b5: Define QT_NO_URL_CAST_FROM_STRING in the top-level CMakeLists.txt (authored by elvisangelaccio).
Define QT_NO_URL_CAST_FROM_STRING in the top-level CMakeLists.txt
Mon, Aug 13, 8:43 PM
elvisangelaccio committed R449:2ddd42b6a392: Port non-editable KComboBoxes to QComboBox (authored by elvisangelaccio).
Port non-editable KComboBoxes to QComboBox
Mon, Aug 13, 8:43 PM
elvisangelaccio committed R449:dd7c13a490cb: Port away from KDialog (authored by elvisangelaccio).
Port away from KDialog
Mon, Aug 13, 8:43 PM
elvisangelaccio committed R449:e21105a5d542: Start porting away from kdelibs4support (authored by elvisangelaccio).
Start porting away from kdelibs4support
Mon, Aug 13, 8:43 PM
elvisangelaccio committed R449:d89cbe1d4aa0: Drop unused KComboBox includes and forward declarations (authored by elvisangelaccio).
Drop unused KComboBox includes and forward declarations
Mon, Aug 13, 1:58 PM
elvisangelaccio committed R449:db88d426e909: Fix automoc warnings about unnecessary moc includes (authored by elvisangelaccio).
Fix automoc warnings about unnecessary moc includes
Mon, Aug 13, 1:20 PM

Sat, Aug 11

elvisangelaccio added a comment to D14442: Unify window and tab title.

Please try to write unit test, if you can (have a look at dolphinmainwindowtest.cpp). That's the only way to make sure we don't break anything :)

Sat, Aug 11, 4:49 PM · Dolphin

Tue, Aug 7

elvisangelaccio accepted D14510: Add --mimetypes command line option.
Tue, Aug 7, 8:57 PM · Ark
elvisangelaccio accepted D14641: Refine wording when a folder with an invalid name could not be created.
Tue, Aug 7, 8:46 PM · Frameworks

Sat, Aug 4

elvisangelaccio requested changes to D14510: Add --mimetypes command line option.

Thanks for the patch. Just a couple of small nitpicks, looks good otherwise.

Sat, Aug 4, 3:36 PM · Ark
elvisangelaccio committed R236:e8519d6af2ad: Add workaround for labels with word-wrapping (authored by elvisangelaccio).
Add workaround for labels with word-wrapping
Sat, Aug 4, 3:07 PM
elvisangelaccio closed D13570: Add workaround for labels with word-wrapping.
Sat, Aug 4, 3:07 PM · Frameworks
elvisangelaccio accepted D14378: Remove custom icon selection for trash.

@pino does it look good to you now?

Sat, Aug 4, 2:15 PM · Dolphin

Tue, Jul 31

elvisangelaccio requested changes to D14443: Use nullptr.

Just out of curiosity, what is the motivation for this change? What do we gain by assigning pointers to nullptr? Would it instead make sense to use a smart pointer? Maybe unique_ptr or a Qt version?

Tue, Jul 31, 9:13 PM · Dolphin

Sun, Jul 29

elvisangelaccio committed R318:9be80423dcc9: Drop redundant setAttribute for WA_DeleteOnClose (authored by elvisangelaccio).
Drop redundant setAttribute for WA_DeleteOnClose
Sun, Jul 29, 10:02 PM
elvisangelaccio committed R241:54298c16f37a: Present error dialog when user tries to create directory named "." or ".." (authored by tmarshall).
Present error dialog when user tries to create directory named "." or ".."
Sun, Jul 29, 7:18 PM
elvisangelaccio closed D13805: Present error dialog when user tries to create directory named "." or "..".
Sun, Jul 29, 7:18 PM · Dolphin, Frameworks
elvisangelaccio added a comment to D14453: Fixes memory leak of KItemListHeader.

But why doesn't the KItemListView have a parent? Who deletes listView then?

Sun, Jul 29, 6:35 PM · Dolphin
elvisangelaccio requested changes to D14452: Fixes memory leak of DolphinMainWindow.

QPointer is not a smart pointer and doesn't handle memory. But we don't need it anyway, because we have the Qt::WA_DeleteOnClose attribute set which does the cleanup.

Sun, Jul 29, 6:31 PM · Dolphin

Sat, Jul 28

elvisangelaccio requested changes to D14378: Remove custom icon selection for trash.

This will crash as soon as you try to edit the Trash place (because m_iconButton in PlacesItemEditDialog::icon() won't be initialized).

Sat, Jul 28, 3:53 PM · Dolphin
elvisangelaccio added a comment to D13805: Present error dialog when user tries to create directory named "." or "..".

@tmarshall Do you have commit access?

Sat, Jul 28, 3:37 PM · Dolphin, Frameworks
elvisangelaccio accepted D13805: Present error dialog when user tries to create directory named "." or "..".
Sat, Jul 28, 3:37 PM · Dolphin, Frameworks
elvisangelaccio added a comment to D14290: [KWidgetJobTracker] Show "Open Destination" etc buttons only if destination is valid.

+1

Sat, Jul 28, 3:27 PM · Frameworks

Sun, Jul 22

elvisangelaccio committed R36:7aa10cfcccaf: Merge branch 'Applications/18.08' (authored by elvisangelaccio).
Merge branch 'Applications/18.08'
Sun, Jul 22, 9:11 PM
elvisangelaccio committed R36:31b5501b02b1: Don't show comment message widget after clearing the comment view (authored by elvisangelaccio).
Don't show comment message widget after clearing the comment view
Sun, Jul 22, 9:07 PM
elvisangelaccio committed R36:cfee2c4483fc: libzip: use ZIP_FL_ENC_RAW for comments (authored by elvisangelaccio).
libzip: use ZIP_FL_ENC_RAW for comments
Sun, Jul 22, 9:07 PM

Sat, Jul 21

elvisangelaccio added a comment to D14199: Simplify the context menu handling functions in FoldersPanel.

The old code was like that for a reason: https://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0

Now, the chance this change will lead to a crash is very low, but still I don't see what we gain either.

After reading the blog post and looking at the Qt documentation, I think you are absolutely right about this. The TreeViewContextMenu::open function ends up calling QMenu::exec which runs synchronously meaning that the application can close while processing events, what I do not understand about the original code is what good does the

if (contextMenu.data())

do? The whole point of QPointer is to provide memory management of QObjects, also in the case where the managed object is deleted elsewhere, therefore I can't see that it is needed.

Sat, Jul 21, 5:27 PM · Dolphin
elvisangelaccio accepted D14158: Avoid a kio-mtp crash when trying to add a blocked device to the device cache.
Sat, Jul 21, 9:24 AM
elvisangelaccio accepted D14259: Honor BUILD_TESTING.
Sat, Jul 21, 8:30 AM · Baloo
elvisangelaccio committed R824:df6b179ce818: Merge branch 'Applications/18.08' (authored by elvisangelaccio).
Merge branch 'Applications/18.08'
Sat, Jul 21, 8:29 AM
elvisangelaccio committed R824:3b1f3a206e65: Fix unnecessary soversion change (authored by elvisangelaccio).
Fix unnecessary soversion change
Sat, Jul 21, 8:28 AM
elvisangelaccio closed D14258: Fix unnecessary soversion change.
Sat, Jul 21, 8:28 AM · Baloo
elvisangelaccio requested review of D14258: Fix unnecessary soversion change.
Sat, Jul 21, 8:10 AM · Baloo

Wed, Jul 18

elvisangelaccio committed R318:e6bf758406f6: Merge branch 'Applications/18.08' (authored by elvisangelaccio).
Merge branch 'Applications/18.08'
Wed, Jul 18, 9:23 PM
elvisangelaccio committed R318:4536e25ac929: Fixes memory leak in KItemListViewAccessible (authored by hallas).
Fixes memory leak in KItemListViewAccessible
Wed, Jul 18, 9:23 PM
elvisangelaccio closed D14168: Fixes memory leak in KItemListViewAccessible.
Wed, Jul 18, 9:23 PM · Dolphin
elvisangelaccio committed R318:43ab5bdc5f8b: Removes unused member variables (authored by hallas).
Removes unused member variables
Wed, Jul 18, 9:23 PM
elvisangelaccio closed D14180: Removes unused member variables.
Wed, Jul 18, 9:23 PM · Dolphin
elvisangelaccio requested changes to D14199: Simplify the context menu handling functions in FoldersPanel.

The old code was like that for a reason: https://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0

Wed, Jul 18, 9:11 PM · Dolphin

Jul 17 2018

elvisangelaccio accepted D14178: Fixes small memory leak in DolphinContextMenu.
Jul 17 2018, 8:55 PM · Dolphin
elvisangelaccio accepted D14180: Removes unused member variables.
Jul 17 2018, 8:54 PM · Dolphin
elvisangelaccio accepted D14168: Fixes memory leak in KItemListViewAccessible.

@hallas Thanks. Do you have commit access?

Jul 17 2018, 8:53 PM · Dolphin
elvisangelaccio committed R36:16bb5d8acb30: clizip: fix list after adding files to encrypted archive (authored by elvisangelaccio).
clizip: fix list after adding files to encrypted archive
Jul 17 2018, 8:53 PM
elvisangelaccio committed R36:20c6faa54cc8: Stop ignoring compression options when dropping files (authored by elvisangelaccio).
Stop ignoring compression options when dropping files
Jul 17 2018, 8:53 PM
elvisangelaccio triaged T9213: LoadTest: check also the number of entries as Normal priority.
Jul 17 2018, 8:04 PM · Ark
elvisangelaccio triaged T9212: Run each test for every available plugin as High priority.
Jul 17 2018, 8:03 PM · Ark

Jul 16 2018

elvisangelaccio added a comment to T4010: CompressionOptions ignored when copy/moving/updating files.

Currently we set the compression options only when adding new files

Jul 16 2018, 9:13 PM · Ark

Jul 14 2018

elvisangelaccio accepted D13768: Modernize View Properties window.
Jul 14 2018, 7:31 PM · Dolphin

Jul 12 2018

elvisangelaccio updated the diff for D13570: Add workaround for labels with word-wrapping.
  • Added bug report
Jul 12 2018, 8:43 PM · Frameworks
elvisangelaccio updated the summary of D13570: Add workaround for labels with word-wrapping.
Jul 12 2018, 8:40 PM · Frameworks

Jul 10 2018

elvisangelaccio accepted D13814: Speedup sort.

Thanks for filing the upstream bug. Looks good to me now.

Jul 10 2018, 8:25 PM · Dolphin

Jul 8 2018

elvisangelaccio planned changes to D13570: Add workaround for labels with word-wrapping.

There is no bugreport, I'll have to file one.

Jul 8 2018, 9:13 PM · Frameworks
elvisangelaccio requested changes to D13814: Speedup sort.
Jul 8 2018, 5:17 PM · Dolphin
elvisangelaccio reopened D13814: Speedup sort.
Jul 8 2018, 5:16 PM · Dolphin
elvisangelaccio added a comment to D13814: Speedup sort.

Hmm, so the crash is in ucol_close() (aka in ICU) and we are working around it by forcing the cleanup in the KFileItemModel ctor (= single thread).

Jul 8 2018, 5:16 PM · Dolphin
elvisangelaccio requested changes to D13768: Modernize View Properties window.
Jul 8 2018, 1:57 PM · Dolphin
elvisangelaccio added a comment to D13316: manually set format in jpeg thumbnail creator.

I guess this change makes sense (given that we are in the jpeg plugin), but what about QImageReader::decideFormatFromContent() ?

Jul 8 2018, 1:53 PM
elvisangelaccio added a comment to D13570: Add workaround for labels with word-wrapping.

If no one has objections, I'll push it after the next tag.

Jul 8 2018, 1:46 PM · Frameworks
elvisangelaccio added a reviewer for D13570: Add workaround for labels with word-wrapping: cfeck.
Jul 8 2018, 1:45 PM · Frameworks
elvisangelaccio added a comment to D13814: Speedup sort.

@jtamate Can you show a complete gdb backtrace + valgrind log of this crash?

Jul 8 2018, 1:22 PM · Dolphin
elvisangelaccio added a comment to D13941: Honor BUILD_TESTING.

Isn't BUILD_TESTING already honored by ecm_add_tests ?

Jul 8 2018, 1:15 PM · Frameworks

Jul 5 2018

elvisangelaccio accepted D12571: Modernize Settings window.

Thanks for the patience :)

Jul 5 2018, 6:56 PM · Dolphin
elvisangelaccio accepted D13814: Speedup sort.
Jul 5 2018, 6:54 PM · Dolphin

Jul 4 2018

elvisangelaccio added inline comments to D12571: Modernize Settings window.
Jul 4 2018, 9:29 PM · Dolphin
elvisangelaccio accepted D13886: Bump min Qt/KF versions to those of dolphin.
Jul 4 2018, 9:03 PM · Baloo

Jul 2 2018

elvisangelaccio requested changes to D12571: Modernize Settings window.

I'm ok with the UI changes now.
Just some small nitpicks left and then I think we can ship this.

Jul 2 2018, 9:01 PM · Dolphin
elvisangelaccio requested changes to D13814: Speedup sort.

Impressive, I went from 18 seconds to 4 :O

Jul 2 2018, 8:17 PM · Dolphin
elvisangelaccio accepted D13124: Add Share action to Dolphin context menu.

Check out KFileItemActions::addServiceActionsTo

Jul 2 2018, 8:08 PM · Frameworks, Dolphin

Jul 1 2018

elvisangelaccio committed R36:36d6287503ad: cliinterface: restore old working directory after extraction (authored by elvisangelaccio).
cliinterface: restore old working directory after extraction
Jul 1 2018, 10:20 PM
elvisangelaccio committed R36:478d2d71f861: libarchive: restore old working directory after extraction (authored by elvisangelaccio).
libarchive: restore old working directory after extraction
Jul 1 2018, 10:20 PM