- User Since
- Aug 16 2015, 4:08 PM (156 w, 4 d)
No need to apologize, that's what code reviews are for :)
Not an ark issue. See https://mail.kde.org/pipermail/kde-buildsystem/2018-March/012418.html
Same, there is only one entry there.
Right. Then let's ship it as is for now, thanks!
I cannot reproduce the linked bug. If open the same file in both kate and kwrite I get only one entry in krunner (despite the file having two different X-KDE-LastOpenedWith values in .local/share/RecentDocuments/).
Wed, Aug 15
@jtamate Any updates on this? Can you use the new fastInsert() calls here?
Tue, Aug 14
Actually, the list is already const, so this is fine as is.
Looks good otherwise.
Mon, Aug 13
Sat, Aug 11
Please try to write unit test, if you can (have a look at dolphinmainwindowtest.cpp). That's the only way to make sure we don't break anything :)
Tue, Aug 7
Sat, Aug 4
Thanks for the patch. Just a couple of small nitpicks, looks good otherwise.
@pino does it look good to you now?
Tue, Jul 31
Sun, Jul 29
But why doesn't the KItemListView have a parent? Who deletes listView then?
QPointer is not a smart pointer and doesn't handle memory. But we don't need it anyway, because we have the Qt::WA_DeleteOnClose attribute set which does the cleanup.
Sat, Jul 28
This will crash as soon as you try to edit the Trash place (because m_iconButton in PlacesItemEditDialog::icon() won't be initialized).
@tmarshall Do you have commit access?
Sun, Jul 22
Sat, Jul 21
Wed, Jul 18
The old code was like that for a reason: https://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0
Jul 17 2018
@hallas Thanks. Do you have commit access?
Jul 16 2018
Currently we set the compression options only when adding new files
Jul 14 2018
Jul 12 2018
- Added bug report
Jul 10 2018
Thanks for filing the upstream bug. Looks good to me now.
Jul 8 2018
There is no bugreport, I'll have to file one.
Hmm, so the crash is in ucol_close() (aka in ICU) and we are working around it by forcing the cleanup in the KFileItemModel ctor (= single thread).
I guess this change makes sense (given that we are in the jpeg plugin), but what about QImageReader::decideFormatFromContent() ?
If no one has objections, I'll push it after the next tag.
@jtamate Can you show a complete gdb backtrace + valgrind log of this crash?
Isn't BUILD_TESTING already honored by ecm_add_tests ?
Jul 5 2018
Thanks for the patience :)
Jul 4 2018
Jul 2 2018
I'm ok with the UI changes now.
Just some small nitpicks left and then I think we can ship this.
Impressive, I went from 18 seconds to 4 :O