- User Since
- Aug 16 2015, 4:08 PM (174 w, 10 h)
I'd be ok with the proposed behavior.
Unfortunately it's still crashing for me, even with this patch.
Note that mkdir also doesn't warn if the folder already exists. I guess KNewFileMenu was designed to behave accordingly.
Sat, Dec 15
Fri, Dec 14
Mon, Dec 10
Sun, Dec 9
Sat, Dec 8
Already fixed by c08ee4577168070896a4a46220cd39df4e4e32cf
Wed, Dec 5
Tue, Dec 4
There is already a fix in D17348
And yes, this happens only in master, not 18.12
Ops, I just submitted D17363, but this fix is indeed better.
Mon, Dec 3
Can you please push it to the stable branch? (Applications/18.12)
Sun, Dec 2
Finally had the time to look at this diff.
We need to update kfileplacesmodeltest (as well as placesitemmodeltest in dolphin).
Sat, Dec 1
I think we can land this on the stable branch too (Applications/18.12).
Thu, Nov 29
Superseded by T10131.
Sun, Nov 25
I don't have an opinion about the new shortcut, I'll leave that to the VDG team.
@thsurrel Don't forget to abandond this diff :)
Sat, Nov 24
We could have used KUrlNavigator::mouseReleaseEvent() where we already have the same check, but this is also fine.
Sorry for taking so long.
Wed, Nov 21
Tue, Nov 20
Looks good beside the inline issue (hence why my Request Changes).
Thanks, patch looks good and kitemlistselectionmanagertest still passes.
Mon, Nov 19
Shouldn't the plugin check whether the file is writable? I don't think we can add tags to root-owned files, do we?
Sun, Nov 18
This provides a slightly easier way to make the location bar return to breadcrumbs mode
I vote to not make it an option. There is always time to reconsider if enough people complain about the new behavior :)
The patch looks fine and works for me: the upatched test fails, the patched one passes.
Sat, Nov 17
- Properly pass places' labels to the dialog
This should have been pushed on master, Applications/18.12 is feature frozen since 15th November.
Given that we are only two days late, I think we can ask for an exception, but next time please be careful.
@acrouthamel Please open another diff with your patch thats updates the dolphin test, so I can try easily try it out
Thanks, this fixes the bug for me.
Nov 11 2018
ONE PROBLEM HERE: Can not get a count of hidden Items on start up. the count for hidden items is always 0. So the Menu entry always starts enabled. Any help here would be great.
+1, looks good to me now.