- User Since
- Aug 16 2015, 4:08 PM (132 w, 5 h)
Hmm, needs more rebase?
I'd be ok with a KMessageWidget, not the perfect solution but surely the easiest.
If you can manage to dinamically show the button in the toolbar as @rkflx suggested, that would be better for sure.
Thanks for the patch.
Tests now pass for me! But I agree that splitting this diff would be good.
The test does can react to QThread::requestInterruption(), instead. It just doesn't currently do it.
- Improved unit test
- Replaced slotUnlock() with slotPop()
Sun, Feb 18
So, what's wrong with KIconLoader? Shouldn't we fix it?
Crash is gone, but now I get two failures:
FileMetadataWidgetTest::shouldShowProperties() is crashing for me.
Sat, Feb 17
Would be nice to get more feedback before choosing a shortcut that affects many applications.
The patch seems to fix the problem, great!
Code looks good beside the inline comment.
+1 works for me.
Please ask email@example.com whether we can ship this on 17.12
Sorry but #208023 should be closed as wontfix.
Fri, Feb 16
This is a new feature so it should not got in the stable branch (unless we ask for an exception to the release team).
Tue, Feb 13
Ah right, so this is https://bugs.kde.org/show_bug.cgi?id=376735
Sun, Feb 11
Crap. I'll have a look later today.
Sat, Feb 10
I'm not sure I'm following: all the 3 steps in the test plan work for me, without this patch.
Is there something else needed to trigger the bug?
Fri, Feb 9
Almost there, just coding style issues now :)
Thu, Feb 8
Is it normal that the dolphin process does not quit if I close the dolphin window but not the Git Log window?
Can you please rebase the patch? It doesn't apply currently
Wed, Feb 7
Hmm I don't know, that's a button and a button should tell me what happens when I click it (Dolphin is also wrong imho).
Sun, Feb 4
error: could not apply 88a775b... baloo-widgets: Apply coding style to filemetadataprovider
Almost there, I could not find regressions this time :)