elvisangelaccio (Elvis Angelaccio)
Developer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Aug 16 2015, 4:08 PM (165 w, 3 d)
Availability
Available

Recent Activity

Sun, Oct 14

elvisangelaccio committed R36:a8b25500fef6: Introduce default value for OperationMode enum (authored by elvisangelaccio).
Introduce default value for OperationMode enum
Sun, Oct 14, 8:12 PM
elvisangelaccio committed R36:2ace8b247004: Merge branch 'Applications/18.08' (authored by elvisangelaccio).
Merge branch 'Applications/18.08'
Sun, Oct 14, 8:12 PM
elvisangelaccio committed R36:73cb41111248: Show 'Extract' menu on archives without extension (authored by elvisangelaccio).
Show 'Extract' menu on archives without extension
Sun, Oct 14, 7:58 PM
elvisangelaccio accepted D15929: Add a 'Properties' entry in the Places panel context menu.
Sun, Oct 14, 10:17 AM · Dolphin
elvisangelaccio added a comment to D12162: Add support for touch scrolling in Dolphin.

I don't have a touch screen for actual testing, but I'll have a look asap anyway.

Sun, Oct 14, 10:13 AM · Dolphin
elvisangelaccio requested changes to D15980: Warn user before renaming the file/folder to start with a ' . '.
Sun, Oct 14, 10:10 AM · Dolphin
elvisangelaccio added a comment to D15221: appstream: make kio-gdrive an addon component.

What if some day someone changes the Dolphin's ID from <id>org.kde.dolphin.desktop</id> to <id>org.kde.dolphin</id> ?
Will it break this appstream file? (since I'm hardcoding .desktop in the IDs)

Sun, Oct 14, 8:51 AM
elvisangelaccio updated the test plan for D15221: appstream: make kio-gdrive an addon component.
Sun, Oct 14, 8:48 AM
elvisangelaccio updated the diff for D15221: appstream: make kio-gdrive an addon component.
  • Make it an addon instead
Sun, Oct 14, 8:47 AM
elvisangelaccio committed R241:d60d369140c3: [KNewFileMenu] Don't open an empty QFile (authored by elvisangelaccio).
[KNewFileMenu] Don't open an empty QFile
Sun, Oct 14, 8:32 AM
elvisangelaccio closed D16007: [KNewFileMenu] Don't open an empty QFile.
Sun, Oct 14, 8:32 AM · Frameworks
elvisangelaccio triaged T9858: PlacesItemModelTest needs working KDirWatch on the CI as Normal priority.
Sun, Oct 14, 8:27 AM · Dolphin

Sat, Oct 13

elvisangelaccio committed R318:ec3cf251b188: Revert "[PlacesItemModelTest] Make test fail on purpose" (authored by elvisangelaccio).
Revert "[PlacesItemModelTest] Make test fail on purpose"
Sat, Oct 13, 9:25 PM
elvisangelaccio added a reverting change for R318:dd8fce5594e9: [PlacesItemModelTest] Make test fail on purpose: R318:ec3cf251b188: Revert "[PlacesItemModelTest] Make test fail on purpose".
Sat, Oct 13, 9:25 PM
elvisangelaccio committed R318:dd8fce5594e9: [PlacesItemModelTest] Make test fail on purpose (authored by elvisangelaccio).
[PlacesItemModelTest] Make test fail on purpose
Sat, Oct 13, 8:26 PM
elvisangelaccio committed R318:277700425e7d: [PlacesItemModelTest] Revert last two commits (authored by elvisangelaccio).
[PlacesItemModelTest] Revert last two commits
Sat, Oct 13, 8:11 PM
elvisangelaccio requested changes to D15980: Warn user before renaming the file/folder to start with a ' . '.
Sat, Oct 13, 10:27 AM · Dolphin
elvisangelaccio committed R318:c527dc217234: [PlacesItemModelTest] Try to use an event loop instead of an hardcoded timeout (authored by elvisangelaccio).
[PlacesItemModelTest] Try to use an event loop instead of an hardcoded timeout
Sat, Oct 13, 10:10 AM
elvisangelaccio committed R318:c9dd3478be21: [PlacesItemModelTest] Try to double test timeout (authored by elvisangelaccio).
[PlacesItemModelTest] Try to double test timeout
Sat, Oct 13, 9:20 AM

Thu, Oct 11

elvisangelaccio accepted D15989: Disable unmount option for / or /home.

Thanks!

Thu, Oct 11, 9:21 PM · Dolphin
elvisangelaccio requested changes to D15989: Disable unmount option for / or /home.
Thu, Oct 11, 8:17 PM · Dolphin

Wed, Oct 10

elvisangelaccio committed R318:96f7a25b3d05: [PlacesItemModelTest] Improve name of helper method (authored by elvisangelaccio).
[PlacesItemModelTest] Improve name of helper method
Wed, Oct 10, 9:03 PM
elvisangelaccio added a comment to D16115: Update hidden state correctly.

This is a bugfix, it should be pushed to the stable branch (Applications/18.08).

Wed, Oct 10, 8:56 PM · Dolphin
elvisangelaccio accepted D16115: Update hidden state correctly.

Thanks

Wed, Oct 10, 8:47 PM · Dolphin
elvisangelaccio added a comment to D15278: Close Dolphin if last tab closed.

Hmm, I don't know. If the tabbar is not visible, there is no "last tab". Why should the "close tab" action be enabled then?

Browsers are different because they always have the tabbar visible (even if there is only one tab).

Wed, Oct 10, 8:06 PM · Dolphin

Tue, Oct 9

elvisangelaccio committed R318:8a932cb83730: [PlacesItemModelTest] Try harder to not hardcode indexes (authored by elvisangelaccio).
[PlacesItemModelTest] Try harder to not hardcode indexes
Tue, Oct 9, 9:01 PM

Mon, Oct 8

elvisangelaccio accepted D16050: Added missing QStringLiteral to Dolphin code.

Thanks

Mon, Oct 8, 7:22 PM · Dolphin
elvisangelaccio accepted D15507: [MountPointObserverCache] Update mounts less frequently.
Mon, Oct 8, 7:19 PM · Dolphin
elvisangelaccio accepted D15609: Add "Create New" menu to "Control" button.
Mon, Oct 8, 7:10 PM · Dolphin

Sun, Oct 7

elvisangelaccio committed R318:092d08f5e833: Fix implicit-fallthrough gcc warning (authored by elvisangelaccio).
Fix implicit-fallthrough gcc warning
Sun, Oct 7, 9:08 PM
elvisangelaccio requested changes to D15609: Add "Create New" menu to "Control" button.
Sun, Oct 7, 7:58 PM · Dolphin
elvisangelaccio committed R318:2871364f6605: Drop noisy debug output (authored by elvisangelaccio).
Drop noisy debug output
Sun, Oct 7, 7:49 PM
elvisangelaccio committed R318:949da1fb3117: [DolphinMainWindowTest] Attempt to fix testOpenInNewTabTile() on the CI (authored by elvisangelaccio).
[DolphinMainWindowTest] Attempt to fix testOpenInNewTabTile() on the CI
Sun, Oct 7, 7:40 PM
elvisangelaccio accepted D15277: [mtp] Move MTP device handling from kioslave to kiod-module.

Awesome job, Andreas <3

Sun, Oct 7, 7:22 PM · Frameworks, Dolphin
elvisangelaccio committed R318:54ae7f2488c1: [DolphinMainWindowTest] Add some debug output (authored by elvisangelaccio).
[DolphinMainWindowTest] Add some debug output
Sun, Oct 7, 7:20 PM
elvisangelaccio committed R318:4c40ad45efe5: Fix another stale comment (authored by elvisangelaccio).
Fix another stale comment
Sun, Oct 7, 6:04 PM
elvisangelaccio committed R318:7904ae417af2: Merge branch 'Applications/18.08' (authored by elvisangelaccio).
Merge branch 'Applications/18.08'
Sun, Oct 7, 5:56 PM
elvisangelaccio committed R318:e2f93a28294f: [PlacesItemModelTest] More index-related fixes (authored by elvisangelaccio).
[PlacesItemModelTest] More index-related fixes
Sun, Oct 7, 5:43 PM
elvisangelaccio committed R318:4a56d21fb1e9: [PlacesItemModel] Fix testSystemItems() (authored by elvisangelaccio).
[PlacesItemModel] Fix testSystemItems()
Sun, Oct 7, 5:43 PM
elvisangelaccio committed R318:e99827293bea: [PlacesItemModelTest] Fix testHideItem() (authored by elvisangelaccio).
[PlacesItemModelTest] Fix testHideItem()
Sun, Oct 7, 4:01 PM
elvisangelaccio committed R318:26d02ecbdb8b: [PlacesItemModelTest] Fix testTearDownDevice() (authored by elvisangelaccio).
[PlacesItemModelTest] Fix testTearDownDevice()
Sun, Oct 7, 3:51 PM
elvisangelaccio committed R318:0abba76eea63: [PlacesItemModelTest] Fix testDeletePlace() (authored by elvisangelaccio).
[PlacesItemModelTest] Fix testDeletePlace()
Sun, Oct 7, 3:43 PM
elvisangelaccio committed R318:9204f3272bf7: [PlacesItemModelTest] Fix testGroups() test case (authored by elvisangelaccio).
[PlacesItemModelTest] Fix testGroups() test case
Sun, Oct 7, 3:43 PM
elvisangelaccio committed R318:92157f6d7d1d: Follow-up of commit 9760f9607d (authored by elvisangelaccio).
Follow-up of commit 9760f9607d
Sun, Oct 7, 3:09 PM
elvisangelaccio committed R318:9760f9607d48: [PlacesItemModelTest] Check whether Desktop and Download folders exist (authored by elvisangelaccio).
[PlacesItemModelTest] Check whether Desktop and Download folders exist
Sun, Oct 7, 2:54 PM
elvisangelaccio committed R318:5e8b892a519b: Fix disabling of DolphinNewFileMenu (authored by elvisangelaccio).
Fix disabling of DolphinNewFileMenu
Sun, Oct 7, 2:54 PM
elvisangelaccio committed R318:dec7016c0d52: Add test cases for enabled status of DolphinNewFileMenu (authored by elvisangelaccio).
Add test cases for enabled status of DolphinNewFileMenu
Sun, Oct 7, 2:54 PM
elvisangelaccio closed D16006: Fix disabling of DolphinNewFileMenu.
Sun, Oct 7, 2:54 PM · Dolphin
elvisangelaccio closed D16005: Add test cases for enabled status of DolphinNewFileMenu.
Sun, Oct 7, 2:54 PM · Dolphin
elvisangelaccio added inline comments to D15929: Add a 'Properties' entry in the Places panel context menu.
Sun, Oct 7, 1:36 PM · Dolphin
elvisangelaccio requested review of D16007: [KNewFileMenu] Don't open an empty QFile.
Sun, Oct 7, 11:35 AM · Frameworks
elvisangelaccio committed R318:3b5c5543aa42: Fix stale comment (authored by elvisangelaccio).
Fix stale comment
Sun, Oct 7, 11:34 AM
elvisangelaccio requested review of D16006: Fix disabling of DolphinNewFileMenu.
Sun, Oct 7, 11:27 AM · Dolphin
elvisangelaccio requested review of D16005: Add test cases for enabled status of DolphinNewFileMenu.
Sun, Oct 7, 11:17 AM · Dolphin
elvisangelaccio accepted D15974: Add 'Mount' option to context menu of unmounted device in Places.
Sun, Oct 7, 9:13 AM · Dolphin
elvisangelaccio requested changes to D15989: Disable unmount option for / or /home.
Sun, Oct 7, 9:08 AM · Dolphin
D15973: Add a 'Properties' entry in the places panel context menu is now accepted and ready to land.
Sun, Oct 7, 9:00 AM · Frameworks
elvisangelaccio requested changes to D15929: Add a 'Properties' entry in the Places panel context menu.
Sun, Oct 7, 8:59 AM · Dolphin

Sat, Oct 6

elvisangelaccio requested changes to D15980: Warn user before renaming the file/folder to start with a ' . '.

Please don't use goto.
Also this will need some i18n fixes to avoid word puzzles, see https://api.kde.org/frameworks/ki18n/html/prg_guide.html#good_text

Sat, Oct 6, 8:25 AM · Dolphin
elvisangelaccio added a comment to D15371: Don't assign twice the same key to the action New Tab.

I don't get it. Ctrl+T works with dolphin from my arch distro package. It doesn't work with my self-compiled dolphin though. What's going on?

Sat, Oct 6, 8:18 AM · Dolphin

Thu, Oct 4

elvisangelaccio added a comment to D15609: Add "Create New" menu to "Control" button.

Btw we broke the "Create New" button on read-only folders. Time to write an unit test for that...

Thu, Oct 4, 9:12 PM · Dolphin
elvisangelaccio committed R318:7c8a9906a2d5: [PlacesItemModel] Update apidox (authored by elvisangelaccio).
[PlacesItemModel] Update apidox
Thu, Oct 4, 9:06 PM
elvisangelaccio committed R318:4ccf2bbfd95d: [PlacesItemModel] Drop unused forward declaration (authored by elvisangelaccio).
[PlacesItemModel] Drop unused forward declaration
Thu, Oct 4, 9:06 PM
elvisangelaccio committed R318:50f23e8b11ff: [PlacesItemModel] Drop dead code (authored by elvisangelaccio).
[PlacesItemModel] Drop dead code
Thu, Oct 4, 9:06 PM
elvisangelaccio added a comment to D15929: Add a 'Properties' entry in the Places panel context menu.

I'm pretty sure this can be implemented in KFilePlacesModel without the need to duplicate the feature here in dolphin.

Thu, Oct 4, 8:00 PM · Dolphin
elvisangelaccio added a comment to T9795: Use Places Panel code from KIO instead of private implementation.

One thing that strikes me is that a lot of the PlacesItemModel code is just proxying KFilePlacesModel. Another large part of the code seems entirely duplicated. It would make sense to check if we can just use KFilePlacesModel directly in the Places Panel.

Thu, Oct 4, 7:58 PM · Frameworks, Dolphin

Tue, Oct 2

elvisangelaccio accepted D15904: Fix that dragging a file can trigger inline rename..

Thanks!

Tue, Oct 2, 7:50 PM · Dolphin
elvisangelaccio added inline comments to D15698: Port audiocd-kio away from kdelibs4support.
Tue, Oct 2, 7:30 PM

Mon, Oct 1

elvisangelaccio accepted D15873: Improve debugging output by displaying whether the SMBSlave::del() function attempts to delete a file or a directory..

@madcatx Time to request commit access? :D

Mon, Oct 1, 8:55 PM · Frameworks, Dolphin

Sun, Sep 30

elvisangelaccio planned changes to D15221: appstream: make kio-gdrive an addon component.
In D15221#321062, @mak wrote:

That is not entirely correct, and I really hope the notion of ".desktop file" will finally die at some point soon... AppStream requires you to set one or multiple component-IDs that the component extends. So, if KIO had a metainfo file, you could extend it by specifying your addon to extend org.kde.kio (or whatever ID it would have).
Apps looking for extensions that know they use KIO can then also look for KIO extensions.
Since very few apps (none?) do that currently and users will want to find your module in software centers easily, I would also make your addon extend org.kde.dolphin (or whatever Dolphin's ID is) as well as Konqueror. That will likely cover 90% of all usecases.

Sun, Sep 30, 5:02 PM
elvisangelaccio added a comment to D15801: Add icon to compress/extract actions.

I also think we should use monochrome icons there.

Sun, Sep 30, 3:59 PM · Ark

Sun, Sep 23

elvisangelaccio added a comment to D14442: Unify window and tab title.

Apparently this also caused https://bugs.kde.org/show_bug.cgi?id=398817

Sun, Sep 23, 10:05 AM · Dolphin
elvisangelaccio added a comment to D7647: Two clicks on file/folder to rename.

This apparently caused regressions as I noticed:

1.) Long-clicking on a selected file now triggers inline renaming in single-click mode too.
Or was that intentional? The summary states this though:

Sun, Sep 23, 10:03 AM · Dolphin
elvisangelaccio accepted D15611: [KCollapsibleGroupBox] Respect style's widget animation duration.
Sun, Sep 23, 9:57 AM · Frameworks
elvisangelaccio accepted D15448: Send file contents in chunks.

Please push to the stable branch (1.2). Thanks!

Sun, Sep 23, 9:48 AM

Sat, Sep 22

elvisangelaccio added inline comments to D15277: [mtp] Move MTP device handling from kioslave to kiod-module.
Sat, Sep 22, 3:16 PM · Frameworks, Dolphin
elvisangelaccio added a reviewer for D15277: [mtp] Move MTP device handling from kioslave to kiod-module: dfaure.
Sat, Sep 22, 3:05 PM · Frameworks, Dolphin
Restricted Application added projects to D15277: [mtp] Move MTP device handling from kioslave to kiod-module: Dolphin, Frameworks.

From a quick look, the architecture is sound and respects what was discussed in T9390. And indeed it works pretty well, awesome job @akrutzler!

Sat, Sep 22, 3:05 PM · Frameworks, Dolphin
elvisangelaccio accepted D15636: [Places Panel] Cleanup includes.
Sat, Sep 22, 8:50 AM · Dolphin
elvisangelaccio accepted D15589: Add proper labels to Trash Emptied notification.
Sat, Sep 22, 8:18 AM · Dolphin
elvisangelaccio accepted D15445: Use Ark part only when mime type exactly matches a supported type.
Sat, Sep 22, 8:09 AM · Ark

Sep 16 2018

elvisangelaccio added inline comments to D15448: Send file contents in chunks.
Sep 16 2018, 4:09 PM
elvisangelaccio requested changes to D15445: Use Ark part only when mime type exactly matches a supported type.

Looks good otherwise

Sep 16 2018, 3:57 PM · Ark
elvisangelaccio added a comment to D15369: Add support for Zstd-compressed Tar-archives.

For the record, I submitted the following two patches:

Sep 16 2018, 3:43 PM · Ark
elvisangelaccio requested changes to D15369: Add support for Zstd-compressed Tar-archives.

Looks good except the version bump.

Sep 16 2018, 3:42 PM · Ark
elvisangelaccio accepted D15539: Keep org.freedesktop.FileManager1 registered across processes.

Thanks

Sep 16 2018, 8:47 AM · Dolphin

Sep 15 2018

elvisangelaccio added a reviewer for D15448: Send file contents in chunks: dfaure.
Sep 15 2018, 1:51 PM
elvisangelaccio updated subscribers of D15448: Send file contents in chunks.

Thanks a lot for working on this.

Sep 15 2018, 1:51 PM
elvisangelaccio added a comment to D15278: Close Dolphin if last tab closed.

Let's not make this an option, please :/

Sep 15 2018, 11:26 AM · Dolphin
elvisangelaccio added a comment to D15404: [KFileItemModelRolesUpdater] Avoid duplicate indexes to resolve.

@broulik Can you please "plan changes" or abandon it then?

Sep 15 2018, 11:05 AM · Dolphin
elvisangelaccio added a comment to D15506: RFC: [StatusBarSpaceInfo] Only update when window is active.

+1 for D15507 and D15508

Sep 15 2018, 10:56 AM · Dolphin
elvisangelaccio added inline comments to D15508: Update disk space info on refresh.
Sep 15 2018, 10:52 AM · Dolphin
elvisangelaccio accepted D15237: [ViewProperties] Check part of home first before doing file system stuff.
Sep 15 2018, 10:39 AM · Dolphin

Sep 9 2018

elvisangelaccio accepted D15371: Don't assign twice the same key to the action New Tab.

Stable branch, please. Thanks!

Sep 9 2018, 1:56 PM · Dolphin

Sep 6 2018

elvisangelaccio added a comment to D15318: Automatically re-upload saved files located on remote locations instead of asking first.

Note that kioexecd is slave-agnostic, we shouldn't test only with the samba slave.

Sep 6 2018, 9:09 PM · Frameworks
elvisangelaccio accepted D15069: Make thumbnail frame-and-shadow drawing criteria match those of the file dialog.
Sep 6 2018, 8:44 PM · Dolphin

Sep 5 2018

elvisangelaccio added a comment to D15278: Close Dolphin if last tab closed.

Hmm, I don't know. If the tabbar is not visible, there is no "last tab". Why should the "close tab" action be enabled then?

Sep 5 2018, 7:34 PM · Dolphin
elvisangelaccio accepted D15249: Use lambdas instead of QSignalMapper.

Thanks

Sep 5 2018, 7:28 PM · Ark
elvisangelaccio accepted D15180: kioexecd: watch for creations or modifications of the temporary files.
Sep 5 2018, 7:23 PM · Frameworks
elvisangelaccio added a comment to D15221: appstream: make kio-gdrive an addon component.

Yes I was condering that, but the problem is this is an ioslave that almost anyone can use (not just dolphin or plasma).

If anyone (KIO-based) can use it, doesn't it make it an addon?

Sep 5 2018, 7:09 PM