- User Since
- Aug 16 2015, 4:08 PM (217 w, 6 d)
Sun, Oct 13
I still don't understand if we are fixing an issue or if this is just a removal of a redundant signal. AFAICS we are only removing a selectionChanged() instance called by clearSelection() in "search mode", but this signal is also emitted in many other places (e.g. is emitted 3 times if I change selection with the mouse).
Thu, Oct 10
More info on the i18n markers here: https://api.kde.org/frameworks/ki18n/html/prg_guide.html#good_ctxt
Wed, Oct 9
Tue, Oct 8
@meven Looks like this patch is not enough: https://build.kde.org/job/Applications/job/dolphin/job/kf5-qt5%20SUSEQt5.12/78/testReport/projectroot.src/tests/placesitemmodeltest/
+1 for the idea.
This is perfect, I love it!
Mon, Oct 7
Would you mind to move the isIndexingEnabled() refactoring to another commit?
Sun, Oct 6
Another thing that I forgot: the double click trigger should only be enabled in single-click mode, probably.
Yep, the i18n issue if fixed now.
Patch seems to work fine, but the lack of commit message makes it hard to understand where the actual bugfix is. Please simplify the patch as mentioned inline.
Thu, Oct 3
This is what I get in the shortcuts dialog:
@elvisangelaccio, if you would like to revert that commit to keep the history cleaner I can rebase this one.
Wed, Oct 2
I'll push to 19.08, thanks for the patch!
Why not assign a default shortcut? Alt + i seems to be the standard pattern for this (tried with Firefox and Chrome).
Tue, Oct 1
Sun, Sep 29
@hallas I noticed the following warning on dolphin start:
Sorry for the long delay. I don't think we should add an option to let the user choose what to do on double clicks.
Oh, and there is a missing BUG: 371837 in the commit message ;)
While the Confirmation tab is not perfect, I don't think that moving this setting to the Behavior or Navigation tabs would be much better.
LGTM now, let's ship it so that we can move forward with the arrows patches.
Tue, Sep 24
https://git.reviewboard.kde.org/r/129383/ had a patch for this but it never got merged. Copying the diff here in case anyone wants to take over:
So should we close https://bugs.kde.org/show_bug.cgi?id=376992 ? ;)
Sun, Sep 22
Sat, Sep 21
LGTM now. Ship it! :)
Thanks, cool stuff :)
Sep 15 2019
Sorry for the delay.
Feel free to push after fixing the last two nitpicks.
It seems to me that making the URL navigator buttons more discoverable and moving the URL navigator to the toolbar are two orthogonal things.
Needs one more rebase, sorry
Mention that URLs will be stored in the QUrl::FullyEncoded string format.
- Fixed typo
Yeah, that's my next patch ;)
Nice, this seems to do the trick :)