Ping?

Thanks

@ltoscano Yes, seems the docboock lists the page in their actual order within the dialog.

Indeed, it probably makes sense to be consistent here.

In D12571#278266, @ngraham wrote:

In D12571#277946, @elvisangelaccio wrote:

In D12571#276764, @ngraham wrote:>

Don't they control how the view appears on startup?

Only "Split view mode" does. The other ones control things that are outside the view. How about using "On startup:" and rewording the sentences on the checkboxes where necessary?

I was using the term "View" from a user perspective. I think to people who aren't Dolphin developers, these are view settings. The technical distinction between the view, its container, and the main window are not relevant to users, or important to understand.

Some screens:

In D12571#276764, @ngraham wrote:>

Don't they control how the view appears on startup?

Should we backport this on the stable branch? Otherwise affected people will have to either downgrade kio or compile kio-extras from master...

I'm not 100% convinced. The Defaults button resets all dolphin settings, while this one resets only this particular option.
The problem is we don't know if someone relies on this "feature", and in theory we could break someone else's workflow (unlikely, but still).

In D12571#272751, @ngraham wrote:

I updated the title to reflect what this patch actually does now: it modernizes the look and feel of the whole settings window to be in line with the current HIG and our latest design focus for settings windows throughout KDE.

@dfaure Can you respin the kio tarball with this commit?

Though we should probably fix the non-localized ", " usage, eventually :D

• Also delete when the dialog is rejected

In D13304#273616, @emateli wrote:

Works for me as well. One potential issue is that the object is not deleted if the rename operation is cancelled as the flag is not there anymore.

• Use auto

In D13152#272717, @anthonyfieroni wrote:

When you have more than one tab with search box in click repeatedly between.

No need to resubmit, I'll amend the commit locally for this time.

In D13152#272642, @anthonyfieroni wrote:

I try this too, but loop still present

Sorry but now there are even more visual regressions than the original revision had.

Ping?

Superseded by D12731.

@nerdopolist: why does arc create a commit with author "nerdopolis <rbos@rbos>" ?

• Bring back setFocus() call

• Don't schedule the activation if we are already active

In D13152#269115, @anthonyfieroni wrote:

I try this, but it does not work in all cases. I can't test right now, but i'll provide more info soon.
Edit: I remember, now when change tabs focus is not in search box, which is annoying.

@sontolbonggol What's the email address we should use for the git commit?

@anthonyfieroni I propose another fix in D13152 :)

Patch doesn't apply, can you rebase it?

@anthonyfieroni Thanks, that was helpful and I was finally able to reproduce the problem.

@anthonyfieroni Can you make a video? I still don't understand how to reproduce

LGTM

@emateli Can you please click on "Plan Changes" if this review needs to be updated?

Please tell us which email address we should use to land this patch on your behalf. Thanks!