Sorry for the delay, I moved to a new house. I'll resume all pending reviews soon.

Still does not apply for me.

Patch doesn't seem to apply, can you rebase it on master please?

I don't get why we want to start a rename operation at all, tbf.

LGTM now.

I'm still not a big fan of the huge "normal" icon, but at least now they don't look bad as in D11022.

LGTM now.

How about "Context Menu Plugins" ?

I noticed the following warning if I close dolphin while kompare is still running:

In T11560#217073, @ryanrsmith wrote:

Hi, I get the message,

Sign in with Google temporarily disabled for this app
This app has not yet been verified by Google in order to use Google Sign in.

When I use Dolphin on Manjaro Linux to access GDrive after signing in to Google.

kio-gdrive 1.2.7-1

Is this related?

Haven't tried the dolphin branch yet, just a comment on the API for now.
From a quick look the patch looks good though.

Sorry for the delay, patch looks good but needs some polish.

Looks safe enough to me.

In D8208#592754, @ngraham wrote:

In D8208#592667, @elvisangelaccio wrote:

Well, that depends on the current sorting mode, right? If I have sort-by-modified then the duplicate file will jump to the top of the view even if it has the "copy" suffix rather than the "Copy of" prefix, no?

If you prepend "Copy of," then it jumps around when you're sorting by Name or Creation Date.

If you append "copy," then it only jumps around when you're sorting by Creation Date.

Very nice, much simpler than D18838 ;)

In D8208#592689, @dfaure wrote:

Normally this shouldn't happen, since this uses CopyJob which preserves the mtime of the file.

In D8208#592084, @ngraham wrote:

I can do that, sure. But IMO there's a UX problem when you append "Copy of" to the beginning rather than the end. Imagine that you have a file that starts with a Z and you duplicate it. The duplicate appears near the top of the window because it begins with C. If the current view is scrollable, view scrolls up to the top to show you the newly duplicated file. This causes you to lose your place in the view, which could be annoying if you were planning to do something else with another adjacent file or perform another operation on the original file (perhaps to duplicate it a second time to perform some A/B testing on two duplicates with slightly different changes, for example). For this reason, I prefer the macOS behavior of appending "copy" to the end of the filename, not to the beginning.

In D26590#592493, @meven wrote:

I would delete those setText here and add it when the action is created around line 1328, since the text does not change anymore.

Thanks! Going to push to 19.12.

Sorry, we can't make this an option. Moving the navigator to the toolbar would require lots of changes to the code. We can't possibly maintain both implementations, it would be a nightmare.

Do you have commit access?

In D26460#589111, @nazark wrote:

Nice, thanks =)

And now about the other apps, I found out that actually there are quite a lot of apps that have this issue, not only the kcalc and the konsole.
So, there is no better option than just making one patch per app and submitting it on the phabricator, right?

Fixed, it was a problem on my end. I'm going to push it, thanks!

In T12308#216754, @manueljlin wrote:

dolphin with breadcrumbs inside view

In D26460#588919, @nazark wrote:

I'm afraid that I'll need a bit of help in order to do that, sorry :-(
Git tells me that my copy is up-to-date, so I think that my patch is applied on top of most recent commit.
What exactly should I do to rebase it?

Just minor nitpicks, looks good otherwise.

It seems to me that moving the url navigator to the toolbar creates more problems than it solves, because of split views.

Can you please rebase this patch? It doesn't apply currently.

Yes, the fix is correct. Feel free to submit patches for all affected apps :)

Update: Google still hasn't verified my app after months, but I noticed that the libkgapi's embedded web browser fails to meet Google's security standards anyway (too old webengine?):

+1

Is it possible to add a test case in dolphinquerytest.cpp?

@nicolasfella I don't like the hardcoding of 48. If there is no clean way to port IconSize(KIconLoader::Desktop), I'd prefer to port to a different non-hardcoded size.

Please update the commit message before pushing.

Ping?

@heikobecker are you still interested in this patch? I can take over otherwise.

In D26273#584234, @vkrause wrote:

Longer term we probably either want to convince upstream to install cmake config files, or at least have this in ECM, a quick local grep find a handful of copies of this.

In D11382#578198, @elvisangelaccio wrote:

Fair enough.

Please note that I'm planning to rework the dbus handling in global.cpp during the christmas holidays. If you don't mind I'd wait to get that merged and then rebase this patch (which should also become simpler).

Nice cleanup!

In D8208#155926, @elvisangelaccio wrote:

If the main/classic method of copying doesn't work well with many files, imho we should find a way to fix that. So that the use case would be ok for everyone, not just those who have the menubar visible or know the CTRL+D shortcut.

So the threshold is now 50%? Isn't that a bit too low?

LGTM, thanks.

Improve API

Not in the current version, I'm afraid.

Go for it

Do you mind splitting this into a renaming-only patch and another patch for the changes to the logic?

Fair enough.

LGTM otherwise.