In D25260#569081, @iasensio wrote:

@elvisangelaccio, @bruns, if there is no strong objections, I would like to push this fix to release/19.12 today, before the RC tagging

Interesting. How did you test this? Just opening an archive?

Thanks

I'm going to push this tomorrow unless there are strong objections.

+1 but why only archivemodel.cpp ?

In D25510#567096, @anthonyfieroni wrote:

It looks like a hack knowing Qt algorithm, can we append the pid in the name? It looks like same, but if we have more than one instances?

@bruns Ping.
We have until November 28 to get this in.

What about a dialog that asks the user what to do (--cache, --force, neither) and tell the user what will happen to the file?

LGTM.

Thanks

Actually https://kde.org/applications/system/dolphin already works and redirects to https://kde.org/applications/system/org.kde.dolphin

Is there a reason why this was pushed only to master ?

Please push to release/19.12 only.

In D25255#562221, @elvisangelaccio wrote:

Sure ;)

Sure ;)

Please wait for @bruns approval too.

In D11382#560853, @ngraham wrote:

19.12 has branched so we can target 20.04 for this and have time for lots and lots of testing. Can I request a review, @elvisangelaccio?

Please push to the release/19.12 branch. Thanks!

Please provide an email address so that we can commit this patch on your behalf. Thanks!

In T11933#207480, @aspotashev wrote:

On branch naming:

"release/19.12" is not so good because such branch corresponds to multiple releases: 19.11.70 through 19.12.5.
"stable/19.12" or "development/19.12" look better to me.

In T11933#207509, @aacid wrote:

We also need to decide what to rename KDE_APPLICATIONS_VERSION_XXX in CMakeLists.txt if at all, or just pretend this is internal and noone cares

Remove qDebug line

In D25218#560431, @meven wrote:

Do we understand each other ?
Do you have an opinion about this update delay, taking into account my last comment ?
Or did you mean LGTM ?

Feel free to push as soon as you get the answer to https://bugs.kde.org/show_bug.cgi?id=413086#c6

In D25218#560389, @meven wrote:

I am not so sure about this 150 ms delay.
When navigating with the keyboard, it is quite noticeable.
So in the meantime, I am gonna reduce this delay to 50 ms.

Removing it altogether might be appropriate.

Just as a reminder, the information panel delay is mostly due to technicalities : thumbnail generation and metadata extraction are costly.
Whereas here we don't have such reasons to limit text refreshing.

In D24422#560282, @bruns wrote:

The problem with the original code is it mixes the model and the view.

Please do the following:

1. Split the current code to model/view, i.e. move the "rating + filename + remainder" into a separate trivial class
2. Populate the model class from the existing parser, populate the view from the model
3. Add the unit test you have written (of course, no longer testing the DolphinSearchBox, but the model) (some tests have to be marked as XFAIL).
4. Update the parser, update the XFAILs
   
   Splitting model/view makes it much easier to extend the searchbox later, and to e.g. reuse Baloos parser.

In D25120#558138, @ognarb wrote:

• According to stats.kde.org, there is only 60 visits to stats.kde.org per day (probably a 2 to 3 times more counting people using adblocker and setting do not track header)

Thanks

@iasensio Please consider applying for a developer account ;)

+1 for "release/19.12". IMHO it makes clear that everything committed to that branch is going into the 19.12 release.

Patch looks good, but I don't see how we fix https://bugs.kde.org/show_bug.cgi?id=386754

I assume the VDG is fine with this even without formal approval ;)

Thanks