elvisangelaccio (Elvis Angelaccio)
Developer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Aug 16 2015, 4:08 PM (217 w, 6 d)
Availability
Available

Recent Activity

Sun, Oct 13

elvisangelaccio committed R36:e5dea0cc02b7: Display "executable" in info panel instead of "unknown" (authored by umanovskis).
Display "executable" in info panel instead of "unknown"
Sun, Oct 13, 9:07 PM
elvisangelaccio closed D24383: Display "executable" in info panel instead of "unknown".
Sun, Oct 13, 9:07 PM · Ark
elvisangelaccio accepted D24383: Display "executable" in info panel instead of "unknown".
Sun, Oct 13, 9:05 PM · Ark
elvisangelaccio added inline comments to D24577: [dolphin/search] Fix search behavior when selecting "Your Files".
Sun, Oct 13, 3:51 PM · Dolphin
elvisangelaccio requested changes to D24450: [dolphin/search] Reset search options when needed.
Sun, Oct 13, 3:42 PM · Dolphin
elvisangelaccio committed R318:c144701c28aa: Hide search extra options when not available (authored by iasensio).
Hide search extra options when not available
Sun, Oct 13, 3:25 PM
elvisangelaccio closed D24446: Hide search extra options when not available.
Sun, Oct 13, 3:25 PM · Dolphin
elvisangelaccio accepted D24446: Hide search extra options when not available.
Sun, Oct 13, 3:25 PM · Dolphin
elvisangelaccio requested changes to D22594: [Dolphin] Open Preferred Search Tool action.

Almost there!

Sun, Oct 13, 3:19 PM · Documentation, Dolphin
elvisangelaccio committed R318:e04ec8601f37: Add actions for switching to a specific tab (authored by alexmi).
Add actions for switching to a specific tab
Sun, Oct 13, 3:03 PM
elvisangelaccio closed D24353: Add actions for switching to a specific tab.
Sun, Oct 13, 3:03 PM · Dolphin
elvisangelaccio accepted D24353: Add actions for switching to a specific tab.
Sun, Oct 13, 2:43 PM · Dolphin
elvisangelaccio requested changes to D24505: Avoid emitting twice twice selectionChanged when keyboard changes the selection.

I still don't understand if we are fixing an issue or if this is just a removal of a redundant signal. AFAICS we are only removing a selectionChanged() instance called by clearSelection() in "search mode", but this signal is also emitted in many other places (e.g. is emitted 3 times if I change selection with the mouse).

Sun, Oct 13, 2:08 PM · Dolphin

Thu, Oct 10

elvisangelaccio requested changes to D24446: Hide search extra options when not available.

More info on the i18n markers here: https://api.kde.org/frameworks/ki18n/html/prg_guide.html#good_ctxt

Thu, Oct 10, 7:57 PM · Dolphin

Wed, Oct 9

elvisangelaccio added a comment to D23557: Update dolphin tests following place changes D7446.

It seems to me the test fails because is uses an older kio version than 5.63 with D7446 applied creating "Recently Saved" group instead of group "Recent".

FAIL! : PlacesItemModelTest::testGroups() Compared values are not the same

Actual   (groups.at(2).second.toString()): "Recently Saved"
Expected (QStringLiteral("Recent"))      : "Recent"

The actual shows that the old "Recently Saved" group was created when it should not have been.

I don't know how this jenkins job works, but I would recommend cleaning the cached artifact KIO 5.63.0 for dolphin somehow.
We can alternatively limit this test run only on KF5 >= 5.64

Wed, Oct 9, 8:17 PM · Dolphin

Tue, Oct 8

elvisangelaccio added a comment to D23557: Update dolphin tests following place changes D7446.

@meven Looks like this patch is not enough: https://build.kde.org/job/Applications/job/dolphin/job/kf5-qt5%20SUSEQt5.12/78/testReport/projectroot.src/tests/placesitemmodeltest/

Tue, Oct 8, 8:33 PM · Dolphin
elvisangelaccio requested changes to D24383: Display "executable" in info panel instead of "unknown".

+1 for the idea.

Tue, Oct 8, 8:30 PM · Ark
elvisangelaccio accepted D24362: Don't count hidden files in folder item count.

This is perfect, I love it!

Tue, Oct 8, 8:14 PM · Baloo
elvisangelaccio added a comment to D20532: Proof of Concept: Add double click actions to empty space in the folder view.

Adding a new setting makes the code and the UI more complex and harder to maintain in the long term. We should add new settings only when there is no other way (this usually happens if a new feature makes sense only for a subset of users).

But even if we go with just the "Go up" action, I think there should be an option to turn it off.
I often miss the file or folder when double clicking and going up would be annoying.

Tue, Oct 8, 8:03 PM · Dolphin
elvisangelaccio committed R318:df9ca5b0c223: [dolphin/search] Add method isIndexEnabled() (authored by iasensio).
[dolphin/search] Add method isIndexEnabled()
Tue, Oct 8, 7:45 PM
elvisangelaccio closed D24478: [dolphin/search] Add method isIndexEnabled().
Tue, Oct 8, 7:45 PM · Dolphin
elvisangelaccio accepted D24478: [dolphin/search] Add method isIndexEnabled().

Thanks

Tue, Oct 8, 7:42 PM · Dolphin

Mon, Oct 7

elvisangelaccio added a comment to D24446: Hide search extra options when not available.

Would you mind to move the isIndexingEnabled() refactoring to another commit?

Mon, Oct 7, 7:58 PM · Dolphin
elvisangelaccio committed R318:e30357343bda: [dolphin/search] Avoid unnecesary reloads on setSearchPath (authored by iasensio).
[dolphin/search] Avoid unnecesary reloads on setSearchPath
Mon, Oct 7, 7:51 PM
elvisangelaccio closed D24449: [dolphin/search] Avoid unnecesary reloads on setSearchPath.
Mon, Oct 7, 7:51 PM · Dolphin
elvisangelaccio accepted D24449: [dolphin/search] Avoid unnecesary reloads on setSearchPath.
Mon, Oct 7, 7:51 PM · Dolphin
elvisangelaccio committed R318:304ab14e0883: [dolphin/search] Add missing parsing for type 'Folder' (authored by iasensio).
[dolphin/search] Add missing parsing for type 'Folder'
Mon, Oct 7, 7:50 PM
elvisangelaccio closed D24448: [dolphin/search] Add missing parsing for type 'Folder'.
Mon, Oct 7, 7:50 PM · Dolphin
elvisangelaccio accepted D24448: [dolphin/search] Add missing parsing for type 'Folder'.
Mon, Oct 7, 7:46 PM · Dolphin

Sun, Oct 6

elvisangelaccio added a comment to D24362: Don't count hidden files in folder item count.

I almost feel like we would need to add a setting to hide the hidden count, as at least some users will be annoyed by this, in particular those using local view settings with .directory files.

Sun, Oct 6, 3:08 PM · Baloo
elvisangelaccio added a comment to D20532: Proof of Concept: Add double click actions to empty space in the folder view.

Another thing that I forgot: the double click trigger should only be enabled in single-click mode, probably.

Sun, Oct 6, 12:43 PM · Dolphin
elvisangelaccio added a comment to D24353: Add actions for switching to a specific tab.

Yep, the i18n issue if fixed now.

Sun, Oct 6, 11:43 AM · Dolphin
elvisangelaccio requested changes to D23716: When the selection is deselected, restart the keyboard search from the beginning.

Patch seems to work fine, but the lack of commit message makes it hard to understand where the actual bugfix is. Please simplify the patch as mentioned inline.

Sun, Oct 6, 11:24 AM · Dolphin
elvisangelaccio accepted D24362: Don't count hidden files in folder item count.

Well, without this patch it's already showing wrong information. "There are only 3 things in here, why does the information panel say there are 7?" Hence the bug report from a user.

Sure, the current behavior is also wrong. But why switch from wrong to wrong when there is a way to make it right? ;)

The switch moves from wrong to right in most common cases.

Sun, Oct 6, 10:18 AM · Baloo
elvisangelaccio committed R318:fcf2d98447a1: Merge branch 'Applications/19.08' (authored by elvisangelaccio).
Merge branch 'Applications/19.08'
Sun, Oct 6, 9:55 AM
elvisangelaccio committed R318:31fd775f368f: Fix crash when lauching dolphin with a search scheme (authored by iasensio).
Fix crash when lauching dolphin with a search scheme
Sun, Oct 6, 9:40 AM
elvisangelaccio closed D24432: Fix crash when lauching dolphin with a search scheme.
Sun, Oct 6, 9:40 AM · Dolphin
elvisangelaccio accepted D24432: Fix crash when lauching dolphin with a search scheme.
Sun, Oct 6, 9:39 AM · Dolphin

Thu, Oct 3

elvisangelaccio requested changes to D24353: Add actions for switching to a specific tab.

This is what I get in the shortcuts dialog:

Thu, Oct 3, 8:32 PM · Dolphin
elvisangelaccio committed R318:3d65fa9a7959: Update searchbox on URL changes (Fix D24369) (authored by iasensio).
Update searchbox on URL changes (Fix D24369)
Thu, Oct 3, 8:18 PM
elvisangelaccio committed R318:8599a42ac13e: Update searchbox on URL changes (Fix D24369) (authored by iasensio).
Update searchbox on URL changes (Fix D24369)
Thu, Oct 3, 8:08 PM
elvisangelaccio closed D24376: Update searchbox on URL changes (Fix D24369).
Thu, Oct 3, 8:08 PM · Dolphin
elvisangelaccio accepted D24376: Update searchbox on URL changes (Fix D24369).

@elvisangelaccio, if you would like to revert that commit to keep the history cleaner I can rebase this one.

Thu, Oct 3, 8:06 PM · Dolphin
elvisangelaccio added a comment to D24362: Don't count hidden files in folder item count.

Well, without this patch it's already showing wrong information. "There are only 3 things in here, why does the information panel say there are 7?" Hence the bug report from a user.

Thu, Oct 3, 7:54 PM · Baloo

Wed, Oct 2

elvisangelaccio committed R318:43ea7052e15b: Merge branch 'Applications/19.08' (authored by elvisangelaccio).
Merge branch 'Applications/19.08'
Wed, Oct 2, 9:15 PM
elvisangelaccio added a comment to D24362: Don't count hidden files in folder item count.

Why? What' wrong with always showing "X items (Y hidden)" ?

I don't hate this idea, but for the average user I don't think it adds any value to show the number of hidden files, since they're hidden. The average user doesn't even know that there are hidden files. It's just noise.

Wed, Oct 2, 9:15 PM · Baloo
elvisangelaccio committed R318:b3120cb90e3d: Update searchbar parameters on URL change (authored by iasensio).
Update searchbar parameters on URL change
Wed, Oct 2, 9:05 PM
elvisangelaccio closed D24369: [dolphin] Update searchbar parameters on URL change.
Wed, Oct 2, 9:05 PM · Dolphin
elvisangelaccio accepted D24369: [dolphin] Update searchbar parameters on URL change.

I'll push to 19.08, thanks for the patch!

Wed, Oct 2, 9:02 PM · Dolphin
elvisangelaccio added a comment to D24369: [dolphin] Update searchbar parameters on URL change.

LGTM

Wed, Oct 2, 8:39 PM · Dolphin
elvisangelaccio added a comment to D24362: Don't count hidden files in folder item count.

I think we should include the number of hidden files only when hidden files are shown and then include them in the total count.

Wed, Oct 2, 8:28 PM · Baloo
elvisangelaccio accepted D24366: Allow stat()ing new-account link..
Wed, Oct 2, 8:20 PM · KIO GDrive
elvisangelaccio accepted D23557: Update dolphin tests following place changes D7446.
Wed, Oct 2, 8:13 PM · Dolphin
elvisangelaccio added a comment to D24353: Add actions for switching to a specific tab.

Why not assign a default shortcut? Alt + i seems to be the standard pattern for this (tried with Firefox and Chrome).

Wed, Oct 2, 8:09 PM · Dolphin
elvisangelaccio accepted D7446: [Places panel] Revamp the Recently Saved section.
Wed, Oct 2, 8:03 PM · Frameworks, Dolphin

Tue, Oct 1

elvisangelaccio committed R318:335b1f048ec1: Fix another crash if HAVE_TERMINAL is not defined (authored by elvisangelaccio).
Fix another crash if HAVE_TERMINAL is not defined
Tue, Oct 1, 8:30 PM
elvisangelaccio accepted D24342: Fix missing setDefaultShortcuts call.

Thanks

Tue, Oct 1, 8:14 PM · Dolphin

Sun, Sep 29

elvisangelaccio committed R318:35add56ea4b5: KItemListHeaderWidget: drop unnecessary remove() call (authored by elvisangelaccio).
KItemListHeaderWidget: drop unnecessary remove() call
Sun, Sep 29, 5:08 PM
elvisangelaccio added a comment to D19311: Add navigation history to forward/back buttons.

@hallas I noticed the following warning on dolphin start:

Sun, Sep 29, 5:06 PM · Dolphin
elvisangelaccio added a comment to D20532: Proof of Concept: Add double click actions to empty space in the folder view.

Sorry for the long delay. I don't think we should add an option to let the user choose what to do on double clicks.

Sun, Sep 29, 4:24 PM · Dolphin
elvisangelaccio added a comment to D24247: Expose full set of script execution options in settings window.

Oh, and there is a missing BUG: 371837 in the commit message ;)

Sun, Sep 29, 3:52 PM · Dolphin
elvisangelaccio accepted D24247: Expose full set of script execution options in settings window.

While the Confirmation tab is not perfect, I don't think that moving this setting to the Behavior or Navigation tabs would be much better.

Sun, Sep 29, 3:51 PM · Dolphin
elvisangelaccio accepted D24270: Improve consistency of settings window sidebar categories' text and icons.
Sun, Sep 29, 11:08 AM · Ark
elvisangelaccio accepted D19311: Add navigation history to forward/back buttons.

LGTM now, let's ship it so that we can move forward with the arrows patches.

Sun, Sep 29, 11:07 AM · Dolphin

Tue, Sep 24

elvisangelaccio added a comment to T9932: [ConfirmationsSettingsPage] behaviourOnLaunch setting needs a tri-state.

https://git.reviewboard.kde.org/r/129383/ had a patch for this but it never got merged. Copying the diff here in case anyone wants to take over:

Tue, Sep 24, 8:26 PM · Dolphin
elvisangelaccio added a comment to T5970: NaturalSorting option needs a place in system settings.

So should we close https://bugs.kde.org/show_bug.cgi?id=376992 ? ;)

Tue, Sep 24, 8:21 PM · Dolphin, Frameworks
elvisangelaccio requested changes to D19311: Add navigation history to forward/back buttons.
Tue, Sep 24, 8:11 PM · Dolphin

Sun, Sep 22

elvisangelaccio requested changes to D22594: [Dolphin] Open Preferred Search Tool action.
Sun, Sep 22, 8:59 PM · Documentation, Dolphin

Sat, Sep 21

elvisangelaccio accepted D23804: Add Shared Drives to GDriveUrl slave..

LGTM now. Ship it! :)

Sat, Sep 21, 6:08 PM · KIO GDrive
elvisangelaccio committed R318:c0ca8f2c79c9: [dolphin] Animate gifs on preview (authored by iasensio).
[dolphin] Animate gifs on preview
Sat, Sep 21, 2:28 PM
elvisangelaccio closed D23538: [dolphin] Animate gifs on preview.
Sat, Sep 21, 2:28 PM · Dolphin
elvisangelaccio accepted D23538: [dolphin] Animate gifs on preview.

Thanks, cool stuff :)

Sat, Sep 21, 2:28 PM · Dolphin
elvisangelaccio added inline comments to D21897: Address some issues reported by Krazy analysis.
Sat, Sep 21, 1:31 PM · Frameworks
elvisangelaccio added inline comments to D23804: Add Shared Drives to GDriveUrl slave..
Sat, Sep 21, 12:48 PM · KIO GDrive

Sep 15 2019

elvisangelaccio committed R318:cb0f6f4d9bf5: Fix failing testWindowTitle() on the KDE CI (authored by elvisangelaccio).
Fix failing testWindowTitle() on the KDE CI
Sep 15 2019, 7:00 PM
elvisangelaccio accepted D22116: [KStandardItemListWidget] Request the pixmap size we want and let the icon loader scale it.

Sorry for the delay.

Sep 15 2019, 6:51 PM · Dolphin
elvisangelaccio accepted D23874: Add KFileItemActionPlugin for copying Google URL to clipboard..

Feel free to push after fixing the last two nitpicks.

Sep 15 2019, 6:48 PM · KIO GDrive
elvisangelaccio committed R241:bcf51ae68193: Add apidox to most of KFilePlacesModel (authored by elvisangelaccio).
Add apidox to most of KFilePlacesModel
Sep 15 2019, 6:45 PM
elvisangelaccio closed D23961: Add apidox to most of KFilePlacesModel.
Sep 15 2019, 6:45 PM · Frameworks
elvisangelaccio committed R294:797763d4b4d2: KBookmark: improve addBookmark apidox (authored by elvisangelaccio).
KBookmark: improve addBookmark apidox
Sep 15 2019, 6:43 PM
elvisangelaccio closed D23955: KBookmark: improve addBookmark apidox.
Sep 15 2019, 6:43 PM · Frameworks
elvisangelaccio committed R318:681d8bb6cd13: Fix wrong window titles (authored by nazark).
Fix wrong window titles
Sep 15 2019, 6:40 PM
elvisangelaccio committed R318:79bbadb26319: Introduce test for window titles (authored by elvisangelaccio).
Introduce test for window titles
Sep 15 2019, 6:40 PM
elvisangelaccio closed D23706: Fix wrong window titles.
Sep 15 2019, 6:40 PM · Dolphin
elvisangelaccio accepted D23706: Fix wrong window titles.
Sep 15 2019, 6:40 PM · Dolphin
elvisangelaccio added a comment to T11663: Move URL Navigator into toolbar.

It seems to me that making the URL navigator buttons more discoverable and moving the URL navigator to the toolbar are two orthogonal things.

Sep 15 2019, 6:35 PM · VDG, Dolphin
elvisangelaccio added a comment to D22594: [Dolphin] Open Preferred Search Tool action.

Needs one more rebase, sorry

Sep 15 2019, 1:28 PM · Documentation, Dolphin
elvisangelaccio added a comment to D23874: Add KFileItemActionPlugin for copying Google URL to clipboard..

Almost there!

Sep 15 2019, 1:23 PM · KIO GDrive
elvisangelaccio updated the diff for D23961: Add apidox to most of KFilePlacesModel.

Mention that URLs will be stored in the QUrl::FullyEncoded string format.

Sep 15 2019, 1:09 PM · Frameworks
elvisangelaccio updated the diff for D23961: Add apidox to most of KFilePlacesModel.
  • Fixed typo
Sep 15 2019, 1:04 PM · Frameworks
elvisangelaccio requested review of D23961: Add apidox to most of KFilePlacesModel.
Sep 15 2019, 1:01 PM · Frameworks
elvisangelaccio committed R241:90c5872c08de: KFilePlacesModel: fix @since tags (authored by elvisangelaccio).
KFilePlacesModel: fix @since tags
Sep 15 2019, 10:54 AM
elvisangelaccio closed D23956: KFilePlacesModel: fix @since tags.
Sep 15 2019, 10:54 AM · Frameworks
elvisangelaccio added a comment to D23956: KFilePlacesModel: fix @since tags.

Yeah, that's my next patch ;)

Sep 15 2019, 10:50 AM · Frameworks
elvisangelaccio requested review of D23956: KFilePlacesModel: fix @since tags.
Sep 15 2019, 10:46 AM · Frameworks
elvisangelaccio added a comment to D23955: KBookmark: improve addBookmark apidox.

OK (why does this matter to the user of the class, though?)

Sep 15 2019, 10:27 AM · Frameworks
elvisangelaccio requested review of D23955: KBookmark: improve addBookmark apidox.
Sep 15 2019, 10:16 AM · Frameworks
elvisangelaccio accepted D23757: Clean up hamburger menu and viewport and single-folder context menus.
Sep 15 2019, 10:10 AM · Dolphin
elvisangelaccio added a comment to D23706: Fix wrong window titles.

Nice, this seems to do the trick :)

Sep 15 2019, 9:57 AM · Dolphin
elvisangelaccio committed R318:b4188442d184: Bring back placesitemmodeltest (authored by meven).
Bring back placesitemmodeltest
Sep 15 2019, 8:36 AM