elvisangelaccio (Elvis Angelaccio)
Developer

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 16 2015, 4:08 PM (113 w, 1 d)
Availability
Available

Recent Activity

Yesterday

elvisangelaccio committed R286:16751d8e232d: Fix display name of Generator property (authored by elvisangelaccio).
Fix display name of Generator property
Mon, Oct 16, 6:41 PM
elvisangelaccio closed D8334: Fix display name of Generator property.
Mon, Oct 16, 6:41 PM · Frameworks
elvisangelaccio created D8336: Improve apidox of KJobTrackerInterface.
Mon, Oct 16, 6:38 PM · Frameworks
elvisangelaccio committed R36:05c9fecc3229: Stop manually unregister of BatchExtract jobs (authored by elvisangelaccio).
Stop manually unregister of BatchExtract jobs
Mon, Oct 16, 6:15 PM
elvisangelaccio committed R36:5ee79a80bc01: Use KIO jobtracker from Part (authored by elvisangelaccio).
Use KIO jobtracker from Part
Mon, Oct 16, 6:15 PM
elvisangelaccio closed D8322: Stop manually unregister of BatchExtract jobs.
Mon, Oct 16, 6:15 PM · Ark
elvisangelaccio closed D8323: Use KIO jobtracker from Part.
Mon, Oct 16, 6:15 PM · Ark
elvisangelaccio committed R318:f20300256b19: Make sure we always have the Del shortcut (authored by elvisangelaccio).
Make sure we always have the Del shortcut
Mon, Oct 16, 6:00 PM
elvisangelaccio closed D7860: Make sure we always have the Del shortcut.
Mon, Oct 16, 6:00 PM
elvisangelaccio created D8334: Fix display name of Generator property.
Mon, Oct 16, 5:51 PM · Frameworks
elvisangelaccio accepted D8305: libzip: Support file permissions when creating/opening archives.
Mon, Oct 16, 5:36 PM · Ark
elvisangelaccio accepted D8299: libzip: Preserve modtime when extracting.

LGTM now.

Mon, Oct 16, 5:23 PM · Ark

Sun, Oct 15

elvisangelaccio added a comment to D8212: Be more verbose about missing providers.

I don't know if there should be a word wrap, text stretches the layout (and provider buttons) considerably. It can be scrolled as is, but still…

Sun, Oct 15, 10:33 PM
elvisangelaccio created D8323: Use KIO jobtracker from Part.
Sun, Oct 15, 10:03 PM · Ark
elvisangelaccio created D8322: Stop manually unregister of BatchExtract jobs.
Sun, Oct 15, 9:54 PM · Ark
elvisangelaccio added a comment to D3977: Fix memleak in KDynamicJobTracker, KWidgetJobTracker needs QApplication.

On a quick look the automatic unregistering based on the finished signal seems to make sense for any KJob subclass. Perhaps the change in this commit conflicts with some older code in Ark to work around the old behaviour and which does some additional manual unregistration? Or perhaps some slot in accidentally invoked 2x so the unregistration happens more than once, with the second try than failing? Wild guesses is all I have to offer, sorry. I cannot remember anything questionable about this patch, so no pointers into it, instead my initial reaction would be to look at the consumer side.

Sun, Oct 15, 9:48 PM · Frameworks
elvisangelaccio added a comment to D8208: Add Duplicate feature.

If the main/classic method of copying doesn't work well with many files, imho we should find a way to fix that. So that the use case would be ok for everyone, not just those who have the menubar visible or know the CTRL+D shortcut.

Sun, Oct 15, 9:12 PM · Dolphin
elvisangelaccio added a comment to D7130: KMoreTools: Update and fix desktopfiles.

@ngraham This patch is for knewstuff :)

Sun, Oct 15, 8:56 PM · Frameworks
elvisangelaccio created T7206: Fix threading issue with AddToArchive.
Sun, Oct 15, 5:31 PM · Ark
elvisangelaccio requested changes to D8299: libzip: Preserve modtime when extracting.
Sun, Oct 15, 4:26 PM · Ark
elvisangelaccio added a comment to D7647: Two clicks on file/folder to rename.

m_twoClicksRenamingTimer(new QTimer(this))

Sun, Oct 15, 1:47 PM
elvisangelaccio added a comment to D3977: Fix memleak in KDynamicJobTracker, KWidgetJobTracker needs QApplication.

@kossebau
After this change we get the

Sun, Oct 15, 1:44 PM · Frameworks
elvisangelaccio added inline comments to D7647: Two clicks on file/folder to rename.
Sun, Oct 15, 1:06 PM
elvisangelaccio added inline comments to D7647: Two clicks on file/folder to rename.
Sun, Oct 15, 12:27 PM
elvisangelaccio added inline comments to D7647: Two clicks on file/folder to rename.
Sun, Oct 15, 9:51 AM
elvisangelaccio requested changes to D7647: Two clicks on file/folder to rename.
In D7647#155581, @rkflx wrote:

I likely wanted to just give focus back to Dolphin, rather than start a renaming operation.

On the other hand, executing actions when giving focus is already happening today, e.g. activating Dolphin by clicking on a folder will enter this folder. Shouldn't we rather be consistent here?

Sun, Oct 15, 9:49 AM
elvisangelaccio added a comment to D8208: Add Duplicate feature.

Thanks for this patch, but I don't think we should add another action for something that can be already accomplished in two different ways (copy/paste, CTRL+drop).

Sun, Oct 15, 9:23 AM · Dolphin
elvisangelaccio added a comment to D7647: Two clicks on file/folder to rename.

I do have another comment: if Dolphin loses focus the two clicks renaming should be aborted:

Sun, Oct 15, 8:57 AM
elvisangelaccio added a comment to D8303: Show Date Modified information by default in Dolphin's Information Panel and Tooltips.

I guess +1 from me. Infopanel and tooltips are disabled by default anyway, so it's not a big deal if we also show the mtime there.

Sun, Oct 15, 8:46 AM · Dolphin

Sat, Oct 14

elvisangelaccio added a comment to D7860: Make sure we always have the Del shortcut.

Ping? I'll push in a week unless there are objections.

Sat, Oct 14, 5:58 PM
elvisangelaccio accepted D8299: libzip: Preserve modtime when extracting.
Sat, Oct 14, 5:00 PM · Ark
elvisangelaccio accepted D8294: Improve layout in previewer.
Sat, Oct 14, 2:20 PM · Ark
elvisangelaccio added inline comments to D8294: Improve layout in previewer.
Sat, Oct 14, 2:13 PM · Ark
elvisangelaccio committed R318:c58226ce4f40: Fix Q_OS_WIN ifdef (authored by elvisangelaccio).
Fix Q_OS_WIN ifdef
Sat, Oct 14, 10:50 AM
elvisangelaccio committed R318:7787f080678f: Fix build on Windows (authored by elvisangelaccio).
Fix build on Windows
Sat, Oct 14, 10:37 AM
elvisangelaccio accepted D8288: Increase max limit for archive volumes.
Sat, Oct 14, 9:16 AM · Ark

Thu, Oct 12

elvisangelaccio requested changes to D8212: Be more verbose about missing providers.

I wonder how it would look with KMessageWidgets rather than QLabels. Could you try this change and attach another screenshot?

Thu, Oct 12, 9:42 PM
elvisangelaccio committed R318:bd47eb2e6d80: Don't block unmounting when terminal panel's cwd is the mountpoint (authored by martonmiklos).
Don't block unmounting when terminal panel's cwd is the mountpoint
Thu, Oct 12, 9:25 PM
elvisangelaccio closed D7847: Don't block unmounting when terminal panel's cwd is the mountpoint.
Thu, Oct 12, 9:25 PM · Dolphin
elvisangelaccio accepted D7847: Don't block unmounting when terminal panel's cwd is the mountpoint.
Thu, Oct 12, 9:22 PM · Dolphin
elvisangelaccio added a comment to T7185: Icon for kio-stash action.

+1 for the one with the clipboard, I like it.

Thu, Oct 12, 7:01 PM · Dolphin, VDG
elvisangelaccio updated the diff for D7520: Fix icon of KStandardAction::MoveToTrash.
  • Switched from user-trash to trash-empty (discussed with @andreaska in person).
Thu, Oct 12, 9:27 AM · Frameworks
elvisangelaccio created T7189: Search results should be organized in folders.
Thu, Oct 12, 9:12 AM · Dolphin
elvisangelaccio created T7187: Activities context menu action should be hidden if there is only one activity.
Thu, Oct 12, 9:12 AM · Dolphin
elvisangelaccio created T7185: Icon for kio-stash action.
Thu, Oct 12, 9:12 AM · Dolphin, VDG

Wed, Oct 11

elvisangelaccio added a comment to T7040: Drop KFilePlacesModel fork.

There is a patch for the grouping in D8243

Wed, Oct 11, 9:23 PM · Frameworks, Dolphin
elvisangelaccio requested changes to D7847: Don't block unmounting when terminal panel's cwd is the mountpoint.
Wed, Oct 11, 9:20 PM · Dolphin
elvisangelaccio accepted D7130: KMoreTools: Update and fix desktopfiles.

I had tested the patch and it was fixing the bug.
I'm fine with this as long as @gregormi volunteers to maintain this code updated (and eventually to switch to a better design, if possible).

Wed, Oct 11, 8:54 PM · Frameworks

Mon, Oct 9

elvisangelaccio added a comment to D8212: Be more verbose about missing providers.

Can you attach one or more screenshots that show the changes in the UI? Thanks!

Mon, Oct 9, 9:03 PM

Fri, Oct 6

elvisangelaccio committed R40:0d662631e25c: Fix location of Open action in the toolbar. (authored by elvisangelaccio).
Fix location of Open action in the toolbar.
Fri, Oct 6, 2:50 PM
elvisangelaccio closed D8142: Fix location of Open action on the toolbar..
Fri, Oct 6, 2:50 PM · Kate

Thu, Oct 5

elvisangelaccio added a comment to D8142: Fix location of Open action on the toolbar..

Does the file template plugin still exist? If so, did you test this?

Thu, Oct 5, 6:38 PM · Kate
elvisangelaccio added reviewers for D8142: Fix location of Open action on the toolbar.: cullmann, dhaumann.
Thu, Oct 5, 3:07 PM · Kate

Wed, Oct 4

elvisangelaccio accepted D8132: Move Folders item closer to the top.
Wed, Oct 4, 2:45 PM
elvisangelaccio updated subscribers of D8142: Fix location of Open action on the toolbar..
Wed, Oct 4, 2:41 PM · Kate
elvisangelaccio added a reviewer for D8142: Fix location of Open action on the toolbar.: Kate.
Wed, Oct 4, 2:38 PM · Kate
elvisangelaccio created D8142: Fix location of Open action on the toolbar..
Wed, Oct 4, 2:38 PM · Kate

Tue, Oct 3

elvisangelaccio committed R318:60ef0fc76b82: Add option to only search for folders (authored by xyquadrat).
Add option to only search for folders
Tue, Oct 3, 9:33 PM
elvisangelaccio added a comment to D8119: Add "Folders" to Dolphin's search type panel.

Well as long as one of them gets in, I'm happy! :) I slightly prefer my patch since I think the more natural place for Folders is closer to the beginning than the end, but I won't block anything on that.

Tue, Oct 3, 9:14 PM
elvisangelaccio added a comment to D8119: Add "Folders" to Dolphin's search type panel.

There is already: https://git.reviewboard.kde.org/r/130159/

Tue, Oct 3, 12:52 PM

Sun, Oct 1

elvisangelaccio requested changes to D7847: Don't block unmounting when terminal panel's cwd is the mountpoint.

Thanks for the updated diff, please fix the inline issues.

Sun, Oct 1, 9:37 PM · Dolphin

Sat, Sep 30

elvisangelaccio requested changes to D7539: Dolphin - Add autoplay feature for media files.

@ngraham needs some more work, marking it as such.

Sat, Sep 30, 4:47 PM · KDE Applications, Dolphin
elvisangelaccio committed R219:b0b58b2f4598: Bump version (authored by elvisangelaccio).
Bump version
Sat, Sep 30, 3:14 PM
elvisangelaccio added inline comments to D8075: Fix build with Qt 5.10.
Sat, Sep 30, 2:50 PM
elvisangelaccio added a reviewer for D8064: Correct installation of start_kdeinit when DESTDIR and libcap are used together: dfaure.
Sat, Sep 30, 2:43 PM · Frameworks
elvisangelaccio added inline comments to D8075: Fix build with Qt 5.10.
Sat, Sep 30, 2:38 PM

Fri, Sep 29

elvisangelaccio added a comment to D7860: Make sure we always have the Del shortcut.

Ping?

Fri, Sep 29, 8:55 PM
elvisangelaccio committed R304:d967bd9e9345: Properly create KPixmapSequence (authored by elvisangelaccio).
Properly create KPixmapSequence
Fri, Sep 29, 8:44 PM
elvisangelaccio closed D8000: Properly create KPixmapSequence.
Fri, Sep 29, 8:43 PM · Frameworks

Wed, Sep 27

elvisangelaccio committed R219:43005ddc64c7: Merge branch '1.2' (authored by elvisangelaccio).
Merge branch '1.2'
Wed, Sep 27, 9:38 PM
elvisangelaccio committed R219:0155339ce363: Fix build against latest libkgapi (authored by elvisangelaccio).
Fix build against latest libkgapi
Wed, Sep 27, 9:37 PM
elvisangelaccio committed R219:9f8a412c0217: Usage of kdoctools macros means we now require kdoctools to build. (authored by bcooksley).
Usage of kdoctools macros means we now require kdoctools to build.
Wed, Sep 27, 9:37 PM

Tue, Sep 26

elvisangelaccio created D8000: Properly create KPixmapSequence.
Tue, Sep 26, 10:05 PM · Frameworks
elvisangelaccio committed R223:ca12fe50d5fd: Merge branch 'Applications/17.08' (authored by elvisangelaccio).
Merge branch 'Applications/17.08'
Tue, Sep 26, 9:59 PM
elvisangelaccio committed R223:1364d0e97b22: Properly create KPixmapSequence (authored by elvisangelaccio).
Properly create KPixmapSequence
Tue, Sep 26, 9:54 PM
elvisangelaccio closed D7996: Properly create KPixmapSequence.
Tue, Sep 26, 9:54 PM · Okular
elvisangelaccio added a comment to D7996: Properly create KPixmapSequence.

The weird thing is that I can't find the change with git blame. Shouldn't we just restore the old implementation?

Tue, Sep 26, 9:51 PM · Okular
elvisangelaccio added a comment to D7996: Properly create KPixmapSequence.
In D7996#149273, @aacid wrote:

Whoever decided to change from iconName to fullpath deserves some punishment for having a class constructor that has exactly signature but behaves totally different.

every single instance is broken
https://lxr.kde.org/source/frameworks/kpeople/src/widgets/mergedialog.cpp#0082
https://lxr.kde.org/source/frameworks/knewstuff/src/uploaddialog.cpp#0147
https://lxr.kde.org/source/calligra/krita/libs/ui/widgets/kis_cie_tongue_widget.cpp#0162
https://lxr.kde.org/source/extragear/base/nepomuk-webminer/src/lib/ui/fetcherdialog.cpp#0140

meh, i'll forget this to make my life better.

Tue, Sep 26, 9:39 PM · Okular
elvisangelaccio added a reviewer for D7996: Properly create KPixmapSequence: Okular.
Tue, Sep 26, 5:12 PM · Okular
elvisangelaccio created D7996: Properly create KPixmapSequence.
Tue, Sep 26, 5:12 PM · Okular

Mon, Sep 25

elvisangelaccio added inline comments to D7986: Add appdata for Filelight.
Mon, Sep 25, 9:28 PM

Sat, Sep 23

elvisangelaccio committed R98:8e835747b9df: Merge branch 'Plasma/5.11' (authored by elvisangelaccio).
Merge branch 'Plasma/5.11'
Sat, Sep 23, 11:45 AM
elvisangelaccio committed R98:f0ac1407a95c: Don't show scrollbar steppers (authored by elvisangelaccio).
Don't show scrollbar steppers
Sat, Sep 23, 10:57 AM
elvisangelaccio committed R98:0ef85af524bb: Fix background-image warning (authored by elvisangelaccio).
Fix background-image warning
Sat, Sep 23, 10:57 AM
elvisangelaccio closed D7836: Fix background-image warning.
Sat, Sep 23, 10:57 AM · Plasma
elvisangelaccio closed D7835: Don't show scrollbar steppers.
Sat, Sep 23, 10:57 AM · Plasma
elvisangelaccio added a comment to D7835: Don't show scrollbar steppers.

Ping?

Sat, Sep 23, 10:10 AM · Plasma
elvisangelaccio added a comment to D7944: Pre-select navigation bar URL when clicking on it to enter edit mode.

You're right that this improves one workflow and impairs another, but the way I see it, the patch simply brings consistency with the behavior you get if you hit ctrl-L/Replace Location.

Sat, Sep 23, 8:29 AM · Frameworks

Fri, Sep 22

elvisangelaccio added a comment to D7944: Pre-select navigation bar URL when clicking on it to enter edit mode.

The linked bug looks wrong.

Fri, Sep 22, 9:42 PM · Frameworks
elvisangelaccio added a comment to D7446: Add a Recent Documents places item to Dolphin and file pickers by default.

Yeah I also find weird to see weblinks in there. Maybe if we call it "History" would be a bit better (and it would also match the History tab in Kickoff).

Fri, Sep 22, 9:28 PM · Frameworks, Dolphin

Thu, Sep 21

elvisangelaccio added a comment to D7929: [WIP] Add new Column View option to KDirOperator.

I'm not sure if it's a good idea to fork QColumnView in KIO. Is it not possible to contribute the changes upstream?

Thu, Sep 21, 9:35 PM · Frameworks
elvisangelaccio accepted D7855: Fix tags KIO-slave protocol description.
Thu, Sep 21, 9:29 PM · Frameworks
elvisangelaccio added a comment to D7914: Select and scroll to previous folder when going Up.
Thu, Sep 21, 9:28 PM · Dolphin

Tue, Sep 19

elvisangelaccio created T7040: Drop KFilePlacesModel fork.
Tue, Sep 19, 5:05 PM · Frameworks, Dolphin

Mon, Sep 18

elvisangelaccio added a comment to D6312: Keep renamed file(s) in view.

@elvisangelaccio: So I was thinking of using KIO::FileUndoManager::undoJobFinished but it unfortunately provides no details as to what job was undone.
A possible option would be to keep the last job recorded so we have the name that the undo-ed item will have after reverting, but this is just hacky and doesn't support more than 1 action. I think best would be if job information was passed from KIO::FileUndoManager and then Dolphin could leverage it. I also tried to use selectionManager but to no avail.

Mon, Sep 18, 9:30 PM · Dolphin
elvisangelaccio created T7025: Increase upper limit for volumes.
Mon, Sep 18, 8:12 AM · Ark

Sun, Sep 17

elvisangelaccio added a comment to D7847: Don't block unmounting when terminal panel's cwd is the mountpoint.

I'm not sure I agree with this patch.
A standard behavior in other filemanagers when umounting a device is to redirect to the view from the device URL to the home URL.
So imho this patch is using the wrong approach: instead of the mainwindow telling the terminal panel to go to the home, it should be the mainwindow the one that changes its URL to the home.

Sun, Sep 17, 5:20 PM · Dolphin
elvisangelaccio closed T5986: Auto-update bugzilla project versions as Resolved.

@alexeymin Yep, definitely. Thanks for the reminder!

Sun, Sep 17, 10:42 AM · KDE Applications
elvisangelaccio created D7860: Make sure we always have the Del shortcut.
Sun, Sep 17, 10:15 AM
elvisangelaccio committed R318:49396318f0f3: Merge branch 'Applications/17.08' (authored by elvisangelaccio).
Merge branch 'Applications/17.08'
Sun, Sep 17, 10:01 AM