elvisangelaccio (Elvis Angelaccio)
Developer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Aug 16 2015, 4:08 PM (224 w, 6 d)
Availability
Available

Recent Activity

Sun, Dec 1

elvisangelaccio accepted D25615: Refactoring to reduce size of openItemContextMenu and add the ContextType TimelineOrSearchContext.
Sun, Dec 1, 10:17 PM · Dolphin
elvisangelaccio added inline comments to D25615: Refactoring to reduce size of openItemContextMenu and add the ContextType TimelineOrSearchContext.
Sun, Dec 1, 11:16 AM · Dolphin

Thu, Nov 28

elvisangelaccio committed R318:26f0e55f84b4: Merge branch 'release/19.12' (authored by elvisangelaccio).
Merge branch 'release/19.12'
Thu, Nov 28, 9:42 PM
elvisangelaccio committed R318:089a05b4edfd: Force dbus introspection on the Dolphin_1 object (authored by elvisangelaccio).
Force dbus introspection on the Dolphin_1 object
Thu, Nov 28, 8:59 PM
elvisangelaccio closed D25510: Force dbus introspection on the Dolphin_1 object.
Thu, Nov 28, 8:59 PM · Dolphin
elvisangelaccio added a comment to D25260: fix(search): Fix baloo searchString parsing.

@elvisangelaccio, @bruns, if there is no strong objections, I would like to push this fix to release/19.12 today, before the RC tagging

Thu, Nov 28, 8:51 PM · Dolphin
elvisangelaccio added a comment to D25565: Optimize ArchiveModel::cleanFileName.

Interesting. How did you test this? Just opening an archive?

Thu, Nov 28, 8:50 PM · Ark
elvisangelaccio accepted D25536: [extractthere] Don't link against KParts.
Thu, Nov 28, 8:45 PM · Ark
elvisangelaccio accepted D25535: [kerfuffle] Don't link against KService.

Thanks

Thu, Nov 28, 8:44 PM · Ark

Wed, Nov 27

elvisangelaccio added a comment to D25510: Force dbus introspection on the Dolphin_1 object.

I'm going to push this tomorrow unless there are strong objections.

Wed, Nov 27, 8:50 PM · Dolphin

Mon, Nov 25

elvisangelaccio added a comment to D25378: Get icon size from QStyle instead of KIconLoader.

+1 but why only archivemodel.cpp ?

Mon, Nov 25, 9:13 PM · Ark
elvisangelaccio accepted D25527: [activities/fileitemaction] Port plugin metadata to JSON.
Mon, Nov 25, 9:05 PM · Frameworks, Dolphin
elvisangelaccio added a comment to D25510: Force dbus introspection on the Dolphin_1 object.

It looks like a hack knowing Qt algorithm, can we append the pid in the name? It looks like same, but if we have more than one instances?

Mon, Nov 25, 8:38 PM · Dolphin

Sun, Nov 24

elvisangelaccio added reviewers for D25510: Force dbus introspection on the Dolphin_1 object: feverfew, davidedmundson.
Sun, Nov 24, 6:33 PM · Dolphin
elvisangelaccio requested review of D25510: Force dbus introspection on the Dolphin_1 object.
Sun, Nov 24, 6:33 PM · Dolphin
elvisangelaccio committed R318:82e366f024cb: Fix accessibility regression on the Dolphin Control button (authored by elvisangelaccio).
Fix accessibility regression on the Dolphin Control button
Sun, Nov 24, 6:16 PM
elvisangelaccio committed R36:d86d36261b58: Merge branch 'release/19.12' (authored by elvisangelaccio).
Merge branch 'release/19.12'
Sun, Nov 24, 10:17 AM
elvisangelaccio committed R36:31cab930418b: Drop ark.cliexample debug category (authored by elvisangelaccio).
Drop ark.cliexample debug category
Sun, Nov 24, 10:14 AM

Sat, Nov 23

elvisangelaccio added a comment to D25260: fix(search): Fix baloo searchString parsing.

@bruns Ping.
We have until November 28 to get this in.

Sat, Nov 23, 11:19 AM · Dolphin
elvisangelaccio added inline comments to D25416: fix(search): Correctly parse filename and/or content search.
Sat, Nov 23, 11:16 AM · Dolphin
elvisangelaccio accepted D25463: Remove unused include.
Sat, Nov 23, 11:00 AM · Ark
elvisangelaccio added a comment to D25431: [Git] Be safer about removing files.

What about a dialog that asks the user what to do (--cache, --force, neither) and tell the user what will happen to the file?

Sat, Nov 23, 10:49 AM

Tue, Nov 19

elvisangelaccio accepted D25260: fix(search): Fix baloo searchString parsing.

LGTM.

Tue, Nov 19, 10:36 PM · Dolphin
elvisangelaccio accepted D25391: Change default completion mode to CompletionPopupAuto.
Tue, Nov 19, 8:43 PM · Dolphin

Mon, Nov 18

elvisangelaccio committed R36:cce9aac9f3bc: Merge branch 'release/19.12' (authored by elvisangelaccio).
Merge branch 'release/19.12'
Mon, Nov 18, 9:25 PM
elvisangelaccio committed R36:eea94c2fa27a: Update HACKING file (authored by elvisangelaccio).
Update HACKING file
Mon, Nov 18, 9:09 PM
elvisangelaccio accepted D25377: Don't covert icons to pixmaps multiple times.

Thanks

Mon, Nov 18, 8:47 PM · Ark

Sun, Nov 17

elvisangelaccio committed R318:6bcdb624291f: Merge branch 'release/19.12' (authored by elvisangelaccio).
Merge branch 'release/19.12'
Sun, Nov 17, 5:59 PM
elvisangelaccio committed R318:77e705ef3c9e: Fix dolphin homepage in the appstream metadata (authored by elvisangelaccio).
Fix dolphin homepage in the appstream metadata
Sun, Nov 17, 5:54 PM
elvisangelaccio added a comment to T12061: Nicer URLs for kde.org/applications.

Actually https://kde.org/applications/system/dolphin already works and redirects to https://kde.org/applications/system/org.kde.dolphin

Sun, Nov 17, 5:51 PM · Goal: All About the Apps, Websites
elvisangelaccio created T12061: Nicer URLs for kde.org/applications.
Sun, Nov 17, 5:47 PM · Goal: All About the Apps, Websites
elvisangelaccio accepted D25347: Remove dead code.
Sun, Nov 17, 5:28 PM · Dolphin
elvisangelaccio committed R318:537dc7864ae3: [Dolphin] Open Preferred Search Tool action (authored by pdabrowski).
[Dolphin] Open Preferred Search Tool action
Sun, Nov 17, 5:25 PM
elvisangelaccio closed D22594: [Dolphin] Open Preferred Search Tool action.
Sun, Nov 17, 5:25 PM · Documentation, Dolphin
elvisangelaccio accepted D22594: [Dolphin] Open Preferred Search Tool action.
Sun, Nov 17, 5:18 PM · Documentation, Dolphin
elvisangelaccio added a comment to D25242: Allow dolphin to format DateTime at later stage than KBalooRolesProvider.

Is there a reason why this was pushed only to master ?

Sun, Nov 17, 5:18 PM · Dolphin
elvisangelaccio committed R36:cdf979cd1747: Require libarchive 3.3.3 (authored by elvisangelaccio).
Require libarchive 3.3.3
Sun, Nov 17, 5:15 PM
elvisangelaccio accepted D25317: Translate MIME type description.

Please push to release/19.12 only.

Sun, Nov 17, 5:12 PM · Ark

Thu, Nov 14

elvisangelaccio accepted D25297: Add guards for m_terminalPanel.
Thu, Nov 14, 9:23 PM · Dolphin

Wed, Nov 13

elvisangelaccio added a comment to D25255: fix(search): Allow to set empty type.

Sure ;)

Wed, Nov 13, 9:52 PM · Dolphin
elvisangelaccio added a comment to D25255: fix(search): Allow to set empty type.

Sure ;)

Wed, Nov 13, 9:45 PM · Dolphin
elvisangelaccio accepted D25258: test(search): Add test case for baloo parsing model.

Please wait for @bruns approval too.

Wed, Nov 13, 9:44 PM · Dolphin
elvisangelaccio committed R318:fc5546d03b08: DolphinQuery: drop DOLPHIN_EXPORT (authored by elvisangelaccio).
DolphinQuery: drop DOLPHIN_EXPORT
Wed, Nov 13, 9:42 PM
elvisangelaccio added a comment to D11382: Add an option to show tabs from last time when Dolphin starts.

19.12 has branched so we can target 20.04 for this and have time for lots and lots of testing. Can I request a review, @elvisangelaccio?

Wed, Nov 13, 8:52 PM · Dolphin
elvisangelaccio added inline comments to D25258: test(search): Add test case for baloo parsing model.
Wed, Nov 13, 8:50 PM · Dolphin
elvisangelaccio accepted D25255: fix(search): Allow to set empty type.
Wed, Nov 13, 8:48 PM · Dolphin
elvisangelaccio accepted D25257: refactor(search): De-couple baloo URL parsing logic from UI.

Please push to the release/19.12 branch. Thanks!

Wed, Nov 13, 8:48 PM · Dolphin

Tue, Nov 12

elvisangelaccio added inline comments to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Tue, Nov 12, 11:08 PM · Dolphin
elvisangelaccio added inline comments to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Tue, Nov 12, 10:54 PM · Dolphin
elvisangelaccio added inline comments to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Tue, Nov 12, 10:27 PM · Dolphin

Mon, Nov 11

elvisangelaccio added inline comments to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Mon, Nov 11, 9:59 PM · Dolphin
elvisangelaccio requested changes to D25258: test(search): Add test case for baloo parsing model.
Mon, Nov 11, 9:54 PM · Dolphin
elvisangelaccio requested changes to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Mon, Nov 11, 9:44 PM · Dolphin

Sun, Nov 10

elvisangelaccio committed R449:2cf2d4d02912: Fixed git status retrieval splitting entries (authored by macdems).
Fixed git status retrieval splitting entries
Sun, Nov 10, 9:19 PM
elvisangelaccio closed D25187: Fixed git status retrieval splitting entries.
Sun, Nov 10, 9:19 PM
elvisangelaccio accepted D25187: Fixed git status retrieval splitting entries.

Please provide an email address so that we can commit this patch on your behalf. Thanks!

Sun, Nov 10, 8:58 PM
elvisangelaccio committed R318:fa9bd6bed5e3: Merge branch 'release/19.12' (authored by elvisangelaccio).
Merge branch 'release/19.12'
Sun, Nov 10, 9:19 AM
elvisangelaccio committed R318:2e9f6a7abf6c: PlacesItemModel: remove redundant set of properties (authored by elvisangelaccio).
PlacesItemModel: remove redundant set of properties
Sun, Nov 10, 9:05 AM
elvisangelaccio closed D25230: PlacesItemModel: remove redundant set of properties.
Sun, Nov 10, 9:05 AM · Dolphin
elvisangelaccio added a comment to T11933: Debrand KDE Applications as Release Service.

On branch naming:

"release/19.12" is not so good because such branch corresponds to multiple releases: 19.11.70 through 19.12.5.
"stable/19.12" or "development/19.12" look better to me.

Sun, Nov 10, 8:57 AM · KDE Promo, KDE Applications, Goal: All About the Apps
elvisangelaccio added a comment to T11933: Debrand KDE Applications as Release Service.

We also need to decide what to rename KDE_APPLICATIONS_VERSION_XXX in CMakeLists.txt if at all, or just pretend this is internal and noone cares

Sun, Nov 10, 8:43 AM · KDE Promo, KDE Applications, Goal: All About the Apps

Sat, Nov 9

elvisangelaccio added inline comments to D25187: Fixed git status retrieval splitting entries.
Sat, Nov 9, 10:08 PM
elvisangelaccio updated the diff for D25230: PlacesItemModel: remove redundant set of properties.

Remove qDebug line

Sat, Nov 9, 9:57 PM · Dolphin
elvisangelaccio updated the summary of D25230: PlacesItemModel: remove redundant set of properties.
Sat, Nov 9, 9:56 PM · Dolphin
elvisangelaccio requested review of D25230: PlacesItemModel: remove redundant set of properties.
Sat, Nov 9, 9:53 PM · Dolphin
elvisangelaccio committed R318:16a3aea6a629: Remove unnecessary semicolons after Q_UNUSED (authored by elvisangelaccio).
Remove unnecessary semicolons after Q_UNUSED
Sat, Nov 9, 9:11 PM
elvisangelaccio committed R318:273fc202fd66: Fix clazy non-pod-global-static warning (authored by elvisangelaccio).
Fix clazy non-pod-global-static warning
Sat, Nov 9, 9:11 PM
elvisangelaccio committed R318:3512293b9840: Fix clazy writing-to-temporary warning (authored by elvisangelaccio).
Fix clazy writing-to-temporary warning
Sat, Nov 9, 9:11 PM
elvisangelaccio committed R318:b2d4e3322acc: Fix clazy inefficient-qlist-soft warning (authored by elvisangelaccio).
Fix clazy inefficient-qlist-soft warning
Sat, Nov 9, 9:11 PM
elvisangelaccio accepted D25218: [Status Bar] Remove file status Timer, add text update delay.
Sat, Nov 9, 9:04 PM · Dolphin
elvisangelaccio accepted D25218: [Status Bar] Remove file status Timer, add text update delay.

Do we understand each other ?
Do you have an opinion about this update delay, taking into account my last comment ?
Or did you mean LGTM ?

Sat, Nov 9, 8:45 PM · Dolphin
elvisangelaccio added inline comments to D25187: Fixed git status retrieval splitting entries.
Sat, Nov 9, 6:12 PM
elvisangelaccio accepted D24911: Check zstd lzma are really available.

Feel free to push as soon as you get the answer to https://bugs.kde.org/show_bug.cgi?id=413086#c6

Sat, Nov 9, 2:40 PM · Ark
elvisangelaccio added a comment to D25218: [Status Bar] Remove file status Timer, add text update delay.

I am not so sure about this 150 ms delay.
When navigating with the keyboard, it is quite noticeable.
So in the meantime, I am gonna reduce this delay to 50 ms.

Removing it altogether might be appropriate.

Just as a reminder, the information panel delay is mostly due to technicalities : thumbnail generation and metadata extraction are costly.
Whereas here we don't have such reasons to limit text refreshing.

Sat, Nov 9, 12:47 PM · Dolphin
elvisangelaccio requested changes to D24911: Check zstd lzma are really available.
Sat, Nov 9, 9:57 AM · Ark
elvisangelaccio added a comment to D24422: [dolphin] Improve parsing of Baloo query searchString.

The problem with the original code is it mixes the model and the view.

Please do the following:

  1. Split the current code to model/view, i.e. move the "rating + filename + remainder" into a separate trivial class
  2. Populate the model class from the existing parser, populate the view from the model
  3. Add the unit test you have written (of course, no longer testing the DolphinSearchBox, but the model) (some tests have to be marked as XFAIL).
  4. Update the parser, update the XFAILs

    Splitting model/view makes it much easier to extend the searchbox later, and to e.g. reuse Baloos parser.
Sat, Nov 9, 9:35 AM · Dolphin

Nov 6 2019

elvisangelaccio added a comment to D25120: Redirect utils.kde.org to kde.org/applications/utilities.
  • According to stats.kde.org, there is only 60 visits to stats.kde.org per day (probably a 2 to 3 times more counting people using adblocker and setting do not track header)
Nov 6 2019, 8:38 PM
elvisangelaccio accepted D25028: Make the search box more compact.

Thanks

Nov 6 2019, 8:33 PM · Dolphin

Nov 3 2019

elvisangelaccio added a comment to D25057: Get rid of search "More Options" toggle button.

@iasensio Please consider applying for a developer account ;)

Nov 3 2019, 10:06 PM · Dolphin
elvisangelaccio committed R318:54bd267eb96d: Get rid of search "More Options" toggle button (authored by iasensio).
Get rid of search "More Options" toggle button
Nov 3 2019, 10:04 PM
elvisangelaccio closed D25057: Get rid of search "More Options" toggle button.
Nov 3 2019, 10:04 PM · Dolphin
elvisangelaccio accepted D25057: Get rid of search "More Options" toggle button.
Nov 3 2019, 10:04 PM · Dolphin
elvisangelaccio added inline comments to D25028: Make the search box more compact.
Nov 3 2019, 9:59 PM · Dolphin
elvisangelaccio added a reviewer for D25120: Redirect utils.kde.org to kde.org/applications/utilities: dakon.
Nov 3 2019, 2:29 PM
elvisangelaccio added a comment to T11933: Debrand KDE Applications as Release Service.

+1 for "release/19.12". IMHO it makes clear that everything committed to that branch is going into the 19.12 release.

Nov 3 2019, 1:44 PM · KDE Promo, KDE Applications, Goal: All About the Apps

Nov 2 2019

elvisangelaccio requested changes to D25028: Make the search box more compact.
Nov 2 2019, 12:14 PM · Dolphin
elvisangelaccio added a comment to D25057: Get rid of search "More Options" toggle button.

Patch looks good, but I don't see how we fix https://bugs.kde.org/show_bug.cgi?id=386754

Nov 2 2019, 12:00 PM · Dolphin

Oct 27 2019

elvisangelaccio committed R318:1c50de3b3809: New design for extended search options (authored by iasensio).
New design for extended search options
Oct 27 2019, 10:01 PM
elvisangelaccio closed D24602: New design for extended search options.
Oct 27 2019, 10:01 PM · Dolphin
elvisangelaccio accepted D24602: New design for extended search options.

I assume the VDG is fine with this even without formal approval ;)

Oct 27 2019, 9:59 PM · Dolphin

Oct 26 2019

elvisangelaccio accepted D24912: Exit the program with an error when --add or --add-to are used without urls arguments.

Thanks

Oct 26 2019, 8:45 AM · Ark
elvisangelaccio accepted D23716: When the selection is deselected, restart the keyboard search from the beginning.
Oct 26 2019, 8:32 AM · Dolphin
elvisangelaccio accepted D19989: Unmounting busy device doesn't tell who is blocking.
Oct 26 2019, 8:24 AM · Dolphin

Oct 21 2019

elvisangelaccio requested changes to D19989: Unmounting busy device doesn't tell who is blocking.
Oct 21 2019, 8:09 PM · Dolphin
elvisangelaccio added inline comments to D24422: [dolphin] Improve parsing of Baloo query searchString.
Oct 21 2019, 7:42 PM · Dolphin
elvisangelaccio committed R318:d8c11a67bd98: Disable keyboard accelerators for the tabs widget (authored by alexmi).
Disable keyboard accelerators for the tabs widget
Oct 21 2019, 7:40 PM
elvisangelaccio closed D24794: Disable keyboard accelerators for the tabs widget.
Oct 21 2019, 7:40 PM · Dolphin
elvisangelaccio accepted D24794: Disable keyboard accelerators for the tabs widget.
Oct 21 2019, 7:40 PM · Dolphin

Oct 20 2019

elvisangelaccio committed R36:9ce332406308: ArchiveView: use QMimeData::hasUrls() (authored by elvisangelaccio).
ArchiveView: use QMimeData::hasUrls()
Oct 20 2019, 3:04 PM
elvisangelaccio committed R36:79a4f1c6a561: Improve handling of remote URLs drops (authored by elvisangelaccio).
Improve handling of remote URLs drops
Oct 20 2019, 3:04 PM