elvisangelaccio (Elvis Angelaccio)
Developer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Aug 16 2015, 4:08 PM (236 w, 5 d)
Availability
Available

Recent Activity

Sun, Feb 23

elvisangelaccio added a comment to D8208: Add Duplicate feature.

Sorry for the delay, I moved to a new house. I'll resume all pending reviews soon.

Sun, Feb 23, 12:25 AM · Dolphin

Sat, Feb 1

elvisangelaccio added a comment to D26259: Fixes svn plugin issuing "mkfifo" on Windows..

Still does not apply for me.

Sat, Feb 1, 9:55 PM

Jan 26 2020

elvisangelaccio added a comment to D26259: Fixes svn plugin issuing "mkfifo" on Windows..

Patch doesn't seem to apply, can you rebase it on master please?

Jan 26 2020, 9:05 PM
elvisangelaccio added a comment to D8208: Add Duplicate feature.

I don't get why we want to start a rename operation at all, tbf.

Jan 26 2020, 4:22 PM · Dolphin
elvisangelaccio closed D26721: Fixes multiple VCS plugin calls on single directory update..
Jan 26 2020, 4:10 PM · Dolphin
elvisangelaccio committed R318:305085b58143: Fixes multiple VCS plugin calls on single directory update. (authored by nikolaik).
Fixes multiple VCS plugin calls on single directory update.
Jan 26 2020, 4:10 PM
elvisangelaccio accepted D26721: Fixes multiple VCS plugin calls on single directory update..
Jan 26 2020, 4:09 PM · Dolphin
elvisangelaccio accepted D25741: Add natural sorting and case-insensitive sorting for all role-types.

LGTM now.

Jan 26 2020, 10:51 AM · Dolphin
elvisangelaccio added inline comments to D26721: Fixes multiple VCS plugin calls on single directory update..
Jan 26 2020, 10:50 AM · Dolphin
elvisangelaccio added a comment to D26901: Resize previews and icons according to the preview widget size.

I'm still not a big fan of the huge "normal" icon, but at least now they don't look bad as in D11022.

Jan 26 2020, 10:46 AM · Dolphin
elvisangelaccio accepted D26259: Fixes svn plugin issuing "mkfifo" on Windows..

LGTM now.

Jan 26 2020, 10:06 AM

Jan 25 2020

elvisangelaccio added a comment to D15803: [KCM] Replace "Services" with more user-friendly term.

How about "Context Menu Plugins" ?

Jan 25 2020, 11:39 AM · Dolphin
elvisangelaccio added inline comments to D26259: Fixes svn plugin issuing "mkfifo" on Windows..
Jan 25 2020, 11:26 AM

Jan 19 2020

elvisangelaccio accepted D26732: Use QDesktopServices to open urls not supported by dolphin.
Jan 19 2020, 10:10 PM · Dolphin
elvisangelaccio requested changes to D26259: Fixes svn plugin issuing "mkfifo" on Windows..

I noticed the following warning if I close dolphin while kompare is still running:

Jan 19 2020, 9:51 PM
elvisangelaccio accepted D26369: (search) Fix searching tags with spaces.
Jan 19 2020, 9:37 PM · Dolphin
elvisangelaccio added a comment to T11560: Create new set of keys to replace the PIM ones.

Hi, I get the message,

Sign in with Google temporarily disabled for this app
This app has not yet been verified by Google in order to use Google Sign in.

When I use Dolphin on Manjaro Linux to access GDrive after signing in to Google.

kio-gdrive 1.2.7-1

Is this related?

Jan 19 2020, 9:32 PM · KIO GDrive
elvisangelaccio requested changes to D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again.

Haven't tried the dolphin branch yet, just a comment on the API for now.
From a quick look the patch looks good though.

Jan 19 2020, 9:30 PM · Frameworks
elvisangelaccio requested changes to D26721: Fixes multiple VCS plugin calls on single directory update..
Jan 19 2020, 9:15 PM · Dolphin
elvisangelaccio requested changes to D25741: Add natural sorting and case-insensitive sorting for all role-types.

Sorry for the delay, patch looks good but needs some polish.

Jan 19 2020, 9:09 PM · Dolphin
elvisangelaccio committed R373:3e2ea6e924d0: GSCreator: Fix hang due to calling exit() after fork() (authored by abizjak).
GSCreator: Fix hang due to calling exit() after fork()
Jan 19 2020, 8:35 PM
elvisangelaccio closed D26635: GSCreator: Fix hang due to calling exit() after fork().
Jan 19 2020, 8:35 PM
elvisangelaccio requested changes to D23505: added sorting benchmark.
Jan 19 2020, 7:23 PM · Dolphin
elvisangelaccio accepted D26635: GSCreator: Fix hang due to calling exit() after fork().

Looks safe enough to me.

Jan 19 2020, 7:16 PM
elvisangelaccio requested changes to D8208: Add Duplicate feature.

Well, that depends on the current sorting mode, right? If I have sort-by-modified then the duplicate file will jump to the top of the view even if it has the "copy" suffix rather than the "Copy of" prefix, no?

If you prepend "Copy of," then it jumps around when you're sorting by Name or Creation Date.

If you append "copy," then it only jumps around when you're sorting by Creation Date.

Jan 19 2020, 4:12 PM · Dolphin
elvisangelaccio added a comment to D26732: Use QDesktopServices to open urls not supported by dolphin.

Very nice, much simpler than D18838 ;)

Jan 19 2020, 3:11 PM · Dolphin
elvisangelaccio accepted D26669: Name the items as per HIG.
Jan 19 2020, 2:21 PM

Jan 12 2020

elvisangelaccio added a comment to D8208: Add Duplicate feature.

Normally this shouldn't happen, since this uses CopyJob which preserves the mtime of the file.

Jan 12 2020, 9:45 PM · Dolphin
elvisangelaccio added a comment to D8208: Add Duplicate feature.

I can do that, sure. But IMO there's a UX problem when you append "Copy of" to the beginning rather than the end. Imagine that you have a file that starts with a Z and you duplicate it. The duplicate appears near the top of the window because it begins with C. If the current view is scrollable, view scrolls up to the top to show you the newly duplicated file. This causes you to lose your place in the view, which could be annoying if you were planning to do something else with another adjacent file or perform another operation on the original file (perhaps to duplicate it a second time to perform some A/B testing on two duplicates with slightly different changes, for example). For this reason, I prefer the macOS behavior of appending "copy" to the end of the filename, not to the beginning.

Jan 12 2020, 6:36 PM · Dolphin
elvisangelaccio requested changes to D26259: Fixes svn plugin issuing "mkfifo" on Windows..
Jan 12 2020, 6:32 PM
elvisangelaccio added a comment to D26590: Use more conventional "Add to Places" text for that action.

I would delete those setText here and add it when the action is created around line 1328, since the text does not change anymore.

Jan 12 2020, 5:58 PM · Dolphin
elvisangelaccio accepted D26585: Get rid of -Wdeprecated-copy warning.
Jan 12 2020, 5:46 PM · Dolphin

Jan 11 2020

elvisangelaccio committed R318:10d6556373fd: Merge branch 'release/19.12' (authored by elvisangelaccio).
Merge branch 'release/19.12'
Jan 11 2020, 3:18 PM
elvisangelaccio committed R318:f729f6f5b1d1: Hide tooltip instantly on filter change (authored by pdabrowski).
Hide tooltip instantly on filter change
Jan 11 2020, 3:18 PM
elvisangelaccio closed D26576: [Dolphin] Hide tooltip instantly on filter change.
Jan 11 2020, 3:18 PM · Dolphin
elvisangelaccio accepted D26576: [Dolphin] Hide tooltip instantly on filter change.

Thanks! Going to push to 19.12.

Jan 11 2020, 3:13 PM · Dolphin
elvisangelaccio added a comment to T12308: Dolphin UI redesign.

Sorry, we can't make this an option. Moving the navigator to the toolbar would require lots of changes to the code. We can't possibly maintain both implementations, it would be a nightmare.

Jan 11 2020, 1:04 PM · Dolphin, Goal: All About the Apps, VDG
elvisangelaccio accepted D25732: Add only canonical paths to dirWatcher.

Do you have commit access?

Jan 11 2020, 12:45 PM · Dolphin
elvisangelaccio added inline comments to D26484: Add KIO::DropJobFlag to allow manually showing the menu.
Jan 11 2020, 12:40 PM · Frameworks

Jan 6 2020

elvisangelaccio added a comment to D26460: Fix warning on launch from QCommandLineParser.

Nice, thanks =)

And now about the other apps, I found out that actually there are quite a lot of apps that have this issue, not only the kcalc and the konsole.
So, there is no better option than just making one patch per app and submitting it on the phabricator, right?

Jan 6 2020, 8:41 PM
elvisangelaccio committed R353:6680ac45e36a: Merge branch 'release/19.12' (authored by elvisangelaccio).
Merge branch 'release/19.12'
Jan 6 2020, 7:47 PM
elvisangelaccio committed R353:ac05c80883dc: Fix warning on launch from QCommandLineParser (authored by nazark).
Fix warning on launch from QCommandLineParser
Jan 6 2020, 7:46 PM
elvisangelaccio closed D26460: Fix warning on launch from QCommandLineParser.
Jan 6 2020, 7:46 PM
elvisangelaccio added a comment to D26460: Fix warning on launch from QCommandLineParser.

Fixed, it was a problem on my end. I'm going to push it, thanks!

Jan 6 2020, 7:45 PM
elvisangelaccio added a comment to T12308: Dolphin UI redesign.

dolphin with breadcrumbs inside view

Jan 6 2020, 7:21 PM · Dolphin, Goal: All About the Apps, VDG
elvisangelaccio added a comment to D26460: Fix warning on launch from QCommandLineParser.

I'm afraid that I'll need a bit of help in order to do that, sorry :-(
Git tells me that my copy is up-to-date, so I think that my patch is applied on top of most recent commit.
What exactly should I do to rebase it?

Jan 6 2020, 7:07 PM
elvisangelaccio requested changes to D25732: Add only canonical paths to dirWatcher.

Just minor nitpicks, looks good otherwise.

Jan 6 2020, 3:36 PM · Dolphin
elvisangelaccio added a comment to T12308: Dolphin UI redesign.

It seems to me that moving the url navigator to the toolbar creates more problems than it solves, because of split views.

Jan 6 2020, 3:26 PM · Dolphin, Goal: All About the Apps, VDG
elvisangelaccio added a comment to D26460: Fix warning on launch from QCommandLineParser.

Can you please rebase this patch? It doesn't apply currently.

Jan 6 2020, 3:10 PM
elvisangelaccio accepted D26460: Fix warning on launch from QCommandLineParser.

Yes, the fix is correct. Feel free to submit patches for all affected apps :)

Jan 6 2020, 3:06 PM
elvisangelaccio added a comment to T11560: Create new set of keys to replace the PIM ones.

Update: Google still hasn't verified my app after months, but I noticed that the libkgapi's embedded web browser fails to meet Google's security standards anyway (too old webengine?):

Jan 6 2020, 3:00 PM · KIO GDrive
elvisangelaccio accepted D26454: Google provider: limit requested OAuth scopes.
Jan 6 2020, 1:20 PM
elvisangelaccio committed R241:bdc2df9c1735: KFilePlaceEditDialog: move logic into isIconEditable() (authored by elvisangelaccio).
KFilePlaceEditDialog: move logic into isIconEditable()
Jan 6 2020, 1:09 PM
elvisangelaccio closed D26277: KFilePlaceEditDialog: move logic into isIconEditable().
Jan 6 2020, 1:09 PM · Frameworks
elvisangelaccio accepted D17595: Upstream Dolphin's file rename dialog.
Jan 6 2020, 1:08 PM · Frameworks
elvisangelaccio added inline comments to D26448: Add KRecentFilesMenu to replace KRecentFileAction.
Jan 6 2020, 1:00 PM · Frameworks
elvisangelaccio added a comment to D26358: KIO/SMB convert kio protocol declaration to json format.

+1

Jan 6 2020, 12:49 PM · Frameworks, Dolphin
elvisangelaccio accepted D17597: Use newly-upstreamed rename dialog from KIO.
Jan 6 2020, 12:45 PM · Dolphin
elvisangelaccio added inline comments to D17595: Upstream Dolphin's file rename dialog.
Jan 6 2020, 12:44 PM · Frameworks
elvisangelaccio added inline comments to D17595: Upstream Dolphin's file rename dialog.
Jan 6 2020, 12:40 PM · Frameworks
elvisangelaccio accepted D26343: (search) Keep menu open when selecting tags.
Jan 6 2020, 12:35 PM · Dolphin
elvisangelaccio requested changes to D26369: (search) Fix searching tags with spaces.

Is it possible to add a test case in dolphinquerytest.cpp?

Jan 6 2020, 12:31 PM · Dolphin
elvisangelaccio added a comment to D26370: Port away from KIconThemes.

@nicolasfella I don't like the hardcoding of 48. If there is no clean way to port IconSize(KIconLoader::Desktop), I'd prefer to port to a different non-hardcoded size.

Jan 6 2020, 12:19 PM · Ark

Jan 2 2020

elvisangelaccio accepted D25565: Optimize ArchiveModel::cleanFileName.

Please update the commit message before pushing.

Jan 2 2020, 12:30 PM · Ark
elvisangelaccio added a comment to D26277: KFilePlaceEditDialog: move logic into isIconEditable().

Ping?

Jan 2 2020, 12:18 PM · Frameworks

Dec 29 2019

elvisangelaccio requested review of D26277: KFilePlaceEditDialog: move logic into isIconEditable().
Dec 29 2019, 6:25 PM · Frameworks
elvisangelaccio committed R241:a9ea007cf87c: KFilePlaceEditDialog: fix crash when editing the Trash place (authored by elvisangelaccio).
KFilePlaceEditDialog: fix crash when editing the Trash place
Dec 29 2019, 6:24 PM
elvisangelaccio closed D26276: KFilePlaceEditDialog: fix crash when editing the Trash place.
Dec 29 2019, 6:24 PM · Frameworks
elvisangelaccio requested review of D26276: KFilePlaceEditDialog: fix crash when editing the Trash place.
Dec 29 2019, 6:06 PM · Frameworks
elvisangelaccio added a comment to D21695: Add FindTaglib.cmake.

@heikobecker are you still interested in this patch? I can take over otherwise.

Dec 29 2019, 4:02 PM · Build System, Frameworks
elvisangelaccio added a comment to D26273: cmake: don't use taglib-config if we are cross compiling.

Longer term we probably either want to convince upstream to install cmake config files, or at least have this in ECM, a quick local grep find a handful of copies of this.

Dec 29 2019, 4:01 PM · Baloo, Frameworks

Dec 28 2019

elvisangelaccio committed R373:a6b662f0e1b6: Merge branch 'release/19.12' (authored by elvisangelaccio).
Merge branch 'release/19.12'
Dec 28 2019, 7:00 PM
elvisangelaccio committed R373:af3f38a4d8f6: Prevent division by zero and force ghostscript run (authored by elvisangelaccio).
Prevent division by zero and force ghostscript run
Dec 28 2019, 7:00 PM
elvisangelaccio added a comment to D11382: Add an option to show tabs from last time when Dolphin starts.

Fair enough.

Please note that I'm planning to rework the dbus handling in global.cpp during the christmas holidays. If you don't mind I'd wait to get that merged and then rebase this patch (which should also become simpler).

Dec 28 2019, 6:09 PM · Dolphin
elvisangelaccio accepted D26150: Clean-up DolphinFacetsWidget.

Nice cleanup!

Dec 28 2019, 6:07 PM · Dolphin
elvisangelaccio added a comment to D8208: Add Duplicate feature.

If the main/classic method of copying doesn't work well with many files, imho we should find a way to fix that. So that the use case would be ok for everyone, not just those who have the menubar visible or know the CTRL+D shortcut.

Dec 28 2019, 5:56 PM · Dolphin
elvisangelaccio added a comment to D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.

So the threshold is now 50%? Isn't that a bit too low?

Dec 28 2019, 5:40 PM · Dolphin

Dec 26 2019

elvisangelaccio committed R449:163dc0c3bfdd: "SVN Commit" action is now active on file addition. (authored by nikolaik).
"SVN Commit" action is now active on file addition.
Dec 26 2019, 6:16 PM
elvisangelaccio closed D26204: "SVN Commit" action is now active on file addition..
Dec 26 2019, 6:16 PM
elvisangelaccio accepted D26204: "SVN Commit" action is now active on file addition..

LGTM, thanks.

Dec 26 2019, 6:14 PM
elvisangelaccio accepted D26029: Rename methods on DolphinFacetsWidget.
Dec 26 2019, 6:06 PM · Dolphin
elvisangelaccio accepted D26237: Port from deprecated KIconLoader::IconSize().
Dec 26 2019, 6:05 PM · Dolphin
elvisangelaccio added inline comments to D26213: Exclude daemonized processes from Dolphin::attachToExistingInstance().
Dec 26 2019, 6:00 PM · Dolphin
elvisangelaccio updated the diff for D26213: Exclude daemonized processes from Dolphin::attachToExistingInstance().

Improve API

Dec 26 2019, 5:59 PM · Dolphin

Dec 24 2019

elvisangelaccio committed R318:61edac184249: Use non-deprecated install dir variables from ECM (authored by elvisangelaccio).
Use non-deprecated install dir variables from ECM
Dec 24 2019, 6:31 PM
elvisangelaccio added a reviewer for D26197: Display fully qualified class/namespace name as page header: ochurlaud.
Dec 24 2019, 6:21 PM · Documentation, Frameworks
elvisangelaccio added a dependent revision for D26213: Exclude daemonized processes from Dolphin::attachToExistingInstance(): D26214: Switch to generated MainWindow dbus interface.
Dec 24 2019, 5:59 PM · Dolphin
elvisangelaccio added a dependency for D26214: Switch to generated MainWindow dbus interface: D26213: Exclude daemonized processes from Dolphin::attachToExistingInstance().
Dec 24 2019, 5:59 PM · Dolphin
elvisangelaccio requested review of D26214: Switch to generated MainWindow dbus interface.
Dec 24 2019, 5:58 PM · Dolphin
elvisangelaccio requested review of D26213: Exclude daemonized processes from Dolphin::attachToExistingInstance().
Dec 24 2019, 5:55 PM · Dolphin
elvisangelaccio committed R318:224028d931bf: Rename variables to improve readability of Dolphin::attachToExistingInstance (authored by elvisangelaccio).
Rename variables to improve readability of Dolphin::attachToExistingInstance
Dec 24 2019, 5:10 PM

Dec 21 2019

elvisangelaccio accepted D26115: Fixed broken SVN Commit dialog..
Dec 21 2019, 6:21 PM
elvisangelaccio accepted D26140: Use KParts::ReadOnlyPart::localFilePath() in DolphinPart::slotOpenTerminal().
Dec 21 2019, 6:20 PM · Dolphin
elvisangelaccio added a comment to D20532: Proof of Concept: Add double click actions to empty space in the folder view.

Not in the current version, I'm afraid.

Dec 21 2019, 6:11 PM · Dolphin
elvisangelaccio accepted D25416: fix(search): Correctly parse filename and/or content search.

Go for it

Dec 21 2019, 6:05 PM · Dolphin
elvisangelaccio added a comment to D26029: Rename methods on DolphinFacetsWidget.

Do you mind splitting this into a renaming-only patch and another patch for the changes to the logic?

Dec 21 2019, 6:04 PM · Dolphin
elvisangelaccio accepted D19190: Improve scroll wheel speed by basing it on label height, not icon height.
Dec 21 2019, 5:59 PM · Dolphin

Dec 15 2019

elvisangelaccio added a comment to D11382: Add an option to show tabs from last time when Dolphin starts.

Fair enough.

Dec 15 2019, 1:20 PM · Dolphin
elvisangelaccio added a comment to D25416: fix(search): Correctly parse filename and/or content search.

LGTM otherwise.

Dec 15 2019, 1:16 PM · Dolphin
elvisangelaccio accepted D25987: Don't overload the word "Properties" to mean multiple things.
Dec 15 2019, 1:07 PM · Documentation, Dolphin