elvisangelaccio (Elvis Angelaccio)
Developer

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 16 2015, 4:08 PM (121 w, 1 d)
Availability
Available

Recent Activity

Yesterday

elvisangelaccio moved T7467: Announcement text for the Applications 17.12 release from Backlog to Review on the KDE Promo board.
Mon, Dec 11, 9:49 PM · KDE Applications, KDE Promo

Sun, Dec 10

elvisangelaccio updated the diff for D8336: Improve apidox of KJobTrackerInterface.
  • Dropped TODO, there is not enough evidence that this method should become protected.
Sun, Dec 10, 3:42 PM · Frameworks

Fri, Dec 8

elvisangelaccio committed R893:d6749776956f: Use KNewPasswordDialog for encryption (authored by elvisangelaccio).
Use KNewPasswordDialog for encryption
Fri, Dec 8, 8:02 PM
elvisangelaccio added a comment to D9242: Implemented support for hide/show groups.

It appears we still need to land D8855 first.

I do not think this is the problem since that after run: arc patch D9242. I got both changes on my tree.

Fri, Dec 8, 6:58 PM
elvisangelaccio added a comment to D9242: Implemented support for hide/show groups.

I can't apply this patch, can you please rebase it?

done

Fri, Dec 8, 6:31 PM
elvisangelaccio added a comment to D9242: Implemented support for hide/show groups.

I can't apply this patch, can you please rebase it?

Fri, Dec 8, 5:03 PM
elvisangelaccio added inline comments to D9242: Implemented support for hide/show groups.
Fri, Dec 8, 9:10 AM
elvisangelaccio accepted D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.

LGTM as well.

Fri, Dec 8, 9:04 AM

Mon, Dec 4

elvisangelaccio committed R893:42ac5bf17717: Define translation domain (authored by elvisangelaccio).
Define translation domain
Mon, Dec 4, 9:27 PM
elvisangelaccio committed R893:21b2126efbb8: Set i18n application domain (authored by elvisangelaccio).
Set i18n application domain
Mon, Dec 4, 9:27 PM

Sun, Dec 3

elvisangelaccio committed R893:518a813e605b: Fix usage with relative URLs (authored by elvisangelaccio).
Fix usage with relative URLs
Sun, Dec 3, 11:10 PM
elvisangelaccio committed R136:02524f67cc16: Bump version and changelog (authored by elvisangelaccio).
Bump version and changelog
Sun, Dec 3, 3:09 PM
elvisangelaccio accepted D8273: Change window title when searching.

LGTM now, thanks!

Sun, Dec 3, 2:55 PM · Dolphin
elvisangelaccio added a comment to D9094: Use a faster way to determine kio-stash isn't installed.

on Windows we don't have dbus

Why is it so? Craft installs and packages dbus...

Sun, Dec 3, 2:53 PM
elvisangelaccio requested changes to D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.
Sun, Dec 3, 2:52 PM

Fri, Dec 1

elvisangelaccio added a comment to D9094: Use a faster way to determine kio-stash isn't installed.

What about non-unix systems? e.g. on Windows we don't have dbus but the stash ioslave could still be functional (or maybe not, @shortstheory what do you say?)

Fri, Dec 1, 10:45 PM
elvisangelaccio accepted D9091: Use CMakePackageConfigHelpers instead of the ECM variant.
Fri, Dec 1, 10:18 PM
elvisangelaccio added inline comments to D8273: Change window title when searching.
Fri, Dec 1, 10:14 PM · Dolphin
elvisangelaccio raised the priority of T7467: Announcement text for the Applications 17.12 release from Normal to High.

Ping? Is anyone working on this?

Fri, Dec 1, 10:50 AM · KDE Applications, KDE Promo

Thu, Nov 30

elvisangelaccio added a comment to D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.

Patch doesn't apply for me (running arc patch D8855). Do you need to rebase it?

Thu, Nov 30, 10:13 PM
elvisangelaccio added inline comments to D8273: Change window title when searching.
Thu, Nov 30, 10:00 PM · Dolphin

Tue, Nov 28

elvisangelaccio added a comment to D8698: Fix KProtocoInfoTest if krusader is installed.

Is the same problem present in the non-test code? I just noticed https://bugs.kde.org/show_bug.cgi?id=384991, which seems to report a similar or identical issue.

Tue, Nov 28, 10:06 PM · Frameworks
elvisangelaccio committed R241:549fc81e8e8a: Don't check whether an empty filename exists (authored by elvisangelaccio).
Don't check whether an empty filename exists
Tue, Nov 28, 10:04 PM
elvisangelaccio closed D8697: Don't check whether an empty filename exists.
Tue, Nov 28, 10:04 PM · Frameworks
elvisangelaccio updated the diff for D8336: Improve apidox of KJobTrackerInterface.
  • Addressed comments
Tue, Nov 28, 9:59 PM · Frameworks

Mon, Nov 27

elvisangelaccio accepted D8630: Created unit test for PlacesItemModel.

Thanks!

Mon, Nov 27, 3:04 PM
elvisangelaccio added inline comments to D8630: Created unit test for PlacesItemModel.
Mon, Nov 27, 1:36 PM
elvisangelaccio added a comment to D8630: Created unit test for PlacesItemModel.

I'm getting this failure when running the test:

Mon, Nov 27, 10:43 AM

Sun, Nov 26

elvisangelaccio added reviewers for D8536: Add more hashing algorithms to KPropertiesDialog: VDG, colomar.
Sun, Nov 26, 12:26 PM · Frameworks
elvisangelaccio updated subscribers of D8536: Add more hashing algorithms to KPropertiesDialog.

As I mentioned, using only a combobox doesn't work, because the main functionality (= check integrity of downloaded files) is now harder to use.

In other hand moslty user check one of following algorithms i.e. when i check a downloaded file i validate sha256, so i selected it in combobox (if needed) then paste expected. In most of time *one* prefered algorithm is used.

Sun, Nov 26, 12:26 PM · Frameworks
elvisangelaccio added a comment to D9005: fix crash during file copy after message box warning.

If this doesn't fix bug #332948, please remove it from the BUG: keyword, otherwise it will be automatically closed when pushing this commit.

Sun, Nov 26, 9:32 AM · Frameworks

Sat, Nov 25

elvisangelaccio committed R318:11e2b186af64: Use kSqueezedTextLabel for the label text on the statusbar (authored by ahmadsamir).
Use kSqueezedTextLabel for the label text on the statusbar
Sat, Nov 25, 5:29 PM
elvisangelaccio closed D8991: Use kSqueezedTextLabel for the label text on the statusbar.
Sat, Nov 25, 5:29 PM
elvisangelaccio accepted D8991: Use kSqueezedTextLabel for the label text on the statusbar.

Oh, you're totally right. Everything looks good then, thanks for the patch!

Sat, Nov 25, 5:27 PM
elvisangelaccio committed R893:911cabe7e4f6: Introduce appstream metadata (authored by elvisangelaccio).
Introduce appstream metadata
Sat, Nov 25, 3:42 PM
elvisangelaccio requested changes to D8991: Use kSqueezedTextLabel for the label text on the statusbar.
  • To reproduced the issue of the widgets on the statusbar, we just need to remove the stretch factor from the addWidget() call, or set it to zero (default).
Sat, Nov 25, 3:30 PM
elvisangelaccio committed R893:8d0fc1c32528: Normalize signature (authored by elvisangelaccio).
Normalize signature
Sat, Nov 25, 12:46 PM
elvisangelaccio committed R893:7a431dac8f6a: Use variable for gpgme version (authored by elvisangelaccio).
Use variable for gpgme version
Sat, Nov 25, 12:46 PM
elvisangelaccio committed R893:5b3eb51374cf: Install manpage rather than docbook (authored by elvisangelaccio).
Install manpage rather than docbook
Sat, Nov 25, 12:38 PM
elvisangelaccio closed D8994: Install manpage rather than docbook.
Sat, Nov 25, 12:38 PM
elvisangelaccio committed R893:9b1104f208c2: Add .arcconfig (authored by elvisangelaccio).
Add .arcconfig
Sat, Nov 25, 12:38 PM
elvisangelaccio added inline comments to D8991: Use kSqueezedTextLabel for the label text on the statusbar.
Sat, Nov 25, 10:31 AM
elvisangelaccio added reviewers for D8994: Install manpage rather than docbook: lueck, ltoscano.
Sat, Nov 25, 10:13 AM
elvisangelaccio created D8994: Install manpage rather than docbook.
Sat, Nov 25, 10:12 AM

Fri, Nov 24

elvisangelaccio added a comment to D8988: Proofread Symmy docbook.

We probably need a manpage anyway, since this is a cli app. If we go with manpage only, would it show up in khelpcenter?

Fri, Nov 24, 10:24 PM

Thu, Nov 23

elvisangelaccio committed R893:11c066946f59: Show an error if gpg-agent is not running (authored by elvisangelaccio).
Show an error if gpg-agent is not running
Thu, Nov 23, 12:21 PM
elvisangelaccio committed R893:e19f53fe7c67: Add docbook (authored by elvisangelaccio).
Add docbook
Thu, Nov 23, 11:07 AM

Wed, Nov 22

elvisangelaccio added a comment to D8931: derive app version from kde applications release.

What about using ecm_setup_version ?

Wed, Nov 22, 11:06 AM
elvisangelaccio committed R219:eea9a8b59511: Merge branch '1.2' (authored by elvisangelaccio).
Merge branch '1.2'
Wed, Nov 22, 10:36 AM
elvisangelaccio committed R219:86e8d5767ff7: Enable translations of kaccounts subfolder (authored by elvisangelaccio).
Enable translations of kaccounts subfolder
Wed, Nov 22, 10:33 AM

Tue, Nov 21

elvisangelaccio added a comment to D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.

Please bump the minimum KIO version in CMakeLists.txt

Tue, Nov 21, 11:10 PM
elvisangelaccio accepted D8927: Elide the label text on the statusbar in the middle.

By the way, this code can probably be simplified by making m_label a KSqueezedTextLabel. Feel like doing a follow up patch? :)

Tue, Nov 21, 10:22 PM
elvisangelaccio committed R247:45599d5d7a2a: Bump kronometer stable branch (authored by elvisangelaccio).
Bump kronometer stable branch
Tue, Nov 21, 9:03 AM
elvisangelaccio committed R499:ef7d35a713f1: Bump kronometer stable branch (authored by elvisangelaccio).
Bump kronometer stable branch
Tue, Nov 21, 9:00 AM
elvisangelaccio committed R136:bb297561fd40: Fix unused warning (authored by elvisangelaccio).
Fix unused warning
Tue, Nov 21, 8:53 AM
elvisangelaccio committed R136:72354e76ece3: Add missing reference (authored by elvisangelaccio).
Add missing reference
Tue, Nov 21, 8:53 AM
elvisangelaccio committed R136:e4380b485899: Exclude krazy postfix check (authored by elvisangelaccio).
Exclude krazy postfix check
Tue, Nov 21, 8:48 AM
elvisangelaccio added a reviewer for D8920: Fixes url navigation with relative links on KUrlNavigator: dfaure.
Tue, Nov 21, 8:34 AM · Frameworks

Mon, Nov 20

elvisangelaccio added inline comments to D8785: Persist path for "Copy/Move/Link To" to config file.
Mon, Nov 20, 7:22 PM
elvisangelaccio added inline comments to D8785: Persist path for "Copy/Move/Link To" to config file.
Mon, Nov 20, 5:19 PM

Sun, Nov 19

elvisangelaccio added a comment to D8822: Fix scrolling during inline renaming causes rename of wrong file.

Cherry-picked on the stable branch.
@ngraham Next time please push bugfixes to the Applications/xx.yy branch, then merge on master.

Sun, Nov 19, 10:20 AM
elvisangelaccio committed R318:af27d5735c77: Fix scrolling during inline renaming causes rename of wrong file (authored by akrutzler).
Fix scrolling during inline renaming causes rename of wrong file
Sun, Nov 19, 10:17 AM
elvisangelaccio added a commit to T7443: Rename inline: UI glitch during scrolling with mouse wheel: R318:af27d5735c77: Fix scrolling during inline renaming causes rename of wrong file.
Sun, Nov 19, 10:17 AM · Dolphin

Sat, Nov 18

elvisangelaccio accepted D8822: Fix scrolling during inline renaming causes rename of wrong file.
Sat, Nov 18, 4:45 PM
elvisangelaccio added inline comments to D8822: Fix scrolling during inline renaming causes rename of wrong file.
Sat, Nov 18, 4:24 PM
elvisangelaccio added a comment to D8822: Fix scrolling during inline renaming causes rename of wrong file.

@rkflx Good catch :(

Sat, Nov 18, 11:39 AM
elvisangelaccio created T7467: Announcement text for the Applications 17.12 release.
Sat, Nov 18, 9:33 AM · KDE Applications, KDE Promo
elvisangelaccio committed R36:4d9abbae0a0d: Merge branch 'Applications/17.12' (authored by elvisangelaccio).
Merge branch 'Applications/17.12'
Sat, Nov 18, 9:18 AM
elvisangelaccio committed R36:52cbbd803a2f: ExtractJob: set destination URL in the job description (authored by elvisangelaccio).
ExtractJob: set destination URL in the job description
Sat, Nov 18, 9:16 AM
elvisangelaccio closed D8861: ExtractJob: set destination URL in the job description.
Sat, Nov 18, 9:16 AM · Ark
elvisangelaccio accepted D8822: Fix scrolling during inline renaming causes rename of wrong file.
Sat, Nov 18, 8:46 AM
elvisangelaccio created T7466: Drop-down menus not working with mobile browsers on Akademy website.
Sat, Nov 18, 8:36 AM · KDE Promo, Sysadmin, Akademy

Fri, Nov 17

elvisangelaccio requested changes to D8630: Created unit test for PlacesItemModel.
Fri, Nov 17, 12:48 PM
elvisangelaccio created D8861: ExtractJob: set destination URL in the job description.
Fri, Nov 17, 11:42 AM · Ark
elvisangelaccio accepted D8851: Set enable_blur_behind hint on demand..
Fri, Nov 17, 10:20 AM · Frameworks
elvisangelaccio added a comment to D8837: Fix testtrash with qtbase 5.10 beta 4.

The reason why I ask is - would it be worth setting up a parallel build against Qt 5.10 on the CI to see what else breaks test wise?

Fri, Nov 17, 10:15 AM · Frameworks

Thu, Nov 16

elvisangelaccio accepted D8846: Use KConfig::readEntry()'s default argument properly.
Thu, Nov 16, 3:38 PM
elvisangelaccio accepted D8847: Depend on KIO::PreviewJob::defaultPlugins() and KF 5.40.
Thu, Nov 16, 3:37 PM
elvisangelaccio committed R241:a208dc70c9a5: Fix build on FreeBSD (authored by elvisangelaccio).
Fix build on FreeBSD
Thu, Nov 16, 12:55 PM
elvisangelaccio closed D8841: Fix build on FreeBSD.
Thu, Nov 16, 12:55 PM · Frameworks
elvisangelaccio added a comment to D8822: Fix scrolling during inline renaming causes rename of wrong file.

Thanks for working on this.
Can you try to use the event filter in KItemListRoleEditor instead? It should be enough to also check for the QEvent::Wheel event.
It seems to work for me and the patch becomes much simpler.

Thu, Nov 16, 12:25 PM
elvisangelaccio created D8841: Fix build on FreeBSD.
Thu, Nov 16, 11:47 AM · Frameworks
elvisangelaccio committed R241:05938a167dd4: Fix testtrash with qtbase 5.10 beta 4 (authored by elvisangelaccio).
Fix testtrash with qtbase 5.10 beta 4
Thu, Nov 16, 11:14 AM
elvisangelaccio closed D8837: Fix testtrash with qtbase 5.10 beta 4.
Thu, Nov 16, 11:14 AM · Frameworks
elvisangelaccio committed R241:2353119aae8f: Fix KIO::mkpath with qtbase 5.10 beta 4 (authored by elvisangelaccio).
Fix KIO::mkpath with qtbase 5.10 beta 4
Thu, Nov 16, 11:14 AM
elvisangelaccio closed D8836: Fix KIO::mkpath with qtbase 5.10 beta 4.
Thu, Nov 16, 11:14 AM · Frameworks
elvisangelaccio updated the summary of D8836: Fix KIO::mkpath with qtbase 5.10 beta 4.
Thu, Nov 16, 10:51 AM · Frameworks
elvisangelaccio updated the diff for D8836: Fix KIO::mkpath with qtbase 5.10 beta 4.
  • Use local variables
Thu, Nov 16, 10:43 AM · Frameworks
elvisangelaccio updated the diff for D8836: Fix KIO::mkpath with qtbase 5.10 beta 4.
  • Fix also mkpathjobtest and fileundomanagertest
Thu, Nov 16, 10:27 AM · Frameworks
elvisangelaccio added a comment to D8837: Fix testtrash with qtbase 5.10 beta 4.

Elvis, how many other issues like this do we expect to crop up due to Qt 5.10?

Thu, Nov 16, 10:16 AM · Frameworks
elvisangelaccio created D8837: Fix testtrash with qtbase 5.10 beta 4.
Thu, Nov 16, 10:00 AM · Frameworks
elvisangelaccio created D8836: Fix KIO::mkpath with qtbase 5.10 beta 4.
Thu, Nov 16, 9:46 AM · Frameworks

Wed, Nov 15

elvisangelaccio removed a reviewer for D7440: Turn on Dolphin icon previews by default: KDE Applications.
Wed, Nov 15, 5:29 PM · Dolphin
elvisangelaccio accepted D7440: Turn on Dolphin icon previews by default.
Wed, Nov 15, 5:29 PM · Dolphin

Tue, Nov 14

elvisangelaccio committed R36:ae758226b8b6: ArkViewer: close on Escape (authored by elvisangelaccio).
ArkViewer: close on Escape
Tue, Nov 14, 10:46 PM
elvisangelaccio closed D8761: ArkViewer: close on Escape.
Tue, Nov 14, 10:46 PM · Ark

Mon, Nov 13

elvisangelaccio added a comment to D7440: Turn on Dolphin icon previews by default.

The Applications/17.12 branch has been created, so on master we could already depend on KIO >= 5.40. How about doing that?

Mon, Nov 13, 3:37 PM · Dolphin

Sun, Nov 12

elvisangelaccio updated the summary of D8773: Improve discoverability of drag-and-drop of toolbar actions.
Sun, Nov 12, 9:25 PM · Frameworks
elvisangelaccio updated the diff for D8773: Improve discoverability of drag-and-drop of toolbar actions.
  • Implement a global 'edit mode' that enables both kind of drags (whole toolbar + actions within the toolbar).
Sun, Nov 12, 9:23 PM · Frameworks
elvisangelaccio retitled D8698: Fix KProtocoInfoTest if krusader is installed from Fix KProtolInfoTest if krusader is installed to Fix KProtocoInfoTest if krusader is installed.
Sun, Nov 12, 8:43 PM · Frameworks