- User Since
- Aug 16 2015, 4:08 PM (140 w, 2 d)
This is indeed the proper fix, since m_primaryViewActive will be set to true again in slotViewActivated(). I also added a test case for this bug.
This will only fix the test if you have a recent enough version of KIO. I wonder if we can find a more robust solution (which we'd also need in the 18.04 branch).
Mon, Apr 23
From a quick look it seems there is something strange going on here. I'll investigate in the next days, please don't push it yet.
Sun, Apr 22
One more reason to move this stuff from the Dolphin settings into a KCM...
Sat, Apr 21
UI looks good now, but I think there is still room for improvements in the code. See inline comment.
I'm not sure I agree with this change, and afaik Windows does not show the tree view by default in its file dialogs (unless you are referring to FolderBrowserDialog from .Net)
Mon, Apr 16
Sun, Apr 15
I get a crash when I try to open the control menu:
This patch should have bumped the minimum required version of baloo-widgets.
As for D11569, make sure we don't break the konqueror test before pushing.
Yes, what I meant was to show only the "Open with" entry for folders.
Mon, Apr 9
Sun, Apr 8
Go for it!
I didn't notice that this change also affects the context menu of folders. That doesn't make much sense and just clutters the menu, imho.
I also don't see the problem of double click + selection markers and I don't understand why Folder View doesn't show them.
I don't think there is a logic bug, this is just a missing check for an off-by-one error caused by the places panel (if you hide it, the warning is gone).
Commit message also needs to be updated (it should not mention 'open in new tab' or it should say why we are ignoring it).
Sat, Apr 7
I cannot reproduce with Qt 5.11, let's see if someone else can.
I cannot reproduce the loop of FocusIn events. At step 4. there is only one searchbox (the one in the first tab), the new tab doesn't have a searchbox when I open it.
Thu, Apr 5
- Set m_renamedItems also in single-rename case
Wed, Apr 4
I'll have a look this weekend.
Tue, Apr 3
New "After" screenshot:
- Yes -> Quit Dolphin
Mon, Apr 2
Right. How about "Close All Tabs"? But I'd also be ok with "Quit Dolphin".
Ok, I was finally able to reproduce the issue. I'll investigate in the next days...
Sun, Apr 1
I have another comment on the UI: I don't understand how #name, #bname, and #ext are supposed to work.
Sat, Mar 31
There are still a few bits of code to be ported:
Can you explain how to reproduce the "scrolls to an incorrect location" issue?
I'd just remove the code and explain why in the commit message.
Fri, Mar 30
Qt minimum version for plasma-integration is 5.9 these days, so this patch should be updated.