elvisangelaccio (Elvis Angelaccio)
Developer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 16 2015, 4:08 PM (200 w, 6 h)
Availability
Available

Recent Activity

Today

elvisangelaccio requested changes to D21789: Fix tests relating to the removal of the Root Place in D15739.

I'd avoid to bump the KF5 version only because of a test.

Sun, Jun 16, 8:32 PM · Dolphin
elvisangelaccio accepted D15739: [Places panel] Don't show Root by default.
Sun, Jun 16, 8:24 PM · Frameworks
elvisangelaccio accepted D20471: Add "What's This?" to nearly everything in the main window.
Sun, Jun 16, 7:57 PM · Dolphin
elvisangelaccio updated subscribers of D21831: Move Kruler from 'Graphics' category to 'Utilities'.

I'm not sure if there are any other changes to be made.

Sun, Jun 16, 7:48 PM
elvisangelaccio edited reviewers for D21781: Fix for Tree, added: sitter; removed: KDE Applications, elvisangelaccio.
Sun, Jun 16, 7:38 PM
elvisangelaccio requested changes to D21590: Fix rubber band not going away after right-click.
Sun, Jun 16, 11:25 AM · Dolphin
elvisangelaccio added a comment to D21666: Do not match daemonized dolphin instances.

This does not actually fix https://bugs.kde.org/show_bug.cgi?id=408244:

  1. Open Dolphin
  2. Use that Dolphin window to navigate to an image
  3. Open the image in Gwenview
  4. in Gwenview, go to FileOpen Containing Folder

    Nothing happens.
Sun, Jun 16, 10:58 AM · Dolphin
elvisangelaccio committed R36:037883a7c65c: Fix ECM version comparison (authored by elvisangelaccio).
Fix ECM version comparison
Sun, Jun 16, 10:36 AM
elvisangelaccio closed D21666: Do not match daemonized dolphin instances.

Yeah it seems I should have used CCBUG: instead. D21691 will fix it.

Sun, Jun 16, 10:25 AM · Dolphin
elvisangelaccio added inline comments to D21736: Adding option to open externally called folder in a new tab.
Sun, Jun 16, 10:24 AM · Dolphin
elvisangelaccio committed R318:ff81ed60cfd7: Fix ECM version comparison (authored by elvisangelaccio).
Fix ECM version comparison
Sun, Jun 16, 10:09 AM

Mon, Jun 10

elvisangelaccio committed R318:7df5fc8edb54: Do not match daemonized dolphin instances (authored by elvisangelaccio).
Do not match daemonized dolphin instances
Mon, Jun 10, 8:20 PM
elvisangelaccio closed D21666: Do not match daemonized dolphin instances.
Mon, Jun 10, 8:20 PM · Dolphin
elvisangelaccio requested changes to D21691: Open new instance of Dolphin if no URLs are given.
Mon, Jun 10, 8:19 PM · Dolphin
elvisangelaccio added a comment to D21695: Add FindTaglib.cmake.

I'm not entirely sure about taglib-config on Windows

Mon, Jun 10, 7:55 PM · Build System, Frameworks
elvisangelaccio added a comment to D21695: Add FindTaglib.cmake.

Where does this FindTaglib.cmake come from?

Mon, Jun 10, 7:53 PM · Build System, Frameworks

Sun, Jun 9

elvisangelaccio committed R36:3560fdc58559: Merge branch 'Applications/19.04' (authored by elvisangelaccio).
Merge branch 'Applications/19.04'
Sun, Jun 9, 10:58 AM
elvisangelaccio committed R36:97bb6421e287: CreateJob: connect to progress() signal instead of KJob::percent() (authored by elvisangelaccio).
CreateJob: connect to progress() signal instead of KJob::percent()
Sun, Jun 9, 10:53 AM
elvisangelaccio closed D21686: CreateJob: connect to progress() signal instead of KJob::percent().
Sun, Jun 9, 10:53 AM · Ark
elvisangelaccio added a comment to T10159: kde.org/applications rewrite.

@jriddell Would it be possible to have https://kde.org/applications/utilities/ark instead of https://kde.org/applications/utilities/org.kde.ark?

Sun, Jun 9, 9:20 AM · KDE Applications, Website Developers, KDE Promo
elvisangelaccio triaged T11050: Improve Appstream description as Normal priority.
Sun, Jun 9, 9:15 AM · Ark
elvisangelaccio triaged T11049: Get rid of CreateJob as High priority.
Sun, Jun 9, 9:11 AM · Ark
elvisangelaccio added a comment to D21403: Fix progress info for CreateJob for non-CLI-plugins.

I'm not sure what is going on to be honest. What do you think is the more correct solution?

Sun, Jun 9, 9:06 AM · Ark
elvisangelaccio requested review of D21686: CreateJob: connect to progress() signal instead of KJob::percent().
Sun, Jun 9, 9:02 AM · Ark

Sat, Jun 8

elvisangelaccio committed R318:d886cf3c85eb: Fix container detaching (authored by elvisangelaccio).
Fix container detaching
Sat, Jun 8, 5:55 PM
elvisangelaccio updated the summary of D21666: Do not match daemonized dolphin instances.
Sat, Jun 8, 11:03 AM · Dolphin
elvisangelaccio requested review of D21666: Do not match daemonized dolphin instances.
Sat, Jun 8, 11:01 AM · Dolphin

Thu, Jun 6

elvisangelaccio accepted D21600: [DolphinContextMenu] Restore check for whether place already exists.
Thu, Jun 6, 9:50 PM · Dolphin

Wed, Jun 5

elvisangelaccio added inline comments to D21600: [DolphinContextMenu] Restore check for whether place already exists.
Wed, Jun 5, 9:35 PM · Dolphin

Tue, Jun 4

elvisangelaccio accepted D21573: Scroll when pressing PageUp/PageDown.

Thanks for the quick fix :)

Tue, Jun 4, 7:47 PM · Dolphin

Mon, Jun 3

elvisangelaccio accepted D21558: [Places Panel] Pass iconName to KFilePlaceEditDialog.
Mon, Jun 3, 7:55 PM · Dolphin
elvisangelaccio committed R318:853a95b6d5d2: Tighter match own service when trying to find suitable window to open path in. (authored by thomasp).
Tighter match own service when trying to find suitable window to open path in.
Mon, Jun 3, 7:53 PM
elvisangelaccio closed D21547: Tighter match own service when trying to find suitable window to open path in..
Mon, Jun 3, 7:53 PM · Dolphin

Sun, Jun 2

elvisangelaccio closed D16648: Open externally called files/directories in new tabs.
Sun, Jun 2, 9:51 PM · Dolphin
elvisangelaccio accepted D21547: Tighter match own service when trying to find suitable window to open path in..

Makes sense, thanks!

Sun, Jun 2, 9:51 PM · Dolphin
elvisangelaccio added a comment to D21542: Ignore Okteta part if there is an external application available.

Well, the point of the preview is that I don't need the full app if I just want to have a quick glance at some file. I don't need the full kate or the full okular if I just want to quickly see what's in a text file or in a PDF.

Sun, Jun 2, 2:55 PM · Ark
elvisangelaccio added a comment to D16648: Open externally called files/directories in new tabs.

Thanks for the feedback. We haven't tested Activities indeed, sorry about that.

Sun, Jun 2, 2:35 PM · Dolphin
elvisangelaccio planned changes to D21542: Ignore Okteta part if there is an external application available.

What is so wrong with hex editor previews? Spot your trojans while they enter your system in a zip !;)

More serious: I am not sure if users want a full-blown application started instead of the previewer. Even more if this cannot be foreseen when triggering the preview, what actually will happen.
I would rather expect no preview if there is no (wanted) previewer available. And have a dedicated "Open" instead.

Sun, Jun 2, 1:09 PM · Ark
elvisangelaccio added a comment to D21542: Ignore Okteta part if there is an external application available.

Ah, weird. Then why is okularApplication_fb.desktop associated with binaries? (even if I right-click any binary in /usr/bin from dolphin)

Sun, Jun 2, 11:06 AM · Ark
elvisangelaccio updated subscribers of D21542: Ignore Okteta part if there is an external application available.

Note: as side-effect of this patch, now binaries/libraries in an archive will open in Okular, because there is a okularapplication_fb desktop file registered with application/x-sharedlib.

Sun, Jun 2, 10:51 AM · Ark
elvisangelaccio requested review of D21542: Ignore Okteta part if there is an external application available.
Sun, Jun 2, 10:44 AM · Ark
elvisangelaccio moved T10988: [ReadWriteLibarchivePlugin] Fix memory handling (QSaveFile + ArchiveWrite) from In progress to Under review on the Ark board.
Sun, Jun 2, 8:53 AM · Ark
elvisangelaccio added a comment to T10988: [ReadWriteLibarchivePlugin] Fix memory handling (QSaveFile + ArchiveWrite).

The actual stacktrace here is fixed by dfbbc9561e, but df024e3d13 should prevent this crash from happening in the first place.

Sun, Jun 2, 8:53 AM · Ark
elvisangelaccio moved T10987: [Libarchive] Compression of a large file cannot be stopped from In progress to Under review on the Ark board.
Sun, Jun 2, 8:51 AM · Ark
elvisangelaccio added a comment to T10987: [Libarchive] Compression of a large file cannot be stopped.

Should be fixed by df024e3d13 + 3dbdac8175 + dfbbc9561e.

Sun, Jun 2, 8:51 AM · Ark
elvisangelaccio committed R36:060744c037fa: ReadWriteLibarchivePlugin: always return false if jobs are killed (authored by elvisangelaccio).
ReadWriteLibarchivePlugin: always return false if jobs are killed
Sun, Jun 2, 8:48 AM
elvisangelaccio committed R36:c1786b50741e: Part: reset UI after aborting creation of new archives (authored by elvisangelaccio).
Part: reset UI after aborting creation of new archives
Sun, Jun 2, 8:48 AM
elvisangelaccio committed R36:3dbdac817514: Simplify kill logic (authored by elvisangelaccio).
Simplify kill logic
Sun, Jun 2, 8:48 AM
elvisangelaccio committed R36:dfbbc9561e4b: ReadWriteLibarchivePlugin: call archive_write_fail on fail (authored by elvisangelaccio).
ReadWriteLibarchivePlugin: call archive_write_fail on fail
Sun, Jun 2, 8:48 AM
elvisangelaccio committed R36:3ac306f25f3a: Part: call updateWithDefaults() instead of setting an invalid index (authored by elvisangelaccio).
Part: call updateWithDefaults() instead of setting an invalid index
Sun, Jun 2, 8:48 AM
elvisangelaccio committed R36:df024e3d1375: ReadWriteLibarchivePlugin: stop calling QSaveFile::commit() on fail (authored by elvisangelaccio).
ReadWriteLibarchivePlugin: stop calling QSaveFile::commit() on fail
Sun, Jun 2, 8:48 AM
elvisangelaccio committed R36:1ef661a12e22: ReadWriteLibarchivePlugin: bring back an old TODO (authored by elvisangelaccio).
ReadWriteLibarchivePlugin: bring back an old TODO
Sun, Jun 2, 8:48 AM
elvisangelaccio committed R36:06d3264ed0df: Promote m_operationMode as protected member of ReadWriteArchiveInterface (authored by elvisangelaccio).
Promote m_operationMode as protected member of ReadWriteArchiveInterface
Sun, Jun 2, 8:48 AM
elvisangelaccio triaged T11013: Move ArchiveModel out of main thread as High priority.
Sun, Jun 2, 8:25 AM · Ark
elvisangelaccio moved T10988: [ReadWriteLibarchivePlugin] Fix memory handling (QSaveFile + ArchiveWrite) from Backlog to In progress on the Ark board.
Sun, Jun 2, 8:15 AM · Ark
elvisangelaccio moved T9105: Modernize libarchive code from Backlog to In progress on the Ark board.
Sun, Jun 2, 8:13 AM · Ark
elvisangelaccio moved T10987: [Libarchive] Compression of a large file cannot be stopped from Backlog to In progress on the Ark board.
Sun, Jun 2, 8:13 AM · Ark

Sat, Jun 1

elvisangelaccio updated the task description for T10988: [ReadWriteLibarchivePlugin] Fix memory handling (QSaveFile + ArchiveWrite).
Sat, Jun 1, 2:36 PM · Ark
elvisangelaccio accepted D21515: Make it compile without foreach.

Thanks

Sat, Jun 1, 1:29 PM · Ark
elvisangelaccio committed R36:cdb178e52bbf: ReadWriteLibarchivePlugin: simplify error check (authored by elvisangelaccio).
ReadWriteLibarchivePlugin: simplify error check
Sat, Jun 1, 11:00 AM
elvisangelaccio committed R36:408b1aaf0d55: ReadWriteLibarchivePlugin: move declaration near to usage (authored by elvisangelaccio).
ReadWriteLibarchivePlugin: move declaration near to usage
Sat, Jun 1, 11:00 AM
elvisangelaccio committed R36:4536e99add58: ReadWriteLibarchivePlugin: rename variable (authored by elvisangelaccio).
ReadWriteLibarchivePlugin: rename variable
Sat, Jun 1, 11:00 AM
elvisangelaccio updated the task description for T10988: [ReadWriteLibarchivePlugin] Fix memory handling (QSaveFile + ArchiveWrite).
Sat, Jun 1, 10:11 AM · Ark
elvisangelaccio requested changes to D21515: Make it compile without foreach.
Sat, Jun 1, 9:33 AM · Ark

Thu, May 30

elvisangelaccio committed R318:27e3907a3daf: Open externally called files/directories in new tabs (authored by feverfew).
Open externally called files/directories in new tabs
Thu, May 30, 8:46 PM
elvisangelaccio closed D16648: Open externally called files/directories in new tabs.
Thu, May 30, 8:46 PM · Dolphin
elvisangelaccio accepted D16648: Open externally called files/directories in new tabs.
Thu, May 30, 8:45 PM · Dolphin

Wed, May 29

elvisangelaccio requested changes to D16648: Open externally called files/directories in new tabs.

Sorry, one last thing: can you fix the trailing white spaces? The phabricator UI doesn't show them, but there are a lot of them (check with git diff).

Wed, May 29, 9:22 PM · Dolphin

Tue, May 28

elvisangelaccio accepted D16648: Open externally called files/directories in new tabs.

Tested also on gnome, window activation works fine also there.

Tue, May 28, 7:27 PM · Dolphin

Mon, May 27

elvisangelaccio added a comment to D16648: Open externally called files/directories in new tabs.
In D16648#470609, @zzag wrote:

Wayland clients can't raise or activate themselves (so maybe ignore that for now?).

If I recall correctly, @davidedmundson proposed a protocol (for rfc) some time ago on wayland-devel that would a wayland client to pass the focus to another client.

Mon, May 27, 7:40 PM · Dolphin
elvisangelaccio accepted D21367: kioexec: change the scary debug messages for delayed deletion.
Mon, May 27, 7:26 PM · Frameworks

Sun, May 26

elvisangelaccio committed R36:66874474a2f0: ReadWriteLibarchivePlugin: remove stale comment (authored by elvisangelaccio).
ReadWriteLibarchivePlugin: remove stale comment
Sun, May 26, 5:32 PM
elvisangelaccio added a comment to T10988: [ReadWriteLibarchivePlugin] Fix memory handling (QSaveFile + ArchiveWrite).

This is possibly due to m_tempFile and m_archiveWriter being class member (since @mvlabat's GSoC refactoring), while they used to be local variables in ReadWriteLibarchivePlugin::addFiles().

Sun, May 26, 5:15 PM · Ark
elvisangelaccio added a parent task for T10987: [Libarchive] Compression of a large file cannot be stopped: T10988: [ReadWriteLibarchivePlugin] Fix memory handling (QSaveFile + ArchiveWrite).
Sun, May 26, 5:10 PM · Ark
elvisangelaccio added a subtask for T10988: [ReadWriteLibarchivePlugin] Fix memory handling (QSaveFile + ArchiveWrite): T10987: [Libarchive] Compression of a large file cannot be stopped.
Sun, May 26, 5:10 PM · Ark
elvisangelaccio added a subtask for T9105: Modernize libarchive code: T10988: [ReadWriteLibarchivePlugin] Fix memory handling (QSaveFile + ArchiveWrite).
Sun, May 26, 5:09 PM · Ark
elvisangelaccio added a parent task for T10988: [ReadWriteLibarchivePlugin] Fix memory handling (QSaveFile + ArchiveWrite): T9105: Modernize libarchive code.
Sun, May 26, 5:09 PM · Ark
elvisangelaccio triaged T10988: [ReadWriteLibarchivePlugin] Fix memory handling (QSaveFile + ArchiveWrite) as High priority.
Sun, May 26, 5:08 PM · Ark
elvisangelaccio triaged T10987: [Libarchive] Compression of a large file cannot be stopped as High priority.
Sun, May 26, 5:02 PM · Ark
elvisangelaccio added a comment to D21403: Fix progress info for CreateJob for non-CLI-plugins.
  • Is this the correct way to solve the problem?
  • Should this connection type be used for any of the other signals?
Sun, May 26, 2:54 PM · Ark

Sat, May 25

elvisangelaccio committed R219:8188cc3c5d02: Refactor kio_gdrive to make use of new GDriveUrl functionalities (authored by barchiesi).
Refactor kio_gdrive to make use of new GDriveUrl functionalities
Sat, May 25, 5:32 PM
elvisangelaccio committed R219:ebde1f787754: Add useful functions to GDriveUrl. (authored by barchiesi).
Add useful functions to GDriveUrl.
Sat, May 25, 5:32 PM
elvisangelaccio closed D20941: Refactor kio_gdrive to make use of new GDriveUrl functionalities.
Sat, May 25, 5:32 PM · KIO GDrive
elvisangelaccio closed D20064: Add usefull functions to GDriveUrl..
Sat, May 25, 5:32 PM · KIO GDrive
elvisangelaccio accepted D20941: Refactor kio_gdrive to make use of new GDriveUrl functionalities.
Sat, May 25, 5:05 PM · KIO GDrive
elvisangelaccio accepted D20064: Add usefull functions to GDriveUrl..
Sat, May 25, 5:04 PM · KIO GDrive
elvisangelaccio accepted D21157: handle maps with multiple or single entries from Baloo.
Sat, May 25, 3:25 PM · Dolphin
elvisangelaccio added a comment to D20471: Add "What's This?" to nearly everything in the main window.

Patch looks almost ready now.

Sat, May 25, 3:20 PM · Dolphin
elvisangelaccio accepted D21177: When filter bar is focused, switch to view when tab key is pressed.
Sat, May 25, 3:01 PM · Dolphin
elvisangelaccio added inline comments to D21367: kioexec: change the scary debug messages for delayed deletion.
Sat, May 25, 2:59 PM · Frameworks
elvisangelaccio added a comment to D16648: Open externally called files/directories in new tabs.

Hmm, I just noticed that KWindowSystem::activateWindow() doesn't seem to work on Wayland.

Sat, May 25, 10:36 AM · Dolphin
elvisangelaccio added a comment to D16648: Open externally called files/directories in new tabs.

Almost there :)

Sat, May 25, 10:11 AM · Dolphin

Thu, May 23

elvisangelaccio requested changes to D16648: Open externally called files/directories in new tabs.
Thu, May 23, 8:40 PM · Dolphin
elvisangelaccio added inline comments to D21367: kioexec: change the scary debug messages for delayed deletion.
Thu, May 23, 7:52 PM · Frameworks

Sun, May 19

elvisangelaccio added inline comments to D20941: Refactor kio_gdrive to make use of new GDriveUrl functionalities.
Sun, May 19, 8:54 PM · KIO GDrive
elvisangelaccio added inline comments to D20064: Add usefull functions to GDriveUrl..
Sun, May 19, 8:48 PM · KIO GDrive
elvisangelaccio committed R236:d8ac7511993d: KNewPasswordDialog: add periods to message widgets (authored by elvisangelaccio).
KNewPasswordDialog: add periods to message widgets
Sun, May 19, 2:32 PM
elvisangelaccio accepted D20888: Adapt to LibKGAPI setFields() changes..

Please don't forget to bump kio-gdrive's KGAPI_MIN_VERSION to the new libkgapi's KGAPI_VERSION_STRING.

Sun, May 19, 11:20 AM · LibKGAPI, KIO GDrive
elvisangelaccio added a comment to D20886: Add fields standard query parameter to Job and use it in FileFetchJob..

That worked, thanks :)

Sun, May 19, 11:01 AM · KDE PIM, LibKGAPI
elvisangelaccio committed R219:373ef7d503a1: Bump version (authored by elvisangelaccio).
Bump version
Sun, May 19, 11:00 AM