- User Since
- Aug 16 2015, 4:08 PM (182 w, 6 d)
Fixes the crash for me, thanks!
Please use FEATURE: instead of BUG: in the commit message.
Looks good to me now, landing it.
@cfeck What if we use a KSqueezedTextLabel in KMessageWidget instead? That would mostly fix also the 'aaaaaaaaaaaa' case without requiring new API in QLabel.
- Added warnings
Sun, Feb 10
- Use untraslated string as fallback
You're welcome :)
Thanks. Do you have commit access?
Thanks, looks good to me now.
Thanks, that fixed the tests.
Failing test case added with 95bf2244e5b4c9fe7901fd50dd662dd514439407 (thanks for the test archive!)
Sorry but this patch breaks the following tests:
Would be nice if we manage to not keep the http link in the URL navigator, but that's probably an unrelated issue.
Thu, Feb 7
Wait, do we need to add this workaround to every popup menu around? What about 3d-party apps?
Wed, Feb 6
Tue, Feb 5
Sun, Feb 3
I'll review it soon. I want to add a test case with your test archive first; feel free to beat me to it :)
Sat, Feb 2
Also, can you please update the Summary and the Test Plan? We should remove mentions of the option (which we dropped) and we should use FEATURE: instead of BUG:.
I'm not sure if I'm testing this patch the wrong way, but it doesn't seem to work here. What I did:
Can you please rebase the patch? There is new code in dolphinmainwindowtest which needs to be adapted.
Note: this will break with older clazy versions. I'm not sure how to prevent that.
One could argue that a developer interested in clazy should probably run the latest version anyway...
I'll push in a week unless there are objections.
Tue, Jan 29
I'm also a bit puzzled: are we removing a feature in order to show an error message instead?
I prefer your previous approach: an "observer" class is not supposed to have public slots, it should react on its own when stuff happens.
@anthonyfieroni Next time please add the summary of the revision to the actual commit message. You may want to setup arc to do that.
Mon, Jan 28
Thanks. Can you share a test archive that works with this patch but doesn't without?
Sat, Jan 19
- Added set_package_properties to explain the optional feature
Jan 16 2019
Jan 15 2019
Note: I have no clue what KActivities::ResourceInstance actually does, but it doesn't seem to break anything either.
Sorry but I can't reproduce the bug you put in the commit message.
Jan 13 2019
Jan 12 2019
For the record I still think that we should add another button rather than a new option. But anyway I think we discussed this enough, let's go with the option.
What else is missing to fix #402665?
Jan 5 2019
Well ok, you seem confident enough :)
I don't know, "cursorRow" and "cursorColumn" are pretty editor-specific. I'm not sure they make sense in the KRun API.
Jan 1 2019
Dec 30 2018
Much better now, but I noticed that with webdavs:// the errore message does not show the name of the new folder: