rthomsen (Ragnar Thomsen)
Ark developer

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jul 9 2015, 3:33 PM (231 w, 19 h)
Availability
Available

Recent Activity

Jun 9 2019

rthomsen abandoned D21403: Fix progress info for CreateJob for non-CLI-plugins.

See task T11049.

Jun 9 2019, 10:07 AM · Ark
rthomsen accepted D21686: CreateJob: connect to progress() signal instead of KJob::percent().

Looks good. I tested that the progress info works for both library- and CLI-based plugins.

Jun 9 2019, 10:06 AM · Ark

Jun 2 2019

rthomsen added a comment to D21403: Fix progress info for CreateJob for non-CLI-plugins.

I also tried to add

connect(archiveInterface(), &ReadOnlyArchiveInterface::progress, this, &CreateJob::onProgress);

at the beginning of CreateJob::doWork(), without direct connection, but this only fixes the progress for libzip :/

Jun 2 2019, 9:19 AM · Ark

Jun 1 2019

rthomsen committed R36:42c8e2d8379e: clirar: Use switch-case instead of if-else (authored by rthomsen).
clirar: Use switch-case instead of if-else
Jun 1 2019, 1:15 PM

May 25 2019

rthomsen requested review of D21403: Fix progress info for CreateJob for non-CLI-plugins.
May 25 2019, 2:18 PM · Ark

May 12 2019

rthomsen committed R36:3ad7526bf9ce: Get columns to show from first file entry (authored by rthomsen).
Get columns to show from first file entry
May 12 2019, 11:10 AM
rthomsen closed D20683: Get columns to show from first file entry.
May 12 2019, 11:10 AM · Ark

May 11 2019

rthomsen updated the diff for D20683: Get columns to show from first file entry.

Implement Elvis' suggestions.

May 11 2019, 7:25 AM · Ark

Apr 19 2019

rthomsen requested review of D20683: Get columns to show from first file entry.
Apr 19 2019, 10:25 AM · Ark

Apr 11 2019

rthomsen added a comment to D20333: libzip: Fix CRC checksum display.

Thanks for submitting the patch.

Apr 11 2019, 7:13 PM · Ark

Apr 7 2019

rthomsen committed R36:3a21006fa55c: Handle locked RAR archives (authored by rthomsen).
Handle locked RAR archives
Apr 7 2019, 5:44 PM
rthomsen closed D20122: Properly handle locked RAR archives.
Apr 7 2019, 5:44 PM · Ark

Apr 6 2019

rthomsen updated the diff for D20122: Properly handle locked RAR archives.

Make ReadOnlyArchiveInterface::isLocked() public.

Apr 6 2019, 8:53 PM · Ark

Apr 4 2019

rthomsen committed R36:45fc55b914b8: clirar: Remove double backslashes in isPasswordPrompt() (authored by rthomsen).
clirar: Remove double backslashes in isPasswordPrompt()
Apr 4 2019, 6:31 PM
rthomsen added a comment to D20122: Properly handle locked RAR archives.

Ping? :)

Apr 4 2019, 6:23 PM · Ark

Mar 31 2019

rthomsen added a comment to D20122: Properly handle locked RAR archives.

I cannot open the test file...

Mimetype for filename extension ( "application/vnd.rar" ) did not match mimetype for content ( "application/x-zerosize" ). Using content-based mimetype.
Mar 31 2019, 11:34 AM · Ark
rthomsen added a comment to D20122: Properly handle locked RAR archives.

Test file:

Mar 31 2019, 11:33 AM · Ark
rthomsen added inline comments to D20122: Properly handle locked RAR archives.
Mar 31 2019, 11:32 AM · Ark
rthomsen updated the diff for D20122: Properly handle locked RAR archives.

Remove unrelated change.

Mar 31 2019, 11:31 AM · Ark
rthomsen updated the diff for D20122: Properly handle locked RAR archives.

Add unittest.

Mar 31 2019, 9:01 AM · Ark

Mar 30 2019

rthomsen requested review of D20122: Properly handle locked RAR archives.
Mar 30 2019, 11:48 AM · Ark

Mar 27 2019

rthomsen committed R36:127224bfbdbf: Merge branch 'Applications/19.04' (authored by rthomsen).
Merge branch 'Applications/19.04'
Mar 27 2019, 7:19 PM
rthomsen committed R36:ce2f7f6690be: Fix progress info for CreateJob (authored by rthomsen).
Fix progress info for CreateJob
Mar 27 2019, 7:19 PM
rthomsen closed D19953: Fix progress info for CreateJob.
Mar 27 2019, 7:19 PM · Ark

Mar 26 2019

rthomsen updated the diff for D19953: Fix progress info for CreateJob.

Use QOverload::of() so we dont require C++14.

Mar 26 2019, 5:37 AM · Ark

Mar 25 2019

rthomsen updated the diff for D19953: Fix progress info for CreateJob.

I managed to avoid adding another signal by using qOverload on the connect statement. This requires C++14 support.

Mar 25 2019, 5:13 PM · Ark

Mar 24 2019

rthomsen added a comment to D19953: Fix progress info for CreateJob.

If it is possible to somehow force Qt to connect to the signal, then the PercentFromNestedJob is not necessary.

Have you tried with the old-style connect?

This

connect(m_addJob, SIGNAL(percent(KJob*,ulong)), this, SIGNAL(percent(KJob*,ulong)));

compiles for me, but I haven't tested it.

Mar 24 2019, 4:48 PM · Ark

Mar 21 2019

rthomsen requested review of D19953: Fix progress info for CreateJob.
Mar 21 2019, 7:30 PM · Ark

Mar 20 2019

rthomsen committed R36:01289d698855: Improve performance of cliplugins (authored by rthomsen).
Improve performance of cliplugins
Mar 20 2019, 8:16 PM
rthomsen closed D19766: Improve performance of cliplugins.
Mar 20 2019, 8:16 PM · Ark

Mar 19 2019

rthomsen added inline comments to D19766: Improve performance of cliplugins.
Mar 19 2019, 7:05 PM · Ark

Mar 18 2019

rthomsen added inline comments to D19766: Improve performance of cliplugins.
Mar 18 2019, 5:50 PM · Ark
rthomsen updated the diff for D19766: Improve performance of cliplugins.

Implement Elvis' suggestions.

Mar 18 2019, 5:48 PM · Ark

Mar 15 2019

rthomsen committed R36:00d6582462fd: cli7z: Performance improvements and cleanup (authored by rthomsen).
cli7z: Performance improvements and cleanup
Mar 15 2019, 6:06 PM

Mar 14 2019

rthomsen added inline comments to D19766: Improve performance of cliplugins.
Mar 14 2019, 7:07 PM · Ark
rthomsen requested review of D19766: Improve performance of cliplugins.
Mar 14 2019, 7:05 PM · Ark

Mar 12 2019

rthomsen committed R36:24b7a8f9cb66: clirar: Performance improvements (authored by rthomsen).
clirar: Performance improvements
Mar 12 2019, 8:42 PM

Nov 6 2018

rthomsen committed R36:74c6c250e173: clizip: Insert break statement (authored by rthomsen).
clizip: Insert break statement
Nov 6 2018, 9:07 PM
rthomsen committed R36:79e3e0de4086: Fix zstd autotest on Jenkins (authored by rthomsen).
Fix zstd autotest on Jenkins
Nov 6 2018, 8:05 PM
rthomsen committed R36:c6c6b2cf2bcc: Add a missing end parenthesis (authored by rthomsen).
Add a missing end parenthesis
Nov 6 2018, 7:11 PM
rthomsen committed R36:b3db87e0e057: Update copyright year (authored by rthomsen).
Update copyright year
Nov 6 2018, 6:38 PM
rthomsen committed R36:d876ba3d9ebc: Add support for Zstd-compressed Tar-archives (authored by rthomsen).
Add support for Zstd-compressed Tar-archives
Nov 6 2018, 4:50 PM
rthomsen closed D15369: Add support for Zstd-compressed Tar-archives.
Nov 6 2018, 4:50 PM · Ark

Nov 5 2018

rthomsen updated the diff for D15369: Add support for Zstd-compressed Tar-archives.

Check for zstd executable.

Nov 5 2018, 4:21 PM · Ark

Nov 3 2018

rthomsen added inline comments to D15369: Add support for Zstd-compressed Tar-archives.
Nov 3 2018, 6:02 PM · Ark
rthomsen updated the diff for D15369: Add support for Zstd-compressed Tar-archives.

Implement suggestions.

Nov 3 2018, 6:00 PM · Ark
rthomsen updated the diff for D15369: Add support for Zstd-compressed Tar-archives.

Only enable Zstandard support if libarchive >= 3.3.3.

Nov 3 2018, 3:07 PM · Ark
rthomsen added a comment to D15369: Add support for Zstd-compressed Tar-archives.

Looks good except the version bump.

Nov 3 2018, 10:09 AM · Ark
rthomsen updated the diff for D15369: Add support for Zstd-compressed Tar-archives.

Add loadtest.

Nov 3 2018, 10:06 AM · Ark

Sep 9 2018

rthomsen closed T5450: libarchive 3.3 requires lzop to handle tar.lzo archives as Resolved.
Sep 9 2018, 10:44 AM · Ark
rthomsen closed T8081: Job::doKill should not trigger the result signal as Resolved.
Sep 9 2018, 10:43 AM · Ark
rthomsen closed T7025: Increase upper limit for volumes as Resolved.
Sep 9 2018, 10:43 AM · Ark
rthomsen closed T6575: Refactor Part::slotLoadingFinished as Resolved.
Sep 9 2018, 10:43 AM · Ark
rthomsen closed T2583: libzip plugin as Resolved.
Sep 9 2018, 10:43 AM · Ark
rthomsen closed T1984: Plugins page in Settings dialog as Resolved.
Sep 9 2018, 10:43 AM · Ark
rthomsen closed T4701: Add search function as Resolved.
Sep 9 2018, 10:43 AM · Ark
rthomsen updated the summary of D15369: Add support for Zstd-compressed Tar-archives.
Sep 9 2018, 10:39 AM · Ark
rthomsen updated the summary of D15369: Add support for Zstd-compressed Tar-archives.
Sep 9 2018, 10:31 AM · Ark
rthomsen updated the summary of D15369: Add support for Zstd-compressed Tar-archives.
Sep 9 2018, 9:55 AM · Ark
rthomsen requested review of D15369: Add support for Zstd-compressed Tar-archives.
Sep 9 2018, 9:52 AM · Ark

Oct 28 2017

rthomsen accepted D8406: libzip: more descriptive variable names.
Oct 28 2017, 11:24 AM · Ark

Oct 22 2017

rthomsen committed R36:ee5d045b058a: libzip: Add support for compression methods and levels (authored by rthomsen).
libzip: Add support for compression methods and levels
Oct 22 2017, 11:32 AM
rthomsen closed D8414: libzip: Add support for compression methods and levels.
Oct 22 2017, 11:32 AM · Ark
rthomsen updated the diff for D8414: libzip: Add support for compression methods and levels.

Follow Elvis' suggestion.

Oct 22 2017, 11:29 AM · Ark
rthomsen created D8414: libzip: Add support for compression methods and levels.
Oct 22 2017, 8:11 AM · Ark

Oct 21 2017

rthomsen accepted D8407: libzip: reduce scope of variable.
Oct 21 2017, 6:45 PM · Ark
rthomsen committed R36:16313b967cb0: libzip: Support file permissions when creating/opening archives (authored by rthomsen).
libzip: Support file permissions when creating/opening archives
Oct 21 2017, 6:43 PM
rthomsen closed D8305: libzip: Support file permissions when creating/opening archives.
Oct 21 2017, 6:43 PM · Ark
rthomsen accepted D8404: libzip: more const.
Oct 21 2017, 5:53 PM · Ark
rthomsen committed R36:a9147d82b3d1: libzip: Improve test integrity function (authored by rthomsen).
libzip: Improve test integrity function
Oct 21 2017, 5:34 PM
rthomsen closed D8400: libzip: Improve test archive function.
Oct 21 2017, 5:34 PM · Ark
rthomsen updated the diff for D8400: libzip: Improve test archive function.

Implement ELvis' suggestions.

Oct 21 2017, 5:12 PM · Ark
rthomsen created D8400: libzip: Improve test archive function.
Oct 21 2017, 4:27 PM · Ark
rthomsen committed R36:48393a65b730: Detect CRC errors when extracting w. cli7z and clizip Detect CRC errors when… (authored by rthomsen).
Detect CRC errors when extracting w. cli7z and clizip Detect CRC errors when…
Oct 21 2017, 4:13 PM
rthomsen closed D8392: Add regexps for catching bad CRC for entries.
Oct 21 2017, 4:13 PM · Ark
rthomsen updated the diff for D8392: Add regexps for catching bad CRC for entries.

Provide more useful error message.

Oct 21 2017, 4:06 PM · Ark
rthomsen added inline comments to D8305: libzip: Support file permissions when creating/opening archives.
Oct 21 2017, 2:19 PM · Ark
rthomsen added a comment to D8392: Add regexps for catching bad CRC for entries.

Libzipplugin already catches this CRC errors when extracting.

I don't get the corrupt query when opening the test archive with libzip. Do you?

Oct 21 2017, 2:16 PM · Ark
rthomsen created D8392: Add regexps for catching bad CRC for entries.
Oct 21 2017, 8:20 AM · Ark

Oct 18 2017

rthomsen updated the diff for D8305: libzip: Support file permissions when creating/opening archives.

Show file type in permissions.

Oct 18 2017, 5:15 PM · Ark

Oct 17 2017

rthomsen updated the diff for D8305: libzip: Support file permissions when creating/opening archives.

Implement permission handling in copyFiles(). This necessitated removing the in-loop emitEntryForIndex() call and instead calling list() after the entries are copied.

Oct 17 2017, 5:53 PM · Ark

Oct 16 2017

rthomsen committed R36:d688d04b7ef0: QDateTime::toSecsSinceEpoch() -> toMSecsSinceEpoch() (authored by rthomsen).
QDateTime::toSecsSinceEpoch() -> toMSecsSinceEpoch()
Oct 16 2017, 6:18 PM
rthomsen committed R36:b99bf9620f12: libzip: Preserve modtime when extracting (authored by rthomsen).
libzip: Preserve modtime when extracting
Oct 16 2017, 5:52 PM
rthomsen closed D8299: libzip: Preserve modtime when extracting.
Oct 16 2017, 5:52 PM · Ark
rthomsen accepted D8323: Use KIO jobtracker from Part.

Looks good to me :)

Oct 16 2017, 4:48 PM · Ark
rthomsen accepted D8322: Stop manually unregister of BatchExtract jobs.

This fixes the error in cli output.

Oct 16 2017, 4:11 PM · Ark

Oct 15 2017

rthomsen updated the summary of D8305: libzip: Support file permissions when creating/opening archives.
Oct 15 2017, 6:22 PM · Ark
rthomsen updated the diff for D8305: libzip: Support file permissions when creating/opening archives.

Also set permissions in archive when adding files.

Oct 15 2017, 6:18 PM · Ark
rthomsen updated the diff for D8299: libzip: Preserve modtime when extracting.

Use QFileInfo::lastModified() instead of stat().

Oct 15 2017, 6:05 PM · Ark
rthomsen added inline comments to D8299: libzip: Preserve modtime when extracting.
Oct 15 2017, 5:44 PM · Ark
rthomsen updated the diff for D8299: libzip: Preserve modtime when extracting.

Follow Elvis' suggestions.

Oct 15 2017, 5:41 PM · Ark
rthomsen created D8305: libzip: Support file permissions when creating/opening archives.
Oct 15 2017, 9:25 AM · Ark

Oct 14 2017

rthomsen updated the summary of D8299: libzip: Preserve modtime when extracting.
Oct 14 2017, 7:13 PM · Ark
rthomsen updated the test plan for D8299: libzip: Preserve modtime when extracting.
Oct 14 2017, 7:12 PM · Ark
rthomsen updated the diff for D8299: libzip: Preserve modtime when extracting.

Also restore mtime for directories. Since mtime for a dir gets updated when files/subfolders are added to it, we need to first save mtime for parentdir, then write the file/subfolder and finally restore the mtime for the parentdir.

Oct 14 2017, 7:10 PM · Ark
rthomsen created D8299: libzip: Preserve modtime when extracting.
Oct 14 2017, 4:37 PM · Ark
rthomsen moved T7025: Increase upper limit for volumes from Backlog to Done on the Ark board.
Oct 14 2017, 2:27 PM · Ark
rthomsen committed R36:f78dc3357284: Improve layout of internal previewer (authored by rthomsen).
Improve layout of internal previewer
Oct 14 2017, 2:25 PM
rthomsen closed D8294: Improve layout in previewer.
Oct 14 2017, 2:25 PM · Ark
rthomsen added inline comments to D8294: Improve layout in previewer.
Oct 14 2017, 2:18 PM · Ark