- User Since
- Feb 10 2018, 12:40 PM (84 w, 1 d)
Fri, Sep 20
As far i can it does not hold when building with kde-srcbuild : kwayland-integration was not built when building plasma-desktop or Kwin for instance.
Assuming the same logic holds, and as long as the respective maintainers of KWayland Integration and KWin are still fine with this, it can go in again.
Thu, Sep 19
Apparently my previous changes made in D23931 were overriden, I had to redo them.
Wed, Sep 18
Thanks for clarifying. I will make a followup PR for the master branch.
Tue, Sep 17
Sat, Sep 14
@pino if this is fine for you...
Update @since references
@jgrulich if you could have a second look, I improved this because my previous code could have prevented requestScan to be fired.
Add a timer per interface allowing to scan devices as soon as technically possible, rescheduling wifi scan for when it will be possible
Add a KF6 clean up todo
Fri, Sep 13
Improve code and make it cleaner
Update KIO dependency
Build with QT 5.12
Update @deprecated message to be more clear
Update since version
add recentlyused:/ bookmarks only in plasma, update following D23742 changes
I will land this soonish if no one has any objections.
Allow users to use ?type filter with /files path
Improve help text, rebase
Rebase on master, review feedback
Thu, Sep 12
Clean up and update @since
Tue, Sep 10
Btw we have quite a few CMakeLists.txt files that would need the same attention.
LGTM this fixes plasma-workspace build
Use QUrl::fromUserInput as we should have, now need D23851 to work
A plan of action would be :
- Check add recenly_used only on plasma KDE_FULL_SESSION (it can't be used outside )
Mon, Sep 9
You have a few code indentation issues, that you can take care of.
Remove unneeded friend function declarations
Thank you @luc4 for pinging again
Sun, Sep 8
Fine to me
Sat, Sep 7
7zip:/ is in fact not correct because this would make the url scheme 7zip, but a url scheme must begin with a letter .
That's too bad URL aren't not more flexible.
Fix test and implementation
Use new folder-open-recent for /locations bookmark
Is that the expected result ?
Use new folder-open-recent for /locations
Fri, Sep 6
Conditionalize the code here with version ifdefs so that people only get both new entries when using kio-extras from 19.12.0
Also it seems to me the icon is not very similar to
The thickness of the clock pen in particular.
They should be somewhat reminiscent of one another IMHO.
Add two entries to Recent 'Recent Files' and 'Recent Locations'
It would be great to have two different icons for recentlyused:/locations and recentlyused:/files.
Also I am not sure recentlyuserd:/ should use "document-open-recent-symbolic" since it is monochrone, the kio declares currently "document-open-recent".
Maybe "folder-temp" for /locations.
Any suggestion @ngraham ?
Rename constant LOCATIONS_TYPE_TAG -> DIRECTORIES_TYPE_TAG bis
Rename constant LOCATIONS_TYPE_TAG -> DIRECTORIES_TYPE_TAG
Rename locations to directories
Thu, Sep 5
Replace /folders by /locations, add some documentation
Add some const
Rephrase 'Recent Folders' to 'Recent Locations'
const QString &mimetype
Exclude files whose mimetype is not known from the files filter