meven (Méven Car)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 10 2018, 12:40 PM (101 w, 1 d)
Availability
Available

Recent Activity

Today

meven added a comment to T12551: Revamp KCM/Component chooser.

@ngraham I have added a mockup for the final kcm :


Let me know your thoughts.

Mon, Jan 20, 12:12 PM · Plasma: KCM Redesign, VDG
meven updated the task description for T12551: Revamp KCM/Component chooser.
Mon, Jan 20, 12:11 PM · Plasma: KCM Redesign, VDG
meven updated the diff for D26732: Use QDesktopServices to open urls not supported by dolphin.

Ensure the url navigator matches the current path

Mon, Jan 20, 9:43 AM · Dolphin
meven updated the summary of D26732: Use QDesktopServices to open urls not supported by dolphin.
Mon, Jan 20, 9:29 AM · Dolphin
meven updated the summary of D18838: Fix opening http links in browser.
Mon, Jan 20, 9:29 AM · Dolphin
meven updated the summary of D18838: Fix opening http links in browser.
Mon, Jan 20, 9:28 AM · Dolphin
meven updated the summary of D26690: Make "Default Applications" in mimeapps.list the preferred applications.
Mon, Jan 20, 9:25 AM · Frameworks
meven added a comment to D18778: [KRun] Fall back to reading text/html in mimeapps.list if others aren't there.

I think you can abandon this one, because 26690 is fixing this.

Mon, Jan 20, 9:25 AM · Frameworks
meven added a comment to D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default.

Too bad I missed the boat for KF 5.66 and Plasma 5.18.

Mon, Jan 20, 9:19 AM · Frameworks
meven updated the test plan for D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default.
Mon, Jan 20, 9:18 AM · Frameworks
meven updated the diff for D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default.

Clean commit

Mon, Jan 20, 9:15 AM · Frameworks
meven requested review of D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default.
Mon, Jan 20, 9:14 AM · Frameworks
meven requested review of D26781: Fix test since Konsole added icons to its actions.
Mon, Jan 20, 8:48 AM · Frameworks
meven updated the diff for D26690: Make "Default Applications" in mimeapps.list the preferred applications.

Simplify implementation of Default Applications parsing, update tests

Mon, Jan 20, 8:24 AM · Frameworks

Yesterday

meven added inline comments to D23505: added sorting benchmark.
Sun, Jan 19, 9:54 PM · Dolphin
meven added a comment to D26732: Use QDesktopServices to open urls not supported by dolphin.

Very nice, much simpler than D18838 ;)

This should fix https://bugs.kde.org/show_bug.cgi?id=372642 right?

Sun, Jan 19, 9:46 PM · Dolphin
meven updated the summary of D26732: Use QDesktopServices to open urls not supported by dolphin.
Sun, Jan 19, 9:45 PM · Dolphin

Sat, Jan 18

meven planned changes to D26690: Make "Default Applications" in mimeapps.list the preferred applications.

I'm quite confused by all this. Wouldn't it be enough to do http://www.davidfaure.fr/2020/kmimeassociations.cpp.diff ?
The modified unittest passes :-)

Sat, Jan 18, 6:44 PM · Frameworks
meven planned changes to D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs.

Really? that's not what all callers might want.
e.g. for \"free disk space\" calculation we want the real final mountpoint for that path.
If you need something else, it should be a different method, or indeed a flag

Sat, Jan 18, 6:24 PM · Frameworks
meven updated the diff for D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs.

Fix comment issues and improve syntax used

Sat, Jan 18, 6:18 PM · Frameworks
meven added inline comments to D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs.
Sat, Jan 18, 1:59 PM · Frameworks
meven updated the diff for D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs.

Use mid/lastIndexOf instead of split/join, use const assign in loop

Sat, Jan 18, 1:58 PM · Frameworks
meven added inline comments to D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs.
Sat, Jan 18, 8:28 AM · Frameworks
meven updated the diff for D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs.

Make the recursive canonical work

Sat, Jan 18, 8:28 AM · Frameworks
meven added a comment to D26580: Kicker/RecentDocuments display place's icon when resource matches one.

ping @hein
Might be good to go to plasma 5.18

Sat, Jan 18, 8:05 AM · Plasma
meven added a comment to D25741: Add natural sorting and case-insensitive sorting for all role-types.

ping @elvisangelaccio

Sat, Jan 18, 8:04 AM · Dolphin

Fri, Jan 17

meven updated the summary of D26690: Make "Default Applications" in mimeapps.list the preferred applications.
Fri, Jan 17, 5:18 PM · Frameworks
meven added a comment to D26690: Make "Default Applications" in mimeapps.list the preferred applications.
Fri, Jan 17, 5:18 PM · Frameworks
meven requested review of D26732: Use QDesktopServices to open urls not supported by dolphin.
Fri, Jan 17, 5:12 PM · Dolphin
meven added a comment to D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI.

Writing into the user's home dir is a "hack".

There are better ways for distros to set defaults (such as the global mimeapps.list) but it seems KIO ignores that... (to be checked...)

Fri, Jan 17, 4:48 PM · Plasma
meven updated the task description for T12551: Revamp KCM/Component chooser.
Fri, Jan 17, 4:10 PM · Plasma: KCM Redesign, VDG
meven added a revision to T12551: Revamp KCM/Component chooser: D26731: KCM/Component Revamp Browser config.
Fri, Jan 17, 4:09 PM · Plasma: KCM Redesign, VDG
meven added a task to D26731: KCM/Component Revamp Browser config: T12551: Revamp KCM/Component chooser.
Fri, Jan 17, 4:09 PM · Plasma
meven added inline comments to D26731: KCM/Component Revamp Browser config.
Fri, Jan 17, 4:08 PM · Plasma
meven updated the test plan for D26731: KCM/Component Revamp Browser config.
Fri, Jan 17, 4:02 PM · Plasma
meven requested review of D26731: KCM/Component Revamp Browser config.
Fri, Jan 17, 4:01 PM · Plasma
meven updated the diff for D26690: Make "Default Applications" in mimeapps.list the preferred applications.
Fri, Jan 17, 3:57 PM · Frameworks
meven updated the diff for D26690: Make "Default Applications" in mimeapps.list the preferred applications.

Review : Add an enum AddServiceFlag

Fri, Jan 17, 3:49 PM · Frameworks
meven added a comment to D26721: Fixes multiple VCS plugin calls on single directory update..

Seems fine

Fri, Jan 17, 11:32 AM · Dolphin
meven added inline comments to D26721: Fixes multiple VCS plugin calls on single directory update..
Fri, Jan 17, 11:31 AM · Dolphin
meven added inline comments to D26705: KCM/Component Revamp Terminal Emulator UI.
Fri, Jan 17, 10:39 AM · Plasma
meven added inline comments to D26714: KCM/Component Revamp FileManager UI.
Fri, Jan 17, 10:18 AM · Plasma
meven updated the diff for D26705: KCM/Component Revamp Terminal Emulator UI.

Clean two bad lines

Fri, Jan 17, 10:00 AM · Plasma
meven added inline comments to D26705: KCM/Component Revamp Terminal Emulator UI.
Fri, Jan 17, 8:33 AM · Plasma
meven updated the diff for D26565: KCM/Component Revamp email config.

Remove a bad line

Fri, Jan 17, 8:32 AM · Plasma
meven added inline comments to D26565: KCM/Component Revamp email config.
Fri, Jan 17, 8:31 AM · Plasma
meven updated the diff for D26714: KCM/Component Revamp FileManager UI.

Use KOpenWithDialog instead of keditfiletype5 to select the filemanager + small fix

Fri, Jan 17, 8:27 AM · Plasma
meven planned changes to D26714: KCM/Component Revamp FileManager UI.

Selecting the "Other..." option for this one takes me to the filetype editor for inode/directory instead of the app chooser as in the other patches. Is that intentional?

Fri, Jan 17, 8:04 AM · Plasma

Thu, Jan 16

meven added a comment to D26111: Runner: make recentdocument use KActivityStats data.

Adding @apol as reviewers as he was the original author of this runner.

Thu, Jan 16, 9:04 PM · Plasma
meven added a reviewer for D26111: Runner: make recentdocument use KActivityStats data: apol.
Thu, Jan 16, 9:04 PM · Plasma
meven added a comment to D26580: Kicker/RecentDocuments display place's icon when resource matches one.

ping @hein

Thu, Jan 16, 6:14 PM · Plasma
meven updated the test plan for D26714: KCM/Component Revamp FileManager UI.
Thu, Jan 16, 6:03 PM · Plasma
meven updated the task description for T12551: Revamp KCM/Component chooser.
Thu, Jan 16, 6:03 PM · Plasma: KCM Redesign, VDG
meven added a task to D26714: KCM/Component Revamp FileManager UI: T12551: Revamp KCM/Component chooser.
Thu, Jan 16, 6:03 PM · Plasma
meven added a revision to T12551: Revamp KCM/Component chooser: D26714: KCM/Component Revamp FileManager UI.
Thu, Jan 16, 6:03 PM · Plasma: KCM Redesign, VDG
meven requested review of D26714: KCM/Component Revamp FileManager UI.
Thu, Jan 16, 6:03 PM · Plasma
meven added a comment to D26565: KCM/Component Revamp email config.

Hmm, I don't have KMail installed yet it shows up in the combobox anyway. I don't think that makes sense.

Thu, Jan 16, 4:33 PM · Plasma
meven updated the diff for D26705: KCM/Component Revamp Terminal Emulator UI.

NoDisplay == false instead of NoDisplay != true

Thu, Jan 16, 4:22 PM · Plasma
meven added a comment to D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.

Could you please first update the code here to request feedback? I still see new_palette.setBrush(QPalette::Highlight, colorScheme.foreground(KColorScheme::ActiveText)) which is wrong, because QPalette::Highlight is a background color role, not a foreground color role.

Thu, Jan 16, 3:44 PM · Dolphin
meven updated the diff for D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.

Support fusion style based KCapacityBar

Thu, Jan 16, 3:43 PM · Dolphin
meven updated the test plan for D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.
Thu, Jan 16, 3:40 PM · Dolphin
meven updated the task description for T12551: Revamp KCM/Component chooser.
Thu, Jan 16, 2:20 PM · Plasma: KCM Redesign, VDG
meven added a revision to T12551: Revamp KCM/Component chooser: D26705: KCM/Component Revamp Terminal Emulator UI.
Thu, Jan 16, 1:58 PM · Plasma: KCM Redesign, VDG
meven added a task to D26705: KCM/Component Revamp Terminal Emulator UI: T12551: Revamp KCM/Component chooser.
Thu, Jan 16, 1:58 PM · Plasma
meven added a task to D26565: KCM/Component Revamp email config: T12551: Revamp KCM/Component chooser.
Thu, Jan 16, 1:57 PM · Plasma
meven added a revision to T12551: Revamp KCM/Component chooser: D26565: KCM/Component Revamp email config.
Thu, Jan 16, 1:57 PM · Plasma: KCM Redesign, VDG
meven committed R295:abd2e496efaa: KCModuleQml: Ensure defaulted is emitted with the current configModule… (authored by meven).
KCModuleQml: Ensure defaulted is emitted with the current configModule…
Thu, Jan 16, 1:53 PM
meven closed D26085: KCModuleQml: Ensure defaulted is emitted with the current configModule->representsDefaults on load.
Thu, Jan 16, 1:53 PM · Frameworks
meven added a comment to D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.

You marked my issues as Done but didn't change the code there. Please test with CheckColorRoles on Fusion widget style.

Thank you for pointing this out.

Default KCapactityBar style uses palette().window().color() to get its filling color (QPalette::Base color).

But breeze uses:

//! styled painting for KCapacityBar
QStyle::ControlElement CE_CapacityBar;

from breeze/kstyle/breezestyle.h

My curront code works for breeze but not for Fusion.

Using for fusion :

new_palette.setBrush(QPalette::Base, colorScheme.foreground(KColorScheme::NegativeText));

Works.

So I guess I have to cover the two cases, breeze and more fusion like themes.

Thu, Jan 16, 1:51 PM · Dolphin
meven created T12551: Revamp KCM/Component chooser.
Thu, Jan 16, 1:45 PM · Plasma: KCM Redesign, VDG
meven updated the summary of D26705: KCM/Component Revamp Terminal Emulator UI.
Thu, Jan 16, 1:41 PM · Plasma
meven updated the test plan for D26705: KCM/Component Revamp Terminal Emulator UI.
Thu, Jan 16, 1:41 PM · Plasma
meven requested review of D26705: KCM/Component Revamp Terminal Emulator UI.
Thu, Jan 16, 1:40 PM · Plasma
meven updated the diff for D26565: KCM/Component Revamp email config.

Add a couple of const

Thu, Jan 16, 1:12 PM · Plasma
meven updated the diff for D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs.

Fix poping .length() > 0 ordering

Thu, Jan 16, 10:22 AM · Frameworks
meven updated the diff for D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs.

Check parent dir transitive symlinks, aka manual canonicalPath

Thu, Jan 16, 10:10 AM · Frameworks
meven added a comment to D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick.

Cancel that, it fails to build on Linux as well - i'm guessing that the KNetstuff changes have not been landed?

The KNS changes have indeed not been landed yet

Thu, Jan 16, 9:48 AM · Plasma
meven added a reviewer for D26690: Make "Default Applications" in mimeapps.list the preferred applications: Frameworks.
Thu, Jan 16, 9:13 AM · Frameworks
meven updated the diff for D26690: Make "Default Applications" in mimeapps.list the preferred applications.

Update code to have a better implementation reusing existant API

Thu, Jan 16, 9:13 AM · Frameworks
meven updated the summary of D26690: Make "Default Applications" in mimeapps.list the preferred applications.
Thu, Jan 16, 9:11 AM · Frameworks
meven added a comment to D26690: Make "Default Applications" in mimeapps.list the preferred applications.

s/Schema/Scheme/ everywhere (method name, commit log)

I want to deprecate KMimeTypeTrader, this should rather go into the upcoming KApplicationTrader D25698, if new API is needed.

I'm pretty sure you can use KMimeTypeTrader::query(mimeHandler) instead of parsing mimeapps.list. And then I wonder if you really need new API :)

Thu, Jan 16, 8:50 AM · Frameworks

Wed, Jan 15

meven requested changes to D26673: Ajout d'une traduction d'un article de dot.kde.org.
Wed, Jan 15, 4:30 PM
meven accepted D26673: Ajout d'une traduction d'un article de dot.kde.org.
Wed, Jan 15, 4:29 PM
meven added a comment to D26690: Make "Default Applications" in mimeapps.list the preferred applications.

I mean here to build consensus then implement about the need for this, then on how to implement it.

Wed, Jan 15, 4:27 PM · Frameworks
meven added reviewers for D26690: Make "Default Applications" in mimeapps.list the preferred applications: dfaure, dvratil, ervin.
Wed, Jan 15, 4:25 PM · Frameworks
meven requested review of D26690: Make "Default Applications" in mimeapps.list the preferred applications.
Wed, Jan 15, 4:20 PM · Frameworks
meven added inline comments to D26673: Ajout d'une traduction d'un article de dot.kde.org.
Wed, Jan 15, 3:36 PM
meven accepted D26683: KCM Notifications : fix applications behavior not properly updated in KCM.
Wed, Jan 15, 10:01 AM · Plasma
meven added inline comments to D26650: Use KService to look for Filelight.
Wed, Jan 15, 9:08 AM · Frameworks
meven added a comment to D26673: Ajout d'une traduction d'un article de dot.kde.org.

Super idée @ognarb

Wed, Jan 15, 8:39 AM
meven added inline comments to D26680: [kcms/feedback] Implement setRepresentsDefaults.
Wed, Jan 15, 8:31 AM · Plasma
meven added a comment to D26565: KCM/Component Revamp email config.

Let me know if and when this is reviewable, or if it's still WIP.

Wed, Jan 15, 8:11 AM · Plasma
meven added a reviewer for D26565: KCM/Component Revamp email config: dvratil.
Wed, Jan 15, 8:03 AM · Plasma

Tue, Jan 14

meven updated the test plan for D26565: KCM/Component Revamp email config.
Tue, Jan 14, 4:42 PM · Plasma
meven updated the diff for D26565: KCM/Component Revamp email config.

clean some unused incudes

Tue, Jan 14, 4:33 PM · Plasma
meven updated the test plan for D26565: KCM/Component Revamp email config.
Tue, Jan 14, 4:27 PM · Plasma
meven updated the test plan for D26565: KCM/Component Revamp email config.
Tue, Jan 14, 4:27 PM · Plasma
meven updated the diff for D26565: KCM/Component Revamp email config.

Allow to select any app as email client, mimeapps.list preferred email is the source of truth regarding default mail client, depends on KF5.67 (post plasma 5.18)

Tue, Jan 14, 4:26 PM · Plasma
meven committed R241:be69b302f1d7: Fix doc block in KProtocolInfoFactory (authored by meven).
Fix doc block in KProtocolInfoFactory
Tue, Jan 14, 3:22 PM
meven closed D26663: Fix doc block in KProtocolInfoFactory.
Tue, Jan 14, 3:22 PM · Frameworks