meven (Méven Car)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 10 2018, 12:40 PM (137 w, 2 d)
Availability
Available

Recent Activity

Tue, Sep 8

meven added a comment to D29526: Thumbnails: make thumbnail generation dpr-aware.

For all but text the DPR is completely irrelevant, large@1 is identical to normal@2.

Tue, Sep 8, 10:51 AM · Frameworks, Dolphin
meven added a comment to T12031: Clean up KRunner.

@alex should be interested in this.

Tue, Sep 8, 9:35 AM · KF6
meven moved T12169: KNotifyConfig: Port away from Phonon from Backlog to Done on the KF6 board.
Tue, Sep 8, 9:30 AM · KF6
meven updated subscribers of D29466: [applets/appmenu] Add search to global application menu.

Can this be moved to krunner? In that case it can be used even when the user doesn't use global menu?

Tue, Sep 8, 8:50 AM · Plasma
meven added a comment to D29397: KPreviewJob : Support for DeviceRatioPixel.

FYI on this patch serie, I am currently focusing on the specification work : https://gitlab.freedesktop.org/xdg/xdg-specs/-/merge_requests/35
Then I am thinking about moving my patch serie to gitlab reflecting on the last feedback of course.
Those patchs are getting old and are going to need some degree of rebasing.

Tue, Sep 8, 8:43 AM · Frameworks

Mon, Sep 7

meven added a comment to D29526: Thumbnails: make thumbnail generation dpr-aware.

I just sent a specification evolution to cover this use case : https://gitlab.freedesktop.org/xdg/xdg-specs/-/merge_requests/35

Mon, Sep 7, 9:39 AM · Frameworks, Dolphin

Jul 25 2020

meven added a comment to D29282: QuickEditor: Allow to take screen region screenshot under Wayland.

Tried this out and Rectangular Region mode disappeared from the combobox.

I think this is because there is a now check in spectacle that plasma is > 5.20 for the shuttermode.
You can edit the PlatformKWinWayland::supportedShutterModes to work locally.
The patch needs adjustment.

Jul 25 2020, 4:45 PM · Spectacle

Jul 18 2020

meven added a comment to D23168: Use embedded cover in MP4 video files.

I added my ssh-key to gitlab, set the upstream urls:

origin git@invent.kde.org:multimedia/ffmpegthumbs.git (fetch)
origin git@invent.kde.org:multimedia/ffmpegthumbs.git (push)

Than I follwed the instructions here: https://docs.gitlab.com/ee/user/project/merge_requests/creating_merge_requests.html#new-merge-request-from-your-local-environment

git push origin diff-D23168

Jul 18 2020, 8:51 AM

Jul 17 2020

meven added a comment to D23168: Use embedded cover in MP4 video files.

How do I switch to the right repo?

git remote -v

origin http://anongit.kde.org/ffmpegthumbs (fetch)
origin http://anongit.kde.org/ffmpegthumbs (push)

git remote set-url origin https://invent.kde.org/multimedia/ffmpegthumbs.git

Jul 17 2020, 1:29 PM

Jul 16 2020

meven added a comment to D23168: Use embedded cover in MP4 video files.

After struggling with git (as usual since git rebase master did nothing) I came up with that diff.

Jul 16 2020, 7:58 AM

Jul 15 2020

meven closed D26718: aggregate text for KRunner in DesktopView.

At moved to https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/148

Jul 15 2020, 1:48 PM · Plasma

Jul 10 2020

meven added inline comments to D28651: Load and use global animation settings.
Jul 10 2020, 8:06 AM · Plasma, Breeze

Jun 30 2020

meven added a comment to D28856: Save disabling of desktop file components in kglobalshortcutsrc.

Would be important to land with https://invent.kde.org/frameworks/kglobalaccel/-/merge_requests/2

Jun 30 2020, 10:45 AM · Frameworks

Jun 23 2020

meven updated the diff for D29282: QuickEditor: Allow to take screen region screenshot under Wayland.

Rebased on master

Jun 23 2020, 10:46 AM · Spectacle

Jun 20 2020

meven added a comment to D23168: Use embedded cover in MP4 video files.

@hschaefer still around ?

Jun 20 2020, 11:33 AM

Jun 17 2020

meven added a comment to D29282: QuickEditor: Allow to take screen region screenshot under Wayland.

Needs a rebase.

Jun 17 2020, 8:40 AM · Spectacle

Jun 16 2020

meven closed D26114: Places: Use Solid::Device::DisplayName for DisplayRole.
Jun 16 2020, 5:37 PM · Dolphin
meven closed D29408: Wayland: allow to take immediate and delayed screenshots.
Jun 16 2020, 5:06 PM · Spectacle
meven updated the summary of D29408: Wayland: allow to take immediate and delayed screenshots.
Jun 16 2020, 5:04 PM · Spectacle
meven closed D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation.
Jun 16 2020, 5:00 PM · KWin
meven accepted D29807: Change Chrome API design.
Jun 16 2020, 1:43 PM · Plasma
meven added a comment to D29807: Change Chrome API design.
In D29807#675032, @alex wrote:

Friendly Ping :-)

Or should I just move this to gitlab?

Jun 16 2020, 1:42 PM · Plasma
meven added a comment to D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation.

@zzag I believe I can land now

Jun 16 2020, 9:16 AM · KWin
meven added a comment to D29395: Refactor MediaController.

ping @cblack and reviewers

Jun 16 2020, 8:53 AM · Plasma

Jun 15 2020

meven added a comment to D29847: Fixes compile problem for freebsd because of missing crypt.h.
In D29847#674811, @usta wrote:

https://invent.kde.org/adridg/plasma-desktop/-/tree/normalize-includes

There's already a CMake-time check for <crypt.h>, it's just not used. (HAVE_CRYPT_H)

@adridg having or not having crypt_h I think won't solve this problem because it looks like Linux needs it on the other hand BSD system doesn't have it and use unistd.h
instead of crypt.h so doesn't we still need to check if the system is linux or not ? I have almost 0 knowledge about bsd systems so i think anyone who has knowledge
on this topic might be more suitable for this patch request. ( at first, I have just think about freebsd and now i can see there are other alternatives (net,open,... bsd has similar issue ) )

Jun 15 2020, 11:34 AM · FreeBSD, Plasma
meven added inline comments to D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation.
Jun 15 2020, 9:43 AM · KWin

Jun 12 2020

meven added a comment to D28781: Allow configuring click behavior in Desktop Grid effect.

I am in favor of merging this. @davidedmundson or @zzag any thoughts ?

Jun 12 2020, 11:58 AM · KWin
meven added a comment to D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation.

This should be ready.

Jun 12 2020, 11:55 AM · KWin

Jun 11 2020

meven updated the diff for D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation.

Add a KWIN_UTILS logging category

Jun 11 2020, 3:23 PM · KWin
meven added a comment to D28745: Skip caching thumbnails on encrypted filesystems.

Ok, so, what I want to do now is to create static method findByPath which is going to return Solid::StorageVolume instance (is there a case in which we can expect something different than StorageVolume?).

Jun 11 2020, 10:00 AM · Frameworks, Dolphin
meven added inline comments to D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation.
Jun 11 2020, 9:32 AM · KWin
meven added a comment to D29408: Wayland: allow to take immediate and delayed screenshots.

Needs https://invent.kde.org/graphics/spectacle/-/merge_requests/5 after latest D29408 changes

Jun 11 2020, 9:08 AM · Spectacle
meven added inline comments to D29408: Wayland: allow to take immediate and delayed screenshots.
Jun 11 2020, 9:07 AM · Spectacle
meven updated the task description for T8552: Polish Open/Save dialogs.
Jun 11 2020, 8:58 AM · Frameworks, VDG
meven updated the diff for D29408: Wayland: allow to take immediate and delayed screenshots.

Check Plasma major version, use splitRef

Jun 11 2020, 7:22 AM · Spectacle

Jun 10 2020

meven accepted D23168: Use embedded cover in MP4 video files.
Jun 10 2020, 3:30 PM
meven updated the summary of D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation.
Jun 10 2020, 1:58 PM · KWin
meven updated the diff for D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation.

Use Real DBus interface name as required value in X-KDE-DBUS-Restricted-Interfaces

Jun 10 2020, 1:58 PM · KWin
meven updated the diff for D29408: Wayland: allow to take immediate and delayed screenshots.

Make raw DBus call

Jun 10 2020, 1:07 PM · Spectacle
meven updated the diff for D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation.

Add documentation, improve variable naming

Jun 10 2020, 8:29 AM · KWin
meven added inline comments to D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation.
Jun 10 2020, 8:24 AM · KWin
meven updated the diff for D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation.

Fix emails in copyrights

Jun 10 2020, 7:59 AM · KWin
meven added a comment to D29408: Wayland: allow to take immediate and delayed screenshots.

I think we shouldn't use QDBUsInterface but given that we already do this is probably ok

Jun 10 2020, 7:56 AM · Spectacle

Jun 9 2020

meven added a comment to D29408: Wayland: allow to take immediate and delayed screenshots.

I am abandonning https://invent.kde.org/frameworks/kdbusaddons/-/merge_requests/1/diffs.

Jun 9 2020, 4:56 PM · Spectacle
meven updated the diff for D29408: Wayland: allow to take immediate and delayed screenshots.

Check only once the plasma version when needed

Jun 9 2020, 4:55 PM · Spectacle
meven updated the diff for D29408: Wayland: allow to take immediate and delayed screenshots.

Avoid adding the dependency to spectacle

Jun 9 2020, 3:45 PM · Spectacle
meven updated the summary of D29408: Wayland: allow to take immediate and delayed screenshots.
Jun 9 2020, 3:44 PM · Spectacle

Jun 8 2020

meven added a comment to D29408: Wayland: allow to take immediate and delayed screenshots.

This adds a dependency on https://invent.kde.org/frameworks/kdbusaddons/-/merge_requests/1/diffs

Jun 8 2020, 3:10 PM · Spectacle
meven updated the diff for D29408: Wayland: allow to take immediate and delayed screenshots.

Use KDBusAddon' PlasmaVersion

Jun 8 2020, 3:09 PM · Spectacle
meven added inline comments to D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation.
Jun 8 2020, 1:43 PM · KWin
meven added a comment to D29408: Wayland: allow to take immediate and delayed screenshots.

https://invent.kde.org/graphics/spectacle/-/merge_requests/3 was merged

Jun 8 2020, 7:43 AM · Spectacle
meven updated the diff for D29408: Wayland: allow to take immediate and delayed screenshots.

Removed .arcconfig, rebased

Jun 8 2020, 7:36 AM · Spectacle
meven updated the diff for D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation.

Remove whitespace & rebase

Jun 8 2020, 7:27 AM · KWin
meven committed R318:bf4388c75525: Status bar: Hide the space free bar when size is unknown (authored by meven).
Status bar: Hide the space free bar when size is unknown
Jun 8 2020, 5:53 AM
meven closed D29213: Status bar: Hide the space free bar when size is unknown.
Jun 8 2020, 5:49 AM · Dolphin
meven added a comment to D28745: Skip caching thumbnails on encrypted filesystems.

Solid does not provide straight folder => StorageVolume yet, but I think Solid could have such a utility feature added.
Something like Solid::Device::findByPath(), it would need to canonically and recursively resolves the path parent to pay attention to symlinks.
This would also help D26407

No recursion needed, stat provides the device.

Jun 8 2020, 5:45 AM · Frameworks, Dolphin

Jun 7 2020

meven accepted D27129: [Notifications] Allow expiring an entire group.

Seems fine to me

Jun 7 2020, 11:30 AM · Plasma

Jun 6 2020

meven added a comment to D28745: Skip caching thumbnails on encrypted filesystems.

I tried to research Solid using api.kde.org (https://api.kde.org/frameworks/solid/html/classSolid_1_1Device.html, https://api.kde.org/frameworks/solid/html/classSolid_1_1StorageVolume.html) and looking for usages of both Solid::Device and Solid::StorageVolume in code but I'm not able to get StorageVolume instance for given file/directory.

Jun 6 2020, 12:28 PM · Frameworks, Dolphin
meven committed R318:ec63140ce7dd: Prevent warnings such as QFSFileEngine::open: No file name specified (authored by meven).
Prevent warnings such as QFSFileEngine::open: No file name specified
Jun 6 2020, 7:52 AM

Jun 5 2020

meven committed R166:86feda3fcda5: Add X-KDE-DBUS-Restricted-Interfaces to desktop file (authored by meven).
Add X-KDE-DBUS-Restricted-Interfaces to desktop file
Jun 5 2020, 10:52 AM
meven added a comment to D29408: Wayland: allow to take immediate and delayed screenshots.

This is ready to land except I need either to :

  • wait after 20.08 is released since this fix is dependent on KWin D29407 that won't be available before Plasma 5.20.
  • or add a runtime plasma version check
Jun 5 2020, 10:50 AM · Spectacle
meven updated the diff for D29408: Wayland: allow to take immediate and delayed screenshots.

Clean up delayed shutterMode

Jun 5 2020, 10:43 AM · Spectacle
meven added a comment to D29774: Add X-KDE-DBUS-Restricted-Interfaces to Application desktop entry fields.
In D29774#674668, @zzag wrote:

This added field to Application desktop entries allows to declare an access request to a DBUS interface.

Just to be sure. Does X-KDE-DBUS-Restricted-Interfaces indicate a D-Bus interface or a D-Bus service?

Jun 5 2020, 10:26 AM · Frameworks
meven committed R309:cdad4f73ccb7: Add X-KDE-DBUS-Restricted-Interfaces to Application desktop entry fields (authored by meven).
Add X-KDE-DBUS-Restricted-Interfaces to Application desktop entry fields
Jun 5 2020, 9:41 AM
meven closed D29774: Add X-KDE-DBUS-Restricted-Interfaces to Application desktop entry fields.
Jun 5 2020, 9:41 AM · Frameworks
meven closed D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.
Jun 5 2020, 9:31 AM · Spectacle
meven committed R166:dec0e6cef23a: Refactor Spectacle to run in single instance mode with KDBusService::Unique (authored by meven).
Refactor Spectacle to run in single instance mode with KDBusService::Unique
Jun 5 2020, 9:31 AM
meven updated the diff for D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

Fix build

Jun 5 2020, 9:11 AM · Spectacle
meven updated the summary of D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.
Jun 5 2020, 8:37 AM · Spectacle

Jun 3 2020

meven added a comment to T11601: Primary Clipboard (middle click) Support.

The patch has landed :
https://invent.kde.org/plasma/kwayland-server/-/merge_requests/15
https://invent.kde.org/plasma/kwin/-/merge_requests/27

Jun 3 2020, 3:48 PM · Plasma on Wayland
meven accepted D29807: Change Chrome API design.

@broulik perhaps a review ?

Jun 3 2020, 7:24 AM · Plasma

Jun 2 2020

meven added a comment to D29397: KPreviewJob : Support for DeviceRatioPixel.

To not have that block this improvement, you could in parallel for now use a "kde" namespaced directories, say "*@kde2x/", where we/you could just use the for-now-KF-only theme extension. And once there is an agreed specification extension, the code could be switched to just any non-namespace shared hidpi folder matching whatever the specification ended up to be.

Jun 2 2020, 3:10 PM · Frameworks
meven added a comment to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

Hmm, for me this breaks the option to open a new instance when the PrintScreen key is pressed and an existing instance is already running. It only works if I launch Spectacle manually using the --new-instance flag. The feature should work regardless of how the app is launched.

Jun 2 2020, 1:07 PM · Spectacle
meven added a comment to D28544: RecentDocuments Runner: Cleanup and formatting.

Well @alex https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/31 was merged, so if you are still up to do it, now is a good time to rebase your changes.

Jun 2 2020, 10:13 AM · Plasma
meven committed R127:dfd852abd913: OutputDevice: mark them as disabled initially (authored by meven).
OutputDevice: mark them as disabled initially
Jun 2 2020, 9:10 AM
meven committed R108:1b1831a5ac53: Merge branch 'Plasma/5.19' of https://invent.kde.org/plasma/kwin (authored by meven).
Merge branch 'Plasma/5.19' of https://invent.kde.org/plasma/kwin
Jun 2 2020, 9:08 AM
meven committed R108:1a50c98f4a99: [scene] Avoid a crash when currentPixmap is invalid and previousPixmap is null… (authored by meven).
[scene] Avoid a crash when currentPixmap is invalid and previousPixmap is null…
Jun 2 2020, 9:07 AM
meven committed R108:ebf4c6230031: Fix build (authored by zzag).
Fix build
Jun 2 2020, 9:05 AM
meven committed R108:9da9ab753987: [scene] Avoid a crash when currentPixmap is invalid and previousPixmap is null… (authored by meven).
[scene] Avoid a crash when currentPixmap is invalid and previousPixmap is null…
Jun 2 2020, 9:05 AM
meven committed R108:3442666ede68: [effects/logout] Start the animation on only windowAdded or windowClosed (authored by zzag).
[effects/logout] Start the animation on only windowAdded or windowClosed
Jun 2 2020, 9:05 AM
meven committed R108:f0d8109dfe6a: [effects/slidingpopups] Start the animation on only windowAdded or windowClosed (authored by zzag).
[effects/slidingpopups] Start the animation on only windowAdded or windowClosed
Jun 2 2020, 9:05 AM
meven committed R108:003274ce582c: [effects/fade] Start the animation on only windowAdded or windowClosed (authored by zzag).
[effects/fade] Start the animation on only windowAdded or windowClosed
Jun 2 2020, 9:05 AM
meven committed R108:aadcc712160d: [wayland] Rework xdg-shell implementation (authored by zzag).
[wayland] Rework xdg-shell implementation
Jun 2 2020, 9:05 AM
meven committed R108:a238f3af6835: [effects/zoom] Implement text caret tracking (authored by zzag).
[effects/zoom] Implement text caret tracking
Jun 2 2020, 9:05 AM
meven committed R108:ecddb37316a4: [effects/zoom] Implement focus tracking with QAccessibilityClient (authored by zzag).
[effects/zoom] Implement focus tracking with QAccessibilityClient
Jun 2 2020, 9:05 AM
meven committed R108:3717579733f6: Notify about decoration theme change (authored by gikari).
Notify about decoration theme change
Jun 2 2020, 9:05 AM
meven committed R108:b599531f42d3: [kcm/kwinrules] Detect also window complete class (authored by iasensio).
[kcm/kwinrules] Detect also window complete class
Jun 2 2020, 9:05 AM
meven committed R108:a650e6520f3e: Don't compare string with empty string (authored by ognarb).
Don't compare string with empty string
Jun 2 2020, 9:05 AM
meven committed R108:5089ff179a39: Take in consideration keyboard shortcuts inhibit rename to V1 (authored by bport).
Take in consideration keyboard shortcuts inhibit rename to V1
Jun 2 2020, 9:05 AM
meven committed R108:ce06eea000ad: Add support to keyboard shortcuts inhibitor (authored by bport).
Add support to keyboard shortcuts inhibitor
Jun 2 2020, 9:05 AM
meven committed R108:8a7743f332c9: Wayland server getters => const (authored by bport).
Wayland server getters => const
Jun 2 2020, 9:05 AM
meven committed R108:f28e4268ab11: Clean #if version check blocks (authored by meven).
Clean #if version check blocks
Jun 2 2020, 9:05 AM
meven committed R108:b9d6710179cb: [wayland] Adjust to kwayland-server changes (authored by zzag).
[wayland] Adjust to kwayland-server changes
Jun 2 2020, 9:05 AM
meven committed R108:449bc085bdf8: [wayland] Allow nested mode to have a fractional scale < 1 (authored by davidedmundson).
[wayland] Allow nested mode to have a fractional scale < 1
Jun 2 2020, 9:05 AM
meven committed R108:8db5a9a58a51: DrmOutput: Ensure waylandOutput dpms mode matches DrmOutputs (authored by meven).
DrmOutput: Ensure waylandOutput dpms mode matches DrmOutputs
Jun 2 2020, 9:05 AM
meven committed R108:3eea5fab5f44: [effects/blur] Update to kwayland changes (authored by davidedmundson).
[effects/blur] Update to kwayland changes
Jun 2 2020, 9:05 AM
meven committed R108:6fcc851efb48: [wayland] Create DataControlDeviceManager (authored by davidedmundson).
[wayland] Create DataControlDeviceManager
Jun 2 2020, 9:05 AM
meven committed R108:9138b598edaa: [xwl] Update to kwaylandserver changes (authored by davidedmundson).
[xwl] Update to kwaylandserver changes
Jun 2 2020, 9:05 AM
meven committed R108:38ee8b888946: Improve code readability of presentwindows effect (authored by muesli).
Improve code readability of presentwindows effect
Jun 2 2020, 9:04 AM
meven committed R108:55854b472a1c: Change CommandAllKey to Meta (authored by ndavis).
Change CommandAllKey to Meta
Jun 2 2020, 9:04 AM