meven (Méven Car)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 10 2018, 12:40 PM (84 w, 1 d)
Availability
Available

Recent Activity

Fri, Sep 20

meven added a comment to D23667: Add == and != operators to KIO::UDSEntry.

Looks ok, but I'm just curious about the use case. "I felt it was missing" doesn't sound as strong an argument as "I need this"...

Slaves are supposed to mostly create those, not compare them, and apps are supposed to use KFileItem rather than UDSEntry directly.

Fri, Sep 20, 6:52 PM · Frameworks
meven added a comment to D24071: Add kwayland-integration to KWin dependencies.

The changes were probably rolled back when I synced stable and master to ensure they matched.

Note that the KWayland Integration changes are likely unnecessary - all Frameworks are provided by default to projects outside of frameworks/*

As far i can it does not hold when building with kde-srcbuild : kwayland-integration was not built when building plasma-desktop or Kwin for instance.

Assuming the same logic holds, and as long as the respective maintainers of KWayland Integration and KWin are still fine with this, it can go in again.

Fri, Sep 20, 7:56 AM

Thu, Sep 19

meven added a comment to D24071: Add kwayland-integration to KWin dependencies.

Apparently my previous changes made in D23931 were overriden, I had to redo them.

Thu, Sep 19, 8:07 AM
meven requested review of D24071: Add kwayland-integration to KWin dependencies.
Thu, Sep 19, 8:06 AM

Wed, Sep 18

meven added a comment to D23931: Add kwayland-integration to kwin dependencies.

Thanks for clarifying. I will make a followup PR for the master branch.

Wed, Sep 18, 3:02 PM
meven added a comment to D23931: Add kwayland-integration to kwin dependencies.

Is there any reason why this was only done for stable and not also for the master branch?

Wed, Sep 18, 2:57 PM

Tue, Sep 17

meven added inline comments to D23578: Before requesting a scan, check the time threshold.
Tue, Sep 17, 9:27 AM · Plasma

Sat, Sep 14

meven added a comment to D23667: Add == and != operators to KIO::UDSEntry.

@pino if this is fine for you...

Sat, Sep 14, 7:56 PM · Frameworks
meven updated the diff for D23667: Add == and != operators to KIO::UDSEntry.

Update @since references

Sat, Sep 14, 7:56 PM · Frameworks
meven added a comment to D23578: Before requesting a scan, check the time threshold.

@jgrulich if you could have a second look, I improved this because my previous code could have prevented requestScan to be fired.

Sat, Sep 14, 3:15 PM · Plasma
meven updated the diff for D23578: Before requesting a scan, check the time threshold.

Add a timer per interface allowing to scan devices as soon as technically possible, rescheduling wifi scan for when it will be possible

Sat, Sep 14, 3:09 PM · Plasma
meven updated the diff for D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes.

Add a KF6 clean up todo

Sat, Sep 14, 9:30 AM · Frameworks
meven added inline comments to D23520: Add time line to X axis.
Sat, Sep 14, 8:41 AM · Plasma

Fri, Sep 13

meven updated the diff for D23578: Before requesting a scan, check the time threshold.

Improve code and make it cleaner

Fri, Sep 13, 11:26 PM · Plasma
meven added a comment to D23931: Add kwayland-integration to kwin dependencies.
In D23931#530715, @zzag wrote:

Code-wise, kwin doesn't need any bit of kwayland-integration.

Fri, Sep 13, 4:27 PM
meven updated the diff for D23557: Update dolphin tests following place changes D7446.

Update KIO dependency

Fri, Sep 13, 4:15 PM · Dolphin
meven closed D23931: Add kwayland-integration to kwin dependencies.
Fri, Sep 13, 3:47 PM
meven committed R499:c46b7e5cf44b: Add kwayland-integration to kwin dependencies (authored by meven).
Add kwayland-integration to kwin dependencies
Fri, Sep 13, 3:47 PM
meven requested review of D23931: Add kwayland-integration to kwin dependencies.
Fri, Sep 13, 3:46 PM
meven accepted D23287: Create a plugin framework for processes.

Build with QT 5.12

Fri, Sep 13, 2:42 PM · Plasma
meven added a comment to D12827: Added process details in the process list context menu.

@meven Sorry I've totally forgotten about your suggestions when I was updating the patch...
I have renamed DetailsDlg to ProcessDetailsDialog. But I've got some minor issues with code indentation. I have tried out uncrustify-kf5 (which didn't even work out-of-box. Instead of formatting the files in-place, it produced *.uncrustify files instead. I have uncrustify 0.69, and I worked around the issue by adding --replace to the arguments for uncrystify in uncrustify-kf5). But the script produces way too many changes in some files I changed. One of those files is processes_linux_p.cpp, which uses both spaces and tabs for indentation. So at this moment I've only committed some of the indentation changes.
Any further help with pushing this patch forward would be greatly appreciated.

Fri, Sep 13, 2:08 PM · Plasma
meven updated the diff for D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config.

Update @deprecated message to be more clear

Fri, Sep 13, 2:04 PM · Frameworks
meven updated the diff for D7446: [Places panel] Revamp the Recently Saved section.

Update since version

Fri, Sep 13, 12:39 PM · Frameworks, Dolphin
meven updated the summary of D7446: [Places panel] Revamp the Recently Saved section.
Fri, Sep 13, 12:37 PM · Frameworks, Dolphin
meven updated the diff for D7446: [Places panel] Revamp the Recently Saved section.

add recentlyused:/ bookmarks only in plasma, update following D23742 changes

Fri, Sep 13, 12:36 PM · Frameworks, Dolphin
meven added inline comments to D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config.
Fri, Sep 13, 12:17 PM · Frameworks
meven committed R36:fe2cccec33e8: With autodetect, extract single files archive in current dir (authored by meven).
With autodetect, extract single files archive in current dir
Fri, Sep 13, 9:20 AM
meven closed D23693: With autodetect, extract single files archive in current dir.
Fri, Sep 13, 9:20 AM · Ark
meven added a comment to D23742: Add two special cases url recentlyused:/files and recentlyused:/folders.

I will land this soonish if no one has any objections.

Fri, Sep 13, 9:17 AM · Frameworks, Dolphin
meven updated the diff for D23742: Add two special cases url recentlyused:/files and recentlyused:/folders.

Allow users to use ?type filter with /files path

Fri, Sep 13, 9:16 AM · Frameworks, Dolphin
meven updated the summary of D23693: With autodetect, extract single files archive in current dir.
Fri, Sep 13, 8:57 AM · Ark
meven updated the diff for D23693: With autodetect, extract single files archive in current dir.

Improve help text, rebase

Fri, Sep 13, 8:43 AM · Ark
meven updated the diff for D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart.

Rebase on master, review feedback

Fri, Sep 13, 8:12 AM · Frameworks

Thu, Sep 12

meven added a comment to D23693: With autodetect, extract single files archive in current dir.

ping

Thu, Sep 12, 3:52 PM · Ark
meven updated the diff for D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config.

Clean up and update @since

Thu, Sep 12, 3:50 PM · Frameworks
meven added a comment to D23538: [dolphin] Animate gifs on preview.

This is an screenshot on current master code, without this patch. I'd like for the animatedImage to follow also the path on line 271.

Thu, Sep 12, 1:35 PM · Dolphin
meven triaged T11627: Improve KIO asynchronicity as Normal priority.
Thu, Sep 12, 8:44 AM

Tue, Sep 10

meven added inline comments to D23538: [dolphin] Animate gifs on preview.
Tue, Sep 10, 11:05 PM · Dolphin
meven closed D23855: Avoid installing log categorie file to KDE_INSTALL_CONFDIR.
Tue, Sep 10, 10:19 PM · Frameworks
meven committed R159:31f921f65093: Avoid installing log categorie file to KDE_INSTALL_CONFDIR (authored by meven).
Avoid installing log categorie file to KDE_INSTALL_CONFDIR
Tue, Sep 10, 10:19 PM
meven added a comment to D23855: Avoid installing log categorie file to KDE_INSTALL_CONFDIR.

Btw we have quite a few CMakeLists.txt files that would need the same attention.

Tue, Sep 10, 10:18 PM · Frameworks
meven accepted D23846: Fix build error of wrong function reference.

LGTM this fixes plasma-workspace build

Tue, Sep 10, 10:12 PM · Plasma
meven retitled D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes from Avoid sending KDirNotify::emitFilesAdded when the trash is emptied to Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes.
Tue, Sep 10, 8:51 PM · Frameworks
meven updated the diff for D23668: [Information Panel] Allows to refresh icon and metadata for urls such as trash:/.

Use QUrl::fromUserInput as we should have, now need D23851 to work

Tue, Sep 10, 8:50 PM · Dolphin
meven added a comment to D23855: Avoid installing log categorie file to KDE_INSTALL_CONFDIR.

See https://phabricator.kde.org/D22143#526980

Tue, Sep 10, 8:42 PM · Frameworks
meven updated the diff for D23855: Avoid installing log categorie file to KDE_INSTALL_CONFDIR.

rebase

Tue, Sep 10, 8:41 PM · Frameworks
meven requested review of D23855: Avoid installing log categorie file to KDE_INSTALL_CONFDIR.
Tue, Sep 10, 8:40 PM · Frameworks
meven requested review of D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes.
Tue, Sep 10, 8:22 PM · Frameworks
meven added inline comments to D23742: Add two special cases url recentlyused:/files and recentlyused:/folders.
Tue, Sep 10, 7:28 PM · Frameworks, Dolphin
meven added a comment to D23693: With autodetect, extract single files archive in current dir.

Hmm I don't know, this might break some workflows :/
Basically with "autodetect subfolder" you can always assume that a folder will be created and some poeple might rely on this.

What is your motivation for this change?

Tue, Sep 10, 12:41 PM · Ark
meven added a comment to D7446: [Places panel] Revamp the Recently Saved section.

A plan of action would be :

  1. Check add recenly_used only on plasma KDE_FULL_SESSION (it can't be used outside )
Tue, Sep 10, 10:49 AM · Frameworks, Dolphin

Mon, Sep 9

meven added a comment to D12827: Added process details in the process list context menu.

Patch updated. Any suggestions?

You have a few code indentation issues, that you can take care of.
https://phabricator.kde.org/D12827#inline-130952

Mon, Sep 9, 10:01 PM · Plasma
meven updated the diff for D23667: Add == and != operators to KIO::UDSEntry.

Remove unneeded friend function declarations

Mon, Sep 9, 9:19 PM · Frameworks
meven closed D23599: Lower the log level for when the mimeFromContent differed from MimeFromExtension.
Mon, Sep 9, 1:23 PM · Ark
meven committed R36:efe398981d5f: Lower the log level for when the mimeFromContent differed from MimeFromExtension (authored by meven).
Lower the log level for when the mimeFromContent differed from MimeFromExtension
Mon, Sep 9, 1:23 PM
meven added inline comments to D23668: [Information Panel] Allows to refresh icon and metadata for urls such as trash:/.
Mon, Sep 9, 11:17 AM · Dolphin
meven added a comment to D21273: Add support for newer linux kernel power_supply API.

Thank you @luc4 for pinging again

Mon, Sep 9, 9:28 AM · Plasma

Sun, Sep 8

meven accepted D23757: Clean up hamburger menu and viewport and single-folder context menus.

Fine to me

Sun, Sep 8, 12:07 PM · Dolphin

Sat, Sep 7

meven added a reviewer for D23693: With autodetect, extract single files archive in current dir: ngraham.
Sat, Sep 7, 10:55 PM · Ark
meven added a comment to D23757: Clean up hamburger menu and viewport and single-folder context menus.

Right now it's always in its own single-item group, which looks bad IMO. Open to suggestions.

Perhaps it should be grouped with and placed just above Properties? We put "Add to Favorites" at the bottom of the context menu in Kickoff and Properties typically doesn't go with anything else.

Sat, Sep 7, 10:40 PM · Dolphin
meven accepted D23730: Add new protocol for 7z archives.

7zip:/ is in fact not correct because this would make the url scheme 7zip, but a url scheme must begin with a letter .
That's too bad URL aren't not more flexible.

Sat, Sep 7, 9:37 PM · Dolphin, Frameworks
meven updated the diff for D23667: Add == and != operators to KIO::UDSEntry.

typo fix

Sat, Sep 7, 9:30 PM · Frameworks
meven updated the diff for D23667: Add == and != operators to KIO::UDSEntry.

Fix test and implementation

Sat, Sep 7, 9:29 PM · Frameworks
meven updated the diff for D7446: [Places panel] Revamp the Recently Saved section.

Use new folder-open-recent for /locations bookmark

Sat, Sep 7, 9:04 PM · Frameworks, Dolphin
meven added a comment to D23761: Make small recent documents icons look like documents and improve clock emblems.

Is that the expected result ?

Sat, Sep 7, 9:02 PM · Frameworks
meven updated the diff for D23742: Add two special cases url recentlyused:/files and recentlyused:/folders.

Use new folder-open-recent for /locations

Sat, Sep 7, 8:25 PM · Frameworks, Dolphin

Fri, Sep 6

meven added a comment to D23760: Create new "Recent folders" icon.

The document icons will also need adjustment to match this style, and also to correct some related visual deficiencies (e.g. the lack of a folded corner). We can do that next.

Fri, Sep 6, 9:24 PM · Frameworks
meven added a comment to D7446: [Places panel] Revamp the Recently Saved section.

Conditionalize the code here with version ifdefs so that people only get both new entries when using kio-extras from 19.12.0

Fri, Sep 6, 9:16 PM · Frameworks, Dolphin
meven added a comment to D23760: Create new "Recent folders" icon.

Also it seems to me the icon is not very similar to


The thickness of the clock pen in particular.
They should be somewhat reminiscent of one another IMHO.

Fri, Sep 6, 8:43 PM · Frameworks
meven committed R159:df52b1a382af: Add Term::Type::files() and Term::Type::directories() to filter only… (authored by meven).
Add Term::Type::files() and Term::Type::directories() to filter only…
Fri, Sep 6, 4:31 PM
meven closed D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them.
Fri, Sep 6, 4:31 PM · Frameworks
meven updated the diff for D7446: [Places panel] Revamp the Recently Saved section.

Add two entries to Recent 'Recent Files' and 'Recent Locations'

Fri, Sep 6, 3:49 PM · Frameworks, Dolphin
meven updated the test plan for D7446: [Places panel] Revamp the Recently Saved section.
Fri, Sep 6, 3:49 PM · Frameworks, Dolphin
meven added a comment to D7446: [Places panel] Revamp the Recently Saved section.
In D7446#526494, @meven wrote:

It would be great to have two different icons for recentlyused:/locations and recentlyused:/files.
Also I am not sure recentlyuserd:/ should use "document-open-recent-symbolic" since it is monochrone, the kio declares currently "document-open-recent".
Maybe "folder-temp" for /locations.
Any suggestion @ngraham ?

Good point. We probably need a new icon. document-open-recent is fine for recentlyused:/files, however for recentlyused:/locations we'll need a folder-open-recent that uses the same style, but with a folder as the background instead of a file. Ideally both would also have appropriate colorful versions for the >22px sizes but that's not a hard requirement.

There's plenty of time before the 19.12 release. Please file a bug to Breeze | Icons requesting the new icon and mention it in the VDG chatroom. Thanks!

Fri, Sep 6, 6:15 AM · Frameworks, Dolphin
meven added a comment to D7446: [Places panel] Revamp the Recently Saved section.

It would be great to have two different icons for recentlyused:/locations and recentlyused:/files.
Also I am not sure recentlyuserd:/ should use "document-open-recent-symbolic" since it is monochrone, the kio declares currently "document-open-recent".
Maybe "folder-temp" for /locations.
Any suggestion @ngraham ?

Fri, Sep 6, 4:17 AM · Frameworks, Dolphin
meven committed R260:c6a5b405fd35: Save the Mimetype of opened resources (authored by meven).
Save the Mimetype of opened resources
Fri, Sep 6, 3:58 AM
meven closed D23741: Save the Mimetype of opened resources.
Fri, Sep 6, 3:58 AM · Gwenview
meven updated the diff for D23742: Add two special cases url recentlyused:/files and recentlyused:/folders.

Use Terms::Type::directories()

Fri, Sep 6, 3:25 AM · Frameworks, Dolphin
meven added a comment to D7446: [Places panel] Revamp the Recently Saved section.

@ngraham you added some dependencies but D23737 and D23741 are not direct dependencies, but rather related fixes.
Still, I don't mind leaving them as dependencies.

Fri, Sep 6, 3:25 AM · Frameworks, Dolphin
meven updated the diff for D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them.

Spacing

Fri, Sep 6, 3:16 AM · Frameworks
meven updated the diff for D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them.

Rename constant LOCATIONS_TYPE_TAG -> DIRECTORIES_TYPE_TAG bis

Fri, Sep 6, 3:14 AM · Frameworks
meven updated the diff for D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them.

Rename constant LOCATIONS_TYPE_TAG -> DIRECTORIES_TYPE_TAG

Fri, Sep 6, 3:12 AM · Frameworks
meven retitled D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them from Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding then to Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them.
Fri, Sep 6, 3:10 AM · Frameworks
meven retitled D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them from Add Term::Type::files() and Term::Type::locations() to filter excluding or only directories to Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding then.
Fri, Sep 6, 3:10 AM · Frameworks
meven updated the diff for D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them.

Rename locations to directories

Fri, Sep 6, 3:10 AM · Frameworks

Thu, Sep 5

meven retitled D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them from Add a Term::Type::files() to filter excluding directories to Add Term::Type::files() and Term::Type::locations() to filter excluding or only directories.
Thu, Sep 5, 8:39 PM · Frameworks
meven updated the diff for D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them.

Add Term::Type::locations

Thu, Sep 5, 8:39 PM · Frameworks
meven updated the diff for D23742: Add two special cases url recentlyused:/files and recentlyused:/folders.

grammar

Thu, Sep 5, 8:36 PM · Frameworks, Dolphin
meven updated the diff for D23742: Add two special cases url recentlyused:/files and recentlyused:/folders.

typo

Thu, Sep 5, 7:02 PM · Frameworks, Dolphin
meven updated the diff for D23742: Add two special cases url recentlyused:/files and recentlyused:/folders.

Replace /folders by /locations, add some documentation

Thu, Sep 5, 7:02 PM · Frameworks, Dolphin
meven updated the diff for D23742: Add two special cases url recentlyused:/files and recentlyused:/folders.

Add some const

Thu, Sep 5, 6:52 PM · Frameworks, Dolphin
meven committed R161:3cd9e64d359b: Extract mimetype from recentlyused.xbel (authored by meven).
Extract mimetype from recentlyused.xbel
Thu, Sep 5, 6:23 PM
meven closed D23737: Extract mimetype from recentlyused.xbel.
Thu, Sep 5, 6:23 PM · Plasma
meven updated the diff for D23742: Add two special cases url recentlyused:/files and recentlyused:/folders.

Rephrase 'Recent Folders' to 'Recent Locations'

Thu, Sep 5, 5:58 PM · Frameworks, Dolphin
meven added a comment to D7446: [Places panel] Revamp the Recently Saved section.

Fantastic work. That's exactly what I had in mind and it works perfectly!

With those, we can have Recent Files and Recent Locations (or maybe Recent Folders) in the Recent section, and we can get rid of the existing Today entry. That will make this patch perfect.

Thu, Sep 5, 5:57 PM · Frameworks, Dolphin
meven updated the diff for D23737: Extract mimetype from recentlyused.xbel.

const QString &mimetype

Thu, Sep 5, 5:52 PM · Plasma
meven added a comment to D7446: [Places panel] Revamp the Recently Saved section.
In D7446#526039, @meven wrote:

This works great.

one minor concern I have with the new IOSlave in general is how it shows both files and folders. For me, the folders are a distraction from the file listing. But I was thinking: how about adding modes that allow it to show only files or only folders? Like the IOSlave could support recentlyused:/files and recentlyused:/folders, each of which would limit the display to just those things. Then under the "Recent" section, we could have "Recent Files" and "Recent Locations", which would allow us to remove the useless old "Today" entry without any trouble.

This would provide a better fix for https://bugs.kde.org/show_bug.cgi?id=159299.

Great suggestions, I will add those to the kio slave.

Thu, Sep 5, 3:53 PM · Frameworks, Dolphin
meven added a dependent revision for D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them: D23742: Add two special cases url recentlyused:/files and recentlyused:/folders.
Thu, Sep 5, 3:51 PM · Frameworks
meven requested review of D23742: Add two special cases url recentlyused:/files and recentlyused:/folders.
Thu, Sep 5, 3:51 PM · Frameworks, Dolphin
meven updated the diff for D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them.

Exclude files whose mimetype is not known from the files filter

Thu, Sep 5, 3:46 PM · Frameworks