meven (Méven Car)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 10 2018, 12:40 PM (91 w, 4 d)
Availability
Available

Recent Activity

Today

meven added a comment to D25010: [StatJob] Use A QFlag to specify the details returned by StatJob.

friendly ping

Thu, Nov 14, 8:41 AM · Frameworks
meven added a comment to D25117: file ioslave: stop copying as soon as the ioslave is killed.

Anyone to review this ? 30 lines change + test

Thu, Nov 14, 8:37 AM · Frameworks
meven committed R241:80d5f52b0675: [DeleteJob] Use a separate worker thread to run actual IO operation (authored by meven).
[DeleteJob] Use a separate worker thread to run actual IO operation
Thu, Nov 14, 8:35 AM
meven closed D24962: [DeleteJob] Use a separate worker thread to run actual IO operation.
Thu, Nov 14, 8:35 AM · Frameworks

Yesterday

meven added a comment to D23507: Replace custom single threaded merge sort with std::stable_sort.

Seems sane to me and nice since it removes some code.

Wed, Nov 13, 12:43 PM · Dolphin
meven added a comment to D22801: [KIO] silence a QFileInfo warning.

The issue could be as well located in previewjob.cpp.
Could you debug why KMountPoint::List::findByPath is called with an empty string or non-existing file.
We might want to prevent this to happen instead.

Wed, Nov 13, 12:35 PM · Frameworks

Tue, Nov 12

meven added a comment to D20427: When renaming files, move to next file using tab key..

This is a nice patch with just a few rough edges to polish.
I encourage @msciubidlo to have a look again.

Tue, Nov 12, 2:03 PM · Dolphin
meven added a comment to D22802: [dolphin] make link with LLVM.

ping @rjvbb
Do you want someone else to commit this patch or do you want to do it yourself https://community.kde.org/Infrastructure/Phabricator ?

Tue, Nov 12, 1:54 PM · Dolphin
meven added a comment to D18838: Fix opening http links in browser.

ping @broulik

Tue, Nov 12, 1:39 PM · Dolphin
meven updated the summary of D18838: Fix opening http links in browser.
Tue, Nov 12, 1:39 PM · Dolphin
meven updated the summary of D25242: Allow dolphin to format DateTime at later stage than KBalooRolesProvider.
Tue, Nov 12, 12:57 PM · Dolphin
meven committed R318:e2e43c907393: Allow dolphin to format DateTime at later stage than KBalooRolesProvider (authored by meven).
Allow dolphin to format DateTime at later stage than KBalooRolesProvider
Tue, Nov 12, 12:51 PM
meven closed D25242: Allow dolphin to format DateTime at later stage than KBalooRolesProvider.
Tue, Nov 12, 12:51 PM · Dolphin
meven abandoned D10702: Always use a job to delete files to avoid freezing process waiting on IO.

Abandoned in favor of D24962

Tue, Nov 12, 12:33 PM · Frameworks
meven committed R318:89a7b316d1a1: [Information Panel] Allows to refresh icon and metadata for urls such as trash:/ (authored by meven).
[Information Panel] Allows to refresh icon and metadata for urls such as trash:/
Tue, Nov 12, 7:21 AM
meven closed D23668: [Information Panel] Allows to refresh icon and metadata for urls such as trash:/.
Tue, Nov 12, 7:21 AM · Dolphin

Mon, Nov 11

meven updated the diff for D23668: [Information Panel] Allows to refresh icon and metadata for urls such as trash:/.

Bump KF5_MIN_VERSION to 5.64

Mon, Nov 11, 5:18 PM · Dolphin
meven updated the diff for D23668: [Information Panel] Allows to refresh icon and metadata for urls such as trash:/.

Rebase patch

Mon, Nov 11, 5:15 PM · Dolphin
meven committed R320:49440c0cbea1: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue (authored by meven).
Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue
Mon, Nov 11, 4:23 PM
meven closed D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue.
Mon, Nov 11, 4:23 PM · Frameworks, Dolphin
meven accepted D24433: Move URL parsing methods from kioslave to query object.

Seems good to me.
Tested and works

Mon, Nov 11, 11:20 AM · Baloo, Frameworks
meven added a reviewer for D24433: Move URL parsing methods from kioslave to query object: astippich.
Mon, Nov 11, 11:12 AM · Baloo, Frameworks
meven added a reviewer for D24433: Move URL parsing methods from kioslave to query object: ngraham.
Mon, Nov 11, 11:11 AM · Baloo, Frameworks
meven abandoned D24760: Enable Hidpi support.

Abandonned in favor of D19920

Mon, Nov 11, 11:04 AM
meven accepted D19920: Add High DPI support.

LGTM

Mon, Nov 11, 11:04 AM
meven added inline comments to D25079: [CopyJob] Increase the amount of data sendfile can copy at once.
Mon, Nov 11, 8:12 AM · Frameworks

Sun, Nov 10

meven requested review of D25242: Allow dolphin to format DateTime at later stage than KBalooRolesProvider.
Sun, Nov 10, 5:15 PM · Dolphin
meven updated the diff for D24911: Check zstd lzma are really available.

Clean double lz4 checks

Sun, Nov 10, 11:42 AM · Ark
meven retitled D24911: Check zstd lzma are really available from Check zstd, lz4 lzma are really available to Check zstd lzma are really available.
Sun, Nov 10, 11:29 AM · Ark
meven updated the summary of D24911: Check zstd lzma are really available.
Sun, Nov 10, 11:22 AM · Ark
meven updated the diff for D24911: Check zstd lzma are really available.

Add missing lz4 check

Sun, Nov 10, 11:22 AM · Ark
meven accepted D25230: PlacesItemModel: remove redundant set of properties.
Sun, Nov 10, 7:05 AM · Dolphin
meven updated the summary of D25230: PlacesItemModel: remove redundant set of properties.
Sun, Nov 10, 6:51 AM · Dolphin

Sat, Nov 9

meven committed R318:31bc909c3bd0: [Status Bar] Remove file status Timer, add text update delay (authored by meven).
[Status Bar] Remove file status Timer, add text update delay
Sat, Nov 9, 9:07 PM
meven closed D25218: [Status Bar] Remove file status Timer, add text update delay.
Sat, Nov 9, 9:07 PM · Dolphin
meven retitled D25218: [Status Bar] Remove file status Timer, add text update delay from [Status Bar] Remove file status Timer to [Status Bar] Remove file status Timer, add text update delay.
Sat, Nov 9, 8:59 PM · Dolphin
meven updated the diff for D25218: [Status Bar] Remove file status Timer, add text update delay.

Add m_textTimestamp constructor initializer

Sat, Nov 9, 8:57 PM · Dolphin
meven updated the diff for D25218: [Status Bar] Remove file status Timer, add text update delay.

Amend commit comment, add some comments

Sat, Nov 9, 8:55 PM · Dolphin
meven updated the summary of D25218: [Status Bar] Remove file status Timer, add text update delay.
Sat, Nov 9, 8:50 PM · Dolphin
meven added a reviewer for D25117: file ioslave: stop copying as soon as the ioslave is killed: apol.
Sat, Nov 9, 2:36 PM · Frameworks
meven updated the diff for D24911: Check zstd lzma are really available.

nitpicks formatting and naming

Sat, Nov 9, 2:30 PM · Ark
meven updated the summary of D24911: Check zstd lzma are really available.
Sat, Nov 9, 2:20 PM · Ark
meven added a comment to D25218: [Status Bar] Remove file status Timer, add text update delay.

I am not so sure about this 150 ms delay.
When navigating with the keyboard, it is quite noticeable.
So in the meantime, I am gonna reduce this delay to 50 ms.

Removing it altogether might be appropriate.

Just as a reminder, the information panel delay is mostly due to technicalities : thumbnail generation and metadata extraction are costly.
Whereas here we don't have such reasons to limit text refreshing.

Another thing to mention is that the information panel is not even visible by default.

This 1s timer was added by 1ea09b24e16d98ac2f1033b without explaining why, so I think we can safely remove it. So I'd restore the previous version of this patch that removed the timer altogether.

Sat, Nov 9, 2:15 PM · Dolphin
meven updated the diff for D25218: [Status Bar] Remove file status Timer, add text update delay.

Reduce update delay to 50ms

Sat, Nov 9, 7:24 AM · Dolphin
meven committed R304:d9258f219328: Add OBS to screenrecorders (authored by meven).
Add OBS to screenrecorders
Sat, Nov 9, 7:23 AM
meven closed D25221: Add OBS to screenrecorders.
Sat, Nov 9, 7:23 AM · Frameworks
meven added a comment to D25218: [Status Bar] Remove file status Timer, add text update delay.

I am not so sure about this 150 ms delay.
When navigating with the keyboard, it is quite noticeable.
So in the meantime, I am gonna reduce this delay to 50 ms.

Sat, Nov 9, 7:21 AM · Dolphin

Fri, Nov 8

meven added a comment to D25218: [Status Bar] Remove file status Timer, add text update delay.

Will wait for @elvisangelaccio feedback for a few days.

Fri, Nov 8, 5:53 PM · Dolphin
meven committed R304:cdafed6b395f: Fix a couple of broken links, update links to https://kde.org/applications/ (authored by meven).
Fix a couple of broken links, update links to https://kde.org/applications/
Fri, Nov 8, 5:50 PM
meven closed D25215: Fix a couple of broken links, update links to https://kde.org/applications/.
Fri, Nov 8, 5:50 PM · Frameworks
meven updated the diff for D25221: Add OBS to screenrecorders.

Remove translations

Fri, Nov 8, 5:47 PM · Frameworks
meven added a comment to D25215: Fix a couple of broken links, update links to https://kde.org/applications/.

In an ideal world the OBS stuff would be in a separate patch. :)

Fri, Nov 8, 5:40 PM · Frameworks
meven updated the diff for D25215: Fix a couple of broken links, update links to https://kde.org/applications/.

Split obs changes to D25221

Fri, Nov 8, 5:39 PM · Frameworks
meven updated the summary of D25215: Fix a couple of broken links, update links to https://kde.org/applications/.
Fri, Nov 8, 5:38 PM · Frameworks
meven retitled D25215: Fix a couple of broken links, update links to https://kde.org/applications/ from Fix a couple of broken links, update links to https://kde.org/applications/, add obs to Fix a couple of broken links, update links to https://kde.org/applications/.
Fri, Nov 8, 5:38 PM · Frameworks
meven requested review of D25221: Add OBS to screenrecorders.
Fri, Nov 8, 5:36 PM · Frameworks
meven updated the diff for D25215: Fix a couple of broken links, update links to https://kde.org/applications/.

rebasing on master

Fri, Nov 8, 5:26 PM · Frameworks
meven updated the diff for D25215: Fix a couple of broken links, update links to https://kde.org/applications/.

rebase on master

Fri, Nov 8, 5:18 PM · Frameworks
meven closed D25216: Fix translations of $GenericName.
Fri, Nov 8, 5:16 PM · Frameworks
meven committed R304:91f212f983ef: Fix translations of $GenericName (authored by meven).
Fix translations of $GenericName
Fri, Nov 8, 5:16 PM
meven added a comment to D25216: Fix translations of $GenericName.

LGTM since it fixes the issue.

A next step could be a clearer explaination of what $GenericName will be replaced with. Is it always replaced with Filelight's GenericName from its filelight.desktop file?

Fri, Nov 8, 5:15 PM · Frameworks
meven updated the diff for D25215: Fix a couple of broken links, update links to https://kde.org/applications/.

Reapply some lost changes

Fri, Nov 8, 5:13 PM · Frameworks
meven updated the diff for D25215: Fix a couple of broken links, update links to https://kde.org/applications/.

Add OBS entry to screenrecorders

Fri, Nov 8, 5:10 PM · Frameworks
meven updated the summary of D25215: Fix a couple of broken links, update links to https://kde.org/applications/.
Fri, Nov 8, 5:08 PM · Frameworks
meven added a comment to D25216: Fix translations of $GenericName.

@aspotashev Is it good for ?

Fri, Nov 8, 4:31 PM · Frameworks
meven updated the diff for D25218: [Status Bar] Remove file status Timer, add text update delay.

Delay by 150ms before the status bar text is updated

Fri, Nov 8, 4:29 PM · Dolphin
meven updated the diff for D25216: Fix translations of $GenericName.

Better translator-friendly implementation

Fri, Nov 8, 3:58 PM · Frameworks
meven added a comment to D25216: Fix translations of $GenericName.

I suggest a more flexible approach which allows translators to more around the "$GenericName" part inside their translation and change the " - " separator to anything more appropriate in their language:

i18nc("@action:inmenu %1=\"$GenericName\"", "%1 - current folder", "$GenericName")

(and so on for the other messages)

Fri, Nov 8, 3:52 PM · Frameworks
meven added a reviewer for D25117: file ioslave: stop copying as soon as the ioslave is killed: ngraham.
Fri, Nov 8, 3:50 PM · Frameworks
meven updated the diff for D25215: Fix a couple of broken links, update links to https://kde.org/applications/.

Replace remaning kde project links to https://kde.org/applications/

Fri, Nov 8, 3:47 PM · Frameworks
meven updated the diff for D25218: [Status Bar] Remove file status Timer, add text update delay.

Update commit message

Fri, Nov 8, 3:44 PM · Dolphin
meven retitled D25218: [Status Bar] Remove file status Timer, add text update delay from [Status Bar] Remove file status Timer i to [Status Bar] Remove file status Timer.
Fri, Nov 8, 3:43 PM · Dolphin
meven requested review of D25218: [Status Bar] Remove file status Timer, add text update delay.
Fri, Nov 8, 3:43 PM · Dolphin
meven updated the diff for D25215: Fix a couple of broken links, update links to https://kde.org/applications/.

amend comment

Fri, Nov 8, 3:34 PM · Frameworks
meven retitled D25215: Fix a couple of broken links, update links to https://kde.org/applications/ from Fix a couple of broken links to Fix a couple of broken links, update links to https://kde.org/applications/.
Fri, Nov 8, 3:34 PM · Frameworks
meven updated the diff for D25215: Fix a couple of broken links, update links to https://kde.org/applications/.

Fix kdf link and update others

Fri, Nov 8, 3:32 PM · Frameworks
meven added a comment to D25215: Fix a couple of broken links, update links to https://kde.org/applications/.

We should use the kde.org/applications links, e.g. https://kde.org/applications/system/org.kde.kdf, not https://utils.kde.org/projects/kdf

Fri, Nov 8, 3:29 PM · Frameworks
meven updated the diff for D25216: Fix translations of $GenericName.

Amend comment

Fri, Nov 8, 3:11 PM · Frameworks
meven updated the summary of D25216: Fix translations of $GenericName.
Fri, Nov 8, 3:11 PM · Frameworks
meven added reviewers for D25216: Fix translations of $GenericName: leinir, ngraham.
Fri, Nov 8, 3:10 PM · Frameworks
meven requested review of D25216: Fix translations of $GenericName.
Fri, Nov 8, 3:10 PM · Frameworks
meven requested review of D25215: Fix a couple of broken links, update links to https://kde.org/applications/.
Fri, Nov 8, 2:38 PM · Frameworks
meven added a comment to D25117: file ioslave: stop copying as soon as the ioslave is killed.

friendly ping

Fri, Nov 8, 12:06 PM · Frameworks
meven added inline comments to D24720: [applets/systemtray] Rewrite popups with layouts.
Fri, Nov 8, 7:43 AM · Plasma

Thu, Nov 7

meven abandoned D25190: Translates the Search placeholder in kcm_kwin_effects.

I saw from other code in plasma this was common to do this replacement.

Where? There are lots of TextFields with the placeholder set.

The SearchFields I found (notifications KCM, systemsettings, discover) didn't.

Thu, Nov 7, 2:03 PM · KWin
meven added a comment to D25190: Translates the Search placeholder in kcm_kwin_effects.

Kirigami has:
SearchField.qml

placeholderText: qsTr("Search...")

If there is a bug (lack of domain set / loaded) we need to fix that at the root.

Thu, Nov 7, 1:33 PM · KWin
meven requested review of D25190: Translates the Search placeholder in kcm_kwin_effects.
Thu, Nov 7, 12:54 PM · KWin
meven added a comment to D25010: [StatJob] Use A QFlag to specify the details returned by StatJob.

I feel the code is ready for review toward merging.

Thu, Nov 7, 12:31 PM · Frameworks
meven updated the diff for D25010: [StatJob] Use A QFlag to specify the details returned by StatJob.

Add Stat prefix to enum values of KIO::StatDetail

Thu, Nov 7, 12:27 PM · Frameworks
meven added a comment to T9233: Wayland Thumbnails.

I guess https://source.puri.sm/Librem5/wlroots/blob/librem5-0.6.x/types/wlr_export_dmabuf_v1.c can be used as inspiration for our own implementation.
Added in https://source.puri.sm/Librem5/wlroots/commit/36bd4795d4fe2282dfcc59f26863bac2896a4a3f

Thu, Nov 7, 11:31 AM · Plasma on Wayland

Wed, Nov 6

meven committed R161:0b36c8f9aa46: Remove transient file CMakeLists.txt.user (authored by meven).
Remove transient file CMakeLists.txt.user
Wed, Nov 6, 3:38 PM
meven added a comment to T11551: use C++ modern features.

We can use clang-tidy and its fixits to modernize code.

Wed, Nov 6, 3:23 PM · KF6
meven committed R242:000022b66892: MobileTextActionsToolBar check if controlRoot is undefined before using it (authored by meven).
MobileTextActionsToolBar check if controlRoot is undefined before using it
Wed, Nov 6, 2:20 PM
meven closed D25164: MobileTextActionsToolBar check if controlRoot is undefined before using it.
Wed, Nov 6, 2:20 PM · Frameworks
meven requested review of D25164: MobileTextActionsToolBar check if controlRoot is undefined before using it.
Wed, Nov 6, 9:51 AM · Frameworks
meven added inline comments to D24962: [DeleteJob] Use a separate worker thread to run actual IO operation.
Wed, Nov 6, 9:04 AM · Frameworks
meven updated the diff for D24962: [DeleteJob] Use a separate worker thread to run actual IO operation.

Use m_current instead of passing const QUrl &url around

Wed, Nov 6, 9:00 AM · Frameworks
meven updated the summary of D24962: [DeleteJob] Use a separate worker thread to run actual IO operation.
Wed, Nov 6, 8:50 AM · Frameworks

Mon, Nov 4

meven updated the diff for D25010: [StatJob] Use A QFlag to specify the details returned by StatJob.

Move KIO::StatJob::StatDetail(s) to KIO::StatDetail(s), wrapped old details metadata code path with KIOCORE_ENABLE_DEPRECATED_SINCE

Mon, Nov 4, 12:23 PM · Frameworks
meven committed R161:fbcd08aacb5f: Rename cmake project to KActivityManagerd, remove unused option (authored by meven).
Rename cmake project to KActivityManagerd, remove unused option
Mon, Nov 4, 11:59 AM