meven (Méven Car)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 10 2018, 12:40 PM (120 w, 4 d)
Availability
Available

Recent Activity

Yesterday

meven added a comment to T11601: Primary Clipboard (middle click) Support.

The patch has landed :
https://invent.kde.org/plasma/kwayland-server/-/merge_requests/15
https://invent.kde.org/plasma/kwin/-/merge_requests/27

Wed, Jun 3, 3:48 PM · Plasma on Wayland
meven accepted D29807: Change Chrome API design.

@broulik perhaps a review ?

Wed, Jun 3, 7:24 AM · Plasma

Tue, Jun 2

meven added a comment to D29397: KPreviewJob : Support for DeviceRatioPixel.

To not have that block this improvement, you could in parallel for now use a "kde" namespaced directories, say "*@kde2x/", where we/you could just use the for-now-KF-only theme extension. And once there is an agreed specification extension, the code could be switched to just any non-namespace shared hidpi folder matching whatever the specification ended up to be.

Tue, Jun 2, 3:10 PM · Frameworks
meven added a comment to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

Hmm, for me this breaks the option to open a new instance when the PrintScreen key is pressed and an existing instance is already running. It only works if I launch Spectacle manually using the --new-instance flag. The feature should work regardless of how the app is launched.

Tue, Jun 2, 1:07 PM · Spectacle
meven added a comment to D28544: RecentDocuments Runner: Cleanup and formatting.

Well @alex https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/31 was merged, so if you are still up to do it, now is a good time to rebase your changes.

Tue, Jun 2, 10:13 AM · Plasma
meven committed R127:dfd852abd913: OutputDevice: mark them as disabled initially (authored by meven).
OutputDevice: mark them as disabled initially
Tue, Jun 2, 9:10 AM
meven committed R108:1b1831a5ac53: Merge branch 'Plasma/5.19' of https://invent.kde.org/plasma/kwin (authored by meven).
Merge branch 'Plasma/5.19' of https://invent.kde.org/plasma/kwin
Tue, Jun 2, 9:08 AM
meven committed R108:1a50c98f4a99: [scene] Avoid a crash when currentPixmap is invalid and previousPixmap is null… (authored by meven).
[scene] Avoid a crash when currentPixmap is invalid and previousPixmap is null…
Tue, Jun 2, 9:07 AM
meven committed R108:ebf4c6230031: Fix build (authored by zzag).
Fix build
Tue, Jun 2, 9:05 AM
meven committed R108:9da9ab753987: [scene] Avoid a crash when currentPixmap is invalid and previousPixmap is null… (authored by meven).
[scene] Avoid a crash when currentPixmap is invalid and previousPixmap is null…
Tue, Jun 2, 9:05 AM
meven committed R108:3442666ede68: [effects/logout] Start the animation on only windowAdded or windowClosed (authored by zzag).
[effects/logout] Start the animation on only windowAdded or windowClosed
Tue, Jun 2, 9:05 AM
meven committed R108:f0d8109dfe6a: [effects/slidingpopups] Start the animation on only windowAdded or windowClosed (authored by zzag).
[effects/slidingpopups] Start the animation on only windowAdded or windowClosed
Tue, Jun 2, 9:05 AM
meven committed R108:003274ce582c: [effects/fade] Start the animation on only windowAdded or windowClosed (authored by zzag).
[effects/fade] Start the animation on only windowAdded or windowClosed
Tue, Jun 2, 9:05 AM
meven committed R108:aadcc712160d: [wayland] Rework xdg-shell implementation (authored by zzag).
[wayland] Rework xdg-shell implementation
Tue, Jun 2, 9:05 AM
meven committed R108:a238f3af6835: [effects/zoom] Implement text caret tracking (authored by zzag).
[effects/zoom] Implement text caret tracking
Tue, Jun 2, 9:05 AM
meven committed R108:ecddb37316a4: [effects/zoom] Implement focus tracking with QAccessibilityClient (authored by zzag).
[effects/zoom] Implement focus tracking with QAccessibilityClient
Tue, Jun 2, 9:05 AM
meven committed R108:3717579733f6: Notify about decoration theme change (authored by gikari).
Notify about decoration theme change
Tue, Jun 2, 9:05 AM
meven committed R108:b599531f42d3: [kcm/kwinrules] Detect also window complete class (authored by iasensio).
[kcm/kwinrules] Detect also window complete class
Tue, Jun 2, 9:05 AM
meven committed R108:a650e6520f3e: Don't compare string with empty string (authored by ognarb).
Don't compare string with empty string
Tue, Jun 2, 9:05 AM
meven committed R108:5089ff179a39: Take in consideration keyboard shortcuts inhibit rename to V1 (authored by bport).
Take in consideration keyboard shortcuts inhibit rename to V1
Tue, Jun 2, 9:05 AM
meven committed R108:ce06eea000ad: Add support to keyboard shortcuts inhibitor (authored by bport).
Add support to keyboard shortcuts inhibitor
Tue, Jun 2, 9:05 AM
meven committed R108:8a7743f332c9: Wayland server getters => const (authored by bport).
Wayland server getters => const
Tue, Jun 2, 9:05 AM
meven committed R108:f28e4268ab11: Clean #if version check blocks (authored by meven).
Clean #if version check blocks
Tue, Jun 2, 9:05 AM
meven committed R108:b9d6710179cb: [wayland] Adjust to kwayland-server changes (authored by zzag).
[wayland] Adjust to kwayland-server changes
Tue, Jun 2, 9:05 AM
meven committed R108:449bc085bdf8: [wayland] Allow nested mode to have a fractional scale < 1 (authored by davidedmundson).
[wayland] Allow nested mode to have a fractional scale < 1
Tue, Jun 2, 9:05 AM
meven committed R108:8db5a9a58a51: DrmOutput: Ensure waylandOutput dpms mode matches DrmOutputs (authored by meven).
DrmOutput: Ensure waylandOutput dpms mode matches DrmOutputs
Tue, Jun 2, 9:05 AM
meven committed R108:3eea5fab5f44: [effects/blur] Update to kwayland changes (authored by davidedmundson).
[effects/blur] Update to kwayland changes
Tue, Jun 2, 9:05 AM
meven committed R108:6fcc851efb48: [wayland] Create DataControlDeviceManager (authored by davidedmundson).
[wayland] Create DataControlDeviceManager
Tue, Jun 2, 9:05 AM
meven committed R108:9138b598edaa: [xwl] Update to kwaylandserver changes (authored by davidedmundson).
[xwl] Update to kwaylandserver changes
Tue, Jun 2, 9:05 AM
meven committed R108:38ee8b888946: Improve code readability of presentwindows effect (authored by muesli).
Improve code readability of presentwindows effect
Tue, Jun 2, 9:04 AM
meven committed R108:55854b472a1c: Change CommandAllKey to Meta (authored by ndavis).
Change CommandAllKey to Meta
Tue, Jun 2, 9:04 AM
meven committed R108:d199bfe635f3: Position OSD a bit farther down (authored by ngraham).
Position OSD a bit farther down
Tue, Jun 2, 9:04 AM
meven committed R108:aef1e4d1239c: Drm backend: delete DrmOutput* after DrmScreens notified its users (authored by meven).
Drm backend: delete DrmOutput* after DrmScreens notified its users
Tue, Jun 2, 9:04 AM
meven committed R108:aa7b1b39c0b1: GIT_SILENT: add KWin icon as repository logo (authored by IlyaBizyaev).
GIT_SILENT: add KWin icon as repository logo
Tue, Jun 2, 9:04 AM
meven committed R108:21ab0bc46f80: scripting: Provide methods to create and remove virtual desktops (authored by tcorreabr).
scripting: Provide methods to create and remove virtual desktops
Tue, Jun 2, 9:04 AM
meven committed R108:65fb872ee669: GIT_SILENT: we don't use phabricator now (authored by mlaurent).
GIT_SILENT: we don't use phabricator now
Tue, Jun 2, 9:04 AM
meven committed R108:32ab9c1afb71: Improve opengl debug messages (authored by apol).
Improve opengl debug messages
Tue, Jun 2, 9:04 AM
meven committed R108:9f9691c73ae5: Update version number for 5.19.80 GIT_SILENT (authored by jriddell).
Update version number for 5.19.80 GIT_SILENT
Tue, Jun 2, 9:04 AM
meven committed R108:67b6053a9450: Properly include private Qt5 targets (authored by apol).
Properly include private Qt5 targets
Tue, Jun 2, 9:04 AM
meven committed R108:4fa7d867cef3: Fix TestXdgShellClient::testDesktopFileName (authored by apol).
Fix TestXdgShellClient::testDesktopFileName
Tue, Jun 2, 9:04 AM
meven committed R108:5af0b6a47307: wayland_server: Improve debug message, reduce duplicates (authored by apol).
wayland_server: Improve debug message, reduce duplicates
Tue, Jun 2, 9:04 AM
meven committed R108:27a0a3e37a08: Improve partial maximization strings (authored by ngraham).
Improve partial maximization strings
Tue, Jun 2, 9:04 AM
meven committed R108:c7737b77c190: Store normal clients and desktop clients in the same list (authored by zzag).
Store normal clients and desktop clients in the same list
Tue, Jun 2, 9:04 AM
meven committed R108:b2ca9b86876a: Fix org.telegram.desktop identification (authored by apol).
Fix org.telegram.desktop identification
Tue, Jun 2, 9:04 AM
meven committed R108:0c2f7969f76d: [scene] Avoid a crash when currentPixmap is invalid and previousPixmap is null… (authored by meven).
[scene] Avoid a crash when currentPixmap is invalid and previousPixmap is null…
Tue, Jun 2, 8:49 AM
meven committed R108:cb173fbba0f8: [scene] Avoid a crash when currentPixmap is invalid and previousPixmap is null… (authored by meven).
[scene] Avoid a crash when currentPixmap is invalid and previousPixmap is null…
Tue, Jun 2, 8:43 AM
meven committed R108:36a82d9cbe4d: Scene windowPixmap: avoid crashing when currentPixmap is invalid and… (authored by meven).
Scene windowPixmap: avoid crashing when currentPixmap is invalid and…
Tue, Jun 2, 8:31 AM
meven committed R108:da7b58a99933: Scene windowPixmap: avoid crashing when currentPixmap is invalid and… (authored by meven).
Scene windowPixmap: avoid crashing when currentPixmap is invalid and…
Tue, Jun 2, 8:25 AM
meven committed R108:16d8b07351ee: Scene windowPixmap: avoid crashnig when current and previousPixmap are null (authored by meven).
Scene windowPixmap: avoid crashnig when current and previousPixmap are null
Tue, Jun 2, 7:55 AM
meven added a comment to D29282: QuickEditor: Allow to take screen region screenshot under Wayland.

Hmm, that's unfortunate. Is there really no cross-compositor screenshot API in Wayland? Every compositor needs to re-invent the wheel?

Tue, Jun 2, 5:24 AM · Spectacle

Mon, Jun 1

meven added a comment to D29213: Status bar: Hide the space free bar when size is unknown.

Will merge soonish if @elvisangelaccio has nothing to say

Mon, Jun 1, 8:49 AM · Dolphin
meven committed R241:ac0556e38833: Fix kfileplacesmodeltest when recentlyused:/ is not present (authored by meven).
Fix kfileplacesmodeltest when recentlyused:/ is not present
Mon, Jun 1, 8:44 AM
meven updated the summary of D29525: Make Previews devicePixelRatio aware.
Mon, Jun 1, 8:31 AM · Dolphin
meven added a comment to D29282: QuickEditor: Allow to take screen region screenshot under Wayland.

I don't think making KScreen a mandatory dependency is going to work. If we do that, then installing Spectacle on a platform other than Plasma is going to try to pull in all of KScreen and its dependencies. It would be half of the Plasma stack.

Mon, Jun 1, 8:24 AM · Spectacle
meven committed R320:e1338bb3b132: Archive Ioslave: use ecm_qt_declare_logging_category (authored by meven).
Archive Ioslave: use ecm_qt_declare_logging_category
Mon, Jun 1, 5:46 AM
meven updated the diff for D29213: Status bar: Hide the space free bar when size is unknown.

Rename member field to m_ready

Mon, Jun 1, 5:43 AM · Dolphin

Sun, May 31

meven added a comment to D27523: Add an option to use a KUrlNavigator on the toolbar instead.

Any progress @felixernst ?

Sun, May 31, 1:24 PM · Dolphin

Sat, May 30

meven committed R241:42da8d28d612: Use a lambda to reduce repeating code and better handle io errors (authored by meven).
Use a lambda to reduce repeating code and better handle io errors
Sat, May 30, 4:59 PM
meven committed R241:7e397227084a: Add tooltip when files are identical (authored by meven).
Add tooltip when files are identical
Sat, May 30, 4:59 PM
meven committed R241:7708234a4ce0: RenameDialog: Show if files are identical (authored by meven).
RenameDialog: Show if files are identical
Sat, May 30, 4:59 PM
meven committed R241:f96575b7c129: Use a lambda to reduce repeating code and better handle io errors (authored by meven).
Use a lambda to reduce repeating code and better handle io errors
Sat, May 30, 4:58 PM
meven committed R241:83e04bc362a6: Use a lambda to reduce repeating code and better handle io errors (authored by meven).
Use a lambda to reduce repeating code and better handle io errors
Sat, May 30, 4:35 PM
meven updated the summary of D29805: Thumbnail djvu: Avoid a crash when djvu is not installed.
Sat, May 30, 4:29 PM · Frameworks, Dolphin
meven added a comment to D29805: Thumbnail djvu: Avoid a crash when djvu is not installed.
In D29805#674225, @pino wrote:
In D29805#674206, @pino wrote:
In D29805#674204, @pino wrote:

FIXED-IN: 20.08

still for 20.08...

Yes kio-extra is released with KDE Applications

Yes, I know. Asked to land this fix instead to release/20.04, and thus change the commit message accordingly.

Please be explicit when you comment, no one could deduce what you meant.

I wrote it two times to land this on the stable branch: the first time when I explained why the initial patch was not correct and what the problem actually was (with hints on short term and long term fixes), and earlier today when I wrote:

In D29805#674185, @pino wrote:

please target release/20.04 for this fix, thanks

There is no need to "deduce" anything, just read what I wrote, thanks.

If this is ready approve and add a comment "land to 20.04".

The commit message still says "20.08", so not yet.

Sat, May 30, 4:29 PM · Frameworks, Dolphin
meven added a comment to D29805: Thumbnail djvu: Avoid a crash when djvu is not installed.
In D29805#674206, @pino wrote:
In D29805#674204, @pino wrote:

FIXED-IN: 20.08

still for 20.08...

Yes kio-extra is released with KDE Applications

Yes, I know. Asked to land this fix instead to release/20.04, and thus change the commit message accordingly.

Sat, May 30, 3:53 PM · Frameworks, Dolphin
meven added a comment to D29805: Thumbnail djvu: Avoid a crash when djvu is not installed.
In D29805#674204, @pino wrote:

FIXED-IN: 20.08

still for 20.08...

Sat, May 30, 1:33 PM · Frameworks, Dolphin
meven committed R120:c1b97eab1f6b: Runner: make recentdocument use KActivityStats data (authored by meven).
Runner: make recentdocument use KActivityStats data
Sat, May 30, 1:31 PM
meven committed R318:8aa7cde289d8: Prevents showing StatJob Progress info (authored by meven).
Prevents showing StatJob Progress info
Sat, May 30, 1:02 PM
meven committed R318:118616d64a0d: Prevents showing StatJob Progress info (authored by meven).
Prevents showing StatJob Progress info
Sat, May 30, 11:59 AM
meven updated the summary of D29213: Status bar: Hide the space free bar when size is unknown.
Sat, May 30, 11:29 AM · Dolphin
meven updated the diff for D29805: Thumbnail djvu: Avoid a crash when djvu is not installed.

Remove brackets

Sat, May 30, 11:16 AM · Frameworks, Dolphin
meven committed R241:1064275cf6b5: fix kfileplacesviewtest.cpp (authored by meven).
fix kfileplacesviewtest.cpp
Sat, May 30, 11:14 AM
meven committed R320:20971687e2bc: Archive Ioslave: use ecm_qt_declare_logging_category (authored by meven).
Archive Ioslave: use ecm_qt_declare_logging_category
Sat, May 30, 11:05 AM
meven committed R320:4ddfe8a8c613: Archive Ioslave: use ecm_qt_declare_logging_category (authored by meven).
Archive Ioslave: use ecm_qt_declare_logging_category
Sat, May 30, 11:04 AM
meven committed R320:1f863f3d2127: Archive Ioslave: convert to json metadata (authored by meven).
Archive Ioslave: convert to json metadata
Sat, May 30, 10:51 AM
meven added inline comments to D29805: Thumbnail djvu: Avoid a crash when djvu is not installed.
Sat, May 30, 10:19 AM · Frameworks, Dolphin
meven committed R241:2a8a1d9f613a: Fix test KFilePlacesModelTest::testEnableBaloo (authored by meven).
Fix test KFilePlacesModelTest::testEnableBaloo
Sat, May 30, 10:16 AM
meven committed R241:5f43507996e5: Places: Use Solid::Device::DisplayName for DisplayRole (authored by meven).
Places: Use Solid::Device::DisplayName for DisplayRole
Sat, May 30, 10:15 AM
meven closed D26113: Places: Use Solid::Device::DisplayName for DisplayRole.
Sat, May 30, 10:15 AM · Frameworks
meven committed R320:9fd351bab756: Archive IoSlave: Add icon and total size to the root (authored by meven).
Archive IoSlave: Add icon and total size to the root
Sat, May 30, 10:14 AM
meven committed R320:9349d799d11d: Archive IoSlave: Add icon and total size to the root (authored by meven).
Archive IoSlave: Add icon and total size to the root
Sat, May 30, 10:09 AM
meven committed R320:ec5685dfb675: Archive IoSlave: Add icon and total size to the root (authored by meven).
Archive IoSlave: Add icon and total size to the root
Sat, May 30, 10:03 AM
meven updated the summary of D29213: Status bar: Hide the space free bar when size is unknown.
Sat, May 30, 10:00 AM · Dolphin
meven committed R241:6afdc3b94125: Use a lambda to reduce repeating code and better handle io errors (authored by meven).
Use a lambda to reduce repeating code and better handle io errors
Sat, May 30, 7:58 AM
meven committed R241:71ccb0f0e7dd: Add tooltip when files are identical (authored by meven).
Add tooltip when files are identical
Sat, May 30, 7:58 AM
meven committed R241:df9e1ce24ec4: RenameDialog: Show if files are identical (authored by meven).
RenameDialog: Show if files are identical
Sat, May 30, 7:58 AM
meven committed R241:efc5721d3cb5: Use a lambda to reduce repeating code and better handle io errors (authored by meven).
Use a lambda to reduce repeating code and better handle io errors
Sat, May 30, 7:43 AM
meven committed R241:b677e584c17d: Use a lambda to reduce repeating code and better handle io errors (authored by meven).
Use a lambda to reduce repeating code and better handle io errors
Sat, May 30, 7:39 AM
meven committed R241:6e28af9b63bc: Use a lambda to reduce repeating code and better handle io errors (authored by meven).
Use a lambda to reduce repeating code and better handle io errors
Sat, May 30, 7:37 AM
meven committed R241:62152e62a7c1: Add tooltip when files are identical (authored by meven).
Add tooltip when files are identical
Sat, May 30, 7:37 AM
meven committed R241:1b0b9640f6d1: Add tooltip when files are identical (authored by meven).
Add tooltip when files are identical
Sat, May 30, 7:14 AM
meven committed R241:9c36aef5d858: RenameDialog: Show if files are identical (authored by meven).
RenameDialog: Show if files are identical
Sat, May 30, 7:03 AM
meven accepted D3835: [Calendar] Populate overview models on-demand.

@broulik is it still on the table ?

Sat, May 30, 6:26 AM · Frameworks, Plasma
meven added inline comments to D29459: Scripting: Make client.activities writable.
Sat, May 30, 6:22 AM · KWin
meven committed R241:ac75ba8a2045: RenameDialog: Show if files are identical (authored by meven).
RenameDialog: Show if files are identical
Sat, May 30, 5:09 AM
meven added a comment to D26113: Places: Use Solid::Device::DisplayName for DisplayRole.

Please check that kfileplacesmodeltest and kfileplacesviewtest still pass.

Sat, May 30, 5:04 AM · Frameworks
meven committed R241:4056d138a90f: Fix test KFilePlacesModelTest::testEnableBaloo (authored by meven).
Fix test KFilePlacesModelTest::testEnableBaloo
Sat, May 30, 4:53 AM
meven committed R241:340868ade2a6: Fix test KFilePlacesModelTest::testEnableBaloo (authored by meven).
Fix test KFilePlacesModelTest::testEnableBaloo
Sat, May 30, 4:53 AM

Fri, May 29

meven committed R318:ead80d558566: Prevents warnings (authored by meven).
Prevents warnings
Fri, May 29, 5:39 PM
meven added a comment to D29213: Status bar: Hide the space free bar when size is unknown.

+1, though I see a brief flicker of the widget when I switch between two views where it's hidden, such as recentlyused:/files/ and recentlyused:/locations/ can you reproduce?

Fri, May 29, 5:15 PM · Dolphin