meven (Méven Car)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 10 2018, 12:40 PM (67 w, 1 d)
Availability
Available

Recent Activity

Today

meven added inline comments to D17595: Upstream Dolphin's file rename dialog.
Mon, May 27, 9:08 AM · Frameworks
meven added a comment to D20763: Fix test, taking into account access time field is now always available.

I'm going to accept to fix the test for now, but it should be rewritten in the future

Mon, May 27, 8:57 AM · Baloo
meven added inline comments to D21409: KWrite: Implement sceleton KTextEditor::Application.
Mon, May 27, 8:50 AM · Kate
meven closed D20763: Fix test, taking into account access time field is now always available.
Mon, May 27, 8:38 AM · Baloo
meven committed R824:ac3cf9cf5e5c: Fix test, taking into account access time field is now always available (authored by meven).
Fix test, taking into account access time field is now always available
Mon, May 27, 8:38 AM
meven updated the task description for T8552: Polish Open/Save dialogs.
Mon, May 27, 8:29 AM · VDG
meven committed R39:fb2ea92822d2: Use native dialog overwrite check (authored by meven).
Use native dialog overwrite check
Mon, May 27, 8:29 AM
meven closed D21401: Use native dialog overwrite check.
Mon, May 27, 8:29 AM · Frameworks, Kate
meven committed R40:09053597e699: Avoid double overwrite check (authored by meven).
Avoid double overwrite check
Mon, May 27, 8:28 AM
meven closed D21402: Avoid double overwrite check.
Mon, May 27, 8:28 AM · Kate
meven added a comment to D21401: Use native dialog overwrite check.

Good part is that the overwrite check dialog will now be a native one analog to other apps instead of a KMessageBox, providing consistency outside of KDE.

Mon, May 27, 8:26 AM · Frameworks, Kate
meven updated the diff for D21401: Use native dialog overwrite check.

Remove decl of removed function checkOverwrite

Mon, May 27, 8:24 AM · Frameworks, Kate

Yesterday

meven added a comment to D21401: Use native dialog overwrite check.

This will work fine for a KDE environment where we know that the file dialog correctly handles the overwrite use case. Do we know that the GTK file dialog does the same for when Kate is run on GNOME, XFCE, or MATE?

Sun, May 26, 6:46 AM · Frameworks, Kate

Sat, May 25

meven added a revision to T8552: Polish Open/Save dialogs: D21401: Use native dialog overwrite check.
Sat, May 25, 1:40 PM · VDG
meven added a task to D21401: Use native dialog overwrite check: T8552: Polish Open/Save dialogs.
Sat, May 25, 1:40 PM · Frameworks, Kate
meven updated the task description for T8552: Polish Open/Save dialogs.
Sat, May 25, 1:35 PM · VDG
meven requested review of D21402: Avoid double overwrite check.
Sat, May 25, 1:34 PM · Kate
meven requested review of D21401: Use native dialog overwrite check.
Sat, May 25, 1:30 PM · Frameworks, Kate
meven updated the diff for D21315: Dolphin-style view modes in the file dialog.

Fix missing ')'

Sat, May 25, 12:30 PM · Frameworks
meven added a comment to D12647: Move the inline preview button into the menu.

I don't think this makes sense anymore.

"Put the Show Inline Preview button in the settings menu" is still in T8552, shouldn't we remove this there then ?

Sat, May 25, 12:24 PM · Frameworks

Tue, May 21

meven updated the diff for D21315: Dolphin-style view modes in the file dialog.

Reword Allow Expansion to Allow Expansion in Details View

Tue, May 21, 5:22 PM · Frameworks
meven updated the test plan for D21315: Dolphin-style view modes in the file dialog.
Tue, May 21, 9:53 AM · Frameworks
meven requested review of D21315: Dolphin-style view modes in the file dialog.
Tue, May 21, 9:46 AM · Frameworks
meven abandoned D21283: Replace Simple View and Tree view by an icon view and compact view.

Thanks I'd be happy to take over.
Some of the changes I did seem to me nice to have like moving class kdiroperatoriconview out of kdiroperator.cpp file and I am thinking about doing it again.

Tue, May 21, 6:56 AM · Frameworks

Mon, May 20

meven added a comment to D21283: Replace Simple View and Tree view by an icon view and compact view.

This patch seems to me now inappropriate given the history of D12358 and D12326.

Mon, May 20, 6:22 PM · Frameworks
meven updated the diff for D21283: Replace Simple View and Tree view by an icon view and compact view.

Clean up

Mon, May 20, 9:27 AM · Frameworks
meven updated the summary of D21283: Replace Simple View and Tree view by an icon view and compact view.
Mon, May 20, 9:24 AM · Frameworks
meven updated the diff for D21283: Replace Simple View and Tree view by an icon view and compact view.

Keep DetailTree as default file view

Mon, May 20, 9:19 AM · Frameworks
meven updated the diff for D21283: Replace Simple View and Tree view by an icon view and compact view.

Extract KDirOperatorIconView to its own class

Mon, May 20, 9:11 AM · Frameworks
meven updated the diff for D21283: Replace Simple View and Tree view by an icon view and compact view.

Reword Icon View to Icons View

Mon, May 20, 8:51 AM · Frameworks

Sun, May 19

meven updated the diff for D21283: Replace Simple View and Tree view by an icon view and compact view.

Clean up reference to action decoration menu

Sun, May 19, 1:53 PM · Frameworks
meven updated the diff for D21283: Replace Simple View and Tree view by an icon view and compact view.

Rename IconView kind Simple to Icon

Sun, May 19, 9:00 AM · Frameworks
meven updated the diff for D21283: Replace Simple View and Tree view by an icon view and compact view.

Capitalization

Sun, May 19, 8:28 AM · Frameworks
meven added a reviewer for D21283: Replace Simple View and Tree view by an icon view and compact view: ngraham.
Sun, May 19, 8:27 AM · Frameworks
meven requested review of D21283: Replace Simple View and Tree view by an icon view and compact view.
Sun, May 19, 8:25 AM · Frameworks

Sat, May 18

meven updated the task description for T8552: Polish Open/Save dialogs.
Sat, May 18, 8:56 AM · VDG
meven committed R241:25eb17ffa666: Allow to drop one file or one folder on KDirOperator (authored by meven).
Allow to drop one file or one folder on KDirOperator
Sat, May 18, 8:54 AM
meven closed D20838: Allow to drop one file or one folder on KDirOperator.
Sat, May 18, 8:54 AM · Frameworks
meven added inline comments to D21204: Ensure no trailing slash in mountpoint read from fstab file..
Sat, May 18, 7:04 AM · Frameworks
meven updated the diff for D21204: Ensure no trailing slash in mountpoint read from fstab file..

Shorten comment line, ensure fuse mount do not end with / either

Sat, May 18, 7:03 AM · Frameworks

Fri, May 17

meven updated the diff for D21204: Ensure no trailing slash in mountpoint read from fstab file..

Move code change to _k_deviceNameForMountpoint

Fri, May 17, 12:42 PM · Frameworks
meven updated the diff for D21204: Ensure no trailing slash in mountpoint read from fstab file..

use chop to strip last /

Fri, May 17, 12:35 PM · Frameworks
meven updated the diff for D21204: Ensure no trailing slash in mountpoint read from fstab file..

Fix code, improved doc, better testing

Fri, May 17, 12:34 PM · Frameworks

Tue, May 14

meven abandoned D20301: Ensure to add a trailing / at the end of fstab mounted devices..

Abandoned n favor of D21204

Tue, May 14, 7:44 AM · Frameworks
meven requested review of D21204: Ensure no trailing slash in mountpoint read from fstab file..
Tue, May 14, 7:43 AM · Frameworks

Mon, May 13

meven updated the diff for D20838: Allow to drop one file or one folder on KDirOperator.

Review, removed a dead variable in test, use QRegularExpression

Mon, May 13, 12:23 PM · Frameworks

Thu, May 9

meven added inline comments to D17595: Upstream Dolphin's file rename dialog.
Thu, May 9, 11:13 AM · Frameworks
meven updated the task description for T8552: Polish Open/Save dialogs.
Thu, May 9, 11:09 AM · VDG

Wed, May 8

meven added a comment to D16425: Added new Suspend then Hibernate option.

This is how the module looks with the new option:


It looks the same as the "Even when an external monitor is connected", I tried using a HBox but it didn't change the alignment, maybe there is a restriction on how powerdevil builds the UI, but I'm no expert on that. if anyone has any idea on how to change it I'm open to suggestions.

Wed, May 8, 2:13 PM · Plasma
meven added a reviewer for D20838: Allow to drop one file or one folder on KDirOperator: Frameworks.
Wed, May 8, 2:06 PM · Frameworks
meven added a comment to D20838: Allow to drop one file or one folder on KDirOperator.

@ngraham Should I wait for some more review/testing, or LGTM means let's get this merge ASAP ?

Wed, May 8, 1:41 PM · Frameworks

Tue, May 7

meven updated the diff for D20838: Allow to drop one file or one folder on KDirOperator.

update since comment kio version

Tue, May 7, 10:23 AM · Frameworks

Mon, May 6

meven added inline comments to D20763: Fix test, taking into account access time field is now always available.
Mon, May 6, 11:04 AM · Baloo
meven updated the diff for D20838: Allow to drop one file or one folder on KDirOperator.

Fix drag^Ciltering, add mime filtering to the drag filtering

Mon, May 6, 10:32 AM · Frameworks
meven planned changes to D20838: Allow to drop one file or one folder on KDirOperator.

An eventFilter must return true when the event has been processed and prevent further event handling.
This prevent the drag filtering to not work (multiple files for instance).
The code does not do that currently, I am on it.

Mon, May 6, 9:38 AM · Frameworks
meven updated the test plan for D20838: Allow to drop one file or one folder on KDirOperator.
Mon, May 6, 9:14 AM · Frameworks
meven added inline comments to D20838: Allow to drop one file or one folder on KDirOperator.
Mon, May 6, 1:36 AM · Frameworks
meven updated the diff for D20838: Allow to drop one file or one folder on KDirOperator.

review feedback

Mon, May 6, 1:35 AM · Frameworks
meven added a comment to D20863: Allow folder view elements to be be dropped using other Action than Copy.

Now don't forget to merge to master. :)

git checkout Plasma/5.15
git pull
git checkout master
git merge -s recursive -Xours origin/Plasma/5.15
git push

I have a handy shell function kmerge that does this for me and then checks the result:

function kmerge {
    # Make sure the merge branch is up to date
    CURRENTBRANCH=`git branch 2> /dev/null | sed -e '/^[^*]/d' -e 's/* \(.*\)/\1/'`
    git checkout $1
    git pull

    # Do the merge safely
    git checkout $CURRENTBRANCH
    git merge -s recursive -Xours $1

    # Verify it afterwards
    git diff origin/HEAD HEAD

    # Now push!
}
Mon, May 6, 1:24 AM · Plasma
meven committed R119:f3c987c0730d: Merge remote-tracking branch 'origin/Plasma/5.15' (authored by meven).
Merge remote-tracking branch 'origin/Plasma/5.15'
Mon, May 6, 1:24 AM

Sun, May 5

meven committed R119:b753301b74ac: Allow folder view elements to be be dropped using other Action than Copy (authored by meven).
Allow folder view elements to be be dropped using other Action than Copy
Sun, May 5, 7:24 PM
meven closed D20863: Allow folder view elements to be be dropped using other Action than Copy.
Sun, May 5, 7:24 PM · Plasma
meven added a comment to D20301: Ensure to add a trailing / at the end of fstab mounted devices..

What do you think @bruns ?

Sun, May 5, 3:45 PM · Frameworks
meven added a comment to D20863: Allow folder view elements to be be dropped using other Action than Copy.

@hein is it ok ?

Sun, May 5, 3:44 PM · Plasma
meven updated the diff for D20838: Allow to drop one file or one folder on KDirOperator.

oops

Sun, May 5, 3:43 PM · Frameworks
meven updated the diff for D20838: Allow to drop one file or one folder on KDirOperator.

Clean up test code

Sun, May 5, 3:33 PM · Frameworks
meven updated the diff for D20838: Allow to drop one file or one folder on KDirOperator.

Clean up and fix test

Sun, May 5, 12:45 PM · Frameworks

Sat, May 4

meven committed R824:ba9b1814d63a: Avoid copying key variable in the loop, as warned by QtCreator (authored by meven).
Avoid copying key variable in the loop, as warned by QtCreator
Sat, May 4, 1:22 PM
meven closed D20768: Avoid copying key variable in the loop, as warned by QtCreator.
Sat, May 4, 1:22 PM · Baloo

Fri, May 3

meven updated the diff for D20838: Allow to drop one file or one folder on KDirOperator.

Grab the focus so that the currentItem becomes the kfilewidget selected item, otherwise the user needs to give the kdiroperator the focus first

Fri, May 3, 8:30 AM · Frameworks
meven updated the diff for D20838: Allow to drop one file or one folder on KDirOperator.

Fix an issue where the closuser would be called for each finished event once set

Fri, May 3, 8:23 AM · Frameworks
meven updated the diff for D20768: Avoid copying key variable in the loop, as warned by QtCreator.

Add a sp

Fri, May 3, 7:47 AM · Baloo

Mon, Apr 29

meven added a comment to D19926: Add Bookmark Handling.

We would probably like to allow the bookmarks to be accessible from KIOFileWidgets open/save dialog, somehow.
There is already a bookmark feature there, it would be great if the two matches.

Mon, Apr 29, 8:07 AM · Dolphin
meven added a comment to D19926: Add Bookmark Handling.

We would probably like to allow the bookmarks to be accessible from KIOFileWidgets open/save dialog, somehow.
There is already a bookmark feature there, it would be great if the two matches.

Mon, Apr 29, 8:00 AM · Dolphin
meven added a comment to D20827: Reword some text, a couple clean ups, add a separator.

@meven FYI this change broke the Frameworks string freeze: https://community.kde.org/Schedules/Frameworks

Mon, Apr 29, 7:58 AM · VDG, Frameworks

Sun, Apr 28

meven added a comment to D20838: Allow to drop one file or one folder on KDirOperator.

I have tested on my side, I don't understand why it does not work.
From dolphin desktop:/ you can drag'n drop fine but not from the folder view.
I receive events and desktop:/ urls but the drag is not accepted whatever I do, like always calling event->accept() in the "case QEvent::DragEnter".
Could it be a because of the folder view filtering where it accepts to get dragged for instance ?

Sounds like it. If it works from desktop:/ in Dolphin, but not from Folder view, I bet the drag isn't being sent the right way.

However, testing with a file in desktop:/, the drag and drop happens successfully, but the path listed in the filename field is invalid (e.g. desktop:IMG_0713.JPG and the file can't actually be opened:

Looks like the protocol is missing a trailing slash before the file path part. Interestingly, I notice that if I drag the same file from desktop:/<file> the filename field, the path is listed as file:///home/dev/Desktop/IMG_0713.JPG which is different, but also correct. Perhaps the path just needs to be sanitized in the same way when dragged to the file view?

Sun, Apr 28, 10:34 AM · Frameworks
meven updated the diff for D20838: Allow to drop one file or one folder on KDirOperator.

Allow KDirModel to accept more actions when dropping on the model, simplify implementation, translates kde url to mostlocalurls when dropping

Sun, Apr 28, 10:20 AM · Frameworks

Sat, Apr 27

meven accepted D20864: [MetadataProvider] Use fixed order for modified/accessed/created.
Sat, Apr 27, 1:47 PM · Baloo
meven updated the diff for D20838: Allow to drop one file or one folder on KDirOperator.

Have to keep a reference to the connection in the object, or it gets deleted before the closure is run

Sat, Apr 27, 1:46 PM · Frameworks
meven updated the diff for D20838: Allow to drop one file or one folder on KDirOperator.

Fix dropping directory

Sat, Apr 27, 1:26 PM · Frameworks
meven updated the diff for D20838: Allow to drop one file or one folder on KDirOperator.

Use mostLocalUrls when resolving the dropped url, bettor organize code

Sat, Apr 27, 1:23 PM · Frameworks

Apr 27 2019

meven requested review of D20863: Allow folder view elements to be be dropped using other Action than Copy.
Apr 27 2019, 11:08 AM · Plasma
meven added a comment to D20856: [TagsFileItemAction] Move expensive tag retrieval out of the loop.

Nice

Apr 27 2019, 9:03 AM · Baloo

Apr 26 2019

meven added a comment to D20838: Allow to drop one file or one folder on KDirOperator.

Wow, it works and it's sooooooooo nice. What an improvement!

:)

Apr 26 2019, 5:01 PM · Frameworks
meven updated the diff for D20838: Allow to drop one file or one folder on KDirOperator.

Remove unnecessary comment

Apr 26 2019, 4:48 PM · Frameworks
meven added a comment to D20737: Convert c arrays to std::array.

For reference:
https://en.cppreference.com/w/cpp/container/array

Apr 26 2019, 3:50 PM · Dolphin
meven added a comment to D20301: Ensure to add a trailing / at the end of fstab mounted devices..

I've been told that @bruns can review this sometime next week. :)

Apr 26 2019, 3:29 PM · Frameworks
meven added inline comments to D20838: Allow to drop one file or one folder on KDirOperator.
Apr 26 2019, 12:59 PM · Frameworks
meven updated the diff for D20838: Allow to drop one file or one folder on KDirOperator.

Add a since in documentation

Apr 26 2019, 12:14 PM · Frameworks
meven updated the diff for D20838: Allow to drop one file or one folder on KDirOperator.

Review feedback

Apr 26 2019, 12:12 PM · Frameworks
meven updated the task description for T8552: Polish Open/Save dialogs.
Apr 26 2019, 11:23 AM · VDG
meven added a reviewer for D20838: Allow to drop one file or one folder on KDirOperator: ngraham.
Apr 26 2019, 11:19 AM · Frameworks
meven requested review of D20838: Allow to drop one file or one folder on KDirOperator.
Apr 26 2019, 11:19 AM · Frameworks

Apr 25 2019

meven added a comment to D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues.

Works for me, nice work with aligning the layouts.

I'm a bit conflicted, but I think visually the issue is how these buttons look like with the port, as well as their icons (but that was a problem before as well):

Before they had a useless frame, but the buttons had a border on all 4 sides:

Losing the bottom maybe makes sense, but feels disconnected here IMO.

Apr 25 2019, 8:20 PM · Plasma
meven added a comment to D12647: Move the inline preview button into the menu.

I don't think this makes sense anymore.

Apr 25 2019, 7:49 PM · Frameworks
meven updated the task description for T8552: Polish Open/Save dialogs.
Apr 25 2019, 7:48 PM · VDG
meven committed R241:f17749e70c09: Reword some text, a couple clean ups, add a separator (authored by meven).
Reword some text, a couple clean ups, add a separator
Apr 25 2019, 7:47 PM
meven closed D20827: Reword some text, a couple clean ups, add a separator.
Apr 25 2019, 7:47 PM · VDG, Frameworks
meven added a reviewer for D20827: Reword some text, a couple clean ups, add a separator: ngraham.
Apr 25 2019, 6:58 PM · VDG, Frameworks
meven requested review of D20827: Reword some text, a couple clean ups, add a separator.
Apr 25 2019, 6:57 PM · VDG, Frameworks