meven (Méven Car)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Feb 10 2018, 12:40 PM (74 w, 2 d)
Availability
Available

Recent Activity

Yesterday

meven committed R318:200bc71130f4: Fix a regression preventing previews to be resized (authored by meven).
Fix a regression preventing previews to be resized
Mon, Jul 15, 4:40 PM
meven closed D22473: Fix a regression preventing previews to be resized.
Mon, Jul 15, 4:40 PM · Dolphin
meven retitled D22473: Fix a regression preventing previews to be resized from Fix a rgression preventing previews to be resized to Fix a regression preventing previews to be resized.
Mon, Jul 15, 4:39 PM · Dolphin
meven requested review of D22473: Fix a regression preventing previews to be resized.
Mon, Jul 15, 2:21 PM · Dolphin
meven updated the diff for D22183: Add click to play/play feature on previews for audio/video.

Let the video player use the pointing hand cursor

Mon, Jul 15, 8:12 AM · Dolphin
meven updated the diff for D22183: Add click to play/play feature on previews for audio/video.

Add an arrow on videos to let the user know he can click to preview it, add a Pointing Hand cursor when hover the preview for audio and video

Mon, Jul 15, 8:07 AM · Dolphin
meven added a comment to D22183: Add click to play/play feature on previews for audio/video.

+1 for this feature. However, I feel like as implemented, it won't be very discoverable. To improve this, how about doing one of the following:

  • Use a pointing hand cursor when hovering over the preview, to show that something will happen on click
  • Show a play button in the center of the preview on hover, and make it look clicked and then disappear when the preview is clicked
  • A combination of both
  • Something else?
  • etc.
Mon, Jul 15, 7:19 AM · Dolphin

Sun, Jul 14

meven added a comment to D22144: Add kio recentlyused:/ to access KactivitytStats data.

I wonder if this is the problem:

ls /home/nate/kde/usr/bin/kioclient5
ls: cannot access '/home/nate/kde/usr/bin/kioclient5': No such file or directory

What actually builds that binary? My KIO doesn't seem to do it.

Sun, Jul 14, 1:48 PM · Frameworks, Dolphin
meven retitled D22144: Add kio recentlyused:/ to access KactivitytStats data from - Add kio recentlyused:/ to access KactivitytStats data to Add kio recentlyused:/ to access KactivitytStats data.
Sun, Jul 14, 10:21 AM · Frameworks, Dolphin

Tue, Jul 9

meven added inline comments to D22183: Add click to play/play feature on previews for audio/video.
Tue, Jul 9, 5:09 PM · Dolphin
meven updated the diff for D22183: Add click to play/play feature on previews for audio/video.

Avoid a double installEventFilter

Tue, Jul 9, 5:08 PM · Dolphin
meven updated the diff for D22183: Add click to play/play feature on previews for audio/video.

Avoid the play/stop buttons to flicker when the video is paused.

Tue, Jul 9, 12:25 PM · Dolphin
meven abandoned D22186: [Video preview] Prevents the play/stop button to flicker when the video state changes.

See D22183 that includes this fix.

Tue, Jul 9, 12:24 PM · Dolphin
meven updated the summary of D22183: Add click to play/play feature on previews for audio/video.
Tue, Jul 9, 12:23 PM · Dolphin
meven abandoned D22051: Add click to play/play feature on previews for audio/video.

Since D22050 is abandoned, this one can be as well.

Tue, Jul 9, 12:23 PM · Dolphin
meven abandoned D22050: Port from phonon to qtmultimedia.

I have opened "When pausing video playback the video output can turn black" https://bugs.kde.org/show_bug.cgi?id=409363 in phonon-gstreamer

I didn't know phonon-vlc was the recommended one.
I believe distros mostly ship phonon-gstreamer. At least debian/ubuntu do https://packages.debian.org/stretch/phonon

What you linked to is the Qt4 package, Qt5 correctly prefers VLC https://packages.debian.org/stretch/phonon4qt5

Tue, Jul 9, 12:22 PM · Dolphin
meven added a comment to D22186: [Video preview] Prevents the play/stop button to flicker when the video state changes.

I'd like to merge this ASAP since it will prevent bugs in D22183.

Tue, Jul 9, 12:19 PM · Dolphin
meven added a comment to D20838: Allow to drop one file or one folder on KDirOperator.

The test fails in CI, please check.

https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/139/testReport/junit/projectroot/autotests/kiofilewidgets_kfilewidgettest/
https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.13/job/kio/job/kf5-qt5%20SUSEQt5.13/7/testReport/projectroot/autotests/kiofilewidgets_kfilewidgettest/

PASS   : KFileWidgetTest::testDropFile(some.txt)
FAIL!  : KFileWidgetTest::testDropFile(subdir/some.txt) Compared values are not the same
  Actual   (fileWidget.locationEdit()->currentText()): ""
  Expected (expectedCurrentText)                     : "some.txt"
  Loc: [/home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/autotests/kfilewidgettest.cpp(496)]
Tue, Jul 9, 11:34 AM · Frameworks

Mon, Jul 8

meven added a comment to D22144: Add kio recentlyused:/ to access KactivitytStats data.

Nice!

What's the right way to apply this patch? Using the instructions in the text plan section, I'm not able to get it to work:

~/kde/src/kio-extras $  (arcpatch-D22144) kb
Total of 'trivial' dependency cycles detected & eliminated: 2

Building kio-extras from kf5-base-applications (1/1)
        Source update complete for kio-extras: Skipped
        Compiling... succeeded (after 2 seconds)
        Installing.. succeeded (after 0 seconds)

<<<  PACKAGES SUCCESSFULLY BUILT  >>>
kio-extras
 
Removing 1 out of 22 old log directories...
:-)
Your logs are saved in /home/nate/kde/src/log/2019-07-01-01


~/kde/src/kio-extras $  (arcpatch-D22144) kdeinit5
kdeinit5: Shutting down running client.
kdeinit5: Got termination request (PID 28252).
klauncher: Exiting on signal 15
kdeinit5: preparing to launch '/home/nate/kde/usr/lib64/libexec/kf5/klauncher'
kdeinit5: Launched KLauncher, pid = 28914, result = 0
Connecting to deprecated signal QDBusConnectionInterface::serviceOwnerChanged(QString,QString,QString)
kdeinit5: opened connection to :0


~/kde/src/kio-extras $  (arcpatch-D22144) kioclient5 ls recentlyused:/?limit=100
kf5.kio.core: couldn't create slave: "klauncher said: Unknown protocol 'recentlyused'.\n"
"Unable to create io-slave. klauncher said: Unknown protocol 'recentlyused'.\n"
Mon, Jul 8, 1:57 PM · Frameworks, Dolphin

Mon, Jul 1

meven committed R122:daa06ba31ff1: Added new Suspend then Hibernate option (authored by avaldes).
Added new Suspend then Hibernate option
Mon, Jul 1, 6:18 PM
meven closed D16425: Added new Suspend then Hibernate option.
Mon, Jul 1, 6:18 PM · Plasma
meven added a comment to D16425: Added new Suspend then Hibernate option.

I'd quite like to get this in as I'll end up moving part of this - and we've got too much bikeshedding here.

i18n("While asleep, hibernate after 3 hours")

If you don't know the timeout, don't write it. It's better to be vague than lie.

"Suspend, then hibernate after a period of inactivitiy"

I have updated the message. I cannot land it so I need help with that

Mon, Jul 1, 5:32 PM · Plasma
meven updated the summary of D22186: [Video preview] Prevents the play/stop button to flicker when the video state changes.
Mon, Jul 1, 12:01 PM · Dolphin
meven requested review of D22186: [Video preview] Prevents the play/stop button to flicker when the video state changes.
Mon, Jul 1, 11:59 AM · Dolphin
meven added a comment to D22050: Port from phonon to qtmultimedia.

I have opened "When pausing video playback the video output can turn black" https://bugs.kde.org/show_bug.cgi?id=409363 in phonon-gstreamer

Mon, Jul 1, 11:46 AM · Dolphin
meven updated the diff for D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart.

Use an iterator to loop over globalFstabCache->m_fstabCache

Mon, Jul 1, 11:16 AM · Frameworks
meven added a comment to D22050: Port from phonon to qtmultimedia.

I would be curious about opinions of phonon maintainers/commiters, perhaps I make wrong assumptions here.

What bugs are there?

Mon, Jul 1, 10:32 AM · Dolphin
meven requested review of D22183: Add click to play/play feature on previews for audio/video.
Mon, Jul 1, 10:14 AM · Dolphin
meven added a dependent revision for D22050: Port from phonon to qtmultimedia: D22183: Add click to play/play feature on previews for audio/video.
Mon, Jul 1, 10:14 AM · Dolphin
meven retitled D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart from Ensure mounted mounted nfs filesystems matches their fstab declared counterpart to Ensure mounted nfs filesystems matches their fstab declared counterpart.
Mon, Jul 1, 9:58 AM · Frameworks
meven added a comment to D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart.

Minor/general comment: given this is a KDE Frameworks change, could you improve the summary of the commit message for this and future commits? Here it just says bug, ccbug, fixedin. Imho a commit log should be self-explaining and self-contained: what is broken exactly, why is it broken, why is the suggested fix correct, what testing did you do, what possible risks does the change have?

Everything is missing here. As consequence, you get poor or no reviews, and no one feels good enough giving a ship-it.

Mon, Jul 1, 9:32 AM · Frameworks
meven updated the test plan for D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart.
Mon, Jul 1, 9:30 AM · Frameworks

Sun, Jun 30

meven added a comment to D7446: [Places panel] Revamp the Recently Saved section.
In D7446#486700, @meven wrote:

I have started D22082 enrolling the plan set in the previous comment.

Once this task has done enough progress and has landed some of its work, I will be able to revisit this diff.

Sun, Jun 30, 9:11 PM · Frameworks, Dolphin
meven updated the test plan for D22144: Add kio recentlyused:/ to access KactivitytStats data.
Sun, Jun 30, 9:06 PM · Frameworks, Dolphin
meven added a comment to D22144: Add kio recentlyused:/ to access KactivitytStats data.
Sun, Jun 30, 8:58 PM · Frameworks, Dolphin
meven updated the test plan for D22144: Add kio recentlyused:/ to access KactivitytStats data.
Sun, Jun 30, 8:55 PM · Frameworks, Dolphin
meven updated the diff for D22144: Add kio recentlyused:/ to access KactivitytStats data.

New json metadata file

Sun, Jun 30, 8:52 PM · Frameworks, Dolphin
meven added a comment to D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName().

Nice work !

Sun, Jun 30, 8:32 PM · Frameworks
meven added a comment to D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart.

Thanks @anthonyfieroni

Sun, Jun 30, 10:25 AM · Frameworks
meven updated the diff for D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart.

Use a const ref in the loop use append to add a trailing /

Sun, Jun 30, 10:24 AM · Frameworks

Sat, Jun 29

meven accepted D16425: Added new Suspend then Hibernate option.

Except that I couldn't test it, the code looks in great shape to me.

Sat, Jun 29, 10:12 AM · Plasma
meven added a comment to D20766: Use appropriate background color for text previews.

For context :

Sat, Jun 29, 9:41 AM · Frameworks, Dolphin
meven added a comment to D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart.

ping @bruns

Sat, Jun 29, 8:55 AM · Frameworks
meven updated the summary of D22144: Add kio recentlyused:/ to access KactivitytStats data.
Sat, Jun 29, 8:47 AM · Frameworks, Dolphin
meven updated the test plan for D22144: Add kio recentlyused:/ to access KactivitytStats data.
Sat, Jun 29, 8:46 AM · Frameworks, Dolphin
meven added inline comments to D22143: Add proper logging using ECMQtDeclareLoggingCategory.
Sat, Jun 29, 8:17 AM · Frameworks
meven updated the test plan for D22149: Add "Add to Places" action to file menu.
Sat, Jun 29, 7:32 AM · Dolphin
meven closed D22146: Add frameworks/purpose to the gwenview dependencies.
Sat, Jun 29, 7:09 AM
meven committed R499:3c13b9c55e8b: Add frameworks/purpose to the gwenview dependencies (authored by meven).
Add frameworks/purpose to the gwenview dependencies
Sat, Jun 29, 7:09 AM

Fri, Jun 28

meven updated the diff for D22146: Add frameworks/purpose to the gwenview dependencies.

Regroup frameworks together

Fri, Jun 28, 5:59 PM
meven added a reviewer for D22146: Add frameworks/purpose to the gwenview dependencies: Gwenview.
Fri, Jun 28, 5:59 PM
meven added a reviewer for D22146: Add frameworks/purpose to the gwenview dependencies: kdesrc-build.
Fri, Jun 28, 5:58 PM
meven requested review of D22146: Add frameworks/purpose to the gwenview dependencies.
Fri, Jun 28, 5:58 PM
meven added inline comments to D22143: Add proper logging using ECMQtDeclareLoggingCategory.
Fri, Jun 28, 5:09 PM · Frameworks
meven updated the diff for D22144: Add kio recentlyused:/ to access KactivitytStats data.

Improve declared protocol

Fri, Jun 28, 2:53 PM · Frameworks, Dolphin
meven updated the diff for D22144: Add kio recentlyused:/ to access KactivitytStats data.

Remove default debug option sevirity at debug

Fri, Jun 28, 2:52 PM · Frameworks, Dolphin
meven abandoned D22082: WIP Add an ioslave to access KActivityStat data.

Abandoned in favor of D22144

Fri, Jun 28, 2:51 PM · Frameworks
meven requested review of D22144: Add kio recentlyused:/ to access KactivitytStats data.
Fri, Jun 28, 2:50 PM · Frameworks, Dolphin
meven requested review of D22143: Add proper logging using ECMQtDeclareLoggingCategory.
Fri, Jun 28, 2:07 PM · Frameworks
meven planned changes to D22082: WIP Add an ioslave to access KActivityStat data.
Fri, Jun 28, 2:02 PM · Frameworks
meven updated the diff for D22082: WIP Add an ioslave to access KActivityStat data.
  • Add proper logging using ECMQtDeclareLoggingCategory
Fri, Jun 28, 2:02 PM · Frameworks
meven planned changes to D22082: WIP Add an ioslave to access KActivityStat data.
Fri, Jun 28, 1:54 PM · Frameworks
meven updated the diff for D22082: WIP Add an ioslave to access KActivityStat data.
  • Add proper logging using ECMQtDeclareLoggingCategory
Fri, Jun 28, 1:54 PM · Frameworks
meven planned changes to D22082: WIP Add an ioslave to access KActivityStat data.

recentlyused:/ will be moved to kio-extras.

Fri, Jun 28, 7:32 AM · Frameworks

Thu, Jun 27

meven added a comment to D16425: Added new Suspend then Hibernate option.

I tried using it but my system does not suspend-then-hibernate mode.

Thu, Jun 27, 3:09 PM · Plasma
meven updated the diff for D22082: WIP Add an ioslave to access KActivityStat data.
  • Add a logging category kf5.kactivity.stat
Thu, Jun 27, 6:21 AM · Frameworks

Wed, Jun 26

meven updated the diff for D22082: WIP Add an ioslave to access KActivityStat data.

Allow to find data accross all activities using ?activity=any

Wed, Jun 26, 7:55 AM · Frameworks
meven added a comment to D22082: WIP Add an ioslave to access KActivityStat data.
In D22082#486782, @ivan wrote:

I'd add support for HighScoredFirst and RecentlyCreatedFirst. Maybe the protocol could be something like "used:/" or something.

Wed, Jun 26, 6:58 AM · Frameworks
meven committed R159:b45c34ecfeb1: Fix a crash in KactivityTestApp when Result has strings with non-ASCII (authored by meven).
Fix a crash in KactivityTestApp when Result has strings with non-ASCII
Wed, Jun 26, 6:45 AM
meven closed D22091: Fix a crash in KactivityTestApp when Result has strings with non-ASCII.
Wed, Jun 26, 6:45 AM · Frameworks
meven updated the diff for D22091: Fix a crash in KactivityTestApp when Result has strings with non-ASCII.

Clean leftover declaration

Wed, Jun 26, 6:39 AM · Frameworks

Tue, Jun 25

meven planned changes to D7446: [Places panel] Revamp the Recently Saved section.

I have started D22082 enrolling the plan set in the previous comment.

Tue, Jun 25, 8:41 PM · Frameworks, Dolphin
meven added a comment to D22028: Improve QWidget KCM and QML KCM consistency.

Could this be backported to the stable branch? It's a relative straightforward bugfix.

Tue, Jun 25, 4:32 PM · Plasma
meven committed R119:2dbdc6c59168: Fix a warning message (authored by meven).
Fix a warning message
Tue, Jun 25, 4:29 PM
meven closed D22090: Fix a warning message.
Tue, Jun 25, 4:29 PM · Plasma
meven updated the diff for D22082: WIP Add an ioslave to access KActivityStat data.

Add activity filtering

Tue, Jun 25, 3:34 PM · Frameworks
meven requested review of D22091: Fix a crash in KactivityTestApp when Result has strings with non-ASCII.
Tue, Jun 25, 3:28 PM · Frameworks
meven updated the diff for D22082: WIP Add an ioslave to access KActivityStat data.

Implement proper logging, add url filter parameter

Tue, Jun 25, 2:44 PM · Frameworks
meven added a reviewer for D22090: Fix a warning message: Plasma.
Tue, Jun 25, 2:26 PM · Plasma
meven requested review of D22090: Fix a warning message.
Tue, Jun 25, 2:26 PM · Plasma
meven edited reviewers for D22082: WIP Add an ioslave to access KActivityStat data, added: ivan; removed: lunakl.
Tue, Jun 25, 10:50 AM · Frameworks
meven updated subscribers of D22082: WIP Add an ioslave to access KActivityStat data.

I have added you @ivan as you were the main author of KAcvitiesStat and might be interested in the review.

Tue, Jun 25, 10:50 AM · Frameworks
meven added a reviewer for D22082: WIP Add an ioslave to access KActivityStat data: lunakl.
Tue, Jun 25, 10:48 AM · Frameworks
meven updated the diff for D22082: WIP Add an ioslave to access KActivityStat data.

Allow to override default 30 results limit

Tue, Jun 25, 10:03 AM · Frameworks
meven updated the diff for D22082: WIP Add an ioslave to access KActivityStat data.

Allow to filter mimetype with ?type=mimetype1[,mimetype2]

Tue, Jun 25, 9:43 AM · Frameworks

Mon, Jun 24

meven committed R102:4d5321648e9a: Improve QWidget KCM and QML KCM consistency (authored by meven).
Improve QWidget KCM and QML KCM consistency
Mon, Jun 24, 8:41 PM
meven closed D22028: Improve QWidget KCM and QML KCM consistency.
Mon, Jun 24, 8:41 PM · Plasma
meven updated the diff for D22061: Add a logging category for logs warnings.

Add logging category for all kconfig core warnings message

Mon, Jun 24, 6:10 PM · Frameworks
meven updated the summary of D22082: WIP Add an ioslave to access KActivityStat data.
Mon, Jun 24, 4:46 PM · Frameworks
meven requested review of D22082: WIP Add an ioslave to access KActivityStat data.
Mon, Jun 24, 4:45 PM · Frameworks
meven added a comment to D7446: [Places panel] Revamp the Recently Saved section.

After some discussion, we realized we have three different sets of "recent documents" backends :

  • recentdocument ioslave using KDirWatch that miss accessed dir and files (used in places)
  • baloo's timeline ioslave using baloo extractor, that requires baloo but has indexing and filtering capatibilities (used in places)
  • kactivities-stats that has activity context, and works for modified or accessed files, but that has no ioslave (used in kickoff and kicker)
Mon, Jun 24, 11:11 AM · Frameworks, Dolphin
meven updated the summary of D22061: Add a logging category for logs warnings.
Mon, Jun 24, 9:10 AM · Frameworks
meven updated the diff for D22061: Add a logging category for logs warnings.

Use KCONF_CORE_LOG as identifier and kf5.kconfig.core as category_name

Mon, Jun 24, 9:09 AM · Frameworks

Sun, Jun 23

meven added inline comments to D7446: [Places panel] Revamp the Recently Saved section.
Sun, Jun 23, 11:11 PM · Frameworks, Dolphin
meven added a comment to D7446: [Places panel] Revamp the Recently Saved section.

Now that we have creation date support, what do you think about adjusting the timeline to show files that were either created or modified during a given time period?

Sun, Jun 23, 11:11 PM · Frameworks, Dolphin
meven added a comment to D22061: Add a logging category for logs warnings.

Thank you very much again @apol for your guidance.

Sun, Jun 23, 11:10 PM · Frameworks
meven updated the diff for D22061: Add a logging category for logs warnings.

Removed blank line

Sun, Jun 23, 11:08 PM · Frameworks
meven updated the diff for D22061: Add a logging category for logs warnings.

Use KCONF_DESKTOP_LOG to setup logging

Sun, Jun 23, 11:07 PM · Frameworks
meven commandeered D7446: [Places panel] Revamp the Recently Saved section.
Sun, Jun 23, 10:31 PM · Frameworks, Dolphin
meven requested review of D22061: Add a logging category for logs warnings.
Sun, Jun 23, 10:28 PM · Frameworks