meven (Méven Car)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 10 2018, 12:40 PM (58 w, 12 h)
Availability
Available

Recent Activity

Yesterday

meven retitled D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio from Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio to BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
Sat, Mar 23, 9:36 AM · Dolphin

Fri, Mar 22

meven closed D19970: Fix missings override warnings.
Fri, Mar 22, 2:44 PM
meven committed R487:f7575f8befb7: Fix missings override warnings (authored by meven).
Fix missings override warnings
Fri, Mar 22, 2:44 PM
meven added a comment to D19970: Fix missings override warnings.

Q_FALLTHROUGH is too new. This thing is still qt 4 compatible

Fri, Mar 22, 12:41 PM
meven retitled D19970: Fix missings override warnings from Fix missings override warnings and two Q_FALLTHROUGH warnings to Fix missings override warnings.
Fri, Mar 22, 12:36 PM
meven updated the diff for D19970: Fix missings override warnings.

Removing the Q_FALLTHROUGH

Fri, Mar 22, 12:36 PM
meven added a comment to D19844: [InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled.

@ngraham I have made a couple of changes to the patch since you reviewed.
Namely addin refreshPreview() and using refreshMetaData for a different purpose.
This was needed otherwise the patch introduced a bug.

Fri, Mar 22, 11:46 AM · Dolphin
meven retitled D19970: Fix missings override warnings from Fix overrid warning and add two Q_FALLTHROUGH to Fix missings override warnings and two Q_FALLTHROUGH warnings.
Fri, Mar 22, 11:42 AM
meven requested review of D19970: Fix missings override warnings.
Fri, Mar 22, 11:41 AM
meven committed R318:6dbabdfee650: Convert foreach to for loops (authored by meven).
Convert foreach to for loops
Fri, Mar 22, 9:40 AM
meven closed D19911: Convert foreach to for loops.
Fri, Mar 22, 9:40 AM · Dolphin
meven closed D19945: Update link to fsearch project.
Fri, Mar 22, 8:09 AM · Frameworks
meven committed R304:2a3cea27ea58: Update link to fsearch project (authored by meven).
Update link to fsearch project
Fri, Mar 22, 8:09 AM
meven updated the diff for D19945: Update link to fsearch project.

Redoing the commit to set full name in the commit

Fri, Mar 22, 8:02 AM · Frameworks

Thu, Mar 21

meven requested review of D19945: Update link to fsearch project.
Thu, Mar 21, 4:25 PM · Frameworks
meven added a watcher for Dolphin: meven.
Thu, Mar 21, 2:11 PM
meven added a comment to D19911: Convert foreach to for loops.

For future reference https://www.kdab.com/goodbye-q_foreach/ for why and how to replace foreach

Thu, Mar 21, 11:40 AM · Dolphin
meven added a reviewer for D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk: dfaure.
Thu, Mar 21, 11:38 AM · Frameworks
meven added reviewers for D19936: When hovering over a file on the not-focus view panel, the information panel gets updated: elvisangelaccio, ngraham.
Thu, Mar 21, 10:45 AM · Dolphin
meven added a comment to D19936: When hovering over a file on the not-focus view panel, the information panel gets updated.

Especially useful with D19782, to sort audio/video files for instance
Good also to sort photo.

Thu, Mar 21, 10:43 AM · Dolphin
meven updated the summary of D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
Thu, Mar 21, 10:26 AM · Dolphin
meven requested review of D19936: When hovering over a file on the not-focus view panel, the information panel gets updated.
Thu, Mar 21, 10:25 AM · Dolphin

Wed, Mar 20

meven updated the diff for D19911: Convert foreach to for loops.

Avoid detaching a const

Wed, Mar 20, 9:56 PM · Dolphin
meven updated the test plan for D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
Wed, Mar 20, 7:14 PM · Dolphin
meven updated the test plan for D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
Wed, Mar 20, 7:13 PM · Dolphin
meven updated the test plan for D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
Wed, Mar 20, 7:13 PM · Dolphin
meven updated the diff for D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
  • Improve autoplay feature, add click to play/pause playback
Wed, Mar 20, 7:07 PM · Dolphin
meven added a comment to D19844: [InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled.

I would need to get this merged for D19782.

Wed, Mar 20, 12:08 PM · Dolphin
meven added reviewers for D19911: Convert foreach to for loops: elvisangelaccio, ngraham.
Wed, Mar 20, 10:42 AM · Dolphin
meven requested review of D19911: Convert foreach to for loops.
Wed, Mar 20, 10:42 AM · Dolphin
meven updated the diff for D19844: [InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled.
  • Avoid refreshing the preview when refreshing the metadata and vice-versa
Wed, Mar 20, 10:37 AM · Dolphin
meven updated the test plan for D19910: Hide the phonon widget when preview gets disabled.
Wed, Mar 20, 10:20 AM · Dolphin
meven updated the summary of D19910: Hide the phonon widget when preview gets disabled.
Wed, Mar 20, 10:20 AM · Dolphin
meven requested review of D19910: Hide the phonon widget when preview gets disabled.
Wed, Mar 20, 10:16 AM · Dolphin

Tue, Mar 19

meven planned changes to D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.

The patch currently causes some flickering that I will address once D19844 is merged and this branch is rebased.

Tue, Mar 19, 12:15 PM · Dolphin
meven added a comment to D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk.

Makes sense, thanks. This fix works and looks sane to me.

Maybe wait until at least one more Dolphin and/or Frameworks person has reviewed before committing, though.

Tue, Mar 19, 10:15 AM · Frameworks

Mon, Mar 18

meven added a comment to D19844: [InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled.

Sorry to be pedantic, but we are fixing two different bugs, right? Would it be possible to split this patch into two commits?

Mon, Mar 18, 9:46 PM · Dolphin
meven updated the test plan for D19844: [InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled.
Mon, Mar 18, 9:26 PM · Dolphin
meven added a comment to D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk.

Thanks for the patch, and for adding a test!

Question: how come the return/enter key currently works for this use case in the open dialog without all this extra code?

Mon, Mar 18, 8:32 PM · Frameworks
meven retitled D19844: [InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled from Hide the video when the preview is disabled, avoid computing the preview when it is disabled to [InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled.
Mon, Mar 18, 3:45 PM · Dolphin
meven updated the diff for D19844: [InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled.

Rebase on master

Mon, Mar 18, 3:39 PM · Dolphin
meven added a comment to D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.

The patch currently causes some flickering that I will address once D19844 is merged and this branch is rebased.

Mon, Mar 18, 3:35 PM · Dolphin
meven updated the summary of D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
Mon, Mar 18, 2:50 PM · Dolphin
meven updated the diff for D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
  • Fix missing rewording
Mon, Mar 18, 2:46 PM · Dolphin
meven updated the diff for D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
  • rewording
Mon, Mar 18, 2:25 PM · Dolphin
meven added a dependency for D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio: D19844: [InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled.
Mon, Mar 18, 1:41 PM · Dolphin
meven added a dependent revision for D19844: [InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled: D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
Mon, Mar 18, 1:41 PM · Dolphin
meven added a comment to D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.

This is what it looks like :

Mon, Mar 18, 1:34 PM · Dolphin
meven updated the summary of D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
Mon, Mar 18, 1:26 PM · Dolphin
meven updated subscribers of D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.

This doesn't compile:

[ 70%] Building CXX object src/CMakeFiles/dolphinstatic.dir/dolphin_generalsettings.cpp.o
/home/nate/kde/src/dolphin/src/panels/information/informationpanel.cpp: In member function ‘void InformationPanel::showContextMenu(const QPoint&)’:
/home/nate/kde/src/dolphin/src/panels/information/informationpanel.cpp:182:65: error: ‘previewsAutoplay’ is not a member of ‘InformationPanelSettings’
     previewAutoPlayAction->setChecked(InformationPanelSettings::previewsAutoplay());
                                                                 ^~~~~~~~~~~~~~~~
/home/nate/kde/src/dolphin/src/panels/information/informationpanel.cpp:224:35: error: ‘setPreviewsAutoplay’ is not a member of ‘InformationPanelSettings’
         InformationPanelSettings::setPreviewsAutoplay(isChecked);
                                   ^~~~~~~~~~~~~~~~~~~
make[2]: *** [src/CMakeFiles/dolphinstatic.dir/build.make:853: src/CMakeFiles/dolphinstatic.dir/panels/information/informationpanel.cpp.o] Error 1

Please make sure to test your code before updating the diff :)

Mon, Mar 18, 1:25 PM · Dolphin
meven updated the diff for D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
  • Rewording
Mon, Mar 18, 1:25 PM · Dolphin
meven updated the diff for D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
  • Fix method calls
Mon, Mar 18, 1:13 PM · Dolphin
meven updated the diff for D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
  • Fix method calls
Mon, Mar 18, 1:05 PM · Dolphin
meven updated the diff for D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
  • Rewording to Auto-play
Mon, Mar 18, 12:56 PM · Dolphin
meven updated the diff for D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
  • Add missing kcfg file changes
Mon, Mar 18, 11:54 AM · Dolphin
meven updated the diff for D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
  • remove useless include
Mon, Mar 18, 11:38 AM · Dolphin
meven updated the diff for D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
  • remove useless include
Mon, Mar 18, 11:35 AM · Dolphin
meven updated the diff for D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
  • Avoid calling refreshMedata when changing auto play preview setting
Mon, Mar 18, 11:33 AM · Dolphin
meven updated the diff for D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
  • Avoid restarting playing when already playing
Mon, Mar 18, 11:25 AM · Dolphin
meven retitled D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio from Allow dolphin to auto play previewed media file after a 1 second delay to Allow dolphin to auto play previewed media file.
Mon, Mar 18, 11:18 AM · Dolphin
meven added a reviewer for D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio: elvisangelaccio.
Mon, Mar 18, 11:17 AM · Dolphin
meven updated the diff for D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
  • Remove unused include
Mon, Mar 18, 11:15 AM · Dolphin
meven updated the diff for D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
  • Better connect syntax and adding a context to it
  • The autoplay setting is moved to the information panel context menu, the autoplay starts directly on hover without delay
Mon, Mar 18, 11:13 AM · Dolphin
meven added a comment to D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.

I have updated the diff to remove the timer.
The setting is moved to the information panel setting.

Mon, Mar 18, 11:12 AM · Dolphin
meven retitled D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk from In saving single file mode an enter/return press on the KDirOperator triggers slotOk to KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk.
Mon, Mar 18, 9:46 AM · Frameworks

Sun, Mar 17

meven added reviewers for D19844: [InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled: Dolphin, elvisangelaccio.
Sun, Mar 17, 8:36 PM · Dolphin
meven updated the test plan for D19844: [InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled.
Sun, Mar 17, 8:33 PM · Dolphin
meven committed R318:df81f266cab6: Merge remote-tracking branch 'origin/Applications/19.04' (authored by meven).
Merge remote-tracking branch 'origin/Applications/19.04'
Sun, Mar 17, 8:25 PM
meven committed R318:bf314f2dff99: When the previewed video stops playing (because of the user or because the… (authored by meven).
When the previewed video stops playing (because of the user or because the…
Sun, Mar 17, 8:23 PM
meven closed D19843: When the previewed video stops playing (because of the user or because the media playback has ended), show the regular preview only if the preview setting is on..
Sun, Mar 17, 8:23 PM · Dolphin
meven requested review of D19844: [InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled.
Sun, Mar 17, 8:20 PM · Dolphin
meven added a comment to D19843: When the previewed video stops playing (because of the user or because the media playback has ended), show the regular preview only if the preview setting is on..

Thanks

Sun, Mar 17, 8:11 PM · Dolphin
meven updated the test plan for D19843: When the previewed video stops playing (because of the user or because the media playback has ended), show the regular preview only if the preview setting is on..
Sun, Mar 17, 7:44 PM · Dolphin
meven requested review of D19843: When the previewed video stops playing (because of the user or because the media playback has ended), show the regular preview only if the preview setting is on..
Sun, Mar 17, 7:37 PM · Dolphin
meven committed R318:bc1a99bd11f4: Merge remote-tracking branch 'origin/Applications/19.04' (authored by meven).
Merge remote-tracking branch 'origin/Applications/19.04'
Sun, Mar 17, 6:38 PM
meven committed R318:1ff74854ecb4: Fix a todo: InformationPanelContent::configureSettings code is moved to… (authored by meven).
Fix a todo: InformationPanelContent::configureSettings code is moved to…
Sun, Mar 17, 6:30 PM
meven closed D19832: Fix a todo: InformationPanelContent::configureSettings code is moved to InformationPanel::contextMenuEvent.
Sun, Mar 17, 6:30 PM · Dolphin
meven added inline comments to D19832: Fix a todo: InformationPanelContent::configureSettings code is moved to InformationPanel::contextMenuEvent.
Sun, Mar 17, 5:50 PM · Dolphin
meven updated the diff for D19832: Fix a todo: InformationPanelContent::configureSettings code is moved to InformationPanel::contextMenuEvent.

Code review

Sun, Mar 17, 5:48 PM · Dolphin
meven added a comment to D19535: Correctly position context menu of the information panel under wayland with a secondary screen.

This is not a KWin bug. QCursor::pos()} is not reliable on Wayland and should not be used.

Could we document this ? So that the community avoids discovering a horde a bugs once wayland usage grows. Maybe on https://community.kde.org/Plasma/Wayland_Showstoppers

Better on https://community.kde.org/Guidelines_and_HOWTOs/Wayland_Porting_Notes (where we already explain how to avoid similar bugs).

Sun, Mar 17, 4:51 PM · Dolphin
meven abandoned D19780: Fix a todo in Information Panel, fixing two bugs.

Will be split, first patch at D19832

Sun, Mar 17, 4:31 PM · Dolphin
meven added a comment to D19780: Fix a todo in Information Panel, fixing two bugs.

Can you please split this patch into two or more? One for the code refactoring and another one for each bug you are fixing, describing how to reproduce the issue and how we are going to fix it.

Sun, Mar 17, 4:30 PM · Dolphin
meven retitled D19832: Fix a todo: InformationPanelContent::configureSettings code is moved to InformationPanel::contextMenuEvent from fix a todo to Fix a todo: InformationPanelContent::configureSettings code is moved to InformationPanel::contextMenuEvent.
Sun, Mar 17, 4:29 PM · Dolphin
meven updated the summary of D19832: Fix a todo: InformationPanelContent::configureSettings code is moved to InformationPanel::contextMenuEvent.
Sun, Mar 17, 4:29 PM · Dolphin
meven requested review of D19832: Fix a todo: InformationPanelContent::configureSettings code is moved to InformationPanel::contextMenuEvent.
Sun, Mar 17, 4:28 PM · Dolphin
meven updated the diff for D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk.

Add deleted blank line

Sun, Mar 17, 1:15 PM · Frameworks
meven updated the diff for D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk.

Remove blank line

Sun, Mar 17, 1:13 PM · Frameworks
meven requested review of D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk.
Sun, Mar 17, 1:11 PM · Frameworks

Sat, Mar 16

meven retitled D19780: Fix a todo in Information Panel, fixing two bugs from Refactor the Information Panel, fixing bugs to Fix a todo in Information Panel, fixing two bugs.
Sat, Mar 16, 7:37 PM · Dolphin
meven updated the diff for D19780: Fix a todo in Information Panel, fixing two bugs.
  • Remove a useless added blank line
Sat, Mar 16, 7:31 PM · Dolphin
meven added a comment to D19775: Show preview of the filename in the save settings.

I'm thinking of dropping the "Filename" now and just having "Preview:". For comparison:

Sat, Mar 16, 5:48 PM · Spectacle
meven updated the summary of D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
Sat, Mar 16, 3:50 PM · Dolphin
meven updated the summary of D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
Sat, Mar 16, 3:49 PM · Dolphin
meven updated the summary of D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
Sat, Mar 16, 3:48 PM · Dolphin
meven updated the summary of D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
Sat, Mar 16, 2:58 PM · Dolphin
meven updated the summary of D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
Sat, Mar 16, 2:39 PM · Dolphin
meven updated the summary of D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
Sat, Mar 16, 2:37 PM · Dolphin
meven updated the summary of D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
Sat, Mar 16, 2:37 PM · Dolphin
meven added a comment to D19775: Show preview of the filename in the save settings.

Very nice !

Sat, Mar 16, 11:58 AM · Spectacle
meven added inline comments to D19782: BUG 378613: Allow dolphin to auto play previewed media file, click on preview to play/pause videos or audio.
Sat, Mar 16, 11:14 AM · Dolphin