- User Since
- Feb 10 2018, 12:40 PM (91 w, 4 d)
Anyone to review this ? 30 lines change + test
Seems sane to me and nice since it removes some code.
The issue could be as well located in previewjob.cpp.
Could you debug why KMountPoint::List::findByPath is called with an empty string or non-existing file.
We might want to prevent this to happen instead.
Tue, Nov 12
This is a nice patch with just a few rough edges to polish.
I encourage @msciubidlo to have a look again.
Do you want someone else to commit this patch or do you want to do it yourself https://community.kde.org/Infrastructure/Phabricator ?
Abandoned in favor of D24962
Mon, Nov 11
Bump KF5_MIN_VERSION to 5.64
Seems good to me.
Tested and works
Sun, Nov 10
Clean double lz4 checks
Add missing lz4 check
Sat, Nov 9
Add m_textTimestamp constructor initializer
Amend commit comment, add some comments
nitpicks formatting and naming
Reduce update delay to 50ms
I am not so sure about this 150 ms delay.
When navigating with the keyboard, it is quite noticeable.
So in the meantime, I am gonna reduce this delay to 50 ms.
Fri, Nov 8
Will wait for @elvisangelaccio feedback for a few days.
Split obs changes to D25221
rebasing on master
rebase on master
Reapply some lost changes
Add OBS entry to screenrecorders
@aspotashev Is it good for ?
Delay by 150ms before the status bar text is updated
Better translator-friendly implementation
Replace remaning kde project links to https://kde.org/applications/
Update commit message
Fix kdf link and update others
Thu, Nov 7
I feel the code is ready for review toward merging.
Add Stat prefix to enum values of KIO::StatDetail
I guess https://source.puri.sm/Librem5/wlroots/blob/librem5-0.6.x/types/wlr_export_dmabuf_v1.c can be used as inspiration for our own implementation.
Added in https://source.puri.sm/Librem5/wlroots/commit/36bd4795d4fe2282dfcc59f26863bac2896a4a3f
Wed, Nov 6
We can use clang-tidy and its fixits to modernize code.
Use m_current instead of passing const QUrl &url around
Mon, Nov 4
Move KIO::StatJob::StatDetail(s) to KIO::StatDetail(s), wrapped old details metadata code path with KIOCORE_ENABLE_DEPRECATED_SINCE