mart (Marco Martin)
User

Projects (15)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:09 PM (173 w, 6 d)
Availability
Available

Recent Activity

Today

mart created T9398: component: thumbnail based grid view.
Wed, Aug 15, 9:56 AM · Kirigami
mart created T9397: component: something akin to KAboutDialog.
Wed, Aug 15, 9:55 AM · Kirigami
mart created T9396: component: date-time.
Wed, Aug 15, 9:55 AM · Kirigami
mart moved T3976: Kirigami Mockup Components for Pencil from Work in Progress to Postponed on the Kirigami board.
Wed, Aug 15, 9:54 AM · VDG, Kirigami
mart created T9395: Landing Kirigami website.
Wed, Aug 15, 9:53 AM · Kirigami
mart created T9394: HIG pages about the principal Kirigami design concepts.
Wed, Aug 15, 9:52 AM · Kirigami
mart committed R1014:e777a668c348: another icon in button test (authored by mart).
another icon in button test
Wed, Aug 15, 9:24 AM
mart committed R1014:ae92b7cdc252: some icons in buttons (authored by mart).
some icons in buttons
Wed, Aug 15, 9:09 AM
mart accepted D14850: [effects] Turn off Translucency by default.

I don't think it has anything to do with privacy at all.
It's purely a design decision on what looks more elegant here.
back in the day, the effect was added mainly because having compositing was a huge achevement (linux desktops were known to not be able to do proper transpacency for a loong time)
so compiz had this on by default, therefore we did implement it and put it on by default. that's pretty much all it's to it.

Wed, Aug 15, 7:43 AM · KWin

Sun, Aug 12

mart accepted D14549: EDID parsing: replace non-printable characters with '-'.
Sun, Aug 12, 2:52 PM · Plasma
mart accepted D14672: [plasma-changeicons] Call sync() after writing.
Sun, Aug 12, 2:51 PM · Plasma
mart closed D14691: make the layout work.
Sun, Aug 12, 2:49 PM · Plasma
mart added a comment to D14764: Simplify XRandR::outputChanged.

code looks fine, can you put a longer description in the summary for git history sake?

Sun, Aug 12, 2:47 PM · Plasma

Wed, Aug 8

mart committed R296:6a0cb3efb4f1: add an implicit size (authored by mart).
add an implicit size
Wed, Aug 8, 4:44 PM
mart requested review of D14695: disable title for QML kcms.
Wed, Aug 8, 4:31 PM · Plasma
mart committed R169:b8a426dd2e69: base palette from applications (authored by mart).
base palette from applications
Wed, Aug 8, 3:44 PM
mart committed R169:e3f85373cb32: add noops of all required private functions of Theme (authored by mart).
add noops of all required private functions of Theme
Wed, Aug 8, 3:14 PM
mart updated the summary of D14581: support for multilevel kcms.
Wed, Aug 8, 1:45 PM · Plasma
mart abandoned D14579: api for multi level kcms.
Wed, Aug 8, 1:44 PM · Frameworks
mart retitled D14581: support for multilevel kcms from e a breadcrumb for multilevel kcms to support for multilevel kcms.
Wed, Aug 8, 1:44 PM · Plasma
mart updated the diff for D14581: support for multilevel kcms.

new approach: modules paint themselves

Wed, Aug 8, 1:43 PM · Plasma
mart updated the diff for D14580: support for multi pages kcms.
  • paint internally the title and breadcrumb
Wed, Aug 8, 1:40 PM · Frameworks
mart committed R295:614ccc7d0d13: paint internally the title and breadcrumb (authored by mart).
paint internally the title and breadcrumb
Wed, Aug 8, 1:39 PM
mart committed R169:a243c36ddeb3: export separatorvisible to the globaltoolbar (authored by mart).
export separatorvisible to the globaltoolbar
Wed, Aug 8, 1:35 PM
mart committed R124:1e9a967f2669: build (authored by mart).
build
Wed, Aug 8, 12:35 PM
mart committed R116:73a57823ce86: make the layout work (authored by mart).
make the layout work
Wed, Aug 8, 12:31 PM
mart requested review of D14691: make the layout work.
Wed, Aug 8, 12:24 PM · Plasma
mart abandoned D14690: make the layout of the nm kcm fully work.
Wed, Aug 8, 12:21 PM · Plasma
mart added a reviewer for D14690: make the layout of the nm kcm fully work: jgrulich.
Wed, Aug 8, 11:50 AM · Plasma
mart requested review of D14690: make the layout of the nm kcm fully work.
Wed, Aug 8, 11:50 AM · Plasma
mart committed R169:e74a1a1e90eb: only inherit width if parent width > 0 (authored by mart).
only inherit width if parent width > 0
Wed, Aug 8, 11:39 AM
mart accepted D14577: Fixed missing import in Outline.qml and added more options to ruler.
Wed, Aug 8, 8:27 AM

Tue, Aug 7

mart committed R169:867283d0c159: Fix the Kirigami QRC static plugin generation (authored by mart).
Fix the Kirigami QRC static plugin generation
Tue, Aug 7, 3:51 PM
mart closed D14673: Fix the Kirigami QRC static plugin generation.
Tue, Aug 7, 3:51 PM · Kirigami
mart updated the diff for D14673: Fix the Kirigami QRC static plugin generation.
  • kirigami.qrc.in for cmake, kirigami.qrc for qmake
Tue, Aug 7, 3:50 PM · Kirigami
mart commandeered D14673: Fix the Kirigami QRC static plugin generation.
Tue, Aug 7, 3:44 PM · Kirigami
mart committed R169:ef23a56dfe09: start on custom toolbars (authored by mart).
start on custom toolbars
Tue, Aug 7, 2:19 PM
mart accepted D14670: Fix an undefined reference error with static mode + LTO.
Tue, Aug 7, 12:35 PM · Kirigami
mart committed R1014:bbd2633438d6: mobileApp is almost the same file, but with a contextDrawer (authored by mart).
mobileApp is almost the same file, but with a contextDrawer
Tue, Aug 7, 9:28 AM
mart committed R169:7181915c909b: remove the gallery (authored by mart).
remove the gallery
Tue, Aug 7, 9:06 AM
mart committed R1014:10f9886a0caa: sync with the frameworks version (authored by mart).
sync with the frameworks version
Tue, Aug 7, 9:04 AM
mart committed R169:7b194df2dd1d: FormLayout is an Item (authored by mart).
FormLayout is an Item
Tue, Aug 7, 8:43 AM

Mon, Aug 6

mart committed R169:7120cd98a680: Ensure drawerOpen property is synced correctly (authored by mart).
Ensure drawerOpen property is synced correctly
Mon, Aug 6, 4:14 PM
mart committed R169:fc5bb5fd892a: ld on old gcc (authored by mart).
ld on old gcc
Mon, Aug 6, 2:03 PM
mart requested changes to D14562: Introduce Theme.smallestFont.

good idea, 2 comments:

  • the import version of platformtheme cannot change or will break existing code
  • needs a smallestfont declared also in all version of qml-base theme implementations, one in controls, one is in the kirigami repo, under controls, one is in the plasma-framework repo, under src/declarativeimports/kirigamiplasmastyle/
Mon, Aug 6, 9:02 AM · Kirigami

Fri, Aug 3

mart committed R124:71635effc008: Same text color for enabled and disabled (authored by mart).
Same text color for enabled and disabled
Fri, Aug 3, 3:07 PM
mart added a reviewer for D14581: support for multilevel kcms: VDG.
Fri, Aug 3, 3:04 PM · Plasma
mart added a comment to D14581: support for multilevel kcms.

Fri, Aug 3, 3:04 PM · Plasma
mart added a reviewer for D14580: support for multi pages kcms: Frameworks.
Fri, Aug 3, 3:02 PM · Frameworks
mart added a reviewer for D14579: api for multi level kcms: Frameworks.
Fri, Aug 3, 3:02 PM · Frameworks
mart requested review of D14581: support for multilevel kcms.
Fri, Aug 3, 3:01 PM · Plasma
mart requested review of D14580: support for multi pages kcms.
Fri, Aug 3, 2:58 PM · Frameworks
mart added a dependent revision for D14579: api for multi level kcms: D14580: support for multi pages kcms.
Fri, Aug 3, 2:58 PM · Frameworks
mart requested review of D14579: api for multi level kcms.
Fri, Aug 3, 2:56 PM · Frameworks
mart committed R296:7adae4470569: ensure we are always writing in the engine's root context (authored by mart).
ensure we are always writing in the engine's root context
Fri, Aug 3, 2:32 PM
mart committed R296:14850b182092: better readability (authored by mart).
better readability
Fri, Aug 3, 2:30 PM
mart committed R169:007ef1e0c119: support dynamically adding and removing title (authored by mart).
support dynamically adding and removing title
Fri, Aug 3, 10:13 AM

Thu, Aug 2

mart committed R169:1c89c00379bb: introduce actionsVisible (authored by mart).
introduce actionsVisible
Thu, Aug 2, 2:28 PM
mart added a comment to F6172220: After.png.

I'm not convinced by that, especially having the whole page gray, as is an item view, it should be white.

Thu, Aug 2, 1:24 PM
mart added a comment to F6172218: Updates page.png.

why the 231 updates selected row is white? being part of the toolbar kinda breaks the flow (note the top doesn't have a separator in this case in order to have a single block for the toolbar

Thu, Aug 2, 1:19 PM
mart committed R169:7a456f063192: adapt margins when scrollbar appears/disappear (authored by mart).
adapt margins when scrollbar appears/disappear
Thu, Aug 2, 1:02 PM
mart committed R169:555d6a5cfb79: better management of the size (authored by mart).
better management of the size
Thu, Aug 2, 11:36 AM
mart added inline comments to D14542: WIP: Basic KCM using new virtual desktops DBus interface.
Thu, Aug 2, 10:29 AM · KWin
mart added a comment to D13887: use the new plasma virtual desktop protocol.
In D13887#301460, @hein wrote:

Kai pointed me at plasma-workspace/gmenu-dbusmenu-proxy/gdbusmenutypes_p.h, it seems I really need to clone all this marshalling stuff on the client side too - I guess QtDbus ultimately just uses fdo.Introspect to provide a type name annotation and then does a lookup in the meta type registry on the other side, instead of really providing convenience stuff to work with DBus types ...

Still not a fan of the struct for the other reason though as mentioned :) Anyway, I will use it for now tomorrow.

Thu, Aug 2, 10:12 AM · KWin

Mon, Jul 30

mart accepted D13340: Initial content for card.
Mon, Jul 30, 8:22 AM · KDE Human Interface Guidelines

Fri, Jul 27

mart committed R265:d80df6d86f99: api for multi level kcms in base kcmodule (authored by mart).
api for multi level kcms in base kcmodule
Fri, Jul 27, 5:14 PM
mart committed R124:324142bb2120: proper opacity (authored by mart).
proper opacity
Fri, Jul 27, 3:51 PM
mart committed R124:f12e684a9998: first breadcrumb prototype (authored by mart).
first breadcrumb prototype
Fri, Jul 27, 3:29 PM
mart committed R295:afe8ad6bc805: sync the current level (authored by mart).
sync the current level
Fri, Jul 27, 3:22 PM
mart committed R295:0acc5dee48df: e the new api for levels (authored by mart).
e the new api for levels
Fri, Jul 27, 3:22 PM
mart accepted D14387: Optimise setting up the palette.
Fri, Jul 27, 2:07 PM · Kirigami
mart committed R169:594eb923a591: AbstractApplciationItem shouldn't have its own size, only implicit (authored by mart).
AbstractApplciationItem shouldn't have its own size, only implicit
Fri, Jul 27, 1:44 PM
mart committed R169:79e6132d8c19: new signals pagePushed/pageRemoved (authored by mart).
new signals pagePushed/pageRemoved
Fri, Jul 27, 10:52 AM
mart committed R249:296ee789c773: a file has been renamed (authored by mart).
a file has been renamed
Fri, Jul 27, 10:29 AM
mart added a comment to D13744: Let ki18n macro file name follow style of other find_package related files.

KI18n fails to install now

Fri, Jul 27, 10:24 AM · Frameworks

Thu, Jul 26

mart committed R169:448458d006f8: fix logic (authored by mart).
fix logic
Thu, Jul 26, 3:39 PM
mart committed R169:9a261bff2e51: add ScenePosition element (authored by mart).
add ScenePosition element
Thu, Jul 26, 3:26 PM
mart committed R242:56f0df412713: if an applet is invalid, it has immediately UiReadyConstraint (authored by mart).
if an applet is invalid, it has immediately UiReadyConstraint
Thu, Jul 26, 11:10 AM
mart closed D14341: if an applet is invalid, it has immediately UiReadyConstraint.
Thu, Jul 26, 11:10 AM · Frameworks
mart updated the summary of D14341: if an applet is invalid, it has immediately UiReadyConstraint.
Thu, Jul 26, 11:09 AM · Frameworks
mart updated the diff for D13887: use the new plasma virtual desktop protocol.
  • new dbus protocol which maps more closely the wayland one
Thu, Jul 26, 10:55 AM · KWin
mart committed R108:540cde6058ed: new dbus protocol which maps more closely the wayland one (authored by mart).
new dbus protocol which maps more closely the wayland one
Thu, Jul 26, 10:55 AM

Wed, Jul 25

mart committed R124:eb265ac7d70c: Merge branch 'Plasma/5.13' (authored by mart).
Merge branch 'Plasma/5.13'
Wed, Jul 25, 3:52 PM
mart committed R124:6f032226cebe: check for window existence (authored by mart).
check for window existence
Wed, Jul 25, 3:52 PM
mart added a comment to D12820: Add KWayland virtual desktop protocol.

RFC: add back some info for the layout? (in particular: rows and orientation, tought orientation is a bit concerning as is view-spacific)

Wed, Jul 25, 3:15 PM · Frameworks
mart added a comment to D13887: use the new plasma virtual desktop protocol.

added a DBus interface to manage virtual desktops, the functionality of the kcm should be covered
(the kcm could be ported to this for both the x11 and wayland cases)
Still no support for orientation in wayland case.
not sure if the number of rows should be in the wayland protocol & having orientation as well.
The problem with orientation (even with current x11 implementation) is that is view-specific, so if you have 2 pagers, one in an horizontal panel and one in a vertical one, they will override the global orientation to each other, but one of the two should "win" and force the desktopgrid and other effects to conform to that layout.

Wed, Jul 25, 3:11 PM · KWin
mart updated the diff for D13887: use the new plasma virtual desktop protocol.
  • first rough non working prototype of a DBus interface
  • almost working dbus interface
  • move waypand protocol logic in VirtualDesktopManager
  • expose rows to the dbus interface
Wed, Jul 25, 3:04 PM · KWin
mart committed R108:1ffc5bc37702: expose rows to the dbus interface (authored by mart).
expose rows to the dbus interface
Wed, Jul 25, 3:04 PM
mart added inline comments to D14211: Collapsible Sidebar Mode.
Wed, Jul 25, 1:08 PM · VDG, Kirigami
mart committed R169:e3644aa4a191: hide->show (authored by mart).
hide->show
Wed, Jul 25, 12:59 PM
mart committed R169:6b887b056ce6: Collapsible Sidebar Mode (authored by mart).
Collapsible Sidebar Mode
Wed, Jul 25, 12:59 PM
mart closed D14211: Collapsible Sidebar Mode.
Wed, Jul 25, 12:59 PM · VDG, Kirigami
mart committed R108:6cb63284e81f: move waypand protocol logic in VirtualDesktopManager (authored by mart).
move waypand protocol logic in VirtualDesktopManager
Wed, Jul 25, 12:32 PM
mart added inline comments to D13887: use the new plasma virtual desktop protocol.
Wed, Jul 25, 8:42 AM · KWin

Tue, Jul 24

mart requested review of D14341: if an applet is invalid, it has immediately UiReadyConstraint.
Tue, Jul 24, 7:10 PM · Frameworks
mart committed R108:8dd15548fe7e: almost working dbus interface (authored by mart).
almost working dbus interface
Tue, Jul 24, 1:52 PM

Mon, Jul 23

mart committed R108:45708889d106: first rough non working prototype of a DBus interface (authored by mart).
first rough non working prototype of a DBus interface
Mon, Jul 23, 6:19 PM
mart added a comment to D14218: Introduce a test to make sure we're not offering duplicated icons.

+100 from me as well

Mon, Jul 23, 3:23 PM · Frameworks
mart updated the diff for D13887: use the new plasma virtual desktop protocol.
  • adress some comments
Mon, Jul 23, 2:36 PM · KWin
mart committed R108:115c796b23f0: adress some comments (authored by mart).
adress some comments
Mon, Jul 23, 2:29 PM