mart (Marco Martin)
User

Projects (15)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:09 PM (166 w, 2 h)
Availability
Available

Recent Activity

Today

mart committed R169:6ed28c4d07fa: fix positioning of the handle (authored by mart).
fix positioning of the handle
Wed, Jun 20, 6:03 PM
mart committed R169:a1b5be03e05e: fixes in toolbar sizing (authored by mart).
fixes in toolbar sizing
Wed, Jun 20, 6:03 PM
mart committed R169:e1d7d22df47f: some RTL fixes (authored by mart).
some RTL fixes
Wed, Jun 20, 2:30 PM
mart committed R169:78fb071a8138: warnings -- (authored by mart).
warnings --
Wed, Jun 20, 2:30 PM
mart committed R169:4f9d5c93fbb3: support rightReservedSpace (authored by mart).
support rightReservedSpace
Wed, Jun 20, 12:32 PM
mart accepted D13612: Fix drop between shared views.
Wed, Jun 20, 8:35 AM · Plasma
mart accepted D13614: Workaround crash in Aurorae destruction.
Wed, Jun 20, 8:35 AM · KWin
mart accepted D13617: Support kwin fractional scaling in wayland backend.
Wed, Jun 20, 8:34 AM · Plasma
mart added a comment to D13625: Add 'Documentation' category to the Application menus.

good idea but a bit on the fence on this.. is something that is definitely useful, but for a short time.. i see the user wanting to eventually remove this after having used said distro for enough time and feeling to have learned it

Wed, Jun 20, 8:34 AM · Plasma

Yesterday

mart added a comment to T8170: Attend External Events 2018: Embedded Linux Conference Europe.

I can submit a kirigami talk about convergence things.. tough I'm not sure how much is on topic with embedded and iot

Tue, Jun 19, 7:14 PM · Plasma, KDE Promo
mart committed R169:da264cd6e8d9: start moving the globaltoolbar in the Page itself (authored by mart).
start moving the globaltoolbar in the Page itself
Tue, Jun 19, 4:13 PM
mart committed R169:0eee66bdb4b4: work a bit better with layers (authored by mart).
work a bit better with layers
Tue, Jun 19, 2:09 PM
mart committed R169:7f427728e200: add missing file (authored by mart).
add missing file
Tue, Jun 19, 12:59 PM
mart committed R169:786843f579c7: move the global toolbar in own file (authored by mart).
move the global toolbar in own file
Tue, Jun 19, 12:46 PM
mart committed R169:4748638313dd: tweak visible property (authored by mart).
tweak visible property
Tue, Jun 19, 12:46 PM
mart committed R169:a37bf5a40c6e: better centering of breadcrumb (authored by mart).
better centering of breadcrumb
Tue, Jun 19, 12:46 PM
mart accepted D13487: Fix build against static Qt without QLibrary.
Tue, Jun 19, 8:56 AM · Kirigami
mart accepted D13573: Touchpad KCM QtQuickControls2 Conversion.

QML-wise looks ok for me now, still wait for Roman's accept as well.

Tue, Jun 19, 8:56 AM · Plasma
mart accepted D13542: [effects/slide] Add "Slide desktop background" option.
Tue, Jun 19, 8:52 AM · KWin
mart added a comment to D13530: Add XDG WmBase support.

+1, no stray commas, please :)
(should probably be added in the kdelibs coding style page)

Tue, Jun 19, 8:51 AM · KWin

Mon, Jun 18

mart committed R169:8b773cfc2968: correct layout for the global menu button (authored by mart).
correct layout for the global menu button
Mon, Jun 18, 5:29 PM
mart committed R169:cae55b08b70a: support dynamically changing the toolbar style (authored by mart).
support dynamically changing the toolbar style
Mon, Jun 18, 4:31 PM
mart committed R169:6f23ad8a1fee: proper page (authored by mart).
proper page
Mon, Jun 18, 4:31 PM
mart committed R169:22624afbbb2d: more documentation (authored by mart).
more documentation
Mon, Jun 18, 3:37 PM
mart committed R169:e98353313c0a: fully support legacy (authored by mart).
fully support legacy
Mon, Jun 18, 3:37 PM
mart committed R169:a66e1dd60fd9: integrate with ActionButton (authored by mart).
integrate with ActionButton
Mon, Jun 18, 3:37 PM
mart committed R169:042febe68877: globalToolBar exported in api (authored by mart).
globalToolBar exported in api
Mon, Jun 18, 2:15 PM
mart committed R169:95b726ad8bc9: PrivateActionToolButton sizing on themes != desktop (authored by mart).
PrivateActionToolButton sizing on themes != desktop
Mon, Jun 18, 1:19 PM
mart added a comment to D13481: Recommend window border size "None".

+1

Mon, Jun 18, 10:40 AM · Plasma
mart requested changes to D13573: Touchpad KCM QtQuickControls2 Conversion.
Mon, Jun 18, 10:37 AM · Plasma

Fri, Jun 15

mart committed R169:d38f19c7954a: try to dynamically load ToolBarPageHeader (authored by mart).
try to dynamically load ToolBarPageHeader
Fri, Jun 15, 4:47 PM
mart committed R169:ffca7916dafa: merge toolbars when there are both global and page ones (authored by mart).
merge toolbars when there are both global and page ones
Fri, Jun 15, 3:39 PM

Thu, Jun 14

mart committed R169:ac822b2172a0: use only one global ApplicationHeader (authored by mart).
use only one global ApplicationHeader
Thu, Jun 14, 5:04 PM
mart accepted D13533: Add the arclint file in kwayland.
Thu, Jun 14, 2:32 PM · Frameworks
mart updated the diff for D12820: Add KWayland virtual desktop protocol.
  • remove release from the protocol
  • new_id is id
Thu, Jun 14, 2:31 PM · Frameworks
mart committed R127:6319b0dac389: new_id is id (authored by mart).
new_id is id
Thu, Jun 14, 2:31 PM
mart committed R127:90fdb5414c7d: remove release from the protocol (authored by mart).
remove release from the protocol
Thu, Jun 14, 2:31 PM
mart committed R169:40f0967da478: Introduce ActionToolbar (authored by mart).
Introduce ActionToolbar
Thu, Jun 14, 11:34 AM
mart committed R169:ab8fe3d7741f: update qmltypes (authored by mart).
update qmltypes
Thu, Jun 14, 11:32 AM
mart committed R169:2b8fab409fcd: first prototype of ActionToolbar and port usage (authored by mart).
first prototype of ActionToolbar and port usage
Thu, Jun 14, 11:32 AM
mart committed R169:4dd77fe05499: document flat (authored by mart).
document flat
Thu, Jun 14, 11:32 AM
mart committed R169:fd8fb834843c: remove the dead code (authored by mart).
remove the dead code
Thu, Jun 14, 11:32 AM
mart closed D13433: Introduce ActionToolbar.
Thu, Jun 14, 11:32 AM · Kirigami
mart committed R169:986e83ab7c14: concept of currentHeader (authored by mart).
concept of currentHeader
Thu, Jun 14, 11:24 AM

Wed, Jun 13

mart committed R169:8b803828ad9e: fix pull to refresh (authored by mart).
fix pull to refresh
Wed, Jun 13, 5:44 PM
mart committed R169:ea63ec6c2e6a: almost full functionality (authored by mart).
almost full functionality
Wed, Jun 13, 5:27 PM
mart added a comment to T8707: Window borders.

So, there are many practical benefits for cropping (and it works great for OS X). Are there any practical reasons for not doing it?

Wed, Jun 13, 4:17 PM · VDG
mart accepted D13372: Mouse KCM Redesign Using Kirigami.
Wed, Jun 13, 1:59 PM · Plasma
mart added a comment to T9009: Add the action toolbar to the toolbar page.

To remember it, copying from a discussion from Telegram:

Wed, Jun 13, 9:35 AM · KDE Human Interface Guidelines

Tue, Jun 12

mart updated the diff for D12820: Add KWayland virtual desktop protocol.
  • remove neighbours, only order
  • store data in a single structure
  • auto activate a new desktop
Tue, Jun 12, 4:33 PM · Frameworks
mart committed R127:c89495b886e3: auto activate a new desktop (authored by mart).
auto activate a new desktop
Tue, Jun 12, 4:33 PM
mart committed R127:ce6acf7d51b5: store data in a single structure (authored by mart).
store data in a single structure
Tue, Jun 12, 4:33 PM
mart committed R127:1e25ae6c6a28: remove neighbours, only order (authored by mart).
remove neighbours, only order
Tue, Jun 12, 4:33 PM
mart committed R858:935f754f6957: no pixel values in checkindicator (authored by mart).
no pixel values in checkindicator
Tue, Jun 12, 2:31 PM
mart added a reverting change for D13086: Don't set explicit spacing on RadioButton/CheckBox: R858:935f754f6957: no pixel values in checkindicator.
Tue, Jun 12, 2:31 PM · Plasma
mart committed R169:837301dcfb29: correct resizing of the toolbar (authored by mart).
correct resizing of the toolbar
Tue, Jun 12, 2:10 PM
mart committed R169:a4c11fec714d: fix auto hide toolbars in mobile (authored by mart).
fix auto hide toolbars in mobile
Tue, Jun 12, 12:46 PM
mart committed R169:a7e591f7ef66: minimally functioning toolbar (authored by mart).
minimally functioning toolbar
Tue, Jun 12, 11:36 AM
mart accepted D13194: Use the new drag handle in the Language KCM.
Tue, Jun 12, 9:47 AM · Plasma

Mon, Jun 11

mart committed R169:98706f2ee1bc: first prototype of moval of handles into PageRow (authored by mart).
first prototype of moval of handles into PageRow
Mon, Jun 11, 4:16 PM
mart added a comment to T8995: Package Maliit and friends.

Note that while our long term plan is to go with the internal KWin keyboard as has several advantages, we must ship an ad interim solution as a virtual keyboard for x11 even if it's very far from perfect, that gets a keyboard that can open automatically on both qt and gtk, so we should have a maliit working almost out of the box for neon

Mon, Jun 11, 4:08 PM · Neon
mart committed R169:4de818787bad: no extra margin for overlaysheets in overlay (authored by mart).
no extra margin for overlaysheets in overlay
Mon, Jun 11, 2:03 PM
mart committed R169:89a4248bf279: fix the menu for Qt 5.9 (authored by mart).
fix the menu for Qt 5.9
Mon, Jun 11, 1:36 PM
mart added inline comments to D13372: Mouse KCM Redesign Using Kirigami.
Mon, Jun 11, 12:36 PM · Plasma
mart added a comment to D13372: Mouse KCM Redesign Using Kirigami.

here a patch against this which ports it to qqc2, using the completely different radiobutton mechanics qqc2 uses, fixing separators, removing plasmacore import

Mon, Jun 11, 12:34 PM · Plasma
mart committed R858:7413f47ada94: own sizehit for sliders (authored by mart).
own sizehit for sliders
Mon, Jun 11, 12:28 PM
mart committed R858:e0aabfb0a610: use RadioIndicator for everybody (authored by mart).
use RadioIndicator for everybody
Mon, Jun 11, 12:28 PM
mart added inline comments to D13372: Mouse KCM Redesign Using Kirigami.
Mon, Jun 11, 11:24 AM · Plasma
mart added a comment to D13372: Mouse KCM Redesign Using Kirigami.
In D13372#277040, @mart wrote:

for me, using qqc1 in a new kcm, is an absolute blocker, no matter what the problem is with qqc2, problems must be fixed, not worked around. ever.

So please keep following the topic and help to find the best way to fix the problems.

Mon, Jun 11, 10:36 AM · Plasma
mart requested changes to D13372: Mouse KCM Redesign Using Kirigami.

for me, using qqc1 in a new kcm, is an absolute blocker, no matter what the problem is with qqc2, problems must be fixed, not worked around. ever.

Mon, Jun 11, 10:12 AM · Plasma
mart accepted D13418: Add build dependencies to INSTALL file.
Mon, Jun 11, 10:04 AM · Plasma, Documentation
mart accepted D13422: [effects/slide] Use FormLayout in KCM.
Mon, Jun 11, 10:01 AM · KWin
mart accepted D13459: [RFC] Implement new window tab API in DecoratedClientImpl.
Mon, Jun 11, 9:59 AM · KWin
mart accepted D13478: Correctly check forcebackgroundcontrastrule.
Mon, Jun 11, 9:52 AM · KWin
mart added a comment to D12820: Add KWayland virtual desktop protocol.

Don't feel the need to change the code unless you and whoever else agree.
I'm not forcing anything, just commenting on my preference.

Mon, Jun 11, 9:43 AM · Frameworks

Sat, Jun 9

mart added a comment to D13433: Introduce ActionToolbar.

Did you fix your binding loop?

Sat, Jun 9, 9:51 AM · Kirigami

Fri, Jun 8

mart added a comment to D13433: Introduce ActionToolbar.

Fri, Jun 8, 4:14 PM · Kirigami
mart added reviewers for D13433: Introduce ActionToolbar: Kirigami, hein.
Fri, Jun 8, 4:13 PM · Kirigami
mart updated the diff for D13433: Introduce ActionToolbar.
  • document flat
Fri, Jun 8, 4:11 PM · Kirigami
mart requested review of D13433: Introduce ActionToolbar.
Fri, Jun 8, 4:10 PM · Kirigami
mart added a comment to D12820: Add KWayland virtual desktop protocol.

In the current (even on X state) I can represent 4 virtual desktops in 1 2x2 grid on the pager so it fits best, yet 4x1 along the edges of the cube, and it wouldn't be unfeasible to display them 1x4 in an activity manager style switcher.

What I think would work best is a shared ordered-list, but the visual representation of that ordered list is entirely up to the view.

Kwin still needs to turn that into a grid in some places for keyboard nav and the slide effect, but that's just the case of a single int config value.

Fri, Jun 8, 2:29 PM · Frameworks
mart committed R120:033ad5ca60b3: Port Plasma Desktop Scripting to QJSEngine (authored by mart).
Port Plasma Desktop Scripting to QJSEngine
Fri, Jun 8, 2:15 PM
mart closed D13112: Port Plasma Desktop Scripting to QJSEngine.
Fri, Jun 8, 2:15 PM · Plasma
mart committed R120:13b9064f1bce: Port Plasma Desktop Scripting to QJSEngine (authored by mart).
Port Plasma Desktop Scripting to QJSEngine
Fri, Jun 8, 2:14 PM
mart updated the diff for D13112: Port Plasma Desktop Scripting to QJSEngine.
  • newError function to create JS errors
Fri, Jun 8, 2:14 PM · Plasma
mart added a comment to D13112: Port Plasma Desktop Scripting to QJSEngine.

https://github.com/pashazz/ksetwallpaper/blob/master/ksetwallpaper.py works perfectly

Fri, Jun 8, 2:03 PM · Plasma
mart added a comment to D13112: Port Plasma Desktop Scripting to QJSEngine.

+++++
Thanks for tackling a very boring and difficult task.

There are two things I'd like to see also tested:

  • the DBus wallpaper changing script that I know a bunch of people use
Fri, Jun 8, 10:56 AM · Plasma
mart accepted D13390: Fonts KCM: Fix text readability regression.

awesome, thanks :)

Fri, Jun 8, 10:53 AM · Plasma

Thu, Jun 7

mart committed R169:0feb36b70ea4: first prototype of ActionToolbar and port usage (authored by mart).
first prototype of ActionToolbar and port usage
Thu, Jun 7, 4:49 PM
mart accepted D13374: Check the visible property of the action as well.
Thu, Jun 7, 3:26 PM · Kirigami
mart committed R169:d66867d6b54b: warnings-- (authored by mart).
warnings--
Thu, Jun 7, 1:19 PM
mart committed R169:38b6ae02d68c: ibetter look/aligment in compact mode (authored by mart).
ibetter look/aligment in compact mode
Thu, Jun 7, 1:08 PM
mart added a comment to D13405: Added page about the switch component.

On desktop they are tricky as since qwidgets doesn't have them, to style them with qqc2-desktop-style i do a tiny slider, which works but is kind of lol... the only alternative is to draw something custom which will not be styled in any other desktop theme

Thu, Jun 7, 12:53 PM · KDE Human Interface Guidelines
mart added a comment to D13390: Fonts KCM: Fix text readability regression.

edit: Kirigami.Theme.colorGroup: was wrong,should have been
Kirigami.Theme.colorSet: Kirigami.Theme.Window

Thu, Jun 7, 12:49 PM · Plasma
mart added a comment to D13390: Fonts KCM: Fix text readability regression.

on which it looks like that:

Thu, Jun 7, 12:33 PM · Plasma
mart added a comment to D13390: Fonts KCM: Fix text readability regression.
In D13390#275153, @mart wrote:

what you should do is:
TextField {

readOnly: true
Kirigami.Theme.inherit: false   //always to be set when you are writing anything to the Theme attached proeprty
Kirigami.Theme.colorGroup: Kirigami.Theme.Window

}

changing the textfield colorgroup to window, will make its background to become gray, so a look somewhat less "clickable"

Now it looks as if you can edit the text, and the previews are placeholders for what you can type in:

Thu, Jun 7, 12:32 PM · Plasma
mart added a comment to D13178: Compress calls to configuration slots upon new connections.
In D13178#270671, @mart wrote:

are configureKeyboard configureMouse etc doing an immediate write to disk? (like KConfig::sync()

Hey notmart, long time no see!

The configureKeyboard() method is calling xmodmap (should the user need special configuration), so who knows what happens in there.

Thu, Jun 7, 10:35 AM · Plasma
mart added inline comments to D13194: Use the new drag handle in the Language KCM.
Thu, Jun 7, 10:24 AM · Plasma
mart added a comment to D13202: Circular user avatar for Kickoff.

The bordered avatars are done in a different manner than this (mine involves less math!). I'll see if there's a way I can sort it out.

If you copy and paste the ShaderEffect from UserDelegate.qml colorBorder is a property you can change

Thu, Jun 7, 10:20 AM · Plasma
mart added a comment to D13202: Circular user avatar for Kickoff.

Nice work! Will test it out later today.

There's no reason to have the appearance user-selectable, IMHO. Part of the goal here is a consistent visual appearance. I vote for always showing the round avatar and marking this as fixing Bug 386656.

The one visual improvement I could think of is adding a thin light gray outline around the circle to help separate it from the background. This is done on the login and lock screens; might be able to mine those implementations for ideas, if it's not too hard. But even without that, this is looking good. :)

Thu, Jun 7, 10:18 AM · Plasma