mart (Marco Martin)
User

Projects (17)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:09 PM (234 w, 4 d)
Availability
Available

Recent Activity

Fri, Oct 11

mart added a comment to D24265: support global edit mode.

proper look now

Fri, Oct 11, 4:20 PM · Plasma
mart updated the diff for D24265: support global edit mode.
  • proper plasmoid background
Fri, Oct 11, 4:19 PM · Plasma
mart added a comment to D24265: support global edit mode.

hold on, there is some clipping going on actually

Fri, Oct 11, 4:06 PM · Plasma
mart added a comment to D24265: support global edit mode.
In D24265#545400, @GB_2 wrote:

It would be nice if the desktop toolbox had a shadow and had the standard background.

Fri, Oct 11, 3:14 PM · Plasma
mart added a comment to D24265: support global edit mode.

does that on current version of D24264

Fri, Oct 11, 2:55 PM · Plasma
mart updated the diff for D24264: edit mode action and dbus.
  • only close with proper touch events
Fri, Oct 11, 2:23 PM · Plasma
mart committed R20:0d3ad6fd2ea3: stop at bounds for the top panel (authored by mart).
stop at bounds for the top panel
Fri, Oct 11, 1:22 PM
mart added a comment to D24454: Include an emoji picker.

Cool beans.

Can you make the drawer/sidebar more narrow like we do in Discover? The width is hardcoded in Kirigami to something that's just way too high for this application IMO.

Also an "all" category on top would be nice too. Many smartphone implementations also have a "recently/frequently used" category that's quite user-friendly.

Fri, Oct 11, 12:23 PM · VDG, Plasma
mart added a comment to D24265: support global edit mode.
In D24265#544549, @mart wrote:

I actually like that a lot, to me is really the click anywhere to dismiss pattern all over the place in modal dialogs, websites and what not.
If I have to remove it, i would at least keep it for touch events, as i really want it in plasma mobile (and is harder to exit from edit mode there)

I'm okay keeping it on Plasma Mobile. To me it feels out of place on desktop because I don't have a mental model that clicking on the desktop does something like this and I do it a lot. :)

Fri, Oct 11, 10:38 AM · Plasma
mart committed R20:7347c671a331: visible button (authored by mart).
visible button
Fri, Oct 11, 10:06 AM
mart committed R20:f75b55699eee: mouseareas touch (authored by mart).
mouseareas touch
Fri, Oct 11, 9:54 AM
mart committed R20:38459f3e78de: bottom panel transparent when showing desktop (authored by mart).
bottom panel transparent when showing desktop
Fri, Oct 11, 9:54 AM
mart committed R20:902eed025880: ensure the top quicksettings is always on top of the second row (authored by mart).
ensure the top quicksettings is always on top of the second row
Fri, Oct 11, 9:01 AM
mart committed R108:10ace126be21: [wayland] Make sure fullscreen windows aren't repositioned (authored by mart).
[wayland] Make sure fullscreen windows aren't repositioned
Fri, Oct 11, 8:47 AM
mart closed D24542: [wayland] Make sure fullscreen windows aren't repositioned.
Fri, Oct 11, 8:47 AM · KWin
mart updated the diff for D24542: [wayland] Make sure fullscreen windows aren't repositioned.
  • add David's test
Fri, Oct 11, 8:46 AM · KWin
mart retitled D24542: [wayland] Make sure fullscreen windows aren't repositioned from explicitly place fullscreen windows over fullscreen to [wayland] Make sure fullscreen windows aren't repositioned.
Fri, Oct 11, 8:39 AM · KWin
mart updated the diff for D24542: [wayland] Make sure fullscreen windows aren't repositioned.
  • remove unrelated changes
Fri, Oct 11, 8:31 AM · KWin
mart accepted D24523: Disable dragging global drawer when in menu mode.
Fri, Oct 11, 8:28 AM · Kirigami
mart updated the diff for D24542: [wayland] Make sure fullscreen windows aren't repositioned.
  • fullscreen windows don't need placement
Fri, Oct 11, 8:17 AM · KWin

Thu, Oct 10

mart updated the diff for D24542: [wayland] Make sure fullscreen windows aren't repositioned.
  • whitespace
Thu, Oct 10, 6:01 PM · KWin
mart requested review of D24542: [wayland] Make sure fullscreen windows aren't repositioned.
Thu, Oct 10, 6:00 PM · KWin
mart committed R20:acc49da907e6: remove debug rectangle (authored by mart).
remove debug rectangle
Thu, Oct 10, 11:57 AM
mart accepted D24425: Listen to the application style changing.
Thu, Oct 10, 11:06 AM · Plasma
mart committed R20:3a72512e79a5: different heuristics for cutting names (authored by mart).
different heuristics for cutting names
Thu, Oct 10, 10:30 AM
mart committed R20:fbbb604318ab: don't split (authored by mart).
don't split
Thu, Oct 10, 10:08 AM
mart committed R20:91b4f891e7e6: hide applet when no notifications (authored by mart).
hide applet when no notifications
Thu, Oct 10, 10:07 AM
mart added a comment to D24265: support global edit mode.

Hmm, I have some UX concerns here after trying it out:

If I invoke Present Windows to see the desktop so that I can right-click on it to enter edit mode, when I exit the mode, all the windows return again unexpectedly. Exiting edit mode should only restore the windows if the Present Windows effect was invoked by entering edit mode, not if the effect was already invoked manually by the user.

Thu, Oct 10, 8:12 AM · Plasma

Wed, Oct 9

mart added a comment to D24265: support global edit mode.

latest version of D24264 does show the desktop when in edit mode (and as sideeffect edit mode doesn't close when the widget explorer is closed)

Wed, Oct 9, 3:14 PM · Plasma
mart added inline comments to D24263: edit mode action.
Wed, Oct 9, 3:12 PM · Frameworks
mart updated the diff for D24264: edit mode action and dbus.
  • show desktop when in edit mode
Wed, Oct 9, 3:11 PM · Plasma
mart updated the diff for D24263: edit mode action.
  • add parameter to editModeChanged
  • hide action on systemimmutable
Wed, Oct 9, 2:33 PM · Frameworks
mart committed R20:ba9c60f54ccb: smaller label, only one line of text (authored by mart).
smaller label, only one line of text
Wed, Oct 9, 2:22 PM
mart committed R20:5bd75786bc94: prevent control from eating events (authored by mart).
prevent control from eating events
Wed, Oct 9, 2:13 PM
mart accepted D24501: Use MenuItem's action property directly in ActionMenuItem.
Wed, Oct 9, 1:23 PM · Kirigami
mart accepted D24469: Allow the global drawer to become a menu if desired.
Wed, Oct 9, 1:22 PM · Kirigami
mart accepted D24474: Show menu items tooltip text.
Wed, Oct 9, 1:21 PM · Kirigami
mart accepted D24499: Do not warn about LayoutDirection in SearchField.
Wed, Oct 9, 1:21 PM · Kirigami
mart accepted D24498: Properly check enabled state of Action for ActionToolBar buttons.
Wed, Oct 9, 1:20 PM · Kirigami
mart committed R108:8d847bd0ff9f: don't allow to resize or move fullscreen windows (authored by mart).
don't allow to resize or move fullscreen windows
Wed, Oct 9, 12:32 PM
mart committed R108:1a9a49ab7a44: don't allow to resize or move fullscreen windows (authored by mart).
don't allow to resize or move fullscreen windows
Wed, Oct 9, 12:30 PM
mart closed D24515: don't allow to resize or move fullscreen windows.
Wed, Oct 9, 12:30 PM · KWin
mart requested review of D24515: don't allow to resize or move fullscreen windows.
Wed, Oct 9, 12:03 PM · KWin
mart added a comment to D24265: support global edit mode.

I would tend to agree. If we feel that it's too difficult to exit this mode, maybe we should make it more obvious, like changing the X button in the toolbox to a toolbutton with the "finish editing" text.

Wed, Oct 9, 9:35 AM · Plasma
mart added a comment to D24265: support global edit mode.

this happens because some other window gets focus (that behavior in somewhere deep in kwin and i think makes sense).
Would you keep edit mode active when the focus goes to another app? I'm very hesitant about that and don't really like the concept...

Wed, Oct 9, 8:58 AM · Plasma

Tue, Oct 8

mart added a comment to D24265: support global edit mode.
In D24265#541411, @GB_2 wrote:
  • when you open the desktop context menu it enters the edit mode automatically (probably because it thinks you still click)
Tue, Oct 8, 5:20 PM · Plasma
mart updated the diff for D24264: edit mode action and dbus.
  • don't trigger edit mode with right button
Tue, Oct 8, 5:20 PM · Plasma
mart committed R20:fc640f98271b: remove devicenotifier (authored by mart).
remove devicenotifier
Tue, Oct 8, 4:42 PM
mart committed R20:510a825b41af: widescreen mode for plasmoids (authored by mart).
widescreen mode for plasmoids
Tue, Oct 8, 4:22 PM
mart committed R20:a01e64531625: move to the right plasmoid when asked (authored by mart).
move to the right plasmoid when asked
Tue, Oct 8, 3:18 PM
mart added inline comments to D24469: Allow the global drawer to become a menu if desired.
Tue, Oct 8, 1:30 PM · Kirigami
mart requested changes to D24469: Allow the global drawer to become a menu if desired.
Tue, Oct 8, 1:28 PM · Kirigami
mart accepted D24469: Allow the global drawer to become a menu if desired.

conceptually i like it.
I would like positioning the menu right under the button and having the button looking pressed as long as the menu is open (like the ... button does)

Tue, Oct 8, 1:28 PM · Kirigami
mart accepted D24430: [KCModuleLoader] Show error when QML fails to load.
Tue, Oct 8, 11:34 AM · Frameworks
mart accepted D24429: [ConfigModule] Expose mainUi component status and error string.
Tue, Oct 8, 11:34 AM · Frameworks

Mon, Oct 7

mart committed R20:e7ade0e8c715: notifications flow top to bottom (authored by mart).
notifications flow top to bottom
Mon, Oct 7, 5:11 PM
mart committed R20:69c0edd70489: move signal strength in indicators (authored by mart).
move signal strength in indicators
Mon, Oct 7, 5:11 PM
mart committed R20:8d2cf6997282: most icons are not plasmoids anymore (authored by mart).
most icons are not plasmoids anymore
Mon, Oct 7, 5:11 PM
mart added a comment to D24265: support global edit mode.
In D24265#541411, @GB_2 wrote:

A few bugs I found:

  • when you open the desktop context menu it enters the edit mode automatically (probably because it thinks you still click)
Mon, Oct 7, 4:55 PM · Plasma
mart accepted D24402: [PlasmaComponents3] Fix checkable toolbutton background.
Mon, Oct 7, 1:25 PM · Frameworks

Sun, Oct 6

l10n daemon script <scripty@kde.org> committed R169:307ab1db97ba: Revert "don't generate shortcuts in QQuickWidget" (authored by mart).
Revert "don't generate shortcuts in QQuickWidget"
Sun, Oct 6, 10:59 AM
mart added a reverting change for R169:32d724f2b68c: don't generate shortcuts in QQuickWidget: R169:307ab1db97ba: Revert "don't generate shortcuts in QQuickWidget".
Sun, Oct 6, 10:59 AM
mart committed R169:f9dd811ef8b7: Revert "don't generate shortcuts in QQuickWidget" (authored by mart).
Revert "don't generate shortcuts in QQuickWidget"
Sun, Oct 6, 10:07 AM
mart added a reverting change for R169:32d724f2b68c: don't generate shortcuts in QQuickWidget: R169:f9dd811ef8b7: Revert "don't generate shortcuts in QQuickWidget".
Sun, Oct 6, 10:07 AM

Fri, Oct 4

mart committed R169:d2ed29be4073: start SwipeListItem port to SwipeDelegate (authored by mart).
start SwipeListItem port to SwipeDelegate
Fri, Oct 4, 4:16 PM
mart committed R20:851d17a03d58: fancier anim (authored by mart).
fancier anim
Fri, Oct 4, 2:38 PM
mart committed R20:5a4fdc5a40a7: better looking shadow (authored by mart).
better looking shadow
Fri, Oct 4, 2:28 PM
mart committed R20:2dbb5e7d835c: simplify a lot top panel (authored by mart).
simplify a lot top panel
Fri, Oct 4, 2:03 PM
mart added a comment to T11743: Create and ship LNF packages to replicate common UI styles found in macOS, Ubuntu Unity, Windows 10, etc.

From the point of users' love, this indeed is a very popular request, plus it's a good way to showcase Plasma's customizability.
https://www.youtube.com/watch?v=RX5HwumKPP8

Fri, Oct 4, 12:34 PM · Plasma, VDG
mart added a comment to T11743: Create and ship LNF packages to replicate common UI styles found in macOS, Ubuntu Unity, Windows 10, etc.

I would be very against a yet another new kcm that is in fact a kindof a "dumbed down" global themes kcm.
among proposals like that and the new recent systemsettings reordering the whole "simple by default" efforts are pretty much gone...

Fri, Oct 4, 12:26 PM · Plasma, VDG
mart added a comment to D24223: [RFC] Add global themes that mimic other platforms' workflows.

also, some bits of history:
kde2 had something along the lines in a startup wizard which could chose kde, windows, macos and irrc solaris (which was still a thing back then)

Fri, Oct 4, 12:22 PM · Plasma
mart added a comment to D24223: [RFC] Add global themes that mimic other platforms' workflows.

I'm actually not keen on the concept at all, about shipping what can only be badly done copycats of other platforms in lnf (or a separed layouts kcm.. which would be a big mistake doing at all)
this i think.. can only scream an impression of bad quality

Fri, Oct 4, 12:18 PM · Plasma
mart committed R20:592481da737e: fuse the top panel with krunner (authored by mart).
fuse the top panel with krunner
Fri, Oct 4, 11:01 AM
mart accepted D24363: Fix several build system errors.
Fri, Oct 4, 10:38 AM · Plasma
mart committed R20:46a909a64dfb: never reparent the panel (authored by mart).
never reparent the panel
Fri, Oct 4, 10:16 AM
mart committed R20:08b1e9a47df8: proper icon color (authored by mart).
proper icon color
Fri, Oct 4, 10:16 AM
mart committed R20:83f876a761e1: workaround for dragging on empty areas (authored by mart).
workaround for dragging on empty areas
Fri, Oct 4, 9:48 AM
mart accepted D24393: Switch from naked KConfig to KConfigXT.
Fri, Oct 4, 8:17 AM · Plasma
mart accepted D24394: Expose the settings object to QML.
Fri, Oct 4, 8:17 AM · Plasma
mart accepted D24392: Turn the config into the single source of truth.
Fri, Oct 4, 8:17 AM · Plasma

Thu, Oct 3

mart committed R20:d41f50579521: as an experiment, use the normal color scope (authored by mart).
as an experiment, use the normal color scope
Thu, Oct 3, 5:47 PM
mart added inline comments to D24394: Expose the settings object to QML.
Thu, Oct 3, 4:35 PM · Plasma
mart accepted D24392: Turn the config into the single source of truth.

I investigated a bit where m_defaultTheme comes from. It seems it goes all way back to the old plasma4 version of the kcm, where Theme was a singleton.
now there is no need whatsoever for that anymore.

Thu, Oct 3, 4:31 PM · Plasma
mart accepted D24391: Silence warnings (noops + unused capture variable).
Thu, Oct 3, 4:28 PM · Plasma
mart committed R169:20ea88c1debc: always cache just the last item (authored by mart).
always cache just the last item
Thu, Oct 3, 4:25 PM
mart committed R169:32d724f2b68c: don't generate shortcuts in QQuickWidget (authored by mart).
don't generate shortcuts in QQuickWidget
Thu, Oct 3, 12:05 PM
mart committed R1014:2a7133b0702c: proper import version (authored by mart).
proper import version
Thu, Oct 3, 10:40 AM

Wed, Oct 2

mart committed R169:2d56e6ff8ee0: more z (authored by mart).
more z
Wed, Oct 2, 4:05 PM
mart committed R169:31e7a6e38c06: fix import version in PagePoolAction (authored by mart).
fix import version in PagePoolAction
Wed, Oct 2, 3:38 PM
mart updated the diff for D24265: support global edit mode.
  • don't raise the icons over the toolbox
Wed, Oct 2, 1:48 PM · Plasma
mart updated the diff for D24265: support global edit mode.
  • state machine for right order of opacity and visible
Wed, Oct 2, 1:16 PM · Plasma
mart updated the diff for D24264: edit mode action and dbus.
  • edit mode on mouse over when containment in edit mode
Wed, Oct 2, 1:16 PM · Plasma
mart added a comment to D24264: edit mode action and dbus.

edit mode on mouse over

Wed, Oct 2, 8:12 AM · Plasma
mart updated the diff for D24264: edit mode action and dbus.
  • edit mode on mouse over when containment in edit mode
Wed, Oct 2, 8:11 AM · Plasma

Tue, Oct 1

mart committed R20:959e5ab7978e: try harder to keep panel plasmoid as icons (authored by mart).
try harder to keep panel plasmoid as icons
Tue, Oct 1, 4:21 PM
mart committed R20:65c809326eca: try harder to force panel plasmoids to always icon (authored by mart).
try harder to force panel plasmoids to always icon
Tue, Oct 1, 4:15 PM
mart added a comment to D24264: edit mode action and dbus.
In D24264#540228, @GB_2 wrote:

Just showing the handles when you hover over a widget (or tap on one on touch) is fine IMO.

Yeah that's probably a reasonable compromise.

Tue, Oct 1, 2:35 PM · Plasma
mart accepted D24341: Fix db thread issue in Imagestorage.
Tue, Oct 1, 2:31 PM
mart committed R169:c7ba232f44be: take into account dragging speed when a flick ends (authored by mart).
take into account dragging speed when a flick ends
Tue, Oct 1, 1:48 PM
mart committed R169:b01e0965f7c1: PagePool is Kirigami 2.11 (authored by mart).
PagePool is Kirigami 2.11
Tue, Oct 1, 1:48 PM