mart (Marco Martin)
User

Projects (15)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:09 PM (209 w, 3 d)
Availability
Available

Recent Activity

Yesterday

mart committed R169:aeed0815cff2: single event filter in a singleton (authored by mart).
single event filter in a singleton
Fri, Apr 19, 3:42 PM
mart committed R169:1475373474f0: Revert "make it an attached property" (authored by mart).
Revert "make it an attached property"
Fri, Apr 19, 3:42 PM
mart added a reverting change for R169:b27b61d7ae4f: make it an attached property: R169:1475373474f0: Revert "make it an attached property".
Fri, Apr 19, 3:42 PM
mart committed R169:b27b61d7ae4f: make it an attached property (authored by mart).
make it an attached property
Fri, Apr 19, 3:42 PM
mart committed R169:144c4d3d5e15: final api, documentation++ (authored by mart).
final api, documentation++
Fri, Apr 19, 3:42 PM
mart committed R169:338bff61329d: add blockTargetWheel property (authored by mart).
add blockTargetWheel property
Fri, Apr 19, 8:38 AM

Thu, Apr 18

mart committed R169:e058f9445b2b: add a wheelhandler event filter (authored by mart).
add a wheelhandler event filter
Thu, Apr 18, 4:56 PM
mart committed R169:ac44721f675e: fix implicitWidth (authored by mart).
fix implicitWidth
Thu, Apr 18, 3:31 PM
mart committed R169:a8d954580350: remove all the custom mouse wheel handling (authored by mart).
remove all the custom mouse wheel handling
Thu, Apr 18, 3:11 PM
mart committed R296:d9a0365ccc49: use the base implementation hints (authored by mart).
use the base implementation hints
Thu, Apr 18, 2:51 PM
mart closed D20665: use the base implementation hints.
Thu, Apr 18, 2:51 PM · Frameworks
mart updated the diff for D20665: use the base implementation hints.
  • remove visual debug
Thu, Apr 18, 2:48 PM · Frameworks
mart added a comment to D20665: use the base implementation hints.

Thu, Apr 18, 2:45 PM · Frameworks
mart requested review of D20665: use the base implementation hints.
Thu, Apr 18, 2:44 PM · Frameworks
mart committed R295:21b1cd906807: use size hints from the ApplicationItem itself (authored by mart).
use size hints from the ApplicationItem itself
Thu, Apr 18, 2:42 PM
mart committed R169:d4f4747a5716: remove extra debug (authored by mart).
remove extra debug
Thu, Apr 18, 2:41 PM
mart committed R169:f604477459a2: propagate hints to ColumnView and PageRow (authored by mart).
propagate hints to ColumnView and PageRow
Thu, Apr 18, 2:39 PM
mart committed R169:3b4643b55257: ensure layout is done right after component.oncompleted (authored by mart).
ensure layout is done right after component.oncompleted
Thu, Apr 18, 1:02 PM
mart committed R169:6019ae96a68a: Pages: export correct contentHeight/implicit sizes (authored by mart).
Pages: export correct contentHeight/implicit sizes
Thu, Apr 18, 11:07 AM
mart added a comment to D20283: [RFC] [SimpleKCM] Fix height calculation.

so, now on master Kirigami should have correct contentHeight and implicitHeight/implicitWidth for Page andScrollablePage. this means that this patch *should* be not necessary anymore (only thing that should happen, is ro remove completely implicitWidth/implicitheight calculation from here)

Thu, Apr 18, 10:45 AM · Frameworks

Wed, Apr 17

mart added inline comments to D20283: [RFC] [SimpleKCM] Fix height calculation.
Wed, Apr 17, 5:51 PM · Frameworks

Tue, Apr 16

mart added a comment to D20594: Fix MobileTextSelection namespacing.

sorry, didn't notice it :(

Tue, Apr 16, 9:53 AM · Frameworks
mart committed R242:843122354211: use the mobiletextcursor from proper namespace (authored by mart).
use the mobiletextcursor from proper namespace
Tue, Apr 16, 9:28 AM

Mon, Apr 15

mart accepted D20570: [FrameSvgItem] Respect smooth property.
Mon, Apr 15, 10:42 AM · Frameworks
mart added a comment to D20570: [FrameSvgItem] Respect smooth property.

FrameItemNode needs the same

Mon, Apr 15, 10:38 AM · Frameworks

Fri, Apr 12

mart accepted D20478: Breeze desktoptheme clock: support hand shadow offset hint of Plasma 5.16.
Fri, Apr 12, 9:08 AM · Frameworks
mart accepted D20112: [analog-clock] Allow themes to define hand shadow offset & hand rot center.
Fri, Apr 12, 9:07 AM · Plasma
mart committed R169:aeb3bf425df6: warning-- (authored by mart).
warning--
Fri, Apr 12, 8:38 AM

Wed, Apr 10

mart committed R242:58dd4c5c0f12: separe mobile text selection to avoid recursive imports (authored by mart).
separe mobile text selection to avoid recursive imports
Wed, Apr 10, 11:55 AM
mart closed D20428: separe mobile text selection to avoid recursive imports.
Wed, Apr 10, 11:55 AM · Frameworks
mart requested review of D20428: separe mobile text selection to avoid recursive imports.
Wed, Apr 10, 9:31 AM · Frameworks

Tue, Apr 9

mart committed R242:067ec2eafcbe: use the right namespace (authored by mart).
use the right namespace
Tue, Apr 9, 1:42 PM

Mon, Apr 8

mart committed R242:c72ee78bbbc4: mov the mobile text actions in own import (authored by mart).
mov the mobile text actions in own import
Mon, Apr 8, 11:33 AM
mart requested review of D20375: if no xcursor is found, don't build the kcm at all.
Mon, Apr 8, 10:54 AM · Plasma
mart committed R169:edd1d1e148bc: header has immediately the proper size (authored by mart).
header has immediately the proper size
Mon, Apr 8, 10:36 AM
mart accepted D20204: Fix always full rect blur mask for panels ignoring shape from Plasma themes.
Mon, Apr 8, 10:17 AM · Plasma
mart accepted D20203: desktoppackage: add "panelMask" property for Panel.qml.
Mon, Apr 8, 10:16 AM · Plasma
mart accepted D20202: FrameSvgItem: add "mask" property.
Mon, Apr 8, 10:16 AM · Frameworks

Fri, Apr 5

mart committed R169:04c5d77d602d: fix listItems implicitWidth (authored by mart).
fix listItems implicitWidth
Fri, Apr 5, 3:10 PM

Thu, Apr 4

mart committed R858:3b2494fc0181: the plasma desktop style syupports icon coloring (authored by mart).
the plasma desktop style syupports icon coloring
Thu, Apr 4, 4:48 PM
mart committed R169:f106ed4df750: color icons in updatePaintNode (authored by mart).
color icons in updatePaintNode
Thu, Apr 4, 4:46 PM
mart committed R169:8306d82f0a61: shannon entropy to guess monochrome icon (authored by mart).
shannon entropy to guess monochrome icon
Thu, Apr 4, 4:46 PM
mart closed D19392: shannon entropy to guess monochrome icon.
Thu, Apr 4, 4:46 PM · Kirigami
mart abandoned D19686: don't scale when we are in AA_UseHighDpiPixmaps.
Thu, Apr 4, 3:55 PM · Frameworks
mart committed R169:2e8f86017fc6: warning-- (authored by mart).
warning--
Thu, Apr 4, 12:47 PM

Wed, Apr 3

mart accepted D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.

I think the patch is fine, the extra spacing is probably in the shell package
plasma-desktop/desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

Wed, Apr 3, 5:56 PM · Plasma
mart added a comment to D20205: initialize the kcolorscheme at the first app start.

The analysis makes sense, I don't understand why this is the correct fix.

Colours aren't the only thing lookandfeel syncs to kdeglobals when set.
Is it correct that all of them have a fallback to loading a second config? If they do, why does the lnf kcm copy into kdeglobals instead of just deleting the kdeglobals entries?

Wed, Apr 3, 8:20 AM · Plasma

Tue, Apr 2

mart added a comment to D19077: Redesign the theme preview window.

@mart could you help us out a bit please? I used code with "Kirigami.Theme.viewBackgroundColor.r", which throws out a warning that the value is deprecated. The one suggested for replacement (Theme.View) isn't the same as the deprecated one though. How bad would it be to leave the code with the deprecated value?

Tue, Apr 2, 3:04 PM · Plasma
mart updated the diff for D20205: initialize the kcolorscheme at the first app start.
  • revert mistake
Tue, Apr 2, 3:01 PM · Plasma
mart requested review of D20205: initialize the kcolorscheme at the first app start.
Tue, Apr 2, 2:58 PM · Plasma
mart added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.
In D19822#442125, @hein wrote:

I'd say let's go with Kirigami.Icon for now then, and recolor the icon to the highlight color on hover. @faridb could you take a stab at that? :)

Tue, Apr 2, 9:55 AM · Plasma
mart added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.
In D19822#439167, @hein wrote:

I'm not a fan of the checkbox, I think it's a little gratuitous. If you add a small feature and need to immediately add a checkbox to disable it, it's rather a red flag to me. It means either the feature or the checkbox should probably go. Firefox gets away without the option BTW.

Tue, Apr 2, 8:19 AM · Plasma
mart added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

I still think we should make it configurable. We'd want to be able to avoid situations with parents or a newbies going something like: "I was watching/listening to X and your darn Linux stopped playing sound!".

Tue, Apr 2, 8:17 AM · Plasma
mart added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

Also, it would be nice if you also work on making the volume indicators smaller and always in the corner.

This is what it looks like with a small icon in the corner:

Tue, Apr 2, 8:15 AM · Plasma
mart added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.
In D19822#439297, @hein wrote:

A possible improvement to make here is to make the indicator visually react to hover by recoloring the icon, to teach that it's seperately interactive and will do something different than clicking elsewhere on the task button, so users get habituated not to click it accidentally. This should probably be done anyway (we're usally pretty triggerhappy on the hover feedback).

Tue, Apr 2, 8:15 AM · Plasma

Mon, Apr 1

mart accepted D19977: Prevent context drawer from disappearing.
Mon, Apr 1, 12:44 PM · Kirigami
mart accepted D20113: [Desktop Theme KCM] Adapt clock to new hand rotation center options.
Mon, Apr 1, 10:44 AM · Plasma
mart accepted D20112: [analog-clock] Allow themes to define hand shadow offset & hand rot center.
Mon, Apr 1, 10:44 AM · Plasma
mart accepted D20051: Do not try to set shadows for panels if theme does not provide elements.
Mon, Apr 1, 10:43 AM · Plasma

Thu, Mar 28

mart committed R169:d8ca9cee9c0d: include columnview_p.h in qmake (authored by mart).
include columnview_p.h in qmake
Thu, Mar 28, 5:17 PM
mart requested changes to D20085: Expose a method to show the context menu of an applet from QML.

looking at D20093 made me rething this, the least intrusive one in the end seems really the first version, with explicit check of formfactor being horizontal or vertical

Thu, Mar 28, 2:20 PM · Frameworks
mart accepted D20085: Expose a method to show the context menu of an applet from QML.
Thu, Mar 28, 9:55 AM · Frameworks

Wed, Mar 27

mart added a comment to D20042: Show the plasmoid context menu on long tap.

Don't we want long-press-for-context-menu when using a touchscreen on the desktop?

Wed, Mar 27, 4:27 PM · Frameworks
mart requested changes to D20042: Show the plasmoid context menu on long tap.

for now we could go with this...
can you make it work *only* when the applet's formfactor is horizontal or vertical?
so this codepath wouldn't touch the desktop case at all

Wed, Mar 27, 3:10 PM · Frameworks
mart added a comment to D20042: Show the plasmoid context menu on long tap.

what happens on long tap on the desktop?
this introduces different behavior between long tap on panel and desktop

Wed, Mar 27, 2:27 PM · Frameworks
mart committed R169:595682bbe084: remove actionmenuitembase (authored by mart).
remove actionmenuitembase
Wed, Mar 27, 12:05 PM
mart committed R169:98bb4bf157f2: add columnview to the pro (authored by mart).
add columnview to the pro
Wed, Mar 27, 11:36 AM
mart committed R169:9e35a08bc00a: add columnview to the pri (authored by mart).
add columnview to the pri
Wed, Mar 27, 11:36 AM
mart committed R169:091397fa9dad: don't try to get the version on static builds (authored by mart).
don't try to get the version on static builds
Wed, Mar 27, 11:22 AM

Tue, Mar 26

mart committed R846:f0c6dedd3022: collapse only in panels (authored by mart).
collapse only in panels
Tue, Mar 26, 10:11 AM
mart committed R846:5cfdeb1d2085: add a minimal plasmoid (authored by mart).
add a minimal plasmoid
Tue, Mar 26, 10:11 AM

Mon, Mar 25

mart committed R169:fde9ccd446e1: sync when any model property updates (authored by mart).
sync when any model property updates
Mon, Mar 25, 1:22 PM

Fri, Mar 22

mart accepted D19743: FrameSvgItem: catch margin changes of FrameSvg also outside own methods.
Fri, Mar 22, 10:30 AM · Frameworks

Mar 20 2019

mart committed R169:3acb0b7f452b: use icon.name in back/forward (authored by mart).
use icon.name in back/forward
Mar 20 2019, 9:28 PM
mart committed R169:05e42c8b4088: fix toolbars for layers (authored by mart).
fix toolbars for layers
Mar 20 2019, 5:14 PM
mart committed R108:d2820bf05eff: Don't try to resize desktop or fullscreen windows (authored by mart).
Don't try to resize desktop or fullscreen windows
Mar 20 2019, 4:47 PM
mart closed D19922: Don't try to resize desktop or fullscreen windows.
Mar 20 2019, 4:47 PM · KWin
mart requested review of D19922: Don't try to resize desktop or fullscreen windows.
Mar 20 2019, 4:45 PM · KWin
mart accepted D19919: Fix crash on closing.
Mar 20 2019, 4:25 PM · KWin
mart committed R108:6bc2ddd56a09: virtualkeyboard: resize the focused window to make room for the keyboard (authored by mart).
virtualkeyboard: resize the focused window to make room for the keyboard
Mar 20 2019, 10:05 AM
mart closed D18818: virtualkeyboard: resize the focused window to make room for the keyboard.
Mar 20 2019, 10:05 AM · KWin
mart added a comment to D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.

So,
FormLayout has api to align two or more of them with each other, which is the list property FormLayout.twinFormLayouts

Mar 20 2019, 9:41 AM · Plasma

Mar 19 2019

mart accepted D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0.
Mar 19 2019, 10:22 PM · Frameworks
mart updated the diff for D18818: virtualkeyboard: resize the focused window to make room for the keyboard.
  • add autotest
Mar 19 2019, 9:39 PM · KWin
mart added a comment to D19604: Make it possible to autodetect the tablet mode.

lgtm, maybe add a check more

Mar 19 2019, 3:46 PM · KWin
mart updated the diff for D18818: virtualkeyboard: resize the focused window to make room for the keyboard.
  • take care of subsurfaces focus change
Mar 19 2019, 3:20 PM · KWin
mart updated the diff for D18818: virtualkeyboard: resize the focused window to make room for the keyboard.
  • always try to stay as true as possible to original size
Mar 19 2019, 12:52 PM · KWin
mart accepted D19454: Fix errors in kirigami example files.
Mar 19 2019, 11:35 AM · Kirigami
mart accepted D19502: Add a SearchField and PasswordField component.
Mar 19 2019, 11:33 AM · Kirigami
mart accepted D19851: [kirigami] make it compile without foreach.
Mar 19 2019, 11:31 AM · Kirigami

Mar 18 2019

mart added a comment to D18818: virtualkeyboard: resize the focused window to make room for the keyboard.

maximize didn't work very well.
now it's resizing again, but using a different saved geometry.

Mar 18 2019, 10:39 PM · KWin
mart updated the diff for D18818: virtualkeyboard: resize the focused window to make room for the keyboard.
  • Merge branch 'master' into arcpatch-D18818
  • don't maximize
Mar 18 2019, 10:38 PM · KWin
mart committed R169:fc775081df48: fix handle icons (authored by mart).
fix handle icons
Mar 18 2019, 1:27 PM

Mar 17 2019

mart accepted D19044: [InlineMessage] Do not draw shadows around the message.
In D19044#432853, @mart wrote:

uuh, no, this duplicates more, i meant moving things from the control to the template

But I moved most of things from src/controls/InlineMessage.qml to src/controls/templates/InlineMessage.qml?

Mar 17 2019, 4:47 PM · Kirigami
mart accepted D19834: Fix monochrome icons in tooltips.
Mar 17 2019, 4:45 PM · Plasma
mart added a comment to D19044: [InlineMessage] Do not draw shadows around the message.

uuh, no, this duplicates more, i meant moving things from the control to the template

Mar 17 2019, 4:39 PM · Kirigami
mart accepted D19337: Fixed some undefined properties runtime errors..
Mar 17 2019, 4:37 PM · Kirigami
mart added inline comments to D19454: Fix errors in kirigami example files.
Mar 17 2019, 4:37 PM · Kirigami
mart requested changes to D19502: Add a SearchField and PasswordField component.
Mar 17 2019, 4:35 PM · Kirigami

Mar 16 2019

mart accepted D19801: [KSplashQML] Update stages comment and make code clearer.
Mar 16 2019, 11:21 AM · Plasma