mart (Marco Martin)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:09 PM (267 w, 4 d)
Availability
Available

Recent Activity

Today

mart committed R120:35b592826667: remove dead code (authored by mart).
remove dead code
Mon, Jun 1, 9:29 AM
mart committed R120:51ef7de8f4f1: remove useless debug (authored by mart).
remove useless debug
Mon, Jun 1, 9:29 AM
mart committed R120:09ae8a437c5c: support accessing applet geometry (authored by mart).
support accessing applet geometry
Mon, Jun 1, 9:29 AM
mart committed R111:ff8d055650eb: Fix sensorColors check (authored by broulik).
Fix sensorColors check
Mon, Jun 1, 9:28 AM
mart committed R120:0355286cd896: remove dead code (authored by mart).
remove dead code
Mon, Jun 1, 9:24 AM
mart committed R120:2474a48880d0: remove useless debug (authored by mart).
remove useless debug
Mon, Jun 1, 9:23 AM

Fri, May 29

mart committed R119:ead7660ced78: replace the systemloadviewer plasmoid with new systemmonitor (authored by mart).
replace the systemloadviewer plasmoid with new systemmonitor
Fri, May 29, 3:02 PM
mart committed R119:ec08c5328325: replace the systemloadviewer plasmoid with new systemmonitor (authored by mart).
replace the systemloadviewer plasmoid with new systemmonitor
Fri, May 29, 2:25 PM
mart committed R120:02d38ab08cd8: support accessing applet geometry (authored by mart).
support accessing applet geometry
Fri, May 29, 2:12 PM
mart committed R111:fd453e1695fb: Merge branch 'Plasma/5.19' (authored by mart).
Merge branch 'Plasma/5.19'
Fri, May 29, 2:07 PM
mart committed R111:545b9e6961cb: adapt to controller.sensorColors being a map (authored by mart).
adapt to controller.sensorColors being a map
Fri, May 29, 2:00 PM
mart committed R120:50433d1c08a8: support accessing applet geometry (authored by mart).
support accessing applet geometry
Fri, May 29, 12:26 PM

Wed, May 27

mart committed R114:a50d30b14b20: set AcceptingInputStatus flag only when the text is in the panel (authored by mart).
set AcceptingInputStatus flag only when the text is in the panel
Wed, May 27, 2:23 PM
mart committed R114:72db0a1b0f89: Merge branch 'Plasma/5.19' (authored by mart).
Merge branch 'Plasma/5.19'
Wed, May 27, 2:23 PM
mart committed R124:1a31a1b440d1: Merge branch 'Plasma/5.19' (authored by mart).
Merge branch 'Plasma/5.19'
Wed, May 27, 10:12 AM
mart committed R124:8e6d6e604364: don't try to access invalid modules (authored by mart).
don't try to access invalid modules
Wed, May 27, 10:12 AM
mart added a comment to D29820: Correction when displaying "badger counter" icons using software rendering.

yes please on gitlab.
are you sure you don't get double painting on opengl now?

Wed, May 27, 9:19 AM · Plasma

Mon, May 25

mart committed R169:92e51c172bfc: remove repeated code (authored by mart).
remove repeated code
Mon, May 25, 4:12 PM
mart committed R242:50a699f9e3b4: Merge branch 'mart/headerGroup' (authored by mart).
Merge branch 'mart/headerGroup'
Mon, May 25, 9:17 AM
mart committed R858:e31831873e48: support the Header group (authored by mart).
support the Header group
Mon, May 25, 9:11 AM
mart committed R169:5265f16f4915: Merge branch 'mart/headerGroup' (authored by mart).
Merge branch 'mart/headerGroup'
Mon, May 25, 8:46 AM
mart committed R169:faa4f3756271: introduce the Header group (authored by mart).
introduce the Header group
Mon, May 25, 8:46 AM

Thu, May 21

mart committed R242:5884df4cfcb1: support the Header color grgoup (authored by mart).
support the Header color grgoup
Thu, May 21, 4:49 PM
mart committed R858:12994e64ca69: support the Header group (authored by mart).
support the Header group
Thu, May 21, 4:42 PM
mart committed R169:663b0578647f: introduce the Header group (authored by mart).
introduce the Header group
Thu, May 21, 4:36 PM

Wed, May 20

mart committed R265:e91ccdf0b1ae: Introduce the Header color set (authored by mart).
Introduce the Header color set
Wed, May 20, 2:24 PM
mart closed D29232: Introduce the Header color set.
Wed, May 20, 2:24 PM · Frameworks
mart retitled D29232: Introduce the Header color set from [WIP][RFC]Introduce the Header color set to Introduce the Header color set.
Wed, May 20, 2:19 PM · Frameworks
mart updated the diff for D29232: Introduce the Header color set.
  • update to new colors
Wed, May 20, 2:18 PM · Frameworks
mart committed R111:aa6f81c87ae8: fix parsing (authored by mart).
fix parsing
Wed, May 20, 2:16 PM
mart committed R111:4a55f91af2cf: use the new shortName collapsing feature of legends (authored by mart).
use the new shortName collapsing feature of legends
Wed, May 20, 2:16 PM
mart committed R1049:964de3fe0104: re either nameSource or shortNameSource (authored by mart).
re either nameSource or shortNameSource
Wed, May 20, 2:16 PM
mart committed R1049:46fc864a2523: expose both name and shortName (authored by mart).
expose both name and shortName
Wed, May 20, 2:16 PM
mart committed R1049:7b116c5e9d60: support different long/short labels (authored by mart).
support different long/short labels
Wed, May 20, 8:48 AM

Tue, May 19

mart accepted D29463: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi.
Tue, May 19, 1:43 PM · Frameworks
mart accepted D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi.

looks good

Tue, May 19, 11:01 AM · Kirigami
mart added a comment to D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs.

the length of that button text is quite daunting, i fear imagining how would be in geman :p

Tue, May 19, 10:44 AM · Plasma
mart added a comment to D29796: Fix "Implicitly defined onFoo" deprecation warnings.

this needs dependency upon Qt 5.15, right?

Tue, May 19, 10:43 AM · Plasma
mart accepted D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet.
Tue, May 19, 10:38 AM · Plasma
mart committed R169:3072cd214a61: add shadowedimage (authored by mart).
add shadowedimage
Tue, May 19, 10:18 AM
mart accepted D29716: [applet] Show KCM in System Settings.
Tue, May 19, 8:20 AM · Plasma
mart accepted D29715: [applet] Show KCM in System Settings.
Tue, May 19, 8:20 AM
mart accepted D29714: [applets] Show KCMs in System Settings.
Tue, May 19, 8:20 AM · Plasma
mart accepted D29713: [applets] Show KCMs in System Settings.
Tue, May 19, 8:19 AM · Plasma
mart accepted D29712: [applets] Show KCMs in System Settings or Info Center, as appropriate.
Tue, May 19, 8:19 AM · Plasma
mart accepted D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions.
Tue, May 19, 8:19 AM · Frameworks

Mon, May 18

mart committed R169:32b1a886c819: ensure closestToWhite and closestToBlack (authored by mart).
ensure closestToWhite and closestToBlack
Mon, May 18, 3:50 PM
mart accepted D29785: Always use Window colorset for AbstractApplicationHeader.
Mon, May 18, 1:17 PM · Kirigami
mart accepted D29770: [Free Space Notifer] Use critical notification instead of tray icon and monitor Root, too.
Mon, May 18, 10:04 AM · Plasma
mart added a comment to D28873: Add SwipeNavigator component.

what should happen in this case?

Mon, May 18, 9:46 AM · Kirigami
mart added a comment to D28873: Add SwipeNavigator component.

can you add an example about it in /examples ?

Mon, May 18, 9:44 AM · Kirigami

Fri, May 15

mart added a comment to D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi.
In D29462#668542, @mart wrote:

the different Units.qml depend from the style, QT_QUICK_CONTROLS_STYLE
all of them, including those in plasma-framework should be updated at once

Fri, May 15, 12:59 PM · Kirigami
mart requested changes to D29694: Introduce Avatar component.
Fri, May 15, 12:56 PM · Kirigami
mart added a comment to D29694: Introduce Avatar component.

I would like this class to be splitted in Templates/controls, so different styles could make it look slightly sifferent (or anyways easier for the app developer to make one that looks just slightly different)
the root component should be a Control, with image/icon/initials in contentItem and background collor/border in background
the one in templates would not have a background the one in controls would instantiate the one in templates and give it one.

Fri, May 15, 12:56 PM · Kirigami
mart accepted D29630: Use the new KSysGuard namespace for KSysGuard related targets.
Fri, May 15, 12:31 PM · Plasma
mart added a comment to D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions.

hmm, should probably check before whether systemsettings5 and kinfocenter exist beforehand and fallback to kcmshell if not?

Fri, May 15, 12:20 PM · Frameworks
mart added a comment to D29765: Add a blurless SDDM theme.

I'm not keen on duplicating the entire theme for a single option.

I would also prefer to just have it as an option, but turning off blur requires several workarounds to ensure legibility.

Fri, May 15, 12:08 PM · Plasma
mart added a comment to D28873: Add SwipeNavigator component.

yes, that screenshot is really broken.
to me is important that the tabbar tries to take all the space available before doing any eliding.
Probably whether starting to elide a lot and make the tabs actually scrollable, will depend case by case depending fro mthe app

Fri, May 15, 12:01 PM · Kirigami
mart accepted D29760: Replace MapProxySource with some javascript code.
Fri, May 15, 8:59 AM · Plasma

Thu, May 14

mart added a comment to D28873: Add SwipeNavigator component.

If i make the window narrow enough, that's what happens

Thu, May 14, 2:42 PM · Kirigami
mart committed R169:0ad01e73ff52: fix margins o overlaysheet to be pixel perfect (authored by mart).
fix margins o overlaysheet to be pixel perfect
Thu, May 14, 1:27 PM
mart committed R659:04fa8a15ea09: no top padding (authored by mart).
no top padding
Thu, May 14, 12:31 PM
mart committed R659:0e1d7114e196: fix look of the thumbnails view (authored by mart).
fix look of the thumbnails view
Thu, May 14, 12:18 PM
mart committed R659:398649e97a61: use a custom image-derived palette (authored by mart).
use a custom image-derived palette
Thu, May 14, 11:19 AM
mart committed R169:ae7a8a516a90: make it easier to use cusom colors in pages (authored by mart).
make it easier to use cusom colors in pages
Thu, May 14, 11:08 AM
mart accepted D29700: Add a show label option to the pie chart face.
Thu, May 14, 10:53 AM · Plasma
mart committed R169:83de266962ba: link to QtConcurrent (authored by mart).
link to QtConcurrent
Thu, May 14, 8:41 AM
mart committed R169:3986ad9d0955: Introduce ImageColors (authored by mart).
Introduce ImageColors
Thu, May 14, 8:37 AM
mart closed D29637: Introduce ImageColors.
Thu, May 14, 8:37 AM · Kirigami

Wed, May 13

mart committed R111:e666e384d9d6: use kns kpackage integration (authored by mart).
use kns kpackage integration
Wed, May 13, 6:19 PM
mart committed R120:d474f3108e6f: remove knsrc files from here (authored by mart).
remove knsrc files from here
Wed, May 13, 5:49 PM
mart committed R111:b76457deb37e: move knsrc files here (authored by mart).
move knsrc files here
Wed, May 13, 5:48 PM
mart committed R120:5b9436d7663b: proper package type for faces (authored by mart).
proper package type for faces
Wed, May 13, 5:35 PM
mart committed R1049:0be7ad0d51ab: guard model behind a QPointer (authored by mart).
guard model behind a QPointer
Wed, May 13, 5:34 PM
mart committed R1049:789dbfbc9224: fix infinite recursion (authored by mart).
fix infinite recursion
Wed, May 13, 5:34 PM
mart committed R111:b2a04aa30c79: proper color source (authored by mart).
proper color source
Wed, May 13, 2:34 PM
mart committed R111:ee2ff95bcbab: support translations in faces (authored by mart).
support translations in faces
Wed, May 13, 2:32 PM
mart closed D29706: support translations in faces.
Wed, May 13, 2:32 PM · Plasma
mart updated the diff for D29706: support translations in faces.
  • i18nd
Wed, May 13, 2:18 PM · Plasma
mart updated the diff for D29706: support translations in faces.
  • add own context for the internal qml files
Wed, May 13, 2:13 PM · Plasma
mart added a comment to D29706: support translations in faces.

Who extracts and loads the translations for:

./ConfigAppearance.qml
./ConfigSensors.qml
./FaceDetailsConfig.qml
./UsedSensorsView.qml

in the top level of faces but not in an individual package.

Wed, May 13, 2:03 PM · Plasma
mart requested review of D29706: support translations in faces.
Wed, May 13, 12:29 PM · Plasma

Tue, May 12

mart committed R120:6f6c73394358: sync formfactor from plasmoid to faces (authored by mart).
sync formfactor from plasmoid to faces
Tue, May 12, 5:15 PM
mart committed R111:cd8351b53f93: fix SensorFaceController::compactRepresentation() (authored by mart).
fix SensorFaceController::compactRepresentation()
Tue, May 12, 5:01 PM
mart accepted D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout.
Tue, May 12, 4:47 PM · Plasma
mart updated the diff for D29637: Introduce ImageColors.
  • adress feedbacks
Tue, May 12, 9:37 AM · Kirigami

Mon, May 11

mart accepted D29544: [applets/systemtray] Show base icon when AttentionIcon not set.
Mon, May 11, 4:02 PM · Plasma
mart added a comment to D29535: Add a SpinBox (with draggability) to panel thickness adjustment UI.

Sorry, i don't think it's the right path, for several reasons,

  • The spinbox look is different from the desktop one, better or worse is secondary, but it's actually a sore point of the plasma theme at the moment :/
  • It exposes very directly pixel numbers in the ui, unless it's a graphic application, i hate when it happens in an ui and in our software happens too much (and no, no user should ever be asked to know what a pixel is)
  • it keeps the window still when the panel resizes, looking kinda broken, but worse, making even possible for the panel to cover up the spinbox itself
Mon, May 11, 4:02 PM · Plasma
mart added a comment to D29535: Add a SpinBox (with draggability) to panel thickness adjustment UI.

-1 :(

Mon, May 11, 3:54 PM · Plasma
mart accepted D29625: Add global shortcut.
Mon, May 11, 3:53 PM · Plasma
mart accepted D29579: [kcms/keys] Really ignore unknown action.
Mon, May 11, 3:51 PM · Plasma
mart accepted D29548: Drag and drop assigning windows to activities in the default switcher.

What Nate says, after that go for it

Mon, May 11, 3:51 PM · Plasma
mart accepted D29633: [Battery Monitor] Fix toolTipMainText when plugged in.
Mon, May 11, 3:46 PM · Plasma
mart accepted D29644: Select application after it is added.
Mon, May 11, 3:43 PM · Plasma
mart accepted D29288: Improve PageRouter API.
Mon, May 11, 3:41 PM · Kirigami
mart added a comment to D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi.

the different Units.qml depend from the style, QT_QUICK_CONTROLS_STYLE
all of them, including those in plasma-framework should be updated at once

Mon, May 11, 3:40 PM · Kirigami
mart updated the test plan for D29637: Introduce ImageColors.
Mon, May 11, 3:08 PM · Kirigami
mart requested review of D29637: Introduce ImageColors.
Mon, May 11, 3:06 PM · Kirigami
mart committed R169:63132365bcc9: move lab conversion on own function (authored by mart).
move lab conversion on own function
Mon, May 11, 2:50 PM
mart closed D28922: Port Sensor Face loading from plasmoid.
Mon, May 11, 11:13 AM · Plasma