mart (Marco Martin)
User

Projects (17)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:09 PM (217 w, 4 d)
Availability
Available

Recent Activity

Mon, Jun 10

mart committed R169:a1b1c7dfb497: works correctly (authored by mart).
works correctly
Mon, Jun 10, 9:48 AM
mart accepted D21642: use even more resizing.
Mon, Jun 10, 8:53 AM · Plasma
mart accepted D21648: Ignore power management inhibition in battery critical timeout.
Mon, Jun 10, 8:50 AM · Plasma
mart accepted D21670: Enforce use of the reset timer for clearing the model.
Mon, Jun 10, 8:48 AM · Plasma

Fri, Jun 7

mart committed R119:e2be1ed6c2f9: submit when the text changes (authored by mart).
submit when the text changes
Fri, Jun 7, 3:21 PM
mart committed R119:2c01ee83ee6d: makes time entering a bit more user friendly (authored by mart).
makes time entering a bit more user friendly
Fri, Jun 7, 3:11 PM
mart committed R169:c472391ac96c: ColumnView::itemAt (authored by mart).
ColumnView::itemAt
Fri, Jun 7, 10:28 AM
mart committed R169:a079658e7f53: force breeze-internal if no theme is speacified (authored by mart).
force breeze-internal if no theme is speacified
Fri, Jun 7, 8:06 AM

Thu, Jun 6

mart committed R985:ff7afb7f4a0d: more bare bone structure (authored by mart).
more bare bone structure
Thu, Jun 6, 3:36 PM
mart committed R275:8641e66b18ef: correctly collapse (authored by mart).
correctly collapse
Thu, Jun 6, 2:24 PM
mart committed R236:c2c792f75bed: Revert "correctly collapse" (authored by mart).
Revert "correctly collapse"
Thu, Jun 6, 2:23 PM
mart added a reverting change for R236:fd2c5dea14c5: correctly collapse: R236:c2c792f75bed: Revert "correctly collapse".
Thu, Jun 6, 2:23 PM
mart committed R236:fd2c5dea14c5: correctly collapse (authored by mart).
correctly collapse
Thu, Jun 6, 2:22 PM
mart committed R275:778828c810cf: start work on collapsible tree nodes (authored by mart).
start work on collapsible tree nodes
Thu, Jun 6, 11:30 AM
mart accepted D21593: [showdesktop][minimzeall] Reduce the maximum panel icon size.

should be pushed to 5.16 as well

Thu, Jun 6, 11:07 AM · Plasma

Mon, Jun 3

mart committed R858:62f5df2d3fa2: honor visibility policy (authored by mart).
honor visibility policy
Mon, Jun 3, 4:43 PM
mart added a comment to D20908: RFC: Redesign QML applet configuration windows.

This is the rough patch which gives a rough implementation of this look into qwidget config dialogs

Mon, Jun 3, 1:36 PM · Plasma
mart committed R169:041393a3b48b: Merge branch 'mart/pinnedColumns' (authored by mart).
Merge branch 'mart/pinnedColumns'
Mon, Jun 3, 12:17 PM

Fri, May 31

mart committed R120:b059097a5bc1: queue load() after all deleteLater() in unload() are done (authored by mart).
queue load() after all deleteLater() in unload() are done
Fri, May 31, 4:48 PM
mart closed D21513: queue load() after all deleteLater() in unload() are done.
Fri, May 31, 4:48 PM · Plasma
mart requested review of D21513: queue load() after all deleteLater() in unload() are done.
Fri, May 31, 4:38 PM · Plasma
mart added a comment to D21507: Remove DefaultListItemBackground and MenuItem animation.

it's MenuI

Fri, May 31, 12:43 PM · Plasma
mart accepted D21507: Remove DefaultListItemBackground and MenuItem animation.
Fri, May 31, 12:37 PM · Plasma

Thu, May 30

mart accepted D21435: [ActionTextField] Make QML tooltip consistent.
Thu, May 30, 4:48 PM · Kirigami
mart committed R169:71554e321495: start of uniquePageForUrl feature (authored by mart).
start of uniquePageForUrl feature
Thu, May 30, 4:24 PM
mart added a comment to D14830: Add "Configure Displays" context menu entry on the desktop.

if this would be done, i would prefer for the kcm once ported to qml to be embedded in the desktop settings window

Thu, May 30, 3:09 PM · Plasma

Wed, May 29

mart committed R120:cfc6be168c16: delete the containments with destroy() (authored by mart).
delete the containments with destroy()
Wed, May 29, 12:30 PM

Tue, May 28

mart committed R169:58c270b054f9: base on height for items that should have a top padding (authored by mart).
base on height for items that should have a top padding
Tue, May 28, 4:50 PM
mart committed R1014:84b087939d84: dummy separator shouldn't have a size (authored by mart).
dummy separator shouldn't have a size
Tue, May 28, 4:46 PM
mart committed R119:c8d4823bd42c: first prototype of port to the new C++ layout code (authored by mart).
first prototype of port to the new C++ layout code
Tue, May 28, 4:12 PM

Fri, May 24

mart added a comment to D21378: Make Breeze Light/Dark use more system colors.

the idea is kinda nice and with some schemes it will work just perfect...
however i think it risks a lot of having loss in contrast on certain color schems with your patch try for instance breezedark and the honeycomb system theme, the current task highlight would probably almost disappear

Fri, May 24, 3:04 PM · Frameworks
mart committed R169:d14dbd8a05f3: correct navigation on left pinned page (authored by mart).
correct navigation on left pinned page
Fri, May 24, 2:57 PM
mart accepted D21350: plasmacore: fix qmldir, ToolTip.qml no longer part of module.
Fri, May 24, 12:57 PM · Frameworks
mart accepted D21355: Fix qmldir files.
Fri, May 24, 12:38 PM · Frameworks
mart accepted D21365: [Notifications] Avoid stale screenRect.
Fri, May 24, 12:37 PM · Plasma
l10n daemon script <scripty@kde.org> committed R252:9b044883cbac: ensure to search also in the legacy location (authored by mart).
ensure to search also in the legacy location
Fri, May 24, 10:55 AM
mart committed R252:134d1ebd0e8e: ensure to search also in the legacy location (authored by mart).
ensure to search also in the legacy location
Fri, May 24, 10:55 AM

Thu, May 23

mart committed R169:ccd38ea3b28e: keep track of the space covered by pinned pages (authored by mart).
keep track of the space covered by pinned pages
Thu, May 23, 5:11 PM
mart accepted D21362: Fixes for fonts kcm.
Thu, May 23, 1:50 PM · Plasma
mart accepted D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized..
Thu, May 23, 1:50 PM · Plasma
mart committed R242:cb8bdb8edd7d: signal availableScreenRectChanged for all applets (authored by mart).
signal availableScreenRectChanged for all applets
Thu, May 23, 11:19 AM
mart committed R119:0d433faf4c5f: if no xcursor is found, don't build the kcm at all (authored by mart).
if no xcursor is found, don't build the kcm at all
Thu, May 23, 8:41 AM
mart closed D20375: if no xcursor is found, don't build the kcm at all.
Thu, May 23, 8:41 AM · Plasma
mart accepted D20585: [FormLayout] Use even top and bottom spacing for separator.
Thu, May 23, 8:39 AM · Kirigami

Tue, May 21

mart committed R114:bbd9364c5f4f: can take keyboard focus in panels (authored by mart).
can take keyboard focus in panels
Tue, May 21, 4:48 PM
mart committed R120:ed8bf8785977: use setWmWindowType for less magic strings (authored by mart).
use setWmWindowType for less magic strings
Tue, May 21, 4:22 PM
mart committed R120:60ef118c92e4: make AcceptingInputStatus work (authored by mart).
make AcceptingInputStatus work
Tue, May 21, 4:12 PM
mart closed D21319: make AcceptingInputStatus work.
Tue, May 21, 4:12 PM · Plasma
mart updated the test plan for D21319: make AcceptingInputStatus work.
Tue, May 21, 4:11 PM · Plasma
mart updated the diff for D21319: make AcceptingInputStatus work.
  • use platformheaders
Tue, May 21, 4:11 PM · Plasma
mart requested review of D21319: make AcceptingInputStatus work.
Tue, May 21, 3:43 PM · Plasma
mart updated the task description for T10958: Faster Startup.
Tue, May 21, 1:49 PM · Plasma
mart added a comment to T10958: Faster Startup.
  • kpackage as a qt resource (that Marco started):
Tue, May 21, 1:42 PM · Plasma

Mon, May 20

mart committed R119:fcbe3e0f0f0f: set the proper path in m_package after apply (authored by mart).
set the proper path in m_package after apply
Mon, May 20, 2:01 PM

May 17 2019

mart accepted D21001: Update *.qmltypes to current API of QML modules.
May 17 2019, 4:10 PM · Frameworks

May 16 2019

mart requested changes to D20585: [FormLayout] Use even top and bottom spacing for separator.

I don't like adding a new property to separator for doing duck typing...

May 16 2019, 10:30 AM · Kirigami

May 15 2019

mart added a comment to D21229: Use view background color for sidebar to match other sidebars.

+1

May 15 2019, 4:16 PM · Plasma
mart added a comment to D21226: search for a default wallpaper in lookandfeel.

Has this been considered already? Only noticed recently, but did not want to create a new theme work can for me :)

May 15 2019, 4:15 PM · Plasma
mart updated the diff for D21226: search for a default wallpaper in lookandfeel.
  • use proper path of the package
May 15 2019, 3:12 PM · Plasma
mart added a comment to D21226: search for a default wallpaper in lookandfeel.

Didn't we move contents/layout.js to be part of the lookandfeel and that was the previous way to set a default wallpaper?

May 15 2019, 2:24 PM · Plasma
mart updated the diff for D21225: set the wallpaper when applying look and feel.
  • add property for applyWallpaper
May 15 2019, 2:19 PM · Plasma
mart updated the summary of D21225: set the wallpaper when applying look and feel.
May 15 2019, 2:04 PM · Plasma
mart updated the summary of D21226: search for a default wallpaper in lookandfeel.
May 15 2019, 2:03 PM · Plasma
mart requested review of D21226: search for a default wallpaper in lookandfeel.
May 15 2019, 2:01 PM · Plasma
mart requested review of D21225: set the wallpaper when applying look and feel.
May 15 2019, 2:00 PM · Plasma
mart accepted D21221: [Notes] Port to QQC2 and use GridView KCM components for the color chooser.

I'm not 100% sure about using kcm components outside actual kcms, but i guess to fix that properly it would need those components in a more abstract manner somewhere else like in kirigami and then the kcm import only specializing it.

May 15 2019, 12:46 PM · Plasma

May 14 2019

l10n daemon script <scripty@kde.org> committed R252:2ceb7281d9d2: search in the new location for knsrc files (authored by mart).
search in the new location for knsrc files
May 14 2019, 9:21 PM
mart accepted D20797: [dict] Modernize configuration window.
May 14 2019, 3:50 PM · Plasma
mart accepted D21176: PanelView: update mask on window on change of panelMask property.
May 14 2019, 2:00 PM · Plasma
mart accepted D21175: FrameSvgPrivate::generateBackground: generate background also if reqp != p.
May 14 2019, 1:59 PM · Frameworks
mart accepted D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -.
May 14 2019, 1:57 PM · Frameworks
mart committed R169:17d8acc43cb0: make the recycler a FocusScope (authored by mart).
make the recycler a FocusScope
May 14 2019, 9:42 AM
mart accepted D21188: Improve keyboard-only usage of the toolbar.
May 14 2019, 8:59 AM · Kirigami

May 13 2019

mart closed D21183: search in the new location for knsrc files.
May 13 2019, 12:50 PM · Frameworks
mart committed R252:e0df1f28231c: search in the new location for knsrc files (authored by mart).
search in the new location for knsrc files
May 13 2019, 12:50 PM
mart committed R858:e37ae0c87025: guard minimum and maximum for sliders (authored by mart).
guard minimum and maximum for sliders
May 13 2019, 12:39 PM
mart updated the diff for D21183: search in the new location for knsrc files.

use configSearchLocations

May 13 2019, 11:52 AM · Frameworks
mart requested review of D21183: search in the new location for knsrc files.
May 13 2019, 11:06 AM · Frameworks
mart accepted D21115: [KCModuleQML] Fix typo breaking implicitWidth for modules.
May 13 2019, 10:54 AM · Frameworks
mart committed R242:4498ba9fb980: a kf6 comment (authored by mart).
a kf6 comment
May 13 2019, 9:25 AM
mart added inline comments to D21128: Improve keyboard navigation.
May 13 2019, 9:07 AM · Kirigami

May 10 2019

mart committed R169:3f73d82250b4: show a separator when in left sidebar mode (authored by mart).
show a separator when in left sidebar mode
May 10 2019, 3:25 PM
mart committed R169:ae2d796f839c: first semi working prototype of pinning (authored by mart).
first semi working prototype of pinning
May 10 2019, 3:25 PM
mart committed R169:90efcf43a696: in single column mode, pin has no effect (authored by mart).
in single column mode, pin has no effect
May 10 2019, 3:25 PM
mart accepted D21131: ScrollBar: Make it work as a horizontal scroll bar as well.
May 10 2019, 2:58 PM · Plasma
mart requested changes to D21128: Improve keyboard navigation.
May 10 2019, 2:37 PM · Kirigami

May 9 2019

mart requested changes to D20797: [dict] Modernize configuration window.
May 9 2019, 2:11 PM · Plasma
mart requested changes to D21026: Fix ToolButton remaining in a pressed state after press.
May 9 2019, 2:07 PM · Plasma
mart added a comment to D21026: Fix ToolButton remaining in a pressed state after press.

but now it doesn't display the checked state in any way?

May 9 2019, 2:07 PM · Plasma

May 8 2019

mart accepted D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1.
May 8 2019, 2:05 PM · Plasma
mart accepted D21061: [Task Manager] Use libnotificationmanager for notification badges and application job reporting.
May 8 2019, 1:53 PM · Plasma

May 6 2019

mart added a comment to D20908: RFC: Redesign QML applet configuration windows.

that's a veeery quick and dirty attempt: (so hacky that there is not really usable code i'm afraid)

May 6 2019, 10:32 AM · Plasma
mart added inline comments to D20576: Add new notifications KCM.
May 6 2019, 9:21 AM · Plasma
mart added a comment to D20867: Add Property to disable drawing of menu arrow indicators.

QToolButton::setArrowType?

I just tried that, but it doesn't seem like Breeze honors this property - at least not for the QToolButton produced by KToolBarPopupAction. So adding

May 6 2019, 9:20 AM · Plasma
mart added a comment to D19311: Add navigation history to forward/back buttons.

needs button->setArrowType(Qt::ArrowType::NoArrow);

May 6 2019, 9:19 AM · Dolphin
mart accepted D20898: WIP: [kcms/desktoptheme] Switch knsrc to "Plasma 5 Theme" category.
May 6 2019, 9:15 AM · Plasma
mart accepted D21013: [PanelView] remove outdated hack to support mask without compositing.
May 6 2019, 9:09 AM · Plasma
mart added a comment to D20908: RFC: Redesign QML applet configuration windows.

I was wondering, wouldn't it also make sense to change the layout to be Icon left of text to make it even more consistent with System Settings? Or will that eat too much horizontal space?

May 6 2019, 9:06 AM · Plasma
mart added a comment to D20908: RFC: Redesign QML applet configuration windows.

from the screenshots, i like it a lot,the code seems clean enough.

May 6 2019, 9:04 AM · Plasma

May 3 2019

mart committed R1014:794148b815d8: don't hardcode the style to Material (authored by mart).
don't hardcode the style to Material
May 3 2019, 12:07 PM