mart (Marco Martin)
User

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:09 PM (144 w, 2 d)
Availability
Available

Recent Activity

Yesterday

mart added inline comments to D9965: Provide a tooltip for the main action.
Fri, Jan 19, 1:43 PM · Kirigami
mart added a comment to D9965: Provide a tooltip for the main action.

in general, +1, tough there is something more to do here.
it already shown a notification on press and hold with the text, which should be ported to qqc2 tooltips instead of both things on top of each other.
also, should depend from Settings.isMobile: when false, it should appear on mouse over with the usual delay. when true, it should appear on press and hold, and disappear spontaneously after some delay.
ideally, all 3 buttons should support this.

Fri, Jan 19, 1:41 PM · Kirigami
mart committed R169:b8ed308c1194: restore old minimalqmake (authored by mart).
restore old minimalqmake
Fri, Jan 19, 11:53 AM
mart committed R169:cd623457e1cb: updatethe icons file to the latest used icon names (authored by mart).
updatethe icons file to the latest used icon names
Fri, Jan 19, 11:49 AM
mart committed R169:a995e9c8721e: make the inclusion of .pri work again (authored by mart).
make the inclusion of .pri work again
Fri, Jan 19, 11:32 AM
mart committed R169:8c34dde112e7: cmake: Use the official CMake variable for building as a static plugin. (authored by mart).
cmake: Use the official CMake variable for building as a static plugin.
Fri, Jan 19, 10:21 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Fri, Jan 19, 10:21 AM · Kirigami
Restricted Application edited projects for D9944: [WIP]expose if the tablet mode switch is available, added: KWin; removed Plasma.
Fri, Jan 19, 9:50 AM · Plasma
Restricted Application edited projects for D9944: [WIP]expose if the tablet mode switch is available, added: Plasma; removed KWin.
Fri, Jan 19, 9:49 AM · Plasma

Thu, Jan 18

mart updated the diff for D9892: cmake: Use the official CMake variable for building as a static plugin..

try to diff against the proper stuff

Thu, Jan 18, 2:29 PM · Kirigami
mart added a comment to D9792: even slimmer scrollbars.

landed just in master post 5.12

Thu, Jan 18, 1:13 PM · Kirigami, Plasma
mart committed R31:d4b07d9e1daf: even slimmer scrollbars (authored by mart).
even slimmer scrollbars
Thu, Jan 18, 1:13 PM
mart closed D9792: even slimmer scrollbars.
Thu, Jan 18, 1:13 PM · Kirigami, Plasma
mart added a comment to D9892: cmake: Use the official CMake variable for building as a static plugin..

now the library definition is not duplicated
and both the cmake and qmake example do usa the static plugin

Thu, Jan 18, 1:00 PM · Kirigami
mart updated the diff for D9892: cmake: Use the official CMake variable for building as a static plugin..
  • don't duplicate target_link_libraries
  • properly use the static plugin in the example
  • the pro makes a static library
  • use proper static plugins for the cmake example
  • toplevel qmake with subfolders
  • proper name for executable
Thu, Jan 18, 12:59 PM · Kirigami
mart committed R169:2c70c2168c9e: proper name for executable (authored by mart).
proper name for executable
Thu, Jan 18, 12:58 PM
mart committed R169:bac150bb6605: toplevel qmake with subfolders (authored by mart).
toplevel qmake with subfolders
Thu, Jan 18, 12:31 PM
mart committed R169:d10005e8312e: use proper static plugins for the cmake example (authored by mart).
use proper static plugins for the cmake example
Thu, Jan 18, 12:31 PM
mart committed R169:84a3e64f5db2: the pro makes a static library (authored by mart).
the pro makes a static library
Thu, Jan 18, 12:30 PM
mart committed R169:d7674f3abf7e: properly use the static plugin in the example (authored by mart).
properly use the static plugin in the example
Thu, Jan 18, 11:32 AM
mart committed R169:bfedc7a3748f: don't duplicate target_link_libraries (authored by mart).
don't duplicate target_link_libraries
Thu, Jan 18, 10:59 AM

Wed, Jan 17

mart committed R242:6d60723ed230: delay loading of hidden applets (authored by mart).
delay loading of hidden applets
Wed, Jan 17, 4:59 PM
Restricted Application edited projects for D9944: [WIP]expose if the tablet mode switch is available, added: KWin; removed Plasma.

api-wise on the dbus side, could also be done that the interface being there means the switch is possible, otherwise doesn't get registered/destroyed

Wed, Jan 17, 3:47 PM · Plasma
Restricted Application edited projects for D9944: [WIP]expose if the tablet mode switch is available, added: Plasma; removed KWin.
  1. trying to be a canonical source of what mode a device is in from all information available (which currently happens to be the libinput switch)
Wed, Jan 17, 3:45 PM · Plasma
mart committed R120:036d5e164764: ignore shortcuts for hidden applets (authored by mart).
ignore shortcuts for hidden applets
Wed, Jan 17, 3:43 PM
mart committed R242:78ac3a7fdbb7: set status as hidden when shouldn't be on this input mode (authored by mart).
set status as hidden when shouldn't be on this input mode
Wed, Jan 17, 2:27 PM
Restricted Application edited projects for D9944: [WIP]expose if the tablet mode switch is available, added: Plasma; removed KWin.
Wed, Jan 17, 12:24 PM · Plasma

Tue, Jan 16

mart committed R120:aa024ec40023: prototype usage of tabletMode (authored by mart).
prototype usage of tabletMode
Tue, Jan 16, 4:42 PM
mart added a comment to D9892: cmake: Use the official CMake variable for building as a static plugin..
In D9892#191590, @apol wrote:

I wonder if it would make sense to always ship the qml files as qrc in the plugin. Have you considered it?

Tue, Jan 16, 9:56 AM · Kirigami

Mon, Jan 15

mart added a reviewer for D9892: cmake: Use the official CMake variable for building as a static plugin.: lepagevalleeemmanuel.
Mon, Jan 15, 5:29 PM · Kirigami
mart committed R169:08618b73f487: still use the workaround (authored by mart).
still use the workaround
Mon, Jan 15, 5:22 PM
mart committed R169:ea67759afdb2: make it build and work (authored by mart).
make it build and work
Mon, Jan 15, 4:57 PM
mart committed R169:765636a0d904: don't link to libkirigami2 on static mode (authored by mart).
don't link to libkirigami2 on static mode
Mon, Jan 15, 4:34 PM
mart committed R169:6e8ba84cd03c: Merge branch 'master' into mart/static (authored by mart).
Merge branch 'master' into mart/static
Mon, Jan 15, 3:28 PM
mart added inline comments to D9792: even slimmer scrollbars.
Mon, Jan 15, 10:38 AM · Kirigami, Plasma
mart updated the diff for D9792: even slimmer scrollbars.
  • shorter form
Mon, Jan 15, 10:36 AM · Kirigami, Plasma
mart added inline comments to D9792: even slimmer scrollbars.
Mon, Jan 15, 10:22 AM · Kirigami, Plasma
mart accepted D7681: Update human-readable tier designation in API dox.

ping?

Mon, Jan 15, 10:10 AM · Kirigami
mart added a comment to D8725: [PageRow] Navigate between levels with mouse back/forward buttons.

ping?

Mon, Jan 15, 10:09 AM · Kirigami, Plasma
mart added a comment to D8726: [ScrollView] Scroll one page with Shift+wheel.

ping?

Mon, Jan 15, 10:09 AM · Kirigami, Plasma
mart committed R108:8510f31340ac: don't double delete m_spy (authored by mart).
don't double delete m_spy
Mon, Jan 15, 9:57 AM
mart accepted D9812: [Icon Item] Treat sources starting with a slash as local file.
Mon, Jan 15, 9:16 AM · Frameworks, Plasma

Sun, Jan 14

mart accepted D9803: Apply some C++11 niceties, styling consistency.
Sun, Jan 14, 4:00 PM · Plasma

Fri, Jan 12

mart accepted D9275: fix RTL appearance for ComboBox.
Fri, Jan 12, 3:52 PM · Frameworks, Plasma
mart accepted D9388: Fix queued connection error.
Fri, Jan 12, 3:48 PM · Plasma
mart added inline comments to D9502: [effects/fade] Do some refactoring.
Fri, Jan 12, 3:46 PM · KWin
Restricted Application edited projects for D9638: [effects] replace old slide effect with a new one, added: Plasma; removed KWin.

Just putting it as an idea: maybe we should just drop the "old" slide desktop effect and replace it with this one?

Fri, Jan 12, 3:42 PM · KWin
mart accepted D9649: Use smaller non-italic font for system settings module authentication message.

definitely a visual improvement

Fri, Jan 12, 3:41 PM · Plasma
mart accepted D9782: [DBusMenuImporter] Just send "opened" in updateMenu().
Fri, Jan 12, 3:37 PM · Plasma
mart accepted D9784: [ConfigModule] Re-use QML context and engine if any.
Fri, Jan 12, 3:36 PM · Frameworks, Plasma
mart accepted D9785: [ConfigModel] Set QML context on ConfigModule.
Fri, Jan 12, 3:35 PM · Frameworks, Plasma
mart accepted D9797: [Task Manager] Let mouse back/forward keys switch tracks.

code looks ok.
i don't have such a mouse at the moment, but i love the idea!

Fri, Jan 12, 3:32 PM · Plasma
mart accepted D9799: [Panel View] Check if it's the same applet we're configuring before just hiding current view.
Fri, Jan 12, 3:31 PM · Plasma
mart accepted D9813: [Kicker] Also round to icon size custom square images.
Fri, Jan 12, 3:28 PM · Plasma
mart accepted D9817: Adapt to QQuickWindow hover event synthesis & optimize delegate.
Fri, Jan 12, 3:28 PM · Plasma
mart updated the diff for D9792: even slimmer scrollbars.

fix the math

Fri, Jan 12, 3:21 PM · Kirigami, Plasma
mart accepted D9816: Ensure DesktopIcon paints with the correct aspect ratio.
Fri, Jan 12, 3:15 PM · Kirigami
mart accepted D9304: Get the padding into the header.
Fri, Jan 12, 3:14 PM · Kirigami
mart committed R169:95417dc1f9be: no custom opacity (authored by mart).
no custom opacity
Fri, Jan 12, 3:10 PM
mart committed R242:8daf0c7b63c7: experimental hiding of applet with different supported modes (authored by mart).
experimental hiding of applet with different supported modes
Fri, Jan 12, 2:53 PM
mart committed R242:cb114a82c352: wire up to kirigami tabletmode (authored by mart).
wire up to kirigami tabletmode
Fri, Jan 12, 11:01 AM
mart committed R169:8c978e1da27a: fully working watcher (authored by mart).
fully working watcher
Fri, Jan 12, 10:13 AM

Thu, Jan 11

mart committed R169:87522f7918ee: watch the tabletMode from KWin (authored by mart).
watch the tabletMode from KWin
Thu, Jan 11, 1:46 PM
mart committed R108:1be5256b1b43: A basic TabletModeManager (authored by mart).
A basic TabletModeManager
Thu, Jan 11, 12:11 PM
mart closed D9764: A basic TabletModeManager.
Thu, Jan 11, 12:11 PM · KWin
mart retitled D9764: A basic TabletModeManager from [WIP] a basic TabletModeManager to A basic TabletModeManager.
Thu, Jan 11, 11:52 AM · KWin
mart added a comment to D9792: even slimmer scrollbars.

so, a slightly different approach now, maybe it's a tad cleaner: don't try to draw the handle twice and cross fade it, but draw it smaller and then animate the handle size (and opacity) on mouse over

Thu, Jan 11, 11:52 AM · Kirigami, Plasma
mart updated the diff for D9792: even slimmer scrollbars.
  • const opacity
Thu, Jan 11, 11:51 AM · Kirigami, Plasma
mart updated the diff for D9792: even slimmer scrollbars.
  • use the same slider, animate its size
Thu, Jan 11, 11:49 AM · Kirigami, Plasma
Restricted Application edited projects for D9764: A basic TabletModeManager, added: KWin; removed Plasma.

maybe one could still work around by connecting blindly to that by hand

There's nothing inherently wrong with doing that. Assuming the DBus API is stable is as valid and as easy as assuming the a library is valid and stable.

If you're going to expose it in Kirigami, then I wouldn't bother doing anything else.

Thu, Jan 11, 10:10 AM · KWin
mart added inline comments to D9792: even slimmer scrollbars.
Thu, Jan 11, 10:03 AM · Kirigami, Plasma
mart added inline comments to D9792: even slimmer scrollbars.
Thu, Jan 11, 10:01 AM · Kirigami, Plasma
mart accepted D9804: Add BusyIndicator to the styled controls list.

I'm fine with it, and can go in right now, tough I think I would prefer an official busy indicator dedicated icon from the VDG, if possible

Thu, Jan 11, 9:43 AM · Plasma

Wed, Jan 10

Restricted Application edited projects for D9764: A basic TabletModeManager, added: Plasma; removed KWin.
Wed, Jan 10, 5:11 PM · KWin
mart updated the diff for D9764: A basic TabletModeManager.

adress comments

Wed, Jan 10, 5:10 PM · KWin
Restricted Application edited projects for D9764: A basic TabletModeManager, added: Plasma; removed KWin.
In D9764#188862, @mart wrote:
In D9764#188268, @mart wrote:

one thing i'm wondering, is how to manage dependencies, as ideally we want most of our apps to make use of this, but can't ask for sure to depend from kwin..., which finding the xml would make it an hard dependency (maybe one could still work around by connecting blindly to that by hand)

maybe a new framework which provides the XML and a small client side wrapper? Could probably be tier1.

do you think it should be in a new standalone framework or is there anything already existing which could have it?

maybe KGuiAddons?

Wed, Jan 10, 4:58 PM · KWin
mart committed R242:bb6e6f77397e: first skeleton of tablet mode support (authored by mart).
first skeleton of tablet mode support
Wed, Jan 10, 4:17 PM
Restricted Application edited projects for D9764: A basic TabletModeManager, added: Plasma; removed KWin.
In D9764#188268, @mart wrote:

one thing i'm wondering, is how to manage dependencies, as ideally we want most of our apps to make use of this, but can't ask for sure to depend from kwin..., which finding the xml would make it an hard dependency (maybe one could still work around by connecting blindly to that by hand)

maybe a new framework which provides the XML and a small client side wrapper? Could probably be tier1.

Wed, Jan 10, 4:10 PM · KWin
mart added a comment to D9792: even slimmer scrollbars.

left sidebar: QML, main area: QWidgets

Wed, Jan 10, 2:18 PM · Kirigami, Plasma
mart updated the summary of D9792: even slimmer scrollbars.
Wed, Jan 10, 2:16 PM · Kirigami, Plasma
mart added a reviewer for D9792: even slimmer scrollbars: hpereiradacosta.
Wed, Jan 10, 2:16 PM · Kirigami, Plasma
mart committed R858:8a07eefc5bff: remove flicker when hovering scrollbar (authored by mart).
remove flicker when hovering scrollbar
Wed, Jan 10, 10:54 AM
mart committed R169:a71ed1c5d084: solve conflict of property called action (authored by mart).
solve conflict of property called action
Wed, Jan 10, 10:44 AM

Tue, Jan 9

mart accepted D9768: Cache KColorScheme instances.
Tue, Jan 9, 4:52 PM · Plasma
mart updated the test plan for D9764: A basic TabletModeManager.
Tue, Jan 9, 3:37 PM · KWin
Restricted Application edited projects for D9764: A basic TabletModeManager, added: Plasma; removed KWin.

one thing i'm wondering, is how to manage dependencies, as ideally we want most of our apps to make use of this, but can't ask for sure to depend from kwin..., which finding the xml would make it an hard dependency (maybe one could still work around by connecting blindly to that by hand)

Tue, Jan 9, 2:15 PM · KWin
mart accepted D9640: [Folder View] Explicitly reject Firefox tab drops.
Tue, Jan 9, 2:08 PM · Plasma
mart added reviewers for D9764: A basic TabletModeManager: Plasma, KWin.
Tue, Jan 9, 1:54 PM · KWin
mart updated the diff for D9764: A basic TabletModeManager.

copyright

Tue, Jan 9, 1:54 PM · KWin

Mon, Jan 8

mart accepted D9521: Pass SwitchEvent from LibInput through KWin and add to DebugConsole.
Mon, Jan 8, 4:00 PM · Plasma
mart accepted D9352: [libcolorcorrect] Send auto location updates only when desirable.
Mon, Jan 8, 11:06 AM · Plasma

Fri, Jan 5

mart committed R102:5d022b435fc4: Don't build pci module on ARM (authored by mart).
Don't build pci module on ARM
Fri, Jan 5, 4:21 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Fri, Jan 5, 4:21 PM · Plasma
mart updated the diff for D9682: Don't build pci module on ARM.

also exclude aarch64

Fri, Jan 5, 4:21 PM · Plasma

Tue, Jan 2

mart committed R883:1507527: release plasma 5.11.5.
release plasma 5.11.5
Tue, Jan 2, 7:37 PM
mart committed R883:1507526: release plasma 5.11.5.
release plasma 5.11.5
Tue, Jan 2, 7:37 PM
mart committed R883:1507525: release plasma 5.11.5.
release plasma 5.11.5
Tue, Jan 2, 7:37 PM
mart committed R883:1507519: add plasma 5.11.5 file list.
add plasma 5.11.5 file list
Tue, Jan 2, 6:50 PM
mart committed R883:1507510: start webpages for Plasma 5.11.5.
start webpages for Plasma 5.11.5
Tue, Jan 2, 4:34 PM
mart committed R838:cde59846849d: Update version number for 5.11.5 GIT_SILENT (authored by mart).
Update version number for 5.11.5 GIT_SILENT
Tue, Jan 2, 10:21 AM