mart (Marco Martin)
User

Projects (15)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:09 PM (200 w, 6 d)
Availability
Available

Recent Activity

Today

mart accepted D18928: Fix warnings.
Tue, Feb 19, 5:05 PM · Plasma
mart added a comment to T10495: wallpaper cache.

usability wise, i would much prefer still having a single "photo of the day" wallpaper.
as for caching, this would solve the lockscreen problem only if the plugin is used also as desktop wallpaper, but if it's used only in the lockscreen would still be broken would need an external potd service to be controllable by dbus or something like that)

Tue, Feb 19, 1:35 PM · Plasma
mart added a comment to D19044: [InlineMessage] Do not draw shadows around the message.
In D19044#414479, @mart wrote:

-1
this has to be done at most for the desktop style and the desktop style only

Can you explain a bit more? I don't understand the technical reason for why you think we should do this in the QQC2 style only. If anything, wouldn't it make sense to not have the shadow here and only add it in the QQC2 style if we did want it there (which we don't)?

Tue, Feb 19, 1:20 PM · Kirigami
mart accepted D19135: DelegateRecycler: Fix translation using the wrong domain.
Tue, Feb 19, 1:17 PM · Kirigami
mart committed R169:9bcccb3c8eb1: use only polish, to compless layoutItems (authored by mart).
use only polish, to compless layoutItems
Tue, Feb 19, 1:11 PM
mart created T10493: alter windows geometry to ensure their content is visible when the virtual keyboard opens.
Tue, Feb 19, 1:05 PM · Plasma
mart committed R169:84ccc0fab4b3: sync m_items and childItems (authored by mart).
sync m_items and childItems
Tue, Feb 19, 11:56 AM
mart committed R169:ee52ab8fa26f: first support for reordering by models (authored by mart).
first support for reordering by models
Tue, Feb 19, 11:56 AM

Yesterday

mart requested changes to D18938: Show assigned shortcut in drawer action delegates.
Mon, Feb 18, 1:42 PM · Kirigami
mart accepted D19110: Don't show the tooltip when the drop-down menu is shown.
Mon, Feb 18, 1:36 PM · Kirigami
mart accepted D19043: Fix warning.
Mon, Feb 18, 1:27 PM · Kirigami
mart accepted D19042: Fix warning when using QQuickAction.
Mon, Feb 18, 1:27 PM · Kirigami
mart requested changes to D19044: [InlineMessage] Do not draw shadows around the message.

-1
this has to be done at most for the desktop style and the desktop style only

Mon, Feb 18, 1:25 PM · Kirigami
mart accepted D19040: Remove some unnecessary QString constructions.
Mon, Feb 18, 1:24 PM · Kirigami
mart committed R169:07d001e7b7ed: replace depth with count (authored by mart).
replace depth with count
Mon, Feb 18, 10:33 AM
mart committed R169:7e70acb3dcaa: provide firstVisibleItem and lastVisibleItem (authored by mart).
provide firstVisibleItem and lastVisibleItem
Mon, Feb 18, 10:22 AM

Fri, Feb 15

mart committed R169:d5b662d2b2cd: hide shadows when closed (authored by mart).
hide shadows when closed
Fri, Feb 15, 7:44 PM

Thu, Feb 14

mart accepted D18990: [containment] Modernize tweaks page layout and port to QQC2.
Thu, Feb 14, 6:17 PM · Plasma
mart accepted D18991: [containment] Show an inline message when the Desktop Toolbox is hidden.
Thu, Feb 14, 6:14 PM · Plasma
mart committed R169:7f8fd610709a: add the needed properties for the alternate color (authored by mart).
add the needed properties for the alternate color
Thu, Feb 14, 5:28 PM
mart committed R169:60ea33fcbd41: rename ColumnsView -> ColumnView (authored by mart).
rename ColumnsView -> ColumnView
Thu, Feb 14, 3:41 PM
mart committed R169:fe4d2b03d112: ns->containsItem, warnings-- (authored by mart).
ns->containsItem, warnings--
Thu, Feb 14, 3:21 PM
mart committed R169:5e280a30398f: fix the visibleItems list (authored by mart).
fix the visibleItems list
Thu, Feb 14, 3:21 PM
mart committed R169:70a3ce41f6e0: wire separatorVisible to PageRow (authored by mart).
wire separatorVisible to PageRow
Thu, Feb 14, 2:16 PM
mart committed R169:6ddde7b7845c: finish separators (authored by mart).
finish separators
Thu, Feb 14, 2:08 PM
mart committed R169:06f823943e99: better behavior for separators (authored by mart).
better behavior for separators
Thu, Feb 14, 2:08 PM
mart committed R169:f29d6912032c: correctly bind duration and gridUnit (authored by mart).
correctly bind duration and gridUnit
Thu, Feb 14, 10:54 AM
mart added inline comments to D18716: Add a TextField component.
Thu, Feb 14, 10:41 AM · Kirigami
mart added a comment to D18716: Add a TextField component.

also, the name should possibily not conflict with QQC2 TextField, like ActionTextField or something like that.

Thu, Feb 14, 10:19 AM · Kirigami
mart added a comment to D18645: BasicListItem: use specified tint color when transparency is 0.

I think i'll introduce an heuristic to analyze the image and decide if it's monochrome and drop all this transparent nonsense (would make it a bit inefficient as it wuld need to read pixels colors in software but may be justified).
locally i was trying with Shannon entropy of the distribution of either colors or gray values, which seems to yeld satisfying results

Thu, Feb 14, 9:55 AM · Kirigami
mart added a comment to D18818: virtualkeyboard: resize the focused window to make room for the keyboard.

ping? :)

Thu, Feb 14, 9:50 AM · KWin

Wed, Feb 13

mart committed R169:535fd90e0bec: shannon entropy to detect monochrome (authored by mart).
shannon entropy to detect monochrome
Wed, Feb 13, 5:14 PM

Tue, Feb 12

mart accepted D16658: Respect the display property of buttons.
Tue, Feb 12, 3:50 PM · Plasma
mart committed R169:dc27961ea053: revert most of the icon coloring heuristics change (authored by mart).
revert most of the icon coloring heuristics change
Tue, Feb 12, 11:00 AM
mart added a reverting change for R169:4237521cbe8d: support colored icons in drawer actions: R169:d8450480195b: Revert "support colored icons in drawer actions".
Tue, Feb 12, 11:00 AM
mart committed R169:d8450480195b: Revert "support colored icons in drawer actions" (authored by mart).
Revert "support colored icons in drawer actions"
Tue, Feb 12, 11:00 AM
mart committed R169:6e5d7da0e6d4: properly manage grouped properties (authored by mart).
properly manage grouped properties
Tue, Feb 12, 10:14 AM

Mon, Feb 11

mart committed R169:676d0213a6df: fix push behavior (authored by mart).
fix push behavior
Mon, Feb 11, 6:09 PM
mart committed R169:0b8835376bdc: Merge branch 'master' into mart/columnsView (authored by mart).
Merge branch 'master' into mart/columnsView
Mon, Feb 11, 5:46 PM
mart accepted D18796: [PassiveNotification] Don't start timer until window has focus.
Mon, Feb 11, 3:16 PM · Kirigami
mart accepted D18908: [SwipeListItem] Use a real toolbutton to improve usability.
Mon, Feb 11, 3:15 PM · Kirigami
mart committed R858:9fc67f5a7196: clicking on empty areas behaves like pgup/pgdown (authored by mart).
clicking on empty areas behaves like pgup/pgdown
Mon, Feb 11, 3:00 PM
mart added a comment to D18818: virtualkeyboard: resize the focused window to make room for the keyboard.

I'm not sure whether it's a good idea to resize windows for virtual keyboard. This can easily result in a feedback loop - the window resizes, the element with focus loses focus, keyboard closes, window resizes, element gets focus again and so on.

I would prefer if we could just move the window away. This could be done just by the compositor.

Mon, Feb 11, 1:50 PM · KWin
mart added a comment to D18818: virtualkeyboard: resize the focused window to make room for the keyboard.

Please don't take it negative that I once again request changes here. I once run into this issue myself when I added quick tiling - oh that was a mess, because I didn't track in Client the state changes. Back then Thomas fixed all of it :-) It's just a lesson learned and this geometry handling is really complex.

Mon, Feb 11, 1:39 PM · KWin
mart added a comment to D18818: virtualkeyboard: resize the focused window to make room for the keyboard.

On large enough screens (desktop, tablet) we want real window management or tiling and user might want to have a secondary window open for information. For example typing into text editor a summary of a page opened in browser. Just maximizing the active window wouldn't allow that.

Can you expand on the "like a panel with strut" part?

Mon, Feb 11, 1:34 PM · KWin
mart committed R169:023c6ea87366: support for optional alternating backgrounds (authored by mart).
support for optional alternating backgrounds
Mon, Feb 11, 1:22 PM
mart added a comment to D18571: Add "apply on double-click" feature to most other recent ported KCMs.

also, as the principle of the feature i agree with Pino
I don't recall any non instant apply dialog anywhere which becomes magically instant apply on doubleclick

Mon, Feb 11, 9:54 AM · Plasma
mart requested changes to D18571: Add "apply on double-click" feature to most other recent ported KCMs.

if this is going to be used, it should be in the base component (where you can safely assume that kcm.save will exist) and have it as mandatory for every kcm

Mon, Feb 11, 9:52 AM · Plasma

Sat, Feb 9

mart accepted D18869: Only process onClosing events on Android.
Sat, Feb 9, 12:04 PM · KDE Edu, Marble
mart committed R169:a571aa98992f: Merge branch 'mart/titleDelegate' (authored by mart).
Merge branch 'mart/titleDelegate'
Sat, Feb 9, 11:01 AM
mart committed R169:c69d2e9f5643: only show handles when there are visible actions (authored by mart).
only show handles when there are visible actions
Sat, Feb 9, 10:34 AM
mart committed R169:5747aa5f07b0: Revert "Revert "support colored icons in drawer actions"" (authored by mart).
Revert "Revert "support colored icons in drawer actions""
Sat, Feb 9, 10:21 AM
mart added a reverting change for R169:b3b046ad93d5: Revert "support colored icons in drawer actions": R169:5747aa5f07b0: Revert "Revert "support colored icons in drawer actions"".
Sat, Feb 9, 10:21 AM
mart accepted D18644: GlobalDrawerActionItem: properly reference icon by using group property..
Sat, Feb 9, 10:18 AM · Kirigami
mart added a comment to D18645: BasicListItem: use specified tint color when transparency is 0.

can you try on kirigami master? i did a similar thing the other day with commit 015e1d0ac19e4

Sat, Feb 9, 10:18 AM · Kirigami
mart requested changes to D18716: Add a TextField component.
Sat, Feb 9, 10:09 AM · Kirigami
mart requested changes to D18796: [PassiveNotification] Don't start timer until window has focus.
Sat, Feb 9, 10:04 AM · Kirigami
mart added a comment to D18640: Reset tooltip delegate label height to defaults.

Supposedly fixed in Qt 5.12.1? https://bugreports.qt.io/browse/QTBUG-71684

Sat, Feb 9, 9:56 AM · Plasma
mart added inline comments to D18640: Reset tooltip delegate label height to defaults.
Sat, Feb 9, 9:53 AM · Plasma
mart updated the diff for D18818: virtualkeyboard: resize the focused window to make room for the keyboard.
  • remove useless includes
Sat, Feb 9, 9:48 AM · KWin
mart accepted D18718: Support icon on ComboBox.
Sat, Feb 9, 9:41 AM · Plasma
mart accepted D18721: [Folder View] Assume root of a protocol is always a folder.
Sat, Feb 9, 9:40 AM · Plasma
mart added a comment to D18801: CMakeLists: Fix bfd.h include path on windows.

needs longer commit message

Sat, Feb 9, 9:39 AM · Plasma
mart added a comment to D18802: Fix pragma once problem with process class.

needs better commit message

Sat, Feb 9, 9:38 AM · Plasma
mart accepted D18839: Port Cards Grid, Cards List and Inline Messages extra information to json-based info sheet.
Sat, Feb 9, 9:31 AM · Kirigami, Plasma

Fri, Feb 8

mart committed R169:b3b046ad93d5: Revert "support colored icons in drawer actions" (authored by mart).
Revert "support colored icons in drawer actions"
Fri, Feb 8, 11:30 PM
mart added a reverting change for R169:4237521cbe8d: support colored icons in drawer actions: R169:b3b046ad93d5: Revert "support colored icons in drawer actions".
Fri, Feb 8, 11:30 PM
mart committed R169:4237521cbe8d: support colored icons in drawer actions (authored by mart).
support colored icons in drawer actions
Fri, Feb 8, 7:18 PM
mart committed R169:3781b73f2cac: support colored icons in action buttons (authored by mart).
support colored icons in action buttons
Fri, Feb 8, 7:18 PM
mart committed R858:c67410970ed3: support text positioning api (authored by mart).
support text positioning api
Fri, Feb 8, 4:59 PM
mart committed R20:43d95cd332f7: better popup positioning (authored by mart).
better popup positioning
Fri, Feb 8, 4:29 PM
mart updated the diff for D18818: virtualkeyboard: resize the focused window to make room for the keyboard.
  • clean logic with early returns
Fri, Feb 8, 1:37 PM · KWin
mart updated the diff for D18818: virtualkeyboard: resize the focused window to make room for the keyboard.
  • correctly handle restoring
Fri, Feb 8, 1:26 PM · KWin
mart committed R169:a42a685c035e: correctly initialize item x (authored by mart).
correctly initialize item x
Fri, Feb 8, 10:16 AM

Thu, Feb 7

mart updated the diff for D18818: virtualkeyboard: resize the focused window to make room for the keyboard.
  • correctly restore
Thu, Feb 7, 9:53 PM · KWin
mart accepted D18823: Create a dynamic way to provide component information.
Thu, Feb 7, 8:22 PM · Kirigami, Plasma
mart committed R20:6184b2cae091: always force panel applets to be compact (authored by mart).
always force panel applets to be compact
Thu, Feb 7, 7:19 PM
mart updated the diff for D18818: virtualkeyboard: resize the focused window to make room for the keyboard.
  • move the window at the first keyboard show
Thu, Feb 7, 7:07 PM · KWin
mart committed R169:015e1d0ac19e: api to set icon color (authored by mart).
api to set icon color
Thu, Feb 7, 6:22 PM
mart updated the diff for D18818: virtualkeyboard: resize the focused window to make room for the keyboard.
  • use geometryRestore
Thu, Feb 7, 6:09 PM · KWin
mart abandoned D17544: virtualkeyboard: report the size of the inputwindow.
Thu, Feb 7, 5:45 PM · KWin
mart reclaimed D18818: virtualkeyboard: resize the focused window to make room for the keyboard.
Thu, Feb 7, 5:44 PM · KWin
mart abandoned D18818: virtualkeyboard: resize the focused window to make room for the keyboard.
Thu, Feb 7, 5:44 PM · KWin
mart updated the diff for D18818: virtualkeyboard: resize the focused window to make room for the keyboard.
  • remove wrong line
Thu, Feb 7, 5:44 PM · KWin
mart added a reviewer for D18818: virtualkeyboard: resize the focused window to make room for the keyboard: romangg.
Thu, Feb 7, 5:21 PM · KWin
mart added a comment to D17544: virtualkeyboard: report the size of the inputwindow.

last revision was done by mistake, look at D18818 instead

Thu, Feb 7, 4:56 PM · KWin
mart requested review of D18818: virtualkeyboard: resize the focused window to make room for the keyboard.
Thu, Feb 7, 4:55 PM · KWin
mart updated the diff for D17544: virtualkeyboard: report the size of the inputwindow.
  • resize the focused window t make room for the keyboard
Thu, Feb 7, 4:42 PM · KWin
mart committed R20:8f1ba4b1a42e: Revert "remove the bool guard on screen brightness" (authored by mart).
Revert "remove the bool guard on screen brightness"
Thu, Feb 7, 4:23 PM
mart added a reverting change for R20:d6f0b8b2fc01: remove the bool guard on screen brightness: R20:8f1ba4b1a42e: Revert "remove the bool guard on screen brightness".
Thu, Feb 7, 4:23 PM
mart accepted D18487: Do background contrast fallback at runtime.
Thu, Feb 7, 3:37 PM · Frameworks
mart accepted D18817: Updated documentation (mention of QQuickControls, link to HIG, IRC channel, supported platforms).
Thu, Feb 7, 3:33 PM · Kirigami
mart updated subscribers of D17544: virtualkeyboard: report the size of the inputwindow.

had a discussion about it with @romangg and Dorota from Purism at the plasma mobile sprint and came to the conf=clusion that at first instead we want to resize the toplevel window where the focused surface belongs to a temporary size while the keyboard is open.

Thu, Feb 7, 3:00 PM · KWin
mart committed R169:6b361bfc96b3: scroll indicator done (authored by mart).
scroll indicator done
Thu, Feb 7, 1:15 PM
mart committed R20:d6f0b8b2fc01: remove the bool guard on screen brightness (authored by mart).
remove the bool guard on screen brightness
Thu, Feb 7, 1:07 PM
mart committed R20:86b6265690ac: don't reset brightness at start (authored by mart).
don't reset brightness at start
Thu, Feb 7, 11:58 AM
mart committed R20:f3e1ba0abeca: slightly smaller icons (authored by mart).
slightly smaller icons
Thu, Feb 7, 11:49 AM
mart committed R20:56dc2ad23f5f: better icon sizing (authored by mart).
better icon sizing
Thu, Feb 7, 11:49 AM
mart committed R20:f78f4e73f9d8: remove the blue line for expanded feedback (authored by mart).
remove the blue line for expanded feedback
Thu, Feb 7, 10:17 AM
mart added a comment to D18774: Move lanczos filter away from KWin core.
In D18774#406361, @zzag wrote:
In D18774#406359, @mart wrote:

speaking of lanczos filer, sometimes thumbnails rendered with it seem to be invisible, ca you reproduce that?

Nope, I can't. Are you talking about thumbnails in the desktop grid?

Thu, Feb 7, 9:30 AM · KWin