mart (Marco Martin)
User

Projects (15)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:09 PM (191 w, 6 d)
Availability
Available

Recent Activity

Today

mart committed R169:1a4c17a1bbec: support for the concept of expandible items (authored by mart).
support for the concept of expandible items
Tue, Dec 18, 4:58 PM
mart committed R659:daccbc63c4f5: prepare for collapsible sidebar mode (authored by mart).
prepare for collapsible sidebar mode
Tue, Dec 18, 4:57 PM
mart committed R169:2512e1272150: don't mess with collapsed before startup completion (authored by mart).
don't mess with collapsed before startup completion
Tue, Dec 18, 4:07 PM
mart updated the diff for D17544: virtualkeyboard: report the size of the inputwindow.

adjust window geom by decoration margins

Tue, Dec 18, 2:10 PM · KWin
mart updated the diff for D17544: virtualkeyboard: report the size of the inputwindow.
  • use seat()->focusedTextInputSurface()
Tue, Dec 18, 1:26 PM · KWin

Yesterday

mart committed R169:45ac50e4fdbb: don't show separator in stackviews (authored by mart).
don't show separator in stackviews
Mon, Dec 17, 6:43 PM
mart committed R169:8cdb1804ef59: animate also when there is no flickable (authored by mart).
animate also when there is no flickable
Mon, Dec 17, 6:40 PM
mart committed R169:4530e444e023: fix animate hide of the toolbar (authored by mart).
fix animate hide of the toolbar
Mon, Dec 17, 6:40 PM
mart committed R169:ea99be8cbdb9: no space for handle if drawer not enabled (authored by mart).
no space for handle if drawer not enabled
Mon, Dec 17, 5:58 PM
mart committed R659:f34376378680: better transitions (authored by mart).
better transitions
Mon, Dec 17, 5:44 PM
mart committed R169:bf395ef2e264: fix gridview margins considering scrollbars (authored by mart).
fix gridview margins considering scrollbars
Mon, Dec 17, 5:43 PM
mart committed R659:d60b7ad27ec9: better transitions, autorotate images (authored by mart).
better transitions, autorotate images
Mon, Dec 17, 5:28 PM
mart committed R659:bc1f9194b634: icons size configurable (authored by mart).
icons size configurable
Mon, Dec 17, 4:29 PM
mart committed R659:485f9d649d51: use a sheet for sharing (authored by mart).
use a sheet for sharing
Mon, Dec 17, 4:29 PM
mart committed R659:17f32bec410d: better layout in thumbnails (authored by mart).
better layout in thumbnails
Mon, Dec 17, 4:29 PM
mart committed R659:fac1aa3bb9c4: only one toolbar (authored by mart).
only one toolbar
Mon, Dec 17, 4:29 PM
mart committed R659:a5090eedae47: quiUiKirigami->qmlUi (authored by mart).
quiUiKirigami->qmlUi
Mon, Dec 17, 11:24 AM
mart accepted D17583: Simplify code in MnemonicAttached.
Mon, Dec 17, 9:36 AM · Kirigami
mart accepted D17591: Make AbstractCard.background react to AbstractCard.highlighted.
Mon, Dec 17, 9:35 AM · Kirigami
mart requested changes to D17592: Introduce a DelegateRecycler attached object.

recycler should have a notify signal, because it's going to change all the time.
the delegaterecycler instances are created/destroyed all the time like normal listview delegates, and the delegates instances, those that are actually recycled, will be assigned a new recycler when actually recycled.
since is saved anyways as a context property, perhaps is better to just base off that one and taking care that's always kept up to date to the new recycler.

Mon, Dec 17, 9:35 AM · Kirigami

Fri, Dec 14

mart accepted D17366: Implement "Kill" button when sysguard was invoked from freememorynotifier.
Fri, Dec 14, 4:16 PM · Plasma
mart added a comment to D17355: Align Plasma QML button content in center if it has an icon.

pleaase add the changes to plasmacomponents3 as well

Fri, Dec 14, 4:15 PM · VDG, Plasma, Frameworks
mart added a comment to D17355: Align Plasma QML button content in center if it has an icon.
In D17355#371722, @GB_2 wrote:

Improved code.
How qmlscene tests/components/button.qml looks like:


For some reason "elide" doesn't work...

Fri, Dec 14, 4:14 PM · VDG, Plasma, Frameworks
mart added a comment to D17355: Align Plasma QML button content in center if it has an icon.

in general, buttons with icons may be stacked vertically, which for me makes a general -1

Fri, Dec 14, 4:13 PM · VDG, Plasma, Frameworks
mart added a comment to D17393: [Folder View] make file context menu consistent with Dolphin's.

important is that "open with $default" and "open with..." are grouped together.
apart from that i don't have much preferences for one or the other

Fri, Dec 14, 4:10 PM · Plasma
mart accepted D17433: Add a dbus method getWindowInfo returning same data as queryWindowInfo.
Fri, Dec 14, 4:04 PM · KWin
mart accepted D17574: Remove period ( . ) character from the end.
Fri, Dec 14, 1:47 PM · VDG, Plasma
mart accepted D17556: Make Status and Notification popup consistent with others..
Fri, Dec 14, 1:44 PM · Plasma
mart requested changes to D17556: Make Status and Notification popup consistent with others..
Fri, Dec 14, 1:11 PM · Plasma
mart added inline comments to D17544: virtualkeyboard: report the size of the inputwindow.
Fri, Dec 14, 9:24 AM · KWin

Thu, Dec 13

mart accepted D17562: Don't try to reposition the ScrollView when we get a faulty height.
Thu, Dec 13, 3:12 PM · Kirigami
mart accepted D17551: Take the scrollbar into account for the ScrollablePage margin.
Thu, Dec 13, 3:10 PM · Kirigami
mart accepted D17527: [Chrome Bookmark Runner] Use QJsonObject directly.
Thu, Dec 13, 12:05 PM · Plasma
mart accepted D17536: Make accessibility warning dialog usable again and fix event handling.
Thu, Dec 13, 11:36 AM · Plasma
mart added a comment to D17556: Make Status and Notification popup consistent with others..

for it to be perfect looking, i think it should either be aligned to the left of the icons, or to the left of the text items

Thu, Dec 13, 11:34 AM · Plasma
mart added a comment to D17544: virtualkeyboard: report the size of the inputwindow.

this tries to send just the intersection of the geometries and to track keyboard resize + target window geometry changes

Thu, Dec 13, 11:20 AM · KWin
mart updated the diff for D17544: virtualkeyboard: report the size of the inputwindow.
  • track window and keyboard changes
Thu, Dec 13, 11:17 AM · KWin
mart commandeered D17544: virtualkeyboard: report the size of the inputwindow.
Thu, Dec 13, 11:16 AM · KWin
mart added inline comments to D17467: digital-clock: Show events on initial expansion for all time zones.
Thu, Dec 13, 10:22 AM · Plasma
mart added a comment to D17544: virtualkeyboard: report the size of the inputwindow.

to get the actual geometry of the client would be basing on Workspace::self()->activeClient() ok?
(not other way to get the position i think?)

Thu, Dec 13, 10:14 AM · KWin

Wed, Dec 12

mart accepted D17532: Show tooltip for pinning system tray and calendar.
Wed, Dec 12, 11:24 AM · Plasma

Tue, Dec 11

mart committed R169:6e9ce342f945: fix label vertical aignment (authored by mart).
fix label vertical aignment
Tue, Dec 11, 2:50 PM
mart added inline comments to D17467: digital-clock: Show events on initial expansion for all time zones.
Tue, Dec 11, 2:27 PM · Plasma
mart committed R169:759398ead8b8: map all model properties accessible to the delegate (authored by mart).
map all model properties accessible to the delegate
Tue, Dec 11, 1:57 PM
mart committed R169:0d22f8c3ee8d: follow user specified width/height if defined (authored by mart).
follow user specified width/height if defined
Tue, Dec 11, 1:57 PM

Mon, Dec 10

mart added a comment to D17483: fix virtual keyboard on Plasma Mobile.

Sorry for this, me and @mart did realize that this was pushed too early. If you prefer, we can revert Kirigami part.

ToolButton code path is broken on mobile and makes it not visible at all so that is needed.

Mon, Dec 10, 7:44 PM · KWin
mart committed R108:4001834da8c3: fix virtual keyboard on Plasma Mobile (authored by mart).
fix virtual keyboard on Plasma Mobile
Mon, Dec 10, 3:50 PM
mart closed D17483: fix virtual keyboard on Plasma Mobile.
Mon, Dec 10, 3:50 PM · KWin
mart accepted D17484: Fix menu item width when the delegate is overriden.
Mon, Dec 10, 3:49 PM · Plasma
mart accepted D17268: Fix warning.
Mon, Dec 10, 3:46 PM · Kirigami
mart added a reviewer for D17483: fix virtual keyboard on Plasma Mobile: bshah.
Mon, Dec 10, 3:45 PM · KWin
mart requested review of D17483: fix virtual keyboard on Plasma Mobile.
Mon, Dec 10, 3:45 PM · KWin
mart accepted D17397: Added code example to actionbutton, contextdrawer, globaldrawer, menubar, toolbar.

ship it with that little change on contextualActions

Mon, Dec 10, 9:29 AM · KDE Human Interface Guidelines

Sun, Dec 9

l10n daemon script <scripty@kde.org> committed R244:bf5a80400e9c: make it build (authored by mart).
make it build
Sun, Dec 9, 3:45 PM

Fri, Dec 7

mart updated the diff for D17265: Ensure consistency when the layout is changed via the dbus protocol.
  • Merge branch 'master' into phab/vdconsistency
  • initialize auto created desktops with default name
Fri, Dec 7, 1:52 PM · KWin
mart updated the diff for D17265: Ensure consistency when the layout is changed via the dbus protocol.
  • ensure consistency of rows
Fri, Dec 7, 1:25 PM · KWin

Thu, Dec 6

mart committed R858:c63ea2422593: same behavior as Kirigami ScrollablePage (authored by mart).
same behavior as Kirigami ScrollablePage
Thu, Dec 6, 4:29 PM
mart committed R169:cdd250c0ea18: remove pixelAligned from the internal flickable too (authored by mart).
remove pixelAligned from the internal flickable too
Thu, Dec 6, 3:52 PM
mart accepted D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface.

I've just done a round of testing of the latest revision together my last kwin patch, including:

  • adding and/or removinf desktops
  • changing the number of rows
  • renaming some desktops
  • restarting kwin randomly after any of the above to see settings are kept, without restarting the kcm which keeps showing coherent data
Thu, Dec 6, 3:24 PM · KWin
mart committed R169:47ddac78b62b: manuallylly align to pixel don't rely on pixelAligned (authored by mart).
manuallylly align to pixel don't rely on pixelAligned
Thu, Dec 6, 12:19 PM

Wed, Dec 5

mart updated the diff for D17265: Ensure consistency when the layout is changed via the dbus protocol.
  • fix saving and loading rows number
Wed, Dec 5, 3:40 PM · KWin
mart committed R296:c982847ab310: don't show separators on mobile (authored by mart).
don't show separators on mobile
Wed, Dec 5, 1:08 PM
mart committed R296:8c11b84f96f3: root.contentItem instead of just contentItem (authored by mart).
root.contentItem instead of just contentItem
Wed, Dec 5, 1:08 PM
mart committed R21:012c872dd8bb: make the new multilevel api work (authored by mart).
make the new multilevel api work
Wed, Dec 5, 12:22 PM
mart committed R296:3ee1216ffd31: revert an uninstended line in last patch (authored by mart).
revert an uninstended line in last patch
Wed, Dec 5, 11:34 AM
mart added a comment to D17350: Add the missing api for multilevel KCMs to control the columns.

All is in now :)
(connection name became Network name as requested)

Wed, Dec 5, 10:06 AM · Frameworks
mart committed R116:b3f9240e8310: port to the new multilevel KCM api (authored by mart).
port to the new multilevel KCM api
Wed, Dec 5, 10:05 AM
mart committed R295:313be515b2f8: make use of the new currentIndex api of QML kcms (authored by mart).
make use of the new currentIndex api of QML kcms
Wed, Dec 5, 10:00 AM
mart closed D17351: make use of the new currentIndex api of QML kcms.
Wed, Dec 5, 10:00 AM · Frameworks
mart closed D17350: Add the missing api for multilevel KCMs to control the columns.
Wed, Dec 5, 9:59 AM · Frameworks
mart committed R296:7482529530ca: Add the missing api for multilevel KCMs to control the columns (authored by mart).
Add the missing api for multilevel KCMs to control the columns
Wed, Dec 5, 9:59 AM
mart added a comment to D17350: Add the missing api for multilevel KCMs to control the columns.

@mart , can you push your changes for plasma-nm so I can try this?

Wed, Dec 5, 9:36 AM · Frameworks

Tue, Dec 4

mart updated the summary of D17351: make use of the new currentIndex api of QML kcms.
Tue, Dec 4, 4:16 PM · Frameworks
mart added a reviewer for D17350: Add the missing api for multilevel KCMs to control the columns: jgrulich.
Tue, Dec 4, 4:16 PM · Frameworks
mart added a reviewer for D17351: make use of the new currentIndex api of QML kcms: jgrulich.
Tue, Dec 4, 4:16 PM · Frameworks
mart added a comment to D17350: Add the missing api for multilevel KCMs to control the columns.

Tue, Dec 4, 4:15 PM · Frameworks
mart requested review of D17351: make use of the new currentIndex api of QML kcms.
Tue, Dec 4, 4:13 PM · Frameworks
mart requested review of D17350: Add the missing api for multilevel KCMs to control the columns.
Tue, Dec 4, 4:10 PM · Frameworks
mart committed R169:d82f250c45a1: twinFormLayouts concept (authored by mart).
twinFormLayouts concept
Tue, Dec 4, 3:44 PM
mart committed R169:953f9b4ed2b2: respect all size hints (authored by mart).
respect all size hints
Tue, Dec 4, 10:42 AM

Mon, Dec 3

mart committed R120:39e812d57fd6: Port digital clock settings to QQc2 and Kirigami (authored by mart).
Port digital clock settings to QQc2 and Kirigami
Mon, Dec 3, 4:52 PM
mart closed D17333: Port digital clock settings to QQc2 and Kirigami.
Mon, Dec 3, 4:52 PM · Plasma
mart added a comment to D17333: Port digital clock settings to QQc2 and Kirigami.

Mon, Dec 3, 4:23 PM · Plasma
mart updated the diff for D17333: Port digital clock settings to QQc2 and Kirigami.

restore Information: label

Mon, Dec 3, 4:22 PM · Plasma
mart committed R858:41cd0a4c3915: force checkboxes/radios to be square (authored by mart).
force checkboxes/radios to be square
Mon, Dec 3, 4:12 PM
mart added a comment to D17333: Port digital clock settings to QQc2 and Kirigami.

i can put information again in front of showdate, tough it conveys misleading and wrong info... i really, really hate this abuse of labels as not-really-sections as the label describes the control standing besides it, not any other

Mon, Dec 3, 4:11 PM · Plasma
mart added a comment to D17333: Port digital clock settings to QQc2 and Kirigami.

Here are some examples (in production, from Dolphin's settings window) of how we integrate diverse controls into a form layout and preserve good alignment:

Mon, Dec 3, 4:00 PM · Plasma
mart added a comment to D17333: Port digital clock settings to QQc2 and Kirigami.

that can be done only with hacks that will spontaneously break i'm afraid

Mon, Dec 3, 3:50 PM · Plasma
mart added a comment to D17333: Port digital clock settings to QQc2 and Kirigami.

The new one doesn't follow the HIG and has poor alignment. Combobox labels are supposed to be to the left of the comboboxes. And having a huge list of checkboxes not aligned to the rest of the controls doesn't look great. This is why we typically add a left label to the top checkbox to serve as a pseudo header for all of them. It's the only way to make the alignment work when you have both checkboxes and other controls in a form layout.

Mon, Dec 3, 3:48 PM · Plasma
mart added a comment to D17333: Port digital clock settings to QQc2 and Kirigami.

left old, right new

Mon, Dec 3, 3:41 PM · Plasma
mart requested review of D17333: Port digital clock settings to QQc2 and Kirigami.
Mon, Dec 3, 3:41 PM · Plasma
mart committed R244:e53254a00998: make it build (authored by mart).
make it build
Mon, Dec 3, 10:39 AM
mart accepted D16643: Correct the accept flag of the event object on DragMove .
Mon, Dec 3, 10:02 AM · Frameworks
mart requested changes to D16643: Correct the accept flag of the event object on DragMove .
Mon, Dec 3, 10:01 AM · Frameworks
mart accepted D16643: Correct the accept flag of the event object on DragMove .
Mon, Dec 3, 9:58 AM · Frameworks
mart added a comment to D17192: use a Kirigami Heading for perfect consistency.

It isn't a title, though. At best, the text in question is a list item, not a title.

Mon, Dec 3, 9:04 AM · Plasma
mart committed R120:76eba93be27f: Port to QQC2 and FormLayout (authored by mart).
Port to QQC2 and FormLayout
Mon, Dec 3, 8:59 AM
mart closed D17212: Port to QQC2 and FormLayout.
Mon, Dec 3, 8:59 AM · Plasma
mart added a comment to D11410: [RFC] Add option to make applet fixed width.

any updates on this?

Mon, Dec 3, 8:58 AM · Plasma

Fri, Nov 30

mart requested review of D17265: Ensure consistency when the layout is changed via the dbus protocol.
Fri, Nov 30, 4:48 PM · KWin