mart (Marco Martin)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:09 PM (283 w, 6 d)
Availability
Available

Recent Activity

Tue, Sep 8

mart renamed T12190: Purpose: API Clean up or use contenthub instead from Purpose: API Clean up to Purpose: API Clean up or use contenthub instead.
Tue, Sep 8, 9:35 AM · KF6
mart moved T12116: Plasma Framework: qml imports: kill accessdenied from Backlog to Waiting on KF6 Branching on the KF6 board.
Tue, Sep 8, 9:28 AM · KF6
mart moved T12115: Plasma Framework: qml imports: kill platformcomponents from Backlog to Waiting on KF6 Branching on the KF6 board.
Tue, Sep 8, 9:27 AM · KF6
mart moved T12114: Plasma Framework: port everything to QQC2 from Backlog to In Progress on the KF6 board.
Tue, Sep 8, 9:26 AM · KF6
mart moved T12113: Plasma Framework: qml imports: kill depprecated imports from Backlog to Waiting on KF6 Branching on the KF6 board.
Tue, Sep 8, 9:26 AM · KF6
mart moved T12112: Plasma Framework: qml imports: kill calendar from Backlog to Waiting on KF6 Branching on the KF6 board.
Tue, Sep 8, 9:25 AM · KF6

Jul 31 2020

mart added a comment to T10966: Unify how we refer to KRunner.

the thing that triggered my attention on it is the desktop context menu entry:

FYI, the systemsettings entry also changed, that's far more user facing.

Copying my comment from bugzilla:

"krunner" use is already released in 5.17 onwards.
Whilst I didn't necessarily like the change, another change again now means a new set of user interruptions and relearning which I'm even more against. We shouldn't flip-flop on things that affect the end user.

Jul 31 2020, 5:22 PM · VDG, Plasma

Jul 22 2020

mart added a comment to T10966: Unify how we refer to KRunner.

There are several arguments against it:

  • the thing that triggered my attention on it is the desktop context menu entry: usually context menus should have actions and description of what the action does as text
Jul 22 2020, 10:41 AM · VDG, Plasma
mart created T13422: Move some kcms to plasma-workspace.
Jul 22 2020, 8:24 AM · Plasma: Mobile

Jul 20 2020

mart added a comment to T10966: Unify how we refer to KRunner.

https://bugs.kde.org/show_bug.cgi?id=424455

Jul 20 2020, 10:05 AM · VDG, Plasma
mart reopened T10966: Unify how we refer to KRunner as "Open".

I ask to reconsider this.
KRunner is a terrible jargon name, which is perfectly ok for a framework, but that's it.

Jul 20 2020, 9:59 AM · VDG, Plasma
mart added a comment to D21341: Call KRunner KRunner.

This was a terrible decision.
KRunner is the worst jargon one can imagine and shouldn't be anywhere in user facing UI

Jul 20 2020, 9:54 AM · Plasma

Jun 29 2020

mart added a parent task for T13349: Port weather away from dataengines: T13315: Port away from DataEngines.
Jun 29 2020, 10:44 AM · Plasma 6
mart added a subtask for T13315: Port away from DataEngines: T13349: Port weather away from dataengines.
Jun 29 2020, 10:44 AM · Plasma 6
mart created T13349: Port weather away from dataengines.
Jun 29 2020, 10:44 AM · Plasma 6
mart added a parent task for T13348: Port Comics from dataengine: T13315: Port away from DataEngines.
Jun 29 2020, 10:42 AM · Plasma 6
mart added a subtask for T13315: Port away from DataEngines: T13348: Port Comics from dataengine.
Jun 29 2020, 10:42 AM · Plasma 6
mart created T13348: Port Comics from dataengine.
Jun 29 2020, 10:41 AM · Plasma 6

Jun 13 2020

mart accepted D29390: Respect QIcon::fallbackSearchpaths().

go for it :)

Jun 13 2020, 3:27 PM · Frameworks

Jun 12 2020

mart accepted D29535: Add a SpinBox (with draggability) to panel thickness adjustment UI.

after discussing it a bit thoroughly during the sprint we came to the conclusion is the best solution for now

Jun 12 2020, 2:40 PM · Plasma

Jun 11 2020

mart added a comment to T13256: Come up with a solution for displaying QQC2 elements in Plasma.

feasible technical solutions at the moment are

  • QQmlAbstractUrlInterceptor based solution: kinda error prone but easy to do
  • configuration windows in a separate process: quite complicated and error prone, would take a year to do
  • having config windows with the plasma style
Jun 11 2020, 1:12 PM · Kirigami, Plasma, KF6
mart added a comment to T11558: kill plasma components in favour of qqc2-desktop-style.

the simple fact is that we can't just dump all the custom plasma themes in kde-look.org, there are just too many users likeing, using and creating those.
especially, is a no-go replacing it with a completely inflexible, obsolete and hard to create/share system like QStyle
If that ever is to be done, a theme engine that can load styles which are mostly images and text files (so, sharable on the store) that works on both widgets and qml should be done

Jun 11 2020, 1:05 PM · Plasma, KF6
mart added a comment to T12622: Move wallpaper changing into a KCM and make it easier to apply the wallpaper to the desktop(s), lock screen, and login screen all at once.
Jun 11 2020, 12:53 PM · VDG, Plasma
mart added a comment to T12622: Move wallpaper changing into a KCM and make it easier to apply the wallpaper to the desktop(s), lock screen, and login screen all at once.

please no.
it may sound attractive, but besides the technical diffivulties of writing in the proper place in the plasma config, there is the question of background which monitor of which activity that would require doing a quite complicated spacial ui mapping in systemsettings, where just clicking configure on the actual wallpaper one needs to change requires no mental mapping, it's just there.

Jun 11 2020, 12:52 PM · VDG, Plasma

Jun 10 2020

mart committed R120:790333991ee7: support accessing applet geometry (authored by mart).
support accessing applet geometry
Jun 10 2020, 9:09 AM
mart committed R120:94711eb38d85: remove dead code (authored by mart).
remove dead code
Jun 10 2020, 9:07 AM
mart committed R120:75fd61d83653: support accessing applet geometry (authored by mart).
support accessing applet geometry
Jun 10 2020, 9:07 AM
mart committed R120:fa178e1be60f: remove useless debug (authored by mart).
remove useless debug
Jun 10 2020, 9:07 AM

Jun 9 2020

mart committed R111:1f7dd67aada0: fix setLowPrioritySensorIds (authored by mart).
fix setLowPrioritySensorIds
Jun 9 2020, 4:08 PM
mart committed R111:7f77bbd32a92: save regexps in config (authored by mart).
save regexps in config
Jun 9 2020, 4:08 PM
mart committed R275:c77fc21633ab: setExpandsByDefault to expand the model by default (authored by mart).
setExpandsByDefault to expand the model by default
Jun 9 2020, 3:47 PM
mart added a comment to T12717: Plasma Mobile Design.

The mockups look very nice :)

Jun 9 2020, 10:39 AM · VDG, Plasma: Mobile

Jun 8 2020

mart committed R275:4fe0c83ae88c: add kDescendantHasSiblings role (authored by mart).
add kDescendantHasSiblings role
Jun 8 2020, 2:09 PM
mart added a comment to D27223: add kirigami-gallery icon.

can we fix this and go ahead?
@mbruchert can you still work on it? want to put it on invent?

Jun 8 2020, 11:57 AM · Frameworks
mart added inline comments to D29820: Correction when displaying "badger counter" icons using software rendering.
Jun 8 2020, 9:00 AM · Plasma
mart added a comment to D29845: Added option to change grid thickness.

couldn't also gridThickness automatically scale itself without having to expose it to the user?

Jun 8 2020, 8:44 AM · Plasma
mart added a comment to D29845: Added option to change grid thickness.

please use gitlab on invent.kde.org for new review requests

Jun 8 2020, 8:39 AM · Plasma

Jun 5 2020

mart committed R169:cee1b994e518: prototype for shader based hero anim (authored by mart).
prototype for shader based hero anim
Jun 5 2020, 4:41 PM
mart committed R275:ecbeafc0a656: don't try to map from source collapsed nodes (authored by mart).
don't try to map from source collapsed nodes
Jun 5 2020, 3:50 PM
mart committed R275:ce2db8cbe60b: restore work on old collapsible tree branch (authored by mart).
restore work on old collapsible tree branch
Jun 5 2020, 2:18 PM

Jun 3 2020

mart committed R169:533a8a9a1054: trace implicitWidth (authored by mart).
trace implicitWidth
Jun 3 2020, 2:13 PM
mart committed R169:21381c23d1f6: try to make the drawer resizable (authored by mart).
try to make the drawer resizable
Jun 3 2020, 2:13 PM
mart committed R169:5c64035651ca: register SplitHandle (authored by mart).
register SplitHandle
Jun 3 2020, 2:13 PM
mart committed R111:c23734fd8af0: Merge branch 'Plasma/5.19' (authored by mart).
Merge branch 'Plasma/5.19'
Jun 3 2020, 11:33 AM
mart committed R111:aa4aafe0cd72: properly access savedColors (authored by mart).
properly access savedColors
Jun 3 2020, 11:20 AM
mart committed R111:5f97970bc849: Fix sensorColors check (authored by broulik).
Fix sensorColors check
Jun 3 2020, 10:26 AM
mart committed R119:acb33c947ab9: replace the systemloadviewer plasmoid with new systemmonitor (authored by mart).
replace the systemloadviewer plasmoid with new systemmonitor
Jun 3 2020, 7:49 AM
mart committed R120:3e64f6ea8f68: remove dead code (authored by mart).
remove dead code
Jun 3 2020, 7:49 AM
mart committed R120:0c18fc616892: remove useless debug (authored by mart).
remove useless debug
Jun 3 2020, 7:49 AM
mart committed R120:1f1fe2254780: support accessing applet geometry (authored by mart).
support accessing applet geometry
Jun 3 2020, 7:49 AM

Jun 1 2020

mart added a reverting change for R265:d82db2903eb0: Make Header backwards compatible with titlebar colors: R265:7d7bfb62aedf: Revert "Make Header backwards compatible with titlebar colors".
Jun 1 2020, 1:38 PM
mart committed R265:7d7bfb62aedf: Revert "Make Header backwards compatible with titlebar colors" (authored by mart).
Revert "Make Header backwards compatible with titlebar colors"
Jun 1 2020, 1:38 PM
mart committed R120:35b592826667: remove dead code (authored by mart).
remove dead code
Jun 1 2020, 9:29 AM
mart committed R120:51ef7de8f4f1: remove useless debug (authored by mart).
remove useless debug
Jun 1 2020, 9:29 AM
mart committed R120:09ae8a437c5c: support accessing applet geometry (authored by mart).
support accessing applet geometry
Jun 1 2020, 9:29 AM
mart committed R111:ff8d055650eb: Fix sensorColors check (authored by broulik).
Fix sensorColors check
Jun 1 2020, 9:28 AM
mart committed R120:0355286cd896: remove dead code (authored by mart).
remove dead code
Jun 1 2020, 9:24 AM
mart committed R120:2474a48880d0: remove useless debug (authored by mart).
remove useless debug
Jun 1 2020, 9:23 AM

May 29 2020

mart committed R119:ead7660ced78: replace the systemloadviewer plasmoid with new systemmonitor (authored by mart).
replace the systemloadviewer plasmoid with new systemmonitor
May 29 2020, 3:02 PM
mart committed R119:ec08c5328325: replace the systemloadviewer plasmoid with new systemmonitor (authored by mart).
replace the systemloadviewer plasmoid with new systemmonitor
May 29 2020, 2:25 PM
mart committed R120:02d38ab08cd8: support accessing applet geometry (authored by mart).
support accessing applet geometry
May 29 2020, 2:12 PM
mart committed R111:fd453e1695fb: Merge branch 'Plasma/5.19' (authored by mart).
Merge branch 'Plasma/5.19'
May 29 2020, 2:07 PM
mart committed R111:545b9e6961cb: adapt to controller.sensorColors being a map (authored by mart).
adapt to controller.sensorColors being a map
May 29 2020, 2:00 PM
mart committed R120:50433d1c08a8: support accessing applet geometry (authored by mart).
support accessing applet geometry
May 29 2020, 12:26 PM

May 27 2020

mart committed R114:a50d30b14b20: set AcceptingInputStatus flag only when the text is in the panel (authored by mart).
set AcceptingInputStatus flag only when the text is in the panel
May 27 2020, 2:23 PM
mart committed R114:72db0a1b0f89: Merge branch 'Plasma/5.19' (authored by mart).
Merge branch 'Plasma/5.19'
May 27 2020, 2:23 PM
mart committed R124:1a31a1b440d1: Merge branch 'Plasma/5.19' (authored by mart).
Merge branch 'Plasma/5.19'
May 27 2020, 10:12 AM
mart committed R124:8e6d6e604364: don't try to access invalid modules (authored by mart).
don't try to access invalid modules
May 27 2020, 10:12 AM
mart added a comment to D29820: Correction when displaying "badger counter" icons using software rendering.

yes please on gitlab.
are you sure you don't get double painting on opengl now?

May 27 2020, 9:19 AM · Plasma

May 25 2020

mart committed R169:92e51c172bfc: remove repeated code (authored by mart).
remove repeated code
May 25 2020, 4:12 PM
mart committed R242:50a699f9e3b4: Merge branch 'mart/headerGroup' (authored by mart).
Merge branch 'mart/headerGroup'
May 25 2020, 9:17 AM
mart committed R858:e31831873e48: support the Header group (authored by mart).
support the Header group
May 25 2020, 9:11 AM
mart committed R169:5265f16f4915: Merge branch 'mart/headerGroup' (authored by mart).
Merge branch 'mart/headerGroup'
May 25 2020, 8:46 AM
mart committed R169:faa4f3756271: introduce the Header group (authored by mart).
introduce the Header group
May 25 2020, 8:46 AM

May 21 2020

mart committed R242:5884df4cfcb1: support the Header color grgoup (authored by mart).
support the Header color grgoup
May 21 2020, 4:49 PM
mart committed R858:12994e64ca69: support the Header group (authored by mart).
support the Header group
May 21 2020, 4:42 PM
mart committed R169:663b0578647f: introduce the Header group (authored by mart).
introduce the Header group
May 21 2020, 4:36 PM

May 20 2020

mart committed R265:e91ccdf0b1ae: Introduce the Header color set (authored by mart).
Introduce the Header color set
May 20 2020, 2:24 PM
mart closed D29232: Introduce the Header color set.
May 20 2020, 2:24 PM · Frameworks
mart retitled D29232: Introduce the Header color set from [WIP][RFC]Introduce the Header color set to Introduce the Header color set.
May 20 2020, 2:19 PM · Frameworks
mart updated the diff for D29232: Introduce the Header color set.
  • update to new colors
May 20 2020, 2:18 PM · Frameworks
mart committed R111:aa6f81c87ae8: fix parsing (authored by mart).
fix parsing
May 20 2020, 2:16 PM
mart committed R111:4a55f91af2cf: use the new shortName collapsing feature of legends (authored by mart).
use the new shortName collapsing feature of legends
May 20 2020, 2:16 PM
mart committed R1049:964de3fe0104: re either nameSource or shortNameSource (authored by mart).
re either nameSource or shortNameSource
May 20 2020, 2:16 PM
mart committed R1049:46fc864a2523: expose both name and shortName (authored by mart).
expose both name and shortName
May 20 2020, 2:16 PM
mart committed R1049:7b116c5e9d60: support different long/short labels (authored by mart).
support different long/short labels
May 20 2020, 8:48 AM

May 19 2020

mart accepted D29463: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi.
May 19 2020, 1:43 PM · Frameworks
mart accepted D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi.

looks good

May 19 2020, 11:01 AM · Kirigami
mart added a comment to D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs.

the length of that button text is quite daunting, i fear imagining how would be in geman :p

May 19 2020, 10:44 AM · Plasma
mart added a comment to D29796: Fix "Implicitly defined onFoo" deprecation warnings.

this needs dependency upon Qt 5.15, right?

May 19 2020, 10:43 AM · Plasma
mart accepted D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet.
May 19 2020, 10:38 AM · Plasma
mart committed R169:3072cd214a61: add shadowedimage (authored by mart).
add shadowedimage
May 19 2020, 10:18 AM
mart accepted D29716: [applet] Show KCM in System Settings.
May 19 2020, 8:20 AM · Plasma
mart accepted D29715: [applet] Show KCM in System Settings.
May 19 2020, 8:20 AM
mart accepted D29714: [applets] Show KCMs in System Settings.
May 19 2020, 8:20 AM · Plasma
mart accepted D29713: [applets] Show KCMs in System Settings.
May 19 2020, 8:19 AM · Plasma
mart accepted D29712: [applets] Show KCMs in System Settings or Info Center, as appropriate.
May 19 2020, 8:19 AM · Plasma
mart accepted D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions.
May 19 2020, 8:19 AM · Frameworks

May 18 2020

mart committed R169:32b1a886c819: ensure closestToWhite and closestToBlack (authored by mart).
ensure closestToWhite and closestToBlack
May 18 2020, 3:50 PM
mart accepted D29785: Always use Window colorset for AbstractApplicationHeader.
May 18 2020, 1:17 PM · Kirigami