mart (Marco Martin)
User

Projects (18)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:09 PM (253 w, 3 d)
Availability
Available

Recent Activity

Thu, Feb 20

mart added inline comments to D27189: Created a top area based on widgets/toparea.svg.
Thu, Feb 20, 6:36 PM · Plasma
mart added a comment to D27444: Added top area.

i also wonder if the normal "toolbar2 element already existing can be used..

Thu, Feb 20, 6:33 PM · Frameworks
mart added a comment to D27444: Added top area.

some considerations:

  • this toparea will need to "overflow" its parent for the exact distance needed to perfectly fuse with the background, and has to work with both dialogs and widgets-on-desktop (so we're kinda assuming those 2 backgrounds have the exact same shape) for this reason also fallback should be disabled and be used only in themes that directly provide it.
  • we need 2 margins here: how much we want to overflow, which i would say should be the actual framesvg margins, so one doesn't have to *ever* access the dialog instance or the applet background, and the margins we want to actually use as padding for its contents. we can decide either to put both as hints in the svg, or to use units.smallspacing as padding for the contents and be happy with it
  • i would provide one single svg with top and bottom areas so one can use something like that as a footer as well (and probably a frame that has nothing rounded)
  • if you have a top panel the top won't be rounded, we need a way to know this.. perhaps with plasmoid.location... not sure yet
Thu, Feb 20, 6:31 PM · Frameworks
mart added a comment to T10891: Breeze theme evolution.

Thu, Feb 20, 5:35 PM · Plasma 6, Plasma, VDG, Breeze
mart added a comment to T10891: Breeze theme evolution.

Then again Apple has standardized on buttonlike toolbar buttons for ages and I think it looks fine:

Thu, Feb 20, 5:34 PM · Plasma 6, Plasma, VDG, Breeze
mart added a comment to T12724: Default Wallpapers.

especially Vera, Flow light, Milky way and Kay are gooorgeous

Thu, Feb 20, 3:28 PM · VDG
mart added a comment to T12724: Default Wallpapers.

since there are many good wallpapers there, iff, those will be the ones used in the new releases i retire my reservation of changing it every release.

Thu, Feb 20, 3:27 PM · VDG
mart added a comment to D27481: Panel spacer that can center things.

I think the deisgn og the spacer could be better in edit mode to clearly mark it as a spacer but that can be done in the future if desired.

An idea could be to display something similiar to the icon on the "Add spacer" button on then or an arrow on each side

Thu, Feb 20, 11:13 AM · Plasma
mart added inline comments to D27481: Panel spacer that can center things.
Thu, Feb 20, 10:32 AM · Plasma
mart updated the test plan for D27481: Panel spacer that can center things.
Thu, Feb 20, 10:24 AM · Plasma
mart added a comment to D27481: Panel spacer that can center things.

I think the deisgn og the spacer could be better in edit mode to clearly mark it as a spacer but that can be done in the future if desired.

An idea could be to display something similiar to the icon on the "Add spacer" button on then or an arrow on each side

Thu, Feb 20, 10:22 AM · Plasma

Wed, Feb 19

mart added a comment to D27481: Panel spacer that can center things.

I think the deisgn og the spacer could be better in edit mode to clearly mark it as a spacer but that can be done in the future if desired.

An idea could be to display something similiar to the icon on the "Add spacer" button on then or an arrow on each side

Wed, Feb 19, 3:30 PM · Plasma
mart updated the diff for D27481: Panel spacer that can center things.
  • bigger in edit mode
Wed, Feb 19, 12:56 PM · Plasma
mart retitled D27481: Panel spacer that can center things from [WIP]Panel spacer that can center things to Panel spacer that can center things.
Wed, Feb 19, 12:45 PM · Plasma
mart added a comment to D27481: Panel spacer that can center things.

demo of adding 2 spacers and centering mode

Wed, Feb 19, 12:45 PM · Plasma
mart updated the diff for D27481: Panel spacer that can center things.
  • put the second spacer at the beginning
Wed, Feb 19, 12:43 PM · Plasma
mart added inline comments to D27481: Panel spacer that can center things.
Wed, Feb 19, 11:47 AM · Plasma
mart updated the diff for D27481: Panel spacer that can center things.
  • use a binding
  • use twinlayouts only when both are expanding
Wed, Feb 19, 11:47 AM · Plasma
mart committed R242:ba0b637de94a: fix layout size hints for button labels (authored by mart).
fix layout size hints for button labels
Wed, Feb 19, 11:12 AM
mart closed D27460: fix layout size hints for button labels.
Wed, Feb 19, 11:12 AM · Frameworks
mart added inline comments to D27460: fix layout size hints for button labels.
Wed, Feb 19, 11:07 AM · Frameworks
mart updated the diff for D27460: fix layout size hints for button labels.
  • remove extra check for squareness
Wed, Feb 19, 11:06 AM · Frameworks
mart committed R169:2cea7b4781c9: fix margins in OverlaySheet (authored by mart).
fix margins in OverlaySheet
Wed, Feb 19, 10:58 AM
mart added inline comments to D27460: fix layout size hints for button labels.
Wed, Feb 19, 9:41 AM · Frameworks
mart updated the diff for D27460: fix layout size hints for button labels.
  • fix button display property
  • add a test for tabbar
Wed, Feb 19, 9:41 AM · Frameworks
mart added a comment to D27479: Polish up the KAccounts KCM.

this look


is fine. is already used by other kcms.

Wed, Feb 19, 9:20 AM

Tue, Feb 18

mart added inline comments to D27460: fix layout size hints for button labels.
Tue, Feb 18, 4:07 PM · Frameworks
mart updated the diff for D27460: fix layout size hints for button labels.
  • add an icon
Tue, Feb 18, 4:06 PM · Frameworks
mart added a comment to D27481: Panel spacer that can center things.

Implementation-wise could make sense for the implementation be in the panel itself, tough it may be difficult to control from the external panel configuration tool

Tue, Feb 18, 3:48 PM · Plasma
mart updated the test plan for D27481: Panel spacer that can center things.
Tue, Feb 18, 3:45 PM · Plasma
mart requested review of D27481: Panel spacer that can center things.
Tue, Feb 18, 3:44 PM · Plasma
mart committed R120:ac5be591a30d: take layout spacing into account (authored by mart).
take layout spacing into account
Tue, Feb 18, 3:25 PM
mart added a comment to D27460: fix layout size hints for button labels.

latest version, plasmacontrols 2 and 3 one beside the other

Tue, Feb 18, 3:10 PM · Frameworks
mart updated the diff for D27460: fix layout size hints for button labels.
  • some quirks to make it more similar to pc2
Tue, Feb 18, 3:09 PM · Frameworks

Mon, Feb 17

mart committed R120:74446d50f0b8: debug-- (authored by mart).
debug--
Mon, Feb 17, 4:46 PM
mart committed R120:e59219abfd7e: take hints of every item to compute spacer hints (authored by mart).
take hints of every item to compute spacer hints
Mon, Feb 17, 4:21 PM
mart updated the test plan for D27460: fix layout size hints for button labels.
Mon, Feb 17, 2:52 PM · Frameworks
mart requested review of D27460: fix layout size hints for button labels.
Mon, Feb 17, 2:46 PM · Frameworks
mart accepted D26769: Always strip html if server does not support it.
Mon, Feb 17, 11:19 AM · Frameworks
mart committed R20:11703e204372: remove debug background (authored by mart).
remove debug background
Mon, Feb 17, 9:29 AM

Fri, Feb 14

mart committed R120:89bbc0885e6c: first experiment of a panel spacer refactor (authored by mart).
first experiment of a panel spacer refactor
Fri, Feb 14, 3:56 PM
mart committed R20:d8aac56a4ddf: more reliable dragging in the favorite strip (authored by mart).
more reliable dragging in the favorite strip
Fri, Feb 14, 3:14 PM
mart committed R20:1d359284ecd4: another tiny adjustment (authored by mart).
another tiny adjustment
Fri, Feb 14, 1:04 PM
mart closed D27399: make sure the size hints are integer and even.
Fri, Feb 14, 12:55 PM · Frameworks
mart committed R242:667dce502acf: make sure the size hints are integer and even (authored by mart).
make sure the size hints are integer and even
Fri, Feb 14, 12:55 PM
mart committed R20:130b2d8de0de: less spacing (authored by mart).
less spacing
Fri, Feb 14, 12:40 PM
mart committed R20:e80248b9dafa: warnings-- (authored by mart).
warnings--
Fri, Feb 14, 12:37 PM
mart requested review of D27399: make sure the size hints are integer and even.
Fri, Feb 14, 12:12 PM · Frameworks
mart committed R242:3de1c2462eda: support icon.width/height (authored by mart).
support icon.width/height
Fri, Feb 14, 11:37 AM
mart closed D27396: support icon.width/height.
Fri, Feb 14, 11:37 AM · Frameworks
mart updated the diff for D27396: support icon.width/height.
  • don't expose externally default size
Fri, Feb 14, 11:33 AM · Frameworks
mart updated the diff for D27396: support icon.width/height.
  • default icon sizes
Fri, Feb 14, 11:11 AM · Frameworks
mart added a comment to D27396: support icon.width/height.

Don't we want to set a default? I keep seeing people hardcoding icon.width all over the place when they used PC3 and I want that to stop

Fri, Feb 14, 11:01 AM · Frameworks
mart updated the test plan for D27396: support icon.width/height.
Fri, Feb 14, 11:00 AM · Frameworks
mart requested review of D27396: support icon.width/height.
Fri, Feb 14, 10:57 AM · Frameworks

Wed, Feb 12

mart committed R242:97d431270d19: remove broken references (authored by mart).
remove broken references
Wed, Feb 12, 5:14 PM
mart committed R242:655cc40db886: fix TabButton (authored by mart).
fix TabButton
Wed, Feb 12, 4:10 PM
mart accepted D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles.
Wed, Feb 12, 2:47 PM · Kirigami
mart committed R169:86f988434cd6: properly sync size hints with state machine (authored by mart).
properly sync size hints with state machine
Wed, Feb 12, 11:44 AM
mart committed R1014:c5124274a8a1: add a twin form layout (authored by mart).
add a twin form layout
Wed, Feb 12, 11:22 AM
mart committed R242:1b1dc79dc49c: Revert "Make the attached property a simple QObject" (authored by mart).
Revert "Make the attached property a simple QObject"
Wed, Feb 12, 11:01 AM
mart added a reverting change for R242:68a273aef6c1: Make the attached property a simple QObject: R242:1b1dc79dc49c: Revert "Make the attached property a simple QObject".
Wed, Feb 12, 11:01 AM
mart committed R20:0608967e1069: Add look and feel for logout screen (authored by lnj).
Add look and feel for logout screen
Wed, Feb 12, 9:01 AM
mart committed R20:af8a4b506a84: Add lock screen look-and-feel (authored by jbbgameich).
Add lock screen look-and-feel
Wed, Feb 12, 9:01 AM
mart committed R20:f40bbadd4862: lighter gradient (authored by mart).
lighter gradient
Wed, Feb 12, 8:59 AM
mart committed R20:cf91c250734b: cache shadows (authored by mart).
cache shadows
Wed, Feb 12, 8:59 AM

Tue, Feb 11

mart committed R119:95c061015eb1: unlock widgets (authored by mart).
unlock widgets
Tue, Feb 11, 3:43 PM
mart committed R119:2bc3c5e92d47: unlock widgets (authored by mart).
unlock widgets
Tue, Feb 11, 3:43 PM
mart committed R20:937758721c84: launch feedback from top panel (authored by mart).
launch feedback from top panel
Tue, Feb 11, 3:25 PM
mart committed R20:ea01f911c59b: remove click feedback anim (authored by mart).
remove click feedback anim
Tue, Feb 11, 3:15 PM
mart committed R20:91c92f8fa1f5: remove local feedbackWindow (authored by mart).
remove local feedbackWindow
Tue, Feb 11, 12:58 PM

Mon, Feb 10

l10n daemon script <scripty@kde.org> committed R169:d6b296179743: make headerParent correctly alignedwhen there is a scrollbar (authored by mart).
make headerParent correctly alignedwhen there is a scrollbar
Mon, Feb 10, 10:12 PM
mart committed R242:2b78afd921e0: support display property for Buttons (authored by mart).
support display property for Buttons
Mon, Feb 10, 5:43 PM
mart committed R169:d7336afe7bb8: fix actionbutton size hints (authored by mart).
fix actionbutton size hints
Mon, Feb 10, 5:31 PM
mart committed R242:014c3fd10422: revert unrelated changes in previous commit (authored by mart).
revert unrelated changes in previous commit
Mon, Feb 10, 4:01 PM
mart committed R242:68a273aef6c1: Make the attached property a simple QObject (authored by mart).
Make the attached property a simple QObject
Mon, Feb 10, 3:50 PM
mart closed D27200: Make the attached property a simple QObject.
Mon, Feb 10, 3:50 PM · Frameworks
mart committed R169:f695cde36a68: make headerParent correctly alignedwhen there is a scrollbar (authored by mart).
make headerParent correctly alignedwhen there is a scrollbar
Mon, Feb 10, 10:55 AM
mart requested changes to D27212: Have pullback toolbars on scrollable pages also for footers.

almost there, just two minor nitpicks

Mon, Feb 10, 9:56 AM · Kirigami
mart accepted D27225: Add support for static platformtheme plugins.
Mon, Feb 10, 9:50 AM · Kirigami
mart committed R20:913b9d6db9c6: Merge branch 'lnj/plasma-phone-components-fix/screen-not-fully-captured' (authored by mart).
Merge branch 'lnj/plasma-phone-components-fix/screen-not-fully-captured'
Mon, Feb 10, 9:46 AM
mart accepted D26871: [examples/simplechatapp] Always set isMenu to true.
Mon, Feb 10, 9:41 AM · Kirigami
mart accepted D27251: Relicense to LGPL-2.0-or-later.
Mon, Feb 10, 9:37 AM · Kirigami
mart added a comment to D27251: Relicense to LGPL-2.0-or-later.

I'm fine with it.
should it be 2.0 or later or 2.1 or later? (I'm ok for whatever makes everyone's life easier)

Mon, Feb 10, 9:37 AM · Kirigami
mart committed R20:842e9dd91a74: homescreen: Add gradient to seperator (authored by jbbgameich).
homescreen: Add gradient to seperator
Mon, Feb 10, 9:20 AM

Fri, Feb 7

mart committed R20:25a85543cd69: fix the text field (authored by mart).
fix the text field
Fri, Feb 7, 5:22 PM
mart committed R20:a49260551d69: don't add 2 krunners (authored by mart).
don't add 2 krunners
Fri, Feb 7, 5:12 PM
mart committed R120:1ed28b161552: a canceledit function that stops timers (authored by mart).
a canceledit function that stops timers
Fri, Feb 7, 12:50 PM
mart committed R20:477d6c1c798c: make sure to cancel edit when the user moves (authored by mart).
make sure to cancel edit when the user moves
Fri, Feb 7, 12:49 PM

Thu, Feb 6

mart committed R20:323ae5e50bcf: consider bottom panel (authored by mart).
consider bottom panel
Thu, Feb 6, 8:23 PM
mart added reviewers for D27200: Make the attached property a simple QObject: bshah, Plasma.
Thu, Feb 6, 7:45 PM · Frameworks
mart requested review of D27200: Make the attached property a simple QObject.
Thu, Feb 6, 7:42 PM · Frameworks
mart committed R169:fac6e588c2b6: allow toolbar style on mobile (authored by mart).
allow toolbar style on mobile
Thu, Feb 6, 6:05 PM
mart committed R20:d4e250f25c67: clean (authored by mart).
clean
Thu, Feb 6, 4:00 PM
mart committed R20:2ef0b5e15b51: no background for the icons (authored by mart).
no background for the icons
Thu, Feb 6, 3:58 PM
mart committed R108:baebfb7f7e0b: actually draw drag icons in the mouse cursor during drags (authored by mart).
actually draw drag icons in the mouse cursor during drags
Thu, Feb 6, 2:48 PM
mart closed D27174: actually draw drag icons in the mouse cursor during drags.
Thu, Feb 6, 2:48 PM · KWin
mart committed R20:9278d9960096: a gradient for contrast (authored by mart).
a gradient for contrast
Thu, Feb 6, 2:42 PM
mart updated the diff for D27174: actually draw drag icons in the mouse cursor during drags.
  • properly use the hotspot
Thu, Feb 6, 12:24 PM · KWin

Wed, Feb 5

mart committed R20:5002023fa9f0: kill shutdown button (authored by mart).
kill shutdown button
Wed, Feb 5, 7:44 PM