mart (Marco Martin)
User

Projects (17)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 5:09 PM (227 w, 23 h)
Availability
Available

Recent Activity

Today

mart committed R20:0d78a4e1d746: fix dragging to appletslayout (authored by mart).
fix dragging to appletslayout
Thu, Aug 22, 4:12 PM
mart committed R120:e35cb7f5fbba: don't remove editmode on focuschange (authored by mart).
don't remove editmode on focuschange
Thu, Aug 22, 4:04 PM
mart committed R20:8c1b75a777db: single role for location (authored by mart).
single role for location
Thu, Aug 22, 2:59 PM
mart committed R20:39a4ae578045: position mapping fixes (authored by mart).
position mapping fixes
Thu, Aug 22, 12:02 PM
mart committed R20:ff2fe85d934f: better behavior of favorite strip (authored by mart).
better behavior of favorite strip
Thu, Aug 22, 11:15 AM
mart committed R20:3ce063b5fa6e: make reorder work (authored by mart).
make reorder work
Thu, Aug 22, 9:26 AM

Fri, Aug 16

mart committed R20:9f7ad74775db: TODO (authored by mart).
TODO
Fri, Aug 16, 5:27 PM
mart committed R20:851ff2bd0554: a new central LauncherDragManager.qml (authored by mart).
a new central LauncherDragManager.qml
Fri, Aug 16, 5:27 PM
mart committed R20:1fd5e92794db: generalize LauncherContainer (authored by mart).
generalize LauncherContainer
Fri, Aug 16, 1:51 PM

Thu, Aug 15

mart committed R20:7ff227a13f06: try a different approach to dragging (authored by mart).
try a different approach to dragging
Thu, Aug 15, 11:22 AM
mart accepted D23171: Avoid enabling kcrash if it's only included via a plugin.

the logic is awesome, the checking with the static is not super pretty but saves significantly useless checks

Thu, Aug 15, 9:39 AM · Frameworks

Wed, Aug 14

mart accepted D23154: allow to set custom icon for the left drawer handle.

it's ok, doesn't add public properties

Wed, Aug 14, 4:59 PM · Kirigami
mart added inline comments to D23154: allow to set custom icon for the left drawer handle.
Wed, Aug 14, 3:51 PM · Kirigami
mart accepted D23109: Rework the visibleActions logic in SwipeListItem.
Wed, Aug 14, 2:39 PM · Kirigami
mart accepted D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action.
Wed, Aug 14, 2:36 PM · Kirigami
mart added inline comments to D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action.
Wed, Aug 14, 2:31 PM · Kirigami
mart accepted D23081: remove references from the icon qrc to missing icons..
Wed, Aug 14, 12:51 PM · Kirigami

Tue, Aug 13

mart committed R169:9f48819f60bc: bump import (authored by mart).
bump import
Tue, Aug 13, 4:03 PM
mart committed R118:cf3df117b990: notify availableScreenRectChanged and availableScreenRegionChanged (authored by mart).
notify availableScreenRectChanged and availableScreenRegionChanged
Tue, Aug 13, 1:22 PM
mart committed R120:fe6ab64089d7: make sure all space is assigned when screen res changes (authored by mart).
make sure all space is assigned when screen res changes
Tue, Aug 13, 1:03 PM
mart committed R118:3e9eb02d487d: ssign a valid screen to the containment (authored by mart).
ssign a valid screen to the containment
Tue, Aug 13, 11:14 AM
mart added inline comments to D23049: Add Kirigami ListSectionHeader component.
Tue, Aug 13, 9:28 AM · Kirigami

Mon, Aug 12

mart requested changes to D23049: Add Kirigami ListSectionHeader component.
Mon, Aug 12, 5:38 PM · Kirigami

Sat, Aug 10

mart requested changes to D22896: Port System Settings sidebar to QQC2.
Sat, Aug 10, 8:21 PM · Plasma
mart accepted D22896: Port System Settings sidebar to QQC2.

Cool, tough I'm a bit hesitant on using qt.labs.platform as it may break any moment in any future release

Sat, Aug 10, 8:11 PM · Plasma
mart accepted D22896: Port System Settings sidebar to QQC2.
Sat, Aug 10, 8:04 PM · Plasma

Fri, Aug 9

mart accepted D22879: Rename "Look and Feel" KCM to "Global Theme".

fine for me if this and the store are changed simultaneously, and *no* internal name is changed anywhere (folder names, plugin names and so on)

Fri, Aug 9, 2:04 PM · Plasma
mart committed R20:f1dd73e6715f: add missing file (authored by mart).
add missing file
Fri, Aug 9, 11:40 AM

Thu, Aug 8

mart abandoned D23023: more control on what shell is loaded.
Thu, Aug 8, 4:29 PM · Plasma
mart committed R120:c3f1fb471e23: use plasmashellrc (authored by mart).
use plasmashellrc
Thu, Aug 8, 4:28 PM
mart committed R120:69451047c0a3: more control on what shell is loaded (authored by mart).
more control on what shell is loaded
Thu, Aug 8, 4:26 PM
mart closed D23031: more control on what shell is loaded.
Thu, Aug 8, 4:26 PM · Plasma
mart added a comment to D23031: more control on what shell is loaded.

alternative to https://phabricator.kde.org/D23023
not sure what's better

Thu, Aug 8, 1:51 PM · Plasma
mart added a comment to D23023: more control on what shell is loaded.

https://phabricator.kde.org/D23031 has a config file approach

Thu, Aug 8, 1:50 PM · Plasma
mart requested review of D23031: more control on what shell is loaded.
Thu, Aug 8, 1:50 PM · Plasma
mart updated the diff for D23023: more control on what shell is loaded.
  • name it KDE_PLASMA_DEFAULT_SHELLPACKAGE
Thu, Aug 8, 1:12 PM · Plasma
mart added a comment to D23023: more control on what shell is loaded.

While i wouldn't mind for that feature to get back, using a temporary file wouldn't work, because as soon you have a crash and auto restart you get again on the default desktop shell.

Thu, Aug 8, 1:10 PM · Plasma
mart updated the diff for D23023: more control on what shell is loaded.
  • KDE_PLASMA_SHELLPACKAGE
Thu, Aug 8, 9:44 AM · Plasma
mart added a reviewer for D23023: more control on what shell is loaded: Plasma.
Thu, Aug 8, 9:12 AM · Plasma
mart updated the test plan for D23023: more control on what shell is loaded.
Thu, Aug 8, 9:12 AM · Plasma
mart requested review of D23023: more control on what shell is loaded.
Thu, Aug 8, 9:11 AM · Plasma

Wed, Aug 7

mart requested changes to D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action.

good direction, unfortunately we can't remove the custom toolbutton contentitem yet, so for now let's keep the custom icon group

Wed, Aug 7, 1:50 PM · Kirigami

Tue, Aug 6

mart accepted D22952: Kirigami.Icon: Fix loading bigger images when source is a URL.
Tue, Aug 6, 1:27 PM · Kirigami
mart accepted D22888: Prefer categories with the query string visible in results.
Tue, Aug 6, 1:27 PM · Plasma
mart accepted D22964: [ColorButton] Forward accepted signal from ColorDialog.
Tue, Aug 6, 11:54 AM · Frameworks
mart accepted D22960: Add handle icons.
Tue, Aug 6, 9:14 AM · Kirigami
mart committed R120:9fa4d9417ca0: introduce the Defaults group for panel values (authored by mart).
introduce the Defaults group for panel values
Tue, Aug 6, 8:46 AM
mart closed D22893: introduce the Defaults group for panel values.
Tue, Aug 6, 8:46 AM · Plasma
mart added inline comments to D22893: introduce the Defaults group for panel values.
Tue, Aug 6, 7:41 AM · Plasma
mart requested changes to D22958: Add initial Android support to ecm_add_app_icon.
Tue, Aug 6, 7:34 AM · Build System, Frameworks

Mon, Aug 5

mart accepted D22948: Fix crash when dropping ShellManager.
Mon, Aug 5, 3:59 PM · Plasma
mart committed R487:2a60967d9f99: Merge branch 'Plasma/5.2' (authored by mart).
Merge branch 'Plasma/5.2'
Mon, Aug 5, 12:12 PM
mart added a comment to T10597: Branding for Minishell.

for me the only two no no are plasma active and plasma spark (for the same historical reasons)

Mon, Aug 5, 8:04 AM · KDE Promo, VDG

Fri, Aug 2

mart committed R119:4bc0d943b09c: remove dead code (authored by mart).
remove dead code
Fri, Aug 2, 4:17 PM
mart committed R169:94a54c9c7d3a: reintroduce 00415d3345a with proper names (authored by mart).
reintroduce 00415d3345a with proper names
Fri, Aug 2, 2:54 PM
mart requested review of D22893: introduce the Defaults group for panel values.
Fri, Aug 2, 2:10 PM · Plasma

Thu, Aug 1

mart committed R20:3274995cbe14: e new dragActive proeprty (authored by mart).
e new dragActive proeprty
Thu, Aug 1, 6:30 PM
mart accepted D22827: Scrollview - Don't fill the parent with the view.
Thu, Aug 1, 5:18 PM · Frameworks
mart committed R120:686ebc2c12a0: pay attention to signal order (authored by mart).
pay attention to signal order
Thu, Aug 1, 4:34 PM
mart committed R120:d95345d3e9f3: add new property "dragactive" (authored by mart).
add new property "dragactive"
Thu, Aug 1, 4:20 PM
mart committed R296:e634bda6331c: introduce FallbackTapHandler (authored by mart).
introduce FallbackTapHandler
Thu, Aug 1, 11:08 AM
mart closed D22860: introduce FallbackTapHandler.
Thu, Aug 1, 11:08 AM · Frameworks
mart updated the diff for D22860: introduce FallbackTapHandler.
  • get completely rid of acceptedMouse§Buttons
Thu, Aug 1, 10:35 AM · Frameworks
mart updated the diff for D22860: introduce FallbackTapHandler.
  • adress comments
Thu, Aug 1, 10:22 AM · Frameworks
mart accepted D22867: Consistently use Units.toolTipDelay instead of hardcoded values.

thanks!

Thu, Aug 1, 7:17 AM · Kirigami

Wed, Jul 31

mart requested review of D22860: introduce FallbackTapHandler.
Wed, Jul 31, 4:25 PM · Frameworks
mart committed R120:c788afb67340: crash-- (authored by mart).
crash--
Wed, Jul 31, 3:19 PM
mart committed R169:6a6e72c09049: properly size the card contents when the card size is constrained (authored by mart).
properly size the card contents when the card size is constrained
Wed, Jul 31, 12:21 PM
mart committed R169:6fbe1d9c11b1: hide ripple when we don't want items clickable (authored by mart).
hide ripple when we don't want items clickable
Wed, Jul 31, 9:29 AM

Tue, Jul 30

mart committed R120:fead2de6e2b2: take current thickness if perresolution not provided (authored by mart).
take current thickness if perresolution not provided
Tue, Jul 30, 2:06 PM
mart committed R20:71948fd9f3ad: first prototype of icons in desktop (authored by mart).
first prototype of icons in desktop
Tue, Jul 30, 12:14 PM
mart committed R20:2f0bc852baef: kinda working again (authored by mart).
kinda working again
Tue, Jul 30, 10:21 AM

Mon, Jul 29

mart committed R20:6c8ae2501a3c: api for favorites and desktop (authored by mart).
api for favorites and desktop
Mon, Jul 29, 5:05 PM
mart committed R20:85035dda60bc: launcher from the mycroft tablet containment (authored by mart).
launcher from the mycroft tablet containment
Mon, Jul 29, 4:51 PM
mart committed R120:fb7797dfd288: better positioning logic (authored by mart).
better positioning logic
Mon, Jul 29, 4:41 PM
mart committed R20:8f8a23c6eabc: prototype for a new homescreen containment (authored by mart).
prototype for a new homescreen containment
Mon, Jul 29, 12:51 PM
mart committed R119:72e656a9cb36: fix some qml warnings (authored by mart).
fix some qml warnings
Mon, Jul 29, 12:31 PM
mart committed R120:dac4acd36a04: unconditionally call QQuickItem::geometryChanged (authored by mart).
unconditionally call QQuickItem::geometryChanged
Mon, Jul 29, 12:24 PM
mart committed R120:220edb3be524: unconditionally call QQuickItem::componentComplete (authored by mart).
unconditionally call QQuickItem::componentComplete
Mon, Jul 29, 12:19 PM

Thu, Jul 25

mart added a comment to D22083: introduce concept of header and footer for kpageview.

Looking into kcmultidialog, it seems there is some internal handling of margins in there, for a reason unknown to me. Maybe you want to investigate there too (in a different patch)

Hugo

Thu, Jul 25, 4:50 PM · Frameworks
mart committed R295:2583ee96e9d7: adapt to UI changes in KPageView (authored by mart).
adapt to UI changes in KPageView
Thu, Jul 25, 4:49 PM
mart committed R236:b581c5f990a6: introduce concept of header and footer for kpageview (authored by mart).
introduce concept of header and footer for kpageview
Thu, Jul 25, 4:29 PM
mart closed D22083: introduce concept of header and footer for kpageview.
Thu, Jul 25, 4:29 PM · Frameworks
mart accepted D22648: make handle follow arbitrary height of the drawer.
Thu, Jul 25, 11:36 AM · Kirigami

Jul 23 2019

mart committed R120:87f636006c9d: hide when not config required (authored by mart).
hide when not config required
Jul 23 2019, 10:14 AM
mart committed R120:31e5781532b8: support the configurationRequired button (authored by mart).
support the configurationRequired button
Jul 23 2019, 10:11 AM
mart committed R242:0e859870a9bc: Search for the plugin of the other plasmoid (authored by mart).
Search for the plugin of the other plasmoid
Jul 23 2019, 9:13 AM
mart closed D22675: Search for the plugin of the other plasmoid.
Jul 23 2019, 9:13 AM · Frameworks
mart requested review of D22675: Search for the plugin of the other plasmoid.
Jul 23 2019, 8:51 AM · Frameworks

Jul 22 2019

mart added inline comments to D22648: make handle follow arbitrary height of the drawer.
Jul 22 2019, 5:01 PM · Kirigami
mart accepted D22654: Fix typo.
Jul 22 2019, 5:00 PM · Kirigami
mart accepted D22564: [SwipeListItem] Take into account scrollbar visibility and form factor for handle and inline actions.
Jul 22 2019, 4:35 PM · Kirigami
mart committed R120:dbd2cd472153: Desktop scripting: support args (authored by mart).
Desktop scripting: support args
Jul 22 2019, 4:00 PM
mart closed D22652: Desktop scripting: support args.
Jul 22 2019, 4:00 PM · Plasma
mart requested review of D22652: Desktop scripting: support args.
Jul 22 2019, 3:47 PM · Plasma
mart accepted D22572: Remove scaling of iconsize unit for isMobile.
Jul 22 2019, 12:25 PM · Kirigami
mart committed R119:f3d914c0fafc: Port FolderView to ContainmentLayoutManager plugin (authored by mart).
Port FolderView to ContainmentLayoutManager plugin
Jul 22 2019, 8:44 AM
mart closed D22035: Port FolderView to ContainmentLayoutManager plugin.
Jul 22 2019, 8:44 AM · Plasma
mart committed R169:6f8346c546a2: always show back button on layers>1 (authored by mart).
always show back button on layers>1
Jul 22 2019, 8:29 AM
mart committed R120:f59aecbcfec6: Introduce ContainmentLayoutManager QML plugin (authored by mart).
Introduce ContainmentLayoutManager QML plugin
Jul 22 2019, 8:14 AM